[Libreoffice-bugs] [Bug 106221] Use of Javascript for writing Macros and Extensions not documented
https://bugs.documentfoundation.org/show_bug.cgi?id=106221 --- Comment #3 from Dan Dascalescu --- This is still an issue. A web search for "LibreOffice JavaScript macro reference" produces non-results, i.e. my own questions[1], and an acknowledgment from Olivier Hallot that the wiki does need to cover this. [1]: https://ask.libreoffice.org/en/question/98257/javascript-macro-reference/ [2]: https://listarchives.libreoffice.org/global/documentation/msg11912.html https://help.libreoffice.org/Common/Scripting mentions JavaScript without any additional details. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108653] The drawing toolbar is always lagging behind when opening draw document
https://bugs.documentfoundation.org/show_bug.cgi?id=108653 --- Comment #10 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106221] Use of Javascript for writing Macros and Extensions not documented
https://bugs.documentfoundation.org/show_bug.cgi?id=106221 --- Comment #2 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92666] Base Form/Database Closed When Report Window Closed If Database Browser Window .SetVisible(False)
https://bugs.documentfoundation.org/show_bug.cgi?id=92666 --- Comment #9 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108258] STATUSBAR: Word & character count incorrect after undo to empty document.
https://bugs.documentfoundation.org/show_bug.cgi?id=108258 --- Comment #4 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54585] UI_LANGS has no effect on update
https://bugs.documentfoundation.org/show_bug.cgi?id=54585 --- Comment #7 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112511] Text pasted as unformatted, gets the insertion point style for all paragraphs.
https://bugs.documentfoundation.org/show_bug.cgi?id=112511 --- Comment #5 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113124] Writer's PDF importer doesnt import font name
https://bugs.documentfoundation.org/show_bug.cgi?id=113124 --- Comment #2 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101198] Inserted OLE Appearance Wrongly Based on Window Dimensions + Zoom and Scroll Positions
https://bugs.documentfoundation.org/show_bug.cgi?id=101198 --- Comment #7 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 64499] Goalseek does not get answer although Excel has no problem on same sheet saved in xls format
https://bugs.documentfoundation.org/show_bug.cgi?id=64499 --- Comment #32 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120636] windows 7 x64 crashes with writer document
https://bugs.documentfoundation.org/show_bug.cgi?id=120636 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from V Stuart Foote --- A bit thin on details. Please identify your hardware configuration (including driver details), and provide better STR as to 'exactly' what you are doing when you have your crash. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119095] Windows 10 native emoji picker doesn’t insert any character in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=119095 V Stuart Foote changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #9 from V Stuart Foote --- On Windows 10 Home 64-bit en-US (1803) with Version: 6.2.0.0.alpha0+ (x64) Build ID: b63d48a146c3615f56b6ec83361b3c02ebcbb215 CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-10-14_01:02:47 Locale: en-US (en_US); Calc: threaded As Mike notes, the + . opens the DE Emoji dialog. Emoji's are inserted to document canvas. As also noted bug 104403 and bug 105488 address lack of color font support needed to render color Emoji. So => WFM -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120612] [LOCALHELP] Edit DDE link has no Help page or ID
https://bugs.documentfoundation.org/show_bug.cgi?id=120612 --- Comment #2 from Olivier Hallot --- The help page already exist for the dialog, but it is not reachable. https://help.libreoffice.org/6.1/en-US/text/shared/01/02180100.html -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119095] Windows 10 native emoji picker doesn’t insert any character in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=119095 --- Comment #8 from Leandro Martín Drudi --- [ES] Con el reporte 120556 descubrí que el problema de que inserte espacios en blanco era por problemas con las fuentes instaladas por mi cuenta. [EN] With report 120556 I discovered that the problem of inserting blank spaces was due to problems with the sources installed on my own. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120556] Password protected sheets in Calc cause crashes annd the same when uses autocorrection (eg. :?:)
https://bugs.documentfoundation.org/show_bug.cgi?id=120556 --- Comment #11 from Leandro Martín Drudi --- [ES] Aún no logro entender el por qué, pero en un grupo de Telegram de LibreOffice en español me sugirieron desinstalar unas fuentes instaladas por mí. Al hacerlo, todo funcionoó perfectamente. Instalé nuevamente una por una para detectar la/s que causaba/n el conflicto y encontré que: - Helvetica LT Std (en formato OTF) - Helvetica Neue (en formato TTS) y otro grupo de fuentes independientes (de webs de descarga gratuita), generaban todo el problema expuesto respecto del cierre y todo lo demás. Dejo abierto el reporte por si hay algo por añadir por parte de los expertos o si esto pueden resolverlo para que no genere problemas en otros usuarios. [EN] I still can not understand why, but in a Telegram group of LibreOffice in Spanish some users suggested me to uninstall some typographies installed by me. In doing so, everything worked perfectly. I installed again one by one to detect the Font who caused the conflict and found that: - Helvetica LT Std (in OTF format) - Helvetica Neue (in TTS format) and another group of independent sources (from free download websites), generated all the problems related to the closure and everything else. I leave the report open in case there is something to be added by the experts or if this can be solved so that it does not generate problems in other users. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/print_revamp' - 888 commits - accessibility/source android/source avmedia/source basctl/inc basctl/source basctl/uiconfig basegfx/source basegfx/test ba
Rebased ref, commits from common ancestor: commit b121f5688ad347401893a3fd2e52d26dbb51bae2 Author: Daniel AuthorDate: Tue Jul 31 09:49:07 2018 -0300 Commit: Daniel Silva CommitDate: Mon Oct 15 16:54:51 2018 -0300 Print dialog UI adjustments Change-Id: Iecf66e31b66d65b9077da4870385ef8f9012f043 Reviewed-on: https://gerrit.libreoffice.org/58361 Tested-by: Jenkins Reviewed-by: Katarina Behrens diff --git a/sd/uiconfig/simpress/ui/impressprinteroptions.ui b/sd/uiconfig/simpress/ui/impressprinteroptions.ui index e09238699de7..44ea2df97feb 100644 --- a/sd/uiconfig/simpress/ui/impressprinteroptions.ui +++ b/sd/uiconfig/simpress/ui/impressprinteroptions.ui @@ -21,115 +21,83 @@ False 6 12 +7 - + True False -vertical -3 +5 +6 - + True False -6 - - -True -False -Type: - - -False -True -0 - - - - -True -False - - -False -True -1 - - +start +Type: +True +impressdocument -False -True -0 +0 +0 - + True False -6 - - -True -False -Slides per page: - - -False -True -0 - - - - -True -False - - -False -True -1 - - +start +Slides per page: +True +slidesperpage -False -True -1 +0 +1 - + True False -6 - - -True -False -Order: - - -False -True -0 - - - - -True -False - - -False -True -1 - - +start +Order: +True +slidesperpageorder -False -True -2 +0 +2 + + + + +True +False + + +1 +0 + + + + +True +False + + +1 +1 + + + + +True +False + + +1 +2 diff --git a/sw/uiconfig/swriter/ui/printeroptions.ui b/sw/uiconfig/swriter/ui/printeroptions.ui index 88bb58a22eb4..6b6fcc4cb586 100644 ---
[Libreoffice-bugs] [Bug 120637] New: windows 7 x64 crashes with writer document
https://bugs.documentfoundation.org/show_bug.cgi?id=120637 Bug ID: 120637 Summary: windows 7 x64 crashes with writer document Product: LibreOffice Version: 6.1.2.1 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mike...@yahoo.com Windows 7 crashes often with more than one writer document open or other programs launched. Please check. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120636] New: windows 7 x64 crashes with writer document
https://bugs.documentfoundation.org/show_bug.cgi?id=120636 Bug ID: 120636 Summary: windows 7 x64 crashes with writer document Product: LibreOffice Version: 6.1.2.1 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mike...@yahoo.com Windows 7 crashes often with more than one writer document open or other programs launched. Please check. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Mobile/Mobile
Mobile/Mobile/AppDelegate.mm| 15 ---
Mobile/Mobile/DocumentViewController.mm |5 +++--
2 files changed, 11 insertions(+), 9 deletions(-)
New commits:
commit c701e875f6118d24ff0b9a7c3823f8f6c9570db0
Author: Tor Lillqvist
AuthorDate: Tue Oct 16 00:01:04 2018 +0300
Commit: Tor Lillqvist
CommitDate: Tue Oct 16 02:00:47 2018 +0300
iOS app work in progress on closing and re-opening a document
diff --git a/Mobile/Mobile/AppDelegate.mm b/Mobile/Mobile/AppDelegate.mm
index 6fbd25d75..eab0054f6 100644
--- a/Mobile/Mobile/AppDelegate.mm
+++ b/Mobile/Mobile/AppDelegate.mm
@@ -40,16 +40,17 @@ static LOOLWSD *loolwsd = nullptr;
dispatch_async(dispatch_get_global_queue( DISPATCH_QUEUE_PRIORITY_DEFAULT,
0),
^{
- if (loolwsd == nullptr)
- {
- loolwsd = new LOOLWSD();
- Util::setThreadName("app");
- }
+ assert(loolwsd == nullptr);
char *argv[2];
argv[0] = strdup([[NSBundle mainBundle].executablePath
UTF8String]);
argv[1] = nullptr;
- loolwsd->run(1, argv);
- assert(false && "? LOOLWSD::main() returned?");
+ Util::setThreadName("app");
+ while (true) {
+ loolwsd = new LOOLWSD();
+ loolwsd->run(1, argv);
+ delete loolwsd;
+ NSLog(@"One run of LOOLWSD completed");
+ }
});
return YES;
}
diff --git a/Mobile/Mobile/DocumentViewController.mm
b/Mobile/Mobile/DocumentViewController.mm
index fc7f2deee..3d5e92c99 100644
--- a/Mobile/Mobile/DocumentViewController.mm
+++ b/Mobile/Mobile/DocumentViewController.mm
@@ -177,7 +177,7 @@
// the other end too just for
cleanliness, even if a
// FakeSocket as such is not a
system resource so nothing
// is saved by closing it.
-
fakeSocketClose(self->closeNotificationPipeForForwardingThread[0]);
+
fakeSocketClose(self->closeNotificationPipeForForwardingThread[1]);
// Close our end of the fake socket
connection to the
// ClientSession thread, so that it
terminates
@@ -210,11 +210,12 @@
return;
} else if ([message.body isEqualToString:@"BYE"]) {
-NSLog(@"document window closed! Closing our end of the socket?");
+NSLog(@"document window terminating on JavaScript side. Closing
our end of the socket.");
// Close one end of the socket pair, that will wake up the
forwarding thread above
fakeSocketClose(closeNotificationPipeForForwardingThread[0]);
+[self dismissDocumentViewController];
return;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: wsd/LOOLWSD.cpp
wsd/LOOLWSD.cpp | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
New commits:
commit 859d799f5c70c55584b04ff322b6f68907780d35
Author: Tor Lillqvist
AuthorDate: Mon Oct 15 23:56:04 2018 +0300
Commit: Tor Lillqvist
CommitDate: Tue Oct 16 01:49:46 2018 +0300
Do run some cleanups on return from LOOLWSD::innerMain() in the mobile app
case
Also, re-initialise the lovely TerminationFlag to false in
LOOLWSD::main().
Change-Id: I8f53e8c809583f931435e6f80324d4438cca4b2a
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 1b5dd8917..e7d99b5ca 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -3010,9 +3010,6 @@ int LOOLWSD::innerMain()
}
LOG_TRC("Loop finished. TerminationFlag=" << TerminationFlag);
-// No point in doing any orderly shutdown on mobile, we will never exit
intentionally, the OS will
-// kill us.
-#ifndef MOBILEAPP
// Stop the listening to new connections
// and wait until sockets close.
LOG_INF("Stopping server socket listening. ShutdownRequestFlag: " <<
@@ -3053,7 +3050,7 @@ int LOOLWSD::innerMain()
DocBrokers.clear();
-#ifndef KIT_IN_PROCESS
+#if !defined(KIT_IN_PROCESS) && !defined(MOBILEAPP)
// Terminate child processes
LOG_INF("Requesting forkit process " << ForKitProcId << " to terminate.");
SigUtil::killChild(ForKitProcId);
@@ -3068,6 +3065,7 @@ int LOOLWSD::innerMain()
child->terminate();
}
+#ifndef MOBILEAPP
#ifndef KIT_IN_PROCESS
// Wait for forkit process finish.
LOG_INF("Waiting for forkit process to exit");
@@ -3111,6 +3109,10 @@ void LOOLWSD::cleanup()
int LOOLWSD::main(const std::vector& /*args*/)
{
+#ifdef MOBILEAPP
+TerminationFlag = false;
+#endif
+
int returnValue;
try {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 97629] [META] Help Content Modernization
https://bugs.documentfoundation.org/show_bug.cgi?id=97629 V Stuart Foote changed: What|Removed |Added Depends on||120538 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=120538 [Bug 120538] Extended help does not work anymore -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120538] Extended help does not work anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=120538 V Stuart Foote changed: What|Removed |Added Blocks||97629 CC||vstuart.fo...@utsa.edu Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=97629 [Bug 97629] [META] Help Content Modernization -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120538] Extended help does not work anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=120538 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||0570 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120570] “Description” of Commands is not Available in Customize Dialogue
https://bugs.documentfoundation.org/show_bug.cgi?id=120570 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||0538 CC||vstuart.fo...@utsa.edu -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: 2 commits - wsd/LOOLWSD.cpp
wsd/LOOLWSD.cpp |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
New commits:
commit 25e3092a48ae21de508668b1312ca5f3eb2f961f
Author: Tor Lillqvist
AuthorDate: Tue Oct 16 01:36:55 2018 +0300
Commit: Tor Lillqvist
CommitDate: Tue Oct 16 01:40:52 2018 +0300
Bin pointless #ifdef MOBILEAPP block
BUILDING_TESTS is not true for the mobile app either.
Change-Id: I54de357c25b7349aaa9c06f054cd8fbfddfb7a37
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index d5cf6cddc..1b5dd8917 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -2822,7 +2822,6 @@ private:
std::shared_ptr socket = getServerSocket(
ClientListenAddr, port, WebServerPoll, factory);
-#ifdef MOBILEAPP
#ifdef BUILDING_TESTS
while (!socket)
{
@@ -2832,7 +2831,6 @@ private:
ServerSocket::Type::Public, port, WebServerPoll, factory);
}
#endif
-#endif
if (!socket)
{
LOG_FTL("Failed to listen on Server port(s) (" <<
commit 8f86e63563d9356c395e25619d937c7f38102d05
Author: Tor Lillqvist
AuthorDate: Mon Oct 15 23:49:48 2018 +0300
Commit: Tor Lillqvist
CommitDate: Tue Oct 16 01:36:01 2018 +0300
Call fakeSocketDumpState() when LOOLWSD::main() is about to return
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 1468d28c1..d5cf6cddc 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -3130,6 +3130,11 @@ int LOOLWSD::main(const std::vector&
/*args*/)
UnitWSD::get().returnValue(returnValue);
LOG_INF("Process [loolwsd] finished.");
+
+#ifdef MOBILEAPP
+fakeSocketDumpState();
+#endif
+
return returnValue;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120618] Horizontal alignment doesn't work on custom page dimensions
https://bugs.documentfoundation.org/show_bug.cgi?id=120618 V Stuart Foote changed: What|Removed |Added Attachment #145748|tdf120168_pageDimension_ali |tdf120618_pageDimension_ali filename|gnment_glitch_620.fodt |gnment_glitch_620.fodt -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119801] AutoCorrect options takes 5 minutes to open
https://bugs.documentfoundation.org/show_bug.cgi?id=119801 --- Comment #7 from zak --- cpu: Intel(R) Core(TM) i5-6260U CPU @ 1.80GHz, 2766 MHz Intel(R) Core(TM) i5-6260U CPU @ 1.80GHz, 2785 MHz Intel(R) Core(TM) i5-6260U CPU @ 1.80GHz, 2771 MHz Intel(R) Core(TM) i5-6260U CPU @ 1.80GHz, 2766 MHz graphics card: Intel Iris Graphics 540 storage: Samsung Electronics NVMe SSD Controller SM951/PM951 network: wlp1s0 Intel Wireless 8260 eno1 Intel Ethernet Connection I219-V disk: /dev/nvme0n1 Samsung Electronics NVMe SSD Controller SM951/PM951 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120570] “Description” of Commands is not Available in Customize Dialogue
https://bugs.documentfoundation.org/show_bug.cgi?id=120570 --- Comment #3 from Regina Henschel --- What you call 'Description" of Commands' is the same text as the extended tips and has the same origin. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82117] Improve shortcut key list for German keyboard layout
https://bugs.documentfoundation.org/show_bug.cgi?id=82117 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #17 from Regina Henschel --- I suggest to extend the solution which was made for other languages in bug 88027 to German. See https://gerrit.libreoffice.org/#/c/22792/. That would be an easy hack. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120633] Date Field in Base
https://bugs.documentfoundation.org/show_bug.cgi?id=120633 --- Comment #3 from Drew Jensen --- I'm using Ubuntu 18.04, not windows, and LibreOffice 6.1.2 and 5.4.7 Date fields default to a format of MM/DD/YY but I can change that to DD/MM/. This change in format however only effects the display of the date. When entering a date I still must enter MM/DD/ (02/29/1972) for it to be accepted and immediately changed for display to 29/02/1972 otherwise it changes to 30/12/1899. By chance have you tried entering 02/29/1972 and see if that is accepted with 6.1.2 under windows? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: kit/Kit.cpp
kit/Kit.cpp |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit ef3e09728fabcf5165c1f2afe85aa40f5709e17c
Author: Tor Lillqvist
AuthorDate: Mon Oct 15 18:59:51 2018 +0300
Commit: Tor Lillqvist
CommitDate: Tue Oct 16 01:03:47 2018 +0300
Revert "Drop one use of TerminationFlag"
Turns out not to be useful for the iOS app after all.
This reverts commit bff5c176937543540c521882994900339a4191e7.
Change-Id: I93367e9de1b6e66b1cbb7587259f1136564e53a4
diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index c22fae469..d609fcb28 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -2433,12 +2433,12 @@ void lokit_main(
if (document && document->purgeSessions() == 0)
{
-LOG_INF("Last session discarded. Breaking out of loop");
-break;
+LOG_INF("Last session discarded. Setting TerminationFlag");
+TerminationFlag = true;
}
}
-LOG_INF("Kit poll finished.");
+LOG_INF("Kit poll terminated.");
// Let forkit handle the jail cleanup.
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: net/FakeSocket.cpp net/FakeSocket.hpp
net/FakeSocket.cpp | 33 +
net/FakeSocket.hpp |2 ++
2 files changed, 35 insertions(+)
New commits:
commit cab2f9b6bb1d1bcc5644c61b88c6a1fff85d71bb
Author: Tor Lillqvist
AuthorDate: Mon Oct 15 22:41:38 2018 +0300
Commit: Tor Lillqvist
CommitDate: Tue Oct 16 01:11:20 2018 +0300
Add fakeSocketDumpState()
diff --git a/net/FakeSocket.cpp b/net/FakeSocket.cpp
index 95dc4ef8f..580fd2af3 100644
--- a/net/FakeSocket.cpp
+++ b/net/FakeSocket.cpp
@@ -653,4 +653,37 @@ int fakeSocketClose(int fd)
return 0;
}
+void fakeSocketDumpState()
+{
+std::vector& fds = getFds();
+std::unique_lock lock(theMutex);
+
+loggingBuffer << "FakeSocket open sockets:";
+for (int i = 0; i < fds.size(); i++)
+{
+if (fds[i].fd[0] != -1)
+{
+assert(fds[i].fd[0] == i*2);
+loggingBuffer << "\n #" << fds[i].fd[0];
+if (fds[i].fd[1] != -1)
+{
+assert(fds[i].fd[1] == i*2+1);
+assert(!fds[i].listening);
+loggingBuffer << " <=> #" << fds[i].fd[1];
+}
+else if (fds[i].listening)
+{
+loggingBuffer << " listening";
+}
+}
+else if (fds[i].fd[1] != -1)
+{
+assert(fds[i].fd[1] == i*2+1);
+assert(!fds[i].listening);
+loggingBuffer << "\n #" << fds[i].fd[1];
+}
+}
+loggingBuffer << flush();
+}
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/net/FakeSocket.hpp b/net/FakeSocket.hpp
index bf9e94d61..c29195ddb 100644
--- a/net/FakeSocket.hpp
+++ b/net/FakeSocket.hpp
@@ -44,6 +44,8 @@ int fakeSocketShutdown(int fd);
int fakeSocketClose(int fd);
+void fakeSocketDumpState();
+
#endif // MOBILEAPP
#endif // INCLUDED_FAKESOCKET_H
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: wsd/LOOLWSD.cpp
wsd/LOOLWSD.cpp |1 +
1 file changed, 1 insertion(+)
New commits:
commit 843e74e533d9e161a9b7a92680103a25ac41447c
Author: Tor Lillqvist
AuthorDate: Mon Oct 15 18:51:56 2018 +0300
Commit: Tor Lillqvist
CommitDate: Tue Oct 16 01:02:00 2018 +0300
Log what TerminationFlag is after the loop in innerMain()
Change-Id: Ib53dc7d760a89a72b47f575ba2787d08cdcd29ec
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 8d2544e3d..1468d28c1 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -3010,6 +3010,7 @@ int LOOLWSD::innerMain()
#endif
#endif
}
+LOG_TRC("Loop finished. TerminationFlag=" << TerminationFlag);
// No point in doing any orderly shutdown on mobile, we will never exit
intentionally, the OS will
// kill us.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: 2 commits - wsd/LOOLWSD.cpp wsd/LOOLWSD.hpp
wsd/LOOLWSD.cpp | 15 +--
wsd/LOOLWSD.hpp |5 -
2 files changed, 1 insertion(+), 19 deletions(-)
New commits:
commit a6e0d407d57a5c6921faee228d0eabfd4fb0a194
Author: Tor Lillqvist
AuthorDate: Tue Oct 16 00:46:47 2018 +0300
Commit: Tor Lillqvist
CommitDate: Tue Oct 16 00:46:47 2018 +0300
Bin unused function handleShutdownRequest()
Change-Id: I1be1fdba9623e7d2c5ee0a43c976a5d3ccf9fd28
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index e1fd5b3d0..8d2544e3d 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -2848,18 +2848,6 @@ private:
static LOOLWSDServer srv;
-bool LOOLWSD::handleShutdownRequest()
-{
-if (ShutdownRequestFlag)
-{
-LOG_INF("Shutdown requested. Initiating WSD shutdown.");
-Util::alertAllUsers("close: shuttingdown");
-return true;
-}
-
-return false;
-}
-
int LOOLWSD::innerMain()
{
#if !defined FUZZER && !defined MOBILEAPP
diff --git a/wsd/LOOLWSD.hpp b/wsd/LOOLWSD.hpp
index f2c0980f0..92b645e83 100644
--- a/wsd/LOOLWSD.hpp
+++ b/wsd/LOOLWSD.hpp
@@ -75,8 +75,6 @@ public:
static std::vector getKitPids();
-bool handleShutdownRequest();
-
static std::string GenSessionId()
{
return Util::encodeId(++NextSessionId, 4);
commit c2b8b1c0904c7ff0f31315ebe1039081fce6156d
Author: Tor Lillqvist
AuthorDate: Tue Oct 16 00:39:21 2018 +0300
Commit: Tor Lillqvist
CommitDate: Tue Oct 16 00:40:35 2018 +0300
Bin unused variable ShutdownFlag
Change-Id: I19c91cbf82beda4498b37d29fbca3c603974f46a
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index fa7d16eac..e1fd5b3d0 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -2854,7 +2854,6 @@ bool LOOLWSD::handleShutdownRequest()
{
LOG_INF("Shutdown requested. Initiating WSD shutdown.");
Util::alertAllUsers("close: shuttingdown");
-ShutdownFlag = true;
return true;
}
@@ -3029,7 +3028,7 @@ int LOOLWSD::innerMain()
#ifndef MOBILEAPP
// Stop the listening to new connections
// and wait until sockets close.
-LOG_INF("Stopping server socket listening. ShutdownFlag: " <<
+LOG_INF("Stopping server socket listening. ShutdownRequestFlag: " <<
ShutdownRequestFlag << ", TerminationFlag: " << TerminationFlag);
// Wait until documents are saved and sessions closed.
diff --git a/wsd/LOOLWSD.hpp b/wsd/LOOLWSD.hpp
index 7eb7c6597..f2c0980f0 100644
--- a/wsd/LOOLWSD.hpp
+++ b/wsd/LOOLWSD.hpp
@@ -75,9 +75,6 @@ public:
static std::vector getKitPids();
-/// Flag to shutdown the server.
-std::atomic ShutdownFlag;
-
bool handleShutdownRequest();
static std::string GenSessionId()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120618] Horizontal alignment doesn't work on custom page dimensions
https://bugs.documentfoundation.org/show_bug.cgi?id=120618 --- Comment #2 from V Stuart Foote --- Created attachment 145748 --> https://bugs.documentfoundation.org/attachment.cgi?id=145748=edit page size at 72.21cm showing right align para at left reduce the page size by .01cm and the right align para moves to correct position -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120618] Horizontal alignment doesn't work on custom page dimensions
https://bugs.documentfoundation.org/show_bug.cgi?id=120618 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from V Stuart Foote --- Confirmed on Windows 10 Ent 64-bit en-US with Version: 6.2.0.0.alpha0+ (x64) Build ID: 5f5d890c242b8a092804991dba809f6f4287cfb2 CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-10-03_23:04:03 Locale: en-US (en_US); Calc: CL Here the toggle was at 72.20cm -> 72.21cm, with a height of 27.94cm Paragraph formatted to align Right would still show the direct formatting--but would jump to left margin when rendered to canvas when page size crosses the threshold. Document (.fodt attached) saved from master/6.2.0 continues the misalignment when opened with 6.1.1.2 Weird! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120570] “Description” of Commands is not Available in Customize Dialogue
https://bugs.documentfoundation.org/show_bug.cgi?id=120570 Harald Koester changed: What|Removed |Added Summary|[NEWHELP] “Description” |“Description” of Commands |(extended tip) is not |is not Available in |available with the new |Customize Dialogue |local help in HTML format | --- Comment #2 from Harald Koester --- (In reply to Regina Henschel from comment #1) > Extended tips are not only missing in the customize dialog but in general. > Use tool "What's this?" from the help menu and hover over some icons. You > should see a more detailed description instead of the simple term. > > I change the summary accordingly. I think there is a misunderstanding. My initial report has nothing to do with the kind of tips. I missed the explanations of each command in the box called Description and not a tip which is diplayed if you move the mouse pointer above an item of the UI. So I changed the summary back to the original summary. You are right, extended tips are not available with versions 6.1.x at all. I think this is a even severe bug in comparison to the bug I described here. So I think it should be addressed in another bug report. I'm not really sure, but I think it has been already described in bug 120538. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120619] Uninstaller does not delete all folders and blocks one
https://bugs.documentfoundation.org/show_bug.cgi?id=120619 --- Comment #7 from Leandro Martín Drudi --- Created attachment 145747 --> https://bugs.documentfoundation.org/attachment.cgi?id=145747=edit Locked file. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115182] FILEOPEN XLSX Pie chart default percentage format does not match Excels
https://bugs.documentfoundation.org/show_bug.cgi?id=115182 Aron Budea changed: What|Removed |Added CC||er...@redhat.com Keywords||bibisected, bisected, ||regression --- Comment #4 from Aron Budea --- This seems to be a regression, which started from the commit referenced below (bibisected using repo bibisect-win32-5.1). I can't establish if this is indeed a regression, or if it had worked fine by accident before the patch, Eike, could you please share your thoughts? https://cgit.freedesktop.org/libreoffice/core/commit/?id=0f4b3cb7d3d68906de316a64dcec281da2a641bd author Eike Rathke 2015-08-10 17:04:13 +0200 committer Eike Rathke 2015-08-10 17:12:45 +0200 if we have a number formatter then use it, dammit.. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70180] Enhance Drop Caps effect to support Raised, Sunken and Dropped initials
https://bugs.documentfoundation.org/show_bug.cgi?id=70180 V Stuart Foote changed: What|Removed |Added CC||st...@edmondsfamily.co.nz --- Comment #15 from V Stuart Foote --- *** Bug 120635 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120635] Drop caps - enable a value of 1 for lines
https://bugs.documentfoundation.org/show_bug.cgi?id=120635 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #1 from V Stuart Foote --- *** This bug has been marked as a duplicate of bug 70180 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: wsd/LOOLWSD.hpp
wsd/LOOLWSD.hpp |5 -
1 file changed, 5 deletions(-)
New commits:
commit 405982716ed0d892f24a0c8a28a4eea4151ff188
Author: Tor Lillqvist
AuthorDate: Mon Oct 15 17:58:41 2018 +0300
Commit: Tor Lillqvist
CommitDate: Tue Oct 16 00:37:42 2018 +0300
Bin unused function
diff --git a/wsd/LOOLWSD.hpp b/wsd/LOOLWSD.hpp
index 369b8ab33..7eb7c6597 100644
--- a/wsd/LOOLWSD.hpp
+++ b/wsd/LOOLWSD.hpp
@@ -78,11 +78,6 @@ public:
/// Flag to shutdown the server.
std::atomic ShutdownFlag;
-bool isShuttingDown()
-{
-return ShutdownFlag;
-}
-
bool handleShutdownRequest();
static std::string GenSessionId()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: wsd/SenderQueue.hpp
wsd/SenderQueue.hpp | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
New commits:
commit 1ce8c940228fa55738ff6e761018f18be3e23c7b
Author: Tor Lillqvist
AuthorDate: Mon Oct 15 17:37:21 2018 +0300
Commit: Tor Lillqvist
CommitDate: Tue Oct 16 00:22:35 2018 +0300
Don't hide check for TerminationFlag behind a pointless local abstraction
layer
It is useful to find all uses of TerminationFlag directly with git
grep without having to look through abstractions.
Change-Id: I8bc999bd36d06c805c2a6331dba739b41239ddec
diff --git a/wsd/SenderQueue.hpp b/wsd/SenderQueue.hpp
index fc3464b3f..251be7df3 100644
--- a/wsd/SenderQueue.hpp
+++ b/wsd/SenderQueue.hpp
@@ -36,13 +36,11 @@ public:
{
}
-bool stopping() const { return TerminationFlag; }
-
size_t enqueue(const Item& item)
{
std::unique_lock lock(_mutex);
-if (!stopping() && deduplicate(item))
+if (!TerminationFlag && deduplicate(item))
_queue.push_back(item);
return _queue.size();
@@ -53,7 +51,7 @@ public:
{
std::unique_lock lock(_mutex);
-if (!_queue.empty() && !stopping())
+if (!_queue.empty() && !TerminationFlag)
{
item = _queue.front();
_queue.pop_front();
@@ -61,8 +59,8 @@ public:
}
else
{
-if (stopping())
-LOG_DBG("SenderQueue: stopping");
+if (TerminationFlag)
+LOG_DBG("SenderQueue: TerminationFlag is set");
return false;
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120610] Unamed dialog in Edit-Links for DDE links
https://bugs.documentfoundation.org/show_bug.cgi?id=120610 Olivier Hallot changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |olivier.hallot@documentfoun |desktop.org |dation.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: kit/Kit.cpp
kit/Kit.cpp |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit c05079d6d5d6f253e9aeaf3560574f50979bc85e
Author: Tor Lillqvist
AuthorDate: Mon Oct 15 16:41:52 2018 +0300
Commit: Tor Lillqvist
CommitDate: Tue Oct 16 00:08:44 2018 +0300
Mention TerminationFlag in a couple more log lines
Why log something vague like "Stop flagged" when we can log what we
actually do?
Also, the log lines already include the name of the thread, so no need
to prefix with "Kit:".
Change-Id: I5a05492aa4e8a26714889cc6341a26862c80e4d0
diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 2c99d962c..c22fae469 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -1851,7 +1851,7 @@ private:
if (_stop || TerminationFlag)
{
-LOG_INF("Kit: Stop flagged.");
+LOG_INF("_stop or TerminationFlag is set, breaking out of
loop");
break;
}
@@ -2066,7 +2066,7 @@ protected:
// Note: Syntax or parsing errors here are unexpected and fatal.
if (TerminationFlag)
{
-LOG_DBG("Too late, we're going down");
+LOG_DBG("Too late, TerminationFlag is set, we're going down");
}
else if (tokens[0] == "session")
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120594] Crash attempting to open More Fields dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=120594 --- Comment #9 from vic...@victorjohnson.net --- Oliver, I have no problems with formating any cells in Calc. All works perfectly. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115182] FILEOPEN XLSX Pie chart default percentage format does not match Excels
https://bugs.documentfoundation.org/show_bug.cgi?id=115182
--- Comment #3 from Andras Timar ---
A related commit:
commit d22a4d945ccf1456fbdb2c39802d956afa583a2a
Author: Matúš Kukan
Date: Thu Sep 11 08:56:22 2014 +0200
bnc#892610: OOXML import: Improve chart number formats.
If sourceLinked is used, do not set "PercentageNumberFormat" even if
showPercent is true. The format string should be used for "NumberFormat".
c8cc89ff802d86b1f3a69afe1b4835b7df7f70c7 unnecessarily disabled
"LinkNumberFormatToSource". Use that for data labels but not for axis.
Also, actually make attaching number format supplier work for Calc.
Previously, non standard formats were added into wrong supplier,
and they were thrown away later because it was attached too late.
(See also ChartModel::attachNumberFormatsSupplier)
Change-Id: Iaf9945abc3d82d0ac63d9f36beb49f39ab57
It seems this logic is wrong.
diff --git a/oox/source/drawingml/chart/objectformatter.cxx
b/oox/source/drawingml/chart/objectformatter.cxx
index 8d49c0d01fef..a90ca8f49f33 100644
--- a/oox/source/drawingml/chart/objectformatter.cxx
+++ b/oox/source/drawingml/chart/objectformatter.cxx
@@ -1080,7 +1080,7 @@ void ObjectFormatter::convertNumberFormat( PropertySet&
rPropSet, const NumberFo
if( mxData->mxNumFmts.is() )
{
const bool bGeneral =
rNumberFormat.maFormatCode.equalsIgnoreAsciiCase("general");
-const bool bPercent = !bAxis && bShowPercent &&
!rNumberFormat.mbSourceLinked;
+const bool bPercent = !bAxis && bShowPercent;
sal_Int32 nPropId = bPercent ? PROP_PercentageNumberFormat :
PROP_NumberFormat;
OUString sFormatCode(rNumberFormat.maFormatCode);
if (bPercent && bGeneral)
After this, percent values are shown as expected, but it breaks a unit test
(and indeed, import of chart2/qa/extras/data/xlsx/number-formats.xlsx becomes
wrong).
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120633] Date Field in Base
https://bugs.documentfoundation.org/show_bug.cgi?id=120633 --- Comment #2 from m.a.riosv --- Sorry forgot my comment I was testing on calc. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120633] Date Field in Base
https://bugs.documentfoundation.org/show_bug.cgi?id=120633 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- For me 29/02/1971 is introduced as text in the cell because it is not a valid date, 1971 it is not a leap year. Only for leap years it's introduce as a true date in the cell. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120634] Unexpected change of table content paragraph style when deleting a row
https://bugs.documentfoundation.org/show_bug.cgi?id=120634 --- Comment #1 from Ulrich Gemkow --- Current git master shows the same behavior. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120627] Unexpected change of style of table content when copying table
https://bugs.documentfoundation.org/show_bug.cgi?id=120627 --- Comment #1 from Ulrich Gemkow --- Current git master shows the same behavior. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 2 commits - sw/source writerfilter/source
sw/source/filter/ww8/wrtw8nds.cxx | 12 +---
writerfilter/source/dmapper/DomainMapper_Impl.cxx | 15 +++
2 files changed, 24 insertions(+), 3 deletions(-)
New commits:
commit ff2067b3d5149c35de17bf1939a34849ae6608aa
Author: Justin Luth
AuthorDate: Wed Oct 10 12:01:04 2018 +0300
Commit: Andras Timar
CommitDate: Sat Oct 13 20:44:09 2018 +0200
tdf120224 docx export: don't double up field bookmarks
fields are internal bookmarks. When the exporter runs
through the bookmarks, it will already write out a bookmark
entry, so don't output a separate one for the fieldmark.
Change-Id: I84af2989035507ac745d028f1585d60d8823ff8b
Reviewed-on: https://gerrit.libreoffice.org/61616
Tested-by: Jenkins
Reviewed-by: Justin Luth
(cherry picked from commit 0a452b5005744d96f37fcb29b37a84e23a04bf8e)
diff --git a/sw/source/filter/ww8/wrtw8nds.cxx
b/sw/source/filter/ww8/wrtw8nds.cxx
index 20a43e27cd30..9361943a7636 100644
--- a/sw/source/filter/ww8/wrtw8nds.cxx
+++ b/sw/source/filter/ww8/wrtw8nds.cxx
@@ -2406,8 +2406,11 @@ void MSWordExportBase::OutputTextNode( SwTextNode& rNode
)
::sw::mark::IFieldmark const * const pFieldmark =
pMarkAccess->getFieldmarkFor( aPosition );
OSL_ENSURE( pFieldmark, "Looks like this doc is broken...;
where is the Fieldmark for the FIELDSTART??" );
-if ( pFieldmark && pFieldmark->GetFieldname() ==
ODF_FORMTEXT )
-AppendBookmark( pFieldmark->GetName() );
+if ( pFieldmark && pFieldmark->GetFieldname() ==
ODF_FORMTEXT
+ && GetExportFormat() !=
MSWordExportBase::ExportFormat::DOCX )
+{
+ AppendBookmark( pFieldmark->GetName() );
+}
ww::eField eFieldId = lcl_getFieldId( pFieldmark );
OUString sCode = lcl_getFieldCode( pFieldmark );
if ( pFieldmark && pFieldmark->GetFieldname() ==
ODF_UNHANDLED )
@@ -2470,8 +2473,11 @@ void MSWordExportBase::OutputTextNode( SwTextNode& rNode
)
OutputField( nullptr, eFieldId, OUString(),
FieldFlags::Close );
-if ( pFieldmark && pFieldmark->GetFieldname() ==
ODF_FORMTEXT )
+if ( pFieldmark && pFieldmark->GetFieldname() ==
ODF_FORMTEXT
+ && GetExportFormat() !=
MSWordExportBase::ExportFormat::DOCX )
+{
AppendBookmark( pFieldmark->GetName() );
+}
}
else if ( ch == CH_TXT_ATR_FORMELEMENT )
{
commit 55728c04006b791a5380e9a4145c593287ec33ca
Author: Justin Luth
AuthorDate: Tue Oct 9 14:03:37 2018 +0300
Commit: Andras Timar
CommitDate: Sat Oct 13 20:43:47 2018 +0200
tdf120224 writerfilter: consume excess bookmark from fields
Although this follows a very different code path, copy the ww8
import idea of "consuming" the bookmark of a BOOK_FIELD.
This is particularly important for textcontrols, especially
since LO keeps duplicating bookmarks as it adds another
bookmark for the field name at each save.
Existing unit tests that this matches are fdo53985.docx and
tdf111964.docx. I expected more, but apparently most fields
don't contain or represent any bookmarks.
This patch is for import only. A followup patch stops
the creation of duplicate bookmarks during export.
Reviewed-on: https://gerrit.libreoffice.org/61615
Tested-by: Jenkins
Reviewed-by: Justin Luth
(cherry picked from commit 579c0749bef8c980507229439715e72060c1b077)
Change-Id: I1e11980e52dc523393fd6d621191228d676e9a17
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index f65d2166cc01..1ea53b810609 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -4827,7 +4827,22 @@ void DomainMapper_Impl::SetBookmarkName( const OUString&
rBookmarkName )
{
BookmarkMap_t::iterator aBookmarkIter = m_aBookmarkMap.find(
m_sCurrentBkmkId );
if( aBookmarkIter != m_aBookmarkMap.end() )
+{
+// fields are internal bookmarks: consume redundant "normal" bookmark
+if ( IsOpenField() )
+{
+FFDataHandler::Pointer_t
pFFDataHandler(GetTopFieldContext()->getFFDataHandler());
+if ( IsOpenFieldCommand() || (pFFDataHandler &&
pFFDataHandler->getName() == rBookmarkName) )
+{
+// HACK: At the END marker, StartOrEndBookmark will START
+// a bookmark which will eventually be abandoned, not created.
+m_aBookmarkMap.erase(aBookmarkIter);
+return;
+}
+}
+
aBookmarkIter->second.m_sBookmarkName =
[Libreoffice-bugs] [Bug 120206] When switching keyboard layout, scrolling should not behave as though Scroll Lock was toggled
https://bugs.documentfoundation.org/show_bug.cgi?id=120206 --- Comment #6 from Mike Kaganski --- I still think it's a clear dupe of bug 112876. The "default for Linux" is too vague. Do you mean TDF build? or do you mean the distro packages? If the former, then I would argue that Linux distros are too different, and implementing the bug 112876 would allow users to handle that as they like, thus I believe no change is required here. On the other hand, with that implementation, distro maintainers would be able to create proper defaults for those flavors where default-off makes sense. So, unless you make this RFE dedicated only to "first option", nothing to see here. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/inc sc/source
sc/inc/conditio.hxx |1 +
sc/source/core/data/conditio.cxx |5 +
sc/source/ui/condformat/condformatmgr.cxx |4 ++--
3 files changed, 8 insertions(+), 2 deletions(-)
New commits:
commit 8c8926d127a3113a6cabc67df6cc6f7f0d583f98
Author: Eike Rathke
AuthorDate: Mon Oct 15 20:38:11 2018 +0200
Commit: Eike Rathke
CommitDate: Mon Oct 15 22:30:09 2018 +0200
Introduce and use ScConditionalFormatList::empty() instead of size()
Change-Id: If42fdfbcac74ef2a04bd5d006272a5c1a4f510e2
Reviewed-on: https://gerrit.libreoffice.org/61804
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/sc/inc/conditio.hxx b/sc/inc/conditio.hxx
index e1bda2ba71d7..65c9067b8700 100644
--- a/sc/inc/conditio.hxx
+++ b/sc/inc/conditio.hxx
@@ -650,6 +650,7 @@ public:
const_iterator end() const;
size_t size() const;
+bool empty() const;
void erase(sal_uLong nIndex);
void clear();
diff --git a/sc/source/core/data/conditio.cxx b/sc/source/core/data/conditio.cxx
index f2799f366005..937bb1b830d5 100644
--- a/sc/source/core/data/conditio.cxx
+++ b/sc/source/core/data/conditio.cxx
@@ -2246,6 +2246,11 @@ size_t ScConditionalFormatList::size() const
return m_ConditionalFormats.size();
}
+bool ScConditionalFormatList::empty() const
+{
+return m_ConditionalFormats.empty();
+}
+
void ScConditionalFormatList::erase( sal_uLong nIndex )
{
for( iterator itr = begin(); itr != end(); ++itr )
diff --git a/sc/source/ui/condformat/condformatmgr.cxx
b/sc/source/ui/condformat/condformatmgr.cxx
index 1ee0eb440fa7..078714b138bd 100644
--- a/sc/source/ui/condformat/condformatmgr.cxx
+++ b/sc/source/ui/condformat/condformatmgr.cxx
@@ -57,7 +57,7 @@ void ScCondFormatManagerWindow::Init()
SetUpdateMode(true);
-if (mpFormatList && mpFormatList->size())
+if (mpFormatList && !mpFormatList->empty())
SelectRow(0);
}
@@ -146,7 +146,7 @@ std::unique_ptr
ScCondFormatManagerDlg::GetConditionalF
void ScCondFormatManagerDlg::UpdateButtonSensitivity()
{
-OUString aNewSensitivity = mpFormatList->size() ? OUString("true") :
OUString("false");
+OUString aNewSensitivity = mpFormatList->empty() ? OUString("false") :
OUString("true");
m_pBtnRemove->set_property("sensitive", aNewSensitivity);
m_pBtnEdit->set_property("sensitive", aNewSensitivity);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120635] New: Drop caps - enable a value of 1 for lines
https://bugs.documentfoundation.org/show_bug.cgi?id=120635 Bug ID: 120635 Summary: Drop caps - enable a value of 1 for lines Product: LibreOffice Version: 6.0.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: st...@edmondsfamily.co.nz Description: A simple change to allow a value of 1 for lines under the drop caps tab would enable a character style to be applied to the first word of a paragraph. Example; In this bug submission form there are 2 paragraphs starting Bad example and Good example starting with different coloured text. With the proposed change a style could be created colouring the first word, in fact the first 2 words if hyphenated. Steps to Reproduce: 1.Open Drop Caps tab of paragraph style 2.Try to reduce lines less than 2 3. Actual Results: Lines can't go less than 2 Expected Results: A value of Lines = 1 can be selected Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120626] Unable to set rewind and direction in custom animation dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=120626 Caolán McNamara changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |ASSIGNED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | --- Comment #2 from Caolán McNamara --- I think there might be two bugs here, and only the direction one is new. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120634] New: Unexpected change of table content paragraph style when deleting a row
https://bugs.documentfoundation.org/show_bug.cgi?id=120634 Bug ID: 120634 Summary: Unexpected change of table content paragraph style when deleting a row Product: LibreOffice Version: 6.1.2.1 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lob...@ikr.uni-stuttgart.de Created attachment 145746 --> https://bugs.documentfoundation.org/attachment.cgi?id=145746=edit Example document I made a rather bizarre observation when further looking into #120627 (which may be related). To reproduce: - Open the attached document (which is an extract from a large document) - Select a field in the table - Open the context menu and press Delete->Rows The format of most of the cells changes to "centered". Even "Undo" does not restore the correct format. I was not able to reproduce this with a newly created document so it seems this is an error in the document itself. But IMHO this is a LO-bug even if this is caused by a format-bug in the document (but cannot judge on this). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120619] Uninstaller does not delete all folders and blocks one
https://bugs.documentfoundation.org/show_bug.cgi?id=120619 --- Comment #6 from Leandro Martín Drudi --- (In reply to Oliver Brinzing from comment #5) > Have you tried to reboot after uninstalling LO? > > I have a Win 10 installation where i have to reboot > after uninstalling LO to get rid of the folder: > > - uninstall LO > - folder "C:\Program Files\LibreOffice\" still exists and can't be removed > - reboot > - now "C:\Program Files\LibreOffice" has gone > - install new version of LO > > i do not need to reboot in safe mode. I have tried installing 6.1.2, 6.1.1 and 6.0.6. The problem is presented with the 6.1.x, and only on one occasion restarting the folder was deleted. The one that never disappeared is that of LibreOffice. But after restarting, the fault has been presented in most cases. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118833] New paragraph style is not shown in the sidebar until its is refreshed
https://bugs.documentfoundation.org/show_bug.cgi?id=118833 Commit Notification changed: What|Removed |Added Whiteboard||target:6.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118049] Style "Title" doubles text if selected after writing the text. The problem disappears after pressing the Enter key
https://bugs.documentfoundation.org/show_bug.cgi?id=118049 --- Comment #5 from Commit Notification --- Bjoern Michaelsen committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bafd49fb4d72b6dbb10b2fea1386d295dc9d435c tdf#118049 tdf#118833 tdf#118725: Fix some SwDepend regressions It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118725] UI: No visual change after applying a paragraph style, until scrolling (no redraw)
https://bugs.documentfoundation.org/show_bug.cgi?id=118725 --- Comment #7 from Commit Notification --- Bjoern Michaelsen committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bafd49fb4d72b6dbb10b2fea1386d295dc9d435c tdf#118049 tdf#118833 tdf#118725: Fix some SwDepend regressions It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118833] New paragraph style is not shown in the sidebar until its is refreshed
https://bugs.documentfoundation.org/show_bug.cgi?id=118833 --- Comment #2 from Commit Notification --- Bjoern Michaelsen committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bafd49fb4d72b6dbb10b2fea1386d295dc9d435c tdf#118049 tdf#118833 tdf#118725: Fix some SwDepend regressions It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118725] UI: No visual change after applying a paragraph style, until scrolling (no redraw)
https://bugs.documentfoundation.org/show_bug.cgi?id=118725 Commit Notification changed: What|Removed |Added Whiteboard||target:6.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/docnode/node.cxx |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit bafd49fb4d72b6dbb10b2fea1386d295dc9d435c
Author: Bjoern Michaelsen
AuthorDate: Sun Oct 14 22:55:25 2018 +0200
Commit: Björn Michaelsen
CommitDate: Mon Oct 15 21:56:55 2018 +0200
tdf#118049 tdf#118833 tdf#118725: Fix some SwDepend regressions
(partial revert/fix of 83243003b46dfb258c2b41049b0e1cb82a2d7ddb)
Change-Id: I96213a41b026ee6496516ad1d0a416c5708a2300
Reviewed-on: https://gerrit.libreoffice.org/61769
Tested-by: Jenkins
Tested-by: Xisco Faulí
Reviewed-by: Björn Michaelsen
diff --git a/sw/source/core/docnode/node.cxx b/sw/source/core/docnode/node.cxx
index acafa528ac01..d59d39a820c2 100644
--- a/sw/source/core/docnode/node.cxx
+++ b/sw/source/core/docnode/node.cxx
@@ -1184,7 +1184,9 @@ SwFormatColl *SwContentNode::ChgFormatColl( SwFormatColl
*pNewColl )
if( !IsModifyLocked() )
{
-ChkCondColl();
+SwFormatChg aTmp1( pOldColl );
+SwFormatChg aTmp2( pNewColl );
+SwClientNotify( *this, sw::LegacyModifyHint(, ) );
}
}
if ( IsInCache() )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 118049] Style "Title" doubles text if selected after writing the text. The problem disappears after pressing the Enter key
https://bugs.documentfoundation.org/show_bug.cgi?id=118049 Commit Notification changed: What|Removed |Added Whiteboard||target:6.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112876] Make use of scroll lock for navigation configurable (it conflicts with system use as keyboard layout indicator)
https://bugs.documentfoundation.org/show_bug.cgi?id=112876 Norbert X changed: What|Removed |Added CC||nrb...@gmail.com --- Comment #21 from Norbert X --- ScrollLock behavior should be configurable. I use ScrollLock LED as indicator of alternative keyboard layout: org.mate.peripherals-keyboard-xkb.kbd options ['grp\tgrp:ctrl_shift_toggle', 'lv3\tlv3:ralt_switch', 'compat\tmisc:typo', 'compat\tnumpad:microsoft', 'grp_led\tgrp_led:scroll'] Currently all modern version from Ubuntu (in 18.04 LTS repository and in PPA) are affected by this bug. I do not want to disable ScrollLock LED indicator. So please add option on yours (LibreOffice) side. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120620] setPosSize does not work properly
https://bugs.documentfoundation.org/show_bug.cgi?id=120620 Drew Jensen changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Version|6.2.0.0.alpha0+ Master |5.4.7.2 release CC||drewjensen.in...@gmail.com --- Comment #3 from Drew Jensen --- Testing with Ubuntu 18.04 LibreOffice 6.2Alpha1 also 6.0.7 and 5.4.7 Tried with OpenGL enabled and disabled and with GTK2 and GTK3 (where I could). The problem is persistent across all the different setups, and requires the following to manifest. First how to make it work every time. If you open the form for editing before you do anything else the macro does correctly resize and position the form window. Close the form without saving it. Now if you open the form in data entry mode you notice that it initally opens full screen and then it is properly resized and positioned. How to make it fail. Open the form for editing or data entry mode again, then maximize the form, now close it and again answer no if/when asked to save it. Now when the form is opened for data entry it starts out at full screen and stays at full screen. NOTE: 5.4 has the worst problems as it does not position the form properly but 6.0 and 6.2Alpha do. I didn't check 6.1 but I doubt it would be different. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120633] New: Date Field in Base
https://bugs.documentfoundation.org/show_bug.cgi?id=120633 Bug ID: 120633 Summary: Date Field in Base Product: LibreOffice Version: 6.1.2.1 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tsthom...@gmail.com Description: Does not recognise 29th February as a valid date. If date is entered, defaults back to 30/12/1899. Steps to Reproduce: 1.Enter 29/02/[] where [] is any year from 1899 onwards 2.Press TAB or click into another cell in Base 3. Actual Results: The date was changed from the date I entered, 29/02/1971, to 30/12/1899. Expected Results: The cell should have read 29/02/1971 Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82091] Spelling dialog correction of Calc cells does not remove red wavy underline, but context menu spelling correction does
https://bugs.documentfoundation.org/show_bug.cgi?id=82091 Aron Budea changed: What|Removed |Added Version|4.1.5.3 release |4.2.0.4 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120632] New: Cursor disappears after operations on Writer tables
https://bugs.documentfoundation.org/show_bug.cgi?id=120632 Bug ID: 120632 Summary: Cursor disappears after operations on Writer tables Product: LibreOffice Version: 6.1.1.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: everto...@gmail.com Description: In LibreOffice Writer, doing operations to exclude and include lines in tables, the cursor disappears, but continues to be moved by the keyboard. you can see that it obeys the keyboard by selecting something with the shift key, for example. The cursor is only displayed with the mouse click in any region of the document. The behavior is observed in LibreOffice 6.1.1.2 running under Debian 9.5 and GNOME 3 Steps to Reproduce: 1. Create a table 2. Delete a row or add a row (the cursor disappears) 3. Move the cursor with the keyboard (the cursor remains hidden) 4. Select something with the screen (the selection is checked, but the cursor remains hidden) 5. Click on the document (and the cursor reappears) Actual Results: The cursor is hidden until the document receives a mouse click. Expected Results: The cursor continues to appear. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Aldric Renaudin license statement
All of my past & future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 65704] UI: Sound and media panel UI stays forever in Writer, and is slow to open sounds
https://bugs.documentfoundation.org/show_bug.cgi?id=65704 Buovjaga changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #11 from Buovjaga --- No problem with any slowness, crash or emptiness. I don't know how to dock it, though. Would be great to hear from the people reproducing the bug in 2013-2015. Arch Linux 64-bit Version: 6.2.0.0.alpha0+ Build ID: 00e10ae3189a4407ffb1a48f836cd52dc9a1b6df CPU threads: 8; OS: Linux 4.18; UI render: default; VCL: gtk3_kde5; Locale: fi-FI (fi_FI.UTF-8); Calc: threaded Built on 13 October 2018 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120631] crashtesting assert
https://bugs.documentfoundation.org/show_bug.cgi?id=120631 Caolán McNamara changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||caol...@redhat.com, ||michael.st...@cib.de, ||nem...@numbertext.org Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88900] EDITING: Table between two numbered headings completely deleted when deleting lower heading
https://bugs.documentfoundation.org/show_bug.cgi?id=88900 Buovjaga changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #5 from Buovjaga --- In 4.3.0 and 4.4.7 on Win the backspacing gets me inside the table. In 6.2 I do not move inside the table, but do not delete the table either. Version: 6.2.0.0.alpha0+ (x64) Build ID: d9ad59da50c1172fe98f94370221c9c1b688200a CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-10-09_01:03:44 Locale: fi-FI (fi_FI); Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120631] New: crashtesting assert
https://bugs.documentfoundation.org/show_bug.cgi?id=120631 Bug ID: 120631 Summary: crashtesting assert Product: LibreOffice Version: 6.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: caol...@redhat.com Description: with the attachment https://bugs.documentfoundation.org/attachment.cgi?id=126429 from bug https://bugs.documentfoundation.org/show_bug.cgi?id=101145 ./instdir/program/soffice.bin --headless --convert-to pdf ./tdf101145-1.odt asserts with... soffice.bin: /home/caolan/LibreOffice/core/sw/source/core/txtnode/thints.cxx:2759: bool SwpHints::MergePortions(SwTextNode&): Assertion `aIter1 != aRange1.second && aIter2 != aRange2.second' failed. Application Error since... commit 1bbbe57dfc0b43d6b5444798d77dcdf5e4e76e49 Author: László Németh Date: Tue Aug 28 21:13:09 2018 +0200 tdf#119571 change tracking: show layout changes at paragraph join Steps to Reproduce: ./instdir/program/soffice.bin --headless --convert-to pdf ./tdf101145-1.odt Actual Results: assert Expected Results: noassert Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: chart2/source chart2/uiconfig
chart2/source/controller/dialogs/dlg_DataSource.cxx |4
chart2/source/controller/dialogs/tp_RangeChooser.cxx | 223 ---
chart2/source/controller/dialogs/tp_RangeChooser.hxx | 52 +---
chart2/uiconfig/ui/tp_RangeChooser.ui| 43 +--
4 files changed, 139 insertions(+), 183 deletions(-)
New commits:
commit aa75bf8b11c6e2e4fd7e9988c3c9d7db2420389a
Author: Caolán McNamara
AuthorDate: Mon Oct 15 15:09:32 2018 +0100
Commit: Caolán McNamara
CommitDate: Mon Oct 15 21:03:34 2018 +0200
weld RangeChooserTabPage
Change-Id: I3006d215cc734d28b208c0c4e8b9c719b70d4954
Reviewed-on: https://gerrit.libreoffice.org/61799
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/chart2/source/controller/dialogs/dlg_DataSource.cxx
b/chart2/source/controller/dialogs/dlg_DataSource.cxx
index 4e2f6062f71c..f71abafffebf 100644
--- a/chart2/source/controller/dialogs/dlg_DataSource.cxx
+++ b/chart2/source/controller/dialogs/dlg_DataSource.cxx
@@ -135,9 +135,9 @@ DataSourceDialog::DataSourceDialog(vcl::Window * pParent,
m_pTabControl->Show();
-m_pRangeChooserTabPage = VclPtr::Create(
m_pTabControl, *(m_apDialogModel.get()),
+m_pRangeChooserTabPage =
VclPtr::Create(TabPageParent(m_pTabControl),
*(m_apDialogModel.get()),
m_apDocTemplateProvider.get(), this, true
/* bHideDescription */ );
-m_pDataSourceTabPage = VclPtr::Create( m_pTabControl,
*(m_apDialogModel.get()),
+m_pDataSourceTabPage = VclPtr::Create(m_pTabControl,
*(m_apDialogModel.get()),
m_apDocTemplateProvider.get(), this, true
/* bHideDescription */ );
m_pTabControl->InsertPage( TP_RANGECHOOSER, SchResId(STR_PAGE_DATA_RANGE)
);
diff --git a/chart2/source/controller/dialogs/tp_RangeChooser.cxx
b/chart2/source/controller/dialogs/tp_RangeChooser.cxx
index a0776b6fff24..838d4df9fdd7 100644
--- a/chart2/source/controller/dialogs/tp_RangeChooser.cxx
+++ b/chart2/source/controller/dialogs/tp_RangeChooser.cxx
@@ -31,12 +31,12 @@
namespace
{
void lcl_ShowChooserButton(
-PushButton& rChooserButton,
+weld::Button& rChooserButton,
bool bShow)
{
-if( rChooserButton.IsVisible() != bShow )
+if( rChooserButton.get_visible() != bShow )
{
-rChooserButton.Show( bShow );
+rChooserButton.show( bShow );
}
}
@@ -58,46 +58,41 @@ using namespace ::com::sun::star::chart2;
using ::com::sun::star::uno::Sequence;
-RangeChooserTabPage::RangeChooserTabPage( vcl::Window* pParent
-, DialogModel & rDialogModel
-, ChartTypeTemplateProvider* pTemplateProvider
-, Dialog * pParentDialog
-, bool bHideDescription /* = false */ )
-: OWizardPage( pParent
-,"tp_RangeChooser"
-,"modules/schart/ui/tp_RangeChooser.ui")
-, m_nChangingControlCalls(0)
-, m_bIsDirty(false)
-, m_aLastValidRangeString()
-, m_pTemplateProvider(pTemplateProvider)
-, m_rDialogModel( rDialogModel )
-, m_pParentDialog( pParentDialog )
-, m_pTabPageNotifiable( dynamic_cast< TabPageNotifiable * >(
pParentDialog ))
+RangeChooserTabPage::RangeChooserTabPage(TabPageParent pParent, DialogModel &
rDialogModel,
+ ChartTypeTemplateProvider*
pTemplateProvider,
+ Dialog * pParentDialog, bool
bHideDescription /* = false */)
+: OWizardPage(pParent, "modules/schart/ui/tp_RangeChooser.ui",
"tp_RangeChooser")
+, m_nChangingControlCalls(0)
+, m_bIsDirty(false)
+, m_aLastValidRangeString()
+, m_pTemplateProvider(pTemplateProvider)
+, m_rDialogModel( rDialogModel )
+, m_pParentDialog( pParentDialog )
+, m_pTabPageNotifiable( dynamic_cast< TabPageNotifiable * >( pParentDialog
))
+, m_xFT_Caption(m_xBuilder->weld_label("FT_CAPTION_FOR_WIZARD"))
+, m_xFT_Range(m_xBuilder->weld_label("FT_RANGE"))
+, m_xED_Range(m_xBuilder->weld_entry("ED_RANGE"))
+, m_xIB_Range(m_xBuilder->weld_button("IB_RANGE"))
+, m_xRB_Rows(m_xBuilder->weld_radio_button("RB_DATAROWS"))
+, m_xRB_Columns(m_xBuilder->weld_radio_button("RB_DATACOLS"))
+,
m_xCB_FirstRowAsLabel(m_xBuilder->weld_check_button("CB_FIRST_ROW_ASLABELS"))
+,
m_xCB_FirstColumnAsLabel(m_xBuilder->weld_check_button("CB_FIRST_COLUMN_ASLABELS"))
+, m_xFTTitle(m_xBuilder->weld_label("STR_PAGE_DATA_RANGE"))
+, m_xFL_TimeBased(m_xBuilder->weld_widget("separator1"))
+, m_xCB_TimeBased(m_xBuilder->weld_check_button("CB_TIME_BASED"))
+, m_xFT_TimeStart(m_xBuilder->weld_label("label1"))
+, m_xEd_TimeStart(m_xBuilder->weld_entry("ED_TIME_BASED_START"))
+, m_xFT_TimeEnd(m_xBuilder->weld_label("label2"))
+, m_xEd_TimeEnd(m_xBuilder->weld_entry("ED_TIME_BASED_END"))
{
-get(m_pFT_Caption, "FT_CAPTION_FOR_WIZARD");
-
[Libreoffice-commits] core.git: chart2/source chart2/uiconfig
chart2/source/controller/dialogs/res_LegendPosition.cxx | 100 ++---
chart2/source/controller/dialogs/res_Titles.cxx | 180
--
chart2/source/controller/dialogs/tp_Wizard_TitlesAndObjects.cxx | 72 +---
chart2/source/controller/dialogs/tp_Wizard_TitlesAndObjects.hxx | 21 -
chart2/source/controller/inc/res_LegendPosition.hxx | 25 -
chart2/source/controller/inc/res_Titles.hxx | 44 +-
chart2/uiconfig/ui/wizelementspage.ui | 80 +---
7 files changed, 219 insertions(+), 303 deletions(-)
New commits:
commit 27a5f7d36874b6a20f5cae27d9b583b821a7cb8f
Author: Caolán McNamara
AuthorDate: Mon Oct 15 14:14:30 2018 +0100
Commit: Caolán McNamara
CommitDate: Mon Oct 15 21:03:16 2018 +0200
weld TitlesAndObjectsTabPage
Change-Id: I071ddf117e44fab3b5f712198973c86a0fd8d206
Reviewed-on: https://gerrit.libreoffice.org/61798
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/chart2/source/controller/dialogs/res_LegendPosition.cxx
b/chart2/source/controller/dialogs/res_LegendPosition.cxx
index 8eab04a77e0f..5842b0e2206f 100644
--- a/chart2/source/controller/dialogs/res_LegendPosition.cxx
+++ b/chart2/source/controller/dialogs/res_LegendPosition.cxx
@@ -39,37 +39,34 @@ namespace chart
using namespace ::com::sun::star;
using namespace ::com::sun::star::chart2;
-LegendPositionResources::LegendPositionResources(VclBuilderContainer& rParent)
-: m_xCC() //unused in this scenario
-, m_pCbxShow( nullptr ) //unused in this scenario, assumed to be visible
+LegendPositionResources::LegendPositionResources(weld::Builder& rBuilder)
+: m_xRbtLeft(rBuilder.weld_radio_button("left"))
+, m_xRbtRight(rBuilder.weld_radio_button("right"))
+, m_xRbtTop(rBuilder.weld_radio_button("top"))
+, m_xRbtBottom(rBuilder.weld_radio_button("bottom"))
{
-rParent.get(m_pRbtLeft, "left");
-rParent.get(m_pRbtRight, "right");
-rParent.get(m_pRbtTop, "top");
-rParent.get(m_pRbtBottom, "bottom");
impl_setRadioButtonToggleHdl();
}
-LegendPositionResources::LegendPositionResources(VclBuilderContainer& rParent,
+LegendPositionResources::LegendPositionResources(weld::Builder& rBuilder,
const uno::Reference< uno::XComponentContext >& xCC)
: m_xCC(xCC)
+, m_xCbxShow(rBuilder.weld_check_button("show"))
+, m_xRbtLeft(rBuilder.weld_radio_button("left"))
+, m_xRbtRight(rBuilder.weld_radio_button("right"))
+, m_xRbtTop(rBuilder.weld_radio_button("top"))
+, m_xRbtBottom(rBuilder.weld_radio_button("bottom"))
{
-rParent.get(m_pCbxShow, "show");
-rParent.get(m_pRbtLeft, "left");
-rParent.get(m_pRbtRight, "right");
-rParent.get(m_pRbtTop, "top");
-rParent.get(m_pRbtBottom, "bottom");
-
-m_pCbxShow->SetToggleHdl( LINK( this, LegendPositionResources,
PositionEnableHdl ) );
+m_xCbxShow->connect_toggled( LINK( this, LegendPositionResources,
PositionEnableHdl ) );
impl_setRadioButtonToggleHdl();
}
void LegendPositionResources::impl_setRadioButtonToggleHdl()
{
-m_pRbtLeft->SetToggleHdl( LINK( this, LegendPositionResources,
PositionChangeHdl ) );
-m_pRbtTop->SetToggleHdl( LINK( this, LegendPositionResources,
PositionChangeHdl ) );
-m_pRbtRight->SetToggleHdl( LINK( this, LegendPositionResources,
PositionChangeHdl ) );
-m_pRbtBottom->SetToggleHdl( LINK( this, LegendPositionResources,
PositionChangeHdl ) );
+m_xRbtLeft->connect_toggled( LINK( this, LegendPositionResources,
PositionChangeHdl ) );
+m_xRbtTop->connect_toggled( LINK( this, LegendPositionResources,
PositionChangeHdl ) );
+m_xRbtRight->connect_toggled( LINK( this, LegendPositionResources,
PositionChangeHdl ) );
+m_xRbtBottom->connect_toggled( LINK( this, LegendPositionResources,
PositionChangeHdl ) );
}
LegendPositionResources::~LegendPositionResources()
@@ -87,9 +84,9 @@ void LegendPositionResources::writeToResources( const
uno::Reference< frame::XMo
//show
bool bShowLegend = false;
xProp->getPropertyValue( "Show" ) >>= bShowLegend;
-if (m_pCbxShow)
-m_pCbxShow->Check( bShowLegend );
-PositionEnableHdl(*m_pCbxShow);
+if (m_xCbxShow)
+m_xCbxShow->set_active( bShowLegend );
+PositionEnableHdl(*m_xCbxShow);
//position
chart2::LegendPosition ePos;
@@ -97,21 +94,20 @@ void LegendPositionResources::writeToResources( const
uno::Reference< frame::XMo
switch( ePos )
{
case chart2::LegendPosition_LINE_START:
-m_pRbtLeft->Check();
+m_xRbtLeft->set_active(true);
break;
case chart2::LegendPosition_LINE_END:
-m_pRbtRight->Check();
+m_xRbtRight->set_active(true);
break;
case
[Libreoffice-commits] core.git: chart2/source chart2/uiconfig include/sfx2 include/svtools include/vcl svtools/source vcl/unx
chart2/source/controller/dialogs/ChartTypeDialogController.cxx | 131 +--
chart2/source/controller/dialogs/ChartTypeDialogController.hxx | 83 +-
chart2/source/controller/dialogs/dlg_ChartType.cxx | 26
chart2/source/controller/dialogs/dlg_ChartType_UNO.cxx |3
chart2/source/controller/dialogs/res_BarGeometry.cxx | 37 -
chart2/source/controller/dialogs/res_BarGeometry.hxx | 21
chart2/source/controller/dialogs/tp_ChartType.cxx | 353
+-
chart2/source/controller/dialogs/tp_ChartType.hxx | 15
chart2/source/controller/dialogs/tp_PointGeometry.cxx | 22
chart2/source/controller/dialogs/tp_PointGeometry.hxx |2
chart2/source/controller/inc/dlg_ChartType.hxx | 15
chart2/source/controller/main/ChartController.cxx |4
chart2/uiconfig/ui/charttypedialog.ui |8
chart2/uiconfig/ui/tp_ChartType.ui | 188 +++--
include/sfx2/tabdlg.hxx| 25
include/svtools/valueset.hxx |2
include/svtools/wizardmachine.hxx |6
include/vcl/tabpage.hxx| 25
svtools/source/control/valueset.cxx|9
svtools/source/dialogs/wizardmachine.cxx | 19
vcl/unx/gtk3/gtk3gtkinst.cxx | 24
21 files changed, 544 insertions(+), 474 deletions(-)
New commits:
commit ec548bce309d965a25e807ae79432114926e06f3
Author: Caolán McNamara
AuthorDate: Mon Oct 15 11:14:02 2018 +0100
Commit: Caolán McNamara
CommitDate: Mon Oct 15 21:02:23 2018 +0200
weld ChartTypeDialog and SchLayoutTabPage
Change-Id: I101c56b855d0bdc43559ca4561d298fa4ad92572
Reviewed-on: https://gerrit.libreoffice.org/61797
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/chart2/source/controller/dialogs/ChartTypeDialogController.cxx
b/chart2/source/controller/dialogs/ChartTypeDialogController.cxx
index 6e330aa3d45b..db42744007aa 100644
--- a/chart2/source/controller/dialogs/ChartTypeDialogController.cxx
+++ b/chart2/source/controller/dialogs/ChartTypeDialogController.cxx
@@ -117,10 +117,7 @@ ChartTypeDialogController::ChartTypeDialogController()
ChartTypeDialogController::~ChartTypeDialogController()
{
}
-Image ChartTypeDialogController::getImage()
-{
-return Image();
-}
+
bool ChartTypeDialogController::isSubType( const OUString& rServiceName )
{
const tTemplateServiceChartTypeParameterMap& rTemplateMap =
getTemplateMap();
@@ -337,7 +334,7 @@ void ChartTypeDialogController::commitToModel( const
ChartTypeParameter& rParame
}
}
}
-void ChartTypeDialogController::fillSubTypeList( ValueSet& rSubTypeList, const
ChartTypeParameter& /*rParameter*/ )
+void ChartTypeDialogController::fillSubTypeList( SvtValueSet& rSubTypeList,
const ChartTypeParameter& /*rParameter*/ )
{
rSubTypeList.Clear();
}
@@ -366,7 +363,7 @@ bool
ChartTypeDialogController::shouldShow_SortByXValuesResourceGroup() const
return false;
}
-void ChartTypeDialogController::showExtraControls( VclBuilderContainer*
/*pParent*/ )
+void ChartTypeDialogController::showExtraControls(weld::Builder* /*pBuilder*/)
{
}
void ChartTypeDialogController::hideExtraControls() const
@@ -411,12 +408,12 @@
ColumnChartDialogController::~ColumnChartDialogController()
}
OUString ColumnChartDialogController::getName()
{
-return SchResId( STR_TYPE_COLUMN );
+return SchResId(STR_TYPE_COLUMN);
}
-Image ColumnChartDialogController::getImage()
+OUString ColumnChartDialogController::getImage()
{
-return Image(BitmapEx(BMP_TYPE_COLUMN));
+return OUStringLiteral(BMP_TYPE_COLUMN);
}
const tTemplateServiceChartTypeParameterMap&
ColumnChartDialogController::getTemplateMap() const
@@ -431,7 +428,7 @@ const tTemplateServiceChartTypeParameterMap&
ColumnChartDialogController::getTem
{"com.sun.star.chart2.template.ThreeDColumnDeep" ,
ChartTypeParameter(4,false,true,GlobalStackMode_STACK_Z)}};
return s_aTemplateMap;
}
-void ColumnChartDialogController::fillSubTypeList( ValueSet& rSubTypeList,
const ChartTypeParameter& rParameter )
+void ColumnChartDialogController::fillSubTypeList( SvtValueSet& rSubTypeList,
const ChartTypeParameter& rParameter )
{
rSubTypeList.Clear();
@@ -488,12 +485,12 @@ BarChartDialogController::~BarChartDialogController()
OUString BarChartDialogController::getName()
{
-return SchResId( STR_TYPE_BAR );
+return SchResId(STR_TYPE_BAR);
}
-Image BarChartDialogController::getImage()
+OUString BarChartDialogController::getImage()
{
-return Image(BitmapEx(BMP_TYPE_BAR));
+return OUStringLiteral(BMP_TYPE_BAR);
}
const tTemplateServiceChartTypeParameterMap&
[Libreoffice-commits] core.git: include/sfx2 sfx2/source
include/sfx2/basedlgs.hxx |2 --
sfx2/source/dialog/basedlgs.cxx |4 +---
2 files changed, 1 insertion(+), 5 deletions(-)
New commits:
commit ff643eb3c5b1a50aab5e544ea689e227eecc751d
Author: Caolán McNamara
AuthorDate: Mon Oct 15 16:11:57 2018 +0100
Commit: Caolán McNamara
CommitDate: Mon Oct 15 21:01:56 2018 +0200
m_pLine is always unset
Change-Id: I269081ed0abcad09b66331d7fc1589e16556bd27
Reviewed-on: https://gerrit.libreoffice.org/61801
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/include/sfx2/basedlgs.hxx b/include/sfx2/basedlgs.hxx
index d2ba78be8c37..d4279599fe4b 100644
--- a/include/sfx2/basedlgs.hxx
+++ b/include/sfx2/basedlgs.hxx
@@ -40,7 +40,6 @@ class OKButton;
class CancelButton;
class HelpButton;
class Button;
-class FixedLine;
// class SfxModalDialog --
@@ -153,7 +152,6 @@ public:
struct SingleTabDlgImpl
{
VclPtr m_pSfxPage;
-VclPtr m_pLine;
SingleTabDlgImpl();
};
diff --git a/sfx2/source/dialog/basedlgs.cxx b/sfx2/source/dialog/basedlgs.cxx
index f8dfdc33123f..f4a07696af43 100644
--- a/sfx2/source/dialog/basedlgs.cxx
+++ b/sfx2/source/dialog/basedlgs.cxx
@@ -46,8 +46,7 @@ using namespace ::com::sun::star::uno;
#define USERITEM_NAME "UserItem"
SingleTabDlgImpl::SingleTabDlgImpl()
-: m_pSfxPage(nullptr)
-, m_pLine(nullptr)
+: m_pSfxPage(nullptr)
{
}
@@ -664,7 +663,6 @@ SfxSingleTabDialog::~SfxSingleTabDialog()
void SfxSingleTabDialog::dispose()
{
pImpl->m_pSfxPage.disposeAndClear();
-pImpl->m_pLine.disposeAndClear();
pImpl.reset();
pOKBtn.clear();
pCancelBtn.clear();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 119623] Lonely SUM formula fails to update, and thus can lead to a treacherously wrong result (steps in comment 5)
https://bugs.documentfoundation.org/show_bug.cgi?id=119623 Eike Rathke changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |er...@redhat.com |desktop.org | --- Comment #9 from Eike Rathke --- Investigating. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/dmapper/TblStylePrHandler.cxx |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
New commits:
commit 992ed5bdf9946b59bcd6bfc2250f85e7d0374826
Author: Mike Kaganski
AuthorDate: Mon Oct 15 16:21:02 2018 +0200
Commit: Mike Kaganski
CommitDate: Mon Oct 15 20:47:32 2018 +0200
Avoid useless copy of vectors
Change-Id: Iadab935efff35e1e8e5d70878414da1ed2f0fbf9
Reviewed-on: https://gerrit.libreoffice.org/61795
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/writerfilter/source/dmapper/TblStylePrHandler.cxx
b/writerfilter/source/dmapper/TblStylePrHandler.cxx
index d3739053efa6..d2e5bb2054ce 100644
--- a/writerfilter/source/dmapper/TblStylePrHandler.cxx
+++ b/writerfilter/source/dmapper/TblStylePrHandler.cxx
@@ -140,8 +140,7 @@ void TblStylePrHandler::lcl_sprm(Sprm & rSprm)
rSprm.getId() == NS_ooxml::LN_CT_TcPrBase;
if (bGrabBag)
{
-aSavedGrabBag = m_aInteropGrabBag;
-m_aInteropGrabBag.clear();
+std::swap(aSavedGrabBag, m_aInteropGrabBag);
}
resolveSprmProps( rSprm );
if (bGrabBag)
@@ -154,7 +153,7 @@ void TblStylePrHandler::lcl_sprm(Sprm & rSprm)
aSavedGrabBag.push_back(getInteropGrabBag("tblPr"));
else if (rSprm.getId() == NS_ooxml::LN_CT_TcPrBase)
aSavedGrabBag.push_back(getInteropGrabBag("tcPr"));
-m_aInteropGrabBag = aSavedGrabBag;
+std::swap(m_aInteropGrabBag, aSavedGrabBag);
}
}
break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120630] Importing CSV
https://bugs.documentfoundation.org/show_bug.cgi?id=120630 Mike Kaganski changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED --- Comment #1 from Mike Kaganski --- This is not a bug. CSV is a plain-text format for data interchange. If some value in it may be interpreted as number, and not quoted, then *by default* it should be treated as number, which happens here. It doesn't matter if previous line contained a text in that position: that night be a table header, or some intermediate summary. If you need to have some column treated as text, just right-click the relevant column title *at CSV import dialog*, and select "Text". Closing NOTABUG. Please feel free to reopen if you disagree; if so, then please describe your reasons. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: LibreOffice ESC call, Thur - 16:00 central European (local) time
Hi ESC, On Tue, Oct 09, 2018 at 10:56:23AM +0100, Michael Meeks wrote: > * mentoring/easyhack update In the aftermath of the LibreOffice conference, we (Eike and me) discussed with members of OpenLabsAlbania how we can continue to grow and strengthen the connection between the local community and the LibreOffice project. One of the things we emphasized were the advantages of having core code contributors in a local community. This was discussed by members of OpenLabs and as a result Izabela and Eva volunteered to pursue this topic further. You can see the discussion on the forum of OpenLabs here: https://forum.openlabs.cc/t/libreoffice-2019/1406/9 As such, I would like to ask to give Izabela and Eva a warm welcome, e.g. on IRC or on the mailing list. I hope we can work together to the benefit of both the LibreOffice project and the community around OpenLabsAlbania. A final note: Due to my daily workday duties, I can only rarely attend the ESC call usually. As such, Im humbly asking the ESC to just maybe (re-)check and reevaluate if we as a project have all our ducks in a row for welcoming some enthusiatic newcomers. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 120630] New: Importing CSV
https://bugs.documentfoundation.org/show_bug.cgi?id=120630 Bug ID: 120630 Summary: Importing CSV Product: LibreOffice Version: 6.2.0.0.alpha0+ Master Hardware: x86-64 (AMD64) OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: t...@backlog.de Description: On csv-import LO interprets specific cells as numeric (and remove leading 0), while other cells in same col are text. Actual Results: Import CSV with col PW and 2 lines. PW-line1=affenzahn, PW-line2=00654 Result after import is affenzahn, 654 Expected Results: expected: affenzahn, 00654 Reproducible: Always User Profile Reset: No Additional Info: do not play with results. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100156] [META] Wayland-related bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=100156 Maxim Monastirsky changed: What|Removed |Added Depends on||117421 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=117421 [Bug 117421] VIEWING: Tooltip on the bottom bar of Writer GUI overflows the screen -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114019] [META] Tooltip bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114019 Bug 114019 depends on bug 117421, which changed state. Bug 117421 Summary: VIEWING: Tooltip on the bottom bar of Writer GUI overflows the screen https://bugs.documentfoundation.org/show_bug.cgi?id=117421 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |NOTOURBUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100156] [META] Wayland-related bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=100156 Bug 100156 depends on bug 117421, which changed state. Bug 117421 Summary: VIEWING: Tooltip on the bottom bar of Writer GUI overflows the screen https://bugs.documentfoundation.org/show_bug.cgi?id=117421 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |NOTOURBUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117421] VIEWING: Tooltip on the bottom bar of Writer GUI overflows the screen
https://bugs.documentfoundation.org/show_bug.cgi?id=117421 Maxim Monastirsky changed: What|Removed |Added CC||momonas...@gmail.com Status|NEEDINFO|RESOLVED Blocks||100156 Resolution|--- |NOTOURBUG --- Comment #8 from Maxim Monastirsky --- That's an upstream gtk3 bug, and it was fixed recently for gtk 3.24 with the following commit: https://gitlab.gnome.org/GNOME/gtk/commit/14d22cb3233efbd7e9f8f6244179eccc2cc8beb8 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100156 [Bug 100156] [META] Wayland-related bugs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120087] Disable unuseable items on Manage Condition Formatting dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=120087 Eike Rathke changed: What|Removed |Added Status|NEW |RESOLVED Assignee|libreoffice-b...@lists.free |sharmaabhyud...@gmail.com |desktop.org | OS|Windows (All) |All Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116221] [META] Manage conditional formatting dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=116221 Bug 116221 depends on bug 120087, which changed state. Bug 120087 Summary: Disable unuseable items on Manage Condition Formatting dialog https://bugs.documentfoundation.org/show_bug.cgi?id=120087 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120087] Disable unuseable items on Manage Condition Formatting dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=120087 Commit Notification changed: What|Removed |Added Whiteboard||target:6.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120087] Disable unuseable items on Manage Condition Formatting dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=120087 --- Comment #3 from Commit Notification --- Abhyudaya Sharma committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=401d1691468fb11281b4eaa290193b4e8ff871c3 tdf#120087 Disable unuseable items in Manage Dialog It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/condformat/condformatmgr.cxx | 12
sc/source/ui/inc/condformatmgr.hxx|1 +
2 files changed, 13 insertions(+)
New commits:
commit 401d1691468fb11281b4eaa290193b4e8ff871c3
Author: Abhyudaya Sharma
AuthorDate: Sat Oct 6 21:27:48 2018 +0530
Commit: Eike Rathke
CommitDate: Mon Oct 15 20:20:25 2018 +0200
tdf#120087 Disable unuseable items in Manage Dialog
Fix behaviour for 'Remove' and 'Edit' buttons for the Manage Conditional
Formatting dialog in Calc
Change-Id: Id8fc37262464232ab8fbb76c5a9609af5982e222
Reviewed-on: https://gerrit.libreoffice.org/61475
Reviewed-by: Eike Rathke
Tested-by: Eike Rathke
diff --git a/sc/source/ui/condformat/condformatmgr.cxx
b/sc/source/ui/condformat/condformatmgr.cxx
index 45d169b0e22e..1ee0eb440fa7 100644
--- a/sc/source/ui/condformat/condformatmgr.cxx
+++ b/sc/source/ui/condformat/condformatmgr.cxx
@@ -119,6 +119,8 @@ ScCondFormatManagerDlg::ScCondFormatManagerDlg(vcl::Window*
pParent, ScDocument*
m_pBtnEdit->SetClickHdl(LINK(this, ScCondFormatManagerDlg,
EditBtnClickHdl));
m_pBtnAdd->SetClickHdl(LINK(this, ScCondFormatManagerDlg, AddBtnHdl));
m_pCtrlManager->SetDoubleClickHdl(LINK(this, ScCondFormatManagerDlg,
EditBtnHdl));
+
+UpdateButtonSensitivity();
}
ScCondFormatManagerDlg::~ScCondFormatManagerDlg()
@@ -142,6 +144,13 @@ std::unique_ptr
ScCondFormatManagerDlg::GetConditionalF
return std::move(mpFormatList);
}
+void ScCondFormatManagerDlg::UpdateButtonSensitivity()
+{
+OUString aNewSensitivity = mpFormatList->size() ? OUString("true") :
OUString("false");
+m_pBtnRemove->set_property("sensitive", aNewSensitivity);
+m_pBtnEdit->set_property("sensitive", aNewSensitivity);
+}
+
// Get the current conditional format selected.
//
ScConditionalFormat* ScCondFormatManagerDlg::GetCondFormatSelected()
@@ -153,12 +162,14 @@ IMPL_LINK_NOARG(ScCondFormatManagerDlg, RemoveBtnHdl,
Button*, void)
{
m_pCtrlManager->DeleteSelection();
mbModified = true;
+UpdateButtonSensitivity();
}
IMPL_LINK_NOARG(ScCondFormatManagerDlg, EditBtnClickHdl, Button*, void)
{
mbModified = true;
EditBtnHdl(nullptr);
+UpdateButtonSensitivity();
}
IMPL_LINK_NOARG(ScCondFormatManagerDlg, EditBtnHdl, SvTreeListBox*, bool)
{
@@ -182,6 +193,7 @@ IMPL_LINK_NOARG(ScCondFormatManagerDlg, AddBtnHdl, Button*,
void)
void ScCondFormatManagerDlg::SetModified()
{
mbModified = true;
+UpdateButtonSensitivity();
}
bool ScCondFormatManagerDlg::CondFormatsChanged() const
diff --git a/sc/source/ui/inc/condformatmgr.hxx
b/sc/source/ui/inc/condformatmgr.hxx
index fec437fd6fa1..58b8b605228c 100644
--- a/sc/source/ui/inc/condformatmgr.hxx
+++ b/sc/source/ui/inc/condformatmgr.hxx
@@ -64,6 +64,7 @@ private:
VclPtr m_pBtnEdit;
std::unique_ptr mpFormatList;
VclPtr m_pCtrlManager;
+void UpdateButtonSensitivity();
DECL_LINK(RemoveBtnHdl, Button*, void);
DECL_LINK(EditBtnClickHdl, Button*, void);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 111002] Paragraph style lost on save after Clear Direct Formatting (Ctrl+M) or rename and went back to Default
https://bugs.documentfoundation.org/show_bug.cgi?id=111002 --- Comment #8 from Mike Kaganski --- (In reply to Thomas Lendo from comment #7) > Mike, what's the difference to the older bug 47471? If only I remembered ;-) Please feel free to close as duplicate (I honestly don't remember why did I file it separately, given that I knew about the first one in See Also list, that I mentioned right at creation...) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120617] Cell background in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=120617 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #2 from m.a.riosv --- There is an extension for that: https://extensions.libreoffice.org/extensions/hatch-patterns-for-cells -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82091] Spelling dialog correction of Calc cells does not remove red wavy underline, but context menu spelling correction does
https://bugs.documentfoundation.org/show_bug.cgi?id=82091 --- Comment #19 from Buovjaga --- (In reply to Aron Budea from comment #18) > Btw, I don't think any of these commits got into LO 4.1, so in that case > perhaps bug 74987 is a different issue. Seems so and was WFM on master. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74987] EDITING: Language None attribute in calc does not disable spellchecking
https://bugs.documentfoundation.org/show_bug.cgi?id=74987 Buovjaga changed: What|Removed |Added CC||todven...@suomi24.fi Resolution|DUPLICATE |WORKSFORME --- Comment #10 from Buovjaga --- This was not actually a duplicate, but good news: I could repro with 4.3.0, but not with master. I will close as WFM Version: 6.2.0.0.alpha0+ (x64) Build ID: d9ad59da50c1172fe98f94370221c9c1b688200a CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-10-09_01:03:44 Locale: fi-FI (fi_FI); Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120629] Hebrew numbering sequence choice reverted to 1, 2, 3... when saving .doc files
https://bugs.documentfoundation.org/show_bug.cgi?id=120629 Eyal Rozenberg changed: What|Removed |Added Blocks||43808 --- Comment #1 from Eyal Rozenberg --- The bug also manifests when you use Arabic letters as the numeral sequence - but _not_ if you use Latin letters (A,B,C,...) Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=43808 [Bug 43808] [META] Right-To-Left (aka Complex Text Layout) language issues (RTL/CTL) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left (aka Complex Text Layout) language issues (RTL/CTL)
https://bugs.documentfoundation.org/show_bug.cgi?id=43808 Eyal Rozenberg changed: What|Removed |Added Depends on||120629 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=120629 [Bug 120629] Hebrew numbering sequence choice reverted to 1,2,3... when saving .doc files -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120629] New: Hebrew numbering sequence choice reverted to 1, 2, 3... when saving .doc files
https://bugs.documentfoundation.org/show_bug.cgi?id=120629 Bug ID: 120629 Summary: Hebrew numbering sequence choice reverted to 1,2,3... when saving .doc files Product: LibreOffice Version: 6.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyal...@technion.ac.il Description: If you create a numbering style using the Hebrew letter sequence, and save it to a .doc file (Word 97-2003) - the style reverts to regular numbers (1,2,3,...) when you open it. Steps to Reproduce: 1. Create a new LO Writer document 2. Set the paragraph direction to RTL (this may not be necessary) 3. Create a new numbering style using Hebrew letters (א,ב,ג,...י,יא,יב,...) 4. Set the paragraph to the new style 5. Save the document in Word 97-2003 format (.doc) 6. Close the document 7. Open the document you saved Actual Results: The single paragraph is numbered 1. Expected Results: The single paragraph should be numbered א. Reproducible: Always User Profile Reset: No Additional Info: It's likely a numbering style, whose name begins with WWNum, has been created. If you change that numeral sequence choice there, save close and reopen - you get the same effect. Seen with: Version: 6.2.0.0.alpha0+ Build ID: ad6adb1bfadf49af3187a0bb3ceffbf355e9eed1 CPU threads: 4; OS: Linux 4.9; UI render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-09-29_02:45:20 Locale: en-US (en_IL); Calc: threaded ... but I believe this must be an old bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
