[Libreoffice-bugs] [Bug 120669] When using LTR and RTL texts on mac, the flow is faulty
https://bugs.documentfoundation.org/show_bug.cgi?id=120669 --- Comment #4 from nisimn...@pendo.io --- I can't seem to find the buttons to change the RTL\LTR directions. Where are they hidden? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120703] Bugs found by PVS-Studio static analyzer
https://bugs.documentfoundation.org/show_bug.cgi?id=120703 --- Comment #15 from Commit Notification --- Mike Kaganski committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=86fd9622fb8066e1b3a41971cdf7ad76539d313c tdf#120703 (PVS): handle failed realloc It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120703] Bugs found by PVS-Studio static analyzer
https://bugs.documentfoundation.org/show_bug.cgi?id=120703 --- Comment #17 from Commit Notification --- Mike Kaganski committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=79e837d8e2fb961cd4825566f07aabf031fddb5f tdf#120703 (PVS): handle failed (re)allocations It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120703] Bugs found by PVS-Studio static analyzer
https://bugs.documentfoundation.org/show_bug.cgi?id=120703 --- Comment #16 from Commit Notification --- Mike Kaganski committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=70198d4f7ffc7b3139cf34764b0e6bb6971489c6 tdf#120703 (PVS): handle malloc/realloc failures It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - desktop/win32 vcl/source
desktop/win32/source/guistdio/guistdio.inc | 123 +++--
vcl/source/filter/igif/decode.cxx | 11 ++
2 files changed, 76 insertions(+), 58 deletions(-)
New commits:
commit 79e837d8e2fb961cd4825566f07aabf031fddb5f
Author: Mike Kaganski
AuthorDate: Sun Oct 21 00:34:25 2018 +0200
Commit: Mike Kaganski
CommitDate: Sun Oct 21 07:08:05 2018 +0200
tdf#120703 (PVS): handle failed (re)allocations
V769 The 'readBuf' pointer in the 'readBuf + readAll' expression could be
nullptr.
In such case, resulting value will be senseless and it should not be
used.
Check lines: 171, 166.
V701 realloc() possible leak: when realloc() fails in allocating memory,
original
pointer 'readBuf' is lost. Consider assigning realloc() to a temporary
pointer.
Change-Id: I2e15a1abb79516dd42d6425646bb54eab5b8
Reviewed-on: https://gerrit.libreoffice.org/62117
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/desktop/win32/source/guistdio/guistdio.inc
b/desktop/win32/source/guistdio/guistdio.inc
index eb1b9cda1639..ea466769d517 100644
--- a/desktop/win32/source/guistdio/guistdio.inc
+++ b/desktop/win32/source/guistdio/guistdio.inc
@@ -26,6 +26,7 @@
#include
#include
+#include
#ifdef UNOPKG
@@ -147,70 +148,80 @@ DWORD WINAPI InputThread( LPVOID pParam )
{
DWORD dwRead = 0;
HANDLE hWritePipe = static_cast(pParam);
-
-//We need to read in the complete input until we encounter a new line
before
-//converting to Unicode. This is necessary because the input string can use
-//characters of one, two, and more bytes. If the last character is not
-//complete, then it will not be converted properly.
-
-//Find out how a new line (0xd 0xa) looks like with the used code page.
-//Characters may have one or multiple bytes and different byte ordering
-//can be used (little and big endian);
-int cNewLine = WideCharToMultiByte(
-GetConsoleCP(), 0, L"\r\n", 2, nullptr, 0, nullptr, nullptr);
-char * mbBuff = new char[cNewLine];
-WideCharToMultiByte(
-GetConsoleCP(), 0, L"\r\n", 2, mbBuff, cNewLine, nullptr, nullptr);
-
-const DWORD dwBufferSize = 256;
-char* readBuf = static_cast(malloc(dwBufferSize));
-int readAll = 0;
-DWORD curBufSize = dwBufferSize;
-
-while ( ReadFile( GetStdHandle( STD_INPUT_HANDLE ),
- readBuf + readAll,
- curBufSize - readAll, , nullptr ) )
+char* readBuf = nullptr;
+try
{
-readAll += dwRead;
-int lastBufSize = curBufSize;
-//Grow the buffer if necessary
-if (readAll > curBufSize * 0.7)
+//We need to read in the complete input until we encounter a new line
before
+//converting to Unicode. This is necessary because the input string
can use
+//characters of one, two, and more bytes. If the last character is not
+//complete, then it will not be converted properly.
+
+//Find out how a new line (0xd 0xa) looks like with the used code page.
+//Characters may have one or multiple bytes and different byte ordering
+//can be used (little and big endian);
+int cNewLine = WideCharToMultiByte(
+GetConsoleCP(), 0, L"\r\n", 2, nullptr, 0, nullptr, nullptr);
+auto mbBuff = o3tl::make_unique(cNewLine);
+WideCharToMultiByte(
+GetConsoleCP(), 0, L"\r\n", 2, mbBuff.get(), cNewLine, nullptr,
nullptr);
+
+const DWORD dwBufferSize = 256;
+readBuf = static_cast(malloc(dwBufferSize));
+if (!readBuf)
+throw std::bad_alloc();
+int readAll = 0;
+DWORD curBufSize = dwBufferSize;
+
+while ( ReadFile( GetStdHandle( STD_INPUT_HANDLE ),
+ readBuf + readAll,
+ curBufSize - readAll, , nullptr ) )
{
-curBufSize *= 2;
-readBuf = static_cast(realloc(readBuf, curBufSize));
-}
+readAll += dwRead;
+int lastBufSize = curBufSize;
+//Grow the buffer if necessary
+if (readAll > curBufSize * 0.7)
+{
+curBufSize *= 2;
+if (auto p = static_cast(realloc(readBuf, curBufSize)))
+readBuf = p;
+else
+{
+throw std::bad_alloc();
+}
+}
-//If the buffer was filled completely then
-//there could be more input coming. But if we read from the console
-//and the console input fits exactly in the buffer, then the next
-//ReadFile would block until the users presses return, etc.
-//Therefore we check if last character is a new line.
-//To test this, set dwBufferSize to 4 and enter "no". This should
produce
-//4 bytes with most code pages.
-if ( readAll ==
[Libreoffice-commits] core.git: ucb/source
ucb/source/ucp/ftp/ftpurl.cxx |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 86fd9622fb8066e1b3a41971cdf7ad76539d313c Author: Mike Kaganski AuthorDate: Sat Oct 20 22:58:47 2018 +0200 Commit: Mike Kaganski CommitDate: Sun Oct 21 07:07:23 2018 +0200 tdf#120703 (PVS): handle failed realloc V701 realloc() possible leak: when realloc() fails in allocating memory, original pointer 'm_pBuffer' is lost. Consider assigning realloc() to a temporary pointer. Change-Id: I8a18e1472072456bfe9f32d822f185cabd24d6ed Reviewed-on: https://gerrit.libreoffice.org/62114 Reviewed-by: Mike Kaganski Tested-by: Mike Kaganski diff --git a/ucb/source/ucp/ftp/ftpurl.cxx b/ucb/source/ucp/ftp/ftpurl.cxx index 38e4afe3345a..01c2eb292860 100644 --- a/ucb/source/ucp/ftp/ftpurl.cxx +++ b/ucb/source/ucp/ftp/ftpurl.cxx @@ -88,7 +88,10 @@ int MemoryContainer::append( m_nLen+=1024; } while(m_nLen < tmp); -m_pBuffer = std::realloc(m_pBuffer,m_nLen); +if (auto p = std::realloc(m_pBuffer, m_nLen)) +m_pBuffer = p; +else +return 0; } memcpy(static_cast(m_pBuffer)+m_nWritePos, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3-desktop' - configure.ac
configure.ac | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
New commits:
commit 35196c456ae1ffb9d826c8ec3b8967d6656779f0
Author: Stephan Bergmann
AuthorDate: Tue Sep 18 08:39:21 2018 +0200
Commit: Andras Timar
CommitDate: Sun Oct 21 06:47:40 2018 +0200
macOS SDK 10.14 is out
Reviewed-on: https://gerrit.libreoffice.org/60657
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
(cherry picked from commit a8eb515599526b5b69647a842b2889b6f56de2c8)
Change-Id: Iab7bc66db94fe02bb3714234d68b3e2fc3569fdf
diff --git a/configure.ac b/configure.ac
index 7b11377cad1a..6c9f89128e2a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2744,8 +2744,7 @@ if test $_os = Darwin; then
# higher than or equal to the minimum required should be found.
AC_MSG_CHECKING([what Mac OS X SDK to use])
-
-for _macosx_sdk in $with_macosx_sdk 10.8 10.9 10.10 10.11 10.12 10.13; do
+for _macosx_sdk in $with_macosx_sdk 10.8 10.9 10.10 10.11 10.12 10.13
10.14; do
MACOSX_SDK_PATH=`xcrun --sdk macosx${_macosx_sdk} --show-sdk-path 2>
/dev/null`
if test -d "$MACOSX_SDK_PATH"; then
with_macosx_sdk="${_macosx_sdk}"
@@ -2782,6 +2781,9 @@ if test $_os = Darwin; then
10.13)
MACOSX_SDK_VERSION=101300
;;
+10.14)
+MACOSX_SDK_VERSION=101400
+;;
*)
AC_MSG_ERROR([with-macosx-sdk $with_macosx_sdk is not a supported
value, supported values are 10.8--13])
;;
@@ -2821,6 +2823,9 @@ if test $_os = Darwin; then
10.13)
MAC_OS_X_VERSION_MIN_REQUIRED="101300"
;;
+10.14)
+MAC_OS_X_VERSION_MIN_REQUIRED="101400"
+;;
*)
AC_MSG_ERROR([with-macosx-version-min-required
$with_macosx_version_min_required is not a supported value, supported values
are 10.8--13])
;;
@@ -2864,6 +2869,9 @@ if test $_os = Darwin; then
10.13)
MAC_OS_X_VERSION_MAX_ALLOWED="101300"
;;
+10.14)
+MAC_OS_X_VERSION_MAX_ALLOWED="101400"
+;;
*)
AC_MSG_ERROR([with-macosx-version-max-allowed
$with_macosx_version_max_allowed is not a supported value, supported values are
10.8--13])
;;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - configure.ac
configure.ac | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
New commits:
commit c6af7bc0bd426ec459197c0b52db0a113fb5cd80
Author: Stephan Bergmann
AuthorDate: Tue Sep 18 08:39:21 2018 +0200
Commit: Andras Timar
CommitDate: Sun Oct 21 00:13:08 2018 +0200
macOS SDK 10.14 is out
Reviewed-on: https://gerrit.libreoffice.org/60657
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
(cherry picked from commit a8eb515599526b5b69647a842b2889b6f56de2c8)
Change-Id: Iab7bc66db94fe02bb3714234d68b3e2fc3569fdf
diff --git a/configure.ac b/configure.ac
index c71ea1672658..932d8c73a6f6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2618,7 +2618,7 @@ if test $_os = Darwin -o $_os = iOS; then
# higher than or equal to the minimum required should be found.
AC_MSG_CHECKING([what Mac OS X SDK to use])
-for _macosx_sdk in $with_macosx_sdk 10.13 10.12; do
+for _macosx_sdk in ${with_macosx_sdk-10.14 10.13 10.12}; do
MACOSX_SDK_PATH=`xcrun --sdk macosx${_macosx_sdk} --show-sdk-path 2>
/dev/null`
if test -d "$MACOSX_SDK_PATH"; then
with_macosx_sdk="${_macosx_sdk}"
@@ -2662,6 +2662,9 @@ if test $_os = Darwin -o $_os = iOS; then
10.13)
MACOSX_SDK_VERSION=101300
;;
+10.14)
+MACOSX_SDK_VERSION=101400
+;;
*)
AC_MSG_ERROR([with-macosx-sdk $with_macosx_sdk is not a supported
value, supported values are 10.9--13])
;;
@@ -2698,6 +2701,9 @@ if test $_os = Darwin -o $_os = iOS; then
10.13)
MAC_OS_X_VERSION_MIN_REQUIRED="101300"
;;
+10.14)
+MAC_OS_X_VERSION_MIN_REQUIRED="101400"
+;;
*)
AC_MSG_ERROR([with-macosx-version-min-required
$with_macosx_version_min_required is not a supported value, supported values
are 10.9--13])
;;
@@ -2739,6 +2745,9 @@ if test $_os = Darwin -o $_os = iOS; then
10.13)
MAC_OS_X_VERSION_MAX_ALLOWED="101300"
;;
+10.14)
+MAC_OS_X_VERSION_MAX_ALLOWED="101400"
+;;
*)
AC_MSG_ERROR([with-macosx-version-max-allowed
$with_macosx_version_max_allowed is not a supported value, supported values are
10.9--13])
;;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 66138] Set text anchor in style; shape doesn't use it
https://bugs.documentfoundation.org/show_bug.cgi?id=66138 --- Comment #5 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77796] FILEOPEN: DOCX - Table cell padding (defined in table style) not imported correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=77796 --- Comment #13 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106878] Improve the LibreOffice "fallback theme"
https://bugs.documentfoundation.org/show_bug.cgi?id=106878 --- Comment #3 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113134] Hebrew Dagesh/Mapiq mis-rendered with Culmus fonts in special chars dialog and when inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=113134 --- Comment #26 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95096] ibus keyboarding solution - kmfl characters are not "swallowed" for cell in row with "table in table"
https://bugs.documentfoundation.org/show_bug.cgi?id=95096 --- Comment #14 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105154] FILESAVE: DOCX: Extra page displayed in MSO Word after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=105154 --- Comment #6 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113260] FORMATTING Adding decimal place display incorrect value
https://bugs.documentfoundation.org/show_bug.cgi?id=113260 --- Comment #7 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113250] UI Navigator ('floating' version, that is in docked state) in Calc doesn't have the focus immediately after opening with F5
https://bugs.documentfoundation.org/show_bug.cgi?id=113250 --- Comment #9 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69175] FILEOPEN DOCX Wrongly formatted vertical frames
https://bugs.documentfoundation.org/show_bug.cgi?id=69175 --- Comment #10 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73499] FILEOPEN: Linked Textbox Grouping Cause partially Missing Text and Messed Layout in LO Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=73499 --- Comment #11 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 113250] UI Navigator ('floating' version, that is in docked state) in Calc doesn't have the focus immediately after opening with F5
https://bugs.documentfoundation.org/show_bug.cgi?id=113250 --- Comment #9 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
CppCheck Report Update
A new cppcheck report is available at : http://dev-builds.libreoffice.org/cppcheck_reports/master/ Note: The script generating this report was run at : 2018-21-10 02:53:45 with user buildslave at host vm140 as /home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s /home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w /home/buildslave/tmp/www It can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=cppcheck/cppcheck-report.sh ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 75509] Incorrect display of digits in default Numeric formatting of a field when language isn't English
https://bugs.documentfoundation.org/show_bug.cgi?id=75509 --- Comment #12 from Anton Abrosimov --- I can confirm this bug in LO V6.1.2, V6.1.3 with Russian langpack. You can use my Docker container for making tests and more details: https://gitlab.com/abrosimov_bug_reports/libreoffice_bug_number -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120748] New: Sidebar: Focus lost using mouse wheel in sidebar tab bar
https://bugs.documentfoundation.org/show_bug.cgi?id=120748 Bug ID: 120748 Summary: Sidebar: Focus lost using mouse wheel in sidebar tab bar Product: LibreOffice Version: 6.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rayk...@gmail.com Steps to reproduce in Writer: 1) Open a text document 2) Open Sidebar (Menu > View > Sidebar) 3) Click on Page deck tab 4) Click in Format panel Width spin box 5) Move mouse pointer over tab bar 6) Use mouse wheel to show a different deck Result: Cursor is hid in Width spin box. Test this by pressing up and down keys and observing document view width change. Expected results: Mouse wheel does not change visible deck so focus is not hid. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120747] Firefox themes: Show an image of the own theme
https://bugs.documentfoundation.org/show_bug.cgi?id=120747 andreas_k changed: What|Removed |Added CC||kain...@gmail.com --- Comment #2 from andreas_k --- yes please but I would do the same layout as for preinstalled themes in the own themes section cause you can download more than one theme from personas webpage. Theme name via tooltip as it is in preinstalled themes. So from my point of view the own theme section can have the same layout than the preinstalled themes. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 120747] Firefox themes: Show an image of the own theme
https://bugs.documentfoundation.org/show_bug.cgi?id=120747 andreas_k changed: What|Removed |Added CC||kain...@gmail.com --- Comment #2 from andreas_k --- yes please but I would do the same layout as for preinstalled themes in the own themes section cause you can download more than one theme from personas webpage. Theme name via tooltip as it is in preinstalled themes. So from my point of view the own theme section can have the same layout than the preinstalled themes. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 120703] Bugs found by PVS-Studio static analyzer
https://bugs.documentfoundation.org/show_bug.cgi?id=120703 --- Comment #14 from Commit Notification --- Mike Kaganski committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=3846561f79cf9065abd9ca83c9fbfbe7e52e28e2 tdf#120703 (PVS) It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sal/osl
sal/osl/w32/security.cxx | 106 +++
1 file changed, 63 insertions(+), 43 deletions(-)
New commits:
commit 3846561f79cf9065abd9ca83c9fbfbe7e52e28e2
Author: Mike Kaganski
AuthorDate: Sat Oct 20 22:24:26 2018 +0200
Commit: Mike Kaganski
CommitDate: Sun Oct 21 00:31:19 2018 +0200
tdf#120703 (PVS)
V522 There might be dereferencing of a potential null pointer 'pSecImpl'.
Check lines: 81, 79.
Check lines: 116, 114.
Check lines: 175, 173.
V522 There might be dereferencing of a potential null pointer
'pSecImpl->m_pNetResource'.
Check lines: 176, 175.
V701 realloc() possible leak: when realloc() fails in allocating memory,
original
pointer 'pInfoBuffer' is lost. Consider assigning realloc() to a
temporary
pointer.
V724 Converting type 'BOOL' to type 'sal_Bool' can lead to a loss of
high-order
bits. Non-zero value can become 'FALSE'.
V522 There might be dereferencing of a potential null pointer 'Ident'.
Check lines: 345, 340.
V614 Potentially uninitialized buffer 'Name' used. Consider checking the
second
actual argument of the 'rtl_uString_newFromStr' function.
Change-Id: Ieadc914d0f15e9c01621f8d7b5a7f8c0778c4498
Reviewed-on: https://gerrit.libreoffice.org/62090
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sal/osl/w32/security.cxx b/sal/osl/w32/security.cxx
index 2082301d2156..ebd3754705dd 100644
--- a/sal/osl/w32/security.cxx
+++ b/sal/osl/w32/security.cxx
@@ -77,12 +77,13 @@ static bool getUserNameImpl(oslSecurity Security,
rtl_uString **strName, bool bI
oslSecurity SAL_CALL osl_getCurrentSecurity(void)
{
oslSecurityImpl* pSecImpl = static_cast(malloc(sizeof(oslSecurityImpl)));
-
-pSecImpl->m_pNetResource = nullptr;
-pSecImpl->m_User[0] = '\0';
-pSecImpl->m_hToken = nullptr;
-pSecImpl->m_hProfile = nullptr;
-
+if (pSecImpl)
+{
+pSecImpl->m_pNetResource = nullptr;
+pSecImpl->m_User[0] = '\0';
+pSecImpl->m_hToken = nullptr;
+pSecImpl->m_hProfile = nullptr;
+}
return pSecImpl;
}
@@ -112,14 +113,15 @@ oslSecurityError SAL_CALL osl_loginUser( rtl_uString
*strUserName, rtl_uString *
))
{
oslSecurityImpl* pSecImpl = static_cast(malloc(sizeof(oslSecurityImpl)));
-
-pSecImpl->m_pNetResource = nullptr;
-pSecImpl->m_hToken = hUserToken;
-pSecImpl->m_hProfile = nullptr;
-wcscpy(o3tl::toW(pSecImpl->m_User), o3tl::toW(strUser));
-
+if (pSecImpl)
+{
+pSecImpl->m_pNetResource = nullptr;
+pSecImpl->m_hToken = hUserToken;
+pSecImpl->m_hProfile = nullptr;
+wcscpy(o3tl::toW(pSecImpl->m_User), o3tl::toW(strUser));
+}
*pSecurity = pSecImpl;
-ret = osl_Security_E_None;
+ret = pSecImpl ? osl_Security_E_None : osl_Security_E_Unknown;
}
else
{
@@ -171,17 +173,25 @@ oslSecurityError SAL_CALL
osl_loginUserOnFileServer(rtl_uString *strUserName,
if ((err == NO_ERROR) || (err == ERROR_ALREADY_ASSIGNED))
{
oslSecurityImpl* pSecImpl = static_cast(malloc(sizeof(oslSecurityImpl)));
-
-pSecImpl->m_pNetResource = static_cast(malloc(sizeof(NETRESOURCE)));
-*pSecImpl->m_pNetResource = netResource;
-
-pSecImpl->m_hToken = nullptr;
-pSecImpl->m_hProfile = nullptr;
-wcscpy(o3tl::toW(pSecImpl->m_User),
o3tl::toW(rtl_uString_getStr(strUserName)));
-
+if (pSecImpl)
+{
+pSecImpl->m_pNetResource = static_cast(malloc(sizeof(NETRESOURCE)));
+if (pSecImpl->m_pNetResource)
+{
+*pSecImpl->m_pNetResource = netResource;
+pSecImpl->m_hToken = nullptr;
+pSecImpl->m_hProfile = nullptr;
+wcscpy(o3tl::toW(pSecImpl->m_User),
o3tl::toW(rtl_uString_getStr(strUserName)));
+}
+else
+{
+free(pSecImpl);
+pSecImpl = nullptr;
+}
+}
*pSecurity = pSecImpl;
-ret = osl_Security_E_None;
+ret = pSecImpl ? osl_Security_E_None : osl_Security_E_Unknown;
}
else
{
@@ -291,7 +301,14 @@ sal_Bool SAL_CALL osl_getUserIdent(oslSecurity Security,
rtl_uString **strIdent)
{
if (GetLastError() == ERROR_INSUFFICIENT_BUFFER)
{
-pInfoBuffer = static_cast(realloc(pInfoBuffer,
nInfoBuffer));
+if (auto p = static_cast(realloc(pInfoBuffer,
nInfoBuffer)))
+pInfoBuffer = p;
+else
+{
+free(pInfoBuffer);
+pInfoBuffer = nullptr;
+break;
+}
}
else
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 15 commits - basic/source configure.ac connectivity/source sc/inc scripting/source sc/source svl/source svtools/source sw/qa sw/sourc
basic/source/runtime/dllmgr-x64.cxx|2
configure.ac |2
connectivity/source/drivers/mysqlc/mysqlc_databasemetadata.cxx |2
sc/inc/dbdata.hxx |3
sc/source/core/tool/dbdata.cxx |6 -
sc/source/ui/view/gridwin.cxx |2
scripting/source/pyprov/pythonscript.py| 30
svl/source/numbers/zformat.cxx |4 -
svtools/source/brwbox/editbrowsebox.cxx| 22 +-
sw/qa/extras/rtfexport/data/tdf112520.docx |binary
sw/qa/extras/rtfexport/rtfexport3.cxx | 21 ++
sw/qa/extras/ww8export/data/fdo53985.doc |binary
sw/qa/extras/ww8export/data/tdf37778_readonlySection.doc |binary
sw/qa/extras/ww8export/ww8export3.cxx | 34
++
sw/source/filter/ww8/rtfsdrexport.cxx | 12 ++-
sw/source/filter/ww8/rtfsdrexport.hxx |2
sw/source/filter/ww8/wrtw8sty.cxx |4 -
sw/source/filter/ww8/wrtww8.cxx| 11 ---
sw/source/filter/ww8/ww8par.cxx| 30 ++--
sw/source/uibase/docvw/edtwin2.cxx |2
xmlscript/source/xmldlg_imexp/xmldlg_export.cxx|2
21 files changed, 138 insertions(+), 53 deletions(-)
New commits:
commit 3a31948ae3f2fff1a010efe34d1fcd94e4a1829f
Author: Andras Timar
AuthorDate: Sun Oct 21 00:01:21 2018 +0200
Commit: Andras Timar
CommitDate: Sun Oct 21 00:01:21 2018 +0200
Bump version to 6.0-13
Change-Id: If4337153f8b0edb424132ab60b50dc5a89ca25ee
diff --git a/configure.ac b/configure.ac
index 07718c3e912e..c71ea1672658 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
# several non-alphanumeric characters, those are split off and used only for
the
# ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no
idea.
-AC_INIT([Collabora Office],[6.0.10.12],[],[],[https://collaboraoffice.com/])
+AC_INIT([Collabora Office],[6.0.10.13],[],[],[https://collaboraoffice.com/])
AC_PREREQ([2.59])
commit 0507a1578da0de9cebda999ec4d916d3bc8b290c
Author: Justin Luth
AuthorDate: Thu Oct 18 09:38:47 2018 +0300
Commit: Andras Timar
CommitDate: Sat Oct 20 23:00:44 2018 +0200
sw mso export: PROTECT_FORM shouldn't force section to protected
PROTECT_FORM maps to enforcement = true, not "everything is protected".
"The enforcement of this property is determined by the documentProtection
element (§17.15.1.29), as it is possible to specify protection
without turning it on."
So, sections should retain their protected on/off status
regardless of the value of PROTECT_FORM. My guess was
that this was to offset the fact that DOCX import did not
import protected status, so this helped to protect the
sections that should not be unprotected. A followup
patch will address the import side.
patch initially developed to support tdf#120499.
Change-Id: I8ff6d31711651a4827cbb8520fd68e88273d6799
Reviewed-on: https://gerrit.libreoffice.org/61905
Tested-by: Jenkins
Reviewed-by: Justin Luth
(cherry picked from commit fa667b6dc410f3af57ef436cc117352c829f95e7)
diff --git a/sw/qa/extras/ww8export/ww8export3.cxx
b/sw/qa/extras/ww8export/ww8export3.cxx
index 84f9e2f2d6cf..d5a888e60dd6 100644
--- a/sw/qa/extras/ww8export/ww8export3.cxx
+++ b/sw/qa/extras/ww8export/ww8export3.cxx
@@ -63,7 +63,6 @@ DECLARE_WW8EXPORT_TEST(testFdo53985, "fdo53985.doc")
uno::Reference xSect(xSections->getByIndex(0),
uno::UNO_QUERY);
CPPUNIT_ASSERT_EQUAL_MESSAGE("Section1 is protected", true,
getProperty(xSect, "IsProtected"));
xSect.set(xSections->getByIndex(3), uno::UNO_QUERY);
-if ( !mbExported )
CPPUNIT_ASSERT_EQUAL_MESSAGE("Section4 is protected", false,
getProperty(xSect, "IsProtected"));
}
diff --git a/sw/source/filter/ww8/wrtw8sty.cxx
b/sw/source/filter/ww8/wrtw8sty.cxx
index 30a8b68d6145..c1eb9f8cdf4c 100644
--- a/sw/source/filter/ww8/wrtw8sty.cxx
+++ b/sw/source/filter/ww8/wrtw8sty.cxx
@@ -1530,9 +1530,7 @@ void MSWordExportBase::SectionProperties( const
WW8_SepInfo& rSepInfo, WW8_PdAtt
AttrOutput().SectFootnoteEndnotePr();
// forms
-bool formProtection = m_pDoc->getIDocumentSettingAccess().get(
DocumentSettingId::PROTECT_FORM );
-formProtection |= rSepInfo.IsProtected();
-AttrOutput().SectionFormProtection( formProtection );
+AttrOutput().SectionFormProtection( rSepInfo.IsProtected() );
// line numbers
const SwLineNumberInfo& rLnNumInfo = m_pDoc->GetLineNumberInfo();
commit
[Libreoffice-bugs] [Bug 119496] LibreCalc - Cell border drawing issue, when the neighbour column is hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=119496 Telesto changed: What|Removed |Added Blocks||114934 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=114934 [Bug 114934] [META] borderline regressions -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120728] crash in report editing: insert page number in footer while header is active
https://bugs.documentfoundation.org/show_bug.cgi?id=120728 --- Comment #11 from Julien Nabet --- (In reply to Regina Henschel from comment #10) > Hi Julien, with that patch I can insert a page number field. But I think, > there is still something wrong. If a try to insert a shape, I get a crash > with the unpatched version and an assertion with your patch. Tested on > master. > Assertion failed! > Program: ..\core\instdir\program\rptuilo.dll > File: .. /Reference.h > Line:420 > > Expression: _pInterface != NULL Indeed, I could reproduce the assert with master sources + patch. I could also reproduce this with LO Debian package 6.1.3.1 so before all of my patches were there since none has been included in 6.1 branch for the moment. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120744] link to external data does not work when named range of cells containing linked formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=120744 --- Comment #11 from Edmund Laugasson --- For AppImage variant, the LibreOffice-fresh.full-x86_64.AppImage was used. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120744] link to external data does not work when named range of cells containing linked formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=120744 --- Comment #10 from Edmund Laugasson --- So, basically I started with bug-link-to-external-data-worse.ods file and made a copy of it to keep the initial file. While repeatedly opened that file (to check whether linked data works or not), there suddenly worked also that "autorefresh-linked" sheet. Then I renamed it to bug-link-to-external-data-better.ods and so I got two files with different state. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120744] link to external data does not work when named range of cells containing linked formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=120744 --- Comment #9 from Edmund Laugasson --- For LibreOffice there was an AppImage version (64-bit): Version: 6.1.2.1 Build ID: 65905a128db06ba48db947242809d14d3f9a93fe CPU threads: 2; OS: Linux 4.15; UI render: default; VCL: gtk2; Locale: et-EE (et_EE.UTF-8); Calc: group threaded user interface was in U.S. English. Log was linked to https://hub.libreoffice.org/git-core/65905a128db06ba48db947242809d14d3f9a93fe and it opened the address https://gerrit.libreoffice.org/gitweb?p=core.git=log=65905a128db06ba48db947242809d14d3f9a93fe -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120744] link to external data does not work when named range of cells containing linked formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=120744 --- Comment #8 from Edmund Laugasson --- ... 64-bit Linux Mint 19 with MATE desktop -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120744] link to external data does not work when named range of cells containing linked formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=120744 --- Comment #7 from Edmund Laugasson --- There was 64-bit Linux Mint 19 used where user student has been created and these .ods files were in testing folder, so the full path for files were: /home/student/testing/bug-link-to-external-data-better.ods /home/student/testing/bug-link-to-external-data-worse.ods Used VirtualBox 5.2.20 with appropriate extension pack installed + guest addition into virtual machine + all updates as of 20th october 2018 were also installed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120744] link to external data does not work when named range of cells containing linked formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=120744 --- Comment #6 from Edmund Laugasson --- Created attachment 145872 --> https://bugs.documentfoundation.org/attachment.cgi?id=145872=edit password formula that has been overwritten here you can see the overwritten password formula with absolute addresses -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120744] link to external data does not work when named range of cells containing linked formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=120744 --- Comment #5 from Edmund Laugasson --- Created attachment 145871 --> https://bugs.documentfoundation.org/attachment.cgi?id=145871=edit password formula that suppose to be here you can see the password formula as entered into cell -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120744] link to external data does not work when named range of cells containing linked formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=120744 --- Comment #4 from Edmund Laugasson --- Created attachment 145870 --> https://bugs.documentfoundation.org/attachment.cgi?id=145870=edit email formula that has been overwritten here you can see the overwritten email formula with absolute addresses -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120744] link to external data does not work when named range of cells containing linked formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=120744 --- Comment #3 from Edmund Laugasson --- Created attachment 145869 --> https://bugs.documentfoundation.org/attachment.cgi?id=145869=edit email formula that suppose to be here is the email formula as it was entered into cell -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120744] link to external data does not work when named range of cells containing linked formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=120744 --- Comment #2 from Edmund Laugasson --- Created attachment 145868 --> https://bugs.documentfoundation.org/attachment.cgi?id=145868=edit here will be #REF! shown for linked data Here you can see #REF! instead of proper output in sheet "autorefresh-linked". Still there is a warning message "Automatic update of external links has been disabled". Actually nothing has been disabled. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120744] link to external data does not work when named range of cells containing linked formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=120744 --- Comment #1 from Edmund Laugasson --- Created attachment 145867 --> https://bugs.documentfoundation.org/attachment.cgi?id=145867=edit linked data autorefresh even works regardless of warning message here on sheet "autorefresh-linked" the autorefreshing even works regardless of warning message "Automatic update of external links has been disabled" even from LibreOffice settings there is "Update links when opening" set to "Always (from trusted locations)" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3-desktop' - 2 commits - configure.ac scripting/source
configure.ac|2 +-
scripting/source/pyprov/pythonscript.py | 30 --
2 files changed, 29 insertions(+), 3 deletions(-)
New commits:
commit 6201ab17a66ce552e0a0d647a4c04ad64d3dd56b
Author: Andras Timar
AuthorDate: Sat Oct 20 23:23:17 2018 +0200
Commit: Andras Timar
CommitDate: Sat Oct 20 23:23:17 2018 +0200
Bump version to 5.3-58
Change-Id: I466c8a5c7ac025751179f3eca6d4223589abad4a
diff --git a/configure.ac b/configure.ac
index 0df4964221eb..7b11377cad1a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
# several non-alphanumeric characters, those are split off and used only for
the
# ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no
idea.
-AC_INIT([Collabora Office],[5.3.10.57],[],[],[https://collaboraoffice.com/])
+AC_INIT([Collabora Office],[5.3.10.58],[],[],[https://collaboraoffice.com/])
AC_PREREQ([2.59])
commit a9d81dd30d809b9c5ce2d3e4752039f19be70494
Author: Caolán McNamara
AuthorDate: Thu Oct 18 20:39:23 2018 +0100
Commit: Andras Timar
CommitDate: Sat Oct 20 23:22:37 2018 +0200
keep pyuno script processing below base uri
Change-Id: Icc13fb7193fb1e7c50e0df286161a10b4ed636c7
Reviewed-on: https://gerrit.libreoffice.org/61969
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
(cherry picked from commit b1c85cdb37a47998f8ab135fbc96f186334b171c)
diff --git a/scripting/source/pyprov/pythonscript.py
b/scripting/source/pyprov/pythonscript.py
index e312c6a52fbf..a2c9e70f9d54 100644
--- a/scripting/source/pyprov/pythonscript.py
+++ b/scripting/source/pyprov/pythonscript.py
@@ -25,6 +25,7 @@ import imp
import time
import ast
import platform
+from com.sun.star.uri.RelativeUriExcessParentSegments import RETAIN
try:
unicode
@@ -212,8 +213,33 @@ class MyUriHelper:
def scriptURI2StorageUri( self, scriptURI ):
try:
-myUri = self.m_uriRefFac.parse(scriptURI)
-ret = self.m_baseUri + "/" + myUri.getName().replace( "|", "/" )
+# base path to the python script location
+sBaseUri = self.m_baseUri + "/"
+xBaseUri = self.m_uriRefFac.parse(sBaseUri)
+
+# path to the .py file + "$functionname, arguments, etc
+xStorageUri = self.m_uriRefFac.parse(scriptURI)
+sStorageUri = xStorageUri.getName().replace( "|", "/" );
+
+# path to the .py file, relative to the base
+sFileUri = sStorageUri[0:sStorageUri.find("$")]
+xFileUri = self.m_uriRefFac.parse(sFileUri)
+if not xFileUri:
+message = "pythonscript: invalid relative uri '" + sFileUri+
"'"
+log.debug( message )
+raise RuntimeException( message )
+
+# absolute path to the .py file
+xAbsScriptUri = self.m_uriRefFac.makeAbsolute(xBaseUri, xFileUri,
True, RETAIN)
+sAbsScriptUri = xAbsScriptUri.getUriReference()
+
+# ensure py file is under the base path
+if not sAbsScriptUri.startswith(sBaseUri):
+message = "pythonscript: storage uri '" + sAbsScriptUri + "'
not in base uri '" + self.m_baseUri + "'"
+log.debug( message )
+raise RuntimeException( message )
+
+ret = sBaseUri + sStorageUri
log.debug( "converting scriptURI="+scriptURI + " to storageURI=" +
ret )
return ret
except UnoException as e:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120744] New: link to external data does not work when named range of cells containing linked formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=120744 Bug ID: 120744 Summary: link to external data does not work when named range of cells containing linked formulas Product: LibreOffice Version: 6.1.2.1 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: edmund.laugas...@gmail.com Description: when named range of cells containing linked formulas from other sheets then #REF! will be displayed instead of linked data Steps to Reproduce: 1. create an .ods file with formulas that contain both linked and direct data 2. add name to range of cells both linked and direct data 3. add externally linked data to separate sheet both linked and direct data Actual Results: Formulas are overwritten with absolute path and therefore named cell range with linked data does not work anymore - formulas will be broken. Expected Results: Formulas are NOT overwritten and named cell range with linked data works like cell range with non-linked data. When data is located in same file there is no point to use absolute path in formulas if it is the same file. Possibly there could be the choice "Sheet->Link to internal data..." where I can choose named range cell(s) in same file - that seems to be solve such issue. Reproducible: Always User Profile Reset: No Additional Info: When adding external linked data, also dead links are created with no element. Actually https://help.libreoffice.org/6.1/en-US/text/shared/01/0218.html?System=UNIX=CALC#bm_id48899801 says that Element means "Lists the application (if known) that last saved the source file" but this is not true. The Element is actually the named cell range that has been used when external data link was created. Later I can change that named cell range by choosing "Edit->Links to External Files..." and after selecting appropriate line, click Modify... button and there is possible to change "Available Tables/Ranges" what are exactly those named range of cells. So - please fix also help text. In addition "Edit->Links to External Files..." shows dead link with no Element referred. Possibly also such dead links are causing issue(s). In addition while opening such file, the warning message "Automatic update of external links has been disabled" will be displayed. When trying to click "Enable Content" then message "The following external file could not be loaded. Data linked from this file did not get updated" and then gives full path to file, e.g. file:///home/student/testing/bug-link-to-external-data.ods and only choice is OK button. At the same time all data is updated as needed. Randomly it shows #REF! and then again not in tab "autorefresh-linked". Actually before I click "Enable", I see #REF! and after that warning message "The following external file could not be loaded. Data linked from this file did not get updated" when I click "Enable Content", I suddenly see linked data properly. When repeatedly opened the file - I did not even need to click "Enable Content" - formulas worked even with linked data. But occasionally there are #REF! on sheet "autorefresh-linked". At the same time "Tools->Options->LibreOffice Calc->General->Update links when opening->Always (from trusted locations)" was selected but did not have effect for "Automatic update of external links has been disabled" message. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120740] New: Pasted Screenshots Appear Much Bigger Than their Original
https://bugs.documentfoundation.org/show_bug.cgi?id=120740 Bug ID: 120740 Summary: Pasted Screenshots Appear Much Bigger Than their Original Product: LibreOffice Version: 5.1.6.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: adalbert.hans...@gmx.de This bug report pertains to LiberOffice Writer, Version: 5.1.6.2, Build-ID: 1:5.1.6~rc2-0ubuntu1~xenial4, CPU-Threads: 4; BS-Version: Linux 4.4; UI-Render: Standard; Gebietsschema: de-DE (de_DE.UTF-8); Calc: group. The program runs under Xubuntu 16.04.3 LTS with current linux kernel version 4.4.0-116-generic x86_64 but it might be present in later versions too, which I did not check. I often take notes of how I managed things on my computer by taking screen shots and paste them to my log file. However, I always have to reduce the size of the images pasted from the clipboard to something like 0.5. I would prefer if the size of the picture (especially if it is a picture from the clipboard) would be the same as before by default. If this can not be done automatically by looking at the number of dots per inch of my computer and the pixel dimensions of the image on the clipboard, I would like to be able to set a general “pasting factor” or a “dots per inch” factor for my screen or something of that kind. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120728] crash in report editing: insert page number in footer while header is active
https://bugs.documentfoundation.org/show_bug.cgi?id=120728 --- Comment #10 from Regina Henschel --- Hi Julien, with that patch I can insert a page number field. But I think, there is still something wrong. If a try to insert a shape, I get a crash with the unpatched version and an assertion with your patch. Tested on master. Assertion failed! Program: ..\core\instdir\program\rptuilo.dll File: .. /Reference.h Line:420 Expression: _pInterface != NULL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120738] Unresponsive document when switching to webview & high CPU usage
https://bugs.documentfoundation.org/show_bug.cgi?id=120738 Jean-Baptiste Faure changed: What|Removed |Added CC||jbfa...@libreoffice.org --- Comment #1 from Jean-Baptiste Faure --- Not sure if there is a bug: switching to webview require a lot of changes in the layout, only 7 pages, note numbering to redo. When the document is ready to edit, I do not experience any lag when modifying the text. Version: 6.2.0.0.alpha0+ Build ID: aa3b2f90a62678c8e594830277a32e3ad742e826 Threads CPU : 4; OS : Linux 4.15; UI Render : par défaut; VCL: gtk3; Ubuntu_18.04_x86-64 Locale : fr-FR (fr_FR.UTF-8); Calc: threaded Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120739] User unfriendly Positioning of the Table (Numbering) Toolbar which Moves the Search Tool Up when a Match is Found Within a Table
https://bugs.documentfoundation.org/show_bug.cgi?id=120739 --- Comment #1 from Adalbert Hanßen --- Created attachment 145864 --> https://bugs.documentfoundation.org/attachment.cgi?id=145864=edit search tool pushed up by table tool after a match in a search happens to be within a table. Changing the paragraph's formatting is probable if one blindly clicks again on where the up or down arrow wa -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120669] When using LTR and RTL texts on mac, the flow is faulty
https://bugs.documentfoundation.org/show_bug.cgi?id=120669 Khaled Hosny changed: What|Removed |Added Resolution|DUPLICATE |NOTABUG --- Comment #3 from Khaled Hosny --- The paragraph in your document has its direction set to left to right not right to left, though it is right aligned. You need to change that to get the right text order. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120739] New: User unfriendly Positioning of the Table (Numbering) Toolbar which Moves the Search Tool Up when a Match is Found Within a Table
https://bugs.documentfoundation.org/show_bug.cgi?id=120739 Bug ID: 120739 Summary: User unfriendly Positioning of the Table (Numbering) Toolbar which Moves the Search Tool Up when a Match is Found Within a Table Product: LibreOffice Version: 5.1.6.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: adalbert.hans...@gmx.de This bug report pertains to LiberOffice Writer, Version: 5.1.6.2, Build-ID: 1:5.1.6~rc2-0ubuntu1~xenial4, CPU-Threads: 4; BS-Version: Linux 4.4; UI-Render: Standard; Gebietsschema: de-DE (de_DE.UTF-8); Calc: group. The program runs under Xubuntu 16.04.3 LTS with current linux kernel version 4.4.0-116-generic x86_64 but it might be present in later versions too, which I did not check. When I do a search I often use the little box which shows up at the bottom left after I pres Ctl-F. I frequently use the up and down arrows next to the search term to go to the next or last match. However, if a match happens to be inside a table, a numbering tool bar (which is not checked in the list of tool bars) shows up. Unfortunately it goes beneath the search tool and pushes it up by one line. However, if one searches for search terms, attention is targeted on the document rather than the position of the search tool on the screen. If I click again on the same position on the screen, I click on one of the numbering tools of the table bar which has taken the space previously occupied by the search tool! That’s quite nasty. I was given the hint to actively position the table (numbering) tool bar vertically to the left border of the LO Writer window. That is a good work around. But a better solution would be to define the “factory setting” for the table and numbering tool bar such that it never gets into conflict with the search tool bar according to the “factory setting”. One other nasty thing with the search tool: By default it works in wrap around mode, i.e. when there is no more match in the selected search direction, it rewinds to the beginning of the file and continues search in the old direction if it was a forward search or it jumps to the very end of the file to continue the backward search from there. That’s also very clumsy because one has to observe the position of the elevator in the scroll bar. My attention however is on the found match and its surroundings. At least there should be an audible signal if wrap around happens in any search direction. But as I often have to switch off the loudspeaker of my PC in order to not disturb the other people around, it would be better to be able to prevent wrap around all together. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: winaccessibility/source
winaccessibility/source/UAccCOM/AccTable.cxx |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) New commits: commit cc21f1ab22328ddf2bd82a77d81dbee69c847e5e Author: Caolán McNamara AuthorDate: Fri Oct 19 14:11:56 2018 +0100 Commit: Caolán McNamara CommitDate: Sat Oct 20 21:51:46 2018 +0200 dubious SysAllocString check Change-Id: I1aece8321b12351b5e8a2d5c33e513531cbc95a1 Reviewed-on: https://gerrit.libreoffice.org/62007 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/winaccessibility/source/UAccCOM/AccTable.cxx b/winaccessibility/source/UAccCOM/AccTable.cxx index dcd4ad2d65d7..6a872b277dc0 100644 --- a/winaccessibility/source/UAccCOM/AccTable.cxx +++ b/winaccessibility/source/UAccCOM/AccTable.cxx @@ -132,9 +132,9 @@ STDMETHODIMP CAccTable::get_columnDescription(long column, BSTR * description) const ::rtl::OUString& ouStr = GetXInterface()->getAccessibleColumnDescription(column); // #CHECK# -SAFE_SYSFREESTRING(*description);//?? +SAFE_SYSFREESTRING(*description); *description = SysAllocString(o3tl::toW(ouStr.getStr())); -if(description==nullptr) +if (*description==nullptr) return E_FAIL; return S_OK; @@ -353,9 +353,8 @@ STDMETHODIMP CAccTable::get_rowDescription(long row, BSTR * description) SAFE_SYSFREESTRING(*description); *description = SysAllocString(o3tl::toW(ouStr.getStr())); -if(description==nullptr) +if (*description==nullptr) return E_FAIL; - return S_OK; LEAVE_PROTECTED_BLOCK ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120703] Bugs found by PVS-Studio static analyzer
https://bugs.documentfoundation.org/show_bug.cgi?id=120703 --- Comment #13 from Commit Notification --- Mike Kaganski committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9f8f804f089a40fc2fc0b43690a4b9d529217d32 tdf#120703 (PVS) It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: winaccessibility/source
winaccessibility/source/UAccCOM/MAccessible.cxx | 52
winaccessibility/source/UAccCOM/MAccessible.h |8 +--
2 files changed, 32 insertions(+), 28 deletions(-)
New commits:
commit 9f8f804f089a40fc2fc0b43690a4b9d529217d32
Author: Mike Kaganski
AuthorDate: Sat Oct 20 14:51:58 2018 +0200
Commit: Mike Kaganski
CommitDate: Sat Oct 20 21:39:48 2018 +0200
tdf#120703 (PVS)
V745 A 'wchar_t *' type string is incorrectly converted to 'BSTR' type
string.
Consider using 'SysAllocString' function.
V560 A part of conditional expression is always false: !ppdispParent.
V595 The 'm_pIParent' pointer was utilized before it was verified against
nullptr.
Check lines: 673, 675.
V745 A 'wchar_t *' type string is incorrectly converted to 'BSTR' type
string.
Consider using 'SysAllocString' function.
V530 The return value of function 'SysAllocString' is required to be
utilized.
V1032 The pointer '& pChildXAcc' is cast to a more strictly aligned pointer
type.
V512 A call of the 'GetUNOInterface' function will lead to overflow of the
buffer
'& pChildXAcc'.
V547 Expression 'pSeq' is always true.
V547 Expression 'pChild' is always true.
V512 A call of the 'GetUNOInterface' function will lead to overflow of the
buffer
'& pTempUNO'.
V1032 The pointer '& pTempUNO' is cast to a more strictly aligned pointer
type.
V716 Suspicious type conversion in return statement: returned HRESULT, but
function
actually returns BOOL.
Change-Id: I2185992dad0127144416783e25476d05c0365b74
Reviewed-on: https://gerrit.libreoffice.org/62075
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/winaccessibility/source/UAccCOM/MAccessible.cxx
b/winaccessibility/source/UAccCOM/MAccessible.cxx
index 1801cf61929e..8c7f4fa6aec1 100644
--- a/winaccessibility/source/UAccCOM/MAccessible.cxx
+++ b/winaccessibility/source/UAccCOM/MAccessible.cxx
@@ -195,23 +195,19 @@ CMAccessible::~CMAccessible()
if(m_pszName!=nullptr)
{
SAFE_SYSFREESTRING(m_pszName);
-m_pszName=nullptr;
}
if(m_pszValue!=nullptr)
{
SAFE_SYSFREESTRING(m_pszValue);
-m_pszValue=nullptr;
}
if(m_pszDescription!=nullptr)
{
SAFE_SYSFREESTRING(m_pszDescription);
-m_pszDescription=nullptr;
}
if(m_pszActionDescription!=nullptr)
{
SAFE_SYSFREESTRING(m_pszActionDescription);
-m_pszActionDescription=nullptr;
}
if(m_pIParent)
@@ -252,7 +248,7 @@ STDMETHODIMP CMAccessible::get_accParent(IDispatch
**ppdispParent)
else if(m_hwnd)
{
HRESULT hr = AccessibleObjectFromWindow(m_hwnd, OBJID_WINDOW,
IID_IAccessible, reinterpret_cast(ppdispParent));
-if( ! SUCCEEDED( hr ) || ! ppdispParent )
+if (!SUCCEEDED(hr) || !*ppdispParent)
{
return S_FALSE;
}
@@ -671,9 +667,9 @@ STDMETHODIMP CMAccessible::get_accKeyboardShortcut(VARIANT
varChild, BSTR *pszKe
VARIANT varParentRole;
VariantInit( );
-m_pIParent->get_accRole(varChild, );
-
-if( m_pIParent && varParentRole.lVal ==
ROLE_SYSTEM_COMBOBOX ) // edit in comboBox
+if (m_pIParent
+&& SUCCEEDED(m_pIParent->get_accRole(varChild,
))
+&& varParentRole.lVal == ROLE_SYSTEM_COMBOBOX)
// edit in comboBox
{
m_pIParent->get_accKeyboardShortcut(varChild,
pszKeyboardShortcut);
return S_OK;
@@ -1436,7 +1432,10 @@ IMAccessible*
CMAccessible::GetNavigateChildForDM(VARIANT varCur, short flags)
}
IMAccessible* pCurChild = nullptr;
-XAccessible* pChildXAcc = nullptr;
+union {
+XAccessible* pChildXAcc;
+hyper nHyper = 0;
+};
Reference pRChildXAcc;
XAccessibleContext* pChildContext = nullptr;
int index = 0,delta=0;
@@ -1455,7 +1454,7 @@ IMAccessible* CMAccessible::GetNavigateChildForDM(VARIANT
varCur, short flags)
{
return nullptr;
}
-pCurChild->GetUNOInterface(reinterpret_cast());
+pCurChild->GetUNOInterface();
if(pChildXAcc==nullptr)
{
return nullptr;
@@ -1907,12 +1906,11 @@ STDMETHODIMP CMAccessible:: get_groupPosition(long
__RPC_FAR *groupLevel,long __
if ( xGroupPosition.is() )
{
Sequence< sal_Int32 > rSeq = xGroupPosition->getGroupPosition(
makeAny( pRContext ) );
-sal_Int32* pSeq = rSeq.getArray();
-if ( pSeq )
+if (rSeq.getLength() >= 3)
{
-
[Libreoffice-bugs] [Bug 120736] Automatic update of external links has been disabled
https://bugs.documentfoundation.org/show_bug.cgi?id=120736 --- Comment #3 from Edmund Laugasson --- The last information after some testing is that even the sharing plays no role. While added linked data to same sheet where named cell block locates, saved document and when reopening - it says a warning message "Automatic update of external links has been disabled" regardless of Tools->Options->LibreOffice Calc->General->Update links when opening->Always (from trusted locations) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/doc/sfxbasemodel.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit f93e29fe7e1207825520b145d8b6c48c958d2ab7
Author: Caolán McNamara
AuthorDate: Fri Oct 19 17:45:01 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 20 21:23:00 2018 +0200
const this up
Change-Id: I878ba62345925a8396b0b2a5f38f069148c8a6b5
Reviewed-on: https://gerrit.libreoffice.org/62071
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sfx2/source/doc/sfxbasemodel.cxx b/sfx2/source/doc/sfxbasemodel.cxx
index e29eb13f37e1..c1953d91739c 100644
--- a/sfx2/source/doc/sfxbasemodel.cxx
+++ b/sfx2/source/doc/sfxbasemodel.cxx
@@ -2101,7 +2101,7 @@ Sequence< datatransfer::DataFlavor > SAL_CALL
SfxBaseModel::getTransferDataFlavo
{
SfxModelGuard aGuard( *this );
-sal_Int32 nSuppFlavors = GraphicHelper::supportsMetaFileHandle_Impl() ? 10
: 8;
+const sal_Int32 nSuppFlavors =
GraphicHelper::supportsMetaFileHandle_Impl() ? 10 : 8;
Sequence< datatransfer::DataFlavor > aFlavorSeq( nSuppFlavors );
aFlavorSeq[0].MimeType =
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svl/source
svl/source/svdde/ddesvr.cxx | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
New commits:
commit aa3b2f90a62678c8e594830277a32e3ad742e826
Author: Caolán McNamara
AuthorDate: Fri Oct 19 17:42:40 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 20 20:47:29 2018 +0200
result of DdeQueryStringW unused
since
commit 88e3b846b8a4bd4ce5507d1bc5441ee4167e5326
Date: Wed Apr 6 11:28:44 2016 +0200
remove some dead bits of DDE
Change-Id: I66b2f8365e3fed15391ff0fe2eb3c874b5054e91
Reviewed-on: https://gerrit.libreoffice.org/62070
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/svl/source/svdde/ddesvr.cxx b/svl/source/svdde/ddesvr.cxx
index e79f26063237..1848342b893b 100644
--- a/svl/source/svdde/ddesvr.cxx
+++ b/svl/source/svdde/ddesvr.cxx
@@ -356,29 +356,14 @@ DdeTopic* DdeInternal::FindTopic( DdeService& rService,
HSZ hTopic )
{
std::vector::iterator iter;
std::vector = rService.aTopics;
-bool bContinue = false;
DdeInstData* pInst = ImpGetInstData();
assert(pInst);
-do
-{ // middle check loop
-for ( iter = rTopics.begin(); iter != rTopics.end(); ++iter )
-{
-if ( *(*iter)->pName == hTopic )
-return *iter;
-}
-
-bContinue = !bContinue;
-if( !bContinue )
-break;
-
-// Let's query our subclass
-WCHAR chBuf[250];
-
DdeQueryStringW(pInst->hDdeInstSvr,hTopic,chBuf,SAL_N_ELEMENTS(chBuf),CP_WINUNICODE
);
-bContinue = false;
-// We need to search again
+for ( iter = rTopics.begin(); iter != rTopics.end(); ++iter )
+{
+if ( *(*iter)->pName == hTopic )
+return *iter;
}
-while( bContinue );
return nullptr;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 108598] FORMATTING Row height is changed or not changed wrongly
https://bugs.documentfoundation.org/show_bug.cgi?id=108598 --- Comment #5 from stefan_lange...@t-online.de --- Correction: The sentence in Comment_4 related the test with LODev 6.2 must be: When test document "Test_Zeilenhöhe_orh_0.ods" is opened the height of rows 73, 75 etc. in sheet "Altix IV und V" is already decreased. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108598] FORMATTING Row height is changed or not changed wrongly
https://bugs.documentfoundation.org/show_bug.cgi?id=108598 --- Comment #4 from stefan_lange...@t-online.de --- The bug is still present, tested with Version: 6.1.3.1 (x64) Build-ID: a9670562c26181ec3afbe381c9ff499ae88c98b7 CPU-Threads: 4; BS: Windows 10.0; UI-Render: GL; Gebietsschema: de-DE (de_DE); Calc: CL and with Version: 6.1.4.0.0+ (x64) Build-ID: 67c65aa21335cf28aca2e92a9fa2f180aa800ea6 CPU-Threads: 4; BS: Windows 10.0; UI-Render: GL; TinderBox: Win-x86_64@62-TDF, Branch:libreoffice-6-1, Time: 2018-10-19_02:44:05 Gebietsschema: de-DE (de_DE); Calc: CL In Version: 6.2.0.0.alpha0+ (x64) Build ID: 6baca63b44bf7f75a522b1adc4b4bbce502aec3b CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-10-20_01:35:41 Locale: de-DE (de_DE); Calc: CL the bug exists in modified version: When test document "Test_Zeilenhöhe_orh_0.ods" is opened the height of rows 73, 75 etc. in sheet "Altix IV und V" is akready. After the height of all rows in the sheet except the header rows is "optimized" by Format - Rows - Optimal height the bug can by reproduced as described. The bug cannot be reproduced with LO 3.3, LO 4.0, LO 5.0 and also not with Version: 5.2.6.2 (x64) Build-ID: a3100ed2409ebf1c212f5048fbe377c281438fdc CPU-Threads: 4; BS-Version: Windows 6.19; UI-Render: GL; Gebietsschema: de-DE (de_DE); Calc: CL I.e. the bug was "introduced" between LO 5.2.6 and 5.3.3, see Comment_2! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: winaccessibility/source
winaccessibility/source/service/AccObject.cxx | 92 --
1 file changed, 43 insertions(+), 49 deletions(-)
New commits:
commit 974f3183221130bfdf93eb8821539a5554909e5c
Author: Caolán McNamara
AuthorDate: Fri Oct 19 17:26:48 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 20 20:28:20 2018 +0200
pvs-studio: pointer was utilized before it was verified against nullptr
Change-Id: Ib677c60019f7ce7d26809e50489f04a457b4c224
Reviewed-on: https://gerrit.libreoffice.org/62066
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/winaccessibility/source/service/AccObject.cxx
b/winaccessibility/source/service/AccObject.cxx
index abcaaf7c2a67..608a1978409c 100644
--- a/winaccessibility/source/service/AccObject.cxx
+++ b/winaccessibility/source/service/AccObject.cxx
@@ -872,43 +872,40 @@ void AccObject::UpdateState()
short Role = m_accRole;
-if( m_pIMAcc )
+switch(m_accRole)
{
-switch(m_accRole)
+case LABEL:
+case STATIC:
+m_pIMAcc->IncreaseState( STATE_SYSTEM_READONLY );
+break;
+case TEXT:
+// 2. editable combobox -> readonly -- bridge
+case EMBEDDED_OBJECT:
+case END_NOTE:
+case FOOTER:
+case FOOTNOTE:
+case GRAPHIC:
+case HEADER:
+case HEADING:
+
+//Image Map
+case PARAGRAPH:
+case PASSWORD_TEXT:
+case SHAPE:
+case SPIN_BOX:
+case TABLE:
+case TABLE_CELL:
+case TEXT_FRAME:
+case DATE_EDITOR:
+case DOCUMENT:
+case COLUMN_HEADER:
{
-case LABEL:
-case STATIC:
-m_pIMAcc->IncreaseState( STATE_SYSTEM_READONLY );
-break;
-case TEXT:
-// 2. editable combobox -> readonly -- bridge
-case EMBEDDED_OBJECT:
-case END_NOTE:
-case FOOTER:
-case FOOTNOTE:
-case GRAPHIC:
-case HEADER:
-case HEADING:
-
-//Image Map
-case PARAGRAPH:
-case PASSWORD_TEXT:
-case SHAPE:
-case SPIN_BOX:
-case TABLE:
-case TABLE_CELL:
-case TEXT_FRAME:
-case DATE_EDITOR:
-case DOCUMENT:
-case COLUMN_HEADER:
-{
-if(!isEditable)
-m_pIMAcc->IncreaseState( STATE_SYSTEM_READONLY );
-}
-break;
-default:
-break;
+if(!isEditable)
+m_pIMAcc->IncreaseState( STATE_SYSTEM_READONLY );
}
+break;
+default:
+break;
}
if( isEnable )
@@ -970,24 +967,21 @@ void AccObject::UpdateState()
}
}
-if( m_pIMAcc )
+switch(m_accRole)
{
-switch(m_accRole)
-{
-case POPUP_MENU:
-case MENU:
-if( pContext->getAccessibleChildCount() > 0 )
-m_pIMAcc->IncreaseState( STATE_SYSTEM_HASPOPUP );
-break;
-case PASSWORD_TEXT:
-m_pIMAcc->IncreaseState( STATE_SYSTEM_PROTECTED );
-break;
-default:
-break;
-}
+case POPUP_MENU:
+case MENU:
+if( pContext->getAccessibleChildCount() > 0 )
+m_pIMAcc->IncreaseState( STATE_SYSTEM_HASPOPUP );
+break;
+case PASSWORD_TEXT:
+m_pIMAcc->IncreaseState( STATE_SYSTEM_PROTECTED );
+break;
+default:
+break;
}
-
}
+
/**
* update location information from uno to com
* @param
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: winaccessibility/source
winaccessibility/source/service/AccDescendantManagerEventListener.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit a8a0d0fa151aee294fc3744c6fbc0729b2a7bcee
Author: Caolán McNamara
AuthorDate: Fri Oct 19 17:32:06 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 20 20:28:03 2018 +0200
pvs-studio: pointer was utilized before it was verified against nullptr
Change-Id: I601d30f8222f7c666eab4727c84e612484e01eed
Reviewed-on: https://gerrit.libreoffice.org/62067
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git
a/winaccessibility/source/service/AccDescendantManagerEventListener.cxx
b/winaccessibility/source/service/AccDescendantManagerEventListener.cxx
index 3f865cd2e27d..c8fc771ae503 100644
--- a/winaccessibility/source/service/AccDescendantManagerEventListener.cxx
+++ b/winaccessibility/source/service/AccDescendantManagerEventListener.cxx
@@ -183,7 +183,7 @@ bool
AccDescendantManagerEventListener::NotifyChildEvent(short nWinEvent,const A
XAccessible* pAcc = xChild.get();
pAgent->NotifyAccEvent(nWinEvent, pAcc);
-if (pAgent && pAgent->IsStateManageDescendant(m_xAccessible.get())
+if (pAgent->IsStateManageDescendant(m_xAccessible.get())
&& (nWinEvent == UM_EVENT_SELECTION_CHANGED_REMOVE))
{
pAgent->DeleteAccObj( pAcc );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120719] Export all settings
https://bugs.documentfoundation.org/show_bug.cgi?id=120719 V Stuart Foote changed: What|Removed |Added CC||s.mehrbr...@gmail.com, ||vstuart.fo...@utsa.edu --- Comment #4 from V Stuart Foote --- How would this be different than what *already* is provided via SafeMode dialog? Perhaps another button to call that UNO command for launching profileexporteddialog.ui https://gerrit.libreoffice.org/#/c/30479 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120733] The blue 'Insert header/footer' popup doesn't appear
https://bugs.documentfoundation.org/show_bug.cgi?id=120733 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG --- Comment #1 from V Stuart Foote --- Optionally enabled now from Insert -> Header and Footer select "User header/footer menu" See bug 118621 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120736] Automatic update of external links has been disabled
https://bugs.documentfoundation.org/show_bug.cgi?id=120736 --- Comment #2 from Edmund Laugasson --- Also wanted to mention that when such situation occur where .ods with externally linked data and shared mode is open and trying to unshare then it will not work - still remains shared. Deleting the external data linking from Edit->Links to external files... and then unsharing but still it will not turn off the sharing (next to filename in title bar still (shared) is written). But when hitting to Save then it says "This spreadsheet is no longer in shared mode" and only choice is OK and it asks to save under new name but I would like to not create yet another file but just turn off sharing and/or also linking if needed. Actually by turning off the sharing should be enough. But it seems that once the sharing is enabled while external data linking is enabled, it breaks something and there seems to be no way back to turn off sharing anymore. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120733] The blue 'Insert header/footer' popup doesn't appear
https://bugs.documentfoundation.org/show_bug.cgi?id=120733 --- Comment #2 from Telesto --- I'm missed that one :-). Thanks -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120730] Make the Ω preset favorite characters list the same as Microsoft Office.
https://bugs.documentfoundation.org/show_bug.cgi?id=120730 V Stuart Foote changed: What|Removed |Added Summary|The Ω preset symbol is the |Make the Ω preset favorite |same as Microsoft Office. |characters list the same as ||Microsoft Office. Status|UNCONFIRMED |RESOLVED CC||vstuart.fo...@utsa.edu Resolution|--- |WONTFIX --- Comment #3 from V Stuart Foote --- Favorites bar is customizable and recorded per user to profile, remove any unwanted. Add any missing. Max of 16 slots. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/win
vcl/win/gdi/gdiimpl.cxx | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
New commits:
commit 5d0b961b1962474fd5c5be9a6a064114a710bc1b
Author: Caolán McNamara
AuthorDate: Fri Oct 19 17:34:39 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 20 19:55:51 2018 +0200
use std::unique_ptr
Change-Id: I8645d1d0776f7b7f2cd6e6d18f387210c6e126d9
Reviewed-on: https://gerrit.libreoffice.org/62068
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/vcl/win/gdi/gdiimpl.cxx b/vcl/win/gdi/gdiimpl.cxx
index 3962c4d4a52d..1ba590cc803e 100644
--- a/vcl/win/gdi/gdiimpl.cxx
+++ b/vcl/win/gdi/gdiimpl.cxx
@@ -579,14 +579,14 @@ void ImplDrawBitmap( HDC hDC, const SalTwoRect& rPosAry,
const WinSalBitmap& rSa
{
HGLOBAL hDrawDIB;
HBITMAP hDrawDDB = rSalBitmap.ImplGethDDB();
-WinSalBitmap* pTmpSalBmp = nullptr;
+std::unique_ptr xTmpSalBmp;
boolbPrintDDB = ( bPrinter && hDrawDDB );
if( bPrintDDB )
{
-pTmpSalBmp = new WinSalBitmap;
-pTmpSalBmp->Create( rSalBitmap, rSalBitmap.GetBitCount() );
-hDrawDIB = pTmpSalBmp->ImplGethDIB();
+xTmpSalBmp.reset(new WinSalBitmap);
+xTmpSalBmp->Create( rSalBitmap, rSalBitmap.GetBitCount() );
+hDrawDIB = xTmpSalBmp->ImplGethDIB();
}
else
hDrawDIB = rSalBitmap.ImplGethDIB();
@@ -670,9 +670,6 @@ void ImplDrawBitmap( HDC hDC, const SalTwoRect& rPosAry,
const WinSalBitmap& rSa
ImplReleaseCachedDC( CACHED_HDC_DRAW );
}
-
-if( bPrintDDB )
-delete pTmpSalBmp;
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120738] New: Unresponsive document when switching to webview & high CPU usage
https://bugs.documentfoundation.org/show_bug.cgi?id=120738 Bug ID: 120738 Summary: Unresponsive document when switching to webview & high CPU usage Product: LibreOffice Version: 4.1.0.4 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Unresponsive document when switching to webview & high CPU usage Steps to Reproduce: 1. Open attachment 145863 2. Switch to webview -> monitor CPU usage 3. Make some edits to for the experience Actual Results: High CPU usage and slow Expected Results: Better performance Reproducible: Always User Profile Reset: No Additional Info: Found in Version: 6.2.0.0.alpha0+ Build ID: b63d48a146c3615f56b6ec83361b3c02ebcbb215 CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2018-10-13_23:33:20 Locale: nl-NL (nl_NL); Calc: CL Versie: 4.1.0.4 Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - xmloff/source xmlsecurity/source
xmloff/source/style/xmlexppr.cxx |6 ---
xmloff/source/style/xmlnumfe.cxx |8 ++--
xmloff/source/style/xmlnumfi.cxx | 32 ++---
xmloff/source/style/xmlnumi.cxx|5 --
xmloff/source/text/txtparai.cxx| 10 ++---
xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx |7 +--
6 files changed, 25 insertions(+), 43 deletions(-)
New commits:
commit 2efbeea3f2625f62e08e78789de25ca5783d5e5d
Author: Caolán McNamara
AuthorDate: Fri Oct 19 16:39:06 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 20 19:54:20 2018 +0200
pvs-studio: loop-variable-too-small
Change-Id: Ie4aafecd17cf53ab3cbab2003b59da374d06e06b
Reviewed-on: https://gerrit.libreoffice.org/62058
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/xmloff/source/style/xmlexppr.cxx b/xmloff/source/style/xmlexppr.cxx
index 4f8292ed26dd..5cb4f9b02e1d 100644
--- a/xmloff/source/style/xmlexppr.cxx
+++ b/xmloff/source/style/xmlexppr.cxx
@@ -999,13 +999,9 @@ void SvXMLExportPropertyMapper::exportElementItems(
SvXmlExportFlags nFlags,
const std::vector& rIndexArray ) const
{
-const sal_uInt16 nCount = rIndexArray.size();
-
bool bItemsExported = false;
-for( sal_uInt16 nIndex = 0; nIndex < nCount; nIndex++ )
+for (const sal_uInt16 nElement : rIndexArray)
{
-const sal_uInt16 nElement = rIndexArray[nIndex];
-
OSL_ENSURE( 0 != (mpImpl->mxPropMapper->GetEntryFlags(
rProperties[nElement].mnIndex ) &
MID_FLAG_ELEMENT_ITEM_EXPORT),
"wrong mid flag!" );
diff --git a/xmloff/source/style/xmlnumfe.cxx b/xmloff/source/style/xmlnumfe.cxx
index b83ae01fb358..81df9f5262a9 100644
--- a/xmloff/source/style/xmlnumfe.cxx
+++ b/xmloff/source/style/xmlnumfe.cxx
@@ -601,8 +601,8 @@ void SvXMLNumFmtExport::WriteNumberElement_Impl(
// number:embedded-text as child elements
-sal_uInt16 nEntryCount = rEmbeddedEntries.size();
-for (sal_uInt16 nEntry=0; nEntryaName == rName )
-return pObj->nKey; // found
+if (rObj.aName == rName)
+return rObj.nKey; // found
}
return NUMBERFORMAT_ENTRY_NOT_FOUND;
}
@@ -373,11 +371,9 @@ void SvXMLNumImpData::AddKey( sal_uInt32 nKey, const
OUString& rName, bool bRemo
// if there is already an entry for this key without the
bRemoveAfterUse flag,
// clear the flag for this entry, too
-sal_uInt16 nCount = m_NameEntries.size();
-for (sal_uInt16 i=0; inKey == nKey && !pObj->bRemoveAfterUse )
+if (rObj.nKey == nKey && !rObj.bRemoveAfterUse)
{
bRemoveAfterUse = false;// clear flag for new entry
break;
@@ -395,13 +391,11 @@ void SvXMLNumImpData::AddKey( sal_uInt32 nKey, const
OUString& rName, bool bRemo
void SvXMLNumImpData::SetUsed( sal_uInt32 nKey )
{
-sal_uInt16 nCount = m_NameEntries.size();
-for (sal_uInt16 i=0; inKey == nKey )
+if (rObj.nKey == nKey)
{
-pObj->bRemoveAfterUse = false; // used -> don't remove
+rObj.bRemoveAfterUse = false; // used -> don't remove
// continue searching - there may be several entries for the same
key
// (with different names), the format must not be deleted if any
one of
@@ -419,15 +413,13 @@ void SvXMLNumImpData::RemoveVolatileFormats()
if ( !pFormatter )
return;
-sal_uInt16 nCount = m_NameEntries.size();
-for (sal_uInt16 i=0; ibRemoveAfterUse )
+if (rObj.bRemoveAfterUse )
{
-const SvNumberformat* pFormat = pFormatter->GetEntry(pObj->nKey);
+const SvNumberformat* pFormat = pFormatter->GetEntry(rObj.nKey);
if (pFormat && (pFormat->GetType() & SvNumFormatType::DEFINED))
-pFormatter->DeleteEntry( pObj->nKey );
+pFormatter->DeleteEntry(rObj.nKey);
}
}
}
diff --git a/xmloff/source/style/xmlnumi.cxx b/xmloff/source/style/xmlnumi.cxx
index 3b60ce724f19..6b36f2edccd2 100644
--- a/xmloff/source/style/xmlnumi.cxx
+++ b/xmloff/source/style/xmlnumi.cxx
@@ -1062,12 +1062,9 @@ void SvxXMLListStyleContext::FillUnoNumRule(
{
if( pLevelStyles && rNumRule.is() )
{
-sal_uInt16 nCount = pLevelStyles->size();
sal_Int32 l_nLevels = rNumRule->getCount();
-for( sal_uInt16 i=0; i < nCount; i++ )
+for (const auto& pLevelStyle : *pLevelStyles)
{
-SvxXMLListLevelStyleContext_Impl *pLevelStyle =
-(*pLevelStyles)[i].get();
sal_Int32 nLevel = pLevelStyle->GetLevel();
if( nLevel >= 0 && nLevel < l_nLevels )
{
diff --git a/xmloff/source/text/txtparai.cxx
[Libreoffice-commits] core.git: 2 commits - winaccessibility/source xmloff/source
winaccessibility/source/UAccCOM/MAccessible.cxx |7 +--
xmloff/source/style/numehelp.cxx| 14 --
2 files changed, 9 insertions(+), 12 deletions(-)
New commits:
commit f90c2001eb8f6d41e90fa347bf5a707bbefb6f43
Author: Caolán McNamara
AuthorDate: Fri Oct 19 16:55:19 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 20 19:53:39 2018 +0200
pvs-studio: Expression '!bWasSetTypeAttribute' is always true.
Change-Id: I605bbc117426bba3dae9a8ec3ffc45967edbf7c4
Reviewed-on: https://gerrit.libreoffice.org/62060
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/xmloff/source/style/numehelp.cxx b/xmloff/source/style/numehelp.cxx
index b678d559a277..db9e1d8dac6e 100644
--- a/xmloff/source/style/numehelp.cxx
+++ b/xmloff/source/style/numehelp.cxx
@@ -105,11 +105,8 @@ void
XMLNumberFormatAttributesExportHelper::WriteAttributes(SvXMLExport& rXMLExp
case util::NumberFormat::SCIENTIFIC:
case util::NumberFormat::FRACTION:
{
-if (!bWasSetTypeAttribute)
-{
-rXMLExport.AddAttribute(XML_NAMESPACE_OFFICE, XML_VALUE_TYPE,
XML_FLOAT);
-bWasSetTypeAttribute = true;
-}
+rXMLExport.AddAttribute(XML_NAMESPACE_OFFICE, XML_VALUE_TYPE,
XML_FLOAT);
+bWasSetTypeAttribute = true;
SAL_FALLTHROUGH;
}
case util::NumberFormat::PERCENT:
@@ -374,11 +371,8 @@ void
XMLNumberFormatAttributesExportHelper::WriteAttributes(
case util::NumberFormat::SCIENTIFIC:
case util::NumberFormat::FRACTION:
{
-if (!bWasSetTypeAttribute)
-{
-pExport->AddAttribute(sAttrValType, XML_FLOAT);
-bWasSetTypeAttribute = true;
-}
+pExport->AddAttribute(sAttrValType, XML_FLOAT);
+bWasSetTypeAttribute = true;
SAL_FALLTHROUGH;
}
case util::NumberFormat::PERCENT:
commit c2b33fec70f0f4c79584db119ecd565af3a5b28e
Author: Caolán McNamara
AuthorDate: Fri Oct 19 17:22:42 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 20 19:53:27 2018 +0200
pvs-studio: 'memcpy' function will lead to underflow of the buffer
Change-Id: I285d5ddcc8906d1e38c6b58c625dc7c894ad433a
Reviewed-on: https://gerrit.libreoffice.org/62064
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/winaccessibility/source/UAccCOM/MAccessible.cxx
b/winaccessibility/source/UAccCOM/MAccessible.cxx
index 0a75d9a4e5a8..1801cf61929e 100644
--- a/winaccessibility/source/UAccCOM/MAccessible.cxx
+++ b/winaccessibility/source/UAccCOM/MAccessible.cxx
@@ -2898,10 +2898,13 @@ void CMAccessible::ConvertAnyToVariant(const
css::uno::Any , VARIANT *pv
break;
case TypeClass_BOOLEAN:
+{
+bool bBoolean(false);
+rAnyVal >>= bBoolean;
pvData->vt = VT_BOOL;
-memcpy(>boolVal, rAnyVal.getValue(), sizeof(sal_Bool));
+pvData->boolVal = bBoolean; // boolVal is a VARIANT_BOOL, a 16bit
field
break;
-
+}
case TypeClass_BYTE:
pvData->vt = VT_UI1;
memcpy(>bVal, rAnyVal.getValue(), sizeof(sal_Int8));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - xmloff/source xmlsecurity/source
xmloff/source/style/xmlimppr.cxx |2 +-
xmlsecurity/source/xmlsec/mscrypt/akmngr.cxx |8
2 files changed, 1 insertion(+), 9 deletions(-)
New commits:
commit 0b8682d83e9e5a9832383aff011af5429ddd7e71
Author: Caolán McNamara
AuthorDate: Fri Oct 19 16:15:01 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 20 19:52:52 2018 +0200
pvs-studio: Expression 'keyStore != nullptr' is always true.
Change-Id: I70a78f731a01f3344bf6c874995d367d26bf2397
Reviewed-on: https://gerrit.libreoffice.org/62052
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/xmlsecurity/source/xmlsec/mscrypt/akmngr.cxx
b/xmlsecurity/source/xmlsec/mscrypt/akmngr.cxx
index aafd7d10a66c..4054777afa1e 100644
--- a/xmlsecurity/source/xmlsec/mscrypt/akmngr.cxx
+++ b/xmlsecurity/source/xmlsec/mscrypt/akmngr.cxx
@@ -55,14 +55,6 @@ xmlSecKeysMngrPtr MSCryptoAppliedKeysMngrCreate()
return nullptr ;
}
-/*-
- * At present, MS Crypto engine do not provide a way to setup a key store.
- */
-if (keyStore != nullptr)
-{
-/*TODO: binding key store.*/
-}
-
keyMngr = xmlSecKeysMngrCreate() ;
if (keyMngr == nullptr)
{
commit 5fa9076a2926b2a54f001f78eea5ce0183466b61
Author: Caolán McNamara
AuthorDate: Fri Oct 19 16:50:50 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 20 19:52:38 2018 +0200
pvs-studio: An excessive check can be simplified
Change-Id: Idaa511d4ccf3d8542bdf6a1dcee4fa54c6d2315f
Reviewed-on: https://gerrit.libreoffice.org/62059
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/xmloff/source/style/xmlimppr.cxx b/xmloff/source/style/xmlimppr.cxx
index 8ebaa88d3fde..f14e64628618 100644
--- a/xmloff/source/style/xmlimppr.cxx
+++ b/xmloff/source/style/xmlimppr.cxx
@@ -585,7 +585,7 @@ void SvXMLImportPropertyMapper::PrepareForMultiPropertySet_(
if ( ( 0 == ( nPropFlags & MID_FLAG_NO_PROPERTY ) ) &&
( ( 0 != ( nPropFlags & MID_FLAG_MUST_EXIST ) ) ||
!rPropSetInfo.is() ||
- (rPropSetInfo.is() && rPropSetInfo->hasPropertyByName(
rPropName )) ) )
+ rPropSetInfo->hasPropertyByName(rPropName) ) )
{
// save property into property pair structure
aPropertyPairs.emplace_back( , );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - xmloff/source xmlsecurity/source
xmloff/source/text/txtparae.cxx |4 ++--
xmlsecurity/source/xmlsec/mscrypt/x509certificate_mscryptimpl.cxx |5 -
2 files changed, 2 insertions(+), 7 deletions(-)
New commits:
commit 014dec7fea06189d79c635e8df35e1f48edf7ef5
Author: Caolán McNamara
AuthorDate: Fri Oct 19 16:36:44 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 20 19:52:26 2018 +0200
pvs-studio: rework expression
Change-Id: Ibcbeef3eba53df790c1860e6e4066de67bdda0bc
Reviewed-on: https://gerrit.libreoffice.org/62057
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/xmloff/source/text/txtparae.cxx b/xmloff/source/text/txtparae.cxx
index 95a3e89c6f2d..4d1d196189ed 100644
--- a/xmloff/source/text/txtparae.cxx
+++ b/xmloff/source/text/txtparae.cxx
@@ -654,7 +654,7 @@ void XMLTextParagraphExport::Add( sal_uInt16 nFamily,
; // section styles have no parents
break;
}
-if( (aPropStates.size() - nIgnoreProps) > 0 )
+if (aPropStates.size() - nIgnoreProps)
{
GetAutoStylePool().Add( nFamily, sParent, aPropStates, bDontSeek );
if( !sCondParent.isEmpty() && sParent != sCondParent )
@@ -848,7 +848,7 @@ OUString XMLTextParagraphExport::FindTextStyleAndHyperlink(
ppAddStates++;
}
}
-if( (aPropStates.size() - nIgnoreProps) > 0 )
+if (aPropStates.size() - nIgnoreProps)
{
// erase the character style, otherwise the autostyle cannot be found!
// erase the hyperlink, otherwise the autostyle cannot be found!
commit cdf8d7a1d88865b26cab11f01cc6307a4033f1dd
Author: Caolán McNamara
AuthorDate: Fri Oct 19 16:05:00 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 20 19:52:12 2018 +0200
pvs-studio: new does not return nullptr
Change-Id: I3ba9048a4563e7c8e6930ae67d5a076a829d6b81
Reviewed-on: https://gerrit.libreoffice.org/62049
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/xmlsecurity/source/xmlsec/mscrypt/x509certificate_mscryptimpl.cxx
b/xmlsecurity/source/xmlsec/mscrypt/x509certificate_mscryptimpl.cxx
index b8783440ea10..d44d093641c1 100644
--- a/xmlsecurity/source/xmlsec/mscrypt/x509certificate_mscryptimpl.cxx
+++ b/xmlsecurity/source/xmlsec/mscrypt/x509certificate_mscryptimpl.cxx
@@ -369,8 +369,6 @@ css::uno::Sequence< css::uno::Reference<
css::security::XCertificateExtension >
xExtn = reinterpret_cast(new
SanExtensionImpl());
else
xExtn = new CertificateExtension_XmlSecImpl;
-if( xExtn == nullptr )
-throw RuntimeException() ;
xExtn->setCertExtn( pExtn->Value.pbData, pExtn->Value.cbData,
reinterpret_cast(pExtn->pszObjId), strlen( pExtn->pszObjId ),
pExtn->fCritical ) ;
@@ -394,9 +392,6 @@ css::uno::Reference< css::security::XCertificateExtension >
SAL_CALL X509Certifi
//TODO: Compare the oid
if( false ) {
xExtn = new CertificateExtension_XmlSecImpl;
-if( xExtn == nullptr )
-throw RuntimeException() ;
-
xExtn->setCertExtn( pExtn->Value.pbData, pExtn->Value.cbData,
reinterpret_cast(pExtn->pszObjId), strlen( pExtn->pszObjId ),
pExtn->fCritical ) ;
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120408] Changed cell outlines in Calc after upgrade to LibreOffice 6.0.6.2
https://bugs.documentfoundation.org/show_bug.cgi?id=120408 --- Comment #5 from johnmcfarlan...@hotmail.com --- (In reply to Roman Kuznetsov from comment #1) > please attach sample of your document into bug Comments 1 to 4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - xmlsecurity/source
xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx| 63
--
xmlsecurity/source/xmlsec/mscrypt/securityenvironment_mscryptimpl.cxx |4
2 files changed, 33 insertions(+), 34 deletions(-)
New commits:
commit fc6dd83ba24a9fed9c61caddfba701d6835bc80c
Author: Caolán McNamara
AuthorDate: Fri Oct 19 16:13:27 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 20 19:51:39 2018 +0200
pvs-studio: Expression 'pCertContext' is always true.
Change-Id: Iefd9b082e44dc22e9bd7fb2856f44c8db6d8482f
Reviewed-on: https://gerrit.libreoffice.org/62051
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git
a/xmlsecurity/source/xmlsec/mscrypt/securityenvironment_mscryptimpl.cxx
b/xmlsecurity/source/xmlsec/mscrypt/securityenvironment_mscryptimpl.cxx
index 2a545ba568b5..5e6dfcb93a99 100644
--- a/xmlsecurity/source/xmlsec/mscrypt/securityenvironment_mscryptimpl.cxx
+++ b/xmlsecurity/source/xmlsec/mscrypt/securityenvironment_mscryptimpl.cxx
@@ -589,8 +589,8 @@ uno::Reference< XCertificate >
SecurityEnvironment_MSCryptImpl::getCertificate(
if( certInfo.Issuer.pbData ) free( certInfo.Issuer.pbData ) ;
if( pCertContext != nullptr ) {
-xcert = MswcryCertContextToXCert( pCertContext ) ;
-if( pCertContext ) CertFreeCertificateContext( pCertContext ) ;
+xcert = MswcryCertContextToXCert(pCertContext);
+CertFreeCertificateContext(pCertContext);
} else {
xcert = nullptr ;
}
commit f9ccf6216022dcaf70bd01e51feb5c88b5f03731
Author: Caolán McNamara
AuthorDate: Fri Oct 19 16:22:08 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 20 19:51:27 2018 +0200
rework to check cPath against nullptr only on !WNT
Change-Id: Iaca0d47b07f4b31b70ddeccb87f0f84019be81cd
Reviewed-on: https://gerrit.libreoffice.org/62055
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
b/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
index 61300fdf6156..98f9bd1da127 100644
--- a/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
+++ b/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
@@ -501,41 +501,40 @@ IMPL_STATIC_LINK(DigitalSignaturesDialog,
CertMgrButtonHdl, Button*, pButton, vo
#else
const OUString aGUIServers[] = { OUString("kleopatra"),
OUString("seahorse"), OUString("gpa"), OUString("kgpg") };
const char* cPath = getenv("PATH");
+if (!cPath)
+return;
#endif
-if (cPath)
+OUString aPath(cPath, strlen(cPath), osl_getThreadTextEncoding());
+OUString sFoundGUIServer, sExecutable;
+
+for ( auto const : aGUIServers )
+{
+osl::FileBase::RC searchError = osl::File::searchFileURL(rServer,
aPath, sFoundGUIServer );
+if (searchError == osl::FileBase::E_None)
+{
+osl::File::getSystemPathFromFileURL( sFoundGUIServer, sExecutable
);
+break;
+}
+
+}
+
+if ( !sExecutable.isEmpty() )
+{
+uno::Reference< uno::XComponentContext > xContext =
+::comphelper::getProcessComponentContext();
+uno::Reference< css::system::XSystemShellExecute > xSystemShell(
+ css::system::SystemShellExecute::create(xContext) );
+
+xSystemShell->execute( sExecutable, OUString(),
+css::system::SystemShellExecuteFlags::DEFAULTS );
+}
+else
{
- OUString aPath(cPath, strlen(cPath), osl_getThreadTextEncoding());
- OUString sFoundGUIServer, sExecutable;
-
- for ( auto const : aGUIServers )
- {
- osl::FileBase::RC searchError = osl::File::searchFileURL(rServer,
aPath, sFoundGUIServer );
- if (searchError == osl::FileBase::E_None)
- {
- osl::File::getSystemPathFromFileURL( sFoundGUIServer,
sExecutable );
- break;
- }
-
- }
-
- if ( !sExecutable.isEmpty() )
- {
- uno::Reference< uno::XComponentContext > xContext =
- ::comphelper::getProcessComponentContext();
- uno::Reference< css::system::XSystemShellExecute > xSystemShell(
-css::system::SystemShellExecute::create(xContext) );
-
- xSystemShell->execute( sExecutable, OUString(),
- css::system::SystemShellExecuteFlags::DEFAULTS );
- }
- else
- {
- std::unique_ptr
xInfoBox(Application::CreateMessageDialog(pButton->GetFrameWeld(),
- VclMessageType::Info,
VclButtonsType::Ok,
-
XsResId(STR_XMLSECDLG_NO_CERT_MANAGER)));
- xInfoBox->run();
- }
+std::unique_ptr
xInfoBox(Application::CreateMessageDialog(pButton->GetFrameWeld(),
+ VclMessageType::Info,
[Libreoffice-commits] core.git: xmlsecurity/source
xmlsecurity/source/xmlsec/mscrypt/securityenvironment_mscryptimpl.cxx | 10
+++---
1 file changed, 3 insertions(+), 7 deletions(-)
New commits:
commit 71c804a05eb07fa21482ca298486ed70c63907ad
Author: Caolán McNamara
AuthorDate: Fri Oct 19 16:10:45 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 20 19:51:53 2018 +0200
pvs-studio: The 'store' variable is assigned values twice successively.
Change-Id: I532bf99935c2f4d3b58f84013bc545791208
Reviewed-on: https://gerrit.libreoffice.org/62050
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git
a/xmlsecurity/source/xmlsec/mscrypt/securityenvironment_mscryptimpl.cxx
b/xmlsecurity/source/xmlsec/mscrypt/securityenvironment_mscryptimpl.cxx
index 5e6dfcb93a99..4ba5ad8a4417 100644
--- a/xmlsecurity/source/xmlsec/mscrypt/securityenvironment_mscryptimpl.cxx
+++ b/xmlsecurity/source/xmlsec/mscrypt/securityenvironment_mscryptimpl.cxx
@@ -735,14 +735,12 @@ uno::Reference< XCertificate >
SecurityEnvironment_MSCryptImpl::createCertificat
}
uno::Reference< XCertificate >
SecurityEnvironment_MSCryptImpl::createCertificateFromAscii( const OUString&
asciiCertificate ) {
-xmlChar* chCert ;
-xmlSecSize certSize ;
OString oscert = OUStringToOString( asciiCertificate ,
RTL_TEXTENCODING_ASCII_US ) ;
-chCert = xmlStrndup( reinterpret_cast(oscert.getStr()),
static_cast(oscert.getLength()) ) ;
+xmlChar* chCert = xmlStrndup( reinterpret_cast(oscert.getStr()), static_cast(oscert.getLength()) ) ;
-certSize = xmlSecBase64Decode( chCert, chCert, xmlStrlen( chCert ) ) ;
+xmlSecSize certSize = xmlSecBase64Decode( chCert, chCert, xmlStrlen(
chCert ) ) ;
uno::Sequence< sal_Int8 > rawCert( certSize ) ;
for( xmlSecSize i = 0 ; i < certSize ; i ++ )
@@ -757,9 +755,7 @@ uno::Reference< XCertificate >
SecurityEnvironment_MSCryptImpl::createCertificat
static HCERTSTORE getCertStoreForIntermediatCerts(
const uno::Sequence< uno::Reference< css::security::XCertificate > >&
seqCerts)
{
-HCERTSTORE store = nullptr;
-store = CertOpenStore(
-CERT_STORE_PROV_MEMORY, 0, NULL, 0, nullptr);
+HCERTSTORE store = CertOpenStore(CERT_STORE_PROV_MEMORY, 0, NULL, 0,
nullptr);
if (store == nullptr)
return nullptr;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - xmlhelp/source xmlsecurity/source
xmlhelp/source/cxxhelp/provider/resultsetforquery.cxx |1 -
xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx | 11 +--
2 files changed, 5 insertions(+), 7 deletions(-)
New commits:
commit 83c82bbb73dec5e3ba82e81b09824cd223e575a7
Author: Caolán McNamara
AuthorDate: Fri Oct 19 16:18:35 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 20 19:51:14 2018 +0200
pvs-studio: A part of conditional expression is always true: bSigValid.
Change-Id: I4da53c79bb9e47548338d3e348677049e664bf8d
Reviewed-on: https://gerrit.libreoffice.org/62053
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
b/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
index 6a5a5936c833..61300fdf6156 100644
--- a/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
+++ b/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
@@ -571,7 +571,6 @@ void DigitalSignaturesDialog::ImplFillSignaturesBox()
OUString aDescription;
OUString aType;
-bool bSigValid = false;
bool bCertValid = false;
if( xCert.is() )
{
@@ -622,7 +621,7 @@ void DigitalSignaturesDialog::ImplFillSignaturesBox()
aType = "PDF";
}
-bSigValid = ( rInfo.nStatus ==
css::xml::crypto::SecurityOperationStatus_OPERATION_SUCCEEDED );
+bool bSigValid = rInfo.nStatus ==
css::xml::crypto::SecurityOperationStatus_OPERATION_SUCCEEDED;
if ( bSigValid )
{
@@ -638,7 +637,7 @@ void DigitalSignaturesDialog::ImplFillSignaturesBox()
{
aImage = m_pSigsInvalidImg->GetImage();
}
-else if (bSigValid && !bCertValid)
+else if (!bCertValid)
{
aImage = m_pSigsNotvalidatedImg->GetImage();
}
@@ -647,20 +646,20 @@ void DigitalSignaturesDialog::ImplFillSignaturesBox()
// If there is no storage, then it's pointless to check storage
// stream references.
else if (maSignatureManager.meSignatureMode ==
DocumentSignatureMode::Content
-&& bSigValid && bCertValid && (maSignatureManager.mxStore.is()
&& !DocumentSignatureHelper::isOOo3_2_Signature(
+&& bCertValid && (maSignatureManager.mxStore.is() &&
!DocumentSignatureHelper::isOOo3_2_Signature(
maSignatureManager.maCurrentSignatureInformations[n])))
{
aImage = m_pSigsNotvalidatedImg->GetImage();
bAllNewSignatures = false;
}
else if (maSignatureManager.meSignatureMode ==
DocumentSignatureMode::Content
-&& bSigValid && bCertValid &&
DocumentSignatureHelper::isOOo3_2_Signature(
+&& bCertValid && DocumentSignatureHelper::isOOo3_2_Signature(
maSignatureManager.maCurrentSignatureInformations[n]))
{
aImage = m_pSigsValidImg->GetImage();
}
else if (maSignatureManager.meSignatureMode ==
DocumentSignatureMode::Macros
-&& bSigValid && bCertValid)
+&& bCertValid)
{
aImage = m_pSigsValidImg->GetImage();
}
commit 5145882f8f33ce2588722ae7439fc47d1cdcaaf6
Author: Caolán McNamara
AuthorDate: Fri Oct 19 17:01:05 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 20 19:51:00 2018 +0200
pvs-studio: The 'aIndexFolderResultVector' variable is used after it was
moved
Change-Id: I565f22594a371188c4a6eff5f405946ec1e04d95
Reviewed-on: https://gerrit.libreoffice.org/62061
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/xmlhelp/source/cxxhelp/provider/resultsetforquery.cxx
b/xmlhelp/source/cxxhelp/provider/resultsetforquery.cxx
index 92e20e6049d0..66ccaf747696 100644
--- a/xmlhelp/source/cxxhelp/provider/resultsetforquery.cxx
+++ b/xmlhelp/source/cxxhelp/provider/resultsetforquery.cxx
@@ -237,7 +237,6 @@ ResultSetForQuery::ResultSetForQuery( const uno::Reference<
uno::XComponentConte
}
aIndexFolderResultVectorVector.push_back(
std::move(aIndexFolderResultVector) );
-aIndexFolderResultVector.clear();
}
catch (const Exception )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: writerperfect/qa
writerperfect/qa/unit/EPUBExportTest.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 993d92d5cbb8f63a630ca615112a6abbefdf8a16
Author: Caolán McNamara
AuthorDate: Fri Oct 19 17:02:50 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 20 19:50:08 2018 +0200
pvs-studio: Possible overflow
Change-Id: Ifa213fd6b719683afae9633615f69db894cd9c18
Reviewed-on: https://gerrit.libreoffice.org/62062
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/writerperfect/qa/unit/EPUBExportTest.cxx
b/writerperfect/qa/unit/EPUBExportTest.cxx
index ecca84410866..be8302dc520e 100644
--- a/writerperfect/qa/unit/EPUBExportTest.cxx
+++ b/writerperfect/qa/unit/EPUBExportTest.cxx
@@ -284,7 +284,7 @@ void EPUBExportTest::testMimetype()
SvMemoryStream aMemoryStream;
aMemoryStream.WriteStream(aFileStream);
OString aExpected("application/epub+zip");
-CPPUNIT_ASSERT(aMemoryStream.GetSize() > static_cast(38 +
aExpected.getLength()));
+CPPUNIT_ASSERT(aMemoryStream.GetSize() >
static_cast(aExpected.getLength()) + 38);
OString aActual(static_cast(aMemoryStream.GetData()) + 38,
aExpected.getLength());
// This failed: actual data was some garbage, not the uncompressed mime
type.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120737] New: Word count starting again when pasting unformatted text to a footnote
https://bugs.documentfoundation.org/show_bug.cgi?id=120737 Bug ID: 120737 Summary: Word count starting again when pasting unformatted text to a footnote Product: LibreOffice Version: 6.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Word count starting again when pasting unformatted text to a footnote (maybe bug 120515) Steps to Reproduce: 1. Open attachment 145863 2. Select some text part & copy it 3. Select the text in a footnote, CTRL+SHIFT+V.. Paste as unformatted text. Word count starts again Actual Results: Full word recount Expected Results: Only the change Reproducible: Always User Profile Reset: No Additional Info: Version: 6.2.0.0.alpha0+ Build ID: b63d48a146c3615f56b6ec83361b3c02ebcbb215 CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2018-10-13_23:33:20 Locale: nl-NL (nl_NL); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: winaccessibility/source
winaccessibility/source/service/AccObject.cxx |6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
New commits:
commit 3421107a2bb5defc99a59fd0683a7b3014bc5444
Author: Caolán McNamara
AuthorDate: Fri Oct 19 17:24:16 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 20 19:49:52 2018 +0200
unused pUNumberString buffer
Change-Id: Ib17f5344b9bdf3710a49fc054dd96d5998e6b822
Reviewed-on: https://gerrit.libreoffice.org/62065
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/winaccessibility/source/service/AccObject.cxx
b/winaccessibility/source/service/AccObject.cxx
index eabed2cc219b..abcaaf7c2a67 100644
--- a/winaccessibility/source/service/AccObject.cxx
+++ b/winaccessibility/source/service/AccObject.cxx
@@ -380,9 +380,6 @@ void AccObject::UpdateDefaultAction( )
*/
void AccObject::SetValue( Any pAny )
{
-unsigned short pUNumberString[100];
-memset( pUNumberString, 0 , sizeof( pUNumberString) );
-
if( nullptr == m_pIMAcc || !m_xAccContextRef.is() )
{
assert(false);
@@ -423,9 +420,8 @@ void AccObject::SetValue( Any pAny )
}
return;
-
-
}
+
::rtl::OUString AccObject::GetMAccessibleValueFromAny(Any pAny)
{
::rtl::OUString strValue;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120736] Automatic update of external links has been disabled
https://bugs.documentfoundation.org/show_bug.cgi?id=120736 --- Comment #1 from Edmund Laugasson --- Noticed also https://ask.libreoffice.org/en/question/162708/automatic-update-of-external-links-has-been-disabled/ but this issue seems to be not connected with that setting whether updating links are updating automatically or not. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120736] New: Automatic update of external links has been disabled
https://bugs.documentfoundation.org/show_bug.cgi?id=120736 Bug ID: 120736 Summary: Automatic update of external links has been disabled Product: LibreOffice Version: 6.1.2.1 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: edmund.laugas...@gmail.com Description: This bug concerns about having external linked data and shared mode. Steps to Reproduce: 1. create an .ods document in Calc 2. add name to cell blocks (https://help.libreoffice.org/Calc/Naming_Cells) 3. add new sheet 4. link named cell block as external data to new sheet (https://help.libreoffice.org/Calc/Link_to_External_Data) 5. save document 6. share the document (Tools->Share spreadsheet) and save it 7. try to open the document in another computer over shared folder, I used Virtualbox 5.2.20 (extension pack + guest additions installed) shared folder 8. there will be a warning message "Automatic update of external links has been disabled" in both side and an option to click the button "Enable Content" - I clicked that in both side 9. After opening same shared document in two different locations: one locally, another over network - at some point the LibreOffice will start using CPU close to maximum (96...98%) and will crash - window keeps open but not responsive and trying to interact with that, system asks that this does not respond, would I like to close that using force. So I will close it with force. Actual Results: There is a warning "Automatic update of external links has been disabled" when opening file with linked data in shared mode. LibreOffice Calc will start consuming CPU intensively and will finally crash. Expected Results: LibreOffice Calc will not crash. If external linked data is not supported while shared mode enabled then either external data linking should be forcibly turned off with appropriate warning or not allow to use shared mode while external data linking is active. If supports then such warning should not be displayed and data linking should work as promised. Reproducible: Always User Profile Reset: No Additional Info: Used 64-bit AppImage version of LibreOffice in Linux Mint 19 MATE (both: host and guest in terms of VirtualBox) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120736] Automatic update of external links has been disabled
https://bugs.documentfoundation.org/show_bug.cgi?id=120736 Edmund Laugasson changed: What|Removed |Added Hardware|All |x86-64 (AMD64) OS|All |Linux (All) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120735] Memory usage on file open 4 times higher compared to LibO6.1 (70 vs 280)
https://bugs.documentfoundation.org/show_bug.cgi?id=120735 --- Comment #1 from Telesto --- Created attachment 145863 --> https://bugs.documentfoundation.org/attachment.cgi?id=145863=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120735] New: Memory usage on file open 4 times higher compared to LibO6.1 (70 vs 280)
https://bugs.documentfoundation.org/show_bug.cgi?id=120735 Bug ID: 120735 Summary: Memory usage on file open 4 times higher compared to LibO6.1 (70 vs 280) Product: LibreOffice Version: 6.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Memory usage on file open 4 times higher compared to LibO6.1 Steps to Reproduce: 1. Open the attached file 2. Compare memory usage with 6.1 Actual Results: 280 MB Expected Results: 70 (or something like that Reproducible: Always User Profile Reset: No Additional Info: Version: 6.2.0.0.alpha0+ Build ID: b63d48a146c3615f56b6ec83361b3c02ebcbb215 CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2018-10-13_23:33:20 Locale: nl-NL (nl_NL); Calc: CL but not in Version: 6.1.0.0.alpha0+ Build ID: c26f644db80e10f755911d277aac0e1d42731d29 CPU threads: 4; OS: Windows 6.3; UI render: default; Locale: nl-NL (nl_NL); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117936] [META] Refactor CommonSalLayout font handling regressions
https://bugs.documentfoundation.org/show_bug.cgi?id=117936 Bug 117936 depends on bug 119302, which changed state. Bug 119302 Summary: Wrong rendering of math formulas with scalable brackets in Writer https://bugs.documentfoundation.org/show_bug.cgi?id=119302 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119302] Wrong rendering of math formulas with scalable brackets in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=119302 V Stuart Foote changed: What|Removed |Added Whiteboard|target:6.2.0 target:6.1.3 |target:6.2.0 target:6.1.4 Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #25 from V Stuart Foote --- OK, so behavior is fixed for 6.1.4 builds Version: 6.1.4.0.0+ (x64) Build ID: 392ec204197c723b4dff4f7091df5afb46b5b9db CPU threads: 4; OS: Windows 10.0; UI render: GL; TinderBox: Win-x86_64@42, Branch:libreoffice-6-1, Time: 2018-10-20_11:13:07 Locale: en-US (en_US); Calc: CL With both OpenGL rendering and default CPU, HA rendering. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120734] New: Right click context menu contains "Remove Hyperlink" without a hyperlink present
https://bugs.documentfoundation.org/show_bug.cgi?id=120734 Bug ID: 120734 Summary: Right click context menu contains "Remove Hyperlink" without a hyperlink present Product: LibreOffice Version: 6.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Right click context menu contains "Remove Hyperlink" without a hyperlink present Steps to Reproduce: 1. Open attachment 145862 2. CTRL+A 3. Open the Right click context menu Actual Results: Remove Hyperlink shows up at the bottom Expected Results: Shouldn't be there Reproducible: Always User Profile Reset: No Additional Info: Version: 6.2.0.0.alpha0+ Build ID: b63d48a146c3615f56b6ec83361b3c02ebcbb215 CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2018-10-13_23:33:20 Locale: nl-NL (nl_NL); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120716] Share spreadsheet does not refresh
https://bugs.documentfoundation.org/show_bug.cgi?id=120716 --- Comment #2 from Edmund Laugasson --- I see that saving is refresh. In that sense such editing without seeing what other collaborators are doing, is quite useless but I see that this is not meant for that. I guess possibly wontfix is the end of current issue. I discovered another issue during testing this which leads to crash of LibreOffice. Will report a new issue. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120731] Crash cuilo!makeAutoCorrEdit when open character dialog with large amount of text selected
https://bugs.documentfoundation.org/show_bug.cgi?id=120731 Jean-Baptiste Faure changed: What|Removed |Added Keywords||regression Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||jbfa...@libreoffice.org --- Comment #2 from Jean-Baptiste Faure --- Reproducible for me with Version: 6.2.0.0.alpha0+ Build ID: 27b0d7237a7e2f32897fa52820c3aa382f6683e9 Threads CPU : 4; OS : Linux 4.15; UI Render : par défaut; VCL: gtk3; Ubuntu_18.04_x86-64 Locale : fr-FR (fr_FR.UTF-8); Calc: threaded No crash with LO 6.1.2 from Ubuntu PPA and LO 6.1.4.0.0+ built at home under Ubuntu 18.04 x86-64 Version: 6.1.4.0.0+ Build ID: 3ec5fb847364ca65322079fdc1026ed95a0a8933 Threads CPU : 4; OS : Linux 4.15; UI Render : par défaut; VCL: gtk3; Ubuntu_18.04_x86-64 Locale : fr-FR (fr_FR.UTF-8); Calc: group threaded Set to NEW and add regression keyword. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120731] Crash cuilo!makeAutoCorrEdit when open character dialog with large amount of text selected
https://bugs.documentfoundation.org/show_bug.cgi?id=120731 --- Comment #1 from Telesto --- Created attachment 145862 --> https://bugs.documentfoundation.org/attachment.cgi?id=145862=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120733] New: The blue 'Insert header/footer' popup doesn't appear
https://bugs.documentfoundation.org/show_bug.cgi?id=120733 Bug ID: 120733 Summary: The blue 'Insert header/footer' popup doesn't appear Product: LibreOffice Version: 6.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: The blue 'Insert header/footer' popup doesn't appear Steps to Reproduce: 1. Open Writer 2. Click/hoover somewhere a the top of the page (nothing happens) Actual Results: No blue popup bar Expected Results: Should be there Reproducible: Always User Profile Reset: No Additional Info: Version: 6.2.0.0.alpha0+ Build ID: b63d48a146c3615f56b6ec83361b3c02ebcbb215 CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2018-10-13_23:33:20 Locale: nl-NL (nl_NL); Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120732] Lots of time spend in re-rendering of page breaks
https://bugs.documentfoundation.org/show_bug.cgi?id=120732 --- Comment #1 from Telesto --- Created attachment 145861 --> https://bugs.documentfoundation.org/attachment.cgi?id=145861=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120732] New: Lots of time spend in re-rendering of page breaks
https://bugs.documentfoundation.org/show_bug.cgi?id=120732 Bug ID: 120732 Summary: Lots of time spend in re-rendering of page breaks Product: LibreOffice Version: 4.4.7.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: A bit of a artificial example.. But the page breaks are redrawn over and over. The same happens when scrolling with the floating header button visible Steps to Reproduce: 1. Open the attached file 2. Open the document in multi-page view -> 4 or more pages in a row 3. Hold enter somewhere on the first page until a empty page is added 4. Undo by holding CTRL+Z and monitor CPU usage Actual Results: Slowdown & high CPU usage/ redrawing of page breaks Expected Results: Not flickering page break/ more performance Reproducible: Always User Profile Reset: No Additional Info: Found in Version: 6.2.0.0.alpha0+ Build ID: b63d48a146c3615f56b6ec83361b3c02ebcbb215 CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2018-10-13_23:33:20 Locale: nl-NL (nl_NL); Calc: threaded Versie: 4.4.7.2 Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600 Locale: nl_NL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120728] crash in report editing: insert page number in footer while header is active
https://bugs.documentfoundation.org/show_bug.cgi?id=120728 --- Comment #9 from Julien Nabet --- I submitted this patch to review: https://gerrit.libreoffice.org/#/c/62082/1 See comments of this one. In brief, perhaps my previous patch on tdf#120152 was wrong but I had no feedback about it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120714] Cannot open .key presentation file in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=120714 Jean-Baptiste Faure changed: What|Removed |Added CC||dtar...@redhat.com --- Comment #5 from Jean-Baptiste Faure --- I try to open this keynote file: https://bugs.documentfoundation.org/attachment.cgi?id=97347 attached to fixed bug 72030 and that does not work very well. Double-click on dekstop gives an error. Open from LO, works only if Apple Keynote filter is set first. The result is clearly not correct. @David Tardon: you may be interested by this bug report. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120707] Cannot open .pages file in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=120707 --- Comment #4 from Daniel --- That's not corrupt, why not try to open with Apple Pages?(In reply to Dieter Praas from comment #3) > When I try to open the file; i get the following message: > > The file 'Project Proposal.pages' is corrupt and therefore cannot be opened. > LibreOfficeDev can try to repair the file. > > The corruption could be the result of document manipulation or of structural > document damage due to data transmission. > > We recommend that you do not trust the content of the repaired document. > Execution of macros is disabled for this document. > > Repairing the docuemtn failed. So I would say NOTABUG. That's not corrupted, I can open it normally in Apple Pages app in my iPad, even in iCloud website and free to edit. This content was trusted originally from Apple Pages app and pick-up some template to create new or edit document freely. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120731] New: Crash cuilo!makeAutoCorrEdit when open character dialog with large amount of text selected
https://bugs.documentfoundation.org/show_bug.cgi?id=120731 Bug ID: 120731 Summary: Crash cuilo!makeAutoCorrEdit when open character dialog with large amount of text selected Product: LibreOffice Version: 6.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Crash cuilo!makeAutoCorrEdit when open character dialog with large amount of text selected Steps to Reproduce: 1. Open the attached file 2. CTRL+A 3. Format -> Character dialog Actual Results: Crash Expected Results: No crash Reproducible: Always User Profile Reset: No Additional Info: Found in Version: 6.2.0.0.alpha0+ Build ID: b63d48a146c3615f56b6ec83361b3c02ebcbb215 CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2018-10-13_23:33:20 Locale: nl-NL (nl_NL); Calc: CL but not in Versie: 4.4.7.2 Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600 Locale: nl_NL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120728] crash in report editing: insert page number in footer while header is active
https://bugs.documentfoundation.org/show_bug.cgi?id=120728 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #8 from Julien Nabet --- Created attachment 145860 --> https://bugs.documentfoundation.org/attachment.cgi?id=145860=edit bt with debug symbols On pc Debian x86-64 with master sources updated today, I could reproduce this. It may be due to https://cgit.freedesktop.org/libreoffice/core/commit/?id=f2bd68c33c13b94cf844227d04a7eba9fe3723f8 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120709] Cannot open .numbers file in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=120709 Jean-Baptiste Faure changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 OS|Windows (All) |All CC||jbfa...@libreoffice.org Hardware|x86 (IA32) |All --- Comment #3 from Jean-Baptiste Faure --- Reproducible with LO 6.1.2 under Ubuntu 18.04 x86-64. Set to NEW. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120714] Cannot open .key presentation file in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=120714 Jean-Baptiste Faure changed: What|Removed |Added Status|NEEDINFO|NEW Hardware|x86 (IA32) |All OS|Windows (All) |All Severity|enhancement |normal --- Comment #4 from Jean-Baptiste Faure --- Forget my previous comment. Well, I see that LO filepicker knows Apple Keynote file. So I guess that the error message comes from a filter which has not been updated after a change in a proprietary file format. I reproduce the error message. So set status to NEW. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120728] crash in report editing: insert page number in footer while header is active
https://bugs.documentfoundation.org/show_bug.cgi?id=120728 Telesto changed: What|Removed |Added Keywords||bibisectRequest, regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
After loplugin:staticvar in sw, Jenkins_Windows_Dbg failing
After https://cgit.freedesktop.org/libreoffice/core/commit/?id=4ba5b003b594f9eb6c9b185208bdb72aef8273d0 loplugin:staticvar in sw Jenkins_Windows_Dbg failing with 9 NEXT C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_dbg/sw/source/filter/html/svxcss1.cxx(3166): error C2065: ´CSS1PropEntryCompare´: undeclared identifier 7049 NEXTmake: *** [Makefile:286: build] Error 2 https://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER=1540039069.23076 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 119302] Wrong rendering of math formulas with scalable brackets in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=119302 --- Comment #24 from V Stuart Foote --- Created attachment 145859 --> https://bugs.documentfoundation.org/attachment.cgi?id=145859=edit clip of attachment 148857 opened and refreshed in current master/6.2.0 build -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
