[Libreoffice-bugs] [Bug 45904] move java based api tests to c++

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45904

--- Comment #138 from Commit Notification 
 ---
Rahul Gurung committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/9329d18235d21a00dbc724ba3251e95fbb675588%5E%21

tdf#45904 Move _XEnumerationAccess Java Tests to C++

It will be available in 6.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: include/test qadevOOo/objdsc sc/qa test/Library_subsequenttest.mk test/source

2018-11-01 Thread Libreoffice Gerrit user
 include/test/container/xenumerationaccess.hxx|   
34 ++
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScAnnotationsObj.csv |
1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScAreaLinksObj.csv   |
1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScAutoFormatObj.csv  |
1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScCellObj.csv|
1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScCellRangesObj.csv  |
1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotTablesObj.csv |
1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDatabaseRangesObj.csv  |
1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScFunctionListObj.csv|
1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScLabelRangesObj.csv |
1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScScenariosObj.csv   |
1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSubTotalDescriptorBase.csv |
1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTabViewObj.csv |
2 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableConditionalFormat.csv |
1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetsObj.csv |
1 
 sc/qa/extras/scannotationsobj.cxx|
7 +-
 sc/qa/extras/scarealinksobj.cxx  |
7 +-
 sc/qa/extras/scautoformatobj.cxx |
9 ++
 sc/qa/extras/sccellobj.cxx   |
5 +
 sc/qa/extras/sccellrangesobj.cxx |
5 +
 sc/qa/extras/scdatabaserangesobj.cxx |
8 ++
 sc/qa/extras/scdatapilottablesobj.cxx|
8 ++
 sc/qa/extras/scfunctionlistobj.cxx   |
8 ++
 sc/qa/extras/sclabelrangesobj.cxx|
8 ++
 sc/qa/extras/scscenariosobj.cxx  |
8 ++
 sc/qa/extras/scsubtotaldescriptorbaseobj.cxx |   
10 ++
 sc/qa/extras/sctableconditionalformatobj.cxx |
8 ++
 sc/qa/extras/sctablesheetsobj.cxx|
9 ++
 sc/qa/extras/sctabviewobj.cxx|
5 +
 test/Library_subsequenttest.mk   |
1 
 test/source/container/xenumerationaccess.cxx |   
32 +
 31 files changed, 159 insertions(+), 28 deletions(-)

New commits:
commit 9329d18235d21a00dbc724ba3251e95fbb675588
Author: Rahul Gurung 
AuthorDate: Sat Oct 13 00:18:58 2018 +0530
Commit: Markus Mohrhard 
CommitDate: Fri Nov 2 06:29:58 2018 +0100

tdf#45904 Move _XEnumerationAccess Java Tests to C++

Change-Id: Id0aa9f3587fc6427bdbd938293eb3cc564c52bb1
Reviewed-on: https://gerrit.libreoffice.org/61731
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard 

diff --git a/include/test/container/xenumerationaccess.hxx 
b/include/test/container/xenumerationaccess.hxx
new file mode 100644
index ..272172c8d519
--- /dev/null
+++ b/include/test/container/xenumerationaccess.hxx
@@ -0,0 +1,34 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+* This file is part of the LibreOffice project.
+*
+* This Source Code Form is subject to the terms of the Mozilla Public
+* License, v. 2.0. If a copy of the MPL was not distributed with this
+* file, You can obtain one at http://mozilla.org/MPL/2.0/.
+*/
+
+#ifndef INCLUDED_TEST_CONTAINER_XENUMERATIONACCESS_HXX
+#define INCLUDED_TEST_CONTAINER_XENUMERATIONACCESS_HXX
+
+#include 
+#include 
+
+#include 
+
+namespace apitest
+{
+class OOO_DLLPUBLIC_TEST XEnumerationAccess
+{
+public:
+virtual css::uno::Reference init() = 0;
+
+void testCreateEnumeration();
+
+protected:
+~XEnumerationAccess() {}
+};
+}
+
+#endif // INCLUDED_TEST_CONTAINER_XENUMERATIONACCESS_HXX
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScAnnotationsObj.csv 
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScAnnotationsObj.csv
index 09c3b94d5afd..1a785cf0f365 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScAnnotationsObj.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScAnnotationsObj.csv
@@ -2,4 +2,3 @@
 "ScAnnotationsObj";"com::sun::star::container::XIndexAccess";"getByIndex()"
 
"ScAnnotationsObj";"com::sun::star::container::XElementAccess";"getElementType()"
 "ScAnnotationsObj";"com::sun::star::container::XElementAccess";"hasElements()"
-"ScAnnotationsObj";"com::sun::star::container::XEnumerationAccess";"createEnumeration()"
diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScAreaLinksObj.csv 

[Libreoffice-commits] core.git: sc/inc sc/source

2018-11-01 Thread Libreoffice Gerrit user
 sc/inc/editutil.hxx   |   42 +++---
 sc/source/core/tool/editutil.cxx  |6 ++---
 sc/source/filter/rtf/eeimpars.cxx |2 -
 sc/source/ui/app/transobj.cxx |2 -
 sc/source/ui/view/viewfun2.cxx|2 -
 sc/source/ui/view/viewfun4.cxx|2 -
 sc/source/ui/view/viewfunc.cxx|2 -
 7 files changed, 29 insertions(+), 29 deletions(-)

New commits:
commit 68af083f9a8e3904aa3c341da5c598212da68f6f
Author: Paul Trojahn 
AuthorDate: Sat Oct 27 14:52:42 2018 +0200
Commit: Markus Mohrhard 
CommitDate: Fri Nov 2 06:22:33 2018 +0100

tdf#115317 Fix empty url representation

ScTabEditEngine doesn't override CalcFieldValue, so the function in
EditEngine returns a single space as representation. By inheriting from
ScFieldEditEngine the representation is calculated correctly.

Change-Id: I6f3be8bd2c3936acf9f3d082c25c080bd3cbee76
Reviewed-on: https://gerrit.libreoffice.org/62428
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/sc/inc/editutil.hxx b/sc/inc/editutil.hxx
index 8d4a8a9fc282..a6d96ef73c49 100644
--- a/sc/inc/editutil.hxx
+++ b/sc/inc/editutil.hxx
@@ -171,15 +171,33 @@ public:
 voidRepeatDefaults();
 };
 
+// for field commands (or just fields?) in a table
+class SC_DLLPUBLIC ScFieldEditEngine : public ScEditEngineDefaulter
+{
+private:
+ScDocument* const mpDoc;
+bool bExecuteURL;
+
+public:
+ScFieldEditEngine(
+ScDocument* pDoc, SfxItemPool* pEnginePool, SfxItemPool* 
pTextObjectPool = nullptr,
+bool bDeleteEnginePool = false);
+
+void SetExecuteURL(bool bSet){ bExecuteURL = bSet; }
+
+virtual voidFieldClicked( const SvxFieldItem& rField, sal_Int32, 
sal_Int32 ) override;
+virtual OUString CalcFieldValue( const SvxFieldItem& rField, sal_Int32 
nPara, sal_Int32 nPos, boost::optional& rTxtColor, 
boost::optional& rFldColor ) override;
+};
+
 // 1/100 mm
-class SC_DLLPUBLIC ScTabEditEngine : public ScEditEngineDefaulter
+class SC_DLLPUBLIC ScTabEditEngine : public ScFieldEditEngine
 {
 private:
 voidInit(const ScPatternAttr& rPattern);
 public:
 ScTabEditEngine( ScDocument* pDoc );// Default
-ScTabEditEngine( const ScPatternAttr& rPattern,
-SfxItemPool* pEnginePool,
+ScTabEditEngine(const ScPatternAttr& rPattern,
+SfxItemPool *pEngineItemPool, ScDocument *pDoc,
 SfxItemPool* pTextObjectPool = nullptr );
 };
 
@@ -197,24 +215,6 @@ struct ScHeaderFieldData
 ScHeaderFieldData();
 };
 
-// for field commands (or just fields?) in a table
-class SC_DLLPUBLIC ScFieldEditEngine : public ScEditEngineDefaulter
-{
-private:
-ScDocument* const mpDoc;
-bool bExecuteURL;
-
-public:
-ScFieldEditEngine(
-ScDocument* pDoc, SfxItemPool* pEnginePool, SfxItemPool* 
pTextObjectPool = nullptr,
-bool bDeleteEnginePool = false);
-
-void SetExecuteURL(bool bSet){ bExecuteURL = bSet; }
-
-virtual voidFieldClicked( const SvxFieldItem& rField, sal_Int32, 
sal_Int32 ) override;
-virtual OUString CalcFieldValue( const SvxFieldItem& rField, sal_Int32 
nPara, sal_Int32 nPos, boost::optional& rTxtColor, 
boost::optional& rFldColor ) override;
-};
-
 // for headers/footers with fields
 class SC_DLLPUBLIC ScHeaderEditEngine : public ScEditEngineDefaulter
 {
diff --git a/sc/source/core/tool/editutil.cxx b/sc/source/core/tool/editutil.cxx
index 78c46e5f76cc..7b2b7c864d2f 100644
--- a/sc/source/core/tool/editutil.cxx
+++ b/sc/source/core/tool/editutil.cxx
@@ -694,15 +694,15 @@ void ScEditEngineDefaulter::RemoveParaAttribs()
 }
 
 ScTabEditEngine::ScTabEditEngine( ScDocument* pDoc )
-: ScEditEngineDefaulter( pDoc->GetEnginePool() )
+: ScFieldEditEngine( pDoc, pDoc->GetEnginePool() )
 {
 SetEditTextObjectPool( pDoc->GetEditPool() );
 Init(pDoc->GetPool()->GetDefaultItem(ATTR_PATTERN));
 }
 
 ScTabEditEngine::ScTabEditEngine( const ScPatternAttr& rPattern,
-SfxItemPool* pEnginePoolP, SfxItemPool* pTextObjectPool )
-: ScEditEngineDefaulter( pEnginePoolP )
+SfxItemPool* pEngineItemPool, ScDocument* pDoc, SfxItemPool* 
pTextObjectPool )
+: ScFieldEditEngine( pDoc, pEngineItemPool, pTextObjectPool )
 {
 if ( pTextObjectPool )
 SetEditTextObjectPool( pTextObjectPool );
diff --git a/sc/source/filter/rtf/eeimpars.cxx 
b/sc/source/filter/rtf/eeimpars.cxx
index da23becae30c..0cfc8456cd97 100644
--- a/sc/source/filter/rtf/eeimpars.cxx
+++ b/sc/source/filter/rtf/eeimpars.cxx
@@ -68,7 +68,7 @@ ScEEImport::ScEEImport( ScDocument* pDocP, const ScRange& 
rRange ) :
 {
 const ScPatternAttr* pPattern = mpDoc->GetPattern(
 maRange.aStart.Col(), maRange.aStart.Row(), maRange.aStart.Tab() );
-mpEngine.reset( new ScTabEditEngine(*pPattern, mpDoc->GetEditPool(), 
mpDoc->GetEditPool()) );
+mpEngine.reset( new ScTabEditEngine(*pPattern, 

[Libreoffice-bugs] [Bug 121090] Change name (description) of 4th argument to VLOOKUP and HLOOKUP to "Sorted range lookup" in help and in function wizard (see comment 7, comment 9)

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121090

--- Comment #14 from Mike Kaganski  ---
Well, if needed, the first sentence of the 4th param

> Sorted is an optional parameter that indicates whether the first column in
> the array is sorted in ascending order.

could be changed to something like:

> Sorted(RangeLookup) is an optional parameter that indicates whether the first 
> column in the array represents a range list sorted in ascending order.

This actually addresses the valid concern from comment 12.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 121090] Change name (description) of 4th argument to VLOOKUP and HLOOKUP to "Sorted range lookup" in help and in function wizard (see comment 7, comment 9)

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121090

--- Comment #14 from Mike Kaganski  ---
Well, if needed, the first sentence of the 4th param

> Sorted is an optional parameter that indicates whether the first column in
> the array is sorted in ascending order.

could be changed to something like:

> Sorted(RangeLookup) is an optional parameter that indicates whether the first 
> column in the array represents a range list sorted in ascending order.

This actually addresses the valid concern from comment 12.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-commits] core.git: offapi/com

2018-11-01 Thread Libreoffice Gerrit user
 offapi/com/sun/star/rendering/XCanvas.idl |   24 
 1 file changed, 4 insertions(+), 20 deletions(-)

New commits:
commit 7d571ce7956d843c4f7ef442abc736b5b0c74c08
Author: Mark Hung 
AuthorDate: Mon Oct 29 21:02:09 2018 +0800
Commit: Mark Hung 
CommitDate: Fri Nov 2 06:14:17 2018 +0100

offapi: update XCanvas::createFont parameter description.

Recognized parameters of aExtraFontProperties were not implemented as
documented. Update the document to reflect current implementation.

Change-Id: I001beb8843161c7633830b7ec64a79695ea0f091
Reviewed-on: https://gerrit.libreoffice.org/62510
Tested-by: Jenkins
Reviewed-by: Mark Hung 

diff --git a/offapi/com/sun/star/rendering/XCanvas.idl 
b/offapi/com/sun/star/rendering/XCanvas.idl
index 28e2a8fe232e..e393854b756b 100644
--- a/offapi/com/sun/star/rendering/XCanvas.idl
+++ b/offapi/com/sun/star/rendering/XCanvas.idl
@@ -464,26 +464,10 @@ interface XCanvas : ::com::sun::star::uno::XInterface
 @param aExtraFontProperties
 Additional font properties to be applied when selecting this
 font. Normally, you should not need this parameter. Currently,
-the following properties are recognized:
-
--   Kerning: a double between 0 and 1, where
-0 completely disables kerning. Whether kerning is on or
-off by default is font-dependent.
-
--   IsEmphasisMarks: a boolean, where `TRUE`
-enables automatic placements of emphasis marks, e.g. for
-Hebrew. The default value, if this property is not
-specified, is `FALSE`.
-
--   ExpandedSpacing: a double value which is added
-between all cell distances for this font. The default value for
-this property is zero. Use negative values for condensed output,
-and positive values for expanded output.
-
--   OptionalLayoutFeatures: a sequence of
-::com::sun::star::beans::PropertyValue listing
-font-specific optional layout features, like glyph
-variants.
+the following property is recognized:
+
+-   EmphasisMark: long integer that represents the emphasis mark.
+@see ::com::sun::star::awt::FontEmphasisMark
 
 @param aFontMatrix
 Font-specific transformation matrix, which affects both the
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - extras/source

2018-11-01 Thread Libreoffice Gerrit user
 extras/source/gallery/arrows/A25-CurvedArrow-DarkBlue.svg |  123 +-
 1 file changed, 122 insertions(+), 1 deletion(-)

New commits:
commit 872f6652b3a04e5aace520d0cff91262cdf4cff4
Author: andreas kainz 
AuthorDate: Wed Oct 24 17:26:28 2018 +0200
Commit: Markus Mohrhard 
CommitDate: Fri Nov 2 06:08:29 2018 +0100

tdf#120038 Fix broken svg galler arrow A25

Change-Id: I833e4d7bddec89d83ea09fbf677c818988c149ce
Reviewed-on: https://gerrit.libreoffice.org/62312
Tested-by: Jenkins
Reviewed-by: andreas_kainz 
(cherry picked from commit 8e8d89b27167a524d7e591d00e5d1ed20288c964)
Reviewed-on: https://gerrit.libreoffice.org/62514
Tested-by: Xisco Faulí 
Reviewed-by: Markus Mohrhard 

diff --git a/extras/source/gallery/arrows/A25-CurvedArrow-DarkBlue.svg 
b/extras/source/gallery/arrows/A25-CurvedArrow-DarkBlue.svg
index ff85f8dd7117..68d6d9f8eaab 100644
--- a/extras/source/gallery/arrows/A25-CurvedArrow-DarkBlue.svg
+++ b/extras/source/gallery/arrows/A25-CurvedArrow-DarkBlue.svg
@@ -1 +1,122 @@
-http://www.w3.org/2000/svg; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
\ No newline at end of file
+
+http://purl.org/dc/elements/1.1/;
+   xmlns:cc="http://creativecommons.org/ns#;
+   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#;
+   xmlns:svg="http://www.w3.org/2000/svg;
+   xmlns="http://www.w3.org/2000/svg;
+   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd;
+   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape;
+   enable-background="new 0 0 90.958 92.554"
+   height="92.554"
+   viewBox="0 0 90.958 92.554"
+   width="90.958"
+   version="1.1"
+   id="svg30"
+   sodipodi:docname="A25-CurvedArrow-DarkBlue.svg"
+   inkscape:version="0.92.3 (2405546, 2018-03-11)">
+  
+
+  
+image/svg+xml
+http://purl.org/dc/dcmitype/StillImage; />
+  
+
+  
+  
+
+  
+  
+
+
+  
+  
+
+
+  
+
+  
+
+
+  
+  
+
+  
+  
+  
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - cui/source

2018-11-01 Thread Libreoffice Gerrit user
 cui/source/tabpages/tparea.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 925d71995028dd0fa7fe0e120a8cf6a26960641b
Author: Tamás Zolnai 
AuthorDate: Thu Nov 1 12:59:11 2018 +0100
Commit: Markus Mohrhard 
CommitDate: Fri Nov 2 06:06:11 2018 +0100

tdf#121083: EDITOR UI Hatch background color not read back from editor

Reviewed-on: https://gerrit.libreoffice.org/62735
Reviewed-by: Tamás Zolnai 
Tested-by: Tamás Zolnai 
(cherry picked from commit 56d799764d394c906936f7a042dfd3e4219d7063)

Change-Id: Ic64fda8184a4cac244fe992dd72db9d67d35870c
Reviewed-on: https://gerrit.libreoffice.org/62763
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard 

diff --git a/cui/source/tabpages/tparea.cxx b/cui/source/tabpages/tparea.cxx
index dbceed157716..a922ed1b0b78 100644
--- a/cui/source/tabpages/tparea.cxx
+++ b/cui/source/tabpages/tparea.cxx
@@ -201,6 +201,8 @@ void SvxAreaTabPage::ActivatePage( const SfxItemSet& rSet )
 case drawing::FillStyle_HATCH:
 {
 m_rXFSet.Put( rSet.Get(XATTR_FILLHATCH) );
+m_rXFSet.Put( rSet.Get(XATTR_FILLBACKGROUND) );
+m_rXFSet.Put( rSet.Get(XATTR_FILLCOLOR) );
 SelectFillTypeHdl_Impl( m_pBtnHatch );
 break;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - external/libepubgen

2018-11-01 Thread Libreoffice Gerrit user
 external/libepubgen/UnpackedTarball_libepubgen.mk |1 
 external/libepubgen/tdf-120491.patch  |   33 ++
 2 files changed, 34 insertions(+)

New commits:
commit a9b3f8ca95bffe3617da914be99d0ffddb2896ba
Author: Miklos Vajna 
AuthorDate: Wed Oct 24 09:25:35 2018 +0200
Commit: Markus Mohrhard 
CommitDate: Fri Nov 2 06:05:21 2018 +0100

tdf#120491 EPUB export: fix IngramSpark validator error

(cherry picked from commit 548e60a8c47e270aba79a5f4e5911cbb35462814)

Change-Id: I7b6d2217525dbf2e8c9c78a14ea7601c4170857a
Reviewed-on: https://gerrit.libreoffice.org/62355
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard 

diff --git a/external/libepubgen/UnpackedTarball_libepubgen.mk 
b/external/libepubgen/UnpackedTarball_libepubgen.mk
index 14efadb337c0..7553e825284f 100644
--- a/external/libepubgen/UnpackedTarball_libepubgen.mk
+++ b/external/libepubgen/UnpackedTarball_libepubgen.mk
@@ -8,6 +8,7 @@
 #
 
 epubgen_patches :=
+epubgen_patches += tdf-120491.patch
 
 ifeq ($(COM_IS_CLANG),TRUE)
 ifneq ($(filter -fsanitize=%,$(CC)),)
diff --git a/external/libepubgen/tdf-120491.patch 
b/external/libepubgen/tdf-120491.patch
new file mode 100644
index ..2a02a66e4808
--- /dev/null
+++ b/external/libepubgen/tdf-120491.patch
@@ -0,0 +1,33 @@
+From 92760e4b0b8da126029c5ff858ebec27df4acfa8 Mon Sep 17 00:00:00 2001
+Subject: [PATCH] tdf#120491 EPUBHTMLGenerator: remove not needed 
+
+IngramSpark flags this as an error, and not writing it still passes
+epubcheck.
+---
+ src/lib/EPUBHTMLGenerator.cpp | 7 +--
+ 1 file changed, 1 insertion(+), 6 deletions(-)
+
+diff --git a/src/lib/EPUBHTMLGenerator.cpp b/src/lib/EPUBHTMLGenerator.cpp
+index a950ea5..f6c2527 100644
+--- src/lib/EPUBHTMLGenerator.cpp
 src/lib/EPUBHTMLGenerator.cpp
+@@ -579,14 +579,9 @@ void EPUBHTMLGenerator::endDocument()
+ m_impl->m_document.openElement("title", RVNGPropertyList());
+ m_impl->m_document.closeElement("title");
+   }
+-  RVNGPropertyList metaAttrs;
+-  metaAttrs.insert("http-equiv", "content-type");
+-  metaAttrs.insert("content", "text/html; charset=UTF-8");
+-  m_impl->m_document.openElement("meta", metaAttrs);
+-  m_impl->m_document.closeElement("meta");
+   if (m_impl->m_version >= 30 && m_impl->m_layoutMethod == 
EPUB_LAYOUT_METHOD_FIXED)
+   {
+-metaAttrs.clear();
++RVNGPropertyList metaAttrs;
+ metaAttrs.insert("name", "viewport");
+ std::stringstream content;
+ if (const librevenge::RVNGProperty *pageWidth = 
m_impl->m_actualPageProperties["fo:page-width"])
+-- 
+2.16.4
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] cppunit.git: examples/simple include/cppunit

2018-11-01 Thread Libreoffice Gerrit user
 examples/simple/ExampleTestCase.cpp   |   15 +++
 include/cppunit/extensions/HelperMacros.h |   23 +++
 2 files changed, 38 insertions(+)

New commits:
commit 48145587c4c2dc4f1e07d83073e136336c81ce79
Author: Miklos Vajna 
AuthorDate: Fri Oct 12 21:34:07 2018 +0200
Commit: Markus Mohrhard 
CommitDate: Fri Nov 2 06:03:13 2018 +0100

extensions: add CPPUNIT_TEST_FIXTURE()

This is similar to googletest's TEST_F() macro, allows to avoid spelling
out the test name in a suite only once, not 3 times.

Change-Id: I90804d271d046d8158678617d8db75ed6ca7c420
Reviewed-on: https://gerrit.libreoffice.org/61732
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/examples/simple/ExampleTestCase.cpp 
b/examples/simple/ExampleTestCase.cpp
index c45109f..823a8df 100644
--- a/examples/simple/ExampleTestCase.cpp
+++ b/examples/simple/ExampleTestCase.cpp
@@ -45,3 +45,18 @@ void ExampleTestCase::testEquals()
   CPPUNIT_ASSERT_EQUAL( 12, 13 );
   CPPUNIT_ASSERT_DOUBLES_EQUAL( 12.0, 11.99, 0.5 );
 }
+
+class FixtureTest : public CPPUNIT_NS::TestFixture
+{
+};
+
+CPPUNIT_TEST_FIXTURE(FixtureTest, testEquals)
+{
+  CPPUNIT_ASSERT_EQUAL( 12, 12 );
+}
+
+CPPUNIT_TEST_FIXTURE(FixtureTest, testAdd)
+{
+  double result = 2.0 + 2.0;
+  CPPUNIT_ASSERT( result == 4.0 );
+}
diff --git a/include/cppunit/extensions/HelperMacros.h 
b/include/cppunit/extensions/HelperMacros.h
index 4c30319..34be2ca 100644
--- a/include/cppunit/extensions/HelperMacros.h
+++ b/include/cppunit/extensions/HelperMacros.h
@@ -240,6 +240,29 @@ public:
   \
   private: /* dummy typedef so that the macro can still end with ';'*/ 
\
 typedef int CppUnitDummyTypedefForSemiColonEnding__
 
+/*! \brief Define test suite with a single test.
+ *
+ * This macro declares a new test suite with a single test and a single parent
+ * class.  Use CPPUNIT_TEST_SUITE(), CPPUNIT_TEST() and
+ * CPPUNIT_TEST_SUITE_END() instead if you wish to include more tests in the
+ * suite. The benefit of using this macro is that you don't have to declare,
+ * register and define your test name manually, so you don't repeat yourself.
+ *
+ * \param TestClass Base class. This type \b MUST be derived from TestFixture.
+ * \param TestName Name of the test.
+ * \see CPPUNIT_TEST_SUITE, CPPUNIT_TEST, CPPUNIT_TEST_SUITE_END
+ */
+#define CPPUNIT_TEST_FIXTURE(TestClass, TestName)  
\
+class TestName : public TestClass  
\
+{  
\
+public:
\
+void TestBody();   
\
+CPPUNIT_TEST_SUITE(TestName);  
\
+CPPUNIT_TEST(TestBody);
\
+CPPUNIT_TEST_SUITE_END();  
\
+}; 
\
+CPPUNIT_TEST_SUITE_REGISTRATION(TestName); 
\
+void TestName::TestBody()
 
 /*! \brief Add a test to the suite (for custom test macro).
  *
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3' - 2 commits - loolwsd-systemplate-setup

2018-11-01 Thread Libreoffice Gerrit user
 loolwsd-systemplate-setup |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit d861ccb30ce9bf78a76ed6deea4fe14eb22fc5bc
Author: Andras Timar 
AuthorDate: Thu Nov 1 17:20:10 2018 +0100
Commit: Aron Budea 
CommitDate: Fri Nov 2 05:11:57 2018 +0100

systemplate: without /etc/nsswitch.conf, /etc/hosts is not read

Change-Id: Id2bee15425f65064db3125042108a8d0f78fa384
Reviewed-on: https://gerrit.libreoffice.org/62745
Reviewed-by: Aron Budea 
Tested-by: Aron Budea 

diff --git a/loolwsd-systemplate-setup b/loolwsd-systemplate-setup
index c1ff66781..5fbeeb12a 100755
--- a/loolwsd-systemplate-setup
+++ b/loolwsd-systemplate-setup
@@ -22,7 +22,7 @@ cd / || exit 1
 
 # First essential files and shared objects
 find etc/passwd etc/group etc/hosts \
- etc/resolv.conf \
+ etc/resolv.conf etc/nsswitch.conf \
  lib/ld-* lib64/ld-* \
  lib/libcap* lib64/libcap* lib/*-linux-gnu/libcap* \
  lib/libattr* lib/*-linux-gnu/libattr* \
commit 0e74617c26f53786f8fd0331a26bf5ff3fafacde
Author: Andras Timar 
AuthorDate: Tue Oct 30 21:17:53 2018 +0100
Commit: Aron Budea 
CommitDate: Fri Nov 2 05:11:43 2018 +0100

/etc/resolv.conf can be a symlink

Change-Id: I23396e598306b7c8ab1498962ab5c09150c6795b
Reviewed-on: https://gerrit.libreoffice.org/62670
Reviewed-by: Aron Budea 
Tested-by: Aron Budea 

diff --git a/loolwsd-systemplate-setup b/loolwsd-systemplate-setup
index 56ca87d20..c1ff66781 100755
--- a/loolwsd-systemplate-setup
+++ b/loolwsd-systemplate-setup
@@ -42,6 +42,7 @@ find etc/passwd etc/group etc/hosts \
 -type f
 
 find etc/fonts \
+ etc/resolv.conf \
  lib/ld-* lib64/ld-* \
  lib/libnss_* lib64/libnss_* lib/*-linux-gnu/libnss*\
  lib/libcap* lib64/libcap* lib/*-linux-gnu/libcap* \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3' - 2 commits - loleaflet/dist loleaflet/src

2018-11-01 Thread Libreoffice Gerrit user
 loleaflet/dist/toolbar/toolbar.js |4 ++--
 loleaflet/src/control/Control.Tabs.js |2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 07d865704e6c8b32bdda8489cef7aeafe6c3bb9b
Author: Andras Timar 
AuthorDate: Thu Nov 1 10:25:58 2018 +0100
Commit: Aron Budea 
CommitDate: Fri Nov 2 05:11:34 2018 +0100

Font size dropdown placeholder string 'Size' and its translations were too 
long and did not fit

Change-Id: I7950f2411f5f148043390277566b0ecd15961085
Reviewed-on: https://gerrit.libreoffice.org/62720
Reviewed-by: Aron Budea 
Tested-by: Aron Budea 

diff --git a/loleaflet/dist/toolbar/toolbar.js 
b/loleaflet/dist/toolbar/toolbar.js
index e7b4ed8b4..9833cfc91 100644
--- a/loleaflet/dist/toolbar/toolbar.js
+++ b/loleaflet/dist/toolbar/toolbar.js
@@ -805,7 +805,7 @@ function updateFontSizeList(font) {
data = 
data.concat(map.getToolbarCommandValues('.uno:CharFontName')[font]);
$('.fontsizes-select').select2({
data: data,
-   placeholder: _('Size'),
+   placeholder: ' ',
//Allow manually entered font size.
createTag: function(query) {
return {
@@ -1405,7 +1405,7 @@ function updateCommandValues() {
 
if ($('.fontsizes-select option').length === 0) {
$('.fontsizes-select').select2({
-   placeholder: _('Size'),
+   placeholder: ' ',
data: []
});
 
commit 431b307986cbd71ace4ee5894b606705f1e7dcb8
Author: Andras Timar 
AuthorDate: Thu Nov 1 11:21:30 2018 +0100
Commit: Aron Budea 
CommitDate: Fri Nov 2 05:11:22 2018 +0100

loleaflet: Rename Sheet dialog should have the current sheet name in input 
box

Change-Id: I944d4781d551ddb5212bd162935719897f121513
Reviewed-on: https://gerrit.libreoffice.org/62727
Reviewed-by: Aron Budea 
Tested-by: Aron Budea 

diff --git a/loleaflet/src/control/Control.Tabs.js 
b/loleaflet/src/control/Control.Tabs.js
index 76e2f946e..d38f13f74 100644
--- a/loleaflet/src/control/Control.Tabs.js
+++ b/loleaflet/src/control/Control.Tabs.js
@@ -63,7 +63,7 @@ L.Control.Tabs = L.Control.extend({
var nPos = 
parseInt(options.$trigger.attr('id').split('spreadsheet-tab')[1]);

vex.dialog.open({

message: _('Enter new sheet name'),
-   input: 
'',
+   input: 
'',

callback: function(data) {

map.renamePage(data.sheetname, nPos);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 84507] FORMATING: Text does not fit to contour in rotated polygon or bézier curve

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=84507

--- Comment #11 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 109004] External form does not save the path to database any more.

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109004

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113561] In LO CALC it is not possible to integrate the SOLVER into a macro by recording a macro

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113561

--- Comment #2 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61274] PDF EXPORT Links are off by one page if presentation includes (unexported) hidden slides.

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=61274

--- Comment #9 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 71501] EDITING: “Enter“ in first Cell of Table Creates a Paragraph above Table

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=71501

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 92771] "run macros" dialog shows libraries in wrong section

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=92771

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112644] UI: Disable "New Master" and "Delete Master" commands in slide pane and slide sorter view

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112644

--- Comment #2 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105404] Draw very slow dividing vector graphic

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105404

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112693] LibO will access share\config\images_tango.zip for every cell when typing something into it (since LibO5.0.0.5)

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112693

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113565] Adding page break before table that crosses over multiple pages cause table to not render/function correctly

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113565

--- Comment #3 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121105] the current() function is confused if used inside or()

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121105

himajin100...@gmail.com changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|NEEDINFO|RESOLVED

--- Comment #6 from himajin100...@gmail.com ---
I believe m.a.riosv's explanation on comment 5 is correct. This is not a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121113] New: LibreOffice won’t run on macOS when CFR font is installed

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121113

Bug ID: 121113
   Summary: LibreOffice won’t run on macOS when CFR font is
installed
   Product: LibreOffice
   Version: 6.1.2.1 release
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: hatsc...@gmail.com

Description:
MacOS supports the Composite Font Representation, a format for composing a
single logical font from several font files to circumvent OpenType’s
65,535-glyph limit. When a CFR font is installed, LibreOffice fails to start.

Steps to Reproduce:
1. Download and install the CFR font Hanazono Mincho and its component fonts:
https://github.com/cjkvi/HanaMinAFDKO/releases/download/8.030/HanaMin.sfont
https://github.com/cjkvi/HanaMinAFDKO/releases/download/8.030/HanaMinA.otf
https://github.com/cjkvi/HanaMinAFDKO/releases/download/8.030/HanaMinB.otf
https://github.com/cjkvi/HanaMinAFDKO/releases/download/8.030/HanaMinC.otf
2. Try to open LibreOffice.

( The issue can also be reproduced with the sample font “Unicode CFR” found
here: http://blogs.adobe.com/CCJKType/2012/07/cfr-support-in-mountain-lion.html
)

Actual Results:
LibreOffice exits before the splash screen would appear. If run from the
console, it prints “Application Error”. After deleting any CFR fonts,
LibreOffice runs normally again.

Expected Results:
CFR fonts should be supported or, if that’s too much trouble, ignored.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 6.1.2.1
Build ID: 65905a128db06ba48db947242809d14d3f9a93fe
CPU threads: 4; OS: Mac OS X 10.14; UI render: default; 
Locale: en-US (en_US.UTF-8); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121112] New: split line position not restored correctly (xlsx)

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121112

Bug ID: 121112
   Summary: split line position not restored correctly (xlsx)
   Product: LibreOffice
   Version: 6.0.1.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: perlan...@gmail.com

Steps to reproduce:

1. Create a new spreadsheet

2. Drag the split line, e.g. the vertical split line to the right of column A
and the horizontal split line to the bottom of row 1.

3. Save as XLSX

4. Close the spreadsheet

5. Reopen. The split lines position is now at ~column E, row 7.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121108] context menu shape and color support for recent colors

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121108

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #1 from Regina Henschel  ---
Are you aware that shapes in Writer and Calc currently have no style but only
direct formatting?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 98446] Hide Whitespace option grayed-out intermittently

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=98446

Michal Suchánek  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTABUG |---

--- Comment #19 from Michal Suchánek  ---
Why can't "Hide Whitespace" switch to single page view as well?

Or is the LO UX design goal to be as asinine as possible?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 37967] VIEWING: Option like "MS WORD's normal view" needed

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=37967

Michal Suchánek  changed:

   What|Removed |Added

 CC||msucha...@suse.de

--- Comment #19 from Michal Suchánek  ---
*** Bug 121107 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121107] "hide whitespace" not persistent

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121107

Michal Suchánek  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Michal Suchánek  ---


*** This bug has been marked as a duplicate of bug 37967 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 37967] VIEWING: Option like "MS WORD's normal view" needed

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=37967

Michal Suchánek  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |---
 Status|RESOLVED|REOPENED

--- Comment #18 from Michal Suchánek  ---
Still not working in  6.1.3.1

Web view is pretty close (unlike "Hide Whitespace") but neither is proper view: 

 - missing in view selector on the bottom toolbar - not discovearble
 - not remembered across restart

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: android/source

2018-11-01 Thread Libreoffice Gerrit user
 android/source/res/layout/toolbar_bottom.xml   
   |4 +-
 android/source/res/values-tr/strings.xml   
   |   19 --
 android/source/res/values/arrays.xml   
   |4 +-
 android/source/res/values/strings.xml  
   |   13 ++
 android/source/src/java/org/libreoffice/FormattingController.java  
   |4 +-
 android/source/src/java/org/libreoffice/LOKitTileProvider.java 
   |   16 
 android/source/src/java/org/libreoffice/LibreOfficeMainActivity.java   
   |6 +--
 android/source/src/java/org/libreoffice/overlay/DocumentOverlayView.java   
   |3 +
 
android/source/src/java/org/libreoffice/storage/external/BrowserSelectorActivity.java
 |3 +
 android/source/src/java/org/libreoffice/ui/PageView.java   
   |2 -
 10 files changed, 52 insertions(+), 22 deletions(-)

New commits:
commit 1239dce2595877ad64fd8c8fd927ea4285d69abe
Author: Mert Tumer 
AuthorDate: Thu Nov 1 22:03:31 2018 +0300
Commit: Gülşah Köse 
CommitDate: Fri Nov 2 01:33:22 2018 +0100

[Pardus] language improvements on Android

More hardcoded strings extrated to the resource file
Few Turkish language improvements
This patch is sponsored by ULAKBIM/Pardus project.
Signed-off-by: Mert Tumer 

Change-Id: I9c49d1b8ec3dfc88a19832a2cdea2c7cbaf2be42
Reviewed-on: https://gerrit.libreoffice.org/62757
Tested-by: Jenkins
Reviewed-by: Gülşah Köse 

diff --git a/android/source/res/layout/toolbar_bottom.xml 
b/android/source/res/layout/toolbar_bottom.xml
index bfe5f74828b3..6fc85ea96290 100644
--- a/android/source/res/layout/toolbar_bottom.xml
+++ b/android/source/res/layout/toolbar_bottom.xml
@@ -365,7 +365,7 @@
 
 Satırları öncekine ekle
 Satırları sonrakine ekle
-Kolonları öncekine ekle
-Kolonları sonrakine ekle
+Sütunları öncekine ekle
+Sütunları sonrakine ekle
 Tablo Ekle
 
 
 Satır Sil
-Kolon Sil
+Sütun Sil
 Tablo Sil
 
 
@@ -227,4 +227,17 @@
 Varsayılan dosya filtrelemesini 
seç
 Uygulama Dili
 Varsayılan dili değiştir
+Unable to export to pdf
+Exported to PDF at
+Your device does not support 
printing
+Hata
+Bölüm ismi girin.
+Bmp boş!
+Dizin kaydedilmedi.
+Sayfa
+Tablo
+Slide
+Bölüm
+Vurgulama Rengi
+Metin Rengi
 
diff --git a/android/source/res/values/arrays.xml 
b/android/source/res/values/arrays.xml
index 5912f08900b9..3b2c71c3dadc 100644
--- a/android/source/res/values/arrays.xml
+++ b/android/source/res/values/arrays.xml
@@ -26,8 +26,8 @@
 
 
 
-Grid
-List
+@string/grid_view
+@string/list_view
 
 
 0
diff --git a/android/source/res/values/strings.xml 
b/android/source/res/values/strings.xml
index 99a6d809f042..123751b8ee3b 100644
--- a/android/source/res/values/strings.xml
+++ b/android/source/res/values/strings.xml
@@ -227,4 +227,17 @@
 Set which file filter should be used by 
default.
 Display Language
 Set the default display 
language
+Unable to export to pdf
+Exported to PDF at
+Your device does not support 
printing
+Error
+Enter a part name
+Bmp is null!
+Directory not saved.
+Page
+Sheet
+Slide
+Part
+Highlight Color
+Font Color
 
diff --git a/android/source/src/java/org/libreoffice/FormattingController.java 
b/android/source/src/java/org/libreoffice/FormattingController.java
index 691c3d06513f..63b4cc53ad35 100644
--- a/android/source/src/java/org/libreoffice/FormattingController.java
+++ b/android/source/src/java/org/libreoffice/FormattingController.java
@@ -305,7 +305,7 @@ class FormattingController implements View.OnClickListener {
 
 AlertDialog.Builder insertBuilder = new AlertDialog.Builder(mContext);
 insertBuilder.setTitle(R.string.select_insert_options);
-insertBuilder.setNeutralButton("Cancel", null);
+insertBuilder.setNeutralButton(R.string.alert_cancel, null);
 final int[] selectedItem = new int[1];
 
insertBuilder.setSingleChoiceItems(mContext.getResources().getStringArray(R.array.insertrowscolumns),
 -1, new DialogInterface.OnClickListener() {
 @Override
@@ -313,7 +313,7 @@ class FormattingController implements View.OnClickListener {
 selectedItem[0] = which;
 }
 });
-insertBuilder.setPositiveButton("OK", new 
DialogInterface.OnClickListener() {
+insertBuilder.setPositiveButton(R.string.alert_ok, new 
DialogInterface.OnClickListener() {
 @Override
 public void onClick(DialogInterface dialog, int which) {
 switch (selectedItem[0]){

[Libreoffice-commits] core.git: android/source

2018-11-01 Thread Libreoffice Gerrit user
 
android/source/src/java/org/libreoffice/storage/local/LocalDocumentsDirectoryProvider.java
 |3 ---
 android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java  
|   10 +-
 2 files changed, 5 insertions(+), 8 deletions(-)

New commits:
commit 187a3db08ecc0e42787aa57d8b4ed67aa9c37e74
Author: Mert Tumer 
AuthorDate: Wed Oct 24 11:41:25 2018 +0300
Commit: Gülşah Köse 
CommitDate: Fri Nov 2 01:31:59 2018 +0100

Fix permission settings on Android Viewer

We ask READ_EXTERNAL_STORAGE permission on first start
then check WRITE_EXTERNAL_STORAGE permission on switching
between document providers. This causes problems on Android 8+
Signed-off-by: Mert Tumer 

Change-Id: Ia7290e33b2a55f5a2197374ca39c60998edfff72
Reviewed-on: https://gerrit.libreoffice.org/62269
Reviewed-by: Christian Lohmaier 
Tested-by: Jenkins

diff --git 
a/android/source/src/java/org/libreoffice/storage/local/LocalDocumentsDirectoryProvider.java
 
b/android/source/src/java/org/libreoffice/storage/local/LocalDocumentsDirectoryProvider.java
index c2e03dfc7bdd..15522e93a45e 100644
--- 
a/android/source/src/java/org/libreoffice/storage/local/LocalDocumentsDirectoryProvider.java
+++ 
b/android/source/src/java/org/libreoffice/storage/local/LocalDocumentsDirectoryProvider.java
@@ -48,9 +48,6 @@ public class LocalDocumentsDirectoryProvider extends 
LocalDocumentsProvider {
 public IFile getRootDirectory(Context context) {
 File documentsDirectory = getDocumentsDir();
 if (!documentsDirectory.exists()) {
-// might be a little counter-intuitive: if we were granted READ 
permission already, we're also granted the write-permission
-// when we ask for it, since they are both in the same storage 
group (for 5.1 and lower it is granted at install-time already)
-// see 
https://developer.android.com/guide/topics/permissions/requesting.html#perm-groups
 if (ContextCompat.checkSelfPermission(context, 
Manifest.permission.WRITE_EXTERNAL_STORAGE) == 
PackageManager.PERMISSION_GRANTED) {
 if(!documentsDirectory.mkdirs()) {
 // fallback to the toplevel dir - might be due to the dir 
not mounted/used as USB-Mass-Storage or similar
diff --git 
a/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java 
b/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
index d6501f08bd85..3fb715e46778 100644
--- a/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
+++ b/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
@@ -99,7 +99,7 @@ public class LibreOfficeUIActivity extends AppCompatActivity 
implements Settings
 private String displayLanguage;
 
 // dynamic permissions IDs
-private static final int PERMISSION_READ_EXTERNAL_STORAGE = 0;
+private static final int PERMISSION_WRITE_EXTERNAL_STORAGE = 0;
 
 FileFilter fileFilter;
 FilenameFilter filenameFilter;
@@ -949,11 +949,11 @@ public class LibreOfficeUIActivity extends 
AppCompatActivity implements Settings
 @Override
 protected void onStart() {
 super.onStart();
-if (ContextCompat.checkSelfPermission(this, 
Manifest.permission.READ_EXTERNAL_STORAGE) != 
PackageManager.PERMISSION_GRANTED) {
+if (ContextCompat.checkSelfPermission(this, 
Manifest.permission.WRITE_EXTERNAL_STORAGE) != 
PackageManager.PERMISSION_GRANTED) {
 Log.i(LOGTAG, "no permission to read external storage - asking for 
permission");
 ActivityCompat.requestPermissions(this,
-new String[]{Manifest.permission.READ_EXTERNAL_STORAGE},
-PERMISSION_READ_EXTERNAL_STORAGE);
+new String[]{Manifest.permission.WRITE_EXTERNAL_STORAGE},
+PERMISSION_WRITE_EXTERNAL_STORAGE);
 } else {
 
switchToDocumentProvider(documentProviderFactory.getDefaultProvider());
 setEditFABVisibility(View.VISIBLE);
@@ -1207,7 +1207,7 @@ public class LibreOfficeUIActivity extends 
AppCompatActivity implements Settings
 @Override
 public void onRequestPermissionsResult(int requestCode, @NonNull String[] 
permissions, @NonNull int[] grantResults) {
 switch(requestCode){
-case PERMISSION_READ_EXTERNAL_STORAGE:
+case PERMISSION_WRITE_EXTERNAL_STORAGE:
 if(permissions.length>0 && grantResults[0] == 
PackageManager.PERMISSION_GRANTED){
 
switchToDocumentProvider(documentProviderFactory.getDefaultProvider());
 setEditFABVisibility(View.VISIBLE);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 104716] General performance problems - UI freezes, slow scrolling, etc. in files with big/complex images

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104716

--- Comment #51 from Samson Yeung  ---
I don't know why you say it is 2 different bugs. My description is consistent
with e.g. comment 35.
Firstly, what i claimed is that the bug can be found in all version 6.
Secondly, Version 5.4.7 perform normally.
I haven't made any test for version 3 to version 5.3 which have been found
buggy in other comments.
Deduced and summerized from all the comments, version 5.4 should be affected
least.
The bug in question, namely, slow scrolling (mouse wheel or page up/down or
scrollbar) in odt editing.
Am i get it right.
I have a sample file.But it is all in tradtional chinese. Maybe you'll find
difficult to use.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 90039] Calc diagrams should be exportable as PDF from the “Export as Graphic” context menu command

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90039

--- Comment #11 from Robert Pollak  ---
I still see that PDF is listed among the possible types in the "Save as Image"
dialog, but it creates an empty file.

Version: 6.0.6.2
Build-ID: 1:6.0.6-0ubuntu0.18.04.1
CPU-Threads: 2; BS: Linux 4.15; UI-Render: Standard; VCL: gtk3; 
Gebietsschema: de-AT (de_AT.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 114947] FORMATTING: Context Menu, Font Colour / Color

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114947

andreas_k  changed:

   What|Removed |Added

 CC||kain...@gmail.com

--- Comment #2 from andreas_k  ---
does this really work. For me font color open always the format cell dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg

2018-11-01 Thread Libreoffice Gerrit user
 icon-themes/colibre/sc/res/sidebar/CellBorder.png  
|binary
 icon-themes/colibre/sc/res/sidebar/CellBorder_All_18x18.png
|binary
 icon-themes/colibre/sc/res/sidebar/CellBorder_Bottom_18x18.png 
|binary
 icon-themes/colibre/sc/res/sidebar/CellBorder_Bottom_Double_18x18.png  
|binary
 icon-themes/colibre/sc/res/sidebar/CellBorder_Bottom_Thick_18x18.png   
|binary
 icon-themes/colibre/sc/res/sidebar/CellBorder_Empty_18x18.png  
|binary
 icon-themes/colibre/sc/res/sidebar/CellBorder_FourBorders_18x18.png
|binary
 icon-themes/colibre/sc/res/sidebar/CellBorder_FourBorders_Thick_18x18.png  
|binary
 icon-themes/colibre/sc/res/sidebar/CellBorder_LeftAndRight_18x18.png   
|binary
 icon-themes/colibre/sc/res/sidebar/CellBorder_LeftDiagonal_18x18.png   
|binary
 icon-themes/colibre/sc/res/sidebar/CellBorder_Left_18x18.png   
|binary
 icon-themes/colibre/sc/res/sidebar/CellBorder_RightDiagonal_18x18.png  
|binary
 icon-themes/colibre/sc/res/sidebar/CellBorder_Right_18x18.png  
|binary
 icon-themes/colibre/sc/res/sidebar/CellBorder_TopAndBottom_18x18.png   
|binary
 icon-themes/colibre/sc/res/sidebar/CellBorder_TopSingle_BottomDouble_18x18.png 
|binary
 icon-themes/colibre/sc/res/sidebar/CellBorder_TopThin_BottomThick_18x18.png
|binary
 icon-themes/colibre/sc/res/sidebar/CellBorder_Top_18x18.png
|binary
 icon-themes/colibre/svx/res/fr010.png  
|binary
 icon-themes/colibre/svx/res/fr011.png  
|binary
 icon-themes/colibre/svx/res/fr012.png  
|binary
 icon-themes/colibre/svx/res/fr02.png   
|binary
 icon-themes/colibre/svx/res/fr03.png   
|binary
 icon-themes/colibre/svx/res/fr04.png   
|binary
 icon-themes/colibre/svx/res/fr05.png   
|binary
 icon-themes/colibre/svx/res/fr06.png   
|binary
 icon-themes/colibre/svx/res/fr07.png   
|binary
 icon-themes/colibre/svx/res/fr08.png   
|binary
 icon-themes/colibre/svx/res/fr09.png   
|binary
 icon-themes/colibre/svx/res/pr01.png   
|binary
 icon-themes/colibre/svx/res/pr010.png  
|binary
 icon-themes/colibre/svx/res/pr011.png  
|binary
 icon-themes/colibre/svx/res/pr012.png  
|binary
 icon-themes/colibre/svx/res/pr013.png  
|binary
 icon-themes/colibre/svx/res/pr014.png  
|binary
 icon-themes/colibre/svx/res/pr015.png  
|binary
 icon-themes/colibre/svx/res/pr016.png  
|binary
 icon-themes/colibre/svx/res/pr017.png  
|binary
 icon-themes/colibre/svx/res/pr018.png  
|binary
 icon-themes/colibre/svx/res/pr019.png  
|binary
 icon-themes/colibre/svx/res/pr02.png   
|binary
 icon-themes/colibre/svx/res/pr020.png  
|binary
 icon-themes/colibre/svx/res/pr021.png  
|binary
 icon-themes/colibre/svx/res/pr03.png   
|binary
 icon-themes/colibre/svx/res/pr04.png   
|binary
 icon-themes/colibre/svx/res/pr05.png   
|binary
 icon-themes/colibre/svx/res/pr06.png   
|binary
 icon-themes/colibre/svx/res/pr07.png   
|binary
 icon-themes/colibre/svx/res/pr08.png   
|binary
 icon-themes/colibre/svx/res/pr09.png   
|binary
 icon-themes/colibre_svg/sc/res/sidebar/CellBorder.svg  
|   44 +--
 icon-themes/colibre_svg/sc/res/sidebar/CellBorder_All_18x18.svg
|   61 +-
 icon-themes/colibre_svg/sc/res/sidebar/CellBorder_Bottom_18x18.svg 
|2 
 icon-themes/colibre_svg/sc/res/sidebar/CellBorder_Bottom_Double_18x18.svg  
|2 
 

[Libreoffice-bugs] [Bug 121090] Change name (description) of 4th argument to VLOOKUP and HLOOKUP to "Sorted range lookup" in help and in function wizard (see comment 7, comment 9)

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121090

--- Comment #13 from Olivier Hallot  ---
The help content for VLOOKUP is quite precise.

en-US
https://help.libreoffice.org/6.2/en-US/text/scalc/01/04060109.html?DbPAR=CALC#bm_id3153152

es
https://help.libreoffice.org/6.2/es/text/scalc/01/04060109.html?DbPAR=CALC#bm_id3153152

eo
https://help.libreoffice.org/6.2/eo/text/scalc/01/04060109.html?=CALC=UNIX#Section9

I don't see any need for changing the name of the parameters. If absolutely
needed, I'll choose "SortedRangeLookup", + adjust the help pages and the UI
dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 121090] Change name (description) of 4th argument to VLOOKUP and HLOOKUP to "Sorted range lookup" in help and in function wizard (see comment 7, comment 9)

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121090

--- Comment #13 from Olivier Hallot  ---
The help content for VLOOKUP is quite precise.

en-US
https://help.libreoffice.org/6.2/en-US/text/scalc/01/04060109.html?DbPAR=CALC#bm_id3153152

es
https://help.libreoffice.org/6.2/es/text/scalc/01/04060109.html?DbPAR=CALC#bm_id3153152

eo
https://help.libreoffice.org/6.2/eo/text/scalc/01/04060109.html?=CALC=UNIX#Section9

I don't see any need for changing the name of the parameters. If absolutely
needed, I'll choose "SortedRangeLookup", + adjust the help pages and the UI
dialog.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 50045] FILESAVE Cannot 'Save graphics' from OLE object

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=50045

andreas_k  changed:

   What|Removed |Added

 CC||kain...@gmail.com

--- Comment #6 from andreas_k  ---
How do you add the OLE object / image?

when I add an image via insert ole the image was move to an draw file which can
be exported as draw file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 114164] EPUB Export: Headings Levels other than Heading 1 are omitted in Outline

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114164

--- Comment #7 from Michael Bauer  ---
I can confirm this bug is still around in 6.1.2.1. Which is a shame because LO
otherwise produces nice and clean epubs off doc/odt files. I tried calibre on
the doc I was trying to convert and while it did TOC levels 2 and 3 correctly,
it messed up the graphics in the process.
Is there perhaps something in the calibre code that could inform a way of
fixing this in LO?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121111] FILESAVE: DOC/RTF: Paragraph fill becomes blue after roundtrip

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=12

Xisco Faulí  changed:

   What|Removed |Added

 CC||jl...@mail.com,
   ||xiscofa...@libreoffice.org
   Keywords||bibisected, bisected,
   ||regression
 Status|UNCONFIRMED |NEW
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=90
   ||906
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=7d9e9ecd5bb5d5abec338c2ceb61ad623d2ac5cb

tdf#90906 writerfilter: Allow COL_AUTO to override non-auto 13/59313/4
author  Justin Luth  
Wed, 22 Aug 2018 07:25:37 +0100 (09:25 +0300)
committer   Miklos Vajna   
Wed, 5 Sep 2018 09:17:32 +0100 (10:17 +0200)
commit  7d9e9ecd5bb5d5abec338c2ceb61ad623d2ac5cb
tree1117a7f8fdbe9a6264f2a81392cb5020e028cc5e
parent  1d4f03114f3fb04fc1b493193e3eddee07cdabb8

Bisected with: bibisect-linux64-6.2

Adding Cc: to Justin Luth

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121111] New: FILESAVE: DOC/RTF: Paragraph fill becomes blue after roundtrip

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=12

Bug ID: 12
   Summary: FILESAVE: DOC/RTF: Paragraph fill becomes blue after
roundtrip
   Product: LibreOffice
   Version: 6.2.0.0.alpha1+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Steps to reproduce:
1. Open attachment 119583 from bug 95032
2. Save it as .DOC or .RTF
3. Reopen the new file

-> all paragraph have a blue background. Not reproduced saving to .ODT or .DOCX

Reproduced in

Version: 6.2.0.0.alpha1+
Build ID: 4326fb3ef3ddd7c6f9d08ba96add4f4736503ceb
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: threaded

[Bug found by office-interoperability-tools]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51267] after removing registrymodifications.xcu the existing user/basic/dialog.xlc and scrip.xlc are overwritten and existing user libraries seem lost

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=51267

--- Comment #19 from Cor Nouws  ---
(In reply to Oliver Brinzing from comment #17)
> i can not confirm this bug with lo 6.1.
> after deleting "registrymodifications.xcu", user my two basic libraries
> "Standard" and "Library1" are still available after restarting lo:

(In reply to Cor Nouws from comment #0)
> Check this in a installation with some additional Basic libraries
> make a backup of the user/basic/dialog.xlc and scrip.xlc files :-)

Does that make sense ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116085] Cannot start Certificate Manager with GPG4win v3

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116085

Cor Nouws  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105605
Bug 105605 depends on bug 116085, which changed state.

Bug 116085 Summary: Cannot start Certificate Manager with GPG4win v3
https://bugs.documentfoundation.org/show_bug.cgi?id=116085

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: 2 commits - configure.ac .gitignore Mobile/Mobile Mobile/Mobile.xcodeproj Mobile/README

2018-11-01 Thread Libreoffice Gerrit user
 .gitignore  |8 
 Mobile/Mobile.xcodeproj/project.pbxproj |  438 +++-
 Mobile/README   |   19 -
 configure.ac|  136 +
 4 files changed, 358 insertions(+), 243 deletions(-)

New commits:
commit d381540db56ad99d4e79862ac6fdb6ccffbb815f
Author: Tor Lillqvist 
AuthorDate: Fri Nov 2 01:13:17 2018 +0200
Commit: Tor Lillqvist 
CommitDate: Fri Nov 2 01:13:17 2018 +0200

Update Mobile/README to match new configury mechanism for the iOS app

Change-Id: I7d7f1d53823f0215024537fa65f00a163c7b61e5

diff --git a/Mobile/README b/Mobile/README
index 989faa002..b2f62c3a8 100644
--- a/Mobile/README
+++ b/Mobile/README
@@ -50,20 +50,11 @@ Then run:
 
 and
 
-./configure --enable-iosapp --with-iosapp-name="My Own Mobile LibreOffice"
+./configure --enable-iosapp --with-iosapp-name="My Own Mobile LibreOffice" 
--with-lo-srcdir=$HOME/lo/ios --with-lo-builddir=$HOME/lo/ios 
--with-poco-includes=/opt/ios-poco/include --with-poco-libs=/opt/ios-poco/lib
 
-The only purpose of running the configure script in this tree is to
-get the app name as the CFBundleDisplayName property into the
-Mobile/Mobile/Info.plist file.
-
-Sure, as we require editing the project.pbxproj file anyway, we could
-as well also require editing the Info.plist file and avoid having to
-run the configure script.
-
-Or maybe the other way around, should we also have the configure
-script expand the project.pbxproj file, passing the configure script
-pointers to the LibreOffice source and build directories, and POCO and
-PNG install directories. Those would then expaned in project.pbxproj,
-and it wouldn't need to be hand-edited.
+The configure script puts the app name as the CFBundleDisplayName
+property into the Mobile/Mobile/Info.plist file, and set up some
+symbolic links that point to the LIbreOffice core source and build
+directories (which can be the same, of course).
 
 4) Now you can open the Mobile Xcode project, build it, and run it.
commit 5f2a6f6aa3a0d0ba8a6ba2fb833f98393f94bb9f
Author: Tor Lillqvist 
AuthorDate: Fri Nov 2 00:37:01 2018 +0200
Commit: Tor Lillqvist 
CommitDate: Fri Nov 2 01:08:37 2018 +0200

Avoid need for manual editing of the iOS app Xcode project file

Since some days, you need to run the configure script in a tree where
you are going to build the iOS app anyway (to set the app's
user-visible name). Use the configure script to set up a couple of
symbolic links pointing to the LibreOffice core source and build
directories and the Poco installation. Use those symbolic links in the
project file.

Also, now a vendor-specific app icon set can be given with the
--with-iosapp-appicon option.

Change-Id: Ib936388a4cc680bd97ca6ef95a91e3296ab04d18

diff --git a/.gitignore b/.gitignore
index 72bc7664d..110ab9b6c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -81,3 +81,11 @@ docker/instdir
 docker/builddir
 
 Mobile/Mobile/Info.plist
+
+# symlinks created by configure for the iOS app Xcode project
+losrcdir-symlink
+lobuilddir-symlink
+pocoinclude-symlink
+pocolib-symlink
+ICU.dat
+Mobile/Mobile/Assets.xcassets/AppIcon.appiconset
diff --git a/Mobile/Mobile.xcodeproj/project.pbxproj 
b/Mobile/Mobile.xcodeproj/project.pbxproj
index 8739933a2..e719f46d7 100644
--- a/Mobile/Mobile.xcodeproj/project.pbxproj
+++ b/Mobile/Mobile.xcodeproj/project.pbxproj
@@ -30,7 +30,7 @@
BE5EB5D421400DC100E0826C /* DocumentBroker.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = BE5EB5D321400DC100E0826C /* DocumentBroker.cpp 
*/; };
BE5EB5D621401E0F00E0826C /* Storage.cpp in Sources */ = {isa = 
PBXBuildFile; fileRef = BE5EB5D521401E0F00E0826C /* Storage.cpp */; };
BE5EB5DA2140363100E0826C /* ios.mm in Sources */ = {isa = 
PBXBuildFile; fileRef = BE5EB5D92140363100E0826C /* ios.mm */; };
-   BE5EB5DC2140480B00E0826C /* icudt63l.dat in Resources */ = {isa 
= PBXBuildFile; fileRef = BE5EB5DB2140480B00E0826C /* icudt63l.dat */; };
+   BE5EB5DC2140480B00E0826C /* ICU.dat in Resources */ = {isa = 
PBXBuildFile; fileRef = BE5EB5DB2140480B00E0826C /* ICU.dat */; };
BE6362C22153B5B500F4237E /* MobileCoreServices.framework in 
Frameworks */ = {isa = PBXBuildFile; fileRef = BE6362C12153B5B500F4237E /* 
MobileCoreServices.framework */; };
BE8D772C2136762500AC58EA /* AppDelegate.mm in Sources */ = {isa 
= PBXBuildFile; fileRef = BE8D772B2136762500AC58EA /* AppDelegate.mm */; };
BE8D772F2136762500AC58EA /* DocumentBrowserViewController.mm in 
Sources */ = {isa = PBXBuildFile; fileRef = BE8D772E2136762500AC58EA /* 
DocumentBrowserViewController.mm */; };
@@ -72,52 +72,52 @@
BE00F89E21396585001CE2D4 /* images */ = {isa = 
PBXFileReference; lastKnownFileType = folder; name = images; path = 
../../../loleaflet/dist/images; sourceTree = ""; };
 

[Libreoffice-bugs] [Bug 119714] Contextmenu Chart: pagebreak

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119714

andreas_k  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120721] Select object also outside of page canvas

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120721

--- Comment #15 from Cor Nouws  ---
thanks for explaining, 和尚蟹

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 86349] [META] Context menu bugs and enhancements

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=86349
Bug 86349 depends on bug 119714, which changed state.

Bug 119714 Summary: Contextmenu Chart: pagebreak
https://bugs.documentfoundation.org/show_bug.cgi?id=119714

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 119714] Contextmenu Chart: pagebreak

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119714

andreas_k  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-ux-advise] [Bug 120721] Select object also outside of page canvas

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120721

--- Comment #15 from Cor Nouws  ---
thanks for explaining, 和尚蟹

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-ux-advise] [Bug 119714] Contextmenu Chart: pagebreak

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119714

andreas_k  changed:

   What|Removed |Added

 CC||kain...@gmail.com

--- Comment #2 from andreas_k  ---
You have to switch in Menubar -> View -> Page break

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 119714] Contextmenu Chart: pagebreak

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119714

andreas_k  changed:

   What|Removed |Added

 CC||kain...@gmail.com

--- Comment #2 from andreas_k  ---
You have to switch in Menubar -> View -> Page break

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121104] FIREBIRD: No connection to external Firebird-file in Windows possible

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121104

Drew Jensen  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #5 from Drew Jensen  ---
(In reply to Gerhard Weydt from comment #4)
> Can confirm with 6.1.3.2
> 
> and also with 6.2:
> Version: 6.2.0.0.alpha0+ (x64)
> Build ID: 89a60912bba7ffd6f65ea99f4664f343c5025c95
> CPU threads: 4; OS: Windows 10.0; UI render: GL; 
> TinderBox: Win-x86_64@42, Branch:master, Time: 2018-10-01_03:18:33
> Locale: de-DE (de_DE); Calc: threaded


I believe this is a duplicate of "Firebird: Link is formed to an external file
with file:///C: (three slash)"
https://bugs.documentfoundation.org/show_bug.cgi?id=115547 also windows only.

*** This bug has been marked as a duplicate of bug 115547 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115547] Firebird: Link is formed to an external file with file:///C: (three slash)

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115547

--- Comment #21 from Drew Jensen  ---
*** Bug 121104 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120156] One or more form fields of FORMCHECKBOX and FORMFIELD give problems with copy-paste / autotext

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120156

Cor Nouws  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME
 CC||c...@nouenoff.nl

--- Comment #4 from Cor Nouws  ---
indeed. My mistake to file this. Apologies!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121109] FILESAVE: Page break is added after removed paragraph

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121109

Xisco Faulí  changed:

   What|Removed |Added

Summary|FILESAVE: DOCX/RTF: Page|FILESAVE: Page break is
   |break is added after|added after removed
   |removed paragraph   |paragraph

--- Comment #2 from Xisco Faulí  ---
Same problem reproduced with attachment 75459 from bug 61410 if it's saved to
.ODT

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 86349] [META] Context menu bugs and enhancements

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=86349
Bug 86349 depends on bug 119713, which changed state.

Bug 119713 Summary: contextmenu Chart: row and colm header
https://bugs.documentfoundation.org/show_bug.cgi?id=119713

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 119713] contextmenu Chart: row and colm header

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119713

andreas_k  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 119713] contextmenu Chart: row and colm header

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119713

andreas_k  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 121110] FILEOPEN: Bidi text is aligned to the left

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121110

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||6174

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121110] FILEOPEN: Bidi text is aligned to the left

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121110

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||jl...@mail.com
   Keywords||bibisected, bisected,
   ||regression

--- Comment #2 from Xisco Faulí  ---
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=85818da3307a28b2d9c6fa5c1c97ca7833dfe24c

author  Justin Luth  2018-07-11 22:37:00 +0300
committer   Justin Luth2018-08-22 06:14:28
+0200
commit  85818da3307a28b2d9c6fa5c1c97ca7833dfe24c (patch)
tree7f1fb56846401ded0c1fb06161fbc4005331456f
parent  cbce9044b075f22a936c8a15bacf3cb57130c984 (diff)
tdf#106174 ww8import: bidi - prev adjust? prev bidi?

Bisected with: bibisect-linux64-6.2

Adding Cc: to Justin Luth

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121110] FILEOPEN: Bidi text is aligned to the left

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121110

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Created attachment 146239
  --> https://bugs.documentfoundation.org/attachment.cgi?id=146239=edit
Comparison

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121110] New: FILEOPEN: Bidi text is aligned to the left

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121110

Bug ID: 121110
   Summary: FILEOPEN: Bidi text is aligned to the left
   Product: LibreOffice
   Version: 6.2.0.0.alpha1+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Created attachment 146238
  --> https://bugs.documentfoundation.org/attachment.cgi?id=146238=edit
sample file

Steps to reproduce:
1. Open attached document

-> See all lines aligned to the left. Some of them should be aligned to the
right.

Reproduced in

Version: 6.2.0.0.alpha1+
Build ID: 4326fb3ef3ddd7c6f9d08ba96add4f4736503ceb
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: threaded

[Bug found by office-interoperability-tools]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/uiconfig

2018-11-01 Thread Libreoffice Gerrit user
 sw/uiconfig/sglobal/popupmenu/text.xml |   17 +
 sw/uiconfig/sweb/popupmenu/text.xml|   17 +
 sw/uiconfig/swriter/popupmenu/text.xml |   17 +
 sw/uiconfig/swxform/popupmenu/text.xml |   17 +
 4 files changed, 20 insertions(+), 48 deletions(-)

New commits:
commit 6acde4a63176e99c287c8d8ab9498c003e138025
Author: andreas kainz 
AuthorDate: Thu Nov 1 22:31:23 2018 +0100
Commit: andreas_kainz 
CommitDate: Thu Nov 1 23:56:04 2018 +0100

Context Menu: Remove Comment section in sw modules

Change-Id: Id82af299502f92fe9024ab552505f086dffe9c71
Reviewed-on: https://gerrit.libreoffice.org/62762
Tested-by: Jenkins
Reviewed-by: andreas_kainz 

diff --git a/sw/uiconfig/sglobal/popupmenu/text.xml 
b/sw/uiconfig/sglobal/popupmenu/text.xml
index f93e1bf17f30..f3fda1a6973d 100644
--- a/sw/uiconfig/sglobal/popupmenu/text.xml
+++ b/sw/uiconfig/sglobal/popupmenu/text.xml
@@ -75,18 +75,11 @@
   
 
   
-  
-
-  
-  
-  
-  
-  
-  
-  
-  
-
-  
+  
+  
+  
+  
+  
   
   
   
diff --git a/sw/uiconfig/sweb/popupmenu/text.xml 
b/sw/uiconfig/sweb/popupmenu/text.xml
index f93e1bf17f30..f3fda1a6973d 100644
--- a/sw/uiconfig/sweb/popupmenu/text.xml
+++ b/sw/uiconfig/sweb/popupmenu/text.xml
@@ -75,18 +75,11 @@
   
 
   
-  
-
-  
-  
-  
-  
-  
-  
-  
-  
-
-  
+  
+  
+  
+  
+  
   
   
   
diff --git a/sw/uiconfig/swriter/popupmenu/text.xml 
b/sw/uiconfig/swriter/popupmenu/text.xml
index f93e1bf17f30..f3fda1a6973d 100644
--- a/sw/uiconfig/swriter/popupmenu/text.xml
+++ b/sw/uiconfig/swriter/popupmenu/text.xml
@@ -75,18 +75,11 @@
   
 
   
-  
-
-  
-  
-  
-  
-  
-  
-  
-  
-
-  
+  
+  
+  
+  
+  
   
   
   
diff --git a/sw/uiconfig/swxform/popupmenu/text.xml 
b/sw/uiconfig/swxform/popupmenu/text.xml
index f93e1bf17f30..f3fda1a6973d 100644
--- a/sw/uiconfig/swxform/popupmenu/text.xml
+++ b/sw/uiconfig/swxform/popupmenu/text.xml
@@ -75,18 +75,11 @@
   
 
   
-  
-
-  
-  
-  
-  
-  
-  
-  
-  
-
-  
+  
+  
+  
+  
+  
   
   
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 86349] [META] Context menu bugs and enhancements

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=86349
Bug 86349 depends on bug 119711, which changed state.

Bug 119711 Summary: contextmenu Chart: sheettab.xml
https://bugs.documentfoundation.org/show_bug.cgi?id=119711

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 119711] contextmenu Chart: sheettab.xml

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119711

andreas_k  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 119711] contextmenu Chart: sheettab.xml

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119711

andreas_k  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120711] FILEOPEN: tracking changes: Paragraph after numbering list is added to the list

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120711

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||1109

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121109] FILESAVE: DOCX/RTF: Page break is added after removed paragraph

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121109

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||0711
 CC||kelem...@ubuntu.com,
   ||nem...@numbertext.org,
   ||xiscofa...@libreoffice.org
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=1bbbe57dfc0b43d6b5444798d77dcdf5e4e76e49

author  László Németh2018-08-28 21:13:09 +0200
committer   László Németh2018-09-05 07:48:59
+0200
commit  1bbbe57dfc0b43d6b5444798d77dcdf5e4e76e49 (patch)
tree52b256c96845b7082d916c255cbaa77594da4aa2
parent  22639148ae5400bac98f32a75d7431b857c80195 (diff)
tdf#119571 change tracking: show layout changes at paragraph join

Bisected with: bibisect-linux64-6.2

Adding Cc: to László Németh

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121109] New: FILESAVE: DOCX/RTF: Page break is added after removed paragraph

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121109

Bug ID: 121109
   Summary: FILESAVE: DOCX/RTF: Page break is added after removed
paragraph
   Product: LibreOffice
   Version: 6.2.0.0.alpha1+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Created attachment 146237
  --> https://bugs.documentfoundation.org/attachment.cgi?id=146237=edit
sample file

Steps to reproduce:
1. Open attached document
2. Save it as DOCX or RTF
3. Open the new file

-> There's a page break after the first deleted paragraph.

Reproduced in

Version: 6.2.0.0.alpha0+
Build ID: 5fb66ae5595b7435e8954df31473fad15a74b8c2
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: en-US (ca_ES.UTF-8); Calc: threaded

[Bug found by office-interoperability-tools]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: desktop/source

2018-11-01 Thread Libreoffice Gerrit user
 desktop/source/lib/init.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit bee3790d547506500dc195eebfa8735bb8fba2d9
Author: Tor Lillqvist 
AuthorDate: Thu Nov 1 23:28:03 2018 +0200
Commit: Tor Lillqvist 
CommitDate: Fri Nov 2 00:35:10 2018 +0200

We now use a fixed name ICU data file in the iOS app

That makes it much easier to use the same Xcode project file when
building against different versions of LibreOffice, with different ICU
data files. The configure script in the "online" directory creates a
ICU.dat symlink to the ICU data file (with a name like icudt60l.dat in
a 6.0 branch, or icudt63l.dat in a current master) in the LibreOffice
build directory, and that is what gets copied into the app bundle.

Change-Id: Ibe2ca85f66e2d4973d6ba3c52fc4d60e113d8f9a

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 040218c1e314..fca76934088c 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -4103,9 +4103,9 @@ static int lo_initialize(LibreOfficeKit* pThis, const 
char* pAppPath, const char
 // to use that.
 NSString *bundlePath = [[NSBundle mainBundle] bundlePath];
 
-int fd = open([[bundlePath 
stringByAppendingPathComponent:@U_ICUDATA_NAME".dat"] UTF8String], O_RDONLY);
+int fd = open([[bundlePath stringByAppendingPathComponent:@"ICU.dat"] 
UTF8String], O_RDONLY);
 if (fd == -1)
-NSLog(@"Could not open ICU data file %s", [[bundlePath 
stringByAppendingPathComponent:@U_ICUDATA_NAME".dat"] UTF8String]);
+NSLog(@"Could not open ICU data file %s", [[bundlePath 
stringByAppendingPathComponent:@"ICU.dat"] UTF8String]);
 else
 {
 struct stat st;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 119526] Multiselect Contextmenu for all apps

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119526

--- Comment #5 from andreas_k  ---
>From maintenance point of view I would recommend to reduce the different
context menus to a minimum and have in all modules the same context menus not
that it's different in each app (which mean also to know where which context
menu do things).

This bug can be closed if Maxim don't see an benefit.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/source

2018-11-01 Thread Libreoffice Gerrit user
 vcl/source/gdi/impglyphitem.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 9cdcc1b7df5bbd0262a1335bd2f3bc8713e19c97
Author: Tor Lillqvist 
AuthorDate: Fri Nov 2 00:05:02 2018 +0200
Commit: Tor Lillqvist 
CommitDate: Fri Nov 2 00:06:08 2018 +0200

Fix iOS build

Change-Id: I7e7ca6290929629db04472129bf80ea204cf0d69

diff --git a/vcl/source/gdi/impglyphitem.cxx b/vcl/source/gdi/impglyphitem.cxx
index d3aa10ebd1b3..55b1fbd5136e 100644
--- a/vcl/source/gdi/impglyphitem.cxx
+++ b/vcl/source/gdi/impglyphitem.cxx
@@ -19,7 +19,7 @@
 
 #include 
 
-#if (defined UNX && !defined MACOSX)
+#if (defined UNX && !defined MACOSX && !defined IOS)
 #include 
 #endif
 
@@ -62,7 +62,7 @@ bool SalGenericLayoutGlyphsImpl::IsValid() const
 return false;
 if (empty())
 return false;
-#if (defined UNX && !defined MACOSX)
+#if (defined UNX && !defined MACOSX && !defined IOS)
 const FreetypeFontInstance* pFFI = 
dynamic_cast(m_rFontInstance.get());
 if (pFFI && !pFFI->GetFreetypeFont())
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 107635] Text Box context menu missing Text Attributes command

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107635

--- Comment #14 from andreas_k  ---
If possible I'd like to close this bug and have the styles support as written
in BUG 121108

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121108] New: context menu shape and color support for recent colors

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121108

Bug ID: 121108
   Summary: context menu shape and color support for recent colors
   Product: LibreOffice
   Version: 6.2.0.0.alpha1+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kain...@gmail.com

I add styles support for text context menu. You can add defined styles for text
and can add also additional styles via configuration menu.

Have this functionality for shapes would be awesome, but there I would prefer
to have all used document shape styles so that you can use always the same
styles.

draw a shape
-> right click
-> style
   -> recent document style list

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121107] New: "hide whitespace" not persistent

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121107

Bug ID: 121107
   Summary: "hide whitespace" not persistent
   Product: LibreOffice
   Version: 6.1.3.1 rc
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: msucha...@suse.de

To reproduce:

1) open a text document

2) select View->Hide Whitespace

3) close LO

4) open a text document

Expected: "Hide Whitespace" mode active

Actual: single page mode active

This would be much more manageable if "Hide whitespace" was not a hack on top
of "single page" view but instead a separate "continuous" view without paging.
Then the "continuous" view mode can be remembered as the other view modes and
numerous bugs that result from abusing the "single page" mode for emulation of
"continuous" mode can be resolved.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121103] Version: 6.1.2.1 Build ID: 65905a128db06ba48db947242809d14d3f9a93fe

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121103

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
Please rephrase the title, to explain in breve the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107635] Text Box context menu missing Text Attributes command

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107635

--- Comment #13 from andreas_k  ---
Hi 

I add in master text context menu styles support to text in writer and calc. So
you can style text, paragraph, table, ... with right click without any code
change. I think it's a good plan and the right way to go.

On my todo list support for shape styles, colors, ... are planned, but
therefore styles support has to get some improvement. Recent Styles would be
also nice.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121105] the current() function is confused if used inside or()

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121105

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #5 from m.a.riosv  ---
What seems a in issue I think it's not, in
=A1+STYLE(IF(OR(CURRENT() > 4, CURRENT() <3),"green","red"))
the second CURRENT() receive their value from the first CURRENT() comparison.

A formula like
=A1+STYLE(IF(O(CURRENT() > 4; CURRENT());"green";"red"))
gives red except for 5.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 111860] FILESAVE: footer elements (page number, date, footer text) are not exported to Microsoft PPTX-format (it is saved to PPT)

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111860

Cor Nouws  changed:

   What|Removed |Added

Version|5.4.0.3 release |4.0.0.3 release
   Severity|normal  |major
 Whiteboard||interoperability
 CC||c...@nouenoff.nl
Summary|FILESAVE: errors when   |FILESAVE: footer elements
   |saving to PPTX - page   |(page number, date, footer
   |number lost in footer   |text) are not exported to
   ||Microsoft PPTX-format (it
   ||is saved to PPT)

--- Comment #9 from Cor Nouws  ---
see also https://bugs.documentfoundation.org/show_bug.cgi?id=117339#c3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 98958] "Hide Whitespace" changes pagination by adding the top and bottom margins to the editing area

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=98958

--- Comment #4 from Michal Suchánek  ---
On 6.1.3.1 the page length increases when text is added after the last line on
a (non-last) page while in hide whitespace mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94074] If you select an image direct after caption was selected, imagerelated entries in contextmenu are missing

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94074

andreas_k  changed:

   What|Removed |Added

 CC||kain...@gmail.com

--- Comment #8 from andreas_k  ---
can be reproduced in master (6.2)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 95487] Hide whitespace mode: entered characters are not displayed.

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=95487

Michal Suchánek  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #3 from Michal Suchánek  ---
Cannot reproduce with 6.1.3.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121106] New: Saved letters open as a blank page without being delegated. What are you doing - or not doing

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121106

Bug ID: 121106
   Summary: Saved letters open as a blank page without being
delegated.  What are you doing - or not doing
   Product: LibreOffice
   Version: 6.1.2.1 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: prkellyfromariz...@outlook.com

Description:
Saved letters open as a blank page without being delegated.  What are you doing
- or not doing.  I can find no way to recover the information.  What can I do?

Steps to Reproduce:
1.Try to open the blank pages.
2.
3.

Actual Results:
Try to open the blank pages.

Expected Results:
A blank page


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: StartModule
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: yes

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 58114] LibreOffice Impress, when saving a picture using "Save as Picture..." the former folder is not remembered

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=58114

andreas_k  changed:

   What|Removed |Added

 CC||kain...@gmail.com

--- Comment #2 from andreas_k  ---
didn't find this function in 6.1 or master, does someone know the uno command?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121105] the current() function is confused if used inside or()

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121105

--- Comment #4 from Jiří Boháč  ---
(In reply to Xavier Van Wijmeersch from comment #3)
> try these one

Thanks for the tip, but my actual use case was something much more complicated,
the above formulas are just minimalist reproducers created to help get the bug
fixed.

I actually worked around the problem by replacing IF(OR(a,b),x,y) with this
nested IF(a,x,IF(b,x,y)). Both conditions, a and b, use CURRENT() and it works.
So it seems it's really the combination of OR() and CURRENT() that is broken.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121105] the current() function is confused if used inside or()

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121105

--- Comment #3 from Xavier Van Wijmeersch  ---
=A1+STYLE(IF(CURRENT()<>3,"green","red"))

try these one

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - ios/source

2018-11-01 Thread Libreoffice Gerrit user
 ios/source/ios.cxx |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit a97e3a59644a8c30486e4ade1bd883ee26a0282d
Author: Tor Lillqvist 
AuthorDate: Wed Oct 31 20:30:24 2018 +0200
Commit: Tor Lillqvist 
CommitDate: Thu Nov 1 22:32:39 2018 +0100

Handle also css::ucb::NameClashException

Change-Id: I979a163e796418d9a693229698b638cec4bf2226
Reviewed-on: https://gerrit.libreoffice.org/62708
Reviewed-by: Tor Lillqvist 
Tested-by: Tor Lillqvist 

diff --git a/ios/source/ios.cxx b/ios/source/ios.cxx
index 36aaa245f76d..bc89150e7ed6 100644
--- a/ios/source/ios.cxx
+++ b/ios/source/ios.cxx
@@ -8,9 +8,11 @@
  */
 
 #include 
+#include 
 
 #include "com/sun/star/uno/Any.hxx"
 #include "com/sun/star/ucb/InteractiveAugmentedIOException.hpp"
+#include "com/sun/star/ucb/NameClashException.hpp"
 #include "ios/ios.hxx"
 
 namespace
@@ -28,8 +30,12 @@ void lo_ios_throwException(css::uno::Any const& aException)
 assert(aException.getValueTypeClass() == css::uno::TypeClass_EXCEPTION);
 
 tryThrow(aException);
+tryThrow(aException);
 tryThrow(aException);
 
+std::cerr << "lo_ios_throwException: Unhandled exception type " << 
aException.getValueTypeName()
+  << std::endl;
+
 assert(false);
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-ux-advise] [Bug 121090] Change name (description) of 4th argument to VLOOKUP and HLOOKUP to "Sorted range lookup" in help and in function wizard (see comment 7, comment 9)

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121090

--- Comment #12 from gmoll...@us.es ---
"and range, order vs. sort... not a big difference"
If the user reads "Ordered" he may think that if the list is ordered he has to
put True. But no, the list could be ordered but the type of search needed could
be exact using False as the fourth parameter.

Si el usuario lee "Ordenado" puede pensar que si la lista es ordenada tiene que
poner Verdadero. Pero no, la lista podría estar ordenada pero el tipo de
búsqueda necesitada podría ser exacta usando Falso como cuarto parámetro.

Se la uzanto legas "Ordonita" li eble pensas, ke se la listo estas ordigita, li
devas meti Vera. Sed ne, la listo povus esti ordigita sed la tipo de serĉo
bezonata povus esti ĝusta uzante Falsa en la kvara parametro.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 121090] Change name (description) of 4th argument to VLOOKUP and HLOOKUP to "Sorted range lookup" in help and in function wizard (see comment 7, comment 9)

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121090

--- Comment #12 from gmoll...@us.es ---
"and range, order vs. sort... not a big difference"
If the user reads "Ordered" he may think that if the list is ordered he has to
put True. But no, the list could be ordered but the type of search needed could
be exact using False as the fourth parameter.

Si el usuario lee "Ordenado" puede pensar que si la lista es ordenada tiene que
poner Verdadero. Pero no, la lista podría estar ordenada pero el tipo de
búsqueda necesitada podría ser exacta usando Falso como cuarto parámetro.

Se la uzanto legas "Ordonita" li eble pensas, ke se la listo estas ordigita, li
devas meti Vera. Sed ne, la listo povus esti ordigita sed la tipo de serĉo
bezonata povus esti ĝusta uzante Falsa en la kvara parametro.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - configure.ac

2018-11-01 Thread Libreoffice Gerrit user
 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0531d203ffd0ff085d10c308d929e8653dd29f70
Author: Tor Lillqvist 
AuthorDate: Wed Oct 31 20:27:45 2018 +0200
Commit: Tor Lillqvist 
CommitDate: Thu Nov 1 22:31:04 2018 +0100

Current iOS SDK is 12.1

It sucks that configure.ac nowadays looks for exactly one specific
version of the iOS SDK. I don't understand why that was thought to be
a good idea.

Change-Id: I5b67e17c627735bbafffc8177f1422813a33e034
Reviewed-on: https://gerrit.libreoffice.org/62707
Reviewed-by: Tor Lillqvist 
Tested-by: Tor Lillqvist 

diff --git a/configure.ac b/configure.ac
index 65b5dc8e9847..a964a00e44d7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2863,7 +2863,7 @@ dnl 
===
 
 if test $_os = iOS; then
 AC_MSG_CHECKING([what iOS SDK to use])
-current_sdk_ver=12.0
+current_sdk_ver=12.1
 if test "$enable_ios_simulator" = "yes"; then
 platform=iPhoneSimulator
 versionmin=-mios-simulator-version-min=$current_sdk_ver
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sd/uiconfig

2018-11-01 Thread Libreoffice Gerrit user
 sd/uiconfig/sdraw/menubar/menubar.xml |   54 +-
 1 file changed, 28 insertions(+), 26 deletions(-)

New commits:
commit 4a93d8dbdce90c60b2b3c4eb176ccc66af4f69f3
Author: andreas kainz 
AuthorDate: Thu Nov 1 21:23:12 2018 +0100
Commit: andreas_kainz 
CommitDate: Thu Nov 1 22:24:58 2018 +0100

Draw menubar: Spahe section update

Change-Id: Ia378a3375ba8fb0e3a9b446bd891466dfcf4bdbf
Reviewed-on: https://gerrit.libreoffice.org/62758
Tested-by: Jenkins
Reviewed-by: andreas_kainz 

diff --git a/sd/uiconfig/sdraw/menubar/menubar.xml 
b/sd/uiconfig/sdraw/menubar/menubar.xml
index b61dbf62b83d..64e2dd268bd3 100644
--- a/sd/uiconfig/sdraw/menubar/menubar.xml
+++ b/sd/uiconfig/sdraw/menubar/menubar.xml
@@ -487,20 +487,19 @@
 
   
   
-  
-  
+  
 
-  
-  
-  
-  
-  
-  
-  
-  
-  
+  
+  
+  
+  
+  
+  
+  
 
   
+  
+  
   
 
   
@@ -512,22 +511,25 @@
   
 
   
-  
-  
-  
-  
-  
-  
-  
-  
+  
 
-  
-  
-  
-  
-  
-  
-  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+
+  
+  
+
+  
+  
+  
+  
 
   
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 61850] PDF: Exporting forms to PDF mis-formats in Adobe reader

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=61850

--- Comment #32 from Paul Simmonds  ---
Can confirm bug is still present

Version: 6.1.2.1 (x64)
Build ID: 65905a128db06ba48db947242809d14d3f9a93fe
CPU threads: 6; OS: Windows 10.0; UI render: default; 
Locale: en-GB (en_GB); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61850] PDF: Exporting forms to PDF mis-formats in Adobe reader

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=61850

--- Comment #31 from Paul Simmonds  ---
Can confirm bug is still present

Version: 6.1.2.1 (x64)
Build ID: 65905a128db06ba48db947242809d14d3f9a93fe
CPU threads: 6; OS: Windows 10.0; UI render: default; 
Locale: en-GB (en_GB); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: 3 commits - configure.ac gtk/mobile.cpp gtk/README wsd/LOOLWSD.cpp

2018-11-01 Thread Libreoffice Gerrit user
 configure.ac|   20 +++---
 gtk/README  |2 -
 gtk/mobile.cpp  |   62 +++-
 wsd/LOOLWSD.cpp |8 +++
 4 files changed, 70 insertions(+), 22 deletions(-)

New commits:
commit 698b806e232bdffb7f61ee0734f7a0079993f134
Author: Michael Meeks 
AuthorDate: Thu Nov 1 21:22:01 2018 +
Commit: Michael Meeks 
CommitDate: Thu Nov 1 21:23:15 2018 +

gtk: compile fixes for socket latency and version display.

Change-Id: I4ff4bcb54d8c1227feeb19b281c38e1769ed83e7

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 8d89e65e5..7af8b7311 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -1330,10 +1330,12 @@ void LOOLWSD::handleOption(const std::string& 
optionName,
 if (masterPort)
 MasterPortNumber = std::stoi(masterPort);
 
+#ifndef MOBILEAPP
 static const char* latencyMs = std::getenv("LOOL_DELAY_SOCKET_MS");
 if (latencyMs)
 SimulatedLatencyMs = std::stoi(latencyMs);
 #endif
+#endif
 
 #ifdef FUZZER
 if (optionName == "dummy-lok")
@@ -1553,8 +1555,10 @@ bool LOOLWSD::createForKit()
 if (UnitWSD::get().hasKitHooks())
 args.push_back("--unitlib=" + UnitTestLibrary);
 
+#ifndef MOBILEAPP
 if (DisplayVersion)
 args.push_back("--version");
+#endif
 
 if (NoCapsForKit)
 args.push_back("--nocaps");
@@ -2807,8 +2811,10 @@ class SslSocketFactory final : public SocketFactory
 {
 int fd = physicalFd;
 
+#ifndef MOBILEAPP
 if (SimulatedLatencyMs > 0)
 fd = Delay::create(SimulatedLatencyMs, physicalFd);
+#endif
 
 return StreamSocket::create(
 fd, false, std::make_shared());
@@ -3052,6 +3058,7 @@ int LOOLWSD::innerMain()
 // down-pay all the forkit linking cost once & early.
 Environment::set("LD_BIND_NOW", "1");
 
+#ifndef MOBILEAPP
 if (DisplayVersion)
 {
 std::string version, hash;
@@ -3059,6 +3066,7 @@ int LOOLWSD::innerMain()
 LOG_INF("Loolwsd version details: " << version << " - " << hash);
 }
 #endif
+#endif
 
 initializeSSL();
 
commit 647150427e295f312deed6c9464f801b00820698
Author: Michael Meeks 
AuthorDate: Thu Nov 1 21:21:04 2018 +
Commit: Michael Meeks 
CommitDate: Thu Nov 1 21:23:12 2018 +

gtk: compile with older WebKit JS interface too.

Change-Id: I62ce96932b77ea8051cfb2862cb4f617d2804c1d

diff --git a/gtk/mobile.cpp b/gtk/mobile.cpp
index a819972cb..0797fd9c6 100644
--- a/gtk/mobile.cpp
+++ b/gtk/mobile.cpp
@@ -36,6 +36,9 @@
 
 #include 
 #include 
+#if !WEBKIT_CHECK_VERSION(2,22,0)
+#  include
+#endif
 
 #include "FakeSocket.hpp"
 #include "Log.hpp"
@@ -133,27 +136,55 @@ static void send2JS(const std::vector& buffer)
}, jscopy);
 }
 
-static void handle_debug_message(WebKitUserContentManager *manager,
- WebKitJavascriptResult   *js_result,
- gpointer  user_data)
+static char *js_result_as_gstring(WebKitJavascriptResult *js_result)
 {
+#if WEBKIT_CHECK_VERSION(2,22,0) // unclear when this API changed ...
 JSCValue *value = webkit_javascript_result_get_js_value(js_result);
 if (jsc_value_is_string(value))
-LOG_TRC_NOFILE("From JS: debug: " << jsc_value_to_string(value));
+return jsc_value_to_string(value);
+else
+return nullptr;
+#else // older Webkits
+JSValueRef value = webkit_javascript_result_get_value(js_result);
+JSContextRef ctx = webkit_javascript_result_get_global_context(js_result);
+if (JSValueIsString(ctx, value))
+{
+const JSStringRef js_str = JSValueToStringCopy(ctx, value, nullptr);
+size_t gstring_max = JSStringGetMaximumUTF8CStringSize(js_str);
+char *gstring = (char *)g_malloc(gstring_max);
+if (gstring)
+JSStringGetUTF8CString(js_str, gstring, gstring_max);
+else
+LOG_TRC_NOFILE("No string");
+JSStringRelease(js_str);
+return gstring;
+}
 else
-LOG_TRC_NOFILE("From JS: debug: some object");
+LOG_TRC_NOFILE("Unexpected object type " << JSValueGetType(ctx, 
value));
+return nullptr;
+#endif
+}
+
+static void handle_message(const char * type, WebKitJavascriptResult 
*js_result)
+{
+gchar *string_value = js_result_as_gstring(js_result);
+
+if (string_value)
+LOG_TRC_NOFILE("From JS: " << type << ": " << string_value);
+else
+LOG_TRC_NOFILE("From JS: " << type << ": some object");
+
+g_free(string_value);
 }
 
 static void handle_lool_message(WebKitUserContentManager *manager,
 WebKitJavascriptResult   *js_result,
 gpointer  user_data)
 {
-JSCValue *value = webkit_javascript_result_get_js_value(js_result);
+gchar *string_value = js_result_as_gstring(js_result);
 
-if (jsc_value_is_string(value))
+if (string_value)
 {
-

[Libreoffice-commits] core.git: include/sfx2 include/vcl sfx2/source sw/inc sw/source sw/uiconfig vcl/inc vcl/qt5 vcl/source vcl/unx

2018-11-01 Thread Libreoffice Gerrit user
 include/sfx2/basedlgs.hxx|   43 -
 include/sfx2/childwin.hxx|8 -
 include/vcl/dialog.hxx   |7 
 include/vcl/weld.hxx |6 
 sfx2/source/appl/childwin.cxx|   73 +++--
 sfx2/source/appl/workwin.cxx |   85 +--
 sfx2/source/dialog/basedlgs.cxx  |  126 
 sfx2/source/inc/workwin.hxx  |   11 +
 sw/inc/swabstdlg.hxx |4 
 sw/inc/viewsh.hxx|   14 -
 sw/source/core/view/viewsh.cxx   |   30 ++-
 sw/source/ui/dialog/swdlgfact.cxx|   19 +-
 sw/source/ui/dialog/swdlgfact.hxx|   17 +-
 sw/source/ui/dialog/wordcountdialog.cxx  |  114 +--
 sw/source/uibase/dialog/wordcountwrapper.cxx |   10 -
 sw/source/uibase/inc/wordcountdialog.hxx |   41 ++---
 sw/source/uibase/uiview/viewport.cxx |4 
 sw/uiconfig/swriter/ui/wordcount.ui  |8 -
 vcl/inc/qt5/Qt5Frame.hxx |1 
 vcl/inc/salframe.hxx |5 
 vcl/inc/unx/gtk/gtkframe.hxx |1 
 vcl/inc/window.h |4 
 vcl/qt5/Qt5Frame.cxx |7 
 vcl/source/app/salvtables.cxx|   43 +
 vcl/source/window/builder.cxx|   14 +
 vcl/source/window/dialog.cxx |  203 +++
 vcl/source/window/syswin.cxx |4 
 vcl/unx/gtk3/gtk3gtkframe.cxx|7 
 vcl/unx/gtk3/gtk3gtkinst.cxx |  101 -
 29 files changed, 725 insertions(+), 285 deletions(-)

New commits:
commit 26c375671aa362b2f59d84645784938677ae1719
Author: Caolán McNamara 
AuthorDate: Thu Oct 4 12:41:22 2018 +0100
Commit: Caolán McNamara 
CommitDate: Thu Nov 1 22:12:33 2018 +0100

weld SwWordCountFloatDlg

enable modeless dialogs to emit a response so runAsync can be used with
them and get something called when the dialog is dismissed

Change-Id: Ie9603bcc063cefabbae635949671baf06620785d
Reviewed-on: https://gerrit.libreoffice.org/61383
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/include/sfx2/basedlgs.hxx b/include/sfx2/basedlgs.hxx
index d4279599fe4b..1c3e2b37caa6 100644
--- a/include/sfx2/basedlgs.hxx
+++ b/include/sfx2/basedlgs.hxx
@@ -107,6 +107,41 @@ public:
 DECL_LINK(TimerHdl, Timer *, void);
 };
 
+class SFX2_DLLPUBLIC SfxDialogController : public weld::GenericDialogController
+{
+private:
+DECL_DLLPRIVATE_LINK(InstallLOKNotifierHdl, void*, 
vcl::ILibreOfficeKitNotifier*);
+public:
+SfxDialogController(weld::Widget* pParent, const OUString& rUIFile, const 
OString& rDialogId);
+};
+
+class SfxModelessDialog_Impl;
+class SFX2_DLLPUBLIC SfxModelessDialogController : public SfxDialogController
+{
+SfxBindings* m_pBindings;
+std::unique_ptr m_xImpl;
+
+SfxModelessDialogController(SfxModelessDialogController&) = delete;
+void operator =(SfxModelessDialogController&) = delete;
+
+void Init(SfxBindings *pBindinx, SfxChildWindow *pCW);
+
+DECL_DLLPRIVATE_LINK(FocusInHdl, weld::Widget&, void);
+DECL_DLLPRIVATE_LINK(FocusOutHdl, weld::Widget&, void);
+protected:
+SfxModelessDialogController(SfxBindings*, SfxChildWindow* pChildWin,
+weld::Window* pParent, const OUString& rUIXMLDescription, const 
OString& rID);
+virtual ~SfxModelessDialogController() override;
+
+public:
+virtual voidFillInfo(SfxChildWinInfo&) const;
+voidInitialize (SfxChildWinInfo const * pInfo);
+voidClose();
+voidDeInit();
+voidEndDialog();
+SfxBindings&GetBindings() { return *m_pBindings; }
+};
+
 // class SfxFloatingWindow --
 class SfxFloatingWindow_Impl;
 class SFX2_DLLPUBLIC SfxFloatingWindow: public FloatingWindow
@@ -188,14 +223,6 @@ private:
 std::unique_ptr   pImpl;
 };
 
-class SFX2_DLLPUBLIC SfxDialogController : public weld::GenericDialogController
-{
-private:
-DECL_DLLPRIVATE_LINK(InstallLOKNotifierHdl, void*, 
vcl::ILibreOfficeKitNotifier*);
-public:
-SfxDialogController(weld::Widget* pParent, const OUString& rUIFile, const 
OString& rDialogId);
-};
-
 class SFX2_DLLPUBLIC SfxSingleTabDialogController : public SfxDialogController
 {
 private:
diff --git a/include/sfx2/childwin.hxx b/include/sfx2/childwin.hxx
index 8c46889e533f..9a12bf896071 100644
--- a/include/sfx2/childwin.hxx
+++ b/include/sfx2/childwin.hxx
@@ -143,9 +143,10 @@ public:
 
 class SFX2_DLLPUBLIC SfxChildWindow
 {
-VclPtrpParent;// parent window ( Topwindow )
-sal_uInt16 const   nType;  // ChildWindow-Id
+VclPtrpParent; // parent window ( 

[Libreoffice-commits] core.git: reportdesign/source

2018-11-01 Thread Libreoffice Gerrit user
 reportdesign/source/ui/dlg/DateTime.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit d611d5535b818854f9c6c6d4c144c2e5a9155a1a
Author: Caolán McNamara 
AuthorDate: Thu Nov 1 17:07:43 2018 +
Commit: Caolán McNamara 
CommitDate: Thu Nov 1 22:12:19 2018 +0100

Resolves: tdf#121097 need an initial call to CBClickHdl

Change-Id: If075c6b555d6bca479d02c27bc6b4adb48b8550c
Reviewed-on: https://gerrit.libreoffice.org/62755
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/reportdesign/source/ui/dlg/DateTime.cxx 
b/reportdesign/source/ui/dlg/DateTime.cxx
index 5b04a35d7870..9b91d657d4c0 100644
--- a/reportdesign/source/ui/dlg/DateTime.cxx
+++ b/reportdesign/source/ui/dlg/DateTime.cxx
@@ -72,6 +72,7 @@ ODateTimeDialog::ODateTimeDialog(weld::Window* _pParent, 
const uno::Reference< r
 weld::CheckButton* aCheckBoxes[] = { m_xDate.get(), m_xTime.get() };
 for (weld::CheckButton* pCheckBox : aCheckBoxes)
 pCheckBox->connect_toggled(LINK(this,ODateTimeDialog,CBClickHdl));
+CBClickHdl(*m_xTime);
 }
 
 void ODateTimeDialog::InsertEntry(sal_Int16 _nNumberFormatId)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 121104] FIREBIRD: No connection to external Firebird-file in Windows possible

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121104

Gerhard Weydt  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #4 from Gerhard Weydt  ---
Can confirm with 6.1.3.2

and also with 6.2:
Version: 6.2.0.0.alpha0+ (x64)
Build ID: 89a60912bba7ffd6f65ea99f4664f343c5025c95
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-10-01_03:18:33
Locale: de-DE (de_DE); Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121105] the current() function is confused if used inside or()

2018-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121105

Jiří Boháč  changed:

   What|Removed |Added

Summary|the current() function is   |the current() function is
   |confused if used twice in a |confused if used inside
   |formula |or()

--- Comment #2 from Jiří Boháč  ---
hmm, the bug description was wrong; I reproduced the bug with a modified
formula:
=A1+STYLE(IF(OR(FALSE(), CURRENT() <3),"green","red"))

It seems to be the CURRENT() inside OR() which is broken.
The above formula should make 1 and 2 "green" and the rest "red"
Everything is green.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   3   4   5   >