[Libreoffice-commits] core.git: 2 commits - framework/qa qadevOOo/Jar_OOoRunner.mk qadevOOo/objdsc qadevOOo/tests sc/CppunitTest_sc_indexenumeration_labelrangesenumeration.mk sc/Module_sc.mk sc/qa
framework/qa/complex/api_internal/api.lst |1 qadevOOo/Jar_OOoRunner.mk |1 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScIndexEnumeration_LabelRangesEnumeration.csv |2 qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_LabelRangesEnumeration.java | 97 -- sc/CppunitTest_sc_indexenumeration_labelrangesenumeration.mk | 43 sc/Module_sc.mk |1 sc/qa/extras/scindexenumeration_labelrangesenumeration.cxx | 92 + sc/qa/extras/scindexenumeration_sheetlinksenumeration.cxx |1 sc/qa/unoapi/sc_5.sce |1 9 files changed, 136 insertions(+), 103 deletions(-) New commits: commit 7ff004e8cac9b3e7296da11fc634facdadcd4d59 Author: Jens Carl AuthorDate: Sun Nov 18 06:48:48 2018 + Commit: Jens Carl CommitDate: Sun Nov 18 08:59:30 2018 +0100 tdf#45904 Move XEnumeration Java tests to C++ Move XEnumeration Java tests to C++ for ScIndexEnumeration_LabelRangesEnumeration. Change-Id: I89c24de2323a2507fd5c1639af72c6b7121e77c9 Reviewed-on: https://gerrit.libreoffice.org/63516 Tested-by: Jenkins Reviewed-by: Jens Carl diff --git a/framework/qa/complex/api_internal/api.lst b/framework/qa/complex/api_internal/api.lst index 0e842eed2d31..f0f8e67a1ca7 100644 --- a/framework/qa/complex/api_internal/api.lst +++ b/framework/qa/complex/api_internal/api.lst @@ -98,7 +98,6 @@ job101=sc.ScIndexEnumeration_CellAnnotationsEnumeration job102=sc.ScIndexEnumeration_CellAreaLinksEnumeration job103=sc.ScIndexEnumeration_DatabaseRangesEnumeration job107=sc.ScIndexEnumeration_FunctionDescriptionEnumeration -job108=sc.ScIndexEnumeration_LabelRangesEnumeration job109=sc.ScIndexEnumeration_NamedRangesEnumeration job111=sc.ScIndexEnumeration_SheetCellRangesEnumeration job113=sc.ScIndexEnumeration_SpreadsheetsEnumeration diff --git a/qadevOOo/Jar_OOoRunner.mk b/qadevOOo/Jar_OOoRunner.mk index 65743536f489..e559a5a80e47 100644 --- a/qadevOOo/Jar_OOoRunner.mk +++ b/qadevOOo/Jar_OOoRunner.mk @@ -997,7 +997,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\ qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_DatabaseRangesEnumeration \ qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_DataPilotItemsEnumeration \ qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_FunctionDescriptionEnumeration \ -qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_LabelRangesEnumeration \ qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_NamedRangesEnumeration \ qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_SheetCellRangesEnumeration \ qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_SpreadsheetsEnumeration \ diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScIndexEnumeration_LabelRangesEnumeration.csv b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScIndexEnumeration_LabelRangesEnumeration.csv deleted file mode 100644 index 76dffe88c9fd.. --- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScIndexEnumeration_LabelRangesEnumeration.csv +++ /dev/null @@ -1,2 +0,0 @@ -"ScIndexEnumeration_LabelRangesEnumeration";"com::sun::star::container::XEnumeration";"hasMoreElements()" -"ScIndexEnumeration_LabelRangesEnumeration";"com::sun::star::container::XEnumeration";"nextElement()" diff --git a/qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_LabelRangesEnumeration.java b/qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_LabelRangesEnumeration.java deleted file mode 100644 index 767c4a1be5f6.. --- a/qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_LabelRangesEnumeration.java +++ /dev/null @@ -1,97 +0,0 @@ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice: - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed - * with this work for additional information regarding copyright - * ownership. The ASF licenses this file to you under the Apache - * License, Version 2.0 (the "License"); you may not use this file - * except in compliance with the License. You may obtain a copy of - * the License at http://www.apache.org/licenses/LICENSE-2.0 . - */ - -package mod._sc; - -import java.io.PrintWriter; - -import lib.TestCase; -import lib.TestEnvironment; -import lib.TestParameters; -import util.SOfficeFactory; - -import com.sun.star.beans.XPropertySet; -import
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - icon-themes/elementary icon-themes/elementary_svg icon-themes/karasa_jaga
icon-themes/elementary/cmd/32/diaspeed.png |binary icon-themes/elementary/cmd/lc_avmediaplayer.png |binary icon-themes/elementary/cmd/lc_diaspeed.png |binary icon-themes/elementary/cmd/sc_diaspeed.png |binary icon-themes/elementary/links.txt|3 +++ icon-themes/elementary_svg/cmd/32/diaspeed.svg |1 + icon-themes/elementary_svg/cmd/lc_avmediaplayer.svg |2 +- icon-themes/elementary_svg/cmd/lc_diaspeed.svg |2 +- icon-themes/elementary_svg/cmd/sc_diaspeed.svg |3 +-- icon-themes/karasa_jaga/links.txt |3 +++ 10 files changed, 10 insertions(+), 4 deletions(-) New commits: commit ac1cc695a97c13ddc0dc7699ac199c73e3e2f9e4 Author: Rizal Muttaqin AuthorDate: Sun Nov 18 05:11:49 2018 +0700 Commit: Adolfo Jayme Barrientos CommitDate: Sun Nov 18 08:52:05 2018 +0100 Add delete cell Calc context menu (KJ & elementary) Improve diaspeed icons (elementary) Change-Id: I71f3e9acadb97512c39a44c929b63f81eea4e944 Reviewed-on: https://gerrit.libreoffice.org/63503 Reviewed-by: Rizal Muttaqin Tested-by: Rizal Muttaqin (cherry picked from commit f21c8878ad7c3af2d0e0c8a491d39874fc60b7ca) Reviewed-on: https://gerrit.libreoffice.org/63518 Reviewed-by: Adolfo Jayme Barrientos Tested-by: Adolfo Jayme Barrientos diff --git a/icon-themes/elementary/cmd/32/diaspeed.png b/icon-themes/elementary/cmd/32/diaspeed.png new file mode 100644 index ..8e85677fc88d Binary files /dev/null and b/icon-themes/elementary/cmd/32/diaspeed.png differ diff --git a/icon-themes/elementary/cmd/lc_avmediaplayer.png b/icon-themes/elementary/cmd/lc_avmediaplayer.png index 0851b74e68e1..a47a290f558a 100644 Binary files a/icon-themes/elementary/cmd/lc_avmediaplayer.png and b/icon-themes/elementary/cmd/lc_avmediaplayer.png differ diff --git a/icon-themes/elementary/cmd/lc_diaspeed.png b/icon-themes/elementary/cmd/lc_diaspeed.png index 5ce58df6d9db..5cbfd0913a28 100644 Binary files a/icon-themes/elementary/cmd/lc_diaspeed.png and b/icon-themes/elementary/cmd/lc_diaspeed.png differ diff --git a/icon-themes/elementary/cmd/sc_diaspeed.png b/icon-themes/elementary/cmd/sc_diaspeed.png index 912bb27d127d..91045afd5a63 100644 Binary files a/icon-themes/elementary/cmd/sc_diaspeed.png and b/icon-themes/elementary/cmd/sc_diaspeed.png differ diff --git a/icon-themes/elementary/links.txt b/icon-themes/elementary/links.txt index 0cc500e17c08..73b821991ec4 100644 --- a/icon-themes/elementary/links.txt +++ b/icon-themes/elementary/links.txt @@ -960,6 +960,7 @@ cmd/sc_objectmenu.png cmd/sc_insertframe.png # Calc menu entries cmd/32/cellcontentsmenu.png cmd/32/calculate.png cmd/32/datapilotmenu.png cmd/32/datadatapilotrun.png +cmd/32/deletecell.png cmd/32/delete.png cmd/32/functiondialog.png cmd/32/dbviewfunctions.png cmd/32/functionbox.png cmd/32/dbviewfunctions.png cmd/32/inputlinevisible.png cmd/32/dbviewfunctions.png @@ -973,6 +974,7 @@ cmd/32/toggleformula.png cmd/32/dbviewfunctions.png cmd/lc_cellcontentsmenu.png cmd/lc_calculate.png cmd/lc_datapilotmenu.png cmd/lc_datadatapilotrun.png +cmd/lc_deletecell.png cmd/lc_delete.png cmd/lc_functiondialog.png cmd/lc_dbviewfunctions.png cmd/lc_functionbox.png cmd/lc_dbviewfunctions.png cmd/lc_inputlinevisible.png cmd/lc_dbviewfunctions.png @@ -986,6 +988,7 @@ cmd/lc_toggleformula.png cmd/lc_dbviewfunctions.png cmd/sc_cellcontentsmenu.png cmd/sc_calculate.png cmd/sc_datapilotmenu.png cmd/sc_datadatapilotrun.png +cmd/sc_deletecell.png cmd/sc_delete.png cmd/sc_functiondialog.png cmd/sc_dbviewfunctions.png cmd/sc_functionbox.png cmd/sc_dbviewfunctions.png cmd/sc_inputlinevisible.png cmd/sc_dbviewfunctions.png diff --git a/icon-themes/elementary_svg/cmd/32/diaspeed.svg b/icon-themes/elementary_svg/cmd/32/diaspeed.svg new file mode 100644 index ..664d77852a31 --- /dev/null +++ b/icon-themes/elementary_svg/cmd/32/diaspeed.svg @@ -0,0 +1 @@ +http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file diff --git a/icon-themes/elementary_svg/cmd/lc_avmediaplayer.svg b/icon-themes/elementary_svg/cmd/lc_avmediaplayer.svg index fcf76b35946a..63792f55b870 100644 --- a/icon-themes/elementary_svg/cmd/lc_avmediaplayer.svg +++ b/icon-themes/elementary_svg/cmd/lc_avmediaplayer.svg @@ -1 +1 @@ -http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file +http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file diff --git a/icon-themes/elementary_svg/cmd/lc_diaspeed.svg b/icon-themes/elementary_svg/cmd/lc_diaspeed.svg index c6da7f2089e4..06a1eefd4216 100644 --- a/icon-themes/elementary_svg/cmd/lc_diaspeed.svg +++ b/icon-themes/elementary_svg/cmd/lc_diaspeed.svg @@ -1 +1 @@ -http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file +http://www.w3.org/2000/svg;
[Libreoffice-bugs] [Bug 45904] move java based api tests to c++
https://bugs.documentfoundation.org/show_bug.cgi?id=45904 Adolfo Jayme changed: What|Removed |Added Whiteboard|target:5.2.0 target:5.5.0 |target:5.2.0 target:6.0.0 |target:6.0.0 target:6.1.0 |target:6.1.0 target:6.2.0 |target:6.2.0|target:6.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121488] New: ERROR.TYPE for "Search out of range" in Excel return 7 but in Calc #N/D
https://bugs.documentfoundation.org/show_bug.cgi?id=121488
Bug ID: 121488
Summary: ERROR.TYPE for "Search out of range" in Excel return 7
but in Calc #N/D
Product: LibreOffice
Version: 6.0.6.2 release
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: Calc
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: gmoll...@us.es
The return value for function ERROR.TYPE when the search is out of range is
#N/D but must to be 7 (as Excel).
Before, the function ERROR.TYPE was different in Calc and Excel, the returned
values was 32767, 532, 502 or 504 in Calc while in Excel was 7,2,7,4 in
different errors.
Steps:
Create new Calc sheet:
Write in cells:
Column A
Row 1: =VLOOKUP("Don't exist",B129:B131,1,0)
Row 2: =5/0
Row 3: =VLOOKUP("Out of range",B121:B123,2,0)
Row 4: =#REF!
Column B
Row 1: =ERROR.TYPE(A1)
Row 2: =ERROR.TYPE(A2)
Row 3: =ERROR.TYPE(A3)
Row 4: =ERROR.TYPE(A4)
results in B1-B4 in Calc: 7,2,#N/D,4 with ERROR.TYPE, and results in Excel:
7,2,7,4.
Ok, in the help says: "If the ERROR.TYPE function is used as condition of the
IF function and the ERROR.TYPE returns #N/A, the IF function returns #N/A as
well. Use ISERROR to avoid it as shown in the example above."
But the behaviour is different in Excel-Calc.
The old function is named ERRORTYPE (without dot, in spanish translation is
TIPO.DE.ERROR.OOO) and the result is: 32767, 532, 502, 504 for errors A1 until
A4.
En la vera internacia lingvo: Esperanto, kiu diskriminacias malpli pro denaska
lingvo:
La valorezulto por la funkcio ERARO.TIPO (ERROR.TYPE en la angla) kiam la serĉo
estas ekstere de ĉelintervalo estas #N/D sed ĝi devas esti 7 (kiel Excel).
Antaŭe, la funkcio ERARO.TIPO estis malsama en Calc kaj Excel, la valorrezultoj
estis 32767, 532, 502 aŭ 504 en Calc kaj en Excel estis 7,2,7,4 en malsamaj
eraroj.
Paŝoj:
Kreu novan Calc-folion:
Skribu en ĉeloj: (apartigilo , povas esti ; laŭ lando)
Kolumno A
Vico 1: =VSERĈO("Ne ekzistas",B129:B131,1,0)
Vico 2: =5/0
Vico 3: =VSERĈO("Ekstere de ĉelintervalo",B121:B123,2,0)
Vico 4: =#REF!
Kolumno B
Vico 1: =ERARO.TIPO(A1)
Vico 2: =ERARO.TIPO(A2)
Vico 3: =ERARO.TIPO(A3)
Vico 4: =ERARO.TIPO(A4)
rezultoj en B1-B4 en Calc: 7,2,#N/D,4 kun ERARO.TIPO, kaj rezultoj en Excel:
7,2,7,4.
Bone, en la helpo diras: "If the ERROR.TYPE function is used as condition of
the IF function and the ERROR.TYPE returns #N/A, the IF function returns #N/A
as well. Use ISERROR to avoid it as shown in the example above."
Sed la konduto estas malsama en Excel-Calc.
La malnova funkcio nun estas nomata ERARTIPO (sen punkto, en la angla ERRORTYPE
kaj en la hispana traduko estas TIPO.DE.ERROR.OOO) kaj la valorrezultoj estas:
32767, 532, 502, 504 por eraroj A1 ĝis A4.
Y en español:
El valor de retorno para la función TIPO.DE.ERROR (ERROR.TYPE en inglés) cuando
la búsqueda está fuera de rango es #N/D pero debe ser 7 (como en Excel).
Antes, la función TIPO.DE.ERROR era diferente en Calc y Excel, los valores
devueltos eran 32767, 532, 502 o 504 en Calc, mientras que en Excel era 7,2,7,4
en diferentes errores.
Pasos:
Crear nueva hoja de cálculo:
Escribir en celdas: (ojo, el separador puede ser , o ; según el país)
Columna A
Fila 1: =BUSCARV("No existe";B129:B131;1;0)
Fila 2: =5/0
Fila 3: =BUSCARV("Fuera de rango";B121:B123;2;0)
Fila 4: =#¡REF!
Columna B
Fila 1: =TIPO.DE.ERROR(A1)
Fila 2: =TIPO.DE.ERROR(A2)
Fila 3: =TIPO.DE.ERROR(A3)
Fila 4: =TIPO.DE.ERROR(A4)
los resultados en B1-B4 en Calc: 7,2,#N/D,4, y los resultados en Excel:
7,2,7,4.
resultados en Calc en versiones anteriores y en Calc ahora con
TIPO.DE.ERROR.OOO
Bien, en la ayuda dice: "Si la función TIPO.DE.ERROR se usa como condición de
la función IF y TIPO.DE.ERROR devuelve # N / A, la función IF también devuelve
# N / A. Use ISERROR para evitarlo como se muestra en el ejemplo de arriba ".
Pero el comportamiento es diferente en Excel-Calc.
La función antigua se denomina TIPO.DE.ERROR.OOO (en inglés ERRORTYPE sin el
punto separador) y el resultado es: 32767, 532, 502, 504 para los errores A1
hasta A4.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45904] move java based api tests to c++
https://bugs.documentfoundation.org/show_bug.cgi?id=45904 --- Comment #152 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/cd52e2775773f3628177da4551d9f18e83740910%5E%21 tdf#45904 Move XEnumeration Java tests to C++ It will be available in 6.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: framework/qa qadevOOo/Jar_OOoRunner.mk qadevOOo/objdsc qadevOOo/tests sc/CppunitTest_sc_indexenumeration_sheetlinksenumeration.mk sc/Module_sc.mk sc/qa
framework/qa/complex/api_internal/api.lst |1 qadevOOo/Jar_OOoRunner.mk |1 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScIndexEnumeration_SheetLinksEnumeration.csv |2 qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_SheetLinksEnumeration.java | 108 -- sc/CppunitTest_sc_indexenumeration_sheetlinksenumeration.mk | 43 +++ sc/Module_sc.mk |1 sc/qa/extras/scindexenumeration_sheetlinksenumeration.cxx | 102 + sc/qa/unoapi/sc_5.sce |1 8 files changed, 146 insertions(+), 113 deletions(-) New commits: commit cd52e2775773f3628177da4551d9f18e83740910 Author: Jens Carl AuthorDate: Sun Nov 18 03:51:29 2018 + Commit: Jens Carl CommitDate: Sun Nov 18 08:05:35 2018 +0100 tdf#45904 Move XEnumeration Java tests to C++ Move XEnumeration Java tests to C++ for ScIndexEnumeration_SheetLinksEnumeration. Change-Id: I19bd376cc7921c9dcb7b08394c9c299c336921e3 Reviewed-on: https://gerrit.libreoffice.org/63511 Tested-by: Jenkins Reviewed-by: Jens Carl diff --git a/framework/qa/complex/api_internal/api.lst b/framework/qa/complex/api_internal/api.lst index eaf424757aa0..0e842eed2d31 100644 --- a/framework/qa/complex/api_internal/api.lst +++ b/framework/qa/complex/api_internal/api.lst @@ -101,7 +101,6 @@ job107=sc.ScIndexEnumeration_FunctionDescriptionEnumeration job108=sc.ScIndexEnumeration_LabelRangesEnumeration job109=sc.ScIndexEnumeration_NamedRangesEnumeration job111=sc.ScIndexEnumeration_SheetCellRangesEnumeration -job112=sc.ScIndexEnumeration_SheetLinksEnumeration job113=sc.ScIndexEnumeration_SpreadsheetsEnumeration job114=sc.ScIndexEnumeration_SpreadsheetViewPanesEnumeration job115=sc.ScIndexEnumeration_SubTotalFieldsEnumeration diff --git a/qadevOOo/Jar_OOoRunner.mk b/qadevOOo/Jar_OOoRunner.mk index 4f33139ccedf..65743536f489 100644 --- a/qadevOOo/Jar_OOoRunner.mk +++ b/qadevOOo/Jar_OOoRunner.mk @@ -1000,7 +1000,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\ qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_LabelRangesEnumeration \ qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_NamedRangesEnumeration \ qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_SheetCellRangesEnumeration \ -qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_SheetLinksEnumeration \ qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_SpreadsheetsEnumeration \ qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_SpreadsheetViewPanesEnumeration \ qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_SubTotalFieldsEnumeration \ diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScIndexEnumeration_SheetLinksEnumeration.csv b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScIndexEnumeration_SheetLinksEnumeration.csv deleted file mode 100644 index 5fdf9c037db7.. --- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScIndexEnumeration_SheetLinksEnumeration.csv +++ /dev/null @@ -1,2 +0,0 @@ -"ScIndexEnumeration_SheetLinksEnumeration";"com::sun::star::container::XEnumeration";"hasMoreElements()" -"ScIndexEnumeration_SheetLinksEnumeration";"com::sun::star::container::XEnumeration";"nextElement()" diff --git a/qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_SheetLinksEnumeration.java b/qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_SheetLinksEnumeration.java deleted file mode 100644 index ec1cdb149ca4.. --- a/qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_SheetLinksEnumeration.java +++ /dev/null @@ -1,108 +0,0 @@ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice: - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed - * with this work for additional information regarding copyright - * ownership. The ASF licenses this file to you under the Apache - * License, Version 2.0 (the "License"); you may not use this file - * except in compliance with the License. You may obtain a copy of - * the License at http://www.apache.org/licenses/LICENSE-2.0 . - */ - -package mod._sc; - -import java.io.PrintWriter; - -import lib.TestCase; -import lib.TestEnvironment; -import lib.TestParameters; -import util.SOfficeFactory; - -import com.sun.star.beans.XPropertySet; -import com.sun.star.container.XEnumerationAccess; -import com.sun.star.container.XIndexAccess; -import com.sun.star.lang.XComponent; -import
[Libreoffice-bugs] [Bug 121487] New: "Expert configuration" not responding to clicks
https://bugs.documentfoundation.org/show_bug.cgi?id=121487 Bug ID: 121487 Summary: "Expert configuration" not responding to clicks Product: LibreOffice Version: 6.2.0.0.alpha0+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: m...@hussam.eu.org In this build Version: 6.3.0.0.alpha0+ Build ID: eb5b353b523ec4d7d6588e2fae5b8b4117bfc2b1 CPU threads: 4; OS: Linux 4.14; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded from https://dev-builds.libreoffice.org/daily/master/Linux-archive-x86_64@80-updater/2018-11-18_02.47.02/LibreOfficeDev_6.3.0.0.alpha0_Linux_x86-64_archive.tar.gz The "expert configuration" dialog does not respond to mouse clicks. This works fine in 6.1.3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94231] FILEOPEN: XLSX - Pattern/hatching fill colors not imported into charts
https://bugs.documentfoundation.org/show_bug.cgi?id=94231 Adolfo Jayme changed: What|Removed |Added Whiteboard|target:6.2.0|target:6.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: oox/source
oox/source/drawingml/chart/seriescontext.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 4bd2e57653ce22044ab984b06c84f22ef287cecf
Author: Markus Mohrhard
AuthorDate: Sun Nov 18 04:37:02 2018 +0100
Commit: Markus Mohrhard
CommitDate: Sun Nov 18 06:16:28 2018 +0100
tdf#102186, don't overwrite the deleted flag
Change-Id: I3cc69a0baebc55ad52b64960657e9daa4be8f39d
Reviewed-on: https://gerrit.libreoffice.org/63510
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard
diff --git a/oox/source/drawingml/chart/seriescontext.cxx
b/oox/source/drawingml/chart/seriescontext.cxx
index a6763ad2fb74..10e3af70108f 100644
--- a/oox/source/drawingml/chart/seriescontext.cxx
+++ b/oox/source/drawingml/chart/seriescontext.cxx
@@ -93,6 +93,7 @@ void lclDataLabelSharedCharacters( ContextHandler2 const &
rContext, const OUStr
DataLabelContext::DataLabelContext( ContextHandler2Helper& rParent,
DataLabelModel& rModel ) :
ContextBase< DataLabelModel >( rParent, rModel )
{
+mrModel.mbDeleted = false;
}
DataLabelContext::~DataLabelContext()
@@ -101,7 +102,6 @@ DataLabelContext::~DataLabelContext()
ContextHandlerRef DataLabelContext::onCreateContext( sal_Int32 nElement, const
AttributeList& rAttribs )
{
-mrModel.mbDeleted = false;
if( isRootElement() ) switch( nElement )
{
case C_TOKEN( idx ):
@@ -124,6 +124,7 @@ void DataLabelContext::onCharacters( const OUString& rChars
)
DataLabelsContext::DataLabelsContext( ContextHandler2Helper& rParent,
DataLabelsModel& rModel ) :
ContextBase< DataLabelsModel >( rParent, rModel )
{
+mrModel.mbDeleted = false;
}
DataLabelsContext::~DataLabelsContext()
@@ -132,7 +133,6 @@ DataLabelsContext::~DataLabelsContext()
ContextHandlerRef DataLabelsContext::onCreateContext( sal_Int32 nElement,
const AttributeList& rAttribs )
{
-mrModel.mbDeleted = false;
bool bMSO2007Doc = getFilter().isMSO2007Document();
if( isRootElement() ) switch( nElement )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/miscdlgs/dataproviderdlg.cxx | 16
1 file changed, 16 insertions(+)
New commits:
commit 14f83b8a8ec8f2fe1570db285f4527b9fd5d86ea
Author: Markus Mohrhard
AuthorDate: Fri Oct 19 21:58:18 2018 -0600
Commit: Markus Mohrhard
CommitDate: Sun Nov 18 05:35:31 2018 +0100
tdf#113916, don't import if no DB range is selected
Change-Id: I6562ded076f53c44b5eeab7027058baf6c71f48f
Reviewed-on: https://gerrit.libreoffice.org/63509
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard
diff --git a/sc/source/ui/miscdlgs/dataproviderdlg.cxx
b/sc/source/ui/miscdlgs/dataproviderdlg.cxx
index 75a7880e42ff..cb58ad0c42ff 100644
--- a/sc/source/ui/miscdlgs/dataproviderdlg.cxx
+++ b/sc/source/ui/miscdlgs/dataproviderdlg.cxx
@@ -18,6 +18,7 @@
#include
#include
+#include
#include
#include
@@ -1137,9 +1138,22 @@ void ScDataProviderDlg::dateTimeTransformation()
mpList->addEntry(pDateTimeTransformationEntry);
}
+namespace {
+
+bool hasDBName(const OUString& rName, ScDBCollection* pDBCollection)
+{
+if
(pDBCollection->getNamedDBs().findByUpperName(ScGlobal::pCharClass->uppercase(rName)))
+return true;
+
+return false;
+}
+
+}
+
void ScDataProviderDlg::import(ScDocument* pDoc, bool bInternal)
{
sc::ExternalDataSource aSource = mpDataProviderCtrl->getDataSource(pDoc);
+
std::vector> aListEntries = mpList->getEntries();
for (size_t i = 1; i < aListEntries.size(); ++i)
{
@@ -1156,6 +1170,8 @@ void ScDataProviderDlg::import(ScDocument* pDoc, bool
bInternal)
else
{
aSource.setDBData(mpDBRanges->GetSelectedEntry());
+if (!hasDBName(aSource.getDBName(), pDoc->GetDBCollection()))
+return;
pDoc->GetExternalDataMapper().insertDataSource(aSource);
}
aSource.refresh(pDoc, true);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/qa include/oox oox/source
chart2/qa/extras/chart2import.cxx| 20
chart2/qa/extras/data/xlsx/chart-hatch-fill.xlsx |binary
include/oox/drawingml/shapepropertymap.hxx |6 +++---
oox/source/drawingml/chart/objectformatter.cxx |7 ---
oox/source/drawingml/shapepropertymap.cxx|4 ++--
5 files changed, 29 insertions(+), 8 deletions(-)
New commits:
commit dddcfa0089bc84965d7a2c94f5f738a325cfae78
Author: Balazs Varga
AuthorDate: Thu Nov 8 09:25:18 2018 +0100
Commit: Markus Mohrhard
CommitDate: Sun Nov 18 05:24:55 2018 +0100
tdf#94231 OOXML Import: Fix disappeared Hatch Background Color
With adding the PROP_FillBackground property to spnCommonPropIds and
spnFilledPropIds the hatch background color imported correctly,
an will not disappear.
Change-Id: I56745179236d2912a2d5c8585098e54acc4e3062
Reviewed-on: https://gerrit.libreoffice.org/63069
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard
diff --git a/chart2/qa/extras/chart2import.cxx
b/chart2/qa/extras/chart2import.cxx
index f9d5343c0317..c85bcc67c06a 100644
--- a/chart2/qa/extras/chart2import.cxx
+++ b/chart2/qa/extras/chart2import.cxx
@@ -912,6 +912,7 @@ void Chart2ImportTest::testChartHatchFillXLSX()
uno::Reference xChartDoc = getChartDocFromSheet(0,
mxComponent);
CPPUNIT_ASSERT_MESSAGE("failed to load chart", xChartDoc.is());
+// Check the chart background FillStyle is HATCH
Reference xPropSet = xChartDoc->getPageBackground();
CPPUNIT_ASSERT(xPropSet.is());
drawing::FillStyle eStyle =
xPropSet->getPropertyValue("FillStyle").get();
@@ -919,6 +920,16 @@ void Chart2ImportTest::testChartHatchFillXLSX()
CPPUNIT_ASSERT_EQUAL_MESSAGE("Chart background fill in this xlsx should be
loaded as hatch fill.",
drawing::FillStyle_HATCH, eStyle);
+// Check the FillBackground of chart background
+bool bBackgroundFill = false;
+xPropSet->getPropertyValue("FillBackground") >>= bBackgroundFill;
+CPPUNIT_ASSERT(bBackgroundFill);
+
+sal_Int32 nBackgroundColor;
+xPropSet->getPropertyValue("FillColor") >>= nBackgroundColor;
+CPPUNIT_ASSERT_EQUAL(static_cast(0xFF), nBackgroundColor);
+
+// Check the datapoint has HatchName value
uno::Reference
xDataSeries(getDataSeriesFromDoc(xChartDoc, 0));
CPPUNIT_ASSERT(xDataSeries.is());
@@ -926,6 +937,15 @@ void Chart2ImportTest::testChartHatchFillXLSX()
OUString sHatchName;
xPropertySet->getPropertyValue("HatchName") >>= sHatchName;
CPPUNIT_ASSERT(!sHatchName.isEmpty());
+
+// Check the FillBackground of datapoint
+bool bBackgroundFillofDatapoint = false;
+xPropertySet->getPropertyValue("FillBackground") >>=
bBackgroundFillofDatapoint;
+CPPUNIT_ASSERT(bBackgroundFillofDatapoint);
+
+sal_Int32 nBackgroundColorofDatapoint;
+xPropertySet->getPropertyValue("FillColor") >>=
nBackgroundColorofDatapoint;
+CPPUNIT_ASSERT_EQUAL(static_cast(0x00B050),
nBackgroundColorofDatapoint);
}
void Chart2ImportTest::testAxisTextRotationXLSX()
diff --git a/chart2/qa/extras/data/xlsx/chart-hatch-fill.xlsx
b/chart2/qa/extras/data/xlsx/chart-hatch-fill.xlsx
index e15a46b144dd..4e3394c8efdf 100644
Binary files a/chart2/qa/extras/data/xlsx/chart-hatch-fill.xlsx and
b/chart2/qa/extras/data/xlsx/chart-hatch-fill.xlsx differ
diff --git a/include/oox/drawingml/shapepropertymap.hxx
b/include/oox/drawingml/shapepropertymap.hxx
index bace1978d78a..edbae76f0d6c 100644
--- a/include/oox/drawingml/shapepropertymap.hxx
+++ b/include/oox/drawingml/shapepropertymap.hxx
@@ -72,10 +72,10 @@ enum class ShapeProperty
FillBitmapOffsetY,
FillBitmapRectanglePoint,
FillHatch,/// Explicit fill hatch or name of a fill
hatch stored in a global container.
-ShadowXDistance,
-FillBitmapName,
FillBackground,
-LAST = FillBackground
+FillBitmapName,
+ShadowXDistance,
+LAST = ShadowXDistance
};
typedef o3tl::enumarray ShapePropertyIds;
diff --git a/oox/source/drawingml/chart/objectformatter.cxx
b/oox/source/drawingml/chart/objectformatter.cxx
index a513fdb435a5..184cb111f02f 100644
--- a/oox/source/drawingml/chart/objectformatter.cxx
+++ b/oox/source/drawingml/chart/objectformatter.cxx
@@ -450,7 +450,7 @@ static const ShapePropertyIds spnCommonPropIds =
PROP_FillStyle, PROP_FillColor, PROP_FillTransparence, PROP_INVALID,
PROP_FillGradientName,
PROP_FillBitmapName, PROP_FillBitmapMode, PROP_FillBitmapSizeX,
PROP_FillBitmapSizeY,
PROP_FillBitmapPositionOffsetX, PROP_FillBitmapPositionOffsetY,
PROP_FillBitmapRectanglePoint,
-PROP_FillHatchName
+PROP_FillHatchName, PROP_FillBackground
};
static const ShapePropertyIds spnLinearPropIds =
@@ -460,7 +460,7 @@ static const ShapePropertyIds spnLinearPropIds =
PROP_INVALID, PROP_INVALID, PROP_INVALID, PROP_INVALID, PROP_INVALID,
PROP_INVALID, PROP_INVALID, PROP_INVALID, PROP_INVALID,
PROP_INVALID,
[Libreoffice-bugs] [Bug 94231] FILEOPEN: XLSX - Pattern/hatching fill colors not imported into charts
https://bugs.documentfoundation.org/show_bug.cgi?id=94231 --- Comment #5 from Commit Notification --- Balazs Varga committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/dddcfa0089bc84965d7a2c94f5f738a325cfae78%5E%21 tdf#94231 OOXML Import: Fix disappeared Hatch Background Color It will be available in 6.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94231] FILEOPEN: XLSX - Pattern/hatching fill colors not imported into charts
https://bugs.documentfoundation.org/show_bug.cgi?id=94231 Commit Notification changed: What|Removed |Added Whiteboard||target:6.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=108226 Bug 108226 depends on bug 102186, which changed state. Bug 102186 Summary: MS PowerPoint with Chart shows hidden data labels when opened in Impress https://bugs.documentfoundation.org/show_bug.cgi?id=102186 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75057] [META] OOXML Chart object issues
https://bugs.documentfoundation.org/show_bug.cgi?id=75057 Bug 75057 depends on bug 102186, which changed state. Bug 102186 Summary: MS PowerPoint with Chart shows hidden data labels when opened in Impress https://bugs.documentfoundation.org/show_bug.cgi?id=102186 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: onlineupdate/source
onlineupdate/source/libmar/sign/nss_secutil.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 1baf55c0ab7cc003225fd9adcaf702a511db575a
Author: Markus Mohrhard
AuthorDate: Thu Oct 11 00:10:48 2018 +0200
Commit: Markus Mohrhard
CommitDate: Sun Nov 18 05:20:02 2018 +0100
fix off by one error
BLRG-PT-18-004
Change-Id: I9cd2582aebf2b33d40f23254047c35c8dee90f4b
Reviewed-on: https://gerrit.libreoffice.org/63508
Reviewed-by: Markus Mohrhard
Tested-by: Markus Mohrhard
diff --git a/onlineupdate/source/libmar/sign/nss_secutil.c
b/onlineupdate/source/libmar/sign/nss_secutil.c
index 9fe5fe4d49e2..875c14309ec0 100644
--- a/onlineupdate/source/libmar/sign/nss_secutil.c
+++ b/onlineupdate/source/libmar/sign/nss_secutil.c
@@ -122,7 +122,7 @@ SECU_FilePasswd(PK11SlotInfo *slot, PRBool retry, void *arg)
return 0; /* no good retrying - the files contents will be the same */
}
- phrases = PORT_ZAlloc(maxPwdFileSize);
+ phrases = PORT_ZAlloc(maxPwdFileSize + 1);
if (!phrases) {
return 0; /* out of memory */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 45904] move java based api tests to c++
https://bugs.documentfoundation.org/show_bug.cgi?id=45904 --- Comment #151 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/a146438bdbe043357b6c729a6136d1aeef269d97%5E%21 tdf#45904 Move XEnumeration Java tests to C++ It will be available in 6.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45904] move java based api tests to c++
https://bugs.documentfoundation.org/show_bug.cgi?id=45904 --- Comment #150 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/b5fca203d1561be77ab5f3f78cf3ef38208305f1%5E%21 tdf#45904 Move XEnumeration Java tests to C++ It will be available in 6.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - framework/qa qadevOOo/Jar_OOoRunner.mk qadevOOo/objdsc qadevOOo/tests sc/CppunitTest_sc_indexenumeration_datapilotfieldsenumeration.mk sc/CppunitTest_sc_ind
framework/qa/complex/api_internal/api.lst |2 qadevOOo/Jar_OOoRunner.mk |2 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScIndexEnumeration_DataPilotFieldsEnumeration.csv |2 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScIndexEnumeration_DataPilotTablesEnumeration.csv |2 qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_DataPilotFieldsEnumeration.java | 129 -- qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_DataPilotTablesEnumeration.java | 127 - sc/CppunitTest_sc_indexenumeration_datapilotfieldsenumeration.mk | 43 +++ sc/CppunitTest_sc_indexenumeration_datapilottablesenumeration.mk | 43 +++ sc/Module_sc.mk |2 sc/qa/extras/scindexenumeration_datapilotfieldsenumeration.cxx | 113 sc/qa/extras/scindexenumeration_datapilottablesenumeration.cxx | 112 sc/qa/unoapi/sc_5.sce |2 12 files changed, 313 insertions(+), 266 deletions(-) New commits: commit a146438bdbe043357b6c729a6136d1aeef269d97 Author: Jens Carl AuthorDate: Sun Nov 18 02:54:04 2018 + Commit: Jens Carl CommitDate: Sun Nov 18 04:57:52 2018 +0100 tdf#45904 Move XEnumeration Java tests to C++ Move XEnumeration Java tests to C++ for ScIndexEnumeration_DataPilotTablesEnumeration. Change-Id: I6f5f8439b50cdf313b00f9dd69b780d654b5cdb4 Reviewed-on: https://gerrit.libreoffice.org/63507 Tested-by: Jenkins Reviewed-by: Jens Carl diff --git a/framework/qa/complex/api_internal/api.lst b/framework/qa/complex/api_internal/api.lst index ef30cc2c1f50..eaf424757aa0 100644 --- a/framework/qa/complex/api_internal/api.lst +++ b/framework/qa/complex/api_internal/api.lst @@ -97,7 +97,6 @@ job99=sc.ScHeaderFieldsObj job101=sc.ScIndexEnumeration_CellAnnotationsEnumeration job102=sc.ScIndexEnumeration_CellAreaLinksEnumeration job103=sc.ScIndexEnumeration_DatabaseRangesEnumeration -job105=sc.ScIndexEnumeration_DataPilotTablesEnumeration job107=sc.ScIndexEnumeration_FunctionDescriptionEnumeration job108=sc.ScIndexEnumeration_LabelRangesEnumeration job109=sc.ScIndexEnumeration_NamedRangesEnumeration diff --git a/qadevOOo/Jar_OOoRunner.mk b/qadevOOo/Jar_OOoRunner.mk index b8dab8fe51e8..4f33139ccedf 100644 --- a/qadevOOo/Jar_OOoRunner.mk +++ b/qadevOOo/Jar_OOoRunner.mk @@ -996,7 +996,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\ qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_CellAreaLinksEnumeration \ qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_DatabaseRangesEnumeration \ qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_DataPilotItemsEnumeration \ -qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_DataPilotTablesEnumeration \ qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_FunctionDescriptionEnumeration \ qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_LabelRangesEnumeration \ qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_NamedRangesEnumeration \ diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScIndexEnumeration_DataPilotTablesEnumeration.csv b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScIndexEnumeration_DataPilotTablesEnumeration.csv deleted file mode 100644 index 756fb96baeca.. --- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScIndexEnumeration_DataPilotTablesEnumeration.csv +++ /dev/null @@ -1,2 +0,0 @@ -"ScIndexEnumeration_DataPilotTablesEnumeration";"com::sun::star::container::XEnumeration";"hasMoreElements()" -"ScIndexEnumeration_DataPilotTablesEnumeration";"com::sun::star::container::XEnumeration";"nextElement()" diff --git a/qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_DataPilotTablesEnumeration.java b/qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_DataPilotTablesEnumeration.java deleted file mode 100644 index e2472dbacc22.. --- a/qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_DataPilotTablesEnumeration.java +++ /dev/null @@ -1,127 +0,0 @@ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice: - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed - * with this work for additional information regarding copyright - * ownership. The ASF licenses this file to you under the Apache - * License, Version 2.0 (the "License"); you may not use this file - *
[Libreoffice-bugs] [Bug 48713] FILEOPEN Picture moves to left importing Word .doc
https://bugs.documentfoundation.org/show_bug.cgi?id=48713 --- Comment #9 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45136] PC freezes with math document including grids created with Sinequanon in WMF image format
https://bugs.documentfoundation.org/show_bug.cgi?id=45136 --- Comment #11 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113325] Deleting a table style is not reflected in table style sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=113325 --- Comment #3 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71324] EDITING: can't un-bold selection if it crosses hidden lines of an auto-filter
https://bugs.documentfoundation.org/show_bug.cgi?id=71324 --- Comment #10 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102186] MS PowerPoint with Chart shows hidden data labels when opened in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=102186 Markus Mohrhard changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |markus.mohrhard@googlemail. |desktop.org |com -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121486] New: Text in Thai for some font go right to left
https://bugs.documentfoundation.org/show_bug.cgi?id=121486 Bug ID: 121486 Summary: Text in Thai for some font go right to left Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Linguistic Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tongwa...@hotmail.com Created attachment 146718 --> https://bugs.documentfoundation.org/attachment.cgi?id=146718=edit showing what it's like when I type For several fonts that are in Thai, the letter seems to go from right to left. I've attached some screen cap to demonstrate it. You can see the text are falling off the page when they are supposed to be aligned-left. I also select all by ctrl+A to highlight where the text are actually supposed to be. The fonts in question that I've verified are having the same problems are: TH Baijam TH Fah kwang TH Chakra Petch TH Charm of AU TH Koho FYI, the problem also exist on another computer of mine (Win 10 X64). This computer where I'm making this report is Win 7 X64 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121485] header logo when applied 50% transparency has no effect on libreoffice writer
https://bugs.documentfoundation.org/show_bug.cgi?id=121485 --- Comment #1 from Alfeno Rodrigues --- Created attachment 146717 --> https://bugs.documentfoundation.org/attachment.cgi?id=146717=edit libre office write archive for inspect -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121485] New: header logo when applied 50% transparency has no effect on libreoffice writer
https://bugs.documentfoundation.org/show_bug.cgi?id=121485 Bug ID: 121485 Summary: header logo when applied 50% transparency has no effect on libreoffice writer Product: LibreOffice Version: 6.1.3.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: alf...@gmail.com Description: When a inserted a image file and applied 50% transparency has no effect. But if a save a file with .docx format and open it on microsoft word the transparency effect work foor headed only. Steps to Reproduce: 1.insert a image file on the header or in the document body. 2.click on it, and open "properties" menu by right button of the mouse 3.Select transparency tab options 4.select transparency radio menu and put 50% value or other value. Actual Results: The libreoffice writer don't render the transparent effect. But in my environment has strange behavior for: 1) image file insert on header -> Libreoffice writer don't render it but save it using .docx format and open on microsoft office, the transparency effect work appropriately. 2) image insert on document body -> the transparency effect didn't work in the libreoffice writer and on the microsoft word the file (.docx) effect didn't work too. obs: I nstalled by snap package (stable version) https://snapcraft.io/search?category==libreoffice. Expected Results: the transparency effect works in the libreoffice write and Microsoft's archive (.docx), saved by libreoffice writer, works appropriates on the microsoft office. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Extended renderer info (GLX_MESA_query_renderer): Vendor: Intel Open Source Technology Center (0x8086) Device: Mesa DRI Intel(R) HD Graphics 5500 (Broadwell GT2) (0x1616) Version: 18.2.2 Accelerated: yes Video memory: 3072MB -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121469] FIREBIRD: Migration for table names with special characters fails
https://bugs.documentfoundation.org/show_bug.cgi?id=121469 --- Comment #7 from Drew Jensen --- Created attachment 146716 --> https://bugs.documentfoundation.org/attachment.cgi?id=146716=edit Pictures are worth lots of words Here is what I find using a recent build of LO 6.2Alpha1 on Linux. I found no problem using unicode characters with Base GUI controls with ODB files using HSQL or Firebird, this included Table Designer, Query Designer, Form Designer and Report Builder. Created the table Straße with a column Straße in HSQL and used Drag-n-Drop to create a copy of it in an empty Firebird ODB, with no problem. Created the table Straße with a column Straße in Firebird and used Drag-n-Drop to create a copy of it in an empty HSQL ODB, with no problem. For the rest of the checks, I put them in pictures - an Impress file attached. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118510] Libreoffice kills my pc (prevents it from waking from suspend)
https://bugs.documentfoundation.org/show_bug.cgi?id=118510 --- Comment #7 from Elias --- Again, I'm talking about the DISTRO. I dont want to reinstall my DISTRO for various reasons. I've been reinstalling libreoffice plenty of times with no results. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118510] Libreoffice kills my pc (prevents it from waking from suspend)
https://bugs.documentfoundation.org/show_bug.cgi?id=118510 --- Comment #6 from Elias --- Kernel version 4.15.0-39-generic I already said which distro I'm using. Specs: ASUS M5A78L-M PLUS/USB3 motherboard Graphics card: ASUS GTX 460 1gb AMD FX-6300 processor 6gb RAM (I've ran a ram check already, its fine) Corsair 500w power supply I dont think my specs have anything to do with it. It's probably because I have an old install of my distro (NOT Libreoffice which I have reinstalled multiple times since getting this issue). But at this point I'm not willing to reinstall, getting my system back to where I am now would be a rather arduous process. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
CppCheck Report Update
A new cppcheck report is available at : http://dev-builds.libreoffice.org/cppcheck_reports/master/ Note: The script generating this report was run at : 2018-18-11 02:54:04 with user buildslave at host vm140 as /home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s /home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w /home/buildslave/tmp/www It can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=cppcheck/cppcheck-report.sh ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 121474] Hyphenation for Indonesian Language is not working
https://bugs.documentfoundation.org/show_bug.cgi?id=121474 --- Comment #2 from M. S. Rosyidi --- I have chosen the Indonesian Dictionary to be installed during the installation of LibreOffice 6.1.3. I have created the document and set the default style as below: 1. set the language for Western Text Font as Indonesia 2. set the alignment to Justified 3. set the Hyhenation to Automatically I Write some texts in Indonesian but I found the hyphenation is not working as expected. After saving and closing the document, I check the directory of the dictionary in C:\Program Files\LibreOffice\share\extensions\dict-id and open the dictionaries.xcu. In the dictionaries.xcu there is a calling to hyph_id_ID.dic file (line 18) but the called file is missing from C:\Program Files\LibreOffice\share\extensions\dict-id. I copy the hyph_id_ID.dic file from an extension named Kamus Bahasa Indonesia Version 2.0 by Benitius Brevoort (https://extensions.libreoffice.org/extensions/indonesian-dictionary-kamus-indonesia-by-benitius) to the directory and open the document again and the hyphenation is working as expected. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118510] Libreoffice kills my pc (prevents it from waking from suspend)
https://bugs.documentfoundation.org/show_bug.cgi?id=118510 Elias changed: What|Removed |Added Status|NEEDINFO|REOPENED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118510] Libreoffice kills my pc (prevents it from waking from suspend)
https://bugs.documentfoundation.org/show_bug.cgi?id=118510 --- Comment #5 from Elias --- and of course I uninstalled and reinstalled. thats the first thing I did. and changing the autorecovery settings is really putting a bandaid on a gaping wound. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118510] Libreoffice kills my pc (prevents it from waking from suspend)
https://bugs.documentfoundation.org/show_bug.cgi?id=118510 --- Comment #4 from Elias --- I'm gonna have to bump this thread because I'm having the exact same problems in the exact same version of libreoffice still. I thought I fixed it somehow but I'm pretty sure my "fix" was just closing libreoffice before I put the computer to sleep every time. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51733] Update icons for high-resolution HiDPI / Retina display
https://bugs.documentfoundation.org/show_bug.cgi?id=51733 --- Comment #31 from Gustavo HC --- Some icons are ok. Others still pixelated. 28" 4k monitor. 150% scale. Attachment added 2 screenshots (Pixelated icons 1 and 2) Version: 6.2.0.0.alpha1+ (x64) Build ID: 525ed5d1fcb89412f0b80be0b1e35410b048c337 CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win; -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51733] Update icons for high-resolution HiDPI / Retina display
https://bugs.documentfoundation.org/show_bug.cgi?id=51733 --- Comment #29 from Gustavo HC --- Created attachment 146714 --> https://bugs.documentfoundation.org/attachment.cgi?id=146714=edit Pixelated icons 1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51733] Update icons for high-resolution HiDPI / Retina display
https://bugs.documentfoundation.org/show_bug.cgi?id=51733 --- Comment #30 from Gustavo HC --- Created attachment 146715 --> https://bugs.documentfoundation.org/attachment.cgi?id=146715=edit Pixelated icons 2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121476] Libreoffice in chinese language can't display UI text correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=121476 Flywater changed: What|Removed |Added Component|Localization|UI -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103182 Bug 103182 depends on bug 121361, which changed state. Bug 121361 Summary: Tooltips don't appear when hover on the buttons in toolbar while using KDE Plasma https://bugs.documentfoundation.org/show_bug.cgi?id=121361 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTOURBUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121361] Tooltips don't appear when hover on the buttons in toolbar while using KDE Plasma
https://bugs.documentfoundation.org/show_bug.cgi?id=121361 Maxim Monastirsky changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Blocks||103182 Resolution|--- |NOTOURBUG --- Comment #4 from Maxim Monastirsky --- (In reply to Łukasz Konieczny from comment #3) > Adding gtk-cursor-theme-size = 16 to the ~/.config/gtk-3.0/settings.ini > makes tooltips appear. Thanks. So this proves it's indeed the gtk bug I linked => RESOLVED NOTOURBUG. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103182 [Bug 103182] [META] GTK3-specific bugs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103182 Maxim Monastirsky changed: What|Removed |Added Depends on||121361 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=121361 [Bug 121361] Tooltips don't appear when hover on the buttons in toolbar while using KDE Plasma -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103428] [META] Properties deck/tab of the sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=103428 Bug 103428 depends on bug 121267, which changed state. Bug 121267 Summary: SIDEBAR: border cell color isn't shown (white box) https://bugs.documentfoundation.org/show_bug.cgi?id=121267 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/svx svx/source
include/svx/colorwindow.hxx |2
svx/source/tbxctrls/tbcontrl.cxx | 124 ---
2 files changed, 29 insertions(+), 97 deletions(-)
New commits:
commit eb5b353b523ec4d7d6588e2fae5b8b4117bfc2b1
Author: Maxim Monastirsky
AuthorDate: Sun Nov 11 01:38:01 2018 +0200
Commit: Maxim Monastirsky
CommitDate: Sun Nov 18 00:39:12 2018 +0100
Simplify color status handling
Change-Id: I9335fa2ab94f69853b45f070499d7e18aac458c3
Reviewed-on: https://gerrit.libreoffice.org/63499
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky
diff --git a/include/svx/colorwindow.hxx b/include/svx/colorwindow.hxx
index 5611e4d3e2bd..53605eb9ca12 100644
--- a/include/svx/colorwindow.hxx
+++ b/include/svx/colorwindow.hxx
@@ -40,7 +40,7 @@ class SVX_DLLPUBLIC ColorStatus
public:
ColorStatus();
~ColorStatus();
-bool statusChanged( const css::frame::FeatureStateEvent& rEvent );
+void statusChanged( const css::frame::FeatureStateEvent& rEvent );
Color GetColor();
};
diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index 6a3e96edb831..a379d919f268 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -1772,20 +1772,8 @@ void SvxColorWindow::statusChanged( const
css::frame::FeatureStateEvent& rEvent
}
else
{
-Color aColor(COL_TRANSPARENT);
-
-if (mrColorStatus.statusChanged(rEvent))
-{
-aColor = mrColorStatus.GetColor();
-}
-else if (rEvent.IsEnabled)
-{
-sal_Int32 nValue;
-if (rEvent.State >>= nValue)
-aColor = Color(nValue);
-}
-
-SelectEntry(aColor);
+mrColorStatus.statusChanged(rEvent);
+SelectEntry(mrColorStatus.GetColor());
}
}
@@ -1801,20 +1789,8 @@ void ColorWindow::statusChanged( const
css::frame::FeatureStateEvent& rEvent )
}
else
{
-Color aColor(COL_TRANSPARENT);
-
-if (mrColorStatus.statusChanged(rEvent))
-{
-aColor = mrColorStatus.GetColor();
-}
-else if (rEvent.IsEnabled)
-{
-sal_Int32 nValue;
-if (rEvent.State >>= nValue)
-aColor = Color(nValue);
-}
-
-SelectEntry(aColor);
+mrColorStatus.statusChanged(rEvent);
+SelectEntry(mrColorStatus.GetColor());
}
}
@@ -1937,83 +1913,48 @@ ColorStatus::~ColorStatus()
{
}
-bool ColorStatus::statusChanged( const css::frame::FeatureStateEvent& rEvent )
+void ColorStatus::statusChanged( const css::frame::FeatureStateEvent& rEvent )
{
Color aColor( COL_TRANSPARENT );
+css::table::BorderLine2 aTable;
-if ( rEvent.FeatureURL.Complete == ".uno:FrameLineColor" )
+if ( rEvent.State >>= aTable )
{
-if ( rEvent.IsEnabled )
-rEvent.State >>= aColor;
-
-maColor = aColor;
-return true;
-}
-else
-{
-css::table::BorderLine2 aTable;
-if ( rEvent.IsEnabled )
-rEvent.State >>= aTable;
-
SvxBorderLine aLine;
SvxBoxItem::LineToSvxLine( aTable, aLine, false );
if ( !aLine.isEmpty() )
aColor = aLine.GetColor();
-
-if ( rEvent.FeatureURL.Complete == ".uno:BorderTLBR" )
-{
-maTLBRColor = aColor;
-return true;
-}
-else if ( rEvent.FeatureURL.Complete == ".uno:BorderBLTR" )
-{
-maBLTRColor = aColor;
-return true;
-}
}
+else
+rEvent.State >>= aColor;
-return false;
+if ( rEvent.FeatureURL.Path == "BorderTLBR" )
+maTLBRColor = aColor;
+else if ( rEvent.FeatureURL.Path == "BorderBLTR" )
+maBLTRColor = aColor;
+else
+maColor = aColor;
}
Color ColorStatus::GetColor()
{
-bool bHasColor = maColor != COL_TRANSPARENT;
-bool bHasTLBRColor = maTLBRColor != COL_TRANSPARENT;
-bool bHasBLTRColor = maBLTRColor != COL_TRANSPARENT;
+Color aColor( maColor );
-if ( !bHasColor && bHasTLBRColor && !bHasBLTRColor )
-return maTLBRColor;
-else if ( !bHasColor && !bHasTLBRColor && bHasBLTRColor )
-return maBLTRColor;
-else if ( bHasColor && bHasTLBRColor && !bHasBLTRColor )
-{
-if ( maColor == maTLBRColor )
-return maColor;
-else
-return maBLTRColor;
-}
-else if ( bHasColor && !bHasTLBRColor && bHasBLTRColor )
-{
-if ( maColor == maBLTRColor )
-return maColor;
-else
-return maTLBRColor;
-}
-else if ( !bHasColor && bHasTLBRColor && bHasBLTRColor )
+if ( maTLBRColor != COL_TRANSPARENT )
{
-if ( maTLBRColor == maBLTRColor )
-return maTLBRColor;
-else
-return maColor;
+if ( aColor != maTLBRColor && aColor != COL_TRANSPARENT )
+return COL_TRANSPARENT;
+
[Libreoffice-commits] core.git: icon-themes/elementary icon-themes/elementary_svg icon-themes/karasa_jaga
icon-themes/elementary/cmd/32/diaspeed.png |binary icon-themes/elementary/cmd/lc_avmediaplayer.png |binary icon-themes/elementary/cmd/lc_diaspeed.png |binary icon-themes/elementary/cmd/sc_diaspeed.png |binary icon-themes/elementary/links.txt|3 +++ icon-themes/elementary_svg/cmd/32/diaspeed.svg |1 + icon-themes/elementary_svg/cmd/lc_avmediaplayer.svg |2 +- icon-themes/elementary_svg/cmd/lc_diaspeed.svg |2 +- icon-themes/elementary_svg/cmd/sc_diaspeed.svg |3 +-- icon-themes/karasa_jaga/links.txt |3 +++ 10 files changed, 10 insertions(+), 4 deletions(-) New commits: commit f21c8878ad7c3af2d0e0c8a491d39874fc60b7ca Author: Rizal Muttaqin AuthorDate: Sun Nov 18 05:11:49 2018 +0700 Commit: Rizal Muttaqin CommitDate: Sun Nov 18 00:26:04 2018 +0100 Add delete cell Calc context menu (KJ & elementary) Improve diaspeed icons (elementary) Change-Id: I71f3e9acadb97512c39a44c929b63f81eea4e944 Reviewed-on: https://gerrit.libreoffice.org/63503 Reviewed-by: Rizal Muttaqin Tested-by: Rizal Muttaqin diff --git a/icon-themes/elementary/cmd/32/diaspeed.png b/icon-themes/elementary/cmd/32/diaspeed.png new file mode 100644 index ..8e85677fc88d Binary files /dev/null and b/icon-themes/elementary/cmd/32/diaspeed.png differ diff --git a/icon-themes/elementary/cmd/lc_avmediaplayer.png b/icon-themes/elementary/cmd/lc_avmediaplayer.png index 0851b74e68e1..a47a290f558a 100644 Binary files a/icon-themes/elementary/cmd/lc_avmediaplayer.png and b/icon-themes/elementary/cmd/lc_avmediaplayer.png differ diff --git a/icon-themes/elementary/cmd/lc_diaspeed.png b/icon-themes/elementary/cmd/lc_diaspeed.png index 5ce58df6d9db..5cbfd0913a28 100644 Binary files a/icon-themes/elementary/cmd/lc_diaspeed.png and b/icon-themes/elementary/cmd/lc_diaspeed.png differ diff --git a/icon-themes/elementary/cmd/sc_diaspeed.png b/icon-themes/elementary/cmd/sc_diaspeed.png index 912bb27d127d..91045afd5a63 100644 Binary files a/icon-themes/elementary/cmd/sc_diaspeed.png and b/icon-themes/elementary/cmd/sc_diaspeed.png differ diff --git a/icon-themes/elementary/links.txt b/icon-themes/elementary/links.txt index 0cc500e17c08..73b821991ec4 100644 --- a/icon-themes/elementary/links.txt +++ b/icon-themes/elementary/links.txt @@ -960,6 +960,7 @@ cmd/sc_objectmenu.png cmd/sc_insertframe.png # Calc menu entries cmd/32/cellcontentsmenu.png cmd/32/calculate.png cmd/32/datapilotmenu.png cmd/32/datadatapilotrun.png +cmd/32/deletecell.png cmd/32/delete.png cmd/32/functiondialog.png cmd/32/dbviewfunctions.png cmd/32/functionbox.png cmd/32/dbviewfunctions.png cmd/32/inputlinevisible.png cmd/32/dbviewfunctions.png @@ -973,6 +974,7 @@ cmd/32/toggleformula.png cmd/32/dbviewfunctions.png cmd/lc_cellcontentsmenu.png cmd/lc_calculate.png cmd/lc_datapilotmenu.png cmd/lc_datadatapilotrun.png +cmd/lc_deletecell.png cmd/lc_delete.png cmd/lc_functiondialog.png cmd/lc_dbviewfunctions.png cmd/lc_functionbox.png cmd/lc_dbviewfunctions.png cmd/lc_inputlinevisible.png cmd/lc_dbviewfunctions.png @@ -986,6 +988,7 @@ cmd/lc_toggleformula.png cmd/lc_dbviewfunctions.png cmd/sc_cellcontentsmenu.png cmd/sc_calculate.png cmd/sc_datapilotmenu.png cmd/sc_datadatapilotrun.png +cmd/sc_deletecell.png cmd/sc_delete.png cmd/sc_functiondialog.png cmd/sc_dbviewfunctions.png cmd/sc_functionbox.png cmd/sc_dbviewfunctions.png cmd/sc_inputlinevisible.png cmd/sc_dbviewfunctions.png diff --git a/icon-themes/elementary_svg/cmd/32/diaspeed.svg b/icon-themes/elementary_svg/cmd/32/diaspeed.svg new file mode 100644 index ..664d77852a31 --- /dev/null +++ b/icon-themes/elementary_svg/cmd/32/diaspeed.svg @@ -0,0 +1 @@ +http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file diff --git a/icon-themes/elementary_svg/cmd/lc_avmediaplayer.svg b/icon-themes/elementary_svg/cmd/lc_avmediaplayer.svg index fcf76b35946a..63792f55b870 100644 --- a/icon-themes/elementary_svg/cmd/lc_avmediaplayer.svg +++ b/icon-themes/elementary_svg/cmd/lc_avmediaplayer.svg @@ -1 +1 @@ -http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file +http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file diff --git a/icon-themes/elementary_svg/cmd/lc_diaspeed.svg b/icon-themes/elementary_svg/cmd/lc_diaspeed.svg index c6da7f2089e4..06a1eefd4216 100644 --- a/icon-themes/elementary_svg/cmd/lc_diaspeed.svg +++ b/icon-themes/elementary_svg/cmd/lc_diaspeed.svg @@ -1 +1 @@ -http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file +http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file diff --git a/icon-themes/elementary_svg/cmd/sc_diaspeed.svg b/icon-themes/elementary_svg/cmd/sc_diaspeed.svg index e846cb0f8039..b67f7cce8bed 100644
[Libreoffice-commits] core.git: include/svx reportdesign/source svx/source
include/svx/colorbox.hxx |4 +--
include/svx/colorwindow.hxx | 14 ++--
include/svx/tbcontrl.hxx |2 -
reportdesign/source/ui/dlg/Condition.cxx |2 -
reportdesign/source/ui/dlg/Condition.hxx |2 -
svx/source/tbxctrls/tbcontrl.cxx | 34 +++
6 files changed, 29 insertions(+), 29 deletions(-)
New commits:
commit 57f33bfd0c69a4568d1d5840391ab9901d4f4f66
Author: Maxim Monastirsky
AuthorDate: Sun Nov 11 00:28:36 2018 +0200
Commit: Maxim Monastirsky
CommitDate: Sat Nov 17 23:42:49 2018 +0100
Rename BorderColorStatus to ColorStatus
Next commit will use this for all color status updates,
not just for borders.
Change-Id: Ibd95d755a33bfc079fcbffabfd8896b6b777609f
Reviewed-on: https://gerrit.libreoffice.org/63498
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky
diff --git a/include/svx/colorbox.hxx b/include/svx/colorbox.hxx
index 67e26e652576..0a62fafceacc 100644
--- a/include/svx/colorbox.hxx
+++ b/include/svx/colorbox.hxx
@@ -42,7 +42,7 @@ private:
sal_uInt16 m_nSlotId;
bool m_bShowNoneButton;
std::shared_ptr m_xPaletteManager;
-BorderColorStatus m_aBorderColorStatus;
+ColorStatus m_aColorStatus;
DECL_LINK(MenuActivateHdl, MenuButton *, void);
void Selected(const NamedColor& rNamedColor);
@@ -104,7 +104,7 @@ private:
sal_uInt16 m_nSlotId;
bool m_bShowNoneButton;
std::shared_ptr m_xPaletteManager;
-BorderColorStatus m_aBorderColorStatus;
+ColorStatus m_aColorStatus;
void Selected(const NamedColor& rNamedColor);
void createColorWindow();
diff --git a/include/svx/colorwindow.hxx b/include/svx/colorwindow.hxx
index f5de49f7fd9a..5611e4d3e2bd 100644
--- a/include/svx/colorwindow.hxx
+++ b/include/svx/colorwindow.hxx
@@ -32,14 +32,14 @@
#include
-class SVX_DLLPUBLIC BorderColorStatus
+class SVX_DLLPUBLIC ColorStatus
{
Color maColor;
Color maTLBRColor;
Color maBLTRColor;
public:
-BorderColorStatus();
-~BorderColorStatus();
+ColorStatus();
+~ColorStatus();
bool statusChanged( const css::frame::FeatureStateEvent& rEvent );
Color GetColor();
};
@@ -66,7 +66,7 @@ private:
VclPtr mxParentWindow;
std::shared_ptr mxPaletteManager;
-BorderColorStatus& mrBorderColorStatus;
+ColorStatus& mrColorStatus;
ColorSelectFunction const maColorSelectFunction;
bool const mbReuseParentForPicker;
@@ -83,7 +83,7 @@ private:
public:
SvxColorWindow(const OUString& rCommand,
std::shared_ptr const & rPaletteManager,
- BorderColorStatus& rBorderColorStatus,
+ ColorStatus& rColorStatus,
sal_uInt16 nSlotId,
const css::uno::Reference< css::frame::XFrame >& rFrame,
vcl::Window* pParentWindow,
@@ -118,7 +118,7 @@ private:
weld::Window* const mpParentWindow;
weld::MenuButton* mpMenuButton;
std::shared_ptr mxPaletteManager;
-BorderColorStatus& mrBorderColorStatus;
+ColorStatus& mrColorStatus;
ColorSelectFunction const maColorSelectFunction;
std::unique_ptr mxColorSet;
@@ -144,7 +144,7 @@ private:
public:
ColorWindow(std::shared_ptr const & rPaletteManager,
-BorderColorStatus& rBorderColorStatus,
+ColorStatus& rColorStatus,
sal_uInt16 nSlotId,
const css::uno::Reference< css::frame::XFrame >& rFrame,
weld::Window* pParentWindow, weld::MenuButton* pMenuButton,
diff --git a/include/svx/tbcontrl.hxx b/include/svx/tbcontrl.hxx
index ded664983f21..afa61b9b38b1 100644
--- a/include/svx/tbcontrl.hxx
+++ b/include/svx/tbcontrl.hxx
@@ -210,7 +210,7 @@ class SVX_DLLPUBLIC SvxColorToolBoxControl : public
cppu::ImplInheritanceHelper<
{
std::unique_ptr m_xBtnUpdater;
std::shared_ptr m_xPaletteManager;
-BorderColorStatus m_aBorderColorStatus;
+ColorStatus m_aColorStatus;
bool m_bSplitButton;
sal_uInt16 m_nSlotId;
ColorSelectFunction m_aColorSelectFunction;
diff --git a/reportdesign/source/ui/dlg/Condition.cxx
b/reportdesign/source/ui/dlg/Condition.cxx
index 5e8194fd7214..48f2a5c3c26c 100644
--- a/reportdesign/source/ui/dlg/Condition.cxx
+++ b/reportdesign/source/ui/dlg/Condition.cxx
@@ -227,7 +227,7 @@ IMPL_LINK(Condition, DropdownClick, ToolBox*, pToolBox,
void)
m_pColorFloat = VclPtr::Create(
OUString() /*m_aCommandURL*/,
m_xPaletteManager,
- m_aBorderColorStatus,
+ m_aColorStatus,
nSlotId,
nullptr,
pToolBox,
diff --git a/reportdesign/source/ui/dlg/Condition.hxx
b/reportdesign/source/ui/dlg/Condition.hxx
index ceca03281ecc..d94804d35c24 100644
---
[Libreoffice-commits] core.git: svx/source
svx/source/tbxctrls/tbcontrl.cxx |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
New commits:
commit f162066d9df814086c92fa008c563ffc08daaf98
Author: Maxim Monastirsky
AuthorDate: Fri Nov 9 01:36:33 2018 +0200
Commit: Maxim Monastirsky
CommitDate: Sat Nov 17 23:41:52 2018 +0100
tdf#121267 Handle missing diagonal borders
Regression of 9125a4f3f63a7f49fd307908c181e999120063e0
("Use FeatureStateEvent directly for status updates").
Change-Id: I57856c5707fffcf84f95afa9ef80a394b550c56f
Reviewed-on: https://gerrit.libreoffice.org/63497
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky
diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index 2a50eb6329b7..f4d85d734526 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -1952,8 +1952,13 @@ bool BorderColorStatus::statusChanged( const
css::frame::FeatureStateEvent& rEve
else
{
css::table::BorderLine2 aTable;
-if ( rEvent.IsEnabled && ( rEvent.State >>= aTable ) )
-aColor = Color(aTable.Color);
+if ( rEvent.IsEnabled )
+rEvent.State >>= aTable;
+
+SvxBorderLine aLine;
+SvxBoxItem::LineToSvxLine( aTable, aLine, false );
+if ( !aLine.isEmpty() )
+aColor = aLine.GetColor();
if ( rEvent.FeatureURL.Complete == ".uno:BorderTLBR" )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 34965] Make Impress slides editable during presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=34965 --- Comment #36 from Roland Taylor --- The most simple use case, which I encounter every week, is that there's a simple mistake to correct (such as a duplicated or missing word, or a typo), and you can't do it without ending the presentation and starting again. Another example: while running a presentation, a new point needs to be added on a new slide or slides. However, you can't do that without ending the presentation. Just these two small items would greatly improve usability, and I can speak from real life experience - the lack of the option to edit live presentations makes some people choose other software that can. All that is needed is for presentation editing not to be disabled while a slide show is running. You can already alt+tab between the presenter console and the normal window without affecting what is visible on an external screen/projector. This should be straightforward to enable according to https://bugs.documentfoundation.org/show_bug.cgi?id=34965#c6 If I were familiar with LibreOffice source code and brushed up on my C++ skills, I'd do it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119415] Browser-based help search feature does not honor the "module" drop-down (local offline)
https://bugs.documentfoundation.org/show_bug.cgi?id=119415 --- Comment #13 from Jim Avera --- But is that really intended? If a user is running the Calc application and asks for Help, why is it helpful to show that generic info (or worse, only WRITER info)? IMO Help in Calc should automatically show help for Calc (and similarly for other apps). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121409] Calc Styles dialog Background tab page does not show color or bitmap pages using selection buttons
https://bugs.documentfoundation.org/show_bug.cgi?id=121409 Caolán McNamara changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | Ever confirmed|0 |1 Status|UNCONFIRMED |ASSIGNED --- Comment #3 from Caolán McNamara --- Seems to be a missing dialog parent issue, or at least, fixing that seems to fix this too. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121409] Calc Styles dialog Background tab page does not show color or bitmap pages using selection buttons
https://bugs.documentfoundation.org/show_bug.cgi?id=121409 --- Comment #2 from Jim Raykowski --- Roman, Thanks for trying to repro this. For me, it happens in both: Version: 6.2.0.0.alpha1+ Build ID: 46c1a75b144a4c5fd1f4ab0113b87fe030bebd27 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded and Version 6.2.0.0.alpha1+ Build ID: 397dd8a5f7694540f31f32759c2c915d63506ccd CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86@42; Branch:master, Time: 2018-11-07_23:58:04 Locale: en-US (en_US); Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-6.2.0.0.beta1'
Tag 'libreoffice-6.2.0.0.beta1' created by Christian Lohmaier at 2018-11-17 20:05 + Tag libreoffice-6.2.0.0.beta1 -BEGIN PGP SIGNATURE- iQIcBAABAgAGBQJb8HSTAAoJEPQ0oe+v7q6jSwEQAKBNaatzRQHaBTxthDK2eeH3 n8bMbhxZK552zqHwGGn8LwYmk0TutFxZGNx19e8md0KXTo1ibdQNBQoUEcqgN2yX BQj2uXmexfjwIYEhn10bJYN1IFzu01JD1hDRuR4YeSzRViVdR8vb+VtLSomGunPf xwzq7ndQ+fOu6+q27sAE3zLCZZoW9jUnAIH6+9K4U6BO0ikNXhjRnMzlN2thUFLN OzAkpmX9lNK0rzAWbSfmsioaZYC/B3Tkve3RBkphDCa51as3dkQQ3DfkEW9T8Lwq h4qFdJEZldAdWv4R9mTqrSThg20OcDFrZ7P0r8sVL4riZotofmwJSi/vMNdGCbR8 1ZNiQCY3jFFKzuj1XLsXvnY6KWZCusoeRvXkjztLc0YLBBAXNTWfPhhW0mcup6Po 26AWtNiq/GPNJEbT+dtv8+VHw1gcwxY2xeJh0p4w6vgaw88vJIcA+CJfP0sGs62r ZAeR3xsJC1y9SGdeUTRN+Y70F8os7y0hEqU0e6pJzUQ6GS7sl76FmWdjkudUo2ZG vr7HlLOFrEa4ESLgHXsP09zgyJrFCeIOMGZEJ1Tt5QLbL3LsFQ++/12y5CQW+wi1 vRun/3ucgDrgsGgq/SUCTFZq5XGhAMzs7xApnn/RiThRMy5+6YdDyvtkNgyYIJ7/ 6G3T58OeEzeRrm+YaL3D =mCqd -END PGP SIGNATURE- Changes since libreoffice-6-1-branch-point-18: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-6.2.0.0.beta1'
Tag 'libreoffice-6.2.0.0.beta1' created by Christian Lohmaier at 2018-11-17 20:05 + Tag libreoffice-6.2.0.0.beta1 -BEGIN PGP SIGNATURE- iQIcBAABAgAGBQJb8HSWAAoJEPQ0oe+v7q6j9VMP/1H28SjAhttAECPtUSHFmgAo MjwWyNNjLuJGk8Mam03SY/iw6LRPP2NtSMuYrzDe/iZTTjtAat+YbNGmY/FoMhiF CDCI2deW3yLQCs3o9M5luXDUAjFuskfRV/PtoCS65yFlxYgPA/cOGU+CMol1d+R0 5vPc5w2nVzWcfhgwad3zsDokogPfgvoK1078AvY4EL8FqtEgyZInecT78SR4KAXh YIcNiwBYLtHUQZ7+A6lqawRPB5CcjIqlT7+azip8JzjopG0bXPJf446c8ZhILBeE 4ewY+mBPirxolCWNo35Ky09fwBdq071nLQu2uZcD5FTC/iHdlJSTJ7hy9msScjIG l5rk5YZqY9vd1XJd1TWGZxJhHT2Pd8e9SeKz2BwaQanKD+oU9Fu8aTfD6Q+awHo3 VyTkouvTOxAMkjqvrZv/sgA5YAQOrHK/a8Pe/Cii++q3OwhVac/SIBTTXMUjpcZJ ZX1RaU+cy6+EcSPY5hqq7Bd3nx2Yo0363qhZM3l0HKqeZbLefVG5SyHNXhz30gp9 lWH9s4bCQkKp8DFs8qVkmARkC2KTFi6HPt++WrnXtiSOk1luTqNoxtkoY2nqqpRx 5elN7ZHvI92sXQZZ/AxEnjjuI0TNOSmfGPXUxumz0myM6o+q0fDqKSKuugQIz1BG QMIrTaiZMD5dUkKj/yw0 =MTSQ -END PGP SIGNATURE- Changes since libreoffice-6-1-branch-point-7137: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1c70bf876920faace2d8a1d3ad48d38410bf36bc Author: Christian Lohmaier AuthorDate: Sat Nov 17 21:14:14 2018 +0100 Commit: Christian Lohmaier CommitDate: Sat Nov 17 21:14:14 2018 +0100 bump product version to 6.2.0.0.beta1+ Change-Id: Id216fbed8d9c255d09553004bb468d01bd65ed6c diff --git a/configure.ac b/configure.ac index 442ada332ada..d553580772c0 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([LibreOffice],[6.2.0.0.alpha1+],[],[],[http://documentfoundation.org/]) +AC_INIT([LibreOffice],[6.2.0.0.beta1+],[],[],[http://documentfoundation.org/]) AC_PREREQ([2.59]) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-6.2.0.0.beta1'
Tag 'libreoffice-6.2.0.0.beta1' created by Christian Lohmaier at 2018-11-17 20:05 + Tag libreoffice-6.2.0.0.beta1 -BEGIN PGP SIGNATURE- iQIcBAABAgAGBQJb8HSQAAoJEPQ0oe+v7q6jXXsQAM/abJ7Q/AcWEgS6MpqBN0IQ 8ta662Cw48qKwzd5+NKU7pdDlhlei8PjshR99d+VY0bXyhplSmb++xbiLsgcWO/2 +qlcUWfkjITtJZq+FdHNHKuSF1xMIAsXAkr9oyV+OgF1OAostYfDyc5Z0HokY3jh D3rYgUVbALcidlE6NT26PJExYi4XQwOCSucDodeX8e4iJQcUHvjzNKkMeS2xsVec h1ansLg8a9FEKuUjbkinK7LEKVhSi6O67M1f3Ssf7Qsv9EE0hBmGfKHIx1U9JC+X 4kKHRcRjCZanjP/Dhum4GaJqMrgKeBPSya5Vx2QXMEdSgY1tSvnNmYghRZTA1cwu XDnKA/yiEl3FgIdNciIdG7F7TMyPLUJCpPccOFU8+cqpscKBF9OivbK0o8MAH/E7 1OUP3FvoMzEkq2awVRMfnQ12TEspyzFqYj2ub5RBIb4FRX27m7k8rB4oxb+y6KFG cctPyKKi+spcZAiGref/w3J0odUUyN6JaAQHBGnKetITGzPzmWq2nBA/JKpwbbbx YO28qCcdkUg9lIBLXCwpvI0Y6hB3JhYngzUmohH+UIOLEorRkwCmIMGSeRpuWzxL SvdEqVIjhz0oaKYjKijq3iZlTxWZzaroo5IVN+hKebJBmNHml4mIxBF1sk2O/vJ9 3T4pM/kEdK331OKdR9iJ =1dya -END PGP SIGNATURE- Changes since libreoffice-6-1-branch-point-274: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-6.2.0.0.beta1'
Tag 'libreoffice-6.2.0.0.beta1' created by Christian Lohmaier at 2018-11-17 20:05 + Tag libreoffice-6.2.0.0.beta1 -BEGIN PGP SIGNATURE- iQIcBAABAgAGBQJb8HSNAAoJEPQ0oe+v7q6jiN4P/33j38hA93gdRovYQfpw+IA+ fAYh6nMafn2nR4NOkk4a0w/Zu/QM6oJ96vkhjW4RG31pUIMm+dAPK76Bs6u57cgW 5i2CkujfRfCUphVopyQxJdnSyKJHjBSgH0BZuu/e+rG1SHLjDmVelSh/+X05l2wP qf6kZ7LnL1DYZQnk4V3wXAp1O88jasa+t4uHN8ntn7TV/W3HxENCVo5xA5Lmz9dJ Ms/cAvKddtH2JODOIk0Szx0Hzqt9W+FsKBuIPgk1srwWWrJqbej5JNA+6R7AODhl aa+a/6j+gUEBwUuWXxEJZSQ4/L+6wdk4/89YxHTPd/dtgDUR7Jobm2FZMn2BjA61 LS+69KMa4WAxKQqroC0vUqWMINt8OfPJIrTQiDvu/lpf5rgA/QCNMLzsTw6iL6Rk 67i3MhLuXjkVYkZpWBjtY7m3A2jAhqI486wKiYIVpuhuX50/kVzMnqqbYZ3Eoqpb /F5TxERAzpU44kato0kZjA375uy8PKBonMtLpZ0Jjvtfp/XPYxTvp7vGPIN8BHIo w5CPFau0vQk41v92QYBG15AU0horLT3q/PxbGXaJN+M12Jp2m6SXb4vjq/oRnJtQ 6VpQRS/FijKd9JWyrHAa/yNaCcoYXCaEz4JPOA+8xqnYhNpEpRszl1EiyemOp5sg G4pR92l8knOI+HHf1yRa =20iG -END PGP SIGNATURE- Changes since libreoffice-6-1-branch-point-15: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] translations.git: Branch 'libreoffice-libreoffice-6-2' - 0 commits -
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Changes to 'libreoffice-6-2'
New branch 'libreoffice-6-2' available with the following commits: commit d51157294fedaaf963a3f727ab0d0141d0363fdc Author: Christian Lohmaier Date: Sat Nov 17 21:01:19 2018 +0100 Branch libreoffice-6-2 This is 'libreoffice-6-2' - the stable branch for the 6.2.x releases. The commit rules are different according to the development phase: A. 6.2.0 beta phase: A. any bug fixes are allowed without review B. late features need approval by 3 people with different affiliation B. 6.2.0 rc phase and later: A. fixes need approval by one reviewer B. late features need approval by 3 more people with different affiliation IMPORTANT: Every developer is responsible for pushing the fixes into all appropriate branches. Note that we do not plan any merge from this branch to master or vice versa. Please, help use to make stable and usable release. If you want to build something cool, unstable, and risky, use master. Change-Id: If51d297293e40c30f8f3fffdfa1446c9799f7367 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] translations.git: Changes to 'libreoffice-6-2'
New branch 'libreoffice-6-2' available with the following commits: commit 3f828a5b82478bc11c29db56288476e2b204ad2f Author: Christian Lohmaier Date: Sat Nov 17 21:01:20 2018 +0100 Branch libreoffice-6-2 This is 'libreoffice-6-2' - the stable branch for the 6.2.x releases. The commit rules are different according to the development phase: A. 6.2.0 beta phase: A. any bug fixes are allowed without review B. late features need approval by 3 people with different affiliation B. 6.2.0 rc phase and later: A. fixes need approval by one reviewer B. late features need approval by 3 more people with different affiliation IMPORTANT: Every developer is responsible for pushing the fixes into all appropriate branches. Note that we do not plan any merge from this branch to master or vice versa. Please, help use to make stable and usable release. If you want to build something cool, unstable, and risky, use master. Change-Id: Ie4d5d1da97ff343c27397b2d5862120978ddae6e ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Branch 'libreoffice-libreoffice-6-2' - 0 commits -
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: Changes to 'libreoffice-6-2'
New branch 'libreoffice-6-2' available with the following commits: commit 9e4ee1ee9c422f811557d7570bdc26e42a162987 Author: Christian Lohmaier Date: Sat Nov 17 21:01:19 2018 +0100 Branch libreoffice-6-2 This is 'libreoffice-6-2' - the stable branch for the 6.2.x releases. The commit rules are different according to the development phase: A. 6.2.0 beta phase: A. any bug fixes are allowed without review B. late features need approval by 3 people with different affiliation B. 6.2.0 rc phase and later: A. fixes need approval by one reviewer B. late features need approval by 3 more people with different affiliation IMPORTANT: Every developer is responsible for pushing the fixes into all appropriate branches. Note that we do not plan any merge from this branch to master or vice versa. Please, help use to make stable and usable release. If you want to build something cool, unstable, and risky, use master. Change-Id: I7867b07b0de23b9108fc0e2bbbe94841df8ea0ac ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: Branch 'libreoffice-libreoffice-6-2' - 0 commits -
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'libreoffice-6-2'
New branch 'libreoffice-6-2' available with the following commits: commit 2ca0e0f17cba32ecc74c480088ac767cce688b92 Author: Christian Lohmaier Date: Sat Nov 17 21:01:47 2018 +0100 Branch libreoffice-6-2 This is 'libreoffice-6-2' - the stable branch for the 6.2.x releases. The commit rules are different according to the development phase: A. 6.2.0 beta phase: A. any bug fixes are allowed without review B. late features need approval by 3 people with different affiliation B. 6.2.0 rc phase and later: A. fixes need approval by one reviewer B. late features need approval by 3 more people with different affiliation IMPORTANT: Every developer is responsible for pushing the fixes into all appropriate branches. Note that we do not plan any merge from this branch to master or vice versa. Please, help use to make stable and usable release. If you want to build something cool, unstable, and risky, use master. Change-Id: I5a52629368f332dd3b5f5a9525047e338dd57ebc ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-libreoffice-6-2' - 0 commits -
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8a02a1d329c43df6de383a7b0cf8ac14247b18c9 Author: Christian Lohmaier AuthorDate: Sat Nov 17 21:03:33 2018 +0100 Commit: Christian Lohmaier CommitDate: Sat Nov 17 21:03:33 2018 +0100 bump product version to 6.3.0.0.alpha0+ Change-Id: Ia9d5785fd32823e3c4f5b40fd3db1dc89d217bbe diff --git a/configure.ac b/configure.ac index 442ada332ada..b968f83938ff 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([LibreOffice],[6.2.0.0.alpha1+],[],[],[http://documentfoundation.org/]) +AC_INIT([LibreOffice],[6.3.0.0.alpha0+],[],[],[http://documentfoundation.org/]) AC_PREREQ([2.59]) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'libreoffice-libreoffice-6-2'
New branch 'libreoffice-libreoffice-6-2' available with the following commits: commit 2ca0e0f17cba32ecc74c480088ac767cce688b92 Author: Christian Lohmaier Date: Sat Nov 17 21:01:47 2018 +0100 Branch libreoffice-6-2 This is 'libreoffice-6-2' - the stable branch for the 6.2.x releases. The commit rules are different according to the development phase: A. 6.2.0 beta phase: A. any bug fixes are allowed without review B. late features need approval by 3 people with different affiliation B. 6.2.0 rc phase and later: A. fixes need approval by one reviewer B. late features need approval by 3 more people with different affiliation IMPORTANT: Every developer is responsible for pushing the fixes into all appropriate branches. Note that we do not plan any merge from this branch to master or vice versa. Please, help use to make stable and usable release. If you want to build something cool, unstable, and risky, use master. Change-Id: I5a52629368f332dd3b5f5a9525047e338dd57ebc ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] translations.git: Changes to 'libreoffice-libreoffice-6-2'
New branch 'libreoffice-libreoffice-6-2' available with the following commits: commit 3f828a5b82478bc11c29db56288476e2b204ad2f Author: Christian Lohmaier Date: Sat Nov 17 21:01:20 2018 +0100 Branch libreoffice-6-2 This is 'libreoffice-6-2' - the stable branch for the 6.2.x releases. The commit rules are different according to the development phase: A. 6.2.0 beta phase: A. any bug fixes are allowed without review B. late features need approval by 3 people with different affiliation B. 6.2.0 rc phase and later: A. fixes need approval by one reviewer B. late features need approval by 3 more people with different affiliation IMPORTANT: Every developer is responsible for pushing the fixes into all appropriate branches. Note that we do not plan any merge from this branch to master or vice versa. Please, help use to make stable and usable release. If you want to build something cool, unstable, and risky, use master. Change-Id: Ie4d5d1da97ff343c27397b2d5862120978ddae6e ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: Changes to 'libreoffice-libreoffice-6-2'
New branch 'libreoffice-libreoffice-6-2' available with the following commits: commit 9e4ee1ee9c422f811557d7570bdc26e42a162987 Author: Christian Lohmaier Date: Sat Nov 17 21:01:19 2018 +0100 Branch libreoffice-6-2 This is 'libreoffice-6-2' - the stable branch for the 6.2.x releases. The commit rules are different according to the development phase: A. 6.2.0 beta phase: A. any bug fixes are allowed without review B. late features need approval by 3 people with different affiliation B. 6.2.0 rc phase and later: A. fixes need approval by one reviewer B. late features need approval by 3 more people with different affiliation IMPORTANT: Every developer is responsible for pushing the fixes into all appropriate branches. Note that we do not plan any merge from this branch to master or vice versa. Please, help use to make stable and usable release. If you want to build something cool, unstable, and risky, use master. Change-Id: I7867b07b0de23b9108fc0e2bbbe94841df8ea0ac ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Changes to 'libreoffice-libreoffice-6-2'
New branch 'libreoffice-libreoffice-6-2' available with the following commits: commit d51157294fedaaf963a3f727ab0d0141d0363fdc Author: Christian Lohmaier Date: Sat Nov 17 21:01:19 2018 +0100 Branch libreoffice-6-2 This is 'libreoffice-6-2' - the stable branch for the 6.2.x releases. The commit rules are different according to the development phase: A. 6.2.0 beta phase: A. any bug fixes are allowed without review B. late features need approval by 3 people with different affiliation B. 6.2.0 rc phase and later: A. fixes need approval by one reviewer B. late features need approval by 3 more people with different affiliation IMPORTANT: Every developer is responsible for pushing the fixes into all appropriate branches. Note that we do not plan any merge from this branch to master or vice versa. Please, help use to make stable and usable release. If you want to build something cool, unstable, and risky, use master. Change-Id: If51d297293e40c30f8f3fffdfa1446c9799f7367 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 121484] Notebookbar: Tabbed variant for Math
https://bugs.documentfoundation.org/show_bug.cgi?id=121484 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||107237 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107237 [Bug 107237] [META] Notebookbar Tabbed Implementation -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107237] [META] Notebookbar Tabbed Implementation
https://bugs.documentfoundation.org/show_bug.cgi?id=107237 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||121484 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=121484 [Bug 121484] Notebookbar: Tabbed variant for Math -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121484] Notebookbar: Tabbed variant for Math
https://bugs.documentfoundation.org/show_bug.cgi?id=121484 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121484] Notebookbar: Tabbed variant for Math
https://bugs.documentfoundation.org/show_bug.cgi?id=121484 --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Created attachment 146713 --> https://bugs.documentfoundation.org/attachment.cgi?id=146713=edit Tab bar Math mockup -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121484] New: Notebookbar: Tabbed variant for Math
https://bugs.documentfoundation.org/show_bug.cgi?id=121484 Bug ID: 121484 Summary: Notebookbar: Tabbed variant for Math Product: LibreOffice Version: 6.2.0.0.alpha1+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: 79045_79...@mail.ru Description: I want offer Tabbed variant of NB for Math Steps to Reproduce: 1. See mockup from attach 2. 3. Actual Results: We don't have Tabbed NB for Math Expected Results: We have Tabbed NB for Math Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6e4ec68783efb630e60a80e46817200ca89ed518 Author: Christian Lohmaier AuthorDate: Sat Nov 17 20:20:11 2018 +0100 Commit: Gerrit Code Review CommitDate: Sat Nov 17 20:42:39 2018 +0100 Update git submodules * Update translations from branch 'master' - final update of translations for 6.2.0 beta1 and force-fix using pocheck Change-Id: I355e7331efc15474a5b4e8277d8c375b5cac7c42 diff --git a/translations b/translations index 8ac785874f36..552fa2fbab05 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit 8ac785874f36764b40593b4c4d33b1a5848b4cc1 +Subproject commit 552fa2fbab0570d8f7747620cf8744662ce43d9c ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 121402] Can't Open Saved Files
https://bugs.documentfoundation.org/show_bug.cgi?id=121402 MM changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #4 from MM --- Maybe you start in 'safe mode' and see if you've still got problems. https://help.libreoffice.org/Common/Safe_Mode If you can open the files again, your lo user profile maybe corrupt: https://wiki.documentfoundation.org/UserProfile#Resolving_corruption_in_the_user_profile -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121447] File - Exit LibreOffice doesn't work on 6.2
https://bugs.documentfoundation.org/show_bug.cgi?id=121447 --- Comment #5 from BogdanB --- (In reply to Roman Kuznetsov from comment #4) > don't confirm in > > Версия: 6.2.0.0.alpha1+ > ID сборки: 7cf6cee97bc05512fae482733ee45f039e9d2160 > Потоков ЦП: 4; ОС:Linux 4.18; Отрисовка ИП: по умолчанию; VCL: kde5; > TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: > 2018-11-04_22:10:34 > Локаль: ru-RU (ru_RU.UTF-8); Calc: threaded > > > gtk3 problem? Please try with informations from comment 2. A new file opened with Help - About window, and then open a new window and try to exit with File - Exit Libre Office. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121482] [EDITING] Border Colors Are Not Shown in Border Options
https://bugs.documentfoundation.org/show_bug.cgi?id=121482 Maxim Monastirsky changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Maxim Monastirsky --- *** This bug has been marked as a duplicate of bug 121267 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: connectivity/source framework/source sd/qa
connectivity/source/drivers/firebird/PreparedStatement.cxx |8 framework/source/services/autorecovery.cxx |2 +- sd/qa/unit/import-tests-smartart.cxx |2 +- 3 files changed, 6 insertions(+), 6 deletions(-) New commits: commit 0143e976454f7937b3f9ba29113bbc36505173c8 Author: Andrea Gelmini AuthorDate: Sat Nov 17 09:43:23 2018 +0100 Commit: Julien Nabet CommitDate: Sat Nov 17 19:35:38 2018 +0100 Fix typos Change-Id: Ic7a29f572ce4c42cc88e5d45ebbb774c4b21aaa0 Reviewed-on: https://gerrit.libreoffice.org/63488 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/connectivity/source/drivers/firebird/PreparedStatement.cxx b/connectivity/source/drivers/firebird/PreparedStatement.cxx index 0fb8579b0894..e0d120d0cfec 100644 --- a/connectivity/source/drivers/firebird/PreparedStatement.cxx +++ b/connectivity/source/drivers/firebird/PreparedStatement.cxx @@ -567,7 +567,7 @@ void SAL_CALL OPreparedStatement::setClob(sal_Int32 nParameterIndex, const Refer break; } -// We need to make sure we close the Blob even if their are errors, hence evaluate +// We need to make sure we close the Blob even if there are errors, hence evaluate // errors after closing. closeBlobAfterWriting(aBlobHandle); @@ -605,7 +605,7 @@ void OPreparedStatement::setClob( sal_Int32 nParameterIndex, const OUString& rSt sData.getLength(), sData.getStr() ); -// We need to make sure we close the Blob even if their are errors, hence evaluate +// We need to make sure we close the Blob even if there are errors, hence evaluate // errors after closing. closeBlobAfterWriting(aBlobHandle); @@ -657,7 +657,7 @@ void SAL_CALL OPreparedStatement::setBlob(sal_Int32 nParameterIndex, } } -// We need to make sure we close the Blob even if their are errors, hence evaluate +// We need to make sure we close the Blob even if there are errors, hence evaluate // errors after closing. closeBlobAfterWriting(aBlobHandle); @@ -824,7 +824,7 @@ void SAL_CALL OPreparedStatement::setBytes(sal_Int32 nParameterIndex, } } -// We need to make sure we close the Blob even if their are errors, hence evaluate +// We need to make sure we close the Blob even if there are errors, hence evaluate // errors after closing. closeBlobAfterWriting(aBlobHandle); diff --git a/framework/source/services/autorecovery.cxx b/framework/source/services/autorecovery.cxx index cb1c30858d6a..da6c33022c23 100644 --- a/framework/source/services/autorecovery.cxx +++ b/framework/source/services/autorecovery.cxx @@ -737,7 +737,7 @@ private: Note further: it patches the info struct more than ones. E.g. the new temp URL is set before the file is saved. And the old URL is removed -only if removing oft he old file was successfully. +only if removing of the old file was successfully. If this method returns without an exception - everything was OK. Otherwise the info struct can be analyzed to get more information, e.g. when the problem occurs. diff --git a/sd/qa/unit/import-tests-smartart.cxx b/sd/qa/unit/import-tests-smartart.cxx index 56c504e40b72..edb64c3ba600 100644 --- a/sd/qa/unit/import-tests-smartart.cxx +++ b/sd/qa/unit/import-tests-smartart.cxx @@ -463,7 +463,7 @@ void SdImportTestSmartArt::testAccentProcess() CPPUNIT_ASSERT(xGroupShape.is()); // The pair is a parent (shape + text) and a child, so 3 shapes in total. -// The order is importent, first is at the back, last is at the front. +// The order is important, first is at the back, last is at the front. uno::Reference xFirstPair(xGroup->getByIndex(0), uno::UNO_QUERY); CPPUNIT_ASSERT(xFirstPair.is()); CPPUNIT_ASSERT_EQUAL(static_cast(3), xFirstPair->getCount()); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: framework/source qadevOOo/tests
framework/source/services/autorecovery.cxx |4 ++--
qadevOOo/tests/java/mod/_sc/ScModelObj.java|2 +-
qadevOOo/tests/java/mod/_sc/ScTableColumnsObj.java |2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
New commits:
commit b12acadfeade6749f2d3f522811539b6f1f6e664
Author: Andrea Gelmini
AuthorDate: Sat Nov 17 09:52:20 2018 +0100
Commit: Julien Nabet
CommitDate: Sat Nov 17 19:34:53 2018 +0100
Fix typos
Change-Id: Ie41eaccb9a70769e43b945595039f6f598e78c8a
Reviewed-on: https://gerrit.libreoffice.org/63489
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/framework/source/services/autorecovery.cxx
b/framework/source/services/autorecovery.cxx
index 844591d56a20..cb1c30858d6a 100644
--- a/framework/source/services/autorecovery.cxx
+++ b/framework/source/services/autorecovery.cxx
@@ -1092,8 +1092,8 @@ class CacheLockGuard
// this variable knows the state of the "cache lock"
sal_Int32& m_rCacheLock;
-// to prevent increasing/decreasing of m_rCacheLock more than ones
-// we must know if THIS guard has an actual lock set there !
+// to prevent increasing/decreasing of m_rCacheLock more than once
+// we must know if THIS guard has an actual lock set there!
bool m_bLockedByThisGuard;
public:
diff --git a/qadevOOo/tests/java/mod/_sc/ScModelObj.java
b/qadevOOo/tests/java/mod/_sc/ScModelObj.java
index 0b4589ddeec9..6df6d3becae2 100644
--- a/qadevOOo/tests/java/mod/_sc/ScModelObj.java
+++ b/qadevOOo/tests/java/mod/_sc/ScModelObj.java
@@ -118,7 +118,7 @@ public class ScModelObj extends TestCase {
PrintWriter
log) throws Exception {
// creation of the testobject here
// first we write what we are intend to do to log file
-log.println("craeting a test environment");
+log.println("creating a test environment");
// get a soffice factory object
SOfficeFactory SOF = SOfficeFactory.getFactory(
diff --git a/qadevOOo/tests/java/mod/_sc/ScTableColumnsObj.java
b/qadevOOo/tests/java/mod/_sc/ScTableColumnsObj.java
index dbb115acd695..97fab4bbbea3 100644
--- a/qadevOOo/tests/java/mod/_sc/ScTableColumnsObj.java
+++ b/qadevOOo/tests/java/mod/_sc/ScTableColumnsObj.java
@@ -98,7 +98,7 @@ public class ScTableColumnsObj extends TestCase {
// creation of the testobject here
// first we write what we are intend to do to log file
-log.println("craeting a test environment");
+log.println("creating a test environment");
log.println("getting column");
XSpreadsheets xSpreadsheets = xSheetDoc.getSheets();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 121483] New: My Libre Documents file has emptied.
https://bugs.documentfoundation.org/show_bug.cgi?id=121483 Bug ID: 121483 Summary: My Libre Documents file has emptied. Product: LibreOffice Version: 6.2.0.0.alpha0+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rstore...@gmail.com I can only now find my files in recent files as my default Documents file has emptied. When I try to "Save As" I get the search file and the file option is not given. This may be associated with a Windows 8.1 Update of yesterday. I do not have a recover to previous date on this computer.Any new file is now saved as a recent file with a path of c:user/library/ documents but I cannot find such a source. Am totally confused. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121469] FIREBIRD: Migration for table names with special characters fails
https://bugs.documentfoundation.org/show_bug.cgi?id=121469 --- Comment #6 from rob...@familiegrosskopf.de --- (In reply to m.a.riosv from comment #5) > CREATE TABLE Straße (CUST_NO INTEGER NOT NULL, CUSTOMER VARCHAR(25) NOT > NULL, PRIMARY KEY (CUST_NO) ) This is wrong code for creating a table with lower characters. "ß" is a special lower character. With CREATE TABLE Strasse the table will be named STRASSE. With the right delimiters CREATE TABLE "Straße" it will work well as observed by you. There will be used delimiters during the migration-process, because the tables where shown with lower and upper case characters. So this isn't the problem of the migration-process. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121482] [EDITING] Border Colors Are Not Shown in Border Options
https://bugs.documentfoundation.org/show_bug.cgi?id=121482 --- Comment #4 from n33...@bol.com.br --- Created attachment 146712 --> https://bugs.documentfoundation.org/attachment.cgi?id=146712=edit Incorrect form -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121482] [EDITING] Border Colors Are Not Shown in Border Options
https://bugs.documentfoundation.org/show_bug.cgi?id=121482 --- Comment #3 from n33...@bol.com.br --- Created attachment 146711 --> https://bugs.documentfoundation.org/attachment.cgi?id=146711=edit Incorrect form -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121482] [EDITING] Border Colors Are Not Shown in Border Options
https://bugs.documentfoundation.org/show_bug.cgi?id=121482 --- Comment #2 from n33...@bol.com.br --- Created attachment 146710 --> https://bugs.documentfoundation.org/attachment.cgi?id=146710=edit Incorrect form -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121482] [EDITING] Border Colors Are Not Shown in Border Options
https://bugs.documentfoundation.org/show_bug.cgi?id=121482 --- Comment #1 from n33...@bol.com.br --- Created attachment 146709 --> https://bugs.documentfoundation.org/attachment.cgi?id=146709=edit Correct form -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121469] FIREBIRD: Migration for table names with special characters fails
https://bugs.documentfoundation.org/show_bug.cgi?id=121469 --- Comment #5 from m.a.riosv --- If I'm not wrong LibreOffice base always use delimiters. Doing a test with direct SQL with a sentence like: CREATE TABLE TESTTABLE (CUST_NO INTEGER NOT NULL, CUSTOMER VARCHAR(25) NOT NULL, PRIMARY KEY (CUST_NO) ) works, but CREATE TABLE Straße (CUST_NO INTEGER NOT NULL, CUSTOMER VARCHAR(25) NOT NULL, PRIMARY KEY (CUST_NO) ) givers an error: 1: firebird_sdbc error:*Dynamic SQL Error *SQL error code = -104 *Token unknown - line 1, column 18. Just in the position of ß. With CREATE TABLE "Straße" seems work. Perhaps the issue it's the migration process not using delimiters. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121482] New: [EDITING] Border Colors Are Not Shown in Border Options
https://bugs.documentfoundation.org/show_bug.cgi?id=121482 Bug ID: 121482 Summary: [EDITING] Border Colors Are Not Shown in Border Options Product: LibreOffice Version: 6.1.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: n33...@bol.com.br Description: When you insert a new border color into the Calc the color indication square turns white. Only the black color is correct. Any other border color will be indicated as white. In the spreadsheet the color is entered correctly, but not indicated only white. Steps to Reproduce: 1.Insert a border in the worksheet. 2.Open the "properties" on the right bar and go to "cell appearance" 3.With the border on the worksheet try to change the color from the edge line on the display to any other color that is not black. Actual Results: After inserting a border in the worksheet try changing the in cell appearances. You will see that any color other than black does not look like the selected result. Expected Results: The color of the border in the worksheet is changed, however the color in the square of changes in the cell appearances is all white. Reproducible: Always User Profile Reset: No Additional Info: When selecting a color it should be shown on the white sampling square to indicate the exact color that is in the document. If the border color is red the square is red rather than white. -- Versão: 6.1.3.2 (x64) ID de compilação: 86daf60bf00efa86ad547e59e09d6bb77c699acb Threads da CPU:4; SO:Windows 10.0; Realizador da interface: GL; Local: pt-BR (pt_BR); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119415] Browser-based help search feature does not honor the "module" drop-down (local offline)
https://bugs.documentfoundation.org/show_bug.cgi?id=119415 --- Comment #12 from Buovjaga --- (In reply to Jim Avera from comment #11) > The exact page which was opened by Calc: Help->LibreOfficeDevHelp was > > file://.../6.2.0.0.alpha1/opt/libreofficedev6.2/help/en-US/text/shared/ > main0108.html?System=UNIX=CALC=.uno:HelpIndex#bm_id3149178 That page is the help about Help: https://helponline.libreoffice.org/6.2/en-US/text/shared/main0108.html?System=UNIX=CALC The url has text/shared so that means it is a common topic. Working as intended. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sc/inc sc/source
sc/inc/global.hxx |2 +-
sc/source/core/data/global.cxx | 11 ---
2 files changed, 5 insertions(+), 8 deletions(-)
New commits:
commit 170474a638301baceac7e1adb2ab250e5cd4c22a
Author: Luboš Luňák
AuthorDate: Fri Oct 12 11:47:02 2018 +0200
Commit: Caolán McNamara
CommitDate: Sat Nov 17 17:54:57 2018 +0100
thread-safe ScGlobal::GetUnitConverter()
Triggered by sc/qa/unit/data/functions/mathematical/fods/convert_ooo.fods
with SC_FORCE_CALCULATION=threads.
Change-Id: Ibedb32ee03519911650a0deee67011efeda57c93
Reviewed-on: https://gerrit.libreoffice.org/63175
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
(cherry picked from commit 9553f2afd0527ba435dae7bf4506c620a943b150)
Reviewed-on: https://gerrit.libreoffice.org/63376
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/inc/global.hxx b/sc/inc/global.hxx
index b9ef661f43db..b888b52a116e 100644
--- a/sc/inc/global.hxx
+++ b/sc/inc/global.hxx
@@ -519,7 +519,7 @@ class ScGlobal
static ScFunctionList* pStarCalcFunctionList;
static ScFunctionMgr* pStarCalcFunctionMgr;
-static ScUnitConverter* pUnitConverter;
+static std::atomic pUnitConverter;
static SvNumberFormatter* pEnglishFormatter; // for UNO / XML
export
diff --git a/sc/source/core/data/global.cxx b/sc/source/core/data/global.cxx
index f3819735f6dc..cb5a13ceed0f 100644
--- a/sc/source/core/data/global.cxx
+++ b/sc/source/core/data/global.cxx
@@ -109,7 +109,7 @@ SvxBrushItem* ScGlobal::pEmbeddedBrushItem = nullptr;
ScFunctionList* ScGlobal::pStarCalcFunctionList = nullptr;
ScFunctionMgr* ScGlobal::pStarCalcFunctionMgr = nullptr;
-ScUnitConverter* ScGlobal::pUnitConverter = nullptr;
+std::atomic ScGlobal::pUnitConverter(nullptr);
SvNumberFormatter* ScGlobal::pEnglishFormatter = nullptr;
ScFieldEditEngine* ScGlobal::pFieldEditEngine = nullptr;
@@ -586,7 +586,7 @@ void ScGlobal::Clear()
delete pLocale.load(); pLocale = nullptr;
DELETEZ(pStrClipDocName);
-DELETEZ(pUnitConverter);
+delete pUnitConverter.load(); pUnitConverter = nullptr;
DELETEZ(pFieldEditEngine);
DELETEZ(pEmptyOUString);
@@ -676,11 +676,8 @@ void ScGlobal::ResetFunctionList()
ScUnitConverter* ScGlobal::GetUnitConverter()
{
-assert(!bThreadedGroupCalcInProgress);
-if ( !pUnitConverter )
-pUnitConverter = new ScUnitConverter;
-
-return pUnitConverter;
+return comphelper::doubleCheckedInit( pUnitConverter,
+[]() { return new ScUnitConverter; });
}
const sal_Unicode* ScGlobal::UnicodeStrChr( const sal_Unicode* pStr,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sfx2/source
sfx2/source/doc/docfile.cxx | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
New commits:
commit f0388c306edfce91241d59420e96a5b2b1c939f5
Author: Mike Kaganski
AuthorDate: Thu Nov 8 20:42:28 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Nov 17 17:53:08 2018 +0100
tdf#121288: ReplaceFile WinAPI doesn't play nicely with WebDAV mapped drives
Change-Id: I0d7a64459de283dc10448e0086c66bedbf132553
Reviewed-on: https://gerrit.libreoffice.org/63133
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen
Tested-by: Gabor Kelemen
Reviewed-by: Mike Kaganski
(cherry picked from commit 603b63b4c154882ecfe95ae3c6960b08eb9fb626)
Reviewed-on: https://gerrit.libreoffice.org/63286
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index e101aa2e815d..11d6fc293301 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -200,7 +200,7 @@ sal_uInt64 GetDefaultFileAttributes(const OUString& rURL)
}
/// Determines if rURL is safe to move or not.
-bool IsFileMovable(const OUString& rURL)
+bool IsFileMovable(const INetURLObject& rURL)
{
#ifdef MACOSX
(void)rURL;
@@ -208,22 +208,25 @@ bool IsFileMovable(const OUString& rURL)
return false;
#else
-if (!comphelper::isFileUrl(rURL))
+if (rURL.GetProtocol() != INetProtocol::File)
// Not a file:// URL.
return false;
#ifdef UNX
-OUString rPath;
-if (osl::FileBase::getSystemPathFromFileURL(rURL, rPath) !=
osl::FileBase::E_None)
+OUString sPath = rURL.getFSysPath(FSysStyle::Unix);
+if (sPath.isEmpty())
return false;
struct stat buf;
-if (lstat(rPath.toUtf8().getStr(), ) != 0)
+if (lstat(sPath.toUtf8().getStr(), ) != 0)
return false;
// Hardlink or symlink: osl::File::move() doesn't play with these nicely.
if (buf.st_nlink > 1 || S_ISLNK(buf.st_mode))
return false;
+#elif defined _WIN32
+if (tools::IsMappedWebDAVPath(rURL))
+return false;
#endif
return true;
@@ -1860,7 +1863,7 @@ void SfxMedium::TransactedTransferForFS_Impl( const
INetURLObject& aSource,
OUString aDestMainURL =
aDest.GetMainURL(INetURLObject::DecodeMechanism::NONE);
sal_uInt64 nAttributes =
GetDefaultFileAttributes(aDestMainURL);
-if (IsFileMovable(aDestMainURL)
+if (IsFileMovable(aDest)
&& osl::File::replace(aSourceMainURL, aDestMainURL) ==
osl::FileBase::E_None)
{
if (nAttributes)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - 2 commits - basic/qa basic/source sw/qa writerfilter/source
basic/qa/basic_coverage/test_mid_replace_less.vb | 19
basic/qa/basic_coverage/test_mid_replace_more.vb | 17 +++
basic/qa/basic_coverage/test_mid_replace_more_end.vb | 19
basic/source/runtime/methods.cxx | 14 ++
sw/qa/extras/ooxmlimport/data/tdf121203.docx |binary
sw/qa/extras/ooxmlimport/ooxmlimport2.cxx|8 +++
writerfilter/source/dmapper/DomainMapper.cxx |2
writerfilter/source/dmapper/SdtHelper.cxx| 41 ---
writerfilter/source/dmapper/SdtHelper.hxx|4 +
9 files changed, 109 insertions(+), 15 deletions(-)
New commits:
commit 3478c3d40b06163816e15f63cf71892cfae9f868
Author: Miklos Vajna
AuthorDate: Mon Nov 12 23:01:12 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Nov 17 17:51:58 2018 +0100
tdf#121203 DOCX import: fix loss of free-form text in date control
Date SDT from DOCX is imported as date control since commit
3ec2d26dc2017ac4a27483febfc63328632f352d (bnc#779630 initial DOCX import
of w:sdt's w:date, 2013-04-30).
One detail I missed there is our date control is strict: it doesn't
allow free-form text. However, DOCX date SDT has an optional ISO date,
but the actual value can be free-form text. This means that importing
free-form text without an ISO date is lost on import.
Fix the data loss by restricting the creation of the date control: only
do this if we recognize the date format or in case we have an ISO date.
Otherwise just show the free-form text to avoid data loss.
(cherry picked from commit 3583f7a1256c901199574c8373443038e28813f0)
Change-Id: I8125bdc749954a6a1c496de74b6682744adb7680
Reviewed-on: https://gerrit.libreoffice.org/63335
Tested-by: Jenkins
Tested-by: Xisco Faulí
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sw/qa/extras/ooxmlimport/data/tdf121203.docx
b/sw/qa/extras/ooxmlimport/data/tdf121203.docx
new file mode 100644
index ..5aa3b2ed7474
Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/tdf121203.docx differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
b/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
index 3de2c9bcb097..6b54a7991fb3 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
@@ -37,6 +37,14 @@ DECLARE_OOXMLIMPORT_TEST(testTdf108545_embeddedDocxIcon,
"tdf108545_embeddedDocx
CPPUNIT_ASSERT_EQUAL(embed::Aspects::MSOLE_ICON, xSupplier->getAspect());
}
+DECLARE_OOXMLIMPORT_TEST(testTdf121203, "tdf121203.docx")
+{
+// Make sure that the date SDT's content is imported as plain text, as it
+// has no ISO date, so we have no idea how to represent that with our date
+// control.
+CPPUNIT_ASSERT_EQUAL(OUString("17-Oct-2018 09:00"),
getRun(getParagraph(1), 1)->getString());
+}
+
DECLARE_OOXMLIMPORT_TEST(testTdf109053, "tdf109053.docx")
{
// Table was imported into a text frame which led to a one page document
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx
b/writerfilter/source/dmapper/DomainMapper.cxx
index 07400a945856..b14db3d28767 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -3241,7 +3241,7 @@ void DomainMapper::lcl_utext(const sal_uInt8 * data_,
size_t len)
}
}
// Form controls are not allowed in headers / footers; see
sw::DocumentContentOperationsManager::InsertDrawObj()
-else if (!m_pImpl->m_pSdtHelper->getDateFormat().isEmpty() &&
!IsInHeaderFooter())
+else if (m_pImpl->m_pSdtHelper->validateDateFormat() &&
!IsInHeaderFooter())
{
/*
* Here we assume w:sdt only contains a single text token. We need to
diff --git a/writerfilter/source/dmapper/SdtHelper.cxx
b/writerfilter/source/dmapper/SdtHelper.cxx
index b80903e44efa..8f15d51a963e 100644
--- a/writerfilter/source/dmapper/SdtHelper.cxx
+++ b/writerfilter/source/dmapper/SdtHelper.cxx
@@ -21,6 +21,26 @@
#include "DomainMapper_Impl.hxx"
#include "StyleSheetTable.hxx"
+namespace
+{
+/// Maps OOXML values to UNO date format values.
+sal_Int16 getUNODateFormat(const OUString& rDateFormat)
+{
+// See com/sun/star/awt/UnoControlDateFieldModel.idl, DateFormat; sadly
+// there are no constants.
+sal_Int16 nDateFormat = -1;
+
+if (rDateFormat == "M/d/" || rDateFormat == "M.d.")
+// MMDD
+nDateFormat = 8;
+else if (rDateFormat == "dd/MM/")
+// DDMM
+nDateFormat = 7;
+
+return nDateFormat;
+}
+}
+
namespace writerfilter
{
namespace dmapper
@@ -89,6 +109,14 @@ void SdtHelper::createDropDownControl()
m_aDropDownItems.clear();
}
+bool SdtHelper::validateDateFormat()
+{
+bool bRet = !m_sDate.isEmpty() ||
getUNODateFormat(m_sDateFormat.toString()) != -1;
+if (!bRet)
+m_sDateFormat.setLength(0);
+return bRet;
[Libreoffice-bugs] [Bug 121479] text is pasted with strikethrough format
https://bugs.documentfoundation.org/show_bug.cgi?id=121479 Telesto changed: What|Removed |Added CC||tele...@surfxs.nl --- Comment #1 from Telesto --- Speculation: could t be the autocorrect option for * bold *, / italic /, - strikeout -, _ underline _ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sc/source
sc/source/filter/xml/XMLExportIterator.hxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit f2c6156a90093d38e1ab304d11ffed90555d5fa1
Author: Eike Rathke
AuthorDate: Wed Nov 14 15:57:36 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Nov 17 17:50:07 2018 +0100
Resolves: tdf#119700 save correct table:last-row-spanned
Regression from
commit f6e6a6139e90d6e88fb65308e8592193ac602a8a
CommitDate: Mon Nov 21 07:49:06 2016 +
tdf#48140 Replace uno CellRangeAddress and CellAddress with direct
calls
that calculated endrow-startcol instead of endrow-startrow.
Change-Id: Ie576f9abdcdc23fc5f0a06735caadc24e975360f
Reviewed-on: https://gerrit.libreoffice.org/63374
Reviewed-by: Eike Rathke
Tested-by: Jenkins
(cherry picked from commit 6e566c2b2b23d457a9fd47c16df15ce11e84c8e8)
Reviewed-on: https://gerrit.libreoffice.org/63382
Reviewed-by: Xisco Faulí
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/filter/xml/XMLExportIterator.hxx
b/sc/source/filter/xml/XMLExportIterator.hxx
index 11d88f004f01..a5dbaa0bc697 100644
--- a/sc/source/filter/xml/XMLExportIterator.hxx
+++ b/sc/source/filter/xml/XMLExportIterator.hxx
@@ -157,7 +157,7 @@ struct ScMyAreaLink
ScMyAreaLink() : nRefresh( 0 ) {}
sal_Int32GetColCount() const { return aDestRange.aEnd.Col() -
aDestRange.aStart.Col() + 1; }
-sal_Int32GetRowCount() const { return aDestRange.aEnd.Row() -
aDestRange.aStart.Col() + 1; }
+sal_Int32GetRowCount() const { return aDestRange.aEnd.Row() -
aDestRange.aStart.Row() + 1; }
boolCompare( const ScMyAreaLink& rAreaLink ) const;
booloperator<(const ScMyAreaLink& rAreaLink )
const;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source sw/uiconfig sw/UIConfig_swriter.mk
sw/UIConfig_swriter.mk |1
sw/source/ui/dialog/swdlgfact.cxx |2
sw/source/ui/fmtui/tmpdlg.cxx | 152 +++--
sw/source/uibase/inc/tmpdlg.hxx|4
sw/uiconfig/swriter/ui/comboboxfragment.ui |8 +
5 files changed, 69 insertions(+), 98 deletions(-)
New commits:
commit 35d548e414903c9f513c0899a2bab475ff56d0f0
Author: Caolán McNamara
AuthorDate: Sat Nov 17 15:33:54 2018 +
Commit: Caolán McNamara
CommitDate: Sat Nov 17 17:49:45 2018 +0100
weld writer numbering styles dialog
Change-Id: I697fa74a21acec550fcacd2a8d8468dfb21afcac
Reviewed-on: https://gerrit.libreoffice.org/63495
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sw/UIConfig_swriter.mk b/sw/UIConfig_swriter.mk
index 0ab905433e7d..37dffed460ed 100644
--- a/sw/UIConfig_swriter.mk
+++ b/sw/UIConfig_swriter.mk
@@ -112,6 +112,7 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/swriter,\
sw/uiconfig/swriter/ui/columndialog \
sw/uiconfig/swriter/ui/columnpage \
sw/uiconfig/swriter/ui/columnwidth \
+ sw/uiconfig/swriter/ui/comboboxfragment \
sw/uiconfig/swriter/ui/conditionpage \
sw/uiconfig/swriter/ui/converttexttable \
sw/uiconfig/swriter/ui/createaddresslist \
diff --git a/sw/source/ui/dialog/swdlgfact.cxx
b/sw/source/ui/dialog/swdlgfact.cxx
index c773d98038ac..83ae9b85ba41 100644
--- a/sw/source/ui/dialog/swdlgfact.cxx
+++ b/sw/source/ui/dialog/swdlgfact.cxx
@@ -1008,7 +1008,7 @@ VclPtr
SwAbstractDialogFactory_Impl::CreateTemplateDi
SwWrtShell* pActShell,
boolbNew )
{
-if (nRegion == SfxStyleFamily::Page)
+if (nRegion == SfxStyleFamily::Page || nRegion == SfxStyleFamily::Pseudo)
{
return
VclPtr::Create(o3tl::make_unique(pParent
? pParent->GetFrameWeld() : nullptr, rBase, nRegion, sPage, pActShell, bNew));
}
diff --git a/sw/source/ui/fmtui/tmpdlg.cxx b/sw/source/ui/fmtui/tmpdlg.cxx
index 43a520866966..20344ea0ed9b 100644
--- a/sw/source/ui/fmtui/tmpdlg.cxx
+++ b/sw/source/ui/fmtui/tmpdlg.cxx
@@ -100,10 +100,6 @@ SwTemplateDlg::SwTemplateDlg(vcl::Window* pParent,
, m_nHeaderId(0)
, m_nFooterId(0)
, m_nPageId(0)
-, m_nBulletId(0)
-, m_nNumId(0)
-, m_nNumOptId(0)
-, m_nNumPosId(0)
{
nHtmlMode = ::GetHtmlMode(pWrtShell->GetView().GetDocShell());
SfxAbstractDialogFactory* pFact = SfxAbstractDialogFactory::Create();
@@ -250,54 +246,6 @@ SwTemplateDlg::SwTemplateDlg(vcl::Window* pParent,
break;
}
-// page styles
-case SfxStyleFamily::Page:
-{
-// add Area and Transparence TabPages
-m_nAreaId = AddTabPage("area", pFact->GetTabPageCreatorFunc(
RID_SVXPAGE_AREA ), pFact->GetTabPageRangesFunc( RID_SVXPAGE_AREA ));
-m_nTransparenceId = AddTabPage("transparence",
pFact->GetTabPageCreatorFunc( RID_SVXPAGE_TRANSPARENCE ),
pFact->GetTabPageRangesFunc( RID_SVXPAGE_TRANSPARENCE ) );
-
-m_nHeaderId = AddTabPage("header", SvxHeaderPage::Create,
SvxHeaderPage::GetRanges);
-m_nFooterId = AddTabPage("footer", SvxFooterPage::Create,
SvxFooterPage::GetRanges);
-
-OSL_ENSURE(pFact->GetTabPageCreatorFunc( RID_SVXPAGE_PAGE ),
"GetTabPageCreatorFunc fail!");
-OSL_ENSURE(pFact->GetTabPageRangesFunc( RID_SVXPAGE_PAGE ),
"GetTabPageRangesFunc fail!");
-m_nPageId = AddTabPage("page",
-pFact->GetTabPageCreatorFunc(
RID_SVXPAGE_PAGE ),
-pFact->GetTabPageRangesFunc(
RID_SVXPAGE_PAGE ) );
-if (0 == ::GetHtmlMode(pWrtShell->GetView().GetDocShell()))
-{
-OSL_ENSURE(pFact->GetTabPageCreatorFunc( RID_SVXPAGE_BORDER ),
"GetTabPageCreatorFunc fail!");
-OSL_ENSURE(pFact->GetTabPageRangesFunc( RID_SVXPAGE_BORDER ),
"GetTabPageRangesFunc fail!");
-m_nBorderId = AddTabPage("borders",
-pFact->GetTabPageCreatorFunc(
RID_SVXPAGE_BORDER ), pFact->GetTabPageRangesFunc( RID_SVXPAGE_BORDER ) );
-m_nColumnId = AddTabPage("columns", SwColumnPage::Create,
SwColumnPage::GetRanges );
-AddTabPage("footnotes", SwFootNotePage::Create,
SwFootNotePage::GetRanges );
-AddTabPage("textgrid", SwTextGridPage::Create,
SwTextGridPage::GetRanges );
-SvtCJKOptions aCJKOptions;
-if(!aCJKOptions.IsAsianTypographyEnabled())
-RemoveTabPage("textgrid");
-}
-else
-{
-RemoveTabPage("borders");
-RemoveTabPage("columns");
-RemoveTabPage("footnotes");
-
[Libreoffice-ux-advise] [Bug 114900] CALC: Support custom data series in chart with labels and their values placed on two or more lines or columns
https://bugs.documentfoundation.org/show_bug.cgi?id=114900 rainer changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #3 from rainer --- The example originally attached was created only to show the noted behaviour. As you say, LO seems to be restricted to "basic" (single) rows and columns. Having to plot data sets that "wrap" over more than one row or column is maybe not as exotic, though. I remember having done so on MS Excel over 20 years ago (for my grad thesis). I have seen many other instances (e.g., accounting or budgeting) in which a data set may be separated in several tables (different sheets or not, depending on the user/company presentation/printing needs), but plots needed both for individual table data and for the whole lot. It wouldn't make sense to duplicate and re-arrange the data only for one plot. I do not have one of those with me now but I'll try to get my hands on a real-life example to see if I can share it. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 114900] CALC: Support custom data series in chart with labels and their values placed on two or more lines or columns
https://bugs.documentfoundation.org/show_bug.cgi?id=114900 rainer changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #3 from rainer --- The example originally attached was created only to show the noted behaviour. As you say, LO seems to be restricted to "basic" (single) rows and columns. Having to plot data sets that "wrap" over more than one row or column is maybe not as exotic, though. I remember having done so on MS Excel over 20 years ago (for my grad thesis). I have seen many other instances (e.g., accounting or budgeting) in which a data set may be separated in several tables (different sheets or not, depending on the user/company presentation/printing needs), but plots needed both for individual table data and for the whole lot. It wouldn't make sense to duplicate and re-arrange the data only for one plot. I do not have one of those with me now but I'll try to get my hands on a real-life example to see if I can share it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - 2 commits - sc/source
sc/source/core/tool/token.cxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit afbe6d46898f2c4137111afb4b08fb44b7713e28
Author: Luboš Luňák
AuthorDate: Thu Nov 8 15:08:48 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Nov 17 17:46:29 2018 +0100
blacklist svMatrix for calc threaded calculation
If a formula contains a matrix, interpreting it will actually result
in modifying it in some ways (e.g. ScInterpreter::PopRangeMatrix() calls
SetErrorInterpreter() on the matrix).
Testcase: rhbz#1645905
Change-Id: I63742449ba0e4e375d6e459dc7bccd7e6b62920e
Reviewed-on: https://gerrit.libreoffice.org/63187
Reviewed-by: Michael Meeks
Tested-by: Jenkins
Reviewed-on: https://gerrit.libreoffice.org/63379
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/core/tool/token.cxx b/sc/source/core/tool/token.cxx
index 8a448e9cd80c..494d1626cbc1 100644
--- a/sc/source/core/tool/token.cxx
+++ b/sc/source/core/tool/token.cxx
@@ -1367,6 +1367,7 @@ void ScTokenArray::CheckForThreading( const FormulaToken&
r )
case svExternalDoubleRef:
case svExternalSingleRef:
case svExternalName:
+case svMatrix:
SAL_INFO("sc.core.formulagroup", "opcode ocPush: variable type
" << StackVarEnumToString(r.GetType())
<< " disables threaded calculcation of formula group");
mbThreadingEnabled = false;
commit 319c88d41c2896937c8320bdaed44be01b25a0a1
Author: Luboš Luňák
AuthorDate: Fri Oct 12 13:42:17 2018 +0200
Commit: Caolán McNamara
CommitDate: Sat Nov 17 17:46:18 2018 +0100
blacklist svExternalName for calc threading
It's the same like svExternal(Single|Double)Ref, there's a lot of
thread-unsafe
code involved.
Change-Id: Ief8bbbd9393788c374215412ee5236ce6bb551fa
Reviewed-on: https://gerrit.libreoffice.org/63176
Reviewed-by: Michael Meeks
Tested-by: Jenkins
(cherry picked from commit 3460e91ac853964015215ec75be7cf63361ca0e9)
Reviewed-on: https://gerrit.libreoffice.org/63377
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/core/tool/token.cxx b/sc/source/core/tool/token.cxx
index db03b6a3f649..8a448e9cd80c 100644
--- a/sc/source/core/tool/token.cxx
+++ b/sc/source/core/tool/token.cxx
@@ -1366,6 +1366,7 @@ void ScTokenArray::CheckForThreading( const FormulaToken&
r )
{
case svExternalDoubleRef:
case svExternalSingleRef:
+case svExternalName:
SAL_INFO("sc.core.formulagroup", "opcode ocPush: variable type
" << StackVarEnumToString(r.GetType())
<< " disables threaded calculcation of formula group");
mbThreadingEnabled = false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: compilerplugins/clang include/vcl vcl/source
compilerplugins/clang/unusedenumconstants.writeonly.results |2 --
include/vcl/treelistbox.hxx |7 +++
vcl/source/treelist/treelistbox.cxx |4
3 files changed, 3 insertions(+), 10 deletions(-)
New commits:
commit 5197e6582e0658112013bd81b905b24e5c00b5ad
Author: Noel Grandin
AuthorDate: Sat Nov 17 14:54:23 2018 +0200
Commit: Caolán McNamara
CommitDate: Sat Nov 17 17:45:51 2018 +0100
remove unused IS_TRAVELSELECT
Change-Id: I2651b28ec52a001b67cdb3b2d88e8bca0eeb7790
Reviewed-on: https://gerrit.libreoffice.org/63493
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/compilerplugins/clang/unusedenumconstants.writeonly.results
b/compilerplugins/clang/unusedenumconstants.writeonly.results
index 6ba7ebb40d81..2efcd5310136 100644
--- a/compilerplugins/clang/unusedenumconstants.writeonly.results
+++ b/compilerplugins/clang/unusedenumconstants.writeonly.results
@@ -2726,8 +2726,6 @@ include/svtools/treelistbox.hxx:191
enum SvTreeListBoxFlags IN_EDT
include/svtools/treelistbox.hxx:192
enum SvTreeListBoxFlags EDT_ENABLED
-include/svtools/treelistbox.hxx:194
-enum SvTreeListBoxFlags IS_TRAVELSELECT
include/svtools/treelistbox.hxx:195
enum SvTreeListBoxFlags TARGEMPH_VIS
include/svtools/treelistbox.hxx:196
diff --git a/include/vcl/treelistbox.hxx b/include/vcl/treelistbox.hxx
index 5e7787b9ab88..675d141be53e 100644
--- a/include/vcl/treelistbox.hxx
+++ b/include/vcl/treelistbox.hxx
@@ -180,13 +180,12 @@ enum class SvTreeListBoxFlags
NONE = 0x,
IN_EDT = 0x0001,
EDT_ENABLED = 0x0002,
-IS_TRAVELSELECT = 0x0004,
-TARGEMPH_VIS = 0x0008,
-EDTEND_CALLED= 0x0010,
+TARGEMPH_VIS = 0x0004,
+EDTEND_CALLED= 0x0008,
};
namespace o3tl
{
-template<> struct typed_flags :
is_typed_flags {};
+template<> struct typed_flags :
is_typed_flags {};
}
struct SvTreeListBoxImpl;
diff --git a/vcl/source/treelist/treelistbox.cxx
b/vcl/source/treelist/treelistbox.cxx
index 65114a2a1936..a581fd5172e6 100644
--- a/vcl/source/treelist/treelistbox.cxx
+++ b/vcl/source/treelist/treelistbox.cxx
@@ -1954,16 +1954,12 @@ void SvTreeListBox::KeyInput( const KeyEvent& rKEvt )
if( IsEditingActive() )
return;
-nImpFlags |= SvTreeListBoxFlags::IS_TRAVELSELECT;
-
if( !pImpl->KeyInput( rKEvt ) )
{
bool bHandled = HandleKeyInput( rKEvt );
if ( !bHandled )
Control::KeyInput( rKEvt );
}
-
-nImpFlags &= ~SvTreeListBoxFlags::IS_TRAVELSELECT;
}
void SvTreeListBox::RequestingChildren( SvTreeListEntry* pParent )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sw/source
sw/source/uibase/utlui/content.cxx |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
New commits:
commit 9968f6bc25c3ec416a6db863a8d8642ae9a26126
Author: Michael Stahl
AuthorDate: Mon Nov 5 13:41:29 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Nov 17 17:44:36 2018 +0100
sw: fix crash in SwContentTree::HasContentChanged()
Remove() will remove the node including its children, but
SvTreeList::Next() will actually return the first child, so the pChild
points to an entry that has been deleted.
Change-Id: Ia4bd75d64c8436ea03c0727a8d49ee0c34fda16f
(cherry picked from commit cdbe48633f198250e883837dac5d93f93a42888d)
Reviewed-on: https://gerrit.libreoffice.org/63427
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index b6d5946c9b23..9c6c26c1e47b 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -2187,14 +2187,11 @@ bool SwContentTree::HasContentChanged()
}
if(bRemoveChildren)
{
-SvTreeListEntry* pChild = FirstChild(pEntry);
-SvTreeListEntry* pRemove = pChild;
for(size_t j = 0; j < nChildCount; ++j)
{
-pChild = Next(pRemove);
+SvTreeListEntry *const pRemove =
FirstChild(pEntry);
assert(pRemove);
GetModel()->Remove(pRemove);
-pRemove = pChild;
}
}
if(!nChildCount)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
