Re: Compiler baselines

2018-11-22 Thread Stephan Bergmann 

On 21/11/2018 17:42, Stephan Bergmann wrote:
If nobody objects, we'd update the build baselines on master (towards LO 
6.3) as follows (cf README.md):


(also discussed this in yesterday's ESC, 
 
"minutes of ESC call ...")



* Windows: from Visual Studio 2017 to Visual Studio 2017 version 15.7


The relevant Windows Jenkins nodes (tb68-bytemark, tb72, tb73, tb77, and 
tb78, I assume) need to be upgraded to >= Visual Studio 2017 version 
15.7.  Who can do that?  Cloph?


(The latest available Visual Studio 2017 is version 15.9, and I have 
seen successful builds with it locally.  When installing a new version 
on the Jenkins nodes, there are pros and cons for both choosing 15.7 and 
15.9.  15.7 will guarantee that Gerrit checks against the baseline, 
while we'll need to upgrade the nodes sooner.  15.9 will postpone the 
need to upgrade again in the future, but Gerrit doesn't exactly check 
against the baseline.  I'll leave that decision at the discretion of 
those who'll actually do the upgrade :)


Also,  "Require at least 
flex 2.6.0, which no longer emits 'register'" failing on tb73 due to 
"checking the flex version... configure: error: failed 
(C:/cygwin/bin/flex 2.5.39 found, but need at least 2.6.0)" shows that 
at least some of the relevant Windows Jenkins nodes have outdated Cygwin 
utilities.  Who can update these?  flex 2.5.35 and gperf 3.1 would be 
relevant.  The Jenkins admin_lode job can't do that automatically, I 
think.  Cloph, can you do it manually?



* macOS: from Xcode 8 to Xcode 9.3


(Nothing needs to be done for this on the Jenkins side, as reportedly 
all relevant macOS nodes are already on some Xcode 9.3 or later.)



* Linux GCC: from GCC 4.8.1 to GCC 7


(See the discussion in its own sub-thread at 
 
"Re: Compiler baselines" about rolling this out on Jenkins.)



* Linux Clang: from Clang to Clang 5.0.2


The relevant Linux Jenkins nodes (tb75-lilith, tb76-maggie, and 
tb79-pollux) have been updated (via admin_lode and 
 
"On Linux, upgrade to Clang 5 plus libstdc++ 7").



* Clang compiler plugins: from Clang 3.8 to Clang 5.0.2


Enforced with 
 
"Bump compiler plugins Clang baseline to 5.0.2".



* flex: from 2.5.35 to 2.6.0


The relevant Linux Jenkins nodes (tb75-lilith, tb76-maggie, and 
tb79-pollux) and most of the relevant macOS Jenkins nodes (tb57, tb58, 
tb66, gb69, tb80, and tb81; tb59 and tb82 are permanently offline) have 
been updated (via admin_lode and 
 
"Install flex 2.6.4 if necessary").  The relevant Windows Jenkins nodes 
apparently still need updating (see above).



* gperf: from 3.0.0 to 3.1


The relevant Linux Jenkins nodes (tb75-lilith, tb76-maggie, and 
tb79-pollux) and most of the relevant macOS Jenkins nodes (tb57, tb58, 
tb66, gb69, tb80, and tb81; tb59 and tb82 are permanently offline) have 
been updated (via admin_ldoe and 
 
"On Linux, use latest gperf 3.1" resp. 
 
"Install gperf 3.1 if necessary").  The relevant Windows Jenkins nodes 
presumably still need updating (see above).

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 121401] Notebookbar F6 + Tab didn't work

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121401

--- Comment #12 from andreas_k  ---
I submit the patch for can_focus True in sfxlo-NotebookbarTabControl it works
really nice.
Change-Id: I5e4b3559bdb642a3e0d8a44ad744efe65b684e59

In writer tabbed NB (notebookbar.ui) I added shortcuts support to the tabbs,
but it doesn't work. Do you know how it will work. (will add the shortcuts to
the other apps if it will work in writer)

Thanks for your help, you improve the NB a lot.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/svtools svtools/source

2018-11-22 Thread Libreoffice Gerrit user 
 include/svtools/valueset.hxx|8 -
 svtools/source/control/valueset.cxx |  162 ++--
 2 files changed, 49 insertions(+), 121 deletions(-)

New commits:
commit 8ea1bdce62880448a42bcc4a283308bdccebb2cf
Author: Mike Kaganski 
AuthorDate: Thu Nov 22 15:20:16 2018 +0300
Commit: Mike Kaganski 
CommitDate: Fri Nov 23 08:37:34 2018 +0100

Get rid of ValueSet's internal VirtualDevice, draw to RenderContext

This improves support for Online HiDPI scenarios.

Change-Id: I1d4d13d8877b761cabaefa028dcd50d8345d9893
Reviewed-on: https://gerrit.libreoffice.org/63827
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/include/svtools/valueset.hxx b/include/svtools/valueset.hxx
index b085a3e9e314..dacdd25eb5eb 100644
--- a/include/svtools/valueset.hxx
+++ b/include/svtools/valueset.hxx
@@ -197,8 +197,6 @@ typedef std::vector> 
SvtValueItemList;
 class SVT_DLLPUBLIC ValueSet : public Control
 {
 private:
-
-ScopedVclPtr maVirDev;
 Timer   maTimer;
 ValueItemList   mItemList;
 std::unique_ptr mpNoneItem;
@@ -248,11 +246,10 @@ private:
 
 SVT_DLLPRIVATE void ImplInitScrollBar();
 SVT_DLLPRIVATE void ImplDeleteItems();
-SVT_DLLPRIVATE void ImplFormatItem(vcl::RenderContext const & 
rRenderContext, ValueSetItem* pItem, tools::Rectangle aRect);
+SVT_DLLPRIVATE void ImplFormatItem(vcl::RenderContext& 
rRenderContext, ValueSetItem* pItem, tools::Rectangle aRect);
 SVT_DLLPRIVATE void ImplDrawItemText(vcl::RenderContext& 
rRenderContext, const OUString& rStr);
 SVT_DLLPRIVATE void ImplDrawSelect(vcl::RenderContext& 
rRenderContext, sal_uInt16 nItemId, const bool bFocus, const bool bDrawSel);
 SVT_DLLPRIVATE void ImplDrawSelect(vcl::RenderContext& 
rRenderContext);
-SVT_DLLPRIVATE void ImplHideSelect(sal_uInt16 nItemId);
 SVT_DLLPRIVATE void ImplHighlightItem(sal_uInt16 nItemId, bool 
bIsSelection = true);
 SVT_DLLPRIVATE void ImplDraw(vcl::RenderContext& rRenderContext);
 using Window::ImplScroll;
@@ -273,6 +270,8 @@ private:
 ValueSet (const ValueSet &) = delete;
 ValueSet & operator= (const ValueSet &) = delete;
 
+SVT_DLLPRIVATE void Format(vcl::RenderContext& rRenderContext);
+
 protected:
 void StartDrag( const CommandEvent& rCEvt, vcl::Region& rRegion );
 
@@ -372,7 +371,6 @@ public:
 
 voidSetExtraSpacing( sal_uInt16 nNewSpacing );
 
-voidFormat(vcl::RenderContext const & rRenderContext);
 voidSetFormat();
 
 voidStartSelection();
diff --git a/svtools/source/control/valueset.cxx 
b/svtools/source/control/valueset.cxx
index 4e57665d21ed..7d89298a2e6e 100644
--- a/svtools/source/control/valueset.cxx
+++ b/svtools/source/control/valueset.cxx
@@ -59,7 +59,6 @@ enum
 
 ValueSet::ValueSet( vcl::Window* pParent, WinBits nWinStyle ) :
 Control( pParent, nWinStyle ),
-maVirDev( VclPtr::Create(*this) ),
 maColor( COL_TRANSPARENT )
 {
 mpNoneItem.reset(nullptr);
@@ -93,9 +92,6 @@ ValueSet::ValueSet( vcl::Window* pParent, WinBits nWinStyle ) 
:
 mbEdgeBlending  = false;
 mbHasVisibleItems   = false;
 
-// #106446#, #106601# force mirroring of virtual device
-maVirDev->EnableRTL( GetParent()->IsRTLEnabled() );
-
 ImplInitSettings( true, true, true );
 }
 
@@ -203,7 +199,7 @@ void ValueSet::ImplInitScrollBar()
 }
 }
 
-void ValueSet::ImplFormatItem(vcl::RenderContext const & rRenderContext, 
ValueSetItem* pItem, tools::Rectangle aRect)
+void ValueSet::ImplFormatItem(vcl::RenderContext& rRenderContext, 
ValueSetItem* pItem, tools::Rectangle aRect)
 {
 WinBits nStyle = GetStyle();
 if (nStyle & WB_ITEMBORDER)
@@ -224,7 +220,7 @@ void ValueSet::ImplFormatItem(vcl::RenderContext const & 
rRenderContext, ValueSe
 }
 else
 {
-DecorationView aView(maVirDev.get());
+DecorationView aView();
 aRect = aView.DrawFrame(aRect, mnFrameStyle);
 }
 }
@@ -239,42 +235,45 @@ void ValueSet::ImplFormatItem(vcl::RenderContext const & 
rRenderContext, ValueSe
 
 if (pItem == mpNoneItem.get())
 {
-maVirDev->SetFont(rRenderContext.GetFont());
-maVirDev->SetTextColor((nStyle & WB_MENUSTYLEVALUESET) ? 
rStyleSettings.GetMenuTextColor() : rStyleSettings.GetWindowTextColor());
-maVirDev->SetTextFillColor();
-maVirDev->SetFillColor((nStyle & WB_MENUSTYLEVALUESET) ? 
rStyleSettings.GetMenuColor() : rStyleSettings.GetWindowColor());
-maVirDev->DrawRect(aRect);
+rRenderContext.SetTextColor((nStyle & WB_MENUSTYLEVALUESET)
+? rStyleSettings.GetMenuTextColor()
+: rStyleSettings.GetWindowTextColor());
+rRenderContext.SetTextFillColor();
+rRenderContext.SetFillColor((nStyle &

[Libreoffice-bugs] [Bug 121647] font list box preview certain malformed TTF fonts crash LO

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121647

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #4 from Aron Budea  ---
I don't get the crash with DFKaiSho-SB when scrolling through the font list,
but when I close Writer right afterwards, sometimes I do. With the other font
it does crash right away, though. Tested with LO 6.1.3.2 / Windows 7.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Compiler baselines

2018-11-22 Thread Stephan Bergmann 

On 23/11/2018 00:48, Thorsten Wagner wrote:

Due to other changes building master is no longer possible with macOS 10.11. 
SDK 10.13 is required now (maybe SDK 10.12 but I’m unable to verify this).


According to README.md (in the root of the core repo), our build 
baseline is 10.12, while the runtime baseline we target with those 
builds is 10.9.


(And I'm not going to change any of that in the context of this compiler 
baseline bump.)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: compilerplugins/clang configure.ac README.md

2018-11-22 Thread Libreoffice Gerrit user 
 README.md   |2 
 compilerplugins/clang/casttovoid.cxx|4 -
 compilerplugins/clang/checkconfigmacros.cxx |   12 ---
 compilerplugins/clang/compat.hxx|   76 
 compilerplugins/clang/constantparam.cxx |2 
 compilerplugins/clang/constfields.cxx   |5 -
 compilerplugins/clang/constparams.cxx   |2 
 compilerplugins/clang/countusersofdefaultparams.cxx |2 
 compilerplugins/clang/dynexcspec.cxx|5 -
 compilerplugins/clang/expandablemethods.cxx |4 -
 compilerplugins/clang/external.cxx  |8 --
 compilerplugins/clang/externvar.cxx |3 
 compilerplugins/clang/includeform.cxx   |3 
 compilerplugins/clang/methodcycles.cxx  |8 --
 compilerplugins/clang/oslendian.cxx |6 -
 compilerplugins/clang/overrideparam.cxx |3 
 compilerplugins/clang/plugin.cxx|2 
 compilerplugins/clang/redundantinline.cxx   |9 --
 compilerplugins/clang/salbool.cxx   |4 -
 compilerplugins/clang/singlevalfields.cxx   |4 -
 compilerplugins/clang/staticconstfield.cxx  |2 
 compilerplugins/clang/test/staticconstfield.cxx |2 
 compilerplugins/clang/test/staticvar.cxx|2 
 compilerplugins/clang/test/unnecessaryoverride.cxx  |2 
 compilerplugins/clang/test/useuniqueptr.cxx |2 
 compilerplugins/clang/unnecessaryvirtual.cxx|3 
 compilerplugins/clang/unusedfields.cxx  |   10 --
 compilerplugins/clang/unusedmethods.cxx |8 --
 compilerplugins/clang/unusedmethodsremove.cxx   |2 
 compilerplugins/clang/useuniqueptr.cxx  |4 -
 compilerplugins/clang/virtualdown.cxx   |8 --
 configure.ac|4 -
 32 files changed, 31 insertions(+), 182 deletions(-)

New commits:
commit f23aa1a51cb1beea4ebe3a61ba0c9b3abd844fd9
Author: Stephan Bergmann 
AuthorDate: Thu Nov 22 19:57:38 2018 +0100
Commit: Stephan Bergmann 
CommitDate: Fri Nov 23 08:20:53 2018 +0100

Bump compiler plugins Clang baseline to 5.0.2

...as discussed at


"minutes of ESC call ..."

Change-Id: Ia053da171d59747984546f38e19da808825b4f79
Reviewed-on: https://gerrit.libreoffice.org/63832
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/README.md b/README.md
index 1e32005147d3..39fe759836c6 100644
--- a/README.md
+++ b/README.md
@@ -50,7 +50,7 @@ C++17, C++14, or C++11" in its current form (due to the 
#pragma GCC diagnostic i
 that it does not understand).
 
 If you want to use Clang with the LibreOffice compiler plugins, the minimal
-version of Clang is 3.8. Since Xcode doesn't provide the compiler plugin
+version of Clang is 5.0.2. Since Xcode doesn't provide the compiler plugin
 headers, you have to compile your own Clang to use them on macOS.
 
 You can find the TDF configure switches in the distro-configs/ directory.
diff --git a/compilerplugins/clang/casttovoid.cxx 
b/compilerplugins/clang/casttovoid.cxx
index 3812618a7283..e6da5b6d7445 100644
--- a/compilerplugins/clang/casttovoid.cxx
+++ b/compilerplugins/clang/casttovoid.cxx
@@ -105,7 +105,6 @@ public:
 return ret;
 }
 
-#if CLANG_VERSION >= 5
 bool TraverseCXXDeductionGuideDecl(CXXDeductionGuideDecl * decl) {
 returnTypes_.push(decl->getReturnType());
 auto const ret = RecursiveASTVisitor::TraverseCXXDeductionGuideDecl(
@@ -115,7 +114,6 @@ public:
 returnTypes_.pop();
 return ret;
 }
-#endif
 
 bool TraverseCXXMethodDecl(CXXMethodDecl * decl) {
 returnTypes_.push(decl->getReturnType());
@@ -489,7 +487,7 @@ private:
 }
 auto const loc = compat::getBeginLoc(dre);
 if (compiler.getSourceManager().isMacroArgExpansion(loc)
-&& (compat::getImmediateMacroNameForDiagnostics(
+&& (Lexer::getImmediateMacroNameForDiagnostics(
 loc, compiler.getSourceManager(), compiler.getLangOpts())
 == "assert"))
 {
diff --git a/compilerplugins/clang/checkconfigmacros.cxx 
b/compilerplugins/clang/checkconfigmacros.cxx
index 7e0a722ef2bb..cff2d41dd6df 100644
--- a/compilerplugins/clang/checkconfigmacros.cxx
+++ b/compilerplugins/clang/checkconfigmacros.cxx
@@ -37,11 +37,7 @@ class CheckConfigMacros
 explicit CheckConfigMacros( const InstantiationData& data );
 virtual void run() override;
 virtual void MacroDefined( const Token& macroToken, const 
MacroDirective* info ) override;
-virtual void MacroUndefined( const Token& macroToken, MacroDefinition 
const &
-#if CLANG_VERSION >= 5
-, MacroDirective const *

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - icon-themes/colibre icon-themes/colibre_svg

2018-11-22 Thread Libreoffice Gerrit user 
 icon-themes/colibre/cmd/lc_acceptalltrackedchanges.png |binary
 icon-themes/colibre/cmd/lc_autooutline.png |binary
 icon-themes/colibre/cmd/lc_currencyfield.png   |binary
 icon-themes/colibre/cmd/lc_dataconsolidate.png |binary
 icon-themes/colibre/cmd/lc_dataincolumns.png   |binary
 icon-themes/colibre/cmd/lc_dataproviderrefresh.png |binary
 icon-themes/colibre/cmd/lc_datasubtotals.png   |binary
 icon-themes/colibre/cmd/lc_formattedfield.png  |binary
 icon-themes/colibre/cmd/lc_group.png   |binary
 icon-themes/colibre/cmd/lc_hideallnotes.png|binary
 icon-themes/colibre/cmd/lc_hidedetail.png  |binary
 icon-themes/colibre/cmd/lc_insertcolumnbreak.png   |binary
 icon-themes/colibre/cmd/lc_insertlinebreak.png |binary
 icon-themes/colibre/cmd/lc_label.png   |binary
 icon-themes/colibre/cmd/lc_name.png|binary
 icon-themes/colibre/cmd/lc_sharedocument.png   |binary
 icon-themes/colibre/cmd/lc_showallnotes.png|binary
 icon-themes/colibre/cmd/lc_showdetail.png  |binary
 icon-themes/colibre/cmd/lc_ungroup.png |binary
 icon-themes/colibre/cmd/lc_validation.png  |binary
 icon-themes/colibre/cmd/sc_acceptalltrackedchanges.png |binary
 icon-themes/colibre/cmd/sc_autooutline.png |binary
 icon-themes/colibre/cmd/sc_currencyfield.png   |binary
 icon-themes/colibre/cmd/sc_dataconsolidate.png |binary
 icon-themes/colibre/cmd/sc_dataincolumns.png   |binary
 icon-themes/colibre/cmd/sc_dataproviderrefresh.png |binary
 icon-themes/colibre/cmd/sc_datasubtotals.png   |binary
 icon-themes/colibre/cmd/sc_formatgroup.png |binary
 icon-themes/colibre/cmd/sc_formattedfield.png  |binary
 icon-themes/colibre/cmd/sc_group.png   |binary
 icon-themes/colibre/cmd/sc_hideallnotes.png|binary
 icon-themes/colibre/cmd/sc_hidedetail.png  |binary
 icon-themes/colibre/cmd/sc_insertcolumnbreak.png   |binary
 icon-themes/colibre/cmd/sc_insertlinebreak.png |binary
 icon-themes/colibre/cmd/sc_label.png   |binary
 icon-themes/colibre/cmd/sc_name.png|binary
 icon-themes/colibre/cmd/sc_sharedocument.png   |binary
 icon-themes/colibre/cmd/sc_showallnotes.png|binary
 icon-themes/colibre/cmd/sc_showdetail.png  |binary
 icon-themes/colibre/cmd/sc_statisticsmenu.png  |binary
 icon-themes/colibre/cmd/sc_ungroup.png |binary
 icon-themes/colibre/cmd/sc_validation.png  |binary
 icon-themes/colibre/links.txt  |   41 +---
 icon-themes/colibre_svg/cmd/lc_acceptalltrackedchanges.svg |   20 
 icon-themes/colibre_svg/cmd/lc_autooutline.svg |   20 
 icon-themes/colibre_svg/cmd/lc_currencyfield.svg   |   62 +
 icon-themes/colibre_svg/cmd/lc_dataconsolidate.svg |   18 +++
 icon-themes/colibre_svg/cmd/lc_dataincolumns.svg   |   16 +++
 icon-themes/colibre_svg/cmd/lc_dataproviderrefresh.svg |   30 ++
 icon-themes/colibre_svg/cmd/lc_datasubtotals.svg   |   22 
 icon-themes/colibre_svg/cmd/lc_definename.svg  |1 
 icon-themes/colibre_svg/cmd/lc_formattedfield.svg  |   15 ++-
 icon-themes/colibre_svg/cmd/lc_group.svg   |   19 +++
 icon-themes/colibre_svg/cmd/lc_hideallnotes.svg|   15 +++
 icon-themes/colibre_svg/cmd/lc_hidedetail.svg  |   10 ++
 icon-themes/colibre_svg/cmd/lc_insertcolumnbreak.svg   |   14 ++
 icon-themes/colibre_svg/cmd/lc_insertlinebreak.svg |   14 ++
 icon-themes/colibre_svg/cmd/lc_label.svg   |   13 ++
 icon-themes/colibre_svg/cmd/lc_name.svg|   16 +++
 icon-themes/colibre_svg/cmd/lc_sharedocument.svg   |   18 +++
 icon-themes/colibre_svg/cmd/lc_showallnotes.svg|   10 ++
 icon-themes/colibre_svg/cmd/lc_showdetail.svg  |   10 ++
 icon-themes/colibre_svg/cmd/lc_ungroup.svg |   19 +++
 icon-themes/colibre_svg/cmd/lc_validation.svg  |   18 +++
 icon-themes/colibre_svg/cmd/sc_acceptalltrackedchanges.svg |   16 +++
 icon-themes/colibre_svg/cmd/sc_autooutline.svg |   14 ++
 icon-themes/colibre_svg/cmd/sc_currencyfield.svg   |   34 +++
 icon-themes/colibre_svg/cmd/sc_dataconsolidate.svg |   15 +++
 icon-themes/colibre_svg/cmd/sc_dataincolumns.svg   |   16 +++
 icon-themes/colibre_svg/cmd/sc_dataproviderrefresh.svg |   18 +++
 icon-themes/colibre_svg/cmd/sc_datasubtotals.svg   |   22 
 icon-themes/colibre_svg/cmd/sc_definename.svg  |2

[Libreoffice-commits] core.git: svx/source

2018-11-22 Thread Libreoffice Gerrit user 
 svx/source/unodraw/unoshape.cxx |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 80cf278d365a2d357c70b8c28947c91fa97e7a99
Author: Markus Mohrhard 
AuthorDate: Fri Nov 23 01:21:29 2018 +0100
Commit: Markus Mohrhard 
CommitDate: Fri Nov 23 08:00:40 2018 +0100

tdf#114836, only set changed SfxItemSet properties

By always setting all existing properties again the calls started
to differ between XMultiPropertySet::setPropertyValues and
XPropertySet::setPropertyValue. This patch reduces the changes in
the called methods. We can not avoid slight differences but at least
the risk is minimized that something is unexpectedly changed.

Change-Id: I5866db7be2829e6aba930f620f45db655df4e3f7
Reviewed-on: https://gerrit.libreoffice.org/63854
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard 

diff --git a/svx/source/unodraw/unoshape.cxx b/svx/source/unodraw/unoshape.cxx
index 21938249c7f5..09ec87f7ab54 100644
--- a/svx/source/unodraw/unoshape.cxx
+++ b/svx/source/unodraw/unoshape.cxx
@@ -1617,7 +1617,11 @@ void SvxShape::_setPropertyValue( const OUString& 
rPropertyName, const uno::Any&
 {
 if( mpImpl->mpItemSet == nullptr )
 {
-mpImpl->mpItemSet = GetSdrObject()->GetMergedItemSet().Clone();
+mpImpl->mpItemSet.reset(new SfxItemSet( 
GetSdrObject()->getSdrModelFromSdrObject().GetItemPool(),  {{pMap->nWID, 
pMap->nWID}}));
+}
+else
+{
+mpImpl->mpItemSet->MergeRange(pMap->nWID, pMap->nWID);
 }
 pSet = mpImpl->mpItemSet.get();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 121401] Notebookbar F6 + Tab didn't work

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121401

--- Comment #11 from Jim Raykowski  ---
(In reply to andreas_k from comment #8)
> about the other recommendations (thanks for that). In File tab you have each
> command in an separate NotebookbarToolBox so with F6 + tab you switch from
> one command to the next. As notebookbar_compact is very simple (cause it's
> only one row) I will suggest to have in the other tabbs also each command in
> an separate NotebookbarToolBox so you don't need F6 + tab + arrow key, you
> only need F6 + tab.
> 
> What do you think Jim?

Sidebar uses F6, tab, arrows, space, and esc keys for keyboard navigation. F6
to enter sidebar, tab to navigate panel title bar and panel content tool boxes,
arrows to navigate items in tool boxes and among panel titles and tab bar
buttons, esc to move to panel title and to document. If all toolboxes in all
notebookbars are made single item toolboxes, navigation of controls would be
consistent in notebookbar but inconsistent with sidebar where control groups
are separated by space as opposed to the vertical separator used in notebookbar
ui's.

In writer Tabbed interface (notebookbar.ui), I find the same behavior as in
Tabbed Compact (notebookbar_compact.ui) where Shortcuts tool box containing
Menubar, Open, Save, Undo, Redo, and Print controls and Hamburger popup menu
can not be reached using keyboard navigation. Tab cycle in Tabbed interface
does not include the tab bar tab title as in Tabbed Compact[1]. The common
method used to switch tabs in both Tabbed interface and Tabbed Compact
interface is Ctrl+(Shift)Tab. Making controls tab navigation cycle include
notebookbar tab title for Tabbed interface would provide a method by using
Ctrl+Left/Right keys to navigate to the Shortcuts tool box and Hamburger menu.
I can provide a patch for this if it is decided acceptable.

[1] To include tab bar tab title in tab cycle: 
/core/sw/uiconfig/swriter/ui/notebookbar.ui:1840

True
False   <-- needs to be True
to focus to tab title

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104449] [META] DOCX (OOXML) textbox-related issues

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=104449
Bug 104449 depends on bug 100920, which changed state.

Bug 100920 Summary: FILEOPEN DOCX Text box position (absolute position right to 
column and below paragraph) wrong in LO (left to paragraph and top to margin)
https://bugs.documentfoundation.org/show_bug.cgi?id=100920

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100920] FILEOPEN DOCX Text box position (absolute position right to column and below paragraph) wrong in LO (left to paragraph and top to margin)

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100920

Alankrit  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100979] Complex Line displayed as 'single' and hiding text line below

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100979

Alankrit  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104520] [META] DOCX (OOXML) bug tracker

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=104520
Bug 104520 depends on bug 100979, which changed state.

Bug 100979 Summary: Complex Line displayed as 'single' and hiding text line 
below
https://bugs.documentfoundation.org/show_bug.cgi?id=100979

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg

2018-11-22 Thread Libreoffice Gerrit user 
 icon-themes/colibre/cmd/lc_acceptalltrackedchanges.png |binary
 icon-themes/colibre/cmd/lc_autooutline.png |binary
 icon-themes/colibre/cmd/lc_currencyfield.png   |binary
 icon-themes/colibre/cmd/lc_dataconsolidate.png |binary
 icon-themes/colibre/cmd/lc_dataincolumns.png   |binary
 icon-themes/colibre/cmd/lc_dataproviderrefresh.png |binary
 icon-themes/colibre/cmd/lc_datasubtotals.png   |binary
 icon-themes/colibre/cmd/lc_formattedfield.png  |binary
 icon-themes/colibre/cmd/lc_group.png   |binary
 icon-themes/colibre/cmd/lc_hideallnotes.png|binary
 icon-themes/colibre/cmd/lc_hidedetail.png  |binary
 icon-themes/colibre/cmd/lc_insertcolumnbreak.png   |binary
 icon-themes/colibre/cmd/lc_insertlinebreak.png |binary
 icon-themes/colibre/cmd/lc_label.png   |binary
 icon-themes/colibre/cmd/lc_name.png|binary
 icon-themes/colibre/cmd/lc_sharedocument.png   |binary
 icon-themes/colibre/cmd/lc_showallnotes.png|binary
 icon-themes/colibre/cmd/lc_showdetail.png  |binary
 icon-themes/colibre/cmd/lc_ungroup.png |binary
 icon-themes/colibre/cmd/lc_validation.png  |binary
 icon-themes/colibre/cmd/sc_acceptalltrackedchanges.png |binary
 icon-themes/colibre/cmd/sc_autooutline.png |binary
 icon-themes/colibre/cmd/sc_currencyfield.png   |binary
 icon-themes/colibre/cmd/sc_dataconsolidate.png |binary
 icon-themes/colibre/cmd/sc_dataincolumns.png   |binary
 icon-themes/colibre/cmd/sc_dataproviderrefresh.png |binary
 icon-themes/colibre/cmd/sc_datasubtotals.png   |binary
 icon-themes/colibre/cmd/sc_formatgroup.png |binary
 icon-themes/colibre/cmd/sc_formattedfield.png  |binary
 icon-themes/colibre/cmd/sc_group.png   |binary
 icon-themes/colibre/cmd/sc_hideallnotes.png|binary
 icon-themes/colibre/cmd/sc_hidedetail.png  |binary
 icon-themes/colibre/cmd/sc_insertcolumnbreak.png   |binary
 icon-themes/colibre/cmd/sc_insertlinebreak.png |binary
 icon-themes/colibre/cmd/sc_label.png   |binary
 icon-themes/colibre/cmd/sc_name.png|binary
 icon-themes/colibre/cmd/sc_sharedocument.png   |binary
 icon-themes/colibre/cmd/sc_showallnotes.png|binary
 icon-themes/colibre/cmd/sc_showdetail.png  |binary
 icon-themes/colibre/cmd/sc_statisticsmenu.png  |binary
 icon-themes/colibre/cmd/sc_ungroup.png |binary
 icon-themes/colibre/cmd/sc_validation.png  |binary
 icon-themes/colibre/links.txt  |   41 +---
 icon-themes/colibre_svg/cmd/lc_acceptalltrackedchanges.svg |   20 
 icon-themes/colibre_svg/cmd/lc_autooutline.svg |   20 
 icon-themes/colibre_svg/cmd/lc_currencyfield.svg   |   62 +
 icon-themes/colibre_svg/cmd/lc_dataconsolidate.svg |   18 +++
 icon-themes/colibre_svg/cmd/lc_dataincolumns.svg   |   16 +++
 icon-themes/colibre_svg/cmd/lc_dataproviderrefresh.svg |   30 ++
 icon-themes/colibre_svg/cmd/lc_datasubtotals.svg   |   22 
 icon-themes/colibre_svg/cmd/lc_definename.svg  |1 
 icon-themes/colibre_svg/cmd/lc_formattedfield.svg  |   15 ++-
 icon-themes/colibre_svg/cmd/lc_group.svg   |   19 +++
 icon-themes/colibre_svg/cmd/lc_hideallnotes.svg|   15 +++
 icon-themes/colibre_svg/cmd/lc_hidedetail.svg  |   10 ++
 icon-themes/colibre_svg/cmd/lc_insertcolumnbreak.svg   |   14 ++
 icon-themes/colibre_svg/cmd/lc_insertlinebreak.svg |   14 ++
 icon-themes/colibre_svg/cmd/lc_label.svg   |   13 ++
 icon-themes/colibre_svg/cmd/lc_name.svg|   16 +++
 icon-themes/colibre_svg/cmd/lc_sharedocument.svg   |   18 +++
 icon-themes/colibre_svg/cmd/lc_showallnotes.svg|   10 ++
 icon-themes/colibre_svg/cmd/lc_showdetail.svg  |   10 ++
 icon-themes/colibre_svg/cmd/lc_ungroup.svg |   19 +++
 icon-themes/colibre_svg/cmd/lc_validation.svg  |   18 +++
 icon-themes/colibre_svg/cmd/sc_acceptalltrackedchanges.svg |   16 +++
 icon-themes/colibre_svg/cmd/sc_autooutline.svg |   14 ++
 icon-themes/colibre_svg/cmd/sc_currencyfield.svg   |   34 +++
 icon-themes/colibre_svg/cmd/sc_dataconsolidate.svg |   15 +++
 icon-themes/colibre_svg/cmd/sc_dataincolumns.svg   |   16 +++
 icon-themes/colibre_svg/cmd/sc_dataproviderrefresh.svg |   18 +++
 icon-themes/colibre_svg/cmd/sc_datasubtotals.svg   |   22 
 icon-themes/colibre_svg/cmd/sc_definename.svg  |2

[Libreoffice-bugs] [Bug 121536] Embedding external (links) images programmatically no longer works

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121536

--- Comment #2 from Simon  ---
Thanks a million Oliver. 

What I was trying to do is the opposite of your example, but it helped me a
lot! I don't like being force to check the product and version but it works.
Thanks again.

Here's my new function:

  private static void convertLinkedImagesToEmbeded(
  final XComponentContext context, final XComponent document) throws
Exception {

// Create a GraphicProvider.
final XGraphicProvider graphicProvider =
UnoRuntime.queryInterface(
XGraphicProvider.class,
context
.getServiceManager()
   
.createInstanceWithContext("com.sun.star.graphic.GraphicProvider", context));
final XIndexAccess indexAccess =
UnoRuntime.queryInterface(
XIndexAccess.class,
UnoRuntime.queryInterface(XTextGraphicObjectsSupplier.class,
document)
.getGraphicObjects());
for (int i = 0; i < indexAccess.getCount(); i++) {
  final Any xImageAny = (Any) indexAccess.getByIndex(i);
  final Object xImageObject = xImageAny.getObject();
  final XTextContent xImage = (XTextContent) xImageObject;
  final XServiceInfo xInfo = UnoRuntime.queryInterface(XServiceInfo.class,
xImage);
  if (xInfo.supportsService("com.sun.star.text.TextGraphicObject")) {
final XPropertySet xPropSet =
UnoRuntime.queryInterface(XPropertySet.class, xImage);
if (is LibreOffice and Version >= 6.1) { ***
  final XGraphic xGraphic =
  (XGraphic)
  AnyConverter.toObject(XGraphic.class,
xPropSet.getPropertyValue("Graphic"));
  // Only ones that are not embedded
  final XPropertySet xGraphixPropSet =
UnoRuntime.queryInterface(XPropertySet.class, xGraphic);
  boolean linked = (boolean)
xGraphixPropSet.getPropertyValue("Linked");
  if (linked) {
// Since 6.1, we must use "Graphic" instead of "GraphicURL"
final PropertyValue[] props =
new PropertyValue[] {new PropertyValue(), new PropertyValue()};
props[0].Name = "URL";
props[0].Value =
xGraphixPropSet.getPropertyValue("OriginURL").toString();
props[1].Name = "LoadAsLink";
props[1].Value = false;
xPropSet.setPropertyValue("Graphic",
graphicProvider.queryGraphic(props));
  }
} else {
  final String name =
xPropSet.getPropertyValue("LinkDisplayName").toString();
  final String graphicURL =
xPropSet.getPropertyValue("GraphicURL").toString();
  // Only ones that are not embedded
  if (graphicURL.indexOf("vnd.sun.") == -1) {
// Creating bitmap container service
final XNameContainer bitmapContainer =
UnoRuntime.queryInterface(
XNameContainer.class,
UnoRuntime.queryInterface(XMultiServiceFactory.class,
document)
.createInstance("com.sun.star.drawing.BitmapTable"));
if (!bitmapContainer.hasByName(name)) {
  bitmapContainer.insertByName(name, graphicURL);
  xPropSet.setPropertyValue("GraphicURL",
bitmapContainer.getByName(name).toString());
}
  }
}
  }
}
  }

*** I didn't show how to check the product and version, the function would have
been too long, but I've been inspired by the Utilities made by Dr. Andrew
Davison that can be found here:
http://fivedots.coe.psu.ac.th/~ad/jlop

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57599] Stop overlapping images

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=57599

--- Comment #22 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57351] Calc: "Insert columns" is not available in the context menu if an autofilter to hide rows is applied

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=57351

--- Comment #23 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121651] Crash in: SwAccessibleMap::GetContext(SwFrame const *, bool)

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121651

intelat...@gmail.com changed:

   What|Removed |Added

Version|unspecified |6.0.6.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121651] New: Crash in: SwAccessibleMap::GetContext(SwFrame const *, bool)

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121651

Bug ID: 121651
   Summary: Crash in: SwAccessibleMap::GetContext(SwFrame const
*,bool)
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: intelat...@gmail.com

This bug was filed from the crash reporting server and is
br-474eae30-c2e6-4f93-84c0-4329038b8867.
=
Many many more crash reports with same signature
http://crashreport.libreoffice.org/stats/signature/SwAccessibleMap::GetContext(SwFrame%20const%20*,bool)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sd/inc sd/source

2018-11-22 Thread Libreoffice Gerrit user 
 sd/inc/sdfilter.hxx  |5 +
 sd/source/filter/cgm/sdcgmfilter.cxx |7 -
 sd/source/filter/sdfilter.cxx|   37 --
 sd/source/filter/sdpptwrp.cxx|  126 ++-
 sd/source/ui/app/sddll.cxx   |2 
 5 files changed, 93 insertions(+), 84 deletions(-)

New commits:
commit 33675c657960ce2de2c0d0576f4cff64cc44e1df
Author: Michael Meeks 
AuthorDate: Wed Nov 21 19:07:41 2018 +
Commit: Michael Meeks 
CommitDate: Fri Nov 23 04:10:13 2018 +0100

Re-factor internal filter logic, and impl. preload properly.

Change-Id: I4c55ceb19d5db2c1e4756901d0d8b14878641a99
Reviewed-on: https://gerrit.libreoffice.org/63761
Tested-by: Jenkins
Reviewed-by: Michael Meeks 
(cherry picked from commit 7b34fb18a4d60bfc4e32b7c382ac596cbc2e776f)
Reviewed-on: https://gerrit.libreoffice.org/63850

diff --git a/sd/inc/sdfilter.hxx b/sd/inc/sdfilter.hxx
index 17ce09d3647b..fb184ff10626 100644
--- a/sd/inc/sdfilter.hxx
+++ b/sd/inc/sdfilter.hxx
@@ -20,6 +20,7 @@
 #ifndef INCLUDED_SD_INC_SDFILTER_HXX
 #define INCLUDED_SD_INC_SDFILTER_HXX
 
+#include 
 #include 
 #include 
 #include 
@@ -42,7 +43,9 @@ public:
 virtual boolExport() = 0;
 
 #ifndef DISABLE_DYNLOADING
-static ::osl::Module*   OpenLibrary( const OUString& rLibraryName );
+static void Preload();
+/// Open library @rLibraryName and lookup symbol @rFnSymbol
+static oslGenericFunction GetLibrarySymbol( const OUString& rLibraryName, 
const OUString  );
 #endif
 
 protected:
diff --git a/sd/source/filter/cgm/sdcgmfilter.cxx 
b/sd/source/filter/cgm/sdcgmfilter.cxx
index 73e4cc9392d2..c8841c42fdb5 100644
--- a/sd/source/filter/cgm/sdcgmfilter.cxx
+++ b/sd/source/filter/cgm/sdcgmfilter.cxx
@@ -61,17 +61,14 @@ namespace
 class CGMPointer
 {
 ImportCGMPointer m_pPointer;
-#ifndef DISABLE_DYNLOADING
-std::unique_ptr m_xLibrary;
-#endif
 public:
 CGMPointer()
 {
 #ifdef DISABLE_DYNLOADING
 m_pPointer = ImportCGM;
 #else
-m_xLibrary.reset(SdFilter::OpenLibrary("icg"));
-m_pPointer = m_xLibrary ? 
reinterpret_cast(m_xLibrary->getFunctionSymbol("ImportCGM")) 
: nullptr;
+m_pPointer = reinterpret_cast(
+SdFilter::GetLibrarySymbol("icg", "ImportCGM"));
 #endif
 }
 ImportCGMPointer get() { return m_pPointer; }
diff --git a/sd/source/filter/sdfilter.cxx b/sd/source/filter/sdfilter.cxx
index b822baa21c5c..fbffe2cf5ed9 100644
--- a/sd/source/filter/sdfilter.cxx
+++ b/sd/source/filter/sdfilter.cxx
@@ -58,14 +58,41 @@ OUString SdFilter::ImplGetFullLibraryName( const OUString& 
rLibraryName )
 }
 
 #ifndef DISABLE_DYNLOADING
+
+typedef std::map> SdModuleMap;
+static SdModuleMap g_SdModuleMap;
+
 extern "C" { static void thisModule() {} }
 
-::osl::Module* SdFilter::OpenLibrary( const OUString& rLibraryName )
+oslGenericFunction SdFilter::GetLibrarySymbol( const OUString& rLibraryName, 
const OUString  )
+{
+osl::Module *pMod = nullptr;
+auto it = g_SdModuleMap.find(rLibraryName);
+if (it != g_SdModuleMap.end())
+pMod = it->second.get();
+
+if (!pMod)
+{
+pMod = new osl::Module;
+if (pMod->loadRelative(, 
ImplGetFullLibraryName(rLibraryName),
+   SAL_LOADMODULE_GLOBAL | SAL_LOADMODULE_LAZY))
+g_SdModuleMap[rLibraryName] = std::unique_ptr(pMod);
+else
+{
+delete pMod;
+pMod = nullptr;
+}
+}
+if (!pMod)
+return nullptr;
+else
+return pMod->getFunctionSymbol(rFnSymbol);
+}
+
+void SdFilter::Preload()
 {
-std::unique_ptr< osl::Module > mod(new osl::Module);
-return mod->loadRelative(, ImplGetFullLibraryName(rLibraryName),
- SAL_LOADMODULE_GLOBAL | SAL_LOADMODULE_LAZY)
-? mod.release() : nullptr;
+(void)GetLibrarySymbol("sdfilt", "ImportPPT");
+(void)GetLibrarySymbol("icg", "ImportCGM");
 }
 
 #endif
diff --git a/sd/source/filter/sdpptwrp.cxx b/sd/source/filter/sdpptwrp.cxx
index df3f4da8d010..0eaf9934a22b 100644
--- a/sd/source/filter/sdpptwrp.cxx
+++ b/sd/source/filter/sdpptwrp.cxx
@@ -74,7 +74,7 @@ SdPPTFilter::~SdPPTFilter()
 
 bool SdPPTFilter::Import()
 {
-boolbRet = false;
+bool bRet = false;
 tools::SvRef pStorage = new SotStorage( 
mrMedium.GetInStream(), false );
 if( !pStorage->GetError() )
 {
@@ -97,24 +97,18 @@ bool SdPPTFilter::Import()
 mrMedium.SetError(ERRCODE_SVX_READ_FILTER_PPOINT);
 else
 {
-#ifndef DISABLE_DYNLOADING
-::osl::Module* pLibrary = OpenLibrary( 
mrMedium.GetFilter()->GetUserData() );
-if ( pLibrary )
-{
-ImportPPTPointer PPTImport = reinterpret_cast< 
ImportPPTPointer >( pLibrary->getFunctionSymbol( "ImportPPT" ) );
-if ( PPTImport )
-

[Libreoffice-bugs] [Bug 121650] New: LibreOffice 6.1.1.2 Calc - Date formatting for US and UK are interchanged

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121650

Bug ID: 121650
   Summary: LibreOffice 6.1.1.2 Calc - Date formatting for US and
UK are interchanged
   Product: LibreOffice
   Version: 6.1.1.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: topoc...@gmail.com

Description:
Date formatting for US and UK are interchanged



Steps to Reproduce:
1.Choose US formatting and you get DD/MM/YY
2.Choose UK formatting and you get MM/DD/YY
3.

Actual Results:
Choose US formatting and you get DD/MM/YY
Choose UK formatting and you get MM/DD/YY

Expected Results:
Choose US formatting and you should get MM/DD/YY
Choose UK formatting and you should get DD/MM/YY


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121618] VIEWING: When the document displays !broken!! instead of the correct text, writer can lock up

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121618

--- Comment #7 from Luke Kendall  ---
Created attachment 146935
  --> https://bugs.documentfoundation.org/attachment.cgi?id=146935=edit
The render errors, now highlighted and numbered

The reason I suspected data corruption in the text run structure is because as
well as the '!br0ken!!' text displayed there are errors in the rendering of the
three lines before that.

I had replaced the name 'Gadger' with the name 'Wiz' and the text should be
fully justified.
1. Instead that line ends with a "-" that does not appear in the actual text.
2. The same line starts with the text "me" instead of the text "some".
3. The following line also starts with a rendered space character " eyed",
which again should not happen because of full justification.
4. There's a similar subtle problem on the line before the line I had edited -
there is a space rendered after "For", despite the full justification. 

Hope this helps.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121647] font list box preview certain malformed TTF fonts crash LO

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121647

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||haveBacktrace

--- Comment #3 from V Stuart Foote  ---
Here is a WinDbg stacktrace of 6.1.3.2 run against the Character dialog
scrolling onto the dfmw5.ttf font...


0:017> g
ModLoad: 7ffd`30fd 7ffd`31201000   C:\Program
Files\LibreOffice\program\dict_zh.dll
ModLoad: 7ffd`39ae 7ffd`39c7c000   C:\Program
Files\LibreOffice\program\localedata_others.dll
ModLoad: 7ffd`58dd 7ffd`58f5b000   C:\Program
Files\LibreOffice\program\sal_textenclo.dll
(2a24.20f0): Access violation - code c005 (first chance)
First chance exceptions are reported before any exception handling.
This exception may be expected and handled.
ntdll!RtlpLowFragHeapAllocFromContext+0x5e9:
7ffd`72383419 410fb781ae00 movzx   eax,word ptr [r9+0AEh]
ds:9e94`9f3f=
0:000> g
(2a24.20f0): Access violation - code c005 (!!! second chance !!!)
ntdll!RtlpLowFragHeapAllocFromContext+0x5e9:
7ffd`72383419 410fb781ae00 movzx   eax,word ptr [r9+0AEh]
ds:9e94`9f3f=
0:000> ~* kp

.  0  Id: 2a24.20f0 Suspend: 1 Teb: 00a7`99e31000 Unfrozen
 # Child-SP  RetAddr   Call Site
00 00a7`9a98d7f0 7ffd`7238265b
ntdll!RtlpLowFragHeapAllocFromContext+0x5e9
01 00a7`9a98d8d0 7ffd`6f29a506 ntdll!RtlpAllocateHeapInternal+0xeb
02 00a7`9a98d9b0 7ffd`65400c40 ucrtbase!_malloc_base+0x36
03 (Inline Function) ` sal3!rtl_allocateMemory_SYSTEM+0x6
[c:\cygwin64\home\buildslave\source\libo-core\sal\rtl\alloc_global.cxx @ 232] 
04 00a7`9a98d9e0 7ffd`6541949d sal3!rtl_allocateMemory(unsigned int64 n
= )+0x40
[c:\cygwin64\home\buildslave\source\libo-core\sal\rtl\alloc_global.cxx @ 259] 
05 00a7`9a98da20 7ffd`6541a65a sal3!rtl_uString_ImplAlloc(long nLen =
0n28)+0x2d [c:\cygwin64\home\buildslave\source\libo-core\sal\rtl\strtmpl.cxx @
1155] 
06 00a7`9a98da50 7ffd`3bf8dc9f
sal3!rtl_uString_newFromStr_WithLength(struct _rtl_uString ** ppThis =
0x00a7`9a98dac8, char16_t * pCharStr = 0x01f8`aa96a6ea
"org.openoffice.Office.Common/Misc/FontsUseWinMetrics", long nLen = 0n28)+0x3a
[c:\cygwin64\home\buildslave\source\libo-core\sal\rtl\strtmpl.cxx @ 1374] 
07 00a7`9a98da80 7ffd`3c19e2ce mergedlo!rtl::OUString::copy(long
beginIndex = , long count = )+0x2f
[c:\cygwin64\home\buildslave\source\libo-core\include\rtl\ustring.hxx @ 2215] 
08 00a7`9a98dac0 7ffd`3c176742
mergedlo!configmgr::Data::parseSegment(class rtl::OUString * path =
0x00a7`9a98dd10 "/org.openoffice.Office.Common/Misc/FontsUseWinMetrics",
long index = , class rtl::OUString * name =
0x00a7`9a98db38 empty, bool * setElement = 0x00a7`9a98dbd0, class
rtl::OUString * templateName = 0x00a7`9a98dbd8 empty)+0x16e
[c:\cygwin64\home\buildslave\source\libo-core\configmgr\source\data.cxx @ 124] 
09 00a7`9a98db00 7ffd`3c173d3b
mergedlo!configmgr::Access::getSubChild(class rtl::OUString * path =
0x00a7`9a98dd10
"/org.openoffice.Office.Common/Misc/FontsUseWinMetrics")+0x372
[c:\cygwin64\home\buildslave\source\libo-core\configmgr\source\access.cxx @
2001] 
0a 00a7`9a98dbc0 7ffd`3c1a58d1
mergedlo!configmgr::Access::getByHierarchicalName(class rtl::OUString * aName =
0x00a7`9a98dd10
"/org.openoffice.Office.Common/Misc/FontsUseWinMetrics")+0x6b
[c:\cygwin64\home\buildslave\source\libo-core\configmgr\source\access.cxx @
436] 
0b 00a7`9a98dc30 7ffd`3c0b7714
mergedlo!configmgr::read_write_access::`anonymous
namespace'::Service::getByHierarchicalName(class rtl::OUString * aName =
0x00a7`9a98dd10
"/org.openoffice.Office.Common/Misc/FontsUseWinMetrics")+0x51
[c:\cygwin64\home\buildslave\source\libo-core\configmgr\source\readwriteaccess.cxx
@ 76] 
0c 00a7`9a98dc70 7ffd`3ddf94fb
mergedlo!comphelper::detail::ConfigurationWrapper::getPropertyValue(class
rtl::OUString * path = )+0x24
[c:\cygwin64\home\buildslave\source\libo-core\comphelper\source\misc\configuration.cxx
@ 140] 
0d 00a7`9a98dcb0 7ffd`3ddf8ffb
mergedlo!comphelper::ConfigurationProperty
>::get(class
com::sun::star::uno::Reference *
context = 0x00a7`9a98dd78 {{...}})+0x5b
[c:\cygwin64\home\buildslave\source\libo-core\include\comphelper\configuration.hxx
@ 210] 
0e 00a7`9a98dd10 7ffd`3ddf85b5
mergedlo!ImplFontMetricData::ShouldUseWinMetrics(struct vcl::TTGlobalFontInfo *
rInfo = )+0x23b
[c:\cygwin64\home\buildslave\source\libo-core\vcl\source\font\fontmetric.cxx @
412] 
0f 00a7`9a98de70 7ffd`3de7bbb5
mergedlo!ImplFontMetricData::ImplCalcLineSpacing(class std::vector > * rHheaData = 0x00a7`9a98dfe0 {
size=36 }, class std::vector > *
rOS2Data = 0x00a7`9a98dfc8 { size=86 }, int nUPEM = )+0x135
[c:\cygwin64\home\buildslave\source\libo-core\vcl\source\font\fontmetric.cxx @

[Libreoffice-bugs] [Bug 121618] VIEWING: When the document displays !broken!! instead of the correct text, writer can lock up

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121618

Luke Kendall  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121618] VIEWING: When the document displays !broken!! instead of the correct text, writer can lock up

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121618

--- Comment #6 from Luke Kendall  ---
Created attachment 146934
  --> https://bugs.documentfoundation.org/attachment.cgi?id=146934=edit
The document in which the problem occurred, now obfuscated

Find performance was so bad it was basically unusable because I had
change tracking and show changes turned on, and making a massive change (every
consonant turned into an x).

But now it's apparently frozen trying to just start a save.
I can't close the F panel.  I killed it and started again with change
tracking off.
F showed visible progress now, completing in about 5 minutes.

I have turned change tracking back on, and attached the sample document.
But I don't have reproduction steps for the problem, sorry.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121649] FILEOPEN: Drawing lines not displayed

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121649

--- Comment #4 from Xisco Faulí  ---
Created attachment 146933
  --> https://bugs.documentfoundation.org/attachment.cgi?id=146933=edit
attachment 66500

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121649] FILEOPEN: Drawing lines not displayed

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121649

--- Comment #3 from Xisco Faulí  ---
Same behaviour reproduced with the arrows in attachment 66500 from bug 54398

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121649] FILEOPEN: Drawing lines not displayed

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121649

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||0728

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121649] FILEOPEN: Drawing lines not displayed

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121649

Xisco Faulí  changed:

   What|Removed |Added

 CC||armin.le.gr...@me.com
   Keywords||bibisected, bisected,
   ||regression
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from Xisco Faulí  ---
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=52bbb04f1e39b2d778275c91f77b6c0714ecd0d0

author  Armin Le Grand   2018-10-31 20:47:49 +0100
committer   Armin Le Grand   2018-11-01 10:58:57
+0100
commit  52bbb04f1e39b2d778275c91f77b6c0714ecd0d0 (patch)
tree6e51e676a95c8147fd5055ebeab78ec36d4dd6cf
parent  88cbc3ea2db8358bbedff01361f95f972f2b0231 (diff)
tdf#120728 support SvxShape for SdrShape if not inserted

Bisected with: bibisect-linux64-6.2

Adding Cc: to Armin Le Grand

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121649] FILEOPEN: Drawing lines not displayed

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121649

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Created attachment 146932
  --> https://bugs.documentfoundation.org/attachment.cgi?id=146932=edit
how it looks in MSO 2010

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121649] New: FILEOPEN: Drawing lines not displayed

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121649

Bug ID: 121649
   Summary: FILEOPEN: Drawing lines not displayed
   Product: LibreOffice
   Version: 6.2.0.0.alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Created attachment 146931
  --> https://bugs.documentfoundation.org/attachment.cgi?id=146931=edit
minimal sample

Steps to reproduce:
1. Open attached document

-> Three lines should be displayed on first page. it's empty though

Reproduced in

Version: 6.2.0.0.beta1+
Build ID: a5bb6a0406d0018d1df279b925c80b392d9db277
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

[Bug found by office-interoperability-tools]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121648] FILEOPEN: EMF+: String Drawing is unreadable

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121648

Xisco Faulí  changed:

   What|Removed |Added

 Blocks||103859


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103859
[Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=103859

Xisco Faulí  changed:

   What|Removed |Added

 Depends on||121648


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121648
[Bug 121648] FILEOPEN: EMF+: String Drawing is unreadable
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121648] FILEOPEN: EMF+: String Drawing is unreadable

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121648

Xisco Faulí  changed:

   What|Removed |Added

 CC||gan...@poczta.onet.pl,
   ||xiscofa...@libreoffice.org
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Keywords||bibisected, bisected,
   ||regression

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=cd7054b5e49f435349860d55bcff5a78d14a5f67

author  Bartosz Kosiorek 2018-11-02 15:53:05
+0100
committer   Bartosz Kosiorek 2018-11-05
19:28:22 +0100
commit  cd7054b5e49f435349860d55bcff5a78d14a5f67 (patch)
tree3e07a4cf2894c09dfbe239493486c9e7763bbedc
parent  485efed71807ecee5ce69fa556db98dbc78a97e5 (diff)
tdf#55058 tdf#106084 tdf#114738 EMF+ Add rotation support for String drawing

Bisected with: bibisect-linux64-6.2

Adding Cc: to Bartosz Kosiorek

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121648] New: FILEOPEN: EMF+: String Drawing is unreadable

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121648

Bug ID: 121648
   Summary: FILEOPEN: EMF+: String Drawing is unreadable
   Product: LibreOffice
   Version: 6.2.0.0.alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Created attachment 146930
  --> https://bugs.documentfoundation.org/attachment.cgi?id=146930=edit
Comparison MSO 2010 and LibreOffice 6.2 Master

Steps to reproduce:
1. Open attachment 78551 from bug 63991

-> text is unreadable

Reproduced in

Version: 6.2.0.0.beta1+
Build ID: a5bb6a0406d0018d1df279b925c80b392d9db277
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

[Bug found by office-interoperability-tools]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108235] Pivot table update on undo lags a step behind

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=108235

Markus Mohrhard  changed:

   What|Removed |Added

  Component|Chart   |Calc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106265] Scrolling font list with previews enabled makes LO crash ( steps in comment 36 )

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106265

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||1647

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121647] font list box preview certain malformed TTF fonts crash LO

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121647

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||71732
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||6265

--- Comment #2 from V Stuart Foote  ---
This was not a recurrence of the GDI issues of bug 106265, seems isolated to at
least these two fonts.

I'd be fine to NOB this, but wonder if we should be able to guard against
malformed fonts causing crash.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=71732
[Bug 71732] [META] Bugs related to text rendering, typography and font features
in LO
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=71732

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||121647


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121647
[Bug 121647] font list box preview certain malformed TTF fonts crash LO
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114836] FILEOPEN: Chart height is different than before

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114836

Markus Mohrhard  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |markus.mohrhard@googlemail.
   |desktop.org |com

--- Comment #6 from Markus Mohrhard  ---
The Shape UNO API implementation for the XMultiPropertySet::setPropertyValues
implementation was a bit problematic. Instead of only changing the properties
for the few properties that were actually set, the implementation was always
setting every single property again. This led to some slightly different calls
than by calls to XPropertySet::setPropertyValue.

I have a fix that actually changes the behavior of the
XMultiPropertySet::setPropertyValues to only set the changed properties.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121647] font list box preview certain malformed TTF fonts crash LO

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121647

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #1 from V Stuart Foote  ---
Created attachment 146929
  --> https://bugs.documentfoundation.org/attachment.cgi?id=146929=edit
old broken TTF fonts that crash font preview list box

uninstalling these fonts clears the issue

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121647] New: font list box preview certain malformed TTF fonts crash LO

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121647

Bug ID: 121647
   Summary: font list box preview certain malformed TTF fonts
crash LO
   Product: LibreOffice
   Version: 6.1.3.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: graphics stack
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: vstuart.fo...@utsa.edu

LO Crashes when scrolling the Font list box on the Formatting toolbar, or the
Font list box from the Character dialog.

Scrolling the font list box onto these fonts would consistently crash LO--with
either OpenGL or Default rendering enabled.

Two specific TTF fonts, installed as part of Corel Technical Suite 2017, seemed
to be the cause.

dfmw5.ttf, v1.0 --DFMincho-W5
dfkai71.ttf v2.71 -- DFKaiSho-SB

Both by DynaComWare/DynaLab, commonly installed with Corel suites.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121636] The last angle of poly polygon line is shown as rotation angle

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121636

Regina Henschel  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||rb.hensc...@t-online.de
 Status|UNCONFIRMED |NEW

--- Comment #1 from Regina Henschel  ---
That has been fixed in AOO with
https://bz.apache.org/ooo/show_bug.cgi?id=116244
https://cgit.freedesktop.org/libreoffice/core/commit/?h=aoo/trunk=0c170376f7e1896455f439237055e39df020e7ae

The fix went into LibreOffice with
http://opengrok.libreoffice.org/history/core/svx/source/svdraw/svdopath.cxx?n=25=125#20dee85b
https://cgit.freedesktop.org/libreoffice/core/commit/?id=20dee85b6390ef3edc5434889523cd9fd0137bae

and was removed from LibreOffice with
http://opengrok.libreoffice.org/history/core/svx/source/svdraw/svdopath.cxx?n=25=125#f47ed987
https://cgit.freedesktop.org/libreoffice/core/commit/?id=f47ed987388e4df58ba74b9aca574a7d1fba396a

I don't know, why it was removed. The commit message gives no reason.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-5-2+backports' - sc/source

2018-11-22 Thread Libreoffice Gerrit user 
 sc/source/core/data/drwlayer.cxx |  112 ---
 1 file changed, 82 insertions(+), 30 deletions(-)

New commits:
commit 02311dfa57f6a41fbb2dec85dcbe3f14cc37a4db
Author: Armin Le Grand 
AuthorDate: Thu Nov 22 13:18:30 2018 +0100
Commit: Thorsten Behrens 
CommitDate: Fri Nov 23 01:06:30 2018 +0100

tdf#116931 Fix scale when calc cells move indirectly

For the anchor mode 'To Cell (resize with cell)' there
were errors e.g. when the cell the object is in does
not scale but move. If that move went further than the
object is, wrong offsets emerged.
Also added full linear per-cell scale instead of only
scale (no translation through scale). Overhauled to
use liner transfomations, too.

Change-Id: Icff0fad168476c68ea10fd5830bf53bd7294b89f
Reviewed-on: https://gerrit.libreoffice.org/63803
Tested-by: Jenkins
Reviewed-by: Armin Le Grand 
Reviewed-on: https://gerrit.libreoffice.org/63831
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/sc/source/core/data/drwlayer.cxx b/sc/source/core/data/drwlayer.cxx
index e55c3d5bdbeb..8bccca95b0ec 100644
--- a/sc/source/core/data/drwlayer.cxx
+++ b/sc/source/core/data/drwlayer.cxx
@@ -670,11 +670,15 @@ void ScDrawLayer::ResizeLastRectFromAnchor( SdrObject* 
pObj, ScDrawObjData& rDat
 aPos.setX(TwipsToHmm(aPos.X()));
 aPos.setY(TwipsToHmm(aPos.Y()));
 aPos += lcl_calcAvailableDiff(*pDoc, nCol1, nRow1, nTab1, 
rData.maStartOffset);
+
+// this sets the needed changed position (translation)
 aRect.SetPos(aPos);
 
 if (bCanResize)
 {
-Rectangle aLastCellRect = rData.getLastCellRect();
+// all this stuff is additional stuff to evtl. not only translate the
+// range (Rectangle), but also check for and evtl. do corrections for 
it's size
+const Rectangle aLastCellRect(rData.getLastCellRect());
 
 // If the row was hidden before, or we don't have a valid cell rect, 
calculate the
 // new rect based on the end point.
@@ -694,57 +698,105 @@ void ScDrawLayer::ResizeLastRectFromAnchor( SdrObject* 
pObj, ScDrawObjData& rDat
 // We calculate based on the last cell rect to be able to scale 
the image
 // as much as the cell was scaled.
 // Still, we keep the image in its current cell (to keep start 
anchor == end anchor)
-Rectangle aCurrentCellRect = GetCellRect(*GetDocument(), 
rData.maStart, true);
-double fWidthFactor = 
static_cast(aCurrentCellRect.GetWidth())
-  / 
static_cast(aLastCellRect.GetWidth());
-double fHeightFactor = 
static_cast(aCurrentCellRect.GetHeight())
-   / 
static_cast(aLastCellRect.GetHeight());
+const Rectangle aCurrentCellRect(GetCellRect(*GetDocument(), 
rData.maStart, true));
+long nCurrentWidth(aCurrentCellRect.GetWidth());
+long nCurrentHeight(aCurrentCellRect.GetHeight());
+const long nLastWidth(aLastCellRect.GetWidth());
+const long nLastHeight(aLastCellRect.GetHeight());
+
+// tdf#116931 Avoid and correct nifty numerical problems with the 
integer
+// based and converted values (GetCellRect uses multiplies with 
HMM_PER_TWIPS)
+if(nCurrentWidth + 1 == nLastWidth || nCurrentWidth == nLastWidth 
+ 1)
+{
+nCurrentWidth = nLastWidth;
+}
 
-bool bIsGrowingLarger = aLastCellRect.GetWidth() * 
aLastCellRect.GetHeight()
-< aCurrentCellRect.GetWidth() * 
aCurrentCellRect.GetHeight();
+if(nCurrentHeight + 1 == nLastHeight || nCurrentHeight == 
nLastHeight + 1)
+{
+nCurrentHeight = nLastHeight;
+}
 
-if (pObj->shouldKeepAspectRatio())
+// get intial ScalingFactors
+double fWidthFactor(nCurrentWidth == nLastWidth || 0 == nLastWidth
+? 1.0
+: static_cast(nCurrentWidth) / 
static_cast(nLastWidth));
+double fHeightFactor(nCurrentHeight == nLastHeight || 0 == 
nLastHeight
+? 1.0
+: static_cast(nCurrentHeight) / 
static_cast(nLastHeight));
+
+// check if we grow or shrink - and at all
+const bool bIsGrowing(nCurrentWidth > nLastWidth || nCurrentHeight 
> nLastHeight);
+const bool bIsShrinking(nCurrentWidth < nLastWidth || 
nCurrentHeight < nLastHeight);
+const bool bIsSizeChanged(bIsGrowing || bIsShrinking);
+
+// handle AspectRatio, only needed if size does change
+if(bIsSizeChanged && pObj->shouldKeepAspectRatio())
 {
 Rectangle aRectIncludingOffset = aRect;
 aRectIncludingOffset.setWidth(aRect.GetWidth() + 
rData.maStartOffset.X());

[Libreoffice-bugs] [Bug 121609] The 'Position and Size' tab of the sidebar is not displaying correctly the size of shapes.

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121609

agm2...@outlook.com changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121609] The 'Position and Size' tab of the sidebar is not displaying correctly the size of shapes.

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121609

agm2...@outlook.com changed:

   What|Removed |Added

 CC||agm2...@outlook.com

--- Comment #5 from agm2...@outlook.com ---
Created attachment 146928
  --> https://bugs.documentfoundation.org/attachment.cgi?id=146928=edit
Page Size 16:9 [Draw]

The attached image is from Draw, but the same is true for Impress.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Hunspell probably breaks build on macOS

2018-11-22 Thread Thorsten Wagner 
Changing code is not necessary, but mentioning it as a build prerequisite 
within documentation would save much time.

On 14. Oct 2018, at 13:48, Michael Stahl  wrote:

On 13/10/2018 23:51, Thorsten Wagner wrote:
> Issue has been fixed. Reason was automake 1.16. After reverting to
> automake 1.14 build succeded without errors. Hunspell 1.6.2 do not
> cause any errors now. Many thanks for looking at the issue anyway.

if automake 1.16 breaks the build, do we need to check for this version
in LO's configure?

why does hunspell run "autoreconf" anyway, isn't this something we want
to avoid, for exactly this reason?

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 121646] Animating Slide Transitions Rendering Issues with LibreOffice 6.2 Beta1

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121646

ammine007  changed:

   What|Removed |Added

Summary|Animating Slide Transitions |Animating Slide Transitions
   |Rendering Issues|Rendering Issues with
   ||LibreOffice 6.2 Beta1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121646] New: Animating Slide Transitions Rendering Issues

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121646

Bug ID: 121646
   Summary: Animating Slide Transitions Rendering Issues
   Product: LibreOffice
   Version: 6.2.0.0.beta1+
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ammine...@gmail.com

Created attachment 146927
  --> https://bugs.documentfoundation.org/attachment.cgi?id=146927=edit
Impress Animatiing Slide Transitions issues

I've created an Album Photo with Captions on LibreOffice 6.2 Beta1; And the
porblem seen, is that almost all of slide transitions have got issues while
played. But Play correctly in LibreOffice 6.1.3

You will find attached the odp Impress problematic file, and here is a video
link of the issue: 
**
** https://youtu.be/TwvQPRBJqPE
**
Problem of Animating Slide Transitions with LibreOffice Impress 6.2 Beta1
release. Most of the Impress Slide Transitions are not played correctly, one
can clearly see residues from the past slide.

1 -- When screen recording with a software, the slides are animated almost
without any noticed problem in LibreOffice 6.2 beta1.

2-- When recording my laptop screen with my smartphone, the issues are clear
and annoying when played with LibreOffice 6.2 beta1.

3-- If there is an issue animating a Slide transition, when starting from the
current slide, the animation is played without problems, in LibreOffice Impress
6.2 Beta1.

4- Using LibreOffice 6.1.3, animating slide transitions goes smooth,and almost
without any noticeable issue, in both cases using a screencast software or
recording via smartphone camera.


Here are the animations that are problematic:

Cube
Tiles
Fall
Turn Down
Iris
Turn Around
Static
3D Venetian
Rochade
Ripple
Vortex
Fine Dissolve
News FLash
HoneyComb
Glitter

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Compiler baselines

2018-11-22 Thread Thorsten Wagner 
Due to other changes building master is no longer possible with macOS 10.11. 
SDK 10.13 is required now (maybe SDK 10.12 but I’m unable to verify this).

On 22. Nov 2018, at 09:50, Tor Lillqvist  wrote:

Slightly related, could we bump the minimum macOS version requirement? We have 
had it at 10.9 for quite some time now already. IMHO we should bump it once a 
year, so that the maximum age of macOS we support stays the same. (Assuming 
macOS keeps coming out with a new 10.x release once a year.)
 
Bumping it to 10.10 would for instance allow us to with a clean conscience get 
rid of the dubious macOS-specific code that perhaps tries to make buttons 
"pulsate", as that look has not been in vogue since pre-10.10 days. (See 
tdf#114839 and look for AquaBlinker in vcl.)

Perhaps bump to 10.11 even?

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 121645] New: Storing a document in LO 6.3.0.0.alpha0

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121645

Bug ID: 121645
   Summary: Storing a document in LO 6.3.0.0.alpha0
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: hel...@wolff-dattenberg.net

Description:
When I want store a document; always the storing-dialog appears.

Steps to Reproduce:
1. When I want store a document; always the storing-dialog appears.

Actual Results:
Always the storing-dialog appears.

Expected Results:
Always the storing-dialog appears.


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121638] Different angle shown between sidebar & size and position dialog

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121638

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||rb.hensc...@t-online.de,
   ||tietze.he...@gmail.com,
   ||xiscofa...@libreoffice.org
 Ever confirmed|0   |1
Version|6.3.0.0.alpha0+ Master  |5.3 all versions

--- Comment #1 from Xisco Faulí  ---
Reproduced in

Version: 6.2.0.0.beta1+
Build ID: a5bb6a0406d0018d1df279b925c80b392d9db277
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

and

Version: 5.3.0.0.alpha1+
Build ID: 4136757b4e51c4e6f7cb4132c95538a7f831ef2c
CPU Threads: 4; OS Version: Linux 4.15; UI Render: default; VCL: gtk3; Layout
Engine: new; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

it seems it only reproducible when the line is drawn from top to bottom, no the
other way around

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sw/inc sw/source

2018-11-22 Thread Libreoffice Gerrit user 
 sw/inc/viewsh.hxx   |3 +++
 sw/source/core/doc/DocumentTimerManager.cxx |   10 +++---
 sw/source/core/frmedt/feshview.cxx  |4 ++--
 sw/source/core/view/viewsh.cxx  |3 +--
 sw/source/core/view/vnew.cxx|5 +
 sw/source/uibase/uiview/view2.cxx   |2 +-
 6 files changed, 19 insertions(+), 8 deletions(-)

New commits:
commit 0d3d476b6af2acfd7dc334a80b94825e59cc8698
Author: Michael Meeks 
AuthorDate: Thu Nov 22 12:48:17 2018 +
Commit: Michael Meeks 
CommitDate: Fri Nov 23 00:16:21 2018 +0100

Avoid busy-loop related to layout when dragging objects.

Change-Id: I4fb437356bc154cfefc5958592ae5888e24d59c3
Reviewed-on: https://gerrit.libreoffice.org/63804
Tested-by: Jenkins
Reviewed-by: Michael Meeks 
(cherry picked from commit f19dfaf817556ba28d68c000f3561a2752635727)
Reviewed-on: https://gerrit.libreoffice.org/63830

diff --git a/sw/inc/viewsh.hxx b/sw/inc/viewsh.hxx
index bf09c8118590..66382ecc216c 100644
--- a/sw/inc/viewsh.hxx
+++ b/sw/inc/viewsh.hxx
@@ -467,6 +467,9 @@ public:
 bool HasDrawView() const;
 void MakeDrawView();
 
+// Are we dragging draw shapes around.
+bool HasDrawViewDrag() const;
+
 // DrawView may be used at UI.
   SdrView *GetDrawView();
 const SdrView *GetDrawView() const { return 
const_cast(this)->GetDrawView(); }
diff --git a/sw/source/core/doc/DocumentTimerManager.cxx 
b/sw/source/core/doc/DocumentTimerManager.cxx
index 7bd2e505a3a4..5d8c425dfd46 100644
--- a/sw/source/core/doc/DocumentTimerManager.cxx
+++ b/sw/source/core/doc/DocumentTimerManager.cxx
@@ -108,10 +108,14 @@ DocumentTimerManager::IdleJob 
DocumentTimerManager::GetNextIdleJob() const
 return IdleJob::Grammar;
 }
 
-for ( auto pLayout : m_rDoc.GetAllLayouts() )
+// If we're dragging re-layout doesn't occur so avoid a busy loop.
+if (!pShell->HasDrawViewDrag())
 {
-if( pLayout->IsIdleFormat() )
-return IdleJob::Layout;
+for ( auto pLayout : m_rDoc.GetAllLayouts() )
+{
+if( pLayout->IsIdleFormat() )
+return IdleJob::Layout;
+}
 }
 
 SwFieldUpdateFlags nFieldUpdFlag = 
m_rDoc.GetDocumentSettingManager().getFieldUpdateFlags(true);
diff --git a/sw/source/core/frmedt/feshview.cxx 
b/sw/source/core/frmedt/feshview.cxx
index 1d00cd578e29..ae1259ce55ca 100644
--- a/sw/source/core/frmedt/feshview.cxx
+++ b/sw/source/core/frmedt/feshview.cxx
@@ -720,7 +720,7 @@ void SwFEShell::BeginDrag( const Point* pPt, bool bIsShift)
 void SwFEShell::Drag( const Point *pPt, bool )
 {
 OSL_ENSURE( Imp()->HasDrawView(), "Drag without DrawView?" );
-if ( Imp()->GetDrawView()->IsDragObj() )
+if ( HasDrawViewDrag() )
 {
 ScrollTo( *pPt );
 Imp()->GetDrawView()->MovDragObj( *pPt );
@@ -772,7 +772,7 @@ void SwFEShell::EndDrag()
 void SwFEShell::BreakDrag()
 {
 OSL_ENSURE( Imp()->HasDrawView(), "BreakDrag without DrawView?" );
-if ( Imp()->GetDrawView()->IsDragObj() )
+if( HasDrawViewDrag() )
 Imp()->GetDrawView()->BrkDragObj();
 SetChainMarker();
 }
diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx
index 273692a86aa7..77ccf51f2cd4 100644
--- a/sw/source/core/view/viewsh.cxx
+++ b/sw/source/core/view/viewsh.cxx
@@ -698,8 +698,7 @@ bool SwViewShell::HasCharts() const
 
 void SwViewShell::LayoutIdle()
 {
-if( !mpOpt->IsIdle() || !GetWin() ||
-( Imp()->HasDrawView() && Imp()->GetDrawView()->IsDragObj() ) )
+if( !mpOpt->IsIdle() || !GetWin() || HasDrawViewDrag() )
 return;
 
 //No idle when printing is going on.
diff --git a/sw/source/core/view/vnew.cxx b/sw/source/core/view/vnew.cxx
index 2dd39f081668..5b386da0da16 100644
--- a/sw/source/core/view/vnew.cxx
+++ b/sw/source/core/view/vnew.cxx
@@ -367,6 +367,11 @@ void SwViewShell::MakeDrawView()
 Imp()->MakeDrawView( );
 }
 
+bool SwViewShell::HasDrawViewDrag() const
+{
+return Imp()->HasDrawView() && Imp()->GetDrawView()->IsDragObj();
+}
+
 SdrView* SwViewShell::GetDrawView()
 {
 return Imp()->GetDrawView();
diff --git a/sw/source/uibase/uiview/view2.cxx 
b/sw/source/uibase/uiview/view2.cxx
index 534beec5cce6..f4222bf07eb4 100644
--- a/sw/source/uibase/uiview/view2.cxx
+++ b/sw/source/uibase/uiview/view2.cxx
@@ -804,7 +804,7 @@ void SwView::Execute(SfxRequest )
 break;
 case FN_ESCAPE:
 {
-if ( m_pWrtShell->HasDrawView() && 
m_pWrtShell->GetDrawView()->IsDragObj() )
+if ( m_pWrtShell->HasDrawViewDrag() )
 {
 m_pWrtShell->BreakDrag();
 m_pWrtShell->EnterSelFrameMode();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 121643] Pressing on the "Reset" button when the focus is on the "Type" drop-down field causes LibreOffice to crash, on Properties - Custom Properties

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121643

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
 OS|Windows (All)   |All
 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED
Version|6.1.3.2 release |Inherited From OOo
   See Also||https://crashreport.libreof
   ||fice.org/stats/signature/Li
   ||stBox::GetSelectedEntryPos(
   ||long)
Crash report or||["ListBox::GetSelectedEntry
crash signature||Pos(long)"]

--- Comment #1 from Xisco Faulí  ---
Reproduced in

LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

Since the crash signature is the same as in bug 121644, I believe the root
cause is the same.
Anyway, thank you very much for reporting it!!

*** This bug has been marked as a duplicate of bug 121644 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121644] Pressing on the "Reset" button when the writing focus is on the "Value" input field of a property causes LibreOffice to crash on Properties - Custom Properties

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121644

--- Comment #4 from Xisco Faulí  ---
*** Bug 121643 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/PythonTest_sw_python.mk sw/qa

2018-11-22 Thread Libreoffice Gerrit user 
 sw/PythonTest_sw_python.mk |1 
 sw/qa/python/testdocuments/xtextcursor.odt |binary
 sw/qa/python/xtextcursor.py|  107 +
 3 files changed, 108 insertions(+)

New commits:
commit 19923ea1d1608044e101b1875b47f6d4fbccf2d7
Author: Vasily Melenchuk 
AuthorDate: Fri Sep 28 13:53:46 2018 +0300
Commit: Thorsten Behrens 
CommitDate: Fri Nov 23 00:09:57 2018 +0100

sw: new unit test for XTextCursor

Change-Id: I5b70f6dc8f7399be78daefa95d6d98687d99ec18
Reviewed-on: https://gerrit.libreoffice.org/61098
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/sw/PythonTest_sw_python.mk b/sw/PythonTest_sw_python.mk
index ad479f527504..4f97724d835c 100644
--- a/sw/PythonTest_sw_python.mk
+++ b/sw/PythonTest_sw_python.mk
@@ -42,6 +42,7 @@ $(eval $(call 
gb_PythonTest_add_modules,sw_python,$(SRCDIR)/sw/qa/python,\
xtextcontent \
xtextrange \
xtext \
+   xtextcursor \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/sw/qa/python/testdocuments/xtextcursor.odt 
b/sw/qa/python/testdocuments/xtextcursor.odt
new file mode 100644
index ..1fdcfb9b77f9
Binary files /dev/null and b/sw/qa/python/testdocuments/xtextcursor.odt differ
diff --git a/sw/qa/python/xtextcursor.py b/sw/qa/python/xtextcursor.py
new file mode 100644
index ..30d0518690a7
--- /dev/null
+++ b/sw/qa/python/xtextcursor.py
@@ -0,0 +1,107 @@
+#! /usr/bin/env python
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+import unittest
+import unohelper
+from org.libreoffice.unotest import UnoInProcess
+import uno
+import time
+
+
+class TestXTextCursor(unittest.TestCase):
+
+@classmethod
+def setUpClass(cls):
+cls._uno = UnoInProcess()
+cls._uno.setUp()
+cls._uno.openDocFromTDOC("xtextcursor.odt")
+
+@classmethod
+def tearDownClass(cls):
+cls._uno.tearDown()
+
+def createTextCursorInFrame(self, frameName):
+xTextFrames = self._uno.getDoc().getTextFrames()
+self.assertIsNotNone(xTextFrames)
+xTextFrame = xTextFrames[frameName]
+self.assertIsNotNone(xTextFrame)
+xCursor = xTextFrame.getText().createTextCursor()
+self.assertIsNotNone(xCursor)
+return xCursor
+
+def test_cursorMoveInText(self):
+# Create cursor in frame with simple text (to avoid moving beyond)
+xCursor = self.createTextCursorInFrame("FrameSimple")
+
+xCursor.collapseToStart()
+self.assertTrue(xCursor.isCollapsed())
+self.assertTrue(xCursor.goRight(1, True))
+self.assertFalse(xCursor.isCollapsed())
+# Try to move right 10 characters, but we really can just 3, so 
partial move
+self.assertFalse(xCursor.goRight(10, True))
+self.assertFalse(xCursor.isCollapsed())
+# Ensure that all line text is selected
+self.assertEqual(xCursor.getString(), "1234")
+
+self.assertFalse(xCursor.goRight(-10, True))
+self.assertEqual(xCursor.getString(), "1234")
+
+xCursor.collapseToEnd()
+self.assertTrue(xCursor.isCollapsed())
+self.assertTrue(xCursor.goLeft(2, True))
+self.assertFalse(xCursor.isCollapsed())
+self.assertEqual(xCursor.getString(), "34")
+
+# Move to start without selection
+self.assertTrue(xCursor.goLeft(2, False))
+self.assertEqual(xCursor.getString(), "")
+
+self.assertTrue(xCursor.isCollapsed())
+
+# Select all text
+xCursor.gotoStart(False)
+self.assertTrue(xCursor.isCollapsed())
+xCursor.gotoEnd(True)
+self.assertFalse(xCursor.isCollapsed())
+self.assertEqual(xCursor.getString(), "1234")
+
+# Select all text from behind
+xCursor.gotoEnd(False)
+self.assertTrue(xCursor.isCollapsed())
+xCursor.gotoStart(True)
+self.assertFalse(xCursor.isCollapsed())
+self.assertEqual(xCursor.getString(), "1234")
+
+# Select all text, alternative way via gotoRange
+xCursor2 = self.createTextCursorInFrame("FrameSimple")
+xCursor2.gotoEnd(False)
+xCursor2.gotoStart(True)
+xCursor.gotoEnd(False)
+self.assertTrue(xCursor.isCollapsed())
+xCursor.gotoRange(xCursor2, True)
+self.assertFalse(xCursor.isCollapsed())
+self.assertEqual(xCursor.getString(), "1234")
+
+def test_cursorMoveInTable(self):
+# Create cursor in frame with table
+xCursor = self.createTextCursorInFrame("FrameTable")
+
+# Nothing is selected
+xCursor.collapseToEnd()
+self.assertTrue(xCursor.isCollapsed())
+self.assertEqual(xCursor.getString(), "")

[Libreoffice-commits] core.git: sw/PythonTest_sw_python.mk sw/qa

2018-11-22 Thread Libreoffice Gerrit user 
 sw/PythonTest_sw_python.mk |1 
 sw/qa/python/xtext.py  |   89 +
 2 files changed, 90 insertions(+)

New commits:
commit ba85d48c0384610829f6b0cfddd944da3cffeed7
Author: Vasily Melenchuk 
AuthorDate: Wed Oct 3 09:39:50 2018 +0300
Commit: Thorsten Behrens 
CommitDate: Fri Nov 23 00:09:17 2018 +0100

sw: new testcase for XText

Change-Id: I8c4b89e1e0851e808daa0902f970f967c6d057a9
Reviewed-on: https://gerrit.libreoffice.org/61348
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/sw/PythonTest_sw_python.mk b/sw/PythonTest_sw_python.mk
index cd73e90f199a..ad479f527504 100644
--- a/sw/PythonTest_sw_python.mk
+++ b/sw/PythonTest_sw_python.mk
@@ -41,6 +41,7 @@ $(eval $(call 
gb_PythonTest_add_modules,sw_python,$(SRCDIR)/sw/qa/python,\
xcontrolshape \
xtextcontent \
xtextrange \
+   xtext \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/sw/qa/python/xtext.py b/sw/qa/python/xtext.py
new file mode 100644
index ..5ee5986a5454
--- /dev/null
+++ b/sw/qa/python/xtext.py
@@ -0,0 +1,89 @@
+#! /usr/bin/env python
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+import unittest
+import unohelper
+from org.libreoffice.unotest import UnoInProcess
+from com.sun.star.lang import IllegalArgumentException
+from com.sun.star.container import NoSuchElementException
+import uno
+import time
+
+
+class TestXText(unittest.TestCase):
+
+@classmethod
+def setUpClass(cls):
+cls._uno = UnoInProcess()
+cls._uno.setUp()
+cls._uno.openEmptyWriterDoc()
+
+@classmethod
+def tearDownClass(cls):
+cls._uno.tearDown()
+
+def test_insertAndRemoveAnnotations(self):
+xText = self._uno.getDoc().getText()
+self.assertIsNotNone(xText)
+
+# Insert annotation field
+xAnnotation = self.createAnnotation("John Doe")
+xCursor = xText.createTextCursor()
+xText.insertTextContent(xCursor, xAnnotation, False)
+
+# And the same once again, actually not inserted
+xText.insertTextContent(xCursor, xAnnotation, False)
+
+# Exception if we try to replace object by itself
+with self.assertRaises(IllegalArgumentException):
+xText.insertTextContent(xCursor, xAnnotation, True)
+# We expect just one annotation actually
+self.checkAnnotations(["John Doe"])
+
+xAnnotation2 = self.createAnnotation("Richard Roe")
+xText.insertTextContent(xCursor, xAnnotation2, True)
+self.checkAnnotations(["Richard Roe"])
+
+xAnnotation3 = self.createAnnotation("Jane Roe")
+xText.insertTextContent(xCursor, xAnnotation3, True)
+self.checkAnnotations(["Jane Roe", "Richard Roe"])
+
+# Remove annotations
+xText.removeTextContent(xAnnotation3)
+self.checkAnnotations(["Richard Roe"])
+xText.removeTextContent(xAnnotation2)
+self.checkAnnotations([])
+
+# Remove _already removed_ ones again
+# TODO: unexpected behaviour, it should throw an exception,
+# but let's nail down current behaviour
+xText.removeTextContent(xAnnotation2)
+xText.removeTextContent(xAnnotation)
+
+self.checkAnnotations([])
+
+def createAnnotation(self, author):
+xAnnotation = 
self._uno.getDoc().createInstance("com.sun.star.text.TextField.Annotation")
+self.assertIsNotNone(xAnnotation)
+xAnnotation.setPropertyValue("Author", author)
+return xAnnotation
+
+def checkAnnotations(self, authors):
+xFieldsEnum = self._uno.getDoc().getTextFields().createEnumeration()
+annotationsFound = 0
+for xField, author in zip(xFieldsEnum, authors):
+
self.assertTrue(xField.supportsService("com.sun.star.text.TextField.Annotation"))
+self.assertEqual(xField.getPropertyValue("Author"), author)
+annotationsFound += 1
+self.assertEqual(annotationsFound, len(authors))
+
+if __name__ == '__main__':
+unittest.main()
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/PythonTest_sw_python.mk sw/qa

2018-11-22 Thread Libreoffice Gerrit user 
 sw/PythonTest_sw_python.mk|1 
 sw/qa/python/testdocuments/xtextrange.odt |binary
 sw/qa/python/xtextrange.py|   97 ++
 3 files changed, 98 insertions(+)

New commits:
commit 284dd58e326e61a5d84bde367e1e4873dd738c76
Author: Vasily Melenchuk 
AuthorDate: Mon Oct 1 09:43:59 2018 +0300
Commit: Thorsten Behrens 
CommitDate: Fri Nov 23 00:08:38 2018 +0100

sw: new testcase for XTextRange

Change-Id: Ia476f4f001851d0f8b51fca62b5c041b1d866cc3
Reviewed-on: https://gerrit.libreoffice.org/61174
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/sw/PythonTest_sw_python.mk b/sw/PythonTest_sw_python.mk
index 0dc15f929de0..cd73e90f199a 100644
--- a/sw/PythonTest_sw_python.mk
+++ b/sw/PythonTest_sw_python.mk
@@ -40,6 +40,7 @@ $(eval $(call 
gb_PythonTest_add_modules,sw_python,$(SRCDIR)/sw/qa/python,\
xtextfieldssupplier \
xcontrolshape \
xtextcontent \
+   xtextrange \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/sw/qa/python/testdocuments/xtextrange.odt 
b/sw/qa/python/testdocuments/xtextrange.odt
new file mode 100644
index ..5881ea44a447
Binary files /dev/null and b/sw/qa/python/testdocuments/xtextrange.odt differ
diff --git a/sw/qa/python/xtextrange.py b/sw/qa/python/xtextrange.py
new file mode 100644
index ..e6875fadc097
--- /dev/null
+++ b/sw/qa/python/xtextrange.py
@@ -0,0 +1,97 @@
+#! /usr/bin/env python
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+import unittest
+import unohelper
+from org.libreoffice.unotest import UnoInProcess
+import uno
+import time
+
+
+class TestXTextRange(unittest.TestCase):
+
+@classmethod
+def setUpClass(cls):
+cls._uno = UnoInProcess()
+cls._uno.setUp()
+cls._uno.openDocFromTDOC("xtextrange.odt")
+
+@classmethod
+def tearDownClass(cls):
+cls._uno.tearDown()
+
+def test_textRangesInPlainText(self):
+xCursor = self._uno.getDoc().getText().createTextCursor()
+xCursor.goRight(10, True)
+xTextRange = xCursor
+self.assertEqual(xTextRange.getString(), "0123456789")
+
+# getStart
+xTextRangeStart = xTextRange.getStart()
+self.assertIsNotNone(xTextRangeStart)
+self.assertEqual(xTextRangeStart.getString(), "")
+xTextRangeStart.setString("before")
+self.assertEqual(xTextRangeStart.getString(), "before")
+
+# Owerwrite strings
+xTextRangeStart.setString("beforebeforebeforebefore")
+xTextRangeStart.setString("before2")
+xTextRangeStart.setString("before3")
+xTextRangeStart.setString("before")
+self.assertEqual(xTextRangeStart.getString(), "before")
+xCursor = self._uno.getDoc().getText().createTextCursor()
+xCursor.goRight(16, True)
+self.assertEqual(xCursor.getString(), "before0123456789")
+
+# getEnd
+xTextRangeEnd = xTextRange.getEnd()
+self.assertIsNotNone(xTextRangeEnd)
+self.assertEqual(xTextRangeEnd.getString(), "")
+xTextRangeEnd.setString("after")
+self.assertEqual(xTextRangeEnd.getString(), "after")
+
+# getText
+xText = xTextRange.getText()
+self.assertIsNotNone(xText)
+
+# Final check of what we have inserted
+xCursor = self._uno.getDoc().getText().createTextCursor()
+xCursor.goRight(21, True)
+self.assertEqual(xCursor.getString(), "before0123456789after")
+
+def test_textRangesInTable(self):
+xTextTables = self._uno.getDoc().getTextTables()
+self.assertIsNotNone(xTextTables)
+xTextTable = xTextTables[0]
+self.assertIsNotNone(xTextTable)
+
+xTextRange = xTextTable.getCellByName("A1")
+self.assertIsNotNone(xTextRange)
+self.assertEqual(xTextRange.getString(), "C1")
+
+xTextRangeStart = xTextRange.getStart()
+self.assertIsNotNone(xTextRangeStart)
+self.assertEqual(xTextRangeStart.getString(), "")
+xTextRangeStart.setString("before")
+self.assertEqual(xTextRangeStart.getString(), "before")
+
+xTextRangeEnd = xTextRange.getEnd()
+self.assertIsNotNone(xTextRangeEnd)
+self.assertEqual(xTextRangeEnd.getString(), "")
+xTextRangeEnd.setString("after")
+self.assertEqual(xTextRangeEnd.getString(), "after")
+
+# Ensure that what we inserted is in cell
+xTextRange2 = xTextTable.getCellByName("A1")
+self.assertEqual(xTextRange2.getString(), "beforeC1after")
+
+if __name__ == '__main__':
+unittest.main()
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:

[Libreoffice-commits] core.git: sw/qa

2018-11-22 Thread Libreoffice Gerrit user 
 sw/qa/python/check_xautotextcontainer.py |  125 ---
 1 file changed, 34 insertions(+), 91 deletions(-)

New commits:
commit 28033ada111c1f08f1d5305e709803e84ab6ddae
Author: Thorsten Behrens 
AuthorDate: Thu Nov 22 12:40:47 2018 +0100
Commit: Thorsten Behrens 
CommitDate: Fri Nov 23 00:08:02 2018 +0100

sw: fixup XAutoTextContainer test

This is a follow-up to 4967d498c486800b72ba34192c82c232bc0685bd and
avoids to have setup errors making these tests silently pass.

Also cleanup code a bit & share common init sequence.

Change-Id: I043447a28f5e2c9f416aa906135030c07b2cacc8
Reviewed-on: https://gerrit.libreoffice.org/63800
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/sw/qa/python/check_xautotextcontainer.py 
b/sw/qa/python/check_xautotextcontainer.py
index 20f9c018d24f..c460c3d0eaa6 100644
--- a/sw/qa/python/check_xautotextcontainer.py
+++ b/sw/qa/python/check_xautotextcontainer.py
@@ -19,78 +19,59 @@ class XAutoTextContainer(unittest.TestCase):
 GROUP_POSTFIX = '*1'
 
 @classmethod
-def setUpClass(self):
-self._uno = UnoInProcess()
-self._uno.setUp()
-self._uno.openEmptyWriterDoc()
+def setUpClass(cls):
+cls._uno = UnoInProcess()
+cls._uno.setUp()
+cls._uno.openEmptyWriterDoc()
+
+def setUp(self):
+xServiceManager = self._uno.xContext.ServiceManager
+self.xAutoTextContainer = xServiceManager.createInstance(
+"com.sun.star.text.AutoTextContainer")
 
 @classmethod
-def tearDownClass(self):
-self._uno.tearDown()
+def tearDownClass(cls):
+cls._uno.tearDown()
 
 def test_insertNewByName(self):
-# initialization
-xAutoTextContainer = self.createAutoTextContainer()
-if xAutoTextContainer is None:
-return
-
-# perform unit test
 # group name must contain a-z, A-z, 0-9, '_', ' ' only
 xNames = ['Name', 'TEST', 'Name2', '_With_underscore_', 'with space', 
'123456']
 for xName in xNames:
-xAutoTextContainer.insertNewByName(xName+self.GROUP_POSTFIX)
-xAutoTextContainer.removeByName(xName+self.GROUP_POSTFIX)
+self.xAutoTextContainer.insertNewByName(xName+self.GROUP_POSTFIX)
+self.xAutoTextContainer.removeByName(xName+self.GROUP_POSTFIX)
 
 def test_insertNewByName_Spaces(self):
-# initialization
-xAutoTextContainer = self.createAutoTextContainer()
-if xAutoTextContainer is None:
-return
-
-# perform unit test
 # add
 xName = '  spaces  '
-xAutoTextContainer.insertNewByName(xName+self.GROUP_POSTFIX)
+self.xAutoTextContainer.insertNewByName(xName+self.GROUP_POSTFIX)
 
 # try to remove
 with self.assertRaises(NoSuchElementException):
-xAutoTextContainer.removeByName(xName+self.GROUP_POSTFIX)
+self.xAutoTextContainer.removeByName(xName+self.GROUP_POSTFIX)
 
 # remove trimmed
-xAutoTextContainer.removeByName('spaces'+self.GROUP_POSTFIX)
+self.xAutoTextContainer.removeByName('spaces'+self.GROUP_POSTFIX)
 
 def test_insertNewByName_Several(self):
-# initialization
-xAutoTextContainer = self.createAutoTextContainer()
-if xAutoTextContainer is None:
-return
-
-# perform unit test
-xAutoTextGroup1 = xAutoTextContainer.insertNewByName(
+xAutoTextGroup1 = self.xAutoTextContainer.insertNewByName(
 "atc_name1"+self.GROUP_POSTFIX)
-xAutoTextGroup2 = xAutoTextContainer.insertNewByName(
+xAutoTextGroup2 = self.xAutoTextContainer.insertNewByName(
 "atc_name2"+self.GROUP_POSTFIX)
-xAutoTextGroup3 = xAutoTextContainer.insertNewByName(
+xAutoTextGroup3 = self.xAutoTextContainer.insertNewByName(
 "atc_name3"+self.GROUP_POSTFIX)
 
 self.assertEqual("atc_name1"+self.GROUP_POSTFIX, 
xAutoTextGroup1.getName())
 self.assertEqual("atc_name2"+self.GROUP_POSTFIX, 
xAutoTextGroup2.getName())
 self.assertEqual("atc_name3"+self.GROUP_POSTFIX, 
xAutoTextGroup3.getName())
 
-xAutoTextContainer.removeByName("atc_name1"+self.GROUP_POSTFIX)
-xAutoTextContainer.removeByName("atc_name2"+self.GROUP_POSTFIX)
-xAutoTextContainer.removeByName("atc_name3"+self.GROUP_POSTFIX)
+self.xAutoTextContainer.removeByName("atc_name1"+self.GROUP_POSTFIX)
+self.xAutoTextContainer.removeByName("atc_name2"+self.GROUP_POSTFIX)
+self.xAutoTextContainer.removeByName("atc_name3"+self.GROUP_POSTFIX)
 
 def test_insertNewByName_DifferentCase(self):
-# initialization
-xAutoTextContainer = self.createAutoTextContainer()
-if xAutoTextContainer is None:
-return
-
-# perform unit test
-xAutoTextGroup1 =

[Libreoffice-commits] core.git: sw/PythonTest_sw_python.mk sw/qa

2018-11-22 Thread Libreoffice Gerrit user 
 sw/PythonTest_sw_python.mk   |1 
 sw/qa/python/check_xautotextgroup.py |  150 +++
 2 files changed, 151 insertions(+)

New commits:
commit c690fb0fa0f1e1e9ebdc782321b0b166f61e76f0
Author: Serge Krot 
AuthorDate: Tue Oct 2 18:59:29 2018 +0200
Commit: Thorsten Behrens 
CommitDate: Fri Nov 23 00:07:39 2018 +0100

sw: new unit test for XAutoTextGroup

Change-Id: I3928248b73025f304c0e1ef7b5f86349df9a3c8d
Reviewed-on: https://gerrit.libreoffice.org/61267
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/sw/PythonTest_sw_python.mk b/sw/PythonTest_sw_python.mk
index 836c6e06378a..0dc15f929de0 100644
--- a/sw/PythonTest_sw_python.mk
+++ b/sw/PythonTest_sw_python.mk
@@ -27,6 +27,7 @@ $(eval $(call 
gb_PythonTest_add_modules,sw_python,$(SRCDIR)/sw/qa/python,\
check_xtexttable \
check_table \
check_xautotextcontainer \
+   check_xautotextgroup \
check_xmodifiable2 \
check_xnamedgraph \
check_xrefreshable \
diff --git a/sw/qa/python/check_xautotextgroup.py 
b/sw/qa/python/check_xautotextgroup.py
new file mode 100644
index ..a41987103e6b
--- /dev/null
+++ b/sw/qa/python/check_xautotextgroup.py
@@ -0,0 +1,150 @@
+#! /usr/bin/env python
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+import unittest
+from org.libreoffice.unotest import UnoInProcess
+from com.sun.star.container import ElementExistException
+from com.sun.star.container import NoSuchElementException
+from com.sun.star.uno import RuntimeException
+
+
+class XAutoTextGroup(unittest.TestCase):
+# 0 indicates the path of the Office Basis layer
+# 1 indicates the path of the user directory
+GROUP_NAME = 'atg_name1*1'
+
+@classmethod
+def setUpClass(cls):
+cls._uno = UnoInProcess()
+cls._uno.setUp()
+cls._uno.openEmptyWriterDoc()
+
+def setUp(self):
+self.xAutoTextContainer = self.createAutoTextContainer()
+self.xAutoTextGroup = self.insertNewGroup(self.xAutoTextContainer)
+
+self.xText = self._uno.getDoc().getText()
+self.xCursor = self.xText.createTextCursor()
+self.xRange = self.xCursor.getStart()
+
+def tearDown(self):
+self.xAutoTextContainer.removeByName(self.GROUP_NAME)
+
+@classmethod
+def tearDownClass(cls):
+cls._uno.tearDown()
+
+def test_XAutoTextGroup(self):
+xName = 'Name'
+xTitle = 'Title'
+
+titlesBefore = self.xAutoTextGroup.getTitles()
+
+self.xAutoTextGroup.insertNewByName(xName, xTitle, self.xRange)
+self.assertNotEqual(titlesBefore, self.xAutoTextGroup.getTitles())
+
+self.xAutoTextGroup.removeByName(xName)
+self.assertEqual(titlesBefore, self.xAutoTextGroup.getTitles())
+
+def test_XAutoTextGroup_NoTitle(self):
+xName = 'Name'
+
+titlesBefore = self.xAutoTextGroup.getTitles()
+
+self.xAutoTextGroup.insertNewByName(xName, xName, self.xRange)
+self.assertNotEqual(titlesBefore, self.xAutoTextGroup.getTitles())
+
+self.xAutoTextGroup.removeByName(xName)
+self.assertEqual(titlesBefore, self.xAutoTextGroup.getTitles())
+
+def test_insertNewByName_Twice(self):
+xName = 'Name'
+xTitle = 'Title'
+
+self.xAutoTextGroup.insertNewByName(xName, xTitle, self.xRange)
+
+with self.assertRaises(ElementExistException):
+self.xAutoTextGroup.insertNewByName(xName, xTitle, self.xRange)
+
+self.xAutoTextGroup.removeByName(xName)
+
+def test_renameByName(self):
+xName = 'Name'
+xTitle = 'Title'
+
+xNewName = 'New Name'
+xNewTitle = 'New Title'
+
+self.xAutoTextGroup.insertNewByName(xName, xTitle, self.xRange)
+self.xAutoTextGroup.renameByName(xName, xNewName, xNewTitle)
+
+titlesBefore = self.xAutoTextGroup.getTitles()
+with self.assertRaises(NoSuchElementException):
+self.xAutoTextGroup.removeByName(xName)
+titlesAfter = self.xAutoTextGroup.getTitles()
+self.assertEqual(titlesBefore, titlesAfter)
+
+self.xAutoTextGroup.removeByName(xNewName)
+titlesAfter2 = self.xAutoTextGroup.getTitles()
+self.assertNotEqual(titlesBefore, titlesAfter2)
+
+def test_renameByName_Failed(self):
+xName = 'Name'
+xTitle = 'Title'
+
+xNewName = 'New Name'
+xNewTitle = 'New Title'
+
+self.xAutoTextGroup.insertNewByName(xName, xTitle, self.xRange)
+self.xAutoTextGroup.insertNewByName(xNewName, xNewTitle, self.xRange)
+
+with self.assertRaises(ElementExistException):
+

[Libreoffice-bugs] [Bug 121644] Pressing on the "Reset" button when the writing focus is on the "Value" input field of a property causes LibreOffice to crash on Properties - Custom Properties

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121644

Xisco Faulí  changed:

   What|Removed |Added

 CC||caol...@redhat.com
   Keywords||haveBacktrace

--- Comment #3 from Xisco Faulí  ---
@Caolán, I thought you might be interested in this crash...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121644] Pressing on the "Reset" button when the writing focus is on the "Value" input field of a property causes LibreOffice to crash on Properties - Custom Properties

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121644

--- Comment #2 from Xisco Faulí  ---
Created attachment 146926
  --> https://bugs.documentfoundation.org/attachment.cgi?id=146926=edit
gdb backtrace

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121644] Pressing on the "Reset" button when the writing focus is on the "Value" input field of a property causes LibreOffice to crash on Properties - Custom Properties

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121644

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
Version|6.1.3.2 release |Inherited From OOo
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Reproduced in

Version: 6.2.0.0.beta1+
Build ID: a5bb6a0406d0018d1df279b925c80b392d9db277
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

Version: 5.2.0.0.alpha0+
Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53
Threads 4; Ver: 4.10; Render: default; 

Version: 4.3.0.0.alpha1+
Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e


LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

old crashes are still popping up

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121614] Calc: FORMATTING changing orientation of text causes corruption of cell borders

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121614

David Lynch  changed:

   What|Removed |Added

 CC||david_ly...@blueyonder.co.u
   ||k

--- Comment #4 from David Lynch  ---
Using Menu/Tools/Options/LibreOffice calc - Genereal - Use printer metrics for
text formatting has no effect. Bug still appears. Tested in safe mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121644] Pressing on the "Reset" button when the writing focus is on the "Value" input field of a property causes LibreOffice to crash on Properties - Custom Properties

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121644

Xisco Faulí  changed:

   What|Removed |Added

Crash report or||["ListBox::GetSelectedEntry
crash signature||Pos(long)"]
   See Also||https://crashreport.libreof
   ||fice.org/stats/signature/Li
   ||stBox::GetSelectedEntryPos(
   ||long)
 CC||xiscofa...@libreoffice.org
 OS|Windows (All)   |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121639] RTF rendering a hyperlink fails in version 6.1.3.2

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121639

Xisco Faulí  changed:

   What|Removed |Added

 OS|Mac OS X (All)  |All
Version|6.1.3.2 release |6.0.0.0.alpha1+
   Keywords||bibisected, bisected,
   ||regression
   Hardware|x86-64 (AMD64)  |All
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||t...@libreoffice.org,
   ||vasily.melenc...@cib.de,
   ||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Thanks for reporting the issue.

Regression introduced by:

author  Vasily Melenchuk   2017-08-18 22:14:08
+0300
committer   Thorsten Behrens   2017-11-10
02:01:57 +0100
commit  eaa9cf6a3069fba3d82c046f0041bfb537d9e648 (patch)
tree55806b023e2f7c380a877d0df6b0bd5bb53ad46e
parent  7f603dd111afcc30eec8bbec97efc16ad8b4c4d1 (diff)
tdf#43017: Support for DOCX hyperlinks character properties

Bisected with: bibisect-linux64-6.0

Adding Cc: to Vasily Melenchuk

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121609] The 'Position and Size' tab of the sidebar is not displaying correctly the size of shapes.

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121609

--- Comment #4 from agm2...@outlook.com ---
The unit of measurement I am using is the Point (pt).

The LO version I am using is 6.0.7.3 (stable).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121644] New: Pressing on the "Reset" button when the writing focus is on the "Value" input field of a property causes LibreOffice to crash on Properties - Custom Properties

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121644

Bug ID: 121644
   Summary: Pressing on the "Reset" button when the writing focus
is on the "Value" input field of a property causes
LibreOffice to crash on Properties - Custom Properties
   Product: LibreOffice
   Version: 6.1.3.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: liski...@gmail.com

Description:
Unsaved changes are not lost after crash

Steps to Reproduce:
1. Go to File->Properties.
2. Go to the "Custom Properties" tab.
3. Press the "Add Property" button.
4. Press on the "Value" input field of that property
5. Press the "Reset" button.

Actual Results:
When pressing the "Reset" button the property is being deleted and LibreOffice
crashes.

Expected Results:
When pressing the "Reset" button the property should just get deleted without
anything else happening.


Reproducible: Always


User Profile Reset: No



Additional Info:
- Pressing on the "Value" input field of an already existing (not new) property
causes the same problem.
- The problem happens only when the chosen value on the "Type" field is Text or
Number.

LibreOffice about info:
Version: 6.1.3.2 (x64)
Build ID: 86daf60bf00efa86ad547e59e09d6bb77c699acb
CPU threads: 4; OS: Windows 10.0; UI render: default; 
Locale: en-US (en_US); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121614] Calc: FORMATTING changing orientation of text causes corruption of cell borders

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121614

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #3 from m.a.riosv  ---
Please test if 'Menu/Tools/Options/LibreOffice calc - Genereal - Use printer
metrics for text formatting' has some effect.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121641] Properties are invisible after pressing the "Reset" button on Properties - Custom Properties

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121641

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 Ever confirmed|0   |1
Version|6.1.3.2 release |6.0.0.0.alpha1+
 Status|UNCONFIRMED |NEW
 CC||szymon.k...@collabora.com,
   ||xiscofa...@libreoffice.org
 OS|Windows (All)   |All

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

author  Szymon Kłos  2017-11-07 20:39:06 +0100
committer   Szymon Kłos  2017-11-08 09:50:14
+0100
commit  272a96da03522a82db4185e7858d05375f3ea95e (patch)
tree1ca63aefb0e0d8b9c0fcacfc75d6f8f423e0cac8
parent  35ca7baca44cc547818324731805fcefde71dd0d (diff)
tdf#100922 Refactor Custom Properties page

Bisected with: bibisect-linux64-6.0 

Adding Cc: to Szymon Kłos

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121399] [gtk3_kde5] 6.1 stable branch: within Plasma-5 session w/ drkonqi: lo_kde5filepicker crashes every time on close (OK/Cancel regardless)

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121399

--- Comment #20 from andreas.sturmlech...@gmail.com ---
Thanks for your quick patch, unfortunately this did not solve the issue yet.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121619] Data validity has problems if input data is changed

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121619

m.a.riosv  changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|UNCONFIRMED |RESOLVED
 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #6 from m.a.riosv  ---
It is not an bug, data validity only runs when you click to select, no formula
in the cell only a value that doesn't change if you not select a new one.

What you want it's introduce a formula addressing the cell with the selection,
but it is no possible with data validity.

Please take a look to the help.
https://help.libreoffice.org/6.1/en-US/text/scalc/guide/validity.html?DbPAR=CALC#bm_id3156442

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120497] Fontwork messed up after last LibreOffice upgrade

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=120497

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #5 from Xisco Faulí  ---
Hello tiotrom,
Could you please try to reproduce it with version 6.1.3 of LibreOffice
from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98015] Allow Labels Wizard to use a spreadsheet for data

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=98015

Mike Sapsard  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120679] [META] Labels and Business Cards issues

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=120679
Bug 120679 depends on bug 98015, which changed state.

Bug 98015 Summary: Allow Labels Wizard to use a spreadsheet for data
https://bugs.documentfoundation.org/show_bug.cgi?id=98015

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121609] The 'Position and Size' tab of the sidebar is not displaying correctly the size of shapes.

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121609

Xisco Faulí  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #3 from Xisco Faulí  ---
Could you please create and attach a screencast showing the steps?
There are various free screencast software available for use, including
Camstudio (Windows), Jing (Mac), Simple Screen Recorder (Linux) or
screencast-o-matic.com (Web).

I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the requested screencast is provided.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121627] Slide Pane: drag outside the widget duplicates the slide

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121627

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |NOTABUG

--- Comment #4 from Xisco Faulí  ---
ahh, you're right. I didn't notice that.
Closing as RESOLVED NOTABUG
Sorry for the noise...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121643] New: Pressing on the "Reset" button when the focus is on the "Type" drop-down field causes LibreOffice to crash, on Properties - Custom Properties

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121643

Bug ID: 121643
   Summary: Pressing on the "Reset" button when the focus is on
the "Type" drop-down field causes LibreOffice to
crash, on Properties - Custom Properties
   Product: LibreOffice
   Version: 6.1.3.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: liski...@gmail.com

Description:
Unsaved changes are not lost after crash

Steps to Reproduce:
1. Go to File->Properties.
2. Go to the "Custom Properties" tab.
3. Press the "Add Property" button.
4. Press "Tab" until the focus is on the "Type" drop-down field of that
property.
5. Press the "Reset" button.

Actual Results:
When pressing the "Reset" button the property is being deleted and LibreOffice
crashes.

Expected Results:
When pressing the "Reset" button the property should just get deleted without
anything else happening.


Reproducible: Always


User Profile Reset: No



Additional Info:
- Bringing the focus to the "Type" field of an already existing (not new)
property causes the same problem.

LibreOffice about info:
Version: 6.1.3.2 (x64)
Build ID: 86daf60bf00efa86ad547e59e09d6bb77c699acb
CPU threads: 4; OS: Windows 10.0; UI render: default; 
Locale: en-US (en_US); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121431] Set language for multiple paragraphs only sets it for the last selected one

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121431

--- Comment #2 from Adalbert Hanßen  ---
I had no doubt that it has been like this in all previous versions. 

Thank you for the hint of using different styles for different languages. I did
not know about that. 

But that's not really a workaround because it blows up the number of styles
because you need a complete set for every languages you are working with. If
you are using LO a lot and deal with more than two languages, this becomes very
cumbersome.

The bug should be corrected at its root. The currently implemented functions
accessible to the user just don't do what they promise to do.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121619] Data validity has problems if input data is changed

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121619

--- Comment #5 from laurentiusil...@gmail.com ---
@ Xavier Van Wijmeersch

In AOO 4.1.6 is the same behavior, so it doesn't work for me :(

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 119625] Firebird: Migration: "value exceeds range for a valid time"

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=119625

--- Comment #9 from Terrence Enger  ---
@Julian,

Can you recall or recreate the failing tests?  I am worried that that
bug may not be fixed after all.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121604] change the default behavior when exporting a spreadsheet to pdf

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121604

--- Comment #5 from m.a.riosv  ---
Sorry not, because the new bug sure it's more clear without the comments in
this one.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121642] RTF rendering fails to neutralize indention using \li0 in a table with a shape

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121642

--- Comment #3 from poul.st...@gmail.com ---
Created attachment 146925
  --> https://bugs.documentfoundation.org/attachment.cgi?id=146925=edit
Picture showing how the RTF rendering works in version 6.1.3.2

Picture of the incorrect rendering of the attached RTF file using LibreOffice
Write version 6.1.3.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121642] RTF rendering fails to neutralize indention using \li0 in a table with a shape

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121642

--- Comment #2 from poul.st...@gmail.com ---
Created attachment 146924
  --> https://bugs.documentfoundation.org/attachment.cgi?id=146924=edit
Picture showing how the RTF rendering was expected

Picture of the correct rendering of the attached RTF file using LibreOffice
Write version 5.3.7.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121642] RTF rendering fails to neutralize indention using \li0 in a table with a shape

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121642

poul.st...@gmail.com changed:

   What|Removed |Added

 CC||poul.st...@gmail.com

--- Comment #1 from poul.st...@gmail.com ---
Created attachment 146923
  --> https://bugs.documentfoundation.org/attachment.cgi?id=146923=edit
RTF file demonstrating the lack of neutralizing indention using \li0

This RTF file contains a table with two rows with some indented text in the
left column (indented 567 twips using the control word "\\li567"). At the end
of the cell, 
this indention is neutralized both using  the "\\li0" control word, which
should be enough, and in addition using the control word sequence "\\par\\pard"
to ensure the picture in the next cell is NOT indented. 
This works perfectly in version 5.3.7.2, while the neutralization of the
indention appears to be ignored in version 6.1.3.2. See the two pictures in the
next two attachments

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121642] New: RTF rendering fails to neutralize indention using \li0 in a table with a shape

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121642

Bug ID: 121642
   Summary: RTF rendering fails to neutralize indention using \li0
in a table with a shape
   Product: LibreOffice
   Version: 6.1.3.2 release
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: poul.st...@gmail.com

Description:
In a row with two cells the text in the first cell is indented using th \li
control word - works fine. In the second cell a shape (with a picture) is to be
shown with no indention using \li0. This works fine in version 5.3.7.2, while
the neutralization of the indention appears to be ignored in version 6.1.3.2.

Steps to Reproduce:
1.Create a table with two cells using
\trowd\trql\trkeep\intbl\trleft0\cellx8108\cellx9072
2.Indent the text in the first cell using \li567
3.Remove the indention in the second cell using \li0 and include a shape with a
picture in the second cell

Actual Results:
The shape is indented despite the \li0 - a text in second cell will NOT be
indented, so apparently the problem is only for shapes.

Expected Results:
The text in the first cell should be indented while the shape with the picture
in the second cell should NOT be indented as the indention should have been
neutralized by the  \li0 control word


Reproducible: Always


User Profile Reset: Yes



Additional Info:
The RTF rendering is working as expected in version 5.3.7.2 (my previous
version), while the new version 6.1.3.2. shows the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121641] New: Properties are invisible after pressing the "Reset" button on Properties - Custom Properties

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=121641

Bug ID: 121641
   Summary: Properties are invisible after pressing the "Reset"
button on Properties - Custom Properties
   Product: LibreOffice
   Version: 6.1.3.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: liski...@gmail.com

Description:
After pressing the "Reset" button, "Add Property" doesn't add properties

Steps to Reproduce:
1. Go to File->Properties
2. Go to the "Custom Properties" tab
3. Press the "Reset" button
4. Press the "Add Property" button

Actual Results:
After pressing the "Reset" button when pressing the "Add Properties" button, no
properties are being added.

Expected Results:
Pressing the "Add Properties" should add a new property, even after pressing
the "Reset" button.


Reproducible: Always


User Profile Reset: No



Additional Info:
-When adding a few properties, the page is getting larger since the scroll bar
is getting smaller (therefore, properties are invisible).
-Pressing "OK" doesn't save the invisible properties.
- Already saved properties are turning invisible When pressing the "Reset"
button, but when reopening the window, they are still saved.

LibreOffice help info:
Version: 6.1.3.2 (x64)
Build ID: 86daf60bf00efa86ad547e59e09d6bb77c699acb
CPU threads: 4; OS: Windows 10.0; UI render: default; 
Locale: en-US (en_US); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 119625] Firebird: Migration: "value exceeds range for a valid time"

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=119625

Julien Nabet  changed:

   What|Removed |Added

 CC|serval2...@yahoo.fr |

--- Comment #8 from Julien Nabet  ---
(In reply to Terrence Enger from comment #7)
>...
> As I am the reporter of the bug, it would normally fall to me to set
> status VERIFIED FIXED.  However, I suggest that someone else should do
> that with this bug.  Julian, would you volunteer for this?

I can't verify it since I remember that for some tests I did about a fix, it
worked, for others it didn't work.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118764] Broken tab key navigation in Properties and Navigator decks

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=118764

--- Comment #20 from Commit Notification 
 ---
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/e08002d10faf26932f5f154ade4dcd1f88565af2%5E%21

tdf#118764 Pos and Shadow panels tab stop fixes

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118764] Broken tab key navigation in Properties and Navigator decks

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=118764

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.2.0 target:6.1.1   |target:6.2.0 target:6.1.1
   |target:6.1.0 target:6.1.3   |target:6.1.0 target:6.1.3
   ||target:6.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/source

2018-11-22 Thread Libreoffice Gerrit user 
 vcl/source/window/dlgctrl.cxx |   35 +--
 1 file changed, 33 insertions(+), 2 deletions(-)

New commits:
commit af16e73d786ed22fe102bd173ea555630a49a832
Author: Jim Raykowski 
AuthorDate: Thu Nov 8 22:43:45 2018 -0900
Commit: Caolán McNamara 
CommitDate: Thu Nov 22 22:08:58 2018 +0100

tdf#121326 Don't tab stop at toolboxes with no visible or enabled items

Change-Id: I4d20bafbda9e6b675654d0359421cf9e57712d15
Reviewed-on: https://gerrit.libreoffice.org/63457
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/source/window/dlgctrl.cxx b/vcl/source/window/dlgctrl.cxx
index 261cf32b23a6..dda51ab396a8 100644
--- a/vcl/source/window/dlgctrl.cxx
+++ b/vcl/source/window/dlgctrl.cxx
@@ -187,6 +187,21 @@ static vcl::Window* ImplGetNextWindow( vcl::Window* 
pParent, sal_uInt16 n, sal_u
 
 namespace vcl {
 
+static bool lcl_ToolBoxTabStop( Window* pWindow )
+{
+ToolBox* pToolBoxWindow = static_cast( pWindow );
+
+sal_uInt16 nId;
+for ( ToolBox::ImplToolItems::size_type nPos = 0; nPos < 
pToolBoxWindow->GetItemCount(); nPos++ )
+{
+nId = pToolBoxWindow->GetItemId( nPos );
+if ( pToolBoxWindow->IsItemVisible( nId ) && 
pToolBoxWindow->IsItemEnabled( nId ) )
+return true;
+}
+
+return false;
+}
+
 vcl::Window* Window::ImplGetDlgWindow( sal_uInt16 nIndex, GetDlgWindowType 
nType,
   sal_uInt16 nFormStart, sal_uInt16 nFormEnd,
   sal_uInt16* pIndex )
@@ -212,7 +227,15 @@ vcl::Window* Window::ImplGetDlgWindow( sal_uInt16 nIndex, 
GetDlgWindowType nType
 if ( !pWindow )
 break;
 if ( (i == nTemp) && (pWindow->GetStyle() & WB_TABSTOP) )
-break;
+{
+if ( WindowType::TOOLBOX == pWindow->GetType() )
+{
+if ( lcl_ToolBoxTabStop( pWindow ) )
+break;
+}
+else
+break;
+}
 }
 while ( i != nIndex );
 }
@@ -245,7 +268,15 @@ vcl::Window* Window::ImplGetDlgWindow( sal_uInt16 nIndex, 
GetDlgWindowType nType
 do
 {
 if ( pWindow->GetStyle() & WB_TABSTOP )
-break;
+{
+if ( WindowType::TOOLBOX == pWindow->GetType() )
+{
+if ( lcl_ToolBoxTabStop( pWindow ) )
+break;
+}
+else
+break;
+}
 if( i == nOldIndex ) // only disabled controls ?
 {
 i = nStartIndex2;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svx/uiconfig

2018-11-22 Thread Libreoffice Gerrit user 
 svx/uiconfig/ui/sidebarpossize.ui |4 ++--
 svx/uiconfig/ui/sidebarshadow.ui  |6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit e08002d10faf26932f5f154ade4dcd1f88565af2
Author: Jim Raykowski 
AuthorDate: Mon Nov 12 14:59:07 2018 -0900
Commit: Caolán McNamara 
CommitDate: Thu Nov 22 22:07:47 2018 +0100

tdf#118764 Pos and Shadow panels tab stop fixes

Change-Id: Id6ee2eed8ee96b901be81729b50e01877e3b
Reviewed-on: https://gerrit.libreoffice.org/63361
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/svx/uiconfig/ui/sidebarpossize.ui 
b/svx/uiconfig/ui/sidebarpossize.ui
index e1f632d245c7..46a920313d95 100644
--- a/svx/uiconfig/ui/sidebarpossize.ui
+++ b/svx/uiconfig/ui/sidebarpossize.ui
@@ -263,7 +263,7 @@
 
   
 True
-False
+True
 True
 Select the angle for 
rotation.
 True
@@ -299,7 +299,7 @@
 
   
 True
-False
+True
 end
 
   
diff --git a/svx/uiconfig/ui/sidebarshadow.ui b/svx/uiconfig/ui/sidebarshadow.ui
index 0a0644dc1196..3bcd4e4439ea 100644
--- a/svx/uiconfig/ui/sidebarshadow.ui
+++ b/svx/uiconfig/ui/sidebarshadow.ui
@@ -77,7 +77,7 @@
 
   
 True
-False
+True
 True
 adjustment1
   
@@ -89,7 +89,7 @@
 
   
 True
-False
+True
 True
   
   
@@ -187,7 +187,7 @@
 
   
 True
-False
+True
 end
   
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 119625] Firebird: Migration: "value exceeds range for a valid time"

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=119625

--- Comment #7 from Terrence Enger  ---
Thank you, Xisco, for the reminder.  I am setting status RESOLVED
FIXED.

As I am the reporter of the bug, it would normally fall to me to set
status VERIFIED FIXED.  However, I suggest that someone else should do
that with this bug.  Julian, would you volunteer for this?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116968] [META] Migrating existing embedded HSQLDB databases to Firebird

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=116968
Bug 116968 depends on bug 119625, which changed state.

Bug 119625 Summary: Firebird: Migration: "value exceeds range for a valid time"
https://bugs.documentfoundation.org/show_bug.cgi?id=119625

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 119625] Firebird: Migration: "value exceeds range for a valid time"

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=119625

Terrence Enger  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr
 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sc/source

2018-11-22 Thread Libreoffice Gerrit user 
 sc/source/core/tool/interpr4.cxx |   11 ++-
 1 file changed, 10 insertions(+), 1 deletion(-)

New commits:
commit 8bc69c4a45d1fc4fe73dd579bc5dc828aaa9b1e7
Author: Eike Rathke 
AuthorDate: Thu Nov 22 00:52:40 2018 +0100
Commit: Caolán McNamara 
CommitDate: Thu Nov 22 22:00:45 2018 +0100

Resolves: tdf#113898 create JumpMatrix for svExternalDoubleRef scalar values

Change-Id: I45d2a1e573a7e4923aaaf5b69f3c4b39215aacc2
Reviewed-on: https://gerrit.libreoffice.org/63778
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit 266aab73a88ae5b62fcddaf383107d8e7edc51f2)
Reviewed-on: https://gerrit.libreoffice.org/63797
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index ecb3bdb95e07..32238916e162 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -1524,7 +1524,7 @@ bool ScInterpreter::ConvertMatrixParameters()
 case svExternalDoubleRef:
 {
 formula::ParamClass eType = 
ScParameterClassification::GetParameterType( pCur, nParams - i);
-if (eType == formula::ParamClass::Array)
+if (eType == formula::ParamClass::Value || eType == 
formula::ParamClass::Array)
 {
 sal_uInt16 nFileId = p->GetIndex();
 OUString aTabName = p->GetString().getString();
@@ -1540,6 +1540,15 @@ bool ScInterpreter::ConvertMatrixParameters()
 ScMatrixRef pMat = pTemp->GetMatrix();
 if (pMat)
 {
+if (eType == formula::ParamClass::Value)
+{   // only if single value expected
+SCSIZE nC, nR;
+pMat->GetDimensions( nC, nR);
+if (nJumpCols < nC)
+nJumpCols = nC;
+if (nJumpRows < nR)
+nJumpRows = nR;
+}
 formula::FormulaToken* pNew = new ScMatrixToken( 
pMat);
 pNew->IncRef();
 pStack[ sp - i ] = pNew;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

2018-11-22 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=103182
Bug 103182 depends on bug 120426, which changed state.

Bug 120426 Summary: Outline/Chapter Numbering Dialog can only accept one level 
(GTK3)
https://bugs.documentfoundation.org/show_bug.cgi?id=120426

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: extras/source include/svx solenv/bin svx/source sw/source sw/uiconfig

2018-11-22 Thread Libreoffice Gerrit user 
 extras/source/glade/libreoffice-catalog.xml.in |3 
 include/svx/swframeexample.hxx |   64 -
 solenv/bin/native-code.py  |1 
 svx/source/dialog/swframeexample.cxx   |  693 
 sw/source/ui/frmdlg/column.cxx |   24 
 sw/source/ui/frmdlg/frmpage.cxx| 1033 +++--
 sw/source/ui/table/tabledlg.cxx|   42 -
 sw/source/uibase/inc/frmpage.hxx   |  137 +--
 sw/source/uibase/inc/prcntfld.hxx  |   73 -
 sw/source/uibase/utlui/prcntfld.cxx|  271 --
 sw/uiconfig/swriter/ui/frmtypepage.ui  |   51 -
 11 files changed, 645 insertions(+), 1747 deletions(-)

New commits:
commit 4b7e2b8a64eca337ea06f7d11fc9d2f66a9d555e
Author: Caolán McNamara 
AuthorDate: Wed Nov 21 21:21:35 2018 +
Commit: Caolán McNamara 
CommitDate: Thu Nov 22 21:59:48 2018 +0100

weld SwFramePage

Change-Id: I12f868611860867df26bd29474aa19189c2b9a96
Reviewed-on: https://gerrit.libreoffice.org/63818
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/extras/source/glade/libreoffice-catalog.xml.in 
b/extras/source/glade/libreoffice-catalog.xml.in
index a02836e94439..629a835e5232 100644
--- a/extras/source/glade/libreoffice-catalog.xml.in
+++ b/extras/source/glade/libreoffice-catalog.xml.in
@@ -250,9 +250,6 @@
 
-
 
diff --git a/include/svx/swframeexample.hxx b/include/svx/swframeexample.hxx
index ddcc5961b95a..814f0d84aa22 100644
--- a/include/svx/swframeexample.hxx
+++ b/include/svx/swframeexample.hxx
@@ -27,7 +27,7 @@
 #include 
 #include 
 
-class SVX_DLLPUBLIC SvxSwFrameExample : public vcl::Window
+class SVX_DLLPUBLIC SwFrameExample : public weld::CustomWidgetController
 {
 Color   m_aTransColor;  ///< transparency
 Color   m_aBgCol;   ///< background
@@ -63,65 +63,6 @@ class SVX_DLLPUBLIC SvxSwFrameExample : public vcl::Window
 
 void InitColors_Impl();
 void InitAllRects_Impl(vcl::RenderContext& rRenderContext);
-void CalcBoundRect_Impl(tools::Rectangle );
-tools::Rectangle DrawInnerFrame_Impl(vcl::RenderContext& rRenderContext, 
const tools::Rectangle , const Color , const Color 
);
-
-virtual void Paint(vcl::RenderContext& rRenderContext, const 
tools::Rectangle&) override;
-virtual Size GetOptimalSize() const override;
-protected:
-virtual void DataChanged( const DataChangedEvent& rDCEvt ) override;
-public:
-
-SvxSwFrameExample(vcl::Window* pParent, WinBits nStyle);
-
-void SetWrap(css::text::WrapTextMode nW) { nWrap = nW; }
-
-void SetHAlign(short nH)  { nHAlign   = nH; }
-void SetHoriRel(short nR) { nHRel = nR; }
-
-void SetVAlign(short nV)  { nVAlign   = nV; }
-void SetVertRel(short nR) { nVRel = nR; }
-
-void SetTransparent(bool bT)  { bTrans= bT; }
-void SetAnchor(RndStdIds nA) { nAnchor   = nA; }
-
-void SetRelPos(const Point& rP);
-};
-
-class SVX_DLLPUBLIC SwFrameExample : public weld::CustomWidgetController
-{
-Color   m_aTransColor;  ///< transparency
-Color   m_aBgCol;   ///< background
-Color   m_aFrameColor;  ///< graphic frame
-Color   m_aAlignColor;  ///< align anchor
-Color   m_aBorderCol;   ///< frame of doc
-Color   m_aPrintAreaCol;///< frame of printable area of doc
-Color   m_aTxtCol;  ///< symbolised text
-Color   m_aBlankCol;///< area of symbol for blank
-Color   m_aBlankFrameCol;   ///< frame of symbol for blank
-
-tools::Rectangle   aPage;
-tools::Rectangle   aPagePrtArea;
-tools::Rectangle   aTextLine;
-tools::Rectangle   aPara;
-tools::Rectangle   aParaPrtArea;
-tools::Rectangle   aFrameAtFrame;
-tools::Rectangle   aDrawObj;
-tools::Rectangle   aAutoCharFrame;
-SizeaFrmSize;
-
-short   nHAlign;
-short   nHRel;
-
-short   nVAlign;
-short   nVRel;
-
-RndStdIds   nAnchor;
-
-Point   aRelPos;
-
-void InitColors_Impl();
-void InitAllRects_Impl(vcl::RenderContext& rRenderContext);
 void CalcBoundRect_Impl(vcl::RenderContext& rRenderContext, 
tools::Rectangle );
 tools::Rectangle DrawInnerFrame_Impl(vcl::RenderContext& rRenderContext, 
const tools::Rectangle , const Color , const Color 
);
 
@@ -133,12 +74,15 @@ public:
 
 virtual void SetDrawingArea(weld::DrawingArea* pDrawingArea) override;
 
+void SetWrap(css::text::WrapTextMode nW) { nWrap = nW; }
+
 void SetHAlign(short nH)  { nHAlign   = nH; }
 void SetHoriRel(short nR) { nHRel = nR; }
 
 void SetVAlign(short nV)  { nVAlign   = nV; }
 void SetVertRel(short nR) { nVRel = nR; }
 
+void SetTransparent(bool bT)  { bTrans= bT; }
 void SetAnchor(RndStdIds nA) { nAnchor

[Libreoffice-commits] core.git: sw/source

2018-11-22 Thread Libreoffice Gerrit user 
 sw/source/ui/chrdlg/swuiccoll.cxx |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit b6aa70dc67983eac812e6f4a67b2b4f08de79fbb
Author: Caolán McNamara 
AuthorDate: Thu Nov 22 15:33:19 2018 +
Commit: Caolán McNamara 
CommitDate: Thu Nov 22 21:58:51 2018 +0100

coverity#1441484 Logically dead code

Change-Id: I42a97ccb5cae95f57a03faf210af362a2874fcb1
Reviewed-on: https://gerrit.libreoffice.org/63809
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/ui/chrdlg/swuiccoll.cxx 
b/sw/source/ui/chrdlg/swuiccoll.cxx
index 16fa6e1761db..b79c721ba593 100644
--- a/sw/source/ui/chrdlg/swuiccoll.cxx
+++ b/sw/source/ui/chrdlg/swuiccoll.cxx
@@ -243,8 +243,7 @@ void SwCondCollPage::SelectHdl(const weld::Widget* pBox)
 }
 pBase = pPool->Next();
 }
-if (!bEmpty)
-m_xStyleLB->select(bEmpty ? -1 : 0);
+m_xStyleLB->select(bEmpty ? -1 : 0);
 SelectHdl(m_xStyleLB.get());
 }
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svx/source

2018-11-22 Thread Libreoffice Gerrit user 
 svx/source/accessibility/ChildrenManagerImpl.cxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 7b6f9b6db7eab2c95b010f542a237dce5350ee73
Author: Caolán McNamara 
AuthorDate: Thu Nov 22 15:36:33 2018 +
Commit: Caolán McNamara 
CommitDate: Thu Nov 22 21:58:25 2018 +0100

coverity#1441483 try and silence bogus Using invalid iterator

Change-Id: I312cef93a0cef48207a3b7f5165dd48d702de3c6
Reviewed-on: https://gerrit.libreoffice.org/63810
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/svx/source/accessibility/ChildrenManagerImpl.cxx 
b/svx/source/accessibility/ChildrenManagerImpl.cxx
index 0485b35d24ab..928438bd6ff2 100644
--- a/svx/source/accessibility/ChildrenManagerImpl.cxx
+++ b/svx/source/accessibility/ChildrenManagerImpl.cxx
@@ -737,8 +737,7 @@ bool ChildrenManagerImpl::ReplaceChild (
 auto I = std::find_if(maVisibleChildren.begin(), maVisibleChildren.end(),
 [](const ChildDescriptor& rChild) { return 
rChild.GetAccessibleShape() == pCurrentChild; });
 
-bool bResult = I != maVisibleChildren.end();
-if (bResult)
+if (I != maVisibleChildren.end())
 {
 // Dispose the current child and send an event about its deletion.
 pCurrentChild->dispose();
@@ -754,12 +753,13 @@ bool ChildrenManagerImpl::ReplaceChild (
 AccessibleEventId::CHILD,
 uno::makeAny (I->mxAccessibleShape),
 uno::Any());
+
+return true;
 }
 
 // When not found among the visible children we have to search the list
 // of accessible shapes.  This is not yet implemented.
-
-return bResult;
+return false;
 }
 
 // Add the impl method for IAccessibleParent interface
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

  1   2   3   4   >