[Libreoffice-bugs] [Bug 121822] Macro execution from macro-assigned draw:custom-shape, involving a Save-as (FILESAVE) and subsequent Reload (FILEOPEN), Close and Reopen original makes application cras

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121822

--- Comment #6 from Oliver Brinzing  ---
Created attachment 147217
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147217=edit
14396a70-0449-468c-9142-4dcae7027223.dmp

adding *.dmp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121856] LibreOffice Writer 6.1.x Outline Numbering not working properly

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121856

Anthony Vimbaye  changed:

   What|Removed |Added

 CC||avimb...@protonmail.com

--- Comment #1 from Anthony Vimbaye  ---
Created attachment 147216
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147216=edit
Tools - Outline Numbering window

Impossible to configure multiple outline numbering to different titles.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121822] Macro execution from macro-assigned draw:custom-shape, involving a Save-as (FILESAVE) and subsequent Reload (FILEOPEN), Close and Reopen original makes application cras

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121822

Oliver Brinzing  changed:

   What|Removed |Added

Summary|Macro execution from|Macro execution from
   |macro-assigned button   |macro-assigned
   |activation, involving a |draw:custom-shape,
   |Save-as (FILESAVE) and  |involving a Save-as
   |subsequent Reload   |(FILESAVE) and subsequent
   |(FILEOPEN), Close and   |Reload (FILEOPEN), Close
   |Reopen original makes   |and Reopen original makes
   |application crash   |application crash

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121856] New: LibreOffice Writer 6.1.x Outline Numbering not working properly

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121856

Bug ID: 121856
   Summary: LibreOffice Writer 6.1.x Outline Numbering not working
properly
   Product: LibreOffice
   Version: 6.1.3.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: avimb...@protonmail.com

Description:
Hello everyone,

First of all, I tried the following operation with the Writer v6.0.7, v6.1.2
and v6.1.3. The problem does not occur in the 6.0 version but in the 6.1.x
versions indeed.

So, there is a problem with the Tools - Outline Numbering in the last
LibreOffice Writer.

When I try to numbering different level of titles, it is always the last
modification which is saved but not the entire configuration. So at the end, I
can number only one heading style.

Thank you for reading.

Steps to Reproduce:
1. Choose Tools - Outline Numbering, and then click the Numbering tab.

2. Choose plan level 1 from the left column.

3. In the Paragraph Style box, select the desired heading style (+ some
options)
Paragraph Style: Title 1
Number: 1, 2, 3...
Sublevel: 1
After: .

4. Choose plan level 2 from the left column.

5. In the Paragraph Style box, select the desired heading style (+ some
options)
Paragraph Style: Title 2
Number: 1, 2, 3...
Sublevel: 2
After: .

6. Choose plan level 3 from the left column.

7. In the Paragraph Style box, select the desired heading style (+ some
options)
Paragraph Style: Title 3
Number: 1, 2, 3...
Sublevel: 3
After: .

8. Validate

Actual Results:
My level 1 title
My level 2 title
1.1.1. My level 3 title

Expected Results:
1. My level 1 title
1.1. My level 2 title
1.1.1. My level 3 title


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
[Information automatically included from LibreOffice]
Locale: fr
Module: TextDocument
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes

Version: 6.1.3.2
Build ID: libreoffice-6.1.3.2-snap1
Threads CPU : 4; OS : Linux 4.18; UI Render : par défaut; VCL: gtk3; 
Locale : fr-FR (fr_FR.UTF-8); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121822] Macro execution from macro-assigned button activation, involving a Save-as (FILESAVE) and subsequent Reload (FILEOPEN), Close and Reopen original makes application cras

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121822

--- Comment #5 from Oliver Brinzing  ---
Created attachment 147215
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147215=edit
Export-Test with form control

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121822] Macro execution from macro-assigned button activation, involving a Save-as (FILESAVE) and subsequent Reload (FILEOPEN), Close and Reopen original makes application cras

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121822

Oliver Brinzing  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW
Version|6.1.3.2 release |Inherited From OOo

--- Comment #4 from Oliver Brinzing  ---
confirming crash if macro is called from:


 
   
  
  
   Shell Script Export Button
  
  


but it will *not* crash, if macro is started via a form control.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113219] contents of the context menu after selecting a word with a mouse differs depending on the direction in which the selection was made

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113219

--- Comment #8 from mcaa...@mail.ru ---
There is no selection reset bug in version 6.1.3.
Thanks.


Fedora Core 27

Writer
Version: 6.1.3.2
Build ID: 86daf60bf00efa86ad547e59e09d6bb77c699acb
CPU threads: 4; OS: Linux 4.18; UI Rendering: default; VCL: gtk2;
Locale: ru-RU (ru_RU.utf8); Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112458] Base table does not retain record updates from Standalone form

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112458

--- Comment #13 from Lionel Elie Mamane  ---
(In reply to robert from comment #10)
> You could work around this with
> -
> Sub S_FLUSH(EVENT)
> EVENT.SOURCE.ACTIVECONNECTION.flush
> End Sub
> -
> Start this "After record action" and the data will be saved.

This looks like either the standalone form doesn't flush the connection when it
is being closed, _or_ it tries, but that fails (because the connection is
already destroyed?), _or_ the connection doesn't correctly flush itself when it
is being closed (comment 7 could be relevant there), _or_ the connection is
never closed / closed at the wrong moment (which brings us back to lifecycle
management).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112458] Base table does not retain record updates from Standalone form

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112458

--- Comment #14 from Lionel Elie Mamane  ---
(In reply to Stang from comment #8)
> I have come up with a work around.  If the database is split then the
> standalone works.  The problem only seems to occur when using embedded DB.

Hmm... Does it work with an embedded Firebird database, or is the bug also
present there?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112458] Base table does not retain record updates from Standalone form

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112458

Lionel Elie Mamane  changed:

   What|Removed |Added

 CC||noelgran...@gmail.com

--- Comment #12 from Lionel Elie Mamane  ---
(In reply to Terrence Enger from comment #11)

> (...) I see that the bug came into LibreOffice sometime in
> the 53 or so commits:

>  cd6c9aef>

>From looking at these commits, a prime suspect is:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=2660d24a07866e083c5135ea263030f3e3a2e729

since it touches lifecycle management... Maybe the data source is not any more
destroyed, or destroyed at a different time? The debug message in comment 7
looks relevant.

Other commits that touch database stuff is
https://cgit.freedesktop.org/libreoffice/core/commit/?id=7339c360ef55fdde99907e1e34a231386ebc534e
and its followup
https://cgit.freedesktop.org/libreoffice/core/commit/?id=37ec6cbeebc5dc9bf642eedcf45f0441edd3d610

But, true, the bug may come from outside database code altogether, so
theoretically possible a sw or sc change is responsible.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121843] In the "Options", add "Select Text" and "Select Pattern" to change the function of "filling color" and "transparency". (no "outer frame")

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121843

--- Comment #7 from 和尚蟹  ---
(In reply to Mike Kaganski from comment #6)


I believe that the "most" people will "support" to change the "filled color."
Because you change the "filling color", you can "personalize".
Just like the "grid" can change the color.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 119502] Firebird: Migration: Incorrect calculation of the length of the table name (Russian)

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119502

--- Comment #4 from s...@imail.ru ---
It helped me

http://www.java2s.com/Code/Java/Development-Class/ASCII2NATIVE.htm

https://github.com/Aleks-Ya/ascii2native-maven-plugin

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121794] DOCX: Specific Document looses all tab stops

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121794

--- Comment #8 from jvsingh...@gmail.com ---
If I may ask, how would we all know if the tab stops are there or not? What is
the indication if they are there or not there? What does it look like.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120703] Bugs found by PVS-Studio static analyzer

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120703

--- Comment #133 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/1f2d3b3f09d16033dae1f99f7739564a5f4c5482%5E%21

tdf#120703 PVS: V560 A part of conditional expression is always true/false

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120703] Bugs found by PVS-Studio static analyzer

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120703

--- Comment #134 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/4da61d4cc8f70ff62d7bac23a1b97d9d7011a678%5E%21

tdf#120703 PVS: logical AND had been used instead of bitwise

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: 2 commits - basic/source canvas/source dbaccess/source sd/source sw/source vcl/source vcl/win

2018-12-01 Thread Libreoffice Gerrit user
 basic/source/sbx/sbxform.cxx   |2 -
 canvas/source/simplecanvas/simplecanvasimpl.cxx|4 +--
 dbaccess/source/ui/querydesign/querycontroller.cxx |2 -
 sd/source/core/sdpage.cxx  |3 --
 sd/source/core/sdpage2.cxx |6 +
 sd/source/ui/app/sdmod2.cxx|2 -
 sd/source/ui/app/sdxfer.cxx|2 -
 sd/source/ui/view/sdview.cxx   |4 +--
 sd/source/ui/view/sdview2.cxx  |   11 ++---
 sw/source/core/docnode/section.cxx |   11 -
 sw/source/core/layout/sectfrm.cxx  |6 ++---
 sw/source/uibase/wrtsh/select.cxx  |2 -
 vcl/source/fontsubset/sft.cxx  |2 -
 vcl/win/gdi/salnativewidgets-luna.cxx  |   24 ++---
 vcl/win/window/salframe.cxx|9 +++
 15 files changed, 44 insertions(+), 46 deletions(-)

New commits:
commit 4da61d4cc8f70ff62d7bac23a1b97d9d7011a678
Author: Mike Kaganski 
AuthorDate: Sun Dec 2 01:14:15 2018 +0300
Commit: Mike Kaganski 
CommitDate: Sun Dec 2 05:31:19 2018 +0100

tdf#120703 PVS: logical AND had been used instead of bitwise

V560 A part of conditional expression is always true:
 sal_Int32(0xFF) != 0.

Change-Id: I5f19c4ff20e91767d22a85239f9693d68ff360b1
Reviewed-on: https://gerrit.libreoffice.org/64414
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/canvas/source/simplecanvas/simplecanvasimpl.cxx 
b/canvas/source/simplecanvas/simplecanvasimpl.cxx
index fe558b0a8886..2e38ee8ffc2b 100644
--- a/canvas/source/simplecanvas/simplecanvasimpl.cxx
+++ b/canvas/source/simplecanvas/simplecanvasimpl.cxx
@@ -112,7 +112,7 @@ namespace
 private:
 bool isStrokingEnabled() const
 {
-return maRenderState.m_aPenColor.getInValue() && sal_Int32(0xFF) 
!= 0;
+return maRenderState.m_aPenColor.getInValue() % 0x100 != 0;
 }
 
 rendering::RenderState createStrokingRenderState() const
@@ -125,7 +125,7 @@ namespace
 
 bool isFillingEnabled() const
 {
-return maRenderState.m_aFillColor.getInValue() && sal_Int32(0xFF) 
!= 0;
+return maRenderState.m_aFillColor.getInValue() % 0x100 != 0;
 }
 
 rendering::RenderState createFillingRenderState() const
commit 1f2d3b3f09d16033dae1f99f7739564a5f4c5482
Author: Mike Kaganski 
AuthorDate: Sun Dec 2 00:59:58 2018 +0300
Commit: Mike Kaganski 
CommitDate: Sun Dec 2 05:31:10 2018 +0100

tdf#120703 PVS: V560 A part of conditional expression is always true/false

Change-Id: Ia9c496ec93bedb13764969bf21c3f21d84caacef
Reviewed-on: https://gerrit.libreoffice.org/64413
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/basic/source/sbx/sbxform.cxx b/basic/source/sbx/sbxform.cxx
index 45a88b556546..ce394fa903b3 100644
--- a/basic/source/sbx/sbxform.cxx
+++ b/basic/source/sbx/sbxform.cxx
@@ -647,7 +647,7 @@ void SbxBasicFormater::ScanFormatString( double dNumber,
 // Remark: in Visual-Basic the first 0 turns on the 0 for
 // all the following # (up to the decimal point),
 // this behaviour is simulated here with the flag.
-if( bGenerateThousandSeparator && ( c=='0' || nMaxDigit >= 
nDigitPos ) && nDigitPos > 0 && (nDigitPos % 3 == 0) )
+if (bGenerateThousandSeparator && c == '0' && nDigitPos > 
0 && (nDigitPos % 3 == 0))
 {
 sReturnStrg.append(cThousandSep);
 }
diff --git a/dbaccess/source/ui/querydesign/querycontroller.cxx 
b/dbaccess/source/ui/querydesign/querycontroller.cxx
index b47c8727bf3e..9a42963ffdfa 100644
--- a/dbaccess/source/ui/querydesign/querycontroller.cxx
+++ b/dbaccess/source/ui/querydesign/querycontroller.cxx
@@ -1200,7 +1200,7 @@ bool OQueryController::askForNewName(const 
Reference& _xElements, b
 if(bNew)
 {
 OUString aDefaultName;
-if ( ( _bSaveAs && !bNew ) || ( bNew && !m_sName.isEmpty() ) )
+if (!m_sName.isEmpty())
 aDefaultName = m_sName;
 else
 {
diff --git a/sd/source/core/sdpage.cxx b/sd/source/core/sdpage.cxx
index 6475a933cfb0..5fdbd63e8007 100644
--- a/sd/source/core/sdpage.cxx
+++ b/sd/source/core/sdpage.cxx
@@ -2902,8 +2902,7 @@ bool SdPage::RestoreDefaultText( SdrObject* pObj )
 // OutlinerParaObjects needs to be changed. The
 // AutoGrowWidth/Height items still exist in the
 // not changed object.
-if(pTextObj
-&& pTextObj->GetOutlinerParaObject()
+if(pTextObj->GetOutlinerParaObject()
 && pTextObj->GetOutlinerParaObject()->IsVertical() != 

[Libreoffice-bugs] [Bug 121855] Calc freezes (CPU power 100% and No response) with fcitx and VCL gtk3

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121855

noga...@gmail.com changed:

   What|Removed |Added

 Blocks||83066, 103182, 109182


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83066
[Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language
issues
https://bugs.documentfoundation.org/show_bug.cgi?id=103182
[Bug 103182] [META] GTK3-specific bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=109182
[Bug 109182] [META] Cell freezing/fixing/locking bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103182

noga...@gmail.com changed:

   What|Removed |Added

 Depends on||121855


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121855
[Bug 121855] Calc freezes (CPU power 100% and No response) with fcitx and VCL
gtk3
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 109182] [META] Cell freezing/fixing/locking bugs and enhancements

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109182

noga...@gmail.com changed:

   What|Removed |Added

 Depends on||121855


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121855
[Bug 121855] Calc freezes (CPU power 100% and No response) with fcitx and VCL
gtk3
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language issues

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83066

noga...@gmail.com changed:

   What|Removed |Added

 Depends on||121855


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121855
[Bug 121855] Calc freezes (CPU power 100% and No response) with fcitx and VCL
gtk3
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121855] New: Calc freezes (CPU power 100% and No response) with fcitx and VCL gtk3

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121855

Bug ID: 121855
   Summary: Calc freezes (CPU power 100% and No response) with
fcitx and VCL gtk3
   Product: LibreOffice
   Version: 6.2.0.0.beta1+
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: noga...@gmail.com

Description:
Calc become unresponsive(CPU power 100%), After "Freeze Cells", input the "="
to move the active cell.

Steps to Reproduce:
Environment
- Input method: fcitx
- VCL: gtk3

1. Launch the Calc (with SAL_USE_VCLPLUGIN=gtk3)

$ SAL_USE_VCLPLUGIN=gtk3 /opt/libreofficedev6.2/program/soffice --calc

2. Select menu View > Freeze Cells > Freeze First Row on A1 cell.
3. Input the "=" (Equal)
4. Press the Down key

Actual Results:
No responsive and CPU power 100%

Expected Results:
The Active cell moves.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
ibus is no problem, VCL gen and kde5 is no proble.

LibreOffice:
バージョン: 6.2.0.0.beta1
Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18
CPU threads: 4; OS:Linux 4.18; UI render: default; VCL: gtk3; 
ロケール: ja-JP (ja_JP.UTF-8); UIの言語: ja-JP
Calc: threaded

Operating System: Debian GNU/Linux sid
KDE Plasma Version: 5.14.3
Qt Version: 5.11.2
KDE Frameworks Version: 5.51.0

Input method:
fcitx: 1:4.2.9.6-5
fcitx-mozc: 2.23.2815.102+dfsg-2+b1
fcitx-hangul: 0.3.1-2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121749] problem downloading beta file

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121749

mois...@hushmail.com changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121749] problem downloading beta file

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121749

--- Comment #4 from mois...@hushmail.com ---
Created attachment 147214
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147214=edit
website

please see attachment. I hope this answers most of your question. 
i'm sorry, I don't know how to answer the size question.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121749] problem downloading beta file

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121749

Aron Budea  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||ba...@caesar.elte.hu

--- Comment #3 from Aron Budea  ---
Can you give the size of the downloaded file, and the link of the mirror it was
downloaded from?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: JunitTest_forms_unoapi_3

2018-12-01 Thread Jens Carl

Hello Luke,

On 12/1/18 4:03 PM, Luke Benes wrote:

Jens,
Have you seen: 
http://document-foundation-mail-archive.969070.n3.nabble.com/JunitTest-forms-unoapi-3-failing-on-Windows-td4253238.html


 I've seen it, but didn't paid too much attention to it.

They're having trouble tracking it down. Any chance you could put this 
on your short list of tests to convert over? The C++ tests provide a lot 
more debugging info.


I already looked at the error message in the thread, but couldn't 
determinate which exact test is failing. Can you post the content of file

workdir/JunitTest/forms_unoapi_3/done.log of a failing run?
After that I can give a more educated answer.

I can't reproduce the error, because I don't have any Windows box available.

Thanks and Cheers

 Jens
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


CppCheck Report Update

2018-12-01 Thread cppcheck.libreoff...@gmail.com

A new cppcheck report is available at : 
http://dev-builds.libreoffice.org/cppcheck_reports/master/


Note:
The script generating this report was run at :
2018-02-12 03:23:32 with user buildslave at host vm140 as 
/home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s 
/home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w 
/home/buildslave/tmp/www

It can be found and improved here:

https://gerrit.libreoffice.org/plugins/gitiles/dev-tools/+/master/cppcheck/cppcheck-report.sh


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 121854] CALC: Make available wildcards with Standard and Advanced filters like in find & replace.

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121854

m.a.riosv  changed:

   What|Removed |Added

Summary|Make available wildcards on |CALC: Make available
   |filters like in find &  |wildcards with Standard and
   |replace.|Advanced filters like in
   ||find & replace.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121854] New: Make available wildcards on filters like in find & replace.

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121854

Bug ID: 121854
   Summary: Make available wildcards on filters like in find &
replace.
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: miguelange...@libreoffice.org

Description:
Currently the wildcards are available in Functions and in Find & Replace, but
not in Standard and Advanced filters. 

Steps to Reproduce:
.

Actual Results:
.

Expected Results:
Add the option in Standard and Advanced filters to use also 'Wildcars'


Reproducible: Always


User Profile Reset: No



Additional Info:
.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121853] Notebookbar Color is not Perfectly Blending on Lubuntu 18.04.1 LTS

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121853

--- Comment #3 from ditokurn...@tutanota.com ---
Created attachment 147211
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147211=edit
Screenshot from LibreOffice Impress

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121853] Notebookbar Color is not Perfectly Blending on Lubuntu 18.04.1 LTS

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121853

--- Comment #4 from ditokurn...@tutanota.com ---
Created attachment 147212
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147212=edit
Another Screenshot - LibreOffice Impress

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121448] Focus incorrectly moves to document on escape key input in undocked sidebar fill type and fill attribute boxes

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121448

Jim Raykowski  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |rayk...@gmail.com
   |desktop.org |

--- Comment #1 from Jim Raykowski  ---
patch for is here:
https://gerrit.libreoffice.org/#/c/64419/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121448] Focus incorrectly moves to document on escape key input in undocked sidebar fill type and fill attribute boxes

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121448

Jim Raykowski  changed:

   What|Removed |Added

Summary|Focus incorrectly moves to  |Focus incorrectly moves to
   |document when escape key is |document on escape key
   |pressed while in undocked   |input in undocked sidebar
   |sidebar Fill control|fill type and fill
   ||attribute boxes

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112458] Base table does not retain record updates from Standalone form

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112458

Terrence Enger  changed:

   What|Removed |Added

 CC||lo_b...@iseries-guru.com

--- Comment #11 from Terrence Enger  ---
Created attachment 147213
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147213=edit
bibisect in till51 repo, tail of terminal output

Working on debian-buster in the daily till51 bibisect repository, I
see that the bug came into LibreOffice sometime in the 53 or so
commits:

  commitdates-h
    --  
good  567a8477  2015-08-03  71ace488
bad   b6f9394f  2015-08-04  cd6c9aef

which is to say


I am removing key bibisectRequest and adding bibisected.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121853] Notebookbar Color is not Perfectly Blending on Lubuntu 18.04.1 LTS

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121853

--- Comment #2 from ditokurn...@tutanota.com ---
Created attachment 147210
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147210=edit
Another Screenshot - LibreOffice Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121853] New: Notebookbar Color is not Perfectly Blending on Lubuntu 18.04.1 LTS

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121853

Bug ID: 121853
   Summary: Notebookbar Color is not Perfectly Blending on Lubuntu
18.04.1 LTS
   Product: LibreOffice
   Version: 6.0.6.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ditokurn...@tutanota.com

Description:
Today I download LibreOffice Impress and Writer in Lubuntu 18.04.1 LTS. It runs
normal. But when I change the layout to Notebookbar, the Notebookbar color is
not blending perfectly. The button background is white but the Notebookbar
background is grey. I find this bug on Impress and Writer, and still not trying
other LibreOffice. I download the LibreOffice Impress and Writer from Synaptic
Package Manager.

Before I moved to Lubuntu 18.04.1 LTS, I used Ubuntu 18.04.1 LTS and I don't
find this bug on Ubuntu 18.04.1 LTS.

Note: I want to submit screenshot too in this document, but I don't know how to
do that, sorry.

Steps to Reproduce:
1.Open LibreOffice Impress or Writer
2.Enable experimental feature in the LibreOffice options 
3.Click "View" -> "Toolbar Layout" -> "Notebookbar"
4.Choose Notebookbar layout in "View" -> "Notebookbar"

Actual Results:
The Notebookbar color background not perfectly blending with the background
color of buttons.

Expected Results:
The Notebookbar color background blend perfectly with the background color of
buttons.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 6.0.6.2
Build ID: 1:6.0.6-0ubuntu0.18.04.1
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; 
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121853] Notebookbar Color is not Perfectly Blending on Lubuntu 18.04.1 LTS

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121853

ditokurn...@tutanota.com changed:

   What|Removed |Added

 CC||ditokurn...@tutanota.com

--- Comment #1 from ditokurn...@tutanota.com ---
Created attachment 147209
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147209=edit
Notebookbar background color is not blending with the background color of the
buttons

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120170] Sidebar: Escape key press in floating sidebar Style or Character panel comboboxes sends focus to document view

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120170

Jim Raykowski  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |rayk...@gmail.com
   |desktop.org |

--- Comment #2 from Jim Raykowski  ---
gerrit link to proposed patch:
https://gerrit.libreoffice.org/#/c/64417/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121852] New: Accelerator shortcut keys for recent files no longer work

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121852

Bug ID: 121852
   Summary: Accelerator shortcut keys for recent files no longer
work
   Product: LibreOffice
   Version: 6.2.0.0.beta1+
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ddascalescu+freedesk...@gmail.com

This is a regression from v5.4.

1. Go to File -> Recent Documents
2. Press 1

The first file should open, but nothing happens in Calc 6.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 45904] move java based api tests to c++

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45904

--- Comment #172 from Commit Notification 
 ---
Jens Carl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/a9b13f2b7f0d2ab8bcf25a3110a06ababb4573f6%5E%21

tdf#45904 Move XElementAccess Java tests to C++

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 45904] move java based api tests to c++

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45904

--- Comment #171 from Commit Notification 
 ---
Jens Carl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/2562eb1aff667fd9ddc07b75fa8346e9d61ea093%5E%21

tdf#45904 Move XIndexAccess Java tests to C++

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: framework/qa qadevOOo/Jar_OOoRunner.mk qadevOOo/objdsc qadevOOo/tests sc/qa

2018-12-01 Thread Libreoffice Gerrit user
 framework/qa/complex/api_internal/api.lst|1 
 qadevOOo/Jar_OOoRunner.mk|1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScAnnotationsObj.csv |2 
 qadevOOo/tests/java/mod/_sc/ScAnnotationsObj.java|  132 
--
 sc/qa/extras/scannotationsobj.cxx|   17 +
 sc/qa/unoapi/sc_2.sce|1 
 6 files changed, 14 insertions(+), 140 deletions(-)

New commits:
commit a9b13f2b7f0d2ab8bcf25a3110a06ababb4573f6
Author: Jens Carl 
AuthorDate: Sat Dec 1 19:35:01 2018 +
Commit: Jens Carl 
CommitDate: Sun Dec 2 00:28:27 2018 +0100

tdf#45904 Move XElementAccess Java tests to C++

Move XElementAccess Java tests to C++ for ScAnnotationsObj.

Change-Id: Ife8c2d51a3aae409fa008c5ad2515a8976481771
Reviewed-on: https://gerrit.libreoffice.org/64407
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/framework/qa/complex/api_internal/api.lst 
b/framework/qa/complex/api_internal/api.lst
index fd5f7f2dd491..b47dad57003c 100644
--- a/framework/qa/complex/api_internal/api.lst
+++ b/framework/qa/complex/api_internal/api.lst
@@ -72,7 +72,6 @@ job72=sc.ScAccessiblePageHeader
 job73=sc.ScAccessiblePreviewTable
 job74=sc.ScAccessibleSpreadsheet
 job75=sc.ScAnnotationObj
-job76=sc.ScAnnotationsObj
 job78=sc.ScAutoFormatFieldObj
 job79=sc.ScAutoFormatObj
 job80=sc.ScAutoFormatsObj
diff --git a/qadevOOo/Jar_OOoRunner.mk b/qadevOOo/Jar_OOoRunner.mk
index 575f7fa0c301..2c5673c4e86a 100644
--- a/qadevOOo/Jar_OOoRunner.mk
+++ b/qadevOOo/Jar_OOoRunner.mk
@@ -952,7 +952,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\
 qadevOOo/tests/java/mod/_sc/ScAccessibleSpreadsheet \
 qadevOOo/tests/java/mod/_sc/ScAnnotationObj \
 qadevOOo/tests/java/mod/_sc/ScAnnotationShapeObj \
-qadevOOo/tests/java/mod/_sc/ScAnnotationsObj \
 qadevOOo/tests/java/mod/_sc/ScAnnotationTextCursor \
 qadevOOo/tests/java/mod/_sc/ScAreaLinkObj \
 qadevOOo/tests/java/mod/_sc/ScAutoFormatFieldObj \
diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScAnnotationsObj.csv 
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScAnnotationsObj.csv
deleted file mode 100644
index a6e62ec29e06..
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScAnnotationsObj.csv
+++ /dev/null
@@ -1,2 +0,0 @@
-"ScAnnotationsObj";"com::sun::star::container::XElementAccess";"getElementType()"
-"ScAnnotationsObj";"com::sun::star::container::XElementAccess";"hasElements()"
diff --git a/qadevOOo/tests/java/mod/_sc/ScAnnotationsObj.java 
b/qadevOOo/tests/java/mod/_sc/ScAnnotationsObj.java
deleted file mode 100644
index 24d9756528d7..
--- a/qadevOOo/tests/java/mod/_sc/ScAnnotationsObj.java
+++ /dev/null
@@ -1,132 +0,0 @@
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-package mod._sc;
-
-import java.io.PrintWriter;
-
-import lib.TestCase;
-import lib.TestEnvironment;
-import lib.TestParameters;
-import util.SOfficeFactory;
-
-import com.sun.star.container.XNameAccess;
-import com.sun.star.lang.XComponent;
-import com.sun.star.sheet.XSheetAnnotation;
-import com.sun.star.sheet.XSheetAnnotationAnchor;
-import com.sun.star.sheet.XSheetAnnotationsSupplier;
-import com.sun.star.sheet.XSpreadsheet;
-import com.sun.star.sheet.XSpreadsheetDocument;
-import com.sun.star.sheet.XSpreadsheets;
-import com.sun.star.table.XCell;
-import com.sun.star.table.XCellRange;
-import com.sun.star.text.XSimpleText;
-import com.sun.star.uno.AnyConverter;
-import com.sun.star.uno.Type;
-import com.sun.star.uno.UnoRuntime;
-import com.sun.star.uno.XInterface;
-
-/**
-* Test for object which represents a collection of annotations
-* for a spreadsheet document (implements
-* com.sun.star.sheet.CellAnnotations). 
-* Object implements the following interfaces :
-* 
-*   com::sun::star::container::XIndexAccess
-*   com::sun::star::container::XElementAccess
-*   com::sun::star::sheet::XSheetAnnotations
-*  
-* This object test  is NOT  designed to be run in several
-* threads concurrently.
-* @see com.sun.star.sheet.CellAnnotations
-* @see com.sun.star.container.XIndexAccess
-* @see 

[Libreoffice-commits] core.git: qadevOOo/objdsc sc/qa

2018-12-01 Thread Libreoffice Gerrit user
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScAnnotationsObj.csv |2 --
 sc/qa/extras/scannotationsobj.cxx|   10 
++
 2 files changed, 10 insertions(+), 2 deletions(-)

New commits:
commit 2562eb1aff667fd9ddc07b75fa8346e9d61ea093
Author: Jens Carl 
AuthorDate: Sat Dec 1 19:16:11 2018 +
Commit: Jens Carl 
CommitDate: Sun Dec 2 00:27:38 2018 +0100

tdf#45904 Move XIndexAccess Java tests to C++

Move XIndexAccess Java tests to C++ for ScAnnotationsObj.

Change-Id: Icbd34ffe4b4911754045e4a5dc511b3fb25d4dd0
Reviewed-on: https://gerrit.libreoffice.org/64404
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScAnnotationsObj.csv 
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScAnnotationsObj.csv
index 1a785cf0f365..a6e62ec29e06 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScAnnotationsObj.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScAnnotationsObj.csv
@@ -1,4 +1,2 @@
-"ScAnnotationsObj";"com::sun::star::container::XIndexAccess";"getCount()"
-"ScAnnotationsObj";"com::sun::star::container::XIndexAccess";"getByIndex()"
 
"ScAnnotationsObj";"com::sun::star::container::XElementAccess";"getElementType()"
 "ScAnnotationsObj";"com::sun::star::container::XElementAccess";"hasElements()"
diff --git a/sc/qa/extras/scannotationsobj.cxx 
b/sc/qa/extras/scannotationsobj.cxx
index a80c35e35a18..5c358e2b4caf 100644
--- a/sc/qa/extras/scannotationsobj.cxx
+++ b/sc/qa/extras/scannotationsobj.cxx
@@ -9,6 +9,7 @@
 
 #include 
 #include 
+#include 
 #include 
 
 #include 
@@ -16,6 +17,9 @@
 #include 
 #include 
 #include 
+#include 
+
+#include 
 
 using namespace css;
 using namespace css::uno;
@@ -23,6 +27,7 @@ using namespace css::uno;
 namespace sc_apitest {
 
 class ScAnnontationsObj : public CalcUnoApiTest, public 
apitest::XEnumerationAccess,
+ public apitest::XIndexAccess,
  public 
apitest::XSheetAnnotations
 {
 public:
@@ -39,6 +44,10 @@ public:
 // XEnumerationAccess
 CPPUNIT_TEST(testCreateEnumeration);
 
+// XIndexAccess
+CPPUNIT_TEST(testGetByIndex);
+CPPUNIT_TEST(testGetCount);
+
 // XSheetAnnotations
 CPPUNIT_TEST(testCount);
 CPPUNIT_TEST(testIndex);
@@ -55,6 +64,7 @@ private:
 
 ScAnnontationsObj::ScAnnontationsObj()
: CalcUnoApiTest("/sc/qa/extras/testdocuments")
+   , XIndexAccess(1)
 {
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 120042] FIREBIRD: Crash in: libc-2.27.so when Save As of an ODB overtop of an existing ODB if the target has been opened in current session

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120042

--- Comment #9 from Terrence Enger  ---
I still see the crash in daily Linux dbgutil bibisect repository
version 2018-12-01 (s-h 099772a1) and local build of commit 7d459621
(2018-12-01 12:40:38 UTC).

These are both dbgutil builds.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121839] FORMATTING -- ConditionalFormat.ColorScale Does Not Survive File-Rreload

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121839

--- Comment #2 from Mike Kaganski  ---
Created attachment 147208
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147208=edit
Reportedly, the problem is caused by R1C1 syntax (GIF produced by OP)

However, in testing on Windows, I also used R1C1, and didn't repro
(http://youtu.be/vcU6wxnhnX8?hd=1).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121781] Status of time zone data storage in date cells; timezone conversion

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121781

--- Comment #1 from Dan Dascalescu  ---
It appears LibreCalc doesn't have the concept of universal time, or time zone,
either. Please see bug #121851.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121851] New: Calc loses time zone information for datetime cells

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121851

Bug ID: 121851
   Summary: Calc loses time zone information for datetime cells
   Product: LibreOffice
   Version: 6.2.0.0.beta1+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ddascalescu+freedesk...@gmail.com

Created attachment 147207
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147207=edit
Whatever time zone you're in, you'll see the same time, 23:30 on Nov 30

In today's age with geographically distributed teams, and people traveling
frequently, time zone information is critical when sharing spreadsheets. If
accuracy is important, then if a person in San Francisco has an invoice like

"Order received", "2018-11-30 23:00:00"
"Job completed", "2018-12-01 10:00:00"

and sends it to someone in Berlin, the person in Berlin should see

"Order received", "2018-12-01 08:00:00"
"Job completed", "2018-12-01 19:00:00"

This is not what happens. The person in Berlin will see the same local times as
the person in San Francisco, which is confusing (I don't send orders at 11pm),
and simply incorrect. Moreover, dates may be off, as in the example above, and
for monthly billing processes, this can push items from one month to the next
to one party, while to the other they're in the same month.

1. Is this really acceptable for Calc? Do we assume users no longer send
spreadhseets, but use Google Sheets or equivalent online systems?
2. What about people who travel? If I have a sheet in which I log
time-sensitive incidents, or if such a sheet is generated by another system,
and I look at it from a different timezone, the timestamp information will be
incorrect.

I know Excel doesn't have the concept of universal time, but that was 20 years
ago. Should we try to improve the situation in LibreCalc?

To test, I've opened the attached file with LibreCalc 6.2dev on Ubuntu 16,
after changing time zones and restarting Calc. The time shown was always the
same, 2018-11-30 23:30:00.

The way I generated the file was with this Node.js code:

```js
const XLSX = require('xlsx');

const wb = XLSX.utils.book_new();

const ws = XLSX.utils.json_to_sheet([]);

XLSX.utils.book_append_sheet(wb, ws, 'Bug sheet');

// Dec 1, 00:30 in Berlin
// Nov 30, 23:30 in London
// Nov 30, 17:30 in New York
// Nov 13, 14:30 in San Francisco
ws.A1 = { t: 'd', v: new Date('2018-11-30T23:30:00Z') };

XLSX.writeFile(wb, 'date.ods');
```

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121849] Crash in: RIC655c.DLL

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121849

--- Comment #1 from raal  ---
*** Bug 121850 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121850] Crash in: RIC655c.DLL

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121850

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE
 CC||r...@post.cz

--- Comment #1 from raal  ---


*** This bug has been marked as a duplicate of bug 121849 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121822] Macro execution from macro-assigned button activation, involving a Save-as (FILESAVE) and subsequent Reload (FILEOPEN), Close and Reopen original makes application cras

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121822

--- Comment #3 from Thijs  ---
Created attachment 147206
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147206=edit
Test spreadsheet

Sorry, picked the wrong file when building the zip. Here is the test
spreadsheet for reproducing the crash

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121721] GTK3: super slow xor mode used for slideshow gradients

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121721

--- Comment #7 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/0aaebad112a2d877450133b737c5b08bf8b2387d%5E%21

Related: tdf#121721 use premultiply unpremultiply tables

It will be available in 6.2.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121721] GTK3: super slow xor mode used for slideshow gradients

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121721

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.3.0|target:6.3.0 target:6.2.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/headless

2018-12-01 Thread Libreoffice Gerrit user
 vcl/headless/svpgdi.cxx |   74 +---
 1 file changed, 58 insertions(+), 16 deletions(-)

New commits:
commit 0aaebad112a2d877450133b737c5b08bf8b2387d
Author: Caolán McNamara 
AuthorDate: Fri Nov 30 17:03:11 2018 +
Commit: Caolán McNamara 
CommitDate: Sat Dec 1 22:38:12 2018 +0100

Related: tdf#121721 use premultiply unpremultiply tables

for tdf#121721 this brings the time down between pressing F5 and seeing the
image from 4 seconds to 1.4 seconds

Change-Id: I8e7f15e5126218b040e96f9143827ff788b4fb51
Reviewed-on: https://gerrit.libreoffice.org/64403
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index 0ae7cbd6ba11..ec01ec520a86 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -1641,7 +1641,7 @@ void SvpSalGraphics::drawBitmap( const SalTwoRect& rTR,
 
 static sal_uInt8 unpremultiply(sal_uInt8 c, sal_uInt8 a)
 {
-return (a > 0) ? (c * 255 + a / 2) / a : 0;
+return (a == 0) ? 0 : (c * 255 + a / 2) / a;
 }
 
 static sal_uInt8 premultiply(sal_uInt8 c, sal_uInt8 a)
@@ -1649,6 +1649,40 @@ static sal_uInt8 premultiply(sal_uInt8 c, sal_uInt8 a)
 return (c * a + 127) / 255;
 }
 
+typedef sal_uInt8 (*lookup_table)[256];
+
+static lookup_table get_unpremultiply_table()
+{
+static bool inited;
+static sal_uInt8 unpremultiply_table[256][256];
+
+if (!inited)
+{
+for (int a = 0; a < 256; ++a)
+for (int c = 0; c < 256; ++c)
+unpremultiply_table[a][c] = unpremultiply(c, a);
+inited = true;
+}
+
+return unpremultiply_table;
+}
+
+static lookup_table get_premultiply_table()
+{
+static bool inited;
+static sal_uInt8 premultiply_table[256][256];
+
+if (!inited)
+{
+for (int a = 0; a < 256; ++a)
+for (int c = 0; c < 256; ++c)
+premultiply_table[a][c] = premultiply(c, a);
+inited = true;
+}
+
+return premultiply_table;
+}
+
 void SvpSalGraphics::drawMask( const SalTwoRect& rTR,
const SalBitmap& rSalBitmap,
Color nMaskColor )
@@ -1663,15 +1697,17 @@ void SvpSalGraphics::drawMask( const SalTwoRect& rTR,
 }
 sal_Int32 nStride;
 unsigned char *mask_data = aSurface.getBits(nStride);
+lookup_table unpremultiply_table = get_unpremultiply_table();
 for (long y = rTR.mnSrcY ; y < rTR.mnSrcY + rTR.mnSrcHeight; ++y)
 {
 unsigned char *row = mask_data + (nStride*y);
 unsigned char *data = row + (rTR.mnSrcX * 4);
 for (long x = rTR.mnSrcX; x < rTR.mnSrcX + rTR.mnSrcWidth; ++x)
 {
-sal_uInt8 b = unpremultiply(data[SVP_CAIRO_BLUE], 
data[SVP_CAIRO_ALPHA]);
-sal_uInt8 g = unpremultiply(data[SVP_CAIRO_GREEN], 
data[SVP_CAIRO_ALPHA]);
-sal_uInt8 r = unpremultiply(data[SVP_CAIRO_RED], 
data[SVP_CAIRO_ALPHA]);
+sal_uInt8 a = data[SVP_CAIRO_ALPHA];
+sal_uInt8 b = unpremultiply_table[a][data[SVP_CAIRO_BLUE]];
+sal_uInt8 g = unpremultiply_table[a][data[SVP_CAIRO_GREEN]];
+sal_uInt8 r = unpremultiply_table[a][data[SVP_CAIRO_RED]];
 if (r == 0 && g == 0 && b == 0)
 {
 data[0] = nMaskColor.GetBlue();
@@ -1769,10 +1805,12 @@ Color SvpSalGraphics::getPixel( long nX, long nY )
 cairo_destroy(cr);
 
 cairo_surface_flush(target);
+lookup_table unpremultiply_table = get_unpremultiply_table();
 unsigned char *data = cairo_image_surface_get_data(target);
-sal_uInt8 b = unpremultiply(data[SVP_CAIRO_BLUE], data[SVP_CAIRO_ALPHA]);
-sal_uInt8 g = unpremultiply(data[SVP_CAIRO_GREEN], data[SVP_CAIRO_ALPHA]);
-sal_uInt8 r = unpremultiply(data[SVP_CAIRO_RED], data[SVP_CAIRO_ALPHA]);
+sal_uInt8 a = data[SVP_CAIRO_ALPHA];
+sal_uInt8 b = unpremultiply_table[a][data[SVP_CAIRO_BLUE]];
+sal_uInt8 g = unpremultiply_table[a][data[SVP_CAIRO_GREEN]];
+sal_uInt8 r = unpremultiply_table[a][data[SVP_CAIRO_RED]];
 Color nRet = Color(r, g, b);
 
 cairo_surface_destroy(target);
@@ -2101,6 +2139,8 @@ void SvpSalGraphics::releaseCairoContext(cairo_t* cr, 
bool bXorModeAllowed, cons
 sal_Int32 nUnscaledExtentsRight = nExtentsRight * m_fScale;
 sal_Int32 nUnscaledExtentsTop = nExtentsTop * m_fScale;
 sal_Int32 nUnscaledExtentsBottom = nExtentsBottom * m_fScale;
+lookup_table unpremultiply_table = get_unpremultiply_table();
+lookup_table premultiply_table = get_premultiply_table();
 for (sal_Int32 y = nUnscaledExtentsTop; y < nUnscaledExtentsBottom; 
++y)
 {
 unsigned char *true_row = target_surface_data + (nStride*y);
@@ -2109,15 +2149,17 @@ void SvpSalGraphics::releaseCairoContext(cairo_t* cr, 
bool bXorModeAllowed, cons
 unsigned char *xor_data = xor_row + 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sw/inc sw/source

2018-12-01 Thread Libreoffice Gerrit user
 sw/inc/swabstdlg.hxx  |2 +-
 sw/source/ui/dialog/swdlgfact.cxx |4 ++--
 sw/source/ui/dialog/swdlgfact.hxx |2 +-
 sw/source/uibase/app/docst.cxx|2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit 478b714e4e02595b300f9adf73bd6b04c88e6c8f
Author: Caolán McNamara 
AuthorDate: Fri Nov 30 12:31:39 2018 +
Commit: Caolán McNamara 
CommitDate: Sat Dec 1 22:37:37 2018 +0100

can pass window directly to CreateTemplateDialog now

Change-Id: Ic7ff388a338b2b90f4509c807f7ffcb34e468edb
Reviewed-on: https://gerrit.libreoffice.org/64394
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/inc/swabstdlg.hxx b/sw/inc/swabstdlg.hxx
index be930f00e327..5bffda4b0f2d 100644
--- a/sw/inc/swabstdlg.hxx
+++ b/sw/inc/swabstdlg.hxx
@@ -435,7 +435,7 @@ public:
 /// @param nSlot
 /// Identifies optional Slot by which the creation of the Template (Style) 
dialog is triggered.
 /// Currently used, if nRegion == SfxStyleFamily::Page in order to 
activate certain dialog pane
-virtual VclPtr  
CreateTemplateDialog(vcl::Window* pParent,
+virtual VclPtr  
CreateTemplateDialog(weld::Window* pParent,
 SfxStyleSheetBase&  rBase,
 SfxStyleFamily  nRegion,
 const OString&  sPage,
diff --git a/sw/source/ui/dialog/swdlgfact.cxx 
b/sw/source/ui/dialog/swdlgfact.cxx
index 6cba9c300ebd..e5451360c27b 100644
--- a/sw/source/ui/dialog/swdlgfact.cxx
+++ b/sw/source/ui/dialog/swdlgfact.cxx
@@ -988,14 +988,14 @@ VclPtr 
SwAbstractDialogFactory_Impl::CreateFrameTabDialog(
 }
 
 VclPtr 
SwAbstractDialogFactory_Impl::CreateTemplateDialog(
-vcl::Window *pParent,
+weld::Window *pParent,
 SfxStyleSheetBase&  rBase,
 SfxStyleFamily  nRegion,
 const OString&  sPage,
 SwWrtShell* pActShell,
 boolbNew )
 {
-return 
VclPtr::Create(o3tl::make_unique(pParent
 ? pParent->GetFrameWeld() : nullptr, rBase, nRegion, sPage, pActShell, bNew));
+return 
VclPtr::Create(o3tl::make_unique(pParent,
 rBase, nRegion, sPage, pActShell, bNew));
 }
 
 VclPtr 
SwAbstractDialogFactory_Impl::CreateGlossaryDlg(SfxViewFrame* pViewFrame,
diff --git a/sw/source/ui/dialog/swdlgfact.hxx 
b/sw/source/ui/dialog/swdlgfact.hxx
index 20af94170204..ae653f8687d5 100644
--- a/sw/source/ui/dialog/swdlgfact.hxx
+++ b/sw/source/ui/dialog/swdlgfact.hxx
@@ -665,7 +665,7 @@ public:
 bool bNewFrame  = true,
 const OString& sDefPage = 
OString()) override;
 virtual VclPtr  CreateTemplateDialog(
-vcl::Window *pParent,
+weld::Window *pParent,
 SfxStyleSheetBase&  rBase,
 SfxStyleFamily  nRegion,
 const OString&  sPage,
diff --git a/sw/source/uibase/app/docst.cxx b/sw/source/uibase/app/docst.cxx
index 47f65f43f774..d9bc6d2f0cd9 100644
--- a/sw/source/uibase/app/docst.cxx
+++ b/sw/source/uibase/app/docst.cxx
@@ -818,7 +818,7 @@ void SwDocShell::Edit(
 FieldUnit eMetric = ::GetDfltMetric(0 != (HTMLMODE_ON));
 SW_MOD()->PutItem(SfxUInt16Item(SID_ATTR_METRIC, static_cast< 
sal_uInt16 >(eMetric)));
 SwAbstractDialogFactory* pFact = SwAbstractDialogFactory::Create();
-ScopedVclPtr 
pDlg(pFact->CreateTemplateDialog(()->GetViewFrame()->GetWindow(),
+ScopedVclPtr 
pDlg(pFact->CreateTemplateDialog(GetView()->GetViewFrame()->GetWindow().GetFrameWeld(),
 *(xTmp.get()), nFamily, 
sPage, pCurrShell, bNew));
 std::shared_ptr pApplyStyleHelper(new ApplyStyle(*this, 
bNew, xTmp, nFamily, pDlg.get(), m_xBasePool, bModified));
 pDlg->SetApplyHdl(LINK(pApplyStyleHelper.get(), ApplyStyle, ApplyHdl));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: cui/source cui/uiconfig extras/source include/vcl solenv/bin solenv/sanitizers vcl/source vcl/unx

2018-12-01 Thread Libreoffice Gerrit user
 cui/source/inc/autocdlg.hxx|   54 ++
 cui/source/tabpages/autocdlg.cxx   |  223 ++---
 cui/uiconfig/ui/acorexceptpage.ui  |1 
 cui/uiconfig/ui/wordcompletionpage.ui  |   56 +-
 extras/source/glade/libreoffice-catalog.xml.in |3 
 include/vcl/weld.hxx   |   22 +-
 solenv/bin/native-code.py  |1 
 solenv/sanitizers/ui/cui.suppr |3 
 vcl/source/app/salvtables.cxx  |   89 +++--
 vcl/source/control/button.cxx  |3 
 vcl/unx/gtk3/gtk3gtkinst.cxx   |   93 +-
 11 files changed, 289 insertions(+), 259 deletions(-)

New commits:
commit 9c5d20105f0b123fca724cb4845f0e7227c217d8
Author: Caolán McNamara 
AuthorDate: Thu Nov 29 20:11:34 2018 +
Commit: Caolán McNamara 
CommitDate: Sat Dec 1 22:37:22 2018 +0100

weld OfaAutoCompleteTabPage

Change-Id: I84f051fd1dc127663fd510c81addb0fd0cdc2c26
Reviewed-on: https://gerrit.libreoffice.org/64278
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/source/inc/autocdlg.hxx b/cui/source/inc/autocdlg.hxx
index b396ad89e762..81044a633eab 100644
--- a/cui/source/inc/autocdlg.hxx
+++ b/cui/source/inc/autocdlg.hxx
@@ -382,55 +382,39 @@ public:
 class OfaAutoCompleteTabPage : public SfxTabPage
 {
 friend class VclPtr;
-public:
-class AutoCompleteMultiListBox : public MultiListBox
-{
-VclPtr m_pPage;
-public:
-AutoCompleteMultiListBox(vcl::Window *pParent, WinBits nBits)
-: MultiListBox(pParent, nBits)
-, m_pPage(nullptr)
-{
-}
-virtual ~AutoCompleteMultiListBox() override;
-virtual void dispose() override;
-void SetPage(OfaAutoCompleteTabPage *pPage) { m_pPage = pPage; }
-virtual bool PreNotify( NotifyEvent& rNEvt ) override;
-};
-
 private:
 using TabPage::ActivatePage;
-VclPtr   m_pCBActiv; ///   m_pCBAppendSpace;///   m_pCBAsTip; ///   m_pCBCollect;///   m_pCBRemoveList;///<...save the list for later 
use...
-
-VclPtrm_pDCBExpandKey;
-VclPtr   m_pNFMinWordlen;
-VclPtr   m_pNFMaxEntries;
-VclPtr m_pLBEntries;
-VclPtr m_pPBEntries;
 editeng::SortedAutoCompleteStrings* m_pAutoCompleteList;
 sal_uInt16  m_nAutoCmpltListCnt;
 
-DECL_LINK( CheckHdl, CheckBox&, void );
+std::unique_ptr m_xCBActiv; /// m_xCBAppendSpace;/// m_xCBAsTip; /// m_xCBCollect;/// m_xCBRemoveList;///<...save the list 
for later use...
 
-OfaAutoCompleteTabPage( vcl::Window* pParent,
-const SfxItemSet& rSet );
+std::unique_ptr m_xDCBExpandKey;
+std::unique_ptr m_xNFMinWordlen;
+std::unique_ptr m_xNFMaxEntries;
+std::unique_ptr m_xLBEntries;
+std::unique_ptr m_xPBEntries;
+
+DECL_LINK(CheckHdl, weld::ToggleButton&, void);
+DECL_LINK(KeyReleaseHdl, const KeyEvent&, bool);
+
+OfaAutoCompleteTabPage(TabPageParent pParent, const SfxItemSet& rSet);
 public:
 virtual ~OfaAutoCompleteTabPage() override;
-virtual void dispose() override;
-static VclPtr  Create( TabPageParent pParent,
-const SfxItemSet* rAttrSet);
+static VclPtr Create(TabPageParent pParent,
+ const SfxItemSet* rAttrSet);
 
 virtual boolFillItemSet( SfxItemSet* rSet ) override;
 virtual voidReset( const SfxItemSet* rSet ) override;
 virtual voidActivatePage( const SfxItemSet& ) override;
 
 void CopyToClipboard() const;
-DECL_LINK(DeleteHdl, Button*, void);
+DECL_LINK(DeleteHdl, weld::Button&, void);
 };
 
 // class OfaSmartTagOptionsTabPage 
-
diff --git a/cui/source/tabpages/autocdlg.cxx b/cui/source/tabpages/autocdlg.cxx
index 59aa8353b10d..e39a9cba42d1 100644
--- a/cui/source/tabpages/autocdlg.cxx
+++ b/cui/source/tabpages/autocdlg.cxx
@@ -2109,38 +2109,36 @@ OUString OfaQuoteTabPage::ChangeStringExt_Impl( 
sal_UCS4 cChar )
 return aOUStr;
 }
 
-OfaAutoCompleteTabPage::OfaAutoCompleteTabPage(vcl::Window* pParent,
+OfaAutoCompleteTabPage::OfaAutoCompleteTabPage(TabPageParent pParent,
 const SfxItemSet& rSet)
-: SfxTabPage(pParent, "WordCompletionPage",
-"cui/ui/wordcompletionpage.ui", )
+: SfxTabPage(pParent, "cui/ui/wordcompletionpage.ui",
+ "WordCompletionPage", )
 , m_pAutoCompleteList(nullptr)
 , m_nAutoCmpltListCnt(0)
+, m_xCBActiv(m_xBuilder->weld_check_button("enablewordcomplete"))
+, m_xCBAppendSpace(m_xBuilder->weld_check_button("appendspace"))
+, m_xCBAsTip(m_xBuilder->weld_check_button("showastip"))
+, m_xCBCollect(m_xBuilder->weld_check_button("collectwords"))
+, m_xCBRemoveList(m_xBuilder->weld_check_button("whenclosing"))

[Libreoffice-commits] core.git: solenv/clang-format

2018-12-01 Thread Libreoffice Gerrit user
 solenv/clang-format/blacklist |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 4e0be0c35024fc35d4815d2665e12f9ebf241025
Author: Jens Carl 
AuthorDate: Sat Dec 1 18:32:59 2018 +
Commit: Jens Carl 
CommitDate: Sat Dec 1 22:24:44 2018 +0100

sc: turn on clang-format for scarealinksobj

I accidentally formatted the file with commit
20533db9eaafac18b02c81c64b583c76a5ca66a6, so it can be enabled.

Change-Id: I36fb6e9107f4f5b2ac708890184bb4981a703474
Reviewed-on: https://gerrit.libreoffice.org/64401
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/solenv/clang-format/blacklist b/solenv/clang-format/blacklist
index 4693499b7f0e..92aab89287bf 100644
--- a/solenv/clang-format/blacklist
+++ b/solenv/clang-format/blacklist
@@ -10141,7 +10141,6 @@ sc/qa/extras/scannotationobj.cxx
 sc/qa/extras/scannotationshapeobj.cxx
 sc/qa/extras/scannotationsobj.cxx
 sc/qa/extras/scarealinkobj.cxx
-sc/qa/extras/scarealinksobj.cxx
 sc/qa/extras/sccellcursorobj.cxx
 sc/qa/extras/sccellobj.cxx
 sc/qa/extras/sccellrangeobj.cxx
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 121850] New: Crash in: RIC655c.DLL

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121850

Bug ID: 121850
   Summary: Crash in: RIC655c.DLL
   Product: LibreOffice
   Version: 6.1.3.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sanchezsol...@gmail.com

This bug was filed from the crash reporting server and is
br-8e2d54a7-9501-43ad-a818-fc3a86474a69.
=

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121849] New: Crash in: RIC655c.DLL

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121849

Bug ID: 121849
   Summary: Crash in: RIC655c.DLL
   Product: LibreOffice
   Version: 6.1.3.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sanchezsol...@gmail.com

This bug was filed from the crash reporting server and is
br-8e2d54a7-9501-43ad-a818-fc3a86474a69.
=

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120703] Bugs found by PVS-Studio static analyzer

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120703

--- Comment #132 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/abc84c73502210603926ee8083a7c37bcceebaa4%5E%21

tdf#120703 PVS: do not split a band that is just one pixel high

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/source

2018-12-01 Thread Libreoffice Gerrit user
 vcl/source/gdi/region.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit abc84c73502210603926ee8083a7c37bcceebaa4
Author: Mike Kaganski 
AuthorDate: Sat Dec 1 21:12:20 2018 +0300
Commit: Mike Kaganski 
CommitDate: Sat Dec 1 21:26:52 2018 +0100

tdf#120703 PVS: do not split a band that is just one pixel high

This is what mentioned in the comment to the line, so implement just that

V560 A part of conditional expression is always true:
 pBand->mnYTop < pBand->mnYBottom.

Change-Id: I1027a30a07d49940a31838deddb457b6379eb887
Reviewed-on: https://gerrit.libreoffice.org/64399
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/vcl/source/gdi/region.cxx b/vcl/source/gdi/region.cxx
index b363cd019b40..ce963a977dbc 100644
--- a/vcl/source/gdi/region.cxx
+++ b/vcl/source/gdi/region.cxx
@@ -146,7 +146,7 @@ namespace
// this allows the lowest pixel of the band to be split 
off
 && pBand->mnYBottom>=nTop
// do not split a band that is just one pixel high
-&& pBand->mnYTopmnYBottom)
+&& pBand->mnYTopmnYBottom-1)
 {
 // Split the top band.
 pTopBand = pBand->SplitBand(nTop);
@@ -163,7 +163,7 @@ namespace
// prevent splitting off a band that is 0 pixel high
 && pBand->mnYBottom>nBottom
// do not split a band that is just one pixel high
-&& pBand->mnYTopmnYBottom)
+&& pBand->mnYTopmnYBottom-1)
 {
 // Split the bottom band.
 pBand->SplitBand(nBottom+1);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 121465] Impossible to insert a cross reference without the separators

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121465

--- Comment #9 from estesprit...@yahoo.com ---
Looking at
https://github.com/LibreOffice/core/blob/542d17d9384cced62db6bcfa45a5f44316409edc/sw/source/core/fields/reffld.cxx#L836,
it seems "context" here is not linked to separators but to the hierarchy of the
referenced title.

If someone can confirm this, i'll mark this as "Not a Bug" and create a feature
request to allow for numbers to be displayed without the separators.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: include/test sc/qa test/source

2018-12-01 Thread Libreoffice Gerrit user
 include/test/sheet/xsheetannotations.hxx |9 ++---
 sc/qa/extras/scannotationsobj.cxx|7 ---
 test/source/sheet/xsheetannotations.cxx  |2 +-
 3 files changed, 11 insertions(+), 7 deletions(-)

New commits:
commit 68e841326a87004968b07b3ae522a0c312519f25
Author: Jens Carl 
AuthorDate: Sat Dec 1 19:01:51 2018 +
Commit: Jens Carl 
CommitDate: Sat Dec 1 21:17:40 2018 +0100

Rename testGetByIndex to testIndex

Rename testGetByIndex to testIndex of sheet::XSheetAnnotations test
cases so it won't collide with testGetByIndex of
container::XIndexAccess.

Change-Id: Ic48ffe954c9f4f00b68066ad5d0d2df89cc4dfd7
Reviewed-on: https://gerrit.libreoffice.org/64402
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/include/test/sheet/xsheetannotations.hxx 
b/include/test/sheet/xsheetannotations.hxx
index ff44f655e007..d1cd65ea4b09 100644
--- a/include/test/sheet/xsheetannotations.hxx
+++ b/include/test/sheet/xsheetannotations.hxx
@@ -11,6 +11,10 @@
 #define INCLUDED_TEST_SHEET_XSHEETANNOTATIONS_HXX
 
 #include 
+#include 
+
+#include 
+
 #include 
 
 namespace apitest {
@@ -19,17 +23,16 @@ class OOO_DLLPUBLIC_TEST XSheetAnnotations
 {
 public:
 virtual css::uno::Reference< css::uno::XInterface > init() = 0;
+virtual css::uno::Reference< css::sheet::XSheetAnnotations> 
getAnnotations(long nIndex) = 0;
 
 // XSheetAnnotations
-void testGetByIndex();
+void testIndex();
 void testInsertNew();
 void testRemoveByIndex();
 void testCount();
 
 protected:
 ~XSheetAnnotations() {}
-
-virtual css::uno::Reference< css::sheet::XSheetAnnotations> 
getAnnotations(long nIndex) = 0;
 };
 
 }
diff --git a/sc/qa/extras/scannotationsobj.cxx 
b/sc/qa/extras/scannotationsobj.cxx
index cf53b8ae3d3d..a80c35e35a18 100644
--- a/sc/qa/extras/scannotationsobj.cxx
+++ b/sc/qa/extras/scannotationsobj.cxx
@@ -11,9 +11,10 @@
 #include 
 #include 
 
+#include 
+#include 
 #include 
 #include 
-
 #include 
 
 using namespace css;
@@ -39,10 +40,10 @@ public:
 CPPUNIT_TEST(testCreateEnumeration);
 
 // XSheetAnnotations
+CPPUNIT_TEST(testCount);
+CPPUNIT_TEST(testIndex);
 CPPUNIT_TEST(testInsertNew);
 CPPUNIT_TEST(testRemoveByIndex);
-CPPUNIT_TEST(testCount);
-CPPUNIT_TEST(testGetByIndex);
 
 CPPUNIT_TEST_SUITE_END();
 
diff --git a/test/source/sheet/xsheetannotations.cxx 
b/test/source/sheet/xsheetannotations.cxx
index 3df329f5352e..c892642e0bf1 100644
--- a/test/source/sheet/xsheetannotations.cxx
+++ b/test/source/sheet/xsheetannotations.cxx
@@ -157,7 +157,7 @@ void XSheetAnnotations::testRemoveByIndex()
 OUString("an inserted annotation 1"), aPreviousString);
 }
 
-void XSheetAnnotations::testGetByIndex()
+void XSheetAnnotations::testIndex()
 {
 
 // testing #fdo80551 - getByIndex not on the first sheet
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 121848] New: Assistant cannot select the whole column on other sheet using NB.SI (countif) and somme.si (sumif)

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121848

Bug ID: 121848
   Summary: Assistant cannot select the whole column on other
sheet using NB.SI (countif) and somme.si (sumif)
   Product: LibreOffice
   Version: 6.0.7.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: hug.charlo...@gmail.com

Description:
When using assistant for NB.SI (count if) function on one sheet, if I want to
select a whole column in another sheet, it doesn't work.

Same problem with SOMME.SI (sum if)

Steps to Reproduce:
1.open assistant
2.select NB.SI or SOMME.SI function
3.try to select a whole column in another sheet
4.assistant can not display "sheet2.A:A" for instance

Actual Results:
assistant does not display the selected column in the selected sheet

Expected Results:
nothing is displayed


Reproducible: Always


User Profile Reset: No



Additional Info:
assistant displays the name of the selected column and sheet

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121810] Crash in: libgobject-2.0.so.0.5600.3 when selecting more on error dialog

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121810

Caolán McNamara  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121631] Sorbian string is automatically converted into lower case

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121631

--- Comment #1 from mil...@sorbzilla.de ---
Hi,

this bug can be marked as resolved. The issue was caused by a problem in the
user profile. I renamed the old profile that LO can create a new one. So this
bug is fixed now.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121630] Add OS strings to LibreOffice translation

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121630

--- Comment #6 from mil...@sorbzilla.de ---
Hi,

this bug can be marked as resolved. The issue was caused by a problem in the
user profile. I renamed the old profile that LO can create a new one. So this
bug is fixed now.

This bug can be marked as resolved.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121847] New: IMPRESS: slide marking on side pane lost when switching to notes view

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121847

Bug ID: 121847
   Summary: IMPRESS: slide marking on side pane lost when
switching to notes view
   Product: LibreOffice
   Version: 6.0.6.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mathemati...@gmx.de

Description:
When switching from "normal view" to "notes view" the marking of the slide on
the left pane disappears.

This behavior has been disturbing my for years now. Because this is a normal
workflow for me to change some notes in my slides (needing the notes view for
this) and then change some content of the slides (needing the normal view for
this). And each time I need to figure out again on what slide I was before I
can proceed with my work.  

I know there is a workaround (search the tiny page number display on my slide
even in the notes view) and then click onto the icon with this number at the
left pane. But this is bad "usability". I would be happy if this (very small)
feature could be improved in some future LibreOffice release.

Steps to Reproduce:
Here is how to reproduce it:
* In the "View" (german: "Ansicht") menu of Impress, turn on the option "view
pane visible" (german: "Symbolleiste Ansicht")
* open a presentation document with several slides (not just one), I assume
that it will be opened in "normal view" mode (where you can edit single slides)
* use the left side pane (where all slides are shown with a small icon) to jump
to a differen slide, let's slide number 7. The icon of this slide 7 will then
be marked (underlayed with a color) in this side pane.
* Now use the Icon "notes view" on the top, to switch to the "notes view"
(where you can edit the notes of the slides)
* result: the marking of slide 7 on the left side pane is gone :(

Actual Results:
Slide icon (on left pane) not marked any more

Expected Results:
Slide icon (on left pane) marked as before in normal view


Reproducible: Always


User Profile Reset: No



Additional Info:
Slide icon (on left pane) should stay marked in the "notes view" as it has been
before in "normal view"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - helpcontent2

2018-12-01 Thread Libreoffice Gerrit user
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7c95a895983b93d7eff7ecd3eaa07f2830e15e94
Author: Mike Kaganski 
AuthorDate: Fri Nov 30 07:16:19 2018 +0100
Commit: Gerrit Code Review 
CommitDate: Sat Dec 1 20:35:12 2018 +0100

Update git submodules

* Update helpcontent2 from branch 'libreoffice-6-2'
  - REGEX: correct ICU URL to use http, not https (which seems unavailable)

Change-Id: Iaeed0d81dc88418c2bffab730fd682ca8cb3b101
Reviewed-on: https://gerrit.libreoffice.org/64313
Tested-by: Jenkins
Reviewed-by: Eike Rathke 
(cherry picked from commit f9566b6655aad0408724c4df65178f43c3e3d4f8)
Reviewed-on: https://gerrit.libreoffice.org/64400

diff --git a/helpcontent2 b/helpcontent2
index ee142eec43e7..0afeaf5e8ace 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit ee142eec43e73bac7377380c3c72c31600a20355
+Subproject commit 0afeaf5e8ace28ccb5365ffdc763197f8084fb50
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] help.git: Branch 'libreoffice-6-2' - source/text

2018-12-01 Thread Libreoffice Gerrit user
 source/text/scalc/01/func_regex.xhp |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 0afeaf5e8ace28ccb5365ffdc763197f8084fb50
Author: Mike Kaganski 
AuthorDate: Fri Nov 30 07:16:19 2018 +0100
Commit: Eike Rathke 
CommitDate: Sat Dec 1 20:35:12 2018 +0100

REGEX: correct ICU URL to use http, not https (which seems unavailable)

Change-Id: Iaeed0d81dc88418c2bffab730fd682ca8cb3b101
Reviewed-on: https://gerrit.libreoffice.org/64313
Tested-by: Jenkins
Reviewed-by: Eike Rathke 
(cherry picked from commit f9566b6655aad0408724c4df65178f43c3e3d4f8)
Reviewed-on: https://gerrit.libreoffice.org/64400

diff --git a/source/text/scalc/01/func_regex.xhp 
b/source/text/scalc/01/func_regex.xhp
index bd08223d5..c733abc95 100644
--- a/source/text/scalc/01/func_regex.xhp
+++ b/source/text/scalc/01/func_regex.xhp
@@ -29,7 +29,7 @@
 
 REGEX( 
Text ; Expression [ ; [ Replacement ] [ ; Flags|Occurrence ] ] )
 Text: A text or reference to a cell where the 
regular expression is to be applied.
-Expression: A text representing the regular 
expression, using https://userguide.icu-project.org/strings/regexp; 
name="ICU REGEXP">ICU regular expressions. If there is no match and 
Replacement is not given, #N/A is returned.
+Expression: A text representing the regular 
expression, using http://userguide.icu-project.org/strings/regexp; 
name="ICU REGEXP">ICU regular expressions. If there is no match and 
Replacement is not given, #N/A is returned.
 Replacement: Optional. The replacement text and 
references to capture groups. If there is no match, Text is 
returned unmodified.
 Flags: Optional. "g" replaces all matches of 
Expression in Text, not extracted. If there is no 
match, Text is returned unmodified.
 Occurrence: Optional. Number to indicate which 
match of Expression in Text is to be extracted or 
replaced. If there is no match and Replacement is not given, #N/A 
is returned. If there is no match and Replacement is given, 
Text is returned unmodified. If Occurrence is 0, 
Text is returned unmodified.
@@ -41,7 +41,7 @@
 =REGEX("axbxcxd";"(.)x";"$1y";2)  
returns "axbycxd", the second match of "(.)x" (i.e. "bx") replaced with the 
captured group of one character (i.e. "b") followed by "y".
 
 List of regular expressions
-https://userguide.icu-project.org/strings/regexp; 
name="ICU REGEXP">ICU regular expressions
+http://userguide.icu-project.org/strings/regexp; 
name="ICU REGEXP">ICU regular expressions
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 103560] formula: vec or widevec does not work over nabla

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103560

hardy  changed:

   What|Removed |Added

 Resolution|INSUFFICIENTDATA|WORKSFORME

--- Comment #8 from hardy  ---
This now works fine for me, using a newer version of LibreOffice (6.0.6.2 under
Linux).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121841] Missing menu items in LO 6.2.0.0 beta1

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121841

--- Comment #9 from mil...@sorbzilla.de ---
Hi V Stuart Foote,

thank you for your help.

The issue is resolved, it was an "old heritage" in the user profile. In fact, I
have already had this issue earlier. I renamed the user profile, LO created a
new one and so LO displays all menu items correctly now.

This bug can be marked as resolved.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/headless

2018-12-01 Thread Libreoffice Gerrit user
 vcl/headless/svpgdi.cxx |   74 +---
 1 file changed, 58 insertions(+), 16 deletions(-)

New commits:
commit da0afa5ac2b69bcb4b19ec4dd096d7b3f1e50fc9
Author: Caolán McNamara 
AuthorDate: Fri Nov 30 17:03:11 2018 +
Commit: Caolán McNamara 
CommitDate: Sat Dec 1 20:11:05 2018 +0100

Related: tdf#121721 use premultiply unpremultiply tables

for tdf#121721 this brings the time down between pressing F5 and seeing the
image from 4 seconds to 1.4 seconds

Change-Id: I8e7f15e5126218b040e96f9143827ff788b4fb51
Reviewed-on: https://gerrit.libreoffice.org/64111
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index 0ae7cbd6ba11..ec01ec520a86 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -1641,7 +1641,7 @@ void SvpSalGraphics::drawBitmap( const SalTwoRect& rTR,
 
 static sal_uInt8 unpremultiply(sal_uInt8 c, sal_uInt8 a)
 {
-return (a > 0) ? (c * 255 + a / 2) / a : 0;
+return (a == 0) ? 0 : (c * 255 + a / 2) / a;
 }
 
 static sal_uInt8 premultiply(sal_uInt8 c, sal_uInt8 a)
@@ -1649,6 +1649,40 @@ static sal_uInt8 premultiply(sal_uInt8 c, sal_uInt8 a)
 return (c * a + 127) / 255;
 }
 
+typedef sal_uInt8 (*lookup_table)[256];
+
+static lookup_table get_unpremultiply_table()
+{
+static bool inited;
+static sal_uInt8 unpremultiply_table[256][256];
+
+if (!inited)
+{
+for (int a = 0; a < 256; ++a)
+for (int c = 0; c < 256; ++c)
+unpremultiply_table[a][c] = unpremultiply(c, a);
+inited = true;
+}
+
+return unpremultiply_table;
+}
+
+static lookup_table get_premultiply_table()
+{
+static bool inited;
+static sal_uInt8 premultiply_table[256][256];
+
+if (!inited)
+{
+for (int a = 0; a < 256; ++a)
+for (int c = 0; c < 256; ++c)
+premultiply_table[a][c] = premultiply(c, a);
+inited = true;
+}
+
+return premultiply_table;
+}
+
 void SvpSalGraphics::drawMask( const SalTwoRect& rTR,
const SalBitmap& rSalBitmap,
Color nMaskColor )
@@ -1663,15 +1697,17 @@ void SvpSalGraphics::drawMask( const SalTwoRect& rTR,
 }
 sal_Int32 nStride;
 unsigned char *mask_data = aSurface.getBits(nStride);
+lookup_table unpremultiply_table = get_unpremultiply_table();
 for (long y = rTR.mnSrcY ; y < rTR.mnSrcY + rTR.mnSrcHeight; ++y)
 {
 unsigned char *row = mask_data + (nStride*y);
 unsigned char *data = row + (rTR.mnSrcX * 4);
 for (long x = rTR.mnSrcX; x < rTR.mnSrcX + rTR.mnSrcWidth; ++x)
 {
-sal_uInt8 b = unpremultiply(data[SVP_CAIRO_BLUE], 
data[SVP_CAIRO_ALPHA]);
-sal_uInt8 g = unpremultiply(data[SVP_CAIRO_GREEN], 
data[SVP_CAIRO_ALPHA]);
-sal_uInt8 r = unpremultiply(data[SVP_CAIRO_RED], 
data[SVP_CAIRO_ALPHA]);
+sal_uInt8 a = data[SVP_CAIRO_ALPHA];
+sal_uInt8 b = unpremultiply_table[a][data[SVP_CAIRO_BLUE]];
+sal_uInt8 g = unpremultiply_table[a][data[SVP_CAIRO_GREEN]];
+sal_uInt8 r = unpremultiply_table[a][data[SVP_CAIRO_RED]];
 if (r == 0 && g == 0 && b == 0)
 {
 data[0] = nMaskColor.GetBlue();
@@ -1769,10 +1805,12 @@ Color SvpSalGraphics::getPixel( long nX, long nY )
 cairo_destroy(cr);
 
 cairo_surface_flush(target);
+lookup_table unpremultiply_table = get_unpremultiply_table();
 unsigned char *data = cairo_image_surface_get_data(target);
-sal_uInt8 b = unpremultiply(data[SVP_CAIRO_BLUE], data[SVP_CAIRO_ALPHA]);
-sal_uInt8 g = unpremultiply(data[SVP_CAIRO_GREEN], data[SVP_CAIRO_ALPHA]);
-sal_uInt8 r = unpremultiply(data[SVP_CAIRO_RED], data[SVP_CAIRO_ALPHA]);
+sal_uInt8 a = data[SVP_CAIRO_ALPHA];
+sal_uInt8 b = unpremultiply_table[a][data[SVP_CAIRO_BLUE]];
+sal_uInt8 g = unpremultiply_table[a][data[SVP_CAIRO_GREEN]];
+sal_uInt8 r = unpremultiply_table[a][data[SVP_CAIRO_RED]];
 Color nRet = Color(r, g, b);
 
 cairo_surface_destroy(target);
@@ -2101,6 +2139,8 @@ void SvpSalGraphics::releaseCairoContext(cairo_t* cr, 
bool bXorModeAllowed, cons
 sal_Int32 nUnscaledExtentsRight = nExtentsRight * m_fScale;
 sal_Int32 nUnscaledExtentsTop = nExtentsTop * m_fScale;
 sal_Int32 nUnscaledExtentsBottom = nExtentsBottom * m_fScale;
+lookup_table unpremultiply_table = get_unpremultiply_table();
+lookup_table premultiply_table = get_premultiply_table();
 for (sal_Int32 y = nUnscaledExtentsTop; y < nUnscaledExtentsBottom; 
++y)
 {
 unsigned char *true_row = target_surface_data + (nStride*y);
@@ -2109,15 +2149,17 @@ void SvpSalGraphics::releaseCairoContext(cairo_t* cr, 
bool bXorModeAllowed, cons
 unsigned char *xor_data = xor_row + 

[Libreoffice-bugs] [Bug 121721] GTK3: super slow xor mode used for slideshow gradients

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121721

--- Comment #6 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/da0afa5ac2b69bcb4b19ec4dd096d7b3f1e50fc9%5E%21

Related: tdf#121721 use premultiply unpremultiply tables

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121721] GTK3: super slow xor mode used for slideshow gradients

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121721

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - extras/source solenv/bin sw/source sw/uiconfig vcl/source

2018-12-01 Thread Libreoffice Gerrit user
 extras/source/glade/libreoffice-catalog.xml.in |6 
 solenv/bin/native-code.py  |2 
 sw/source/ui/misc/glosbib.cxx  |  301 +++--
 sw/source/ui/misc/glossary.cxx |6 
 sw/source/uibase/inc/glosbib.hxx   |   79 ++
 sw/uiconfig/swriter/ui/editcategories.ui   |  124 +++---
 vcl/source/app/salvtables.cxx  |7 
 7 files changed, 266 insertions(+), 259 deletions(-)

New commits:
commit 85a7a14a1b824ae5ffed6f7d3965020c9bfcfeff
Author: Caolán McNamara 
AuthorDate: Thu Nov 29 23:49:29 2018 +
Commit: Caolán McNamara 
CommitDate: Sat Dec 1 20:09:39 2018 +0100

weld SwGlossaryGroupDlg

Change-Id: I142123b474e0e35f6da375977e33d40e0ad39054
Reviewed-on: https://gerrit.libreoffice.org/64395
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/extras/source/glade/libreoffice-catalog.xml.in 
b/extras/source/glade/libreoffice-catalog.xml.in
index 89c1348c2c1a..47505da352aa 100644
--- a/extras/source/glade/libreoffice-catalog.xml.in
+++ b/extras/source/glade/libreoffice-catalog.xml.in
@@ -256,18 +256,12 @@
 
-
 
 
-
 
diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py
index 94e362bf45ca..38207d73d4b3 100755
--- a/solenv/bin/native-code.py
+++ b/solenv/bin/native-code.py
@@ -420,7 +420,6 @@ custom_widgets = [
 'EmojiView',
 'ExtBoxWithBtns',
 'ExtensionBox',
-'FEdit',
 'FontNameBox',
 'FontSizeBox',
 'FontStyleBox',
@@ -513,7 +512,6 @@ custom_widgets = [
 'SwCaptionPreview',
 'SwFieldRefTreeListBox',
 'SwGlTreeListBox',
-'SwGlossaryGroupTLB',
 'SwIdxTreeListBox',
 'SwMarkPreview',
 'SwNavHelpToolBox',
diff --git a/sw/source/ui/misc/glosbib.cxx b/sw/source/ui/misc/glosbib.cxx
index 3e8d9a3f7bde..82febac648ed 100644
--- a/sw/source/ui/misc/glosbib.cxx
+++ b/sw/source/ui/misc/glosbib.cxx
@@ -44,53 +44,55 @@
 
 #define RENAME_TOKEN_DELIM  u'\x0001'
 
-SwGlossaryGroupDlg::SwGlossaryGroupDlg(vcl::Window * pParent,
+SwGlossaryGroupDlg::SwGlossaryGroupDlg(weld::Window * pParent,
 std::vector const& rPathArr, SwGlossaryHdl *pHdl)
-: SvxStandardDialog(pParent, "EditCategoriesDialog",
-"modules/swriter/ui/editcategories.ui")
+: SfxDialogController(pParent, "modules/swriter/ui/editcategories.ui",
+  "EditCategoriesDialog")
+, m_pParent(pParent)
 , pGlosHdl(pHdl)
+, m_xNameED(m_xBuilder->weld_entry("name"))
+, m_xPathLB(m_xBuilder->weld_combo_box("pathlb"))
+, m_xGroupTLB(m_xBuilder->weld_tree_view("group"))
+, m_xNewPB(m_xBuilder->weld_button("new"))
+, m_xDelPB(m_xBuilder->weld_button("delete"))
+, m_xRenamePB(m_xBuilder->weld_button("rename"))
 {
-get(m_pPathLB, "pathlb");
-get(m_pNewPB, "new");
-get(m_pDelPB, "delete");
-get(m_pRenamePB, "rename");
-get(m_pNameED, "name");
-get(m_pGroupTLB, "group");
-
-const int nAppFontUnits = 130;
-long nWidth = LogicToPixel(Size(nAppFontUnits, 0), 
MapMode(MapUnit::MapAppFont)).Width();
-m_pPathLB->set_width_request(nWidth);
+int nWidth = m_xGroupTLB->get_approximate_digit_width() * 34;
+m_xPathLB->set_size_request(nWidth, -1);
 //just has to be something small, real size will be available space
-m_pGroupTLB->set_width_request(nWidth);
-m_pGroupTLB->set_height_request(GetTextHeight() * 10);
+m_xGroupTLB->set_size_request(nWidth, m_xGroupTLB->get_height_rows(10));
 
-long nTabs[] = {  0, nAppFontUnits };
+std::vector aWidths;
+aWidths.push_back(nWidth);
+m_xGroupTLB->set_column_fixed_widths(aWidths);
+m_xGroupTLB->connect_changed(LINK(this, SwGlossaryGroupDlg, SelectHdl));
 
-m_pGroupTLB->SetTabs( SAL_N_ELEMENTS(nTabs), nTabs );
-m_pGroupTLB->SetSelectHdl(LINK(this, SwGlossaryGroupDlg, SelectHdl));
-m_pGroupTLB->GetModel()->SetSortMode(SortAscending);
-m_pNewPB->SetClickHdl(LINK(this, SwGlossaryGroupDlg, NewHdl));
-m_pDelPB->SetClickHdl(LINK(this, SwGlossaryGroupDlg, DeleteHdl));
-m_pNameED->SetModifyHdl(LINK(this, SwGlossaryGroupDlg, ModifyHdl));
-m_pPathLB->SetSelectHdl(LINK(this, SwGlossaryGroupDlg, ModifyListBoxHdl));
-m_pRenamePB->SetClickHdl(LINK(this, SwGlossaryGroupDlg, RenameHdl));
+m_xNewPB->connect_clicked(LINK(this, SwGlossaryGroupDlg, NewHdl));
+m_xDelPB->connect_clicked(LINK(this, SwGlossaryGroupDlg, DeleteHdl));
+m_xNameED->connect_changed(LINK(this, SwGlossaryGroupDlg, ModifyHdl));
+m_xNameED->connect_insert_text(LINK(this, SwGlossaryGroupDlg, 
EditInsertTextHdl));
+m_xPathLB->connect_changed(LINK(this, SwGlossaryGroupDlg, 
ModifyListBoxHdl));
+m_xRenamePB->connect_clicked(LINK(this, SwGlossaryGroupDlg, RenameHdl));
+
+m_xNameED->connect_size_allocate(LINK(this, SwGlossaryGroupDlg, 
EntrySizeAllocHdl));
+m_xPathLB->connect_size_allocate(LINK(this, SwGlossaryGroupDlg, 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - 2 commits - cui/source cui/uiconfig extras/source include/vcl solenv/bin solenv/sanitizers vcl/source vcl/unx

2018-12-01 Thread Libreoffice Gerrit user
 cui/source/inc/autocdlg.hxx|   54 ++
 cui/source/tabpages/autocdlg.cxx   |  223 ++---
 cui/uiconfig/ui/acorexceptpage.ui  |1 
 cui/uiconfig/ui/wordcompletionpage.ui  |   56 +-
 extras/source/glade/libreoffice-catalog.xml.in |3 
 include/vcl/weld.hxx   |   22 +-
 solenv/bin/native-code.py  |1 
 solenv/sanitizers/ui/cui.suppr |3 
 vcl/source/app/salvtables.cxx  |   89 +++--
 vcl/source/control/button.cxx  |3 
 vcl/source/treelist/svimpbox.cxx   |9 -
 vcl/unx/gtk3/gtk3gtkinst.cxx   |   93 +-
 12 files changed, 293 insertions(+), 264 deletions(-)

New commits:
commit 8c50907f1a91ad1d25087f970ff376f67e7ad906
Author: Caolán McNamara 
AuthorDate: Thu Nov 29 20:11:34 2018 +
Commit: Caolán McNamara 
CommitDate: Sat Dec 1 20:09:26 2018 +0100

weld OfaAutoCompleteTabPage

Change-Id: I84f051fd1dc127663fd510c81addb0fd0cdc2c26
Reviewed-on: https://gerrit.libreoffice.org/64393
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/source/inc/autocdlg.hxx b/cui/source/inc/autocdlg.hxx
index b396ad89e762..81044a633eab 100644
--- a/cui/source/inc/autocdlg.hxx
+++ b/cui/source/inc/autocdlg.hxx
@@ -382,55 +382,39 @@ public:
 class OfaAutoCompleteTabPage : public SfxTabPage
 {
 friend class VclPtr;
-public:
-class AutoCompleteMultiListBox : public MultiListBox
-{
-VclPtr m_pPage;
-public:
-AutoCompleteMultiListBox(vcl::Window *pParent, WinBits nBits)
-: MultiListBox(pParent, nBits)
-, m_pPage(nullptr)
-{
-}
-virtual ~AutoCompleteMultiListBox() override;
-virtual void dispose() override;
-void SetPage(OfaAutoCompleteTabPage *pPage) { m_pPage = pPage; }
-virtual bool PreNotify( NotifyEvent& rNEvt ) override;
-};
-
 private:
 using TabPage::ActivatePage;
-VclPtr   m_pCBActiv; ///   m_pCBAppendSpace;///   m_pCBAsTip; ///   m_pCBCollect;///   m_pCBRemoveList;///<...save the list for later 
use...
-
-VclPtrm_pDCBExpandKey;
-VclPtr   m_pNFMinWordlen;
-VclPtr   m_pNFMaxEntries;
-VclPtr m_pLBEntries;
-VclPtr m_pPBEntries;
 editeng::SortedAutoCompleteStrings* m_pAutoCompleteList;
 sal_uInt16  m_nAutoCmpltListCnt;
 
-DECL_LINK( CheckHdl, CheckBox&, void );
+std::unique_ptr m_xCBActiv; /// m_xCBAppendSpace;/// m_xCBAsTip; /// m_xCBCollect;/// m_xCBRemoveList;///<...save the list 
for later use...
 
-OfaAutoCompleteTabPage( vcl::Window* pParent,
-const SfxItemSet& rSet );
+std::unique_ptr m_xDCBExpandKey;
+std::unique_ptr m_xNFMinWordlen;
+std::unique_ptr m_xNFMaxEntries;
+std::unique_ptr m_xLBEntries;
+std::unique_ptr m_xPBEntries;
+
+DECL_LINK(CheckHdl, weld::ToggleButton&, void);
+DECL_LINK(KeyReleaseHdl, const KeyEvent&, bool);
+
+OfaAutoCompleteTabPage(TabPageParent pParent, const SfxItemSet& rSet);
 public:
 virtual ~OfaAutoCompleteTabPage() override;
-virtual void dispose() override;
-static VclPtr  Create( TabPageParent pParent,
-const SfxItemSet* rAttrSet);
+static VclPtr Create(TabPageParent pParent,
+ const SfxItemSet* rAttrSet);
 
 virtual boolFillItemSet( SfxItemSet* rSet ) override;
 virtual voidReset( const SfxItemSet* rSet ) override;
 virtual voidActivatePage( const SfxItemSet& ) override;
 
 void CopyToClipboard() const;
-DECL_LINK(DeleteHdl, Button*, void);
+DECL_LINK(DeleteHdl, weld::Button&, void);
 };
 
 // class OfaSmartTagOptionsTabPage 
-
diff --git a/cui/source/tabpages/autocdlg.cxx b/cui/source/tabpages/autocdlg.cxx
index caded93d8f43..9adb259e66e1 100644
--- a/cui/source/tabpages/autocdlg.cxx
+++ b/cui/source/tabpages/autocdlg.cxx
@@ -2109,38 +2109,36 @@ OUString OfaQuoteTabPage::ChangeStringExt_Impl( 
sal_UCS4 cChar )
 return aOUStr;
 }
 
-OfaAutoCompleteTabPage::OfaAutoCompleteTabPage(vcl::Window* pParent,
+OfaAutoCompleteTabPage::OfaAutoCompleteTabPage(TabPageParent pParent,
 const SfxItemSet& rSet)
-: SfxTabPage(pParent, "WordCompletionPage",
-"cui/ui/wordcompletionpage.ui", )
+: SfxTabPage(pParent, "cui/ui/wordcompletionpage.ui",
+ "WordCompletionPage", )
 , m_pAutoCompleteList(nullptr)
 , m_nAutoCmpltListCnt(0)
+, m_xCBActiv(m_xBuilder->weld_check_button("enablewordcomplete"))
+, m_xCBAppendSpace(m_xBuilder->weld_check_button("appendspace"))
+, m_xCBAsTip(m_xBuilder->weld_check_button("showastip"))
+, m_xCBCollect(m_xBuilder->weld_check_button("collectwords"))
+, 

[Libreoffice-bugs] [Bug 39468] translate German comments, removing redundant ones

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=39468

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.3.0 target:5.4.0   |target:5.3.0 target:5.4.0
   |target:5.5.0 target:6.0.0   |target:5.5.0 target:6.0.0
   |target:6.2.0|target:6.2.0 target:6.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: helpcontent2

2018-12-01 Thread Libreoffice Gerrit user
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f772860a866fd88286c9659f033f57aa9d850b1f
Author: Mike Kaganski 
AuthorDate: Fri Nov 30 07:16:19 2018 +0100
Commit: Gerrit Code Review 
CommitDate: Sat Dec 1 19:24:56 2018 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  - REGEX: correct ICU URL to use http, not https (which seems unavailable)

Change-Id: Iaeed0d81dc88418c2bffab730fd682ca8cb3b101
Reviewed-on: https://gerrit.libreoffice.org/64313
Tested-by: Jenkins
Reviewed-by: Eike Rathke 

diff --git a/helpcontent2 b/helpcontent2
index d3bee2ee2777..f9566b6655aa 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit d3bee2ee29cfd6432207acfc8059e5d7c43e
+Subproject commit f9566b6655aad0408724c4df65178f43c3e3d4f8
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] help.git: source/text

2018-12-01 Thread Libreoffice Gerrit user
 source/text/scalc/01/func_regex.xhp |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit f9566b6655aad0408724c4df65178f43c3e3d4f8
Author: Mike Kaganski 
AuthorDate: Fri Nov 30 07:16:19 2018 +0100
Commit: Eike Rathke 
CommitDate: Sat Dec 1 19:24:56 2018 +0100

REGEX: correct ICU URL to use http, not https (which seems unavailable)

Change-Id: Iaeed0d81dc88418c2bffab730fd682ca8cb3b101
Reviewed-on: https://gerrit.libreoffice.org/64313
Tested-by: Jenkins
Reviewed-by: Eike Rathke 

diff --git a/source/text/scalc/01/func_regex.xhp 
b/source/text/scalc/01/func_regex.xhp
index bd08223d5..c733abc95 100644
--- a/source/text/scalc/01/func_regex.xhp
+++ b/source/text/scalc/01/func_regex.xhp
@@ -29,7 +29,7 @@
 
 REGEX( 
Text ; Expression [ ; [ Replacement ] [ ; Flags|Occurrence ] ] )
 Text: A text or reference to a cell where the 
regular expression is to be applied.
-Expression: A text representing the regular 
expression, using https://userguide.icu-project.org/strings/regexp; 
name="ICU REGEXP">ICU regular expressions. If there is no match and 
Replacement is not given, #N/A is returned.
+Expression: A text representing the regular 
expression, using http://userguide.icu-project.org/strings/regexp; 
name="ICU REGEXP">ICU regular expressions. If there is no match and 
Replacement is not given, #N/A is returned.
 Replacement: Optional. The replacement text and 
references to capture groups. If there is no match, Text is 
returned unmodified.
 Flags: Optional. "g" replaces all matches of 
Expression in Text, not extracted. If there is no 
match, Text is returned unmodified.
 Occurrence: Optional. Number to indicate which 
match of Expression in Text is to be extracted or 
replaced. If there is no match and Replacement is not given, #N/A 
is returned. If there is no match and Replacement is given, 
Text is returned unmodified. If Occurrence is 0, 
Text is returned unmodified.
@@ -41,7 +41,7 @@
 =REGEX("axbxcxd";"(.)x";"$1y";2)  
returns "axbycxd", the second match of "(.)x" (i.e. "bx") replaced with the 
captured group of one character (i.e. "b") followed by "y".
 
 List of regular expressions
-https://userguide.icu-project.org/strings/regexp; 
name="ICU REGEXP">ICU regular expressions
+http://userguide.icu-project.org/strings/regexp; 
name="ICU REGEXP">ICU regular expressions
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 39468] translate German comments, removing redundant ones

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=39468

--- Comment #365 from Commit Notification 
 ---
Jens Carl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/55bb8bddd72079e619ab637409733764ddd33328%5E%21

tdf#39468 Translate German comments

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sal/textenc sc/source

2018-12-01 Thread Libreoffice Gerrit user
 sal/textenc/tencinfo.cxx  |2 +-
 sc/source/ui/app/inputhdl.cxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 55bb8bddd72079e619ab637409733764ddd33328
Author: Jens Carl 
AuthorDate: Fri Nov 30 17:46:04 2018 +
Commit: Eike Rathke 
CommitDate: Sat Dec 1 19:23:31 2018 +0100

tdf#39468 Translate German comments

Change-Id: I27e5e4604cd999d778eb84976b3bea0ef35122ee
Reviewed-on: https://gerrit.libreoffice.org/64353
Tested-by: Jenkins
Reviewed-by: Eike Rathke 

diff --git a/sal/textenc/tencinfo.cxx b/sal/textenc/tencinfo.cxx
index 91b98c056f68..915f1e27237b 100644
--- a/sal/textenc/tencinfo.cxx
+++ b/sal/textenc/tencinfo.cxx
@@ -433,7 +433,7 @@ rtl_TextEncoding SAL_CALL 
rtl_getTextEncodingFromUnixCharset( const char* pUnixC
 pTempBuf++;
 }
 
-/* Parttrenner gefunden */
+/* found part separator */
 if ( pSecondPart )
 {
 /* Search for the part tab */
diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx
index ab2d53995fd4..dbe34d3fc937 100644
--- a/sc/source/ui/app/inputhdl.cxx
+++ b/sc/source/ui/app/inputhdl.cxx
@@ -322,7 +322,7 @@ void ScInputHandler::InitRangeFinder( const OUString& 
rFormula )
 ++nPos; // Separator or closing quote
 }
 
-//  Text zwischen Trennern
+//  text between separators
 nStart = nPos;
 handle_r1c1:
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 45904] move java based api tests to c++

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45904

--- Comment #170 from Commit Notification 
 ---
Jens Carl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/e268016887aba18af67ad5060c8dfbf936f688d8%5E%21

tdf#45904 Move XIndexAccess Java tests to C++

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: framework/qa qadevOOo/Jar_OOoRunner.mk qadevOOo/objdsc qadevOOo/tests sc/qa

2018-12-01 Thread Libreoffice Gerrit user
 framework/qa/complex/api_internal/api.lst  |1 
 qadevOOo/Jar_OOoRunner.mk  |1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScAreaLinksObj.csv |2 
 qadevOOo/tests/java/mod/_sc/ScAreaLinksObj.java|  118 
--
 sc/qa/extras/scarealinksobj.cxx|9 
 sc/qa/unoapi/sc_2.sce  |1 
 6 files changed, 8 insertions(+), 124 deletions(-)

New commits:
commit e268016887aba18af67ad5060c8dfbf936f688d8
Author: Jens Carl 
AuthorDate: Sat Dec 1 07:48:35 2018 +
Commit: Jens Carl 
CommitDate: Sat Dec 1 19:13:46 2018 +0100

tdf#45904 Move XIndexAccess Java tests to C++

Move XIndexAccess Java test to C++ for ScAreaLinksObj.

Change-Id: I374b7301caf67c900b7a64920d2ac5b642a8c6fd
Reviewed-on: https://gerrit.libreoffice.org/64376
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/framework/qa/complex/api_internal/api.lst 
b/framework/qa/complex/api_internal/api.lst
index 89361f5b9349..fd5f7f2dd491 100644
--- a/framework/qa/complex/api_internal/api.lst
+++ b/framework/qa/complex/api_internal/api.lst
@@ -73,7 +73,6 @@ job73=sc.ScAccessiblePreviewTable
 job74=sc.ScAccessibleSpreadsheet
 job75=sc.ScAnnotationObj
 job76=sc.ScAnnotationsObj
-job77=sc.ScAreaLinksObj
 job78=sc.ScAutoFormatFieldObj
 job79=sc.ScAutoFormatObj
 job80=sc.ScAutoFormatsObj
diff --git a/qadevOOo/Jar_OOoRunner.mk b/qadevOOo/Jar_OOoRunner.mk
index a2e9b82e89f8..575f7fa0c301 100644
--- a/qadevOOo/Jar_OOoRunner.mk
+++ b/qadevOOo/Jar_OOoRunner.mk
@@ -955,7 +955,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\
 qadevOOo/tests/java/mod/_sc/ScAnnotationsObj \
 qadevOOo/tests/java/mod/_sc/ScAnnotationTextCursor \
 qadevOOo/tests/java/mod/_sc/ScAreaLinkObj \
-qadevOOo/tests/java/mod/_sc/ScAreaLinksObj \
 qadevOOo/tests/java/mod/_sc/ScAutoFormatFieldObj \
 qadevOOo/tests/java/mod/_sc/ScAutoFormatObj \
 qadevOOo/tests/java/mod/_sc/ScAutoFormatsObj \
diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScAreaLinksObj.csv 
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScAreaLinksObj.csv
deleted file mode 100644
index d21c646b1eee..
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScAreaLinksObj.csv
+++ /dev/null
@@ -1,2 +0,0 @@
-"ScAreaLinksObj";"com::sun::star::container::XIndexAccess";"getCount()"
-"ScAreaLinksObj";"com::sun::star::container::XIndexAccess";"getByIndex()"
diff --git a/qadevOOo/tests/java/mod/_sc/ScAreaLinksObj.java 
b/qadevOOo/tests/java/mod/_sc/ScAreaLinksObj.java
deleted file mode 100644
index 8b324a723502..
--- a/qadevOOo/tests/java/mod/_sc/ScAreaLinksObj.java
+++ /dev/null
@@ -1,118 +0,0 @@
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-package mod._sc;
-
-import java.io.PrintWriter;
-
-import lib.TestCase;
-import lib.TestEnvironment;
-import lib.TestParameters;
-import util.SOfficeFactory;
-
-import com.sun.star.beans.XPropertySet;
-import com.sun.star.lang.XComponent;
-import com.sun.star.sheet.XAreaLinks;
-import com.sun.star.sheet.XSpreadsheetDocument;
-import com.sun.star.table.CellAddress;
-import com.sun.star.uno.AnyConverter;
-import com.sun.star.uno.Type;
-import com.sun.star.uno.UnoRuntime;
-import com.sun.star.uno.XInterface;
-
-
-/**
-* Test for object which is represented by service
-* com.sun.star.sheet.CellAreaLinks.
-* This is a collection aff all links present
-* in a Spreadsheet document.
-* Object implements the following interfaces :
-* 
-*   com::sun::star::container::XIndexAccess
-*   com::sun::star::container::XElementAccess
-*   com::sun::star::sheet::XAreaLinks
-* 
-* This object test  is NOT  designed to be run in several
-* threads concurrently.
-* @see com.sun.star.container.XIndexAccess
-* @see com.sun.star.container.XElementAccess
-* @see com.sun.star.sheet.XAreaLinks
-* @see ifc.container._XIndexAccess
-* @see ifc.container._XElementAccess
-* @see ifc.sheet._XAreaLinks
-* @see com.sun.star.sheet.CellAreaLinks
-*/
-public class ScAreaLinksObj extends TestCase {
-private XSpreadsheetDocument xSheetDoc = null;
-
-/**
-* Creates Spreadsheet document.
-*/
-   

[Libreoffice-bugs] [Bug 121846] New: LibreOffice draw and libreOffice Impress do not start

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121846

Bug ID: 121846
   Summary: LibreOffice draw and libreOffice Impress do not start
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: epr...@cesip.it

Description:
Choosing "create draw document" from the soffice front page we obtain an error
notification.
Choosing "create impress document" simply does not happen anything. 

All other document's type go well.


Steps to Reproduce:
1. Choose "create draw document" or open a document created with older release
(.odg)
2. 
3.

Actual Results:
loading component library

failed.

Expected Results:
Opening of application "Draw"


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Linux Slackware kernel version 4.8.7

LibreOffice Versione: 6.1.3.2
Build ID: 86daf60bf00efa86ad547e59e09d6bb77c699acb
Thread CPU: 4; SO: Linux 4.8; Resa interfaccia: predefinito; VCL: kde4; 
Versione locale: it-IT (it_IT); Calc: threaded

The component libsdlo.so exists on the path, as you can see from these shell
commands:
# ls -l /opt/libreoffice/opt/libreoffice6.1/program/../program/libsdlo.so
-rwxr-xr-x 1 emilio emilio 8183704 ott 30 03:19
/opt/libreoffice/opt/libreoffice6.1/program/../program/libsdlo.so
# file /opt/libreoffice/opt/libreoffice6.1/program/../program/libsdlo.so
/opt/libreoffice/opt/libreoffice6.1/program/../program/libsdlo.so: ELF 64-bit
LSB shared object, x86-64, version 1 (GNU/Linux), dynamically linked,
BuildID[sha1]=4084ca26ae3881067de09880d02ae5e2b92258f4, stripped
# sum /opt/libreoffice/opt/libreoffice6.1/program/../program/libsdlo.so
47830  7992

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120703] Bugs found by PVS-Studio static analyzer

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120703

--- Comment #131 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/4e8f01716ec11ea8e7b8991a659e3ef708f4fee4%5E%21

tdf#120703 PVS: the condition needs &&, not ||

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/source

2018-12-01 Thread Libreoffice Gerrit user
 sc/source/ui/view/printfun.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4e8f01716ec11ea8e7b8991a659e3ef708f4fee4
Author: Mike Kaganski 
AuthorDate: Mon Nov 26 11:17:01 2018 +0300
Commit: Mike Kaganski 
CommitDate: Sat Dec 1 19:08:05 2018 +0100

tdf#120703 PVS: the condition needs &&, not ||

... ever since commit 9ae5a91f7955e44d3b24a3f7741f9bca02ac7f24

V560 A part of conditional expression is always false: nRangeNo < nRCount.
 The value range of unsigned short type: [0, 65535].

Actually, simple if (nRangeNo < nRCount) would be enough, given that if
sal_uInt16 is less than another sal_uInt16, it cannot be equal to greatest
sal_uInt16. But let's keep this redundant comparison, in case types or
define changes later.

Change-Id: I886a0bc847a8c30966dea3ea0670bcee9b43c7f1
Reviewed-on: https://gerrit.libreoffice.org/64021
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sc/source/ui/view/printfun.cxx b/sc/source/ui/view/printfun.cxx
index 2ba69ecc79dc..b2de8a6bf82d 100644
--- a/sc/source/ui/view/printfun.cxx
+++ b/sc/source/ui/view/printfun.cxx
@@ -2773,7 +2773,7 @@ void ScPrintFunc::CalcZoom( sal_uInt16 nRangeNo ) 
  // calcu
 {
 sal_uInt16 nRCount = pDoc->GetPrintRangeCount( nPrintTab );
 const ScRange* pThisRange = nullptr;
-if ( nRangeNo != RANGENO_NORANGE || nRangeNo < nRCount )
+if (nRangeNo != RANGENO_NORANGE && nRangeNo < nRCount)
 pThisRange = pDoc->GetPrintRange( nPrintTab, nRangeNo );
 if ( pThisRange )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 121845] New: custom shape with command U (angleellipse) is wrongly drawn

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121845

Bug ID: 121845
   Summary: custom shape with command U (angleellipse) is wrongly
drawn
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Created attachment 147205
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147205=edit
Wrong rendering of angleellipse

The command U in the enhanced-path is wrongly drawn. You see the problem, if
you compare the endpoints of the curve with the handle.

The essential part in page 2 of the attached file is

  
 

The modifier is directly referenced in the polar-handle and in the
enhanced-path.

Expected behavior: The curve starts at the handle and goes clockwise to the
direction 270°, which is down vertical axis. That would generate a large arc.

Current behavior: The curve is drawn counter clockwise and it does not start at
the handle.

I had reported the problem already for Apache OpenOffice in
https://bz.apache.org/ooo/show_bug.cgi?id=121491

This error prevents a proper import and converting from ooxml-arc.

[The spec has radius and angle in draw:handle-position the other way round. But
because PowerPoint has it the same way as LibreOffice, that will likely be
changed in the spec and is not part of this issue.
http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#attribute-draw_enhanced-path]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121574] Enhancement : Pasting from Writer to Impress Should be "Text only" by default

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121574

--- Comment #6 from jim  ---
Agreed - Text Only as default.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 6 commits - desktop/qa desktop/source sfx2/source xmlsecurity/source

2018-12-01 Thread Libreoffice Gerrit user
 desktop/qa/data/test-PK-signing.pem|   28 +
 desktop/qa/data/test-cert-chain-1.pem  |   24 
 desktop/qa/data/test-cert-chain-2.pem  |   26 
 desktop/qa/data/test-cert-chain-3.pem  |   23 
 desktop/qa/data/test-cert-signing.pem  |   23 
 desktop/qa/desktop_lib/test_desktop_lib.cxx|   87 +++
 desktop/source/lib/init.cxx|   94 +++--
 sfx2/source/doc/guisaveas.cxx  |5 
 xmlsecurity/source/helper/documentsignaturemanager.cxx |7 -
 xmlsecurity/source/xmlsec/nss/xmlsignature_nssimpl.cxx |   16 +-
 10 files changed, 313 insertions(+), 20 deletions(-)

New commits:
commit c0b2e7697d9647199d489a838d4fabc543264094
Author: Tomaž Vajngerl 
AuthorDate: Fri Nov 30 11:48:50 2018 +0100
Commit: Tomaž Vajngerl 
CommitDate: Sat Dec 1 18:32:30 2018 +0100

convert to range for

Change-Id: I3558010129eaafdab94ca3f8a63abeda32318fbb
Reviewed-on: https://gerrit.libreoffice.org/64336
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 
(cherry picked from commit bb8c2b1cbf7a9eb56b1515f60a2aadbef24199a2)

diff --git a/xmlsecurity/source/helper/documentsignaturemanager.cxx 
b/xmlsecurity/source/helper/documentsignaturemanager.cxx
index 218360d2f60c..c65b73c3b85d 100644
--- a/xmlsecurity/source/helper/documentsignaturemanager.cxx
+++ b/xmlsecurity/source/helper/documentsignaturemanager.cxx
@@ -355,11 +355,10 @@ bool DocumentSignatureManager::add(const 
uno::Reference&
 std::vector< OUString > aElements = 
DocumentSignatureHelper::CreateElementList(mxStore, meSignatureMode, 
DocumentSignatureAlgorithm::OOo3_2);
 DocumentSignatureHelper::AppendContentTypes(mxStore, aElements);
 
-sal_Int32 nElements = aElements.size();
-for (sal_Int32 n = 0; n < nElements; n++)
+for (OUString const& rUri : aElements)
 {
-bool bBinaryMode = !isXML(aElements[n]);
-maSignatureHelper.AddForSigning(nSecurityId, aElements[n], 
bBinaryMode, bAdESCompliant);
+bool bBinaryMode = !isXML(rUri);
+maSignatureHelper.AddForSigning(nSecurityId, rUri, bBinaryMode, 
bAdESCompliant);
 }
 
 maSignatureHelper.SetDateTime(nSecurityId, Date(Date::SYSTEM), 
tools::Time(tools::Time::SYSTEM));
commit 33c795b3d42e0c6e8ff2214838c8da35bfceddfb
Author: Tomaž Vajngerl 
AuthorDate: Thu Nov 29 22:09:07 2018 +0100
Commit: Tomaž Vajngerl 
CommitDate: Sat Dec 1 18:32:14 2018 +0100

test signing with certificate chain and private key in PEM format

Change-Id: If3b121e44ceec8be668820a7e8a9e35c15d547ff
Reviewed-on: https://gerrit.libreoffice.org/64295
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 
(cherry picked from commit 07e586574d5f0255ade1fe4305d56730dd7ae4c7)

diff --git a/desktop/qa/data/test-PK-signing.pem 
b/desktop/qa/data/test-PK-signing.pem
new file mode 100644
index ..eabbaae18c10
--- /dev/null
+++ b/desktop/qa/data/test-PK-signing.pem
@@ -0,0 +1,28 @@
+-BEGIN PRIVATE KEY-
+MIIEvAIBADANBgkqhkiG9w0BAQEFAASCBKYwggSiAgEAAoIBAQC/x1dyX2PgJs6o
+e/BcBT5XTJXtipme29mtI/FmTq5vuAFopqvAEg084hNM7Q++wKyKG8F0ABF2pUOY
+vo6Pq6rXQqMbxUaO47NNefh4v/f6hBoMfSYmXtEPji8NjIcIrQ3U8yTWquaHi13h
+coG/cVf16Doem5AxUdQ6a9e/jA1VU2MmSZxthkABKPWdw1pfFJDLWhFrCjhePKrB
+xw2ArmNx66fdzpi5XK0fC2TbHD2NVc8cbYOzF4h3knGZo2sq4/MBevyVhzXZNn2P
+jf3PbOxp1O8CLx86MuDTLDkSVjmP0yXBf6rLFMWtEfv1Jmf3I61meIuOcw6wvXRK
+zPnAKpLRAgMBAAECggEAFQU1JooiGQg9OpEV0ArwbFfZTxy+qH+Rz70oJn3qohWE
+bK4SwTi5TrpmQdZHatxqN7EXIS8out0ebaLlXrCtnG6SEOcsoVjVPGFpb1ggnCAt
+TWp3lgO/3SPz2wOo1rXxKtguaivNR39qc4g+LyJYm9GFHU8RHPbKe6TPvw+2HmtB
+Qr2dfwgN+JJ/lBTIE0lUVuGcBcCRxbM6aG3WVpVrWcsGwRekcuuy9xrv+6fd1p2E
+7zdM0/18+tnCWF9kCO6ot+spKJGTKqiuaKrSB54gFnDEgjQKIW7lUuOcXKI8vOZb
+yO3owLE4mlNbE9sv8gPKoMXf2d6wzMRA6wBdaqOlKQKBgQD1XhyNDTpCoqcO82KY
+YCJOZ6d1jH27XhHplfmrYDlQuWiuJ/b3ckq5Pqw5J5pRO19tvb4RSonYtmOcLajR
+CkQtHapeH8mUzGsE/tgauB4KoZ1sVhzsag0Ill44P5/5oBlzhRrvJ7L80qlHn8xC
+a4Tzk5t0tWbCS6K3/rqvil0hXwKBgQDIFsMoujc8hW5jyC6rO41elWEDVmPs5P+5
+RYxH5+uVeByyz2R86CAFmHUn/1nD47KKouNhwU4Anf5lA8JHh9rNVF07a2dAfH1o
+yfkBGz8d3xb5hq3ahVGg9WyMRyfczGGA19uJrQ19dY4G4B4FPPz0J6oOnNkTFaQ9
+Bks/k/fJzwKBgGSBqVZJzcyPzbh9D6z06/iL0vd+ld4TGWlCKqP9ZVzgpbV431va
+sCsTNf6vbzHJDTzplRqGGtLvWvwVY+pEt0p3tVqa0LqnxUqljSXct0mJi+9dkrlw
+c2hKF8wYm9Hnt6UvJ6pA67tOG1MgbM3kNvCDTRFQYQhDbSLLL/NJzP4nAoGAJqhv
+MFE6FtFY0KJ+kcrBt4J46eIpED32Ql9ziPkABTLdqJZ1PcTDWxFnoUCuoTA+8JYk
+BGEKpwfffLjLMnLHDWC9WpuXqVfkCvjqyRHwkd7mW3Nv54ZWjRidzkR5KSm7tN7/
+pYvvzUuHE0D9y9lKrglzy7r2Hb/SqY+rvi7icvUCgYADV2kkky++OmCVLkEg3WUf
+SJkF6jUAVMqlMdjTbySEfCJbxpVwRAiUWWlDD07c5HCBEASi6/NSn06MDb9Fvxo0
+a3m24Aa2c+K4ENj+bj453gdxhtvpeyfSRK+gBEP64iBG92UFJjcwHz5kFCzppPuP
+p+ZtA6JAnV6QPT1EixAOCA==
+-END PRIVATE KEY-
diff --git a/desktop/qa/data/test-cert-chain-1.pem 
b/desktop/qa/data/test-cert-chain-1.pem
new file mode 100644
index ..3a3407caf613
--- /dev/null
+++ 

[Libreoffice-commits] core.git: sfx2/source shell/source

2018-12-01 Thread Libreoffice Gerrit user
 sfx2/source/appl/linkmgr2.cxx  |5 
 sfx2/source/appl/linksrc.cxx   |   10 -
 sfx2/source/appl/preventduplicateinteraction.cxx   |   65 +++-
 sfx2/source/control/templatelocalview.cxx  |   32 +---
 sfx2/source/dialog/dinfdlg.cxx |   45 ++
 sfx2/source/dialog/filtergrouping.cxx  |   14 -
 sfx2/source/dialog/infobar.cxx |   23 +--
 sfx2/source/doc/DocumentMetadataAccess.cxx |   12 -
 sfx2/source/doc/docfac.cxx |7 
 sfx2/source/doc/docinf.cxx |7 
 sfx2/source/notebookbar/PriorityHBox.cxx   |   17 --
 sfx2/source/notify/globalevents.cxx|   16 --
 sfx2/source/sidebar/DeckLayouter.cxx   |   73 
+++---
 sfx2/source/sidebar/SidebarController.cxx  |   52 ++-
 sfx2/source/sidebar/Theme.cxx  |   30 
 sfx2/source/sidebar/UnoDecks.cxx   |   21 --
 sfx2/source/sidebar/UnoPanels.cxx  |   29 +--
 sfx2/source/view/viewsh.cxx|   11 -
 shell/source/win32/shlxthandler/propsheets/listviewbuilder.cxx |   16 --
 shell/source/win32/shlxthandler/util/iso8601_converter.cxx |   17 --
 20 files changed, 189 insertions(+), 313 deletions(-)

New commits:
commit 56d97cdd0af15c90c744d2ac66e879818c073ec6
Author: Arkadiy Illarionov 
AuthorDate: Sat Dec 1 15:19:04 2018 +0300
Commit: Noel Grandin 
CommitDate: Sat Dec 1 18:26:01 2018 +0100

Simplify containers iterations in sfx2, shell

Use range-based loop or replace with STL functions

Change-Id: I42361d6a73d201db8eb6dca09d79768e2d62051d
Reviewed-on: https://gerrit.libreoffice.org/64389
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sfx2/source/appl/linkmgr2.cxx b/sfx2/source/appl/linkmgr2.cxx
index fba3d944c225..1e631bc949aa 100644
--- a/sfx2/source/appl/linkmgr2.cxx
+++ b/sfx2/source/appl/linkmgr2.cxx
@@ -92,10 +92,9 @@ void LinkManager::InsertCachedComp(const 
Reference& xComp)
 
 void LinkManager::CloseCachedComps()
 {
-CompVector::iterator itr = maCachedComps.begin(), itrEnd = 
maCachedComps.end();
-for (; itr != itrEnd; ++itr)
+for (const auto& rxCachedComp : maCachedComps)
 {
-Reference xCloseable(*itr, UNO_QUERY);
+Reference xCloseable(rxCachedComp, UNO_QUERY);
 if (!xCloseable.is())
 continue;
 
diff --git a/sfx2/source/appl/linksrc.cxx b/sfx2/source/appl/linksrc.cxx
index 16a94bad6abd..98c347713dfb 100644
--- a/sfx2/source/appl/linksrc.cxx
+++ b/sfx2/source/appl/linksrc.cxx
@@ -99,12 +99,10 @@ public:
 
 void DeleteAndDestroy(SvLinkSource_Entry_Impl const * p)
 {
-for (auto it = mvData.begin(); it != mvData.end(); ++it)
-if (it->get() == p)
-{
-mvData.erase(it);
-break;
-}
+auto it = std::find_if(mvData.begin(), mvData.end(),
+[](const std::unique_ptr& rxData) { 
return rxData.get() == p; });
+if (it != mvData.end())
+mvData.erase(it);
 }
 };
 
diff --git a/sfx2/source/appl/preventduplicateinteraction.cxx 
b/sfx2/source/appl/preventduplicateinteraction.cxx
index ffe89813c0db..f9c38dd81132 100644
--- a/sfx2/source/appl/preventduplicateinteraction.cxx
+++ b/sfx2/source/appl/preventduplicateinteraction.cxx
@@ -88,20 +88,15 @@ void SAL_CALL PreventDuplicateInteraction::handle(const 
css::uno::Reference< css
 // SAFE ->
 ::osl::ResettableMutexGuard aLock(m_aLock);
 
-InteractionList::iterator pIt;
-for (  pIt  = m_lInteractionRules.begin();
-   pIt != m_lInteractionRules.end();
- ++pIt   )
+auto pIt = std::find_if(m_lInteractionRules.begin(), 
m_lInteractionRules.end(),
+[](const InteractionInfo& rInfo) { return 
aRequest.isExtractableTo(rInfo.m_aInteraction); });
+if (pIt != m_lInteractionRules.end())
 {
 InteractionInfo& rInfo = *pIt;
 
-if (aRequest.isExtractableTo(rInfo.m_aInteraction))
-{
-++rInfo.m_nCallCount;
-rInfo.m_xRequest = xRequest;
-bHandleIt = (rInfo.m_nCallCount <= rInfo.m_nMaxCount);
-break;
-}
+++rInfo.m_nCallCount;
+rInfo.m_xRequest = xRequest;
+bHandleIt = (rInfo.m_nCallCount <= rInfo.m_nMaxCount);
 }
 
 css::uno::Reference< css::task::XInteractionHandler > xHandler = 
m_xHandler;
@@ -138,20 +133,15 @@ sal_Bool SAL_CALL 
PreventDuplicateInteraction::handleInteractionRequest( const c
 // SAFE ->
 ::osl::ResettableMutexGuard aLock(m_aLock);
 
-InteractionList::iterator pIt;
-for (  pIt  = m_lInteractionRules.begin();

[Libreoffice-bugs] [Bug 120703] Bugs found by PVS-Studio static analyzer

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120703

--- Comment #130 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/fff501a3393b459c512ec155e2d2cd935e7885a2%5E%21

tdf#120703 PVS: V560 A part of conditional expression is always true/false

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: embeddedobj/source sdext/source soltools/mkdepend sw/source

2018-12-01 Thread Libreoffice Gerrit user
 embeddedobj/source/commonembedding/persistence.cxx |   10 +-
 sdext/source/pdfimport/test/pdfunzip.cxx   |   10 --
 soltools/mkdepend/pr.c |2 +-
 sw/source/core/text/porlay.cxx |6 +++---
 4 files changed, 9 insertions(+), 19 deletions(-)

New commits:
commit fff501a3393b459c512ec155e2d2cd935e7885a2
Author: Mike Kaganski 
AuthorDate: Mon Nov 26 10:36:52 2018 +0300
Commit: Mike Kaganski 
CommitDate: Sat Dec 1 18:20:24 2018 +0100

tdf#120703 PVS: V560 A part of conditional expression is always true/false

Change-Id: I38f3e3243f8cb891c9a0fe2f4c68bc76acd1ef44
Reviewed-on: https://gerrit.libreoffice.org/64020
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/embeddedobj/source/commonembedding/persistence.cxx 
b/embeddedobj/source/commonembedding/persistence.cxx
index 06562ac39682..aae1180f8d8b 100644
--- a/embeddedobj/source/commonembedding/persistence.cxx
+++ b/embeddedobj/source/commonembedding/persistence.cxx
@@ -1771,7 +1771,7 @@ void SAL_CALL OCommonEmbeddedObject::breakLink( const 
uno::Reference< embed::XSt
 if ( m_bDisposed )
 throw lang::DisposedException(); // TODO
 
-if ( !m_bIsLink )
+if (!m_bIsLink || m_nObjectState == -1)
 {
 // it must be a linked initialized object
 throw embed::WrongStateException(
@@ -1791,14 +1791,6 @@ void SAL_CALL OCommonEmbeddedObject::breakLink( const 
uno::Reference< embed::XSt
 static_cast< ::cppu::OWeakObject* 
>(this),
 2 );
 
-if ( !m_bIsLink || m_nObjectState == -1 )
-{
-// it must be a linked initialized object
-throw embed::WrongStateException(
-"The object is not a valid linked object!",
-static_cast< ::cppu::OWeakObject* >(this) );
-}
-
 if ( m_bWaitSaveCompleted )
 throw embed::WrongStateException(
 "The object waits for saveCompleted() call!",
diff --git a/sdext/source/pdfimport/test/pdfunzip.cxx 
b/sdext/source/pdfimport/test/pdfunzip.cxx
index 17807af628d6..ca7e5afa0b1a 100644
--- a/sdext/source/pdfimport/test/pdfunzip.cxx
+++ b/sdext/source/pdfimport/test/pdfunzip.cxx
@@ -311,9 +311,8 @@ static int write_addStreams( const char* pInFile, const 
char* pOutFile, PDFFile*
 
 static int write_fonts( const char* i_pInFile, const char* i_pOutFile, 
PDFFile* i_pPDFFile )
 {
-int nRet = 0;
 unsigned int nElements = i_pPDFFile->m_aSubElements.size();
-for( unsigned i = 0; i < nElements && nRet == 0; i++ )
+for (unsigned i = 0; i < nElements; i++)
 {
 // search FontDescriptors
 PDFObject* pObj = 
dynamic_cast(i_pPDFFile->m_aSubElements[i].get());
@@ -390,16 +389,15 @@ static int write_fonts( const char* i_pInFile, const 
char* i_pOutFile, PDFFile*
 aContext.m_bDecrypt = i_pPDFFile->isEncrypted();
 pStream->writeStream( aContext, i_pPDFFile );
 }
-return nRet;
+return 0;
 }
 
 static std::vector< std::pair< sal_Int32, sal_Int32 > > s_aEmitObjects;
 
 static int write_objects( const char* i_pInFile, const char* i_pOutFile, 
PDFFile* i_pPDFFile )
 {
-int nRet = 0;
 unsigned int nElements = s_aEmitObjects.size();
-for( unsigned i = 0; i < nElements && nRet == 0; i++ )
+for (unsigned i = 0; i < nElements; i++)
 {
 sal_Int32 nObject = s_aEmitObjects[i].first;
 sal_Int32 nGeneration = s_aEmitObjects[i].second;
@@ -419,7 +417,7 @@ static int write_objects( const char* i_pInFile, const 
char* i_pOutFile, PDFFile
 aContext.m_bDecrypt = i_pPDFFile->isEncrypted();
 pStream->writeStream( aContext, i_pPDFFile );
 }
-return nRet;
+return 0;
 }
 
 SAL_IMPLEMENT_MAIN_WITH_ARGS( argc, argv )
diff --git a/soltools/mkdepend/pr.c b/soltools/mkdepend/pr.c
index 4fe0b4ada2fa..391e39dfcd20 100644
--- a/soltools/mkdepend/pr.c
+++ b/soltools/mkdepend/pr.c
@@ -59,7 +59,7 @@ void add_include(struct filepointer *filep, struct inclist 
*file, struct inclist
 if (newfile) {
 
 /* Only add new dependency files if they don't have "/usr/include" in 
them. */
-if (!(newfile && newfile->i_file && strstr(newfile->i_file, "/usr/"))) 
{
+if (!(newfile->i_file && strstr(newfile->i_file, "/usr/"))) {
 included_by(file, newfile);
 }
 
diff --git a/sw/source/core/text/porlay.cxx b/sw/source/core/text/porlay.cxx
index 02900e9e5d79..781c8aef5302 100644
--- a/sw/source/core/text/porlay.cxx
+++ b/sw/source/core/text/porlay.cxx
@@ -1510,7 +1510,7 @@ sal_Int32 SwScriptInfo::MaskHiddenRanges( const 
SwTextNode& rNode, OUStringBuffe
 
 while ( nHiddenStart < nHiddenEnd && nHiddenStart < nEnd )
 {
-if ( nHiddenStart >= nStt && nHiddenStart < nEnd )
+if (nHiddenStart >= nStt)
 {
 rText[nHiddenStart] = cChar;
 

[Libreoffice-bugs] [Bug 121822] Macro execution from macro-assigned button activation, involving a Save-as (FILESAVE) and subsequent Reload (FILEOPEN), Close and Reopen original makes application cras

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121822

Oliver Brinzing  changed:

   What|Removed |Added

 CC||oliver.brinz...@gmx.de
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from Oliver Brinzing  ---
(In reply to Thijs from comment #1)
> The zip file contains the test-sheet, as well as the macro

the zip file only contains the *.bas file. 
could you please attach the test-file too?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118510] Libreoffice kills my pc (prevents it from waking from suspend)

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118510

--- Comment #9 from Elias  ---
RE: Comment 8

I just got the error again a few minutes ago and had to restart my PC (Yes,
libreoffice was open). I tried doing ctrl+alt+f1 then ctrl+alt+f2 then
ctrl+alt+f1 again, it didn't bring the system back to life unfortunately.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121689] Copy cells with condition to external programs (Word/Moodle) doesnt work properly

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121689

Oliver Brinzing  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #8 from Oliver Brinzing  ---
(In reply to Eduardo from comment #7)
>https://drive.google.com/drive/folders

i cannot find an example file, only jpg's.
could you please attach a simple example file, where the bug can be reproduced?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120042] FIREBIRD: Crash in: libc-2.27.so when Save As of an ODB overtop of an existing ODB if the target has been opened in current session

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120042

--- Comment #8 from Drew Jensen  ---
Checked this again today with Ubuntu 18.04 and 
Version: 6.1.4.0.0+
Build ID: 1c73f379bf8d6f75460790fec2993106e10f15a0
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:libreoffice-6-1, Time:
2018-11-21_23:30:33
Locale: en-US (en_US.UTF-8); Calc: group threaded

Same crash as before, but with no actual crash report to send in.

Version: 6.2.0.0.beta1
Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

Same crash with a crash report:
crashreport.libreoffice.org/stats/crash_details/1e20bd39-5aab-415a-97a6-49518dc96ad5

and 

Version: 6.3.0.0.alpha0+
Build ID: d8d231f97d829350d965105e3a5be119d1a6494c
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2018-11-30_00:14:18
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

It works exactly as expected, no crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121810] Crash in: libgobject-2.0.so.0.5600.3 when selecting more on error dialog

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121810

raal  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||caol...@redhat.com,
   ||r...@post.cz

--- Comment #3 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Caolán McNamara ; Could you possibly take a look at this one?
Thanks

9f8daa91b1d102bb6445df46e0e011f4c1507b62 is the first bad commit
commit 9f8daa91b1d102bb6445df46e0e011f4c1507b62
Author: Jenkins Build User 
Date:   Thu Nov 22 10:56:52 2018 +0100

source sha:4b7cbb569e52e483a5edda8afe27d423e428edbb

author  Caolán McNamara 2018-11-17 21:37:50 +
committer   Caolán McNamara 2018-11-22 09:55:16
+0100
commit  4b7cbb569e52e483a5edda8afe27d423e428edbb (patch)
treeb767f526b821002d1b71d49e0e205d9e3dcab8fa
parent  b9b62d96f6de8908ddf69f5b56eb58fe82013a24 (diff)
weld SwCondCollPage

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121838] Firebird: Mirgration: Certain ODB crashes application during Migration Assistant execution

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121838

--- Comment #3 from Drew Jensen  ---
Created attachment 147204
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147204=edit
Second ODB which causes crash

Adding a second example file.
Much smaller and simpler.
All reports, forms and queries have been removed, leaving only the data schema.
Triggers the same crash as the other file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121791] Can't insert avi file into slide

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121791

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #7 from raal  ---
https://wiki.documentfoundation.org/Media_Support/Windows

You should install codecs first. I cannot play file in media windows player. I
can play the file in linux, codec is Intel Video 4.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121825] Add date-related formulas

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121825

mathieu_p...@hotmail.com changed:

   What|Removed |Added

 Resolution|WORKSFORME  |---
 Status|RESOLVED|UNCONFIRMED

--- Comment #2 from mathieu_p...@hotmail.com ---
Sorry, but TODAY() is definitely not the same as EOMONTH(TODAY();0), is it?
With the field option, I would need to write the document on the last day of
the month for instance to get the wanted date. And if I want to use
EOMONTH(TODAY();6), I would have to write it in 6 months.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121841] Missing menu items in LO 6.2.0.0 beta1

2018-12-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121841

V Stuart Foote  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #8 from V Stuart Foote  ---
Thanks. So while old, that Q45/Q43 GMA X4500 graphics chipset -- E5200 CPU
Intel hardware should be OK. No OpenGL of course.

The 8.15.10.2702 driver WDDM Windows 7 driver that was picked up with the
Windows 10 install should probably be updated.

The Intel 15.17.19.64.2869 Windows 7 driver from the .zip package [1] would be
my suggestion. Use a "have disk" update and point to the unzipped package.

Not clear if the 15.22.58.64.2993 would behave correctly on the Q45/Q43--but
you could try that and roll back if unstable.

=-ref-=
[1]
https://downloadcenter.intel.com/download/22166/Intel-Graphics-Media-Accelerator-Driver-for-Windows-7-Windows-Vista-64-Bit-zip-?product=81515

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   >