[Libreoffice-bugs] [Bug 121815] Crash in: FreetypeFont::GetFtFace
https://bugs.documentfoundation.org/show_bug.cgi?id=121815 --- Comment #12 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/b6764835b4bbd532ba796b48d52f3e87453776a1%5E%21 tdf#121815 just use valid cached layout glyphs It will be available in 6.2.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121815] Crash in: FreetypeFont::GetFtFace
https://bugs.documentfoundation.org/show_bug.cgi?id=121815 Commit Notification changed: What|Removed |Added Whiteboard|target:6.3.0|target:6.3.0 target:6.2.0.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 120992] Selection box should include a grid guide
https://bugs.documentfoundation.org/show_bug.cgi?id=120992 --- Comment #10 from 和尚蟹 --- (In reply to Heiko Tietze from comment #9) This article can be used as a copy of bug 121843. You can also delete this article directly. In short, this article is not to be used, whatever you do. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 120992] Selection box should include a grid guide
https://bugs.documentfoundation.org/show_bug.cgi?id=120992 --- Comment #10 from 和尚蟹 --- (In reply to Heiko Tietze from comment #9) This article can be used as a copy of bug 121843. You can also delete this article directly. In short, this article is not to be used, whatever you do. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/source
vcl/source/outdev/text.cxx |6 ++
1 file changed, 6 insertions(+)
New commits:
commit b6764835b4bbd532ba796b48d52f3e87453776a1
Author: Jan-Marek Glogowski
AuthorDate: Tue Dec 4 14:26:18 2018 +
Commit: Jan-Marek Glogowski
CommitDate: Wed Dec 5 08:53:25 2018 +0100
tdf#121815 just use valid cached layout glyphs
I'm not exacly sure when and why the font cache is invalidated,
but as a result this also invalidates the cached layouted glyphs.
So just check the glyph layout cache state before trying to use
it. But actually the status bar should update it's cache, so I'm
not sure where to really put the fix. At least this won't crash
LO anymore.
Change-Id: I5f3ff8b9d56808af74d1419e878819d6019cd893
Reviewed-on: https://gerrit.libreoffice.org/64529
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
(cherry picked from commit 9e2e6c27231f916fec349ff60cb0f2c12e0988ad)
Reviewed-on: https://gerrit.libreoffice.org/64572
diff --git a/vcl/source/outdev/text.cxx b/vcl/source/outdev/text.cxx
index 2bb81ad8da2d..ddc8af2c0073 100644
--- a/vcl/source/outdev/text.cxx
+++ b/vcl/source/outdev/text.cxx
@@ -1249,6 +1249,12 @@ std::unique_ptr
OutputDevice::ImplLayout(const OUString& rOrigStr,
vcl::TextLayoutCache const* pLayoutCache,
const SalLayoutGlyphs* pGlyphs) const
{
+if (pGlyphs && !pGlyphs->IsValid())
+{
+SAL_WARN("vcl", "Trying to setup invalid cached glyphs - falling back
to relayout!");
+pGlyphs = nullptr;
+}
+
if (!InitFont())
return nullptr;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: basic/source
basic/source/runtime/runtime.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f4e5cdcc283275be6cf75e24c2502a4ad39cf0fd Author: Andrea Gelmini AuthorDate: Sun Dec 2 00:09:23 2018 +0100 Commit: Julien Nabet CommitDate: Wed Dec 5 08:41:11 2018 +0100 Fix typo Change-Id: I0345811912003e308054df426e533ac7c3866284 Reviewed-on: https://gerrit.libreoffice.org/64416 Reviewed-by: Julien Nabet Tested-by: Julien Nabet diff --git a/basic/source/runtime/runtime.cxx b/basic/source/runtime/runtime.cxx index f111c65fdb52..c8d3ccbd5699 100644 --- a/basic/source/runtime/runtime.cxx +++ b/basic/source/runtime/runtime.cxx @@ -1891,7 +1891,7 @@ void SbiRuntime::StepSET_Impl( SbxVariableRef& refVal, SbxVariableRef& refVar, b // lhs is a property who's value is currently (Empty e.g. no broadcast yet) // in this case if there is a default prop involved the value of the -// default property may infact be void so the type will also be SbxEMPTY +// default property may in fact be void so the type will also be SbxEMPTY // in this case we do not want to call checkUnoStructCopy 'cause that will // cause an error also if ( !checkUnoStructCopy( bHandleDefaultProp, refVal, refVar ) ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: canvas/source
canvas/source/directx/dx_spritecanvashelper.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 58f15b44d26355da0bfe7ee3c8377d6229b2659c Author: Andrea Gelmini AuthorDate: Tue Dec 4 13:48:45 2018 +0100 Commit: Julien Nabet CommitDate: Wed Dec 5 08:40:04 2018 +0100 Fix typo Change-Id: Iff7717094f82fdbb13b09c05cb44d059c7ba5f3b Reviewed-on: https://gerrit.libreoffice.org/64575 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/canvas/source/directx/dx_spritecanvashelper.cxx b/canvas/source/directx/dx_spritecanvashelper.cxx index 7d859cff0e40..416c66ba5fca 100644 --- a/canvas/source/directx/dx_spritecanvashelper.cxx +++ b/canvas/source/directx/dx_spritecanvashelper.cxx @@ -158,7 +158,7 @@ namespace dxcanvas // clear area that needs to be blitted to screen beforehand maUpdateRect.reset(); -// TODO(P1): Might be worthwile to track areas of background +// TODO(P1): Might be worthwhile to track areas of background // changes, too. // TODO(P2): Might be worthwhile to use page-flipping only if ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 121725] Export to PDF from DOCX gives wrong PDF file that doesn't open with error
https://bugs.documentfoundation.org/show_bug.cgi?id=121725 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||1912 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa
0 files changed New commits: commit 2d89bc5a5bc27b83a6720a6740425a3055917dfe Author: Andrea Gelmini AuthorDate: Fri Nov 30 19:57:24 2018 +0100 Commit: Julien Nabet CommitDate: Wed Dec 5 08:40:21 2018 +0100 Removed executable permission on docx file Change-Id: I7738c8048a3dee4788b89826d69b35d62ce79417 Reviewed-on: https://gerrit.libreoffice.org/64356 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/sw/qa/extras/ooxmlexport/data/Chart_Plot_BorderLine_Style.docx b/sw/qa/extras/ooxmlexport/data/Chart_Plot_BorderLine_Style.docx old mode 100755 new mode 100644 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||121912 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=121912 [Bug 121912] PDF Export of odt documents to pdf -created pdf document is not readable in Acrobat reader -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121912] PDF Export of odt documents to pdf -created pdf document is not readable in Acrobat reader
https://bugs.documentfoundation.org/show_bug.cgi?id=121912 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Keywords||filter:pdf See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||1725 Blocks||103378 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103378 [Bug 103378] [META] PDF export bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 121759] Doesn't active menu item Insert->Headers and Footers in Calc 6.2
https://bugs.documentfoundation.org/show_bug.cgi?id=121759 --- Comment #13 from Heiko Tietze --- (In reply to Cor Nouws from comment #12) > In Writer the item is active from scratch. So why not in Calc? It was requested in bug 99296 to disable h/f in Calc, and you also have to enable it first in Writer. But that's not an answer or solution to this issue. a) Revert 99296 b) Make this a WFM c) Move the disabled menu item to Edit d) Auto enable H/F when content is inserted at the edit dialog -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 121759] Doesn't active menu item Insert->Headers and Footers in Calc 6.2
https://bugs.documentfoundation.org/show_bug.cgi?id=121759 --- Comment #13 from Heiko Tietze --- (In reply to Cor Nouws from comment #12) > In Writer the item is active from scratch. So why not in Calc? It was requested in bug 99296 to disable h/f in Calc, and you also have to enable it first in Writer. But that's not an answer or solution to this issue. a) Revert 99296 b) Make this a WFM c) Move the disabled menu item to Edit d) Auto enable H/F when content is inserted at the edit dialog -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96971] SetXORMode - remove un-needed parameter ...
https://bugs.documentfoundation.org/show_bug.cgi?id=96971 Commit Notification changed: What|Removed |Added Whiteboard|target:5.3.0|target:5.3.0 target:6.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/headless vcl/inc vcl/opengl vcl/quartz vcl/source vcl/unx vcl/win
vcl/headless/svpgdi.cxx |2 +-
vcl/inc/headless/svpgdi.hxx |2 +-
vcl/inc/openglgdiimpl.hxx|2 +-
vcl/inc/quartz/salgdi.h |2 +-
vcl/inc/salgdi.hxx |2 +-
vcl/inc/salgdiimpl.hxx |2 +-
vcl/inc/unx/genpspgraphics.h |2 +-
vcl/inc/unx/salgdi.h |2 +-
vcl/inc/win/salgdi.h |2 +-
vcl/opengl/gdiimpl.cxx |2 +-
vcl/quartz/salgdicommon.cxx |4 ++--
vcl/source/gdi/print.cxx |2 +-
vcl/source/gdi/virdev.cxx|2 +-
vcl/source/outdev/outdevstate.cxx|2 +-
vcl/source/window/window.cxx |2 +-
vcl/unx/generic/gdi/gdiimpl.cxx |2 +-
vcl/unx/generic/gdi/gdiimpl.hxx |2 +-
vcl/unx/generic/gdi/salgdi.cxx |4 ++--
vcl/unx/generic/print/genpspgraphics.cxx |2 +-
vcl/win/gdi/gdiimpl.cxx |2 +-
vcl/win/gdi/gdiimpl.hxx |2 +-
vcl/win/gdi/salgdi.cxx |4 ++--
22 files changed, 25 insertions(+), 25 deletions(-)
New commits:
commit be504e8c7ef06637f055c43ad350381377df1e90
Author: Xisco Fauli
AuthorDate: Wed Dec 5 01:23:17 2018 +0100
Commit: Noel Grandin
CommitDate: Wed Dec 5 08:18:50 2018 +0100
tdf#121719: Revert fix for tdf#96971
it's still used on Mac. Revert it until XOL is removed
This reverts 258301879bcd20397c38bbd522dea2c923bd9fc2
Change-Id: I06548a590f370618ad640724a1b9c59a3faceec2
Reviewed-on: https://gerrit.libreoffice.org/64582
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index 848d2e0f2b04..0a428545f8b3 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -668,7 +668,7 @@ void SvpSalGraphics::SetFillColor( Color nColor )
m_aFillColor = nColor;
}
-void SvpSalGraphics::SetXORMode(bool bSet )
+void SvpSalGraphics::SetXORMode(bool bSet, bool )
{
m_ePaintMode = bSet ? PaintMode::Xor : PaintMode::Over;
}
diff --git a/vcl/inc/headless/svpgdi.hxx b/vcl/inc/headless/svpgdi.hxx
index 8546387f8962..9ba284300a37 100644
--- a/vcl/inc/headless/svpgdi.hxx
+++ b/vcl/inc/headless/svpgdi.hxx
@@ -163,7 +163,7 @@ public:
virtual voidSetFillColor() override;
virtual voidSetFillColor( Color nColor ) override;
-virtual voidSetXORMode( bool bSet ) override;
+virtual voidSetXORMode( bool bSet, bool ) override;
virtual voidSetROPLineColor( SalROPColor nROPColor ) override;
virtual voidSetROPFillColor( SalROPColor nROPColor ) override;
diff --git a/vcl/inc/openglgdiimpl.hxx b/vcl/inc/openglgdiimpl.hxx
index bc19dcd338fb..132a64327e42 100644
--- a/vcl/inc/openglgdiimpl.hxx
+++ b/vcl/inc/openglgdiimpl.hxx
@@ -228,7 +228,7 @@ public:
virtual void SetFillColor( Color nColor ) override;
// enable/disable XOR drawing
-virtual void SetXORMode( bool bSet ) override;
+virtual void SetXORMode( bool bSet, bool bInvertOnly ) override;
// set line color for raster operations
virtual void SetROPLineColor( SalROPColor nROPColor ) override;
diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h
index b79bf4425534..cacf56dcb84f 100644
--- a/vcl/inc/quartz/salgdi.h
+++ b/vcl/inc/quartz/salgdi.h
@@ -320,7 +320,7 @@ public:
// filled accordingly
virtual voidSetFillColor( Color nColor ) override;
// enable/disable XOR drawing
-virtual voidSetXORMode( bool bSet ) override;
+virtual voidSetXORMode( bool bSet, bool bInvertOnly ) override;
// set line color for raster operations
virtual voidSetROPLineColor( SalROPColor nROPColor ) override;
// set fill color for raster operations
diff --git a/vcl/inc/salgdi.hxx b/vcl/inc/salgdi.hxx
index d87a09c070b2..c71235816bae 100644
--- a/vcl/inc/salgdi.hxx
+++ b/vcl/inc/salgdi.hxx
@@ -114,7 +114,7 @@ public:
virtual voidSetFillColor( Color nColor ) = 0;
// enable/disable XOR drawing
-virtual voidSetXORMode( bool bSet ) = 0;
+virtual voidSetXORMode( bool bSet, bool bInvertOnly ) = 0;
// set line color for raster operations
virtual voidSetROPLineColor( SalROPColor nROPColor ) = 0;
diff --git a/vcl/inc/salgdiimpl.hxx b/vcl/inc/salgdiimpl.hxx
index d4023bd52947..a6dc4a808ee9 100644
--- a/vcl/inc/salgdiimpl.hxx
+++ b/vcl/inc/salgdiimpl.hxx
@@ -79,7 +79,7 @@ public:
virtual void SetFillColor( Color nColor ) = 0;
// enable/disable XOR drawing
-virtual void SetXORMode( bool bSet ) = 0;
+virtual void SetXORMode( bool bSet, bool bInvertOnly ) = 0;
// set line color for raster operations
virtual void SetROPLineColor( SalROPColor nROPColor ) =
[Libreoffice-bugs] [Bug 121719] Gradient shows separator borders in slideshow mode
https://bugs.documentfoundation.org/show_bug.cgi?id=121719 --- Comment #11 from Commit Notification --- Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/be504e8c7ef06637f055c43ad350381377df1e90%5E%21 tdf#121719: Revert fix for tdf#96971 It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121719] Gradient shows separator borders in slideshow mode
https://bugs.documentfoundation.org/show_bug.cgi?id=121719 Commit Notification changed: What|Removed |Added Whiteboard||target:6.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96971] SetXORMode - remove un-needed parameter ...
https://bugs.documentfoundation.org/show_bug.cgi?id=96971 --- Comment #10 from Commit Notification --- Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/be504e8c7ef06637f055c43ad350381377df1e90%5E%21 tdf#121719: Revert fix for tdf#96971 It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 120992] Selection box should include a grid guide
https://bugs.documentfoundation.org/show_bug.cgi?id=120992 --- Comment #9 from Heiko Tietze --- (In reply to 和尚蟹 from comment #8) > This article has been replaced by another URL from my website below. > Because of the article below, there are better ideas. > https://bugs.documentfoundation.org/show_bug.cgi?id=121843 You mean it can be resolved as a duplicate of bug 121843? Don't get it. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 120992] Selection box should include a grid guide
https://bugs.documentfoundation.org/show_bug.cgi?id=120992 --- Comment #9 from Heiko Tietze --- (In reply to 和尚蟹 from comment #8) > This article has been replaced by another URL from my website below. > Because of the article below, there are better ideas. > https://bugs.documentfoundation.org/show_bug.cgi?id=121843 You mean it can be resolved as a duplicate of bug 121843? Don't get it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83946 Bug 83946 depends on bug 105413, which changed state. Bug 105413 Summary: Any paragraph style applied to a short text in a document with track changes is lost after saving the document https://bugs.documentfoundation.org/show_bug.cgi?id=105413 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sc/source
sc/source/ui/app/inputwin.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b347009a4fb12b01100e97d9577b94449966f873 Author: heiko tietze AuthorDate: Tue Dec 4 11:24:53 2018 +0100 Commit: Heiko Tietze CommitDate: Wed Dec 5 08:10:38 2018 +0100 tdf#117425 - Increase the length of the Name Box drop down menu Now 20 MRU plus... Change-Id: I069021bf1f42da793f7ec79a7e0eacbea519bc14 Reviewed-on: https://gerrit.libreoffice.org/64515 Tested-by: Jenkins Reviewed-by: Heiko Tietze (cherry picked from commit 271a767d9d8f473ef7829cbf16febe656420959c) Reviewed-on: https://gerrit.libreoffice.org/64530 diff --git a/sc/source/ui/app/inputwin.cxx b/sc/source/ui/app/inputwin.cxx index 71abccec99a4..3669d3840793 100644 --- a/sc/source/ui/app/inputwin.cxx +++ b/sc/source/ui/app/inputwin.cxx @@ -1808,7 +1808,7 @@ ScPosWnd::ScPosWnd( vcl::Window* pParent ) : Size aSize( GetTextWidth( "GW9:GW9" ), GetTextHeight() ); aSize.AdjustWidth(25 );// FIXME: ?? -aSize.setHeight( CalcWindowSizePixel(11) ); // Functions: 10 MRU + "others..." +aSize.setHeight( CalcWindowSizePixel(21) ); // Functions: 20 MRU + "others..." SetSizePixel( aSize ); FillRangeNames(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 121620] Opening Image tab of Bullets and Numbering dialog resets selection
https://bugs.documentfoundation.org/show_bug.cgi?id=121620 --- Comment #4 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/253af4f2cfb93a7f8c223661c0c1b7845c1644f0%5E%21 tdf#121620 Opening Image tab of Bullets and Numbering dialog resets selection It will be available in 6.2.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121620] Opening Image tab of Bullets and Numbering dialog resets selection
https://bugs.documentfoundation.org/show_bug.cgi?id=121620 Commit Notification changed: What|Removed |Added Whiteboard|target:6.3.0|target:6.3.0 target:6.2.0.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - cui/source
cui/source/tabpages/numpages.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 253af4f2cfb93a7f8c223661c0c1b7845c1644f0
Author: Noel Grandin
AuthorDate: Mon Dec 3 10:42:01 2018 +0200
Commit: Noel Grandin
CommitDate: Wed Dec 5 08:06:44 2018 +0100
tdf#121620 Opening Image tab of Bullets and Numbering dialog resets
selection
regression from
commit 39e6bae2c4be24a3aad5ef8cd37d3d83c41a4abe
loplugin:useuniqueptr in cui numpages
Change-Id: I77e16880d0590793545da38b7a3c8c5d2626d8f5
Reviewed-on: https://gerrit.libreoffice.org/64441
Tested-by: Jenkins
Reviewed-by: Noel Grandin
(cherry picked from commit c9e70af2bf6dc9427a9c1dd32d5e8ecccd32c3c2)
Reviewed-on: https://gerrit.libreoffice.org/64536
diff --git a/cui/source/tabpages/numpages.cxx b/cui/source/tabpages/numpages.cxx
index 4b8f278b93b4..a6ea4899f3dd 100644
--- a/cui/source/tabpages/numpages.cxx
+++ b/cui/source/tabpages/numpages.cxx
@@ -845,7 +845,7 @@ void SvxBitmapPickTabPage::ActivatePage(const SfxItemSet&
rSet)
}
if(!aGrfNames.empty() &&
-(pActNum && (lcl_IsNumFmtSet(pActNum.get(), nActNumLvl) || bIsPreset)))
+(pActNum && (!lcl_IsNumFmtSet(pActNum.get(), nActNumLvl) ||
bIsPreset)))
{
m_xExamplesVS->SelectItem(1);
NumSelectHdl_Impl(m_xExamplesVS.get());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/uiwriter/data2/tdf105413.fodt | 38 +++
sw/qa/extras/uiwriter/uiwriter2.cxx| 69 +
sw/source/core/edit/edfcol.cxx | 16 ++
3 files changed, 123 insertions(+)
New commits:
commit 1d65ffc5a37be21e0316019b1c96eb9a1c871ac0
Author: László Németh
AuthorDate: Tue Dec 4 21:54:24 2018 +0100
Commit: László Németh
CommitDate: Wed Dec 5 08:02:14 2018 +0100
tdf#105413 track changes: keep paragraph styles
applied in Show Changes mode, instead of losing them
after saving the document or hiding the changes. The bug
occured in paragraphs with directly preceding tracked deletions.
Change-Id: I9a5fd1b82cb7e99884d8807d0abee1fea59d5df3
Reviewed-on: https://gerrit.libreoffice.org/64518
Reviewed-by: László Németh
Tested-by: László Németh
diff --git a/sw/qa/extras/uiwriter/data2/tdf105413.fodt
b/sw/qa/extras/uiwriter/data2/tdf105413.fodt
new file mode 100644
index ..f27ee904d82b
--- /dev/null
+++ b/sw/qa/extras/uiwriter/data2/tdf105413.fodt
@@ -0,0 +1,38 @@
+
+
+http://www.w3.org/1999/xlink;
xmlns:dc="http://purl.org/dc/elements/1.1/;
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0"
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0"
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0"
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0"
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0"
xmlns:math="http://www.w3.org/1998/Math/MathML;
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0"
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0"
xmlns:config="urn:oas
is:names:tc:opendocument:xmlns:config:1.0"
xmlns:ooo="http://openoffice.org/2004/office;
xmlns:ooow="http://openoffice.org/2004/writer;
xmlns:oooc="http://openoffice.org/2004/calc;
xmlns:dom="http://www.w3.org/2001/xml-events;
xmlns:xforms="http://www.w3.org/2002/xforms;
xmlns:xsd="http://www.w3.org/2001/XMLSchema;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xmlns:rpt="http://openoffice.org/2005/report;
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2"
xmlns:xhtml="http://www.w3.org/1999/xhtml;
xmlns:grddl="http://www.w3.org/2003/g/data-view#;
xmlns:officeooo="http://openoffice.org/2009/office;
xmlns:tableooo="http://openoffice.org/2009/table;
xmlns:drawooo="http://openoffice.org/2010/draw;
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0"
xmlns:formx="urn:openoffice:names:
experimental:ooxml-odf-interop:xmlns:form:1.0"
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2"
office:mimetype="application/vnd.oasis.opendocument.text">
+
+
+
+
+
+
+ Ismeretlen szerző
+ 2018-12-03T20:35:00
+
+
+
+
+
+
+ Ismeretlen szerző
+ 2018-12-03T20:34:58
+
+
+
+
+
+
+
+
+
+
+
+ Par1Par2
+
+ Format
this...
+ Par3
+
+
+
+
diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index 0b5daf0f0fa5..0ab26ac25485 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -9,6 +9,8 @@
#include
#include
+#include
+#include
#include
#include
#include
@@ -38,6 +40,7 @@ public:
void testTdf119571();
void testTdf119019();
void testTdf119824();
+void testTdf105413();
CPPUNIT_TEST_SUITE(SwUiWriterTest2);
CPPUNIT_TEST(testRedlineMoveInsertInDelete);
@@ -48,12 +51,30 @@ public:
CPPUNIT_TEST(testTdf119571);
CPPUNIT_TEST(testTdf119019);
CPPUNIT_TEST(testTdf119824);
+CPPUNIT_TEST(testTdf105413);
CPPUNIT_TEST_SUITE_END();
private:
SwDoc* createDoc(const char* pName = nullptr);
};
+static void lcl_dispatchCommand(const uno::Reference&
xComponent,
+const OUString& rCommand,
+const uno::Sequence&
rPropertyValues)
+{
+uno::Reference xController
+= uno::Reference(xComponent,
uno::UNO_QUERY)->getCurrentController();
+CPPUNIT_ASSERT(xController.is());
+uno::Reference xFrame(xController->getFrame(),
uno::UNO_QUERY);
+CPPUNIT_ASSERT(xFrame.is());
+
+uno::Reference xContext =
::comphelper::getProcessComponentContext();
+uno::Reference
xDispatchHelper(frame::DispatchHelper::create(xContext));
+CPPUNIT_ASSERT(xDispatchHelper.is());
+
+xDispatchHelper->executeDispatch(xFrame, rCommand, OUString(), 0,
rPropertyValues);
+}
+
SwDoc* SwUiWriterTest2::createDoc(const char* pName)
{
if (!pName)
@@ -373,6 +394,54 @@ void SwUiWriterTest2::testTdf119824()
CPPUNIT_ASSERT(hasProperty(getRun(getParagraph(3), 6), "RedlineType"));
}
+void
[Libreoffice-commits] core.git: include/sfx2 sc/source sfx2/source sw/source
include/sfx2/bindings.hxx |5 ++---
sc/source/ui/condformat/condformatdlgentry.cxx |2 +-
sfx2/source/dialog/mgetempl.cxx|2 +-
sfx2/source/dialog/templdlg.cxx|2 +-
sw/source/ui/chrdlg/numpara.cxx|2 +-
sw/source/ui/index/cnttab.cxx |4 ++--
6 files changed, 8 insertions(+), 9 deletions(-)
New commits:
commit 9ad04dad665f9bfc054d0db4174f18ce154e20fc
Author: Noel Grandin
AuthorDate: Tue Dec 4 20:02:56 2018 +0200
Commit: Noel Grandin
CommitDate: Wed Dec 5 08:00:23 2018 +0100
remove unused SfxCallMode enum value
Change-Id: Ie092724ac22088d607f6250fbed764269b3707ba
Reviewed-on: https://gerrit.libreoffice.org/64571
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/sfx2/bindings.hxx b/include/sfx2/bindings.hxx
index 5d1e7b5e4089..38a41a25bcee 100644
--- a/include/sfx2/bindings.hxx
+++ b/include/sfx2/bindings.hxx
@@ -55,13 +55,12 @@ enum class SfxCallMode : sal_uInt16
SYNCHRON = 0x01,// synchronously in the same Stackframe
ASYNCHRON = 0x02,// asynchronously via AppEvent
RECORD= 0x04,// take into account while recording
-API = 0x08,// API call (silent)
-MODAL = 0x10 // despite ModalMode
+API = 0x08 // API call (silent)
};
namespace o3tl {
-template<> struct typed_flags: is_typed_flags
+template<> struct typed_flags: is_typed_flags
{};
}
diff --git a/sc/source/ui/condformat/condformatdlgentry.cxx
b/sc/source/ui/condformat/condformatdlgentry.cxx
index f0683d6b302f..2478dfc6323d 100644
--- a/sc/source/ui/condformat/condformatdlgentry.cxx
+++ b/sc/source/ui/condformat/condformatdlgentry.cxx
@@ -495,7 +495,7 @@ void StyleSelect( ListBox& rLbStyle, const ScDocument*
pDoc, SvxFontPrevWindow&
// Execute the "new style" slot, complete with undo and all necessary
updates.
// The return value (SfxUInt16Item) is ignored, look for new styles
instead.
pDisp->ExecuteList(SID_STYLE_NEW,
-SfxCallMode::SYNCHRON | SfxCallMode::RECORD | SfxCallMode::MODAL,
+SfxCallMode::SYNCHRON | SfxCallMode::RECORD,
{ , });
if (bLocked)
diff --git a/sfx2/source/dialog/mgetempl.cxx b/sfx2/source/dialog/mgetempl.cxx
index 73dd20d49cf6..6b80a35e4e23 100644
--- a/sfx2/source/dialog/mgetempl.cxx
+++ b/sfx2/source/dialog/mgetempl.cxx
@@ -372,7 +372,7 @@ bool SfxManageStyleSheetPage::Execute_Impl(
pItems[ nCount++ ] = nullptr;
const SfxPoolItem* pItem = rDispatcher.Execute(
-nId, SfxCallMode::SYNCHRON | SfxCallMode::RECORD | SfxCallMode::MODAL,
+nId, SfxCallMode::SYNCHRON | SfxCallMode::RECORD,
pItems );
return pItem != nullptr;
diff --git a/sfx2/source/dialog/templdlg.cxx b/sfx2/source/dialog/templdlg.cxx
index 45959e32e135..4e9ffe77520d 100644
--- a/sfx2/source/dialog/templdlg.cxx
+++ b/sfx2/source/dialog/templdlg.cxx
@@ -1556,7 +1556,7 @@ bool SfxCommonTemplateDialog_Impl::Execute_Impl(
DeletionWatcher aDeleted(*this);
sal_uInt16 nModi = pModifier ? *pModifier : 0;
const SfxPoolItem* pItem = rDispatcher.Execute(
-nId, SfxCallMode::SYNCHRON | SfxCallMode::RECORD | SfxCallMode::MODAL,
+nId, SfxCallMode::SYNCHRON | SfxCallMode::RECORD,
pItems, nModi );
// Dialog can be destroyed while in Execute() because started
diff --git a/sw/source/ui/chrdlg/numpara.cxx b/sw/source/ui/chrdlg/numpara.cxx
index 0a102586c1e4..5b15c5143c57 100644
--- a/sw/source/ui/chrdlg/numpara.cxx
+++ b/sw/source/ui/chrdlg/numpara.cxx
@@ -328,7 +328,7 @@ bool SwParagraphNumTabPage::ExecuteEditNumStyle_Impl(
pItems[ nCount++ ] = nullptr;
const SfxPoolItem* pItem = rDispatcher.Execute(
-nId, SfxCallMode::SYNCHRON | SfxCallMode::RECORD | SfxCallMode::MODAL,
+nId, SfxCallMode::SYNCHRON | SfxCallMode::RECORD,
pItems );
return pItem != nullptr;
diff --git a/sw/source/ui/index/cnttab.cxx b/sw/source/ui/index/cnttab.cxx
index 94aaf4930544..6dac9f18b8c6 100644
--- a/sw/source/ui/index/cnttab.cxx
+++ b/sw/source/ui/index/cnttab.cxx
@@ -2239,7 +2239,7 @@ IMPL_LINK_NOARG(SwTOXEntryTabPage, EditStyleHdl, Button*,
void)
SfxUInt16Item aFamily(SID_STYLE_FAMILY,
sal_uInt16(SfxStyleFamily::Char));
static_cast(GetTabDialog())->GetWrtShell().
GetView().GetViewFrame()->GetDispatcher()->ExecuteList(SID_STYLE_EDIT,
-SfxCallMode::SYNCHRON|SfxCallMode::MODAL,
+SfxCallMode::SYNCHRON,
{ , });
}
}
@@ -3717,7 +3717,7 @@ IMPL_LINK_NOARG(SwTOXStylesTabPage, EditStyleHdl,
weld::Button&, void)
SfxUInt16Item aFamily(SID_STYLE_FAMILY,
sal_uInt16(SfxStyleFamily::Para));
SwWrtShell& rSh =
static_cast(GetTabDialog())->GetWrtShell();
rSh.GetView().GetViewFrame()->GetDispatcher()->ExecuteList(SID_STYLE_EDIT,
-
[Libreoffice-commits] core.git: 2 commits - include/sot include/svtools sot/source svtools/source
include/sot/exchange.hxx |4
include/svtools/ivctrl.hxx |3
sot/source/base/formats.cxx| 250 ++---
svtools/source/contnr/imivctl1.cxx |5
4 files changed, 128 insertions(+), 134 deletions(-)
New commits:
commit 29df3d5b291e0857d337a311b6ae4054b0bdc026
Author: Noel Grandin
AuthorDate: Tue Dec 4 15:42:28 2018 +0200
Commit: Noel Grandin
CommitDate: Wed Dec 5 08:00:11 2018 +0100
remove unused SotExchangeActionFlags enum values
Change-Id: Iba1e8f24d3ea8f2dbdab0e48b04c7ae57c9c6c8f
Reviewed-on: https://gerrit.libreoffice.org/64570
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/sot/exchange.hxx b/include/sot/exchange.hxx
index 15279ebab582..f76cec123b5c 100644
--- a/include/sot/exchange.hxx
+++ b/include/sot/exchange.hxx
@@ -75,14 +75,12 @@ SOT_DLLPUBLIC bool IsFormatSupported( const
DataFlavorExVector& rDataFlavorExVec
enum class SotExchangeActionFlags {
NONE = 0x,
-KeepPosSize = 0x0200,
InsertImageMap = 0x0400,
ReplaceImageMap = 0x0800,
-Fill = 0x1000,
InsertTargetUrl = 0x2000,
};
namespace o3tl {
-template<> struct typed_flags :
is_typed_flags {};
+template<> struct typed_flags :
is_typed_flags {};
}
// destinations
diff --git a/sot/source/base/formats.cxx b/sot/source/base/formats.cxx
index cc8ea22feaaa..16b7bd3a87ce 100644
--- a/sot/source/base/formats.cxx
+++ b/sot/source/base/formats.cxx
@@ -352,17 +352,17 @@ SotAction_Impl const aEXCHG_DEST_DOC_GRAPHOBJ_Def[] =
};
SotAction_Impl const aEXCHG_DEST_DOC_GRAPHOBJ_Move[] =
{
-{ SotClipboardFormatId::DRAWING, EXCHG_OUT_ACTION_REPLACE_DRAWOBJ,
SotExchangeActionFlags::InsertImageMap | SotExchangeActionFlags::KeepPosSize |
SotExchangeActionFlags::InsertTargetUrl, 0 },
-{ SotClipboardFormatId::SVXB, EXCHG_OUT_ACTION_REPLACE_SVXB,
SotExchangeActionFlags::InsertImageMap | SotExchangeActionFlags::KeepPosSize |
SotExchangeActionFlags::InsertTargetUrl, 0 },
-{ SotClipboardFormatId::GDIMETAFILE, EXCHG_OUT_ACTION_REPLACE_GDIMETAFILE,
SotExchangeActionFlags::InsertImageMap | SotExchangeActionFlags::KeepPosSize |
SotExchangeActionFlags::InsertTargetUrl, 0 },
-{ SotClipboardFormatId::PNG, EXCHG_OUT_ACTION_REPLACE_BITMAP,
SotExchangeActionFlags::InsertImageMap | SotExchangeActionFlags::KeepPosSize |
SotExchangeActionFlags::InsertTargetUrl, 0 },
-{ SotClipboardFormatId::JPEG, EXCHG_OUT_ACTION_REPLACE_BITMAP,
SotExchangeActionFlags::InsertImageMap | SotExchangeActionFlags::KeepPosSize |
SotExchangeActionFlags::InsertTargetUrl, 0 },
-{ SotClipboardFormatId::BITMAP, EXCHG_OUT_ACTION_REPLACE_BITMAP,
SotExchangeActionFlags::InsertImageMap | SotExchangeActionFlags::KeepPosSize |
SotExchangeActionFlags::InsertTargetUrl, 0 },
-{ SotClipboardFormatId::SOLK, EXCHG_OUT_ACTION_REPLACE_GRAPH,
SotExchangeActionFlags::InsertImageMap | SotExchangeActionFlags::KeepPosSize |
SotExchangeActionFlags::InsertTargetUrl, 0 },
-{ SotClipboardFormatId::NETSCAPE_BOOKMARK, EXCHG_OUT_ACTION_REPLACE_GRAPH,
SotExchangeActionFlags::InsertImageMap | SotExchangeActionFlags::KeepPosSize |
SotExchangeActionFlags::InsertTargetUrl, 0 },
-{ SotClipboardFormatId::FILEGRPDESCRIPTOR, EXCHG_OUT_ACTION_REPLACE_GRAPH,
SotExchangeActionFlags::InsertImageMap | SotExchangeActionFlags::KeepPosSize |
SotExchangeActionFlags::InsertTargetUrl, FILEGRPDSC_ONLY_URL },
-{ SotClipboardFormatId::UNIFORMRESOURCELOCATOR,
EXCHG_OUT_ACTION_REPLACE_GRAPH, SotExchangeActionFlags::InsertImageMap |
SotExchangeActionFlags::KeepPosSize | SotExchangeActionFlags::InsertTargetUrl,
0 },
-{ SotClipboardFormatId::SIMPLE_FILE, EXCHG_OUT_ACTION_REPLACE_GRAPH,
SotExchangeActionFlags::InsertImageMap | SotExchangeActionFlags::KeepPosSize |
SotExchangeActionFlags::InsertTargetUrl, 0 },
+{ SotClipboardFormatId::DRAWING, EXCHG_OUT_ACTION_REPLACE_DRAWOBJ,
SotExchangeActionFlags::InsertImageMap |
SotExchangeActionFlags::InsertTargetUrl, 0 },
+{ SotClipboardFormatId::SVXB, EXCHG_OUT_ACTION_REPLACE_SVXB,
SotExchangeActionFlags::InsertImageMap |
SotExchangeActionFlags::InsertTargetUrl, 0 },
+{ SotClipboardFormatId::GDIMETAFILE, EXCHG_OUT_ACTION_REPLACE_GDIMETAFILE,
SotExchangeActionFlags::InsertImageMap |
SotExchangeActionFlags::InsertTargetUrl, 0 },
+{ SotClipboardFormatId::PNG, EXCHG_OUT_ACTION_REPLACE_BITMAP,
SotExchangeActionFlags::InsertImageMap |
SotExchangeActionFlags::InsertTargetUrl, 0 },
+{ SotClipboardFormatId::JPEG, EXCHG_OUT_ACTION_REPLACE_BITMAP,
SotExchangeActionFlags::InsertImageMap |
SotExchangeActionFlags::InsertTargetUrl, 0 },
+{ SotClipboardFormatId::BITMAP, EXCHG_OUT_ACTION_REPLACE_BITMAP,
SotExchangeActionFlags::InsertImageMap |
SotExchangeActionFlags::InsertTargetUrl, 0 },
+{ SotClipboardFormatId::SOLK, EXCHG_OUT_ACTION_REPLACE_GRAPH,
SotExchangeActionFlags::InsertImageMap |
[Libreoffice-commits] core.git: 2 commits - include/svx sc/inc sc/source svx/source
include/svx/galmisc.hxx |3 +--
include/svx/shapeproperty.hxx|4 +---
sc/inc/shapeuno.hxx |1 -
sc/source/ui/unoobj/shapeuno.cxx | 26 +-
svx/source/gallery2/galtheme.cxx |4
5 files changed, 3 insertions(+), 35 deletions(-)
New commits:
commit 39ea830ef5f060586d4674ffce9915dc352af0fc
Author: Noel Grandin
AuthorDate: Tue Dec 4 11:14:12 2018 +0200
Commit: Noel Grandin
CommitDate: Wed Dec 5 07:59:49 2018 +0100
remove unused GalleryHintType enum value
Change-Id: If4149e8b4a6e58f89997b150cc81e2e1195be4da
Reviewed-on: https://gerrit.libreoffice.org/64567
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/svx/galmisc.hxx b/include/svx/galmisc.hxx
index 2c21b09ae822..d586325cc9a8 100644
--- a/include/svx/galmisc.hxx
+++ b/include/svx/galmisc.hxx
@@ -168,8 +168,7 @@ enum class GalleryHintType
THEME_RENAMED,
THEME_CREATED,
THEME_UPDATEVIEW,
-CLOSE_OBJECT,
-OBJECT_REMOVED,
+CLOSE_OBJECT
};
class GalleryHint : public SfxHint
diff --git a/svx/source/gallery2/galtheme.cxx b/svx/source/gallery2/galtheme.cxx
index f782081b30a1..b6118c7bb2d2 100644
--- a/svx/source/gallery2/galtheme.cxx
+++ b/svx/source/gallery2/galtheme.cxx
@@ -82,7 +82,6 @@ GalleryTheme::~GalleryTheme()
for (auto & pEntry : aObjectList)
{
Broadcast( GalleryHint( GalleryHintType::CLOSE_OBJECT, GetName(),
pEntry.get() ) );
-Broadcast( GalleryHint( GalleryHintType::OBJECT_REMOVED, GetName(),
pEntry.get() ) );
pEntry.reset();
}
aObjectList.clear();
@@ -445,7 +444,6 @@ void GalleryTheme::RemoveObject(sal_uInt32 nPos)
aSvDrawStorageRef->Remove( pEntry->aURL.GetMainURL(
INetURLObject::DecodeMechanism::NONE ) );
Broadcast( GalleryHint( GalleryHintType::CLOSE_OBJECT, GetName(),
pEntry.get() ) );
-Broadcast( GalleryHint( GalleryHintType::OBJECT_REMOVED, GetName(),
pEntry.get() ) );
pEntry.reset();
ImplSetModified( true );
@@ -562,7 +560,6 @@ void GalleryTheme::Actualize( const Link& rActualize
if( (*it)->mbDelete )
{
Broadcast( GalleryHint( GalleryHintType::CLOSE_OBJECT, GetName(),
it->get() ) );
-Broadcast( GalleryHint( GalleryHintType::OBJECT_REMOVED,
GetName(), it->get() ) );
it = aObjectList.erase( it );
}
else
@@ -1350,7 +1347,6 @@ SvStream& GalleryTheme::ReadData( SvStream& rIStm )
{
GalleryObject* pObj = i.get();
Broadcast( GalleryHint( GalleryHintType::CLOSE_OBJECT, GetName(),
pObj ) );
-Broadcast( GalleryHint( GalleryHintType::OBJECT_REMOVED,
GetName(), pObj ) );
i.reset();
}
aObjectList.clear();
commit 00f731038fd64c8b29c94614560e38d696ba
Author: Noel Grandin
AuthorDate: Tue Dec 4 11:03:29 2018 +0200
Commit: Noel Grandin
CommitDate: Wed Dec 5 07:59:37 2018 +0100
remove unused svx::ShapeProperty enum value
Change-Id: Iafc65902ed00206ff80dfc135c1ae767893abeca
Reviewed-on: https://gerrit.libreoffice.org/64566
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/svx/shapeproperty.hxx b/include/svx/shapeproperty.hxx
index 56a71fdd3aef..bb0011199447 100644
--- a/include/svx/shapeproperty.hxx
+++ b/include/svx/shapeproperty.hxx
@@ -32,9 +32,7 @@ namespace svx
Position,
Size,
// text doc shape properties
-TextDocAnchor,
-// spreadsheet doc shape properties
-CalcDocAnchor
+TextDocAnchor
};
}
diff --git a/sc/inc/shapeuno.hxx b/sc/inc/shapeuno.hxx
index e3ce7f2855d8..e4678427c762 100644
--- a/sc/inc/shapeuno.hxx
+++ b/sc/inc/shapeuno.hxx
@@ -70,7 +70,6 @@ private:
css::uno::Reference< css::beans::XPropertySetInfo >mxPropSetInfo;
bool bIsTextShape;
bool bIsNoteCaption;
-bool
bInitializedNotifier;
SdrObject* GetSdrObject() const throw();
diff --git a/sc/source/ui/unoobj/shapeuno.cxx b/sc/source/ui/unoobj/shapeuno.cxx
index 49ce7146ccd1..1468ef39e831 100644
--- a/sc/source/ui/unoobj/shapeuno.cxx
+++ b/sc/source/ui/unoobj/shapeuno.cxx
@@ -82,21 +82,11 @@ ScMacroInfo* ScShapeObj_getShapeHyperMacroInfo( const
ScShapeObj* pShape, bool b
return nullptr;
}
-namespace
-{
-void lcl_initializeNotifier( SdrObject& _rSdrObj, ::cppu::OWeakObject&
_rShape )
-{
-std::shared_ptr pProvider( new
svx::PropertyValueProvider( _rShape, "Anchor" ) );
-_rSdrObj.getShapePropertyChangeNotifier().registerProvider(
svx::ShapeProperty::CalcDocAnchor, pProvider );
-}
-}
-
ScShapeObj::ScShapeObj( uno::Reference& xShape ) :
pShapePropertySet(nullptr),
pShapePropertyState(nullptr),
bIsTextShape(false),
-
[Libreoffice-bugs] [Bug 114266] EDITING: HANG if copy / paste very big number of cells with conditional formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=114266 --- Comment #5 from Rainer Bielefeld Retired --- As expected still REPRODUCIBLE with Version: 6.0.5.2 (x64) Build-ID: 54c8cbb85f300ac59db32fe8a675ff7683cd5a16 CPU-Threads: 4; BS: Windows 6.1; UI-Render: Standard; -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - forms/source include/svx include/tools svl/source svx/source sw/source tools/source unotools/source
forms/source/component/imgprod.cxx |6 +++---
include/svx/svdograf.hxx |9 -
include/tools/stream.hxx |4 +---
svl/source/items/lckbitem.cxx |2 +-
svx/source/svdraw/svdedtv2.cxx |2 +-
svx/source/svdraw/svdograf.cxx |2 +-
sw/source/uibase/app/docsh2.cxx|4 ++--
tools/source/stream/stream.cxx |4 ++--
unotools/source/streaming/streamhelper.cxx |2 +-
unotools/source/ucbhelper/ucblockbytes.cxx |4 ++--
unotools/source/ucbhelper/ucblockbytes.hxx |2 +-
11 files changed, 19 insertions(+), 22 deletions(-)
New commits:
commit 307b746cd41fa5bf971573dd7665108def4e298b
Author: Noel Grandin
AuthorDate: Tue Dec 4 10:16:05 2018 +0200
Commit: Noel Grandin
CommitDate: Wed Dec 5 07:52:29 2018 +0100
remove unused SdrGrafObjTransformsAttrs enum value
Change-Id: I6b6808362ff08c5af3b0d294a80cfe79505a9710
Reviewed-on: https://gerrit.libreoffice.org/64563
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/svx/svdograf.hxx b/include/svx/svdograf.hxx
index c3e2ae0c1874..4b50d122b256 100644
--- a/include/svx/svdograf.hxx
+++ b/include/svx/svdograf.hxx
@@ -47,14 +47,13 @@ namespace sdr
enum class SdrGrafObjTransformsAttrs
{
NONE = 0x00,
-COLOR = 0x01,
-MIRROR = 0x02,
-ROTATE = 0x04,
-ALL= 0x07,
+MIRROR = 0x01,
+ROTATE = 0x02,
+ALL= 0x03,
};
namespace o3tl
{
-template<> struct typed_flags :
is_typed_flags {};
+template<> struct typed_flags :
is_typed_flags {};
}
class SdrGrafObjGeoData : public SdrTextObjGeoData
diff --git a/svx/source/svdraw/svdedtv2.cxx b/svx/source/svdraw/svdedtv2.cxx
index 732bd1ce63f8..441ea9ba4bda 100644
--- a/svx/source/svdraw/svdedtv2.cxx
+++ b/svx/source/svdraw/svdedtv2.cxx
@@ -1999,7 +1999,7 @@ namespace
GDIMetaFile GetMetaFile(SdrGrafObj const * pGraf)
{
if (pGraf->HasGDIMetaFile())
-return
pGraf->GetTransformedGraphic(SdrGrafObjTransformsAttrs::COLOR|SdrGrafObjTransformsAttrs::MIRROR).GetGDIMetaFile();
+return
pGraf->GetTransformedGraphic(SdrGrafObjTransformsAttrs::MIRROR).GetGDIMetaFile();
assert(pGraf->isEmbeddedVectorGraphicData());
return pGraf->getMetafileFromEmbeddedVectorGraphicData();
}
diff --git a/svx/source/svdraw/svdograf.cxx b/svx/source/svdraw/svdograf.cxx
index bcc4f1098a51..1bf7cbfbbfa2 100644
--- a/svx/source/svdraw/svdograf.cxx
+++ b/svx/source/svdraw/svdograf.cxx
@@ -880,7 +880,7 @@ GDIMetaFile SdrGrafObj::GetMetaFile(GraphicType
) const
}
else if (GraphicType::GdiMetafile == rGraphicType)
{
-return
GetTransformedGraphic(SdrGrafObjTransformsAttrs::COLOR|SdrGrafObjTransformsAttrs::MIRROR).GetGDIMetaFile();
+return
GetTransformedGraphic(SdrGrafObjTransformsAttrs::MIRROR).GetGDIMetaFile();
}
return GDIMetaFile();
}
commit 36b21429c2c423271786e29c6a480b4b689a8ab8
Author: Noel Grandin
AuthorDate: Tue Dec 4 09:49:13 2018 +0200
Commit: Noel Grandin
CommitDate: Wed Dec 5 07:52:16 2018 +0100
remove unused SvLockBytesStatFlag enum
Change-Id: I90b82f1bbf4b51fc76cde10ec55448053345018c
Reviewed-on: https://gerrit.libreoffice.org/64561
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/forms/source/component/imgprod.cxx
b/forms/source/component/imgprod.cxx
index dc51b5ef47e2..c4ae8ee9e008 100644
--- a/forms/source/component/imgprod.cxx
+++ b/forms/source/component/imgprod.cxx
@@ -48,7 +48,7 @@ public:
virtual ErrCode WriteAt( sal_uInt64 nPos, const void* pBuffer,
std::size_t nCount, std::size_t * pWritten ) override;
virtual ErrCode Flush() const override;
virtual ErrCode SetSize( sal_uInt64 nSize ) override;
-virtual ErrCode Stat( SvLockBytesStat*, SvLockBytesStatFlag ) const
override;
+virtual ErrCode Stat( SvLockBytesStat* ) const override;
};
@@ -144,10 +144,10 @@ ErrCode ImgProdLockBytes::SetSize(sal_uInt64 const nSize)
}
-ErrCode ImgProdLockBytes::Stat( SvLockBytesStat* pStat, SvLockBytesStatFlag
eFlag ) const
+ErrCode ImgProdLockBytes::Stat( SvLockBytesStat* pStat ) const
{
if( GetStream() )
-return SvLockBytes::Stat( pStat, eFlag );
+return SvLockBytes::Stat( pStat );
else
{
DBG_ASSERT( xStmRef.is(), "ImgProdLockBytes::Stat: xInputStream has no
reference..." );
diff --git a/include/tools/stream.hxx b/include/tools/stream.hxx
index 42f4231addd7..ea3e53d21ff9 100644
--- a/include/tools/stream.hxx
+++ b/include/tools/stream.hxx
@@ -94,8 +94,6 @@ struct SvLockBytesStat
SvLockBytesStat() : nSize(0) {}
};
-enum SvLockBytesStatFlag { SVSTATFLAG_DEFAULT };
-
class TOOLS_DLLPUBLIC SvLockBytes: public virtual SvRefBase
{
SvStream * m_pStream;
@@ -128,7 +126,7 @@ public:
virtual ErrCode SetSize(sal_uInt64 nSize);
-
[Libreoffice-commits] core.git: include/svx sc/source sd/source svx/source
include/svx/svdmodel.hxx | 15 ---
sc/source/ui/app/drwtrans.cxx | 11 ---
sd/source/filter/sdpptwrp.cxx |2 --
sd/source/ui/app/sdxfer.cxx| 16
sd/source/ui/docshell/docshel3.cxx |4
sd/source/ui/docshell/docshel4.cxx |6 --
svx/source/svdraw/svdmodel.cxx |1 -
7 files changed, 55 deletions(-)
New commits:
commit a04e615e1f9371401946c7c89d7ec439ce92cfec
Author: Noel Grandin
AuthorDate: Tue Dec 4 10:47:21 2018 +0200
Commit: Noel Grandin
CommitDate: Wed Dec 5 07:52:42 2018 +0100
remove unused SdrSwapGraphicsMode enum
Change-Id: Iec7660563e96f821f72caae5047820f425ca69fb
Reviewed-on: https://gerrit.libreoffice.org/64565
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/svx/svdmodel.hxx b/include/svx/svdmodel.hxx
index 8cb3c6c25a2c..5cddb416791f 100644
--- a/include/svx/svdmodel.hxx
+++ b/include/svx/svdmodel.hxx
@@ -97,18 +97,6 @@ namespace sfx2
}
-enum class SdrSwapGraphicsMode
-{
-TEMP = 0x0001,
-PURGE = 0x0100,
-DEFAULT= TEMP | PURGE,
-};
-namespace o3tl
-{
-template<> struct typed_flags :
is_typed_flags {};
-}
-
-
enum class SdrHintKind
{
LayerChange, // changed layer definition
@@ -231,7 +219,6 @@ protected:
public:
std::shared_ptr mpForbiddenCharactersTable;
-SdrSwapGraphicsMode nSwapGraphicsMode;
std::unique_ptr mpOutlinerCache;
//get a vector of all the SdrOutliner belonging to the model
@@ -446,8 +433,6 @@ public:
// Default=FALSE. Flag is not persistent.
boolIsSwapGraphics() const { return bSwapGraphics; }
voidSetSwapGraphics();
-voidSetSwapGraphicsMode(SdrSwapGraphicsMode nMode) {
nSwapGraphicsMode = nMode; }
-SdrSwapGraphicsMode GetSwapGraphicsMode() const { return
nSwapGraphicsMode; }
// Text frames without filling can be select with a mouse click by default
(sal_False).
// With this flag set to true you can hit them only in the area in which
text is to be
diff --git a/sc/source/ui/app/drwtrans.cxx b/sc/source/ui/app/drwtrans.cxx
index a73b474ad477..59cb1ac4454f 100644
--- a/sc/source/ui/app/drwtrans.cxx
+++ b/sc/source/ui/app/drwtrans.cxx
@@ -362,19 +362,8 @@ bool ScDrawTransferObj::GetData( const
css::datatransfer::DataFlavor& rFlavor, c
if( m_aOleData.GetTransferable().is() && m_aOleData.HasFormat( rFlavor
) )
{
-SdrSwapGraphicsMode nOldSwapMode(SdrSwapGraphicsMode::DEFAULT);
-
-if( m_pModel )
-{
-nOldSwapMode = m_pModel->GetSwapGraphicsMode();
-m_pModel->SetSwapGraphicsMode( SdrSwapGraphicsMode::PURGE );
-}
-
bOK = SetAny( m_aOleData.GetAny(rFlavor, rDestDoc) );
-if( m_pModel )
-m_pModel->SetSwapGraphicsMode( nOldSwapMode );
-
return bOK;
}
}
diff --git a/sd/source/filter/sdpptwrp.cxx b/sd/source/filter/sdpptwrp.cxx
index 0eaf9934a22b..e2966aab3e8b 100644
--- a/sd/source/filter/sdpptwrp.cxx
+++ b/sd/source/filter/sdpptwrp.cxx
@@ -148,8 +148,6 @@ bool SdPPTFilter::Export()
if ( rFilterOptions.IsEnablePPTPreview() )
nCnvrtFlags |= 0x8000;
-mrDocument.SetSwapGraphicsMode( SdrSwapGraphicsMode::TEMP );
-
CreateStatusIndicator();
//OUString sBaseURI( "BaseURI");
diff --git a/sd/source/ui/app/sdxfer.cxx b/sd/source/ui/app/sdxfer.cxx
index 2c873604aa30..560f5f0bee7d 100644
--- a/sd/source/ui/app/sdxfer.cxx
+++ b/sd/source/ui/app/sdxfer.cxx
@@ -457,22 +457,11 @@ bool SdTransferable::GetData( const DataFlavor& rFlavor,
const OUString& rDestDo
}
else if( mpOLEDataHelper && mpOLEDataHelper->HasFormat( rFlavor ) )
{
-SdrSwapGraphicsMode nOldSwapMode(SdrSwapGraphicsMode::DEFAULT);
-
-if( mpSdDrawDocumentIntern )
-{
-nOldSwapMode = mpSdDrawDocumentIntern->GetSwapGraphicsMode();
-mpSdDrawDocumentIntern->SetSwapGraphicsMode(
SdrSwapGraphicsMode::PURGE );
-}
-
// TODO/LATER: support all the graphical formats, the embedded object
scenario should not have separated handling
if( nFormat == SotClipboardFormatId::GDIMETAFILE && mpGraphic )
bOK = SetGDIMetaFile( mpGraphic->GetGDIMetaFile() );
else
bOK = SetAny( mpOLEDataHelper->GetAny(rFlavor, rDestDoc) );
-
-if( mpSdDrawDocumentIntern )
-mpSdDrawDocumentIntern->SetSwapGraphicsMode( nOldSwapMode );
}
else if( HasFormat( nFormat ) )
{
@@ -551,9 +540,6 @@ bool SdTransferable::GetData( const DataFlavor& rFlavor,
const OUString& rDestDo
{
if( mpSdDrawDocumentIntern )
{
-SdrSwapGraphicsMode nOldSwapMode =
mpSdDrawDocumentIntern->GetSwapGraphicsMode();
-mpSdDrawDocumentIntern->SetSwapGraphicsMode(
[Libreoffice-commits] core.git: 2 commits - include/vcl vcl/source
include/vcl/vclevent.hxx |4
include/vcl/window.hxx |1 -
vcl/source/control/listbox.cxx |5 +
vcl/source/window/status.cxx |2 --
vcl/source/window/window.cxx |4
5 files changed, 1 insertion(+), 15 deletions(-)
New commits:
commit f22f5a8a1c25d0a68d64d82bd824f5e153cf9959
Author: Noel Grandin
AuthorDate: Tue Dec 4 09:40:38 2018 +0200
Commit: Noel Grandin
CommitDate: Wed Dec 5 07:52:02 2018 +0100
remove unused StateChangedType enum value
Change-Id: I5b241e35af90cc5c0a2df15e596bb5d45f110e52
Reviewed-on: https://gerrit.libreoffice.org/64560
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/vcl/window.hxx b/include/vcl/window.hxx
index 60389e836aa9..02b59375423c 100644
--- a/include/vcl/window.hxx
+++ b/include/vcl/window.hxx
@@ -331,7 +331,6 @@ enum class StateChangedType : sal_uInt16
ControlForeground = 14,
ControlBackground = 15,
ReadOnly = 16,
-ExtendedStyle = 17,
Mirroring = 18,
Layout = 19,
ControlFocus = 20
diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index e57d446709d1..38cd829661d8 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -1948,7 +1948,6 @@ void Window::SetExtendedStyle( WindowExtendedStyle
nExtendedStyle )
pWindow->ImplGetFrame()->SetExtendedFrameStyle( nExt );
}
mpWindowImpl->mnExtendedStyle = nExtendedStyle;
-CompatStateChanged( StateChangedType::ExtendedStyle );
}
}
commit 0adbc69c81cc287386b31b25b2dc89780933e2b1
Author: Noel Grandin
AuthorDate: Tue Dec 4 09:33:17 2018 +0200
Commit: Noel Grandin
CommitDate: Wed Dec 5 07:51:48 2018 +0100
remove unused VclEventId enum values
Change-Id: I7887a7de37a024f2e97dbd20a27a1aa3fdfcfbfa
Reviewed-on: https://gerrit.libreoffice.org/64559
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/vcl/vclevent.hxx b/include/vcl/vclevent.hxx
index 698fd038bbde..26cf1a681c2b 100644
--- a/include/vcl/vclevent.hxx
+++ b/include/vcl/vclevent.hxx
@@ -69,7 +69,6 @@ enum class VclEventId
ListboxItemRemoved, // pData = itempos, -1=All
ListboxScrolled,
ListboxSelect,
-ListboxStateUpdate,
ListboxTreeFocus,
ListboxTreeSelect,
MenuActivate,
@@ -102,8 +101,6 @@ enum class VclEventId
SpinfieldLast,
SpinfieldUp,
StatusbarAllItemsRemoved,
-StatusbarClick,
-StatusbarDoubleClick,
StatusbarDrawItem, // pData = itemid
StatusbarHideItem, // pData = itemid
StatusbarItemAdded, // pData = itemid
@@ -143,7 +140,6 @@ enum class VclEventId
ToolboxItemWindowChanged,
ToolboxSelect,
WindowActivate,
-WindowChildCreated, // pData = vcl::Window*
WindowChildDestroyed, // pData = vcl::Window*
WindowClose,
WindowCommand, // pData = CommandEvent*
diff --git a/vcl/source/control/listbox.cxx b/vcl/source/control/listbox.cxx
index e109e135d0d4..3a048a3fedb8 100644
--- a/vcl/source/control/listbox.cxx
+++ b/vcl/source/control/listbox.cxx
@@ -946,7 +946,6 @@ void ListBox::SetNoSelection()
mpImplWin->SetImage( aImage );
mpImplWin->Invalidate();
}
-CallEventListeners(VclEventId::ListboxStateUpdate);
}
sal_Int32 ListBox::InsertEntry( const OUString& rStr, sal_Int32 nPos )
@@ -1066,11 +1065,9 @@ void ListBox::SelectEntryPos( sal_Int32 nPos, bool
bSelect )
if ( 0 <= nPos && nPos < mpImplLB->GetEntryList()->GetEntryCount() )
{
-sal_Int32 oldSelectCount = GetSelectedEntryCount(), newSelectCount =
0, nCurrentPos = mpImplLB->GetCurrentPos();
+sal_Int32 newSelectCount = 0, nCurrentPos = mpImplLB->GetCurrentPos();
mpImplLB->SelectEntry( nPos + mpImplLB->GetEntryList()->GetMRUCount(),
bSelect );
newSelectCount = GetSelectedEntryCount();
-if (oldSelectCount == 0 && newSelectCount > 0)
-CallEventListeners(VclEventId::ListboxStateUpdate);
//Only when bSelect == true, send both Selection & Focus events
if (nCurrentPos != nPos && bSelect)
{
diff --git a/vcl/source/window/status.cxx b/vcl/source/window/status.cxx
index be83ef42282c..723ab9d07b4f 100644
--- a/vcl/source/window/status.cxx
+++ b/vcl/source/window/status.cxx
@@ -874,13 +874,11 @@ void StatusBar::DataChanged( const DataChangedEvent&
rDCEvt )
void StatusBar::Click()
{
-CallEventListeners( VclEventId::StatusbarClick );
maClickHdl.Call( this );
}
void StatusBar::DoubleClick()
{
-CallEventListeners( VclEventId::StatusbarDoubleClick );
maDoubleClickHdl.Call( this );
}
diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index 11fd8d5f482e..e57d446709d1 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -1159,9 +1159,6 @@ void Window::ImplInit( vcl::Window* pParent, WinBits
nStyle,
[Libreoffice-commits] core.git: 2 commits - include/vcl sc/source sw/source vcl/source vcl/workben
include/vcl/GraphicObject.hxx | 17 +
include/vcl/outdev.hxx|7 +++
include/vcl/salgtype.hxx |7 +++
sc/source/ui/view/printfun.cxx|1 -
sw/source/core/layout/paintfrm.cxx|1 -
vcl/source/graphic/GraphicObject.cxx |4 ++--
vcl/source/graphic/GraphicObject2.cxx | 16
vcl/source/outdev/rect.cxx|4
vcl/workben/vcldemo.cxx |1 -
9 files changed, 17 insertions(+), 41 deletions(-)
New commits:
commit 6ba25b96e6187931c0651f099413dbf1e2a7ab97
Author: Noel Grandin
AuthorDate: Tue Dec 4 09:16:04 2018 +0200
Commit: Noel Grandin
CommitDate: Wed Dec 5 07:51:32 2018 +0100
remove unused InvertFlags::Highlight
Change-Id: Id881142f39a6160b8040d0446476767aad83f260
Reviewed-on: https://gerrit.libreoffice.org/64558
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index 0d6b80eb6bc2..1d4a936e22a6 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -267,13 +267,12 @@ namespace o3tl
enum class InvertFlags
{
NONE= 0x,
-Highlight = 0x0001,
-N50 = 0x0002,
-TrackFrame = 0x0004
+N50 = 0x0001,
+TrackFrame = 0x0002
};
namespace o3tl
{
-template<> struct typed_flags : is_typed_flags {};
+template<> struct typed_flags : is_typed_flags {};
}
enum OutDevType { OUTDEV_WINDOW, OUTDEV_PRINTER, OUTDEV_VIRDEV, OUTDEV_PDF };
diff --git a/include/vcl/salgtype.hxx b/include/vcl/salgtype.hxx
index d920ede00dac..a373a0a62d07 100644
--- a/include/vcl/salgtype.hxx
+++ b/include/vcl/salgtype.hxx
@@ -84,13 +84,12 @@ enum class SalROPColor {
enum class SalInvert {
NONE = 0x00,
-Highlight = 0x01,
-N50= 0x02,
-TrackFrame = 0x04
+N50= 0x01,
+TrackFrame = 0x02
};
namespace o3tl
{
-template<> struct typed_flags : is_typed_flags
{};
+template<> struct typed_flags : is_typed_flags
{};
}
#endif // INCLUDED_VCL_SALGTYPE_HXX
diff --git a/vcl/source/outdev/rect.cxx b/vcl/source/outdev/rect.cxx
index 0770b68db5b6..67343278a1be 100644
--- a/vcl/source/outdev/rect.cxx
+++ b/vcl/source/outdev/rect.cxx
@@ -149,8 +149,6 @@ void OutputDevice::Invert( const tools::Rectangle& rRect,
InvertFlags nFlags )
return;
SalInvert nSalFlags = SalInvert::NONE;
-if ( nFlags & InvertFlags::Highlight )
-nSalFlags |= SalInvert::Highlight;
if ( nFlags & InvertFlags::N50 )
nSalFlags |= SalInvert::N50;
if ( nFlags & InvertFlags::TrackFrame )
@@ -182,8 +180,6 @@ void OutputDevice::Invert( const tools::Polygon& rPoly,
InvertFlags nFlags )
return;
SalInvert nSalFlags = SalInvert::NONE;
-if ( nFlags & InvertFlags::Highlight )
-nSalFlags |= SalInvert::Highlight;
if ( nFlags & InvertFlags::N50 )
nSalFlags |= SalInvert::N50;
if ( nFlags & InvertFlags::TrackFrame )
diff --git a/vcl/workben/vcldemo.cxx b/vcl/workben/vcldemo.cxx
index b14bc4d96c80..27950196282b 100644
--- a/vcl/workben/vcldemo.cxx
+++ b/vcl/workben/vcldemo.cxx
@@ -767,7 +767,6 @@ public:
auto aRegions = partition(rCtx, 2, 2);
doInvert(rDev, aRegions[0], InvertFlags::NONE);
doInvert(rDev, aRegions[1], InvertFlags::N50);
-doInvert(rDev, aRegions[2], InvertFlags::Highlight);
doInvert(rDev, aRegions[3], InvertFlags::TrackFrame);
}
}
commit df55a6ca81848a5a095f08ae5265186d38176d40
Author: Noel Grandin
AuthorDate: Tue Dec 4 08:37:09 2018 +0200
Commit: Noel Grandin
CommitDate: Wed Dec 5 07:51:19 2018 +0100
remove unused GraphicManagerDrawFlags enum
Change-Id: I12ef5e6257db337c4432b251bc92107a2c2ea88b
Reviewed-on: https://gerrit.libreoffice.org/64557
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/vcl/GraphicObject.hxx b/include/vcl/GraphicObject.hxx
index 854cc14ec6fd..9ffbd9a73ba2 100644
--- a/include/vcl/GraphicObject.hxx
+++ b/include/vcl/GraphicObject.hxx
@@ -27,17 +27,6 @@
namespace com { namespace sun { namespace star { namespace graphic { class
XGraphic; } } } }
namespace o3tl { template struct typed_flags; }
-enum class GraphicManagerDrawFlags
-{
-CACHED = 0x01,
-SMOOTHSCALE = 0x02,
-STANDARD= CACHED | SMOOTHSCALE,
-};
-namespace o3tl
-{
-template<> struct typed_flags :
is_typed_flags {};
-}
-
// Adjustment defines
enum class GraphicAdjustmentFlags
{
@@ -214,8 +203,7 @@ private:
int nNumTilesX,
int nNumTilesY,
const Size& rTileSizePixel,
-const GraphicAttr* pAttr,
-
[Libreoffice-commits] core.git: sot/source
sot/source/sdstor/ucbstorage.cxx | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
New commits:
commit 73d667e3a0db5f0d3ee1f9d001b6220190c02bfa
Author: Noel Grandin
AuthorDate: Tue Dec 4 14:56:10 2018 +0200
Commit: Noel Grandin
CommitDate: Wed Dec 5 07:50:21 2018 +0100
use unique_ptr in UCBStorage_Impl
Change-Id: Iec07d23087dafd34a6c777a7c1825ebc9cbe7858
Reviewed-on: https://gerrit.libreoffice.org/64525
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sot/source/sdstor/ucbstorage.cxx b/sot/source/sdstor/ucbstorage.cxx
index 98633c9fec72..c4136ade6ddf 100644
--- a/sot/source/sdstor/ucbstorage.cxx
+++ b/sot/source/sdstor/ucbstorage.cxx
@@ -455,8 +455,8 @@ public:
OUStringm_aURL; // the full path name to
create the content
OUStringm_aContentType;
OUStringm_aOriginalContentType;
-::ucbhelper::Content* m_pContent; // the content that provides
the storage elements
-::utl::TempFile*m_pTempFile;// temporary file, only for
storages on stream
+std::unique_ptr<::ucbhelper::Content> m_pContent; // the content that
provides the storage elements
+std::unique_ptr<::utl::TempFile> m_pTempFile;// temporary file,
only for storages on stream
SvStream* m_pSource; // original stream, only for
storages on a stream
ErrCode m_nError;
StreamMode m_nMode;// open mode (
read/write/trunc/nocreate/sharing )
@@ -496,7 +496,7 @@ public:
{
if ( !m_pContent )
CreateContent();
-return m_pContent;
+return m_pContent.get();
}
UCBStorageElementList_Impl& GetChildrenList()
{
@@ -1442,7 +1442,6 @@ UCBStorage::~UCBStorage()
UCBStorage_Impl::UCBStorage_Impl( const ::ucbhelper::Content& rContent, const
OUString& rName, StreamMode nMode, UCBStorage* pStorage, bool bDirect, bool
bIsRoot, bool bIsRepair, Reference< XProgressHandler > const & xProgressHandler
)
: m_pAntiImpl( pStorage )
, m_pContent( new ::ucbhelper::Content( rContent ) )
-, m_pTempFile( nullptr )
, m_pSource( nullptr )
//, m_pStream( NULL )
, m_nError( ERRCODE_NONE )
@@ -1462,7 +1461,7 @@ UCBStorage_Impl::UCBStorage_Impl( const
::ucbhelper::Content& rContent, const OU
{
// no name given = use temporary name!
DBG_ASSERT( m_bIsRoot, "SubStorage must have a name!" );
-m_pTempFile = new ::utl::TempFile;
+m_pTempFile.reset(new ::utl::TempFile);
m_pTempFile->EnableKillingFile();
m_aName = m_aOriginalName = aName = m_pTempFile->GetURL();
}
@@ -1472,8 +1471,6 @@ UCBStorage_Impl::UCBStorage_Impl( const
::ucbhelper::Content& rContent, const OU
UCBStorage_Impl::UCBStorage_Impl( const OUString& rName, StreamMode nMode,
UCBStorage* pStorage, bool bDirect, bool bIsRoot, bool bIsRepair, Reference<
XProgressHandler > const & xProgressHandler )
: m_pAntiImpl( pStorage )
-, m_pContent( nullptr )
-, m_pTempFile( nullptr )
, m_pSource( nullptr )
//, m_pStream( NULL )
, m_nError( ERRCODE_NONE )
@@ -1493,7 +1490,7 @@ UCBStorage_Impl::UCBStorage_Impl( const OUString& rName,
StreamMode nMode, UCBSt
{
// no name given = use temporary name!
DBG_ASSERT( m_bIsRoot, "SubStorage must have a name!" );
-m_pTempFile = new ::utl::TempFile;
+m_pTempFile.reset(new ::utl::TempFile);
m_pTempFile->EnableKillingFile();
m_aName = m_aOriginalName = aName = m_pTempFile->GetURL();
}
@@ -1522,7 +1519,6 @@ UCBStorage_Impl::UCBStorage_Impl( const OUString& rName,
StreamMode nMode, UCBSt
UCBStorage_Impl::UCBStorage_Impl( SvStream& rStream, UCBStorage* pStorage,
bool bDirect )
: m_pAntiImpl( pStorage )
-, m_pContent( nullptr )
, m_pTempFile( new ::utl::TempFile )
, m_pSource( )
, m_nError( ERRCODE_NONE )
@@ -1669,7 +1665,7 @@ void UCBStorage_Impl::CreateContent()
aTemp += "?repairpackage";
}
-m_pContent = new ::ucbhelper::Content( aTemp, xComEnv,
comphelper::getProcessComponentContext() );
+m_pContent.reset(new ::ucbhelper::Content( aTemp, xComEnv,
comphelper::getProcessComponentContext() ));
}
catch (const ContentCreationException&)
{
@@ -1940,8 +1936,8 @@ UCBStorage_Impl::~UCBStorage_Impl()
{
m_aChildrenList.clear();
-delete m_pContent;
-delete m_pTempFile;
+m_pContent.reset();
+m_pTempFile.reset();
}
bool UCBStorage_Impl::Insert( ::ucbhelper::Content *pContent )
@@ -1980,8 +1976,7 @@ bool UCBStorage_Impl::Insert( ::ucbhelper::Content
*pContent )
[Libreoffice-commits] core.git: 2 commits - sfx2/source
sfx2/source/doc/objmisc.cxx |7 +++
sfx2/source/doc/objxtor.cxx |3 +--
sfx2/source/doc/sfxbasemodel.cxx |8
sfx2/source/inc/objshimp.hxx |2 +-
sfx2/source/view/viewfrm.cxx |2 +-
5 files changed, 10 insertions(+), 12 deletions(-)
New commits:
commit 5e93e406cbada31882c33fe1f420af29039027be
Author: Noel Grandin
AuthorDate: Tue Dec 4 15:03:33 2018 +0200
Commit: Noel Grandin
CommitDate: Wed Dec 5 07:51:10 2018 +0100
use unique_ptr in SfxBaseModel::storeSelf
Change-Id: I73524a15b5ac33ee6243a2e0e563b9986e887e40
Reviewed-on: https://gerrit.libreoffice.org/64528
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sfx2/source/doc/sfxbasemodel.cxx b/sfx2/source/doc/sfxbasemodel.cxx
index 254177efadf0..76be8c85d969 100644
--- a/sfx2/source/doc/sfxbasemodel.cxx
+++ b/sfx2/source/doc/sfxbasemodel.cxx
@@ -1515,7 +1515,7 @@ void SAL_CALL SfxBaseModel::storeSelf( constSequence<
beans::PropertyValue >
}
}
-SfxAllItemSet *pParams = new SfxAllItemSet( SfxGetpApp()->GetPool() );
+std::unique_ptr pParams(new SfxAllItemSet(
SfxGetpApp()->GetPool() ));
TransformParameters( nSlotId, aArgs, *pParams );
SfxGetpApp()->NotifyEvent( SfxEventHint( SfxEventHintId::SaveDoc,
GlobalEventConfig::GetEventName(GlobalEventId::SAVEDOC),
m_pData->m_pObjectShell.get() ) );
@@ -1537,18 +1537,18 @@ void SAL_CALL SfxBaseModel::storeSelf( const
Sequence< beans::PropertyValue >
}
else
{
-bRet = m_pData->m_pObjectShell->Save_Impl( pParams );
+bRet = m_pData->m_pObjectShell->Save_Impl( pParams.get() );
}
}
else
{
// Tell the SfxMedium if we are in checkin instead of normal save
m_pData->m_pObjectShell->GetMedium( )->SetInCheckIn( nSlotId ==
SID_CHECKIN );
-bRet = m_pData->m_pObjectShell->Save_Impl( pParams );
+bRet = m_pData->m_pObjectShell->Save_Impl( pParams.get() );
m_pData->m_pObjectShell->GetMedium( )->SetInCheckIn( nSlotId !=
SID_CHECKIN );
}
-DELETEZ( pParams );
+pParams.reset();
ErrCode nErrCode = m_pData->m_pObjectShell->GetError() ?
m_pData->m_pObjectShell->GetError()
:
ERRCODE_IO_CANTWRITE;
commit 0cc702232e4799f03a468d1e8014d050a683165e
Author: Noel Grandin
AuthorDate: Tue Dec 4 15:00:43 2018 +0200
Commit: Noel Grandin
CommitDate: Wed Dec 5 07:50:55 2018 +0100
use unique_ptr in SfxObjectShell_Impl
Change-Id: I3f3b0514bdb87f59d9c5f34d2d36dc63e8b1e33d
Reviewed-on: https://gerrit.libreoffice.org/64527
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sfx2/source/doc/objmisc.cxx b/sfx2/source/doc/objmisc.cxx
index a199f99cb4d9..a7fc00a38aa8 100644
--- a/sfx2/source/doc/objmisc.cxx
+++ b/sfx2/source/doc/objmisc.cxx
@@ -985,13 +985,12 @@ void SfxObjectShell::CheckForBrokenDocSignatures_Impl()
void SfxObjectShell::SetAutoLoad(
const INetURLObject& rUrl, sal_uInt32 nTime, bool bReload )
{
-if ( pImpl->pReloadTimer )
-DELETEZ(pImpl->pReloadTimer);
+pImpl->pReloadTimer.reset();
if ( bReload )
{
-pImpl->pReloadTimer = new AutoReloadTimer_Impl(
+pImpl->pReloadTimer.reset(new AutoReloadTimer_Impl(
rUrl.GetMainURL(
INetURLObject::DecodeMechanism::ToIUri ),
-nTime, this );
+nTime, this ));
pImpl->pReloadTimer->Start();
}
}
diff --git a/sfx2/source/doc/objxtor.cxx b/sfx2/source/doc/objxtor.cxx
index ac2fd4eca9d3..093fbbc4ecc9 100644
--- a/sfx2/source/doc/objxtor.cxx
+++ b/sfx2/source/doc/objxtor.cxx
@@ -233,7 +233,6 @@ SfxObjectShell_Impl::SfxObjectShell_Impl( SfxObjectShell&
_rDocShell )
,m_bConfigOptionsChecked( false )
,lErr(ERRCODE_NONE)
,nEventId ( SfxEventHintId::NONE )
-,pReloadTimer ( nullptr)
,nLoadedFlags ( SfxLoadedFlags::ALL )
,nFlagsInProgress( SfxLoadedFlags::NONE )
,bModalMode( false )
@@ -310,7 +309,7 @@ SfxObjectShell::~SfxObjectShell()
SfxObjectShell::CloseInternal();
pImpl->pBaseModel.set( nullptr );
-DELETEZ( pImpl->pReloadTimer );
+pImpl->pReloadTimer.reset();
SfxApplication *pSfxApp = SfxGetpApp();
if ( USHRT_MAX != pImpl->nVisualDocumentNumber && pSfxApp )
diff --git a/sfx2/source/inc/objshimp.hxx b/sfx2/source/inc/objshimp.hxx
index 4f883c2f8d53..d31414b8588f 100644
--- a/sfx2/source/inc/objshimp.hxx
+++ b/sfx2/source/inc/objshimp.hxx
@@ -96,7 +96,7 @@ struct SfxObjectShell_Impl : public
::sfx2::IMacroDocumentAccess
ErrCode lErr;
SfxEventHintId nEventId; // If Open/Create as to be sent
// before Activate
-AutoReloadTimer_Impl
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/view/viewfrm.cxx | 16
1 file changed, 8 insertions(+), 8 deletions(-)
New commits:
commit a8694d21a87c44f6008a3547f0b004a17253fdd6
Author: Noel Grandin
AuthorDate: Tue Dec 4 14:59:06 2018 +0200
Commit: Noel Grandin
CommitDate: Wed Dec 5 07:50:39 2018 +0100
use unique_ptr in SfxViewFrame::ExecReload_Impl
Change-Id: I35a8a3a6ccbf811e529f761f840bfc7acf870056
Reviewed-on: https://gerrit.libreoffice.org/64526
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx
index 61cb945c738a..a642771b2c1f 100644
--- a/sfx2/source/view/viewfrm.cxx
+++ b/sfx2/source/view/viewfrm.cxx
@@ -616,11 +616,11 @@ void SfxViewFrame::ExecReload_Impl( SfxRequest& rReq )
DELETEZ( xOldObj->Get_Impl()->pReloadTimer );
-SfxItemSet* pNewSet = nullptr;
+std::unique_ptr pNewSet;
std::shared_ptr pFilter =
pMedium->GetFilter();
if( pURLItem )
{
-pNewSet = new SfxAllItemSet( pApp->GetPool() );
+pNewSet.reset(new SfxAllItemSet( pApp->GetPool() ));
pNewSet->Put( *pURLItem );
// Filter Detection
@@ -637,7 +637,7 @@ void SfxViewFrame::ExecReload_Impl( SfxRequest& rReq )
}
else
{
-pNewSet = new SfxAllItemSet( *pMedium->GetItemSet() );
+pNewSet.reset(new SfxAllItemSet( *pMedium->GetItemSet() ));
pNewSet->ClearItem( SID_VIEW_ID );
pNewSet->ClearItem( SID_STREAM );
pNewSet->ClearItem( SID_INPUTSTREAM );
@@ -657,7 +657,7 @@ void SfxViewFrame::ExecReload_Impl( SfxRequest& rReq )
// If a salvaged file is present, do not enclose the OrigURL
// again, since the Template is invalid after reload.
-const SfxStringItem* pSalvageItem =
SfxItemSet::GetItem(pNewSet, SID_DOC_SALVAGE, false);
+const SfxStringItem* pSalvageItem =
SfxItemSet::GetItem(pNewSet.get(), SID_DOC_SALVAGE, false);
if( pSalvageItem )
{
pNewSet->ClearItem( SID_DOC_SALVAGE );
@@ -680,9 +680,9 @@ void SfxViewFrame::ExecReload_Impl( SfxRequest& rReq )
if ( pSilentItem && pSilentItem->GetValue() )
pNewSet->Put( SfxBoolItem( SID_SILENT, true ) );
-const SfxUnoAnyItem* pInteractionItem =
SfxItemSet::GetItem(pNewSet, SID_INTERACTIONHANDLER, false);
-const SfxUInt16Item* pMacroExecItem =
SfxItemSet::GetItem(pNewSet, SID_MACROEXECMODE, false);
-const SfxUInt16Item* pDocTemplateItem =
SfxItemSet::GetItem(pNewSet, SID_UPDATEDOCMODE, false);
+const SfxUnoAnyItem* pInteractionItem =
SfxItemSet::GetItem(pNewSet.get(), SID_INTERACTIONHANDLER,
false);
+const SfxUInt16Item* pMacroExecItem =
SfxItemSet::GetItem(pNewSet.get(), SID_MACROEXECMODE, false);
+const SfxUInt16Item* pDocTemplateItem =
SfxItemSet::GetItem(pNewSet.get(), SID_UPDATEDOCMODE, false);
if (!pInteractionItem)
{
@@ -734,7 +734,7 @@ void SfxViewFrame::ExecReload_Impl( SfxRequest& rReq )
xNewObj = nullptr;
}
-DELETEZ( pNewSet );
+pNewSet.reset();
if( !xNewObj.Is() )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - sot/source sw/source
sot/source/unoolestorage/xolesimplestorage.cxx | 48 +++---
sot/source/unoolestorage/xolesimplestorage.hxx |2
sw/source/filter/ww8/docxexport.cxx|5 -
sw/source/filter/ww8/rtfexport.cxx |2
sw/source/filter/ww8/wrtww8.cxx| 64 ++---
sw/source/filter/ww8/wrtww8.hxx| 26 +-
sw/source/filter/ww8/ww8atr.cxx| 16 +++---
7 files changed, 70 insertions(+), 93 deletions(-)
New commits:
commit b06abdb3ddfa1337b7433f02689fa9f0f9c7cf09
Author: Noel Grandin
AuthorDate: Tue Dec 4 14:49:22 2018 +0200
Commit: Noel Grandin
CommitDate: Wed Dec 5 07:50:05 2018 +0100
use unique_ptr in OLESimpleStorage
Change-Id: I5ef95846640efac00055336435356efdd0a8326d
Reviewed-on: https://gerrit.libreoffice.org/64524
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sot/source/unoolestorage/xolesimplestorage.cxx
b/sot/source/unoolestorage/xolesimplestorage.cxx
index 8804c4318fad..c61b643811f0 100644
--- a/sot/source/unoolestorage/xolesimplestorage.cxx
+++ b/sot/source/unoolestorage/xolesimplestorage.cxx
@@ -45,7 +45,6 @@ OLESimpleStorage::OLESimpleStorage(
css::uno::Reference const & xContext,
css::uno::Sequence const )
: m_bDisposed( false )
-, m_pStorage( nullptr )
, m_pListenersContainer( nullptr )
, m_xContext( xContext )
, m_bNoTemporaryCopy( false )
@@ -135,7 +134,7 @@ OLESimpleStorage::OLESimpleStorage(
if ( !m_pStream || m_pStream->GetError() )
throw io::IOException(); // TODO
-m_pStorage = new Storage( *m_pStream, false );
+m_pStorage.reset(new Storage( *m_pStream, false ));
}
OLESimpleStorage::~OLESimpleStorage()
@@ -187,11 +186,10 @@ void OLESimpleStorage::InsertInputStreamToStorage_Impl(
BaseStorage* pStorage, c
if ( pStorage->IsContained( aName ) )
throw container::ElementExistException(); // TODO:
-BaseStorageStream* pNewStream = pStorage->OpenStream( aName );
+std::unique_ptr pNewStream(pStorage->OpenStream( aName
));
if ( !pNewStream || pNewStream->GetError() || pStorage->GetError() )
{
-if ( pNewStream )
-DELETEZ( pNewStream );
+pNewStream.reset();
pStorage->ResetError();
throw io::IOException(); // TODO
}
@@ -211,13 +209,11 @@ void OLESimpleStorage::InsertInputStreamToStorage_Impl(
BaseStorage* pStorage, c
}
catch( uno::Exception& )
{
-DELETEZ( pNewStream );
+pNewStream.reset();
pStorage->Remove( aName );
throw;
}
-
-DELETEZ( pNewStream );
}
@@ -229,11 +225,10 @@ void OLESimpleStorage::InsertNameAccessToStorage_Impl(
BaseStorage* pStorage, co
if ( pStorage->IsContained( aName ) )
throw container::ElementExistException(); // TODO:
-BaseStorage* pNewStorage = pStorage->OpenStorage( aName );
+std::unique_ptr pNewStorage(pStorage->OpenStorage( aName ));
if ( !pNewStorage || pNewStorage->GetError() || pStorage->GetError() )
{
-if ( pNewStorage )
-DELETEZ( pNewStorage );
+pNewStorage.reset();
pStorage->ResetError();
throw io::IOException(); // TODO
}
@@ -247,20 +242,18 @@ void OLESimpleStorage::InsertNameAccessToStorage_Impl(
BaseStorage* pStorage, co
uno::Reference< container::XNameAccess > xSubNameAccess;
uno::Any aAny = xNameAccess->getByName( aElements[nInd] );
if ( aAny >>= xInputStream )
-InsertInputStreamToStorage_Impl( pNewStorage, aElements[nInd],
xInputStream );
+InsertInputStreamToStorage_Impl( pNewStorage.get(),
aElements[nInd], xInputStream );
else if ( aAny >>= xSubNameAccess )
-InsertNameAccessToStorage_Impl( pNewStorage, aElements[nInd],
xSubNameAccess );
+InsertNameAccessToStorage_Impl( pNewStorage.get(),
aElements[nInd], xSubNameAccess );
}
}
catch( uno::Exception& )
{
-DELETEZ( pNewStorage );
+pNewStorage.reset();
pStorage->Remove( aName );
throw;
}
-
-DELETEZ( pNewStorage );
}
@@ -292,9 +285,9 @@ void SAL_CALL OLESimpleStorage::insertByName( const
OUString& aName, const uno::
throw lang::IllegalArgumentException(); // TODO:
if ( xInputStream.is() )
-InsertInputStreamToStorage_Impl( m_pStorage, aName, xInputStream );
+InsertInputStreamToStorage_Impl( m_pStorage.get(), aName,
xInputStream );
else if ( xNameAccess.is() )
-InsertNameAccessToStorage_Impl( m_pStorage, aName, xNameAccess );
+InsertNameAccessToStorage_Impl( m_pStorage.get(), aName,
xNameAccess );
else
throw uno::RuntimeException();
}
@@ -391,7 +384,7 @@ uno::Any SAL_CALL OLESimpleStorage::getByName( const
OUString& aName )
if ( m_pStorage->IsStorage( aName ) )
{
-
[Libreoffice-bugs] [Bug 120992] Selection box should include a grid guide
https://bugs.documentfoundation.org/show_bug.cgi?id=120992 --- Comment #8 from 和尚蟹 --- This article has been replaced by another URL from my website below. Because of the article below, there are better ideas. https://bugs.documentfoundation.org/show_bug.cgi?id=121843 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 120992] Selection box should include a grid guide
https://bugs.documentfoundation.org/show_bug.cgi?id=120992 --- Comment #8 from 和尚蟹 --- This article has been replaced by another URL from my website below. Because of the article below, there are better ideas. https://bugs.documentfoundation.org/show_bug.cgi?id=121843 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: oox/source
oox/source/ole/axcontrol.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 126e5a4d5b1d6c7ba5b313786793a38f99488b33 Author: Mike Kaganski AuthorDate: Wed Dec 5 07:17:18 2018 +0100 Commit: Mike Kaganski CommitDate: Wed Dec 5 07:19:10 2018 +0100 Include vcl/outdev.hxx Breaks Windows builds since commit 1c8eb8ba49340b7b59a9f1a5f28cd8bee06cd4d1 D:/lode/dev/core/oox/source/ole/axcontrol.cxx(942): error C2027: use of undefined type 'OutputDevice' D:/lode/dev/core/include\vcl/svapp.hxx(63): note: see declaration of 'OutputDevice' D:/lode/dev/core/oox/source/ole/axcontrol.cxx(942): error C2227: left of '->GetSettings' must point to class/struct/union/generic type D:/lode/dev/core/oox/source/ole/axcontrol.cxx(942): error C2228: left of '.GetStyleSettings' must have class/struct/union D:/lode/dev/core/oox/source/ole/axcontrol.cxx(942): error C2228: left of '.GetAppFont' must have class/struct/union make[1]: *** [D:/lode/dev/core/solenv/gbuild/LinkTarget.mk:293: D:/lode/dev/core/workdir/CxxObject/oox/source/ole/axcontrol.o] Error 2 make: *** [Makefile:283: build] Error 2 Change-Id: I017bb5b99d4f314bb83cacddbe681d51cb0f9b14 Reviewed-on: https://gerrit.libreoffice.org/64589 Reviewed-by: Mike Kaganski Tested-by: Mike Kaganski diff --git a/oox/source/ole/axcontrol.cxx b/oox/source/ole/axcontrol.cxx index fa1d19ef01ce..216cc1982816 100644 --- a/oox/source/ole/axcontrol.cxx +++ b/oox/source/ole/axcontrol.cxx @@ -51,6 +51,7 @@ #include #include #include +#include #include #include #include ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3_kde5/kde5_filepicker_ipc.cxx | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
New commits:
commit 93815c2b04f1905e43c695caf5cc2c594bb897ce
Author: Michael Weghorn
AuthorDate: Tue Dec 4 14:42:31 2018 +0100
Commit: Michael Weghorn
CommitDate: Wed Dec 5 07:14:22 2018 +0100
tdf#121399 Join cmd reading thread in gtk3_kde5
Stop reading commands from the pipe on kde5 side once
the "Quit" command has been sent, in order to have
the thread that is reading commands from stdin finish
properly.
Join the thread in the 'FilePickerIpc' destructor, rather than
just deleting it while it may still be running, which
resulted in 'terminate()' being called.
Change-Id: Ia184987e7994cc1de0208ff2757a3cf06c8b7194
Reviewed-on: https://gerrit.libreoffice.org/63835
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/vcl/unx/gtk3_kde5/kde5_filepicker_ipc.cxx
b/vcl/unx/gtk3_kde5/kde5_filepicker_ipc.cxx
index 550e1d8bb2d4..a2ea6b7bbefd 100644
--- a/vcl/unx/gtk3_kde5/kde5_filepicker_ipc.cxx
+++ b/vcl/unx/gtk3_kde5/kde5_filepicker_ipc.cxx
@@ -192,6 +192,12 @@ static void readCommands(FilePickerIpc* ipc)
readCommandArgs(command, args);
emit ipc->commandReceived(messageId, command, args);
+
+// stop processing once 'Quit' command has been sent
+if (command == Commands::Quit)
+{
+return;
+}
}
}
@@ -211,7 +217,11 @@ FilePickerIpc::FilePickerIpc(KDE5FilePicker* filePicker,
QObject* parent)
m_ipcReaderThread = std::unique_ptr{ new
std::thread(readCommands, this) };
}
-FilePickerIpc::~FilePickerIpc() = default;
+FilePickerIpc::~FilePickerIpc()
+{
+// join thread that reads commands
+m_ipcReaderThread->join();
+};
bool FilePickerIpc::handleCommand(uint64_t messageId, Commands command,
QList args)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3_kde5/gtk3_kde5_filepicker.cxx |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
New commits:
commit 8dbe0af729c9e054135a0f41706165033441f867
Author: Michael Weghorn
AuthorDate: Tue Dec 4 09:24:32 2018 +0100
Commit: Michael Weghorn
CommitDate: Wed Dec 5 07:12:02 2018 +0100
tdf#121892 Guard Gtk3KDE5FilePicker::execute with SolarMutexGuard
Adhere to what gtk3's file picker does as well.
Threading is involved in Gtk3KDE5FilePickerIpc::execute().
Change-Id: I4fa0a12f46ed13ef04211cb8577e77d1db5e8eae
Reviewed-on: https://gerrit.libreoffice.org/64502
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/vcl/unx/gtk3_kde5/gtk3_kde5_filepicker.cxx
b/vcl/unx/gtk3_kde5/gtk3_kde5_filepicker.cxx
index 919328dd9d6c..8006bc37c7dc 100644
--- a/vcl/unx/gtk3_kde5/gtk3_kde5_filepicker.cxx
+++ b/vcl/unx/gtk3_kde5/gtk3_kde5_filepicker.cxx
@@ -94,7 +94,11 @@ void SAL_CALL Gtk3KDE5FilePicker::setTitle(const OUString&
title)
m_ipc.sendCommand(Commands::SetTitle, title);
}
-sal_Int16 SAL_CALL Gtk3KDE5FilePicker::execute() { return m_ipc.execute(); }
+sal_Int16 SAL_CALL Gtk3KDE5FilePicker::execute()
+{
+SolarMutexGuard g;
+return m_ipc.execute();
+}
void SAL_CALL Gtk3KDE5FilePicker::setMultiSelectionMode(sal_Bool multiSelect)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115747] Can't edit file on samba shares
https://bugs.documentfoundation.org/show_bug.cgi?id=115747 --- Comment #20 from Lena --- We have the same. We can open and edit file, but can't save them because get error "Unable to create tmp file". Samba share mounted from /etc/fstab with following string: //os-srv/public /mnt/samba cifs uid=nobody,noperm,file_mode=0777,dir_mode=0777,credentials=/usr/local/etc/samba/smbcredentials,iocharset=utf8,sec=ntlm 0 0 Other programs like mousepad or another works fine. Ancient LibreOffice 5.1.6 from Ubuntu repo works ok. Versions we have: Ubuntu 16.04 LibreOffice 6.1.3 cifs-utils 6.4-1ubuntu1.1 samba 4.3.11+dfsg-0ubuntu0.16.04.18 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87351] [META] Conditional formatting bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=87351 Bug 87351 depends on bug 117332, which changed state. Bug 117332 Summary: Conditional formatting: selecting a cell range for the condition with the mouse gets you every cell individually, but not the range (see comment 10) https://bugs.documentfoundation.org/show_bug.cgi?id=117332 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/condformat/condformatdlg.cxx |6 ++
1 file changed, 6 insertions(+)
New commits:
commit 6c5839d399c6277a7f2f0e214a20996761563525
Author: Mike Kaganski
AuthorDate: Tue Dec 4 21:28:46 2018 +0300
Commit: Mike Kaganski
CommitDate: Wed Dec 5 05:26:50 2018 +0100
tdf#117332: select replaced text to properly replace it next time
... othervise the next drag event will insert the new range immediately
after the just inserted, resulting in invalid reference.
Regression after commit 42aece949ec96c775b31216bddd723aa5321e966
don't replace content of formula field when selecting range, tdf#58635
Change-Id: I7dfdc1ce041ebadf4406dbb605676d87cd489efa
Reviewed-on: https://gerrit.libreoffice.org/64574
Reviewed-by: Mike Kaganski
Tested-by: Mike Kaganski
diff --git a/sc/source/ui/condformat/condformatdlg.cxx
b/sc/source/ui/condformat/condformatdlg.cxx
index 64952101d0ea..79e0e3f233d6 100644
--- a/sc/source/ui/condformat/condformatdlg.cxx
+++ b/sc/source/ui/condformat/condformatdlg.cxx
@@ -674,7 +674,13 @@ void ScCondFormatDlg::SetReference(const ScRange& rRef,
ScDocument*)
OUString aRefStr(rRef.Format(nFlags, mpViewData->GetDocument(),
ScAddress::Details(mpViewData->GetDocument()->GetAddressConvention(), 0, 0)));
if (pEdit != mpEdRange)
+{
+Selection sel = pEdit->GetSelection();
+sel.Justify();// in case of RtL selection
+sel.Max() = sel.Min() + aRefStr.getLength();
pEdit->ReplaceSelected(aRefStr);
+pEdit->SetSelection(sel); // to replace it again with next drag
event
+}
else
pEdit->SetRefString( aRefStr );
updateTitle();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 112978] CPU usage for selecting text has increased since 5.1
https://bugs.documentfoundation.org/show_bug.cgi?id=112978 --- Comment #4 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89887] FileOpen: Drawing is not visible in DOCX file
https://bugs.documentfoundation.org/show_bug.cgi?id=89887 --- Comment #8 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114130] Crash when I open a .doc file (attached file) in version 5.4.3.2.0+ for Android
https://bugs.documentfoundation.org/show_bug.cgi?id=114130 --- Comment #8 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55529] .doc and .docx triggers X process 100% CPU usage
https://bugs.documentfoundation.org/show_bug.cgi?id=55529 --- Comment #13 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112472] "Number" number format listbox entry should toggle the format as number uno command
https://bugs.documentfoundation.org/show_bug.cgi?id=112472 --- Comment #5 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36711] FILOPEN import of Word side-by-side heading superimposes headings (opening of doc file is incorrect)
https://bugs.documentfoundation.org/show_bug.cgi?id=36711 --- Comment #13 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114203] Sidebar deck outside of sidebar container when opening multiple windows (gtk2)
https://bugs.documentfoundation.org/show_bug.cgi?id=114203 --- Comment #6 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45904] move java based api tests to c++
https://bugs.documentfoundation.org/show_bug.cgi?id=45904 --- Comment #176 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/63ff8602c16b0c26927dc3413b12a5368fe367b0%5E%21 tdf#45904 Move XRefreshable Java tests to C++ It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: framework/qa include/test qadevOOo/Jar_OOoRunner.mk qadevOOo/objdsc qadevOOo/tests sc/qa test/Library_subsequenttest.mk test/source
framework/qa/complex/api_internal/api.lst|1
include/test/util/xrefreshable.hxx | 38 ++
qadevOOo/Jar_OOoRunner.mk|1
qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDDELinkObj.csv |3
qadevOOo/tests/java/mod/_sc/ScDDELinkObj.java| 181 ---
sc/qa/extras/scddelinkobj.cxx| 11
sc/qa/unoapi/sc_3.sce|1
test/Library_subsequenttest.mk |1
test/source/util/xrefreshable.cxx| 81
9 files changed, 130 insertions(+), 188 deletions(-)
New commits:
commit 63ff8602c16b0c26927dc3413b12a5368fe367b0
Author: Jens Carl
AuthorDate: Tue Dec 4 09:29:11 2018 +
Commit: Jens Carl
CommitDate: Wed Dec 5 04:45:59 2018 +0100
tdf#45904 Move XRefreshable Java tests to C++
Move XRefreshable Java tests to C++ for ScDDELinkObj.
Change-Id: I121d9fe6a66c549e402b0cf6fd54fea1201e443f
Reviewed-on: https://gerrit.libreoffice.org/64511
Tested-by: Jenkins
Reviewed-by: Jens Carl
diff --git a/framework/qa/complex/api_internal/api.lst
b/framework/qa/complex/api_internal/api.lst
index a4b45dfd2053..4f1cc7cb2540 100644
--- a/framework/qa/complex/api_internal/api.lst
+++ b/framework/qa/complex/api_internal/api.lst
@@ -84,7 +84,6 @@ job89=sc.ScDatabaseRangesObj
job90=sc.ScDataPilotFieldObj
job91=sc.ScDataPilotFieldsObj
job92=sc.ScDataPilotTablesObj
-job93=sc.ScDDELinkObj
job94=sc.ScDDELinksObj
job95=sc.ScDrawPagesObj
job96=sc.ScFilterDescriptorBase
diff --git a/include/test/util/xrefreshable.hxx
b/include/test/util/xrefreshable.hxx
new file mode 100644
index ..2ffab9946e4a
--- /dev/null
+++ b/include/test/util/xrefreshable.hxx
@@ -0,0 +1,38 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4;
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#ifndef INCLUDED_TEST_UTIL_XREFRESHABLE_HXX
+#define INCLUDED_TEST_UTIL_XREFRESHABLE_HXX
+
+#include
+
+#include
+
+#include
+
+namespace apitest
+{
+class OOO_DLLPUBLIC_TEST XRefreshable
+{
+public:
+virtual css::uno::Reference init() = 0;
+
+void testAddRefreshListener();
+void testRefresh();
+void testRemoveRefreshListener();
+
+protected:
+~XRefreshable() {}
+};
+
+} // namespace apitest
+
+#endif // INCLUDED_TEST_UTIL_XREFRESHABLE_HXX
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s
cinkeys+=0=break: */
diff --git a/qadevOOo/Jar_OOoRunner.mk b/qadevOOo/Jar_OOoRunner.mk
index 9de56bbe02dd..80b62f084af6 100644
--- a/qadevOOo/Jar_OOoRunner.mk
+++ b/qadevOOo/Jar_OOoRunner.mk
@@ -978,7 +978,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\
qadevOOo/tests/java/mod/_sc/ScDataPilotItemObj \
qadevOOo/tests/java/mod/_sc/ScDataPilotItemsObj \
qadevOOo/tests/java/mod/_sc/ScDataPilotTablesObj \
-qadevOOo/tests/java/mod/_sc/ScDDELinkObj \
qadevOOo/tests/java/mod/_sc/ScDDELinksObj \
qadevOOo/tests/java/mod/_sc/ScDocumentConfiguration \
qadevOOo/tests/java/mod/_sc/ScDrawPageObj \
diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDDELinkObj.csv
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDDELinkObj.csv
deleted file mode 100644
index 651b7c6ffebd..
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDDELinkObj.csv
+++ /dev/null
@@ -1,3 +0,0 @@
-"ScDDELinkObj";"com::sun::star::util::XRefreshable";"refresh()"
-"ScDDELinkObj";"com::sun::star::util::XRefreshable";"addRefreshListener()"
-"ScDDELinkObj";"com::sun::star::util::XRefreshable";"removeRefreshListener()"
diff --git a/qadevOOo/tests/java/mod/_sc/ScDDELinkObj.java
b/qadevOOo/tests/java/mod/_sc/ScDDELinkObj.java
deleted file mode 100644
index 04e9beebb8c5..
--- a/qadevOOo/tests/java/mod/_sc/ScDDELinkObj.java
+++ /dev/null
@@ -1,181 +0,0 @@
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed
- * with this work for additional information regarding copyright
- * ownership. The ASF licenses this file to you under the Apache
- * License, Version 2.0 (the "License"); you may not use this file
- * except in compliance with the License. You may obtain a copy of
- * the License at http://www.apache.org/licenses/LICENSE-2.0
[Libreoffice-bugs] [Bug 51671] [XLS] FILEOPEN particular .XLS uses all chart data instead of first row for Legend
https://bugs.documentfoundation.org/show_bug.cgi?id=51671 Markus Mohrhard changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |markus.mohrhard@googlemail. |desktop.org |com --- Comment #10 from Markus Mohrhard --- Was a nice and simple task. However I need to add a UI entry and an ODF extension as well. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51671] [XLS] FILEOPEN particular .XLS uses all chart data instead of first row for Legend
https://bugs.documentfoundation.org/show_bug.cgi?id=51671 --- Comment #9 from Markus Mohrhard --- The legend issue is related to the LegendException record. The document actually contains that many different data series but contains a special record that marks the legend of most of them as deleted. See the LegendException entry of the series in current oletoy. I'm not sure if that feature is actually supported by our current implementation. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117361] changing formula font size in impress destroys view
https://bugs.documentfoundation.org/show_bug.cgi?id=117361 --- Comment #14 from muso --- It gets worse because following the steps of the initial comment LO 6.1.3 hangs/crashes now and only with the help of Windows task manager I can end soffice.bin to restart LO. Here is the crash report. crashreport.libreoffice.org/stats/crash_details/74975f11-273f-4eba-8238-c0d05b36b737 -> is now a major bug in my opinion. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117361] changing formula font size in impress destroys view and eventually crashes LO
https://bugs.documentfoundation.org/show_bug.cgi?id=117361 muso changed: What|Removed |Added Summary|changing formula font size |changing formula font size |in impress destroys view|in impress destroys view ||and eventually crashes LO -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121914] Undo/redo of text box movement broken
https://bugs.documentfoundation.org/show_bug.cgi?id=121914 --- Comment #1 from muso --- The occurs no matter if you move the box to the upper or lower right of the page, the random movement with several undo/redo however only occurs when moving the box to the lower right. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121914] New: Undo/redo of text box movement broken
https://bugs.documentfoundation.org/show_bug.cgi?id=121914 Bug ID: 121914 Summary: Undo/redo of text box movement broken Product: LibreOffice Version: 6.1.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: uwesto...@web.de Created attachment 147293 --> https://bugs.documentfoundation.org/attachment.cgi?id=147293=edit ODT test file - open the attached simple file and move the box "some red text" to the right side - click the undo button result: the movement is not undone since the moved text box lands on a different place - now press the redo button result: the box is placed somewhere else - now press undo then redo a few times and see that the box is placed quite randomly I found out that the bug does not appear when I delete the image in the file so it seems the fact that the file contains an image seems to be important for the bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121913] New: Title case setting for style headings capitalizes 'and'
https://bugs.documentfoundation.org/show_bug.cgi?id=121913 Bug ID: 121913 Summary: Title case setting for style headings capitalizes 'and' Product: LibreOffice Version: 6.1.3.2 release Hardware: All OS: Mac OS X (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gs_gar...@me.com Description: When setting the Effect of a Style to 'Title' case, the word 'and' is capitalized when it shouldn't be. LOs validation here should be updated to allow for title case but exclude non-title case words. Actual Results: N.A. Expected Results: N.A. Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: TextDocument [Information guessed from browser] OS: Mac OS X (All) OS is 64bit: no -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121719] Gradient shows separator borders in slideshow mode
https://bugs.documentfoundation.org/show_bug.cgi?id=121719 --- Comment #10 from Xisco Faulí --- Patch in gerrit: https://gerrit.libreoffice.org/#/c/64582/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121719] Gradient shows separator borders in slideshow mode
https://bugs.documentfoundation.org/show_bug.cgi?id=121719 Xisco Faulí changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=96 ||971 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96971] SetXORMode - remove un-needed parameter ...
https://bugs.documentfoundation.org/show_bug.cgi?id=96971 Xisco Faulí changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||1719 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b690f42eaf0d83089591e69c876dfa6fbfadc204 Author: Alain Romedenne AuthorDate: Sun Dec 2 23:27:29 2018 -0200 Commit: Gerrit Code Review CommitDate: Wed Dec 5 00:57:21 2018 +0100 Update git submodules * Update helpcontent2 from branch 'master' - Update End Statement in BASIC Change-Id: I513db8eb06bc396b71ca2aaed1a6a50ec3ac5c2f Signed-off-by: Olivier Hallot Reviewed-on: https://gerrit.libreoffice.org/64438 Tested-by: Jenkins diff --git a/helpcontent2 b/helpcontent2 index f9566b6655aa..5c79d5ed41c8 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit f9566b6655aad0408724c4df65178f43c3e3d4f8 +Subproject commit 5c79d5ed41c81305e7315ee6ce6e9faa987cb696 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/sbasic/shared/03090404.xhp |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit 5c79d5ed41c81305e7315ee6ce6e9faa987cb696 Author: Alain Romedenne AuthorDate: Sun Dec 2 23:27:29 2018 -0200 Commit: Olivier Hallot CommitDate: Wed Dec 5 00:57:21 2018 +0100 Update End Statement in BASIC Change-Id: I513db8eb06bc396b71ca2aaed1a6a50ec3ac5c2f Signed-off-by: Olivier Hallot Reviewed-on: https://gerrit.libreoffice.org/64438 Tested-by: Jenkins diff --git a/source/text/sbasic/shared/03090404.xhp b/source/text/sbasic/shared/03090404.xhp index 1a31ebe19..0c933d7cb 100644 --- a/source/text/sbasic/shared/03090404.xhp +++ b/source/text/sbasic/shared/03090404.xhp @@ -40,7 +40,7 @@ Syntax: -End, End Function, End If, End Select, End Sub +End, End Enum, End Function, End If, End Select, End Sub, End With Parameters: @@ -48,10 +48,12 @@ Statement End: Is not required, but can be entered anywhere within a procedure to end the program execution. +End Enum: Ends an Enum VBA statement End Function: Ends a Function statement. End If: Marks the end of a If...Then...Else block. End Select: Marks the end of a Select Case block. End Sub: Ends a Sub statement. +End With: Ends a With statement Example: @@ -71,5 +73,4 @@ End Sub - ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 121826] Insert document dialog does nothing
https://bugs.documentfoundation.org/show_bug.cgi?id=121826 Aron Budea changed: What|Removed |Added Resolution|--- |WORKSFORME Status|UNCONFIRMED |RESOLVED CC||ba...@caesar.elte.hu --- Comment #1 from Aron Budea --- Hi Pierre, thanks for reporting, this has been fixed in master (only Internet and Mail choices are kept), and will be part of the next release. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121719] Gradient shows separator borders in slideshow mode
https://bugs.documentfoundation.org/show_bug.cgi?id=121719 Xisco Faulí changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected Version|5.3.1.2 release |5.3 all versions --- Comment #9 from Xisco Faulí --- Regression introduced by: author melikeyurtoglu2016-01-31 11:39:20 +0200 committer jan iversen2016-06-09 11:31:11 + commit 258301879bcd20397c38bbd522dea2c923bd9fc2 (patch) tree01ee1fe2d3f8df727039c97025e3577575a53e93 parent e420a335f783bb4d2ee9d74d56f91e16d189566f (diff) tdf#96971 SetXORMode - remove un-needed parameter -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121778] LibreOffice Vanilla not usable; opens OK but crashes when entering data ( Mac 10.14.1 Mojave )
https://bugs.documentfoundation.org/show_bug.cgi?id=121778 Xisco Faulí changed: What|Removed |Added Severity|major |critical Priority|high|highest Summary|LibreOffice Vanilla not |LibreOffice Vanilla not |usable; opens OK but|usable; opens OK but |crashes when entering data |crashes when entering data ||( Mac 10.14.1 Mojave ) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121468] Cannot open ppt files
https://bugs.documentfoundation.org/show_bug.cgi?id=121468 Aron Budea changed: What|Removed |Added Whiteboard||target:6.3.0 target:6.2.0 Resolution|--- |FIXED CC||ba...@caesar.elte.hu Status|UNCONFIRMED |RESOLVED --- Comment #3 from Aron Budea --- Should be fixed by the following commits in master and 6.2, thanks for the report! https://gerrit.libreoffice.org/plugins/gitiles/core/+/7b34fb18a4d60bfc4e32b7c382ac596cbc2e776f https://gerrit.libreoffice.org/plugins/gitiles/core/+/fd2b9f1fdf020b630c1bf44c5857d42353212a50 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121893] Wrong gradient on left hand side of startcenter - LO Vanilla
https://bugs.documentfoundation.org/show_bug.cgi?id=121893 --- Comment #3 from Xisco Faulí --- @Alex, I guess you're using Mojave ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121893] Wrong gradient on left hand side of startcenter - LO Vanilla
https://bugs.documentfoundation.org/show_bug.cgi?id=121893 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #2 from Xisco Faulí --- Might be related to bug 121778... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121570] XINERAMA
https://bugs.documentfoundation.org/show_bug.cgi?id=121570 --- Comment #8 from rayandr...@eastlink.ca --- Yeah, dunno, maybe you guys should update Debian or whatever the protocols might be. Anyway, happy that libreoffice now works, I've been trying for years. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121778] LibreOffice Vanilla not usable; opens OK but crashes when entering data
https://bugs.documentfoundation.org/show_bug.cgi?id=121778 --- Comment #12 from Xisco Faulí --- I've just updated my macbook to 10.14.1 but I can't reproduce the issue in Version: 6.2.0.0.beta1+ Build ID: 3640db087386d699e49f9a5d426c91de6788d612 CPU threads: 8; OS: Mac OS X 10.14.1; UI render: default; VCL: osx; Locale: en-US (en_ES.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121912] PDF Export of odt documents to pdf -created pdf document is not readable in Acrobat reader
https://bugs.documentfoundation.org/show_bug.cgi?id=121912 --- Comment #2 from m.a.riosv --- I have done the triage with calc. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121912] PDF Export of odt documents to pdf -created pdf document is not readable in Acrobat reader
https://bugs.documentfoundation.org/show_bug.cgi?id=121912 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Severity|normal |critical Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Priority|medium |high --- Comment #1 from m.a.riosv --- Seems the pdf is generated as hybrid even the option is no marked. Reproducible. Last good for me. Version: 6.1.4.1 (x64) Build ID: 25073d18caee244880112e52c4a7e71f6081b3a9 CPU threads: 4; OS: Windows 10.0; UI render: GL; Locale: es-ES (es_ES); Calc: CL First bad when I see Versión: 6.2.0.0.beta1+ (x64) Id. de compilación: e45c30858dec1dd705b9144fab981a3c8819ba96 Subprocs. CPU: 4; SO: Windows 10.0; Repres. IU: GL; VCL: win; TinderBox: Win-x86_64@42, Branch:libreoffice-6-2, Time: 2018-12-03_12:04:06 Configuración regional: es-ES (es_ES); Idioma de IU: es-ES Calc: threaded Bad Versión: 6.2.0.0.beta1+ (x64) Id. de compilación: 02a8982aa505480fe744991bfa41efdc1436e60e Subprocs. CPU: 4; SO: Windows 10.0; Repres. IU: GL; VCL: win; TinderBox: Win-x86_64@42, Branch:libreoffice-6-2, Time: 2018-12-04_05:56:47 Configuración regional: es-ES (es_ES); Idioma de IU: es-ES Calc: threaded Bad Version: 6.3.0.0.alpha0+ (x64) Build ID: 16d12d50c2bfd924d2a7e6946896526a15a150d4 CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-12-04_00:57:42 Locale: es-ES (es_ES); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120727] Excessive CPU usage under normal use (typing)
https://bugs.documentfoundation.org/show_bug.cgi?id=120727 Xisco Faulí changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||1778 --- Comment #8 from Xisco Faulí --- Might be related to bug 121778... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121778] LibreOffice Vanilla not usable; opens OK but crashes when entering data
https://bugs.documentfoundation.org/show_bug.cgi?id=121778 Xisco Faulí changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||0727 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121910] Is LibreOffice Vanilla compatible with macOS Majove?
https://bugs.documentfoundation.org/show_bug.cgi?id=121910 Xisco Faulí changed: What|Removed |Added Resolution|--- |DUPLICATE CC||xiscofa...@libreoffice.org Status|UNCONFIRMED |RESOLVED --- Comment #1 from Xisco Faulí --- Seems like a dupe of bug 121778. There's already a patch to fix it. *** This bug has been marked as a duplicate of bug 121778 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121778] LibreOffice Vanilla not usable; opens OK but crashes when entering data
https://bugs.documentfoundation.org/show_bug.cgi?id=121778 Xisco Faulí changed: What|Removed |Added CC||brenda.may...@btinternet.co ||m --- Comment #11 from Xisco Faulí --- *** Bug 121910 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121570] XINERAMA
https://bugs.documentfoundation.org/show_bug.cgi?id=121570 Xisco Faulí changed: What|Removed |Added Resolution|FIXED |WORKSFORME --- Comment #7 from Xisco Faulí --- Thanks for retesting with the latest version. Setting to RESOLVED WORKSFORME as the commit fixing this issue hasn't been identified. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sd/uiconfig
sd/uiconfig/sdraw/ui/notebookbar_groupedbar_compact.ui | 439 - 1 file changed, 229 insertions(+), 210 deletions(-) New commits: commit a0477a479293211ca97d1047cd7eb06116da4244 Author: andreas kainz AuthorDate: Wed Nov 28 17:29:29 2018 +0100 Commit: andreas_kainz CommitDate: Tue Dec 4 23:26:13 2018 +0100 NB: update draw groupedbar_compact Change-Id: I10f801de49cdf3d5fb37657ee88842223bf50570 Reviewed-on: https://gerrit.libreoffice.org/64385 Tested-by: Jenkins Reviewed-by: andreas_kainz (cherry picked from commit 5f6b5c98dd1d46b09ad02111c2884a195c053223) Reviewed-on: https://gerrit.libreoffice.org/64512 diff --git a/sd/uiconfig/sdraw/ui/notebookbar_groupedbar_compact.ui b/sd/uiconfig/sdraw/ui/notebookbar_groupedbar_compact.ui index 1b081e0b1c45..7bc75788ccf5 100644 --- a/sd/uiconfig/sdraw/ui/notebookbar_groupedbar_compact.ui +++ b/sd/uiconfig/sdraw/ui/notebookbar_groupedbar_compact.ui @@ -7,54 +7,54 @@ True False - + True False .uno:ExtrusionToggle - + True False - + True False .uno:ExtrusionTiltDown - + True False .uno:ExtrusionTiltUp - + True False .uno:ExtrusionTiltLeft - + True False .uno:ExtrusionTiltRight - + True False - + True False .uno:Window3D @@ -265,151 +265,165 @@ True False - + True False .uno:Line - + True False .uno:Freeline_Unfilled - + True False .uno:Freeline - + True False .uno:Bezier_Unfilled - + True False .uno:BezierFill - + True False .uno:Polygon_Unfilled - + True False .uno:Polygon_Diagonal_Unfilled - + True False .uno:Polygon_Diagonal - + True False - + True False .uno:BasicShapes - + True False .uno:SymbolShapes - + True False .uno:ArrowShapes - + True False .uno:StarShapes - + True False .uno:CalloutShapes - + True False .uno:FlowChartShapes - + True False - + True False .uno:DrawCaption - + True False .uno:InsertGraphic - + True False .uno:FontworkGalleryFloater - + True False - + +True +False +.uno:Text + + + + +True +False +.uno:VerticalText + + + + True False .uno:ExtrusionToggle - + True False .uno:ToggleObjectBezierMode @@ -506,107 +520,120 @@ True False - + True False .uno:Undo - + True False .uno:Redo - + True False .uno:Repeat - + True False - + True False .uno:Cut - + True False .uno:Copy - + True False .uno:Paste - + True False -.uno:PasteSpecial +.uno:PasteUnformatted - + True False -.uno:PasteUnformatted +.uno:PasteSpecial - + True False - + True False .uno:SelectAll - + True False - + True False
[Libreoffice-bugs] [Bug 72662] Be able to see different measurement units for line versus page properties (e.g. pt and in)
https://bugs.documentfoundation.org/show_bug.cgi?id=72662 --- Comment #13 from Cor Nouws --- (In reply to Luke from comment #10) > This alone would solve my use case and the use case described by the bug > reporter. Making the UI easier to change these 2 classes is fine, but I'm > opposed to modifying the UI without first addressing this underlying issue. Looks as a useful idea to me. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 72662] Be able to see different measurement units for line versus page properties (e.g. pt and in)
https://bugs.documentfoundation.org/show_bug.cgi?id=72662 --- Comment #13 from Cor Nouws --- (In reply to Luke from comment #10) > This alone would solve my use case and the use case described by the bug > reporter. Making the UI easier to change these 2 classes is fine, but I'm > opposed to modifying the UI without first addressing this underlying issue. Looks as a useful idea to me. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 121574] Enhancement : Pasting from Writer to Impress Should be "Text only" by default
https://bugs.documentfoundation.org/show_bug.cgi?id=121574 Cor Nouws changed: What|Removed |Added Version|6.0.6.2 release |Inherited From OOo --- Comment #9 from Cor Nouws --- Pasting a slide to a text document, seems more useful to me than pasting just text. And I agree with Luke on the consistency, -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121778] LibreOffice Vanilla not usable; opens OK but crashes when entering data
https://bugs.documentfoundation.org/show_bug.cgi?id=121778 --- Comment #10 from Tor Lillqvist --- See https://gerrit.libreoffice.org/#/c/64576/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 64370] Templates with Different File Name but Same Title are not Displayed in Template Manager
https://bugs.documentfoundation.org/show_bug.cgi?id=64370 --- Comment #13 from Harald Koester --- Bug according comment 11 still exists with version 6.1.3 (64 bit, Win 10). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52234] EDITING: Mouse pointer does not change timely to "move view" when drag modus changes to "without shadow"
https://bugs.documentfoundation.org/show_bug.cgi?id=52234 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #20 from Regina Henschel --- This is not a bug at all. There exists two modes. One is the move mode with the "cross" mouse pointer. You need it, if you want to move an object within the current page. The other one is a drag mode. It has a rectangle as mouse pointer. You need it, if you want to move or copy the object to a different page in the page panel or to a different layer. That mode keeps the position of the object. You use the modifier key Ctrl to switch form move to copy. Copying works too on the same page. In addition you need that mode, if you want to put an object into a Gallery theme or you want to drag it into a different document. For me the time of about a second to switch from move mode to drag mode is just right. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51289] UI: Add an easy way to add image as chart background
https://bugs.documentfoundation.org/show_bug.cgi?id=51289 Markus Mohrhard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Markus Mohrhard --- Seems to be fixed in master and most likely some older builds. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108538] [META] Chart feature enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108538 Bug 108538 depends on bug 51289, which changed state. Bug 51289 Summary: UI: Add an easy way to add image as chart background https://bugs.documentfoundation.org/show_bug.cgi?id=51289 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120243] Remove old idle workaround ...
https://bugs.documentfoundation.org/show_bug.cgi?id=120243 Markus Mohrhard changed: What|Removed |Added Component|Chart |Calc -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] translations.git: Changes to 'refs/tags/cd-5.3-61'
Tag 'cd-5.3-61' created by Andras Timar at 2018-12-04 21:41 + cd-5.3-61 Changes since cp-5.3-53-2: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/tags/cd-5.3-61'
Tag 'cd-5.3-61' created by Andras Timar at 2018-12-04 21:41 + cd-5.3-61 Changes since cd-5.3-60-1: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cd-5.3-61'
Tag 'cd-5.3-61' created by Andras Timar at 2018-12-04 21:41 + cd-5.3-61 Changes since cp-5.3-10: Olivier R (1): tdf#107558 French spelling dictionary (6.0.3) and thesaurus --- fr_FR/README_fr.txt |4 fr_FR/description.xml |2 fr_FR/fr.aff |17751 ++-- fr_FR/fr.dic |155369 +- fr_FR/package-description.txt |2 fr_FR/thes_fr.dat | 206 6 files changed, 88495 insertions(+), 84839 deletions(-) --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Changes to 'refs/tags/cd-5.3-61'
Tag 'cd-5.3-61' created by Andras Timar at 2018-12-04 21:41 + cd-5.3-61 Changes since libreoffice-5-3-branch-point-28: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cd-5.3-3.4' - 2 commits - configure.ac uui/source
configure.ac |2 +-
uui/source/iahndl-ssl.cxx |7 +++
2 files changed, 8 insertions(+), 1 deletion(-)
New commits:
commit 476212d9b2b91ceedf48b998e4eaa91e1bda0ff6
Author: Andras Timar
AuthorDate: Thu Nov 29 14:47:24 2018 +0100
Commit: Andras Timar
CommitDate: Tue Dec 4 22:41:01 2018 +0100
Bump version to 5.3-61
Change-Id: I0753c83b554dca20de6650d7947b3112d177df90
(cherry picked from commit cd2475c52a096b001a7e3179f02e11cbc8a5615f)
diff --git a/configure.ac b/configure.ac
index bd93fe182eb5..c9227f742d5b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
# several non-alphanumeric characters, those are split off and used only for
the
# ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no
idea.
-AC_INIT([Collabora Office],[5.3.10.60],[],[],[https://collaboraoffice.com/])
+AC_INIT([Collabora Office],[5.3.10.61],[],[],[https://collaboraoffice.com/])
AC_PREREQ([2.59])
commit c625c49bac701c9b58ed4728a460b7094d632501
Author: Andras Timar
AuthorDate: Sun Nov 25 17:41:20 2018 +0100
Commit: Andras Timar
CommitDate: Tue Dec 4 22:40:54 2018 +0100
Do not validate SSL cert in LOK case
Currently we cannot tunnel interaction handler dialog, so if there
is a problem with site's SSL cert, the operation (e.g. insert image)
would silently fail. As a workaround, let's not validate the remote
site's SSL cert, as we also do not validate the site's SSL cert when
we download the file through WOPI from the site, in the first place.
So this patch does not really make things worse, but makes it possible
to use the insert image feature with a self signed cert in test
environments.
Change-Id: I672ba9016b1555c6d9d8faba8d0a4b2a17adf453
Reviewed-on: https://gerrit.libreoffice.org/63993
Reviewed-by: Andras Timar
Tested-by: Andras Timar
(cherry picked from commit ea471b508cb90fbaa770f291a40864324d8d74ef)
diff --git a/uui/source/iahndl-ssl.cxx b/uui/source/iahndl-ssl.cxx
index 20688f7a3c9f..d27e273952b9 100644
--- a/uui/source/iahndl-ssl.cxx
+++ b/uui/source/iahndl-ssl.cxx
@@ -28,6 +28,7 @@
#include
#include
+#include
#include
#include
#include
@@ -256,6 +257,12 @@ handleCertificateValidationRequest_(
uno::Reference< task::XInteractionAbort > xAbort;
getContinuations(rContinuations, , );
+if ( comphelper::LibreOfficeKit::isActive() && xApprove.is() )
+{
+xApprove->select();
+return;
+}
+
sal_Int32 failures = rRequest.CertificateValidity;
bool trustCert = true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Changes to 'refs/tags/cd-3.4.2-1'
Tag 'cd-3.4.2-1' created by Andras Timar at 2018-12-04 21:38 + cd-3.4.2-1 Changes since cd-3.4.1-2-10: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-cd-3-4' - 10 commits - capabilities.json configure.ac debian/changelog debian/control etc/apache2 etc/nginx loleaflet/po lol
capabilities.json |5 --
configure.ac |2 -
debian/changelog |6 +++
debian/control|2 -
etc/apache2/loolwsd.conf |4 ++
etc/nginx/loolwsd.conf|6 +++
loleaflet/po/ui-de.po |2 -
loleaflet/po/ui-es.po |2 -
loleaflet/po/ui-fr.po |2 -
loleaflet/po/ui-ja.po |2 -
loleaflet/po/ui-pt.po |2 -
loleaflet/src/control/Control.Scroll.js |2 -
loleaflet/src/control/Parts.js|2 -
loleaflet/src/layer/tile/TileLayer.js | 55 +++---
loleaflet/src/map/Map.js | 22 +++-
loleaflet/src/map/handler/Map.Keyboard.js |8
loleaflet/src/map/handler/Map.Scroll.js |2 -
loolwsd.spec.in |4 +-
tools/Config.cpp | 10 +
wsd/LOOLWSD.cpp | 28 +++
20 files changed, 95 insertions(+), 73 deletions(-)
New commits:
commit 49ae58ece98c9457b1b33e9f3082e71ee0ae6125
Author: Andras Timar
AuthorDate: Tue Dec 4 22:36:39 2018 +0100
Commit: Andras Timar
CommitDate: Tue Dec 4 22:36:39 2018 +0100
loleaflet: updated translations
Change-Id: I987c2056b08174d7e0b2e3665602a97169c28809
diff --git a/loleaflet/po/ui-de.po b/loleaflet/po/ui-de.po
index b4bfd002e..39fbd8f67 100644
--- a/loleaflet/po/ui-de.po
+++ b/loleaflet/po/ui-de.po
@@ -834,4 +834,4 @@ msgstr "Hochladen..."
#: src/map/handler/Map.WOPI.js:250
msgid "Creating copy..."
-msgstr ""
+msgstr "Kopie erstellen..."
diff --git a/loleaflet/po/ui-es.po b/loleaflet/po/ui-es.po
index 359a3e8bd..cd7ede66b 100644
--- a/loleaflet/po/ui-es.po
+++ b/loleaflet/po/ui-es.po
@@ -834,4 +834,4 @@ msgstr "Cargando…"
#: src/map/handler/Map.WOPI.js:250
msgid "Creating copy..."
-msgstr ""
+msgstr "Creando una copia…"
diff --git a/loleaflet/po/ui-fr.po b/loleaflet/po/ui-fr.po
index ba5c45f80..bedc37e7e 100644
--- a/loleaflet/po/ui-fr.po
+++ b/loleaflet/po/ui-fr.po
@@ -834,4 +834,4 @@ msgstr "Chargement…"
#: src/map/handler/Map.WOPI.js:250
msgid "Creating copy..."
-msgstr ""
+msgstr "Création d'une copie..."
diff --git a/loleaflet/po/ui-ja.po b/loleaflet/po/ui-ja.po
index 0a5d8aa63..398c80394 100644
--- a/loleaflet/po/ui-ja.po
+++ b/loleaflet/po/ui-ja.po
@@ -834,4 +834,4 @@ msgstr "アップロード中..."
#: src/map/handler/Map.WOPI.js:250
msgid "Creating copy..."
-msgstr ""
+msgstr "コピーの作成..."
diff --git a/loleaflet/po/ui-pt.po b/loleaflet/po/ui-pt.po
index 12abf33e1..a9007b833 100644
--- a/loleaflet/po/ui-pt.po
+++ b/loleaflet/po/ui-pt.po
@@ -834,4 +834,4 @@ msgstr "A enviar..."
#: src/map/handler/Map.WOPI.js:250
msgid "Creating copy..."
-msgstr ""
+msgstr "Criar uma cópia..."
commit 16e6a04f4c8ae3e2f8323146d1e00a1b56906ada
Author: Andras Timar
AuthorDate: Thu Nov 29 15:37:19 2018 +0100
Commit: Andras Timar
CommitDate: Tue Dec 4 22:19:02 2018 +0100
Bump package version to 3.4.2-1
Change-Id: I6287e625e8049a9962ef64bb01d6ba0a783f24e7
(cherry picked from commit e503dc1c82fd33f3191824f694b55fccc217e8da)
diff --git a/configure.ac b/configure.ac
index c213ed383..495767fcf 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3,7 +3,7 @@
AC_PREREQ([2.63])
-AC_INIT([loolwsd], [3.4.1], [libreoffice@lists.freedesktop.org])
+AC_INIT([loolwsd], [3.4.2], [libreoffice@lists.freedesktop.org])
LT_INIT([shared, disable-static, dlopen])
AM_INIT_AUTOMAKE([1.10 subdir-objects tar-pax -Wno-portability])
diff --git a/debian/changelog b/debian/changelog
index 5438841d7..0ed964368 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+loolwsd (3.4.2-1) unstable; urgency=medium
+
+ * see the git log: http://col.la/coolcd34
+
+ -- Andras Timar Thu, 29 Nov 2018 15:30:00 +0100
+
loolwsd (3.4.1-2) unstable; urgency=medium
* see the git log: http://col.la/coolcd34
diff --git a/debian/control b/debian/control
index 4ca2f3292..2dcc6ca2e 100644
--- a/debian/control
+++ b/debian/control
@@ -8,7 +8,7 @@ Standards-Version: 3.9.7
Package: loolwsd
Section: web
Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, adduser, fontconfig, libsm6,
libxinerama1, libxrender1, libgl1-mesa-glx, libcups2, libcurl3-gnutls, cpio,
libcap2-bin, libexpat1, libicu55, libjpeg-turbo8, libnss3, libpng12-0,
libpoppler58, libxcb-render0, libxcb-shm0, libxml2, libxslt1.1,
collaboraofficebasis5.3-calc (>= 5.3.10.60), collaboraofficebasis5.3-core (>=
5.3.10.60), collaboraofficebasis5.3-graphicfilter (>= 5.3.10.60),
collaboraofficebasis5.3-images (>= 5.3.10.60), collaboraofficebasis5.3-impress
(>= 5.3.10.60), collaboraofficebasis5.3-ooofonts (>= 5.3.10.60),
collaboraofficebasis5.3-writer (>= 5.3.10.60), collaboraoffice5.3 (>=
5.3.10.60), collaboraoffice5.3-ure (>= 5.3.10.60),
[Libreoffice-bugs] [Bug 121570] XINERAMA
https://bugs.documentfoundation.org/show_bug.cgi?id=121570 rayandr...@eastlink.ca changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED --- Comment #6 from rayandr...@eastlink.ca --- It's fixed guys, thanks. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
