[Libreoffice-commits] core.git: basctl/source
basctl/source/basicide/basides1.cxx |9 basctl/source/basicide/basobj2.cxx |2 basctl/source/basicide/macrodlg.cxx | 23 +- basctl/source/basicide/moduldl2.cxx | 391 ++-- basctl/source/dlged/managelang.cxx | 28 +- 5 files changed, 230 insertions(+), 223 deletions(-) New commits: commit 99cecd1f12a1d17822b9b29ceb112c0c48945386 Author: Noel Grandin AuthorDate: Sat Dec 29 13:26:25 2018 +0200 Commit: Noel Grandin CommitDate: Sun Dec 30 08:47:26 2018 +0100 use StartExecuteAsync in basctl Change-Id: Id24d03631ff60305525835144ad543d5dcb2064f Reviewed-on: https://gerrit.libreoffice.org/65709 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/basctl/source/basicide/basides1.cxx b/basctl/source/basicide/basides1.cxx index d6611bc764ef..7cc498490af6 100644 --- a/basctl/source/basicide/basides1.cxx +++ b/basctl/source/basicide/basides1.cxx @@ -739,9 +739,12 @@ void Shell::ExecuteGlobal( SfxRequest& rReq ) case SID_BASICIDE_MANAGE_LANG: { -ScopedVclPtrInstance< ManageLanguageDialog > aDlg(pCurWin, m_pCurLocalizationMgr); -aDlg->Execute(); -rReq.Done(); +std::shared_ptr pRequest(new SfxRequest(rReq)); +rReq.Ignore(); // the 'old' request is not relevant any more +auto pDlg = VclPtr::Create(pCurWin, m_pCurLocalizationMgr); +pDlg->StartExecuteAsync([=](sal_Int32 /*nResult*/){ +pRequest->Done(); +}); } break; diff --git a/basctl/source/basicide/basobj2.cxx b/basctl/source/basicide/basobj2.cxx index 708c35dbd7c1..de273c0810cd 100644 --- a/basctl/source/basicide/basobj2.cxx +++ b/basctl/source/basicide/basobj2.cxx @@ -72,7 +72,7 @@ void Organize( sal_Int16 tabId ) aDesc = pCurWin->CreateEntryDescriptor(); vcl::Window* pParent = Application::GetDefDialogParent(); -ScopedVclPtrInstance(pParent, tabId, aDesc)->Execute(); +VclPtr::Create(pParent, tabId, aDesc)->StartExecuteAsync(nullptr); } bool IsValidSbxName( const OUString& rName ) diff --git a/basctl/source/basicide/macrodlg.cxx b/basctl/source/basicide/macrodlg.cxx index f882d7a9542f..fb2500aad587 100644 --- a/basctl/source/basicide/macrodlg.cxx +++ b/basctl/source/basicide/macrodlg.cxx @@ -742,20 +742,19 @@ IMPL_LINK(MacroChooser, ButtonHdl, weld::Button&, rButton, void) m_xBasicBox->get_selected(m_xBasicBoxIter.get()); EntryDescriptor aDesc = m_xBasicBox->GetEntryDescriptor(m_xBasicBoxIter.get()); VclPtrInstance< OrganizeDialog > pDlg( nullptr, 0, aDesc ); //TODO -sal_uInt16 nRet = pDlg->Execute(); -pDlg.reset(); - -if ( nRet ) // not only closed -{ -m_xDialog->response(Macro_Edit); -return; -} +pDlg->StartExecuteAsync([=](sal_Int32 nRet){ +if ( nRet ) // not only closed +{ +m_xDialog->response(Macro_Edit); +return; +} -Shell* pShell = GetShell(); -if ( pShell && pShell->IsAppBasicModified() ) -bForceStoreBasic = true; +Shell* pShell = GetShell(); +if ( pShell && pShell->IsAppBasicModified() ) +bForceStoreBasic = true; -m_xBasicBox->UpdateEntries(); +m_xBasicBox->UpdateEntries(); +}); } } diff --git a/basctl/source/basicide/moduldl2.cxx b/basctl/source/basicide/moduldl2.cxx index c7cf1527007b..5bbcd1a5dccd 100644 --- a/basctl/source/basicide/moduldl2.cxx +++ b/basctl/source/basicide/moduldl2.cxx @@ -831,240 +831,243 @@ void LibPage::InsertLib() if ( aExtension != aLibExtension && aExtension != aContExtension ) pLibDlg->EnableReference(false); -if ( !pLibDlg->Execute() ) -return; - -bool bChanges = false; -sal_uLong nNewPos = m_pLibBox->GetEntryCount(); -bool bRemove = false; -bool bReplace = pLibDlg->IsReplace(); -bool bReference = pLibDlg->IsReference(); -for ( sal_uLong nLib = 0; nLib < pLibDlg->GetLibBox().GetEntryCount(); nLib++ ) -{ -if ( pLibDlg->GetLibBox().IsChecked( nLib ) ) +pLibDlg->StartExecuteAsync([=](sal_Int32 nResult) { -SvTreeListEntry* pEntry = pLibDlg->GetLibBox().GetEntry( nLib ); -DBG_ASSERT( pEntry, "Entry?!" ); -OUString aLibName( SvTabListBox::GetEntryText( pEntry, 0 ) ); -Reference< script::XLibraryContainer2 > xModLibContainer( m_aCurDocument.getLibraryContainer( E_SCRIPTS ), UNO_QUERY ); -Reference< script::XLibraryContainer2 > xDlgLibContainer( m_aCurDocument.getLibraryContainer( E_DIALOGS ), UNO_QUERY ); - -// check, if the library is already existing -if ( ( xModLibContainer.is() && xModLibContainer->hasByName( aLibName ) ) || - ( xDlgLibContainer.is() &&
[Libreoffice-bugs] [Bug 122367] Find text: Counter-intuitive Find Next/Previous arrow buttons
https://bugs.documentfoundation.org/show_bug.cgi?id=122367 V Stuart Foote changed: What|Removed |Added Ever confirmed|1 |0 Status|NEW |UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122370] Style Heading 1 is not applied to content nor option Numeric with all sublevels is applied to Headings whose levels are superior to level 1.
https://bugs.documentfoundation.org/show_bug.cgi?id=122370 Dieter Praas changed: What|Removed |Added CC||dgp-m...@gmx.de --- Comment #2 from Dieter Praas --- Ricky, I'm not sure, if I grasp your problem. I opened the paragraph dialog for styles heading 1 and heading 2. Numbering style was set to none. I can't follow your 4th step: "Under Bullets and Numbering -> Outline, apply option Numeric with all sublevels to styles Heading 1, Heading 2;" So could you perhaps (at last for me) give some more infomration about this step? Additional information: You combine heading with lists. If you qant to create chapter numbering, you should use tools => chapter numbering instead of lists. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: download.lst solenv/flatpak-manifest.in
download.lst |4 ++-- solenv/flatpak-manifest.in |6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) New commits: commit 6aaed7c5165ea87c3a263fd9582c97892345120f Author: David Tardon AuthorDate: Sat Dec 29 20:23:26 2018 +0100 Commit: David Tardon CommitDate: Sun Dec 30 08:19:18 2018 +0100 upload libqxp 0.0.2 Change-Id: Idda6c0ce0c087a3be2e7fe31999a7d5a6fde4835 Reviewed-on: https://gerrit.libreoffice.org/65725 Tested-by: Jenkins Reviewed-by: David Tardon diff --git a/download.lst b/download.lst index 0745b7058f3c..e7aa94b3ff77 100644 --- a/download.lst +++ b/download.lst @@ -212,8 +212,8 @@ export POSTGRESQL_SHA256SUM := a754c02f7051c2f21e52f8669a421b50485afcde9a581674d export POSTGRESQL_TARBALL := postgresql-9.2.24.tar.bz2 export PYTHON_SHA256SUM := 063d2c3b0402d6191b90731e0f735c64830e7522348aeb7ed382a83165d45009 export PYTHON_TARBALL := Python-3.5.5.tar.xz -export QXP_SHA256SUM := 8c257f6184ff94aefa7c9fa1cfae82083d55a49247266905c71c53e013f95c73 -export QXP_TARBALL := libqxp-0.0.1.tar.xz +export QXP_SHA256SUM := e137b6b110120a52c98edd02ebdc4095ee08d0d5295a94316a981750095a945c +export QXP_TARBALL := libqxp-0.0.2.tar.xz export RAPTOR_SHA256SUM := ada7f0ba54787b33485d090d3d2680533520cd4426d2f7fb4782dd4a6a1480ed export RAPTOR_TARBALL := a39f6c07ddb20d7dd2ff1f95fa21e2cd-raptor2-2.0.15.tar.gz export RASQAL_SHA256SUM := 6924c9ac6570bd241a9669f83b467c728a322470bf34f4b2da4f69492ccfd97c diff --git a/solenv/flatpak-manifest.in b/solenv/flatpak-manifest.in index 7da44be8953d..bb9b9c993f7b 100644 --- a/solenv/flatpak-manifest.in +++ b/solenv/flatpak-manifest.in @@ -409,10 +409,10 @@ "dest-filename": "external/tarballs/libepubgen-0.1.1.tar.xz" }, { -"url": "https://dev-www.libreoffice.org/src/libqxp-0.0.1.tar.xz;, -"sha256": "8c257f6184ff94aefa7c9fa1cfae82083d55a49247266905c71c53e013f95c73", +"url": "https://dev-www.libreoffice.org/src/libqxp-0.0.2.tar.xz;, +"sha256": "e137b6b110120a52c98edd02ebdc4095ee08d0d5295a94316a981750095a945c", "type": "file", -"dest-filename": "external/tarballs/libqxp-0.0.1.tar.xz" +"dest-filename": "external/tarballs/libqxp-0.0.2.tar.xz" }, { "url": "https://dev-www.libreoffice.org/src/alef-1.001.tar.gz;, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 122348] EDITING: Image width/height ratio can be lost in properties dialogue
https://bugs.documentfoundation.org/show_bug.cgi?id=122348 Dieter Praas changed: What|Removed |Added OS|All |Windows (All) --- Comment #5 from Dieter Praas --- With pressing Enter I can confirm in Version: 6.3.0.0.alpha0+ (x64) Build ID: ffa5b8a82eab18041bbee4d6914892b82c7801d3 CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-12-19_03:24:54 Locale: en-US (de_DE); UI-Language: en-US Calc: threaded but not in Version: 6.1.4.2 (x64) Build-ID: 9d0f32d1f0b509096fd65e0d4bec26ddd1938fd3 CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; Gebietsschema: de-DE (de_DE); Calc: group threaded Until now the bug wasn't confirmed with Linux, so I changed hardware to Windows. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105584] [META] Calc image bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105584 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||119163 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=119163 [Bug 119163] Spreadsheets containing thousands of embedded images are slow to navigate -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119163] Spreadsheets containing thousands of embedded images are slow to navigate
https://bugs.documentfoundation.org/show_bug.cgi?id=119163 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||105584 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105584 [Bug 105584] [META] Calc image bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86066] [META] bugs and improvements to the statusbar
https://bugs.documentfoundation.org/show_bug.cgi?id=86066 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||119248 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=119248 [Bug 119248] Status bar displays "wrong" sum when colored negative cell format used -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119248] Status bar displays "wrong" sum when colored negative cell format used
https://bugs.documentfoundation.org/show_bug.cgi?id=119248 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||86066 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=86066 [Bug 86066] [META] bugs and improvements to the statusbar -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119253] [Writer Table] Freezes/hangs when splits a table with merged cells to 2 pages
https://bugs.documentfoundation.org/show_bug.cgi?id=119253 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||t...@libreoffice.org Blocks||103100 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103100 [Bug 103100] [META] Writer table bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||119253 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=119253 [Bug 119253] [Writer Table] Freezes/hangs when splits a table with merged cells to 2 pages -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107701] [META] Table border bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107701 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||119818 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=119818 [Bug 119818] Right table border disappearing for 1/2 sec when holding space -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119818] Right table border disappearing for 1/2 sec when holding space
https://bugs.documentfoundation.org/show_bug.cgi?id=119818 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||107923, 107701 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107701 [Bug 107701] [META] Table border bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=107923 [Bug 107923] [META] Zoom issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107923] [META] Zoom issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107923 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||119818 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=119818 [Bug 119818] Right table border disappearing for 1/2 sec when holding space -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122367] Find text: Counter-intuitive Find Next/Previous arrow buttons
https://bugs.documentfoundation.org/show_bug.cgi?id=122367 Tom changed: What|Removed |Added Status|NEEDINFO|NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122367] Find text: Counter-intuitive Find Next/Previous arrow buttons
https://bugs.documentfoundation.org/show_bug.cgi?id=122367 --- Comment #4 from Tom --- Created attachment 147894 --> https://bugs.documentfoundation.org/attachment.cgi?id=147894=edit Find Screenshot of LO 6.0.7.3 Follow-up: Please see the corresponding screenshot of LO 6.0.7.3 running on the same computer. As you can see the button icons are correct in LO 6.0.7.3. Regards Tom -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||119880 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=119880 [Bug 119880] Writer 6.1.1 fails to export to PDF a document containing PDF 1.5 images -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119880] Writer 6.1.1 fails to export to PDF a document containing PDF 1.5 images
https://bugs.documentfoundation.org/show_bug.cgi?id=119880 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Keywords||filter:pdf Blocks||103378 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103378 [Bug 103378] [META] PDF export bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107830] [META] DOCX (OOXML) paragraph-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107830 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||119886 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=119886 [Bug 119886] DOCX: Spacing of font "Open Sans" differs from Word -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119886] DOCX: Spacing of font "Open Sans" differs from Word
https://bugs.documentfoundation.org/show_bug.cgi?id=119886 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||107830 Keywords||filter:docx Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107830 [Bug 107830] [META] DOCX (OOXML) paragraph-related issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122355] HELP button in Format Cells no longer opens help on Format Cells (it opens top of Help)
https://bugs.documentfoundation.org/show_bug.cgi?id=122355 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks|58168 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=58168 [Bug 58168] [META] LOCALHELP reached via Help button should be context related -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58168] [META] LOCALHELP reached via Help button should be context related
https://bugs.documentfoundation.org/show_bug.cgi?id=58168 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on|122355 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122355 [Bug 122355] HELP button in Format Cells no longer opens help on Format Cells (it opens top of Help) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122355] HELP button in Format Cells no longer opens help on Format Cells (it opens top of Help)
https://bugs.documentfoundation.org/show_bug.cgi?id=122355 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||58168 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=58168 [Bug 58168] [META] LOCALHELP reached via Help button should be context related -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58168] [META] LOCALHELP reached via Help button should be context related
https://bugs.documentfoundation.org/show_bug.cgi?id=58168 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||122355 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122355 [Bug 122355] HELP button in Format Cells no longer opens help on Format Cells (it opens top of Help) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122376] New: EDITING Calc locks up when selecting cells for formula across "freeze" boundary
https://bugs.documentfoundation.org/show_bug.cgi?id=122376 Bug ID: 122376 Summary: EDITING Calc locks up when selecting cells for formula across "freeze" boundary Product: LibreOffice Version: 6.0.7.3 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jamshar...@zoho.com This sequence of events reliably locks up LibO Calc for me. 1. Set up a sheet like this: NameValues A 1 2 3 B 4 5 6 C 7 8 9 2. Go to C2 (value 1). 3. View > Freeze Cells > Freeze Rows and Columns. 4. Go to B2 (empty). This is to the left of the "Freeze Columns" boundary. 5. Type "=sum(" and right-arrow to C2 (which is to the right of the boundary). It will probably lock up here. If it doesn't, try shift-right-arrow to E3. At some point during the key sequence in step 5, LibO enters an infinite loop. The interface locks up and the only option is to kill the program (and hope that document recovery works -- which it did, actually). I saw this issue repeatedly in LibO 6.0.4.2. I just upgraded to 6.0.7.3 to see if it had been fixed, and it's still a problem in this version. I haven't tried the 6.2 RC (and I'm not a heavy enough LibO user to a lot of time into installing many versions). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122370] Style Heading 1 is not applied to content nor option Numeric with all sublevels is applied to Headings whose levels are superior to level 1.
https://bugs.documentfoundation.org/show_bug.cgi?id=122370 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||107833 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107833 [Bug 107833] [META] Writer paragraph style bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107833] [META] Writer paragraph style bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107833 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||122370 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122370 [Bug 122370] Style Heading 1 is not applied to content nor option Numeric with all sublevels is applied to Headings whose levels are superior to level 1. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74244] OSX LibreOffice.App Version is incorrect on 4.2.0.4 RELEASE through 4.2.2.1 RC1, let's make that consistent with the "About" window
https://bugs.documentfoundation.org/show_bug.cgi?id=74244 V Stuart Foote changed: What|Removed |Added CC||jul...@corecode.io --- Comment #14 from V Stuart Foote --- *** Bug 122375 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122375] the version information embedded in LibreOffice for macOS are broken
https://bugs.documentfoundation.org/show_bug.cgi?id=122375 V Stuart Foote changed: What|Removed |Added CC||t...@iki.fi, ||vstuart.fo...@utsa.edu Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from V Stuart Foote --- *** This bug has been marked as a duplicate of bug 74244 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122188] Disappear table lines with a dark theme
https://bugs.documentfoundation.org/show_bug.cgi?id=122188 --- Comment #3 from tr...@yandex.com --- I can reproduce it on my Tumbleweed KDE with: - libreoffice-calc-6.1.3 - Breeze-dark gtk theme -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100164] HiDPI shouldn't be thresholded
https://bugs.documentfoundation.org/show_bug.cgi?id=100164 --- Comment #5 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59274] FILEOPEN: table in DOCX file is more narrower than it should be (no AutoFit Table Layout from OOXML)
https://bugs.documentfoundation.org/show_bug.cgi?id=59274 --- Comment #20 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107513] Template title and comments shouldnt be used in document
https://bugs.documentfoundation.org/show_bug.cgi?id=107513 --- Comment #13 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102298] [UI] In Autofilter the 5 elements on top do not get focus by Tab, nor have a shortcut
https://bugs.documentfoundation.org/show_bug.cgi?id=102298 --- Comment #6 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100758] [FILEOPEN] Word Continuous section break results in 2nd and more footnotes being pushed to next page on import of DOCX file
https://bugs.documentfoundation.org/show_bug.cgi?id=100758 --- Comment #5 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114585] doc top row is missing for bottom table
https://bugs.documentfoundation.org/show_bug.cgi?id=114585 --- Comment #2 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114746] Improve CJK and CTL fonts setting in default Impress templates
https://bugs.documentfoundation.org/show_bug.cgi?id=114746 --- Comment #6 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92249] Checkboxes and radio buttons (in Options screen) too small on HiDPI
https://bugs.documentfoundation.org/show_bug.cgi?id=92249 --- Comment #8 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95033] Borders missing from some table cells in DOCX file
https://bugs.documentfoundation.org/show_bug.cgi?id=95033 --- Comment #9 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95804] FILEOPEN: DOC import: incomplete import of table in footnote
https://bugs.documentfoundation.org/show_bug.cgi?id=95804 --- Comment #3 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
#Bug 114441
Hello Team, I am Komal. I am novice to open source. But really interested to learn and contribute for this organization. I went through #Bug 114441 [1] description and I made changes to one of the file ./sw/inc/pvprtdat.hxx. But I was confused about how to commit the changes. I have committed it on libreoffice/core repository on github. Is that valid? I'm sorry if I have done anything wrong. Thank you! [1]https://bugs.documentfoundation.org/show_bug.cgi?id=114441 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
CppCheck Report Update
A new cppcheck report is available at : http://dev-builds.libreoffice.org/cppcheck_reports/master/ Note: The script generating this report was run at : 2018-30-12 03:07:31 with user buildslave at host vm140 as /home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s /home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w /home/buildslave/tmp/www It can be found and improved here: https://gerrit.libreoffice.org/plugins/gitiles/dev-tools/+/master/cppcheck/cppcheck-report.sh ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: icon-themes/breeze icon-themes/breeze_dark icon-themes/breeze_svg icon-themes/colibre icon-themes/colibre_svg
icon-themes/breeze/cmd/lc_currencyfield.png|binary icon-themes/breeze/cmd/lc_renameobject.png |binary icon-themes/breeze/cmd/lc_renamepage.png |binary icon-themes/breeze/cmd/lc_renameslide.png |binary icon-themes/breeze/cmd/lc_renametable.png |binary icon-themes/breeze/cmd/lc_savebackground.png |binary icon-themes/breeze/cmd/lc_selectbackground.png |binary icon-themes/breeze/cmd/sc_currencyfield.png|binary icon-themes/breeze/cmd/sc_displaymasterbackground.png |binary icon-themes/breeze/cmd/sc_insertgraphic.png|binary icon-themes/breeze/cmd/sc_renameobject.png |binary icon-themes/breeze/cmd/sc_renamepage.png |binary icon-themes/breeze/cmd/sc_renameslide.png |binary icon-themes/breeze/cmd/sc_renametable.png |binary icon-themes/breeze/cmd/sc_savebackground.png |binary icon-themes/breeze/cmd/sc_selectbackground.png |binary icon-themes/breeze/links.txt | 10 - icon-themes/breeze_dark/cmd/lc_currencyfield.png |binary icon-themes/breeze_dark/cmd/lc_renameobject.png|binary icon-themes/breeze_dark/cmd/lc_renamepage.png |binary icon-themes/breeze_dark/cmd/lc_renameslide.png |binary icon-themes/breeze_dark/cmd/lc_renametable.png |binary icon-themes/breeze_dark/cmd/lc_savebackground.png |binary icon-themes/breeze_dark/cmd/lc_selectbackground.png|binary icon-themes/breeze_dark/cmd/sc_currencyfield.png |binary icon-themes/breeze_dark/cmd/sc_displaymasterbackground.png |binary icon-themes/breeze_dark/cmd/sc_insertgraphic.png |binary icon-themes/breeze_dark/cmd/sc_renameobject.png|binary icon-themes/breeze_dark/cmd/sc_renamepage.png |binary icon-themes/breeze_dark/cmd/sc_renameslide.png |binary icon-themes/breeze_dark/cmd/sc_renametable.png |binary icon-themes/breeze_dark/cmd/sc_savebackground.png |binary icon-themes/breeze_dark/cmd/sc_selectbackground.png|binary icon-themes/breeze_svg/cmd/lc_currencyfield.svg|6 icon-themes/breeze_svg/cmd/lc_formattedfield.svg |6 icon-themes/breeze_svg/cmd/lc_renameobject.svg | 10 + icon-themes/breeze_svg/cmd/lc_renamepage.svg | 10 + icon-themes/breeze_svg/cmd/lc_renameslide.svg | 10 + icon-themes/breeze_svg/cmd/lc_renametable.svg | 10 + icon-themes/breeze_svg/cmd/lc_savebackground.svg | 10 + icon-themes/breeze_svg/cmd/lc_selectbackground.svg |6 icon-themes/breeze_svg/cmd/sc_currencyfield.svg|6 icon-themes/breeze_svg/cmd/sc_displaymasterbackground.svg |6 icon-themes/breeze_svg/cmd/sc_formattedfield.svg |7 icon-themes/breeze_svg/cmd/sc_insertgraphic.svg| 12 - icon-themes/breeze_svg/cmd/sc_renameobject.svg | 10 + icon-themes/breeze_svg/cmd/sc_renamepage.svg | 10 + icon-themes/breeze_svg/cmd/sc_renameslide.svg | 10 + icon-themes/breeze_svg/cmd/sc_renametable.svg | 10 + icon-themes/breeze_svg/cmd/sc_savebackground.svg | 10 + icon-themes/breeze_svg/cmd/sc_selectbackground.svg |6 icon-themes/colibre/cmd/lc_renameobject.png|binary icon-themes/colibre/cmd/lc_renamepage.png |binary icon-themes/colibre/cmd/sc_renameobject.png|binary icon-themes/colibre/cmd/sc_renamepage.png |binary icon-themes/colibre_svg/cmd/lc_renameobject.svg| 10 + icon-themes/colibre_svg/cmd/lc_renametable.svg | 21 -- icon-themes/colibre_svg/cmd/sc_renameobject.svg| 94 - icon-themes/colibre_svg/cmd/sc_renametable.svg | 23 --- 59 files changed, 159 insertions(+), 154 deletions(-) New commits: commit 6451a499e332d3e05382cefbdf3307af2a8f0129 Author: andreas kainz AuthorDate: Sat Dec 29 14:10:07 2018 +0100 Commit: andreas_kainz CommitDate: Sun Dec 30 02:46:46 2018 +0100 Breeze icon update Change-Id: I979c7d9bbcd8d692c719dd402422077f5efa2652 Reviewed-on: https://gerrit.libreoffice.org/65729 Tested-by: Jenkins Reviewed-by: andreas_kainz diff --git a/icon-themes/breeze/cmd/lc_currencyfield.png b/icon-themes/breeze/cmd/lc_currencyfield.png new file mode 100644 index ..fb316b22f61e Binary files /dev/null and b/icon-themes/breeze/cmd/lc_currencyfield.png differ diff --git a/icon-themes/breeze/cmd/lc_renameobject.png b/icon-themes/breeze/cmd/lc_renameobject.png new file mode 100644 index ..7199468e304f Binary files /dev/null and b/icon-themes/breeze/cmd/lc_renameobject.png differ diff --git
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - oox/source udkapi/com vcl/win
oox/source/ole/axbinaryreader.cxx |2 +- udkapi/com/sun/star/script/ArrayWrapper.idl |2 +- vcl/win/source/gdi/winlayout.cxx|2 +- 3 files changed, 3 insertions(+), 3 deletions(-) New commits: commit b92f9eee148c42c9f261695be22cc307cfd9a1ab Author: Matthias Seidel AuthorDate: Sat Dec 29 23:59:21 2018 + Commit: Matthias Seidel CommitDate: Sat Dec 29 23:59:21 2018 + Fixed typos (boundries -> boundaries) diff --git a/oox/source/ole/axbinaryreader.cxx b/oox/source/ole/axbinaryreader.cxx index 34cae7e71eee..ed8119a1b4d5 100644 --- a/oox/source/ole/axbinaryreader.cxx +++ b/oox/source/ole/axbinaryreader.cxx @@ -231,7 +231,7 @@ bool AxBinaryPropertyReader::StringArrayProperty::readProperty( AxAlignedInputSt if( !lclReadString( rInStrm, aString, rInStrm.readuInt32(), true ) ) return false; mrArray.push_back( aString ); -// every array string is aligned on 4 byte boundries +// every array string is aligned on 4 byte boundaries rInStrm.align( 4 ); } return true; diff --git a/udkapi/com/sun/star/script/ArrayWrapper.idl b/udkapi/com/sun/star/script/ArrayWrapper.idl index 289a40036400..9bb6fe5f245f 100644 --- a/udkapi/com/sun/star/script/ArrayWrapper.idl +++ b/udkapi/com/sun/star/script/ArrayWrapper.idl @@ -33,7 +33,7 @@ module com { module sun { module star { module script { //= /** Allows an UNO sequence that is passed between different language -boundries to indicate it prefers to be represented as a multidimensional +boundaries to indicate it prefers to be represented as a multidimensional array with 0 or 1 based indices. UNO does not natively represent Multi-Dimensional arrays, instead a sequence can have elements that are themselves sequences (an array of arrays ). Some languages ( example diff --git a/vcl/win/source/gdi/winlayout.cxx b/vcl/win/source/gdi/winlayout.cxx index 51db718e72e2..3d3a998681ff 100644 --- a/vcl/win/source/gdi/winlayout.cxx +++ b/vcl/win/source/gdi/winlayout.cxx @@ -1708,7 +1708,7 @@ bool UniscribeLayout::GetItemSubrange( const VisualItem& rVisualItem, && (rVisualItem.mnEndCharPos <= mnEndCharPos ) ) return true; -// get glyph range from char range by looking at cluster boundries +// get glyph range from char range by looking at cluster boundaries // TODO: optimize for case that LTR/RTL correspond to monotonous glyph indexes rMinGlyphPos = rVisualItem.mnEndGlyphPos; int nMaxGlyphPos = 0; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: extensions/Library_scn.mk extensions/source
extensions/Library_scn.mk |1 extensions/source/scanner/scanwin.cxx | 159 +- 2 files changed, 101 insertions(+), 59 deletions(-) New commits: commit 70e1be1b2f40e881b9aeee8f0d39f894dbf67205 Author: Mike Kaganski AuthorDate: Sat Dec 29 23:56:44 2018 +0300 Commit: Mike Kaganski CommitDate: Sun Dec 30 01:43:26 2018 +0100 tdf#114635: Scan operations are modal To ensure that a document frame isn't modified/closed while an asynchronous scan operation is performed, the frame is blocked for the lifetime of the shim process. Change-Id: I7e21c816ca6de8eb0a53498e77eae359985dbf71 Reviewed-on: https://gerrit.libreoffice.org/65727 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/extensions/Library_scn.mk b/extensions/Library_scn.mk index 71051e112624..a95675823495 100644 --- a/extensions/Library_scn.mk +++ b/extensions/Library_scn.mk @@ -33,6 +33,7 @@ $(eval $(call gb_Library_use_libraries,scn,\ sal \ $(if $(filter WNT,$(OS)),salhelper) \ svt \ + $(if $(filter WNT,$(OS)),tk) \ tl \ utl \ vcl \ diff --git a/extensions/source/scanner/scanwin.cxx b/extensions/source/scanner/scanwin.cxx index e6d238fbcaf8..24068e12b1ee 100644 --- a/extensions/source/scanner/scanwin.cxx +++ b/extensions/source/scanner/scanwin.cxx @@ -18,9 +18,12 @@ */ #include +#include +#include #include "twain32shim.hxx" +#include #include #include #include @@ -28,12 +31,15 @@ #include #include #include +#include #include #include #include +#include #include "scanner.hxx" -using namespace ::com::sun::star; +namespace +{ enum TwainState { @@ -53,15 +59,23 @@ using ScopedHANDLE = std::unique_ptr; class Twain { +public: +Twain(); +~Twain(); + +bool SelectSource(ScannerManager& rMgr); +bool PerformTransfer(ScannerManager& rMgr, + const css::uno::Reference& rxListener); + +TwainState GetState() const { return meState; } + +private: friend class ShimListenerThread; class ShimListenerThread : public salhelper::Thread { public: -ShimListenerThread(Twain& rOwner) -: salhelper::Thread("TWAINShimListenerThread") -, mrOwner(rOwner) -{ -} +ShimListenerThread(); +~ShimListenerThread() override; void execute() override; const OUString& getError() { return msErrorReported; } @@ -74,7 +88,7 @@ class Twain bool RequestInitXfer(); private: -Twain& mrOwner; +VclPtr mxTopWindow; // the window that we made modal bool mbDontNotify = false; HWND mhWndShim = nullptr; // shim main window handle OUString msErrorReported; @@ -89,8 +103,8 @@ class Twain void NotifyOwner(WPARAM nEvent); void NotifyXFerOwner(LPARAM nHandle); }; -uno::Reference mxListener; -uno::Reference mxMgr; +css::uno::Reference mxListener; +css::uno::Reference mxMgr; ScannerManager* mpCurMgr = nullptr; TwainState meState = TWAIN_STATE_NONE; rtl::Reference mpThread; @@ -104,17 +118,47 @@ class Twain bool InitializeNewShim(ScannerManager& rMgr); void Reset(); // cleanup thread and manager +}; -public: -Twain(); -~Twain(); +static Twain aTwain; -bool SelectSource(ScannerManager& rMgr); -bool PerformTransfer(ScannerManager& rMgr, - const uno::Reference& rxListener); +css::uno::Reference ImplGetActiveFrame() +{ +try +{ +// query desktop instance +css::uno::Reference xDesktop += css::frame::Desktop::create(comphelper::getProcessComponentContext()); +if (css::uno::Reference xActiveFrame = xDesktop->getActiveFrame()) +return xActiveFrame; +} +catch (const css::uno::Exception&) +{ +} +SAL_WARN("extensions.scanner", "ImplGetActiveFrame: Could not determine active frame!"); +return css::uno::Reference(); +} -TwainState GetState() const { return meState; } -}; +Twain::ShimListenerThread::ShimListenerThread() +: salhelper::Thread("TWAINShimListenerThread") +{ +if (css::uno::Reference xTopFrame = ImplGetActiveFrame()) +{ +mxTopWindow = VCLUnoHelper::GetWindow(xTopFrame->getComponentWindow()); +if (mxTopWindow) +{ +mxTopWindow->IncModalCount(); // the operation is modal to the frame +} +} +} + +Twain::ShimListenerThread::~ShimListenerThread() +{ +if (mxTopWindow) +{ +mxTopWindow->DecModalCount(); // unblock the frame +} +} bool Twain::ShimListenerThread::WaitInitialization() { @@ -128,20 +172,6 @@ bool Twain::ShimListenerThread::WaitRequestResult() return mbRequestResult; } -void Twain::ShimListenerThread::RequestDestroy() { SendShimRequest(TWAIN_REQUEST_QUIT); } - -bool Twain::ShimListenerThread::RequestSelectSource() -{
[Libreoffice-bugs] [Bug 122375] the version information embedded in LibreOffice for macOS are broken
https://bugs.documentfoundation.org/show_bug.cgi?id=122375 --- Comment #2 from dink --- Created attachment 147893 --> https://bugs.documentfoundation.org/attachment.cgi?id=147893=edit image of the version numbers of recent releases image of the version numbers of recent releases -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122375] the version information embedded in LibreOffice for macOS are broken
https://bugs.documentfoundation.org/show_bug.cgi?id=122375 --- Comment #1 from dink --- Created attachment 147892 --> https://bugs.documentfoundation.org/attachment.cgi?id=147892=edit version numbers of libre office version numbers of libre office -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122375] New: the version information embedded in LibreOffice for macOS are broken
https://bugs.documentfoundation.org/show_bug.cgi?id=122375 Bug ID: 122375 Summary: the version information embedded in LibreOffice for macOS are broken Product: LibreOffice Version: unspecified Hardware: All OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jul...@corecode.io Description: the version information embedded into LibreOffice on macOS is broken. have a look at this image of a spreadsheet that contains the meta information of the last two dozen releases: https://ibb.co/PZMC7gM its immediately obvious that only the information in 'CFBundleGetInfoString' is correct. which is funny, since this key has been deprecated for nearly 10 years, should be removed right now, and is certainly not the right place to have version information. the CFBundleShortVersionString and CFBundleVersion strings are broken in a funny inconsistent way. 1.) for dot-zero (x.y.0.p) releases, they are always of a 3-number format, but the last number is ALWAYS wrong: consider the 6.1.0.3 release which is the 3rd and last build of the 6.1.0 releases. the CFBundleShortVersionString and CFBundleVersion keys should be 6.1.0.3. but it has been set to 6.1.3 which is obviously wrong. the 6.1.3 release didn't happen until 3 months later. not sure what the rationale is here. 2.) for non-dot-zero (x.y.z!=0.p) releases, they are always of a 3-number format, but the last number always contains 2 zeroes instead of the additional point that should seperate the patch level. consider the current 6.1.4.2 release which is the second build of the 6.1.4 releases. the CFBundleShortVersionString and CFBundleVersion keys should be 6.1.4.2 (or possibly 6.1.4 if you want to ignore the patch level in the short version string). but it has been set to 6.1.4002 which doesn't make sense to me. even if it did make sense, it should be applied consistently, which is the single most important thing about any version number format. its not as important how much sense it makes, but whether you apply it consistently. but you consistently alternate between two different schemes, that in my opinion are broken in different ways. in summary, please remove the deprecated CFBundleGetInfoString key and add the sane version numbers stores there to the CFBundleShortVersionString key and/or the CFBundleVersion key. thanks Steps to Reproduce: download any and all LibreOffice releases and have a look at the version numbers Actual Results: version numbers are not what you expect Expected Results: sane version numbers Reproducible: Always User Profile Reset: No Additional Info: i'll try to attach the full CSV with all version numbers if its possible -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121065] [NEWHELP] Update icons/images of Math Help page on Unary/Binary operators
https://bugs.documentfoundation.org/show_bug.cgi?id=121065 --- Comment #13 from Mark --- Ok, I choose Liberation Serif, where letters are italic and + - are normal and I will start from beginning. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114919] FILESAVE invalid ODF 1.2 strict when removing calcext:value-type
https://bugs.documentfoundation.org/show_bug.cgi?id=114919 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #4 from Julien Nabet --- Created attachment 147891 --> https://bugs.documentfoundation.org/attachment.cgi?id=147891=edit Valgrind trace On pc Debian x86-64 with master sources updated today, I got a crash. Since I couldn't retrieve a bt because gdb hangs (I don't know why), I could retrieve Valgrind trace. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - icon-themes/breeze_dark
icon-themes/breeze_dark/cmd/lc_closedoc.png|binary icon-themes/breeze_dark/cmd/lc_closemasterview.png |binary icon-themes/breeze_dark/cmd/lc_closepreview.png|binary icon-themes/breeze_dark/cmd/lc_deletemasterpage.png|binary icon-themes/breeze_dark/cmd/lc_displaymasterbackground.png |binary icon-themes/breeze_dark/cmd/lc_displaymasterobjects.png|binary icon-themes/breeze_dark/cmd/lc_insertmasterpage.png|binary icon-themes/breeze_dark/cmd/lc_masterlayouts.png |binary icon-themes/breeze_dark/cmd/lc_masterpage.png |binary icon-themes/breeze_dark/cmd/lc_notesmasterpage.png |binary icon-themes/breeze_dark/cmd/lc_slidemasterpage.png |binary icon-themes/breeze_dark/cmd/sc_closedoc.png|binary icon-themes/breeze_dark/cmd/sc_closemasterview.png |binary icon-themes/breeze_dark/cmd/sc_closepreview.png|binary icon-themes/breeze_dark/cmd/sc_deletemasterpage.png|binary icon-themes/breeze_dark/cmd/sc_displaymasterbackground.png |binary icon-themes/breeze_dark/cmd/sc_displaymasterobjects.png|binary icon-themes/breeze_dark/cmd/sc_insertmasterpage.png|binary icon-themes/breeze_dark/cmd/sc_masterlayouts.png |binary icon-themes/breeze_dark/cmd/sc_notesmasterpage.png |binary icon-themes/breeze_dark/cmd/sc_slidemasterpage.png |binary 21 files changed New commits: commit a86eb14c9d334fb17c1abbb7391a9b2872d3a8df Author: andreas kainz AuthorDate: Sat Dec 29 12:31:11 2018 +0100 Commit: andreas_kainz CommitDate: Sun Dec 30 00:09:15 2018 +0100 Breeze dark: master and close quite icon update Change-Id: I33f05f273b07a209ac89f6c671e412f30d0ca6f7 Reviewed-on: https://gerrit.libreoffice.org/65711 Tested-by: Jenkins Reviewed-by: andreas_kainz (cherry picked from commit 96c9357edc67ff81358573194bbab172cbb33c38) Reviewed-on: https://gerrit.libreoffice.org/65724 diff --git a/icon-themes/breeze_dark/cmd/lc_closedoc.png b/icon-themes/breeze_dark/cmd/lc_closedoc.png index fc135bc2146a..1fa0b52a552e 100644 Binary files a/icon-themes/breeze_dark/cmd/lc_closedoc.png and b/icon-themes/breeze_dark/cmd/lc_closedoc.png differ diff --git a/icon-themes/breeze_dark/cmd/lc_closemasterview.png b/icon-themes/breeze_dark/cmd/lc_closemasterview.png new file mode 100644 index ..8d070138ca5a Binary files /dev/null and b/icon-themes/breeze_dark/cmd/lc_closemasterview.png differ diff --git a/icon-themes/breeze_dark/cmd/lc_closepreview.png b/icon-themes/breeze_dark/cmd/lc_closepreview.png new file mode 100644 index ..397727b63e66 Binary files /dev/null and b/icon-themes/breeze_dark/cmd/lc_closepreview.png differ diff --git a/icon-themes/breeze_dark/cmd/lc_deletemasterpage.png b/icon-themes/breeze_dark/cmd/lc_deletemasterpage.png index fa3a4c0478c7..9769db909c05 100644 Binary files a/icon-themes/breeze_dark/cmd/lc_deletemasterpage.png and b/icon-themes/breeze_dark/cmd/lc_deletemasterpage.png differ diff --git a/icon-themes/breeze_dark/cmd/lc_displaymasterbackground.png b/icon-themes/breeze_dark/cmd/lc_displaymasterbackground.png new file mode 100644 index ..129866529dfc Binary files /dev/null and b/icon-themes/breeze_dark/cmd/lc_displaymasterbackground.png differ diff --git a/icon-themes/breeze_dark/cmd/lc_displaymasterobjects.png b/icon-themes/breeze_dark/cmd/lc_displaymasterobjects.png new file mode 100644 index ..158aa3c873bb Binary files /dev/null and b/icon-themes/breeze_dark/cmd/lc_displaymasterobjects.png differ diff --git a/icon-themes/breeze_dark/cmd/lc_insertmasterpage.png b/icon-themes/breeze_dark/cmd/lc_insertmasterpage.png index d75761861f23..5354e2c86876 100644 Binary files a/icon-themes/breeze_dark/cmd/lc_insertmasterpage.png and b/icon-themes/breeze_dark/cmd/lc_insertmasterpage.png differ diff --git a/icon-themes/breeze_dark/cmd/lc_masterlayouts.png b/icon-themes/breeze_dark/cmd/lc_masterlayouts.png new file mode 100644 index ..93e70b61d43a Binary files /dev/null and b/icon-themes/breeze_dark/cmd/lc_masterlayouts.png differ diff --git a/icon-themes/breeze_dark/cmd/lc_masterpage.png b/icon-themes/breeze_dark/cmd/lc_masterpage.png new file mode 100644 index ..4ee8d26fac69 Binary files /dev/null and b/icon-themes/breeze_dark/cmd/lc_masterpage.png differ diff --git a/icon-themes/breeze_dark/cmd/lc_notesmasterpage.png b/icon-themes/breeze_dark/cmd/lc_notesmasterpage.png index 575f0a0bf0e2..6dfa303199b4 100644 Binary files a/icon-themes/breeze_dark/cmd/lc_notesmasterpage.png and b/icon-themes/breeze_dark/cmd/lc_notesmasterpage.png differ diff --git a/icon-themes/breeze_dark/cmd/lc_slidemasterpage.png b/icon-themes/breeze_dark/cmd/lc_slidemasterpage.png index ad7de95a95d2..765a1499833f 100644 Binary files a/icon-themes/breeze_dark/cmd/lc_slidemasterpage.png and b/icon-themes/breeze_dark/cmd/lc_slidemasterpage.png differ diff
[Libreoffice-bugs] [Bug 122355] HELP button in Format Cells no longer opens help on Format Cells (it opens top of Help)
https://bugs.documentfoundation.org/show_bug.cgi?id=122355 raal changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122355] HELP button in Format Cells no longer opens help on Format Cells (it opens top of Help)
https://bugs.documentfoundation.org/show_bug.cgi?id=122355 raal changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||r...@post.cz --- Comment #1 from raal --- Confirm. Url https://help.libreoffice.org/6.3/en-US/text/scalc/main.html?System=UNIX=CALC -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122344] FILEOPEN DOC: Paragraph auto spacing is imported as 0, 49 cm
https://bugs.documentfoundation.org/show_bug.cgi?id=122344 raal changed: What|Removed |Added Status|UNCONFIRMED |NEW Keywords||filter:doc CC||r...@post.cz Ever confirmed|0 |1 --- Comment #2 from raal --- Confirm. Version: 6.3.0.0.alpha0+ Build ID: 993913469e74e9db9743004bbe36aa412411671c CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - icon-themes/breeze icon-themes/breeze_svg icon-themes/colibre icon-themes/colibre_svg
icon-themes/breeze/cmd/lc_closedoc.png |binary icon-themes/breeze/cmd/lc_closemasterview.png |binary icon-themes/breeze/cmd/lc_closepreview.png |binary icon-themes/breeze/cmd/lc_deletemasterpage.png |binary icon-themes/breeze/cmd/lc_displaymasterbackground.png |binary icon-themes/breeze/cmd/lc_displaymasterobjects.png |binary icon-themes/breeze/cmd/lc_insertmasterpage.png |binary icon-themes/breeze/cmd/lc_masterlayouts.png|binary icon-themes/breeze/cmd/lc_masterpage.png |binary icon-themes/breeze/cmd/lc_notesmasterpage.png |binary icon-themes/breeze/cmd/lc_slidemasterpage.png |binary icon-themes/breeze/cmd/sc_closedoc.png |binary icon-themes/breeze/cmd/sc_closemasterview.png |binary icon-themes/breeze/cmd/sc_closepreview.png |binary icon-themes/breeze/cmd/sc_deletemasterpage.png |binary icon-themes/breeze/cmd/sc_displaymasterbackground.png |binary icon-themes/breeze/cmd/sc_displaymasterobjects.png |binary icon-themes/breeze/cmd/sc_insertmasterpage.png |binary icon-themes/breeze/cmd/sc_masterlayouts.png|binary icon-themes/breeze/cmd/sc_notesmasterpage.png |binary icon-themes/breeze/cmd/sc_slidemasterpage.png |binary icon-themes/breeze/links.txt |8 - icon-themes/breeze_svg/cmd/lc_closedoc.svg | 12 -- icon-themes/breeze_svg/cmd/lc_closemasterview.svg |5 + icon-themes/breeze_svg/cmd/lc_closepreview.svg | 10 ++ icon-themes/breeze_svg/cmd/lc_displaymasterbackground.svg | 10 ++ icon-themes/breeze_svg/cmd/lc_displaymasterobjects.svg | 10 ++ icon-themes/breeze_svg/cmd/lc_masterlayouts.svg|6 + icon-themes/breeze_svg/cmd/lc_masterpage.svg |6 + icon-themes/breeze_svg/cmd/sc_closedoc.svg | 12 -- icon-themes/breeze_svg/cmd/sc_closemasterview.svg |5 + icon-themes/breeze_svg/cmd/sc_closepreview.svg | 10 ++ icon-themes/breeze_svg/cmd/sc_displaymasterbackground.svg | 10 ++ icon-themes/breeze_svg/cmd/sc_displaymasterobjects.svg | 10 ++ icon-themes/colibre/cmd/lc_closedoc.png|binary icon-themes/colibre/cmd/lc_closemasterview.png |binary icon-themes/colibre/cmd/lc_closepreview.png|binary icon-themes/colibre/cmd/lc_deletemasterpage.png|binary icon-themes/colibre/cmd/lc_displaymasterbackground.png |binary icon-themes/colibre/cmd/lc_displaymasterobjects.png|binary icon-themes/colibre/cmd/lc_insertmasterpage.png|binary icon-themes/colibre/cmd/lc_masterlayouts.png |binary icon-themes/colibre/cmd/lc_masterpage.png |binary icon-themes/colibre/cmd/lc_notesmasterpage.png |binary icon-themes/colibre/cmd/lc_quit.png|binary icon-themes/colibre/cmd/lc_slidemasterpage.png |binary icon-themes/colibre/cmd/sc_closedoc.png|binary icon-themes/colibre/cmd/sc_closemasterview.png |binary icon-themes/colibre/cmd/sc_closepreview.png|binary icon-themes/colibre/cmd/sc_deletemasterpage.png|binary icon-themes/colibre/cmd/sc_displaymasterbackground.png |binary icon-themes/colibre/cmd/sc_displaymasterobjects.png|binary icon-themes/colibre/cmd/sc_insertmasterpage.png|binary icon-themes/colibre/cmd/sc_masterlayouts.png |binary icon-themes/colibre/cmd/sc_notesmasterpage.png |binary icon-themes/colibre/cmd/sc_quit.png|binary icon-themes/colibre/cmd/sc_slidemasterpage.png |binary icon-themes/colibre/links.txt |8 - icon-themes/colibre_svg/cmd/lc_closedoc.svg| 23 + icon-themes/colibre_svg/cmd/lc_closemasterview.svg | 22 + icon-themes/colibre_svg/cmd/lc_closepreview.svg| 10 ++ icon-themes/colibre_svg/cmd/lc_deletemasterpage.svg| 19 icon-themes/colibre_svg/cmd/lc_displaymasterbackground.svg | 16 +-- icon-themes/colibre_svg/cmd/lc_displaymasterobjects.svg| 29 +++--- icon-themes/colibre_svg/cmd/lc_insertmasterpage.svg| 19 icon-themes/colibre_svg/cmd/lc_masterlayouts.svg | 19 icon-themes/colibre_svg/cmd/lc_masterpage.svg | 14 +++ icon-themes/colibre_svg/cmd/lc_notesmasterpage.svg | 23 + icon-themes/colibre_svg/cmd/lc_quit.svg| 11 ++ icon-themes/colibre_svg/cmd/lc_slidemasterpage.svg | 25 + icon-themes/colibre_svg/cmd/sc_closedoc.svg| 19 icon-themes/colibre_svg/cmd/sc_closemasterview.svg | 24 +
[Libreoffice-bugs] [Bug 121065] [NEWHELP] Update icons/images of Math Help page on Unary/Binary operators
https://bugs.documentfoundation.org/show_bug.cgi?id=121065 --- Comment #12 from Olivier Hallot --- Hi Mark Yes please lets settle that. The slant effect can be from individual bias. Attached is a sample with 3 lines Font in Line 1 is Liberation Serif, where letters are italic and + - are normal Font in Line 2 is Stix, letters are STIX Two Text and +- are in STIX Two Math Font in Line 3 is OpenSymbol, and there is no italic variant in this font. Pick your choice !!! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121065] [NEWHELP] Update icons/images of Math Help page on Unary/Binary operators
https://bugs.documentfoundation.org/show_bug.cgi?id=121065 --- Comment #11 from Olivier Hallot --- Created attachment 147890 --> https://bugs.documentfoundation.org/attachment.cgi?id=147890=edit comparison of 3 options for fonts -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: download.lst external/libcdr solenv/flatpak-manifest.in
download.lst|4 ++-- external/libcdr/UnpackedTarball_libcdr.mk |4 external/libcdr/libcdr-visibility-win.patch | 11 +++ solenv/flatpak-manifest.in |6 +++--- 4 files changed, 20 insertions(+), 5 deletions(-) New commits: commit a8965ebc1b29ba578fc3e9cd6915e85e807d9fd6 Author: David Tardon AuthorDate: Sat Dec 29 14:53:07 2018 +0100 Commit: David Tardon CommitDate: Sat Dec 29 22:01:48 2018 +0100 upload libcdr 0.1.5 Change-Id: I01454cc35baf96743bd19e64dd3a7269c58621bf Reviewed-on: https://gerrit.libreoffice.org/65715 Tested-by: Jenkins Reviewed-by: David Tardon diff --git a/download.lst b/download.lst index 792c808d8a2b..0745b7058f3c 100644 --- a/download.lst +++ b/download.lst @@ -17,8 +17,8 @@ export BZIP2_TARBALL := 00b516f4704d4a7cb50a1d97e6e8e15b-bzip2-1.0.6.tar.gz export CAIRO_SHA256SUM := 7623081b94548a47ee6839a7312af34e9322997806948b6eec421a8c6d0594c9 export CAIRO_VERSION_MICRO := 12 export CAIRO_TARBALL := cairo-1.15.$(CAIRO_VERSION_MICRO).tar.xz -export CDR_SHA256SUM := e7a7e8b00a3df5798110024d7061fe9d1c3330277d2e4fa9213294f966a4a66d -export CDR_TARBALL := libcdr-0.1.4.tar.xz +export CDR_SHA256SUM := 6ace5c499a8be34ad871e825442ce388614ae2d8675c4381756a7319429e3a48 +export CDR_TARBALL := libcdr-0.1.5.tar.xz export CLUCENE_SHA256SUM := ddfdc433dd8ad31b5c5819cc4404a8d2127472a3b720d3e744e8c51d79732eab export CLUCENE_TARBALL := 48d647fbd8ef8889e5a7f422c1bfda94-clucene-core-2.3.3.4.tar.gz export LIBCMIS_SHA256SUM := d7b18d9602190e10d437f8a964a32e983afd57e2db316a07d87477a79f5000a2 diff --git a/external/libcdr/UnpackedTarball_libcdr.mk b/external/libcdr/UnpackedTarball_libcdr.mk index 4ca54804e6aa..23874f7d01b5 100644 --- a/external/libcdr/UnpackedTarball_libcdr.mk +++ b/external/libcdr/UnpackedTarball_libcdr.mk @@ -15,6 +15,10 @@ $(eval $(call gb_UnpackedTarball_set_patchlevel,libcdr,0)) $(eval $(call gb_UnpackedTarball_update_autoconf_configs,libcdr)) +$(eval $(call gb_UnpackedTarball_add_patches,libcdr, \ +external/libcdr/libcdr-visibility-win.patch \ +)) + ifeq ($(COM_IS_CLANG),TRUE) ifneq ($(filter -fsanitize=%,$(CC)),) $(eval $(call gb_UnpackedTarball_add_patches,libcdr, \ diff --git a/external/libcdr/libcdr-visibility-win.patch b/external/libcdr/libcdr-visibility-win.patch new file mode 100644 index ..7700cfd32f2f --- /dev/null +++ b/external/libcdr/libcdr-visibility-win.patch @@ -0,0 +1,11 @@ +--- configure.dt 2018-12-29 16:23:02.355271146 +0100 configure 2018-12-29 16:23:21.644060142 +0100 +@@ -19116,6 +19116,8 @@ + + + if test $platform_win32 = yes; then : ++ HAVE_VISIBILITY_TRUE='#' ++ HAVE_VISIBILITY_FALSE= + + else + diff --git a/solenv/flatpak-manifest.in b/solenv/flatpak-manifest.in index 3f8323a66935..7da44be8953d 100644 --- a/solenv/flatpak-manifest.in +++ b/solenv/flatpak-manifest.in @@ -205,10 +205,10 @@ "dest-filename": "external/tarballs/libabw-0.1.2.tar.xz" }, { -"url": "https://dev-www.libreoffice.org/src/libcdr-0.1.4.tar.xz;, -"sha256": "e7a7e8b00a3df5798110024d7061fe9d1c3330277d2e4fa9213294f966a4a66d", +"url": "https://dev-www.libreoffice.org/src/libcdr-0.1.5.tar.xz;, +"sha256": "6ace5c499a8be34ad871e825442ce388614ae2d8675c4381756a7319429e3a48", "type": "file", -"dest-filename": "external/tarballs/libcdr-0.1.4.tar.xz" +"dest-filename": "external/tarballs/libcdr-0.1.5.tar.xz" }, { "url": "https://dev-www.libreoffice.org/src/libcmis-0.5.2.tar.xz;, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Mark-R license statement
All of my past & future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 122367] Find text: Counter-intuitive Find Next/Previous arrow buttons
https://bugs.documentfoundation.org/show_bug.cgi?id=122367 --- Comment #3 from Tom --- Created attachment 147889 --> https://bugs.documentfoundation.org/attachment.cgi?id=147889=edit Find Screenshot I have manually installed directly downloaded from https://www.libreoffice.org: LibreOffice_6.1.4_Linux_x86-64_deb.tar.gz LibreOffice_6.1.4_Linux_x86-64_deb_helppack_en-US.tar.gz on Linux Mint Mate 18.3. For illustration I have also added a screenshot showing the issue. Regards Tom -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121065] [NEWHELP] Update icons/images of Math Help page on Unary/Binary operators
https://bugs.documentfoundation.org/show_bug.cgi?id=121065 --- Comment #10 from Mark --- Created attachment 147888 --> https://bugs.documentfoundation.org/attachment.cgi?id=147888=edit Screen Shot a + b I do not see the 'slant effect as if the letters are not aligned to the base line'. see attached image. But the big question is do I continue or fix something? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122372] Artefact/incorrect background with LibreOffice icons on Windows with HiDPI configurations
https://bugs.documentfoundation.org/show_bug.cgi?id=122372 --- Comment #4 from Robert Berg --- Is there a way to make the LibreOffice installer for version 6.2.x clear the icon cache? Clearing the icon cache on users not affected seems to cause no harm, and seems some users with the issue don't know to clear the cache. Two other OSS programs I use (Audacity and Stellarium) have options in their installers to clear config and caches when updating versions. Maybe their devs would be willing to work with LibreOffice devs to add options the installer to clear the cache at updates? I for one would like an easy way to clear the cache at each update just to keep the crud down. Thank you. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99826] Please update Galician (gl) hunspell dictionariy
https://bugs.documentfoundation.org/show_bug.cgi?id=99826 Adolfo Jayme changed: What|Removed |Added Whiteboard|target:6.3.0|target:6.3.0 target:6.2.0.2 ||target:6.1.5 --- Comment #10 from Adolfo Jayme --- Backported for: 6.2.0 RC2: https://git.libreoffice.org/dictionaries/+/3be2dd00ee3c13816bf1433249751737dbe4a371 6.1.5: https://git.libreoffice.org/dictionaries/+/aa3f26cd95e3acd29c4a9ca68052004ab35c6f88 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'libreoffice-6-2' - loleaflet/src
loleaflet/src/control/Toolbar.js | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) New commits: commit 5cf3b662ad9627b05025c7068481f8060e6d1783 Author: Andras Timar AuthorDate: Fri Dec 28 16:15:15 2018 +0100 Commit: Adolfo Jayme Barrientos CommitDate: Sat Dec 29 21:23:42 2018 +0100 Better width of About and Help popup windows on narrow and wide screens Change-Id: I61e639a8a70282dc9e18fa1a4107f0572370947f Reviewed-on: https://gerrit.libreoffice.org/65687 Reviewed-by: Adolfo Jayme Barrientos Tested-by: Adolfo Jayme Barrientos diff --git a/loleaflet/src/control/Toolbar.js b/loleaflet/src/control/Toolbar.js index debc090d6..ba3cbb0ca 100644 --- a/loleaflet/src/control/Toolbar.js +++ b/loleaflet/src/control/Toolbar.js @@ -180,7 +180,17 @@ L.Map.include({ }, showLOKeyboardHelp: function() { - var w = window.innerWidth / 2; + var w; + var iw = window.innerWidth; + if (iw < 768) { + w = iw - 30; + } + else if (iw > 1920) { + w = 960; + } + else { + w = iw / 5 + 590; + } var map = this; $.get('loleaflet-help.html', function(data) { vex.open({ @@ -249,7 +259,17 @@ L.Map.include({ content.find('#product-name').text(productName); var productString = _('This version of %productName is powered by'); content.find('#product-string').text(productString.replace('%productName', productName)); - var w = window.innerWidth / 2; + var w; + var iw = window.innerWidth; + if (iw < 768) { + w = iw - 30; + } + else if (iw > 1920) { + w = 960; + } + else { + w = iw / 5 + 590; + } var map = this; var handler = function(event) { if (event.keyCode === 68) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 50278] Provide separate dock icons for each component on Mac OS X instead of or in addition to the global launcher
https://bugs.documentfoundation.org/show_bug.cgi?id=50278 --- Comment #11 from James --- I also won't use LibreOffice on macOS because the individual components are not packaged separately. Having to open a Works-style launcher to chose the app I need somehow seems to cheapen the perception of the suite. I would ditch my Office 365 subscription if this was changed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] dictionaries.git: Branch 'libreoffice-6-2' - gl/Changelog.txt gl/description.xml gl/gl_ES.aff gl/gl_ES.dic gl/package-description.txt gl/README
gl/Changelog.txt |4 gl/README |4 gl/description.xml |4 gl/gl_ES.aff |41317 -- gl/gl_ES.dic |284530 - gl/package-description.txt |4 6 files changed, 258198 insertions(+), 67665 deletions(-) New commits: commit 3be2dd00ee3c13816bf1433249751737dbe4a371 Author: Adolfo Jayme Barrientos AuthorDate: Fri Nov 30 19:59:11 2018 -0600 Commit: Andras Timar CommitDate: Sat Dec 29 20:43:36 2018 +0100 tdf#99826 Update Galician dictionaries to version 18.07 Change-Id: If3a2f77855159c1a2a50880b0eb37a824c926f6c Reviewed-on: https://gerrit.libreoffice.org/64370 Reviewed-by: Aron Budea Tested-by: Aron Budea (cherry picked from commit fea4ea689cd27d4c0bd981fdc01225d3bfacfc2d) Reviewed-on: https://gerrit.libreoffice.org/65654 Reviewed-by: Andras Timar Tested-by: Andras Timar diff --git a/gl/Changelog.txt b/gl/Changelog.txt index 1d3c16e..38a86d7 100644 --- a/gl/Changelog.txt +++ b/gl/Changelog.txt @@ -1,3 +1 @@ -Versión 12.02: -- Engadido do ficheiro de afixación de Miguel Solla que substitúe ao de Mancomún. - +Véxase/See https://github.com/meixome/hunspell-gl/blob/master/CHANGELOG diff --git a/gl/README b/gl/README index 78e00bc..7bd3779 100644 --- a/gl/README +++ b/gl/README @@ -4,8 +4,8 @@ and the coordination of Antón Méixome for Proxecto Trasno Corrector ortográfico hunspell-gl para galego (Volga estrito) e coordinado por Antón Méixome para Proxecto Trasno (www.trasno.net) -Version 12.10 "Xoán Manuel Pintos" -(http://gl.wikipedia.org/wiki/Xoán_Manuel_Pintos_Villar) +Version 18.07 "Francisco Mirás" +(https://gl.wikipedia.org/wiki/Francisco_Mirás) Nota. diff --git a/gl/description.xml b/gl/description.xml index 4d8e88e..53e73a8 100644 --- a/gl/description.xml +++ b/gl/description.xml @@ -1,7 +1,7 @@ http://openoffice.org/extensions/description/2006; xmlns:d="http://openoffice.org/extensions/description/2006; xmlns:xlink="http://www.w3.org/1999/xlink;> - + @@ -19,7 +19,7 @@ -https://github.com/meixome/hunspell-gl-volga/issues; lang="en">Hunspell-gl-volga +https://github.com/meixome/hunspell-gl/issues; lang="en">Hunspell-gl diff --git a/gl/gl_ES.aff b/gl/gl_ES.aff index 1760198..51f0261 100644 --- a/gl/gl_ES.aff +++ b/gl/gl_ES.aff @@ -1,72 +1,20 @@ -# Proxecto Trasno 18 de outubro de 2012 -# -# Este ficheiro contén os parámetros de configuración -# do verificador ortográfico MySpell/Hunspell, as regras -# para as suxestións de substitución e as regras de afixación -# para o dicionario do verificador en lingua galega. -# Miguel Solla (brado...@gmail.com), 2010. -# -# O ficheiro co dicionario creouse a partir do -# Vocabulario ortográfico da lingua galega (VOLGa) -# Santamarina Fernández, Antón e González González, Manuel (coord.) -# Real Academia Galega / Instituto da Lingua Galega, 2004. -# http://www.realacademiagalega.org/volga/ -# -# As regras de afixación tratan de acadar un comportamento -# consonte as Normas ortográficas e morfolóxicas do idioma -# galego, Real Academia Galega / Instituto da Lingua Galega, 2003. -# http://www.realacademiagalega.org/PlainRAG/catalog/publications/files/normas_galego05.pdf -# -# Para a elaboración das regras de afixación reaproveitáronse -# algunhas das regras da versión que creou en 2006-2007 -# Mar Castro Pereiro para Mancomún (http://www.mancomun.org/) -# baixo os termos da GNU General Public License (GPL) -# -# [SEN REVISAR: ] Os topónimos, os antopónimos, as abreviaturas e -# as siglas que figuran ao final do ficheiro de dicionario tamén -# proceden desta versión anterior. -# -# A descrición do comportamento morfosintáctivo verbal -# pódese atopar no núm. 1 da revista Linguamática (ISSN: 1647-0818) -# http://linguamatica.com/index.php/linguamatica/article/view/13 - - - -# Codificación de caracteres: SET UTF-8 - -# Caracteres que se buscarán para facer suxestións de substitucións -# cando unicamente varíe un carácter na cadea TRY -aáàâãäeéêèiïìíîoóòôõöuùúûübcçdfghjklmnñpqrstvxyzABCDEFGHIJKLMNÑOPQRSTUVWXYZÁÉÍÓÚÀÈÌÒÙÏÜÇ· - -# Indícase o tipo de nomenclatura das regras de afixación FLAG num - -# O seguinte parámetro («666») utilizarase para indicar que a raíz -# do dicionario que se utiliza precisa necesariamente dunha regra de afixación NEEDAFFIX 666 - -# Cadeas de teclas próximas no teclado que poden ser -# facilmente confundidas á hora de teclear unha palabra. En cada serie de -# teclas ─separadas por unha barra vertical, «|»─ terase en conta as teclas -# á esquerda e dereita de cada unha. KEY qwertyuiop|asdfghjklñ|zxcvbnm|qaw|saz|wse|dsx|sz|edr|fdc|dx|rft|gfv|fc|tgz|hgb|gv|zhu|jhn|hb|uji|kjm|jn|iko|lkmñ|plñç - -# Impide que se ofrezan suxestións de substitución con elementos da cadea separados por un espazo -# (impide tamén as regras de substitución de n-gramas) NOSPLITSUGS - -# Establece o
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - dictionaries
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c4221c21e90ee1f1d949a9c6f9616bdbaaf1c0e9 Author: Adolfo Jayme Barrientos AuthorDate: Fri Nov 30 19:59:11 2018 -0600 Commit: Gerrit Code Review CommitDate: Sat Dec 29 20:43:36 2018 +0100 Update git submodules * Update dictionaries from branch 'libreoffice-6-2' - tdf#99826 Update Galician dictionaries to version 18.07 Change-Id: If3a2f77855159c1a2a50880b0eb37a824c926f6c Reviewed-on: https://gerrit.libreoffice.org/64370 Reviewed-by: Aron Budea Tested-by: Aron Budea (cherry picked from commit fea4ea689cd27d4c0bd981fdc01225d3bfacfc2d) Reviewed-on: https://gerrit.libreoffice.org/65654 Reviewed-by: Andras Timar Tested-by: Andras Timar diff --git a/dictionaries b/dictionaries index 9e4ee1ee9c42..3be2dd00ee3c 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit 9e4ee1ee9c422f811557d7570bdc26e42a162987 +Subproject commit 3be2dd00ee3c13816bf1433249751737dbe4a371 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: Branch 'libreoffice-6-1' - gl/Changelog.txt gl/description.xml gl/gl_ES.aff gl/gl_ES.dic gl/package-description.txt gl/README
gl/Changelog.txt |4 gl/README |4 gl/description.xml |4 gl/gl_ES.aff |41317 -- gl/gl_ES.dic |284530 - gl/package-description.txt |4 6 files changed, 258198 insertions(+), 67665 deletions(-) New commits: commit aa3f26cd95e3acd29c4a9ca68052004ab35c6f88 Author: Adolfo Jayme Barrientos AuthorDate: Fri Nov 30 19:59:11 2018 -0600 Commit: Andras Timar CommitDate: Sat Dec 29 20:42:48 2018 +0100 tdf#99826 Update Galician dictionaries to version 18.07 Change-Id: If3a2f77855159c1a2a50880b0eb37a824c926f6c Reviewed-on: https://gerrit.libreoffice.org/64370 Reviewed-by: Aron Budea Tested-by: Aron Budea (cherry picked from commit fea4ea689cd27d4c0bd981fdc01225d3bfacfc2d) Reviewed-on: https://gerrit.libreoffice.org/65655 Reviewed-by: Andras Timar Tested-by: Andras Timar diff --git a/gl/Changelog.txt b/gl/Changelog.txt index 1d3c16e..38a86d7 100644 --- a/gl/Changelog.txt +++ b/gl/Changelog.txt @@ -1,3 +1 @@ -Versión 12.02: -- Engadido do ficheiro de afixación de Miguel Solla que substitúe ao de Mancomún. - +Véxase/See https://github.com/meixome/hunspell-gl/blob/master/CHANGELOG diff --git a/gl/README b/gl/README index 78e00bc..7bd3779 100644 --- a/gl/README +++ b/gl/README @@ -4,8 +4,8 @@ and the coordination of Antón Méixome for Proxecto Trasno Corrector ortográfico hunspell-gl para galego (Volga estrito) e coordinado por Antón Méixome para Proxecto Trasno (www.trasno.net) -Version 12.10 "Xoán Manuel Pintos" -(http://gl.wikipedia.org/wiki/Xoán_Manuel_Pintos_Villar) +Version 18.07 "Francisco Mirás" +(https://gl.wikipedia.org/wiki/Francisco_Mirás) Nota. diff --git a/gl/description.xml b/gl/description.xml index 4d8e88e..53e73a8 100644 --- a/gl/description.xml +++ b/gl/description.xml @@ -1,7 +1,7 @@ http://openoffice.org/extensions/description/2006; xmlns:d="http://openoffice.org/extensions/description/2006; xmlns:xlink="http://www.w3.org/1999/xlink;> - + @@ -19,7 +19,7 @@ -https://github.com/meixome/hunspell-gl-volga/issues; lang="en">Hunspell-gl-volga +https://github.com/meixome/hunspell-gl/issues; lang="en">Hunspell-gl diff --git a/gl/gl_ES.aff b/gl/gl_ES.aff index 1760198..51f0261 100644 --- a/gl/gl_ES.aff +++ b/gl/gl_ES.aff @@ -1,72 +1,20 @@ -# Proxecto Trasno 18 de outubro de 2012 -# -# Este ficheiro contén os parámetros de configuración -# do verificador ortográfico MySpell/Hunspell, as regras -# para as suxestións de substitución e as regras de afixación -# para o dicionario do verificador en lingua galega. -# Miguel Solla (brado...@gmail.com), 2010. -# -# O ficheiro co dicionario creouse a partir do -# Vocabulario ortográfico da lingua galega (VOLGa) -# Santamarina Fernández, Antón e González González, Manuel (coord.) -# Real Academia Galega / Instituto da Lingua Galega, 2004. -# http://www.realacademiagalega.org/volga/ -# -# As regras de afixación tratan de acadar un comportamento -# consonte as Normas ortográficas e morfolóxicas do idioma -# galego, Real Academia Galega / Instituto da Lingua Galega, 2003. -# http://www.realacademiagalega.org/PlainRAG/catalog/publications/files/normas_galego05.pdf -# -# Para a elaboración das regras de afixación reaproveitáronse -# algunhas das regras da versión que creou en 2006-2007 -# Mar Castro Pereiro para Mancomún (http://www.mancomun.org/) -# baixo os termos da GNU General Public License (GPL) -# -# [SEN REVISAR: ] Os topónimos, os antopónimos, as abreviaturas e -# as siglas que figuran ao final do ficheiro de dicionario tamén -# proceden desta versión anterior. -# -# A descrición do comportamento morfosintáctivo verbal -# pódese atopar no núm. 1 da revista Linguamática (ISSN: 1647-0818) -# http://linguamatica.com/index.php/linguamatica/article/view/13 - - - -# Codificación de caracteres: SET UTF-8 - -# Caracteres que se buscarán para facer suxestións de substitucións -# cando unicamente varíe un carácter na cadea TRY -aáàâãäeéêèiïìíîoóòôõöuùúûübcçdfghjklmnñpqrstvxyzABCDEFGHIJKLMNÑOPQRSTUVWXYZÁÉÍÓÚÀÈÌÒÙÏÜÇ· - -# Indícase o tipo de nomenclatura das regras de afixación FLAG num - -# O seguinte parámetro («666») utilizarase para indicar que a raíz -# do dicionario que se utiliza precisa necesariamente dunha regra de afixación NEEDAFFIX 666 - -# Cadeas de teclas próximas no teclado que poden ser -# facilmente confundidas á hora de teclear unha palabra. En cada serie de -# teclas ─separadas por unha barra vertical, «|»─ terase en conta as teclas -# á esquerda e dereita de cada unha. KEY qwertyuiop|asdfghjklñ|zxcvbnm|qaw|saz|wse|dsx|sz|edr|fdc|dx|rft|gfv|fc|tgz|hgb|gv|zhu|jhn|hb|uji|kjm|jn|iko|lkmñ|plñç - -# Impide que se ofrezan suxestións de substitución con elementos da cadea separados por un espazo -# (impide tamén as regras de substitución de n-gramas) NOSPLITSUGS - -# Establece o
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - dictionaries
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 95182333220f96cc511dc023c3235562b210107e Author: Adolfo Jayme Barrientos AuthorDate: Fri Nov 30 19:59:11 2018 -0600 Commit: Gerrit Code Review CommitDate: Sat Dec 29 20:42:48 2018 +0100 Update git submodules * Update dictionaries from branch 'libreoffice-6-1' - tdf#99826 Update Galician dictionaries to version 18.07 Change-Id: If3a2f77855159c1a2a50880b0eb37a824c926f6c Reviewed-on: https://gerrit.libreoffice.org/64370 Reviewed-by: Aron Budea Tested-by: Aron Budea (cherry picked from commit fea4ea689cd27d4c0bd981fdc01225d3bfacfc2d) Reviewed-on: https://gerrit.libreoffice.org/65655 Reviewed-by: Andras Timar Tested-by: Andras Timar diff --git a/dictionaries b/dictionaries index fe5f4cf69ea4..aa3f26cd95e3 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit fe5f4cf69ea41989db468588a69989d6ae444bd0 +Subproject commit aa3f26cd95e3acd29c4a9ca68052004ab35c6f88 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 122374] Macbook Air fresh install hangs with "Verifying..." for hours on initial startup
https://bugs.documentfoundation.org/show_bug.cgi?id=122374 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from V Stuart Foote --- Please provide build of macOS and hardware/GPU configuration. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - sw/qa sw/source
sw/qa/extras/mailmerge/data/linked-with-condition.odt |binary sw/qa/extras/mailmerge/mailmerge.cxx | 81 ++ sw/source/core/docnode/section.cxx|1 3 files changed, 81 insertions(+), 1 deletion(-) New commits: commit 5d4af68bdd2bb167e527d42f21bfe6cfbf3f25b0 Author: Mike Kaganski AuthorDate: Mon Dec 17 16:15:59 2018 +0300 Commit: Andras Timar CommitDate: Sat Dec 29 20:24:06 2018 +0100 tdf#122156: closing a section link should not clear its Hidden flag If a section is hidden or not does not depend on whether it's linked or not. Clearing the Hidden flag made all linked sections not hidden in DocumentLinksAdministrationManager::EmbedAllLinks() during mail merge. Existed since commit 84a3db80b4fd66c6854b3135b5f69b61fd828e62 initial import Reviewed-on: https://gerrit.libreoffice.org/65286 Tested-by: Jenkins Reviewed-by: Mike Kaganski (cherry picked from commit fdf4afb25ba38c7be3278bb4bde462c3f9e722fc) Change-Id: If347008e4cf48ab1327eb04db9fdf69750ce8fa5 diff --git a/sw/qa/extras/mailmerge/data/linked-with-condition.odt b/sw/qa/extras/mailmerge/data/linked-with-condition.odt new file mode 100644 index ..17fefa29b6b8 Binary files /dev/null and b/sw/qa/extras/mailmerge/data/linked-with-condition.odt differ diff --git a/sw/qa/extras/mailmerge/mailmerge.cxx b/sw/qa/extras/mailmerge/mailmerge.cxx index 731927e3b77d..b5063d3c6357 100644 --- a/sw/qa/extras/mailmerge/mailmerge.cxx +++ b/sw/qa/extras/mailmerge/mailmerge.cxx @@ -900,5 +900,86 @@ DECLARE_SHELL_MAILMERGE_TEST(testTdf121168, "section_ps.odt", "4_v01.ods", "Tabe } } +DECLARE_SHELL_MAILMERGE_TEST(testTdf122156_shell, "linked-with-condition.odt", "5-with-blanks.ods", + "names") +{ +// A document with a linked section hidden on an "empty field" condition +// For combined documents, hidden sections are removed completely +executeMailMerge(); +SwXTextDocument* pTextDoc = dynamic_cast(mxMMComponent.get()); +CPPUNIT_ASSERT(pTextDoc); +// 5 documents 1 page each, starting at odd page numbers => 9 +CPPUNIT_ASSERT_EQUAL(sal_uInt16(9), pTextDoc->GetDocShell()->GetWrtShell()->GetPhyPageNum()); +uno::Reference xSectionsSupplier(mxMMComponent, + uno::UNO_QUERY_THROW); +uno::Reference xSections(xSectionsSupplier->getTextSections(), + uno::UNO_QUERY_THROW); +// 2 out of 5 dataset records have empty "Title" field => no sections in respective documents +CPPUNIT_ASSERT_EQUAL(sal_Int32(3), xSections->getCount()); +} + +DECLARE_FILE_MAILMERGE_TEST(testTdf122156_file, "linked-with-condition.odt", "5-with-blanks.ods", +"names") +{ +// A document with a linked section hidden on an "empty field" condition +// For separate documents, the sections are hidden, but not removed +executeMailMerge(); +{ +loadMailMergeDocument(0); +uno::Reference xSectionsSupplier(mxComponent, + uno::UNO_QUERY_THROW); +uno::Reference xSections(xSectionsSupplier->getTextSections(), + uno::UNO_QUERY_THROW); +CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xSections->getCount()); +uno::Reference xSect(xSections->getByIndex(0), uno::UNO_QUERY_THROW); +// Record 1 has empty "Title" field => section is not shown +CPPUNIT_ASSERT_EQUAL(false, getProperty(xSect, "IsCurrentlyVisible")); +} +{ +loadMailMergeDocument(1); +uno::Reference xSectionsSupplier(mxComponent, + uno::UNO_QUERY_THROW); +uno::Reference xSections(xSectionsSupplier->getTextSections(), + uno::UNO_QUERY_THROW); +CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xSections->getCount()); +uno::Reference xSect(xSections->getByIndex(0), uno::UNO_QUERY_THROW); +// Record 2 has non-empty "Title" field => section is shown +CPPUNIT_ASSERT_EQUAL(true, getProperty(xSect, "IsCurrentlyVisible")); +} +{ +loadMailMergeDocument(2); +uno::Reference xSectionsSupplier(mxComponent, + uno::UNO_QUERY_THROW); +uno::Reference xSections(xSectionsSupplier->getTextSections(), + uno::UNO_QUERY_THROW); +CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xSections->getCount()); +uno::Reference xSect(xSections->getByIndex(0), uno::UNO_QUERY_THROW); +// Record 3 has non-empty "Title" field => section is shown +CPPUNIT_ASSERT_EQUAL(true, getProperty(xSect,
[Libreoffice-bugs] [Bug 122374] New: Macbook Air fresh install hangs with "Verifying..." for hours on initial startup
https://bugs.documentfoundation.org/show_bug.cgi?id=122374 Bug ID: 122374 Summary: Macbook Air fresh install hangs with "Verifying..." for hours on initial startup Product: LibreOffice Version: 6.1.4.2 release Hardware: Other OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Installation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cr...@arno.com Fresh install of LibreOffice 6.1.4.2 Mac OS X x86_64 on Macbook Air, downloaded using latest version of Firefox. First attempt to run LibreOffice results in "Verifying..." message which lasted for more than 2 hours. LibreOffice Program would not abort or end. Had to reboot the machine to stop LibreOffice "Verifying...". LibreOffice "Verifying..." prevents other programs from starting/running. Second attempt to run LibreOffice resulted in LibreOffice "Verifying..." (hung) condition. Finally gave up and tried OpenOffice. OpenOffice installs and starts in under 10 minutes (probably 5 minutes or less). All OpenOffice applications run correctly. OpenOffice Mac can't read DOCX or XLSX files, so really want to get LibreOffice running. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - sw/source
sw/source/uibase/app/apphdl.cxx | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) New commits: commit 7f043d099569e87ac9372975241787f364f0056d Author: Mike Kaganski AuthorDate: Thu Dec 6 23:36:04 2018 +0300 Commit: Andras Timar CommitDate: Sat Dec 29 20:20:42 2018 +0100 tdf#121606: displaying Mail Merge toolbar shouldn't activate connection At least I think so. Thus now the code that queries the state of the toolbar controls only queries dataset if connection is active. Operating the navigation buttons (next/prev) will, naturally, activate connection if not yet active. This should also enable the other controls that may be initially disabled: create/save/print/email documents. Thus, the navigation controls also check if they have activated the connection, and invalidate said document creation controls state. Possibly there's a better place for the invalidation of the controls, but I was unable to find one. Regression after commit 5c2c5ff01c23e4f7a8947746afc13a46cbef5bec Change-Id: I76f895c871718c9c761339ba03963baf6837b592 Reviewed-on: https://gerrit.libreoffice.org/64738 Tested-by: Jenkins Reviewed-by: Mike Kaganski (cherry picked from commit 60714a814847f6d10f00aa6809a3896a48741e0b) Reviewed-on: https://gerrit.libreoffice.org/65084 Tested-by: Aron Budea Reviewed-by: Andras Timar diff --git a/sw/source/uibase/app/apphdl.cxx b/sw/source/uibase/app/apphdl.cxx index 5952313aabd4..aed4e9653aa3 100644 --- a/sw/source/uibase/app/apphdl.cxx +++ b/sw/source/uibase/app/apphdl.cxx @@ -189,7 +189,8 @@ void SwModule::StateOther(SfxItemSet ) xConfigItem = pView->GetMailMergeConfigItem(); if (!xConfigItem) rSet.DisableItem(nWhich); -else +else if (xConfigItem->GetConnection().is() + && !xConfigItem->GetConnection()->isClosed()) { bool bFirst, bLast; bool bValid = xConfigItem->IsResultSetFirstLast(bFirst, bLast); @@ -224,6 +225,8 @@ void SwModule::StateOther(SfxItemSet ) // #i51949# hide e-Mail option if e-Mail is not supported // #i63267# printing might be disabled if (!xConfigItem || +!xConfigItem->GetConnection().is() || +xConfigItem->GetConnection()->isClosed() || !xConfigItem->GetResultSet().is() || xConfigItem->GetCurrentDBData().sDataSource.isEmpty() || xConfigItem->GetCurrentDBData().sCommand.isEmpty() || @@ -773,6 +776,9 @@ void SwModule::ExecOther(SfxRequest& rReq) if (!xConfigItem) return; +const bool bHadConnection += xConfigItem->GetConnection().is() && !xConfigItem->GetConnection()->isClosed(); + sal_Int32 nPos = xConfigItem->GetResultSetPosition(); switch (nWhich) { @@ -810,6 +816,15 @@ void SwModule::ExecOther(SfxRequest& rReq) rBindings.Invalidate(FN_MAILMERGE_LAST_ENTRY); rBindings.Invalidate(FN_MAILMERGE_CURRENT_ENTRY); rBindings.Invalidate(FN_MAILMERGE_EXCLUDE_ENTRY); +if (!bHadConnection && xConfigItem->GetConnection().is() +&& !xConfigItem->GetConnection()->isClosed()) +{ +// The connection has been activated. Update controls that were disabled +rBindings.Invalidate(FN_MAILMERGE_CREATE_DOCUMENTS); +rBindings.Invalidate(FN_MAILMERGE_SAVE_DOCUMENTS); +rBindings.Invalidate(FN_MAILMERGE_PRINT_DOCUMENTS); +rBindings.Invalidate(FN_MAILMERGE_EMAIL_DOCUMENTS); +} rBindings.Update(); } break; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - sc/source
sc/source/ui/condformat/condformatdlg.cxx |6 ++ 1 file changed, 6 insertions(+) New commits: commit 9972e23fa2ac292310df86c5b7e7ec4d7d6acea6 Author: Mike Kaganski AuthorDate: Tue Dec 4 21:28:46 2018 +0300 Commit: Andras Timar CommitDate: Sat Dec 29 20:21:04 2018 +0100 tdf#117332: select replaced text to properly replace it next time ... othervise the next drag event will insert the new range immediately after the just inserted, resulting in invalid reference. Regression after commit 42aece949ec96c775b31216bddd723aa5321e966 don't replace content of formula field when selecting range, tdf#58635 Change-Id: I7dfdc1ce041ebadf4406dbb605676d87cd489efa Reviewed-on: https://gerrit.libreoffice.org/64574 Reviewed-by: Mike Kaganski Tested-by: Mike Kaganski (cherry picked from commit 6c5839d399c6277a7f2f0e214a20996761563525) Reviewed-on: https://gerrit.libreoffice.org/65083 Tested-by: Aron Budea Reviewed-by: Andras Timar diff --git a/sc/source/ui/condformat/condformatdlg.cxx b/sc/source/ui/condformat/condformatdlg.cxx index 4f9f82568d1a..00adeac4e296 100644 --- a/sc/source/ui/condformat/condformatdlg.cxx +++ b/sc/source/ui/condformat/condformatdlg.cxx @@ -655,7 +655,13 @@ void ScCondFormatDlg::SetReference(const ScRange& rRef, ScDocument*) OUString aRefStr(rRef.Format(nFlags, mpViewData->GetDocument(), ScAddress::Details(mpViewData->GetDocument()->GetAddressConvention(), 0, 0))); if (pEdit != mpEdRange) +{ +Selection sel = pEdit->GetSelection(); +sel.Justify();// in case of RtL selection +sel.Max() = sel.Min() + aRefStr.getLength(); pEdit->ReplaceSelected(aRefStr); +pEdit->SetSelection(sel); // to replace it again with next drag event +} else pEdit->SetRefString( aRefStr ); updateTitle(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - sw/source
sw/source/core/edit/edfcol.cxx |6 ++ 1 file changed, 6 insertions(+) New commits: commit f192d5b200ed4568c9d03f69f4148a8fc619122c Author: Mike Kaganski AuthorDate: Tue Dec 18 09:19:06 2018 +0300 Commit: Andras Timar CommitDate: Sat Dec 29 20:19:52 2018 +0100 tdf#116496: don't add header when setting empty watermark Regression from commit 22e94ab1860b1bdea8d107d4e8824f63c6b1c8c5 Change-Id: I66a6e0b5069fe459b887a52f1ea26904dfc2d37b Reviewed-on: https://gerrit.libreoffice.org/65303 Reviewed-by: Mike Kaganski Tested-by: Mike Kaganski (cherry picked from commit c4f3bd7c94cacb52f7a791a0d364818cee6080b6) Reviewed-on: https://gerrit.libreoffice.org/65318 Reviewed-by: Andras Timar diff --git a/sw/source/core/edit/edfcol.cxx b/sw/source/core/edit/edfcol.cxx index bf12303ba2c7..f79fc443199e 100644 --- a/sw/source/core/edit/edfcol.cxx +++ b/sw/source/core/edit/edfcol.cxx @@ -1598,6 +1598,7 @@ void SwEditShell::SetWatermark(const SfxWatermarkItem& rWatermark) SwDocShell* pDocShell = GetDoc()->GetDocShell(); if (!pDocShell) return; +const bool bNoWatermark = rWatermark.GetText().isEmpty(); uno::Reference xModel = pDocShell->GetBaseModel(); uno::Reference xStyleFamiliesSupplier(xModel, uno::UNO_QUERY); @@ -1613,7 +1614,12 @@ void SwEditShell::SetWatermark(const SfxWatermarkItem& rWatermark) bool bHeaderIsOn = false; xPageStyle->getPropertyValue(UNO_NAME_HEADER_IS_ON) >>= bHeaderIsOn; if (!bHeaderIsOn) +{ +if (bNoWatermark) +continue; // the style doesn't have any watermark - no need to do anything + xPageStyle->setPropertyValue(UNO_NAME_HEADER_IS_ON, uno::makeAny(true)); +} // backup header height bool bDynamicHeight = true; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - sw/qa sw/source
sw/qa/extras/mailmerge/data/section_ps.odt |binary sw/qa/extras/mailmerge/mailmerge.cxx | 33 + sw/source/uibase/dbui/dbmgr.cxx|9 +++ 3 files changed, 42 insertions(+) New commits: commit 81dc538bdebf7e2c8c0b259eed3b3f8b77309c59 Author: Mike Kaganski AuthorDate: Wed Dec 19 00:35:32 2018 +0300 Commit: Andras Timar CommitDate: Sat Dec 29 20:17:43 2018 +0100 tdf#121168: Ensure page descriptions are correct in work document When first node on a page is a section, then creation of a copy with lcl_CreateWorkingDocument initially produces a document with layout frames having wrong page descriptions applied (set to "Default Style"). The reason is that when SfxViewFrame::LoadHiddenDocument indirectly calls SwRootFrame::Init, the sections in the document have hidden flag set, which causes SwNodes::GoNextSection return the first node after the first section. The returned node naturally doesn't have a page description set, thus the initialized page frame doesn't get it. This makes following copy to destination document use that wrong style; if the correct page style had header/footer, then it would not be properly copied per record in single-document output; headers/footers would be wrong/absent. This change forces check of page descriptions after the work document had been created and initialized. Change-Id: Ic196eb7fac0241f002eddd2c1d1b66dfb489bc60 Reviewed-on: https://gerrit.libreoffice.org/65383 Reviewed-by: Mike Kaganski Tested-by: Mike Kaganski (cherry picked from commit ec928ac5d84273b4bc1f923c545834dc59d3e394) Reviewed-on: https://gerrit.libreoffice.org/65408 Reviewed-by: Andras Timar diff --git a/sw/qa/extras/mailmerge/data/section_ps.odt b/sw/qa/extras/mailmerge/data/section_ps.odt new file mode 100644 index ..dd9704845fac Binary files /dev/null and b/sw/qa/extras/mailmerge/data/section_ps.odt differ diff --git a/sw/qa/extras/mailmerge/mailmerge.cxx b/sw/qa/extras/mailmerge/mailmerge.cxx index ba4c5dd401bd..731927e3b77d 100644 --- a/sw/qa/extras/mailmerge/mailmerge.cxx +++ b/sw/qa/extras/mailmerge/mailmerge.cxx @@ -867,5 +867,38 @@ DECLARE_SHELL_MAILMERGE_TEST(testTdf118845, "tdf118845.fodt", "4_v01.ods", "Tabe CPPUNIT_ASSERT_EQUAL(OUString(""), xParagraph->getString()); } +DECLARE_SHELL_MAILMERGE_TEST(testTdf121168, "section_ps.odt", "4_v01.ods", "Tabelle1") +{ +// A document starting with a section on a page with non-default page style with header +executeMailMerge(); +SwXTextDocument* pTextDoc = dynamic_cast(mxMMComponent.get()); +CPPUNIT_ASSERT(pTextDoc); +// 4 documents 1 page each, starting at odd page numbers => 7 +CPPUNIT_ASSERT_EQUAL(sal_uInt16(7), pTextDoc->GetDocShell()->GetWrtShell()->GetPhyPageNum()); + +SwDoc* pDocMM = pTextDoc->GetDocShell()->GetDoc(); +sal_uLong nSizeMM = pDocMM->GetNodes().GetEndOfContent().GetIndex() +- pDocMM->GetNodes().GetEndOfExtras().GetIndex() - 2; +CPPUNIT_ASSERT_EQUAL(sal_uLong(16), nSizeMM); + +// All even pages should be empty, all sub-documents have one page +const SwRootFrame* pLayout = pDocMM->getIDocumentLayoutAccess().GetCurrentLayout(); +const SwPageFrame* pPageFrm = static_cast(pLayout->Lower()); +while (pPageFrm) +{ +sal_uInt16 nPageNum = pPageFrm->GetPhyPageNum(); +bool bOdd = (1 == (nPageNum % 2)); +CPPUNIT_ASSERT_EQUAL(!bOdd, pPageFrm->IsEmptyPage()); +CPPUNIT_ASSERT_EQUAL(sal_uInt16(bOdd ? 1 : 2), pPageFrm->GetVirtPageNum()); +if (bOdd) +{ +const SwPageDesc* pDesc = pPageFrm->GetPageDesc(); +CPPUNIT_ASSERT_EQUAL(OUString("Teststyle" + OUString::number(nPageNum / 2 + 1)), + pDesc->GetName()); +} +pPageFrm = static_cast(pPageFrm->GetNext()); +} +} + CPPUNIT_PLUGIN_IMPLEMENT(); /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/sw/source/uibase/dbui/dbmgr.cxx b/sw/source/uibase/dbui/dbmgr.cxx index 51f0dde9ae05..55e82e50e8f0 100644 --- a/sw/source/uibase/dbui/dbmgr.cxx +++ b/sw/source/uibase/dbui/dbmgr.cxx @@ -1421,6 +1421,15 @@ bool SwDBManager::MergeMailFiles(SwWrtShell* pSourceShell, // ExpFields update during printing, generation of preview, etc. pWorkShell->LockExpFields(); pWorkShell->CalcLayout(); +// tdf#121168: Now force correct page descriptions applied to page frames. Without +// this, e.g., page frames starting with sections could have page descriptions set +// wrong. This would lead to wrong page styles applied in SwDoc::AppendDoc below. +pWorkShell->GetViewOptions()->SetIdle(true); +for (auto aLayout : pWorkShell->GetDoc()->GetAllLayouts()) +{ +
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - external/gpgmepp
external/gpgmepp/ExternalPackage_gpgmepp.mk |3 +++ 1 file changed, 3 insertions(+) New commits: commit 9f60a160d19521cc0194e5516ef2d23e9d70af33 Author: Mike Kaganski AuthorDate: Thu Oct 18 10:17:12 2018 +0300 Commit: Andras Timar CommitDate: Sat Dec 29 20:15:17 2018 +0100 Copy gpgme-w32spawn.exe to workdir/LinkTarget/Executable ... to avoid "GpgME not installed correctly" message boxes during unit tests. See the mail list thread started with https://lists.freedesktop.org/archives/libreoffice/2018-October/081209.html Change-Id: Ie57e6b5a7281d8f20ba97912f3413eafaac9cfd4 Reviewed-on: https://gerrit.libreoffice.org/61903 Tested-by: Jenkins Tested-by: Jan-Marek Glogowski Reviewed-by: Thorsten Behrens (cherry picked from commit 0de0b8c9d80d68619b6f3c0e8d9429d8b08553fb) Reviewed-on: https://gerrit.libreoffice.org/65093 Reviewed-by: Mike Kaganski Tested-by: Mike Kaganski Reviewed-by: Andras Timar diff --git a/external/gpgmepp/ExternalPackage_gpgmepp.mk b/external/gpgmepp/ExternalPackage_gpgmepp.mk index 67c3dc64ffd3..8253f663e50c 100644 --- a/external/gpgmepp/ExternalPackage_gpgmepp.mk +++ b/external/gpgmepp/ExternalPackage_gpgmepp.mk @@ -27,6 +27,9 @@ else ifeq ($(OS),WNT) $(eval $(call gb_ExternalPackage_add_file,gpgmepp,$(LIBO_LIB_FOLDER)/gpgme-w32spawn.exe,src/gpgme-w32spawn.exe)) +$(call gb_Package_get_target_for_build,gpgmepp): + cp $(call gb_UnpackedTarball_get_dir,gpgmepp)/src/gpgme-w32spawn.exe $(call gb_Executable__get_dir_for_exe,cppunittester)/gpgme-w32spawn.exe + endif # If a tool executed during the build (like svidl) requires these gpgmepp libraries, it will also ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - include/sfx2 sal/osl sfx2/source
include/sfx2/docfile.hxx|3 - sal/osl/w32/file.cxx|2 sfx2/source/doc/docfile.cxx | 108 ++-- 3 files changed, 108 insertions(+), 5 deletions(-) New commits: commit 6365cb0e5e1316bf0b27d22952ec63d72ef7bf5b Author: Mike Kaganski AuthorDate: Tue Dec 4 10:00:51 2018 +0300 Commit: Andras Timar CommitDate: Sat Dec 29 20:14:46 2018 +0100 tdf#34171: check foreign lockfiles to tell who has locked document MS Office (Word/Excel/PowerPoint) lockfiles are supported now. Note that Excel does *not* create lockfiles for pre-OOXML files. This changes osl_openFile implementation on Windows, to treat osl_File_OpenFlag_NoLock to also include FILE_SHARE_DELETE flag for CreateFileW. This is required to allow opening files created with FILE_FLAG_DELETE_ON_CLOSE flag, such as Excel's owner files. The shange should be consistent with the overall meaning of the osl_File_OpenFlag_NoLock to not impose any locking constraints to the file being opened. Change-Id: I7b99012f4bd60ab3821fb91d5166a286031b7e93 Reviewed-on: https://gerrit.libreoffice.org/64496 Tested-by: Jenkins Reviewed-by: Mike Kaganski (cherry picked from commit 607b80ca3cddc239a35580470944a438ce144fc8) Reviewed-on: https://gerrit.libreoffice.org/65085 Tested-by: Mike Kaganski Reviewed-by: Andras Timar diff --git a/include/sfx2/docfile.hxx b/include/sfx2/docfile.hxx index c4aaa766ab98..eae58edf0823 100644 --- a/include/sfx2/docfile.hxx +++ b/include/sfx2/docfile.hxx @@ -289,7 +289,8 @@ public: private: enum class ShowLockResult { NoLock, Succeeded, Try }; -ShowLockResult ShowLockedDocumentDialog(const LockFileEntry& aData, bool bIsLoading, bool bOwnLock, bool bHandleSysLocked); +ShowLockResult ShowLockedDocumentDialog(const OUString& aDocURL, const LockFileEntry& aData, +bool bIsLoading, bool bOwnLock, bool bHandleSysLocked); enum class MessageDlg { LockFileIgnore, LockFileCorrupt }; boolShowLockFileProblemDialog(MessageDlg nWhichDlg); diff --git a/sal/osl/w32/file.cxx b/sal/osl/w32/file.cxx index 7c0b6674c23f..c6265c5b9b2f 100644 --- a/sal/osl/w32/file.cxx +++ b/sal/osl/w32/file.cxx @@ -710,7 +710,7 @@ oslFileError SAL_CALL osl_openFile( dwShare |= FILE_SHARE_WRITE; if (uFlags & osl_File_OpenFlag_NoLock) -dwShare |= FILE_SHARE_WRITE; +dwShare |= FILE_SHARE_WRITE | FILE_SHARE_DELETE; if (uFlags & osl_File_OpenFlag_Create) dwCreation |= CREATE_NEW; diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx index 97431ff3ed10..e8efa9e672a7 100644 --- a/sfx2/source/doc/docfile.cxx +++ b/sfx2/source/doc/docfile.cxx @@ -833,8 +833,104 @@ void SfxMedium::SetEncryptionDataToStorage_Impl() // that. Clearly the knowledge whether lock files should be used or // not for some URL scheme belongs in UCB, not here. +namespace +{ +OUString tryMSOwnerFile(const INetURLObject& aLockfileURL) +{ +try +{ +static osl::Mutex aMutex; +osl::MutexGuard aGuard(aMutex); +css::uno::Reference xEnv; +ucbhelper::Content aSourceContent( +aLockfileURL.GetMainURL(INetURLObject::DecodeMechanism::NONE), xEnv, +comphelper::getProcessComponentContext()); + +// Excel creates Owner Files with FILE_FLAG_DELETE_ON_CLOSE, so we need to open it with +// FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE share mode +css::uno::Reference xStream = aSourceContent.openStreamNoLock(); +if (!xStream) +return OUString(); + +const sal_Int32 nBufLen = 256; +css::uno::Sequence aBuf(nBufLen); +const sal_Int32 nRead = xStream->readBytes(aBuf, nBufLen); +xStream->closeInput(); +if (nRead >= 162) +{ +// Reverse engineering of MS Office Owner Files format (MS Office 2016 tested). +// It starts with a single byte with name length, after which characters of username go +// in current Windows 8-bit codepage. +// For Word lockfiles, the name is followed by zero bytes up to position 54. +// For PowerPoint lockfiles, the name is followed by a single zero byte, and then 0x20 +// bytes up to position 55. +// For Excel lockfiles, the name is followed by 0x20 bytes up to position 55. +// At those positions in each type of lockfile, a name length 2-byte word goes, followed +// by UTF-16-LE-encoded copy of username. Spaces or some garbage follow up to the end of +// the lockfile (total 162 bytes for Word, 165 bytes for Excel/PowerPoint). +// Apparently MS Office does not allow username to be longer than 52 characters (trying +// to enter more in its options dialog results in error messages stating this
[Libreoffice-bugs] [Bug 114441] Convert use of sal_uLong to better integer types
https://bugs.documentfoundation.org/show_bug.cgi?id=114441 --- Comment #11 from himajin100...@gmail.com --- (In reply to Komal from comment #10) https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119241] Crash in: CompareSwOutlineNodes::operator()(SwNode * const &, SwNode * const &)
https://bugs.documentfoundation.org/show_bug.cgi?id=119241 raal changed: What|Removed |Added CC||michael.st...@cib.de, ||r...@post.cz Keywords|bibisectRequest |bibisected, bisected --- Comment #7 from raal --- (In reply to Xisco Faulí from comment #2) > Reproduced with > > 1. Open attachment 144106 [details] > 2. CTRL+A & CTRL+C > 3. CTRL+N (New document) > 4. CTRL+V > 5. CTRL+A > 6. CTRL+X > 7. CTRL+Z (twice) > 8. CTRL+V > 9. CTRL+A > 10. CTRL+X > > CRASH!! This seems to have begun at the below commit. Adding Cc: to Michael Stahl ; Could you possibly take a look at this one? Thanks 8a8b50772859fd6198e8e139ca853a4b7aca9133 is the first bad commit commit 8a8b50772859fd6198e8e139ca853a4b7aca9133 Author: Matthew Francis Date: Sat Sep 5 22:42:31 2015 +0800 source-hash-b8002169336b6b7597d32755e41fa3dc2688539e commit b8002169336b6b7597d32755e41fa3dc2688539e Author: Michael Stahl AuthorDate: Wed Nov 6 16:36:04 2013 +0100 Commit: Michael Stahl CommitDate: Thu Nov 7 14:27:50 2013 -0600 remove INPATH and PROEXT - WORKDIR path is just workdir - INSTDIR path is just instdir - WORKDIR_FOR_BUILD is workdir_for_build - INSTDIR_FOR_BUILD is instdir_for_build - replace other usage of INPATH by combination of OS and CPUNAME Change-Id: Ie398387ebd82a968ec2605f2103c55b43a231482 Reviewed-on: https://gerrit.libreoffice.org/6601 Reviewed-by: Tor Lillqvist Tested-by: Tor Lillqvist Reviewed-by: Michael Stahl -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 V Stuart Foote changed: What|Removed |Added Depends on||122369 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122369 [Bug 122369] Properties->Details page is empty for LO files -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122369] Properties->Details page is empty for LO files
https://bugs.documentfoundation.org/show_bug.cgi?id=122369 V Stuart Foote changed: What|Removed |Added Blocks||102495 CC||vstuart.fo...@utsa.edu --- Comment #3 from V Stuart Foote --- Can not confirm on Windows. The OS file manager "Explorer" reads a full slate of properties for each ODF document. This looks to be an issue in KDE5's Dolphin file management. Would be curious to know if review of File -> Properties from a session of LibreOffice shows details in the OS/DE or is also affected? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102495 [Bug 102495] [META] KDE VCL backend bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122373] New: Date format convert to date and increment in copy enhancement
https://bugs.documentfoundation.org/show_bug.cgi?id=122373 Bug ID: 122373 Summary: Date format convert to date and increment in copy enhancement Product: LibreOffice Version: 6.1.1.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bty-admi...@trebly.net Description: When you define date format you expect : 1- To store the content as a date (if content set is not valid - not recognized - content is left centered to tell that the content is read as standard text) 2- to be able to calculate from the date 3- convert to any format 4- increment the date when cell is multi-duplicated (don't know the right expression in English). This according to format There is strong bug but difficulties to perform operations regard to excel What happens : 1- hits of not exact format of dates are not recognized (for standard and user formats). For example and particularly : - month formats : with format defined JJ/MM/ - unable to understand MM/ (supposed 01/MM/AAA), - unable to recognize a wrong like decimal point (in French keyboard the dot of numerical keypad is translated to "," - unable to (recognize a "janv.2020" as "jan. 2020") recognize without error needs to read with format "MMM. " MMM = "jan" and ="2020" - many examples hold by excel which make easier to get the dates from keyboard when they are not exactly fitting the format - ... 2- Increment when duplicating (multi-copy by dragging copy point) a cell with date function without taking in account the format, for example if format does not display the JJ it could be supposed that the date is incremented by "month" or year if "M" is not included in format ("A" format for example would lead to "01/01/A"). Then to increment by copy a (complex for some users) formula must be developed ("=DATE(ANNEE(A3);MOIS(A3)+1;JOUR(A3))" for French version or "=DATE(YEAR(A3),MONTH(A3)+1,DAY(A3))" in English) to get a calendar with months (date associated to a month is supposed to be 01/MM (MM/01 in English) Note : I had to produce a two columns calendar with : - months (note that when user defines a month it most of time not a date but a span of time 01/MM to endOfMonth/MM). Truncate the JJ converts a date to a SPAN of time of one month - a fixed JJ into the month ( a date to pay) This is currently a major difficulty for most of users. As often libreoffice is very rigorous, but this lead that the incremented value of "jan. 2020" is shown as "jan. 2020" while the "internal" date which is not visible is incremented of one day... (What happens with date with time) To implement a clear increment would need to define the formula if incremented element is not visible into the format Steps to Reproduce: 1. no matter 2. 3. Actual Results: see extended description Expected Results: see extended description Reproducible: Always User Profile Reset: No Additional Info: see extended description Note : While I was writing this report I could not restart to execute the update to 6.1.3 previously used. I suppose that the concerned function has not been updated from 6.1.1 to 6.1.3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122372] Artefact/incorrect background with LibreOffice icons on Windows with HiDPI configurations
https://bugs.documentfoundation.org/show_bug.cgi?id=122372 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||9020 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119020] Icons are corrupted on Windows when scaling UI 150% and higher, with some OpenGL dependency
https://bugs.documentfoundation.org/show_bug.cgi?id=119020 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||2372 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122372] Artefact/incorrect background with LibreOffice icons on Windows with HiDPI configurations
https://bugs.documentfoundation.org/show_bug.cgi?id=122372 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Status|NEW |NEEDINFO --- Comment #3 from V Stuart Foote --- That looks to be a dupe of bug 119020 which has been fixed [1] for 6.1.4 release. OP needs to clear his user cache (which holds scaled icon cache over from prior install) and retest to verify. =-ref-= [1] https://git.libreoffice.org/core/+/47789c45dfc7ba8509eedab37f1dbd70ea79da41%5E%21 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: desktop/source
desktop/source/app/officeipcthread.cxx |6 +++--- desktop/source/app/officeipcthread.hxx |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) New commits: commit 695f841604dbc7122dc6d5beee6b1200e562f3be Author: Andrea Gelmini AuthorDate: Sat Dec 29 18:04:47 2018 +0100 Commit: Julien Nabet CommitDate: Sat Dec 29 19:46:37 2018 +0100 Fix typo in code Change-Id: I1e6d483e7cc7f03149fbd0a0f5f49a62677faecd Reviewed-on: https://gerrit.libreoffice.org/65695 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/desktop/source/app/officeipcthread.cxx b/desktop/source/app/officeipcthread.cxx index 2871072e418b..08c0d4b83fa7 100644 --- a/desktop/source/app/officeipcthread.cxx +++ b/desktop/source/app/officeipcthread.cxx @@ -980,8 +980,8 @@ bool IpcThread::process(OString const & arguments, bool * waitProcessed) { aCmdLineArgs->getCwdUrl()); m_handler->cProcessed.reset(); pRequest->pcProcessed = _handler->cProcessed; -m_handler->mbSucces = false; -pRequest->mpbSuccess = _handler->mbSucces; +m_handler->mbSuccess = false; +pRequest->mpbSuccess = _handler->mbSuccess; // Print requests are not dependent on the --invisible cmdline argument as they are // loaded with the "hidden" flag! So they are always checked. @@ -1185,7 +1185,7 @@ void PipeIpcThread::execute() if (waitProcessed) { m_handler->cProcessed.wait(); -bSuccess = m_handler->mbSucces; +bSuccess = m_handler->mbSuccess; } if (bSuccess) { diff --git a/desktop/source/app/officeipcthread.hxx b/desktop/source/app/officeipcthread.hxx index 224f154e0cce..ca2533e191b8 100644 --- a/desktop/source/app/officeipcthread.hxx +++ b/desktop/source/app/officeipcthread.hxx @@ -93,7 +93,7 @@ class RequestHandler: public salhelper::SimpleReferenceObject /* condition to be set when the request has been processed */ ::osl::Condition cProcessed; /* receives if the processing was successful (may be false e.g. when shutting down) */ -bool mbSucces = false; +bool mbSuccess = false; /* condition to be set when the main event loop is ready otherwise an error dialogs event loop could eat away ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: icon-themes/breeze_dark
icon-themes/breeze_dark/cmd/lc_closedoc.png|binary icon-themes/breeze_dark/cmd/lc_closemasterview.png |binary icon-themes/breeze_dark/cmd/lc_closepreview.png|binary icon-themes/breeze_dark/cmd/lc_deletemasterpage.png|binary icon-themes/breeze_dark/cmd/lc_displaymasterbackground.png |binary icon-themes/breeze_dark/cmd/lc_displaymasterobjects.png|binary icon-themes/breeze_dark/cmd/lc_insertmasterpage.png|binary icon-themes/breeze_dark/cmd/lc_masterlayouts.png |binary icon-themes/breeze_dark/cmd/lc_masterpage.png |binary icon-themes/breeze_dark/cmd/lc_notesmasterpage.png |binary icon-themes/breeze_dark/cmd/lc_slidemasterpage.png |binary icon-themes/breeze_dark/cmd/sc_closedoc.png|binary icon-themes/breeze_dark/cmd/sc_closemasterview.png |binary icon-themes/breeze_dark/cmd/sc_closepreview.png|binary icon-themes/breeze_dark/cmd/sc_deletemasterpage.png|binary icon-themes/breeze_dark/cmd/sc_displaymasterbackground.png |binary icon-themes/breeze_dark/cmd/sc_displaymasterobjects.png|binary icon-themes/breeze_dark/cmd/sc_insertmasterpage.png|binary icon-themes/breeze_dark/cmd/sc_masterlayouts.png |binary icon-themes/breeze_dark/cmd/sc_notesmasterpage.png |binary icon-themes/breeze_dark/cmd/sc_slidemasterpage.png |binary 21 files changed New commits: commit 96c9357edc67ff81358573194bbab172cbb33c38 Author: andreas kainz AuthorDate: Sat Dec 29 12:31:11 2018 +0100 Commit: andreas_kainz CommitDate: Sat Dec 29 19:43:26 2018 +0100 Breeze dark: master and close quite icon update Change-Id: I33f05f273b07a209ac89f6c671e412f30d0ca6f7 Reviewed-on: https://gerrit.libreoffice.org/65711 Tested-by: Jenkins Reviewed-by: andreas_kainz diff --git a/icon-themes/breeze_dark/cmd/lc_closedoc.png b/icon-themes/breeze_dark/cmd/lc_closedoc.png index fc135bc2146a..1fa0b52a552e 100644 Binary files a/icon-themes/breeze_dark/cmd/lc_closedoc.png and b/icon-themes/breeze_dark/cmd/lc_closedoc.png differ diff --git a/icon-themes/breeze_dark/cmd/lc_closemasterview.png b/icon-themes/breeze_dark/cmd/lc_closemasterview.png new file mode 100644 index ..8d070138ca5a Binary files /dev/null and b/icon-themes/breeze_dark/cmd/lc_closemasterview.png differ diff --git a/icon-themes/breeze_dark/cmd/lc_closepreview.png b/icon-themes/breeze_dark/cmd/lc_closepreview.png new file mode 100644 index ..397727b63e66 Binary files /dev/null and b/icon-themes/breeze_dark/cmd/lc_closepreview.png differ diff --git a/icon-themes/breeze_dark/cmd/lc_deletemasterpage.png b/icon-themes/breeze_dark/cmd/lc_deletemasterpage.png index fa3a4c0478c7..9769db909c05 100644 Binary files a/icon-themes/breeze_dark/cmd/lc_deletemasterpage.png and b/icon-themes/breeze_dark/cmd/lc_deletemasterpage.png differ diff --git a/icon-themes/breeze_dark/cmd/lc_displaymasterbackground.png b/icon-themes/breeze_dark/cmd/lc_displaymasterbackground.png new file mode 100644 index ..129866529dfc Binary files /dev/null and b/icon-themes/breeze_dark/cmd/lc_displaymasterbackground.png differ diff --git a/icon-themes/breeze_dark/cmd/lc_displaymasterobjects.png b/icon-themes/breeze_dark/cmd/lc_displaymasterobjects.png new file mode 100644 index ..158aa3c873bb Binary files /dev/null and b/icon-themes/breeze_dark/cmd/lc_displaymasterobjects.png differ diff --git a/icon-themes/breeze_dark/cmd/lc_insertmasterpage.png b/icon-themes/breeze_dark/cmd/lc_insertmasterpage.png index d75761861f23..5354e2c86876 100644 Binary files a/icon-themes/breeze_dark/cmd/lc_insertmasterpage.png and b/icon-themes/breeze_dark/cmd/lc_insertmasterpage.png differ diff --git a/icon-themes/breeze_dark/cmd/lc_masterlayouts.png b/icon-themes/breeze_dark/cmd/lc_masterlayouts.png new file mode 100644 index ..93e70b61d43a Binary files /dev/null and b/icon-themes/breeze_dark/cmd/lc_masterlayouts.png differ diff --git a/icon-themes/breeze_dark/cmd/lc_masterpage.png b/icon-themes/breeze_dark/cmd/lc_masterpage.png new file mode 100644 index ..4ee8d26fac69 Binary files /dev/null and b/icon-themes/breeze_dark/cmd/lc_masterpage.png differ diff --git a/icon-themes/breeze_dark/cmd/lc_notesmasterpage.png b/icon-themes/breeze_dark/cmd/lc_notesmasterpage.png index 575f0a0bf0e2..6dfa303199b4 100644 Binary files a/icon-themes/breeze_dark/cmd/lc_notesmasterpage.png and b/icon-themes/breeze_dark/cmd/lc_notesmasterpage.png differ diff --git a/icon-themes/breeze_dark/cmd/lc_slidemasterpage.png b/icon-themes/breeze_dark/cmd/lc_slidemasterpage.png index ad7de95a95d2..765a1499833f 100644 Binary files a/icon-themes/breeze_dark/cmd/lc_slidemasterpage.png and b/icon-themes/breeze_dark/cmd/lc_slidemasterpage.png differ diff --git a/icon-themes/breeze_dark/cmd/sc_closedoc.png b/icon-themes/breeze_dark/cmd/sc_closedoc.png index
[Libreoffice-commits] core.git: icon-themes/breeze icon-themes/breeze_svg icon-themes/colibre icon-themes/colibre_svg
icon-themes/breeze/cmd/lc_closedoc.png |binary icon-themes/breeze/cmd/lc_closemasterview.png |binary icon-themes/breeze/cmd/lc_closepreview.png |binary icon-themes/breeze/cmd/lc_deletemasterpage.png |binary icon-themes/breeze/cmd/lc_displaymasterbackground.png |binary icon-themes/breeze/cmd/lc_displaymasterobjects.png |binary icon-themes/breeze/cmd/lc_insertmasterpage.png |binary icon-themes/breeze/cmd/lc_masterlayouts.png|binary icon-themes/breeze/cmd/lc_masterpage.png |binary icon-themes/breeze/cmd/lc_notesmasterpage.png |binary icon-themes/breeze/cmd/lc_slidemasterpage.png |binary icon-themes/breeze/cmd/sc_closedoc.png |binary icon-themes/breeze/cmd/sc_closemasterview.png |binary icon-themes/breeze/cmd/sc_closepreview.png |binary icon-themes/breeze/cmd/sc_deletemasterpage.png |binary icon-themes/breeze/cmd/sc_displaymasterbackground.png |binary icon-themes/breeze/cmd/sc_displaymasterobjects.png |binary icon-themes/breeze/cmd/sc_insertmasterpage.png |binary icon-themes/breeze/cmd/sc_masterlayouts.png|binary icon-themes/breeze/cmd/sc_notesmasterpage.png |binary icon-themes/breeze/cmd/sc_slidemasterpage.png |binary icon-themes/breeze/links.txt |8 - icon-themes/breeze_svg/cmd/lc_closedoc.svg | 12 -- icon-themes/breeze_svg/cmd/lc_closemasterview.svg |5 + icon-themes/breeze_svg/cmd/lc_closepreview.svg | 10 ++ icon-themes/breeze_svg/cmd/lc_displaymasterbackground.svg | 10 ++ icon-themes/breeze_svg/cmd/lc_displaymasterobjects.svg | 10 ++ icon-themes/breeze_svg/cmd/lc_masterlayouts.svg|6 + icon-themes/breeze_svg/cmd/lc_masterpage.svg |6 + icon-themes/breeze_svg/cmd/sc_closedoc.svg | 12 -- icon-themes/breeze_svg/cmd/sc_closemasterview.svg |5 + icon-themes/breeze_svg/cmd/sc_closepreview.svg | 10 ++ icon-themes/breeze_svg/cmd/sc_displaymasterbackground.svg | 10 ++ icon-themes/breeze_svg/cmd/sc_displaymasterobjects.svg | 10 ++ icon-themes/colibre/cmd/lc_closedoc.png|binary icon-themes/colibre/cmd/lc_closemasterview.png |binary icon-themes/colibre/cmd/lc_closepreview.png|binary icon-themes/colibre/cmd/lc_deletemasterpage.png|binary icon-themes/colibre/cmd/lc_displaymasterbackground.png |binary icon-themes/colibre/cmd/lc_displaymasterobjects.png|binary icon-themes/colibre/cmd/lc_insertmasterpage.png|binary icon-themes/colibre/cmd/lc_masterlayouts.png |binary icon-themes/colibre/cmd/lc_masterpage.png |binary icon-themes/colibre/cmd/lc_notesmasterpage.png |binary icon-themes/colibre/cmd/lc_quit.png|binary icon-themes/colibre/cmd/lc_slidemasterpage.png |binary icon-themes/colibre/cmd/sc_closedoc.png|binary icon-themes/colibre/cmd/sc_closemasterview.png |binary icon-themes/colibre/cmd/sc_closepreview.png|binary icon-themes/colibre/cmd/sc_deletemasterpage.png|binary icon-themes/colibre/cmd/sc_displaymasterbackground.png |binary icon-themes/colibre/cmd/sc_displaymasterobjects.png|binary icon-themes/colibre/cmd/sc_insertmasterpage.png|binary icon-themes/colibre/cmd/sc_masterlayouts.png |binary icon-themes/colibre/cmd/sc_notesmasterpage.png |binary icon-themes/colibre/cmd/sc_quit.png|binary icon-themes/colibre/cmd/sc_slidemasterpage.png |binary icon-themes/colibre/links.txt |8 - icon-themes/colibre_svg/cmd/lc_closedoc.svg| 23 + icon-themes/colibre_svg/cmd/lc_closemasterview.svg | 22 + icon-themes/colibre_svg/cmd/lc_closepreview.svg| 10 ++ icon-themes/colibre_svg/cmd/lc_deletemasterpage.svg| 19 icon-themes/colibre_svg/cmd/lc_displaymasterbackground.svg | 16 +-- icon-themes/colibre_svg/cmd/lc_displaymasterobjects.svg| 29 +++--- icon-themes/colibre_svg/cmd/lc_insertmasterpage.svg| 19 icon-themes/colibre_svg/cmd/lc_masterlayouts.svg | 19 icon-themes/colibre_svg/cmd/lc_masterpage.svg | 14 +++ icon-themes/colibre_svg/cmd/lc_notesmasterpage.svg | 23 + icon-themes/colibre_svg/cmd/lc_quit.svg| 11 ++ icon-themes/colibre_svg/cmd/lc_slidemasterpage.svg | 25 + icon-themes/colibre_svg/cmd/sc_closedoc.svg| 19 icon-themes/colibre_svg/cmd/sc_closemasterview.svg | 24 +
[Libreoffice-bugs] [Bug 118879] Flat ODF document embed linked image
https://bugs.documentfoundation.org/show_bug.cgi?id=118879 Arnaud Versini changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||2371 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122371] Unable to remove links to external images
https://bugs.documentfoundation.org/show_bug.cgi?id=122371 Arnaud Versini changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||8879 Keywords||regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Contribuciones
Todas mis contribuciones pasadas y futuras a LibreOffice pueden ser licenciado bajo la licencia dual MPLv2 / LGPLv3 +. Antonio Guzmán Simón Mov.: 605 21 48 96 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf120511_eatenSection.docx |binary sw/qa/extras/ooxmlexport/ooxmlexport11.cxx| 11 +++ writerfilter/source/dmapper/DomainMapper.cxx |1 + writerfilter/source/dmapper/DomainMapper_Impl.hxx |3 +++ 4 files changed, 15 insertions(+) New commits: commit 6aeba04b31cc33135f84bd7ea38a04ee9faa14ec Author: Justin Luth AuthorDate: Sat Dec 29 18:50:18 2018 +0300 Commit: Justin Luth CommitDate: Sat Dec 29 19:25:58 2018 +0100 tdf#120511 writerfilter: track inserted frame per section The logic using IsTextFrameInserted is worried about whether a frame has been inserted before a table *in this section*, so track frame's existence per section, not per document. Change-Id: I8aa8a695b89727832e65535adae3fc3c94f95be5 Reviewed-on: https://gerrit.libreoffice.org/65720 Tested-by: Jenkins Reviewed-by: Justin Luth diff --git a/sw/qa/extras/ooxmlexport/data/tdf120511_eatenSection.docx b/sw/qa/extras/ooxmlexport/data/tdf120511_eatenSection.docx new file mode 100644 index ..6a6d6f17bae7 Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf120511_eatenSection.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx index 6659f9a4..4b0d7bd8d1d7 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx @@ -462,6 +462,17 @@ DECLARE_OOXMLEXPORT_TEST(testTdf113258_noBeforeAutospacing, "tdf113258_noBeforeA getProperty(xShape->getStart(), "ParaTopMargin")); } +DECLARE_OOXMLEXPORT_TEST(testTdf120511_eatenSection, "tdf120511_eatenSection.docx") +{ +xmlDocPtr pXmlDoc = parseLayoutDump(); +sal_Int32 nHeight = getXPath(pXmlDoc, "/root/page[1]/infos/prtBounds", "height").toInt32(); +sal_Int32 nWidth = getXPath(pXmlDoc, "/root/page[1]/infos/prtBounds", "width").toInt32(); +CPPUNIT_ASSERT_MESSAGE( "Page1 is portrait", nWidth < nHeight ); +nHeight = getXPath(pXmlDoc, "/root/page[2]/infos/prtBounds", "height").toInt32(); +nWidth = getXPath(pXmlDoc, "/root/page[2]/infos/prtBounds", "width").toInt32(); +CPPUNIT_ASSERT_MESSAGE( "Page2 is landscape", nWidth > nHeight ); +} + DECLARE_OOXMLEXPORT_TEST(testTdf104354, "tdf104354.docx") { uno::Reference xShape(getShape(1), uno::UNO_QUERY); diff --git a/writerfilter/source/dmapper/DomainMapper.cxx b/writerfilter/source/dmapper/DomainMapper.cxx index aa3588cde860..5affdd4d5703 100644 --- a/writerfilter/source/dmapper/DomainMapper.cxx +++ b/writerfilter/source/dmapper/DomainMapper.cxx @@ -2882,6 +2882,7 @@ void DomainMapper::lcl_endSectionGroup() if (m_pImpl->GetIsDummyParaAddedForTableInSection()) m_pImpl->RemoveDummyParaForTableInSection(); } +m_pImpl->SetIsTextFrameInserted( false ); m_pImpl->PopProperties(CONTEXT_SECTION); } } diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.hxx b/writerfilter/source/dmapper/DomainMapper_Impl.hxx index 89deb65f1b56..c20912dabdd5 100644 --- a/writerfilter/source/dmapper/DomainMapper_Impl.hxx +++ b/writerfilter/source/dmapper/DomainMapper_Impl.hxx @@ -604,8 +604,11 @@ public: bool GetIsFirstParagraphInShape() { return m_bIsFirstParaInShape; } void SetIsDummyParaAddedForTableInSection( bool bIsAdded ); bool GetIsDummyParaAddedForTableInSection() { return m_bDummyParaAddedForTableInSection;} + +/// Track if a textframe has been inserted into this section void SetIsTextFrameInserted( bool bIsInserted ); bool GetIsTextFrameInserted() { return m_bTextFrameInserted;} + void SetIsPreviousParagraphFramed( bool bIsFramed ) { m_bIsPreviousParagraphFramed = bIsFramed; } bool GetIsPreviousParagraphFramed() { return m_bIsPreviousParagraphFramed; } void SetParaSectpr(bool bParaSectpr); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 122371] Unable to remove links to external images
https://bugs.documentfoundation.org/show_bug.cgi?id=122371 --- Comment #1 from Arnaud Versini --- Of course I inverted expected results and actual results and should be : Actual Results: The image is linked to the document Expected Results: The image should be inside the document -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103580] UI - Enabling OpenCL in Options-OpenCL has no effect on OSX
https://bugs.documentfoundation.org/show_bug.cgi?id=103580 --- Comment #10 from Frank Fuchs --- The bug is still present in LibO 6.1.4.2 on Mac running macOS 10.14.2. Sad :-( -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122372] Artefact/incorrect background with LibreOffice icons on Windows with HiDPI configurations
https://bugs.documentfoundation.org/show_bug.cgi?id=122372 --- Comment #2 from William Gathoye --- Comment we had in French with an user on Twitter experiencing the same issue: https://twitter.com/tom_dcz/status/1073882275853623296 We are waiting to get more details about his configuration. We don't know yet whether he has an Intel or AMD CPU/GPU. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121847] IMPRESS: slide marking on side pane lost when switching to notes view
https://bugs.documentfoundation.org/show_bug.cgi?id=121847 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #3 from raal --- bisected with bibisect-43max - in the oldest version is slide marked, in the latest ("bad") version is marked first slide in the notes view. It's different then in 6.3, so I'm not sure if bibisect is correct .. This seems to have begun at the below commit. 187d6c28fce4c615df7555c033907d211c279ec2 is the first bad commit commit 187d6c28fce4c615df7555c033907d211c279ec2 Author: Matthew Francis Date: Thu May 28 19:28:39 2015 +0800 source-hash-ad0c4bf5790546242884da0c2ec281f2db9e14a0 commit ad0c4bf5790546242884da0c2ec281f2db9e14a0 Author: Andre Fischer AuthorDate: Fri Feb 21 11:55:33 2014 + Commit: Caolán McNamara CommitDate: Fri Feb 21 15:30:24 2014 + Related: #i123197# Fixed selection problems when switching... between normal and master mode. (cherry picked from commit 163d414311b0c8bcb1b0ad7c7cbf364e0ad4e4c4) Change-Id: Ibabee4c67367c367a9ce1c5afffa76efa3f66bd7 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: basctl/source
basctl/source/basicide/moduldl2.cxx | 546 +--- 1 file changed, 272 insertions(+), 274 deletions(-) New commits: commit c5ab681957283c6624a2380d994f556b0676757d Author: Noel Grandin AuthorDate: Sat Dec 29 12:24:55 2018 +0200 Commit: Noel Grandin CommitDate: Sat Dec 29 18:15:53 2018 +0100 flatten LibPage::InsertLib Change-Id: Ib71c160d3375cb94232894e6bdb1a37132aff3be Reviewed-on: https://gerrit.libreoffice.org/65706 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/basctl/source/basicide/moduldl2.cxx b/basctl/source/basicide/moduldl2.cxx index 764c0507ae66..c7cf1527007b 100644 --- a/basctl/source/basicide/moduldl2.cxx +++ b/basctl/source/basicide/moduldl2.cxx @@ -744,329 +744,327 @@ void LibPage::InsertLib() else xFP->setCurrentFilter( IDEResId(RID_STR_BASIC) ); -if ( xFP->execute() == RET_OK ) +if ( xFP->execute() != RET_OK ) +return; + +GetExtraData()->SetAddLibPath( xFP->getDisplayDirectory() ); +GetExtraData()->SetAddLibFilter( xFP->getCurrentFilter() ); + +// library containers for import +Reference< script::XLibraryContainer2 > xModLibContImport; +Reference< script::XLibraryContainer2 > xDlgLibContImport; + +// file URLs +Sequence< OUString > aFiles = xFP->getSelectedFiles(); +INetURLObject aURLObj( aFiles[0] ); +INetURLObject aModURLObj( aURLObj ); +INetURLObject aDlgURLObj( aURLObj ); + +OUString aBase = aURLObj.getBase(); +OUString aModBase( "script" ); +OUString aDlgBase( "dialog" ); + +if ( aBase == aModBase || aBase == aDlgBase ) { -GetExtraData()->SetAddLibPath( xFP->getDisplayDirectory() ); -GetExtraData()->SetAddLibFilter( xFP->getCurrentFilter() ); +aModURLObj.setBase( aModBase ); +aDlgURLObj.setBase( aDlgBase ); +} -// library containers for import -Reference< script::XLibraryContainer2 > xModLibContImport; -Reference< script::XLibraryContainer2 > xDlgLibContImport; +Reference< XSimpleFileAccess3 > xSFA( SimpleFileAccess::create(comphelper::getProcessComponentContext()) ); -// file URLs -Sequence< OUString > aFiles = xFP->getSelectedFiles(); -INetURLObject aURLObj( aFiles[0] ); -INetURLObject aModURLObj( aURLObj ); -INetURLObject aDlgURLObj( aURLObj ); +OUString aModURL( aModURLObj.GetMainURL( INetURLObject::DecodeMechanism::NONE ) ); +if ( xSFA->exists( aModURL ) ) +{ +xModLibContImport.set( script::DocumentScriptLibraryContainer::createWithURL(xContext, aModURL), UNO_QUERY ); +} -OUString aBase = aURLObj.getBase(); -OUString aModBase( "script" ); -OUString aDlgBase( "dialog" ); +OUString aDlgURL( aDlgURLObj.GetMainURL( INetURLObject::DecodeMechanism::NONE ) ); +if ( xSFA->exists( aDlgURL ) ) +{ +xDlgLibContImport.set( script::DocumentDialogLibraryContainer::createWithURL(xContext, aDlgURL), UNO_QUERY ); +} -if ( aBase == aModBase || aBase == aDlgBase ) -{ -aModURLObj.setBase( aModBase ); -aDlgURLObj.setBase( aDlgBase ); -} +if ( !xModLibContImport.is() && !xDlgLibContImport.is() ) +return; -Reference< XSimpleFileAccess3 > xSFA( SimpleFileAccess::create(comphelper::getProcessComponentContext()) ); +VclPtr pLibDlg; -OUString aModURL( aModURLObj.GetMainURL( INetURLObject::DecodeMechanism::NONE ) ); -if ( xSFA->exists( aModURL ) ) +Reference< script::XLibraryContainer > xModLibContImp( xModLibContImport, UNO_QUERY ); +Reference< script::XLibraryContainer > xDlgLibContImp( xDlgLibContImport, UNO_QUERY ); +Sequence< OUString > aLibNames = GetMergedLibraryNames( xModLibContImp, xDlgLibContImp ); +sal_Int32 nLibCount = aLibNames.getLength(); +const OUString* pLibNames = aLibNames.getConstArray(); +for ( sal_Int32 i = 0 ; i < nLibCount ; i++ ) +{ +// library import dialog +if ( !pLibDlg ) { -xModLibContImport.set( script::DocumentScriptLibraryContainer::createWithURL(xContext, aModURL), UNO_QUERY ); +pLibDlg.reset(VclPtr::Create( this )); +pLibDlg->SetStorageName( aURLObj.getName() ); +pLibDlg->GetLibBox().SetMode(ObjectMode::Library); } -OUString aDlgURL( aDlgURLObj.GetMainURL( INetURLObject::DecodeMechanism::NONE ) ); -if ( xSFA->exists( aDlgURL ) ) +// libbox entries +OUString aLibName( pLibNames[ i ] ); +if ( !( ( xModLibContImport.is() && xModLibContImport->hasByName( aLibName ) && xModLibContImport->isLibraryLink( aLibName ) ) || +( xDlgLibContImport.is() && xDlgLibContImport->hasByName( aLibName ) && xDlgLibContImport->isLibraryLink( aLibName ) ) ) ) { -xDlgLibContImport.set( script::DocumentDialogLibraryContainer::createWithURL(xContext,
[Libreoffice-bugs] [Bug 120942] Calc crashes when copying multiple rows, if Ditto app is running
https://bugs.documentfoundation.org/show_bug.cgi?id=120942 --- Comment #5 from Steve Magruder --- I have to mostly retract my last comment. I'm still getting the system hangs when selecting a number of rows or columns and doing Ctrl-C when Ditto is running, although the hangs eventually work themselves out and I don't have to reboot. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122372] Artefact/incorrect background with LibreOffice icons on Windows with HiDPI configurations
https://bugs.documentfoundation.org/show_bug.cgi?id=122372 William Gathoye changed: What|Removed |Added Summary|LibreOffice icons are weird |Artefact/incorrect |using |background with LibreOffice ||icons on Windows with HiDPI ||configurations -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs