[Libreoffice-commits] core.git: 2 commits - sw/inc sw/source
sw/inc/ndarr.hxx |2 -
sw/source/core/docnode/ndtbl.cxx |7 ++---
sw/source/core/unocore/unosett.cxx | 44 ++---
sw/source/core/unocore/unotext.cxx |6 ++---
4 files changed, 24 insertions(+), 35 deletions(-)
New commits:
commit a41b1d18ad26703f6a5b622f10e1126570bfd419
Author: Noel Grandin
AuthorDate: Thu Jan 10 16:58:45 2019 +0200
Commit: Noel Grandin
CommitDate: Fri Jan 11 08:44:23 2019 +0100
use unique_ptr in SwNodes::ExpandRangeForTableBox
Change-Id: I31cc9d6b962c116c64789d886b82ea476f4e5144
Reviewed-on: https://gerrit.libreoffice.org/66124
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/inc/ndarr.hxx b/sw/inc/ndarr.hxx
index 598397c43cf6..6153af0ad012 100644
--- a/sw/inc/ndarr.hxx
+++ b/sw/inc/ndarr.hxx
@@ -258,7 +258,7 @@ public:
SwTextFormatColl* pTextColl,
SwUndoTextToTable* pUndo );
-SwNodeRange * ExpandRangeForTableBox(const SwNodeRange & rRange);
+std::unique_ptr ExpandRangeForTableBox(const SwNodeRange &
rRange);
/// create a table from a vector of NodeRanges - API support
SwTableNode* TextToTable( const TableRanges_t& rTableNodes,
diff --git a/sw/source/core/docnode/ndtbl.cxx b/sw/source/core/docnode/ndtbl.cxx
index 47246bd18a69..6a173ffab31d 100644
--- a/sw/source/core/docnode/ndtbl.cxx
+++ b/sw/source/core/docnode/ndtbl.cxx
@@ -1279,9 +1279,8 @@ const SwTable* SwDoc::TextToTable( const std::vector<
std::vector >
return
}
-SwNodeRange * SwNodes::ExpandRangeForTableBox(const SwNodeRange & rRange)
+std::unique_ptr SwNodes::ExpandRangeForTableBox(const SwNodeRange
& rRange)
{
-SwNodeRange * pResult = nullptr;
bool bChanged = false;
SwNodeIndex aNewStart = rRange.aStart;
@@ -1335,9 +1334,9 @@ SwNodeRange * SwNodes::ExpandRangeForTableBox(const
SwNodeRange & rRange)
pNode = ();
}
+std::unique_ptr pResult;
if (bChanged)
-pResult = new SwNodeRange(aNewStart, aNewEnd);
-
+pResult.reset(new SwNodeRange(aNewStart, aNewEnd));
return pResult;
}
diff --git a/sw/source/core/unocore/unotext.cxx
b/sw/source/core/unocore/unotext.cxx
index 68d78213fb48..944851a47f2d 100644
--- a/sw/source/core/unocore/unotext.cxx
+++ b/sw/source/core/unocore/unotext.cxx
@@ -1835,10 +1835,10 @@ void SwXText::Impl::ConvertCell(
SwNodeRange aTmpRange(aStartCellPam.Start()->nNode,
aEndCellPam.End()->nNode);
-SwNodeRange * pCorrectedRange =
+std::unique_ptr pCorrectedRange =
m_pDoc->GetNodes().ExpandRangeForTableBox(aTmpRange);
-if (pCorrectedRange != nullptr)
+if (pCorrectedRange)
{
SwPaM aNewStartPaM(pCorrectedRange->aStart, 0);
aStartCellPam = aNewStartPaM;
@@ -1851,7 +1851,7 @@ void SwXText::Impl::ConvertCell(
SwPaM aNewEndPaM(pCorrectedRange->aEnd, nEndLen);
aEndCellPam = aNewEndPaM;
-delete pCorrectedRange;
+pCorrectedRange.reset();
}
/** check the nodes between start and end
commit c7d5ad9dbfc7ada52a3ec8c38fa8420a08b126c3
Author: Noel Grandin
AuthorDate: Thu Jan 10 16:52:25 2019 +0200
Commit: Noel Grandin
CommitDate: Fri Jan 11 08:44:15 2019 +0100
use unique_ptr in SwXNumberingRules
Change-Id: I7daa1fbd11c62d712b2ff70714b5e5bda63d54d8
Reviewed-on: https://gerrit.libreoffice.org/66123
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/core/unocore/unosett.cxx
b/sw/source/core/unocore/unosett.cxx
index 4a82db8bd944..d3b949b2a973 100644
--- a/sw/source/core/unocore/unosett.cxx
+++ b/sw/source/core/unocore/unosett.cxx
@@ -1610,9 +1610,9 @@ void SwXNumberingRules::SetPropertiesToNumFormat(
bool bWrongArg = false;
if(!bExcept)
- {
-SvxBrushItem* pSetBrush = nullptr;
-Size* pSetSize = nullptr;
+{
+std::unique_ptr pSetBrush;
+std::unique_ptr pSetSize;
std::unique_ptr pSetVOrient;
bool bCharStyleNameSet = false;
@@ -1922,11 +1922,9 @@ void SwXNumberingRules::SetPropertiesToNumFormat(
{
const SvxBrushItem* pOrigBrush =
aFormat.GetBrush();
if(pOrigBrush)
-{
-pSetBrush = new SvxBrushItem(*pOrigBrush);
-}
+pSetBrush.reset(new SvxBrushItem(*pOrigBrush));
else
-pSetBrush = new SvxBrushItem(OUString(),
OUString(), GPOS_AREA, RES_BACKGROUND);
+pSetBrush.reset(new SvxBrushItem(OUString(),
OUString(), GPOS_AREA, RES_BACKGROUND));
}
Graphic aGraphic(xGraphic);
pSetBrush->SetGraphic(aGraphic);
@@ -1945,11 +1943,9 @@ void
[Libreoffice-commits] core.git: sw/source
sw/source/core/view/viewsh.cxx |7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
New commits:
commit 1e3442983b44ad6042cb687dbb77bf174796a255
Author: Noel Grandin
AuthorDate: Thu Jan 10 17:03:26 2019 +0200
Commit: Noel Grandin
CommitDate: Fri Jan 11 08:44:34 2019 +0100
use unique_ptr in SwViewShell::ImplEndAction
Change-Id: I9be790996347e191df63198de109acf973104d0d
Reviewed-on: https://gerrit.libreoffice.org/66125
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx
index 77ccf51f2cd4..96fd2a7308fe 100644
--- a/sw/source/core/view/viewsh.cxx
+++ b/sw/source/core/view/viewsh.cxx
@@ -320,7 +320,7 @@ void SwViewShell::ImplEndAction( const bool bIdleEnd )
}
mbPaintWorks = true;
-SwRegionRects *pRegion = Imp()->GetRegion();
+std::unique_ptr pRegion =
std::move(Imp()->m_pRegion);
//JP 27.11.97: what hid the selection, must also Show it,
// else we get Paint errors!
@@ -335,8 +335,6 @@ void SwViewShell::ImplEndAction( const bool bIdleEnd )
{
SwRootFrame* pCurrentLayout = GetLayout();
-(void) Imp()->m_pRegion.release(); // pRegion owns it now
-
//First Invert then Compress, never the other way round!
pRegion->Invert();
@@ -435,9 +433,6 @@ void SwViewShell::ImplEndAction( const bool bIdleEnd )
else
lcl_PaintTransparentFormControls(*this, aRect); //
i#107365
}
-
-delete pRegion;
-Imp()->DelRegion();
}
if( bShowCursor )
static_cast(this)->ShowCursors( true );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/undo/unsect.cxx | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
New commits:
commit 9fd69aba34f9818ac760f5704e007b92679d65b1
Author: Noel Grandin
AuthorDate: Thu Jan 10 16:36:08 2019 +0200
Commit: Noel Grandin
CommitDate: Fri Jan 11 08:41:26 2019 +0100
use unique_ptr in SwUndoDelSection
Change-Id: I2637872300c60f880e32b00f5f545f6145b563bf
Reviewed-on: https://gerrit.libreoffice.org/66120
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/core/undo/unsect.cxx b/sw/source/core/undo/unsect.cxx
index 1a40d6c5b424..d10680ab9f97 100644
--- a/sw/source/core/undo/unsect.cxx
+++ b/sw/source/core/undo/unsect.cxx
@@ -42,12 +42,12 @@
#include
#include
-static SfxItemSet* lcl_GetAttrSet( const SwSection& rSect )
+static std::unique_ptr lcl_GetAttrSet( const SwSection& rSect )
{
// save attributes of the format (columns, color, ...)
// Content and Protect items are not interesting since they are already
// stored in Section, thus delete them.
-SfxItemSet* pAttr = nullptr;
+std::unique_ptr pAttr;
if( rSect.GetFormat() )
{
sal_uInt16 nCnt = 1;
@@ -56,13 +56,12 @@ static SfxItemSet* lcl_GetAttrSet( const SwSection& rSect )
if( nCnt < rSect.GetFormat()->GetAttrSet().Count() )
{
-pAttr = new SfxItemSet( rSect.GetFormat()->GetAttrSet() );
+pAttr.reset(new SfxItemSet( rSect.GetFormat()->GetAttrSet() ));
pAttr->ClearItem( RES_PROTECT );
pAttr->ClearItem( RES_CNTNT );
if( !pAttr->Count() )
{
-delete pAttr;
-pAttr = nullptr;
+pAttr.reset();
}
}
}
@@ -424,7 +423,7 @@ void SwUndoUpdateSection::UndoImpl(::sw::UndoRedoContext &
rContext)
SwSection& rNdSect = pSectNd->GetSection();
SwFormat* pFormat = rNdSect.GetFormat();
-SfxItemSet* pCur = ::lcl_GetAttrSet( rNdSect );
+std::unique_ptr pCur = ::lcl_GetAttrSet( rNdSect );
if (m_pAttrSet)
{
// The Content and Protect items must persist
@@ -445,7 +444,7 @@ void SwUndoUpdateSection::UndoImpl(::sw::UndoRedoContext &
rContext)
pFormat->ResetFormatAttr( RES_HEADER, RES_OPAQUE );
pFormat->ResetFormatAttr( RES_SURROUND, RES_FRMATR_END-1 );
}
-m_pAttrSet.reset(pCur);
+m_pAttrSet = std::move(pCur);
if (!m_bOnlyAttrChanged)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - sw/source
sw/source/core/inc/UndoSort.hxx |2 --
sw/source/core/undo/unsort.cxx | 24 ++--
sw/source/core/unocore/unoframe.cxx | 11 ---
3 files changed, 14 insertions(+), 23 deletions(-)
New commits:
commit 77e62790800f912f557613d98273555292b002d6
Author: Noel Grandin
AuthorDate: Thu Jan 10 16:52:17 2019 +0200
Commit: Noel Grandin
CommitDate: Fri Jan 11 08:41:58 2019 +0100
use unique_ptr in SwXFrame
Change-Id: I3671bf7ab7913a2f07eec347c1e07d036bfca4c4
Reviewed-on: https://gerrit.libreoffice.org/66122
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/core/unocore/unoframe.cxx
b/sw/source/core/unocore/unoframe.cxx
index d63bd91847b1..18da4371bc2c 100644
--- a/sw/source/core/unocore/unoframe.cxx
+++ b/sw/source/core/unocore/unoframe.cxx
@@ -1548,7 +1548,7 @@ void SwXFrame::setPropertyValue(const OUString&
rPropertyName, const ::uno::Any&
UnoActionContext aAction(pFormat->GetDoc());
-SfxItemSet* pSet = nullptr;
+std::unique_ptr pSet;
// #i31771#, #i25798# - No adjustment of
// anchor ( no call of method ),
// if document is currently in reading mode.
@@ -1563,21 +1563,18 @@ void SwXFrame::setPropertyValue(const OUString&
rPropertyName, const ::uno::Any&
const ::SfxPoolItem* pItem;
if( SfxItemState::SET == pFrameFormat->GetItemState(
RES_ANCHOR, false, ))
{
-pSet = new SfxItemSet( pDoc->GetAttrPool(),
aFrameFormatSetRange );
+pSet.reset(new SfxItemSet( pDoc->GetAttrPool(),
aFrameFormatSetRange ));
pSet->Put( *pItem );
if ( pFormat->GetDoc()->GetEditShell() != nullptr
&& !sw_ChkAndSetNewAnchor( *pFly, *pSet ) )
{
-delete pSet;
-pSet = nullptr;
+pSet.reset();
}
}
}
}
-pFormat->GetDoc()->SetFrameFormatToFly( *pFormat, *pFrameFormat,
pSet );
-delete pSet;
-
+pFormat->GetDoc()->SetFrameFormatToFly( *pFormat, *pFrameFormat,
pSet.get() );
}
else if (FN_UNO_GRAPHIC_FILTER == pEntry->nWID)
{
commit 9e2ca20b0514cc77102c9985ad72f242c0af910e
Author: Noel Grandin
AuthorDate: Thu Jan 10 16:43:53 2019 +0200
Commit: Noel Grandin
CommitDate: Fri Jan 11 08:41:44 2019 +0100
no need to allocate on heap in SwUndoSortList
Change-Id: I949a9d32b18d5ccae17dee26f030173307d0b3fb
Reviewed-on: https://gerrit.libreoffice.org/66121
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/core/inc/UndoSort.hxx b/sw/source/core/inc/UndoSort.hxx
index 167aaa4ef625..27f97ceaf995 100644
--- a/sw/source/core/inc/UndoSort.hxx
+++ b/sw/source/core/inc/UndoSort.hxx
@@ -57,8 +57,6 @@ struct SwSortUndoElement
~SwSortUndoElement();
};
-typedef std::vector SwUndoSortList;
-
class SwUndoSort : public SwUndo, private SwUndRng
{
std::unique_ptrpSortOpt;
diff --git a/sw/source/core/undo/unsort.cxx b/sw/source/core/undo/unsort.cxx
index ac354d889be4..b20d4e5b94a2 100644
--- a/sw/source/core/undo/unsort.cxx
+++ b/sw/source/core/undo/unsort.cxx
@@ -121,7 +121,8 @@ void SwUndoSort::UndoImpl(::sw::UndoRedoContext & rContext)
// create index for (sorted) positions
// The IndexList must be created based on (asc.) sorted SourcePosition.
-SwUndoSortList aIdxList;
+std::vector aIdxList;
+aIdxList.reserve(m_SortList.size());
for (size_t i = 0; i < m_SortList.size(); ++i)
{
@@ -129,9 +130,8 @@ void SwUndoSort::UndoImpl(::sw::UndoRedoContext & rContext)
{
if (j->SORT_TXT_TBL.TXT.nSource == nSttNode + i)
{
-SwNodeIndex* pIdx = new SwNodeIndex( rDoc.GetNodes(),
-j->SORT_TXT_TBL.TXT.nTarget );
-aIdxList.insert( aIdxList.begin() + i, pIdx );
+aIdxList.push_back( SwNodeIndex( rDoc.GetNodes(),
+j->SORT_TXT_TBL.TXT.nTarget ) );
break;
}
}
@@ -140,13 +140,11 @@ void SwUndoSort::UndoImpl(::sw::UndoRedoContext &
rContext)
for (size_t i = 0; i < m_SortList.size(); ++i)
{
SwNodeIndex aIdx( rDoc.GetNodes(), nSttNode + i );
-SwNodeRange aRg( *aIdxList[i], 0, *aIdxList[i], 1 );
+SwNodeRange aRg( aIdxList[i], 0, aIdxList[i], 1 );
rDoc.getIDocumentContentOperations().MoveNodeRange(aRg, aIdx,
SwMoveFlags::DEFAULT);
}
// delete indices
-for(auto& rpIdx : aIdxList)
-delete rpIdx;
[Libreoffice-commits] core.git: sw/source
sw/source/core/layout/frmtool.cxx | 16
sw/source/core/layout/laycache.cxx |2 +-
sw/source/core/layout/layhelp.hxx |4 ++--
3 files changed, 11 insertions(+), 11 deletions(-)
New commits:
commit 3c7b2b7279bc5d4fd72ae0b1d1fc50812792ed08
Author: Noel Grandin
AuthorDate: Wed Jan 9 15:27:34 2019 +0200
Commit: Noel Grandin
CommitDate: Fri Jan 11 08:40:26 2019 +0100
use unique_ptr in SwLayHelper
Change-Id: I6b7ee99bb38df882853e3695cd03dcc745c92318
Reviewed-on: https://gerrit.libreoffice.org/66035
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/core/layout/frmtool.cxx
b/sw/source/core/layout/frmtool.cxx
index 429a1066044a..f086f7cc3cf8 100644
--- a/sw/source/core/layout/frmtool.cxx
+++ b/sw/source/core/layout/frmtool.cxx
@@ -1345,7 +1345,7 @@ void InsertCnt_( SwLayoutFrame *pLay, SwDoc *pDoc,
SwPageFrame *pPage = pLay->FindPageFrame();
const SwFrameFormats *pTable = pDoc->GetSpzFrameFormats();
SwFrame *pFrame = nullptr;
-SwActualSection *pActualSection = nullptr;
+std::unique_ptr pActualSection;
SwLayHelper *pPageMaker;
//If the layout will be created (bPages == true) we do head on the progress
@@ -1383,7 +1383,7 @@ void InsertCnt_( SwLayoutFrame *pLay, SwDoc *pDoc,
if( ( !pLay->IsInFootnote() || pSct->IsInFootnote() ) &&
( !pLay->IsInTab() || pSct->IsInTab() ) )
{
-pActualSection = new SwActualSection( nullptr, pSct, nullptr );
+pActualSection.reset(new SwActualSection( nullptr, pSct, nullptr
));
OSL_ENSURE( !pLay->Lower() || !pLay->Lower()->IsColumnFrame(),
"InsertCnt_: Wrong Call" );
}
@@ -1548,8 +1548,8 @@ void InsertCnt_( SwLayoutFrame *pLay, SwDoc *pDoc,
else
{
pFrame = pNode->MakeFrame( pLay );
-pActualSection = new SwActualSection( pActualSection,
-
static_cast(pFrame), pNode );
+pActualSection.reset( new SwActualSection(
pActualSection.release(),
+
static_cast(pFrame), pNode ) );
if ( pActualSection->GetUpper() )
{
//Insert behind the Upper, the "Follow" of the Upper will
be
@@ -1638,10 +1638,10 @@ void InsertCnt_( SwLayoutFrame *pLay, SwDoc *pDoc,
//Close the section, where appropriate activate the surrounding
//section again.
-SwActualSection *pTmp = pActualSection ?
pActualSection->GetUpper() : nullptr;
-delete pActualSection;
+SwActualSection *pActualSectionUpper1 = pActualSection ?
pActualSection->GetUpper() : nullptr;
+pActualSection.reset(pActualSectionUpper1);
pLay = pLay->FindSctFrame();
-if ( nullptr != (pActualSection = pTmp) )
+if ( pActualSection )
{
//Could be, that the last SectionFrame remains empty.
//Then now is the time to remove them.
@@ -1734,7 +1734,7 @@ void InsertCnt_( SwLayoutFrame *pLay, SwDoc *pDoc,
pLay->RemoveFromLayout();
SwFrame::DestroyFrame(pLay);
}
-delete pActualSection;
+pActualSection.reset();
}
if ( bPages ) // let the Flys connect to each other
diff --git a/sw/source/core/layout/laycache.cxx
b/sw/source/core/layout/laycache.cxx
index 014a9fc82ecb..99e0c83bf184 100644
--- a/sw/source/core/layout/laycache.cxx
+++ b/sw/source/core/layout/laycache.cxx
@@ -515,7 +515,7 @@ bool sanityCheckLayoutCache(SwLayCacheImpl const& rCache,
* a guess, but a guess with statistical background.
*/
SwLayHelper::SwLayHelper( SwDoc *pD, SwFrame* , SwFrame* ,
SwPageFrame* ,
- SwLayoutFrame* , SwActualSection* ,
+ SwLayoutFrame* ,
std::unique_ptr ,
sal_uLong nNodeIndex, bool bCache )
: mrpFrame( rpF )
, mrpPrv( rpP )
diff --git a/sw/source/core/layout/layhelp.hxx
b/sw/source/core/layout/layhelp.hxx
index 87b832321d98..c05223112afa 100644
--- a/sw/source/core/layout/layhelp.hxx
+++ b/sw/source/core/layout/layhelp.hxx
@@ -103,7 +103,7 @@ class SwLayHelper
SwFrame*
SwPageFrame*
SwLayoutFrame*
-SwActualSection*
+std::unique_ptr
bool mbBreakAfter;
SwDoc* mpDoc;
SwLayCacheImpl* mpImpl;
@@ -116,7 +116,7 @@ class SwLayHelper
void CheckFlyCache_( SwPageFrame* pPage );
public:
SwLayHelper( SwDoc *pD, SwFrame* , SwFrame* , SwPageFrame* ,
-SwLayoutFrame* , SwActualSection* ,
+SwLayoutFrame* , std::unique_ptr ,
sal_uLong nNodeIndex, bool bCache );
~SwLayHelper();
sal_uLong CalcPageCount();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
[Libreoffice-bugs] [Bug 122629] Parameters set manually under Chapter Numbering..., in Numbering section at 'Paragraph style:' and applied to styles whose model is 'Heading ', are not persiste
https://bugs.documentfoundation.org/show_bug.cgi?id=122629 --- Comment #2 from Dieter Praas --- I can't confirm with Version: 6.3.0.0.alpha0+ (x64) Build ID: ffa5b8a82eab18041bbee4d6914892b82c7801d3 CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-12-19_03:24:54 Locale: en-US (de_DE); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84837] Dissertation Writing Help: Get Professional Assignment Assistance
https://bugs.documentfoundation.org/show_bug.cgi?id=84837 Ted Johnson changed: What|Removed |Added URL|http://computer-geeks.net/ |https://www.ukdissertationh ||elp.co.uk/ Summary|Make show/hide comments UNO |Dissertation Writing Help: |command work in Calc|Get Professional Assignment ||Assistance -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122645] Image/Text position messed up after save-close-open
https://bugs.documentfoundation.org/show_bug.cgi?id=122645 Dieter Praas changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||dgp-m...@gmx.de --- Comment #2 from Dieter Praas --- Document in the attachemnt has 6 pages, but I can see misplaced images. I also noticed, that they are anchored in a different way: To character. All other pictures are achored to paragraph or as character. So that might be the reson. Does it solve your problem, if you change the anchor? (I don't think, this is a bug). I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the problem is still present. Change to RESOLVED NOTABUG, if the problem went away. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122435] LibreOffice hangs when in Calc copying formula while in edit mode then leaving field with escape
https://bugs.documentfoundation.org/show_bug.cgi?id=122435 --- Comment #7 from raal --- (In reply to Maddes from comment #6) > Cannot find a nightly build for Windows 6.3.0.0.alpha0+ to test it. You can download it here: http://dev-builds.libreoffice.org/daily/master/ and choose one of windows build, for example https://dev-builds.libreoffice.org/daily/master/Win-x86@39/current/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86349] [META] Context menu bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=86349 Bug 86349 depends on bug 86605, which changed state. Bug 86605 Summary: CONTEXT MENU: Alignment entry displayed when empty https://bugs.documentfoundation.org/show_bug.cgi?id=86605 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86605] CONTEXT MENU: Alignment entry displayed when empty
https://bugs.documentfoundation.org/show_bug.cgi?id=86605 Dieter Praas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from Dieter Praas --- WORKSFORME with Version: 6.3.0.0.alpha0+ (x64) Build ID: ffa5b8a82eab18041bbee4d6914892b82c7801d3 CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-12-19_03:24:54 Locale: en-US (de_DE); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122647] Crash when mass converting documents via Java UNO Api
https://bugs.documentfoundation.org/show_bug.cgi?id=122647 Samuel Mehrbrodt (CIB) changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |s.mehrbr...@gmail.com |desktop.org | Status|UNCONFIRMED |ASSIGNED CC||s.mehrbr...@gmail.com Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122647] New: Crash when mass converting documents via Java UNO Api
https://bugs.documentfoundation.org/show_bug.cgi?id=122647 Bug ID: 122647 Summary: Crash when mass converting documents via Java UNO Api Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: s.mehrbr...@gmail.com Created attachment 148231 --> https://bugs.documentfoundation.org/attachment.cgi?id=148231=edit Backtrace See backtrace. Crash happens when converting a document ~1000 times to PDF. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: xmlsecurity/source
xmlsecurity/source/helper/documentsignaturemanager.cxx |5 +++--
xmlsecurity/source/helper/ooxmlsecexporter.cxx |4 ++--
2 files changed, 5 insertions(+), 4 deletions(-)
New commits:
commit 108d94db881626dd35fe0decb1de184f7d2fc2bd
Author: Gabor Kelemen
AuthorDate: Thu Dec 27 21:53:42 2018 +0100
Commit: Stephan Bergmann
CommitDate: Fri Jan 11 08:08:59 2019 +0100
o3tl::make_unique -> std::make_unique in xmlsecurity/
Since it is now possible to use C++14, it's time to replace
the temporary solution with the standard one
Change-Id: Ie15220b53c6687e1d4891df668b2dedeae5e4750
Reviewed-on: https://gerrit.libreoffice.org/65795
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/xmlsecurity/source/helper/documentsignaturemanager.cxx
b/xmlsecurity/source/helper/documentsignaturemanager.cxx
index 5da6459779f7..65d691052348 100644
--- a/xmlsecurity/source/helper/documentsignaturemanager.cxx
+++ b/xmlsecurity/source/helper/documentsignaturemanager.cxx
@@ -37,7 +37,6 @@
#include
#include
#include
-#include
#include
#include
@@ -46,6 +45,8 @@
#include
+#include
+
using namespace css;
using namespace css::graphic;
using namespace css::uno;
@@ -99,7 +100,7 @@ PDFSignatureHelper&
DocumentSignatureManager::getPDFSignatureHelper()
SAL_WARN_IF(!bInit, "xmlsecurity.comp", "Error initializing security
context!");
if (!mpPDFSignatureHelper)
-mpPDFSignatureHelper = o3tl::make_unique();
+mpPDFSignatureHelper = std::make_unique();
return *mpPDFSignatureHelper;
}
diff --git a/xmlsecurity/source/helper/ooxmlsecexporter.cxx
b/xmlsecurity/source/helper/ooxmlsecexporter.cxx
index 42a4df0a7792..1518b8b4e092 100644
--- a/xmlsecurity/source/helper/ooxmlsecexporter.cxx
+++ b/xmlsecurity/source/helper/ooxmlsecexporter.cxx
@@ -10,13 +10,13 @@
#include "ooxmlsecexporter.hxx"
#include
+#include
#include
#include
#include
#include
-#include
#include
#include
#include
@@ -463,7 +463,7 @@ OOXMLSecExporter::OOXMLSecExporter(const
uno::Reference&
const uno::Reference&
xRootStorage,
const
uno::Reference& xDocumentHandler,
const SignatureInformation& rInformation)
-: m_pImpl(o3tl::make_unique(xComponentContext, xRootStorage,
xDocumentHandler, rInformation))
+: m_pImpl(std::make_unique(xComponentContext, xRootStorage,
xDocumentHandler, rInformation))
{
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/tools tools/source
include/tools/urlobj.hxx |4 ++--
tools/source/fsys/urlobj.cxx |2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 4f36ea1a1ecde6c000aeb878ab46747edd16c8f0
Author: Stephan Bergmann
AuthorDate: Thu Jan 10 15:32:05 2019 +0100
Commit: Stephan Bergmann
CommitDate: Fri Jan 11 08:05:57 2019 +0100
o3tl::string_view -> std::string_view (in tools)
Change-Id: Ic3952cf0f05752813f60199b7b2c8c8e8dc27427
Reviewed-on: https://gerrit.libreoffice.org/66118
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/include/tools/urlobj.hxx b/include/tools/urlobj.hxx
index 84556aa4a609..391a629c5598 100644
--- a/include/tools/urlobj.hxx
+++ b/include/tools/urlobj.hxx
@@ -23,10 +23,10 @@
#include
#include
#include
-#include
#include
#include
+#include
class SvMemoryStream;
@@ -381,7 +381,7 @@ public:
bool isSchemeEqualTo(INetProtocol scheme) const { return scheme ==
m_eScheme; }
-bool isSchemeEqualTo(o3tl::u16string_view scheme) const;
+bool isSchemeEqualTo(std::u16string_view scheme) const;
/** Check if the scheme is one of the WebDAV scheme
* we know about.
diff --git a/tools/source/fsys/urlobj.cxx b/tools/source/fsys/urlobj.cxx
index e280a7f84abe..45bd5a0d283f 100644
--- a/tools/source/fsys/urlobj.cxx
+++ b/tools/source/fsys/urlobj.cxx
@@ -3862,7 +3862,7 @@ OUString INetURLObject::getExternalURL() const
return aTheExtURIRef;
}
-bool INetURLObject::isSchemeEqualTo(o3tl::u16string_view scheme) const {
+bool INetURLObject::isSchemeEqualTo(std::u16string_view scheme) const {
return m_aScheme.isPresent()
&& (rtl_ustr_compareIgnoreAsciiCase_WithLength(
scheme.data(), scheme.size(),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 122591] Added the function of "Set as preset pattern"
https://bugs.documentfoundation.org/show_bug.cgi?id=122591 --- Comment #8 from 和尚蟹 --- (In reply to Cor Nouws from comment #6) > is it for drawings? Same as "Word". -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113280] Comparability problems with comments when exporting right-to-left comments to doc
https://bugs.documentfoundation.org/show_bug.cgi?id=113280 waltermart changed: What|Removed |Added URL||https://gun-mayhem.co --- Comment #3 from waltermart --- nice post thanks for sharing this. www.gun-mayhem.co -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/inc
sc/inc/math.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 16d1041c604a28e0a8c1a5a5feb4d3dfb7f4e92c Author: Andrea Gelmini AuthorDate: Thu Jan 10 12:09:15 2019 + Commit: Julien Nabet CommitDate: Fri Jan 11 07:10:29 2019 +0100 Fix typo Change-Id: I1a8d3930c3e986ffa8cd23de7acfef2028bf8918 Reviewed-on: https://gerrit.libreoffice.org/66143 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/sc/inc/math.hxx b/sc/inc/math.hxx index b4a6476fb44c..80b6ed17b68b 100644 --- a/sc/inc/math.hxx +++ b/sc/inc/math.hxx @@ -68,7 +68,7 @@ inline double divide( const double& fNumerator, const double& fDenominator ) /** Return pow(fVal1,fVal2) with error handling. -If an error was detectect, a coded double error of +If an error was detected, a coded double error of FormulaError::IllegalFPOperation is returned. */ double power( const double& fVal1, const double& fVal2 ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 121149] LibreOffice crashes on startup in Kubuntu 18.04 (with malloc errors or no output)
https://bugs.documentfoundation.org/show_bug.cgi?id=121149 enanito...@gmail.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #14 from enanito...@gmail.com --- I purged 6.1, installed 6.2, tried to launch it, and the same thing happened (process exited right away) But then I rebooted and it started working :/. Could this second bug be related to a graphics card issue? (NOTE: in the original bug with the packaged version, I did reboot multiple times, and it didn't help) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113338] [META] Embedded fonts bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113338 Bug 113338 depends on bug 69060, which changed state. Bug 69060 Summary: FILEOPEN: Documents with embedded fonts take too long to open https://bugs.documentfoundation.org/show_bug.cgi?id=69060 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104816] Inserting a user field will lose the condition of section
https://bugs.documentfoundation.org/show_bug.cgi?id=104816 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=55 ||814 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl sfx2/source vcl/inc vcl/source
include/vcl/outdev.hxx |3 +++
include/vcl/svapp.hxx | 11 +++
sfx2/source/doc/objstor.cxx |4
vcl/inc/svdata.hxx |3 +++
vcl/source/app/svapp.cxx|5 +
vcl/source/outdev/font.cxx | 40 +++-
6 files changed, 65 insertions(+), 1 deletion(-)
New commits:
commit 98d71c4e0847797a4ba9229a8e6d832a8a3d5e0f
Author: Mike Kaganski
AuthorDate: Fri Jan 11 00:06:49 2019 +0300
Commit: Mike Kaganski
CommitDate: Fri Jan 11 05:38:52 2019 +0100
tdf#69060: lock refreshing font data when loading a document
This accumulates all calls to OutputDevice::ImplRefreshAllFontData
while loading document's model, to avoid multiple updates for each
imported font. After loading, OutputDevice::ImplRefreshAllFontData
is executed once.
Change-Id: I5b23a2b8a3765dee9061b6479665d04c2ba11cbf
Reviewed-on: https://gerrit.libreoffice.org/47112
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index 1d4a936e22a6..3fa9d2167d27 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -1263,6 +1263,9 @@ public:
//If bNewFontLists is true then drop and refetch lists of system fonts
SAL_DLLPRIVATE static void ImplUpdateAllFontData( bool bNewFontLists );
+// Lock font updates for all output devices
+static void LockFontUpdates(bool bLock);
+
protected:
SAL_DLLPRIVATE const LogicalFontInstance* GetFontInstance() const;
SAL_DLLPRIVATE long GetEmphasisAscent() const { return mnEmphasisAscent; }
diff --git a/include/vcl/svapp.hxx b/include/vcl/svapp.hxx
index ac1c0ddfb848..712f75a0f09d 100644
--- a/include/vcl/svapp.hxx
+++ b/include/vcl/svapp.hxx
@@ -1365,6 +1365,17 @@ public:
///@}
+/** Lock font updates for all output devices
+
+ @remark When performing operations that might involve multiple
registration of fonts, such as
+opening/closing documents with multiple embedded fonts, then each font
addition/removal
+might cause an event that initiates a rebuild of each OutputDevice's
font lists.
+
+Locking font updates disables processing such events, and unlocking
causes a single such
+processing for all OutputDevices.
+*/
+static void LockFontUpdates(bool bLock);
+
// For vclbootstrapprotector:
static void setDeInitHook(Link const & hook);
diff --git a/sfx2/source/doc/objstor.cxx b/sfx2/source/doc/objstor.cxx
index f1ae5b009231..e83ff19c3186 100644
--- a/sfx2/source/doc/objstor.cxx
+++ b/sfx2/source/doc/objstor.cxx
@@ -581,6 +581,10 @@ bool SfxObjectShell::ImportFromGeneratedStream_Impl(
bool SfxObjectShell::DoLoad( SfxMedium *pMed )
{
ModifyBlocker_Impl aBlock( this );
+struct FontLockGuard {
+FontLockGuard() { Application::LockFontUpdates(true); }
+~FontLockGuard() { Application::LockFontUpdates(false); }
+} aFontLockGuard;
pMedium = pMed;
pMedium->CanDisposeStorage_Impl( true );
diff --git a/vcl/inc/svdata.hxx b/vcl/inc/svdata.hxx
index beb877f728ff..ea48d774ccca 100644
--- a/vcl/inc/svdata.hxx
+++ b/vcl/inc/svdata.hxx
@@ -351,6 +351,9 @@ struct ImplSVData
boolmbDeInit = false; // Is VCL
deinitializing
std::unique_ptr mpImeStatus; // interface to
ime status window, only used by the X11 backend
std::unique_ptr mpSalSystem; // SalSystem
interface
+int mnFontUpdatesLockCount = 0; // avoid repeated
font updates
+boolmbFontUpdatesPending = false; // need to update
font data after unlock
+boolmbFontUpdatesNewLists = false; // generate new
font lists
boolmbResLocaleSet = false; //
SV-Resource-Manager
std::locale maResLocale;// Resource locale
ImplSchedulerContextmaSchedCtx; // indepen data
for class Scheduler
diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx
index c73769ebcc8a..c3f3b07827f0 100644
--- a/vcl/source/app/svapp.cxx
+++ b/vcl/source/app/svapp.cxx
@@ -987,6 +987,11 @@ void Application::RemoveUserEvent( ImplSVEvent *
nUserEvent )
}
}
+void Application::LockFontUpdates(bool bLock)
+{
+OutputDevice::LockFontUpdates(bLock);
+}
+
WorkWindow* Application::GetAppWindow()
{
return ImplGetSVData()->maWinData.mpAppWin;
diff --git a/vcl/source/outdev/font.cxx b/vcl/source/outdev/font.cxx
index 1e0cb553c04b..4d982e9d1f3a 100644
--- a/vcl/source/outdev/font.cxx
+++ b/vcl/source/outdev/font.cxx
@@ -595,9 +595,26 @@ void OutputDevice::ImplClearAllFontData(bool bNewFontLists)
}
}
+namespace {
+osl::Mutex& GetFontUpdatesLockMutex()
+{
+static osl::Mutex aFontUpdatesMutex;
+return aFontUpdatesMutex;
+}
+}
+
void OutputDevice::ImplRefreshAllFontData(bool bNewFontLists)
{
-
[Libreoffice-commits] core.git: vcl/inc vcl/osx vcl/source
vcl/inc/osx/salinst.h |3 ++-
vcl/inc/salinst.hxx |1 +
vcl/osx/salinst.cxx | 30 +++---
vcl/osx/salmenu.cxx |9 +
vcl/osx/vclnsapp.mm | 16
vcl/source/app/svmain.cxx |6 +-
6 files changed, 52 insertions(+), 13 deletions(-)
New commits:
commit 284a7f60fff72c4d8c011ff60ea2e40163cd25c3
Author: Jan-Marek Glogowski
AuthorDate: Thu Jan 3 13:45:16 2019 +0100
Commit: Jan-Marek Glogowski
CommitDate: Fri Jan 11 05:20:11 2019 +0100
OSX Re-Introduce NSApplicationMain usage
This restores the nested NSApplicationMain and default run loop
usage. Without it the Java AWT integration will start its own
event loop, effectively blocking any non-system event processing.
Reproducible via "Tools - Macros - Organize Macros - BeanShell...
- LibreOffice Macros - HelloWorld - helloworld.bsh - Edit".
The blocking can be prevented by overriding NSApplication::run and
running our own event loop using Application::Execute. But this
still doesn't show the Java AWT editor window and I couldn't find
any information how to fix this.
Since OSX now is a VCL plugin, this can't restore the old hook
mechanism, but instead adds a new function to SalInstance.
SalInstance initialization happens at InitVCL() start just a
little bit later in the call stack.
Somehow NSApplicationMain manages to run the Java VM in an extra
thread, so it doesn't block the main loop. Probably this could
also be handled by LO starting the JVM as a thread.
Further information for an implementation eventually can be found
in the "Technical Note TN2147" "JNI Development on Mac OS X."
Change-Id: I04a0c2bf7949571f1b678ada9ab3592e0fe30c1f
Regression-from: 925e2edb6f3f8fffcff9eddb31ed18bc77e2a690
Reviewed-on: https://gerrit.libreoffice.org/65836
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/vcl/inc/osx/salinst.h b/vcl/inc/osx/salinst.h
index 18b8de8cfc7f..edece53b6bea 100644
--- a/vcl/inc/osx/salinst.h
+++ b/vcl/inc/osx/salinst.h
@@ -91,6 +91,7 @@ public:
virtual ~AquaSalInstance() override;
virtual void AfterAppInit() override;
+virtual bool SVMainHook(int *) override;
virtual SalFrame* CreateChildFrame( SystemParentData* pParent,
SalFrameStyleFlags nStyle ) override;
virtual SalFrame* CreateFrame( SalFrame* pParent, SalFrameStyleFlags
nStyle ) override;
@@ -145,7 +146,7 @@ public:
void endedPrintJob() { mnActivePrintJobs--; }
// event subtypes for NSApplicationDefined events
-static const short AppEndLoopEvent= 1;
+static const short AppExecuteSVMain = 1;
static const short AppStartTimerEvent = 10;
static const short YieldWakeupEvent = 20;
static const short DispatchTimerEvent = 30;
diff --git a/vcl/inc/salinst.hxx b/vcl/inc/salinst.hxx
index f48cca4136e2..e35cd78df4fb 100644
--- a/vcl/inc/salinst.hxx
+++ b/vcl/inc/salinst.hxx
@@ -89,6 +89,7 @@ public:
//called directly after Application::Init
virtual voidAfterAppInit() {}
+virtual boolSVMainHook(int*) { return false; }
// Frame
// DisplayName for Unix ???
diff --git a/vcl/osx/salinst.cxx b/vcl/osx/salinst.cxx
index c92b621a023c..f0f470545138 100644
--- a/vcl/osx/salinst.cxx
+++ b/vcl/osx/salinst.cxx
@@ -81,6 +81,7 @@ extern "C" {
using namespace std;
using namespace ::com::sun::star;
+static int* gpnInit = nullptr;
static NSMenu* pDockMenu = nil;
static bool bLeftMain = false;
@@ -328,8 +329,6 @@ VCLPLUG_OSX_PUBLIC SalInstance* create_SalInstance()
ImplGetSVData()->maNWFData.mbProgressNeedsErase = true;
ImplGetSVData()->maNWFData.mnStatusBarLowerRightOffset = 10;
-[NSApp finishLaunching];
-
return pInst;
}
}
@@ -386,9 +385,14 @@ void AquaSalInstance::handleAppDefinedEvent( NSEvent*
pEvent )
if ( pTimer )
pTimer->handleStartTimerEvent( pEvent );
break;
-case AppEndLoopEvent:
+case AppExecuteSVMain:
+{
+int nRet = ImplSVMain();
+if (gpnInit)
+*gpnInit = nRet;
[NSApp stop: NSApp];
break;
+}
case DispatchTimerEvent:
{
AquaSalInstance *pInst = GetSalData()->mpInstance;
@@ -958,5 +962,25 @@ NSImage* CreateNSImage( const Image& rImage )
return pImage;
}
+bool AquaSalInstance::SVMainHook(int* pnInit)
+{
+gpnInit = pnInit;
+
+OUString aExeURL, aExe;
+osl_getExecutableFile( );
+osl_getSystemPathFromFileURL( aExeURL.pData, );
+OString aByteExe( OUStringToOString( aExe, osl_getThreadTextEncoding() ) );
+
+#ifdef DEBUG
+aByteExe += OString ( " NSAccessibilityDebugLogLevel 1" );
+const char* pArgv[] = { aByteExe.getStr(), NULL };
+NSApplicationMain( 3, pArgv );
+#else
+const char* pArgv[] = { aByteExe.getStr(), nullptr };
+NSApplicationMain( 1, pArgv );
[Libreoffice-bugs] [Bug 88903] COLOR PICKER: Automatic button not correctly showing its state
https://bugs.documentfoundation.org/show_bug.cgi?id=88903 --- Comment #9 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112265] Certain fonts in a frame graphic do not have the correct position.
https://bugs.documentfoundation.org/show_bug.cgi?id=112265 --- Comment #16 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86605] CONTEXT MENU: Alignment entry displayed when empty
https://bugs.documentfoundation.org/show_bug.cgi?id=86605 --- Comment #5 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84742] Basic runtime error '51' Internal error
https://bugs.documentfoundation.org/show_bug.cgi?id=84742 --- Comment #10 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108459] Filesave: "File name without Extension" and "Path" Fields saved as DOC open as "File name" in LO while "Path/file name" isn't shown at all in MSO
https://bugs.documentfoundation.org/show_bug.cgi?id=108459 --- Comment #7 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106187] Document colors not working with text highlight and shape colors
https://bugs.documentfoundation.org/show_bug.cgi?id=106187 --- Comment #4 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114948] FILEOPEN: Wrong position of drawing in DOCX import
https://bugs.documentfoundation.org/show_bug.cgi?id=114948 --- Comment #5 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114832] Filesave: "File name without Extension" and "Path" Fields saved as DOCX open as "File name" in Writer while correctly shown in Word
https://bugs.documentfoundation.org/show_bug.cgi?id=114832 --- Comment #2 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114868] Writer Fontwork Formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=114868 --- Comment #12 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114860] Spreadsheet doesn't work properly on 5.4.4.2 and 6.0.0.1
https://bugs.documentfoundation.org/show_bug.cgi?id=114860 --- Comment #7 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/endingSectionProps.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport13.cxx| 16
writerfilter/source/dmapper/PropertyMap.cxx | 33 ++
writerfilter/source/dmapper/PropertyMap.hxx |3 +
4 files changed, 52 insertions(+)
New commits:
commit 8d4a7b17e60aa889d1a78da47630aae2d1c1513c
Author: Justin Luth
AuthorDate: Tue Jan 8 18:14:52 2019 +0300
Commit: Justin Luth
CommitDate: Fri Jan 11 04:08:46 2019 +0100
writerfilter: import section margins and writingMode
Previously, only page styles got these values. But if the
section is continuous, then these properties should
be transferred to the section itself.
This patch relies on the commit for tdf#122456. It confirms
that it is a good idea for the last section to ignore
the "fake" section and keep the real section properties.
Otherwise these margins would be lost on export.
Change-Id: I45efb0d80fb9307a57ff560b2e1a26899155f827
Reviewed-on: https://gerrit.libreoffice.org/65975
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/sw/qa/extras/ooxmlexport/data/endingSectionProps.docx
b/sw/qa/extras/ooxmlexport/data/endingSectionProps.docx
new file mode 100644
index ..e5dee2f60d51
Binary files /dev/null and
b/sw/qa/extras/ooxmlexport/data/endingSectionProps.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
index 6d7a3a2b618e..b22c5cd96083 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
@@ -11,6 +11,7 @@
#include
#include
+#include
#include
#include
@@ -50,6 +51,21 @@ DECLARE_OOXMLEXPORT_TEST(testTdf121374_sectionHF2,
"tdf121374_sectionHF2.doc")
CPPUNIT_ASSERT( xHeaderText->getString().startsWith("virkamatka-anomus") );
}
+DECLARE_OOXMLEXPORT_TEST(testendingSectionProps, "endingSectionProps.docx")
+{
+uno::Reference
xPageStyle(getStyles("PageStyles")->getByName("Standard"), uno::UNO_QUERY);
+uno::Reference xHeaderText = getProperty<
uno::Reference >(xPageStyle, "HeaderText");
+CPPUNIT_ASSERT_EQUAL( OUString("General header"),
xHeaderText->getString());
+
+uno::Reference
xTextSectionsSupplier(mxComponent, uno::UNO_QUERY);
+uno::Reference
xSections(xTextSectionsSupplier->getTextSections(), uno::UNO_QUERY);
+uno::Reference xSect(xSections->getByIndex(0),
uno::UNO_QUERY);
+
+CPPUNIT_ASSERT_EQUAL_MESSAGE("# of paragraphs", 2, getParagraphs());
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Section is RightToLeft",
text::WritingMode2::RL_TB, getProperty(xSect, "WritingMode"));
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Section Left Margin", sal_Int32(2540),
getProperty(xSect, "SectionLeftMargin"));
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/dmapper/PropertyMap.cxx
b/writerfilter/source/dmapper/PropertyMap.cxx
index 91716a64dbe4..e2f34674b0eb 100644
--- a/writerfilter/source/dmapper/PropertyMap.cxx
+++ b/writerfilter/source/dmapper/PropertyMap.cxx
@@ -682,6 +682,38 @@ void SectionPropertyMap::DontBalanceTextColumns()
}
}
+void SectionPropertyMap::ApplySectionProperties( uno::Reference<
beans::XPropertySet >& xSection, DomainMapper_Impl& rDM_Impl )
+{
+try
+{
+if ( xSection.is() )
+{
+// Margins only valid if page style is already determined.
+// Take some care not to create an automatic page style (with
GetPageStyle) if it isn't already created.
+if ( !m_aFollowPageStyle.is() && !m_sFollowPageStyleName.isEmpty()
)
+GetPageStyle( rDM_Impl.GetPageStyles(),
rDM_Impl.GetTextFactory(), false );
+if ( m_aFollowPageStyle.is() )
+{
+sal_Int32 nPageMargin = 0;
+m_aFollowPageStyle->getPropertyValue( getPropertyName(
PROP_LEFT_MARGIN ) ) >>= nPageMargin;
+xSection->setPropertyValue( "SectionLeftMargin",
uno::makeAny(m_nLeftMargin - nPageMargin) );
+
+nPageMargin = 0;
+m_aFollowPageStyle->getPropertyValue( getPropertyName(
PROP_RIGHT_MARGIN ) ) >>= nPageMargin;
+xSection->setPropertyValue( "SectionRightMargin",
uno::makeAny(m_nRightMargin - nPageMargin) );
+}
+
+boost::optional< PropertyMap::Property > pProp = getProperty(
PROP_WRITING_MODE );
+if ( pProp )
+xSection->setPropertyValue( "WritingMode", pProp->second );
+}
+}
+catch ( uno::Exception& )
+{
+DBG_UNHANDLED_EXCEPTION("writerfilter", "Exception in
SectionPropertyMap::ApplySectionProperties");
+}
+}
+
void SectionPropertyMap::ApplyProtectionProperties( uno::Reference<
beans::XPropertySet >& xSection, DomainMapper_Impl& rDM_Impl )
{
try
@@ -1398,6 +1430,7 @@ void SectionPropertyMap::CloseSectionGroup(
[Libreoffice-bugs] [Bug 54908] printing when a selection is active should take in account it and activate the "print selection" radio button
https://bugs.documentfoundation.org/show_bug.cgi?id=54908 Daniel Silva changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |danielfaleirosi...@gmail.co |desktop.org |m -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a2d2f0b30b75093b6ab517349f6db0649314495f Author: Andrea Gelmini AuthorDate: Thu Jan 10 23:28:18 2019 +0100 Commit: Gerrit Code Review CommitDate: Fri Jan 11 01:30:00 2019 +0100 Update git submodules * Update helpcontent2 from branch 'master' - Removed double word Change-Id: I34d554c9e42d032d46031248f68405a3f49177ab Reviewed-on: https://gerrit.libreoffice.org/66138 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 39d0a905dca4..f25b7e57f893 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 39d0a905dca4f4932204ff9e658f9ab90cf6032b +Subproject commit f25b7e57f8930eaec4024e2d75db4904f8d02064 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/shared/optionen/viewcertificate_c.xhp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f25b7e57f8930eaec4024e2d75db4904f8d02064 Author: Andrea Gelmini AuthorDate: Thu Jan 10 23:28:18 2019 +0100 Commit: Olivier Hallot CommitDate: Fri Jan 11 01:30:00 2019 +0100 Removed double word Change-Id: I34d554c9e42d032d46031248f68405a3f49177ab Reviewed-on: https://gerrit.libreoffice.org/66138 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/shared/optionen/viewcertificate_c.xhp b/source/text/shared/optionen/viewcertificate_c.xhp index 77c28fb22..5f1989c6d 100644 --- a/source/text/shared/optionen/viewcertificate_c.xhp +++ b/source/text/shared/optionen/viewcertificate_c.xhp @@ -26,7 +26,7 @@ /text/shared/optionen/viewcertificate_c.xhp -UFI: View certificate Certificate Path tab page +UFI: View Certificate Path tab page ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 44076] =(-8)^(1/3) should return -2
https://bugs.documentfoundation.org/show_bug.cgi?id=44076 --- Comment #14 from Commit Notification --- Eike Rathke committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/f4844297c9cdbbf341e3e7d5e2e0c0c18cb40553%5E%21 Related: tdf#44076 use sc::power() in ScMatrix::PowOp() It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sc/qa sc/source
sc/qa/unit/data/functions/date_time/fods/second.fods | 91 +-- sc/source/core/tool/interpr2.cxx |5 - 2 files changed, 88 insertions(+), 8 deletions(-) New commits: commit 02817ec9f22fc5845d2b2686cac4573cda3b4062 Author: Winfried Donkers AuthorDate: Sun Dec 23 14:57:01 2018 +0100 Commit: Eike Rathke CommitDate: Fri Jan 11 01:09:28 2019 +0100 tdf#121978 use round again for Calc function SECOND. Round was inadvertedly replaced by floor in commit 273b3e10eab70ebc084cb62568bd699fddfb376e. Change-Id: Ie0824e228c62509952a11b866638482a409c851d Reviewed-on: https://gerrit.libreoffice.org/65579 Tested-by: Jenkins Reviewed-by: Eike Rathke (cherry picked from commit 1692034d53ce28b2c5d1c63ab429232a92b2f861) Reviewed-on: https://gerrit.libreoffice.org/66094 diff --git a/sc/qa/unit/data/functions/date_time/fods/second.fods b/sc/qa/unit/data/functions/date_time/fods/second.fods index 8db288ae3ae9..fbeda46f4841 100644 --- a/sc/qa/unit/data/functions/date_time/fods/second.fods +++ b/sc/qa/unit/data/functions/date_time/fods/second.fods @@ -342,6 +342,13 @@ + + + : + + : + + @@ -527,6 +534,7 @@ + @@ -826,11 +834,11 @@ - - 12 + + 13 - - 12 + + 13 TRUE @@ -839,11 +847,80 @@ =SECOND(J9) - tdf11880 + tdf118800 + + + + 10:11:12.6000 + + + + + + 9 + + + 9 + + + TRUE + + + =SECOND(J10) + + + tdf121978 + + + + 2018-10-22 11:34:53. + + + 2018-10-22 11:31:44. + + + + + + 9 + + + 9 + + + TRUE + + + =SECOND(J11) + + + tdf121978 + + + + 00:00:08.9990 + + + + + + 8 + + + 8 + + + TRUE + + + =SECOND(J12) + + + tdf121978 - - 10:11:12.60 + + 00:00:08.2500 diff --git a/sc/source/core/tool/interpr2.cxx b/sc/source/core/tool/interpr2.cxx index c151000f34e1..b122d0e4f706 100644 --- a/sc/source/core/tool/interpr2.cxx +++ b/sc/source/core/tool/interpr2.cxx @@ -156,7 +156,10 @@ void ScInterpreter::ScGetSec() sal_uInt16 nHour, nMinute, nSecond; double fFractionOfSecond; tools::Time::GetClock( GetDouble(), nHour, nMinute, nSecond, fFractionOfSecond, 0); -PushDouble( nSecond); +if ( fFractionOfSecond >= 0.5 ) +nSecond = ( nSecond + 1 ) % 60; +PushDouble( nSecond ); + } void ScInterpreter::ScGetHour() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/scmatrix.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit f4844297c9cdbbf341e3e7d5e2e0c0c18cb40553
Author: Eike Rathke
AuthorDate: Thu Jan 10 13:56:27 2019 +0100
Commit: Eike Rathke
CommitDate: Fri Jan 11 01:08:37 2019 +0100
Related: tdf#44076 use sc::power() in ScMatrix::PowOp()
Change-Id: I13a47419bd57d71482793d5f9a8429101793aad7
Reviewed-on: https://gerrit.libreoffice.org/66092
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/sc/source/core/tool/scmatrix.cxx b/sc/source/core/tool/scmatrix.cxx
index 8b3c8ffd5407..f7cb87d8f21f 100644
--- a/sc/source/core/tool/scmatrix.cxx
+++ b/sc/source/core/tool/scmatrix.cxx
@@ -3441,13 +3441,13 @@ void ScMatrix::PowOp( bool bFlag, double fVal,
ScMatrix& rMat)
{
if (bFlag)
{
-auto pow_ = [](double a, double b){return pow(b, a);};
+auto pow_ = [](double a, double b){return sc::power(b, a);};
matop::MatOp aOp(pow_, pImpl->GetErrorInterpreter(),
fVal);
pImpl->ApplyOperation(aOp, *rMat.pImpl);
}
else
{
-auto pow_ = [](double a, double b){return pow(a, b);};
+auto pow_ = [](double a, double b){return sc::power(a, b);};
matop::MatOp aOp(pow_, pImpl->GetErrorInterpreter(),
fVal);
pImpl->ApplyOperation(aOp, *rMat.pImpl);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3827fec6e86f2b1de804f69e9747af150de59e15 Author: Andrea Gelmini AuthorDate: Thu Jan 10 23:25:48 2019 +0100 Commit: Gerrit Code Review CommitDate: Fri Jan 11 01:06:55 2019 +0100 Update git submodules * Update helpcontent2 from branch 'master' - Removed double word Change-Id: Ia2ddedbb18ef3772be30cb1828ada0857f523848 Reviewed-on: https://gerrit.libreoffice.org/66137 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 899529868c45..39d0a905dca4 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 899529868c4561aa76bcb63c9f6831f06e6f8f13 +Subproject commit 39d0a905dca4f4932204ff9e658f9ab90cf6032b ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/smath/01/03090400.xhp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 39d0a905dca4f4932204ff9e658f9ab90cf6032b Author: Andrea Gelmini AuthorDate: Thu Jan 10 23:25:48 2019 +0100 Commit: Olivier Hallot CommitDate: Fri Jan 11 01:06:55 2019 +0100 Removed double word Change-Id: Ia2ddedbb18ef3772be30cb1828ada0857f523848 Reviewed-on: https://gerrit.libreoffice.org/66137 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/smath/01/03090400.xhp b/source/text/smath/01/03090400.xhp index d2c0fa7cd..31d18946c 100644 --- a/source/text/smath/01/03090400.xhp +++ b/source/text/smath/01/03090400.xhp @@ -442,7 +442,7 @@ -You can also assign an index or an exponent to a function. For example, typing sin^2x results in in a function "sine to the power of 2x". +You can also assign an index or an exponent to a function. For example, typing sin^2x results in a function "sine to the power of 2x". When typing functions manually in the Commands window, note that spaces are required for some functions (for example, abs 5=5 ; abs -3=3). ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 69060] FILEOPEN: Documents with embedded fonts take too long to open
https://bugs.documentfoundation.org/show_bug.cgi?id=69060 Mike Kaganski changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122646] New: FILEOPEN: EMF+ Wrong line width
https://bugs.documentfoundation.org/show_bug.cgi?id=122646 Bug ID: 122646 Summary: FILEOPEN: EMF+ Wrong line width Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gan...@poczta.onet.pl Description: The EMF+ line width is not set correctly. Steps to Reproduce: 1. Open attached EMF+ file 2. Compare it with file generated by MS Word Actual Results: The lines width are different Expected Results: The lines width are the same Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122646] FILEOPEN: EMF+ Wrong line width
https://bugs.documentfoundation.org/show_bug.cgi?id=122646 Bartosz changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Ever confirmed|0 |1 Assignee|libreoffice-b...@lists.free |gan...@poczta.onet.pl |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122646] FILEOPEN: EMF+ Wrong line width
https://bugs.documentfoundation.org/show_bug.cgi?id=122646 Bartosz changed: What|Removed |Added CC||gan...@poczta.onet.pl --- Comment #1 from Bartosz --- Created attachment 148230 --> https://bugs.documentfoundation.org/attachment.cgi?id=148230=edit EMF+ file with lines with wrongly displayed under LibreOffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119408] Fails to start Draw, Impress due to new Avahi dependency
https://bugs.documentfoundation.org/show_bug.cgi?id=119408 lj...@pobox.com changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #2 from lj...@pobox.com --- CONFIRMED still a bug in 6.1.4 Status changed back to UNCONFIRMED as requested. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122645] Image/Text position messed up after save-close-open
https://bugs.documentfoundation.org/show_bug.cgi?id=122645 --- Comment #1 from Chameleon --- Created attachment 148229 --> https://bugs.documentfoundation.org/attachment.cgi?id=148229=edit The book -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122645] New: Image/Text position messed up after save-close-open
https://bugs.documentfoundation.org/show_bug.cgi?id=122645 Bug ID: 122645 Summary: Image/Text position messed up after save-close-open Product: LibreOffice Version: 6.2.0.1 rc Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gessos.p...@yahoo.gr Description: I have a book with a large number of images. Images usually anchored to character and wrapped with contour. When I save the book, close LibreOffice and re-open the book, many (not all) of images mess with their position. Images/text go to their correct position if, for every misplaced image, I edit contour, stretch a little and stretch back the contour. I must do this every time I open the book. I try to provide a minimal sample but I failed. So I provide the complete book with an equivalent PDF produced with LibreOffice somewhere in 2009. Steps to Reproduce: Open provided book. Actual Results: Images before save have been placed correct. Now they are misplaced. This happens on every save-close-load. Check for instance, pages 9 and 21 Expected Results: Correct placed images and surrounding text. Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122435] LibreOffice hangs when in Calc copying formula while in edit mode then leaving field with escape
https://bugs.documentfoundation.org/show_bug.cgi?id=122435 --- Comment #6 from Maddes --- Cannot find a nightly build for Windows 6.3.0.0.alpha0+ to test it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svtools/source
svtools/source/misc/langhelp.cxx |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) New commits: commit 2dc075d2895c5920a42bd7714d92575d83949639 Author: Stephan Bergmann AuthorDate: Thu Jan 10 15:31:30 2019 +0100 Commit: Stephan Bergmann CommitDate: Thu Jan 10 22:39:17 2019 +0100 o3tl::string_view -> std::string_view (in svtools) Change-Id: Id876708444e969c27c0515d6b6897c016de53437 Reviewed-on: https://gerrit.libreoffice.org/66117 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/svtools/source/misc/langhelp.cxx b/svtools/source/misc/langhelp.cxx index 8c2ef914cd24..57d1d2f89ca3 100644 --- a/svtools/source/misc/langhelp.cxx +++ b/svtools/source/misc/langhelp.cxx @@ -7,10 +7,13 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ +#include + +#include + #include #include #include -#include #include #include #include @@ -129,7 +132,7 @@ OUString getInstalledLocaleForSystemUILanguage(const css::uno::Sequencehttps://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 119804] Permit sorting using column labels even if labels row is protected
https://bugs.documentfoundation.org/show_bug.cgi?id=119804 Martin van Zijl changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |martin.vanz...@gmail.com |desktop.org | --- Comment #2 from Martin van Zijl --- I have just submitted a patch for this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118879] Flat ODF document embed linked image
https://bugs.documentfoundation.org/show_bug.cgi?id=118879 --- Comment #5 from dirk.duschin...@yahoo.de --- Hi all, bug 122625 seems to be a duplicate of this bug, only for LO impress. I assume that if the regression found by Xisco is fixed this would solve things for impress (and probably other components) as well, right? Has there been any progress on this bug? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/appl/sfxhelp.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 06b854bff6061f69d113b2992d646c368d05ce50
Author: Stephan Bergmann
AuthorDate: Thu Jan 10 15:30:27 2019 +0100
Commit: Stephan Bergmann
CommitDate: Thu Jan 10 22:25:16 2019 +0100
o3tl::string_view -> std::string_view (in sfx2)
Change-Id: I61b40db1e75938ecf09c3c2e039be2d757fde170
Reviewed-on: https://gerrit.libreoffice.org/66116
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/sfx2/source/appl/sfxhelp.cxx b/sfx2/source/appl/sfxhelp.cxx
index ebf530a00fb5..e0540ec5e1d9 100644
--- a/sfx2/source/appl/sfxhelp.cxx
+++ b/sfx2/source/appl/sfxhelp.cxx
@@ -21,6 +21,7 @@
#include
#include
+#include
#include
#include
@@ -758,7 +759,7 @@ bool rewriteFlatpakHelpRootUrl(OUString * helpRootUrl) {
<< " before [Instance] app-path");
throw Failure();
}
-o3tl::string_view const line(
+std::string_view const line(
reinterpret_cast(bytes.getConstArray()),
bytes.getLength());
if (instance) {
static constexpr auto keyPath =
OUStringLiteral("app-path=");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 118879] Flat ODF document embed linked image
https://bugs.documentfoundation.org/show_bug.cgi?id=118879 dirk.duschin...@yahoo.de changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||2625 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122625] FILESAVE: File size of Flat XML is much larger than for normal format when using linked images
https://bugs.documentfoundation.org/show_bug.cgi?id=122625 dirk.duschin...@yahoo.de changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||8879 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source
cui/source/options/optinet2.cxx |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
New commits:
commit c16156f78664cf62c1ccc0041370674faf4c0196
Author: Stephan Bergmann
AuthorDate: Thu Jan 10 15:29:22 2019 +0100
Commit: Stephan Bergmann
CommitDate: Thu Jan 10 22:22:46 2019 +0100
o3tl::string_view -> std::string_view (in cui)
Change-Id: I7899802f09d16cfa2c8821782feed4fdfa653dd0
Reviewed-on: https://gerrit.libreoffice.org/66114
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/cui/source/options/optinet2.cxx b/cui/source/options/optinet2.cxx
index 8124c7d8998c..59d0dd663236 100644
--- a/cui/source/options/optinet2.cxx
+++ b/cui/source/options/optinet2.cxx
@@ -19,7 +19,8 @@
#include
-#include
+#include
+
#include
#include
#include
@@ -115,7 +116,7 @@ bool isValidPort(OUString const & value) {
return true;
}
// Overflow in OUString::toUInt64 returns 0, so need to check value
contains only zeroes:
-return o3tl::u16string_view(value).find_first_not_of(u'0') ==
o3tl::u16string_view::npos;
+return std::u16string_view(value).find_first_not_of(u'0') ==
std::u16string_view::npos;
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: embedserv/source include/rtl
embedserv/source/embed/ed_ipersiststr.cxx | 13 -
embedserv/source/embed/guid.cxx |2 +-
embedserv/source/embed/guid.hxx |5 +++--
include/rtl/ustring.hxx | 11 +++
4 files changed, 23 insertions(+), 8 deletions(-)
New commits:
commit 6856da30665705be6380e84cf55de954c41f15d1
Author: Stephan Bergmann
AuthorDate: Thu Jan 10 11:21:45 2019 +0100
Commit: Stephan Bergmann
CommitDate: Thu Jan 10 22:22:29 2019 +0100
o3tl::string_view -> std::string_view (in embedserv)
Change-Id: I32bba8f45ff3b77084aa2d416126f96c051022f4
Reviewed-on: https://gerrit.libreoffice.org/66073
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/embedserv/source/embed/ed_ipersiststr.cxx
b/embedserv/source/embed/ed_ipersiststr.cxx
index 44757a5eb35c..77131196b4b9 100644
--- a/embedserv/source/embed/ed_ipersiststr.cxx
+++ b/embedserv/source/embed/ed_ipersiststr.cxx
@@ -17,6 +17,10 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
+#include
+
+#include
+
#include
#include
#include
@@ -34,7 +38,6 @@
#include
#include
-#include
#include
#include
#include
@@ -397,7 +400,7 @@ STDMETHODIMP EmbedDocument_Impl::InitNew( IStorage *pStg )
if ( m_xFactory.is() && pStg )
{
uno::Reference< frame::XModel > aDocument(
-m_xFactory->createInstance(
o3tl::toOUString(getServiceNameFromGUID_Impl( _guid )) ),
+m_xFactory->createInstance(
getServiceNameFromGUID_Impl( _guid ) ),
uno::UNO_QUERY );
if ( aDocument.is() )
{
@@ -532,7 +535,7 @@ STDMETHODIMP EmbedDocument_Impl::Load( IStorage *pStg )
if ( xTempIn.is() )
{
uno::Reference< frame::XModel > aDocument(
-m_xFactory->createInstance(
o3tl::toOUString(getServiceNameFromGUID_Impl( _guid )) ),
+m_xFactory->createInstance(
getServiceNameFromGUID_Impl( _guid ) ),
uno::UNO_QUERY );
if ( aDocument.is() )
{
@@ -739,7 +742,7 @@ STDMETHODIMP EmbedDocument_Impl::Load( LPCOLESTR
pszFileName, DWORD /*dwMode*/ )
if ( FAILED( hr ) || !m_pMasterStorage ) return E_FAIL;
-o3tl::u16string_view aCurType = getServiceNameFromGUID_Impl( _guid ); //
???
+std::u16string_view aCurType = getServiceNameFromGUID_Impl( _guid ); //
???
CLIPFORMAT cf = static_cast(RegisterClipboardFormatW(
L"Embedded Object" ));
hr = WriteFmtUserTypeStg( m_pMasterStorage,
cf, // ???
@@ -765,7 +768,7 @@ STDMETHODIMP EmbedDocument_Impl::Load( LPCOLESTR
pszFileName, DWORD /*dwMode*/ )
uno::Reference< frame::XModel > aDocument(
-m_xFactory->createInstance(
o3tl::toOUString(getServiceNameFromGUID_Impl( _guid )) ),
+m_xFactory->createInstance( getServiceNameFromGUID_Impl(
_guid ) ),
uno::UNO_QUERY );
if ( aDocument.is() )
{
diff --git a/embedserv/source/embed/guid.cxx b/embedserv/source/embed/guid.cxx
index cb23d05f0fc5..0260cb0ebc7e 100644
--- a/embedserv/source/embed/guid.cxx
+++ b/embedserv/source/embed/guid.cxx
@@ -58,7 +58,7 @@ wchar_t const * getStorageTypeFromGUID_Impl( GUID const *
guid )
return L"";
}
-o3tl::u16string_view getServiceNameFromGUID_Impl( GUID const * guid )
+std::u16string_view getServiceNameFromGUID_Impl( GUID const * guid )
{
if ( *guid == OID_WriterTextServer )
return u"com.sun.star.comp.Writer.TextDocument";
diff --git a/embedserv/source/embed/guid.hxx b/embedserv/source/embed/guid.hxx
index 886004c663ef..eca39c2880c8 100644
--- a/embedserv/source/embed/guid.hxx
+++ b/embedserv/source/embed/guid.hxx
@@ -22,14 +22,15 @@
#include
-#include
+#include
+
#include
#include
OUString getFilterNameFromGUID_Impl( GUID const * );
-o3tl::u16string_view getServiceNameFromGUID_Impl( GUID const * );
+std::u16string_view getServiceNameFromGUID_Impl( GUID const * );
wchar_t const * getStorageTypeFromGUID_Impl( GUID const * guid );
diff --git a/include/rtl/ustring.hxx b/include/rtl/ustring.hxx
index c6e3760838ce..35e0ca7756be 100644
--- a/include/rtl/ustring.hxx
+++ b/include/rtl/ustring.hxx
@@ -24,6 +24,7 @@
#include
#include
+#include
#include
#include
#include
@@ -410,6 +411,16 @@ public:
}
#endif
+#if defined LIBO_INTERNAL_ONLY
+OUString(std::u16string_view sv) {
+if (sv.size() > sal_uInt32(std::numeric_limits::max())) {
+throw std::bad_alloc();
+}
+pData = nullptr;
+rtl_uString_newFromStr_WithLength(, sv.data(), sv.size());
+}
+#endif
+
/**
Release the string data.
*/
___
Libreoffice-commits mailing
[Libreoffice-bugs] [Bug 96000] [META] Spelling and grammar checking bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=96000 Bug 96000 depends on bug 108484, which changed state. Bug 108484 Summary: VIEWING: The text is re-positioning when scrolling up an down if the automatic Spell Checking is enabled https://bugs.documentfoundation.org/show_bug.cgi?id=108484 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108484] VIEWING: The text is re-positioning when scrolling up an down if the automatic Spell Checking is enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=108484 Telesto changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #15 from Telesto --- *** This bug has been marked as a duplicate of bug 103322 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL
https://bugs.documentfoundation.org/show_bug.cgi?id=103322 --- Comment #15 from Telesto --- *** Bug 108484 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122625] FILESAVE: File size of Flat XML is much larger than for normal format when using linked images
https://bugs.documentfoundation.org/show_bug.cgi?id=122625 --- Comment #2 from dirk.duschin...@yahoo.de --- (In reply to Regina Henschel from comment #1) > Duplicate to bug 118879 ? Ineed it describes the same problem, only for writer, which I've seen as well. Unfortunately there hasn't been much progress on that bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source
sd/source/ui/animations/CustomAnimationList.cxx |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
New commits:
commit f0856d3c6115163da837c141b69ab017b8f1fd81
Author: Brian Fraser
AuthorDate: Mon Jan 7 09:30:14 2019 -0800
Commit: Jim Raykowski
CommitDate: Thu Jan 10 22:20:52 2019 +0100
tdf#122454 Impress: Correct d'n'd animation selection in Windows
Change-Id: I0f17ff657beb2a5b3dfed91856ec45ddfca793a9
Reviewed-on: https://gerrit.libreoffice.org/65939
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/sd/source/ui/animations/CustomAnimationList.cxx
b/sd/source/ui/animations/CustomAnimationList.cxx
index c6878658c437..ec42796541f6 100644
--- a/sd/source/ui/animations/CustomAnimationList.cxx
+++ b/sd/source/ui/animations/CustomAnimationList.cxx
@@ -700,11 +700,13 @@ sal_Int8 CustomAnimationList::ExecuteDrop( const
ExecuteDropEvent& /*rEvt*/ )
ret = DND_ACTION_MOVE;
}
+// NOTE: Don't call SvTreeListBox::ExecuteDrop(...) because all required
+// move operations have been completed here to update the model.
return ret;
}
// D'n'D #6: Cleanup (regardless of if we were target of drop or not)
-void CustomAnimationList::DragFinished( sal_Int8 nDropAction )
+void CustomAnimationList::DragFinished( sal_Int8 /*nDropAction*/ )
{
mpDndEffectDragging = nullptr;
mpDndEffectInsertBefore = nullptr;
@@ -714,7 +716,9 @@ void CustomAnimationList::DragFinished( sal_Int8
nDropAction )
// Can hit this without running ExecuteDrop(...) when drag canceled.
mpMainSequence->rebuild();
-SvTreeListBox::DragFinished( nDropAction );
+// Note: Don't call SvTreeListBox::DragFinished(...) because we don't call
+// SvTreeListBox::ExecuteDrop(...) which sets variables that are
+// needed in its DragFinished(...) method.
}
VCL_BUILDER_FACTORY(CustomAnimationList)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 122638] VIEWING: shifting letter
https://bugs.documentfoundation.org/show_bug.cgi?id=122638 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||8484 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108484] VIEWING: The text is re-positioning when scrolling up an down if the automatic Spell Checking is enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=108484 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||2638 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL
https://bugs.documentfoundation.org/show_bug.cgi?id=103322 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||2638 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122638] VIEWING: shifting letter
https://bugs.documentfoundation.org/show_bug.cgi?id=122638 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||3322 CC||tele...@surfxs.nl -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116143] [META] Text cursor bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=116143 Bug 116143 depends on bug 120632, which changed state. Bug 120632 Summary: Text cursor disappears if row in Writer table right-click deleted https://bugs.documentfoundation.org/show_bug.cgi?id=120632 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/window/menufloatingwindow.cxx | 12 +++-
vcl/source/window/menufloatingwindow.hxx |2 ++
2 files changed, 13 insertions(+), 1 deletion(-)
New commits:
commit 59fe75cd7baab2f0c025576413cf8788ac258842
Author: Caolán McNamara
AuthorDate: Thu Jan 10 14:26:43 2019 +
Commit: Caolán McNamara
CommitDate: Thu Jan 10 22:12:49 2019 +0100
Resolves: tdf#120632 consider submenus on restoring focus from menu
additionally to the menu having focus, if a submenu of that menu has
focus, then restore the focus when the whole hierarchy execution ends
return focus to the toplevel menu's saved focus widget
Change-Id: Iefd467fb1ba67ffd0a303505a893d2453e0ffbb3
Reviewed-on: https://gerrit.libreoffice.org/66115
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/vcl/source/window/menufloatingwindow.cxx
b/vcl/source/window/menufloatingwindow.cxx
index 9574457e9151..62b6102f0325 100644
--- a/vcl/source/window/menufloatingwindow.cxx
+++ b/vcl/source/window/menufloatingwindow.cxx
@@ -417,6 +417,16 @@ void MenuFloatingWindow::Start()
GetParent()->IncModalCount();
}
+bool MenuFloatingWindow::MenuInHierarchyHasFocus() const
+{
+if (HasChildPathFocus())
+return true;
+PopupMenu* pSub = GetActivePopup();
+if (!pSub)
+return false;
+return pSub->ImplGetFloatingWindow()->HasChildPathFocus();
+}
+
void MenuFloatingWindow::End()
{
if (!bInExecute)
@@ -428,7 +438,7 @@ void MenuFloatingWindow::End()
// restore focus to previous window if we still have the focus
VclPtr xFocusId(xSaveFocusId);
xSaveFocusId = nullptr;
-if (HasChildPathFocus() && xFocusId != nullptr)
+if (xFocusId != nullptr && MenuInHierarchyHasFocus())
{
ImplGetSVData()->maWinData.mbNoDeactivate = false;
Window::EndSaveFocus(xFocusId);
diff --git a/vcl/source/window/menufloatingwindow.hxx
b/vcl/source/window/menufloatingwindow.hxx
index 9888cd220687..c091b46add4f 100644
--- a/vcl/source/window/menufloatingwindow.hxx
+++ b/vcl/source/window/menufloatingwindow.hxx
@@ -121,6 +121,8 @@ public:
void SetPosInParent( sal_uInt16 nPos ) { nPosInParent = nPos; }
+bool MenuInHierarchyHasFocus() const;
+
virtual css::uno::Reference
CreateAccessible() override;
};
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 102261] FILEOPEN Badly aligned text in pptx presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=102261 --- Comment #7 from Roman Kuznetsov <79045_79...@mail.ru> --- still repro in Version: 6.3.0.0.alpha0+ Build ID: 7809ec859d5bdb5dedb259a362a15324088b334c CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; Locale: ru-RU (ru_RU); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122435] LibreOffice hangs when in Calc copying formula while in edit mode then leaving field with escape
https://bugs.documentfoundation.org/show_bug.cgi?id=122435 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #5 from raal --- No crash with Version: 6.3.0.0.alpha0+ Build ID: 892a5cfe557edb405ec0037676f02a1c24dd76ec CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122625] FILESAVE: File size of Flat XML is much larger than for normal format when using linked images
https://bugs.documentfoundation.org/show_bug.cgi?id=122625 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #1 from Regina Henschel --- Duplicate to bug 118879 ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122643] Crash in: libc-2.27.so after setting Named Ranges to e.g. F:F (non-absolute columns)
https://bugs.documentfoundation.org/show_bug.cgi?id=122643 raal changed: What|Removed |Added Keywords||bibisected, regression Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||l.lu...@collabora.com, ||r...@post.cz Priority|medium |high Severity|normal |major --- Comment #2 from raal --- This seems to have begun at the below commit. Adding Cc: to Luboš Luňák ; Could you possibly take a look at this one? Thanks a79e88101e6ecc177dd9de08f7c5fa0fd4a9843b is the first bad commit commit a79e88101e6ecc177dd9de08f7c5fa0fd4a9843b Author: Jenkins Build User Date: Wed Oct 10 13:22:44 2018 +0200 source sha:79449d73900d7a9bf061244d76f5f8eecc441198 author Luboš Luňák 2018-10-01 14:26:57 +0200 committer Luboš Luňák 2018-10-10 13:01:59 +0200 commit 79449d73900d7a9bf061244d76f5f8eecc441198 (patch) treee85f9bc29941cbf5e5ccb858ee4703ae67d00810 parent b1721b04d8a921a69230927cd7995d8c5d8f5fe2 (diff) make VLOOKUP in Calc thread-safe -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122561] LibreOffice crashes at start of second document.
https://bugs.documentfoundation.org/show_bug.cgi?id=122561 Lifeisgreat changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122643] Crash in: libc-2.27.so after setting Named Ranges to e.g. F:F (non-absolute columns)
https://bugs.documentfoundation.org/show_bug.cgi?id=122643 --- Comment #1 from Xavier Van Wijmeersch --- I have this gdbtrace, don't know if it will be helpful [Detaching after fork from child process 9583] [New Thread 0x7fffe434d700 (LWP 9586)] [New Thread 0x7fffe3b4c700 (LWP 9587)] [Thread 0x7fffe434d700 (LWP 9586) exited] [New Thread 0x7fffe434d700 (LWP 9598)] [Thread 0x7fffe434d700 (LWP 9598) exited] [New Thread 0x7fffe434d700 (LWP 9600)] [New Thread 0x7fffe1dee700 (LWP 9601)] [New Thread 0x7fffdf826700 (LWP 9602)] [New Thread 0x7fffdeec1700 (LWP 9603)] [Thread 0x7fffdeec1700 (LWP 9603) exited] [New Thread 0x7fffdeec1700 (LWP 9604)] [Thread 0x7fffdeec1700 (LWP 9604) exited] [New Thread 0x7fffdeec1700 (LWP 9605)] [Thread 0x7fffdeec1700 (LWP 9605) exited] [New Thread 0x7fffdeec1700 (LWP 9606)] [Thread 0x7fffdeec1700 (LWP 9606) exited] [New Thread 0x7fffdeec1700 (LWP 9607)] [Thread 0x7fffdeec1700 (LWP 9607) exited] [New Thread 0x7fffdeec1700 (LWP 9608)] [New Thread 0x7fffde661700 (LWP 9609)] [Thread 0x7fffdeec1700 (LWP 9608) exited] [Thread 0x7fffde661700 (LWP 9609) exited] [Thread 0x7fffdf826700 (LWP 9602) exited] [New Thread 0x7fffdf826700 (LWP 9610)] [New Thread 0x7fffde661700 (LWP 9611)] [Thread 0x7fffde661700 (LWP 9611) exited] [Thread 0x7fffdf826700 (LWP 9610) exited] [New Thread 0x7fffdf826700 (LWP 9612)] Thread 1 "soffice.bin" received signal SIGABRT, Aborted. 0x77ccf75b in raise () from /lib64/libc.so.6 #0 0x77ccf75b in raise () at /lib64/libc.so.6 #1 0x77cb1524 in abort () at /lib64/libc.so.6 #2 0x7426556e in SalUserEventList::DispatchUserEvents(bool) (this=0x14e4f00, bHandleAllCurrentEvents=) at /home/libreoffice/vcl/source/app/salusereventlist.cxx:125 #3 0x77ea199d in KDEXLib::processYield(bool, bool) (this=this@entry=0x537970, bWait=bWait@entry=true, bHandleAllCurrentEvents=bHandleAllCurrentEvents@entry=false) at /home/libreoffice/vcl/unx/kde4/KDESalDisplay.hxx:42 #4 0x77ea36cf in KDEXLib::Yield(bool, bool) (this=0x537970, bWait=, bHandleAllCurrentEvents=) at /home/libreoffice/vcl/unx/kde4/KDEXLib.cxx:289 #5 0x745c4cf2 in ImplYield(bool, bool) (i_bWait=i_bWait@entry=true, i_bAllEvents=i_bAllEvents@entry=false) at /home/libreoffice/vcl/source/app/svapp.cxx:439 #6 0x745c534c in Application::Yield() () at /home/libreoffice/vcl/source/app/svapp.cxx:503 #7 0x745c6a85 in Application::Execute() () at /home/libreoffice/vcl/source/app/svapp.cxx:420 #8 0x77ee1de3 in desktop::Desktop::Main() (this=0x7fffdc60) at /home/libreoffice/desktop/source/app/app.cxx:1637 #9 0x745ccf46 in ImplSVMain() () at /home/libreoffice/vcl/source/app/svmain.cxx:199 #10 0x77f08cf1 in soffice_main() () at /home/libreoffice/desktop/source/app/sofficemain.cxx:169 #11 0x0040107b in sal_main () at /home/libreoffice/desktop/source/app/main.c:48 #12 0x0040107b in main (argc=, argv=) at /home/libreoffice/desktop/source/app/main.c:47 Thread 17 (Thread 0x7fffdf826700 (LWP 9612)): #0 0x77c7c567 in pthread_cond_timedwait@@GLIBC_2.3.2 () at /lib64/libpthread.so.0 #1 0x77fa2718 in osl_waitCondition(oslCondition, TimeValue const*) (Condition=0x232d540, pTimeout=pTimeout@entry=0x7fffdf825a80) at /home/libreoffice/sal/osl/unx/conditn.cxx:200 #2 0x7fffe470fe4d in osl::Condition::wait(TimeValue const*) (this=, pTimeout=0x7fffdf825a80) at /home/libreoffice/include/osl/conditn.hxx:123 #3 0x7fffe470fe4d in osl::Condition::wait(TimeValue const&) (timeout=..., this=) at /home/libreoffice/include/osl/conditn.hxx:123 #4 0x7fffe470fe4d in configmgr::Components::WriteThread::execute() (this=0x232ad00) at /home/libreoffice/configmgr/source/components.cxx:183 #5 0x76cebaa6 in salhelper::Thread::run() (this=0x232ad00) at /home/libreoffice/salhelper/source/thread.cxx:40 #6 0x76cebc3a in osl::threadFunc(void*) (param=0x232ad10) at /home/libreoffice/include/osl/thread.hxx:185 #7 0x77fae438 in osl_thread_start_Impl(void*) (pData=0x232af00) at /home/libreoffice/sal/osl/unx/thread.cxx:235 #8 0x77c7617e in start_thread () at /lib64/libpthread.so.0 #9 0x77da585f in clone () at /lib64/libc.so.6 Thread 6 (Thread 0x7fffe1dee700 (LWP 9601)): #0 0x77d99aa9 in poll () at /lib64/libc.so.6 #1 0x7fffeb2bdd53 in x11::SelectionManager::dispatchEvent(int) (this=0x194bb20, millisec=-1) at /home/libreoffice/vcl/unx/generic/dtrans/X11_selection.cxx:3608 #2 0x7fffeb2bdf9c in x11::SelectionManager::run(void*) (pThis=0x194bb20) at /home/libreoffice/vcl/unx/generic/dtrans/X11_selection.cxx:3645 #3 0x77fae438 in osl_thread_start_Impl(void*) (pData=0x195e950) at /home/libreoffice/sal/osl/unx/thread.cxx:235 #4 0x77c7617e in start_thread () at /lib64/libpthread.so.0 #5 0x77da585f in clone () at /lib64/libc.so.6 Thread 5 (Thread 0x7fffe434d700 (LWP 9600)): #0 0x77d99aa9 in poll () at /lib64/libc.so.6 #1 0x7fffeb2a1429
[Libreoffice-bugs] [Bug 122561] LibreOffice crashes at start of second document.
https://bugs.documentfoundation.org/show_bug.cgi?id=122561 --- Comment #7 from Lifeisgreat --- Oki, I guess it solved it for some reason...at least it does not crash now. So not sure what had happened. It had been a while since I had restarted the laptop... Sorry guys I know should have tried this first but I didn't think about even I'm an IT-guy myself :) Thx BTW...love you guys' work with Libreoffice! Have used it for several years now...it's getting better and better and I recommend it to everyone who asks for advice :) Happy New Year to all of you :) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122260] EDITING Autofilters not properly cleared
https://bugs.documentfoundation.org/show_bug.cgi?id=122260 --- Comment #3 from Maddes --- Still an issue in latest rc 6.2.0.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119996] Remove support for GNOME Shell application menu
https://bugs.documentfoundation.org/show_bug.cgi?id=119996 --- Comment #5 from Björn Michaelsen --- Hint: To revert these changes, go though the list of commits provided above and run `git revert` for each one top-to-bottom (that is in reverse chronological order). That is: git revert b163772e77e64261b62a9e8196799a499e4ef77d git revert 4843d5e8865d2f63f408f464e28be9440cb1ecc2 ... Resolve any conflicts and ensure the result builds still ;) (might be done on gerrit) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103703] When printing multiple duplex copies of a document with odd pages, the first page is printed on the back of the last page of the first copy
https://bugs.documentfoundation.org/show_bug.cgi?id=103703 Cor Nouws changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #9 from Cor Nouws --- (In reply to Cor Nouws from comment #8) > (In reply to Dr. Martinus from comment #0) > > > 1|2 3|4 5|1 2|3 4|5 1|2 3|4 5|1 2|3 4|5 > > > > It should be: > > > > 1|2 3|4 5|- 1|2 3|4 5|- 1|2 3|4 5|- 1|2 3|4 5|- > > Writer does automatically insert balk pages for that goal. > Tools > Options > Writer > Print .. Other: Print automatically inserted > blank pages. Thus basically I would suggest: notABug ..? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103703] When printing multiple duplex copies of a document with odd pages, the first page is printed on the back of the last page of the first copy
https://bugs.documentfoundation.org/show_bug.cgi?id=103703 Cor Nouws changed: What|Removed |Added CC||c...@nouenoff.nl --- Comment #8 from Cor Nouws --- (In reply to Dr. Martinus from comment #0) > 1|2 3|4 5|1 2|3 4|5 1|2 3|4 5|1 2|3 4|5 > > It should be: > > 1|2 3|4 5|- 1|2 3|4 5|- 1|2 3|4 5|- 1|2 3|4 5|- Writer does automatically insert balk pages for that goal. Tools > Options > Writer > Print .. Other: Print automatically inserted blank pages. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122435] LibreOffice hangs when in Calc copying formula while in edit mode then leaving field with escape
https://bugs.documentfoundation.org/show_bug.cgi?id=122435 --- Comment #4 from Maddes --- Created attachment 148228 --> https://bugs.documentfoundation.org/attachment.cgi?id=148228=edit Sheets file to reproduce issue -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122435] LibreOffice hangs when in Calc copying formula while in edit mode then leaving field with escape
https://bugs.documentfoundation.org/show_bug.cgi?id=122435 Maddes changed: What|Removed |Added Attachment #147956|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122435] LibreOffice hangs when in Calc copying formula while in edit mode then leaving field with escape
https://bugs.documentfoundation.org/show_bug.cgi?id=122435 --- Comment #3 from Maddes --- Recognized that in Step it should be "...and replace each $2 with $9" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122435] LibreOffice hangs when in Calc copying formula while in edit mode then leaving field with escape
https://bugs.documentfoundation.org/show_bug.cgi?id=122435 --- Comment #2 from Maddes --- Still an issue in latest 6.2.0.2. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122644] New: UI almost unresponsive, "buzzing" buttons, when opening attached spreadsheet (regression)
https://bugs.documentfoundation.org/show_bug.cgi?id=122644 Bug ID: 122644 Summary: UI almost unresponsive, "buzzing" buttons, when opening attached spreadsheet (regression) Product: LibreOffice Version: 6.3.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jim.av...@gmail.com Description: This started happening with latest master. Did not happen a week ago, or with 6.2. When the attached spreadsheet is opened, clicking in cells does not (usually) move the black selection rectangle. The row/column headers highlight as expected, but the selection indicator stays stuck on the wrong cell. Meanwhile, some of the buttons are "buzzing" (vibrating) as if being repeatedly re-rendered at high frequency. This occurs with macros disabled, so it can not (hopefully) be due to macro code. Steps to Reproduce: 1. Open attached spreadsheet (buzz.ods) Do NOT enable macros. 2. Open tab _PROTO (should already be open there) 3. Click in some empty cells, eg. G16 and nearby Actual Results: The cell is selected, but the black rectangle indicating that it is selected does not appear, or appears on some other cell (stuck from it's previous position). The buttons in the upper left (labeled "MO, ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122644] UI almost unresponsive, "buzzing" buttons, when opening attached spreadsheet (regression)
https://bugs.documentfoundation.org/show_bug.cgi?id=122644 --- Comment #1 from Jim Avera --- Created attachment 148227 --> https://bugs.documentfoundation.org/attachment.cgi?id=148227=edit Spreadsheet causing problem (buzz.ods). See "Steps to Reproduce" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120284] Autocorrection wrong at word tail - looks it loose first char of pattern when no space before
https://bugs.documentfoundation.org/show_bug.cgi?id=120284 alexrayne changed: What|Removed |Added Version|6.0.5.2 release |6.1.2.1 release --- Comment #3 from alexrayne --- >Eugenio zoppè Well, i try new version v6.1.2.1 with same results. Maybe significant that i use russian windows 8.1 and russian build of LibreOffice? this bug reproduces even on English US language: by default english autocorrection dictionary have rule about "<->" 1) type " <-> " - this leads autocorrection -> ↔ 2) type " a<-> " - this produces " a<→ " 3) type " a<->." - this produces " a<→." 4) type " a<->/" - this nothing chages So, you see: - any letter before autocoreection pattern breacs first char. - autocorrection works only on whole word. pattern word must be noted with space or delimiters. contrary, MS windows autocorrection works perfecty - pattern triggers in any position of typed text, and replaces directly on typing. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37281] emf file display yellow square instead of yelow circle
https://bugs.documentfoundation.org/show_bug.cgi?id=37281 --- Comment #12 from Telesto --- Repro Version: 6.3.0.0.alpha0+ Build ID: 6e5c4001c7b5cab2b2cc6419072acbe5fa7cb04a CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/test sw/CppunitTest_sw_apitests.mk sw/qa test/source
include/test/unoapi_property_testers.hxx | 20
sw/CppunitTest_sw_apitests.mk|1
sw/qa/api/ApiTestBase.hxx| 29 ++
sw/qa/api/DocumentSettings.cxx | 99 +
sw/qa/api/DocumentSettingsTest.hxx | 49 ++
sw/qa/api/PrinterSettingsTest.hxx| 81 +
sw/qa/api/SettingsTest.hxx | 140 +++
test/source/unoapi_property_testers.cxx | 26 +
8 files changed, 445 insertions(+)
New commits:
commit 4631c5d4c129b826df1cc29af1a558149b823667
Author: Tomaž Vajngerl
AuthorDate: Sun Jan 6 21:59:21 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Thu Jan 10 20:11:21 2019 +0100
DocumentSettings Writer UNO API test (converted from Java test)
Change-Id: Id9a691b1aae62f37ef7f865c5ed015b7c6a13976
Reviewed-on: https://gerrit.libreoffice.org/65909
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/test/unoapi_property_testers.hxx
b/include/test/unoapi_property_testers.hxx
index f45b772b86e3..4d83e8179ce4 100644
--- a/include/test/unoapi_property_testers.hxx
+++ b/include/test/unoapi_property_testers.hxx
@@ -75,6 +75,16 @@ void OOO_DLLPUBLIC_TEST
testLongProperty(css::uno::Reference const&
xPropertySet,
const OUString& name, const sal_Int32& nValue = 42);
+/** @brief Tester for optional property type 'long' of a @see
com::sun::star::beans::XPropertySet.
+ *
+ * @param xPropertySetThe property set, which contains the property to
test against.
+ * @param nameName of property to test.
+ * @param nValue Value to use when setting a new value.
+ */
+void OOO_DLLPUBLIC_TEST
+testLongOptionalProperty(css::uno::Reference const&
xPropertySet,
+ const OUString& name, const sal_Int32& nValue = 42);
+
/** @brief Tester for read-only property type 'long' of a @see
com::sun::star::beans::XPropertySet.
*
* @param xPropertySetThe property set, which contains the property to
test against.
@@ -95,6 +105,16 @@ void OOO_DLLPUBLIC_TEST
testShortProperty(css::uno::Reference const&
xPropertySet,
const OUString& name, const sal_Int16& nValue = 42);
+/** @brief Tester for optional property type 'short' of a @see
com::sun::star::beans::XPropertySet.
+ *
+ * @param xPropertySetThe property set, which contains the property to
test against.
+ * @param nameName of property to test.
+ * @param nValue Value to use when setting a new value.
+ */
+void OOO_DLLPUBLIC_TEST
+testShortOptionalProperty(css::uno::Reference const&
xPropertySet,
+ const OUString& name, const sal_Int16& nValue = 42);
+
/** @brief Tester for read-only property type 'short' of a @see
com::sun::star::beans::XPropertySet.
*
* @param xPropertySetThe property set, which contains the property to
test against.
diff --git a/sw/CppunitTest_sw_apitests.mk b/sw/CppunitTest_sw_apitests.mk
index fa0fc26e7d20..595a1940e27f 100644
--- a/sw/CppunitTest_sw_apitests.mk
+++ b/sw/CppunitTest_sw_apitests.mk
@@ -15,6 +15,7 @@ $(eval $(call
gb_CppunitTest_use_external,sw_apitests,boost_headers))
$(eval $(call gb_CppunitTest_add_exception_objects,sw_apitests, \
sw/qa/api/SwXDocumentIndex \
+sw/qa/api/DocumentSettings \
))
$(eval $(call gb_CppunitTest_use_libraries,sw_apitests, \
diff --git a/sw/qa/api/ApiTestBase.hxx b/sw/qa/api/ApiTestBase.hxx
index 7687ff3f..fc25bc3122be 100644
--- a/sw/qa/api/ApiTestBase.hxx
+++ b/sw/qa/api/ApiTestBase.hxx
@@ -11,6 +11,9 @@
#define INCLUDED_SW_QA_CORE_APITESTBASE_HXX
#include
+#include
+#include
+#include
#include
@@ -19,6 +22,32 @@ namespace apitest
class ApiTestBase
{
protected:
+static bool extstsProperty(css::uno::Reference
const& rxPropertySet,
+ OUString const& rPropertyName)
+{
+css::uno::Reference xPropertySetInfo(
+rxPropertySet->getPropertySetInfo());
+return xPropertySetInfo->hasPropertyByName(rPropertyName);
+}
+
+static bool
+isPropertyReadOnly(css::uno::Reference const&
rxPropertySet,
+ OUString const& rPropertyName)
+{
+css::uno::Reference xPropertySetInfo(
+rxPropertySet->getPropertySetInfo());
+css::uno::Sequence xProperties =
xPropertySetInfo->getProperties();
+
+for (auto const& rProperty : xProperties)
+{
+if (rProperty.Name == rPropertyName)
+return (rProperty.Attributes &
com::sun::star::beans::PropertyAttribute::READONLY)
+ != 0;
+}
+
+return false;
+}
+
virtual ~ApiTestBase() {}
virtual std::unordered_map> init() = 0;
diff --git a/sw/qa/api/DocumentSettings.cxx b/sw/qa/api/DocumentSettings.cxx
new file mode 100644
index ..901730d0d65d
--- /dev/null
+++
[Libreoffice-bugs] [Bug 122457] Worse text rendering in newer versions of LibreOffice (OpenGL)
https://bugs.documentfoundation.org/show_bug.cgi?id=122457 Buovjaga changed: What|Removed |Added Summary|Worse text rendering in |Worse text rendering in |newer versions of |newer versions of |LibreOffice |LibreOffice (OpenGL) --- Comment #14 from Buovjaga --- >From Sam's sample documents we see in 5.1 he is not using OpenGL and in 6.1 he is (Sam: please next time just select & copy the text from the About window and do not bother to take a screenshot). LibreTraining: are you using OpenGL or not? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122457] Worse text rendering in newer versions of LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=122457 Buovjaga changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #13 from Buovjaga --- (In reply to LibreTraining from comment #11) > Created attachment 148187 [details] > LibreOffice 5.1 cleartype full color aliasing > > > The LibreOffice 5.1 Cleartype full-color aliasing looks much better onscreen. This is what I get with 6.1 and 6.3. Cleartype is on (Win 10). I wonder, why we get different results? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122643] Crash in: libc-2.27.so after setting Named Ranges to e.g. F:F (non-absolute columns)
https://bugs.documentfoundation.org/show_bug.cgi?id=122643 Jim Avera changed: What|Removed |Added Summary|Crash in: libc-2.27.so |Crash in: libc-2.27.so ||after setting Named Ranges ||to e.g. F:F (non-absolute ||columns) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122643] New: Crash in: libc-2.27.so
https://bugs.documentfoundation.org/show_bug.cgi?id=122643 Bug ID: 122643 Summary: Crash in: libc-2.27.so Product: LibreOffice Version: 6.3.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jim.av...@gmail.com Created attachment 148226 --> https://bugs.documentfoundation.org/attachment.cgi?id=148226=edit Spreadsheet which causes the crash (OT.ods) This bug was filed from the crash reporting server and is br-9afd5496-22fd-4080-b6a2-c57c7afe989c. = Crashes immediately when LO is started on the attached spreadsheet. Previously, this spreadsheet had many Named Ranges of the form Name => $F:$F that is, defining Name to be column F in this example. However if a preceding column was deleted (for example column C), then the Named ranges were broken because they were not adjusted (in this example, Name was not adjusted to be $E:$E). I tried to fix this problem by removing the "$" prefix from all the named range definitions, so they were of the form Name => F:F and then saved the spreadsheet. Afterwards, any attempt to open the spreadsheet caused an immediate crash. STEPS TO REPRODUCE: 1. Open attached spreadsheet RESULTS: Immediate crash, message saying LO was saving files but no files listed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121026] Horizontal table borders appear slightly fatter compared to vertical lines and compared to previous versions
https://bugs.documentfoundation.org/show_bug.cgi?id=121026 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||1241 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121241] MacOS: table borders aren't black but grayish ( zoom level < 150% )
https://bugs.documentfoundation.org/show_bug.cgi?id=121241 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||1026 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/qa
vcl/qa/cppunit/complextext.cxx |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
New commits:
commit 647ad220295e16e05333e4eb801e1c8eac2d77f9
Author: Mike Kaganski
AuthorDate: Thu Jan 10 13:31:08 2019 +0100
Commit: Mike Kaganski
CommitDate: Thu Jan 10 19:41:07 2019 +0100
Revert "Try fixing VclComplexTextTest::testArabic by rescheduling"
Apparently, this patch was ineffective, and wrong, as Jan-Marek
told.
https://ci.libreoffice.org/job/gerrit_windows/25682/consoleFull#1607778044d893063f-7f3d-4b7e-b56f-4e0f225817cd
https://ci.libreoffice.org/job/gerrit_windows/25549/consoleFull#1607778044d893063f-7f3d-4b7e-b56f-4e0f225817cd
https://ci.libreoffice.org/job/gerrit_windows/25531/consoleFull#1607778044d893063f-7f3d-4b7e-b56f-4e0f225817cd
https://ci.libreoffice.org/job/gerrit_windows/25489/consoleFull#1607778044d893063f-7f3d-4b7e-b56f-4e0f225817cd
https://ci.libreoffice.org/job/gerrit_windows/25434/consoleFull#1607778044d893063f-7f3d-4b7e-b56f-4e0f225817cd
This reverts commit 68259f3663ba61a5f15f04793ac32a200100a8a5.
Change-Id: Ibcb804b0b52339d6977c80129b10adb309514dbc
Reviewed-on: https://gerrit.libreoffice.org/66088
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/vcl/qa/cppunit/complextext.cxx b/vcl/qa/cppunit/complextext.cxx
index fdc9064c858d..96332585673b 100644
--- a/vcl/qa/cppunit/complextext.cxx
+++ b/vcl/qa/cppunit/complextext.cxx
@@ -18,7 +18,6 @@ static std::ostream& operator<<(std::ostream& rStream, const
std::vector&
#include
#include
-#include
#include
// workaround MSVC2015 issue with std::unique_ptr
#include
@@ -26,7 +25,7 @@ static std::ostream& operator<<(std::ostream& rStream, const
std::vector&
#include
#include
-#if HAVE_MORE_FONTS
+#if !defined(_WIN32) && HAVE_MORE_FONTS
static std::ostream& operator<<(std::ostream& rStream, const
std::vector& rVec)
{
rStream << "{ ";
@@ -81,17 +80,19 @@ void VclComplexTextTest::testArabic()
OutputDevice *pOutDev = pWin.get();
pOutDev->SetFont( aFont );
-Application::Reschedule(true); // FIXME: workaround for a
threading/event-handling (?) problem
// absolute character widths AKA text array.
+#if !defined(_WIN32)
std::vector aRefCharWidths {6, 9, 16, 16, 22, 22, 26, 29, 32, 32,
36, 40, 49, 53, 56, 63, 63, 66, 72, 72};
std::vector aCharWidths(aOneTwoThree.getLength(), 0);
long nTextWidth = pOutDev->GetTextArray(aOneTwoThree, aCharWidths.data());
CPPUNIT_ASSERT_EQUAL(aRefCharWidths, aCharWidths);
+// this sporadically returns 75 or 74 on some of the windows tinderboxes
eg. tb73
CPPUNIT_ASSERT_EQUAL(72L, nTextWidth);
CPPUNIT_ASSERT_EQUAL(nTextWidth, aCharWidths.back());
+#endif
// text advance width and line height
CPPUNIT_ASSERT_EQUAL(72L, pOutDev->GetTextWidth(aOneTwoThree));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 121235] [META] Regressions introduced by buffering SystemDependent GraphicData
https://bugs.documentfoundation.org/show_bug.cgi?id=121235 Aron Budea changed: What|Removed |Added Depends on||122384 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122384 [Bug 122384] Lines created in Draw are not visible when printed (Windows-only) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122384] Lines created in Draw are not visible when printed (Windows-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=122384 Aron Budea changed: What|Removed |Added Blocks||121235 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=121235 [Bug 121235] [META] Regressions introduced by buffering SystemDependent GraphicData -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104816] Inserting a user field will lose the condition of section
https://bugs.documentfoundation.org/show_bug.cgi?id=104816 --- Comment #10 from Justin L --- proposed fix at https://gerrit.libreoffice.org/66128 The (In reply to Justin L from comment #9) > make sure deleting all visible paragraphs doesn't crash Writer This was from an assert, so it doesn't crash non-debug builds. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106788] Libreoffice kde4 file save dialog allows newline characters in file name
https://bugs.documentfoundation.org/show_bug.cgi?id=106788 --- Comment #12 from Buovjaga --- It seems the kde5 save dialog does not behave like this. Arch Linux 64-bit Version: 6.3.0.0.alpha0+ Build ID: c2d59ec2832c8b51568e73e9314ab9c82f1f5b7b CPU threads: 8; OS: Linux 4.20; UI render: default; VCL: kde5; Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US Calc: threaded Built on 8 January 2019 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
