Re: Could not determine MSC version (Visual Studio 2017)
On 24/01/2019 21:04, julien2412 wrote: Here what I did to avoid language pb: export LANG=C make clean make Here are the last lines: [build ULF] C:/BLP/libo-core/workdir/ScpMergeTarget/scp2/source/writer/registryitem_writer.ulf [build ULF] C:/BLP/libo-core/workdir/ScpMergeTarget/scp2/source/winexplorerext/module_winexplorerext.ulf [build MO ] sdfr [build MO ] sfxfr [build ULF] C:/BLP/libo-core/workdir/CustomTarget/shell/source/win32/shlxthandler/res/shlxthdl.ulf [build MO ] smfr [build MO ] svlfr [build MO ] svtfr [build MO ] svxfr [build MO ] swfr [build MOD] ucbhelper [build MO ] uuifr [build MO ] vclfr [build PRP] CustomTarget/wizards/locproperties/resources_fr.properties [build PRP] CustomTarget/wizards/locproperties/resources_qtz.properties [build MO ] wizfr [build MO ] wptfr [build MO ] xscfr [build PAT] libxslt [build UIC] modules/dbapp make[2]: warning: -jN forced in submake: disabling jobserver mode. expr: syntax error expr: syntax error expr: syntax error checking build system type... x86_64-unknown-cygwin checking host system type... x86_64-unknown-cygwin checking target system type... x86_64-unknown-cygwin checking for cl... cl configure: error: Could not determine MSC version. make[2]: *** [Makefile:129: ../nspr/out/config.status] Error 1 It seems it's quite at random since the build runned a longer time. From "make[2]: *** [Makefile:129: ../nspr/out/config.status] Error 1" it looks like this is a failure during configure of external/nss. workdir/UnpackedTarball/nss/nspr/out/config.log might contain a clue as to why it fails for you. I'll try "make -O" tomorrow. Always use -O. It doesn't make any difference for failing vs. not failing, it just makes sure that the output from recipes that make runs in parallel don't all write to the same stdout/stderr in parallel. Not using -O leads to garbled output, making it hard to tell which make target exactly failed in what way. remarks: - building with Cygwin was taking a lot memory (I got 8GB) and, contrary to Linux building, I saw a lot of "include file" in console. (perhaps both are linked) Those "include file" lines should be from invoking cl with /showincludes (which we use for dependency tracking, similar to GCC -MD). No idea why they (or at least lots of them) show up on stdout/stderr for you, though. - also when using Ctrl-C on cygwin to stop the process then close cygwin, it seems it doesn't stop process and so doesn't free memory ; ie I could see several "make" process on tasks manager. Yes, that's a well-known issue. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 122944] Invalid render of doc
https://bugs.documentfoundation.org/show_bug.cgi?id=122944 --- Comment #4 from Vitaly Zdanevich --- Also preview is correct on macOS (like on Google Drive). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122944] Invalid render of doc
https://bugs.documentfoundation.org/show_bug.cgi?id=122944 --- Comment #3 from Vitaly Zdanevich --- Created attachment 148617 --> https://bugs.documentfoundation.org/attachment.cgi?id=148617=edit doc -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122945] New: VIEWING: Worksheet tab colours not shown in Excel 2007 spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=122945 Bug ID: 122945 Summary: VIEWING: Worksheet tab colours not shown in Excel 2007 spreadsheet Product: LibreOffice Version: 6.1.4.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: b...@air.net.au Description: I have a spreadsheet created with Excel (in .xlsx format). In Excel, the various worksheet tabs are shown in a variety of colours. When opening this spreadsheet in LibreOffice, the tab colours are not shown. The file command reports: foo.xlsx: Microsoft Excel 2007+ Steps to Reproduce: 1. Open the .xlsx file in LibreOffice. 2. Note that tabs are not rendered in the correct colour(s). Actual Results: Tabs are shown in the default colour. Expected Results: Tabs should be shown in the colours as I see them in Excel. Reproducible: Always User Profile Reset: Yes Additional Info: I will try to make a reproducible file that I can attach here. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122944] Invalid render of doc
https://bugs.documentfoundation.org/show_bug.cgi?id=122944 --- Comment #1 from Vitaly Zdanevich --- Created attachment 148615 --> https://bugs.documentfoundation.org/attachment.cgi?id=148615=edit Correct render from Google Doc -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122944] Invalid render of doc
https://bugs.documentfoundation.org/show_bug.cgi?id=122944 --- Comment #2 from Vitaly Zdanevich --- Created attachment 148616 --> https://bugs.documentfoundation.org/attachment.cgi?id=148616=edit Invalid render (just opened) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: oox/source solenv/clang-format
oox/source/shape/WpsContext.cxx | 319 +---
oox/source/shape/WpsContext.hxx |9 -
solenv/clang-format/blacklist |2
3 files changed, 176 insertions(+), 154 deletions(-)
New commits:
commit 83f3706bf489a3ed37880353ca5ea90638c38fe7
Author: Miklos Vajna
AuthorDate: Thu Jan 24 21:25:24 2019 +0100
Commit: Miklos Vajna
CommitDate: Fri Jan 25 08:41:42 2019 +0100
oox: turn on clang-format for WpsContext
This had manual consistent formatting. Recently it was broken, so bring
back consisency by using clang-format.
Change-Id: I742f9a4f328a7455f2e2c7dde4e3cb2624eb9178
Reviewed-on: https://gerrit.libreoffice.org/66885
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/oox/source/shape/WpsContext.cxx b/oox/source/shape/WpsContext.cxx
index 069c6386462d..19b413f5c329 100644
--- a/oox/source/shape/WpsContext.cxx
+++ b/oox/source/shape/WpsContext.cxx
@@ -34,196 +34,221 @@ namespace oox
{
namespace shape
{
-
-WpsContext::WpsContext(ContextHandler2Helper const& rParent,
uno::Reference xShape, const drawingml::ShapePtr&
pMasterShapePtr, const drawingml::ShapePtr& pShapePtr )
-: ShapeContext( rParent, pMasterShapePtr, pShapePtr ),
- mxShape(std::move(xShape))
+WpsContext::WpsContext(ContextHandler2Helper const& rParent,
uno::Reference xShape,
+ const drawingml::ShapePtr& pMasterShapePtr,
+ const drawingml::ShapePtr& pShapePtr)
+: ShapeContext(rParent, pMasterShapePtr, pShapePtr)
+, mxShape(std::move(xShape))
{
mpShapePtr->setWps(true);
}
WpsContext::~WpsContext() = default;
-oox::core::ContextHandlerRef WpsContext::onCreateContext(sal_Int32
nElementToken, const oox::AttributeList& rAttribs)
+oox::core::ContextHandlerRef WpsContext::onCreateContext(sal_Int32
nElementToken,
+ const
oox::AttributeList& rAttribs)
{
switch (getBaseToken(nElementToken))
{
-case XML_wsp:
-break;
-case XML_cNvCnPr:
-break;
-case XML_bodyPr:
-if (mxShape.is())
-{
-uno::Reference xServiceInfo(mxShape,
uno::UNO_QUERY);
-uno::Reference xPropertySet(mxShape,
uno::UNO_QUERY);
-OptValue oVert = rAttribs.getString(XML_vert);
-if (oVert.has() && oVert.get() == "vert270")
+case XML_wsp:
+break;
+case XML_cNvCnPr:
+break;
+case XML_bodyPr:
+if (mxShape.is())
{
-if
(xServiceInfo->supportsService("com.sun.star.text.TextFrame"))
+uno::Reference xServiceInfo(mxShape,
uno::UNO_QUERY);
+uno::Reference xPropertySet(mxShape,
uno::UNO_QUERY);
+OptValue oVert = rAttribs.getString(XML_vert);
+if (oVert.has() && oVert.get() == "vert270")
{
-// No support for this in core, work around by char
rotation, as we do so for table cells already.
-uno::Reference xText(mxShape, uno::UNO_QUERY);
-uno::Reference xTextCursor =
xText->createTextCursor();
-xTextCursor->gotoStart(false);
-xTextCursor->gotoEnd(true);
-uno::Reference
xPropertyState(xTextCursor, uno::UNO_QUERY);
-beans::PropertyState aState =
xPropertyState->getPropertyState("CharRotation");
-if (aState == beans::PropertyState_DEFAULT_VALUE)
+if
(xServiceInfo->supportsService("com.sun.star.text.TextFrame"))
{
-uno::Reference
xTextCursorPropertySet(xTextCursor, uno::UNO_QUERY);
-
xTextCursorPropertySet->setPropertyValue("CharRotation",
uno::makeAny(sal_Int16(900)));
+// No support for this in core, work around by char
rotation, as we do so for table cells already.
+uno::Reference xText(mxShape,
uno::UNO_QUERY);
+uno::Reference xTextCursor =
xText->createTextCursor();
+xTextCursor->gotoStart(false);
+xTextCursor->gotoEnd(true);
+uno::Reference
xPropertyState(xTextCursor,
+
uno::UNO_QUERY);
+beans::PropertyState aState
+= xPropertyState->getPropertyState("CharRotation");
+if (aState == beans::PropertyState_DEFAULT_VALUE)
+{
+uno::Reference
xTextCursorPropertySet(
+xTextCursor, uno::UNO_QUERY);
+
xTextCursorPropertySet->setPropertyValue("CharRotation",
+
uno::makeAny(sal_Int16(900)));
+
[Libreoffice-bugs] [Bug 122944] New: Invalid render of doc
https://bugs.documentfoundation.org/show_bug.cgi?id=122944 Bug ID: 122944 Summary: Invalid render of doc Product: LibreOffice Version: 6.0.7.3 release Hardware: x86 (IA32) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: zdanevich.vit...@ya.ru Description: You can see defect on my attachment. Steps to Reproduce: Fresh install of LibreOffice Writer (through the apt) on Lubuntu 18.04.1. Actual Results: See the attached file (sorry that a photo - not a screenshot). Expected Results: Correct render (for example like in Google Doc, file attached also). Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/cib_contract57c' - 46 commits - basic/source configure.ac cui/source dbaccess/source desktop/source dictionaries download.lst embeddedobj/source extensi
Rebased ref, commits from common ancestor:
commit a331973da8e84dd93c38e3f97389e6a620b07c2d
Author: Samuel Mehrbrodt
AuthorDate: Thu Jan 24 15:52:47 2019 +0100
Commit: Samuel Mehrbrodt
CommitDate: Fri Jan 25 08:38:24 2019 +0100
tdf#122607 Don't unnecessarily redo the layout
Brings weird issues like out of place textboxes as described in the bug.
Change-Id: I19341efc48188f0b52069401dc39ba05f4fcc7f6
Reviewed-on: https://gerrit.libreoffice.org/66874
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
(cherry picked from commit 1ecca673b40fedc53db125e332b087d1c120a254)
Reviewed-on: https://gerrit.libreoffice.org/66897
Tested-by: Samuel Mehrbrodt
diff --git a/sw/source/uibase/uno/unotxdoc.cxx
b/sw/source/uibase/uno/unotxdoc.cxx
index 6e9701c765eb..066907bea12e 100644
--- a/sw/source/uibase/uno/unotxdoc.cxx
+++ b/sw/source/uibase/uno/unotxdoc.cxx
@@ -2633,10 +2633,6 @@ sal_Int32 SAL_CALL SwXTextDocument::getRendererCount(
if( bStateChanged )
pRenderDocShell->EnableSetModified();
-// there is some redundancy between those two function calls, but
right now
-// there is no time to sort this out.
-//TODO: check what exactly needs to be done and make just one
function for that
-pViewShell->CalcLayout();
pViewShell->CalcPagesForPrint( pViewShell->GetPageCount() );
// #122919# Force field update before PDF export, but after layout
init (tdf#121962)
commit 5d76f9bf66d6f8883a1658e134b546d9448e1c2a
Author: Noel Grandin
AuthorDate: Tue Jun 5 14:16:23 2018 +0200
Commit: Samuel Mehrbrodt
CommitDate: Fri Jan 25 08:38:23 2019 +0100
hold LogicalFontInstance with rtl::Reference
instead of manual reference counting.
Also the releasing of not-currently-in-use LogicalFontInstance objects
from the cache is made less aggressive - we now only flush entries until
we have less than CACHE_SIZE instances, instead of flushing the whole
cache.
Reviewed-on: https://gerrit.libreoffice.org/55384
Tested-by: Jenkins
Reviewed-by: Noel Grandin
(cherry picked from commit c4c56de1b0e62ec866b519b2b24c5e805f0a86d3)
Change-Id: Ib235b132776b5f09ae8ae93a933c2eebe5fa9610
diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index 174987e51757..93a3ce610c32 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -332,7 +332,7 @@ private:
mutable VclPtrmpPrevGraphics; ///< Previous output
device in list
mutable VclPtrmpNextGraphics; ///< Next output
device in list
GDIMetaFile*mpMetaFile;
-mutable LogicalFontInstance*mpFontInstance;
+mutable rtl::Reference mpFontInstance;
mutable ImplFontCache* mpFontCache;
mutable PhysicalFontCollection* mpFontCollection;
mutable std::unique_ptr mpDeviceFontList;
diff --git a/vcl/inc/PhysicalFontFace.hxx b/vcl/inc/PhysicalFontFace.hxx
index 2406b6cf41da..e289345716ca 100644
--- a/vcl/inc/PhysicalFontFace.hxx
+++ b/vcl/inc/PhysicalFontFace.hxx
@@ -54,7 +54,7 @@ public:
class VCL_PLUGIN_PUBLIC PhysicalFontFace : public FontAttributes, public
salhelper::SimpleReferenceObject
{
public:
-virtual LogicalFontInstance* CreateFontInstance(const FontSelectPattern&)
const;
+virtual rtl::Reference CreateFontInstance(const
FontSelectPattern&) const;
virtual rtl::Reference Clone() const = 0;
int GetHeight() const { return mnHeight; }
diff --git a/vcl/inc/fontinstance.hxx b/vcl/inc/fontinstance.hxx
index 317b7181198d..149bb553c3eb 100644
--- a/vcl/inc/fontinstance.hxx
+++ b/vcl/inc/fontinstance.hxx
@@ -24,6 +24,7 @@
#include "impfontmetricdata.hxx"
#include
+#include
#include
#include
@@ -35,7 +36,7 @@ class PhysicalFontFace;
// TODO: allow sharing of metrics for related fonts
-class VCL_PLUGIN_PUBLIC LogicalFontInstance
+class VCL_PLUGIN_PUBLIC LogicalFontInstance : public
salhelper::SimpleReferenceObject
{
// just declaring the factory function doesn't work AKA
// friend LogicalFontInstance* PhysicalFontFace::CreateFontInstance(const
FontSelectPattern&) const;
@@ -43,7 +44,7 @@ class VCL_PLUGIN_PUBLIC LogicalFontInstance
friend class ImplFontCache;
public: // TODO: make data members private
-virtual ~LogicalFontInstance();
+virtual ~LogicalFontInstance() override;
ImplFontMetricDataRef mxFontMetric;// Font attributes
const ConvertChar* mpConversion;// used e.g. for
StarBats->StarSymbol
@@ -57,9 +58,6 @@ public: // TODO: make data members private
boolGetFallbackForUnicode( sal_UCS4, FontWeight eWeight,
OUString* pFontName ) const;
voidIgnoreFallbackForUnicode( sal_UCS4, FontWeight eWeight,
const OUString& rFontName );
-voidAcquire();
-voidRelease();
-
inline hb_font_t* GetHbFont();
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 Bug 103378 depends on bug 122607, which changed state. Bug 122607 Summary: Frame gets mispositioned when exported to PDF multiple times https://bugs.documentfoundation.org/show_bug.cgi?id=122607 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89207] Cannot change only part of an array
https://bugs.documentfoundation.org/show_bug.cgi?id=89207
--- Comment #4 from russell ---
I just had this problem (expand an array formula) and found this enhancement
request.
I made a selection over an existing array plus new rows, F2, ctrl-shift-enter,
and the array was not expanded to the new rows. They remained empty. Although
the previous array was updated to reflect the new range; Actually when the new
rows were inserted the array formula range changed.
Before: {=C1:C12*D1:D12} Rows: 1-12
After: {=C1:C14*D1:D14}Rows: 1-12, 13-14 Empty
Only way to expand an array formula seems to be to delete it and reenter it.
LO 6.1.4.2
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/cib_contract57c' - sw/source
sw/source/uibase/uno/unotxdoc.cxx |4 1 file changed, 4 deletions(-) New commits: commit 03edd43627157749b38c2ee44b14169d56987408 Author: Samuel Mehrbrodt AuthorDate: Thu Jan 24 15:52:47 2019 +0100 Commit: Samuel Mehrbrodt CommitDate: Fri Jan 25 08:27:19 2019 +0100 tdf#122607 Don't unnecessarily redo the layout Brings weird issues like out of place textboxes as described in the bug. Change-Id: I19341efc48188f0b52069401dc39ba05f4fcc7f6 Reviewed-on: https://gerrit.libreoffice.org/66874 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt (cherry picked from commit 1ecca673b40fedc53db125e332b087d1c120a254) Reviewed-on: https://gerrit.libreoffice.org/66897 Tested-by: Samuel Mehrbrodt diff --git a/sw/source/uibase/uno/unotxdoc.cxx b/sw/source/uibase/uno/unotxdoc.cxx index 6e9701c765eb..066907bea12e 100644 --- a/sw/source/uibase/uno/unotxdoc.cxx +++ b/sw/source/uibase/uno/unotxdoc.cxx @@ -2633,10 +2633,6 @@ sal_Int32 SAL_CALL SwXTextDocument::getRendererCount( if( bStateChanged ) pRenderDocShell->EnableSetModified(); -// there is some redundancy between those two function calls, but right now -// there is no time to sort this out. -//TODO: check what exactly needs to be done and make just one function for that -pViewShell->CalcLayout(); pViewShell->CalcPagesForPrint( pViewShell->GetPageCount() ); // #122919# Force field update before PDF export, but after layout init (tdf#121962) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/ui/chrdlg/drpcps.cxx |4 1 file changed, 4 insertions(+) New commits: commit b8c725cf871b56f74a74dc5d9b193331f98b3f4a Author: Roman Kuznetsov AuthorDate: Sun Jan 20 18:14:19 2019 +0100 Commit: Heiko Tietze CommitDate: Fri Jan 25 08:25:53 2019 +0100 tdf#92154 limit comboBOX_TEMPLATE length Change-Id: Ic43f70181b26c88e07445f7c90a8dadcd99b3108 Reviewed-on: https://gerrit.libreoffice.org/66653 Reviewed-by: Heiko Tietze Tested-by: Jenkins diff --git a/sw/source/ui/chrdlg/drpcps.cxx b/sw/source/ui/chrdlg/drpcps.cxx index d60a0c23e913..04d88c166db6 100644 --- a/sw/source/ui/chrdlg/drpcps.cxx +++ b/sw/source/ui/chrdlg/drpcps.cxx @@ -483,6 +483,10 @@ SwDropCapsPage::SwDropCapsPage(TabPageParent pParent, const SfxItemSet ) const sal_uInt16 nHtmlMode = ::GetHtmlMode(static_cast(SfxObjectShell::Current())); bHtmlMode = (nHtmlMode & HTMLMODE_ON) != 0; +// tdf#92154 limit comboBOX_TEMPLATE length +const int nMaxWidth(m_xTemplateBox->get_approximate_digit_width() * 50); +m_xTemplateBox->set_size_request(nMaxWidth , -1); + // In the template dialog the text is not influenceable m_xTextText->set_sensitive(!bFormat); m_xTextEdit->set_sensitive(!bFormat); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 107642] [META] Paragraph dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107642 Bug 107642 depends on bug 92154, which changed state. Bug 92154 Summary: UI: Long style names affect the width of dialogues https://bugs.documentfoundation.org/show_bug.cgi?id=92154 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/uno/unotxdoc.cxx |4 1 file changed, 4 deletions(-) New commits: commit 1ecca673b40fedc53db125e332b087d1c120a254 Author: Samuel Mehrbrodt AuthorDate: Thu Jan 24 15:52:47 2019 +0100 Commit: Samuel Mehrbrodt CommitDate: Fri Jan 25 08:18:27 2019 +0100 tdf#122607 Don't unnecessarily redo the layout Brings weird issues like out of place textboxes as described in the bug. Change-Id: I19341efc48188f0b52069401dc39ba05f4fcc7f6 Reviewed-on: https://gerrit.libreoffice.org/66874 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt diff --git a/sw/source/uibase/uno/unotxdoc.cxx b/sw/source/uibase/uno/unotxdoc.cxx index 9f2e45c766f8..c2f7f93b1935 100644 --- a/sw/source/uibase/uno/unotxdoc.cxx +++ b/sw/source/uibase/uno/unotxdoc.cxx @@ -2667,10 +2667,6 @@ sal_Int32 SAL_CALL SwXTextDocument::getRendererCount( if( bStateChanged ) pRenderDocShell->EnableSetModified(); -// there is some redundancy between those two function calls, but right now -// there is no time to sort this out. -//TODO: check what exactly needs to be done and make just one function for that -pViewShell->CalcLayout(); pViewShell->CalcPagesForPrint( pViewShell->GetPageCount() ); // #122919# Force field update before PDF export, but after layout init (tdf#121962) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/headless vcl/inc vcl/qt5 vcl/quartz vcl/source vcl/unx vcl/win
vcl/headless/svptext.cxx |4 ++--
vcl/inc/headless/svpgdi.hxx |4 ++--
vcl/inc/qt5/Qt5Graphics.hxx |2 +-
vcl/inc/quartz/salgdi.h |4 ++--
vcl/inc/salgdi.hxx |4 ++--
vcl/inc/textrender.hxx |4 ++--
vcl/inc/unx/cairotextrender.hxx |4 ++--
vcl/inc/unx/genpspgraphics.h |4 ++--
vcl/inc/unx/salgdi.h |4 ++--
vcl/inc/win/salgdi.h |4 ++--
vcl/qt5/Qt5Graphics_Text.cxx |2 +-
vcl/quartz/salgdi.cxx|2 +-
vcl/source/outdev/font.cxx |2 +-
vcl/source/outdev/text.cxx | 11 +++
vcl/unx/generic/gdi/cairotextrender.cxx |2 +-
vcl/unx/generic/gdi/font.cxx |4 ++--
vcl/unx/generic/print/genpspgraphics.cxx |2 +-
vcl/win/gdi/winlayout.cxx|2 +-
18 files changed, 30 insertions(+), 35 deletions(-)
New commits:
commit f205e4530ef4245ee29b934d050c4ac5c2ce7257
Author: Jan-Marek Glogowski
AuthorDate: Thu Jan 24 19:00:10 2019 +
Commit: Jan-Marek Glogowski
CommitDate: Fri Jan 25 08:15:54 2019 +0100
Change SalGraphics::GetTextLayout definition
* drop the unused ImplLayoutArgs argument
* return a std::unique_ptr
Change-Id: I150a2a46f67f1ffbbd3ba0ffa68f5bffb30206c8
Reviewed-on: https://gerrit.libreoffice.org/66884
Tested-by: Jenkins
Reviewed-by: Noel Grandin
Reviewed-by: Jan-Marek Glogowski
diff --git a/vcl/headless/svptext.cxx b/vcl/headless/svptext.cxx
index aead84a1467b..d81dfa19649a 100644
--- a/vcl/headless/svptext.cxx
+++ b/vcl/headless/svptext.cxx
@@ -92,11 +92,11 @@ void SvpSalGraphics::GetGlyphWidths( const
PhysicalFontFace* pFont,
m_aTextRenderImpl.GetGlyphWidths(pFont, bVertical, rWidths, rUnicodeEnc);
}
-std::unique_ptr SvpSalGraphics::GetTextLayout( ImplLayoutArgs&
rArgs, int nFallbackLevel )
+std::unique_ptr SvpSalGraphics::GetTextLayout(int
nFallbackLevel)
{
if (utl::ConfigManager::IsFuzzing())
return nullptr;
-return m_aTextRenderImpl.GetTextLayout(rArgs, nFallbackLevel);
+return m_aTextRenderImpl.GetTextLayout(nFallbackLevel);
}
void SvpSalGraphics::DrawTextLayout(const GenericSalLayout& rLayout)
diff --git a/vcl/inc/headless/svpgdi.hxx b/vcl/inc/headless/svpgdi.hxx
index e62c508d0863..89e141b78d21 100644
--- a/vcl/inc/headless/svpgdi.hxx
+++ b/vcl/inc/headless/svpgdi.hxx
@@ -190,8 +190,8 @@ public:
bool bVertical,
std::vector< sal_Int32 >& rWidths,
Ucs2UIntMap& rUnicodeEnc )
override;
-virtual std::unique_ptr
-GetTextLayout( ImplLayoutArgs&, int nFallbackLevel
) override;
+virtual std::unique_ptr
+GetTextLayout(int nFallbackLevel) override;
virtual voidDrawTextLayout( const GenericSalLayout& ) override;
virtual boolsupportsOperation( OutDevSupportType ) const
override;
virtual voiddrawPixel( long nX, long nY ) override;
diff --git a/vcl/inc/qt5/Qt5Graphics.hxx b/vcl/inc/qt5/Qt5Graphics.hxx
index 9430be94a112..b11f926f72bb 100644
--- a/vcl/inc/qt5/Qt5Graphics.hxx
+++ b/vcl/inc/qt5/Qt5Graphics.hxx
@@ -195,7 +195,7 @@ public:
virtual void GetGlyphWidths(const PhysicalFontFace*, bool bVertical,
std::vector& rWidths, Ucs2UIntMap&
rUnicodeEnc) override;
-virtual std::unique_ptr GetTextLayout(ImplLayoutArgs&, int
nFallbackLevel) override;
+virtual std::unique_ptr GetTextLayout(int
nFallbackLevel) override;
virtual void DrawTextLayout(const GenericSalLayout&) override;
// Native control support
diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h
index cacf56dcb84f..63bf71090c21 100644
--- a/vcl/inc/quartz/salgdi.h
+++ b/vcl/inc/quartz/salgdi.h
@@ -373,8 +373,8 @@ public:
std::vector< sal_Int32 >& rWidths,
Ucs2UIntMap& rUnicodeEnc )
override;
-virtual std::unique_ptr
-GetTextLayout( ImplLayoutArgs&, int nFallbackLevel
) override;
+virtual std::unique_ptr
+GetTextLayout(int nFallbackLevel) override;
virtual voidDrawTextLayout( const GenericSalLayout& ) override;
virtual boolsupportsOperation( OutDevSupportType ) const
override;
diff --git a/vcl/inc/salgdi.hxx b/vcl/inc/salgdi.hxx
index d3d459d058fe..5313f24c73b8 100644
--- a/vcl/inc/salgdi.hxx
+++ b/vcl/inc/salgdi.hxx
@@ -191,8 +191,8 @@ public:
std::vector< sal_Int32 >& rWidths,
Ucs2UIntMap& rUnicodeEnc ) = 0;
-virtual std::unique_ptr
-
[Libreoffice-commits] core.git: compilerplugins/clang connectivity/source sc/inc sc/source sw/inc sw/source
compilerplugins/clang/unusedmethods.results| 250 + compilerplugins/clang/unusedmethods.unused-returns.results | 26 - connectivity/source/drivers/mysqlc/mysqlc_general.cxx |5 connectivity/source/drivers/mysqlc/mysqlc_general.hxx |2 sc/inc/autoform.hxx|1 sc/source/core/tool/autoform.cxx | 11 sw/inc/authfld.hxx |1 sw/source/core/fields/authfld.cxx |5 sw/source/uibase/inc/uitool.hxx|1 sw/source/uibase/utlui/uitool.cxx | 13 10 files changed, 114 insertions(+), 201 deletions(-) New commits: commit 37f8ea642cd191e7bdbf3596f41e7bb28212472b Author: Noel Grandin AuthorDate: Thu Jan 24 14:07:17 2019 +0200 Commit: Noel Grandin CommitDate: Fri Jan 25 08:07:40 2019 +0100 loplugin:unusedmethods Change-Id: Ifb0c479e9d1aed1cd90d78ed23902fc05db556d6 Reviewed-on: https://gerrit.libreoffice.org/66862 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/compilerplugins/clang/unusedmethods.results b/compilerplugins/clang/unusedmethods.results index 9cebe9adfe9e..39dcf5ecc839 100644 --- a/compilerplugins/clang/unusedmethods.results +++ b/compilerplugins/clang/unusedmethods.results @@ -26,6 +26,8 @@ connectivity/source/drivers/firebird/Util.hxx:66 const class rtl::OUString & connectivity::firebird::ColumnTypeInfo::getCharacterSet() const connectivity/source/drivers/mork/mork_helper.cxx:37 int main(int,char **) +connectivity/source/drivers/mysqlc/mysqlc_general.hxx:108 +class rtl::OUString mysqlc_sdbc_driver::mysqlTypeToStr(const struct st_mysql_field *) connectivity/source/inc/dbase/dindexnode.hxx:70 _Bool connectivity::dbase::ONDXKey::operator<(const class connectivity::dbase::ONDXKey &) const connectivity/source/inc/java/sql/Connection.hxx:63 @@ -64,8 +66,6 @@ dbaccess/source/filter/hsqldb/fbalterparser.hxx:20 void dbahsql::FbAlterStmtParser::ensureProperTableLengths() const dbaccess/source/filter/hsqldb/parseschema.hxx:82 const class std::__debug::map >, struct std::less, class std::allocator > > > > & dbahsql::SchemaParser::getPrimaryKeys() const -dbaccess/source/ui/browser/genericcontroller.cxx:1213 -const type-parameter-?-? & dbaui::(anonymous namespace)::SGI_identity::operator()(const type-parameter-?-? &) const dbaccess/source/ui/inc/dsmeta.hxx:88 class __gnu_debug::_Safe_iterator, class std::__debug::set, class std::allocator > > dbaui::FeatureSet::begin() const dbaccess/source/ui/inc/dsmeta.hxx:89 @@ -84,12 +84,8 @@ desktop/inc/lib/init.hxx:47 _Bool desktop::CallbackFlushHandler::isEventLatchOn() const desktop/inc/lib/init.hxx:49 _Bool desktop::CallbackFlushHandler::isPartTilePainting() const -drawinglayer/source/tools/emfpcustomlinecap.hxx:37 +drawinglayer/source/tools/emfpcustomlinecap.hxx:38 void emfplushelper::EMFPCustomLineCap::SetAttributes(struct com::sun::star::rendering::StrokeAttributes &) -drawinglayer/source/tools/emfppen.hxx:71 -void emfplushelper::EMFPPen::SetStrokeWidth(struct com::sun::star::rendering::StrokeAttributes &,const struct emfplushelper::EmfPlusHelperData &,const class basegfx::B2DHomMatrix &) -drawinglayer/source/tools/emfppen.hxx:73 -void emfplushelper::EMFPPen::SetStrokeAttributes(struct com::sun::star::rendering::StrokeAttributes &) drawinglayer/source/tools/emfpstringformat.hxx:51 _Bool emfplushelper::EMFPStringFormat::NoFitBlackBox() const drawinglayer/source/tools/emfpstringformat.hxx:52 @@ -440,12 +436,6 @@ include/i18nlangtag/languagetag.hxx:261 enum LanguageTag::ScriptType LanguageTag::getScriptType() const include/o3tl/any.hxx:155 class boost::optional o3tl::tryAccess(const class com::sun::star::uno::Any &) -include/o3tl/array_view.hxx:62 - o3tl::array_view::array_view(type-parameter-?-? *,unsigned long) -include/o3tl/array_view.hxx:135 -_Bool o3tl::array_view::operator<(const array_view &) const -include/o3tl/array_view.hxx:155 -unsigned long std::hash::operator()(array_view) const include/o3tl/cow_wrapper.hxx:310 type-parameter-?-? * o3tl::cow_wrapper::get() include/o3tl/enumarray.hxx:105 @@ -456,54 +446,8 @@ include/o3tl/enumarray.hxx:135 _Bool o3tl::enumarray_const_iterator::operator==(const enumarray_const_iterator &) const include/o3tl/safeint.hxx:79 typename enable_if::value, type-parameter-?-?>::type o3tl::saturating_sub(type-parameter-?-?,type-parameter-?-?) -include/o3tl/string_view.hxx:172 - o3tl::basic_string_view::basic_string_view() -include/o3tl/string_view.hxx:486 - o3tl::basic_string_view::basic_string_view(const basic_string > &) -include/o3tl/string_view.hxx:628 -_Bool o3tl::operator==(basic_string_view,basic_string_view) -include/o3tl/string_view.hxx:639 -_Bool o3tl::operator==(typename decay
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1-5' - jvmfwk/distributions jvmfwk/plugins
jvmfwk/distributions/OpenOfficeorg/javavendors_freebsd.xml |5 -
jvmfwk/distributions/OpenOfficeorg/javavendors_linux.xml |5 -
jvmfwk/distributions/OpenOfficeorg/javavendors_macosx.xml |5 -
jvmfwk/distributions/OpenOfficeorg/javavendors_unx.xml |5 -
jvmfwk/distributions/OpenOfficeorg/javavendors_wnt.xml |5 -
jvmfwk/plugins/sunmajor/pluginlib/vendorlist.cxx |1 +
6 files changed, 21 insertions(+), 5 deletions(-)
New commits:
commit d801075217375a79ca037df96b3adff5eee5ebd2
Author: himajin10
AuthorDate: Sat Jan 19 14:25:50 2019 +0900
Commit: Noel Grandin
CommitDate: Fri Jan 25 07:59:18 2019 +0100
Support AdoptOpenJDK
Change-Id: Idcfd542c6caede3d987e9b8219cf48114800daa5
Reviewed-on: https://gerrit.libreoffice.org/66634
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
Reviewed-by: Samuel Mehrbrodt
Reviewed-by: Stephan Bergmann
(cherry picked from commit 61c4f96d6ae6a80370774e53287edb27cbce8067)
Reviewed-on: https://gerrit.libreoffice.org/66716
Reviewed-by: Michael Stahl
(cherry picked from commit b9176c5bfa49e565bae4c7f129df59560110242d)
Reviewed-on: https://gerrit.libreoffice.org/66866
Reviewed-by: Thorsten Behrens
Tested-by: Noel Grandin
Reviewed-by: Noel Grandin
diff --git a/jvmfwk/distributions/OpenOfficeorg/javavendors_freebsd.xml
b/jvmfwk/distributions/OpenOfficeorg/javavendors_freebsd.xml
index c603575f3cb8..b05b6c797ea8 100644
--- a/jvmfwk/distributions/OpenOfficeorg/javavendors_freebsd.xml
+++ b/jvmfwk/distributions/OpenOfficeorg/javavendors_freebsd.xml
@@ -17,7 +17,7 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
-->
http://openoffice.org/2004/java/framework/1.0;>
- 2012-07-12
+ 2019-01-19
1.7.0
@@ -31,5 +31,8 @@
1.5.0
+
+ 1.8.0
+
diff --git a/jvmfwk/distributions/OpenOfficeorg/javavendors_linux.xml
b/jvmfwk/distributions/OpenOfficeorg/javavendors_linux.xml
index 969ed01c6c21..b008bb1fc0f7 100644
--- a/jvmfwk/distributions/OpenOfficeorg/javavendors_linux.xml
+++ b/jvmfwk/distributions/OpenOfficeorg/javavendors_linux.xml
@@ -17,7 +17,7 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
-->
http://openoffice.org/2004/java/framework/1.0;>
- 2013-05-02
+ 2019-01-19
1.5.0
@@ -40,5 +40,8 @@
1.6.0
+
+ 1.8.0
+
diff --git a/jvmfwk/distributions/OpenOfficeorg/javavendors_macosx.xml
b/jvmfwk/distributions/OpenOfficeorg/javavendors_macosx.xml
index c2416582a793..1fe7547d2919 100644
--- a/jvmfwk/distributions/OpenOfficeorg/javavendors_macosx.xml
+++ b/jvmfwk/distributions/OpenOfficeorg/javavendors_macosx.xml
@@ -17,7 +17,7 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
-->
http://openoffice.org/2004/java/framework/1.0;>
- 2013-04-09
+ 2019-01-19
1.7.0
@@ -31,5 +31,8 @@
1.6.0
+
+ 1.8.0
+
diff --git a/jvmfwk/distributions/OpenOfficeorg/javavendors_unx.xml
b/jvmfwk/distributions/OpenOfficeorg/javavendors_unx.xml
index fb79c003196e..7771d81527df 100644
--- a/jvmfwk/distributions/OpenOfficeorg/javavendors_unx.xml
+++ b/jvmfwk/distributions/OpenOfficeorg/javavendors_unx.xml
@@ -17,7 +17,7 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
-->
http://openoffice.org/2004/java/framework/1.0;>
- 2011-01-07
+ 2019-01-19
1.7.0
@@ -25,5 +25,8 @@
1.5.0
+
+ 1.8.0
+
diff --git a/jvmfwk/distributions/OpenOfficeorg/javavendors_wnt.xml
b/jvmfwk/distributions/OpenOfficeorg/javavendors_wnt.xml
index 0a37a4ea88a7..429831121f7b 100644
--- a/jvmfwk/distributions/OpenOfficeorg/javavendors_wnt.xml
+++ b/jvmfwk/distributions/OpenOfficeorg/javavendors_wnt.xml
@@ -17,7 +17,7 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
-->
http://openoffice.org/2004/java/framework/1.0;>
- 2013-05-02
+ 2019-01-19
1.6.0
@@ -31,5 +31,8 @@
1.6.0
+
+ 1.8.0
+
diff --git a/jvmfwk/plugins/sunmajor/pluginlib/vendorlist.cxx
b/jvmfwk/plugins/sunmajor/pluginlib/vendorlist.cxx
index 2960d118cf38..56ec3a4e5a43 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/vendorlist.cxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/vendorlist.cxx
@@ -41,6 +41,7 @@ BEGIN_VENDOR_MAP()
#endif
VENDOR_MAP_ENTRY("Sun Microsystems Inc.", SunInfo)
VENDOR_MAP_ENTRY("Oracle Corporation", SunInfo)
+VENDOR_MAP_ENTRY("AdoptOpenJdk", SunInfo)
#ifndef MACOSX
VENDOR_MAP_ENTRY("IBM Corporation", OtherInfo)
VENDOR_MAP_ENTRY("Blackdown Java-Linux Team", OtherInfo)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2-0' - jvmfwk/distributions jvmfwk/plugins
jvmfwk/distributions/OpenOfficeorg/javavendors_freebsd.xml |5 -
jvmfwk/distributions/OpenOfficeorg/javavendors_linux.xml |5 -
jvmfwk/distributions/OpenOfficeorg/javavendors_macosx.xml |5 -
jvmfwk/distributions/OpenOfficeorg/javavendors_unx.xml |5 -
jvmfwk/distributions/OpenOfficeorg/javavendors_wnt.xml |5 -
jvmfwk/plugins/sunmajor/pluginlib/vendorlist.cxx |1 +
6 files changed, 21 insertions(+), 5 deletions(-)
New commits:
commit 48cad228bc08234ce084c2c6b898bcb1546b1ded
Author: himajin10
AuthorDate: Sat Jan 19 14:25:50 2019 +0900
Commit: Noel Grandin
CommitDate: Fri Jan 25 07:59:38 2019 +0100
Support AdoptOpenJDK
Change-Id: Idcfd542c6caede3d987e9b8219cf48114800daa5
Reviewed-on: https://gerrit.libreoffice.org/66634
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
Reviewed-by: Samuel Mehrbrodt
Reviewed-by: Stephan Bergmann
(cherry picked from commit 61c4f96d6ae6a80370774e53287edb27cbce8067)
Reviewed-on: https://gerrit.libreoffice.org/66715
Reviewed-by: Michael Stahl
(cherry picked from commit 273330a55d7cf457da6d7ba9829527a961c40bc0)
Reviewed-on: https://gerrit.libreoffice.org/66881
Reviewed-by: Noel Grandin
Tested-by: Noel Grandin
diff --git a/jvmfwk/distributions/OpenOfficeorg/javavendors_freebsd.xml
b/jvmfwk/distributions/OpenOfficeorg/javavendors_freebsd.xml
index c603575f3cb8..b05b6c797ea8 100644
--- a/jvmfwk/distributions/OpenOfficeorg/javavendors_freebsd.xml
+++ b/jvmfwk/distributions/OpenOfficeorg/javavendors_freebsd.xml
@@ -17,7 +17,7 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
-->
http://openoffice.org/2004/java/framework/1.0;>
- 2012-07-12
+ 2019-01-19
1.7.0
@@ -31,5 +31,8 @@
1.5.0
+
+ 1.8.0
+
diff --git a/jvmfwk/distributions/OpenOfficeorg/javavendors_linux.xml
b/jvmfwk/distributions/OpenOfficeorg/javavendors_linux.xml
index 969ed01c6c21..b008bb1fc0f7 100644
--- a/jvmfwk/distributions/OpenOfficeorg/javavendors_linux.xml
+++ b/jvmfwk/distributions/OpenOfficeorg/javavendors_linux.xml
@@ -17,7 +17,7 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
-->
http://openoffice.org/2004/java/framework/1.0;>
- 2013-05-02
+ 2019-01-19
1.5.0
@@ -40,5 +40,8 @@
1.6.0
+
+ 1.8.0
+
diff --git a/jvmfwk/distributions/OpenOfficeorg/javavendors_macosx.xml
b/jvmfwk/distributions/OpenOfficeorg/javavendors_macosx.xml
index c2416582a793..1fe7547d2919 100644
--- a/jvmfwk/distributions/OpenOfficeorg/javavendors_macosx.xml
+++ b/jvmfwk/distributions/OpenOfficeorg/javavendors_macosx.xml
@@ -17,7 +17,7 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
-->
http://openoffice.org/2004/java/framework/1.0;>
- 2013-04-09
+ 2019-01-19
1.7.0
@@ -31,5 +31,8 @@
1.6.0
+
+ 1.8.0
+
diff --git a/jvmfwk/distributions/OpenOfficeorg/javavendors_unx.xml
b/jvmfwk/distributions/OpenOfficeorg/javavendors_unx.xml
index fb79c003196e..7771d81527df 100644
--- a/jvmfwk/distributions/OpenOfficeorg/javavendors_unx.xml
+++ b/jvmfwk/distributions/OpenOfficeorg/javavendors_unx.xml
@@ -17,7 +17,7 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
-->
http://openoffice.org/2004/java/framework/1.0;>
- 2011-01-07
+ 2019-01-19
1.7.0
@@ -25,5 +25,8 @@
1.5.0
+
+ 1.8.0
+
diff --git a/jvmfwk/distributions/OpenOfficeorg/javavendors_wnt.xml
b/jvmfwk/distributions/OpenOfficeorg/javavendors_wnt.xml
index 0a37a4ea88a7..429831121f7b 100644
--- a/jvmfwk/distributions/OpenOfficeorg/javavendors_wnt.xml
+++ b/jvmfwk/distributions/OpenOfficeorg/javavendors_wnt.xml
@@ -17,7 +17,7 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
-->
http://openoffice.org/2004/java/framework/1.0;>
- 2013-05-02
+ 2019-01-19
1.6.0
@@ -31,5 +31,8 @@
1.6.0
+
+ 1.8.0
+
diff --git a/jvmfwk/plugins/sunmajor/pluginlib/vendorlist.cxx
b/jvmfwk/plugins/sunmajor/pluginlib/vendorlist.cxx
index 608be1583b8e..b4818b10325a 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/vendorlist.cxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/vendorlist.cxx
@@ -42,6 +42,7 @@ BEGIN_VENDOR_MAP()
#endif
VENDOR_MAP_ENTRY("Sun Microsystems Inc.", SunInfo)
VENDOR_MAP_ENTRY("Oracle Corporation", SunInfo)
+VENDOR_MAP_ENTRY("AdoptOpenJdk", SunInfo)
#ifndef MACOSX
VENDOR_MAP_ENTRY("IBM Corporation", OtherInfo)
VENDOR_MAP_ENTRY("Blackdown Java-Linux Team", OtherInfo)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/constparams.cxx | 59 -
compilerplugins/clang/test/constparams.cxx |4 -
2 files changed, 35 insertions(+), 28 deletions(-)
New commits:
commit a6358f1c1b8f981345061b0cbb708df707a5b7b8
Author: Noel Grandin
AuthorDate: Wed Jan 16 15:25:22 2019 +0200
Commit: Noel Grandin
CommitDate: Fri Jan 25 07:58:04 2019 +0100
improve loplugin constparams
Change-Id: Ic1833dbd030044011e7ee5f89dc35737e5469f05
Reviewed-on: https://gerrit.libreoffice.org/66586
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/compilerplugins/clang/constparams.cxx
b/compilerplugins/clang/constparams.cxx
index 454fa1af..3f1aad80b38e 100644
--- a/compilerplugins/clang/constparams.cxx
+++ b/compilerplugins/clang/constparams.cxx
@@ -76,11 +76,12 @@ public:
{
continue;
}
+std::string fname = functionDecl->getQualifiedNameAsString();
report(
DiagnosticsEngine::Warning,
-"this parameter can be const",
+"this parameter can be const %0",
compat::getBeginLoc(pParmVarDecl))
-<< pParmVarDecl->getSourceRange();
+<< fname << pParmVarDecl->getSourceRange();
if (canonicalDecl->getLocation() != functionDecl->getLocation()) {
unsigned idx = pParmVarDecl->getFunctionScopeIndex();
const ParmVarDecl* pOther = canonicalDecl->getParamDecl(idx);
@@ -150,16 +151,8 @@ bool ConstParams::CheckTraverseFunctionDecl(FunctionDecl *
functionDecl)
if (isInUnoIncludeFile(functionDecl)) {
return false;
}
-// TODO ignore template stuff for now
-if (functionDecl->getTemplatedKind() != FunctionDecl::TK_NonTemplate) {
-return false;
-}
if (functionDecl->isDeleted())
return false;
-if (isa(functionDecl)
-&&
dyn_cast(functionDecl)->getParent()->getDescribedClassTemplate()
!= nullptr ) {
-return false;
-}
// ignore virtual methods
if (isa(functionDecl)
&& dyn_cast(functionDecl)->isVirtual() ) {
@@ -210,10 +203,19 @@ bool ConstParams::CheckTraverseFunctionDecl(FunctionDecl
* functionDecl)
|| name == "Read_And"
// passed as a LINK<> to another method
|| name == "GlobalBasicErrorHdl_Impl"
+// template
+|| name == "extract_throw" || name == "readProp"
)
return false;
+
}
+std::string fqn = functionDecl->getQualifiedNameAsString();
+if ( fqn == "connectivity::jdbc::GlobalRef::set"
+ || fqn == "(anonymous namespace)::ReorderNotifier::operator()"
+ || fqn == "static_txtattr_cast")
+return false;
+
// calculate the ones we want to check
bool foundInterestingParam = false;
for (const ParmVarDecl *pParmVarDecl : functionDecl->parameters()) {
@@ -222,11 +224,8 @@ bool ConstParams::CheckTraverseFunctionDecl(FunctionDecl *
functionDecl)
|| pParmVarDecl->hasAttr())
continue;
auto const type = loplugin::TypeCheck(pParmVarDecl->getType());
-if (!type.Pointer() && !type.LvalueReference())
-continue;
-if (type.Pointer().Const())
-continue;
-if (type.LvalueReference().Const())
+if (!( type.Pointer().NonConst()
+ || type.LvalueReference().NonConst()))
continue;
// since we normally can't change typedefs, just ignore them
if (isa(pParmVarDecl->getType()))
@@ -240,11 +239,6 @@ bool ConstParams::CheckTraverseFunctionDecl(FunctionDecl *
functionDecl)
// const is meaningless when applied to function pointer types
if (pParmVarDecl->getType()->isFunctionPointerType())
continue;
-// ignore things with template params
-if (pParmVarDecl->getType()->isInstantiationDependentType())
-continue;
-if (functionDecl->getIdentifier() && functionDecl->getName() ==
"WW8TransCol")
-pParmVarDecl->getType()->dump();
interestingParamSet.insert(pParmVarDecl);
parmToFunction[pParmVarDecl] = functionDecl;
foundInterestingParam = true;
@@ -281,12 +275,23 @@ bool ConstParams::checkIfCanBeConst(const Stmt* stmt,
const ParmVarDecl* parmVar
{
for ( auto cxxCtorInitializer : cxxConstructorDecl->inits())
{
-if (cxxCtorInitializer->isAnyMemberInitializer() &&
cxxCtorInitializer->getInit() == stmt)
+if ( cxxCtorInitializer->getInit() == stmt)
{
-// if the member is not pointer or ref to-const, we
cannot make the param const
-auto fieldDecl = cxxCtorInitializer->getAnyMember();
-auto tc = loplugin::TypeCheck(fieldDecl->getType());
-return
[Libreoffice-bugs] [Bug 122943] New: Opening a Style dialog's Highlighting/Area tabs adds properties to the property set in the style
https://bugs.documentfoundation.org/show_bug.cgi?id=122943 Bug ID: 122943 Summary: Opening a Style dialog's Highlighting/Area tabs adds properties to the property set in the style Product: LibreOffice Version: 5.3.0.3 release Hardware: All OS: All Status: UNCONFIRMED Keywords: bibisected, bisected, regression Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikekagan...@hotmail.com CC: katarina.behr...@cib.de, rayk...@gmail.com Create new text document; open Styles pane (F11) on Paragraph Styles; right-click "Frame Contents"->Modify...; check that Organizer tab has nothing under "Contains"; switch to Highlighting tab; switch back to Organizer tab and see that "Automatic, Transparent" is shown under "Contains". Switching to Area and back to Organizer tab adds "None" to "Contains". Impact: this bug means that simply visiting the said tabs (without modifying the settings there) adds explicit corresponding values to the style definition; it's impossible to remove these definitions without cancelling the dialog. If user overlooks the change (which is most likely), and presses Apply/OK (e.g., to save changes made on other tabs), then it's totally impossible to get rid of the settings in the style later. Having the explicit settings in the style means that the style doesn't inherit these settings from parent, thus breaking normal (expected) inheritance of unset settings (user cannot set parent's Area later and have all child styles have that Area). The problem with Area tab started at https://git.libreoffice.org/core/+/4c5079791f5d985151ebc090c5a07705e76a728e, *after* the tab already was replaced with new color tab. The problem with Highlighting is present in 6.2.0.2, but I cannot bibisect it, since the latest in bibisect-win32-6.2 doesn't have it, and the oldest in bibisect-win32-6.3 already has it; but it's likely connected with the changes made in bug 105225 moving to the new color pages. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105225] Color palette cannot be chosen in various places
https://bugs.documentfoundation.org/show_bug.cgi?id=105225 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||2943 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122937] The SOMME function not working
https://bugs.documentfoundation.org/show_bug.cgi?id=122937 raal changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG Assignee|dran...@gmail.com |libreoffice-b...@lists.free ||desktop.org --- Comment #8 from raal --- Please do not reopen this bug, it's closed and not a bug. For questions we have AskBot: http://ask.libreoffice.org/ You can change locale settings in Tools - Options - Language - Language -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122905] FORM - Tablecontrol: Second listbox won't show right content when directly beneath first listbox
https://bugs.documentfoundation.org/show_bug.cgi?id=122905 Alex Thurgood changed: What|Removed |Added Keywords||regression Priority|medium |high Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122905] FORM - Tablecontrol: Second listbox won't show right content when directly beneath first listbox
https://bugs.documentfoundation.org/show_bug.cgi?id=122905 Alex Thurgood changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #4 from Alex Thurgood --- Hi Robert, Yes, I have managed to reproduce it ith Version: 6.1.4.2 Build ID: 9d0f32d1f0b509096fd65e0d4bec26ddd1938fd3 Threads CPU : 8; OS : Mac OS X 10.14.2; UI Render : par défaut; Locale : fr-FR (fr_FR.UTF-8); Calc: group threade on my MacbookPro. Indeed, it seems that a forced screen refresh, e.g by context switching to focus on another window and then back to the form window, causes the correct data to be displayed, but on first opening of the form I did indeed see only the key values in the grid control instead of the corresponding referred to values. CONFIRMING, and this is a regression. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84837] Make show/hide comments UNO command work in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=84837 --- Comment #189 from Mihaim <1...@mihai-medves.com> --- They can draw attention to a tilted text column may draw attention to an important image or part of the content, forcing the visitor to observe it, the creare website company to chose in Active Records Agency https://www.active-records.com/ro/creare-website/. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: android/source
android/source/fonts.conf |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit fc2a8bf0ef42dd6787136228d8f11e83e7bf2c16 Author: Andrea Gelmini AuthorDate: Thu Jan 24 18:42:55 2019 + Commit: Julien Nabet CommitDate: Fri Jan 25 07:04:56 2019 +0100 Fix typo Change-Id: Ib630bb2d5465fe8fd20df152e2da70eabbff2a16 Reviewed-on: https://gerrit.libreoffice.org/66894 Reviewed-by: Julien Nabet Tested-by: Julien Nabet diff --git a/android/source/fonts.conf b/android/source/fonts.conf index 5b727ca3aae9..51355b747e85 100644 --- a/android/source/fonts.conf +++ b/android/source/fonts.conf @@ -71,7 +71,7 @@ /data/data/@@APPLICATION_ID@@/fontconfig ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 122900] When opening the navigator, the caret is no longer positioned on the list
https://bugs.documentfoundation.org/show_bug.cgi?id=122900
--- Comment #3 from Jim Raykowski ---
Making the navigator not grab focus to the content tree on show was
intentionally done to resolve:
Bug 49684 - the Navigator gets the focus when starting a new document while
the Navigator is open
commit 88cbc3ea2db8358bbedff01361f95f972f2b0231
Author: Jim Raykowski
Date: Mon Oct 22 17:38:31 2018 -0800
tdf#49684 Don't focus on Navigator or Sidebar on show
Change-Id: I21b36c3ed2e5b6fc574e00f86d2c48c352cf469c
This works for GTK2 but not for GTK3, which I did not know until recently. The
following patch causes it not to work for GTK3:
Bug 98807 - GTK3: Activate the navigator doesn't get focus to the navigator
window
commit c0d6fa1417141a3a7e9deb2f4d50acc28b32f1b4
Author: Caolán McNamara
Date: Tue Oct 18 15:37:59 2016 +0100
Resolves: tdf#98807 gtk3 isn't giving utility windows focus
so just give up on that and give them a dialog hint instead
Change-Id: Icca0c707dc464b0dbf362988b1dfee56866eadc0
I tested patching GTK2 in vcl/unx/gtk/gtksalframe.cxx the same as Caolán's GTK3
patch. It works but re-introduces bug 49684 for GTK2.
A related bug is:
Bug 113250 - UI Navigator ('floating' version, that is in docked state) in Calc
doesn't have the focus immediately after opening with F5
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 122900] When opening the navigator, the caret is no longer positioned on the list
https://bugs.documentfoundation.org/show_bug.cgi?id=122900
--- Comment #3 from Jim Raykowski ---
Making the navigator not grab focus to the content tree on show was
intentionally done to resolve:
Bug 49684 - the Navigator gets the focus when starting a new document while
the Navigator is open
commit 88cbc3ea2db8358bbedff01361f95f972f2b0231
Author: Jim Raykowski
Date: Mon Oct 22 17:38:31 2018 -0800
tdf#49684 Don't focus on Navigator or Sidebar on show
Change-Id: I21b36c3ed2e5b6fc574e00f86d2c48c352cf469c
This works for GTK2 but not for GTK3, which I did not know until recently. The
following patch causes it not to work for GTK3:
Bug 98807 - GTK3: Activate the navigator doesn't get focus to the navigator
window
commit c0d6fa1417141a3a7e9deb2f4d50acc28b32f1b4
Author: Caolán McNamara
Date: Tue Oct 18 15:37:59 2016 +0100
Resolves: tdf#98807 gtk3 isn't giving utility windows focus
so just give up on that and give them a dialog hint instead
Change-Id: Icca0c707dc464b0dbf362988b1dfee56866eadc0
I tested patching GTK2 in vcl/unx/gtk/gtksalframe.cxx the same as Caolán's GTK3
patch. It works but re-introduces bug 49684 for GTK2.
A related bug is:
Bug 113250 - UI Navigator ('floating' version, that is in docked state) in Calc
doesn't have the focus immediately after opening with F5
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117860] FORMATTING rotated images by manipulating the resize handles is inconsistent and unpredictable
https://bugs.documentfoundation.org/show_bug.cgi?id=117860 BottleOnTheGround changed: What|Removed |Added CC||notebook22...@gmail.com --- Comment #3 from BottleOnTheGround --- Created attachment 148614 --> https://bugs.documentfoundation.org/attachment.cgi?id=148614=edit Rotation crops the picture. Further resizing is unpredictable I have a similar problem on 6.0.7.3. I attached a video from my experience: Rotating will crop the picture in a way, that is not 'fixable'. As this behaviour renders the "image rotation" feature completely useless, I would set the priority to higher than "minor". If you consider my experience as a new "report"/bug/suggestion, please let me know. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115164] Calc freezes when trying to update Links without connectivity
https://bugs.documentfoundation.org/show_bug.cgi?id=115164 --- Comment #2 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107521] Improve DirectWrite implementation font rendering on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=107521 --- Comment #23 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98492] Text into the cell not visible When I typed in Calc with openGL activated
https://bugs.documentfoundation.org/show_bug.cgi?id=98492 --- Comment #13 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114989] Action Buttons hard to read
https://bugs.documentfoundation.org/show_bug.cgi?id=114989 --- Comment #3 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115168] Legend not displayed when creating a pie chart with only two cells
https://bugs.documentfoundation.org/show_bug.cgi?id=115168 --- Comment #5 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122942] Inserting shape over chart in DOCX inserts it below chart
https://bugs.documentfoundation.org/show_bug.cgi?id=122942 Aron Budea changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122942] New: Inserting shape over chart in DOCX inserts it below chart
https://bugs.documentfoundation.org/show_bug.cgi?id=122942 Bug ID: 122942 Summary: Inserting shape over chart in DOCX inserts it below chart Product: LibreOffice Version: 5.2.0.4 release Hardware: All OS: All Status: UNCONFIRMED Keywords: bibisected, bisected, regression Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@caesar.elte.hu CC: vmik...@collabora.com Blocks: 104442 - Open any DOCX file (eg. an empty one), - Insert a chart, - Click away to get out of chart editing, - Select a shape for insertion, and insert it over the chart. => Shape is inserted below the chart. When saved and reloaded, the shape overlaps the chart again. If the file is ODT, or an unsaved empty document, the issue doesn't occur. Observed using LO 6.3.0.0.alpha0+ (fdc91f7493171ae600ecb293ad380df5fa77a277), 5.2.0.4 / Ubuntu 18.04. No issue with LO 5.1.0.3. => regression Bibisected to the following commit using repo bibisect-linux-64-5.2. Same commit as for bug 109851 and for bug 113742, but the repro steps are different. Adding Cc: to Miklos Vajna, please take a look. https://cgit.freedesktop.org/libreoffice/core/commit/?id=50223ea6e212b60b7d33839c2753c5601fb50f95 author Miklos Vajna 2016-03-31 15:05:48 +0200 committer Miklos Vajna 2016-03-31 17:49:00 + "tdf#98987 sw: add AddVerticalFrameOffsets compat mode" Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104442 [Bug 104442] [META] OOXML shape (DrawingML and VML) related issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109851] FILESAVE: ODT: image misplaced after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=109851 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||2942 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113742] FILEOPEN: DOCX: Frames not placed correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=113742 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||2942 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104442] [META] OOXML shape (DrawingML and VML) related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104442 Aron Budea changed: What|Removed |Added Depends on||122942 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122942 [Bug 122942] Inserting shape over chart in DOCX inserts it below chart -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45904] move java based api tests to c++
https://bugs.documentfoundation.org/show_bug.cgi?id=45904 --- Comment #227 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/dd0155967e0b679b7df3907fcb12e8cbd82cdefb%5E%21 tdf#45904 Move XPropertySet Java tests to C++ It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa
sc/qa/extras/sctablevalidationobj.cxx |8
1 file changed, 8 insertions(+)
New commits:
commit 33989dcb4ac1730835ba421a4488dbafb877433a
Author: Jens Carl
AuthorDate: Fri Jan 25 02:03:47 2019 +
Commit: Jens Carl
CommitDate: Fri Jan 25 04:17:47 2019 +0100
Add XServiceInfo tests to ScTableValidationObj
Change-Id: I51d48bc8096267a657e7ac588c79864489b5b846
Reviewed-on: https://gerrit.libreoffice.org/66891
Tested-by: Jenkins
Reviewed-by: Jens Carl
diff --git a/sc/qa/extras/sctablevalidationobj.cxx
b/sc/qa/extras/sctablevalidationobj.cxx
index 542e5b2fa7d6..8ba211c43cc6 100644
--- a/sc/qa/extras/sctablevalidationobj.cxx
+++ b/sc/qa/extras/sctablevalidationobj.cxx
@@ -9,6 +9,7 @@
#include
#include
+#include
#include
#include
@@ -33,6 +34,7 @@ namespace sc_apitest
class ScTableValidationObj : public CalcUnoApiTest,
public apitest::TableValidation,
public apitest::XPropertySet,
+ public apitest::XServiceInfo,
public apitest::XSheetCondition
{
public:
@@ -54,6 +56,11 @@ public:
CPPUNIT_TEST(testPropertyChangeListner);
CPPUNIT_TEST(testVetoableChangeListner);
+// XServiceInfo
+CPPUNIT_TEST(testGetImplementationName);
+CPPUNIT_TEST(testGetSupportedServiceNames);
+CPPUNIT_TEST(testSupportsService);
+
// XSheetCondition
CPPUNIT_TEST(testGetSetFormula1);
CPPUNIT_TEST(testGetSetFormula2);
@@ -69,6 +76,7 @@ private:
ScTableValidationObj::ScTableValidationObj()
: CalcUnoApiTest("/sc/qa/extras/testdocuments")
, XPropertySet({ "Type", "ErrorAlertStyle" })
+, XServiceInfo("ScTableValidationObj",
"com.sun.star.sheet.TableValidation")
{
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: framework/qa include/test qadevOOo/Jar_OOoRunner.mk qadevOOo/objdsc qadevOOo/tests sc/qa solenv/clang-format test/source
framework/qa/complex/api_internal/api.lst|1
include/test/beans/xpropertyset.hxx | 25 +
qadevOOo/Jar_OOoRunner.mk|1
qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableValidationObj.csv |7
qadevOOo/tests/java/mod/_sc/ScTableValidationObj.java| 118
-
sc/qa/extras/sctablevalidationobj.cxx| 14 -
sc/qa/unoapi/sc_7.sce|1
solenv/clang-format/blacklist|2
test/source/beans/xpropertyset.cxx | 128
--
9 files changed, 145 insertions(+), 152 deletions(-)
New commits:
commit dd0155967e0b679b7df3907fcb12e8cbd82cdefb
Author: Jens Carl
AuthorDate: Fri Jan 25 00:41:35 2019 +
Commit: Jens Carl
CommitDate: Fri Jan 25 04:17:29 2019 +0100
tdf#45904 Move XPropertySet Java tests to C++
Move XPropertySet Java tests to C++ for ScTableValidationObj.
Change-Id: If058f40ff73203d2705bf9841d0496d52ff93ed8
Reviewed-on: https://gerrit.libreoffice.org/66890
Tested-by: Jenkins
Reviewed-by: Jens Carl
diff --git a/framework/qa/complex/api_internal/api.lst
b/framework/qa/complex/api_internal/api.lst
index 28c133dcdf10..609e7d5c323d 100644
--- a/framework/qa/complex/api_internal/api.lst
+++ b/framework/qa/complex/api_internal/api.lst
@@ -91,7 +91,6 @@ job132=sc.ScStyleObj
job134=sc.ScTableColumnObj
job135=sc.ScTableColumnsObj
job138=sc.ScTableRowObj
-job139=sc.ScTableValidationObj
job140=sc.XMLContentExporter
job141=sc.XMLContentImporter
job142=sc.XMLImporter
diff --git a/include/test/beans/xpropertyset.hxx
b/include/test/beans/xpropertyset.hxx
index 3b110a53db3c..72827aa6ee76 100644
--- a/include/test/beans/xpropertyset.hxx
+++ b/include/test/beans/xpropertyset.hxx
@@ -10,36 +10,46 @@
#ifndef INCLUDED_TEST_BEANS_XPROPERTYSET_HXX
#define INCLUDED_TEST_BEANS_XPROPERTYSET_HXX
-#include
#include
#include
+#include
+
#include
+#include
#include
-namespace apitest {
-
+namespace apitest
+{
class OOO_DLLPUBLIC_TEST XPropertySet
{
public:
-virtual ~XPropertySet();
+XPropertySet() {}
+XPropertySet(const std::set rIgnoreValue)
+: m_IgnoreValue(rIgnoreValue)
+{
+}
virtual css::uno::Reference init() = 0;
void testGetPropertySetInfo();
void testSetPropertyValue();
void testGetPropertyValue();
+void testPropertyChangeListner();
+void testVetoableChangeListner();
protected:
+~XPropertySet(){};
bool isPropertyValueChangeable(const OUString& rName);
virtual bool isPropertyIgnored(const OUString& rName);
private:
void fillPropsToTest(const
css::uno::Reference& xPropInfo);
-static bool getSinglePropertyValue(
-const css::uno::Reference& xPropSet, const
OUString& rName);
+static bool
+getSinglePropertyValue(const
css::uno::Reference& xPropSet,
+ const OUString& rName);
struct OOO_DLLPUBLIC_TEST PropsToTest
{
@@ -54,9 +64,10 @@ private:
};
PropsToTest maPropsToTest;
+std::set m_IgnoreValue;
};
-}
+} // namespace apitest
#endif
diff --git a/qadevOOo/Jar_OOoRunner.mk b/qadevOOo/Jar_OOoRunner.mk
index 8a8374069326..71887651aa48 100644
--- a/qadevOOo/Jar_OOoRunner.mk
+++ b/qadevOOo/Jar_OOoRunner.mk
@@ -992,7 +992,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\
qadevOOo/tests/java/mod/_sc/ScTableRowObj \
qadevOOo/tests/java/mod/_sc/ScTableSheetObj \
qadevOOo/tests/java/mod/_sc/ScTableSheetsObj \
-qadevOOo/tests/java/mod/_sc/ScTableValidationObj \
qadevOOo/tests/java/mod/_sc/ScTabViewObj \
qadevOOo/tests/java/mod/_sc/ScViewPaneObj \
qadevOOo/tests/java/mod/_sc/XMLContentExporter \
diff --git
a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableValidationObj.csv
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableValidationObj.csv
deleted file mode 100644
index 743fb8ef8851..
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableValidationObj.csv
+++ /dev/null
@@ -1,7 +0,0 @@
-"ScTableValidationObj";"com::sun::star::beans::XPropertySet";"getPropertySetInfo()"
-"ScTableValidationObj";"com::sun::star::beans::XPropertySet";"setPropertyValue()"
-"ScTableValidationObj";"com::sun::star::beans::XPropertySet";"getPropertyValue()"
-"ScTableValidationObj";"com::sun::star::beans::XPropertySet";"addPropertyChangeListener()"
-"ScTableValidationObj";"com::sun::star::beans::XPropertySet";"removePropertyChangeListener()"
-"ScTableValidationObj";"com::sun::star::beans::XPropertySet";"addVetoableChangeListener()"
-"ScTableValidationObj";"com::sun::star::beans::XPropertySet";"removeVetoableChangeListener()"
diff --git a/qadevOOo/tests/java/mod/_sc/ScTableValidationObj.java
b/qadevOOo/tests/java/mod/_sc/ScTableValidationObj.java
deleted file mode 100644
[Libreoffice-bugs] [Bug 97128] FILEOPEN: landscape frame not properly shown in DOC DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=97128 --- Comment #9 from Luke --- Created attachment 148613 --> https://bugs.documentfoundation.org/attachment.cgi?id=148613=edit DOCX landscape frames also incorrectly rendered -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa
sc/qa/extras/scchartobj.cxx |5 +
1 file changed, 5 insertions(+)
New commits:
commit 017f846efa9b31cb692ad0c477b8e3607f297181
Author: Jens Carl
AuthorDate: Thu Jan 24 21:25:52 2019 +
Commit: Jens Carl
CommitDate: Fri Jan 25 02:20:55 2019 +0100
Add XPropertySet::testGetPropertySetInfo test for ScChartObj
Change-Id: Ie98c353ec234d1376ef10102b5ee05cce3de6688
Reviewed-on: https://gerrit.libreoffice.org/66887
Tested-by: Jenkins
Reviewed-by: Jens Carl
diff --git a/sc/qa/extras/scchartobj.cxx b/sc/qa/extras/scchartobj.cxx
index 2492a593db9c..10dab5203ec9 100644
--- a/sc/qa/extras/scchartobj.cxx
+++ b/sc/qa/extras/scchartobj.cxx
@@ -8,6 +8,7 @@
*/
#include
+#include
#include
#include
#include
@@ -39,6 +40,7 @@ namespace sc_apitest
class ScChartObj : public CalcUnoApiTest,
public apitest::XEmbeddedObjectSupplier,
public apitest::XNamed,
+ public apitest::XPropertySet,
public apitest::XServiceInfo,
public apitest::XTableChart
{
@@ -58,6 +60,9 @@ public:
CPPUNIT_TEST(testGetName);
CPPUNIT_TEST(testSetNameThrowsException);
+// XPropertySet
+CPPUNIT_TEST(testGetPropertySetInfo);
+
// XServiceInfo
CPPUNIT_TEST(testGetImplementationName);
CPPUNIT_TEST(testGetSupportedServiceNames);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 97128] FILEOPEN: landscape frame not properly shown in DOC DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=97128 --- Comment #8 from Luke --- Created attachment 148612 --> https://bugs.documentfoundation.org/attachment.cgi?id=148612=edit DOC with frame not in header Example showing that the issue is not related to the header/footer -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97128] FILEOPEN: landscape frame not properly shown in DOC DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=97128 Luke changed: What|Removed |Added Blocks|112702 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112702 [Bug 112702] [META] DOC (binary) header and footer-related issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112702] [META] DOC (binary) header and footer-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112702 Luke changed: What|Removed |Added Depends on|97128 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=97128 [Bug 97128] FILEOPEN: landscape frame not properly shown in DOC DOCX -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97128] FILEOPEN: landscape frame not properly shown in DOC DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=97128 Luke changed: What|Removed |Added Summary|FILEOPEN: header with |FILEOPEN: landscape frame |landscape frame not |not properly shown in DOC |properly shown in DOC |DOCX -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97128] FILEOPEN: header with landscape frame not properly shown in DOC
https://bugs.documentfoundation.org/show_bug.cgi?id=97128 Luke changed: What|Removed |Added Summary|FILEOPEN: header with frame |FILEOPEN: header with |not properly shown in DOC |landscape frame not ||properly shown in DOC -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122922] FILESAVE XLSX The spreadsheet protection doesn’t work
https://bugs.documentfoundation.org/show_bug.cgi?id=122922 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #8 from m.a.riosv --- Aoo can't save in xlsx file format even in the last versions, so issue can't be inherited from OOo -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
First-time development/C++ Contributor
Hello open-source and LibreOffice enthusiasts! I am a 21 year old with beginner knowledge in C++ based in Tirana, Albania. Because of my passion towards this C++ I thought of putting my knowledge into practice and why not, expand my knowledge even further. LibreOffice captured my attention as a leading free open source platform. I contacted Open Labs hackerspace' members here in Tirana to hopefully jump start me to the contribution process and how it works and they directed me to this list. I am more than willing to jump start my contribution to LibreOffice and will apreciate if you could show me a way of finding some 'begginer tasks' or any quick fixes. Thank you for reading! I am looking forward to contributing! :) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
enhanced-path command M with multiple pairs of coordinates
Hi, this is about https://gerrit.libreoffice.org/66888. I have put it to Gerrit for discussion. The spec says, "If a moveto is followed by multiple pairs of coordinates, they are treated as lineto." LibreOffice does not honor this, Karbon does it. My patch transforms a path like "M 0 0 5 10 10 0 N" on import in a command sequence, where an additional command L (=lineTo) is introduced. So when saving you get "M 0 0 L 5 10 10 0 N". A different approach would be to keep the current way of using a command M (=moveTO) with multiple pairs of coordinates in the command sequence, and then draw the lines, when rendering the shape. I think, that would request some changes in EnhancedCustomShape2d::CreateSubPath in svx. I haven't tried it yet, so I can't estimate how extensive the changes would be. Is the approach with a change on import acceptable? Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 122145] PARAGRAPH DIALOG: Border styles and tooltips don't match (see comment 3)
https://bugs.documentfoundation.org/show_bug.cgi?id=122145 --- Comment #9 from okinasevych --- Retested with prerelease build: Version: 6.2.0.2 Build ID: 2ce5217b30a543f7666022df50f0562f82be0cff CPU threads: 4; OS: Mac OS X 10.12.6; UI render: GL; VCL: osx; Locale: en-CA (en_CA.UTF-8); UI-Language: en-US Calc: threaded Testing paragraph with 8 pt double-borders on all sides: Double -- OK Double thin -- OK Thin Thick, Small Gap -- ERROR at corners, inner line Thin Thick, Med Gap -- ERROR at corners, inner line Thin Thick, Large Gap -- ERROR at corners, inner line Thick Thin, Small Gap -- OK Thick Thin, Med Gap -- OK Thick Thin, Large Gap -- OK FWIW, an earlier (ca 2015) document I created with double-rules on single bottom edges of paragraphs renders and prints correctly/as intended. Kudos and thanks. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120800] Keyboard shortcuts for text style cause paper cuts
https://bugs.documentfoundation.org/show_bug.cgi?id=120800 --- Comment #5 from Coburn Ingram --- Yes it goes away in Safe Mode. But I have had this problem on every version of LibreOffice/OOO I have used for the last decade or more, on more than one platform. It still persists. Have you tested on Ubuntu? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Bringing command 'arcangleto' (G) to ODF
Hi all, some years ago Radek Doulik has implemented a commant 'G' for the enhanced-path of a custom shape. Such path is written in drawooo namespace. I have not found any documentation about it and it is not mentioned in https://wiki.documentfoundation.org/Development/ODF_Implementer_Notes/List_of_LibreOffice_ODF_Extensions You know, that I'm hesitant to bring something new to ODF. But in this case the new command seems to be useful. You will find the draft for a proposal below. Because the lack of any documentation (and my problems with English) it would be nice, if you look whether I have got it correct. PowerPoint restricts the swing angle to [-360°;360°], but I do not find any such restriction in the OOXML spec. What to do for ODF about this? Currently it is not restricted in my proposal draft. Kind regards Regina Proposal Command G Namearcangleto Parameters (wR hR st sw) + Description Draws an arc of an ellipse. The ellipse is specified by the width 2*wR, and the hight 2*hR. The arc is specifies by the start angle st in degrees and the swing angle sw in degrees. The ellipse is positioned so that the current point is the start point of the arc. The arc is drawn so that sw is the central angle of the arc. If sw is positive, the arc is drawn clockwise; if sw is negative, the arc is drawn counter-clockwise. The endpoint of the arc becomes the new current point. In case the path is filled, the filling is drawn as ellipse sector. The swing angle may be greater as 360° and may be smaller than -360°. In that cases filling will overlap. Explanation === This command is needed for interoperability with the OOXML standard and its attribute "arcTo", see ECMA-376 Part 1 section 20.1.94. With the current commands A, B, U, T, V and W only one direction of the arc is possible, either clockwise or counter-clockwise. The new command G allows to specify the arc direction depending on a parameter. Such parameter can be calculated from a formula or adjustment value, so the direction is not predefined. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 97555] unsuitable colour feedback when selecting multiple sheet in calc
https://bugs.documentfoundation.org/show_bug.cgi?id=97555 --- Comment #9 from Eike Rathke --- Caveat, that TabBar is used also in other places, Draw, Base and Basic IDE (git grep svtools/tabbar.hxx). I doubt we want the same behaviour in all places, specifically not if they do not allow multiple selection. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97555] unsuitable colour feedback when selecting multiple sheet in calc
https://bugs.documentfoundation.org/show_bug.cgi?id=97555 Eike Rathke changed: What|Removed |Added Keywords|needsDevEval| --- Comment #8 from Eike Rathke --- AFAIK the colors in the render context are the same as the window settings, unselected tabs are in window border color, unless the tab has a custom color assigned, and the background color is used as selected tab color. This IMHO is even consistent with style guides. Using the (text or cell) selection color there is not expected. Drawing a bottom bar same as for colored tabs but in the unselected tab color probably is the better solution, though that still would look odd to me. However, implementation is in svtools/source/control/tabbar.cxx class TabDrawer drawColorLine() called from drawTab() if (mbCustomColored && mbSelected), that could be adapted to drawColorLine() with maUnselectedColor for not mbCustomColored. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122936] Cannot Assign a macro to a button in Libre Office 6.1 in Linux Mint Mate 19.0 Libre Offices crashes.
https://bugs.documentfoundation.org/show_bug.cgi?id=122936 Rickie changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #7 from Rickie --- Unchecked openGL but issue is still present. Actually unchecked everything in the openGL menu but problems remain. Should I try and select openGL and see what happens? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Changes to 'refs/tags/CODE-4-RC3'
Tag 'CODE-4-RC3' created by Andras Timar at 2019-01-24 22:37 + CODE-4-RC3 Changes since cp-6.0-21-PTF: Andras Timar (1): Revert "Disable use of X11 or Wayland to reduce dependencies" --- distro-configs/CPLinux-LOKit.conf |1 - 1 file changed, 1 deletion(-) --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/tags/cd-6.0-21'
Tag 'cd-6.0-21' created by Andras Timar at 2019-01-24 22:33 + cd-6.0-21 Changes since cp-6.0-21-PTF-6: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 122941] New: I cannot copy and paste an entire multi-page pdf from LibreOffice to google docs
https://bugs.documentfoundation.org/show_bug.cgi?id=122941 Bug ID: 122941 Summary: I cannot copy and paste an entire multi-page pdf from LibreOffice to google docs Product: LibreOffice Version: 6.0.7.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: n...@nredco.com Description: I converted a pdf in LibreOffice with no problem. When I selected all 13 pages and copied and pasted into a google drive word doc, only page 1 appeared. I did this several times, and I searched online for help. More than one response said it was a bug, which I figured. I even tried selecting all the pages from the left side pane, but when I copied and pasted, only page 1 appeared. Steps to Reproduce: 1.open a multipage pdf in officelibre 2.open the pane on the left showing all pages 3.select all and copy and paste Actual Results: Only the first page will paste Expected Results: only the first page pasted. Reproducible: Always User Profile Reset: Yes Additional Info: All pages should have pasted. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102040] Wireless or Bluetooth Keyboard: Typed Characters are doubled
https://bugs.documentfoundation.org/show_bug.cgi?id=102040 --- Comment #11 from Deve --- I already pushed a patch to gerrit: https://gerrit.libreoffice.org/66708 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/core/data/ww6/pass/ofz-trailingpara.doc |binary sw/source/filter/ww8/ww8par.cxx |7 --- 2 files changed, 4 insertions(+), 3 deletions(-) New commits: commit 9b76295d03ee8d1eb19a62c55ff45804efe40f38 Author: Caolán McNamara AuthorDate: Thu Jan 24 15:52:30 2019 + Commit: Caolán McNamara CommitDate: Thu Jan 24 22:13:05 2019 +0100 ofz#12660 remove flys before removing trailing paras Change-Id: I6c706e5a2066b4fcd4546a22de0aa6327515a0a8 Reviewed-on: https://gerrit.libreoffice.org/66877 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/sw/qa/core/data/ww6/pass/ofz-trailingpara.doc b/sw/qa/core/data/ww6/pass/ofz-trailingpara.doc new file mode 100644 index ..40c574759b03 Binary files /dev/null and b/sw/qa/core/data/ww6/pass/ofz-trailingpara.doc differ diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx index 5b3010e90637..4732ef28c74d 100644 --- a/sw/source/filter/ww8/ww8par.cxx +++ b/sw/source/filter/ww8/ww8par.cxx @@ -5317,13 +5317,14 @@ ErrCode SwWW8ImplReader::CoreLoad(WW8Glossary const *pGloss) DeleteAnchorStack(); DeleteRefStacks(); m_pLastAnchorPos.reset();//ensure this is deleted before UpdatePageDescs +// ofz#10994 remove any trailing fly paras before processing redlines +m_xWFlyPara.reset(); +// ofz#12660 remove any trailing fly paras before deleting extra paras +m_xSFlyPara.reset(); // remove extra paragraphs after attribute ctrl // stacks etc. are destroyed, and before fields // are updated m_aExtraneousParas.delete_all_from_doc(); -// ofz#10994 remove any trailing fly paras before processing redlines -m_xWFlyPara.reset(); -m_xSFlyPara.reset(); m_xRedlineStack->closeall(*m_pPaM->GetPoint()); while (!m_aFrameRedlines.empty()) m_aFrameRedlines.pop(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-5-2+backports' - sc/qa sc/source
dev/null |binary
sc/qa/unit/subsequent_export-test.cxx | 19 ---
sc/source/core/data/dpgroup.cxx |6 +-
sc/source/filter/excel/xepivotxml.cxx | 11 ++-
4 files changed, 3 insertions(+), 33 deletions(-)
New commits:
commit 72cdcf9285cd9dfda4a3196a576fe72b58813658
Author: Thorsten Behrens
AuthorDate: Thu Jan 24 17:58:29 2019 +0100
Commit: Thorsten Behrens
CommitDate: Thu Jan 24 22:12:24 2019 +0100
Revert "tdf#121612: update pivot caches during saving to XLSX"
also revert "crashtesting: ooo55266-3.ods some members are nullptr"
as follow-up commit.
This reverts commit 41d514ecd43ae9ec673071bfa1d79e788b8f935b.
This reverts commit 6f5a27a6711fa9c29c732fdac9e1f175b2a6627e.
Conflicts:
sc/qa/unit/subsequent_export-test.cxx
Change-Id: Ib7d370dbb40553611f9c44d82b56d873492ea324
Reviewed-on: https://gerrit.libreoffice.org/66880
Reviewed-by: Thorsten Behrens
Tested-by: Thorsten Behrens
diff --git a/sc/qa/unit/data/ods/tdf121612.ods
b/sc/qa/unit/data/ods/tdf121612.ods
deleted file mode 100644
index 6afc4e0c931c..
Binary files a/sc/qa/unit/data/ods/tdf121612.ods and /dev/null differ
diff --git a/sc/qa/unit/subsequent_export-test.cxx
b/sc/qa/unit/subsequent_export-test.cxx
index fed665be7803..ba3e5dc610af 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -176,7 +176,6 @@ public:
void testHeaderImage();
void testTdf88657();
-void testTdf121612();
CPPUNIT_TEST_SUITE(ScExportTest);
CPPUNIT_TEST(test);
@@ -259,7 +258,6 @@ public:
CPPUNIT_TEST(testHeaderImage);
CPPUNIT_TEST(testTdf88657);
-CPPUNIT_TEST(testTdf121612);
CPPUNIT_TEST_SUITE_END();
@@ -3707,23 +3705,6 @@ void ScExportTest::testConditionalFormatRangeListXLSX()
assertXPath(pDoc, "//x:conditionalFormatting", "sqref", "F4 F10");
}
-void ScExportTest::testTdf121612()
-{
-ScDocShellRef xDocSh = loadDoc("tdf121612.", FORMAT_ODS);
-CPPUNIT_ASSERT(xDocSh.Is());
-xDocSh = saveAndReload(xDocSh.get(), FORMAT_XLSX);
-
-ScDocument& rDoc = xDocSh->GetDocument();
-
-// There should be a pivot table
-CPPUNIT_ASSERT(rDoc.HasPivotTable());
-
-// DP collection is not lost after export and has one entry
-ScDPCollection* pDPColl = rDoc.GetDPCollection();
-CPPUNIT_ASSERT(pDPColl);
-CPPUNIT_ASSERT_EQUAL(size_t(1), pDPColl->GetCount());
-}
-
CPPUNIT_TEST_SUITE_REGISTRATION(ScExportTest);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sc/source/core/data/dpgroup.cxx b/sc/source/core/data/dpgroup.cxx
index 0af5f2bd1d38..4fecf7970d0a 100644
--- a/sc/source/core/data/dpgroup.cxx
+++ b/sc/source/core/data/dpgroup.cxx
@@ -1035,11 +1035,7 @@ long ScDPGroupTableData::Compare(long nDim, long
nDataId1, long nDataId2)
{
if ( getIsDataLayoutDimension(nDim) )
return 0;
-const ScDPItemData* rItem1 = GetMemberById(nDim, nDataId1);
-const ScDPItemData* rItem2 = GetMemberById(nDim, nDataId2);
-if (rItem1 == nullptr || rItem2 == nullptr)
-return 0;
-return ScDPItemData::Compare( *rItem1,*rItem2);
+return ScDPItemData::Compare( *GetMemberById(nDim,
nDataId1),*GetMemberById(nDim, nDataId2) );
}
#if DEBUG_PIVOT_TABLE
diff --git a/sc/source/filter/excel/xepivotxml.cxx
b/sc/source/filter/excel/xepivotxml.cxx
index 94130bdbb3f9..31e46b70cf46 100644
--- a/sc/source/filter/excel/xepivotxml.cxx
+++ b/sc/source/filter/excel/xepivotxml.cxx
@@ -324,22 +324,15 @@ XclExpXmlPivotTableManager::XclExpXmlPivotTableManager(
const XclExpRoot& rRoot
void XclExpXmlPivotTableManager::Initialize()
{
-ScDocument& rDoc = GetDoc();
+const ScDocument& rDoc = GetDoc();
if (!rDoc.HasPivotTable())
// No pivot table to export.
return;
-ScDPCollection* pDPColl = rDoc.GetDPCollection();
+const ScDPCollection* pDPColl = rDoc.GetDPCollection();
if (!pDPColl)
return;
-// Update caches from DPObject
-for (size_t i = 0; i < pDPColl->GetCount(); ++i)
-{
-ScDPObject& rDPObj = (*pDPColl)[i];
-rDPObj.SyncAllDimensionMembers();
-}
-
// Go through the caches first.
std::vector aCaches;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 122936] Cannot Assign a macro to a button in Libre Office 6.1 in Linux Mint Mate 19.0 Libre Offices crashes.
https://bugs.documentfoundation.org/show_bug.cgi?id=122936 Xisco Faulí changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #6 from Xisco Faulí --- I can't reproduce it in Version: 6.1.4.2 Build ID: 1:6.1.4-0ubuntu0.16.04.1~lo2 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded I can assign both macros to the button click action. Does it work if you disable OpenGl ? -> https://wiki.documentfoundation.org/OpenGL I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the issue is still present -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103182 Bug 103182 depends on bug 122931, which changed state. Bug 122931 Summary: CRASH: GTK3: Closing Bullet and Numbering Dialog after showing the graphics gallery https://bugs.documentfoundation.org/show_bug.cgi?id=122931 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122936] Cannot Assign a macro to a button in Libre Office 6.1 in Linux Mint Mate 19.0 Libre Offices crashes.
https://bugs.documentfoundation.org/show_bug.cgi?id=122936 Xisco Faulí changed: What|Removed |Added Assignee|rjs1...@live.com|libreoffice-b...@lists.free ||desktop.org CC||xiscofa...@libreoffice.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122927] Writer hangs if I insert a graphic from the gallery as a list bullet
https://bugs.documentfoundation.org/show_bug.cgi?id=122927 --- Comment #5 from Xisco Faulí --- Created attachment 148611 --> https://bugs.documentfoundation.org/attachment.cgi?id=148611=edit screencast showing the problem Does the gallery in this case behave like a filepicker ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45904] move java based api tests to c++
https://bugs.documentfoundation.org/show_bug.cgi?id=45904 --- Comment #226 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/b5d2ebb76e763457a8c8f07b26d542295e82e192%5E%21 tdf#45904 Move XTableChart Java tests to C++ It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa
sc/qa/extras/scchartobj.cxx |8
1 file changed, 8 insertions(+)
New commits:
commit c7e064e8a1ca7711cb541c8678ea2ffabd5af7d3
Author: Jens Carl
AuthorDate: Thu Jan 24 08:56:35 2019 +
Commit: Jens Carl
CommitDate: Thu Jan 24 22:02:46 2019 +0100
Add XServiceInfo tests to ScChartObj
Change-Id: I0de28d9a005a2688067610d141e12dfadf37b69a
Reviewed-on: https://gerrit.libreoffice.org/66845
Tested-by: Jenkins
Reviewed-by: Jens Carl
diff --git a/sc/qa/extras/scchartobj.cxx b/sc/qa/extras/scchartobj.cxx
index 20c6688aa4d7..2492a593db9c 100644
--- a/sc/qa/extras/scchartobj.cxx
+++ b/sc/qa/extras/scchartobj.cxx
@@ -11,6 +11,7 @@
#include
#include
#include
+#include
#include
#include
@@ -38,6 +39,7 @@ namespace sc_apitest
class ScChartObj : public CalcUnoApiTest,
public apitest::XEmbeddedObjectSupplier,
public apitest::XNamed,
+ public apitest::XServiceInfo,
public apitest::XTableChart
{
public:
@@ -56,6 +58,11 @@ public:
CPPUNIT_TEST(testGetName);
CPPUNIT_TEST(testSetNameThrowsException);
+// XServiceInfo
+CPPUNIT_TEST(testGetImplementationName);
+CPPUNIT_TEST(testGetSupportedServiceNames);
+CPPUNIT_TEST(testSupportsService);
+
// XTableChart
CPPUNIT_TEST(testGetSetHasColumnHeaders);
CPPUNIT_TEST(testGetSetHasRowHeaders);
@@ -70,6 +77,7 @@ private:
ScChartObj::ScChartObj()
: CalcUnoApiTest("/sc/qa/extras/testdocuments")
, XNamed("ScChartObj")
+, XServiceInfo("ScChartObj", "com.sun.star.table.TableChart")
{
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/test qadevOOo/Jar_OOoRunner.mk qadevOOo/objdsc qadevOOo/tests sc/qa test/Library_subsequenttest.mk test/source
include/test/table/xtablechart.hxx | 37 ++
qadevOOo/Jar_OOoRunner.mk |1
qadevOOo/objdsc/sc/com.sun.star.comp.office.ScChartObj.csv |6
qadevOOo/tests/java/mod/_sc/ScChartObj.java| 234 -
sc/qa/extras/scchartobj.cxx|9
sc/qa/unoapi/sc_3.sce |1
test/Library_subsequenttest.mk |1
test/source/table/xtablechart.cxx | 60 +++
8 files changed, 106 insertions(+), 243 deletions(-)
New commits:
commit b5d2ebb76e763457a8c8f07b26d542295e82e192
Author: Jens Carl
AuthorDate: Thu Jan 24 08:49:21 2019 +
Commit: Jens Carl
CommitDate: Thu Jan 24 22:02:07 2019 +0100
tdf#45904 Move XTableChart Java tests to C++
Move XTableChart Java tests to C++ for ScChartObj.
Change-Id: I007d484357b5743a4283e9aa41bc6d203d312379
Reviewed-on: https://gerrit.libreoffice.org/66842
Tested-by: Jenkins
Reviewed-by: Jens Carl
diff --git a/include/test/table/xtablechart.hxx
b/include/test/table/xtablechart.hxx
new file mode 100644
index ..6c57bf3ac332
--- /dev/null
+++ b/include/test/table/xtablechart.hxx
@@ -0,0 +1,37 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4;
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#ifndef INCLUDED_TEST_TABLE_XTABLECHART_HXX
+#define INCLUDED_TEST_TABLE_XTABLECHART_HXX
+
+#include
+
+#include
+
+#include
+
+namespace apitest
+{
+class OOO_DLLPUBLIC_TEST XTableChart
+{
+public:
+virtual css::uno::Reference init() = 0;
+
+void testGetSetHasColumnHeaders();
+void testGetSetHasRowHeaders();
+void testGetSetRanges();
+
+protected:
+~XTableChart() {}
+};
+} // namespace apitest
+
+#endif // INCLUDED_TEST_TABLE_XTABLECHART_HXX
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s
cinkeys+=0=break: */
diff --git a/qadevOOo/Jar_OOoRunner.mk b/qadevOOo/Jar_OOoRunner.mk
index 2828744ee90e..8a8374069326 100644
--- a/qadevOOo/Jar_OOoRunner.mk
+++ b/qadevOOo/Jar_OOoRunner.mk
@@ -962,7 +962,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\
qadevOOo/tests/java/mod/_sc/ScCellRangesObj \
qadevOOo/tests/java/mod/_sc/ScCellSearchObj \
qadevOOo/tests/java/mod/_sc/ScCellTextCursor \
-qadevOOo/tests/java/mod/_sc/ScChartObj \
qadevOOo/tests/java/mod/_sc/ScChartsObj \
qadevOOo/tests/java/mod/_sc/ScDatabaseRangeObj \
qadevOOo/tests/java/mod/_sc/ScDataPilotFieldGroupItemObj \
diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScChartObj.csv
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScChartObj.csv
deleted file mode 100644
index 921ae1ef8e1b..
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScChartObj.csv
+++ /dev/null
@@ -1,6 +0,0 @@
-"ScChartObj";"com::sun::star::table::XTableChart";"getHasColumnHeaders()"
-"ScChartObj";"com::sun::star::table::XTableChart";"setHasColumnHeaders()"
-"ScChartObj";"com::sun::star::table::XTableChart";"getHasRowHeaders()"
-"ScChartObj";"com::sun::star::table::XTableChart";"setHasRowHeaders()"
-"ScChartObj";"com::sun::star::table::XTableChart";"getRanges()"
-"ScChartObj";"com::sun::star::table::XTableChart";"setRanges()"
diff --git a/qadevOOo/tests/java/mod/_sc/ScChartObj.java
b/qadevOOo/tests/java/mod/_sc/ScChartObj.java
deleted file mode 100644
index d768ceb61128..
--- a/qadevOOo/tests/java/mod/_sc/ScChartObj.java
+++ /dev/null
@@ -1,234 +0,0 @@
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed
- * with this work for additional information regarding copyright
- * ownership. The ASF licenses this file to you under the Apache
- * License, Version 2.0 (the "License"); you may not use this file
- * except in compliance with the License. You may obtain a copy of
- * the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-package mod._sc;
-
-import java.io.PrintWriter;
-
-import lib.TestCase;
-import lib.TestEnvironment;
-import lib.TestParameters;
-import util.SOfficeFactory;
-
-import com.sun.star.awt.Rectangle;
-import com.sun.star.container.XIndexAccess;
-import com.sun.star.container.XNameAccess;
-import com.sun.star.lang.XComponent;
-import
[Libreoffice-bugs] [Bug 122927] Writer hangs if I insert a graphic from the gallery as a list bullet
https://bugs.documentfoundation.org/show_bug.cgi?id=122927 --- Comment #4 from Xisco Faulí --- (In reply to Jan-Marek Glogowski from comment #3) > @Xisco: at which point is a filepicker involved in the process? > The commit just changes the native Windows file picker. > > I couldn't reproduce with my older Windows master. So, I have an old build from 6 month ago on windows and I can't reproduce the hang. I've cherry-picked the commit from gerrit and I can reproduce it -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Linker problems with system vs bundled libraries (RPATH vs RUNPATH)
Hello, I've decided to finally switch the default on --enable-ld to make configure automatically pick the gold/lld linkers if available, as talked about around the end of summer. However, it turns out at least least the relevant Jenkins build fails with a linker different than the old ld.bfd. I think it's really just a problem with the unusual setup of the build system, but I still want to post it here, just in case somebody sees/knows something that I've missed. And of course, if it's really just a problem with the Jenkins box, it'd be nice if somebody fixed that. Basically, the problem seems to be a variant of http://blog.qt.io/blog/2011/10/28/rpath-and-runpath/ . In the build log (https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/22968/consoleFull#12040746019567f988-cbcf-4519-af05-6000b834f13f) there is an error message about "...instdir/program/soffice.bin: /lib64/libgpg-error.so.0: no version information available (required by ...instdir/program/libgpgme.so.11)". But our libgpgme shouldn't be using system libgpg-error, they're both bundled. I cannot reproduce the problem locally, but what I think happens is this: Using "ldd -v soffice.bin" reveals that it ends up using libgpg-error at least two ways, one indirectly by (bundled) libgpgme, one indirectly by system libraries (dbus, etc.). But a process loads the library just once. This normally is not a problem, because apparently either on most systems both the system and bundled version can stand in for each other, or everybody is lucky enough to pull in the newer version. Except for that Jenkins box when it uses ld.gold, that is. I've looked into the problem, the Qt link above and other info I could find, and it seems the underlying issue cannot really be solved. Whatever we do, as long as there's any LO build that bundles a library that's also available as a system one, there's a risk of a case when the older one gets pulled in. You can read the Qt link for details on how RPATH and RUNPATH differ in searching for libraries, but in a nutshell: RPATH makes LO prefer our bundled libs, so there will be a problem if we bundle a lib that's too old for a system lib. RUNPATH makes LO prefer system libs when they are used by other system libs, so there will be a problem if the system lib is too old for our bundled lib (even if the bundled lib build fine against the bundled version of that relevant system lib). And that's presumably why the Jenkins build builds. It has old ld.bfd that still uses RPATH, and so LO picks up bundled libgpg-error and it works, but ld.gold uses RUNPATH, which leads to using the too-old system libgpg-error. I cannot reproduce the problem locally not only because my system libgpg-error is new enough, but also because on my system both ld.bfd and ld.gold use RUNPATH. That also means that just a newer linker on the Jenkins box would cause the same error, even without my patch. So, if I'm right, we basically can't entirely avoid the problem, and so the best course of action seems to be to shrug and not bother with these problems except for solving them as they appear (which, in this case, means updating libgpg-error on the Jenkins box). Does somebody have a better idea? -- Luboš Luňák l.lu...@collabora.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 121846] LibreOffice draw and libreOffice Impress do not start
https://bugs.documentfoundation.org/show_bug.cgi?id=121846 raal changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||r...@post.cz --- Comment #3 from raal --- *** This bug has been marked as a duplicate of bug 119408 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sccomp/qa
sccomp/qa/unit/SwarmSolverTest.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 938012a9f42761836d5240ab8efacbeeaf3385b2 Author: Stephan Bergmann AuthorDate: Thu Jan 24 14:05:32 2019 +0100 Commit: Stephan Bergmann CommitDate: Thu Jan 24 21:23:24 2019 +0100 Fix order of CPPUNIT_ASSERT_EQUAL expected vs. actual arguments Change-Id: I36ea52e6ef7142566d4155c5279f791d4cf509a1 Reviewed-on: https://gerrit.libreoffice.org/66867 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/sccomp/qa/unit/SwarmSolverTest.cxx b/sccomp/qa/unit/SwarmSolverTest.cxx index 2f0e6d48104b..b7bd3025373e 100644 --- a/sccomp/qa/unit/SwarmSolverTest.cxx +++ b/sccomp/qa/unit/SwarmSolverTest.cxx @@ -102,7 +102,7 @@ void SwarmSolverTest::testUnconstrained() CPPUNIT_ASSERT(xSolver->getSuccess()); uno::Sequence aSolution = xSolver->getSolution(); -CPPUNIT_ASSERT_EQUAL(aSolution.getLength(), aVariables.getLength()); +CPPUNIT_ASSERT_EQUAL(aVariables.getLength(), aSolution.getLength()); // It happens that the unconstrained test does not find a solution in the // timeframe or number of generations it has available as the search space is // too big and the values might not converge to solution. So for now just run @@ -161,7 +161,7 @@ void SwarmSolverTest::testVariableBounded() CPPUNIT_ASSERT(xSolver->getSuccess()); uno::Sequence aSolution = xSolver->getSolution(); -CPPUNIT_ASSERT_EQUAL(aSolution.getLength(), aVariables.getLength()); +CPPUNIT_ASSERT_EQUAL(aVariables.getLength(), aSolution.getLength()); CPPUNIT_ASSERT_DOUBLES_EQUAL(3.0, aSolution[0], 1E-5); } @@ -219,7 +219,7 @@ void SwarmSolverTest::testVariableConstrained() CPPUNIT_ASSERT(xSolver->getSuccess()); uno::Sequence aSolution = xSolver->getSolution(); -CPPUNIT_ASSERT_EQUAL(aSolution.getLength(), aVariables.getLength()); +CPPUNIT_ASSERT_EQUAL(aVariables.getLength(), aSolution.getLength()); CPPUNIT_ASSERT_DOUBLES_EQUAL(-0.741657, aSolution[0], 1E-5); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 119408] Fails to start Draw, Impress due to new Avahi dependency
https://bugs.documentfoundation.org/show_bug.cgi?id=119408 raal changed: What|Removed |Added Ever confirmed|0 |1 CC||r...@post.cz Status|UNCONFIRMED |NEW --- Comment #4 from raal --- Confirmed with duplicate bug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119408] Fails to start Draw, Impress due to new Avahi dependency
https://bugs.documentfoundation.org/show_bug.cgi?id=119408 raal changed: What|Removed |Added CC||epr...@cesip.it --- Comment #3 from raal --- *** Bug 121846 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122937] The SOMME function not working
https://bugs.documentfoundation.org/show_bug.cgi?id=122937 Guy Menard changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |dran...@gmail.com |desktop.org | Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #2 from Guy Menard --- Created attachment 148610 --> https://bugs.documentfoundation.org/attachment.cgi?id=148610=edit error of the SOMME function please find a file with the bug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122727] opening ods file (saved in Office 5.3) and adding new data in office 6.0.7.3; pivot table refresh get errors
https://bugs.documentfoundation.org/show_bug.cgi?id=122727 raal changed: What|Removed |Added Keywords||bibisected, bisected, ||regression Ever confirmed|0 |1 CC||bernhard.w...@cib.de Status|UNCONFIRMED |NEW --- Comment #5 from raal --- Need to recalculate formula BH2 again - F9 This seems to have begun at the below commit. Adding Cc: to Bernhard Widl ; Could you possibly take a look at this one? Thanks f74eb5670fbb48853f6fd7c38f5d3da9a3b42ad0 is the first bad commit commit f74eb5670fbb48853f6fd7c38f5d3da9a3b42ad0 Author: Jenkins Build User Date: Tue Apr 11 09:25:23 2017 +0200 source sha:78dfedec7a7ba289691a5d18441796541f3b1812 author Bernhard Widl 2017-04-06 18:17:25 +0200 committer Eike Rathke 2017-04-10 23:56:50 +0200 commit 78dfedec7a7ba289691a5d18441796541f3b1812 (patch) tree37e8721d56415fa4abde6db56c0d37bfc39ce53f parent 13b70bc6f18f8dd910e373694de5a6a0cd3eb559 (diff) tdf#105044 match empty cells on "<> not-empty" comparisons this affects any formula using <> over a range of cells (not only SUMIF and SUMIFS) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: basic/CppunitTest_basic_macros.mk embeddedobj/Module_embeddedobj.mk embedserv/Module_embedserv.mk postprocess/Rdb_services.mk sw/CppunitTest_sw_ww8export2.mk sw/Cppunit
basic/CppunitTest_basic_macros.mk |4 ++-- embeddedobj/Module_embeddedobj.mk |2 +- embedserv/Module_embedserv.mk |7 +-- postprocess/Rdb_services.mk | 12 +--- sw/CppunitTest_sw_ww8export.mk |2 +- sw/CppunitTest_sw_ww8export2.mk |2 +- sw/CppunitTest_sw_ww8export3.mk |2 +- sw/ooxmlexport_setup.mk |4 +--- winaccessibility/Module_winaccessibility.mk |2 -- 9 files changed, 13 insertions(+), 24 deletions(-) New commits: commit df984a465cad0af7ab77257efe5181a8a3348dcf Author: Stephan Bergmann AuthorDate: Thu Jan 24 14:46:32 2019 +0100 Commit: Stephan Bergmann CommitDate: Thu Jan 24 21:23:56 2019 +0100 Clean up dead uses of DISABLE_ATL ...after e597ef0489d9d5504721d21eefa15c65da0fb240 "No need for --disable-activex and --disable-atl any longer" Change-Id: I6ea0026fd18e0097aaaf0c1b05618e2a9ddf1a94 Reviewed-on: https://gerrit.libreoffice.org/66871 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/basic/CppunitTest_basic_macros.mk b/basic/CppunitTest_basic_macros.mk index 2ce70764e294..e86c3dae27e4 100644 --- a/basic/CppunitTest_basic_macros.mk +++ b/basic/CppunitTest_basic_macros.mk @@ -61,8 +61,8 @@ $(eval $(call gb_CppunitTest_use_components,basic_macros,\ i18npool/util/i18npool \ ucb/source/core/ucb1 \ ucb/source/ucp/file/ucpfile1 \ - $(if $(DISABLE_ATL),,$(if $(filter $(OS),WNT), \ - extensions/source/ole/oleautobridge)) \ + $(if $(filter $(OS),WNT), \ + extensions/source/ole/oleautobridge) \ )) $(eval $(call gb_CppunitTest_use_configuration,basic_macros)) diff --git a/embeddedobj/Module_embeddedobj.mk b/embeddedobj/Module_embeddedobj.mk index 68b38e80e909..f344565192f6 100644 --- a/embeddedobj/Module_embeddedobj.mk +++ b/embeddedobj/Module_embeddedobj.mk @@ -12,7 +12,7 @@ $(eval $(call gb_Module_Module,embeddedobj)) $(eval $(call gb_Module_add_targets,embeddedobj,\ Library_embobj \ - $(if $(filter WNT-TRUE,$(OS)-$(DISABLE_ATL)),,Library_emboleobj) \ + Library_emboleobj \ )) # vim: set noet sw=4 ts=4: diff --git a/embedserv/Module_embedserv.mk b/embedserv/Module_embedserv.mk index fc1119012473..505efa5c4494 100644 --- a/embedserv/Module_embedserv.mk +++ b/embedserv/Module_embedserv.mk @@ -13,14 +13,9 @@ $(eval $(call gb_Module_Module,embedserv)) ifeq ($(OS),WNT) $(eval $(call gb_Module_add_targets,embedserv,\ - $(if $(filter WNT-TRUE,$(OS)-$(DISABLE_ATL)),,Library_inprocserv) \ -)) - -ifeq ($(DISABLE_ATL),) -$(eval $(call gb_Module_add_targets,embedserv,\ Library_emser \ + Library_inprocserv \ )) -endif endif diff --git a/postprocess/Rdb_services.mk b/postprocess/Rdb_services.mk index 0e175de547cc..c70d1ca52005 100644 --- a/postprocess/Rdb_services.mk +++ b/postprocess/Rdb_services.mk @@ -154,13 +154,11 @@ $(eval $(call gb_Rdb_add_components,services,\ $(if $(filter-out WNT,$(OS)), \ embeddedobj/source/msole/emboleobj \ ) \ - $(if $(DISABLE_ATL),, \ - $(if $(filter WNT,$(OS)), \ - embeddedobj/source/msole/emboleobj.windows \ - embedserv/util/emser \ - extensions/source/ole/oleautobridge \ - winaccessibility/source/service/winaccessibility \ - ) \ + $(if $(filter WNT,$(OS)), \ + embeddedobj/source/msole/emboleobj.windows \ + embedserv/util/emser \ + extensions/source/ole/oleautobridge \ + winaccessibility/source/service/winaccessibility \ ) \ $(if $(WITH_WEBDAV), \ ucb/source/ucp/webdav-neon/ucpdav1 \ diff --git a/sw/CppunitTest_sw_ww8export.mk b/sw/CppunitTest_sw_ww8export.mk index 4fcf5be03470..548a7bcbad77 100644 --- a/sw/CppunitTest_sw_ww8export.mk +++ b/sw/CppunitTest_sw_ww8export.mk @@ -19,7 +19,7 @@ $(eval $(call gb_CppunitTest_use_libraries,sw_ww8export, \ comphelper \ cppu \ cppuhelper \ -$(if $(filter WNT-TRUE,$(OS)-$(DISABLE_ATL)),,emboleobj) \ +emboleobj \ sal \ test \ unotest \ diff --git a/sw/CppunitTest_sw_ww8export2.mk b/sw/CppunitTest_sw_ww8export2.mk index df8ae2ace998..ff620638cfed 100644 --- a/sw/CppunitTest_sw_ww8export2.mk +++ b/sw/CppunitTest_sw_ww8export2.mk @@ -20,7 +20,7 @@ $(eval $(call gb_CppunitTest_use_libraries,sw_ww8export2, \ cppu \ cppuhelper \ editeng \ -$(if $(filter WNT-TRUE,$(OS)-$(DISABLE_ATL)),,emboleobj) \ +emboleobj \ sal \ sfx \ test \ diff --git a/sw/CppunitTest_sw_ww8export3.mk b/sw/CppunitTest_sw_ww8export3.mk index 564f344d7297..3ceb6178e698 100644 --- a/sw/CppunitTest_sw_ww8export3.mk +++ b/sw/CppunitTest_sw_ww8export3.mk @@ -20,7 +20,7 @@ $(eval $(call gb_CppunitTest_use_libraries,sw_ww8export3, \
[Libreoffice-bugs] [Bug 122727] opening ods file (saved in Office 5.3) and adding new data in office 6.0.7.3; pivot table refresh get errors
https://bugs.documentfoundation.org/show_bug.cgi?id=122727 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #4 from raal --- Hello Dragos, I opened your file in version 5.2. and 6.3 and in both version is BH2 = 13 on sheet "date" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122939] Crash when I'm working whith graph in the report mode
https://bugs.documentfoundation.org/show_bug.cgi?id=122939 Xisco Faulí changed: What|Removed |Added Crash report or||["pcr::FormComponentPropert crash signature||yHandler::impl_getPropertyV ||alue_throw(rtl::OUString ||const &)"] Ever confirmed|0 |1 See Also||https://crashreport.libreof ||fice.org/stats/signature/pc ||r::FormComponentPropertyHan ||dler::impl_getPropertyValue ||_throw(rtl::OUString%20cons ||t%20&) CC||xiscofa...@libreoffice.org Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Xisco Faulí --- it seems like the same crash signature as bug 117159 Thank you for reporting the bug. Please attach a sample document, as this makes it easier for us to verify the bug. (Please note that the attachment will be public, remove any sensitive information before attaching it. See https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F for help on how to do so.) I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Could not determine MSC version (Visual Studio 2017)
sberg wrote > On 24/01/2019 15:52, julien2412 wrote: >> I got when using /opt/lo/bin/make >> checking for cl... cl >> configure: error: Could not determine MSC version. > > During the execution of what make target does that failure happen? > Re-execution of LO's top-level configure as triggered by the makefile, > or configure run for one of the external projects? (Include more > surrounding lines from the failure output, and for a parallel build make > sure to pass -O to make to keep the parallel jobs' output separated.) I did a global build, so just "make" Here what I did to avoid language pb: export LANG=C make clean make Here are the last lines: [build ULF] C:/BLP/libo-core/workdir/ScpMergeTarget/scp2/source/writer/registryitem_writer.ulf [build ULF] C:/BLP/libo-core/workdir/ScpMergeTarget/scp2/source/winexplorerext/module_winexplorerext.ulf [build MO ] sdfr [build MO ] sfxfr [build ULF] C:/BLP/libo-core/workdir/CustomTarget/shell/source/win32/shlxthandler/res/shlxthdl.ulf [build MO ] smfr [build MO ] svlfr [build MO ] svtfr [build MO ] svxfr [build MO ] swfr [build MOD] ucbhelper [build MO ] uuifr [build MO ] vclfr [build PRP] CustomTarget/wizards/locproperties/resources_fr.properties [build PRP] CustomTarget/wizards/locproperties/resources_qtz.properties [build MO ] wizfr [build MO ] wptfr [build MO ] xscfr [build PAT] libxslt [build UIC] modules/dbapp make[2]: warning: -jN forced in submake: disabling jobserver mode. expr: syntax error expr: syntax error expr: syntax error checking build system type... x86_64-unknown-cygwin checking host system type... x86_64-unknown-cygwin checking target system type... x86_64-unknown-cygwin checking for cl... cl configure: error: Could not determine MSC version. make[2]: *** [Makefile:129: ../nspr/out/config.status] Error 1 It seems it's quite at random since the build runned a longer time. I'll try "make -O" tomorrow. remarks: - building with Cygwin was taking a lot memory (I got 8GB) and, contrary to Linux building, I saw a lot of "include file" in console. (perhaps both are linked) - also when using Ctrl-C on cygwin to stop the process then close cygwin, it seems it doesn't stop process and so doesn't free memory ; ie I could see several "make" process on tasks manager. Hope LO may be built with Windows native tools instead of cygwin. -- Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 122940] New: Allow per-document Macro Security settings
https://bugs.documentfoundation.org/show_bug.cgi?id=122940 Bug ID: 122940 Summary: Allow per-document Macro Security settings Product: LibreOffice Version: 6.3.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jim.av...@gmail.com Description: It would be great if the "Enable Macros?" dialog allowed an option of "Don't ask again for this document". The answer (yes or no) would be stored in the user's profile, linked to the path or URI of the document. Optionally, also provide a "Don't ask again for this version of this document" option which also stores a cryptographic checksum. Options->Security->Macro Security would have a button to "forget per-document security settings" (probably any change to the global settings should implicitly forget the saved settings as well). Motivation: Currently it is annoying to have to enable macros every time a known document is opened. Of course, the user can set Macro Security to "Low" to trust every document unconditionally, but that is too dangerous. In fact, if per-document settings are implemented, the "trust all documents without asking" option should IMO be eliminated. It is simply never good practice to do that. Steps to Reproduce: . Actual Results: . Expected Results: . Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: offapi/com sw/qa sw/source
offapi/com/sun/star/text/XPasteListener.idl |1
sw/qa/extras/unowriter/unowriter.cxx| 31
sw/source/uibase/dochdl/swdtflvr.cxx| 70 +++-
3 files changed, 80 insertions(+), 22 deletions(-)
New commits:
commit 2a054445f09e8ba66e7cfb9f1d598554b555772d
Author: Miklos Vajna
AuthorDate: Thu Jan 24 17:01:14 2019 +0100
Commit: Miklos Vajna
CommitDate: Thu Jan 24 20:57:29 2019 +0100
sw paste listener: expose pasted images as well
Do it similar to SwXTextView::getSelection(), so that
SwView::GetShellMode() determines when an image is selected (and
otherwise assume text selection).
Change-Id: I717e1358428daba842309260b54f82b62a0aaec1
Reviewed-on: https://gerrit.libreoffice.org/66879
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/offapi/com/sun/star/text/XPasteListener.idl
b/offapi/com/sun/star/text/XPasteListener.idl
index ce5d663f4ccd..b1a98cae5b12 100644
--- a/offapi/com/sun/star/text/XPasteListener.idl
+++ b/offapi/com/sun/star/text/XPasteListener.idl
@@ -29,6 +29,7 @@ interface XPasteListener : com::sun::star::uno::XInterface
The following keys may be used:
TextRange
+TextGraphicObject
*/
void notifyPasteEvent([in] sequence<
::com::sun::star::beans::PropertyValue > aEvent);
diff --git a/sw/qa/extras/unowriter/unowriter.cxx
b/sw/qa/extras/unowriter/unowriter.cxx
index 77186c1d9350..abe80e2ccaf8 100644
--- a/sw/qa/extras/unowriter/unowriter.cxx
+++ b/sw/qa/extras/unowriter/unowriter.cxx
@@ -18,9 +18,11 @@
#include
#include
#include
+#include
#include
#include
#include
+#include
using namespace ::com::sun::star;
using namespace ::com::sun::star::uno;
@@ -34,11 +36,13 @@ char const DATA_DIRECTORY[] =
"/sw/qa/extras/unowriter/data/";
class PasteListener : public cppu::WeakImplHelper
{
OUString m_aString;
+uno::Reference m_xTextGraphicObject;
public:
void SAL_CALL notifyPasteEvent(const uno::Sequence&
rEvent) override;
OUString& GetString();
+uno::Reference& GetTextGraphicObject();
};
void PasteListener::notifyPasteEvent(const
uno::Sequence& rEvent)
@@ -50,10 +54,24 @@ void PasteListener::notifyPasteEvent(const
uno::Sequence&
auto xTextRange = it->second.get>();
if (xTextRange.is())
m_aString = xTextRange->getString();
+return;
+}
+
+it = aMap.find("TextGraphicObject");
+if (it != aMap.end())
+{
+auto xTextGraphicObject =
it->second.get>();
+if (xTextGraphicObject.is())
+m_xTextGraphicObject = xTextGraphicObject;
}
}
OUString& PasteListener::GetString() { return m_aString; }
+
+uno::Reference& PasteListener::GetTextGraphicObject()
+{
+return m_xTextGraphicObject;
+}
}
/// Test to assert UNO API call results of Writer.
@@ -533,6 +551,19 @@ DECLARE_UNOAPI_TEST(testPasteListener)
// Make sure that paste overwrote "BC".
CPPUNIT_ASSERT_EQUAL(OUString("ADEDEF"), xBodyText->getString());
+// Test image paste.
+SwView& rView = pWrtShell->GetView();
+OUString aGraphicURL = m_directories.getURLFromSrc(DATA_DIRECTORY) +
"test.jpg";
+rView.InsertGraphic(aGraphicURL, OUString(), /*bAsLink=*/false,
+::GetGraphicFilter());
+pTransfer->Cut();
+pListener->GetString().clear();
+SwTransferable::Paste(*pWrtShell, aHelper);
+// Without the working image listener in place, this test would have
+// failed, the listener was not invoked in case of a graphic paste.
+CPPUNIT_ASSERT(pListener->GetTextGraphicObject().is());
+CPPUNIT_ASSERT(pListener->GetString().isEmpty());
+
// Deregister paste listener, make sure it's not invoked.
xBroadcaster->removePasteEventListener(xListener);
pListener->GetString().clear();
diff --git a/sw/source/uibase/dochdl/swdtflvr.cxx
b/sw/source/uibase/dochdl/swdtflvr.cxx
index c7aa43238729..0c99d8424688 100644
--- a/sw/source/uibase/dochdl/swdtflvr.cxx
+++ b/sw/source/uibase/dochdl/swdtflvr.cxx
@@ -126,6 +126,7 @@
#include
#include
#include
+#include
#include
#include
@@ -1125,35 +1126,60 @@ SwPasteContext::~SwPasteContext()
if (m_rWrtShell.GetPasteListeners().getLength() == 0)
return;
-if (!m_pPaM)
-return;
+beans::PropertyValue aPropertyValue;
-SwPaM* pCursor = m_rWrtShell.GetCursor();
-if (!pCursor)
-return;
+switch (m_rWrtShell.GetView().GetShellMode())
+{
+case ShellMode::Graphic:
+{
+SwFrameFormat* pFormat = m_rWrtShell.GetFlyFrameFormat();
+if (!pFormat)
+return;
-if (!pCursor->GetPoint()->nNode.GetNode().IsTextNode())
-// Non-text was pasted.
-return;
+aPropertyValue.Name = "TextGraphicObject";
+aPropertyValue.Value
+
[Libreoffice-commits] core.git: sc/source
sc/source/core/opencl/formulagroupcl.cxx |5 +
1 file changed, 5 insertions(+)
New commits:
commit 78317bc663a0c33bef536b3db98380e64ce32b28
Author: Luboš Luňák
AuthorDate: Fri Nov 30 15:02:48 2018 +0100
Commit: Luboš Luňák
CommitDate: Thu Jan 24 20:37:56 2019 +0100
in dbgutils mode, abort if an OpenCL program fails to compile
Change-Id: I86e57e6da645b59f8c71387057047c9aab4d1759
Reviewed-on: https://gerrit.libreoffice.org/65480
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/sc/source/core/opencl/formulagroupcl.cxx
b/sc/source/core/opencl/formulagroupcl.cxx
index ab43f2f3092a..594ad8acf8bc 100644
--- a/sc/source/core/opencl/formulagroupcl.cxx
+++ b/sc/source/core/opencl/formulagroupcl.cxx
@@ -4029,7 +4029,12 @@ void DynamicKernel::CreateKernel()
}
}
#endif
+#ifdef DBG_UTIL
+SAL_WARN("sc.opencl", "Program failed to build, aborting.");
+abort(); // make sure errors such as typos don't accidentally
go unnoticed
+#else
throw OpenCLError("clBuildProgram", err, __FILE__, __LINE__);
+#endif
}
SAL_INFO("sc.opencl", "Built program " << mpProgram);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/core/opencl/formulagroupcl.cxx | 15 +--
sc/source/core/opencl/opbase.hxx |2 ++
2 files changed, 15 insertions(+), 2 deletions(-)
New commits:
commit 2675e4283a5eceb30d47e622775e7e8c4fc98f15
Author: Luboš Luňák
AuthorDate: Fri Nov 30 15:01:52 2018 +0100
Commit: Luboš Luňák
CommitDate: Thu Jan 24 20:36:24 2019 +0100
avoid incorrect OpenCL code with empty arguments
Change-Id: Ib7438cc2e9a020ce0cfcc649cd82667c64e0d3df
Reviewed-on: https://gerrit.libreoffice.org/65479
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/sc/source/core/opencl/formulagroupcl.cxx
b/sc/source/core/opencl/formulagroupcl.cxx
index 8a0d22529007..ab43f2f3092a 100644
--- a/sc/source/core/opencl/formulagroupcl.cxx
+++ b/sc/source/core/opencl/formulagroupcl.cxx
@@ -2598,6 +2598,13 @@ public:
for (const auto & rSubArgument : mvSubArguments)
rSubArgument->DumpInlineFun(decls, funs);
}
+virtual bool IsEmpty() const override
+{
+for (const auto & rSubArgument : mvSubArguments)
+if( !rSubArgument->IsEmpty())
+return false;
+return true;
+}
virtual ~DynamicKernelSoPArguments() override
{
if (mpClmem2)
@@ -3887,8 +3894,12 @@ void DynamicKernel::CodeGen()
mSyms.DumpSlidingWindowFunctions(decl);
mKernelSignature = DK->DumpOpName();
decl << "__kernel void DynamicKernel" << mKernelSignature;
-decl << "(__global double *result, ";
-DK->GenSlidingWindowDecl(decl);
+decl << "(__global double *result";
+if( !DK->IsEmpty())
+{
+decl << ", ";
+DK->GenSlidingWindowDecl(decl);
+}
decl << ") {\n\tint gid0 = get_global_id(0);\n\tresult[gid0] = " <<
DK->GenSlidingWindowDeclRef() << ";\n}\n";
mFullProgramSrc = decl.str();
diff --git a/sc/source/core/opencl/opbase.hxx b/sc/source/core/opencl/opbase.hxx
index 112589a6a5f6..1e36e7c1a29f 100644
--- a/sc/source/core/opencl/opbase.hxx
+++ b/sc/source/core/opencl/opbase.hxx
@@ -140,6 +140,8 @@ public:
virtual void DumpInlineFun( std::set&, std::set&
) const;
const std::string& GetName() const;
virtual bool NeedParallelReduction() const;
+/// If there's actually no argument, i.e. it expands to no code.
+virtual bool IsEmpty() const { return false; }
protected:
const ScCalcConfig& mCalcConfig;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/core/opencl/formulagroupcl.cxx | 102 ++-
1 file changed, 62 insertions(+), 40 deletions(-)
New commits:
commit 89b9969d24c0272948004fffedf62725671670a6
Author: Luboš Luňák
AuthorDate: Fri Nov 30 14:25:04 2018 +0100
Commit: Luboš Luňák
CommitDate: Thu Jan 24 20:35:39 2019 +0100
fix svDoubleRef handling in OpenCL
Basically just adjust it based on svSingleRef handling, as that one
seems sane, while the svDoubleRef case, as a comment puts it, is
"such crack". It didn't seem to make much sense written that way,
and it didn't handle correctly e.g. COUNT() with only strings,
OpCount says it doesn't take strings, but the code passed the arguments
to it anyway, in the "other case".
It'd be better to merge the code into one shared function, but sadly
there are small differencies, so at least this way for now.
Change-Id: Ia5f6ce60dae54b1d5a97e049600503aaa9be3bf0
Reviewed-on: https://gerrit.libreoffice.org/65478
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/sc/source/core/opencl/formulagroupcl.cxx
b/sc/source/core/opencl/formulagroupcl.cxx
index 357daa62a07b..8a0d22529007 100644
--- a/sc/source/core/opencl/formulagroupcl.cxx
+++ b/sc/source/core/opencl/formulagroupcl.cxx
@@ -2735,47 +2735,68 @@
DynamicKernelSoPArguments::DynamicKernelSoPArguments(const ScCalcConfig& config,
" takeNumeric=" <<
(pCodeGen->takeNumeric()?"YES":"NO") <<
" takeString=" <<
(pCodeGen->takeString()?"YES":"NO"));
-if (pDVR->GetArrays()[j].mpNumericArray ||
-(pDVR->GetArrays()[j].mpNumericArray == nullptr &&
-pDVR->GetArrays()[j].mpStringArray == nullptr))
+if (pDVR->GetArrays()[j].mpNumericArray &&
+pCodeGen->takeNumeric() &&
+pDVR->GetArrays()[j].mpStringArray &&
+pCodeGen->takeString())
{
-if (pDVR->GetArrays()[j].mpNumericArray &&
-pCodeGen->takeNumeric() &&
-pDVR->GetArrays()[j].mpStringArray &&
-pCodeGen->takeString())
-{
-// Function takes numbers or strings, there
are both
-SAL_INFO("sc.opencl", "Numbers and strings and
that is OK");
-mvSubArguments.push_back(
-DynamicKernelArgumentRef(
-new
DynamicKernelMixedSlidingArgument(mCalcConfig,
-ts, ft->Children[i], mpCodeGen,
j)));
-}
-else if
(!AllStringsAreNull(pDVR->GetArrays()[j].mpStringArray, pDVR->GetArrayLength())
&&
- !pCodeGen->takeString())
-{
-// Can't handle
-SAL_INFO("sc.opencl", "Strings but can't do
that.");
-throw UnhandledToken(("unhandled operand " +
StackVarEnumToString(pChild->GetType()) + " for ocPush").c_str(), __FILE__,
__LINE__);
-}
-else
-{
-// Not sure I can figure out what case this
exactly is;)
-SAL_INFO("sc.opencl", "The other case");
-mvSubArguments.push_back(
-
DynamicKernelArgumentRef(VectorRefFactory(mCalcConfig,
-ts, ft->Children[i], mpCodeGen,
j)));
-}
+// Function takes numbers or strings, there are
both
+SAL_INFO("sc.opencl", "Numbers and strings");
+mvSubArguments.push_back(
+DynamicKernelArgumentRef(
+new
DynamicKernelMixedSlidingArgument(mCalcConfig,
+ts, ft->Children[i], mpCodeGen, j)));
}
-else
+else if (pDVR->GetArrays()[j].mpNumericArray &&
+pCodeGen->takeNumeric() &&
+
(AllStringsAreNull(pDVR->GetArrays()[j].mpStringArray, pDVR->GetArrayLength())
|| mCalcConfig.meStringConversion == ScCalcConfig::StringConversion::ZERO))
{
-// Ditto here. This is such crack.
-SAL_INFO("sc.opencl", "The outer other case (can't
figure out what it exactly means)");
+
[Libreoffice-commits] core.git: sc/source
sc/source/core/opencl/formulagroupcl.cxx |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
New commits:
commit c706f61c076995e04038eef6c7fc2942f8e1fb58
Author: Luboš Luňák
AuthorDate: Fri Nov 30 12:52:53 2018 +0100
Commit: Luboš Luňák
CommitDate: Thu Jan 24 20:34:51 2019 +0100
say in log message which opcode is not handled by OpenCL
Change-Id: I836969c777382a3a7dce23733ebfc331391bf4b4
Reviewed-on: https://gerrit.libreoffice.org/65477
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/sc/source/core/opencl/formulagroupcl.cxx
b/sc/source/core/opencl/formulagroupcl.cxx
index 60b4ef6e7d3b..357daa62a07b 100644
--- a/sc/source/core/opencl/formulagroupcl.cxx
+++ b/sc/source/core/opencl/formulagroupcl.cxx
@@ -30,6 +30,8 @@
#include "op_spreadsheet.hxx"
#include "op_addin.hxx"
+#include
+
// FIXME: The idea that somebody would bother to (now and then? once a year?
once a month?) manually
// edit a source file and change the value of some #defined constant and run
some ill-defined
// "correctness test" is of course ludicrous. Either things are checked in
normal unit tests, in
@@ -3758,7 +3760,9 @@
DynamicKernelSoPArguments::DynamicKernelSoPArguments(const ScCalcConfig& config,
break;
default:
-throw UnhandledToken("unhandled opcode", __FILE__, __LINE__);
+throw UnhandledToken(OUString("unhandled opcode "
++
formula::FormulaCompiler().GetOpCodeMap(com::sun::star::sheet::FormulaLanguage::ENGLISH)->getSymbol(opc)
++ "(" + OUString::number(opc) + ")").toUtf8().getStr(),
__FILE__, __LINE__);
}
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 117761] Snake Algorithm unable to display accurate layout.
https://bugs.documentfoundation.org/show_bug.cgi?id=117761 Commit Notification changed: What|Removed |Added Whiteboard|target:6.2.0 target:6.1.4 |target:6.2.0 target:6.1.4 |target:6.1.5 target:6.2.1 |target:6.1.5 target:6.2.1 ||target:6.1.6 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117761] Snake Algorithm unable to display accurate layout.
https://bugs.documentfoundation.org/show_bug.cgi?id=117761 --- Comment #7 from Commit Notification --- Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-6-1": https://git.libreoffice.org/core/+/0e97e05d57a55d0825b321c0d0402dc619f089bf%5E%21 Related: tdf#117761 oox smartart: backport fixes related to org chart It will be available in 6.1.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - include/oox oox/source sd/qa
include/oox/drawingml/shape.hxx |7 oox/source/drawingml/diagram/datamodelcontext.cxx |2 oox/source/drawingml/diagram/diagram.hxx|3 oox/source/drawingml/diagram/diagramfragmenthandler.cxx |2 oox/source/drawingml/diagram/diagramlayoutatoms.cxx | 255 ++-- oox/source/drawingml/diagram/layoutatomvisitors.cxx |3 oox/source/drawingml/shape.cxx |1 sd/qa/unit/data/pptx/smartart-org-chart.pptx|binary sd/qa/unit/import-tests-smartart.cxx| 145 + 9 files changed, 390 insertions(+), 28 deletions(-) New commits: commit 0e97e05d57a55d0825b321c0d0402dc619f089bf Author: Miklos Vajna AuthorDate: Fri Dec 21 17:51:17 2018 +0100 Commit: Aron Budea CommitDate: Thu Jan 24 20:05:30 2019 +0100 Related: tdf#117761 oox smartart: backport fixes related to org chart This is a combination of 10 commits. This is the 1st commit: oox smartart, org chart: add initial hierChild/Root algorithms hierChild is supposed to align and position its child layout nodes in a linear path under the hierRoot layout node, so initially just use a simple vertical layout algorithm. (cherry picked from commit 3103f9f9461f6eabb61a70be73862ef4be98010e) This is the commit #2: oox smartart, org chart: handle multiple elements in hierChild In case one manager has multiple employees, then we laid out only the first one. Recognize non-assistant type as the node type (as a start) to get the correct number of employees (when there are no assistants), and also render employees on a horizontal (and not on a vertical) path. With this, the 1 manager and multiple employees case looks reasonable. (cherry picked from commit dcd378bf614c99d705312259a0a0a25b40d88e2b) This is the commit #3: oox smartart, org chart: fix font color when defined with quick styles createStyleMatrixContext() assumed that contains , but it contains instead. This resulted in a 0 mnThemedIdx, which meant that since commit 89206c472ecf18bfde6824cea8004921cd404365 (bnc#862510: PPTX import: Wrong text color inside shape, 2014-12-21) we ignored the theme color in oox::drawingml::Shape::createAndInsert(). (cherry picked from commit 5dfd5755c709e91d2903bd7be4582f7832e89780) This is the commit #4: oox smartart, org chart: fix vertical order of assistant nodes It seems the manager -> assistant -> employees ordering is not part of the file format. The order is stored twice in the file: the hierRoot algorithm has 3 layout nodes as a children, and also the data model has an order of the presentation nodes: both describe that employees go before assistant nodes. In contrast to that, PowerPoint orders XML_asst nodes before XML_node ones, so teach the hierRoot algorithm about this. This requires tracking the data model node type for each in-diagram drawingML shape, so that layout can determine if a hierRoot algorithm children has an assistant node or not. (cherry picked from commit 22086e70c4f3bb41620ff81ecaf57fd2af6ccbce) This is the commit #5: oox smartart, org chart: handle multiple paragraphs on data node This problem was similar to the one fixed in cfa76f538a44d4396574ece59e8a3953c22c6eb7 (oox smartart, accent process: handle multiple runs from a data point, 2018-11-21), but this there we handled multiple runs and this handles multiple paragraphs. It seems some smartart types allow multiple paragraphs in a diagram node, others only allow multiple runs. Org chart is in the former category. (cherry picked from commit dfc97dd381ef516ca4a7e99b29f9da1033a380f4) This is the commit #6: oox smartart, org chart: fix height of manager nodes without employees Employees and/or assistants reduce the height of managers -- this effect is wanted even if there are no employees/assistants. (cherry picked from commit 8638cc1b737195df16a160b148d2cd2c68131174) This is the commit #7: oox smartart, org chart: improve width of non-manager nodes The default case is that all managers have assistants/employees, so nodes under a manager can only use the horizontal space under the manager to avoid overlapping. But in case the previous / next sibling of the manager have no child nodes (assistant/employee) then we can use that space to make the child nodes larger. This improves readability of the chart's text a lot and brings the layout closer to what PowerPoint does for the same input. Handle all this in the hierChild algorithm, i.e. the container for a list of assistants or a list of employees, which means "parent" in this
[Libreoffice-commits] core.git: cui/source
cui/source/tabpages/border.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit ba5eaf86a84212ab70424fc83464acec5b0d51a0 Author: Caolán McNamara AuthorDate: Thu Jan 24 12:51:03 2019 + Commit: Caolán McNamara CommitDate: Thu Jan 24 20:02:53 2019 +0100 Resolves: tdf#122914 missing save_value Change-Id: Ie28195f342b73b1420a1a120b1414941aab337b7 Reviewed-on: https://gerrit.libreoffice.org/66863 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/cui/source/tabpages/border.cxx b/cui/source/tabpages/border.cxx index 74be368ca8e3..0812c656bbf0 100644 --- a/cui/source/tabpages/border.cxx +++ b/cui/source/tabpages/border.cxx @@ -159,6 +159,7 @@ void ShadowControlsWrapper::SetControlValue(const SvxShadowItem& rItem) } mrMfSize.set_value(mrMfSize.normalize(rItem.GetWidth()), FieldUnit::TWIP); mrLbColor.SelectEntry(rItem.GetColor()); +mrMfSize.save_value(); } void ShadowControlsWrapper::SetControlDontKnow() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtk3gtkinst.cxx | 20
1 file changed, 20 insertions(+)
New commits:
commit 8e8de0a1c8ca88fb8b91ca44e260a87b93057379
Author: Caolán McNamara
AuthorDate: Thu Jan 24 14:31:08 2019 +
Commit: Caolán McNamara
CommitDate: Thu Jan 24 20:02:15 2019 +0100
Resolves: tdf#122931 crash on closing b dialog after gallery menu
activated
Change-Id: I3284edc2ed64895642bd12ea479a1aba8023b2ba
Reviewed-on: https://gerrit.libreoffice.org/66873
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index c6b4553d2bbd..b6cd35b7a01d 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -1826,6 +1826,15 @@ public:
g_signal_connect(pMenuItem, "activate", G_CALLBACK(signalActivate),
this);
}
+void remove_from_map(GtkMenuItem* pMenuItem)
+{
+const gchar* pStr = gtk_buildable_get_name(GTK_BUILDABLE(pMenuItem));
+OString id(pStr, pStr ? strlen(pStr) : 0);
+auto iter = m_aMap.find(id);
+g_signal_handlers_disconnect_by_data(iter->second, this);
+m_aMap.erase(iter);
+}
+
void disable_item_notify_events()
{
for (auto& a : m_aMap)
@@ -4200,6 +4209,7 @@ public:
class GtkInstanceMenu : public MenuHelper, public virtual weld::Menu
{
protected:
+std::vector m_aExtraItems;
OString m_sActivated;
GtkInstanceMenuButton* m_pTopLevelMenuButton;
@@ -4358,12 +4368,22 @@ public:
gtk_menu_shell_append(GTK_MENU_SHELL(m_pMenu), pItem);
gtk_widget_show(pItem);
GtkMenuItem* pMenuItem = GTK_MENU_ITEM(pItem);
+m_aExtraItems.push_back(pMenuItem);
add_to_map(pMenuItem);
if (m_pTopLevelMenuButton)
m_pTopLevelMenuButton->add_to_map(pMenuItem);
if (pos != -1)
gtk_menu_reorder_child(m_pMenu, pItem, pos);
}
+
+virtual ~GtkInstanceMenu() override
+{
+if (m_pTopLevelMenuButton)
+{
+for (auto a : m_aExtraItems)
+m_pTopLevelMenuButton->remove_from_map(a);
+}
+}
};
class GtkInstanceRadioButton : public GtkInstanceToggleButton, public virtual
weld::RadioButton
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cui/source
cui/source/tabpages/paragrph.cxx | 56 +--
1 file changed, 37 insertions(+), 19 deletions(-)
New commits:
commit c66027d18eecaf29962e251def4203091d1669f3
Author: Caolán McNamara
AuthorDate: Thu Jan 24 13:52:31 2019 +
Commit: Caolán McNamara
CommitDate: Thu Jan 24 20:01:20 2019 +0100
Related: tdf#122914 visiting alignment page sets an SvxAdjustItem
even if the user doesn't interact with anything, since...
commit 122da2eea23faf6916c3f3b9e1895f5c404b26c7
Author: Jim Raykowski
Date: Sat Nov 18 22:21:24 2017 -0900
tdf#107567 et al. Paragraph dialog preview windows fixes
tdf#107567 tdf#98211 tdf#98212 tdf#113275
Checking those issues, I don't see a change if I put this
part back to only set SvxAdjustItem in FillItemSet if the radio-button
has changed (or justify subcontrols if justify was already set)
Change-Id: Ia68c50fd659be5b507d6e0989caecb353b494df7
Reviewed-on: https://gerrit.libreoffice.org/66872
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/cui/source/tabpages/paragrph.cxx b/cui/source/tabpages/paragrph.cxx
index 40dbffd567ea..4ceb0c88b0a7 100644
--- a/cui/source/tabpages/paragrph.cxx
+++ b/cui/source/tabpages/paragrph.cxx
@@ -1059,34 +1059,52 @@ bool SvxParaAlignTabPage::FillItemSet( SfxItemSet*
rOutSet )
{
bool bModified = false;
+bool bAdj = false;
SvxAdjust eAdjust = SvxAdjust::Left;
-if ( m_xLeft->get_active() )
+if (m_xLeft->get_active())
+{
eAdjust = SvxAdjust::Left;
-else if ( m_xRight->get_active() )
+bAdj = m_xLeft->get_saved_state() == TRISTATE_FALSE;
+}
+else if (m_xRight->get_active())
+{
eAdjust = SvxAdjust::Right;
-else if ( m_xCenter->get_active() )
+bAdj = m_xRight->get_saved_state() == TRISTATE_FALSE;
+}
+else if (m_xCenter->get_active())
+{
eAdjust = SvxAdjust::Center;
-else if ( m_xJustify->get_active() )
+bAdj = m_xCenter->get_saved_state() == TRISTATE_FALSE;
+}
+else if (m_xJustify->get_active())
+{
eAdjust = SvxAdjust::Block;
+bAdj = m_xJustify->get_saved_state() == TRISTATE_FALSE ||
+m_xExpandCB->get_state_changed_from_saved() ||
+m_xLastLineLB->get_value_changed_from_saved();
+}
sal_uInt16 _nWhich = GetWhich( SID_ATTR_PARA_ADJUST );
-SvxAdjust eOneWord = m_xExpandCB->get_active() ? SvxAdjust::Block :
SvxAdjust::Left;
-
-int nLBPos = m_xLastLineLB->get_active();
-SvxAdjust eLastBlock = SvxAdjust::Left;
-if ( 1 == nLBPos )
-eLastBlock = SvxAdjust::Center;
-else if ( 2 == nLBPos )
-eLastBlock = SvxAdjust::Block;
-
-SvxAdjustItem aAdj( static_cast(GetItemSet().Get(
_nWhich )) );
-aAdj.SetAdjust( eAdjust );
-aAdj.SetOneWord( eOneWord );
-aAdj.SetLastBlock( eLastBlock );
-rOutSet->Put( aAdj );
-bModified = true;
+if (bAdj)
+{
+SvxAdjust eOneWord = m_xExpandCB->get_active() ? SvxAdjust::Block :
SvxAdjust::Left;
+
+int nLBPos = m_xLastLineLB->get_active();
+SvxAdjust eLastBlock = SvxAdjust::Left;
+if ( 1 == nLBPos )
+eLastBlock = SvxAdjust::Center;
+else if ( 2 == nLBPos )
+eLastBlock = SvxAdjust::Block;
+
+SvxAdjustItem aAdj( static_cast(GetItemSet().Get( _nWhich )) );
+aAdj.SetAdjust( eAdjust );
+aAdj.SetOneWord( eOneWord );
+aAdj.SetLastBlock( eLastBlock );
+rOutSet->Put( aAdj );
+bModified = true;
+}
if (m_xSnapToGridCB->get_state_changed_from_saved())
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 122421] text in table wasn't aligned when opening a RTF file
https://bugs.documentfoundation.org/show_bug.cgi?id=122421 --- Comment #6 from Telesto --- (In reply to paolo busto from comment #5) > new rtf file: > please look at gif (that is how I see it with ms word). > where yellow show lines not alligned in libreoffice 6.2.0.1 @paolo busto Please create a new report for "new rtf file + gif". I can confirm it, but it's a different bug (not reproducible with LibO 4.4.7.2 in contrary to the first report) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122939] New: Crash when I'm working whith graph in the report mode
https://bugs.documentfoundation.org/show_bug.cgi?id=122939 Bug ID: 122939 Summary: Crash when I'm working whith graph in the report mode Product: LibreOffice Version: 6.0.7.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bromby.f...@free.fr Description: crashreport.libreoffice.org/stats/crash_details/4178e045-a356-48a6-90a6-e1336d39945d Je travail sur un projet qui inclus un graphique en mode rapport et celui ci plante régulièrement. Actual Results: lorsque je modifie mon graphique. Expected Results: le logiciel crash complètement. Reproducible: Sometimes User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121511] FILESAVE DOCX Shape in frame is lost after export
https://bugs.documentfoundation.org/show_bug.cgi?id=121511 Buovjaga changed: What|Removed |Added Version|4.4 all versions|4.3.0.4 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121513] FILESAVE DOCX TextBox in Shape is modified after export
https://bugs.documentfoundation.org/show_bug.cgi?id=121513 Buovjaga changed: What|Removed |Added Version|6.0.0.0.alpha0+ |5.4.0.3 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
