[Libreoffice-bugs] [Bug 123150] FIREBIRD: Query with 'LIKE' fails with error "malformed string", when index is set for the field of the condition of the query

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123150

Alex Thurgood  changed:

   What|Removed |Added

 CC||btom...@gmail.com,
   ||ipla...@tuta.io,
   ||lio...@mamane.lu

--- Comment #10 from Alex Thurgood  ---
@Tamas : thought you might be interested in this one - it appears that our
parser mechanism doesn't handle UTF strings in LIKE comparisons either when the
column is indexed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: distro-configs/Jenkins

[Libreoffice Gerrit user]

 distro-configs/Jenkins/Linux_ubsan_master.conf |1 +
 1 file changed, 1 insertion(+)

New commits:
commit c394e6a5c850f750a98244291bfd0b00e72481d7
Author: Stephan Bergmann 
AuthorDate: Tue Feb 5 08:45:57 2019 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Feb 5 08:45:57 2019 +0100

Clang ASan fails with gold

...for whatever reason.  Failure is

> AddressSanitizer:DEADLYSIGNAL
> =
> ==16438==ERROR: AddressSanitizer: SEGV on unknown address 0x 
(pc 0x2b6ba8bfe65c bp 0x7ffca100f290 sp 0x7ffca100ba28 T0)
> ==16438==The signal is caused by a READ memory access.
> ==16438==Hint: address points to the zero page.
> #0 0x2b6ba8bfe65b  ()
>
> AddressSanitizer can not provide additional info.
> SUMMARY: AddressSanitizer: SEGV ()
> ==16438==ABORTING
> 
/home/tdf/lode/jenkins/workspace/lo_ubsan/testtools/CustomTarget_uno_test.mk:25:
 recipe for target 
'/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/CustomTarget/testtools/uno_test.done'
 failed

(, but also seen with local 
ASan+
UBSan builds.)

Started to fail with 98f5f97d4a4206ecfb0754e1901d9c44a3287d82 "make 
--enable-ld
the default for debug builds, if available".  (lld would automatically be
disabled by configure.ac because it doesn't support 
--dynamic-list-cpp-typeinfo
as needed by UBSan.)

Change-Id: I7bfbfc4c879cbad7748e5855c22698eec5efc94c

diff --git a/distro-configs/Jenkins/Linux_ubsan_master.conf 
b/distro-configs/Jenkins/Linux_ubsan_master.conf
index 74a4dbf594df..02c630a137a3 100644
--- a/distro-configs/Jenkins/Linux_ubsan_master.conf
+++ b/distro-configs/Jenkins/Linux_ubsan_master.conf
@@ -1,3 +1,4 @@
+--disable-ld
 --disable-ooenv
 --enable-avahi
 --enable-dbgutil
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 103152] [META] Writer image bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103152
Bug 103152 depends on bug 104716, which changed state.

Bug 104716 Summary: General performance problems - UI freezes, slow scrolling, 
etc. in files with big/complex images
https://bugs.documentfoundation.org/show_bug.cgi?id=104716

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104716] General performance problems - UI freezes, slow scrolling, etc. in files with big/complex images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104716

Buovjaga  changed:

   What|Removed |Added

   Keywords|bibisectRequest |
 Status|NEW |RESOLVED
 CC||todven...@suomi24.fi,
   ||wingtong...@gmail.com
 Resolution|--- |INVALID

--- Comment #54 from Buovjaga  ---
Ok folks, this report has run its course and needs to be chopped up to any
useful bits left.

Let's recap:
- Frank's issue from comment 52 is now bug 123165
- Roland's issues a-c from comment 46 seems non-existent in my tests
- Issue d from comment 46, Smooth scrolling + PgDn looks like a real problem
with GTK3. I will open a new report for it and CC Roland. I will do a callgrind
trace of it.
- Samson needs to create a new report with his example file for his problem
from comment 49
- In comment 27, bug 80659 was suspected to be a duplicate of the immediately
preceding issues mentioned by Roland and has now been confirmed to be gone by 3
people
- For comment 28 and 29, I remember there already being a separate report
- For Gorka's issues up to comment 18, we need to determine what is actionable
and create new reports accordingly. Telesto: can you help with this? Slow page
scrolling with SVGs in view is bug 83426, what about the others?
I confirmed with attachment 129696 that scrolling with 8 pages in view is still
sluggish.

Let this be a lesson to all: don't bring your pet bugs to existing reports. It
will create a huge and painful mess.

Tests done on
Arch Linux 64-bit
Version: 6.3.0.0.alpha0+
Build ID: 8fbad2f600cd3ab81e7c1da0e4a2a71ebcac0553
CPU threads: 8; OS: Linux 4.20; UI render: default; VCL: gtk3; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Calc: threaded
Built on 31 January 2019

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47148] [meta] image handling problems

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=47148
Bug 47148 depends on bug 104716, which changed state.

Bug 104716 Summary: General performance problems - UI freezes, slow scrolling, 
etc. in files with big/complex images
https://bugs.documentfoundation.org/show_bug.cgi?id=104716

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83426] SVG's Load Slowly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83426

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #16 from Buovjaga  ---
In attachment 106250, the delay is only in slide 4. I was unable to find the
delay with attachment 128564.

Arch Linux 64-bit
Version: 6.3.0.0.alpha0+
Build ID: 8fbad2f600cd3ab81e7c1da0e4a2a71ebcac0553
CPU threads: 8; OS: Linux 4.20; UI render: default; VCL: gtk3; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Calc: threaded
Built on 31 January 2019

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103152] [META] Writer image bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103152
Bug 103152 depends on bug 80659, which changed state.

Bug 80659 Summary: Non-accelerated / non-cached image scaling ...
https://bugs.documentfoundation.org/show_bug.cgi?id=80659

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80659] Non-accelerated / non-cached image scaling ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80659

Buovjaga  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||todven...@suomi24.fi
 Resolution|--- |WORKSFORME

--- Comment #53 from Buovjaga  ---
Make it three people who have said there is no slowness while scrolling past
images in attachment 101791. Let's close.

Arch Linux 64-bit
Version: 6.3.0.0.alpha0+
Build ID: 8fbad2f600cd3ab81e7c1da0e4a2a71ebcac0553
CPU threads: 8; OS: Linux 4.20; UI render: default; VCL: gtk3; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Calc: threaded
Built on 31 January 2019

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116109] [META] Regressions introduced by unified Graphic processing to use GraphicPrimitive2D

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116109
Bug 116109 depends on bug 80659, which changed state.

Bug 80659 Summary: Non-accelerated / non-cached image scaling ...
https://bugs.documentfoundation.org/show_bug.cgi?id=80659

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47148] [meta] image handling problems

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=47148
Bug 47148 depends on bug 80659, which changed state.

Bug 80659 Summary: Non-accelerated / non-cached image scaling ...
https://bugs.documentfoundation.org/show_bug.cgi?id=80659

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108075] [META] Scrolling and Page up/down issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108075
Bug 108075 depends on bug 80659, which changed state.

Bug 80659 Summary: Non-accelerated / non-cached image scaling ...
https://bugs.documentfoundation.org/show_bug.cgi?id=80659

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123165] Slow scrolling document with pictures (gtk3)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123165

--- Comment #4 from Frank Steiner  ---
Here you are! I hope this helps!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123165] Slow scrolling document with pictures (gtk3)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123165

--- Comment #3 from Frank Steiner  ---
Created attachment 14
  --> https://bugs.documentfoundation.org/attachment.cgi?id=14=edit
picture used in the test file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123165] Slow scrolling document with pictures (gtk3)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123165

--- Comment #2 from Frank Steiner  ---
Created attachment 148887
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148887=edit
Testfile for the picture bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - 2 commits - i18npool/Executable_gencoll_rule.mk i18npool/Executable_genconv_dict.mk i18npool/Executable_gendict.mk i18npool/Executable_genindex_dat

[Libreoffice Gerrit user]

 Module_ooo.mk |1 
 Repository.mk |   16 +
 RepositoryExternal.mk |   54 +++-
 RepositoryFixes.mk|   28 --
 i18npool/Executable_gencoll_rule.mk   |   54 
 i18npool/Executable_genconv_dict.mk   |   45 +++
 i18npool/Executable_gendict.mk|   45 +++
 i18npool/Executable_genindex_data.mk  |   54 
 i18npool/Executable_saxparser.mk  |   73 ++
 i18npool/Library_collator_data.mk |   62 +
 i18npool/Library_dict_ja.mk   |   53 
 i18npool/Library_dict_zh.mk   |   53 
 i18npool/Library_i18nisolang1.mk  |   59 +
 i18npool/Library_i18npaper.mk |   60 +
 i18npool/Library_i18npool.mk  |  203 ++
 i18npool/Library_i18nsearch.mk|   67 +
 i18npool/Library_index_data.mk|   54 
 i18npool/Library_localedata_en.mk |  100 
 i18npool/Library_localedata_es.mk |   76 ++
 i18npool/Library_localedata_euro.mk   |  130 +++
 i18npool/Library_localedata_others.mk |  141 
 i18npool/Library_textconv_dict.mk |   66 +
 i18npool/Makefile |   32 ++
 i18npool/Module_i18npool.mk   |   81 +++
 i18npool/Package_inc.mk   |   28 ++
 i18npool/Package_version.mk   |   27 ++
 i18npool/Package_xml.mk   |   38 +++
 i18npool/inc/pch/precompiled_i18nisolang.cxx  |   25 ++
 i18npool/inc/pch/precompiled_i18nisolang.hxx  |   28 ++
 i18npool/inc/pch/precompiled_i18npaper.cxx|   25 ++
 i18npool/inc/pch/precompiled_i18npaper.hxx|   28 ++
 i18npool/inc/pch/precompiled_search.cxx   |   25 ++
 i18npool/inc/pch/precompiled_search.hxx   |   28 ++
 i18npool/prj/build.lst|   26 --
 i18npool/prj/d.lst|   52 
 i18npool/prj/makefile.mk  |   44 +++
 i18npool/source/breakiterator/gendict.cxx |   10 
 i18npool/source/breakiterator/makefile.mk |2 
 i18npool/source/collator/gencoll_rule.cxx |2 
 i18npool/source/indexentry/genindex_data.cxx  |2 
 i18npool/source/isolang/insys.cxx |2 
 i18npool/source/isolang/inunx.cxx |2 
 i18npool/source/isolang/inwnt.cxx |2 
 i18npool/source/isolang/isolang.cxx   |2 
 i18npool/source/isolang/mslangid.cxx  |2 
 i18npool/source/localedata/filewriter.cxx |   16 -
 i18npool/source/registerservices/registerservices.cxx |4 
 i18npool/source/search/levdis.cxx |2 
 i18npool/source/search/textsearch.cxx |6 
 i18npool/source/textconversion/genconv_dict.cxx   |   42 +--
 icu/icuversion.mk |6 
 lingucomponent/Library_spell.mk   |6 
 postprocess/packcomponents/makefile.mk|4 
 solenv/gbuild/Executable.mk   |1 
 solenv/gbuild/Library.mk  |2 
 solenv/gbuild/LinkTarget.mk   |   53 
 solenv/gbuild/StaticLibrary.mk|1 
 solenv/gbuild/TargetLocations.mk  |2 
 solenv/gbuild/platform/freebsd.mk |5 
 solenv/gbuild/platform/linux.mk   |5 
 solenv/gbuild/platform/macosx.mk  |5 
 solenv/gbuild/platform/os2.mk |5 
 solenv/gbuild/platform/solaris.mk |5 
 solenv/gbuild/platform/windows.mk |4 
 solenv/gbuild/platform/winmingw.mk|6 
 tools/inc/tools/stream.hxx|2 
 tools/source/stream/strmunx.cxx   |2 
 67 files changed, 2018 insertions(+), 173 deletions(-)

New commits:
commit ff3d5a2c5bafdafae641c7e7287df67c182767ef
Author: Damjan Jovanovic 
AuthorDate: Tue Feb 5 05:54:10 2019 +
Commit: Damjan Jovanovic 
CommitDate: Tue Feb 5 05:54:10 2019 +

Stream file handles have to be 64 bits to support Win64.

Patch by: me

diff --git a/tools/inc/tools/stream.hxx b/tools/inc/tools/stream.hxx
index 9466b261f592..2e859196d433 100644
--- a/tools/inc/tools/stream.hxx
+++ b/tools/inc/tools/stream.hxx
@@ -733,7 +733,7 @@ private:
 String  aFilename;
 sal_uInt16  

Re: Libre 6.1.4 bugs with vlookup

[Michael Weghorn]

Hi Sergiu,

On 02/02/2019 19.02, Sergiu Iabanji wrote:
> Hello,
> I've used libreoffice version 5 (don't know exactly the version) until
> now and there was no bugs for me.
> Today, I've installed version 6.1.4 (for Windows 7) and found 2 bugs:
> [...]

Please report these bugs in the Bugzilla issue tracker at [1].
If these bugs were not present in LibreOffice 5, identifying when those
were introduced can help a lot in the process to get them fixed.
If you're interested in helping with this, the wiki page about
Bibisecting [2] describes the steps to do this.

> Is it possible co correct these bugs?

Once the commit that introduced the regressions has been identified, it
is more likely that they can be resolved quickly (there's no guarantee
though).


Michael


[1] https://bugs.documentfoundation.org/
[2] https://wiki.documentfoundation.org/QA/Bibisect
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 103405] L10n: Add additional user interface language Hungarian Rovas [hu-Hung-HU]

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103405

--- Comment #34 from Kovács Viktor  ---
(In reply to Óvári from comment #33)
> (In reply to Kovács Viktor from comment #32)
> > cc:Óvári
> > What is Your opinion about file a bug for a font acceptation method?
> 
> Can a developer who can accept changes please advise whether this will be
> accepted? Thank you

Previously Stuart started with an e-mail, at already closed bug #113017 .
I asked you about Your opinion only.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: icon-themes/sifr icon-themes/sifr_dark icon-themes/sifr_svg

[Libreoffice Gerrit user]

 icon-themes/sifr/cmd/sc_currencyfield.png|binary
 icon-themes/sifr/cmd/sc_deletecolumns.png|binary
 icon-themes/sifr/cmd/sc_deleterows.png   |binary
 icon-themes/sifr/cmd/sc_drawchart.png|binary
 icon-themes/sifr/cmd/sc_edit.png |binary
 icon-themes/sifr/cmd/sc_extendedhelp.png |binary
 icon-themes/sifr/cmd/sc_filecontrol.png  |binary
 icon-themes/sifr/cmd/sc_fillcolor.png|binary
 icon-themes/sifr/cmd/sc_formatarea.png   |binary
 icon-themes/sifr/cmd/sc_formatpaintbrush.png |binary
 icon-themes/sifr/cmd/sc_formattedfield.png   |binary
 icon-themes/sifr/cmd/sc_gallery.png  |binary
 icon-themes/sifr/cmd/sc_helpindex.png|binary
 icon-themes/sifr/cmd/sc_hscrollbar.png   |binary
 icon-themes/sifr/cmd/sc_hyperlinkdialog.png  |binary
 icon-themes/sifr/cmd/sc_imagebutton.png  |binary
 icon-themes/sifr/cmd/sc_imagecontrol.png |binary
 icon-themes/sifr/cmd/sc_insertcolumns.png|binary
 icon-themes/sifr/cmd/sc_insertcurrencyfield.png  |binary
 icon-themes/sifr/cmd/sc_insertedit.png   |binary
 icon-themes/sifr/cmd/sc_insertfieldctrl.png  |binary
 icon-themes/sifr/cmd/sc_insertfilecontrol.png|binary
 icon-themes/sifr/cmd/sc_insertfixedtext.png  |binary
 icon-themes/sifr/cmd/sc_insertformattedfield.png |binary
 icon-themes/sifr/cmd/sc_insertformcheck.png  |binary
 icon-themes/sifr/cmd/sc_insertformvscroll.png|binary
 icon-themes/sifr/cmd/sc_insertgraphic.png|binary
 icon-themes/sifr/cmd/sc_inserthyperlink.png  |binary
 icon-themes/sifr/cmd/sc_insertimagecontrol.png   |binary
 icon-themes/sifr/cmd/sc_insertindexesentry.png   |binary
 icon-themes/sifr/cmd/sc_insertobjectchart.png|binary
 icon-themes/sifr/cmd/sc_insertpushbutton.png |binary
 icon-themes/sifr/cmd/sc_insertrows.png   |binary
 icon-themes/sifr/cmd/sc_label.png|binary
 icon-themes/sifr/cmd/sc_mergecells.png   |binary
 icon-themes/sifr/cmd/sc_navigationbar.png|binary
 icon-themes/sifr/cmd/sc_numberformatdecdecimals.png  |binary
 icon-themes/sifr/cmd/sc_numberformatdecimal.png  |binary
 icon-themes/sifr/cmd/sc_numberformatincdecimals.png  |binary
 icon-themes/sifr/cmd/sc_ok.png   |binary
 icon-themes/sifr/cmd/sc_paste.png|binary
 icon-themes/sifr/cmd/sc_scrollbar.png|binary
 icon-themes/sifr/cmd/sc_showtrackedchanges.png   |binary
 icon-themes/sifr/cmd/sc_splitcells.png   |binary
 icon-themes/sifr/cmd/sc_switchxformsdesignmode.png   |binary
 icon-themes/sifr/cmd/sc_tabdialog.png|binary
 icon-themes/sifr/cmd/sc_togglemergecells.png |binary
 icon-themes/sifr/cmd/sc_trackchanges.png |binary
 icon-themes/sifr/cmd/sc_trackchangesbar.png  |binary
 icon-themes/sifr/cmd/sc_usewizards.png   |binary
 icon-themes/sifr/cmd/sc_xlinecolor.png   |binary
 icon-themes/sifr_dark/cmd/sc_currencyfield.png   |binary
 icon-themes/sifr_dark/cmd/sc_deletecolumns.png   |binary
 icon-themes/sifr_dark/cmd/sc_deleterows.png  |binary
 icon-themes/sifr_dark/cmd/sc_drawchart.png   |binary
 icon-themes/sifr_dark/cmd/sc_edit.png|binary
 icon-themes/sifr_dark/cmd/sc_extendedhelp.png|binary
 icon-themes/sifr_dark/cmd/sc_filecontrol.png |binary
 icon-themes/sifr_dark/cmd/sc_fillcolor.png   |binary
 icon-themes/sifr_dark/cmd/sc_formatarea.png  |binary
 icon-themes/sifr_dark/cmd/sc_formatpaintbrush.png|binary
 icon-themes/sifr_dark/cmd/sc_formattedfield.png  |binary
 icon-themes/sifr_dark/cmd/sc_gallery.png |binary
 icon-themes/sifr_dark/cmd/sc_helpindex.png   |binary
 icon-themes/sifr_dark/cmd/sc_hscrollbar.png  |binary
 icon-themes/sifr_dark/cmd/sc_hyperlinkdialog.png |binary
 icon-themes/sifr_dark/cmd/sc_imagebutton.png |binary
 icon-themes/sifr_dark/cmd/sc_imagecontrol.png|binary
 icon-themes/sifr_dark/cmd/sc_insertcolumns.png   |binary
 icon-themes/sifr_dark/cmd/sc_insertcurrencyfield.png |binary
 icon-themes/sifr_dark/cmd/sc_insertedit.png  |binary
 icon-themes/sifr_dark/cmd/sc_insertfieldctrl.png |binary
 icon-themes/sifr_dark/cmd/sc_insertfilecontrol.png   |binary
 icon-themes/sifr_dark/cmd/sc_insertfixedtext.png |binary
 icon-themes/sifr_dark/cmd/sc_insertformattedfield.png|binary
 

[Libreoffice-bugs] [Bug 123167] BASIC: Pictures in buttons are not persistent in a dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123167

raal  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 OS|Windows (All)   |All
   Keywords||regression
 CC||r...@post.cz
 Status|UNCONFIRMED |NEW

--- Comment #2 from raal  ---
Confirm with Version: 6.3.0.0.alpha0+
Build ID: 1ac54de7869d5809a312acad0a37d48028ad9d3b
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 


regression, works in Version: 4.1.0.0.alpha1+
Build ID: a2c9d4f8bbde97f175bae4df771273a61251f40

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: configure.ac

[Libreoffice Gerrit user]

 configure.ac |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit f3520cce0e03d10c93a74d0edb333161453b4b10
Author: Andrea Gelmini 
AuthorDate: Mon Feb 4 20:40:43 2019 +
Commit: Julien Nabet 
CommitDate: Tue Feb 5 07:08:34 2019 +0100

Fix typos

Change-Id: Ie186b828d500b661029704f95f4c03e56d69c282
Reviewed-on: https://gerrit.libreoffice.org/67382
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/configure.ac b/configure.ac
index 277b60de88c6..f880308285b8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3832,7 +3832,7 @@ dnl 
===
 dnl Select the linker to use (gold/lld/ld.bfd).
 dnl This is done only after compiler checks (need to know if Clang is
 dnl used, for different defaults) and after checking if a debug build
-dnl is wanted (non-debug builds get the default linker if not explictly
+dnl is wanted (non-debug builds get the default linker if not explicitly
 dnl specified otherwise).
 dnl All checks for linker features/options should come after this.
 dnl ===
@@ -7936,7 +7936,7 @@ if test "$with_system_jpeg" = "yes"; then
 AC_CHECK_HEADER(jpeglib.h, [ LIBJPEG_CFLAGS= ],
 [AC_MSG_ERROR(jpeg.h not found. install libjpeg)], [])
 AC_CHECK_LIB(jpeg, jpeg_resync_to_restart, [ LIBJPEG_LIBS="-ljpeg" ],
-[AC_MSG_ERROR(jpeg library not found or fuctional)], [])
+[AC_MSG_ERROR(jpeg library not found or functional)], [])
 else
 SYSTEM_LIBJPEG=
 AC_MSG_RESULT([internal, libjpeg-turbo])
@@ -9663,8 +9663,8 @@ AC_MSG_CHECKING([whether to execute CVE tests])
 if test -z "$enable_cve_tests"; then
 case "$OS" in
 WNT)
-# Default cves off for windows with its wild and wonderful
-# varienty of AV software kicking in and panicking
+# Default cves off for Windows with its wild and wonderful
+# variety of AV software kicking in and panicking
 enable_cve_tests=no
 ;;
 *)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Getting rid of CentOS6 for x86? (was: Compiler baselines)

[Thorsten Behrens]

Hi *,

as briefly talked about in a FOSDEM lightning talk, we managed to get
-m32 cross builds on master going for CentOS with devtoolset-7.

There's an existing setup for CentOS6 (Dockerfile attached) with a
number of ugly hacks; I'm working on a CentOS7 setup that looks much
cleaner, but suffers from one killer bug: a missing
devtoolset-7-libstdc++-devel.i686 package.

This is reported for upstream CentOS already here:
https://bugs.centos.org/view.php?id=15452

Does anybody have good suggestions how to get that fixed (whom to
lobby, whether to roll a custom package via COPR like mlampe did for
CentOS6, or anything else)?

Cheers,

-- Thorsten
# Dockerfile - this is for LibreOffice >=6.2 32bit
FROM centos:centos6

# basic setup & packages
RUN rpm -ivh 
https://dl.fedoraproject.org/pub/epel/epel-release-latest-6.noarch.rpm
# update first, to prevent SSL issues below - touch is due to 
https://bugzilla.redhat.com/show_bug.cgi?id=1213602
RUN touch /var/lib/rpm/* && yum -y update
# pull in more build prerequisite repos
# devtoolset-7: need both repos for 64-bit compiler and 32-bit library/headers
RUN cd /etc/yum.repos.d && \
curl -sLO 
http://download.opensuse.org/repositories/home:/fstrba:/LibreOffice/CentOS_6/home:fstrba:LibreOffice.repo
 && \
curl -sLO 
https://copr.fedorainfracloud.org/coprs/mlampe/devtoolset-7/repo/epel-6/mlampe-devtoolset-7-epel-6.repo
 && \
sed -e 's/\[mlampe-devtoolset-7\]/\[mlampe-devtoolset-7-32bit\]/' -e 
's/$basearch/i386/' < mlampe-devtoolset-7-epel-6.repo > 
mlampe-devtoolset-7-epel-6-32bit.repo
# get build prereqs - touch is due to 
https://bugzilla.redhat.com/show_bug.cgi?id=1213602
RUN touch /var/lib/rpm/* && yum -y install fakeroot automake bison ccache dpkg 
dpkg-devel doxygen git devtoolset-7-gcc-c++ devtoolset-7-make gettext 
perl-Archive-Zip rpm-build zip screen tar nasm glibc-devel 
devtoolset-7-libstdc++-devel autoconf268 \
gnome-vfs2-devel.i686 cups-devel.i686 libffi-devel.i686 gstreamer-devel.i686 
gstreamer-plugins-base-devel.i686 gtk2-devel.i686 kdelibs-devel.i686 
avahi-devel.i686 devtoolset-7-libstdc++-devel.i686 glibc-devel.i686 
zlib-devel.i686 fontconfig-devel.i686 freetype-devel.i686 krb5-devel.i686 
libcom_err-devel.i686 openssl-devel.i686 libICE-devel.i686 libSM-devel.i686 
libXrender-devel.i686 libXau-devel.i686 dbus-glib-devel.i686 dbus-devel.i686 
glib2-devel.i686 pango-devel.i686 cairo-devel.i686 pixman-devel.i686 
libpng-devel.i686 gdk-pixbuf2-devel.i686 atk-devel.i686 libxml2-devel.i686 
mesa-libGL-devel.i686 qt-devel.i686 libX11-devel.i686 libxcb-devel.i686

# 32-bit JDK is only in 32-bit CentOS because it's not parallel-installable 
with 64-bit JDK
RUN sed -e 's/\[\(.*\)\]/\[\1-32\]/' -e 's/$basearch/i386/' < 
/etc/yum.repos.d/CentOS-Base.repo > /etc/yum.repos.d/CentOS-Base-32.repo && yum 
-y install java-1.7.0-openjdk-devel.i686 java-1.7.0-openjdk.i686

# std UID for builder user (for easier sharing on the host side)
RUN useradd -m -o -u 9001 -s /bin/bash builder

# self-built stuff, needed for versions >= LibO-5.3
RUN curl -sLO 
https://ftp.gnome.org/pub/gnome/sources/glib/2.50/glib-2.50.3.tar.xz && \
cd /home/builder && \
linux32 su - -c "tar -xf /glib-2.50.3.tar.xz ; cd glib-2.50.3 ; 
PKG_CONFIG_LIBDIR=/usr/lib/pkgconfig:/usr/share/pkgconfig 
CC=\"/opt/rh/devtoolset-7/root/usr/bin/gcc -m32\" ./configure 
--disable-libmount --with-pcre=internal --prefix=/home/builder/gst10-deps ; 
make -j3; make install" builder && \
rm -rf glib-2.50.3 /glib-2.50.3.tar.xz

# get a newer gperf (for LibreOffice 6.2 on)
RUN curl -sLO https://ftp.gnu.org/pub/gnu/gperf/gperf-3.1.tar.gz && \
cd /home/builder && \
su - -c "tar -xf /gperf-3.1.tar.gz ; cd gperf-3.1 ; ./configure --prefix 
/home/builder/deps CC=/opt/rh/devtoolset-7/root/usr/bin/gcc 
CXX=/opt/rh/devtoolset-7/root/usr/bin/g++ ; make -j3; make install" builder && \
rm -rf gperf-3.1 /gperf-3.1.tar.gz

# get a newer flex (for LibreOffice 6.2 on)
RUN curl -sLO 
https://github.com/westes/flex/releases/download/v2.6.4/flex-2.6.4.tar.gz && \
cd /home/builder && \
su - -c "tar -xf /flex-2.6.4.tar.gz ; cd flex-2.6.4 ; ./configure --prefix 
/home/builder/deps CC=/opt/rh/devtoolset-7/root/usr/bin/gcc 
CC_FOR_BUILD=/opt/rh/devtoolset-7/root/usr/bin/gcc ; make -j3; make install" 
builder && \
rm -rf flex-2.6.4 /flex-flex-2.6.4.tar.gz

# self-built stuff, needed for versions >= LibO-5.3
RUN curl -sLO 
https://gstreamer.freedesktop.org/src/gstreamer/gstreamer-1.8.3.tar.xz && \
cd /home/builder && \
linux32 su - -c "tar -xf /gstreamer-1.8.3.tar.xz ; cd gstreamer-1.8.3 ; 
PATH="/home/builder/deps/bin:${PATH}" 
CC=\"/opt/rh/devtoolset-7/root/usr/bin/gcc -m32\" 
PKG_CONFIG_PATH=/home/builder/gst10-deps/lib/pkgconfig ./configure  
--prefix=/home/builder/gst10-deps ; make -j3; make install" builder && \
rm -rf gstreamer-1.8.3 /gstreamer-1.8.3.tar.xz
RUN curl -sLO 
https://gstreamer.freedesktop.org/src/gst-plugins-base/gst-plugins-base-1.8.3.tar.xz
 && \
cd 

[Libreoffice-bugs] [Bug 123168] trim function problem when copying from other tools

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123168

--- Comment #2 from Elmar  ---
Created attachment 148886
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148886=edit
Text file (xed) of paste from Thunderbird

The example shows what is pasted into text file.
When pasting from the text file into Calc, the Trim function correctly
identifies spaces.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123168] trim function problem when copying from other tools

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123168

--- Comment #1 from Elmar  ---
Created attachment 148885
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148885=edit
trim function examples

The document includes pasted screen shots and multiple examples

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123168] New: trim function problem when copying from other tools

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123168

Bug ID: 123168
   Summary: trim function problem when copying from other tools
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rob...@iafrica.com

Description:
When I copy something from Thunderbird mail client or off an internet page into
Calc, this does not work properly unless I first copy it to a text editor and
from there to Calc

Steps to Reproduce:
1. Select text in source (e.g. Thunderbird)
2. Copy into Calc
3. 

Actual Results:
In many cases (e.g. from a web page) it will not paste using CTL+V but if I use
context menu, it does.
When I use a function like Trim to remove spaces, it does not.


Expected Results:
Should find spaces.


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: SpreadsheetDocument
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes
Version: 6.3.0.0.alpha0+
Build ID: ed707a4806a489467c6d9be7d1b787dab94b5f78
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2019-01-26_22:55:03
Locale: en-GB (en_ZA.UTF-8); UI-Language: en-US
Calc: threaded

Same problem in Version 5.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108669] UI: The default blue area fill color isn't pre-selected in the color picker palette

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108669

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83538] Formatting table in Impress doesn't works correctly (impress)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83538

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94828] [Impress] Inconsistent naming of Slide master / Master pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94828

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85493] VIEWING: In diagrams, tooltips shown over curve points show information about the wrong point when "Range for Name" cell values are not sorted in ascending order

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85493

--- Comment #11 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92165] page numbers doubled (i.e. 1 -> 11; 2 -> 22 etc) after saving specific .odt as .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92165

--- Comment #9 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45525] TABLES, Problem on adjust selected Row or Column to equal space

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45525

--- Comment #15 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105714] Link dialog icons and fields are too big

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105714

--- Comment #8 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105165] media playback toolbar - seek and volume controllers leave traces when dragged

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105165

--- Comment #13 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94261] When multiple styles are selected, the dropdown "Apply Style" in the toolbar is not empty

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94261

--- Comment #8 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96744] QTZ (string ID) files not available for recent builds on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96744

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97767] working in tablet mode LO should automatically open the onscreen-keyboard

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97767

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98403] UGX currency displayed as “Ganda”

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98403

--- Comment #17 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112220] FILESAVE XLSX: Cell Indent Increases on Each Save

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112220

--- Comment #12 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97892] Snapping to snap lines doesnt always work correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97892

--- Comment #3 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72266] EDITING: problems with selecting single charakters in a hyperlink with the mouse

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72266

--- Comment #11 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 58343] Master template name tooltip not updated after slide rename

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58343

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84874] FILESAVE to .xlsx. MS Excel doesn't load spreadsheets with promptTitle longer than 32 characters.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84874

himajin100...@gmail.com changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=79 |
   |998 |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79998] FILESAVE: XLSX export breaks or some sheet names (sheet name length >31 characters)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79998

himajin100...@gmail.com changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=84 |
   |874 |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84874] FILESAVE to .xlsx. MS Excel doesn't load spreadsheets with promptTitle longer than 32 characters.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84874

himajin100...@gmail.com changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=79
   ||998

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79998] FILESAVE: XLSX export breaks or some sheet names (sheet name length >31 characters)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79998

himajin100...@gmail.com changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=84
   ||874

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123167] BASIC: Pictures in buttons are not persistent in a dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123167

--- Comment #1 from Douglas R Almeida  ---
Created attachment 148884
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148884=edit
Doc with a dialog and a button

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123167] New: BASIC: Pictures in buttons are not persistent in a dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123167

Bug ID: 123167
   Summary: BASIC: Pictures in buttons are not persistent in a
dialog
   Product: LibreOffice
   Version: 6.2.0.3 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: douglasralme...@live.com

Description:
When I set a picture to a button in Basic Dialog Editor, it works.
But, I save the dialog and the file and, after reopening, all pictures have
gone.

Steps to Reproduce:
1.Go to Tools - Macros - Organize Dialogs, and then click New.
2.Afer give a name, click in Edit. The Basic dialog editor opens.
3.Add a button. Set a picture.
4.Save the dialog and the file.
5.Close the file.
6.Reopen the file and go to Dialog Editor again.


Actual Results:
The button is shown without the picture.

Expected Results:
The button should be shown with the picture.


Reproducible: Always


User Profile Reset: No



Additional Info:
Versão: 6.2.0.3 (x64)
ID de compilação: 98c6a8a1c6c7b144ce3cc729e34964b47ce25d62
Threads da CPU:4; SO:Windows 10.0; Realizador da interface: padrão; VCL: win; 
Local: pt-BR (pt_BR); Idioma de IU: pt-BR
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - solenv/bin

[Libreoffice Gerrit user]

 solenv/bin/modules/installer/logger.pm |   28 +---
 1 file changed, 13 insertions(+), 15 deletions(-)

New commits:
commit 23b7d74f43725596c16dfaf0e4284f667e020eea
Author: Matthias Seidel 
AuthorDate: Mon Feb 4 23:14:21 2019 +
Commit: Matthias Seidel 
CommitDate: Mon Feb 4 23:14:21 2019 +

Removed whitespace, fixed typo

diff --git a/solenv/bin/modules/installer/logger.pm 
b/solenv/bin/modules/installer/logger.pm
index 652bc17b7f46..1bdf3054cf68 100644
--- a/solenv/bin/modules/installer/logger.pm
+++ b/solenv/bin/modules/installer/logger.pm
@@ -8,7 +8,7 @@
 #  "License"); you may not use this file except in compliance
 #  with the License.  You may obtain a copy of the License at
 #
-#http://www.apache.org/licenses/LICENSE-2.0
+#   http://www.apache.org/licenses/LICENSE-2.0
 #
 #  Unless required by applicable law or agreed to in writing,
 #  software distributed under the License is distributed on an
@@ -45,9 +45,9 @@ sub Die ($);
 
 =head1 DESCRIPTION
 
-This module is in a transition state from a set of loosly connected 
functions to a single class.
+This module is in a transition state from a set of loosely connected 
functions to a single class.
 
-There are three globaly available logger objects:
+There are three globally available logger objects:
 
 =over
 
@@ -59,7 +59,7 @@ sub Die ($);
 
 =item $Glob
 
-is independent of the current language.  Its messages are prepended to 
each $Lang logger.
+is independent of the current language. Its messages are prepended to each 
$Lang logger.
 
 =cut
 
@@ -146,19 +146,19 @@ sub new ($$@)
 # When true then lines are printed to the console.
 'is_print_to_console' => 1,
 'is_save_lines' => 0,
-# A container of printed lines.  Lines are added only when 
'is_save_lines' is true.
+# A container of printed lines. Lines are added only when 
'is_save_lines' is true.
 'lines' => [],
 # Another logger to which all prints are forwarded.
 'forward' => [],
-# A filter function that for example can recoginze build errors.
+# A filter function that for example can recognize build errors.
 'filter' => undef,
 # Show relative time
 'is_show_relative_time' => 0,
-# Show log id (mostly for debugging the logger)
+# Show log id (mostly for debugging the logger).
 'is_show_log_id' => 0,
 # Show the process id, useful on the console when doing a 
multiprocessor build.
 'is_show_process_id' => 0,
-# Current indentation
+# Current indentation.
 'indentation' => "",
 };
 while (scalar @arguments >= 2)
@@ -200,7 +200,7 @@ sub printf ($$@)
 
 Print the given message.
 If the optional $force parameter is given and it evaluates to true then 
the message
-is printed even when the golbal $installer::globals::quiet is true.
+is printed even when the global $installer::globals::quiet is true.
 
 =cut
 sub print ($$;$)
@@ -325,7 +325,7 @@ sub set_filename ($$)
 
 =head2 set_filter ($self, $filter)
 
-Sets $filter (a function reference) as line filter.  It is applied to each 
line.
+Sets $filter (a function reference) as line filter. It is applied to each 
line.
 The filter can extract information from the given message and modify it 
before it is printed.
 
 =cut
@@ -377,7 +377,7 @@ sub copy_lines_from ($$)
 
 =head2 set_forward ($self, $other)
 
-Set a forwarding target.  All future messages are forwarded (copied) to 
$other.
+Set a forwarding target. All future messages are forwarded (copied) to 
$other.
 A typical use is to tie $Info to $Lang so that all messages sent to $Info 
are
 printed to the console AND written to the log file.
 
@@ -454,7 +454,7 @@ sub include_header_into_globallogfile
 
 sub include_timestamp_into_logfile
 {
-Die "deprected";
+Die "deprecated";
 my ($message) = @_;
 
 my $infoline;
@@ -523,7 +523,7 @@ sub copy_globalinfo_into_logfile
 
 sub debuginfo
 {
-my  ( $message ) = @_;
+my ( $message ) = @_;
 
 $message = $message . "\n";
 push(@installer::globals::functioncalls, $message);
@@ -742,6 +742,4 @@ sub Die ($)
 die $message;
 }
 
-
-
 1;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 123163] CRASH when FILEOPEN of DOCX file from scan and Nuance PDF Converter

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123163

--- Comment #2 from Mike Kupfer  ---
(In reply to Julien Nabet from comment #1)
> Would it be possible you attach the file?
> Of course, have in mind to remove any private/confidential part from it (if
> you have MsOffice since LO crashes).

I'll see what I can do. It's possible that after editing, the document will get
saved in a form that no longer causes a crash. Just copying the document using
LO 4.3.3 (using either File>Save As or File>Save a Copy) results in a copy that
does not cause a crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123166] LO 6.x installs but stalls when run re:win8.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123166

data...@bresnan.net  changed:

   What|Removed |Added

Version|unspecified |6.1.4.2 release
   Hardware|All |x86-64 (AMD64)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123166] New: LO 6.x installs but stalls when run re:win8.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123166

Bug ID: 123166
   Summary: LO 6.x installs but stalls when run re:win8.1
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: data...@bresnan.net

LO 6.x installs but stalls when run re:win8.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94238] FILEOPEN: OOXML - Radial fill not imported correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94238

--- Comment #9 from Luke  ---
I think radial should be used in all 5 positions, not just center. The shape of
the ellipsoid is all wrong, and it introduces a hard line that breaks the
radial symmetry.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87328] References are not searchable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87328

--- Comment #13 from Joseph  ---
I confirm that references and cross-references are NOT searchable in Writer.
Windows 8
Libreoffice 6.1.4.2
Search finds only the headings but not in inserted reference to that heading.
Moreover, Search does not find text in cross-references, neither within the
reference I set using {Set Reference} nor within a cross-reference to it
{Insert Reference}.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/uibase/fldui/fldmgr.cxx |   21 +++--
 1 file changed, 11 insertions(+), 10 deletions(-)

New commits:
commit 0b21f6556b6fff76290d1095089da89532365215
Author: Matteo Casalin 
AuthorDate: Sun Jan 27 19:45:51 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 23:36:03 2019 +0100

Use indexed getToken()

Change-Id: Ie8e1a7fdc8c728c7e9e43a444f0d039b2d60b121
Reviewed-on: https://gerrit.libreoffice.org/67309
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/uibase/fldui/fldmgr.cxx 
b/sw/source/uibase/fldui/fldmgr.cxx
index e54397e9c3f5..92faf193d56f 100644
--- a/sw/source/uibase/fldui/fldmgr.cxx
+++ b/sw/source/uibase/fldui/fldmgr.cxx
@@ -1182,10 +1182,11 @@ bool SwFieldMgr::InsertField(
 }
 else
 {
-aDBData.sDataSource = rData.m_sPar1.getToken(0, DB_DELIM);
-aDBData.sCommand = rData.m_sPar1.getToken(1, DB_DELIM);
-aDBData.nCommandType = rData.m_sPar1.getToken(2, 
DB_DELIM).toInt32();
-sPar1 = rData.m_sPar1.getToken(3, DB_DELIM);
+sal_Int32 nIdx{ 0 };
+aDBData.sDataSource = rData.m_sPar1.getToken(0, DB_DELIM, 
nIdx);
+aDBData.sCommand = rData.m_sPar1.getToken(0, DB_DELIM, nIdx);
+aDBData.nCommandType = rData.m_sPar1.getToken(0, DB_DELIM, 
nIdx).toInt32();
+sPar1 = rData.m_sPar1.getToken(0, DB_DELIM, nIdx);
 }
 
 if(!aDBData.sDataSource.isEmpty() && pCurShell->GetDBData() != 
aDBData)
@@ -1469,8 +1470,8 @@ bool SwFieldMgr::InsertField(
 const sal_Int32 nTokenCount = 
comphelper::string::getTokenCount(rData.m_sPar2, DB_DELIM);
 Sequence aEntries(nTokenCount);
 OUString* pArray = aEntries.getArray();
-for(sal_Int32 nToken = 0; nToken < nTokenCount; nToken++)
-pArray[nToken] = rData.m_sPar2.getToken(nToken, DB_DELIM);
+for(sal_Int32 nToken = 0, nIdx = 0; nToken < nTokenCount; nToken++)
+pArray[nToken] = rData.m_sPar2.getToken(0, DB_DELIM, nIdx);
 static_cast(pField.get())->SetItems(aEntries);
 
static_cast(pField.get())->SetName(rData.m_sPar1);
 }
@@ -1641,8 +1642,8 @@ void SwFieldMgr::UpdateCurField(sal_uInt32 nFormat,
 sal_Int32 nTokenCount = comphelper::string::getTokenCount(sPar2, 
DB_DELIM);
 Sequence aEntries(nTokenCount);
 OUString* pArray = aEntries.getArray();
-for(sal_Int32 nToken = 0; nToken < nTokenCount; nToken++)
-pArray[nToken] = sPar2.getToken(nToken, DB_DELIM);
+for(sal_Int32 nToken = 0, nIdx = 0; nToken < nTokenCount; nToken++)
+pArray[nToken] = sPar2.getToken(0, DB_DELIM, nIdx);
 static_cast(pTmpField.get())->SetItems(aEntries);
 static_cast(pTmpField.get())->SetName(rPar1);
 bSetPar1 = bSetPar2 = false;
@@ -1654,9 +1655,9 @@ void SwFieldMgr::UpdateCurField(sal_uInt32 nFormat,
 SwAuthorityField* pAuthorityField = 
static_cast(pTmpField.get());
 SwAuthorityFieldType* pAuthorityType = 
static_cast(pType);
 rtl::Reference xTempEntry(new SwAuthEntry);
-for( sal_uInt16 i = 0; i < AUTH_FIELD_END; ++i )
+for( sal_Int32 i = 0, nIdx = 0; i < AUTH_FIELD_END; ++i )
 xTempEntry->SetAuthorField( static_cast(i),
-rPar1.getToken( i, TOX_STYLE_DELIMITER ));
+rPar1.getToken( 0, TOX_STYLE_DELIMITER, nIdx 
));
 if( pAuthorityType->ChangeEntryContent( xTempEntry.get() ) )
 {
 pType->UpdateFields();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/core/fields/authfld.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 973c906d2af03284a662478d292124bbb0502548
Author: Matteo Casalin 
AuthorDate: Sun Feb 3 18:57:59 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 23:09:31 2019 +0100

Use indexed getToken()

Change-Id: I136a1cdb4a1522d78120f12e5f9ea5ced653c1b6
Reviewed-on: https://gerrit.libreoffice.org/67334
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/core/fields/authfld.cxx 
b/sw/source/core/fields/authfld.cxx
index bf7ceb6df3ee..bd1ff9ff703c 100644
--- a/sw/source/core/fields/authfld.cxx
+++ b/sw/source/core/fields/authfld.cxx
@@ -103,9 +103,10 @@ void SwAuthorityFieldType::RemoveField(const SwAuthEntry* 
nHandle)
 SwAuthEntry* SwAuthorityFieldType::AddField(const OUString& rFieldContents)
 {
 rtl::Reference pEntry(new SwAuthEntry);
+sal_Int32 nIdx{ 0 };
 for( sal_Int32 i = 0; i < AUTH_FIELD_END; ++i )
 pEntry->SetAuthorField( static_cast(i),
-rFieldContents.getToken( i, TOX_STYLE_DELIMITER ));
+rFieldContents.getToken( 0, TOX_STYLE_DELIMITER, nIdx 
));
 
 for (auto  : m_DataArr)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/core/unocore/unofield.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 4a8f0d4ee9b144d215378582f02f788327e8f502
Author: Matteo Casalin 
AuthorDate: Sun Feb 3 18:33:13 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 23:08:05 2019 +0100

Use indexed getToken()

Change-Id: I371ff95ff9d05e0c57844f99c222165e55aa51e8
Reviewed-on: https://gerrit.libreoffice.org/67332
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/core/unocore/unofield.cxx 
b/sw/source/core/unocore/unofield.cxx
index a75abdc77046..7aca6eb4ff03 100644
--- a/sw/source/core/unocore/unofield.cxx
+++ b/sw/source/core/unocore/unofield.cxx
@@ -2660,8 +2660,8 @@ static SwFieldIds lcl_GetIdByName( OUString& rName, 
OUString& rTypeName )
 rName = rName.copy(RTL_CONSTASCII_LENGTH(COM_TEXT_FLDMASTER_CC));
 
 SwFieldIds nResId = SwFieldIds::Unknown;
-sal_Int32 nFound = 0;
-rTypeName = rName.getToken( 0, '.', nFound );
+sal_Int32 nIdx = 0;
+rTypeName = rName.getToken( 0, '.', nIdx );
 if (rTypeName == "User")
 nResId = SwFieldIds::User;
 else if (rTypeName == "DDE")
@@ -2670,7 +2670,7 @@ static SwFieldIds lcl_GetIdByName( OUString& rName, 
OUString& rTypeName )
 {
 nResId = SwFieldIds::SetExp;
 
-const OUString sFieldTypName( rName.getToken( 1, '.' ));
+const OUString sFieldTypName( rName.getToken( 0, '.', nIdx ));
 const OUString sUIName( SwStyleNameMapper::GetSpecialExtraUIName( 
sFieldTypName ) );
 
 if( sUIName != sFieldTypName )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/filter/html/wrthtml.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 25a05cf2b1bc6c80c6079aa7d01b520070083656
Author: Matteo Casalin 
AuthorDate: Fri Feb 1 18:46:27 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 23:07:25 2019 +0100

Use indexed getToken()

Change-Id: Icf81629c80b6c39cef98cba3ba98a20089f7b9ef
Reviewed-on: https://gerrit.libreoffice.org/67331
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/filter/html/wrthtml.cxx 
b/sw/source/filter/html/wrthtml.cxx
index 90afecad0879..816c53726e3b 100644
--- a/sw/source/filter/html/wrthtml.cxx
+++ b/sw/source/filter/html/wrthtml.cxx
@@ -616,9 +616,10 @@ static void lcl_html_OutSectionStartTag( SwHTMLWriter& 
rHTMLWrt,
 rHTMLWrt.Strm().WriteCharPtr( sOut.makeStringAndClear().getStr() );
 
 const OUString& aFName = rSection.GetLinkFileName();
-OUString aURL( aFName.getToken(0,sfx2::cTokenSeparator) );
-OUString aFilter( aFName.getToken(1,sfx2::cTokenSeparator) );
-OUString aSection( aFName.getToken(2,sfx2::cTokenSeparator) );
+sal_Int32 nIdx{ 0 };
+OUString aURL( aFName.getToken(0, sfx2::cTokenSeparator, nIdx) );
+OUString aFilter( aFName.getToken(0, sfx2::cTokenSeparator, nIdx) );
+OUString aSection( aFName.getToken(0, sfx2::cTokenSeparator, nIdx) );
 
 OUString aEncURL( 
URIHelper::simpleNormalizedMakeRelative(rHTMLWrt.GetBaseURL(), aURL ) );
 sal_Unicode cDelim = 255U;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/filter/ww8/ww8atr.cxx |   48 
 1 file changed, 24 insertions(+), 24 deletions(-)

New commits:
commit 8df02f7b333a983c5c4c3b53756e3d792e2d82e1
Author: Matteo Casalin 
AuthorDate: Fri Feb 1 08:00:10 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 23:06:36 2019 +0100

Fix indentation

Change-Id: I2ee92b2fcf0fd589663a0141a67a9aabee180159
Reviewed-on: https://gerrit.libreoffice.org/67330
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
index 46abc4173c96..07f4967a7247 100644
--- a/sw/source/filter/ww8/ww8atr.cxx
+++ b/sw/source/filter/ww8/ww8atr.cxx
@@ -2202,7 +2202,7 @@ void AttributeOutputBase::StartTOX( const SwSection& 
rSect )
 {
sStr += sName + sEntryEnd;
 }
- }
+}
 
 if (!pTOX->GetTOXForm().IsCommaSeparated())
 {
@@ -2370,35 +2370,35 @@ void AttributeOutputBase::StartTOX( const SwSection& 
rSect )
 sStr +="\\u " ;
 }
 
-if( SwTOXElement::Template & pTOX->GetCreateType() )
+if( SwTOXElement::Template & pTOX->GetCreateType() )
+{
+// #i99641# - Consider additional styles regardless of 
TOX-outlinelevel
+for( n = 0; n < MAXLEVEL; ++n )
 {
-// #i99641# - Consider additional styles 
regardless of TOX-outlinelevel
-for( n = 0; n < MAXLEVEL; ++n )
+const OUString& rStyles = pTOX->GetStyleNames( n );
+if( !rStyles.isEmpty() )
 {
-const OUString& rStyles = pTOX->GetStyleNames( 
n );
-if( !rStyles.isEmpty() )
-{
-sal_Int32 nPos = 0;
-const OUString sLvl{ "," + 
OUString::number( n + 1 ) };
-do {
-const OUString sStyle( 
rStyles.getToken( 0, TOX_STYLE_DELIMITER, nPos ));
-if( !sStyle.isEmpty() )
+sal_Int32 nPos = 0;
+const OUString sLvl{ "," + OUString::number( n 
+ 1 ) };
+do {
+const OUString sStyle( rStyles.getToken( 
0, TOX_STYLE_DELIMITER, nPos ));
+if( !sStyle.isEmpty() )
+{
+SwTextFormatColl* pColl = 
GetExport().m_pDoc->FindTextFormatCollByName(sStyle);
+if (pColl)
 {
-SwTextFormatColl* pColl = 
GetExport().m_pDoc->FindTextFormatCollByName(sStyle);
-if (pColl)
+if 
(!pColl->IsAssignedToListLevelOfOutlineStyle() || 
pColl->GetAssignedOutlineStyleLevel() < nTOXLvl)
 {
-if 
(!pColl->IsAssignedToListLevelOfOutlineStyle() || 
pColl->GetAssignedOutlineStyleLevel() < nTOXLvl)
-{
-if( !sTOption.isEmpty() )
-sTOption += ",";
-sTOption += sStyle + sLvl;
-}
+if( !sTOption.isEmpty() )
+sTOption += ",";
+sTOption += sStyle + sLvl;
 }
 }
-} while( -1 != nPos );
-}
+}
+} while( -1 != nPos );
 }
 }
+}
 
 // No 'else' branch; why the below snippet is a block I 
have no idea.
 {
@@ -2454,8 +2454,8 @@ void AttributeOutputBase::StartTOX( const SwSection& 
rSect )
 sStr += "\\t \"" + sTOption + sEntryEnd;
 }
 
-if (lcl_IsHyperlinked(pTOX->GetTOXForm(), nTOXLvl))
-sStr += "\\h";
+if (lcl_IsHyperlinked(pTOX->GetTOXForm(), nTOXLvl))
+sStr += 

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/core/tox/tox.cxx |   17 +
 1 file changed, 9 insertions(+), 8 deletions(-)

New commits:
commit a225305b55e82ac217a25c47d59691d0f2842dd2
Author: Matteo Casalin 
AuthorDate: Fri Feb 1 07:53:12 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 23:06:03 2019 +0100

Use indexed getToken()

Change-Id: I1786e75ff12f16450f62f5091981a26c89af2514
Reviewed-on: https://gerrit.libreoffice.org/67329
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/core/tox/tox.cxx b/sw/source/core/tox/tox.cxx
index 6a5cebb92bf0..3a3860fb2e53 100644
--- a/sw/source/core/tox/tox.cxx
+++ b/sw/source/core/tox/tox.cxx
@@ -840,8 +840,9 @@ lcl_BuildToken(const OUString & sPattern, sal_Int32 & 
nCurPatternPos)
 const OUString sAuthFieldEnum = sToken.copy( 2, 2 );
 sToken = sToken.copy( nTokenLen, sToken.getLength() - nTokenLen - 1);
 
-eRet.sCharStyleName = sToken.getToken( 0, ',');
-OUString sTmp( sToken.getToken( 1, ',' ));
+sal_Int32 nIdx{ 0 };
+eRet.sCharStyleName = sToken.getToken( 0, ',', nIdx );
+OUString sTmp( sToken.getToken( 0, ',', nIdx ));
 if( !sTmp.isEmpty() )
 eRet.nPoolId = static_cast(sTmp.toInt32());
 
@@ -851,10 +852,10 @@ lcl_BuildToken(const OUString & sPattern, sal_Int32 & 
nCurPatternPos)
 case TOKEN_CHAPTER_INFO:
 //i53420
 case TOKEN_ENTRY_NO:
-sTmp = sToken.getToken( 2, ',' );
+sTmp = sToken.getToken( 0, ',', nIdx ); // token 2
 if( !sTmp.isEmpty() )
 eRet.nChapterFormat = static_cast(sTmp.toInt32());
-sTmp = sToken.getToken( 3, ',' );
+sTmp = sToken.getToken( 0, ',', nIdx ); // token 3
 if( !sTmp.isEmpty() )
 eRet.nOutlineLevel = static_cast(sTmp.toInt32()); 
//the maximum outline level to examine
 break;
@@ -876,19 +877,19 @@ lcl_BuildToken(const OUString & sPattern, sal_Int32 & 
nCurPatternPos)
 break;
 
 case TOKEN_TAB_STOP:
-sTmp = sToken.getToken( 2, ',' );
+sTmp = sToken.getToken( 0, ',', nIdx ); // token 2
 if( !sTmp.isEmpty() )
 eRet.nTabStopPosition = sTmp.toInt32();
 
-sTmp = sToken.getToken( 3, ',' );
+sTmp = sToken.getToken( 0, ',', nIdx ); // token 3
 if( !sTmp.isEmpty() )
 eRet.eTabAlign = static_cast(sTmp.toInt32());
 
-sTmp = sToken.getToken( 4, ',' );
+sTmp = sToken.getToken( 0, ',', nIdx ); // token 4
 if( !sTmp.isEmpty() )
 eRet.cTabFillChar = sTmp[0];
 
-sTmp = sToken.getToken( 5, ',' );
+sTmp = sToken.getToken( 0, ',', nIdx ); // token 5
 if( !sTmp.isEmpty() )
 eRet.bWithTab = 0 != sTmp.toInt32();
 break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/filter/ww8/ww8atr.cxx |  114 +---
 1 file changed, 39 insertions(+), 75 deletions(-)

New commits:
commit 4b0517c57240d606a9011bf2a0b3fec4669777d2
Author: Matteo Casalin 
AuthorDate: Fri Feb 1 07:52:05 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 23:05:15 2019 +0100

Use optimized OUString concatenation

Change-Id: Ib83b8cf3cbd46008413c71c098fea9946c090766
Reviewed-on: https://gerrit.libreoffice.org/67328
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
index 26d85550a66b..46abc4173c96 100644
--- a/sw/source/filter/ww8/ww8atr.cxx
+++ b/sw/source/filter/ww8/ww8atr.cxx
@@ -929,15 +929,13 @@ OUString MSWordExportBase::GetBookmarkName( sal_uInt16 
nTyp, const OUString* pNa
 case REF_SETREFATTR:
 if ( pName )
 {
-sRet += "Ref_";
-sRet += *pName;
+sRet = "Ref_" + *pName;
 }
 break;
 case REF_SEQUENCEFLD:
 {
 assert(pName);
-sRet += "Ref_";
-sRet += *pName;
+sRet = "Ref_" + *pName;
 break;
 }
 case REF_BOOKMARK:
@@ -947,12 +945,10 @@ OUString MSWordExportBase::GetBookmarkName( sal_uInt16 
nTyp, const OUString* pNa
 case REF_OUTLINE:
 break;  // ???
 case REF_FOOTNOTE:
-sRet += "_RefF";
-sRet += OUString::number( nSeqNo );
+sRet = "_RefF" + OUString::number( nSeqNo );
 break;
 case REF_ENDNOTE:
-sRet += "_RefE";
-sRet += OUString::number( nSeqNo );
+sRet = "_RefE" + OUString::number( nSeqNo );
 break;
 }
 return BookmarkToWord( sRet ); // #i43956# - encode bookmark accordingly
@@ -1698,10 +1694,8 @@ static void InsertSpecialChar( WW8Export& rWrt, 
sal_uInt8 c,
 
 static OUString lcl_GetExpandedField(const SwField )
 {
-OUString sRet(rField.ExpandField(true, nullptr));
-
 //replace LF 0x0A with VT 0x0B
-return sRet.replace(0x0A, 0x0B);
+return rField.ExpandField(true, nullptr).replace(0x0A, 0x0B);
 }
 
 WW8_WrPlcField* WW8Export::CurrentFieldPlc() const
@@ -1876,15 +1870,13 @@ void WW8Export::OutputField( const SwField* pField, 
ww::eField eFieldType,
 
 void WW8Export::StartCommentOutput(const OUString& rName)
 {
-OUString sStr(FieldString(ww::eQUOTE));
-sStr += "[" + rName + "] ";
+const OUString sStr{ FieldString(ww::eQUOTE) + "[" + rName + "] " };
 OutputField(nullptr, ww::eQUOTE, sStr, FieldFlags::Start | 
FieldFlags::CmdStart);
 }
 
 void WW8Export::EndCommentOutput(const OUString& rName)
 {
-OUString sStr(" [");
-sStr += rName + "] ";
+const OUString sStr{ " [" + rName + "] " };
 OutputField(nullptr, ww::eQUOTE, sStr, FieldFlags::CmdEnd | 
FieldFlags::End |
 FieldFlags::Close);
 }
@@ -2075,15 +2067,13 @@ void 
AttributeOutputBase::GenerateBookmarksForSequenceField(const SwTextNode& rN
 }
 }
 // Generate bookmarks on the right position
-OUString sName("Ref_" + 
pRefField->GetSetRefName());
-sName += 
OUString::number(pRefField->GetSeqNo());
+OUString sName("Ref_" + 
pRefField->GetSetRefName() + OUString::number(pRefField->GetSeqNo()));
 switch (pRefField->GetFormat())
 {
 case REF_PAGE:
 case REF_PAGE_PGDESC:
 case REF_CONTENT:
 case REF_UPDOWN:
-sName += "_full";
 if(!bHaveFullBkm)
 {
 sal_Int32 nLastAttrStart = 0;
@@ -2094,15 +2084,15 @@ void 
AttributeOutputBase::GenerateBookmarksForSequenceField(const SwTextNode& rN
 aLocalAttrIter.NextPos();
 nActAttr = 
aLocalAttrIter.WhereNext();
 }
-WriteBookmarkInActParagraph( 
sName, std::min(nCategoryStart, pHt->GetStart()), nLastAttrStart );
+WriteBookmarkInActParagraph( 
sName + "_full", std::min(nCategoryStart, pHt->GetStart()), nLastAttrStart );
 bHaveFullBkm = true;
 }
 break;

[Libreoffice-bugs] [Bug 119575] Clear recent document list crashes LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=119575

durver...@tuta.io changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #7 from durver...@tuta.io ---
I have just upgraded from 5.4.4.2 to 6.1.4.2 (x64, Windows) and I confirm the
bug is still present. I also have a full (25 item long) Recent Documents list,
which has erroneously not been updated for a while. Selecting the "Clear List"
menu item, causes the application to crash. After the crash I have to manually
stop all LibreOffice related processes in Task Manager before Calc can again be
launched. A crash report can be found here:
crashreport.libreoffice.org/stats/crash_details/f22b8222-d7eb-4cf2-8cc8-edbd924e9b0.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/ui/dialog/uiregionsw.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit d4fe30d494bcedcaf7396a772ce729641c667534
Author: Matteo Casalin 
AuthorDate: Fri Feb 1 07:43:17 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 23:01:53 2019 +0100

Use indexed getToken()

Change-Id: I7637728bac4b7f0df56c564b204dce08db1298e8
Reviewed-on: https://gerrit.libreoffice.org/67326
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/ui/dialog/uiregionsw.cxx 
b/sw/source/ui/dialog/uiregionsw.cxx
index 783e2b0b1f2b..877083ceaf34 100644
--- a/sw/source/ui/dialog/uiregionsw.cxx
+++ b/sw/source/ui/dialog/uiregionsw.cxx
@@ -242,8 +242,9 @@ void SectRepr::SetFilter( const OUString& rFilter )
 {
 OUString sNewFile;
 const OUString sOldFileName( m_SectionData.GetLinkFileName() );
-const OUString sFile( sOldFileName.getToken( 0, sfx2::cTokenSeparator ) );
-const OUString sSub( sOldFileName.getToken( 2, sfx2::cTokenSeparator ) );
+sal_Int32 nIdx{ 0 };
+const OUString sFile( sOldFileName.getToken( 0, sfx2::cTokenSeparator, 
nIdx ) ); // token 0
+const OUString sSub( sOldFileName.getToken( 1, sfx2::cTokenSeparator, nIdx 
) );  // token 2
 
 if( !sFile.isEmpty() )
 sNewFile = sFile + OUStringLiteral1(sfx2::cTokenSeparator) +
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/ui/envelp/label1.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 81c3d469413db27d22ea757ccef677b1aa0669c0
Author: Matteo Casalin 
AuthorDate: Fri Feb 1 07:42:18 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 23:00:28 2019 +0100

Use indexed getToken()

Change-Id: Ic500623b851cd8f4db665aa7c3de7443e0d39a87
Reviewed-on: https://gerrit.libreoffice.org/67324
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/ui/envelp/label1.cxx b/sw/source/ui/envelp/label1.cxx
index a2e1691a5aec..314146a7d049 100644
--- a/sw/source/ui/envelp/label1.cxx
+++ b/sw/source/ui/envelp/label1.cxx
@@ -432,8 +432,9 @@ void SwLabPage::InitDatabaseBox()
 const OUString* pDataNames = aDataNames.getConstArray();
 for (long i = 0; i < aDataNames.getLength(); i++)
 m_xDatabaseLB->append_text(pDataNames[i]);
-OUString sDBName = sActDBName.getToken( 0, DB_DELIM );
-OUString sTableName = sActDBName.getToken( 1, DB_DELIM );
+sal_Int32 nIdx{ 0 };
+OUString sDBName = sActDBName.getToken( 0, DB_DELIM, nIdx );
+OUString sTableName = sActDBName.getToken( 0, DB_DELIM, nIdx );
 m_xDatabaseLB->set_active_text(sDBName);
 if( !sDBName.isEmpty() && GetDBManager()->GetTableNames(*m_xTableLB, 
sDBName))
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/ui/fldui/changedb.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 9d4ed3c555d0fd71b8b569f98814f1090bdeff17
Author: Matteo Casalin 
AuthorDate: Fri Feb 1 07:41:48 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 23:00:01 2019 +0100

Use indexed getToken()

Change-Id: Ifd3885d07f7bcad46039560bbb19f48074fb4cd0
Reviewed-on: https://gerrit.libreoffice.org/67323
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/ui/fldui/changedb.cxx b/sw/source/ui/fldui/changedb.cxx
index 3cda5bbb3a50..54854cd99699 100644
--- a/sw/source/ui/fldui/changedb.cxx
+++ b/sw/source/ui/fldui/changedb.cxx
@@ -125,9 +125,10 @@ void SwChangeDBDlg::FillDBPopup()
 
 SvTreeListEntry* SwChangeDBDlg::Insert(const OUString& rDBName)
 {
-const OUString sDBName(rDBName.getToken(0, DB_DELIM));
-const OUString sTableName(rDBName.getToken(1, DB_DELIM));
-sal_IntPtr nCommandType = rDBName.getToken(2, DB_DELIM).toInt32();
+sal_Int32 nIdx{ 0 };
+const OUString sDBName(rDBName.getToken(0, DB_DELIM, nIdx));
+const OUString sTableName(rDBName.getToken(0, DB_DELIM, nIdx));
+sal_IntPtr nCommandType = rDBName.getToken(0, DB_DELIM, nIdx).toInt32();
 SvTreeListEntry* pParent;
 SvTreeListEntry* pChild;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/ui/fldui/flddb.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit ff0c58d360b1958d896b437035b81058a176d41f
Author: Matteo Casalin 
AuthorDate: Fri Feb 1 07:28:20 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 22:59:31 2019 +0100

Use indexed getToken()

Change-Id: I7f27f9a8023102c5e07fb45ed40e06ee862fccde
Reviewed-on: https://gerrit.libreoffice.org/67322
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/ui/fldui/flddb.cxx b/sw/source/ui/fldui/flddb.cxx
index dff301af6ce1..56da644402fd 100644
--- a/sw/source/ui/fldui/flddb.cxx
+++ b/sw/source/ui/fldui/flddb.cxx
@@ -173,10 +173,11 @@ void SwFieldDBPage::Reset(const SfxItemSet*)
 
 if( !IsRefresh() )
 {
-OUString sUserData = GetUserData();
-if (sUserData.getToken(0, 
';').equalsIgnoreAsciiCase(USER_DATA_VERSION_1))
+const OUString sUserData = GetUserData();
+sal_Int32 nIdx{ 0 };
+if (sUserData.getToken(0, ';', 
nIdx).equalsIgnoreAsciiCase(USER_DATA_VERSION_1))
 {
-const sal_uInt16 nVal = 
static_cast(sUserData.getToken(1, ';').toInt32());
+const sal_uInt16 nVal = 
static_cast(sUserData.getToken(0, ';', nIdx).toInt32());
 if(nVal != USHRT_MAX)
 {
 for (sal_Int32 i = 0; i < m_pTypeLB->GetEntryCount(); ++i)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 103405] L10n: Add additional user interface language Hungarian Rovas [hu-Hung-HU]

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103405

--- Comment #33 from Óvári  ---
(In reply to Kovács Viktor from comment #32)
> cc:Óvári
> What is Your opinion about file a bug for a font acceptation method?

Can a developer who can accept changes please advise whether this will be
accepted? Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90964] Comments wrongly right justified in the Manage Changes sidebar experimental feature

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90964

--- Comment #12 from László Németh  ---
(In reply to Buovjaga from comment #11)
> (In reply to László Németh from comment #10)
> > It seems, there is no experimental feature Manage Changes sidebar any more.
> > Please, reopen this issue if I'm wrong.
> 
> There is: you just have to enable experimental features: Tools - Options -
> LibO - Advanced

Buovjaga: Indeed, and this bug is still there, too. thanks for reopening the
issue, László

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - cui/source vcl/unx

[Libreoffice Gerrit user]

 cui/source/inc/page.hxx  |2 -
 cui/source/tabpages/page.cxx |4 +-
 vcl/unx/gtk3/gtk3gtkinst.cxx |   61 +--
 3 files changed, 56 insertions(+), 11 deletions(-)

New commits:
commit 5d0eba55bf516e94111aa4ed45c107cce6523124
Author: Caolán McNamara 
AuthorDate: Mon Jan 28 13:12:00 2019 +
Commit: Caolán McNamara 
CommitDate: Mon Feb 4 22:37:24 2019 +0100

Resolves: tdf#122930 paper tray is to update on focus-in

which adds the problem that GtkComboBox doesn't send a focus-in,
but its toggle does, to find and use that instead

Change-Id: I18d46511bf2e6997539a8413f574a94b24b4583f
Reviewed-on: https://gerrit.libreoffice.org/67016
Tested-by: Jenkins
Tested-by: Xisco Faulí 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/source/inc/page.hxx b/cui/source/inc/page.hxx
index 7fe4681343f9..315d6a36fd82 100644
--- a/cui/source/inc/page.hxx
+++ b/cui/source/inc/page.hxx
@@ -135,7 +135,7 @@ private:
 
 voidInit_Impl();
 DECL_LINK(LayoutHdl_Impl, weld::ComboBox&, void);
-DECL_LINK(PaperBinHdl_Impl, weld::ComboBox&, void);
+DECL_LINK(PaperBinHdl_Impl, weld::Widget&, void);
 DECL_LINK(SwapOrientation_Impl, weld::Button&, void);
 void SwapFirstValues_Impl( bool bSet );
 DECL_LINK(BorderModify_Impl, weld::MetricSpinButton&, void);
diff --git a/cui/source/tabpages/page.cxx b/cui/source/tabpages/page.cxx
index c9cc5f5dfd64..81ad11e810f6 100644
--- a/cui/source/tabpages/page.cxx
+++ b/cui/source/tabpages/page.cxx
@@ -308,7 +308,7 @@ void SvxPageDescPage::Init_Impl()
 // adjust the handler
 m_xLayoutBox->connect_changed(LINK(this, SvxPageDescPage, LayoutHdl_Impl));
 
-m_xPaperTrayBox->connect_changed(LINK(this, SvxPageDescPage, 
PaperBinHdl_Impl));
+m_xPaperTrayBox->connect_focus_in(LINK(this, SvxPageDescPage, 
PaperBinHdl_Impl));
 m_xPaperSizeBox->connect_changed(LINK(this, SvxPageDescPage, 
PaperSizeSelect_Impl));
 m_xPaperWidthEdit->connect_value_changed( LINK(this, SvxPageDescPage, 
PaperSizeModify_Impl));
 m_xPaperHeightEdit->connect_value_changed(LINK(this, SvxPageDescPage, 
PaperSizeModify_Impl));
@@ -802,7 +802,7 @@ IMPL_LINK_NOARG(SvxPageDescPage, LayoutHdl_Impl, 
weld::ComboBox&, void)
 UpdateExample_Impl( true );
 }
 
-IMPL_LINK_NOARG(SvxPageDescPage, PaperBinHdl_Impl, weld::ComboBox&, void)
+IMPL_LINK_NOARG(SvxPageDescPage, PaperBinHdl_Impl, weld::Widget&, void)
 {
 if (m_xPaperTrayBox->get_count() > 1)
 // already filled
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 32da17be9fc5..08becd0c2ede 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -1203,14 +1203,6 @@ class GtkInstanceWidget : public virtual weld::Widget
 {
 protected:
 GtkWidget* m_pWidget;
-private:
-bool m_bTakeOwnership;
-bool m_bFrozen;
-gulong m_nFocusInSignalId;
-gulong m_nFocusOutSignalId;
-gulong m_nKeyPressSignalId;
-gulong m_nKeyReleaseSignalId;
-gulong m_nSizeAllocateSignalId;
 
 static void signalFocusIn(GtkWidget*, GdkEvent*, gpointer widget)
 {
@@ -1236,6 +1228,15 @@ private:
 m_aFocusOutHdl.Call(*this);
 }
 
+private:
+bool m_bTakeOwnership;
+bool m_bFrozen;
+gulong m_nFocusInSignalId;
+gulong m_nFocusOutSignalId;
+gulong m_nKeyPressSignalId;
+gulong m_nKeyReleaseSignalId;
+gulong m_nSizeAllocateSignalId;
+
 static void signalSizeAllocate(GtkWidget*, GdkRectangle* allocation, 
gpointer widget)
 {
 GtkInstanceWidget* pThis = static_cast(widget);
@@ -6505,11 +6506,14 @@ private:
 GtkTreeModel* m_pTreeModel;
 GtkCellRenderer* m_pTextRenderer;
 GtkMenu* m_pMenu;
+GtkWidget* m_pToggleButton;
 std::unique_ptr m_xSorter;
 vcl::QuickSelectionEngine m_aQuickSelectionEngine;
 std::vector m_aSeparatorRows;
 gboolean m_bPopupActive;
 bool m_bAutoComplete;
+gulong m_nToggleFocusInSignalId;
+gulong m_nToggleFocusOutSignalId;
 gulong m_nChangedSignalId;
 gulong m_nPopupShownSignalId;
 gulong m_nKeyPressEventSignalId;
@@ -6860,15 +6864,29 @@ private:
 g_signal_connect(m_pMenu, "key-press-event", 
G_CALLBACK(signalKeyPress), this);
 }
 
+static void find_toggle_button(GtkWidget *pWidget, gpointer user_data)
+{
+if (g_strcmp0(gtk_widget_get_name(pWidget), "GtkToggleButton") == 0)
+{
+GtkWidget **ppToggleButton = static_cast(user_data);
+*ppToggleButton = pWidget;
+}
+else if (GTK_IS_CONTAINER(pWidget))
+gtk_container_forall(GTK_CONTAINER(pWidget), find_toggle_button, 
user_data);
+}
+
 public:
 GtkInstanceComboBox(GtkComboBox* pComboBox, bool bTakeOwnership)
 : GtkInstanceContainer(GTK_CONTAINER(pComboBox), bTakeOwnership)
 , m_pComboBox(pComboBox)
 , m_pTreeModel(gtk_combo_box_get_model(m_pComboBox))
 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - cui/source vcl/unx

[Libreoffice Gerrit user]

 cui/source/inc/page.hxx  |2 -
 cui/source/tabpages/page.cxx |4 +--
 vcl/unx/gtk3/gtk3gtkinst.cxx |   53 ++-
 3 files changed, 51 insertions(+), 8 deletions(-)

New commits:
commit 336feec6b0bef15bd3a234c63d63ad8d869a3374
Author: Caolán McNamara 
AuthorDate: Mon Jan 28 13:12:00 2019 +
Commit: Caolán McNamara 
CommitDate: Mon Feb 4 22:37:06 2019 +0100

Resolves: tdf#122930 paper tray is to update on focus-in

which adds the problem that GtkComboBox doesn't send a focus-in,
but its toggle does, to find and use that instead

Change-Id: I18d46511bf2e6997539a8413f574a94b24b4583f
Reviewed-on: https://gerrit.libreoffice.org/67136
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/source/inc/page.hxx b/cui/source/inc/page.hxx
index da7ee7047391..d6fc20577fa7 100644
--- a/cui/source/inc/page.hxx
+++ b/cui/source/inc/page.hxx
@@ -136,7 +136,7 @@ private:
 
 voidInit_Impl();
 DECL_LINK(LayoutHdl_Impl, weld::ComboBoxText&, void);
-DECL_LINK(PaperBinHdl_Impl, weld::ComboBoxText&, void);
+DECL_LINK(PaperBinHdl_Impl, weld::Widget&, void);
 DECL_LINK(SwapOrientation_Impl, weld::Button&, void);
 void SwapFirstValues_Impl( bool bSet );
 DECL_LINK(BorderModify_Impl, weld::MetricSpinButton&, void);
diff --git a/cui/source/tabpages/page.cxx b/cui/source/tabpages/page.cxx
index 054bc8fb16ed..a3e7a2ebb80e 100644
--- a/cui/source/tabpages/page.cxx
+++ b/cui/source/tabpages/page.cxx
@@ -314,7 +314,7 @@ void SvxPageDescPage::Init_Impl()
 // adjust the handler
 m_xLayoutBox->connect_changed(LINK(this, SvxPageDescPage, LayoutHdl_Impl));
 
-m_xPaperTrayBox->connect_changed(LINK(this, SvxPageDescPage, 
PaperBinHdl_Impl));
+m_xPaperTrayBox->connect_focus_in(LINK(this, SvxPageDescPage, 
PaperBinHdl_Impl));
 m_xPaperSizeBox->connect_changed(LINK(this, SvxPageDescPage, 
PaperSizeSelect_Impl));
 m_xPaperWidthEdit->connect_value_changed( LINK(this, SvxPageDescPage, 
PaperSizeModify_Impl));
 m_xPaperHeightEdit->connect_value_changed(LINK(this, SvxPageDescPage, 
PaperSizeModify_Impl));
@@ -808,7 +808,7 @@ IMPL_LINK_NOARG(SvxPageDescPage, LayoutHdl_Impl, 
weld::ComboBoxText&, void)
 UpdateExample_Impl( true );
 }
 
-IMPL_LINK_NOARG(SvxPageDescPage, PaperBinHdl_Impl, weld::ComboBoxText&, void)
+IMPL_LINK_NOARG(SvxPageDescPage, PaperBinHdl_Impl, weld::Widget&, void)
 {
 if (m_xPaperTrayBox->get_count() > 1)
 // already filled
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index bd221af10cdb..384f1d411e4d 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -1183,11 +1183,6 @@ class GtkInstanceWidget : public virtual weld::Widget
 {
 protected:
 GtkWidget* m_pWidget;
-private:
-bool m_bTakeOwnership;
-gulong m_nFocusInSignalId;
-gulong m_nFocusOutSignalId;
-gulong m_nKeyPressSignalId;
 
 static void signalFocusIn(GtkWidget*, GdkEvent*, gpointer widget)
 {
@@ -1203,6 +1198,12 @@ private:
 pThis->signal_focus_out();
 }
 
+private:
+bool m_bTakeOwnership;
+gulong m_nFocusInSignalId;
+gulong m_nFocusOutSignalId;
+gulong m_nKeyPressSignalId;
+
 static gboolean signalKeyPress(GtkWidget*, GdkEventKey* pEvent, gpointer)
 {
 // #i1820# use locale specific decimal separator
@@ -4486,8 +4487,11 @@ class GtkInstanceComboBoxText : public 
GtkInstanceContainer, public virtual weld
 {
 private:
 GtkComboBoxText* m_pComboBoxText;
+GtkWidget* m_pToggleButton;
 std::unique_ptr m_xSorter;
 gboolean m_bPopupActive;
+gulong m_nToggleFocusInSignalId;
+gulong m_nToggleFocusOutSignalId;
 gulong m_nChangedSignalId;
 gulong m_nPopupShownSignalId;
 gulong m_nEntryActivateSignalId;
@@ -4594,11 +4598,25 @@ private:
 g_object_unref(pCompletion);
 }
 
+static void find_toggle_button(GtkWidget *pWidget, gpointer user_data)
+{
+if (g_strcmp0(gtk_widget_get_name(pWidget), "GtkToggleButton") == 0)
+{
+GtkWidget **ppToggleButton = static_cast(user_data);
+*ppToggleButton = pWidget;
+}
+else if (GTK_IS_CONTAINER(pWidget))
+gtk_container_forall(GTK_CONTAINER(pWidget), find_toggle_button, 
user_data);
+}
+
 public:
 GtkInstanceComboBoxText(GtkComboBoxText* pComboBoxText, bool 
bTakeOwnership)
 : GtkInstanceContainer(GTK_CONTAINER(pComboBoxText), bTakeOwnership)
 , m_pComboBoxText(pComboBoxText)
+, m_pToggleButton(nullptr)
 , m_bPopupActive(false)
+, m_nToggleFocusInSignalId(0)
+, m_nToggleFocusOutSignalId(0)
 , m_nChangedSignalId(g_signal_connect(m_pComboBoxText, "changed", 
G_CALLBACK(signalChanged), this))
 , m_nPopupShownSignalId(g_signal_connect(m_pComboBoxText, 
"notify::popup-shown", G_CALLBACK(signalPopupShown), this))
 {
@@ 

[Libreoffice-bugs] [Bug 116968] [META] Migrating existing embedded HSQLDB databases to Firebird

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116968
Bug 116968 depends on bug 116987, which changed state.

Bug 116987 Summary: FIREBIRD : Migration : error on importing tables or queries 
with names longer than 30 characters
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116987

Tamas Bunth  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/ui/fldui/flddinf.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 395729260ddd6ff1c32a9ac7ef5c5b4651f0100d
Author: Matteo Casalin 
AuthorDate: Fri Feb 1 07:27:03 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 22:10:30 2019 +0100

Use indexed getToken()

Change-Id: Ic81c216d24eb0b41549f2b82a3888c466d26c5ca
Reviewed-on: https://gerrit.libreoffice.org/67321
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/ui/fldui/flddinf.cxx b/sw/source/ui/fldui/flddinf.cxx
index 05e0bfcd4f45..c412a4045e0a 100644
--- a/sw/source/ui/fldui/flddinf.cxx
+++ b/sw/source/ui/fldui/flddinf.cxx
@@ -146,9 +146,10 @@ void SwFieldDokInfPage::Reset(const SfxItemSet* )
 
 sal_Int32 nSelEntryData = LISTBOX_ENTRY_NOTFOUND;
 const OUString sUserData = GetUserData();
-if (sUserData.getToken(0, ';').equalsIgnoreAsciiCase(USER_DATA_VERSION_1))
+sal_Int32 nIdx{ 0 };
+if (sUserData.getToken(0, ';', 
nIdx).equalsIgnoreAsciiCase(USER_DATA_VERSION_1))
 {
-nSelEntryData = sUserData.getToken(1, ';').toInt32();
+nSelEntryData = sUserData.getToken(0, ';', nIdx).toInt32();
 }
 
 std::vector aLst;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/ui/fldui/fldfunc.cxx |   13 +++--
 1 file changed, 7 insertions(+), 6 deletions(-)

New commits:
commit 9cb73d627a0c6df7c4e01ac1c90e24baf82adc6c
Author: Matteo Casalin 
AuthorDate: Wed Jan 30 08:03:33 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 22:07:11 2019 +0100

Use indexed getToken()

Change-Id: Id3f8352fd367645fffb81fe1c08c3be8fb35cb07
Reviewed-on: https://gerrit.libreoffice.org/67319
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/ui/fldui/fldfunc.cxx b/sw/source/ui/fldui/fldfunc.cxx
index f70a551c3034..d617524a1502 100644
--- a/sw/source/ui/fldui/fldfunc.cxx
+++ b/sw/source/ui/fldui/fldfunc.cxx
@@ -183,11 +183,11 @@ void SwFieldFuncPage::Reset(const SfxItemSet* )
 
 if( !IsRefresh() )
 {
-OUString sUserData = GetUserData();
-if(sUserData.getToken(0, 
';').equalsIgnoreAsciiCase(USER_DATA_VERSION_1))
+const OUString sUserData = GetUserData();
+sal_Int32 nIdx{ 0 };
+if(sUserData.getToken(0, ';', 
nIdx).equalsIgnoreAsciiCase(USER_DATA_VERSION_1))
 {
-OUString sVal = sUserData.getToken(1, ';');
-const sal_uInt16 nVal = static_cast< sal_uInt16 >(sVal.toInt32());
+const sal_uInt16 nVal = static_cast< sal_uInt16 
>(sUserData.getToken(0, ';', nIdx).toInt32());
 if(nVal != USHRT_MAX)
 {
 for(sal_Int32 i = 0; i < m_pTypeLB->GetEntryCount(); i++)
@@ -361,8 +361,9 @@ IMPL_LINK_NOARG(SwFieldFuncPage, TypeHdl, ListBox&, void)
 m_pNameED->SetDropEnable(true);
 if (IsFieldEdit())
 {
-m_pCond1ED->SetText(GetCurField()->GetPar2().getToken(0, '|'));
-m_pCond2ED->SetText(GetCurField()->GetPar2().getToken(1, '|'));
+sal_Int32 nIdx{ 0 };
+m_pCond1ED->SetText(GetCurField()->GetPar2().getToken(0, '|', 
nIdx));
+m_pCond2ED->SetText(GetCurField()->GetPar2().getToken(0, '|', 
nIdx));
 }
 
 bName = bValue = true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/ui/fldui/flddok.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 8936a61e2224c3d7f85c541aa02dd72e82044604
Author: Matteo Casalin 
AuthorDate: Wed Jan 30 08:00:18 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 22:06:14 2019 +0100

Use indexed getToken()

Change-Id: I613105a14a5e834bd9ac915261303b1e058340dd
Reviewed-on: https://gerrit.libreoffice.org/67318
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/ui/fldui/flddok.cxx b/sw/source/ui/fldui/flddok.cxx
index c267d8ba8995..2b68cecac158 100644
--- a/sw/source/ui/fldui/flddok.cxx
+++ b/sw/source/ui/fldui/flddok.cxx
@@ -175,10 +175,10 @@ void SwFieldDokPage::Reset(const SfxItemSet* )
 if( !IsRefresh() )
 {
 const OUString sUserData = GetUserData();
-if (sUserData.getToken(0, 
';').equalsIgnoreAsciiCase(USER_DATA_VERSION_1))
+sal_Int32 nIdx{ 0 };
+if (sUserData.getToken(0, ';', 
nIdx).equalsIgnoreAsciiCase(USER_DATA_VERSION_1))
 {
-const OUString sVal = sUserData.getToken(1, ';');
-const sal_uInt16 nVal = static_cast< sal_uInt16 >(sVal.toInt32());
+const sal_uInt16 nVal = static_cast< sal_uInt16 
>(sUserData.getToken(0, ';', nIdx).toInt32());
 if(nVal != USHRT_MAX)
 {
 for(sal_Int32 i = 0; i < m_pTypeLB->GetEntryCount(); i++)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/ui/fldui/fldref.cxx |   11 ---
 1 file changed, 4 insertions(+), 7 deletions(-)

New commits:
commit c8adf591c724330aa999dfbdeacd94b470f59108
Author: Matteo Casalin 
AuthorDate: Wed Jan 30 07:58:28 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 22:05:33 2019 +0100

Reduce temporaries

Change-Id: I50c22563c7804efe0dd125468d13e81b41b23702
Reviewed-on: https://gerrit.libreoffice.org/67317
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/ui/fldui/fldref.cxx b/sw/source/ui/fldui/fldref.cxx
index f52464c6e142..9680406df1ff 100644
--- a/sw/source/ui/fldui/fldref.cxx
+++ b/sw/source/ui/fldui/fldref.cxx
@@ -140,8 +140,7 @@ void SwFieldRefPage::dispose()
 
 IMPL_LINK_NOARG(SwFieldRefPage, ModifyHdl_Impl, Edit&, void)
 {
-OUString sFilter = comphelper::string::strip(m_pFilterED->GetText(), ' ');
-UpdateSubType(sFilter);
+UpdateSubType(comphelper::string::strip(m_pFilterED->GetText(), ' '));
 }
 
 // #i83479#
@@ -269,12 +268,11 @@ void SwFieldRefPage::Reset(const SfxItemSet* )
 if( !IsRefresh() )
 {
 sal_Int32 nIdx{ 0 };
-OUString sUserData = GetUserData();
+const OUString sUserData = GetUserData();
 if(!IsRefresh() && sUserData.getToken(0, ';', nIdx).
 equalsIgnoreAsciiCase(USER_DATA_VERSION_1))
 {
-OUString sVal = sUserData.getToken(0, ';', nIdx);
-const sal_uInt16 nVal = static_cast< sal_uInt16 >(sVal.toInt32());
+const sal_uInt16 nVal = static_cast< sal_uInt16 
>(sUserData.getToken(0, ';', nIdx).toInt32());
 if(nVal != USHRT_MAX)
 {
 for(sal_Int32 i = 0; i < m_pTypeLB->GetEntryCount(); i++)
@@ -393,8 +391,7 @@ IMPL_LINK_NOARG(SwFieldRefPage, TypeHdl, ListBox&, void)
 sal_uInt16 nTypeId = 
static_cast(reinterpret_cast(m_pTypeLB->GetEntryData(GetTypeSel(;
 
 // fill selection-ListBox
-OUString sFilter = comphelper::string::strip(m_pFilterED->GetText(), ' ');
-UpdateSubType(sFilter);
+UpdateSubType(comphelper::string::strip(m_pFilterED->GetText(), ' '));
 
 bool bName = false;
 nFieldDlgFormatSel = 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/ui/fldui/fldref.cxx |5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit a2d4d00cb34cb092ad3d226d086976991c0991cb
Author: Matteo Casalin 
AuthorDate: Wed Jan 30 07:52:44 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 22:04:21 2019 +0100

Check emptiness of last token on index

Change-Id: I4cf0ea849f221270ebe8763d6a55f20dd72ba576
Reviewed-on: https://gerrit.libreoffice.org/67316
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/ui/fldui/fldref.cxx b/sw/source/ui/fldui/fldref.cxx
index 4ece72e1a1a4..f52464c6e142 100644
--- a/sw/source/ui/fldui/fldref.cxx
+++ b/sw/source/ui/fldui/fldref.cxx
@@ -285,10 +285,9 @@ void SwFieldRefPage::Reset(const SfxItemSet* )
 break;
 }
 }
-sVal = sUserData.getToken(0, ';', nIdx);
-if(!sVal.isEmpty())
+if (nIdx>=0 && nIdx(sVal.toInt32());
+nFormatBoxPosition = static_cast< sal_uInt16 
>(sUserData.getToken(0, ';', nIdx).toInt32());
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/ui/fldui/fldref.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit dc015ccb07c01a32666b87d2535c9265581b0aeb
Author: Matteo Casalin 
AuthorDate: Wed Jan 30 07:46:34 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 22:03:12 2019 +0100

Use indexed getToken()

Change-Id: Icc993a7d32d560823bff6b7d636bc6402f4677c5
Reviewed-on: https://gerrit.libreoffice.org/67315
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/ui/fldui/fldref.cxx b/sw/source/ui/fldui/fldref.cxx
index 1b37b588d4c5..4ece72e1a1a4 100644
--- a/sw/source/ui/fldui/fldref.cxx
+++ b/sw/source/ui/fldui/fldref.cxx
@@ -268,11 +268,12 @@ void SwFieldRefPage::Reset(const SfxItemSet* )
 sal_uInt16 nFormatBoxPosition = USHRT_MAX;
 if( !IsRefresh() )
 {
+sal_Int32 nIdx{ 0 };
 OUString sUserData = GetUserData();
-if(!IsRefresh() && sUserData.getToken(0, ';').
+if(!IsRefresh() && sUserData.getToken(0, ';', nIdx).
 equalsIgnoreAsciiCase(USER_DATA_VERSION_1))
 {
-OUString sVal = sUserData.getToken(1, ';');
+OUString sVal = sUserData.getToken(0, ';', nIdx);
 const sal_uInt16 nVal = static_cast< sal_uInt16 >(sVal.toInt32());
 if(nVal != USHRT_MAX)
 {
@@ -284,7 +285,7 @@ void SwFieldRefPage::Reset(const SfxItemSet* )
 break;
 }
 }
-sVal = sUserData.getToken(2, ';');
+sVal = sUserData.getToken(0, ';', nIdx);
 if(!sVal.isEmpty())
 {
 nFormatBoxPosition = static_cast< sal_uInt16 
>(sVal.toInt32());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/ui/fldui/fldvar.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit ddc4c93436dc4342bb47004376bb7e8352fbe8d6
Author: Matteo Casalin 
AuthorDate: Sun Jan 27 23:19:26 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 22:02:39 2019 +0100

Use indexed getToken()

Change-Id: Ic3cd02928cf8ea938b7cb2963b9fc316dddcac80
Reviewed-on: https://gerrit.libreoffice.org/67314
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/ui/fldui/fldvar.cxx b/sw/source/ui/fldui/fldvar.cxx
index 1bc8682b8276..d156a13204cf 100644
--- a/sw/source/ui/fldui/fldvar.cxx
+++ b/sw/source/ui/fldui/fldvar.cxx
@@ -179,9 +179,10 @@ void SwFieldVarPage::Reset(const SfxItemSet* )
 if( !IsRefresh() )
 {
 OUString sUserData = GetUserData();
-if(!IsRefresh() && sUserData.getToken(0, 
';').equalsIgnoreAsciiCase(USER_DATA_VERSION_1))
+sal_Int32 nIdx{ 0 };
+if(!IsRefresh() && sUserData.getToken(0, ';', 
nIdx).equalsIgnoreAsciiCase(USER_DATA_VERSION_1))
 {
-OUString sVal = sUserData.getToken(1, ';');
+OUString sVal = sUserData.getToken(0, ';', nIdx);
 sal_uInt16 nVal = static_cast(sVal.toInt32());
 if( USHRT_MAX != nVal )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 123165] Slow scrolling document with pictures (gtk3)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123165

Telesto  changed:

   What|Removed |Added

 CC||fsteiner-bo...@bio.ifi.lmu.
   ||de, todven...@suomi24.fi

--- Comment #1 from Telesto  ---
@Frank Steiner
I created a new report for this issue. A sample file would be nice :-)

@Buovjaga
FYI

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/ui/misc/glosbib.cxx |   18 --
 1 file changed, 8 insertions(+), 10 deletions(-)

New commits:
commit ed4a4b87595c1ca8eea4f356560e2b33665e7288
Author: Matteo Casalin 
AuthorDate: Sun Jan 27 23:13:29 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 22:01:35 2019 +0100

Make some OUString const and reduce temporaries

Change-Id: If82df4f962bc36eb505c0e755843a10357b29dcf
Reviewed-on: https://gerrit.libreoffice.org/67313
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/ui/misc/glosbib.cxx b/sw/source/ui/misc/glosbib.cxx
index aa47f32c06d4..ecdeaaf3c3c0 100644
--- a/sw/source/ui/misc/glosbib.cxx
+++ b/sw/source/ui/misc/glosbib.cxx
@@ -88,8 +88,7 @@ SwGlossaryGroupDlg::SwGlossaryGroupDlg(weld::Window * pParent,
 nCaseReadonly |= PATH_READONLY;
 else if( SWUnoHelper::UCB_IsCaseSensitiveFileName( aTempFile.GetURL()))
 nCaseReadonly |= PATH_CASE_SENSITIVE;
-OUString sId(OUString::number(nCaseReadonly));
-m_xPathLB->append(sId, sPath);
+m_xPathLB->append(OUString::number(nCaseReadonly), sPath);
 }
 m_xPathLB->set_active(0);
 m_xPathLB->set_sensitive(true);
@@ -111,7 +110,7 @@ SwGlossaryGroupDlg::SwGlossaryGroupDlg(weld::Window * 
pParent,
 else
 pData->sGroupTitle = sTitle;
 pData->sPath = m_xPathLB->get_text(sGroup.getToken(1, 
GLOS_DELIM).toInt32());
-OUString sId(OUString::number(reinterpret_cast(pData)));
+const OUString 
sId(OUString::number(reinterpret_cast(pData)));
 m_xGroupTLB->append(sId, pData->sGroupTitle);
 int nEntry = m_xGroupTLB->find_id(sId);
 m_xGroupTLB->set_text(nEntry, pData->sPath, 1);
@@ -143,7 +142,7 @@ void SwGlossaryGroupDlg::Apply()
 if (m_xNewPB->get_sensitive())
 NewHdl(*m_xNewPB);
 
-OUString aActGroup = SwGlossaryDlg::GetCurrGroup();
+const OUString aActGroup = SwGlossaryDlg::GetCurrGroup();
 
 for (const auto& removedStr : m_RemovedArr)
 {
@@ -158,9 +157,8 @@ void SwGlossaryGroupDlg::Apply()
 pGlosHdl->SetCurGroup(pUserData->sGroupName);
 }
 }
-OUString sTitle( removedStr.getToken(0, '\t', nIdx) );
 const OUString sMsg(SwResId(STR_QUERY_DELETE_GROUP1)
-+ sTitle
++ removedStr.getToken(0, '\t', nIdx)
 + SwResId(STR_QUERY_DELETE_GROUP2));
 
 std::unique_ptr 
xQueryBox(Application::CreateMessageDialog(m_pParent,
@@ -202,8 +200,8 @@ IMPL_LINK_NOARG( SwGlossaryGroupDlg, SelectHdl, 
weld::TreeView&, void )
 if (nFirstEntry != -1)
 {
 GlosBibUserData* pUserData = 
reinterpret_cast(m_xGroupTLB->get_id(nFirstEntry).toInt64());
-OUString sEntry(pUserData->sGroupName);
-OUString sName(m_xNameED->get_text());
+const OUString sEntry(pUserData->sGroupName);
+const OUString sName(m_xNameED->get_text());
 bool bExists = false;
 int nPos = m_xGroupTLB->find_text(sName);
 if (nPos != -1)
@@ -345,7 +343,7 @@ IMPL_LINK_NOARG(SwGlossaryGroupDlg, ModifyListBoxHdl, 
weld::ComboBox&, void)
 
 IMPL_LINK_NOARG(SwGlossaryGroupDlg, ModifyHdl, weld::Entry&, void)
 {
-OUString sEntry(m_xNameED->get_text());
+const OUString sEntry(m_xNameED->get_text());
 bool bEnableNew = true;
 bool bEnableDel = false;
 sal_uInt32 nCaseReadonly = m_xPathLB->get_active_id().toUInt32();
@@ -362,7 +360,7 @@ IMPL_LINK_NOARG(SwGlossaryGroupDlg, ModifyHdl, 
weld::Entry&, void)
 const ::utl::TransliterationWrapper& rSCmp = GetAppCmpStrIgnore();
 for (int i = 0, nEntryCount = m_xGroupTLB->n_children(); i < 
nEntryCount; ++i)
 {
-OUString sTemp = m_xGroupTLB->get_text(i, 0);
+const OUString sTemp = m_xGroupTLB->get_text(i, 0);
 nCaseReadonly = 
m_xPathLB->get_id(m_xPathLB->find_text(m_xGroupTLB->get_text(i,1))).toUInt32();
 bool bCase = 0 != (nCaseReadonly & PATH_CASE_SENSITIVE);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - cui/source sw/source

[Libreoffice Gerrit user]

 cui/source/options/webconninfo.cxx |4 
 sw/source/ui/misc/glosbib.cxx  |   12 +++-
 2 files changed, 7 insertions(+), 9 deletions(-)

New commits:
commit 1b347e2688e87c79063f2492fdaea8cd824d6a5b
Author: Caolán McNamara 
AuthorDate: Mon Feb 4 16:58:08 2019 +
Commit: Caolán McNamara 
CommitDate: Mon Feb 4 22:00:38 2019 +0100

click handlers set twice

Change-Id: I2b44673330b952b0dc28a8cb321541ee9f944699
Reviewed-on: https://gerrit.libreoffice.org/67373
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/source/options/webconninfo.cxx 
b/cui/source/options/webconninfo.cxx
index 237ded056a45..18a2cd7fbca9 100644
--- a/cui/source/options/webconninfo.cxx
+++ b/cui/source/options/webconninfo.cxx
@@ -120,10 +120,6 @@ 
WebConnectionInfoDialog::WebConnectionInfoDialog(vcl::Window* pParent)
 
pPasswordsLBContainer->set_height_request(m_pPasswordsLB->GetTextHeight()*8);
 
 m_pPasswordsLB->SetHeaderBarClickHdl( LINK( this, WebConnectionInfoDialog, 
HeaderBarClickedHdl ) );
-m_pRemoveBtn->SetClickHdl( LINK( this, WebConnectionInfoDialog, 
RemovePasswordHdl ) );
-m_pRemoveAllBtn->SetClickHdl( LINK( this, WebConnectionInfoDialog, 
RemoveAllPasswordsHdl ) );
-m_pChangeBtn->SetClickHdl( LINK( this, WebConnectionInfoDialog, 
ChangePasswordHdl ) );
-
 
 FillPasswordList();
 
commit d166dc5a1a5962411026a362c3552ecc4660c1dd
Author: Matteo Casalin 
AuthorDate: Sun Jan 27 20:17:43 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 22:00:29 2019 +0100

Use indexed getToken()

Change-Id: I84b75dcc2e5b32fe456c1ecd1a8524d4fb25ebc7
Reviewed-on: https://gerrit.libreoffice.org/67312
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/ui/misc/glosbib.cxx b/sw/source/ui/misc/glosbib.cxx
index d32df5c3e2d8..aa47f32c06d4 100644
--- a/sw/source/ui/misc/glosbib.cxx
+++ b/sw/source/ui/misc/glosbib.cxx
@@ -147,7 +147,8 @@ void SwGlossaryGroupDlg::Apply()
 
 for (const auto& removedStr : m_RemovedArr)
 {
-const OUString sDelGroup = removedStr.getToken(0, '\t');
+sal_Int32 nIdx{ 0 };
+const OUString sDelGroup = removedStr.getToken(0, '\t', nIdx);
 if( sDelGroup == aActGroup )
 {
 //when the current group is deleted, the current group has to be 
relocated
@@ -157,7 +158,7 @@ void SwGlossaryGroupDlg::Apply()
 pGlosHdl->SetCurGroup(pUserData->sGroupName);
 }
 }
-OUString sTitle( removedStr.getToken(1, '\t') );
+OUString sTitle( removedStr.getToken(0, '\t', nIdx) );
 const OUString sMsg(SwResId(STR_QUERY_DELETE_GROUP1)
 + sTitle
 + SwResId(STR_QUERY_DELETE_GROUP2));
@@ -172,9 +173,10 @@ void SwGlossaryGroupDlg::Apply()
 //don't rename before there was one
 for (auto it(m_RenamedArr.cbegin()); it != m_RenamedArr.cend(); ++it)
 {
-OUString const sOld(it->getToken(0, RENAME_TOKEN_DELIM));
-OUString sNew(it->getToken(1, RENAME_TOKEN_DELIM));
-OUString const sTitle(it->getToken(2, RENAME_TOKEN_DELIM));
+sal_Int32 nIdx{ 0 };
+OUString const sOld(it->getToken(0, RENAME_TOKEN_DELIM, nIdx));
+OUString sNew(it->getToken(0, RENAME_TOKEN_DELIM, nIdx));
+OUString const sTitle(it->getToken(0, RENAME_TOKEN_DELIM, nIdx));
 pGlosHdl->RenameGroup(sOld, sNew, sTitle);
 if (it == m_RenamedArr.begin())
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/ui/misc/glossary.cxx |   34 +++---
 1 file changed, 19 insertions(+), 15 deletions(-)

New commits:
commit 148bc64fce5c7980e13de4743f67c0ef65412b7f
Author: Matteo Casalin 
AuthorDate: Sun Jan 27 19:54:58 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 21:59:32 2019 +0100

Group common code

Change-Id: Id836c9e4bce7ae36e3ebbfea2d84f1eb095bd298
Reviewed-on: https://gerrit.libreoffice.org/67311
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/ui/misc/glossary.cxx b/sw/source/ui/misc/glossary.cxx
index 43c616deece3..27c210083eaf 100644
--- a/sw/source/ui/misc/glossary.cxx
+++ b/sw/source/ui/misc/glossary.cxx
@@ -262,6 +262,22 @@ void SwGlossaryDlg::dispose()
 SvxStandardDialog::dispose();
 }
 
+namespace
+{
+
+OUString getCurrentGlossary()
+{
+const OUString sTemp{ ::GetCurrGlosGroup() };
+
+// the zeroth path is not being recorded!
+if (sTemp.getToken(1, GLOS_DELIM).startsWith("0"))
+return sTemp.getToken(0, GLOS_DELIM);
+
+return sTemp;
+}
+
+}
+
 // select new group
 IMPL_LINK( SwGlossaryDlg, GrpSelect, SvTreeListBox *, pBox, void )
 {
@@ -299,11 +315,7 @@ IMPL_LINK( SwGlossaryDlg, GrpSelect, SvTreeListBox *, 
pBox, void )
 if( SfxRequest::HasMacroRecorder( pSh->GetView().GetViewFrame() ) )
 {
 SfxRequest aReq( pSh->GetView().GetViewFrame(), FN_SET_ACT_GLOSSARY );
-OUString sTemp(::GetCurrGlosGroup());
-// the zeroth path is not being recorded!
-if (sTemp.getToken(1, GLOS_DELIM).startsWith("0"))
-sTemp = sTemp.getToken(0, GLOS_DELIM);
-aReq.AppendItem(SfxStringItem(FN_SET_ACT_GLOSSARY, sTemp));
+aReq.AppendItem(SfxStringItem(FN_SET_ACT_GLOSSARY, 
getCurrentGlossary()));
 aReq.Done();
 }
 Invalidate(InvalidateFlags::Update);
@@ -319,11 +331,7 @@ void SwGlossaryDlg::Apply()
 if( SfxRequest::HasMacroRecorder( pSh->GetView().GetViewFrame() ) )
 {
 SfxRequest aReq( pSh->GetView().GetViewFrame(), FN_INSERT_GLOSSARY );
-OUString sTemp(::GetCurrGlosGroup());
-// the zeroth path is not being recorded!
-if (sTemp.getToken(1, GLOS_DELIM).startsWith("0"))
-sTemp = sTemp.getToken(0, GLOS_DELIM);
-aReq.AppendItem(SfxStringItem(FN_INSERT_GLOSSARY, sTemp));
+aReq.AppendItem(SfxStringItem(FN_INSERT_GLOSSARY, 
getCurrentGlossary()));
 aReq.AppendItem(SfxStringItem(FN_PARAM_1, aGlosName));
 aReq.Done();
 }
@@ -474,11 +482,7 @@ IMPL_LINK( SwGlossaryDlg, MenuHdl, Menu *, pMn, bool )
 if( SfxRequest::HasMacroRecorder( pSh->GetView().GetViewFrame() ) )
 {
 SfxRequest aReq(pSh->GetView().GetViewFrame(), 
FN_NEW_GLOSSARY);
-OUString sTemp(::GetCurrGlosGroup());
-// the zeroth path is not being recorded!
-if (sTemp.getToken(1, GLOS_DELIM).startsWith("0"))
-sTemp = sTemp.getToken(0, GLOS_DELIM);
-aReq.AppendItem(SfxStringItem(FN_NEW_GLOSSARY, sTemp));
+aReq.AppendItem(SfxStringItem(FN_NEW_GLOSSARY, 
getCurrentGlossary()));
 aReq.AppendItem(SfxStringItem(FN_PARAM_1, aShortName));
 aReq.AppendItem(SfxStringItem(FN_PARAM_2, aStr));
 aReq.Done();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 123165] New: Slow scrolling document with pictures (gtk3)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123165

Bug ID: 123165
   Summary: Slow scrolling document with pictures (gtk3)
   Product: LibreOffice
   Version: 6.1.3.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
>From bug 104716 comment 52

Just moved from SLE 12 to SLE 15, and while both have libreoffice-6.1.3.2, SLE
15 uses libreoffice-gtk3 instead of -gtk2. And now we can no longer work with
documents having a few pictures.

Steps to Reproduce:
Just added three copies of a pictures with 1/3 the width of the page (all
linked to the same pic file on the disk) in one row. Copied it so that we get 5
rows, i.e. 15 pics.

When we scroll the document so that we have only 3 or none pics in the
viewport, we can type in normal speed. When we see 6 pics in the viewports,
typing already shows some glitches and delays. With 9 pics visible, whole words
are delayed, i.e., we type a full sentence in normal speed and the words appear
2 or 3 seconds later. When we press a key and hold it, we usually see the chars
appear in real-time. With 9 pics in the viewport, nothing happens until we
release the key. Then all the chars appear at once.

With 12 or more pics in the viewport it's impossible to type anything except in
slow motion. When typing in normal speed you always must do a break to see the
chars appear, so you cannot read anything while you type.

With libreoffice-gtk2 it work's fine, but for some reason libreoffice always
crashes after some minutes with libreoffice-gtk2 on SLE 15.

With the QT interface, i.e., neither libreoffice-gtk3 nor -gtk2 installed,
typing works fine even with all 15 pics visible.

We really would like to use the GTK3 interface, e.g. due to the features of the
save/load dialog (tab-completion), but then libreoffice is impossible to use
with any document containing a few pics on a page.

Actual Results:
Slow scroll speed

Expected Results:
Normal speed


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/uibase/uiview/view.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit f0c7e840b02511d1fffb44ee9fc31b23b1fbb538
Author: Matteo Casalin 
AuthorDate: Sun Jan 27 19:46:18 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 21:57:41 2019 +0100

Use indexed getToken()

Change-Id: I8484a6a6314d86026fd634e5c770443941aced48
Reviewed-on: https://gerrit.libreoffice.org/67310
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/uibase/uiview/view.cxx b/sw/source/uibase/uiview/view.cxx
index eefb9ed9ee9c..1d96f6c64206 100644
--- a/sw/source/uibase/uiview/view.cxx
+++ b/sw/source/uibase/uiview/view.cxx
@@ -1241,8 +1241,9 @@ void SwView::ReadUserData( const OUString , 
bool bBrowse )
 //apply information from print preview - if available
 if( !m_sNewCursorPos.isEmpty() )
 {
-long nXTmp = m_sNewCursorPos.getToken( 0, ';' ).toInt32(),
- nYTmp = m_sNewCursorPos.getToken( 1, ';' ).toInt32();
+sal_Int32 nIdx{ 0 };
+const long nXTmp = m_sNewCursorPos.getToken( 0, ';', nIdx 
).toInt32();
+const long nYTmp = m_sNewCursorPos.getToken( 0, ';', nIdx 
).toInt32();
 Point aCursorPos2( nXTmp, nYTmp );
 bSelectObj = m_pWrtShell->IsObjSelectable( aCursorPos2 );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/uibase/app/apphdl.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit a56cc4e993cd5aa7dd9375777a94b09b6a4f8c6a
Author: Matteo Casalin 
AuthorDate: Sun Jan 27 19:45:24 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 21:54:12 2019 +0100

Use indexed getToken()

Change-Id: Iefbcb9c87a77264fa31b8554c122454dc1a88ead
Reviewed-on: https://gerrit.libreoffice.org/67308
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/uibase/app/apphdl.cxx b/sw/source/uibase/app/apphdl.cxx
index 9269f46dc5a0..061a44513e64 100644
--- a/sw/source/uibase/app/apphdl.cxx
+++ b/sw/source/uibase/app/apphdl.cxx
@@ -287,9 +287,10 @@ std::shared_ptr 
SwView::EnsureMailMergeConfigItem(const S
 {
 OUString sDBName(aDBNameList[0]);
 SwDBData aDBData;
-aDBData.sDataSource = sDBName.getToken(0, DB_DELIM);
-aDBData.sCommand = sDBName.getToken(1, DB_DELIM);
-aDBData.nCommandType = sDBName.getToken(2, DB_DELIM).toInt32();
+sal_Int32 nIdx{ 0 };
+aDBData.sDataSource = sDBName.getToken(0, DB_DELIM, nIdx);
+aDBData.sCommand = sDBName.getToken(0, DB_DELIM, nIdx);
+aDBData.nCommandType = sDBName.getToken(0, DB_DELIM, 
nIdx).toInt32();
 //set the currently used database for the wizard
 xMMConfig->SetCurrentDBData(aDBData);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98259
Bug 98259 depends on bug 97596, which changed state.

Bug 97596 Summary: Tools / Customize cannot change CTL-v to paste unformatted 
text
https://bugs.documentfoundation.org/show_bug.cgi?id=97596

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97596] Tools / Customize cannot change CTL-v to paste unformatted text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97596

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||98259
 Resolution|--- |WORKSFORME
 CC||79045_79...@mail.ru
 Status|NEW |RESOLVED

--- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> ---
CTRL+V assigned to "Paste Unformatted Text" works fine in

Version: 6.3.0.0.alpha0+
Build ID: cec3fe24dd4569bf04b13e0284823bad129dbb86
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-02-02_03:18:07
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded

Status->WFM


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=98259
[Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98259

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||97596


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=97596
[Bug 97596] Tools / Customize cannot change CTL-v to paste unformatted text
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/ui/misc/glossary.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 687932bc898a8a7d6fbf68260cefe789eec9aadf
Author: Matteo Casalin 
AuthorDate: Sun Jan 27 19:44:56 2019 +0100
Commit: Matteo Casalin 
CommitDate: Mon Feb 4 21:53:31 2019 +0100

Use indexed getToken()

Change-Id: I0977533e71e070227e19555d140d1de307bf91f4
Reviewed-on: https://gerrit.libreoffice.org/67307
Tested-by: Jenkins
Reviewed-by: Matteo Casalin 

diff --git a/sw/source/ui/misc/glossary.cxx b/sw/source/ui/misc/glossary.cxx
index ba79e0d072cc..43c616deece3 100644
--- a/sw/source/ui/misc/glossary.cxx
+++ b/sw/source/ui/misc/glossary.cxx
@@ -690,13 +690,14 @@ void SwGlossaryDlg::Init()
 OUString sGroupName(pGlossaryHdl->GetGroupName(nId, ));
 if(sGroupName.isEmpty())
 continue;
-const OUString sName{ sGroupName.getToken( 0, GLOS_DELIM ) };
+sal_Int32 nIdx{ 0 };
+const OUString sName{ sGroupName.getToken( 0, GLOS_DELIM, nIdx ) };
 if(sTitle.isEmpty())
 sTitle = sName;
 if(sTitle == sMyAutoTextEnglish)
 sTitle = sMyAutoTextTranslated;
 SvTreeListEntry* pEntry = m_pCategoryBox->InsertEntry( sTitle );
-const sal_Int32 nPath = sGroupName.getToken( 1, GLOS_DELIM ).toInt32();
+const sal_Int32 nPath = sGroupName.getToken( 0, GLOS_DELIM, nIdx 
).toInt32();
 
 GroupUserData* pData = new GroupUserData;
 pData->sGroupName = sName;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 123139] Reading XLSX format ignores horizontal alignment (generated wit Apache POI Java library)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123139

raal  changed:

   What|Removed |Added

Version|6.1.4.2 release |4.2.8.2 release
 CC||noel.po...@gmail.com
   Keywords||bibisected, bisected

--- Comment #3 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Noel Power ; Could you possibly take a look at this one?
Thanks

7768846a5953a624076782f3cc0fbdcca5f5c160 is the first bad commit
commit 7768846a5953a624076782f3cc0fbdcca5f5c160
Author: Matthew Francis 
Date:   Sat Sep 5 17:55:40 2015 +0800

source-hash-bf8e9b29aaebcbdd8f2f06b42ac97b8d9f8f4503

commit bf8e9b29aaebcbdd8f2f06b42ac97b8d9f8f4503
Author: Noel Power 
AuthorDate: Wed May 22 10:00:34 2013 +0100
Commit: Noel Power 
CommitDate: Wed May 22 10:03:26 2013 +0100

fix for bnc#819865 itemstate in parent style incorrectly reported as
set

Problem occurs because attrs set with default values are reported as
set when queried

Change-Id: I89d6c3b09312fb78052d87ff20aa12c6fbe7bc98

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108019] [META] Calc UX bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108019

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||97555


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=97555
[Bug 97555] unsuitable colour feedback when selecting multiple sheet in calc
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97555] unsuitable colour feedback when selecting multiple sheet in calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97555

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||108019


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108019
[Bug 108019] [META] Calc UX bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108019] [META] Calc UX bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108019

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||97551


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=97551
[Bug 97551] add “formula marker” feature like in Quattro Pro
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97551] add “formula marker” feature like in Quattro Pro

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97551

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||108019


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108019
[Bug 108019] [META] Calc UX bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84874] FILESAVE to .xlsx. MS Excel doesn't load spreadsheets with promptTitle longer than 32 characters.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84874

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||88175


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=88175
[Bug 88175] [META] XLSX (OOXML) format limitations
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88175] [META] XLSX (OOXML) format limitations

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88175

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||84874


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=84874
[Bug 84874] FILESAVE to .xlsx. MS Excel doesn't load spreadsheets with
promptTitle longer than 32 characters.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109530] [META] File opening issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109530

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||82984


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=82984
[Bug 82984] FILEOPEN: Error opening XLSX file in zip64 format
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108897] [META] XLSX (OOXML) bug tracker

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108897

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||82984


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=82984
[Bug 82984] FILEOPEN: Error opening XLSX file in zip64 format
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82984] FILEOPEN: Error opening XLSX file in zip64 format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82984

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||108897, 109530
   Keywords||filter:xlsx


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108897
[Bug 108897] [META] XLSX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=109530
[Bug 109530] [META] File opening issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78849] Calc - Make initial sheet tab scroll area longer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78849

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||108019
 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED
 CC||79045_79...@mail.ru

--- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> ---
Now it's already WONTFIX because row with sheet name was moved bottom than
horizontal scrollbar

https://wiki.documentfoundation.org/ReleaseNotes/4.4#Tab_changes


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108019
[Bug 108019] [META] Calc UX bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108019] [META] Calc UX bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108019
Bug 108019 depends on bug 78849, which changed state.

Bug 78849 Summary: Calc - Make initial sheet tab scroll area longer
https://bugs.documentfoundation.org/show_bug.cgi?id=78849

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs