[Libreoffice-bugs] [Bug 124337] Open the PPT file without showing the content of the ppt

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124337

--- Comment #1 from luzuobin  ---
Created attachment 150293
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150293=edit
do not show the content of the ppt

do not show the content of the ppt file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115843] HiDPI images in LibreOffice Writer are blurry with GTK3 backend

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115843

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116520] Fileopen dump for ODT fed from ODS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116520

--- Comment #2 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 33614] Impress [FILEOPEN] did not import double lines from a Powerpoint .ppt correctly.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=33614

--- Comment #18 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116504] PDF export: The empty area in a PDF image is transparent when exporting the PDF, showing table borders hidden below it

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116504

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46892] Provide stacktraces for crashes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46892

Yashasvi Goel  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |yashasvig...@gmail.com
   |desktop.org |

--- Comment #14 from Yashasvi Goel  ---
Starting to Resolve this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101886] Border line style control not a11y accessible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101886

--- Comment #9 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 58125] [UI] Comment marks not hidden when column is hidden

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58125

Ben Elliston  changed:

   What|Removed |Added

   Severity|trivial |minor

--- Comment #13 from Ben Elliston  ---
Still happening in 6.2.0.3. In my case, this problem causes lots of little red
artifacts all over my spreadsheets. I think it's a minor problem, not a trivial
one.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112099] Table borders in DOC or DOCX file render different

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112099

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103903] EMF import distorts propotion of image files (Landscape looks like Portrait)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103903

--- Comment #9 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 68573] FORMATTING:Underline enhancement (see comment 6)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=68573

--- Comment #13 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116622] Inserted EMF image is not cropped correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116622

--- Comment #3 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65685] constant in select list querying a spreadsheet yields blanks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65685

--- Comment #14 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89686] "undo" mess up previous Conditional Format-ranges

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89686

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63025] Copying chart to Writer looses data/ changes diagram type

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=63025

--- Comment #12 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92447] sub-cell text style is removed/misapplied during search/replace

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92447

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 5 commits - desktop/qa desktop/source include/LibreOfficeKit include/vcl vcl/inc vcl/qa vcl/source

[Tomaž Vajngerl (via logerrit)]

 desktop/qa/desktop_lib/test_desktop_lib.cxx  |3 
 desktop/source/lib/init.cxx  |   45 +++
 include/LibreOfficeKit/LibreOfficeKit.h  |9 +
 include/LibreOfficeKit/LibreOfficeKit.hxx|   16 ++
 include/vcl/GestureEvent.hxx |   42 ++
 include/vcl/commandevent.hxx |   25 +++
 include/vcl/svapp.hxx|3 
 include/vcl/vclevent.hxx |1 
 vcl/inc/salwtype.hxx |   14 ++
 vcl/inc/widgetdraw/WidgetDefinition.hxx  |   66 --
 vcl/inc/window.h |1 
 vcl/qa/cppunit/widgetdraw/WidgetDefinitionReaderTest.cxx |   13 +-
 vcl/qa/cppunit/widgetdraw/data/definition1.xml   |8 -
 vcl/source/app/svapp.cxx |   68 +-
 vcl/source/control/imp_listbox.cxx   |4 
 vcl/source/gdi/FileDefinitionWidgetDraw.cxx  |   96 ++-
 vcl/source/gdi/WidgetDefinition.cxx  |   31 +---
 vcl/source/gdi/WidgetDefinitionReader.cxx|   25 ---
 vcl/source/window/commandevent.cxx   |9 +
 vcl/source/window/window.cxx |1 
 vcl/source/window/window2.cxx|   20 +++
 vcl/source/window/winproc.cxx|   44 ++
 22 files changed, 382 insertions(+), 162 deletions(-)

New commits:
commit 5526b0c6776aeb4362b76aa8d0ffd19149f8cd3e
Author: Tomaž Vajngerl 
AuthorDate: Tue Mar 26 21:46:34 2019 +0900
Commit: Tomaž Vajngerl 
CommitDate: Wed Mar 27 11:33:53 2019 +0900

fix build against master

Change-Id: I7ccdbc690d556ecf60ba3a98f67d5de2b0fbf434

diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx
index 5376e2991401..64fc7c40b7d1 100644
--- a/vcl/source/app/svapp.cxx
+++ b/vcl/source/app/svapp.cxx
@@ -898,8 +898,8 @@ ImplSVEvent* Application::PostGestureEvent(VclEventId 
nEvent, vcl::Window* pWin,
 {
 Point aTransformedPosition(pGestureEvent->mnX, pGestureEvent->mnY);
 
-aTransformedPosition.AdjustX(pWin->GetOutOffXPixel());
-aTransformedPosition.AdjustY(pWin->GetOutOffYPixel());
+aTransformedPosition.MoveX(pWin->GetOutOffXPixel());
+aTransformedPosition.MoveY(pWin->GetOutOffYPixel());
 
 const GestureEvent aGestureEvent{
 sal_Int32(aTransformedPosition.X()),
commit 00151d9a31446f5e9b529cacb5bd0e0c469df32e
Author: Tomaž Vajngerl 
AuthorDate: Mon Mar 25 18:23:36 2019 +0900
Commit: Tomaž Vajngerl 
CommitDate: Wed Mar 27 11:33:53 2019 +0900

tdf#124146 support posting of gesture event for LOKit

Reviewed-on: https://gerrit.libreoffice.org/69657
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 
(cherry picked from commit 4a68361d578fe3bf313f80d8e186079bd34b2300)

Change-Id: I51845f2e41dbcbe1ae6cb0a18cf9f42d5549968b

diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index 3bf935275025..691a82bcc4cb 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -2667,9 +2667,10 @@ void DesktopLOKTest::testABI()
 CPPUNIT_ASSERT_EQUAL(documentClassOffset(45), offsetof(struct 
_LibreOfficeKitDocumentClass, getSignatureState));
 CPPUNIT_ASSERT_EQUAL(documentClassOffset(46), offsetof(struct 
_LibreOfficeKitDocumentClass, renderShapeSelection));
 CPPUNIT_ASSERT_EQUAL(documentClassOffset(47), offsetof(struct 
_LibreOfficeKitDocumentClass, createViewWithOptions));
+CPPUNIT_ASSERT_EQUAL(documentClassOffset(48), offsetof(struct 
_LibreOfficeKitDocumentClass, postWindowGestureEvent));
 // Extending is fine, update this, and add new assert for the offsetof the
 // new method
-CPPUNIT_ASSERT_EQUAL(documentClassOffset(48), sizeof(struct 
_LibreOfficeKitDocumentClass));
+CPPUNIT_ASSERT_EQUAL(documentClassOffset(49), sizeof(struct 
_LibreOfficeKitDocumentClass));
 }
 
 CPPUNIT_TEST_SUITE_REGISTRATION(DesktopLOKTest);
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index ee34831af726..1d21b994289d 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -103,6 +103,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -740,6 +741,12 @@ static void doc_postWindowMouseEvent 
(LibreOfficeKitDocument* pThis,
   int nCount,
   int nButtons,
   int nModifier);
+static void doc_postWindowGestureEvent(LibreOfficeKitDocument* pThis,
+  unsigned nLOKWindowId,
+  const char* pType,
+  int nX,
+

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4' - 5 commits - bundled/include kit/ChildSession.cpp kit/ChildSession.hpp loleaflet/src wsd/ClientSession.cpp

[Libreoffice Gerrit user]

 bundled/include/LibreOfficeKit/LibreOfficeKit.h   |9 
 bundled/include/LibreOfficeKit/LibreOfficeKit.hxx |   16 
 kit/ChildSession.cpp  |   44 ++
 kit/ChildSession.hpp  |1 
 loleaflet/src/control/Control.LokDialog.js|   35 +
 wsd/ClientSession.cpp |1 
 6 files changed, 106 insertions(+)

New commits:
commit 8cab62e344198715df11f2f9fffaf79fc331ff0c
Author: Tor Lillqvist 
AuthorDate: Tue Mar 26 18:25:29 2019 +0200
Commit: Tomaž Vajngerl 
CommitDate: Wed Mar 27 11:23:00 2019 +0900

Scroll in correct direction with gesture

It is the combobox contents you are dragging with the gesture, so it
should move in the same direction, not opposite.

(If you would be draging the scrollbar's "thumb", then the contents of
the combobox would indeed move in the other direction. But on a touch
device, it definitely is the contents that the user is dragging.)

Change-Id: I9dc9e3cc7e3a1412176fd1d84c5587c86410d191
(cherry picked from commit d124e3e5aaedd48c7f83f000fcbd682489b45b60)

diff --git a/loleaflet/src/control/Control.LokDialog.js 
b/loleaflet/src/control/Control.LokDialog.js
index a2d90b7ee..7ad6ccade 100644
--- a/loleaflet/src/control/Control.LokDialog.js
+++ b/loleaflet/src/control/Control.LokDialog.js
@@ -687,14 +687,14 @@ L.Control.LokDialog = L.Control.extend({
}
else if (e.type === 'touchend')
{
-   this._postWindowGestureEvent(childId, 'panEnd', 
firstTouchPositionX, firstTouchPositionY, touchY - firstTouchPositionY);
+   this._postWindowGestureEvent(childId, 'panEnd', 
firstTouchPositionX, firstTouchPositionY, firstTouchPositionY - touchY);
firstTouchPositionX = null;
firstTouchPositionY = null;
 
}
else if (e.type === 'touchmove')
{
-   this._postWindowGestureEvent(childId, 
'panUpdate', firstTouchPositionX, firstTouchPositionY, touchY - 
firstTouchPositionY);
+   this._postWindowGestureEvent(childId, 
'panUpdate', firstTouchPositionX, firstTouchPositionY, firstTouchPositionY - 
touchY);
}
}, this);
 
commit 898fa8551e061fff0fb420939a481e5155bf6d83
Author: Tor Lillqvist 
AuthorDate: Tue Mar 26 18:01:16 2019 +0200
Commit: Tomaž Vajngerl 
CommitDate: Wed Mar 27 11:22:25 2019 +0900

Update to match core master

Change-Id: I8932f9ea8ebd1addd9679f2f325b4dbafa48578c
(cherry picked from commit d0186aadee756882cf77fc5366b3298731c40923)

diff --git a/bundled/include/LibreOfficeKit/LibreOfficeKit.h 
b/bundled/include/LibreOfficeKit/LibreOfficeKit.h
index fe1b25bc3..b694dc522 100644
--- a/bundled/include/LibreOfficeKit/LibreOfficeKit.h
+++ b/bundled/include/LibreOfficeKit/LibreOfficeKit.h
@@ -356,6 +356,7 @@ struct _LibreOfficeKitDocumentClass
 
 /// @see lok::Document::getSignatureState().
 int (*getSignatureState) (LibreOfficeKitDocument* pThis);
+// END CERTIFICATE AND SIGNING
 
 /// @see lok::Document::renderShapeSelection
 size_t (*renderShapeSelection)(LibreOfficeKitDocument* pThis, char** 
pOutput);
@@ -363,6 +364,14 @@ struct _LibreOfficeKitDocumentClass
 /// @see lok::Document::createViewWithOptions().
 int (*createViewWithOptions) (LibreOfficeKitDocument* pThis, const char* 
pOptions);
 
+/// @see lok::Document::postWindowGestureEvent().
+void (*postWindowGestureEvent) (LibreOfficeKitDocument* pThis,
+  unsigned nWindowId,
+  const char* pType,
+  int nX,
+  int nY,
+  int nOffset);
+
 #endif // defined LOK_USE_UNSTABLE_API || defined LIBO_INTERNAL_ONLY
 };
 
diff --git a/bundled/include/LibreOfficeKit/LibreOfficeKit.hxx 
b/bundled/include/LibreOfficeKit/LibreOfficeKit.hxx
index 72824be0f..f2163cd1f 100644
--- a/bundled/include/LibreOfficeKit/LibreOfficeKit.hxx
+++ b/bundled/include/LibreOfficeKit/LibreOfficeKit.hxx
@@ -633,6 +633,22 @@ public:
 return mpDoc->pClass->renderShapeSelection(mpDoc, pOutput);
 }
 
+/**
+ * Posts a gesture event to the window with given id.
+ *
+ * @param nWindowId
+ * @param pType Event type, like panStart, panEnd, panUpdate.
+ * @param nX horizontal position in document coordinates
+ * @param nY vertical position in document coordinates
+ * @param nOffset difference value from when the gesture started to 
current value
+ */
+void postWindowGestureEvent(unsigned nWindowId,
+  const char* pType,
+  int nX, int 

[Libreoffice-bugs] [Bug 58492] EDITING: TEXT BOX by default do not let modify align options.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58492

Phillip  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |---
 Status|RESOLVED|REOPENED

--- Comment #12 from Phillip  ---
I really think this bug still needs to be addressed. The instructions in the
first post still replicate the bug in version 6.2.2.2.

Steps to reproduce, creates a text box with the bug:
1. Create a new Draw file
2. Click on the "Insert Text Box" button
3. Single-click on the page to create text box
4. Type the word "center"
5. Single-click outside of the text box
6. Using mouse, increase the size of the text box
7. Align-center and Align-right have no apparent effect


Steps to create a text box that does work:
1. Create a new Draw file
2. Click on the "Insert Text Box" button
3. Click-and-drag to create text box
4. Type the word "center"
5. CTRL-E for align-center
6. The text becomes centered within the text box


This bug has been opened and closed several times, so I'm going to include
significant detail here to justify why this is actually a bug. 

In Bug 41084 comment 3, Rainer Bielefeld wrote, "If you increase size of
textbox after you have typed some text using Menu 'Format -> Position and
size', "Full Width" will remain unchecked, you can not use Text Alignment
icons." Unfortunately, this is not correct. 

Both boxes have "Full Width" checked:
1. Create a new Draw file
2. Create a text box that exhibits the bug (use instructions above)
3. Create a text box that works normally (use instructions above)
4. Right-click on the first box, select "Edit style". Note that "Full width" is
checked.
5. Right-click on the second box, select "Edit style". Note that "Full width"
is checked.

After the two boxes have been created, I have yet to find a combination of
settings that will make the text behave in the same way in both boxes. 

In Comment 9 on this page, Regina Henschel describes a way to justify the
current behavior as not a bug. If the user types "This is a very long line" on
the first line, and then types "short" on the second line, then "short" will be
centered underneath the longer line. However, the longer line is *not* centered
in the text box, which is most likely the user intention. 

Steps to replicate:
1. Create a new Draw file
2. Click on the "Insert Text Box" button
3. Single-click on the page to create text box
4. Type "This is a very long long line"
5. Press  to add a line
6. Type "short" on the second line
7. Using mouse, increase the size of the text box
8. Notice that the text in the second line does move when Align-center and
Align-right are selected. However, the longer line remains stationary. 

Left-justified looks like this:
This is a very long long line
short

Right-justified looks like this:
This is a very long long line
short

But in both cases, the long line still appears to be left-justified compared to
the entire text box.


Here's another bug I found messing around with this that is probably related.
When changing the "Full width" check box of one text box, it also changes the
status of a different text box. 


1. Click-and-drag to create a text box
2. Type "Number 1"
3. Right-click on the text box and select "Edit Style"
4. Un-check the "Full width" check box.
5. Notice that the text now appears to be centered within the text box
6. Click-and-drag to create another text box 
7. Type "Number 2"
8. Right-click on the second text box and select "Edit Style"
9. Check the "Full width" check box
10. Select "OK"
11. Notice that the text in box1 and box2 now appear left justified

Perhaps this is the intended behavior and "Full width" is meant to be a global
setting rather than a per-text-box setting. If that's the case, then there's
still a bug because a text box created with click-and-type is not affected by
the global setting!

1. Create a text box using click-and-drag and call it "Number 1". 
2. Uncheck "Full width"
3. Select Right-aligned on the first text box
4. Create another text box using click-and-drag and call it "Number 2".
5. Create a third text bux using single-click, then type, call it "Number 3"
6. Now make the text box of Number 3 larger.
7. Check "Full width"
8. Note that Number 1 moves to the right edge of it's text box, Number 2 moves
to the left edge, and nothing happens to number 3.
9. Uncheck "Full width"
10. Note that Number 1 becomes centered in the text box, Number 2 becomes
centered in the text box, and nothing happens to number 3. 

Basically, there are two different behaviors for text boxes depending on how
they are created. That must be a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org

[Libreoffice-bugs] [Bug 103494] [META] Textbox bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103494
Bug 103494 depends on bug 58492, which changed state.

Bug 58492 Summary: EDITING: TEXT BOX by default do not let modify align options.
https://bugs.documentfoundation.org/show_bug.cgi?id=58492

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/lhm/fsdfsdfsdf' - 0 commits -

[(via logerrit)]

Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 50916] Allow more than 1024 columns in calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=50916

--- Comment #74 from Shunesburg69  ---
The fix is it already in progress?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 40436] Custom colours in Math

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=40436

--- Comment #16 from Shunesburg69  ---
Some news ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Changes to 'distro/lhm/fsdfsdfsdf'

[Eike Rathke (via logerrit)]

New branch 'distro/lhm/fsdfsdfsdf' available with the following commits:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124029] FILEOPEN: MS Office 97. Shape 'arc' from binary MS Office has wrong position

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124029

Regina Henschel  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |rb.hensc...@t-online.de
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124333] Fileopen: Wrong ZOrder of OLE object imported from PPTX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124333

--- Comment #2 from Ofir  ---
Created attachment 150292
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150292=edit
PDF exported from PowerPoint 2013 showing the expected result

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107977] [META] Calc feature enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107977
Bug 107977 depends on bug 74664, which changed state.

Bug 74664 Summary: Data Analysis Toolkit - Fourier Analysis
https://bugs.documentfoundation.org/show_bug.cgi?id=74664

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124333] Fileopen: Wrong ZOrder of OLE object imported from PPTX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124333

--- Comment #1 from Ofir  ---
Created attachment 150291
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150291=edit
PPTX with OLE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45705] Cant assign shortcuts to "Zoom in" and "Zoom out" commands

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45705

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=82
   ||679
 CC||vstuart.fo...@utsa.edu

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82679] Add shortcut keys / hotkeys to set zoom level?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82679

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=45
   ||705

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45705] Cant assign shortcuts to "Zoom in" and "Zoom out" commands

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45705

V Stuart Foote  changed:

   What|Removed |Added

 CC||b...@air.net.au

--- Comment #28 from V Stuart Foote  ---
*** Bug 124331 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124331] Make Ctrl +/- hotkeys for zoom in/out

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124331

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE
 CC||vstuart.fo...@utsa.edu

--- Comment #1 from V Stuart Foote  ---


*** This bug has been marked as a duplicate of bug 45705 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124258] Groupedbar on LibreOffice Draw 6.2.2.2 release

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124258

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
Version|6.2.2.2 release |6.2.2.1 rc

--- Comment #6 from Roman Kuznetsov <79045_79...@mail.ru> ---
repro in 

Версия: 6.2.2.1 (x64)
ID сборки: fcd633fb1bf21b0a99c9acb3ad6e526437947b01
Потоков ЦП: 4; ОС:Windows 10.0; Отрисовка ИП: GL; VCL: win; 
Локаль: ru-RU (ru_RU); Язык UI: ru-RU
Calc: threaded

I tried delete my user profile, there is a bug anyway

may be only Windows 10 problem?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103100

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||124321


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=124321
[Bug 124321] Sluggish scrolling and high CPU while scrolling for document with
(very) large table (7183 row)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124321] Sluggish scrolling and high CPU while scrolling for document with (very) large table (7183 row)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124321

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
 Ever confirmed|0   |1
Version|6.3.0.0.alpha0+ Master  |4.4.7.2 release
 Blocks||108075, 103100
 Status|UNCONFIRMED |NEW

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
repro in 6.3 and in 4.4.7.2 too

but when I unzip the odt file I get error from 7-zip like "Error in headers"

may be odt file is brocken?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103100
[Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=108075
[Bug 108075] [META] Scrolling and Page up/down issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108075] [META] Scrolling and Page up/down issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108075

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||124321


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=124321
[Bug 124321] Sluggish scrolling and high CPU while scrolling for document with
(very) large table (7183 row)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124332] Copied text from another app is shown as "; ; ; " when pasted into spreadsheet cell.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124332

--- Comment #2 from eriks...@gmail.com ---
Build ID: 98c6a8a1c6c7b144ce3cc729e34964b47ce25d62

After restart in Safe Mode: Pasting copied text in cell. Gets the following
result in cell: ";;[copied text]". Bug still there, but different.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124326] Undo after drag changes the original formula

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124326

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
 Blocks||114220, 108253
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> ---
repro in

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 5a907fe76bc628629fddb5501727642468d38dae
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-03-22_00:18:04
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108253
[Bug 108253] [META] Calc cell formula bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114220
[Bug 114220] [META] Drag and drop bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108253] [META] Calc cell formula bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108253

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||124326


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=124326
[Bug 124326] Undo after drag changes the original formula
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123484] LibreOffice 6.2 shows duplicated items on the main top bar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123484

--- Comment #5 from Peter Sewell  ---
I've also got this problem even after updating to v.6.2.2.2

Ubuntu 16.04LTS

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114220] [META] Drag and drop bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114220

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||124326


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=124326
[Bug 124326] Undo after drag changes the original formula
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123484] LibreOffice 6.2 shows duplicated items on the main top bar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123484

--- Comment #4 from Peter Sewell  ---
Created attachment 150290
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150290=edit
Writer showing duplicate top menu bars

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102593

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||124332


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=124332
[Bug 124332] Copied text from another app is shown as ";;;" when pasted into
spreadsheet cell.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124332] Copied text from another app is shown as "; ; ; " when pasted into spreadsheet cell.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124332

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||102593
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
PLease add info from dialog Help->About LibreOffice

And try reset your user profile uses Help->Restart in Safe mode


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102593
[Bug 102593] [META] Paste bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123944] EDITING: LO stops working for several minutes when editing Forms

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123944

--- Comment #8 from Tim  ---
In safe mode it seemed to happen the same. I would need more time to test it
once more. Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120865] KDE5: Can't move down field to see text with breaks in LO Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120865

Katarina Behrens (CIB)  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |katarina.behr...@cib.de
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - external/more_fonts

[Andras Timar (via logerrit)]

 external/more_fonts/Module_more_fonts.mk |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit e1e29426576af9f709ec2e1753c280a32c3a49bc
Author: Andras Timar 
AuthorDate: Tue Mar 26 23:02:31 2019 +0100
Commit: Andras Timar 
CommitDate: Tue Mar 26 23:14:58 2019 +0100

Do not include KACST fonts (GPLv2) into MPL subset

Change-Id: I0ed447dcbafb605f81c6b8c34fa2a1e5ec4bd9b8

diff --git a/external/more_fonts/Module_more_fonts.mk 
b/external/more_fonts/Module_more_fonts.mk
index 57bf4548783a..d708414f494e 100644
--- a/external/more_fonts/Module_more_fonts.mk
+++ b/external/more_fonts/Module_more_fonts.mk
@@ -17,7 +17,7 @@ $(eval $(call gb_Module_add_targets,more_fonts,\
$(if $(MPL_SUBSET),,ExternalPackage_culmus) \
ExternalPackage_dejavu \
ExternalPackage_gentium \
-   ExternalPackage_kacst \
+   $(if $(MPL_SUBSET),,ExternalPackage_kacst) \
ExternalPackage_karla \
ExternalPackage_liberation \
ExternalPackage_liberation_narrow \
@@ -36,7 +36,7 @@ $(eval $(call gb_Module_add_targets,more_fonts,\
$(if $(MPL_SUBSET),,UnpackedTarball_culmus) \
UnpackedTarball_dejavu \
UnpackedTarball_gentium \
-   UnpackedTarball_kacst \
+   $(if $(MPL_SUBSET),,UnpackedTarball_kacst) \
UnpackedTarball_karla \
UnpackedTarball_liberation \
UnpackedTarball_liberation_narrow \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sfx2/source

[Tamás Zolnai (via logerrit)]

 sfx2/source/appl/appdde.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 5cb2db6dd7d234a610a6501668a9901af8472b7f
Author: Tamás Zolnai 
AuthorDate: Mon Mar 25 18:11:47 2019 +0100
Commit: Tamás Zolnai 
CommitDate: Tue Mar 26 22:34:41 2019 +0100

Fix Windows build.

Change-Id: I7a8c5f16ec4ee17ec491229c7c15f9571d763d5c
Reviewed-on: https://gerrit.libreoffice.org/69710
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai 

diff --git a/sfx2/source/appl/appdde.cxx b/sfx2/source/appl/appdde.cxx
index ac556afa7f42..e405bf3635a8 100644
--- a/sfx2/source/appl/appdde.cxx
+++ b/sfx2/source/appl/appdde.cxx
@@ -43,6 +43,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

[Caolán McNamara (via logerrit)]

 vcl/source/control/edit.cxx |   10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

New commits:
commit 8622dc09954a1a26661e3524c99e7ed0f456cf6e
Author: Caolán McNamara 
AuthorDate: Tue Mar 26 15:57:46 2019 +
Commit: Caolán McNamara 
CommitDate: Tue Mar 26 22:14:30 2019 +0100

Related: tdf#123291 treat overwrite like a selection of 1

for input into ImplTruncateToMaxLen like we do for the
following erase

Change-Id: I8cd02ff1ba76f61ddc614922068cbe2bc9bc4cb8
Reviewed-on: https://gerrit.libreoffice.org/69763
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/source/control/edit.cxx b/vcl/source/control/edit.cxx
index 72325742cac3..a4302902a3c8 100644
--- a/vcl/source/control/edit.cxx
+++ b/vcl/source/control/edit.cxx
@@ -793,13 +793,19 @@ void Edit::ImplInsertText( const OUString& rStr, const 
Selection* pNewSel, bool
 aSelection.Justify();
 
 OUString aNewText( ImplGetValidString( rStr ) );
-ImplTruncateToMaxLen( aNewText, aSelection.Len() );
+
+// as below, if there's no selection, but we're in overwrite mode and not 
beyond
+// the end of the existing text then that's like a selection of 1
+auto nSelectionLen = aSelection.Len();
+if (!nSelectionLen && !mbInsertMode && aSelection.Max() < 
maText.getLength())
+nSelectionLen = 1;
+ImplTruncateToMaxLen( aNewText, nSelectionLen );
 
 ImplClearLayoutData();
 
 if ( aSelection.Len() )
 maText.remove( static_cast(aSelection.Min()), 
static_cast(aSelection.Len()) );
-else if ( !mbInsertMode && (aSelection.Max() < maText.getLength()) )
+else if (!mbInsertMode && aSelection.Max() < maText.getLength())
 maText.remove( static_cast(aSelection.Max()), 1 );
 
 // take care of input-sequence-checking now
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

[Caolán McNamara (via logerrit)]

 vcl/source/control/edit.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit 2f70e6111b61d52bbdfa753257370cb82bfd30eb
Author: Caolán McNamara 
AuthorDate: Tue Mar 26 15:39:32 2019 +
Commit: Caolán McNamara 
CommitDate: Tue Mar 26 22:12:22 2019 +0100

support overwrite-mode

Change-Id: I6133aedbebd3ca358e2b916469873c38fc7453cb
Reviewed-on: https://gerrit.libreoffice.org/69761
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/source/control/edit.cxx b/vcl/source/control/edit.cxx
index d9d9d3d9730d..72325742cac3 100644
--- a/vcl/source/control/edit.cxx
+++ b/vcl/source/control/edit.cxx
@@ -195,6 +195,10 @@ bool Edit::set_property(const OString , const 
OUString )
 {
 SetReadOnly(!toBool(rValue));
 }
+else if (rKey == "overwrite-mode")
+{
+SetInsertMode(!toBool(rValue));
+}
 else if (rKey == "visibility")
 {
 mbPassword = false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: readlicense_oo/license

[Andras Timar (via logerrit)]

 readlicense_oo/license/license.xml |   36 +---
 1 file changed, 21 insertions(+), 15 deletions(-)

New commits:
commit c526689112976d87ec7c974c14611f628ce1051d
Author: Andras Timar 
AuthorDate: Tue Mar 26 14:22:42 2019 +0100
Commit: Andras Timar 
CommitDate: Tue Mar 26 21:33:27 2019 +0100

license: add conditions for bundled extensions

Change-Id: Ia7f8b463491284c87ac90f6778e0bc6786e77713
Reviewed-on: https://gerrit.libreoffice.org/69754
Tested-by: Jenkins
Reviewed-by: Andras Timar 

diff --git a/readlicense_oo/license/license.xml 
b/readlicense_oo/license/license.xml
index 144d4af8b8f6..9c9713a94db8 100644
--- a/readlicense_oo/license/license.xml
+++ b/readlicense_oo/license/license.xml
@@ -2060,16 +2060,20 @@
 
 Extensions
 Only third party extensions are listed here whose source code is not in 
the LibreOffice tree.
-Convert Text to Number
-The following software may be included in this product: Convert Text to 
Number. Use of any of this software is
-governed by the terms of the license below:
-Copyright (C) 2008/2009 - Cor Nouws
-Jump to LGPL Version 3
-LanguageTool Grammar Checker
-The following software may be included in this product: LanguageTool 
Grammar Checker. Use of any of this
-software is governed by the terms of the license below:
-Jump to LGPL Version 3
-
+
+Convert Text to Number
+The following software may be included in this product: Convert 
Text to Number. Use of any of this software is
+governed by the terms of the license below:
+Copyright (C) 2008/2009 - Cor Nouws
+Jump to LGPL Version 3
+
+
+LanguageTool Grammar Checker
+The following software may be included in this product: 
LanguageTool Grammar Checker. Use of any of this
+software is governed by the terms of the license below:
+Jump to LGPL Version 3
+
+
 Numbertext
 The following software may be included in this product: Numbertext. 
Use of any of this software is governed
 by the terms of the license below:
@@ -2084,11 +2088,13 @@
 either express or implied.
 Jump to LGPL Version 3
 
-Solver for Nonlinear Programming
-The following software may be included in this product: Solver for 
Nonlinear Programming. Use of any of this
-software is governed by the terms of the license below:
-Copyright 2009 by Sun Microsystems, Inc.
-Jump to LGPL Version 3
+
+Solver for Nonlinear Programming
+The following software may be included in this product: Solver for 
Nonlinear Programming. Use of any of this
+software is governed by the terms of the license below:
+Copyright 2009 by Sun Microsystems, Inc.
+Jump to LGPL Version 3
+
 
 
 Fonts
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: readlicense_oo/license

[Andras Timar (via logerrit)]

 readlicense_oo/license/license.xml |  679 ++---
 1 file changed, 264 insertions(+), 415 deletions(-)

New commits:
commit 04f83797552fabb6b9fcfa4400de08558b0836bc
Author: Andras Timar 
AuthorDate: Tue Mar 26 12:37:51 2019 +0100
Commit: Andras Timar 
CommitDate: Tue Mar 26 21:32:39 2019 +0100

license: include LPPL only when there are dictionaries (+ re-formatted text)

Change-Id: I835c65e04b25a12dd107cbcfbde30f8f5447e0ea
Reviewed-on: https://gerrit.libreoffice.org/69753
Tested-by: Jenkins
Reviewed-by: Andras Timar 

diff --git a/readlicense_oo/license/license.xml 
b/readlicense_oo/license/license.xml
index 1b820b6a5566..144d4af8b8f6 100644
--- a/readlicense_oo/license/license.xml
+++ b/readlicense_oo/license/license.xml
@@ -44,7 +44,9 @@
 Mozilla Public License Version 2.0
 SIL Open Font License 
Version 1.1
 Apache License
-The LaTeX Project Public License
+
+The LaTeX Project Public License
+
 Creative Commons Attribution-ShareAlike 3.0 
Unported
  
 
@@ -5890,420 +5892,267 @@ under either the MPL or the [___] License."
    See the License for the specific language governing permissions 
and
    limitations under the License.
 
-The LaTeX Project Public 
License
- 
-LPPL Version 1.3c  2008-05-04
- 
-Copyright 1999 2002-2008 LaTeX3 Project
-    Everyone is allowed to distribute verbatim copies of this
-    license document, but modification of it is not allowed.
- 
- 
-PREAMBLE
-
- 
-The LaTeX Project Public License (LPPL) is the primary license under
-which the LaTeX kernel and the base LaTeX packages are distributed.
- 
-You may use this license for any work of which you hold the 
copyright
-and which you wish to distribute.  This license may be particularly
-suitable if your work is TeX-related (such as a LaTeX package), but
-it is written in such a way that you can use it even if your work is
-unrelated to TeX.
- 
-The section `WHETHER AND HOW TO DISTRIBUTE WORKS UNDER THIS 
LICENSE',
-below, gives instructions, examples, and recommendations for authors
-who are considering distributing their works under this license.
- 
-This license gives conditions under which a work may be distributed
-and modified, as well as conditions under which modified versions of
-that work may be distributed.
- 
-We, the LaTeX3 Project, believe that the conditions below give you
-the freedom to make and distribute modified versions of your work
-that conform with whatever technical specifications you wish while
-maintaining the availability, integrity, and reliability of
-that work.  If you do not see how to achieve your goal while
-meeting these conditions, then read the document `cfgguide.tex'
-and `modguide.tex' in the base LaTeX distribution for suggestions.
- 
- 
-DEFINITIONS
-===
- 
-In this license document the following terms are used:
- 
-   `Work'
-    Any work being distributed under this License.
-   
-   `Derived Work'
-    Any work that under any applicable law is derived from the Work.
- 
-   `Modification'
-    Any procedure that produces a Derived Work under any applicable
-    law -- for example, the production of a file containing an
-    original file associated with the Work or a significant portion 
of
-    such a file, either verbatim or with modifications and/or
-    translated into another language.
- 
-   `Modify'
-    To apply any procedure that produces a Derived Work under any
-    applicable law.
-   
-   `Distribution'
-    Making copies of the Work available from one person to another, 
in
-    whole or in part.  Distribution includes (but is not limited to)
-    making any electronic components of the Work accessible by
-    file transfer protocols such as FTP or HTTP or by shared file
-    systems such as Sun's Network File System (NFS).
- 
-   `Compiled Work'
-    A version of the Work that has been processed into a form where 
it
-    is directly usable on a computer system.  This processing may
-    include using installation facilities provided by the Work,
-    transformations of the Work, copying of components of the Work, 
or
-    other activities.  Note that modification of any installation
-    facilities provided by the Work constitutes modification of the 
Work.
- 
-   `Current Maintainer'
-    A person or persons nominated as such within the Work.  If there 
is
-    no such explicit nomination then it is the `Copyright Holder' 
under
-    any applicable law.
- 
-   `Base Interpreter'
-    A program or process that is normally needed for running or
-    interpreting a part or the whole of the Work.    
- 
-    

[Libreoffice-commits] core.git: readlicense_oo/license

[Andras Timar (via logerrit)]

 readlicense_oo/license/license.xml |  153 +
 1 file changed, 153 insertions(+)

New commits:
commit 5d5eedf693a9c73bd230b36edb7a978bc50095e4
Author: Andras Timar 
AuthorDate: Tue Mar 26 12:26:15 2019 +0100
Commit: Andras Timar 
CommitDate: Tue Mar 26 21:32:19 2019 +0100

license: add CoinMP (and Common Public License 1.0)

Change-Id: I90fabd90c96f64d6dbe0175fe0d077095a22bd2e
Reviewed-on: https://gerrit.libreoffice.org/69752
Tested-by: Jenkins
Reviewed-by: Andras Timar 

diff --git a/readlicense_oo/license/license.xml 
b/readlicense_oo/license/license.xml
index 33ab519ff718..1b820b6a5566 100644
--- a/readlicense_oo/license/license.xml
+++ b/readlicense_oo/license/license.xml
@@ -37,6 +37,9 @@
 GNU General Public License Version 
3
 GNU General Public License Version 
2
 
+
+Common Public License Version 1.0 
(CPL)
+
 Mozilla Public License Version 1.1
 Mozilla Public License Version 2.0
 SIL Open Font License 
Version 1.1
@@ -207,6 +210,12 @@
 Jump to LGPL Version 2.1
 Jump to Apache License 
Version 2.0
 
+
+CoinMP
+The following software may be included in this product: CoinMP. Use 
of any of this software is governed by
+the terms of the license below:
+Jump to Common Public License Version 
1.0 (CPL)
+
 
 Epoxy
 The following software may be included in this product: epoxy.
@@ -4983,6 +4992,150 @@ Ty Coon, President of Vice
 Lesser General Public License instead of this License.
 
 
+
+Common Public 
License Version 1.0 (CPL)
+THE ACCOMPANYING PROGRAM IS PROVIDED UNDER THE TERMS OF THIS 
COMMON PUBLIC LICENSE ("AGREEMENT"). ANY
+USE, REPRODUCTION OR DISTRIBUTION OF THE PROGRAM CONSTITUTES 
RECIPIENT'S ACCEPTANCE OF THIS AGREEMENT.
+1. DEFINITIONS
+"Contribution" means:
+
+a) in the case of the initial Contributor, the initial code 
and documentation distributed under this
+Agreement, and
+b) in the case of each subsequent Contributor:
+i) changes to the Program, and
+ii) additions to the Program;
+where such changes and/or additions to the Program 
originate from and are distributed by that
+particular Contributor. A Contribution 'originates' from a 
Contributor if it was added to the Program by
+such Contributor itself or anyone acting on such Contributor's 
behalf. Contributions do not include
+additions to the Program which: (i) are separate modules of 
software distributed in conjunction with the
+Program under their own license agreement, and (ii) are not 
derivative works of the Program.
+
+"Contributor" means any person or entity that distributes the 
Program.
+"Licensed Patents " mean patent claims licensable by a 
Contributor which are necessarily infringed by
+the use or sale of its Contribution alone or when combined with the 
Program.
+"Program" means the Contributions distributed in accordance 
with this Agreement.
+"Recipient" means anyone who receives the Program under this 
Agreement, including all
+Contributors.
+2. GRANT OF RIGHTS
+
+a) Subject to the terms of this Agreement, each Contributor 
hereby grants Recipient a non-exclusive,
+worldwide, royalty-free copyright license to reproduce, prepare 
derivative works of, publicly display,
+publicly perform, distribute and sublicense the Contribution of 
such Contributor, if any, and such
+derivative works, in source code and object code form.
+b) Subject to the terms of this Agreement, each Contributor 
hereby grants Recipient a non-exclusive,
+worldwide, royalty-free patent license under Licensed Patents to 
make, use, sell, offer to sell, import and
+otherwise transfer the Contribution of such Contributor, if any, 
in source code and object code form. This
+patent license shall apply to the combination of the Contribution 
and the Program if, at the time the
+Contribution is added by the Contributor, such addition of the 
Contribution causes such combination to be
+covered by the Licensed Patents. The patent license shall not 
apply to any other combinations which include
+the Contribution. No hardware per se is licensed 
hereunder.
+c) Recipient understands that although each Contributor 
grants the licenses to its Contributions set
+forth herein, no assurances are provided by any Contributor that 
the Program does not infringe the patent
+or other intellectual property rights of any other entity. Each 
Contributor disclaims any liability to
+Recipient for claims brought by any other entity based on 

[Libreoffice-commits] core.git: readlicense_oo/license

[Andras Timar (via logerrit)]

 readlicense_oo/license/license.xml |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit 80107e6168a86b6735a47f28234e7348d2d56a54
Author: Andras Timar 
AuthorDate: Tue Mar 26 12:07:21 2019 +0100
Commit: Andras Timar 
CommitDate: Tue Mar 26 21:31:48 2019 +0100

license: add libabw

Change-Id: I352b076533b7ea30c3fb33deaa89cfe5036cb08a
Reviewed-on: https://gerrit.libreoffice.org/69751
Tested-by: Jenkins
Reviewed-by: Andras Timar 

diff --git a/readlicense_oo/license/license.xml 
b/readlicense_oo/license/license.xml
index ff18817bac47..33ab519ff718 100644
--- a/readlicense_oo/license/license.xml
+++ b/readlicense_oo/license/license.xml
@@ -579,6 +579,12 @@
 the copyright holder.
 All trademarks and registered trademarks mentioned herein are the 
property of their respective owners.
 
+
+libabw
+The following software may be included in this product: libabw. Use 
of any of this software is governed
+by the terms of the license below:
+Jump to MPL Version 2.0
+
 
 libatomic_ops
 The following software may be included in this product: 
libatomic_ops. Use of any of this software is
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: external/more_fonts

[Andras Timar (via logerrit)]

 external/more_fonts/Module_more_fonts.mk |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 1bca86cc672c9c7870bbdc92bec619be13447867
Author: Andras Timar 
AuthorDate: Tue Mar 26 15:07:50 2019 +0100
Commit: Andras Timar 
CommitDate: Tue Mar 26 21:31:11 2019 +0100

Do not include Culmus fonts (GPLv2) into MPL subset

Change-Id: I8de0e8e91d785d51b65ce884caddcc05d86bd47d
Reviewed-on: https://gerrit.libreoffice.org/69755
Tested-by: Jenkins
Reviewed-by: Andras Timar 

diff --git a/external/more_fonts/Module_more_fonts.mk 
b/external/more_fonts/Module_more_fonts.mk
index c3d5631ae689..c514b0d3d249 100644
--- a/external/more_fonts/Module_more_fonts.mk
+++ b/external/more_fonts/Module_more_fonts.mk
@@ -14,7 +14,7 @@ $(eval $(call gb_Module_add_targets,more_fonts,\
ExternalPackage_amiri \
ExternalPackage_caladea \
ExternalPackage_carlito \
-   ExternalPackage_culmus \
+   $(if $(MPL_SUBSET),,ExternalPackage_culmus) \
ExternalPackage_dejavu \
ExternalPackage_gentium \
ExternalPackage_kacst \
@@ -33,7 +33,7 @@ $(eval $(call gb_Module_add_targets,more_fonts,\
UnpackedTarball_amiri \
UnpackedTarball_caladea \
UnpackedTarball_carlito \
-   UnpackedTarball_culmus \
+   $(if $(MPL_SUBSET),,UnpackedTarball_culmus) \
UnpackedTarball_dejavu \
UnpackedTarball_gentium \
UnpackedTarball_kacst \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sc/uiconfig sd/uiconfig sw/uiconfig

[Thorsten Behrens (via logerrit)]

 sc/uiconfig/scalc/ui/notebookbar.ui   |8 
 sc/uiconfig/scalc/ui/notebookbar_compact.ui   |   16 -
 sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui|8 
 sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui   |   24 --
 sd/uiconfig/sdraw/ui/notebookbar.ui   |8 
 sd/uiconfig/sdraw/ui/notebookbar_groupedbar_compact.ui|8 
 sd/uiconfig/simpress/ui/notebookbar.ui|8 
 sd/uiconfig/simpress/ui/notebookbar_groupedbar_compact.ui |8 
 sd/uiconfig/simpress/ui/notebookbar_groupedbar_full.ui|   24 --
 sw/uiconfig/swriter/ui/notebookbar.ui |8 
 sw/uiconfig/swriter/ui/notebookbar_compact.ui |8 
 sw/uiconfig/swriter/ui/notebookbar_groupedbar_compact.ui  |8 
 sw/uiconfig/swriter/ui/notebookbar_groupedbar_full.ui |   16 -
 13 files changed, 152 deletions(-)

New commits:
commit 4b46adb58e843dacc0e5448fb1e598ed97c89e93
Author: Thorsten Behrens 
AuthorDate: Tue Mar 26 11:56:40 2019 +0100
Commit: Katarina Behrens 
CommitDate: Tue Mar 26 20:06:01 2019 +0100

tdf#122989 remove update check from notebookbar for the moment

Temp fix, since update check is an extension, and extensions can't
currently modify notebookbars.

This needs implementation of something like

https://wiki.openoffice.org/wiki/Framework/Article/Addon_Menu_Toolbar_Merging
for notebookbar popup menus. Such that Addons.xcs provide some merge
points with notebookbar menu IDs, we can then plug into existing popup
menus.

Change-Id: If30525fec1e7be0429e351588614618c5f56cdd4
Reviewed-on: https://gerrit.libreoffice.org/69735
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit 98174e163348ab44461f114142bc546e97720eec)
Reviewed-on: https://gerrit.libreoffice.org/69741
Reviewed-by: Katarina Behrens 
Tested-by: Katarina Behrens 

diff --git a/sc/uiconfig/scalc/ui/notebookbar.ui 
b/sc/uiconfig/scalc/ui/notebookbar.ui
index adeb29754cde..4d33af24f753 100644
--- a/sc/uiconfig/scalc/ui/notebookbar.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar.ui
@@ -779,14 +779,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
diff --git a/sc/uiconfig/scalc/ui/notebookbar_compact.ui 
b/sc/uiconfig/scalc/ui/notebookbar_compact.ui
index ac6e9c0f97d9..1301829c7932 100644
--- a/sc/uiconfig/scalc/ui/notebookbar_compact.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar_compact.ui
@@ -850,14 +850,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
@@ -1671,14 +1663,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
diff --git a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui 
b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui
index 836a1486898d..de5f1aff5f16 100644
--- a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui
@@ -2493,14 +2493,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for 
Updates...
-  
-
-
   
 True
 False
diff --git a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui 
b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui
index 2711a049b315..6f8d64726a1c 100644
--- a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui
@@ -1748,14 +1748,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
@@ -2455,14 +2447,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
@@ -2880,14 +2864,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
diff --git a/sd/uiconfig/sdraw/ui/notebookbar.ui 
b/sd/uiconfig/sdraw/ui/notebookbar.ui
index 95ac1e833e58..f3d9aff2aaf1 100644
--- a/sd/uiconfig/sdraw/ui/notebookbar.ui
+++ b/sd/uiconfig/sdraw/ui/notebookbar.ui
@@ -764,14 +764,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
diff --git 

Re: LibreOffice Build failed in cppunit test for complex text

[Lars Meyer]

Hi Miklos

Am 26.03.19 um 15:14 schrieb Miklos Vajna:
> Hi,
>
> On Tue, Mar 26, 2019 at 03:07:52PM +0100, Lars Meyer  
> wrote:
>> VclComplexTextTest::testKashida finished in: 14ms
>> complextext.cxx:153:Assertion
> See if commit 3189d366497419d637042c12824601590542b2f1 helps.

thanks, it works.

Kind regards,
Lars


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sc/qa

[Dennis Francis (via logerrit)]

 sc/qa/unit/parallelism.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0347931fd5d9acbdbbdff88a7b8cc5eaf4fed759
Author: Dennis Francis 
AuthorDate: Tue Mar 26 18:10:35 2019 +0530
Commit: Dennis Francis 
CommitDate: Tue Mar 26 19:53:01 2019 +0100

scale down the load in ScParallelismTest::testVLOOKUPSUM...

since this method alone takes around 8 minutes in a dbgutil build.

Change-Id: I573545446bd42b7a614d8f5b2d6061c3ec157271
Reviewed-on: https://gerrit.libreoffice.org/69742
Tested-by: Jenkins
Reviewed-by: Dennis Francis 

diff --git a/sc/qa/unit/parallelism.cxx b/sc/qa/unit/parallelism.cxx
index 058cbfad9728..2f3e4d35771d 100644
--- a/sc/qa/unit/parallelism.cxx
+++ b/sc/qa/unit/parallelism.cxx
@@ -299,7 +299,7 @@ void ScParallelismTest::testVLOOKUPSUM()
 {
 m_pDoc->InsertTab(0, "1");
 
-const size_t nNumRows = 4096*4;
+const size_t nNumRows = 2048;
 OUString aTableRef = "$A$1:$B$" + OUString::number(nNumRows);
 for (size_t i = 0; i < nNumRows; ++i)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: cui/source cui/uiconfig include/svl include/unotools officecfg/registry sfx2/source svl/qa svl/source unotools/source

[Tamás Zolnai (via logerrit)]

 cui/source/options/optfltr.cxx |   10 ++
 cui/source/options/optfltr.hxx |1 
 cui/uiconfig/ui/optfltrembedpage.ui|   63 +++--
 include/svl/lockfilecommon.hxx |2 
 include/svl/msodocumentlockfile.hxx|8 +
 include/unotools/fltrcfg.hxx   |3 
 officecfg/registry/schema/org/openoffice/Office/Common.xcs |8 +
 sfx2/source/doc/docfile.cxx|   46 +
 svl/qa/unit/lockfiles/test_lockfiles.cxx   |2 
 svl/source/misc/lockfilecommon.cxx |2 
 svl/source/misc/msodocumentlockfile.cxx|   19 ++-
 unotools/source/config/fltrcfg.cxx |   25 -
 12 files changed, 165 insertions(+), 24 deletions(-)

New commits:
commit 41dc917b9b55b8c0c4307ffc58a1fb7257df2b69
Author: Tamás Zolnai 
AuthorDate: Mon Mar 25 13:28:27 2019 +0100
Commit: Tamás Zolnai 
CommitDate: Tue Mar 26 19:09:46 2019 +0100

Generate MSO lock files when the related MSO compat. option is set

Added a new compatibility option to the Tools -> Load / Save ->
Microsoft.
When this option is set on the UI or or set in the configuration files
LO generates lock files for MSO supported file formats, similar to
the lock files MSO generates itself.

Change-Id: I2f882723841162add01be9d3f7285a5162a60331
Reviewed-on: https://gerrit.libreoffice.org/69678
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai 

diff --git a/cui/source/options/optfltr.cxx b/cui/source/options/optfltr.cxx
index e70bdef191b3..f29c14c78837 100644
--- a/cui/source/options/optfltr.cxx
+++ b/cui/source/options/optfltr.cxx
@@ -153,6 +153,7 @@ OfaMSFilterTabPage2::OfaMSFilterTabPage2( vcl::Window* 
pParent, const SfxItemSet
 
 get( aHighlightingRB, "highlighting");
 get( aShadingRB,  "shading" );
+get( aMSOLockFileCB,  "mso_lockfile");
 
 Size aControlSize(248, 55);
 aControlSize = LogicToPixel(aControlSize, MapMode(MapUnit::MapAppFont));
@@ -183,6 +184,7 @@ void OfaMSFilterTabPage2::dispose()
 m_pCheckLBContainer.clear();
 aHighlightingRB.clear();
 aShadingRB.clear();
+aMSOLockFileCB.clear();
 
 SfxTabPage::dispose();
 }
@@ -252,6 +254,11 @@ bool OfaMSFilterTabPage2::FillItemSet( SfxItemSet* )
 rOpt.SetCharBackground2Shading();
 }
 
+if( aMSOLockFileCB->IsValueChangedFromSaved() )
+{
+rOpt.EnableMSOLockFileCreation(aMSOLockFileCB->IsChecked());
+}
+
 return true;
 }
 
@@ -318,6 +325,9 @@ void OfaMSFilterTabPage2::Reset( const SfxItemSet* )
 aShadingRB->Check();
 
 aHighlightingRB->SaveValue();
+
+aMSOLockFileCB->Check(rOpt.IsMSOLockFileCreationIsEnabled());
+aMSOLockFileCB->SaveValue();
 }
 
 void OfaMSFilterTabPage2::InsertEntry( const OUString& _rTxt, 
MSFltrPg2_CheckBoxEntries _nType )
diff --git a/cui/source/options/optfltr.hxx b/cui/source/options/optfltr.hxx
index 9183532e1225..54f00c7b99d1 100644
--- a/cui/source/options/optfltr.hxx
+++ b/cui/source/options/optfltr.hxx
@@ -88,6 +88,7 @@ class OfaMSFilterTabPage2 : public SfxTabPage
 
 VclPtr aHighlightingRB;
 VclPtr aShadingRB;
+VclPtraMSOLockFileCB;
 
 virtual ~OfaMSFilterTabPage2() override;
 virtual void dispose() override;
diff --git a/cui/uiconfig/ui/optfltrembedpage.ui 
b/cui/uiconfig/ui/optfltrembedpage.ui
index 0e65b6cdce69..df931247be30 100644
--- a/cui/uiconfig/ui/optfltrembedpage.ui
+++ b/cui/uiconfig/ui/optfltrembedpage.ui
@@ -1,4 +1,5 @@
 
+
 
   
   
@@ -48,8 +49,8 @@
   
 True
 False
-0
 [L]: Load and convert the object
+0
   
   
 False
@@ -61,8 +62,8 @@
   
 True
 False
-0
 [S]: Convert and save the object
+0
   
   
 False
@@ -88,8 +89,6 @@
   
 0
 0
-1
-1
   
 
 
@@ -184,8 +183,60 @@
   
 0
 1
-1
-1
+  
+
+
+  
+True
+False
+0
+none
+
+  
+True
+False
+6
+12
+
+  
+True
+False
+start
+
+  
+Create MSO lock file
+True
+True
+False
+True
+0
+True
+True
+  
+  
+False
+True
+   

[Libreoffice-commits] core.git: sc/inc sc/source sc/uiconfig

[Caolán McNamara (via logerrit)]

 sc/inc/strings.hrc |3 -
 sc/source/ui/dialogs/searchresults.cxx |   97 ++---
 sc/source/ui/inc/searchresults.hxx |   20 +++---
 sc/source/ui/view/viewfun2.cxx |2 
 sc/uiconfig/scalc/ui/searchresults.ui  |   77 --
 5 files changed, 126 insertions(+), 73 deletions(-)

New commits:
commit cd19a7664a25eda786bb76feefb40ebcbf79a54d
Author: Caolán McNamara 
AuthorDate: Tue Mar 26 14:12:49 2019 +
Commit: Caolán McNamara 
CommitDate: Tue Mar 26 18:23:23 2019 +0100

weld SearchResultsDlg

Change-Id: Ib2a031843a92626941ebe9c94a77a44c4c970585
Reviewed-on: https://gerrit.libreoffice.org/69757
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/inc/strings.hrc b/sc/inc/strings.hrc
index a3392a36b20c..39873fcf46a1 100644
--- a/sc/inc/strings.hrc
+++ b/sc/inc/strings.hrc
@@ -141,9 +141,6 @@
 #define STR_MID NC_("STR_MID", "Mid" )
 #define STR_SOUTH   NC_("STR_SOUTH", "South" )
 #define STR_SUM NC_("STR_SUM", "Total" )
-#define STR_SHEET   NC_("STR_SHEET", "Sheet" )
-#define STR_CELLNC_("STR_CELL", "Cell" )
-#define STR_CONTENT NC_("STR_CONTENT", 
"Content" )
 #define SCSTR_UNDO_PAGE_ANCHOR  
NC_("SCSTR_UNDO_PAGE_ANCHOR", "Page Anchor" )
 #define SCSTR_UNDO_CELL_ANCHOR  
NC_("SCSTR_UNDO_CELL_ANCHOR", "Cell Anchor" )
 #define SCSTR_CONDITION NC_("SCSTR_CONDITION", 
"Condition ")
diff --git a/sc/source/ui/dialogs/searchresults.cxx 
b/sc/source/ui/dialogs/searchresults.cxx
index 34ac4dd989ee..6a4d899d892f 100644
--- a/sc/source/ui/dialogs/searchresults.cxx
+++ b/sc/source/ui/dialogs/searchresults.cxx
@@ -22,66 +22,56 @@
 
 namespace sc {
 
-SearchResultsDlg::SearchResultsDlg( SfxBindings* _pBindings, vcl::Window* 
pParent ) :
-ModelessDialog(pParent, "SearchResultsDialog", 
"modules/scalc/ui/searchresults.ui"),
-aSkipped( ScResId( SCSTR_SKIPPED ) ),
-mpBindings(_pBindings), mpDoc(nullptr)
+SearchResultsDlg::SearchResultsDlg(SfxBindings* _pBindings, weld::Window* 
pParent)
+: SfxDialogController(pParent, "modules/scalc/ui/searchresults.ui", 
"SearchResultsDialog")
+, aSkipped(ScResId(SCSTR_SKIPPED))
+, mpBindings(_pBindings)
+, mpDoc(nullptr)
+, mxList(m_xBuilder->weld_tree_view("results"))
+, mxSearchResults(m_xBuilder->weld_label("lbSearchResults"))
 {
-get(mpSearchResults, "lbSearchResults");
-
-SvSimpleTableContainer *pContainer = 
get("results");
-Size aControlSize(150, 120);
-aControlSize = pContainer->LogicToPixel(aControlSize, 
MapMode(MapUnit::MapAppFont));
-pContainer->set_width_request(aControlSize.Width());
-pContainer->set_height_request(aControlSize.Height());
-
-mpList = VclPtr::Create(*pContainer);
-long nTabs[] = {0, 40, 60};
-mpList->SetTabs(SAL_N_ELEMENTS(nTabs), nTabs);
-mpList->InsertHeaderEntry(ScResId(STR_SHEET) + "\t" + ScResId(STR_CELL) + 
"\t" + ScResId(STR_CONTENT));
-mpList->SetSelectHdl( LINK(this, SearchResultsDlg, ListSelectHdl) );
-}
+mxList->set_size_request(mxList->get_approximate_digit_width() * 50, 
mxList->get_height_rows(15));
 
-SearchResultsDlg::~SearchResultsDlg()
-{
-disposeOnce();
+std::vector aWidths;
+aWidths.push_back(mxList->get_approximate_digit_width() * 10);
+aWidths.push_back(mxList->get_approximate_digit_width() * 10);
+mxList->set_column_fixed_widths(aWidths);
+mxList->connect_changed(LINK(this, SearchResultsDlg, ListSelectHdl));
 }
 
-void SearchResultsDlg::dispose()
+SearchResultsDlg::~SearchResultsDlg()
 {
-mpList.disposeAndClear();
-mpSearchResults.disposeAndClear();
-ModelessDialog::dispose();
 }
 
 namespace
 {
 class ListWrapper {
-OUStringBuffer maName;
-VclPtr mpList;
+weld::TreeView& mrList;
 public:
 size_t mnCount = 0;
 static const size_t mnMaximum = 1000;
-ListWrapper(const VclPtr ) :
-mpList(pList)
+ListWrapper(weld::TreeView& rList)
+: mrList(rList)
 {
-mpList->Clear();
-mpList->SetUpdateMode(false);
+mrList.clear();
+mrList.freeze();
 }
-void Insert(const OUString ,
+~ListWrapper()
+{
+mrList.thaw();
+}
+void Insert(const OUString ,
 const ScAddress ,
 formula::FormulaGrammar::AddressConvention eConvention,
-const OUString )
+const OUString )
 {
 if (mnCount++ < mnMaximum)
 {
-maName.append(aTabName);
-maName.append("\t");
-

[Libreoffice-qa] QA Meeting Minutes (2019-03-26)

[Xisco Fauli]

Meeting started by x1sc0 at 16:00:35 UTC.  The full logs are available
at
http://dev-downloads.libreoffice.org/meetbot/libreoffice-qa/2019/libreoffice-qa.2019-03-26-16.00.log.html
.



Meeting summary
---

* BZ contributors group access  (x1sc0, 16:06:12)

* Wiki updates  (x1sc0, 16:24:05)
  * LINK: https://wiki.documentfoundation.org/Design/Meetings  (x1sc0,
16:27:49)
  * LINK: QA mail archives
https://www.mail-archive.com/libreoffice-qa@lists.freedesktop.org/
(cloph, 16:33:48)
  * LINK:
https://www.mail-archive.com/libreoffice-qa@lists.freedesktop.org/
(x1sc0, 16:35:12)
  * LINK: https://lists.freedesktop.org/archives/libreoffice-qa/
(cloph, 16:36:57)

* QA development program with steps  (x1sc0, 16:47:20)
  * IDEA: "12 steps to happiness and personal growth" type of roadmap
(x1sc0, 16:51:59)



Meeting ended at 17:01:59 UTC.



People present (lines said)
---

* x1sc0 (90)
* buovjaga (29)
* djredaux (23)
* lo-qa-tg (23)
* IZBot (2)
* specing (2)
* bearon (2)
* cloph (2)

-- 
Xisco Faulí
Libreoffice QA Team
IRC: x1sc0

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-commits] core.git: vcl/source

[Tor Lillqvist (via logerrit)]

 vcl/source/window/window2.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cddb51d709f58f54fbf303fdb567ea0484852657
Author: Tor Lillqvist 
AuthorDate: Tue Mar 26 17:51:37 2019 +0200
Commit: Tor Lillqvist 
CommitDate: Tue Mar 26 18:24:21 2019 +0200

Make contents of combobox follow the finger when scrolling with a pan 
gesture

It is the contents that we are dragging with the gesture, not the
scrollbar "thumb". The DoScroll() call takes as argument how much the
"thumb" should be moved, though.

Change-Id: Id95a4bf9d2bb4e950dd85c6bebb4d2b5f2726ee0

diff --git a/vcl/source/window/window2.cxx b/vcl/source/window/window2.cxx
index c352b006d67e..2726c283ebde 100644
--- a/vcl/source/window/window2.cxx
+++ b/vcl/source/window/window2.cxx
@@ -760,7 +760,7 @@ bool Window::HandleScrollCommand( const CommandEvent& rCmd,
 else if(pData->meEventType == GestureEventType::PanningUpdate)
 {
 long nOriginalPosition = 
mpWindowImpl->mpFrameData->mnTouchPanPosition;
-pVScrl->DoScroll(nOriginalPosition + (pData->mfOffset));
+pVScrl->DoScroll(nOriginalPosition + (pData->mfOffset / 
pVScrl->GetVisibleSize()));
 }
 if (pData->meEventType == GestureEventType::PanningEnd)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

[Libreoffice Gerrit user]

 loleaflet/src/control/Control.LokDialog.js |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit d124e3e5aaedd48c7f83f000fcbd682489b45b60
Author: Tor Lillqvist 
AuthorDate: Tue Mar 26 18:25:29 2019 +0200
Commit: Tor Lillqvist 
CommitDate: Tue Mar 26 18:25:29 2019 +0200

Scroll in correct direction with gesture

It is the combobox contents you are dragging with the gesture, so it
should move in the same direction, not opposite.

(If you would be draging the scrollbar's "thumb", then the contents of
the combobox would indeed move in the other direction. But on a touch
device, it definitely is the contents that the user is dragging.)

Change-Id: I9dc9e3cc7e3a1412176fd1d84c5587c86410d191

diff --git a/loleaflet/src/control/Control.LokDialog.js 
b/loleaflet/src/control/Control.LokDialog.js
index 23186e681..814e0ab4f 100644
--- a/loleaflet/src/control/Control.LokDialog.js
+++ b/loleaflet/src/control/Control.LokDialog.js
@@ -687,14 +687,14 @@ L.Control.LokDialog = L.Control.extend({
}
else if (e.type === 'touchend')
{
-   this._postWindowGestureEvent(childId, 'panEnd', 
firstTouchPositionX, firstTouchPositionY, touchY - firstTouchPositionY);
+   this._postWindowGestureEvent(childId, 'panEnd', 
firstTouchPositionX, firstTouchPositionY, firstTouchPositionY - touchY);
firstTouchPositionX = null;
firstTouchPositionY = null;
 
}
else if (e.type === 'touchmove')
{
-   this._postWindowGestureEvent(childId, 
'panUpdate', firstTouchPositionX, firstTouchPositionY, touchY - 
firstTouchPositionY);
+   this._postWindowGestureEvent(childId, 
'panUpdate', firstTouchPositionX, firstTouchPositionY, firstTouchPositionY - 
touchY);
}
}, this);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

[Luboš Luňák (via logerrit)]

 vcl/source/filter/jpeg/JpegWriter.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f8dbee4d860b95717fa906935a8162c7edcd5973
Author: Luboš Luňák 
AuthorDate: Mon Mar 25 16:58:25 2019 +0100
Commit: Miklos Vajna 
CommitDate: Tue Mar 26 17:15:15 2019 +0100

8bit image is "native" only if it has grey palette (tdf#116888)

The image in the bugreport apparently has a different palette even
thought it seems to be a grayscale image.

Change-Id: I3b442b7e2529a60493b64761eb1c537ee9f05a10
Reviewed-on: https://gerrit.libreoffice.org/69699
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/vcl/source/filter/jpeg/JpegWriter.cxx 
b/vcl/source/filter/jpeg/JpegWriter.cxx
index 407e2423b64a..3164918cc90e 100644
--- a/vcl/source/filter/jpeg/JpegWriter.cxx
+++ b/vcl/source/filter/jpeg/JpegWriter.cxx
@@ -231,7 +231,7 @@ bool JPEGWriter::Write( const Graphic& rGraphic )
 *mpExpWasGrey = mbGreys;
 
 if ( mbGreys )
-mbNative = ( mpReadAccess->GetScanlineFormat() == 
ScanlineFormat::N8BitPal );
+mbNative = ( mpReadAccess->GetScanlineFormat() == 
ScanlineFormat::N8BitPal && aGraphicBmp.HasGreyPalette());
 else
 mbNative = ( mpReadAccess->GetScanlineFormat() == 
ScanlineFormat::N24BitTcRgb );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - i18npool/source

[Eike Rathke (via logerrit)]

 i18npool/source/localedata/data/kmr_Latn_TR.xml |   13 ++---
 1 file changed, 10 insertions(+), 3 deletions(-)

New commits:
commit 078dbe815940018705a5c69ddb8ac9d1897689c1
Author: Eike Rathke 
AuthorDate: Mon Mar 25 22:33:03 2019 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Tue Mar 26 17:13:08 2019 +0100

Assign [kmr-Latn-TR] TRY|₺ currency, TRY|YTL and TRL|TL are legacyOnly

This was done long ago for the tr-TR locale as well.

Change-Id: I5bf8595f6d49adb7fd76b3c4924c4d72b3b8ea5e
Reviewed-on: https://gerrit.libreoffice.org/69717
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit 4ca9db953d59d93ce8e3a54a36d23ed52b9c62a9)
Reviewed-on: https://gerrit.libreoffice.org/69723
Tested-by: Eike Rathke 
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/i18npool/source/localedata/data/kmr_Latn_TR.xml 
b/i18npool/source/localedata/data/kmr_Latn_TR.xml
index 2762df9e630f..a566c67170b9 100644
--- a/i18npool/source/localedata/data/kmr_Latn_TR.xml
+++ b/i18npool/source/localedata/data/kmr_Latn_TR.xml
@@ -52,7 +52,7 @@
 PN
 US
   
-  
+  
 M/D
 
   General
@@ -335,14 +335,21 @@
 
   
   
-
+
+  TRY
+  ₺
+  TRY
+  Türk Lirası
+  2
+
+
   TRY
   YTL
   TRY
   Yeni Türk Lirası
   2
 
-
+
   TRL
   TL
   TRL
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: bundled/include

[Libreoffice Gerrit user]

 bundled/include/LibreOfficeKit/LibreOfficeKit.h   |9 +
 bundled/include/LibreOfficeKit/LibreOfficeKit.hxx |   16 
 2 files changed, 25 insertions(+)

New commits:
commit d0186aadee756882cf77fc5366b3298731c40923
Author: Tor Lillqvist 
AuthorDate: Tue Mar 26 18:01:16 2019 +0200
Commit: Tor Lillqvist 
CommitDate: Tue Mar 26 18:01:16 2019 +0200

Update to match core master

Change-Id: I8932f9ea8ebd1addd9679f2f325b4dbafa48578c

diff --git a/bundled/include/LibreOfficeKit/LibreOfficeKit.h 
b/bundled/include/LibreOfficeKit/LibreOfficeKit.h
index 2df1cea6d..0e596f506 100644
--- a/bundled/include/LibreOfficeKit/LibreOfficeKit.h
+++ b/bundled/include/LibreOfficeKit/LibreOfficeKit.h
@@ -356,10 +356,19 @@ struct _LibreOfficeKitDocumentClass
 
 /// @see lok::Document::getSignatureState().
 int (*getSignatureState) (LibreOfficeKitDocument* pThis);
+// END CERTIFICATE AND SIGNING
 
 /// @see lok::Document::renderShapeSelection
 size_t (*renderShapeSelection)(LibreOfficeKitDocument* pThis, char** 
pOutput);
 
+/// @see lok::Document::postWindowGestureEvent().
+void (*postWindowGestureEvent) (LibreOfficeKitDocument* pThis,
+  unsigned nWindowId,
+  const char* pType,
+  int nX,
+  int nY,
+  int nOffset);
+
 #endif // defined LOK_USE_UNSTABLE_API || defined LIBO_INTERNAL_ONLY
 };
 
diff --git a/bundled/include/LibreOfficeKit/LibreOfficeKit.hxx 
b/bundled/include/LibreOfficeKit/LibreOfficeKit.hxx
index 31e95a09c..bd678b0b8 100644
--- a/bundled/include/LibreOfficeKit/LibreOfficeKit.hxx
+++ b/bundled/include/LibreOfficeKit/LibreOfficeKit.hxx
@@ -629,6 +629,22 @@ public:
 return mpDoc->pClass->renderShapeSelection(mpDoc, pOutput);
 }
 
+/**
+ * Posts a gesture event to the window with given id.
+ *
+ * @param nWindowId
+ * @param pType Event type, like panStart, panEnd, panUpdate.
+ * @param nX horizontal position in document coordinates
+ * @param nY vertical position in document coordinates
+ * @param nOffset difference value from when the gesture started to 
current value
+ */
+void postWindowGestureEvent(unsigned nWindowId,
+  const char* pType,
+  int nX, int nY, int nOffset)
+{
+return mpDoc->pClass->postWindowGestureEvent(mpDoc, nWindowId, pType, 
nX, nY, nOffset);
+}
+
 #endif // defined LOK_USE_UNSTABLE_API || defined LIBO_INTERNAL_ONLY
 };
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - external/more_fonts

[Andras Timar (via logerrit)]

 external/more_fonts/Module_more_fonts.mk |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit f69ae64c7ed3cf21eb48ccb43d4bedcaf77fa984
Author: Andras Timar 
AuthorDate: Tue Mar 26 15:07:50 2019 +0100
Commit: Michael Meeks 
CommitDate: Tue Mar 26 16:55:41 2019 +0100

Do not include Culmus fonts (GPLv2) into MPL subset

Change-Id: I8de0e8e91d785d51b65ce884caddcc05d86bd47d
Reviewed-on: https://gerrit.libreoffice.org/69756
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

diff --git a/external/more_fonts/Module_more_fonts.mk 
b/external/more_fonts/Module_more_fonts.mk
index 023e21361d39..57bf4548783a 100644
--- a/external/more_fonts/Module_more_fonts.mk
+++ b/external/more_fonts/Module_more_fonts.mk
@@ -14,7 +14,7 @@ $(eval $(call gb_Module_add_targets,more_fonts,\
ExternalPackage_amiri \
ExternalPackage_caladea \
ExternalPackage_carlito \
-   ExternalPackage_culmus \
+   $(if $(MPL_SUBSET),,ExternalPackage_culmus) \
ExternalPackage_dejavu \
ExternalPackage_gentium \
ExternalPackage_kacst \
@@ -33,7 +33,7 @@ $(eval $(call gb_Module_add_targets,more_fonts,\
UnpackedTarball_amiri \
UnpackedTarball_caladea \
UnpackedTarball_carlito \
-   UnpackedTarball_culmus \
+   $(if $(MPL_SUBSET),,UnpackedTarball_culmus) \
UnpackedTarball_dejavu \
UnpackedTarball_gentium \
UnpackedTarball_kacst \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - vcl/source

[Tor Lillqvist (via logerrit)]

 vcl/source/filter/ipdf/pdfread.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit 77a735be8a2196e890e88662fe73816fa44dd023
Author: Tor Lillqvist 
AuthorDate: Tue Mar 26 17:22:38 2019 +0200
Commit: Tor Lillqvist 
CommitDate: Tue Mar 26 17:39:34 2019 +0200

Fix build in !HAVE_FEATURE_PDFIUM case

Change-Id: I99baba8734b9e03d3986e448bf278587101d24ef

diff --git a/vcl/source/filter/ipdf/pdfread.cxx 
b/vcl/source/filter/ipdf/pdfread.cxx
index 16cb902e2476..f73dc5736fbf 100644
--- a/vcl/source/filter/ipdf/pdfread.cxx
+++ b/vcl/source/filter/ipdf/pdfread.cxx
@@ -155,6 +155,8 @@ bool getCompatibleStream(SvStream& rInStream, SvStream& 
rOutStream,
 namespace vcl
 {
 
+#if HAVE_FEATURE_PDFIUM
+
 size_t RenderPDFBitmaps(const void* pBuffer, int nSize, std::vector& 
rBitmaps,
 const size_t nFirstPage, int nPages,
 const double fResolutionDPI)
@@ -218,6 +220,8 @@ size_t RenderPDFBitmaps(const void* pBuffer, int nSize, 
std::vector& rBi
 return rBitmaps.size();
 }
 
+#endif // HAVE_FEATURE_PDFIUM
+
 bool ImportPDF(SvStream& rStream, Bitmap& rBitmap,
size_t nPageIndex,
css::uno::Sequence& rPdfData,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - sw/source

[Tor Lillqvist (via logerrit)]

 sw/source/ui/vba/vbadocument.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit afbc688fba50e8b76f2e367f62d943587c3411d8
Author: Tor Lillqvist 
AuthorDate: Tue Mar 26 17:32:13 2019 +0200
Commit: Tor Lillqvist 
CommitDate: Tue Mar 26 17:32:13 2019 +0200

Fix compilation error without precompiled headers

Change-Id: I06eea66ac783296a6278d4bcf3be5829a2d7d277

diff --git a/sw/source/ui/vba/vbadocument.cxx b/sw/source/ui/vba/vbadocument.cxx
index 9b44c92c9176..67967bc4eb74 100644
--- a/sw/source/ui/vba/vbadocument.cxx
+++ b/sw/source/ui/vba/vbadocument.cxx
@@ -27,6 +27,7 @@
 #include "vbabookmarks.hxx"
 #include "vbamailmerge.hxx"
 #include "vbavariables.hxx"
+#include 
 #include 
 #include 
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/qa sw/source

[László Németh (via logerrit)]

 sw/qa/extras/ooxmlexport/data/missing_newline.odt |binary
 sw/qa/extras/ooxmlexport/ooxmlexport5.cxx |   12 
 sw/source/filter/ww8/docxattributeoutput.cxx  |2 +-
 3 files changed, 13 insertions(+), 1 deletion(-)

New commits:
commit 15e9e6d12aa2d49e114ec0cf8326f2264ccf2640
Author: László Németh 
AuthorDate: Mon Mar 25 16:30:19 2019 +0100
Commit: László Németh 
CommitDate: Tue Mar 26 16:12:02 2019 +0100

tdf#124339 DOCX export: fix losing line break after tab

characters, hard hyphen and control characters

See also commit 637a96d1e7875043c28a93c9a543f33a862497cb
"fdo#78887  tag is not being preserved after export".

Change-Id: I70b22061b3baca4e6fee8cb5a0c2655975e252bc
Reviewed-on: https://gerrit.libreoffice.org/69697
Tested-by: Jenkins
Reviewed-by: László Németh 

diff --git a/sw/qa/extras/ooxmlexport/data/missing_newline.odt 
b/sw/qa/extras/ooxmlexport/data/missing_newline.odt
new file mode 100644
index ..b0f10ade81f6
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/missing_newline.odt 
differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
index 4ebf802cfa1d..74c85bbfab02 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
@@ -462,6 +462,18 @@ DECLARE_OOXMLEXPORT_TEST(testFDO78887, "fdo78887.docx")
 assertXPath(pXmlDoc, "/w:document[1]/w:body[1]/w:p[1]/w:r[1]/w:br[2]", 1);
 }
 
+DECLARE_OOXMLEXPORT_TEST(testFDO78887b, "missing_newline.odt")
+{
+xmlDocPtr pXmlDoc = parseExport("word/document.xml");
+if (!pXmlDoc)
+return;
+
+assertXPath(pXmlDoc, "/w:document[1]/w:body[1]/w:p[1]/w:r[2]/w:br[1]", 1);
+assertXPathContent(pXmlDoc, 
"/w:document[1]/w:body[1]/w:p[1]/w:r[1]/w:t[1]", "Tab and line break");
+assertXPath(pXmlDoc, "/w:document[1]/w:body[1]/w:p[1]/w:r[5]/w:br[1]", 1);
+assertXPathContent(pXmlDoc, 
"/w:document[1]/w:body[1]/w:p[1]/w:r[6]/w:t[1]", "New line");
+}
+
 DECLARE_OOXMLEXPORT_TEST(testFdo78651, "fdo78651.docx")
 {
 xmlDocPtr pXmlDoc = parseExport("word/document.xml");
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index c40121040717..ed388364a1ba 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -2709,7 +2709,7 @@ void DocxAttributeOutput::RunText( const OUString& rText, 
rtl_TextEncoding /*eCh
 break;
 case 0x0b: // line break
 {
-if (impl_WriteRunText( m_pSerializer, nTextToken, pBegin, 
pIt ) || (prevUnicode == *pIt))
+if (impl_WriteRunText( m_pSerializer, nTextToken, pBegin, 
pIt ) || prevUnicode < 0x0020)
 {
 m_pSerializer->singleElementNS( XML_w, XML_br, FSEND );
 prevUnicode = *pIt;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/inc

[Caolán McNamara (via logerrit)]

 vcl/inc/printdlg.hxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 9042a002a2902e231a98180b610cd438b4f43343
Author: Caolán McNamara 
AuthorDate: Tue Mar 26 13:06:00 2019 +
Commit: Caolán McNamara 
CommitDate: Tue Mar 26 16:03:53 2019 +0100

missing trailing modelines

Change-Id: I2e4d386fd14c9d41aa4270c87ddc2fcae311f245
Reviewed-on: https://gerrit.libreoffice.org/69744
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/inc/printdlg.hxx b/vcl/inc/printdlg.hxx
index e3ea1cdba505..33bbb790fdd3 100644
--- a/vcl/inc/printdlg.hxx
+++ b/vcl/inc/printdlg.hxx
@@ -274,3 +274,5 @@ namespace vcl
 }
 
 #endif // VCL_INC_NEWPRINTDLG_HXX
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/inc vcl/source

[Caolán McNamara (via logerrit)]

 vcl/inc/printdlg.hxx   |   15 ++---
 vcl/source/gdi/print3.cxx  |   45 -
 vcl/source/window/printdlg.cxx |   42 --
 3 files changed, 52 insertions(+), 50 deletions(-)

New commits:
commit 8a109230486166b36c1a097b838c9d0a1d2af1c3
Author: Caolán McNamara 
AuthorDate: Tue Mar 26 13:05:17 2019 +
Commit: Caolán McNamara 
CommitDate: Tue Mar 26 16:03:38 2019 +0100

weld PrintProgressDialog

Change-Id: Icb37642bf3ef0ddd1b31d25b80564cdcbb86e653
Reviewed-on: https://gerrit.libreoffice.org/69743
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/inc/printdlg.hxx b/vcl/inc/printdlg.hxx
index 05985ecdc309..e3ea1cdba505 100644
--- a/vcl/inc/printdlg.hxx
+++ b/vcl/inc/printdlg.hxx
@@ -250,23 +250,22 @@ namespace vcl
 
 };
 
-class PrintProgressDialog : public ModelessDialog
+class PrintProgressDialog : public weld::GenericDialogController
 {
 OUStringmaStr;
-VclPtr   mpText;
-VclPtr mpProgress;
-VclPtr mpButton;
-
 boolmbCanceled;
 sal_Int32   mnCur;
 sal_Int32   mnMax;
 
-DECL_LINK( ClickHdl, Button*, void );
+std::unique_ptr mxText;
+std::unique_ptr mxProgress;
+std::unique_ptr mxButton;
+
+DECL_LINK( ClickHdl, weld::Button&, void );
 
 public:
-PrintProgressDialog(vcl::Window* i_pParent, int i_nMax);
+PrintProgressDialog(weld::Window* i_pParent, int i_nMax);
 virtual ~PrintProgressDialog() override;
-virtual void dispose() override;
 bool isCanceled() const { return mbCanceled; }
 void setProgress( int i_nCurrent );
 void tick();
diff --git a/vcl/source/gdi/print3.cxx b/vcl/source/gdi/print3.cxx
index 96ebfc7197a9..603ec9056212 100644
--- a/vcl/source/gdi/print3.cxx
+++ b/vcl/source/gdi/print3.cxx
@@ -159,7 +159,7 @@ public:
 
 vcl::PrinterController::MultiPageSetup  maMultiPage;
 
-VclPtrmpProgress;
+std::shared_ptr   mxProgress;
 
 ImplPageCache   maPageCache;
 
@@ -194,11 +194,18 @@ public:
 mbPapersizeFromUser( false ),
 mbPrinterModified( false ),
 meJobState( css::view::PrintableState_JOB_STARTED ),
-mpProgress( nullptr ),
 mnDefaultPaperBin( -1 ),
 mnFixedPaperBin( -1 )
 {}
-~ImplPrinterControllerData() { mpProgress.disposeAndClear(); }
+
+~ImplPrinterControllerData()
+{
+if (mxProgress)
+{
+mxProgress->response(RET_CANCEL);
+mxProgress.reset();
+}
+}
 
 const Size& getRealPaperSize( const Size& i_rPageSize, bool bNoNUP ) const
 {
@@ -973,12 +980,12 @@ css::uno::Sequence< css::beans::PropertyValue > 
PrinterController::getPageParame
 PrinterController::PageSize PrinterController::getPageFile( int 
i_nUnfilteredPage, GDIMetaFile& o_rMtf, bool i_bMayUseCache )
 {
 // update progress if necessary
-if( mpImplData->mpProgress )
+if( mpImplData->mxProgress )
 {
 // do nothing if printing is canceled
-if( mpImplData->mpProgress->isCanceled() )
+if( mpImplData->mxProgress->isCanceled() )
 return PrinterController::PageSize();
-mpImplData->mpProgress->tick();
+mpImplData->mxProgress->tick();
 Application::Reschedule( true );
 }
 
@@ -1284,10 +1291,10 @@ void PrinterController::printFilteredPage( int i_nPage )
 GDIMetaFile aPageFile;
 PrinterController::PageSize aPageSize = getFilteredPageFile( i_nPage, 
aPageFile );
 
-if( mpImplData->mpProgress )
+if( mpImplData->mxProgress )
 {
 // do nothing if printing is canceled
-if( mpImplData->mpProgress->isCanceled() )
+if( mpImplData->mxProgress->isCanceled() )
 {
 setJobState( css::view::PrintableState_JOB_ABORTED );
 return;
@@ -1344,7 +1351,13 @@ void PrinterController::abortJob()
 // applications (well, sw) depend on a page request with "IsLastPage" = 
true
 // to free resources, else they (well, sw) will crash eventually
 setLastPage( true );
-mpImplData->mpProgress.disposeAndClear();
+
+if (mpImplData->mxProgress)
+{
+mpImplData->mxProgress->response(RET_CANCEL);
+mpImplData->mxProgress.reset();
+}
+
 GDIMetaFile aMtf;
 getPageFile( 0, aMtf );
 }
@@ -1667,7 +1680,7 @@ OUString PrinterController::makeEnabled( const OUString& 
i_rProperty )
 
 void PrinterController::createProgressDialog()
 {
-if( ! mpImplData->mpProgress )
+if (!mpImplData->mxProgress)
 {
 bool bShow = true;
 css::beans::PropertyValue* pMonitor = getValue( OUString( 
"MonitorVisible" ) );
@@ -1686,17 +1699,21 @@ void 

[Libreoffice-commits] core.git: sc/inc sc/source

[Mike Kaganski (via logerrit)]

 sc/inc/miscuno.hxx |2 
 sc/source/core/data/dpobject.cxx   |   67 -
 sc/source/core/data/dpoutput.cxx   |   24 ++--
 sc/source/core/data/dpsave.cxx |   16 ++---
 sc/source/ui/dataprovider/sqldataprovider.cxx  |3 -
 sc/source/ui/dbgui/dapidata.cxx|3 -
 sc/source/ui/unoobj/PivotTableDataProvider.cxx |9 +--
 sc/source/ui/unoobj/miscuno.cxx|9 ---
 sc/source/ui/unoobj/targuno.cxx|3 -
 sc/source/ui/vba/vbaapplication.cxx|3 -
 10 files changed, 46 insertions(+), 93 deletions(-)

New commits:
commit 830345be2d96d8f699e8cbf33646721fa8c65baf
Author: Mike Kaganski 
AuthorDate: Tue Mar 26 11:20:33 2019 +0100
Commit: Mike Kaganski 
CommitDate: Tue Mar 26 15:34:14 2019 +0100

ScUnoHelpFunctions::AnyToInterface is redundant

Change-Id: Ia61806f7781b49f29122ad9be75a5eb739918c37
Reviewed-on: https://gerrit.libreoffice.org/69734
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sc/inc/miscuno.hxx b/sc/inc/miscuno.hxx
index e0391e431f43..365db0ace50b 100644
--- a/sc/inc/miscuno.hxx
+++ b/sc/inc/miscuno.hxx
@@ -127,8 +127,6 @@ public:
 class SC_DLLPUBLIC ScUnoHelpFunctions
 {
 public:
-static css::uno::Reference
-AnyToInterface( const css::uno::Any& rAny );
 static bool GetBoolProperty( const css::uno::Reference< 
css::beans::XPropertySet>& xProp,
 const OUString& rName, bool 
bDefault = false );
 static sal_Int16GetShortProperty( const css::uno::Reference< 
css::beans::XPropertySet>& xProp,
diff --git a/sc/source/core/data/dpobject.cxx b/sc/source/core/data/dpobject.cxx
index 21f3bf6190c6..97644f1baa69 100644
--- a/sc/source/core/data/dpobject.cxx
+++ b/sc/source/core/data/dpobject.cxx
@@ -268,9 +268,8 @@ static sheet::DataPilotFieldOrientation 
lcl_GetDataGetOrientation( const uno::Re
 bool bFound = false;
 for (long nIntDim=0; nIntDim xIntDim =
-ScUnoHelpFunctions::AnyToInterface( 
xIntDims->getByIndex(nIntDim) );
-uno::Reference xDimProp( xIntDim, 
uno::UNO_QUERY );
+uno::Reference 
xDimProp(xIntDims->getByIndex(nIntDim),
+ uno::UNO_QUERY);
 if ( xDimProp.is() )
 {
 bFound = ScUnoHelpFunctions::GetBoolProperty( xDimProp,
@@ -1204,8 +1203,7 @@ OUString ScDPObject::GetDimName( long nDim, bool& 
rIsDataLayout, sal_Int32* pFla
 long nDimCount = xDims->getCount();
 if ( nDim < nDimCount )
 {
-uno::Reference xIntDim =
-ScUnoHelpFunctions::AnyToInterface( xDims->getByIndex(nDim) );
+uno::Reference xIntDim(xDims->getByIndex(nDim), 
uno::UNO_QUERY);
 uno::Reference xDimName( xIntDim, 
uno::UNO_QUERY );
 uno::Reference xDimProp( xIntDim, 
uno::UNO_QUERY );
 if ( xDimName.is() && xDimProp.is() )
@@ -1247,9 +1245,7 @@ bool ScDPObject::IsDuplicated( long nDim )
 long nDimCount = xDims->getCount();
 if ( nDim < nDimCount )
 {
-uno::Reference xIntDim =
-ScUnoHelpFunctions::AnyToInterface( xDims->getByIndex(nDim) );
-uno::Reference xDimProp( xIntDim, 
uno::UNO_QUERY );
+uno::Reference 
xDimProp(xDims->getByIndex(nDim), uno::UNO_QUERY);
 if ( xDimProp.is() )
 {
 try
@@ -1730,7 +1726,7 @@ bool ScDPObject::ParseFilters(
 sal_Int32 nDimCount = xIntDims->getCount();
 for ( sal_Int32 nDim = 0; nDim xIntDim = 
ScUnoHelpFunctions::AnyToInterface( xIntDims->getByIndex(nDim) );
+uno::Reference xIntDim(xIntDims->getByIndex(nDim), 
uno::UNO_QUERY);
 uno::Reference xDim( xIntDim, uno::UNO_QUERY );
 uno::Reference xDimProp( xDim, uno::UNO_QUERY );
 uno::Reference xDimSupp( xDim, 
uno::UNO_QUERY );
@@ -1759,17 +1755,16 @@ bool ScDPObject::ParseFilters(
 if ( nHierarchy >= xHiers->getCount() )
 nHierarchy = 0;
 
-uno::Reference xHier = 
ScUnoHelpFunctions::AnyToInterface(
-
xHiers->getByIndex(nHierarchy) );
-uno::Reference xHierSupp( xHier, 
uno::UNO_QUERY );
+uno::Reference 
xHierSupp(xHiers->getByIndex(nHierarchy),
+ 
uno::UNO_QUERY);
 if ( xHierSupp.is() )
 {
 uno::Reference xLevels = new 
ScNameToIndexAccess( xHierSupp->getLevels() );
 sal_Int32 nLevCount = xLevels->getCount();
 for (sal_Int32 nLev=0; nLev xLevel = 
ScUnoHelpFunctions::AnyToInterface(
-

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4' - loleaflet/src

[Libreoffice Gerrit user]

 loleaflet/src/layer/tile/WriterTileLayer.js |7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

New commits:
commit 9f7dca3209661a6ca54f287e9709da502223e170
Author: Szymon Kłos 
AuthorDate: Wed Mar 20 09:34:19 2019 +0100
Commit: Szymon Kłos 
CommitDate: Tue Mar 26 15:24:58 2019 +0100

Avoid syntax errors while paring command results

Change-Id: I7d778fd62aeb32c8304afb90c21aafd83379c170

diff --git a/loleaflet/src/layer/tile/WriterTileLayer.js 
b/loleaflet/src/layer/tile/WriterTileLayer.js
index f7bca842b..ece0ddfa4 100644
--- a/loleaflet/src/layer/tile/WriterTileLayer.js
+++ b/loleaflet/src/layer/tile/WriterTileLayer.js
@@ -54,7 +54,12 @@ L.WriterTileLayer = L.TileLayer.extend({
},
 
_onCommandValuesMsg: function (textMsg) {
-   var values = 
JSON.parse(textMsg.substring(textMsg.indexOf('{')));
+   var braceIndex = textMsg.indexOf('{');
+   if (braceIndex < 0) {
+   return;
+   }
+
+   var values = JSON.parse(textMsg.substring(braceIndex));
if (!values) {
return;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

[Libreoffice Gerrit user]

 loleaflet/src/layer/tile/WriterTileLayer.js |7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

New commits:
commit fe702b1d11ca4fecc10eef5e9346689c1804b440
Author: Szymon Kłos 
AuthorDate: Wed Mar 20 09:34:19 2019 +0100
Commit: Szymon Kłos 
CommitDate: Tue Mar 26 15:24:08 2019 +0100

Avoid syntax errors while paring command results

Change-Id: I7d778fd62aeb32c8304afb90c21aafd83379c170

diff --git a/loleaflet/src/layer/tile/WriterTileLayer.js 
b/loleaflet/src/layer/tile/WriterTileLayer.js
index 9883b7e81..727711027 100644
--- a/loleaflet/src/layer/tile/WriterTileLayer.js
+++ b/loleaflet/src/layer/tile/WriterTileLayer.js
@@ -182,7 +182,12 @@ L.WriterTileLayer = L.TileLayer.extend({
},
 
_onCommandValuesMsg: function (textMsg) {
-   var values = 
JSON.parse(textMsg.substring(textMsg.indexOf('{')));
+   var braceIndex = textMsg.indexOf('{');
+   if (braceIndex < 0) {
+   return;
+   }
+
+   var values = JSON.parse(textMsg.substring(braceIndex));
if (!values) {
return;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 2 commits - oovbaapi/ooo svx/source sw/source

[Tor Lillqvist (via logerrit)]

 oovbaapi/ooo/vba/word/XDocument.idl |3 
 svx/source/svdraw/svdograf.cxx  |4 +
 sw/source/ui/vba/vbadocument.cxx|  112 
 sw/source/ui/vba/vbadocument.hxx|2 
 4 files changed, 121 insertions(+)

New commits:
commit c6056a8f913a161199a2833b6afa3735680a1c4d
Author: Tor Lillqvist 
AuthorDate: Tue Mar 26 16:16:44 2019 +0200
Commit: Tor Lillqvist 
CommitDate: Tue Mar 26 16:16:44 2019 +0200

Stopgap measure to fix compilation error on Windows

Somehow  gets included here and it #defines GetMetaFile as
GetMetaFileA. Undo that.

Change-Id: Ia99c077ef7b3f845efabaf286f12e2688fe4a132

diff --git a/svx/source/svdraw/svdograf.cxx b/svx/source/svdraw/svdograf.cxx
index 5829d508f687..df190f4861ee 100644
--- a/svx/source/svdraw/svdograf.cxx
+++ b/svx/source/svdraw/svdograf.cxx
@@ -1098,6 +1098,10 @@ GDIMetaFile 
SdrGrafObj::getMetafileFromEmbeddedVectorGraphicData() const
 return aRetval;
 }
 
+#ifdef _WIN32
+#undef GetMetaFile
+#endif
+
 GDIMetaFile SdrGrafObj::GetMetaFile(GraphicType ) const
 {
 if (isEmbeddedVectorGraphicData())
commit 0de4f894cf23635db639a64fcac2e77b8560c122
Author: Tor Lillqvist 
AuthorDate: Tue Mar 26 15:05:02 2019 +0200
Commit: Tor Lillqvist 
CommitDate: Tue Mar 26 15:53:18 2019 +0200

Add SaveAs2000() and SaveAs() to ooo.vba.word.XDocument and implement

Change-Id: If7e45e2f791a7806e6cf8e7fc9693e19e87d2dbb

diff --git a/oovbaapi/ooo/vba/word/XDocument.idl 
b/oovbaapi/ooo/vba/word/XDocument.idl
index 9259fc9fa4a9..888287b34e1b 100644
--- a/oovbaapi/ooo/vba/word/XDocument.idl
+++ b/oovbaapi/ooo/vba/word/XDocument.idl
@@ -61,6 +61,9 @@ interface XDocument
 void ClosePrintPreview();
 any Revisions( [in] any index );
 any Frames( [in] any index );
+void SaveAs2000( [in] any FileName, [in] any FileFormat, [in] any 
LockComments, [in] any Password, [in] any AddToRecentFiles, [in] any 
WritePassword, [in] any ReadOnlyRecommended, [in] any EmbedTrueTypeFonts, [in] 
any SaveNativePictureFormat, [in] any SaveFormsData, [in] any SaveAsAOCELetter 
);
+void SaveAs( [in] any FileName, [in] any FileFormat, [in] any 
LockComments, [in] any Password, [in] any AddToRecentFiles, [in] any 
WritePassword, [in] any ReadOnlyRecommended, [in] any EmbedTrueTypeFonts, [in] 
any SaveNativePictureFormat, [in] any SaveFormsData, [in] any SaveAsAOCELetter, 
[in] any Encoding, [in] any InsertLineBreaks, [in] any AllowSubstitutions, [in] 
any LineEnding, [in] any AddBiDiMarks );
+
 };
 
 }; }; };
diff --git a/sw/source/ui/vba/vbadocument.cxx b/sw/source/ui/vba/vbadocument.cxx
index eb3f5c2d011d..9b44c92c9176 100644
--- a/sw/source/ui/vba/vbadocument.cxx
+++ b/sw/source/ui/vba/vbadocument.cxx
@@ -33,9 +33,13 @@
 #include 
 #include 
 #include 
+#include 
 #include 
+#include 
 #include 
 #include 
+#include 
+#include 
 #include 
 
 #include 
@@ -450,6 +454,114 @@ SwVbaDocument::Frames( const uno::Any& index )
 return uno::makeAny( xCol );
 }
 
+namespace {
+
+bool setFilterPropsFromFormat( sal_Int32 nFormat, uno::Sequence< 
beans::PropertyValue >& rProps )
+{
+bool bRes = false;
+for ( sal_Int32 index = 0; index < rProps.getLength(); ++index )
+{
+if ( rProps[ index ].Name == "FilterName" )
+{
+switch( nFormat )
+{
+case word::WdSaveFormat::wdFormatDocument:
+rProps[ index ].Value <<= OUString("MS Word 97");
+break;
+// Just save all the text formats as "Text"
+case word::WdSaveFormat::wdFormatDOSText:
+case word::WdSaveFormat::wdFormatDOSTextLineBreaks:
+case word::WdSaveFormat::wdFormatEncodedText:
+case word::WdSaveFormat::wdFormatText:
+case word::WdSaveFormat::wdFormatTextLineBreaks:
+rProps[ index ].Value <<= OUString("Text");
+break;
+case word::WdSaveFormat::wdFormatFilteredHTML:
+case word::WdSaveFormat::wdFormatHTML:
+rProps[ index ].Value <<= OUString("HTML");
+break;
+case word::WdSaveFormat::wdFormatRTF:
+rProps[ index ].Value <<= OUString("Rich Text Format");
+break;
+case word::WdSaveFormat::wdFormatTemplate:
+rProps[ index ].Value <<= OUString("MS Word 97 Vorlage");
+break;
+
+// Default to "MS Word 97"
+default:
+rProps[ index ].Value <<= OUString("MS Word 97");
+break;
+}
+bRes = true;
+break;
+}
+}
+return bRes;
+}
+
+}
+
+void SAL_CALL
+SwVbaDocument::SaveAs2000( const uno::Any& FileName, const uno::Any& 
FileFormat, const uno::Any& /*LockComments*/, const uno::Any& /*Password*/, 
const uno::Any& /*AddToRecentFiles*/, const 

Re: LibreOffice Build failed in cppunit test for complex text

[Miklos Vajna]

Hi,

On Tue, Mar 26, 2019 at 03:07:52PM +0100, Lars Meyer  
wrote:
> VclComplexTextTest::testKashida finished in: 14ms
> complextext.cxx:153:Assertion

See if commit 3189d366497419d637042c12824601590542b2f1 helps.

Regards,

Miklos


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'feature/cib_contract57c' - vcl/win

[Samuel Mehrbrodt (via logerrit)]

 vcl/win/gdi/salfont.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 41caefc49159385bb4f224450311b0d9b5e55786
Author: Samuel Mehrbrodt 
AuthorDate: Tue Mar 26 15:08:12 2019 +0100
Commit: Samuel Mehrbrodt 
CommitDate: Tue Mar 26 15:08:12 2019 +0100

Fix windows build

After 54ac2b203a6dd974c0153996ba67b26d585e98e1

Change-Id: I805415dfa75568d843fceb5a79b637aac337ffd4

diff --git a/vcl/win/gdi/salfont.cxx b/vcl/win/gdi/salfont.cxx
index b0158f9154d5..d34fc8a33996 100644
--- a/vcl/win/gdi/salfont.cxx
+++ b/vcl/win/gdi/salfont.cxx
@@ -932,6 +932,7 @@ void WinSalGraphics::SetFont( const FontSelectPattern* 
pFont, int nFallbackLevel
 // WinSalGraphics::GetEmbedFontData does not set mpFontInstance
 // since it is interested in font file data only.
 mpWinFontEntry[ nFallbackLevel ] = reinterpret_cast( 
pFont->mpFontInstance.get() );
+WinFontInstance *pFontInstance = static_cast(pFont);
 
 HFONT hOldFont = nullptr;
 HFONT hNewFont = pFontInstance ? pFontInstance->GetHFONT() : nullptr;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

LibreOffice Build failed in cppunit test for complex text

[Lars Meyer]

Hello,

I tried to compile LibreOffice from a clean and current git checkout but
the build failed within the cppunit test for complex text. Here is the
error message from the shell:

[CUT] vcl_svm_test
[CUT] vcl_errorhandler
(anonymous namespace)::CanvasBitmapTest::runTest finished in: 607ms
VclComplexTextTest::testArabic finished in: 154ms
/home/lars/libregitrepos/libo2/vcl/qa/cppunit/complextext.cxx:153:VclComplexTextTest::testKashida
assertion failed
- Expression: pGlyphs

VclComplexTextTest::testKashida finished in: 14ms
complextext.cxx:153:Assertion
Test name: VclComplexTextTest::testKashida
assertion failed
- Expression: pGlyphs

Failures !!!
Run: 3   Failure total: 1   Failures: 1   Errors: 0


Is this a know issue? Is there a workaroud for this error?

Kind regards,
Lars

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: oovbaapi/ooo sw/source

[Tor Lillqvist (via logerrit)]

 oovbaapi/ooo/vba/word/XDocument.idl |3 
 sw/source/ui/vba/vbadocument.cxx|  113 
 sw/source/ui/vba/vbadocument.hxx|2 
 3 files changed, 118 insertions(+)

New commits:
commit 0f1458cff56e2be9614acc9357fd10099bb5e8ab
Author: Tor Lillqvist 
AuthorDate: Tue Mar 26 15:05:02 2019 +0200
Commit: Tor Lillqvist 
CommitDate: Tue Mar 26 15:55:04 2019 +0200

Add SaveAs2000() and SaveAs() to ooo.vba.word.XDocument and implement

Change-Id: If7e45e2f791a7806e6cf8e7fc9693e19e87d2dbb

diff --git a/oovbaapi/ooo/vba/word/XDocument.idl 
b/oovbaapi/ooo/vba/word/XDocument.idl
index 9259fc9fa4a9..888287b34e1b 100644
--- a/oovbaapi/ooo/vba/word/XDocument.idl
+++ b/oovbaapi/ooo/vba/word/XDocument.idl
@@ -61,6 +61,9 @@ interface XDocument
 void ClosePrintPreview();
 any Revisions( [in] any index );
 any Frames( [in] any index );
+void SaveAs2000( [in] any FileName, [in] any FileFormat, [in] any 
LockComments, [in] any Password, [in] any AddToRecentFiles, [in] any 
WritePassword, [in] any ReadOnlyRecommended, [in] any EmbedTrueTypeFonts, [in] 
any SaveNativePictureFormat, [in] any SaveFormsData, [in] any SaveAsAOCELetter 
);
+void SaveAs( [in] any FileName, [in] any FileFormat, [in] any 
LockComments, [in] any Password, [in] any AddToRecentFiles, [in] any 
WritePassword, [in] any ReadOnlyRecommended, [in] any EmbedTrueTypeFonts, [in] 
any SaveNativePictureFormat, [in] any SaveFormsData, [in] any SaveAsAOCELetter, 
[in] any Encoding, [in] any InsertLineBreaks, [in] any AllowSubstitutions, [in] 
any LineEnding, [in] any AddBiDiMarks );
+
 };
 
 }; }; };
diff --git a/sw/source/ui/vba/vbadocument.cxx b/sw/source/ui/vba/vbadocument.cxx
index 1b9f5169206d..8be412841206 100644
--- a/sw/source/ui/vba/vbadocument.cxx
+++ b/sw/source/ui/vba/vbadocument.cxx
@@ -28,15 +28,20 @@
 #include "vbabookmarks.hxx"
 #include "vbamailmerge.hxx"
 #include "vbavariables.hxx"
+#include 
 #include 
 #include 
 #include 
 #include 
 #include 
 #include 
+#include 
 #include 
+#include 
 #include 
 #include 
+#include 
+#include 
 #include 
 
 #include 
@@ -451,6 +456,114 @@ SwVbaDocument::Frames( const uno::Any& index )
 return uno::makeAny( xCol );
 }
 
+namespace {
+
+bool setFilterPropsFromFormat( sal_Int32 nFormat, uno::Sequence< 
beans::PropertyValue >& rProps )
+{
+bool bRes = false;
+for ( sal_Int32 index = 0; index < rProps.getLength(); ++index )
+{
+if ( rProps[ index ].Name == "FilterName" )
+{
+switch( nFormat )
+{
+case word::WdSaveFormat::wdFormatDocument:
+rProps[ index ].Value <<= OUString("MS Word 97");
+break;
+// Just save all the text formats as "Text"
+case word::WdSaveFormat::wdFormatDOSText:
+case word::WdSaveFormat::wdFormatDOSTextLineBreaks:
+case word::WdSaveFormat::wdFormatEncodedText:
+case word::WdSaveFormat::wdFormatText:
+case word::WdSaveFormat::wdFormatTextLineBreaks:
+rProps[ index ].Value <<= OUString("Text");
+break;
+case word::WdSaveFormat::wdFormatFilteredHTML:
+case word::WdSaveFormat::wdFormatHTML:
+rProps[ index ].Value <<= OUString("HTML");
+break;
+case word::WdSaveFormat::wdFormatRTF:
+rProps[ index ].Value <<= OUString("Rich Text Format");
+break;
+case word::WdSaveFormat::wdFormatTemplate:
+rProps[ index ].Value <<= OUString("MS Word 97 Vorlage");
+break;
+
+// Default to "MS Word 97"
+default:
+rProps[ index ].Value <<= OUString("MS Word 97");
+break;
+}
+bRes = true;
+break;
+}
+}
+return bRes;
+}
+
+}
+
+void SAL_CALL
+SwVbaDocument::SaveAs2000( const uno::Any& FileName, const uno::Any& 
FileFormat, const uno::Any& /*LockComments*/, const uno::Any& /*Password*/, 
const uno::Any& /*AddToRecentFiles*/, const uno::Any& /*WritePassword*/, const 
uno::Any& /*ReadOnlyRecommended*/, const uno::Any& /*EmbedTrueTypeFonts*/, 
const uno::Any& /*SaveNativePictureFormat*/, const uno::Any& /*SaveFormsData*/, 
const uno::Any& /*SaveAsAOCELetter*/ )
+{
+// Based on ScVbaWorkbook::SaveAs.
+OUString sFileName;
+FileName >>= sFileName;
+OUString sURL;
+osl::FileBase::getFileURLFromSystemPath( sFileName, sURL );
+
+// Detect if there is no path then we need to use the current folder.
+INetURLObject aURL( sURL );
+sURL = aURL.GetMainURL( INetURLObject::DecodeMechanism::ToIUri );
+if( sURL.isEmpty() )
+{
+// Need to add cur dir ( of this document ) or else the 'Work' dir
+sURL = getModel()->getURL();
+
+if ( sURL.isEmpty() )
+  

[Libreoffice-commits] online.git: loleaflet/src

[Libreoffice Gerrit user]

 loleaflet/src/layer/tile/TileLayer.js |   10 --
 1 file changed, 4 insertions(+), 6 deletions(-)

New commits:
commit a0797a751849ac93ea3703f3303132be619747c2
Author: Szymon Kłos 
AuthorDate: Sat Mar 23 14:51:27 2019 +0100
Commit: Szymon Kłos 
CommitDate: Tue Mar 26 15:03:37 2019 +0100

Make all pages accessible after zooming

After zooming scrollbar was updated and scroll
position was incorrect what caused first pages
not accessible.

Regression was introduced by:
ffd7151443ee360c7764aaa77f9e7fe5f5d64eee

Second problem was jumping to the cursor
during zooming. Solution was to not update
the cursors on zooming start.

Change-Id: I0891799b03ed4eccb211ee43eb30e546317a90fc
Reviewed-on: https://gerrit.libreoffice.org/69606
Reviewed-by: Szymon Kłos 
Tested-by: Szymon Kłos 
(cherry picked from commit f496c1e9c588b382fbdb10ae90a0cd85390274e8)
Reviewed-on: https://gerrit.libreoffice.org/69748

diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index 3ca9336f0..726cb622b 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -1588,14 +1588,12 @@ L.TileLayer = L.GridLayer.extend({
 
_onZoomStart: function () {
this._isZooming = true;
-   this._onUpdateCursor();
-   this.updateAllViewCursors();
},
 
 
_onZoomEnd: function () {
this._isZooming = false;
-   this._onUpdateCursor();
+   this._onUpdateCursor(null, true);
this.updateAllViewCursors();
},
 
@@ -1619,16 +1617,16 @@ L.TileLayer = L.GridLayer.extend({
},
 
// Update cursor layer (blinking cursor).
-   _onUpdateCursor: function (scroll) {
+   _onUpdateCursor: function (scroll, zoom) {
var cursorPos = this._visibleCursor.getNorthWest();
var docLayer = this._map._docLayer;
 
-   if ((scroll !== false) && 
!this._map.getBounds().contains(this._visibleCursor) && this._isCursorVisible) {
+   if ((!zoom && scroll !== false) && 
!this._map.getBounds().contains(this._visibleCursor) && this._isCursorVisible) {
var center = this._map.project(cursorPos);
center = 
center.subtract(this._map.getSize().divideBy(2));
center.x = Math.round(center.x < 0 ? 0 : center.x);
center.y = Math.round(center.y < 0 ? 0 : center.y);
-   if (!(this._selectionHandles.start && 
this._selectionHandles.start.isDragged) &&
+   if (!zoom && !(this._selectionHandles.start && 
this._selectionHandles.start.isDragged) &&
!(this._selectionHandles.end && 
this._selectionHandles.end.isDragged) &&
!(docLayer._followEditor || docLayer._followUser)) {
this._map.fire('scrollto', {x: center.x, y: 
center.y, calledFromInvalidateCursorMsg: scroll !== undefined});
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

[Libreoffice Gerrit user]

 loleaflet/src/control/toolbar.js |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6c94280b9c19d8c2ef6b3b61951145f212f03075
Author: Szymon Kłos 
AuthorDate: Tue Mar 26 15:02:13 2019 +0100
Commit: Szymon Kłos 
CommitDate: Tue Mar 26 15:02:41 2019 +0100

Fix doucument loading on mobile

Change-Id: I190b021101fb0bb371b65c666969701d71b024aa

diff --git a/loleaflet/src/control/toolbar.js b/loleaflet/src/control/toolbar.js
index 5ef4f62f0..7b068d771 100644
--- a/loleaflet/src/control/toolbar.js
+++ b/loleaflet/src/control/toolbar.js
@@ -1373,7 +1373,7 @@ function onWopiProps(e) {
$('#document-name-input').removeClass('editable');
$('#document-name-input').off('keypress', 
onDocumentNameKeyPress);
}
-   if (e.EnableInsertRemoteImage === true) {
+   if (e.EnableInsertRemoteImage === true && w2ui['editbar']) {
w2ui['editbar'].hide('insertgraphic');
w2ui['editbar'].show('menugraphic');
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: jvmfwk/README

[Stephan Bergmann (via logerrit)]

 jvmfwk/README |   11 +++
 1 file changed, 11 insertions(+)

New commits:
commit 6b8a96c421bc4766ed6c11791174689da86fa703
Author: Stephan Bergmann 
AuthorDate: Tue Mar 26 10:23:56 2019 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Mar 26 14:52:22 2019 +0100

Note when javavendors_*.xml  should be updated

Change-Id: I387e3c798feae864c046a9274c903b9aa679399b
Reviewed-on: https://gerrit.libreoffice.org/69731
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/jvmfwk/README b/jvmfwk/README
index 3c2b105cd207..7cb338e14f32 100644
--- a/jvmfwk/README
+++ b/jvmfwk/README
@@ -2,3 +2,14 @@ Wrappers so you can use all the Java Runtime Environments with 
their slightly in
 
 Used to use an over-engineered "plugin" mechanism although there was only one
 "plugin", called "sunmajor", that handles all possible JREs.
+
+IMPORTANT:  The  element in 
vmfwk/distributions/OpenOfficeorg/javavendors_*.xml files
+should only be updated for incompatible changes, not for compatible ones.  As 
stated in the commit
+message of  "javavendors_*.xml 
 should not have
+been updated...":  "Changing  causes jfw_startVM and 
jfw_getSelectedJRE (both
+jvmfwk/source/framework.cxx) to fail with JFW_E_INVALID_SETTINGS, which in 
turn causes functionality
+that requires a JVM to issue a GUI error dialog stating that the user must 
select a new JRE in the
+Options dialog.  While that behavior makes sense if a JRE was selected that 
would no longer be
+supported by the modified javavendors_*.xml, it is just annoying if an already 
selected JRE is still
+supported.  And a compatible change to javavendors_*.xml implies that an 
already selected JRE will
+still be supported."
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4' - loleaflet/src

[Libreoffice Gerrit user]

 loleaflet/src/layer/tile/TileLayer.js |   10 --
 1 file changed, 4 insertions(+), 6 deletions(-)

New commits:
commit f496c1e9c588b382fbdb10ae90a0cd85390274e8
Author: Szymon Kłos 
AuthorDate: Sat Mar 23 14:51:27 2019 +0100
Commit: Szymon Kłos 
CommitDate: Tue Mar 26 14:41:15 2019 +0100

Make all pages accessible after zooming

After zooming scrollbar was updated and scroll
position was incorrect what caused first pages
not accessible.

Regression was introduced by:
ffd7151443ee360c7764aaa77f9e7fe5f5d64eee

Second problem was jumping to the cursor
during zooming. Solution was to not update
the cursors on zooming start.

Change-Id: I0891799b03ed4eccb211ee43eb30e546317a90fc
Reviewed-on: https://gerrit.libreoffice.org/69606
Reviewed-by: Szymon Kłos 
Tested-by: Szymon Kłos 

diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index 643a9ba06..f39102829 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -1593,14 +1593,12 @@ L.TileLayer = L.GridLayer.extend({
 
_onZoomStart: function () {
this._isZooming = true;
-   this._onUpdateCursor();
-   this.updateAllViewCursors();
},
 
 
_onZoomEnd: function () {
this._isZooming = false;
-   this._onUpdateCursor();
+   this._onUpdateCursor(null, true);
this.updateAllViewCursors();
},
 
@@ -1624,16 +1622,16 @@ L.TileLayer = L.GridLayer.extend({
},
 
// Update cursor layer (blinking cursor).
-   _onUpdateCursor: function (scroll) {
+   _onUpdateCursor: function (scroll, zoom) {
var cursorPos = this._visibleCursor.getNorthWest();
var docLayer = this._map._docLayer;
 
-   if ((scroll !== false) && 
!this._map.getBounds().contains(this._visibleCursor) && this._isCursorVisible) {
+   if ((!zoom && scroll !== false) && 
!this._map.getBounds().contains(this._visibleCursor) && this._isCursorVisible) {
var center = this._map.project(cursorPos);
center = 
center.subtract(this._map.getSize().divideBy(2));
center.x = Math.round(center.x < 0 ? 0 : center.x);
center.y = Math.round(center.y < 0 ? 0 : center.y);
-   if (!(this._selectionHandles.start && 
this._selectionHandles.start.isDragged) &&
+   if (!zoom && !(this._selectionHandles.start && 
this._selectionHandles.start.isDragged) &&
!(this._selectionHandles.end && 
this._selectionHandles.end.isDragged) &&
!(docLayer._followEditor || docLayer._followUser)) {
if (window.ThisIsAMobileApp) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: officecfg/registry sc/inc sc/Library_sc.mk sc/qa sc/sdi sc/source sc/uiconfig sc/UIConfig_scalc.mk solenv/sanitizers

[Dennis Francis (via logerrit)]

 officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu |8 
 sc/Library_sc.mk  |1 
 sc/UIConfig_scalc.mk  |1 
 sc/inc/sc.hrc |1 
 sc/inc/strings.hrc|   17 
 sc/qa/unit/screenshots/data/screenshots.txt   |1 
 sc/sdi/cellsh.sdi |1 
 sc/sdi/scalc.sdi  |   17 
 sc/source/ui/StatisticsDialogs/FourierAnalysisDialog.cxx  |  247 +
 sc/source/ui/StatisticsDialogs/StatisticsInputOutputDialog.cxx|   28 
 sc/source/ui/app/scdll.cxx|1 
 sc/source/ui/inc/FourierAnalysisDialog.hxx|   60 +
 sc/source/ui/inc/StatisticsInputOutputDialog.hxx  |2 
 sc/source/ui/inc/reffact.hxx  |7 
 sc/source/ui/view/cellsh1.cxx |9 
 sc/source/ui/view/tabvwsh.cxx |1 
 sc/source/ui/view/tabvwshc.cxx|7 
 sc/uiconfig/scalc/menubar/menubar.xml |1 
 sc/uiconfig/scalc/ui/fourieranalysisdialog.ui |  423 
++
 sc/uiconfig/scalc/ui/notebookbar.ui   |7 
 sc/uiconfig/scalc/ui/notebookbar_compact.ui   |7 
 solenv/sanitizers/ui/modules/scalc.suppr  |1 
 22 files changed, 837 insertions(+), 11 deletions(-)

New commits:
commit 1b9f0e99f3ab0deb8ee2291b34c5c2e6a31de2d1
Author: Dennis Francis 
AuthorDate: Tue Mar 12 18:21:34 2019 +0530
Commit: Dennis Francis 
CommitDate: Tue Mar 26 14:33:23 2019 +0100

tdf#74664 : add Fourier analysis tool

Add Fourier analysis tool to Statistics submenu.
Use FOURIER() formula to do all the work here.

Change-Id: Ifdaa79d8ee367f1c1f5054248e01853ffe4c6823
Reviewed-on: https://gerrit.libreoffice.org/69472
Tested-by: Jenkins
Reviewed-by: Dennis Francis 

diff --git a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
index 996d3c1f029d..3a70c4f2fb2b 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
@@ -998,6 +998,14 @@
   1
 
   
+  
+
+  F~ourier Analysis...
+
+
+  1
+
+  
   
 
   ~Headers and Footers...
diff --git a/sc/Library_sc.mk b/sc/Library_sc.mk
index 9e67772d81f2..aa596d001a26 100644
--- a/sc/Library_sc.mk
+++ b/sc/Library_sc.mk
@@ -520,6 +520,7 @@ $(eval $(call gb_Library_add_exception_objects,sc,\
 sc/source/ui/StatisticsDialogs/ChiSquareTestDialog \
 sc/source/ui/StatisticsDialogs/DescriptiveStatisticsDialog \
 sc/source/ui/StatisticsDialogs/ExponentialSmoothingDialog \
+sc/source/ui/StatisticsDialogs/FourierAnalysisDialog \
 sc/source/ui/StatisticsDialogs/FTestDialog \
 sc/source/ui/StatisticsDialogs/MatrixComparisonGenerator \
 sc/source/ui/StatisticsDialogs/MovingAverageDialog \
diff --git a/sc/UIConfig_scalc.mk b/sc/UIConfig_scalc.mk
index 68f210509c2a..a80f9d2ea791 100644
--- a/sc/UIConfig_scalc.mk
+++ b/sc/UIConfig_scalc.mk
@@ -128,6 +128,7 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/scalc,\
sc/uiconfig/scalc/ui/footerdialog \
sc/uiconfig/scalc/ui/formatcellsdialog \
sc/uiconfig/scalc/ui/formulacalculationoptions \
+   sc/uiconfig/scalc/ui/fourieranalysisdialog \
sc/uiconfig/scalc/ui/floatingborderstyle \
sc/uiconfig/scalc/ui/floatinglinestyle \
sc/uiconfig/scalc/ui/functionpanel \
diff --git a/sc/inc/sc.hrc b/sc/inc/sc.hrc
index 52b945ea9441..c8388a4e3c8d 100644
--- a/sc/inc/sc.hrc
+++ b/sc/inc/sc.hrc
@@ -237,6 +237,7 @@
 #define SID_WINDOW_FIX_COL  (SC_MESSAGE_START + 85)
 #define SID_COLUMN_OPERATIONS   (SC_MESSAGE_START + 86)
 #define SID_ROW_OPERATIONS  (SC_MESSAGE_START + 87)
+#define SID_FOURIER_ANALYSIS_DIALOG (SC_MESSAGE_START + 88)
 
 // functions
 
diff --git a/sc/inc/strings.hrc b/sc/inc/strings.hrc
index f85aa46263f2..a3392a36b20c 100644
--- a/sc/inc/strings.hrc
+++ b/sc/inc/strings.hrc
@@ -289,6 +289,8 @@
 #define STR_CHI_SQUARE_TEST NC_("STR_CHI_SQUARE_TEST", 
"Test of Independence (Chi-Square)")
 #define STR_REGRESSION_UNDO_NAME
NC_("STR_REGRESSION_UNDO_NAME", "Regression")
 #define STR_REGRESSION  NC_("STR_REGRESSION", 
"Regression")
+#define STR_FOURIER_ANALYSIS_UNDO_NAME  
NC_("STR_FOURIER_ANALYSIS_UNDO_NAME", "Fourier 

[Libreoffice-commits] core.git: sc/inc sc/source

[Dennis Francis (via logerrit)]

 sc/inc/scfuncs.hrc   |4 +
 sc/source/core/data/funcdesc.cxx |2 
 sc/source/core/tool/interpr3.cxx |   79 +--
 sc/source/core/tool/parclass.cxx |2 
 sc/source/filter/excel/xlformula.cxx |2 
 sc/source/filter/oox/formulabase.cxx |2 
 6 files changed, 64 insertions(+), 27 deletions(-)

New commits:
commit 88b52d4ecc908a817211a5beb908df378cbf5fae
Author: Dennis Francis 
AuthorDate: Tue Mar 12 21:38:14 2019 +0530
Commit: Dennis Francis 
CommitDate: Tue Mar 26 14:30:09 2019 +0100

tdf#74664: FOURIER: add 5th optional parameter MinimumMagnitude

This parameter is used only if Polar=TRUE.
All frequency components with magnitude less than MinimumMagnitude
will be suppressed with a zero magnitude-phase entry.
This is very useful when looking at the magnitude-phase spectrum
of a signal because there is always some very tiny amount of rounding
error when doing FFT algorithms and results in incorrect non-zero
phase for non-existent frequencies. By providing a suitable value to
this parameter, these non-existent frequency components can be filtered
out. By default the value of this 5th parameter is 0.0, so *no*
suppression is done by default.

Change-Id: I422ad1bf91f42b320e98e58a19c99bf8528e4708
Reviewed-on: https://gerrit.libreoffice.org/69471
Tested-by: Jenkins
Reviewed-by: Dennis Francis 

diff --git a/sc/inc/scfuncs.hrc b/sc/inc/scfuncs.hrc
index f0f06eee6427..e17eb9250c65 100644
--- a/sc/inc/scfuncs.hrc
+++ b/sc/inc/scfuncs.hrc
@@ -4129,7 +4129,9 @@ const char* SC_OPCODE_FOURIER_ARY[] =
 NC_("SC_OPCODE_FOURIER", "Inverse"),
 NC_("SC_OPCODE_FOURIER", "Flag to indicate whether an inverse DFT is to be 
computed (default FALSE)."),
 NC_("SC_OPCODE_FOURIER", "Polar"),
-NC_("SC_OPCODE_FOURIER", "Flag to indicate whether to return the results 
in polar form (default FALSE).")
+NC_("SC_OPCODE_FOURIER", "Flag to indicate whether to return the results 
in polar form (default FALSE)."),
+NC_("SC_OPCODE_FOURIER", "MinimumMagnitude"),
+NC_("SC_OPCODE_FOURIER", "In case of Polar=TRUE, the frequency components 
below this magnitude are clipped out (default 0.0).")
 };
 
 #endif
diff --git a/sc/source/core/data/funcdesc.cxx b/sc/source/core/data/funcdesc.cxx
index a5cc499e44df..4679f3e029b4 100644
--- a/sc/source/core/data/funcdesc.cxx
+++ b/sc/source/core/data/funcdesc.cxx
@@ -788,7 +788,7 @@ ScFunctionList::ScFunctionList()
 { SC_OPCODE_FINDB, ENTRY(SC_OPCODE_FINDB_ARY), 0, 
ID_FUNCTION_GRP_TEXT, HID_FUNC_FINDB, 3, { 0, 0, 1 } },
 { SC_OPCODE_SEARCHB, ENTRY(SC_OPCODE_SEARCHB_ARY), 0, 
ID_FUNCTION_GRP_TEXT, HID_FUNC_SEARCHB, 3, { 0, 0, 1 } },
 { SC_OPCODE_REGEX, ENTRY(SC_OPCODE_REGEX_ARY), 0, 
ID_FUNCTION_GRP_TEXT, HID_FUNC_REGEX, 4, { 0, 0, 1, 1 } },
-{ SC_OPCODE_FOURIER, ENTRY(SC_OPCODE_FOURIER_ARY), 0, 
ID_FUNCTION_GRP_MATRIX, HID_FUNC_FOURIER, 4, { 0, 0, 1, 1 } }
+{ SC_OPCODE_FOURIER, ENTRY(SC_OPCODE_FOURIER_ARY), 0, 
ID_FUNCTION_GRP_MATRIX, HID_FUNC_FOURIER, 5, { 0, 0, 1, 1, 1 } }
 };
 
 ScFuncDesc* pDesc = nullptr;
diff --git a/sc/source/core/tool/interpr3.cxx b/sc/source/core/tool/interpr3.cxx
index bd21be239f92..517e2d258f70 100644
--- a/sc/source/core/tool/interpr3.cxx
+++ b/sc/source/core/tool/interpr3.cxx
@@ -4902,12 +4902,14 @@ class ScComplexFFT2
 public:
 // rfArray.size() would always be even and a power of 2. (asserted in 
prepare())
 // rfArray's first half contains the real parts and the later half 
contains the imaginary parts.
-ScComplexFFT2(std::vector& raArray, bool bInverse, bool bPolar, 
ScTwiddleFactors& rTF, bool bSubSampleTFs = false, bool bDisableNormalize = 
false) :
+ScComplexFFT2(std::vector& raArray, bool bInverse, bool bPolar, 
double fMinMag,
+  ScTwiddleFactors& rTF, bool bSubSampleTFs = false, bool 
bDisableNormalize = false) :
 mrArray(raArray),
 mfWReal(rTF.mfWReal),
 mfWImag(rTF.mfWImag),
 mnPoints(raArray.size()/2),
 mnStages(0),
+mfMinMag(fMinMag),
 mbInverse(bInverse),
 mbPolar(bPolar),
 mbDisableNormalize(bDisableNormalize),
@@ -4977,6 +4979,7 @@ private:
 std::vector& mfWImag;
 SCSIZE mnPoints;
 SCSIZE mnStages;
+double mfMinMag;
 bool mbInverse:1;
 bool mbPolar:1;
 bool mbDisableNormalize:1;
@@ -5023,7 +5026,7 @@ static void lcl_normalize(std::vector& 
rCmplxArray, bool bScaleOnlyReal)
 }
 }
 
-static void lcl_convertToPolar(std::vector& rCmplxArray)
+static void lcl_convertToPolar(std::vector& rCmplxArray, double 
fMinMag)
 {
 const SCSIZE nPoints = rCmplxArray.size()/2;
 double fMag, fPhase, fR, fI;
@@ -5031,8 +5034,16 @@ static void lcl_convertToPolar(std::vector& 
rCmplxArray)
 {
 fR = rCmplxArray[nIdx];
 fI = rCmplxArray[nPoints+nIdx];
-fPhase = atan2(fI, fR);
 fMag = 

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - sfx2/source test/source

[Samuel Mehrbrodt (via logerrit)]

 sfx2/source/sidebar/SidebarController.cxx |9 -
 test/source/sheet/xviewsplitable.cxx  |4 ++--
 2 files changed, 10 insertions(+), 3 deletions(-)

New commits:
commit bff470b5826b6c76d34ea6f5b78b41245632374d
Author: Samuel Mehrbrodt 
AuthorDate: Fri Mar 22 16:17:11 2019 +0100
Commit: Thorsten Behrens 
CommitDate: Tue Mar 26 14:13:49 2019 +0100

Related tdf#124263 Make sure sidebar is wide enough for content

If panel's requested minimal size is smaller than current sidebar width,
enlarge the sidebar to fit the content.

Change-Id: I9baa4ef6c01d5563951d4df0d939883fce02e87b
Reviewed-on: https://gerrit.libreoffice.org/69561
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt 
(cherry picked from commit a58391b1f61db702a5246c5a33717cbba68c5252)
Reviewed-on: https://gerrit.libreoffice.org/69698
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/sfx2/source/sidebar/SidebarController.cxx 
b/sfx2/source/sidebar/SidebarController.cxx
index aa30d5cc185e..1121dcea1d32 100644
--- a/sfx2/source/sidebar/SidebarController.cxx
+++ b/sfx2/source/sidebar/SidebarController.cxx
@@ -1195,9 +1195,16 @@ void SidebarController::RestrictWidth (sal_Int32 nWidth)
 {
 const sal_uInt16 nId (pSplitWindow->GetItemId(mpParentWindow.get()));
 const sal_uInt16 nSetId (pSplitWindow->GetSet(nId));
+const sal_Int32 nRequestedWidth
+= (TabBar::GetDefaultWidth() + nWidth) * 
mpTabBar->GetDPIScaleFactor();
+
+// Make sure the sidebar is wide enough to fit the requested content
+if (pSplitWindow->GetSizePixel().Width() < nRequestedWidth)
+SetChildWindowWidth(nRequestedWidth);
+
 pSplitWindow->SetItemSizeRange(
 nSetId,
-Range(TabBar::GetDefaultWidth() * mpTabBar->GetDPIScaleFactor() + 
nWidth,
+Range(nRequestedWidth,
   getMaximumWidth() * mpTabBar->GetDPIScaleFactor()));
 }
 }
diff --git a/test/source/sheet/xviewsplitable.cxx 
b/test/source/sheet/xviewsplitable.cxx
index 7dd18aed2ebb..d88122f584f6 100644
--- a/test/source/sheet/xviewsplitable.cxx
+++ b/test/source/sheet/xviewsplitable.cxx
@@ -23,12 +23,12 @@ void XViewSplitable::testSplit()
 uno::Reference< sheet::XViewSplitable > xViewSplitable(init(), 
UNO_QUERY_THROW);
 CPPUNIT_ASSERT_MESSAGE("View is already split", 
!xViewSplitable->getIsWindowSplit());
 
-xViewSplitable->splitAtPosition(101, 51);
+xViewSplitable->splitAtPosition(90, 51);
 
 CPPUNIT_ASSERT_MESSAGE("View wasn't split", 
xViewSplitable->getIsWindowSplit());
 
 CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong horizontal pixel position",
- sal_Int32(101), 
xViewSplitable->getSplitHorizontal());
+ sal_Int32(90), 
xViewSplitable->getSplitHorizontal());
 CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong vertical pixel position",
  sal_Int32(51), 
xViewSplitable->getSplitVertical());
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - 2 commits - include/sfx2 include/svx offapi/com officecfg/registry sfx2/source svx/source

[Samuel Mehrbrodt (via logerrit)]

 include/sfx2/sidebar/SidebarController.hxx |6 +-
 include/svx/sidebar/PanelLayout.hxx|1 
 offapi/com/sun/star/ui/XSidebarPanel.idl   |7 ++
 officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs |   12 +
 sfx2/source/sidebar/DeckLayouter.cxx   |   24 
+-
 sfx2/source/sidebar/SidebarController.cxx  |4 +
 svx/source/sidebar/PanelLayout.cxx |   13 -
 7 files changed, 60 insertions(+), 7 deletions(-)

New commits:
commit 5d191ab972456808dcf2a4036dfb4e34529c3117
Author: Samuel Mehrbrodt 
AuthorDate: Fri Mar 22 11:39:18 2019 +0100
Commit: Thorsten Behrens 
CommitDate: Tue Mar 26 14:13:35 2019 +0100

tdf#124263 Respect XSidebarPanel::getMinimalWidth

even if it's larger than max sidebar width (increase max sidebar width in 
that case).

Change-Id: I2efbd546596f756df205196fae3e545beddd2f7c
Reviewed-on: https://gerrit.libreoffice.org/69551
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt 
(cherry picked from commit d0c73ce13c02c37fcc094ac6612d6a8eee2a4026)
Reviewed-on: https://gerrit.libreoffice.org/69647
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/include/sfx2/sidebar/SidebarController.hxx 
b/include/sfx2/sidebar/SidebarController.hxx
index 4889b0ad1630..866b8f2c50e1 100644
--- a/include/sfx2/sidebar/SidebarController.hxx
+++ b/include/sfx2/sidebar/SidebarController.hxx
@@ -165,6 +165,7 @@ public:
 tools::Rectangle GetDeckDragArea() const;
 
 sal_Int32 getMaximumWidth() { return mnMaximumSidebarWidth; }
+void setMaximumWidth(sal_Int32 nMaximumWidth) { mnMaximumSidebarWidth = 
nMaximumWidth; }
 
 private:
 SidebarController(
diff --git a/offapi/com/sun/star/ui/XSidebarPanel.idl 
b/offapi/com/sun/star/ui/XSidebarPanel.idl
index aa60b328a611..da8f19aa609f 100644
--- a/offapi/com/sun/star/ui/XSidebarPanel.idl
+++ b/offapi/com/sun/star/ui/XSidebarPanel.idl
@@ -40,7 +40,12 @@ interface XSidebarPanel
 */
 LayoutSize getHeightForWidth ( [in] long nWidth);
 
-/** Minimal possible width of this panel.
+/** Minimal possible width of this panel in pixels.
+
+If this value is smaller than the maximum allowed size of the Sidebar
+(see config option 
'org.openoffice.Office.UI.Sidebar.General.MaximumWidth'),
+the config option will be ignored and the new maximum Sidebar width 
will be
+getMinimalWidth() + 100px.
 */
 long getMinimalWidth();
 } ;
diff --git a/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs 
b/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs
index 2eeed4534040..6ed1d79d80cf 100644
--- a/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs
@@ -237,7 +237,8 @@
   
   
 
-  Maximum width the sidebar can ever have
+  Maximum width the sidebar can have.
+  Note that this can be overridden by extensions returning a larger 
value in XSidebarPanel::getMinimalWidth()
 
 500
   
diff --git a/sfx2/source/sidebar/DeckLayouter.cxx 
b/sfx2/source/sidebar/DeckLayouter.cxx
index 2b7f7df382b5..104b52ec9c8a 100644
--- a/sfx2/source/sidebar/DeckLayouter.cxx
+++ b/sfx2/source/sidebar/DeckLayouter.cxx
@@ -22,10 +22,17 @@
 #include 
 #include 
 #include 
+#include 
 
+#include 
 #include 
 #include 
 
+#include 
+#include 
+#include 
+#include 
+
 using namespace css;
 using namespace css::uno;
 
@@ -376,8 +383,23 @@ void GetRequestedSizes (
 if (xPanel.is())
 {
 aLayoutSize = 
xPanel->getHeightForWidth(rContentBox.GetWidth());
-
 sal_Int32 nWidth = xPanel->getMinimalWidth();
+
+uno::Reference xDesktop
+= 
frame::Desktop::create(comphelper::getProcessComponentContext());
+uno::Reference xFrame = 
xDesktop->getActiveFrame();
+if (xFrame.is())
+{
+SidebarController* pController
+= 
SidebarController::GetSidebarControllerForFrame(xFrame);
+if (pController && pController->getMaximumWidth() < 
nWidth)
+{
+// Add 100 extra pixels to still have the sidebar 
resizable
+// (See also documentation of 
XSidebarPanel::getMinimalWidth)
+pController->setMaximumWidth(nWidth + 100);
+}
+}
+
 if (nWidth > rMinimalWidth)
 rMinimalWidth = nWidth;
 }
commit 5e1c7da329e10ff2d9d394b7663f1376ced69452
Author: Samuel Mehrbrodt 
AuthorDate: Fri Mar 22 08:06:25 2019 +0100
Commit: Thorsten Behrens 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sw/source

[Samuel Mehrbrodt (via logerrit)]

 sw/source/uibase/uno/unotxdoc.cxx |   22 --
 1 file changed, 12 insertions(+), 10 deletions(-)

New commits:
commit 97ff2b5fb8d3f6812c7d2f0a59d1accbff03c468
Author: Samuel Mehrbrodt 
AuthorDate: Mon Mar 25 16:35:40 2019 +0100
Commit: Thorsten Behrens 
CommitDate: Tue Mar 26 14:12:23 2019 +0100

tdf#124025 Update formula before printing

Reintroduce the UpdateFields call, but guard it so that
it does not modify the doc (as it was before)

Change-Id: I23e814f0b5d900d145dc82272034f03e66c079ed
Reviewed-on: https://gerrit.libreoffice.org/69696
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt 
(cherry picked from commit 055480aac88e4688619e9a7815e0a8b0ab97a5a1)
Reviewed-on: https://gerrit.libreoffice.org/69727
Reviewed-by: Thorsten Behrens 

diff --git a/sw/source/uibase/uno/unotxdoc.cxx 
b/sw/source/uibase/uno/unotxdoc.cxx
index 8ee3a4aa689c..f8b476133672 100644
--- a/sw/source/uibase/uno/unotxdoc.cxx
+++ b/sw/source/uibase/uno/unotxdoc.cxx
@@ -2621,24 +2621,26 @@ sal_Int32 SAL_CALL SwXTextDocument::getRendererCount(
 // since printing now also use the API for PDF export this option
 // should be set for printing as well ...
 pViewShell->SetPDFExportOption( true );
-bool bOrigStatus = pRenderDocShell->IsEnableSetModified();
-// check configuration: shall update of printing information in 
DocInfo set the document to "modified"?
+
+// there is some redundancy between those two function calls, but 
right now
+// there is no time to sort this out.
+//TODO: check what exactly needs to be done and make just one 
function for that
+pViewShell->CalcLayout();
+pViewShell->CalcPagesForPrint( pViewShell->GetPageCount() );
+
+
+// #122919# Force field update before PDF export, but after layout 
init (tdf#121962)
 bool bStateChanged = false;
-if ( bOrigStatus && 
!SvtPrintWarningOptions().IsModifyDocumentOnPrintingAllowed() )
+// check configuration: shall update of printing information in 
DocInfo set the document to "modified"?
+if ( pRenderDocShell->IsEnableSetModified() && 
!SvtPrintWarningOptions().IsModifyDocumentOnPrintingAllowed() )
 {
 pRenderDocShell->EnableSetModified( false );
 bStateChanged = true;
 }
-
+pViewShell->SwViewShell::UpdateFields(true);
 if( bStateChanged )
 pRenderDocShell->EnableSetModified();
 
-// there is some redundancy between those two function calls, but 
right now
-// there is no time to sort this out.
-//TODO: check what exactly needs to be done and make just one 
function for that
-pViewShell->CalcLayout();
-pViewShell->CalcPagesForPrint( pViewShell->GetPageCount() );
-
 pViewShell->SetPDFExportOption( false );
 
 // enable view again
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - i18npool/source

[Eike Rathke (via logerrit)]

 i18npool/source/localedata/data/kmr_Latn_TR.xml |   13 ++---
 1 file changed, 10 insertions(+), 3 deletions(-)

New commits:
commit 4847c10452427bbbfd864572e6e06b3297158832
Author: Eike Rathke 
AuthorDate: Mon Mar 25 22:33:03 2019 +0100
Commit: Caolán McNamara 
CommitDate: Tue Mar 26 14:07:10 2019 +0100

Assign [kmr-Latn-TR] TRY|₺ currency, TRY|YTL and TRL|TL are legacyOnly

This was done long ago for the tr-TR locale as well.

Change-Id: I5bf8595f6d49adb7fd76b3c4924c4d72b3b8ea5e
Reviewed-on: https://gerrit.libreoffice.org/69717
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit 4ca9db953d59d93ce8e3a54a36d23ed52b9c62a9)
Reviewed-on: https://gerrit.libreoffice.org/69722
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/i18npool/source/localedata/data/kmr_Latn_TR.xml 
b/i18npool/source/localedata/data/kmr_Latn_TR.xml
index 2762df9e630f..a566c67170b9 100644
--- a/i18npool/source/localedata/data/kmr_Latn_TR.xml
+++ b/i18npool/source/localedata/data/kmr_Latn_TR.xml
@@ -52,7 +52,7 @@
 PN
 US
   
-  
+  
 M/D
 
   General
@@ -335,14 +335,21 @@
 
   
   
-
+
+  TRY
+  ₺
+  TRY
+  Türk Lirası
+  2
+
+
   TRY
   YTL
   TRY
   Yeni Türk Lirası
   2
 
-
+
   TRL
   TL
   TRL
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - include/vcl vcl/source

[Jan Holesovsky (via logerrit)]

 include/vcl/pdfread.hxx|5 +
 vcl/source/filter/ipdf/pdfread.cxx |  121 +++--
 vcl/source/gdi/impgraph.cxx|   40 +++-
 3 files changed, 93 insertions(+), 73 deletions(-)

New commits:
commit 6a96ea6378986ad7a8951dde583ae590edae1a65
Author: Jan Holesovsky 
AuthorDate: Fri Jun 22 00:44:44 2018 +0200
Commit: Jan Holesovsky 
CommitDate: Tue Mar 26 13:56:08 2019 +0100

pdfium: Keep the PDF data in memory, so that we can really share them.

Otherwise the swap out / swap in creates new copy of the underlying PDF
stream.

Change-Id: I88a16a69143783a998201e183bea1a9553e337bd
Reviewed-on: https://gerrit.libreoffice.org/56266
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
Reviewed-on: https://gerrit.libreoffice.org/69626
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/include/vcl/pdfread.hxx b/include/vcl/pdfread.hxx
index 1a1ff0d680cb..c491f50ef34b 100644
--- a/include/vcl/pdfread.hxx
+++ b/include/vcl/pdfread.hxx
@@ -16,6 +16,11 @@
 
 namespace vcl
 {
+/// Fills the rBitmaps vector with rendered pages.
+VCL_DLLPUBLIC size_t RenderPDFBitmaps(const void* pBuffer, int nSize, 
std::vector& rBitmaps,
+  const size_t nFirstPage = 0, int nPages 
= 1,
+  const double fResolutionDPI = 96.);
+
 /// Imports a PDF stream into rGraphic as a GDIMetaFile.
 VCL_DLLPUBLIC bool ImportPDF(SvStream& rStream, Bitmap& rBitmap, size_t 
nPageIndex,
  css::uno::Sequence& rPdfData,
diff --git a/vcl/source/filter/ipdf/pdfread.cxx 
b/vcl/source/filter/ipdf/pdfread.cxx
index ab70a0451d9d..16cb902e2476 100644
--- a/vcl/source/filter/ipdf/pdfread.cxx
+++ b/vcl/source/filter/ipdf/pdfread.cxx
@@ -63,68 +63,12 @@ size_t generatePreview(SvStream& rStream, 
std::vector& rBitmaps,
const size_t nFirstPage = 0, int nPages = 1,
const double fResolutionDPI = 96.)
 {
-FPDF_LIBRARY_CONFIG aConfig;
-aConfig.version = 2;
-aConfig.m_pUserFontPaths = nullptr;
-aConfig.m_pIsolate = nullptr;
-aConfig.m_v8EmbedderSlot = 0;
-FPDF_InitLibraryWithConfig();
-
 // Read input into a buffer.
 SvMemoryStream aInBuffer;
 rStream.Seek(nPos);
 aInBuffer.WriteStream(rStream, nSize);
 
-// Load the buffer using pdfium.
-FPDF_DOCUMENT pPdfDocument = FPDF_LoadMemDocument(aInBuffer.GetData(), 
aInBuffer.GetSize(), /*password=*/nullptr);
-if (!pPdfDocument)
-return 0;
-
-const int nPageCount = FPDF_GetPageCount(pPdfDocument);
-if (nPages <= 0)
-nPages = nPageCount;
-const size_t nLastPage = std::min(nPageCount, nFirstPage + nPages) - 
1;
-for (size_t nPageIndex = nFirstPage; nPageIndex <= nLastPage; ++nPageIndex)
-{
-// Render next page.
-FPDF_PAGE pPdfPage = FPDF_LoadPage(pPdfDocument, nPageIndex);
-if (!pPdfPage)
-break;
-
-// Returned unit is points, convert that to pixel.
-const size_t nPageWidth = pointToPixel(FPDF_GetPageWidth(pPdfPage), 
fResolutionDPI);
-const size_t nPageHeight = pointToPixel(FPDF_GetPageHeight(pPdfPage), 
fResolutionDPI);
-FPDF_BITMAP pPdfBitmap = FPDFBitmap_Create(nPageWidth, nPageHeight, 
/*alpha=*/1);
-if (!pPdfBitmap)
-break;
-
-const FPDF_DWORD nColor = FPDFPage_HasTransparency(pPdfPage) ? 
0x : 0x;
-FPDFBitmap_FillRect(pPdfBitmap, 0, 0, nPageWidth, nPageHeight, nColor);
-FPDF_RenderPageBitmap(pPdfBitmap, pPdfPage, /*start_x=*/0, 
/*start_y=*/0, nPageWidth, nPageHeight, /*rotate=*/0, /*flags=*/0);
-
-// Save the buffer as a bitmap.
-Bitmap aBitmap(Size(nPageWidth, nPageHeight), 24);
-{
-Bitmap::ScopedWriteAccess pWriteAccess(aBitmap);
-const auto pPdfBuffer = 
static_cast(FPDFBitmap_GetBuffer(pPdfBitmap));
-const int nStride = FPDFBitmap_GetStride(pPdfBitmap);
-for (size_t nRow = 0; nRow < nPageHeight; ++nRow)
-{
-ConstScanline pPdfLine = pPdfBuffer + (nStride * nRow);
-// pdfium byte order is BGRA.
-pWriteAccess->CopyScanline(nRow, pPdfLine, 
ScanlineFormat::N32BitTcBgra, nStride);
-}
-}
-
-rBitmaps.emplace_back(std::move(aBitmap));
-FPDFBitmap_Destroy(pPdfBitmap);
-FPDF_ClosePage(pPdfPage);
-}
-
-FPDF_CloseDocument(pPdfDocument);
-FPDF_DestroyLibrary();
-
-return rBitmaps.size();
+return vcl::RenderPDFBitmaps(aInBuffer.GetData(), aInBuffer.GetSize(), 
rBitmaps, nFirstPage, nPages, fResolutionDPI);
 }
 
 /// Decide if PDF data is old enough to be compatible.
@@ -211,6 +155,69 @@ bool getCompatibleStream(SvStream& rInStream, SvStream& 
rOutStream,
 namespace vcl
 {
 
+size_t RenderPDFBitmaps(const void* pBuffer, int nSize, std::vector& 
rBitmaps,
+  

[Libreoffice-commits] core.git: vcl/qa

[Miklos Vajna (via logerrit)]

 vcl/qa/cppunit/complextext.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 3189d366497419d637042c12824601590542b2f1
Author: Miklos Vajna 
AuthorDate: Tue Mar 26 12:24:19 2019 +0100
Commit: Miklos Vajna 
CommitDate: Tue Mar 26 13:52:25 2019 +0100

CppunitTest_vcl_complextext: work around lo_daily_update_gandalf failure

I'm not sure why #if HAVE_MORE_FONTS guard is not enough, but in any
case, the purpose of the test is to see if the final assert succeeds or
not, so if layout fails completely, that's not interesting here.

Change-Id: Ie663f82b86e101167cd7317d25345b2d48960cbb
Reviewed-on: https://gerrit.libreoffice.org/69736
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/vcl/qa/cppunit/complextext.cxx b/vcl/qa/cppunit/complextext.cxx
index 99b05481ed01..2009c6a67aa8 100644
--- a/vcl/qa/cppunit/complextext.cxx
+++ b/vcl/qa/cppunit/complextext.cxx
@@ -150,7 +150,9 @@ void VclComplexTextTest::testKashida()
 std::unique_ptr pLayout = pOutputDevice->ImplLayout(
 aText, 0, aText.getLength(), Point(0, 0), 0, nullptr, 
SalLayoutFlags::GlyphItemsOnly);
 const SalLayoutGlyphs* pGlyphs = pLayout->GetGlyphs();
-CPPUNIT_ASSERT(pGlyphs);
+if (!pGlyphs)
+// Failed in some non-interesting ways.
+return;
 SalLayoutGlyphs aGlyphs = *pGlyphs;
 
 // Now lay it out using the cached glyph list.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

[Libreoffice Gerrit user]

 loleaflet/src/control/Control.LokDialog.js |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 397249b9f3c41bc506ac116283aa34a1e5fdd883
Author: Tomaž Vajngerl 
AuthorDate: Tue Mar 26 21:02:01 2019 +0900
Commit: Tomaž Vajngerl 
CommitDate: Tue Mar 26 21:16:07 2019 +0900

allow to pan outside of widget bounds

Always pass firstTouchPosition{X,Y} instead of current X,Y
position to _postWindowGestureEvent so that panning is continued
even when you go out of widget (combobox) bounds.

Change-Id: I769b013f933881d8d1294ffd094e1cf7871cb701

diff --git a/loleaflet/src/control/Control.LokDialog.js 
b/loleaflet/src/control/Control.LokDialog.js
index 68216fb1f..23186e681 100644
--- a/loleaflet/src/control/Control.LokDialog.js
+++ b/loleaflet/src/control/Control.LokDialog.js
@@ -687,14 +687,14 @@ L.Control.LokDialog = L.Control.extend({
}
else if (e.type === 'touchend')
{
-   this._postWindowGestureEvent(childId, 'panEnd', 
touchX, touchY, touchY - firstTouchPositionY);
+   this._postWindowGestureEvent(childId, 'panEnd', 
firstTouchPositionX, firstTouchPositionY, touchY - firstTouchPositionY);
firstTouchPositionX = null;
firstTouchPositionY = null;
 
}
else if (e.type === 'touchmove')
{
-   this._postWindowGestureEvent(childId, 
'panUpdate', touchX, touchY, touchY - firstTouchPositionY);
+   this._postWindowGestureEvent(childId, 
'panUpdate', firstTouchPositionX, firstTouchPositionY, touchY - 
firstTouchPositionY);
}
}, this);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/uiconfig sd/uiconfig sw/uiconfig

[Thorsten Behrens (via logerrit)]

 sc/uiconfig/scalc/ui/notebookbar.ui   |8 
 sc/uiconfig/scalc/ui/notebookbar_compact.ui   |   16 -
 sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui|8 
 sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui   |   24 --
 sd/uiconfig/sdraw/ui/notebookbar.ui   |8 
 sd/uiconfig/sdraw/ui/notebookbar_groupedbar_compact.ui|8 
 sd/uiconfig/simpress/ui/notebookbar.ui|8 
 sd/uiconfig/simpress/ui/notebookbar_groupedbar_compact.ui |8 
 sd/uiconfig/simpress/ui/notebookbar_groupedbar_full.ui|   24 --
 sw/uiconfig/swriter/ui/notebookbar.ui |8 
 sw/uiconfig/swriter/ui/notebookbar_compact.ui |8 
 sw/uiconfig/swriter/ui/notebookbar_groupedbar_compact.ui  |8 
 sw/uiconfig/swriter/ui/notebookbar_groupedbar_full.ui |   16 -
 13 files changed, 152 deletions(-)

New commits:
commit 98174e163348ab44461f114142bc546e97720eec
Author: Thorsten Behrens 
AuthorDate: Tue Mar 26 11:56:40 2019 +0100
Commit: Thorsten Behrens 
CommitDate: Tue Mar 26 13:37:28 2019 +0100

tdf#122989 remove update check from notebookbar for the moment

Temp fix, since update check is an extension, and extensions can't
currently modify notebookbars.

This needs implementation of something like

https://wiki.openoffice.org/wiki/Framework/Article/Addon_Menu_Toolbar_Merging
for notebookbar popup menus. Such that Addons.xcs provide some merge
points with notebookbar menu IDs, we can then plug into existing popup
menus.

Change-Id: If30525fec1e7be0429e351588614618c5f56cdd4
Reviewed-on: https://gerrit.libreoffice.org/69735
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/sc/uiconfig/scalc/ui/notebookbar.ui 
b/sc/uiconfig/scalc/ui/notebookbar.ui
index 678e0756c0c6..ee4435c6f4ba 100644
--- a/sc/uiconfig/scalc/ui/notebookbar.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar.ui
@@ -779,14 +779,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
diff --git a/sc/uiconfig/scalc/ui/notebookbar_compact.ui 
b/sc/uiconfig/scalc/ui/notebookbar_compact.ui
index ac6e9c0f97d9..1301829c7932 100644
--- a/sc/uiconfig/scalc/ui/notebookbar_compact.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar_compact.ui
@@ -850,14 +850,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
@@ -1671,14 +1663,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
diff --git a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui 
b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui
index 050b76b06fe0..b9b46f1bf409 100644
--- a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui
@@ -2493,14 +2493,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for 
Updates...
-  
-
-
   
 True
 False
diff --git a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui 
b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui
index 2711a049b315..6f8d64726a1c 100644
--- a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_full.ui
@@ -1748,14 +1748,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
@@ -2455,14 +2447,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
@@ -2880,14 +2864,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
diff --git a/sd/uiconfig/sdraw/ui/notebookbar.ui 
b/sd/uiconfig/sdraw/ui/notebookbar.ui
index 95ac1e833e58..f3d9aff2aaf1 100644
--- a/sd/uiconfig/sdraw/ui/notebookbar.ui
+++ b/sd/uiconfig/sdraw/ui/notebookbar.ui
@@ -764,14 +764,6 @@
   
 
 
-  
-True
-False
-vnd.sun.star.job:alias=UpdateCheck
-_Check for Updates...
-  
-
-
   
 True
 False
diff --git a/sd/uiconfig/sdraw/ui/notebookbar_groupedbar_compact.ui 
b/sd/uiconfig/sdraw/ui/notebookbar_groupedbar_compact.ui
index 58923f5f0b6a..f8f1da662c9e 100644
--- 

[Libreoffice-commits] core.git: sc/inc sc/source sc/uiconfig

[Caolán McNamara (via logerrit)]

 sc/inc/scabstdlg.hxx  |5 
 sc/source/ui/attrdlg/scdlgfact.cxx|   14 -
 sc/source/ui/attrdlg/scdlgfact.hxx|   12 
 sc/source/ui/dbgui/pfiltdlg.cxx   |  393 +-
 sc/source/ui/inc/pfiltdlg.hxx |   60 ++--
 sc/source/ui/view/gridwin2.cxx|2 
 sc/source/ui/view/pivotsh.cxx |2 
 sc/uiconfig/scalc/ui/pivotfilterdialog.ui |   57 ++--
 8 files changed, 260 insertions(+), 285 deletions(-)

New commits:
commit d9de9d2d33bffb0032eac563079f66b13f1ca426
Author: Caolán McNamara 
AuthorDate: Tue Mar 26 10:06:54 2019 +
Commit: Caolán McNamara 
CommitDate: Tue Mar 26 13:14:35 2019 +0100

weld ScPivotFilterDlg

Change-Id: I0a2ffa6fd02dcf82d55f961ba229112b456eda8e
Reviewed-on: https://gerrit.libreoffice.org/69733
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/inc/scabstdlg.hxx b/sc/inc/scabstdlg.hxx
index 4a5d326049a1..5bcfd9d5fab4 100644
--- a/sc/inc/scabstdlg.hxx
+++ b/sc/inc/scabstdlg.hxx
@@ -468,8 +468,9 @@ public:
 
 virtual VclPtr CreateScNamePasteDlg(weld::Window * 
pParent, ScDocShell* pShell) = 0;
 
-virtual VclPtr 
CreateScPivotFilterDlg(vcl::Window* pParent,
-const SfxItemSet& rArgSet, sal_uInt16 nSourceTab) = 0;
+virtual VclPtr 
CreateScPivotFilterDlg(weld::Window* pParent,
+const 
SfxItemSet& rArgSet,
+sal_uInt16 
nSourceTab) = 0;
 
 virtual VclPtr 
CreateScDPFunctionDlg(weld::Window* pParent,
   const 
ScDPLabelDataVector& rLabelVec,
diff --git a/sc/source/ui/attrdlg/scdlgfact.cxx 
b/sc/source/ui/attrdlg/scdlgfact.cxx
index 88a153120400..581391c4857a 100644
--- a/sc/source/ui/attrdlg/scdlgfact.cxx
+++ b/sc/source/ui/attrdlg/scdlgfact.cxx
@@ -162,7 +162,10 @@ short AbstractScNamePasteDlg_Impl::Execute()
 return m_xDlg->run();
 }
 
-IMPL_ABSTDLG_BASE(AbstractScPivotFilterDlg_Impl);
+short AbstractScPivotFilterDlg_Impl::Execute()
+{
+return m_xDlg->run();
+}
 
 short AbstractScDPFunctionDlg_Impl::Execute()
 {
@@ -603,9 +606,9 @@ std::vector 
AbstractScNamePasteDlg_Impl::GetSelectedNames() const
 return m_xDlg->GetSelectedNames();
 }
 
-const ScQueryItem&   AbstractScPivotFilterDlg_Impl::GetOutputItem()
+const ScQueryItem& AbstractScPivotFilterDlg_Impl::GetOutputItem()
 {
-return pDlg->GetOutputItem();
+return m_xDlg->GetOutputItem();
 }
 
 PivotFunc AbstractScDPFunctionDlg_Impl::GetFuncMask() const
@@ -903,11 +906,10 @@ VclPtr 
ScAbstractDialogFactory_Impl::CreateScNamePasteDl
 return 
VclPtr::Create(std::make_unique(pParent,
 pShell));
 }
 
-VclPtr 
ScAbstractDialogFactory_Impl::CreateScPivotFilterDlg(vcl::Window* pParent,
+VclPtr 
ScAbstractDialogFactory_Impl::CreateScPivotFilterDlg(weld::Window* pParent,
 const SfxItemSet& rArgSet, sal_uInt16 nSourceTab)
 {
-VclPtr pDlg = VclPtr::Create(pParent, 
rArgSet, nSourceTab);
-return VclPtr::Create(pDlg);
+return 
VclPtr::Create(std::make_unique(pParent,
 rArgSet, nSourceTab));
 }
 
 VclPtr 
ScAbstractDialogFactory_Impl::CreateScDPFunctionDlg(weld::Window* pParent,
diff --git a/sc/source/ui/attrdlg/scdlgfact.hxx 
b/sc/source/ui/attrdlg/scdlgfact.hxx
index c752101f82af..4d762f219742 100644
--- a/sc/source/ui/attrdlg/scdlgfact.hxx
+++ b/sc/source/ui/attrdlg/scdlgfact.hxx
@@ -388,7 +388,13 @@ public:
 
 class AbstractScPivotFilterDlg_Impl : public AbstractScPivotFilterDlg
 {
-DECL_ABSTDLG_BASE( AbstractScPivotFilterDlg_Impl, ScPivotFilterDlg)
+std::unique_ptr m_xDlg;
+public:
+explicit AbstractScPivotFilterDlg_Impl(std::unique_ptr p)
+: m_xDlg(std::move(p))
+{
+}
+virtual short Execute() override;
 virtual const ScQueryItem&  GetOutputItem() override;
 };
 
@@ -660,8 +666,8 @@ public:
 
 virtual VclPtr CreateScNamePasteDlg(weld::Window * 
pParent, ScDocShell* pShell) override;
 
-virtual VclPtr 
CreateScPivotFilterDlg(vcl::Window* pParent,
-const SfxItemSet& rArgSet, sal_uInt16 nSourceTab) override;
+virtual VclPtr 
CreateScPivotFilterDlg(weld::Window* pParent, const SfxItemSet& rArgSet,
+sal_uInt16 
nSourceTab) override;
 
 virtual VclPtr 
CreateScDPFunctionDlg(weld::Window* pParent,
   const 
ScDPLabelDataVector& rLabelVec,
diff --git a/sc/source/ui/dbgui/pfiltdlg.cxx b/sc/source/ui/dbgui/pfiltdlg.cxx
index a23e77027266..bd6b6ec1bbb3 100644
--- a/sc/source/ui/dbgui/pfiltdlg.cxx
+++ b/sc/source/ui/dbgui/pfiltdlg.cxx
@@ -37,72 +37,39 @@
 #include 
 #include 
 
-ScPivotFilterDlg::ScPivotFilterDlg(vcl::Window* pParent, const SfxItemSet& 
rArgSet,
-SCTAB nSourceTab )
-:   ModalDialog(pParent, "PivotFilterDialog",
-

[Libreoffice-commits] help.git: CustomTarget_html.mk help3xsl/get_tree.xsl

[Libreoffice Gerrit user]

 CustomTarget_html.mk  |2 ++
 help3xsl/get_tree.xsl |3 ++-
 2 files changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 9b776454d95f5c6bf13c0ca5508c0b2225aa4c1c
Author: Olivier Hallot 
AuthorDate: Mon Mar 25 15:18:41 2019 -0300
Commit: Olivier Hallot 
CommitDate: Tue Mar 26 12:51:58 2019 +0100

Add module name to Contents link URL

Add ?DbPAR= to the contents link URL. .tree does not
have the DbPAR param in the link URLs.

2 possibiltites:
1) Add to the source files *.tree and we are done (triggers retranslation)

2) get module name at build time and add to the resulting tree (this
solution)

Change-Id: I2a3c1edcec7dd824a44bb93f0343ec8cb88cb0c4
Reviewed-on: https://gerrit.libreoffice.org/69714
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/CustomTarget_html.mk b/CustomTarget_html.mk
index 38ca62b10..45d3f284b 100644
--- a/CustomTarget_html.mk
+++ b/CustomTarget_html.mk
@@ -84,6 +84,7 @@ define html_gen_contents_html_dep
 $(call gb_CustomTarget_get_workdir,helpcontent2/help3xsl)/$(1)/contents.part : 
$(call gb_HelpTarget__get_treefile,$(1),$(3))
 $(call gb_CustomTarget_get_workdir,helpcontent2/help3xsl)/$(1)/contents.part : 
TREE_FILE := $(call gb_HelpTarget__get_treefile,$(1),$(3))
 $(call gb_CustomTarget_get_workdir,helpcontent2/help3xsl)/$(1)/contents.part : 
LANG := $(2)
+$(call gb_CustomTarget_get_workdir,helpcontent2/help3xsl)/$(1)/contents.part : 
MODULE := $(lastword $(subst :, ,$(filter $(module):%, $(html_BMARK_MODULES
 
 endef
 
@@ -115,6 +116,7 @@ $(call 
gb_CustomTarget_get_workdir,helpcontent2/help3xsl)/%/contents.part : \
$(call gb_ExternalExecutable_get_command,xsltproc) \
--stringparam lang $(LANG) \
--stringparam local $(if $(HELP_ONLINE),'no','yes') \
+   --stringparam module $(MODULE) \
--stringparam productname "$(PRODUCTNAME)" \
--stringparam productversion "$(PRODUCTVERSION)" \
-o $@ \
diff --git a/help3xsl/get_tree.xsl b/help3xsl/get_tree.xsl
index 749dd4a53..d1cf965e1 100644
--- a/help3xsl/get_tree.xsl
+++ b/help3xsl/get_tree.xsl
@@ -17,6 +17,7 @@ xsltproc get_tree.xsl 
 
 
 
+
 
 

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e94767dfaacc6e69bda2ac74a8a380a3e016c182
Author: Olivier Hallot 
AuthorDate: Mon Mar 25 15:18:41 2019 -0300
Commit: Gerrit Code Review 
CommitDate: Tue Mar 26 12:51:58 2019 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  - Add module name to Contents link URL

Add ?DbPAR= to the contents link URL. .tree does not
have the DbPAR param in the link URLs.

2 possibiltites:
1) Add to the source files *.tree and we are done (triggers 
retranslation)

2) get module name at build time and add to the resulting tree (this
solution)

Change-Id: I2a3c1edcec7dd824a44bb93f0343ec8cb88cb0c4
Reviewed-on: https://gerrit.libreoffice.org/69714
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index dba79673b5bb..9b776454d95f 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit dba79673b5bbf4f7e6f21dc6a1d776e1556c38d7
+Subproject commit 9b776454d95f5c6bf13c0ca5508c0b2225aa4c1c
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

[Tomaž Vajngerl (via logerrit)]

 vcl/source/gdi/FileDefinitionWidgetDraw.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e98469ea2271edbf75445c1ff883c365785b7f86
Author: Tomaž Vajngerl 
AuthorDate: Tue Mar 26 18:44:34 2019 +0900
Commit: Tomaž Vajngerl 
CommitDate: Tue Mar 26 12:36:20 2019 +0100

fix mistake by setting default scale factor to 2.0

Change-Id: I293cddf1106cdc718cd7e01fdfb3e352776b3e39
Reviewed-on: https://gerrit.libreoffice.org/69732
Reviewed-by: Tomaž Vajngerl 
Tested-by: Tomaž Vajngerl 

diff --git a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx 
b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
index 0cfe446f53a3..210e50280ca0 100644
--- a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
+++ b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
@@ -310,7 +310,7 @@ void 
munchDrawCommands(std::vector> const& rDr
 break;
 case WidgetDrawActionType::IMAGE:
 {
-double nScaleFactor = 2.0;
+double nScaleFactor = 1.0;
 if (comphelper::LibreOfficeKit::isActive())
 nScaleFactor = comphelper::LibreOfficeKit::getDPIScale();
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'feature/cib_contract57c' - sw/qa

[Samuel Mehrbrodt (via logerrit)]

 sw/qa/extras/layout/layout.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 6cb475e637c8402dfd0e9ada90c422e9c0058e11
Author: Samuel Mehrbrodt 
AuthorDate: Tue Mar 26 12:27:38 2019 +0100
Commit: Samuel Mehrbrodt 
CommitDate: Tue Mar 26 12:27:38 2019 +0100

Add missing include

Fallout from 7f9dfae2f83f11cc7799110435164a6bd2ba19d5

Change-Id: If1f9ac47baf389c363f1fbda4158f4101ae2d50a

diff --git a/sw/qa/extras/layout/layout.cxx b/sw/qa/extras/layout/layout.cxx
index 1e9047f855c2..615061572ec1 100755
--- a/sw/qa/extras/layout/layout.cxx
+++ b/sw/qa/extras/layout/layout.cxx
@@ -10,6 +10,7 @@
 #include 
 #include 
 #include 
+#include 
 
 static char const DATA_DIRECTORY[] = "/sw/qa/extras/layout/data/";
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - include/vcl sd/source vcl/inc vcl/source

[Jan Holesovsky (via logerrit)]

 include/vcl/graph.hxx|1 +
 sd/source/filter/pdf/sdpdffilter.cxx |2 +-
 vcl/inc/impgraph.hxx |3 ++-
 vcl/source/gdi/graph.cxx |6 ++
 vcl/source/gdi/impgraph.cxx  |   31 ---
 5 files changed, 38 insertions(+), 5 deletions(-)

New commits:
commit 62654a8c29b945d00afe9f32e87b44ba0d8b84a2
Author: Jan Holesovsky 
AuthorDate: Thu Jun 21 21:33:56 2018 +0200
Commit: Jan Holesovsky 
CommitDate: Tue Mar 26 12:01:58 2019 +0100

pdfium: Share the GfxLink for PDF files.

Partially based on work by Ashod Nakashian, thanks!

Reviewed-on: https://gerrit.libreoffice.org/56265
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

Change-Id: Id7e8c4543368b0caf3e459abaff8c53997779c83
Reviewed-on: https://gerrit.libreoffice.org/69625
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/include/vcl/graph.hxx b/include/vcl/graph.hxx
index 45268462155a..881abda221e4 100644
--- a/include/vcl/graph.hxx
+++ b/include/vcl/graph.hxx
@@ -216,6 +216,7 @@ private:
 
 public:
 voidSetLink( const GfxLink& );
+voidSetSharedLink(const std::shared_ptr& pGfxLink);
 GfxLink GetLink() const;
 boolIsLink() const;
 
diff --git a/sd/source/filter/pdf/sdpdffilter.cxx 
b/sd/source/filter/pdf/sdpdffilter.cxx
index a4747456123b..95daaeb479f1 100644
--- a/sd/source/filter/pdf/sdpdffilter.cxx
+++ b/sd/source/filter/pdf/sdpdffilter.cxx
@@ -128,7 +128,7 @@ bool SdPdfFilter::Import()
 Graphic aGraphic(aBitmap);
 aGraphic.setPdfData(pPdfData);
 aGraphic.setPageNumber(nPageNumber);
-aGraphic.SetLink(aGfxLink);
+aGraphic.SetSharedLink(pGfxLink);
 aGraphic.setOriginURL(aFileName);
 
 // Create the page and insert the Graphic.
diff --git a/vcl/inc/impgraph.hxx b/vcl/inc/impgraph.hxx
index c462dc2c67ac..3d998ec94ac5 100644
--- a/vcl/inc/impgraph.hxx
+++ b/vcl/inc/impgraph.hxx
@@ -160,7 +160,8 @@ private:
 
 boolImplIsSwapOut() const { return mbSwapOut;}
 boolImplIsDummyContext() const { return mbDummyContext; }
-voidImplSetLink( const std::shared_ptr& );
+voidImplSetLink( const GfxLink& );
+voidImplSetSharedLink(const std::shared_ptr& 
pGfxLink);
 GfxLink ImplGetLink();
 boolImplIsLink() const;
 
diff --git a/vcl/source/gdi/graph.cxx b/vcl/source/gdi/graph.cxx
index 1fc7897ac90b..04e567e44d5d 100644
--- a/vcl/source/gdi/graph.cxx
+++ b/vcl/source/gdi/graph.cxx
@@ -569,6 +569,12 @@ void Graphic::SetLink( const GfxLink& rGfxLink )
 mxImpGraphic->ImplSetLink( rGfxLink );
 }
 
+void Graphic::SetSharedLink(const std::shared_ptr& pGfxLink)
+{
+ImplTestRefCount();
+mxImpGraphic->ImplSetSharedLink(pGfxLink);
+}
+
 GfxLink Graphic::GetLink() const
 {
 return mxImpGraphic->ImplGetLink();
diff --git a/vcl/source/gdi/impgraph.cxx b/vcl/source/gdi/impgraph.cxx
index 2d73357ec43d..6e837c979e78 100644
--- a/vcl/source/gdi/impgraph.cxx
+++ b/vcl/source/gdi/impgraph.cxx
@@ -125,6 +125,14 @@ ImpGraphic::ImpGraphic(const ImpGraphic& rImpGraphic)
 , maGraphicExternalLink(rImpGraphic.maGraphicExternalLink)
 , mnPageNumber(rImpGraphic.mnPageNumber)
 {
+if( rImpGraphic.mpGfxLink )
+{
+if (rImpGraphic.mpGfxLink->GetType() == GfxLinkType::NativePdf)
+mpGfxLink = rImpGraphic.mpGfxLink;
+else
+mpGfxLink = std::make_shared(*rImpGraphic.mpGfxLink);
+}
+
 if( rImpGraphic.mpAnimation )
 {
 mpAnimation = o3tl::make_unique( *rImpGraphic.mpAnimation );
@@ -237,9 +245,18 @@ ImpGraphic& ImpGraphic::operator=( const ImpGraphic& 
rImpGraphic )
 mbSwapOut = rImpGraphic.mbSwapOut;
 mpSwapFile = rImpGraphic.mpSwapFile;
 
-mpGfxLink = rImpGraphic.mpGfxLink;
+if (rImpGraphic.mpGfxLink)
+{
+if (rImpGraphic.mpGfxLink->GetType() == GfxLinkType::NativePdf)
+mpGfxLink = rImpGraphic.mpGfxLink;
+else
+{
+mpGfxLink.reset();
+
+mpGfxLink = std::make_shared(*rImpGraphic.mpGfxLink);
+}
+}
 
-maVectorGraphicData = rImpGraphic.maVectorGraphicData;
 mpPdfData = rImpGraphic.mpPdfData;
 }
 
@@ -1367,7 +1384,15 @@ bool ImpGraphic::ImplSwapIn( SvStream* xIStm )
 
 void ImpGraphic::ImplSetLink(const GfxLink& rGfxLink)
 {
-mpGfxLink = rGfxLink;
+mpGfxLink = std::make_shared( rGfxLink );
+
+if( mpGfxLink->IsNative() )
+mpGfxLink->SwapOut();
+}
+
+void ImpGraphic::ImplSetSharedLink(const std::shared_ptr& pGfxLink)
+{
+mpGfxLink = pGfxLink;
 
 if (mpGfxLink && mpGfxLink->IsNative())
 mpGfxLink->SwapOut();
___
Libreoffice-commits mailing list