date:20190330

https://bugs.documentfoundation.org/show_bug.cgi?id=101298

--- Comment #2 from mahfiaz  ---
Cut and merge cells are now (6.2.2.2) gone in the read only view.
Now the context menu reads:
Copy
Paste Special
Selection List
Styles

Paste Special has an empty submenu.
Styles submenu has several options which do nothing, aren't greyed out and give
no warning/error.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122755] [META] Formulae in Writer tables bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=122755
Bug 122755 depends on bug 92143, which changed state.

Bug 92143 Summary: Equations in Writer tables show sum for any undefined 
function
https://bugs.documentfoundation.org/show_bug.cgi?id=92143

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92143] Equations in Writer tables show sum for any undefined function

https://bugs.documentfoundation.org/show_bug.cgi?id=92143

mahfiaz  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #8 from mahfiaz  ---
Looks like it has been fixed. Closing the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: basic/source comphelper/source dtrans/source editeng/source oox/source package/source sd/source svx/source toolkit/source ucb/source unotools/source unoxml/source xmlhe

2019-03-30 Thread Mike Kaganski (via logerrit)

 basic/source/classes/sbunoobj.cxx   |2 +-
 comphelper/source/streaming/seekableinput.cxx   |5 +
 dtrans/source/win32/clipb/wcbentry.cxx  |3 ++-
 dtrans/source/win32/dnd/source.cxx  |3 +--
 dtrans/source/win32/dnd/target.cxx  |5 ++---
 editeng/source/misc/svxacorr.cxx|4 ++--
 editeng/source/uno/unotext.cxx  |6 ++
 oox/source/shape/ShapeContextHandler.cxx|4 ++--
 package/source/xstor/xfactory.cxx   |   20 +++-
 package/source/zippackage/ZipPackageStream.cxx  |4 ++--
 sd/source/ui/unoidl/unomodel.cxx|2 +-
 svx/source/unodraw/unomod.cxx   |2 +-
 toolkit/source/controls/unocontrolcontainer.cxx |3 +--
 ucb/source/core/provprox.cxx|4 +---
 ucb/source/core/ucbprops.cxx|4 +---
 ucb/source/core/ucbstore.cxx|5 ++---
 ucb/source/sorter/sortdynres.cxx|5 ++---
 ucb/source/ucp/tdoc/tdoc_documentcontentfactory.cxx |4 +---
 unotools/source/ucbhelper/ucblockbytes.cxx  |4 ++--
 unotools/source/ucbhelper/ucbstreamhelper.cxx   |6 ++
 unoxml/source/xpath/xpathapi.cxx|2 +-
 xmlhelp/source/cxxhelp/provider/urlparameter.cxx|2 +-
 xmlhelp/source/treeview/tvfactory.cxx   |4 ++--
 xmlscript/source/xml_helper/xml_impctx.cxx  |9 +++--
 xmlscript/source/xmldlg_imexp/xmldlg_import.cxx |3 +--
 xmlscript/source/xmllib_imexp/xmllib_import.cxx |6 ++
 xmlscript/source/xmlmod_imexp/xmlmod_import.cxx |3 +--
 27 files changed, 47 insertions(+), 77 deletions(-)

New commits:
commit 184be2d1352c5d3f3aa1e276d26c463c6e49b302
Author: Mike Kaganski 
AuthorDate: Sun Mar 31 00:06:17 2019 +0300
Commit: Mike Kaganski 
CommitDate: Sun Mar 31 07:27:24 2019 +0200

tdf#120703 PVS: remove redundant static casts

V572 It is odd that the object which was created using 'new' operator
 is immediately cast to another type.

Change-Id: I54976062dc3f62eaaa79f89eff54454f0b24ac2c
Reviewed-on: https://gerrit.libreoffice.org/69989
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/basic/source/classes/sbunoobj.cxx 
b/basic/source/classes/sbunoobj.cxx
index 666fe69673f3..e985a7dddf1c 100644
--- a/basic/source/classes/sbunoobj.cxx
+++ b/basic/source/classes/sbunoobj.cxx
@@ -3892,7 +3892,7 @@ static Reference< XInterface > createAllListenerAdapter
 if( xInvocationAdapterFactory.is() && xListenerType.is() && xListener.is() 
)
 {
 Reference< XInvocation > xInvocationToAllListenerMapper =
-static_cast(new InvocationToAllListenerMapper( 
xListenerType, xListener, Helper ));
+new InvocationToAllListenerMapper(xListenerType, xListener, 
Helper);
 Type aListenerType( xListenerType->getTypeClass(), 
xListenerType->getName() );
 Sequence arg2(1);
 arg2[0] = aListenerType;
diff --git a/comphelper/source/streaming/seekableinput.cxx 
b/comphelper/source/streaming/seekableinput.cxx
index 89d887ea3548..e4f654043dc7 100644
--- a/comphelper/source/streaming/seekableinput.cxx
+++ b/comphelper/source/streaming/seekableinput.cxx
@@ -81,10 +81,7 @@ uno::Reference< io::XInputStream > 
OSeekableInputWrapper::CheckSeekableCanWrap(
 if ( xSeek.is() )
 return xInStream;
 
-uno::Reference< io::XInputStream > xNewStream(
-static_cast< io::XInputStream* >(
-new OSeekableInputWrapper( xInStream, rxContext ) ) );
-return xNewStream;
+return new OSeekableInputWrapper(xInStream, rxContext);
 }
 
 
diff --git a/dtrans/source/win32/clipb/wcbentry.cxx 
b/dtrans/source/win32/clipb/wcbentry.cxx
index d295bf00447c..2a316470f8d3 100644
--- a/dtrans/source/win32/clipb/wcbentry.cxx
+++ b/dtrans/source/win32/clipb/wcbentry.cxx
@@ -42,7 +42,8 @@ namespace
 
 Reference< XInterface > createInstance( const Reference< 
XMultiServiceFactory >& rServiceManager )
 {
-return Reference< XInterface >( static_cast< XClipboard* >( new 
CWinClipboard( comphelper::getComponentContext(rServiceManager), "" ) ) );
+return static_cast(
+new 
CWinClipboard(comphelper::getComponentContext(rServiceManager), ""));
 }
 }
 
diff --git a/dtrans/source/win32/dnd/source.cxx 
b/dtrans/source/win32/dnd/source.cxx
index 45337ec764c4..772eeb0ccb00 100644
--- a/dtrans/source/win32/dnd/source.cxx
+++ b/dtrans/source/win32/dnd/source.cxx
@@ -96,8 +96,7 @@ void DragSource::StartDragImpl(
 // to the IDropSource interface implemented in this class (but only
 // while this function executes). The source context is also used
 // in DragSource::QueryContinueDrag.
-m_currentContext= static_cast( new SourceContext(
-  this, listener ) );
+

[Libreoffice-bugs] [Bug 120703] Bugs found by PVS-Studio static analyzer

https://bugs.documentfoundation.org/show_bug.cgi?id=120703

--- Comment #152 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/184be2d1352c5d3f3aa1e276d26c463c6e49b302%5E%21

tdf#120703 PVS: remove redundant static casts

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 35106] libreoffice should be able to detect the filetype by the datastructure not by the file extension.

https://bugs.documentfoundation.org/show_bug.cgi?id=35106

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||4416

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 35147] dialog Insert->Picture->From File do not shows pictures without extension

https://bugs.documentfoundation.org/show_bug.cgi?id=35147

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||4416

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124416] Image not in insert Dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=124416

V Stuart Foote  changed:

   What|Removed |Added

  Component|BASIC   |LibreOffice
Version|6.2.0.3 release |Inherited From OOo
 CC||vstuart.fo...@utsa.edu
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=35
   ||106,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=35
   ||147

--- Comment #4 from V Stuart Foote  ---
Confirming the behavior, but this is not a bug. We do not parse "magic numbers"
nor do any file analysis that the os/DE does not support in its file manager.

Probably should be duped to bug 35147

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116670] Manage Names Dialog does not repaint after resize

https://bugs.documentfoundation.org/show_bug.cgi?id=116670

--- Comment #5 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85339] FORMCONTROLS: Tabindex is ignored for fields withe the same name

https://bugs.documentfoundation.org/show_bug.cgi?id=85339

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124416] Image not in insert Dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=124416

shubhamgoyal <22shub...@gmail.com> changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124416] Image not in insert Dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=124416

--- Comment #3 from shubhamgoyal <22shub...@gmail.com> ---
Created attachment 150419
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150419=edit
A png format image

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

CppCheck Report Update

2019-03-30 Thread cppcheck.libreoff...@gmail.com


A new cppcheck report is available at : 
http://dev-builds.libreoffice.org/cppcheck_reports/master/


Note:
The script generating this report was run at :
2019-31-03 03:42:13 with user buildslave at host vm140 as 
/home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s 
/home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w 
/home/buildslave/tmp/www

It can be found and improved here:

https://gerrit.libreoffice.org/plugins/gitiles/dev-tools/+/master/cppcheck/cppcheck-report.sh


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Bug 123999] time change causes the return of "parameter index out of range... using mysql and J/connector

2019-03-30 Thread Dan Lewis

I have run into a problem with this bug. I would like to download a 
daily build, but I do not know how. I have clicked on the link below, 
but I don't see any .deb files that I can download. I don't really know 
what it is that I am to download. (I use Ubuntu 18.04.) In fact, I do 
not see any builds available there. I could use some help so that I can 
test this patch to see if it works.


Dan

On 3/27/19 9:14 AM, bugzilla-dae...@bugs.documentfoundation.org wrote:


*Comment # 17 
 on 
bug 123999 
 from 
Commit Notification  *

Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/15f4f8b7bfd666d69381696fe288da24302d2ecd%5E%21

tdf#123999  : ParameterNameSubstitution in mysqljdbc

It will be available in 6.2.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/  in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

You are receiving this mail because:

  * You reported the bug.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 123912] DOCX Text in protected form created in Writer is editable in Word

https://bugs.documentfoundation.org/show_bug.cgi?id=123912

--- Comment #7 from Aron Budea  ---
(In reply to Aron Budea from comment #5)
> Thanks for the proposed fix! Perhaps Serge's commit is the reason why
> switching on Protect form isn't effective immediately, I'll have to check
> that (originally I meant to check after a reload). With the patch it works
> as expected in Word.
Opened bug 124451 on the mentioned case, indeed it's a regression since that
commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124451] New: 'Protect form' compatibility setting doesn't prevent editing in some cases

https://bugs.documentfoundation.org/show_bug.cgi?id=124451

Bug ID: 124451
Summary: 'Protect form' compatibility setting doesn't prevent
editing in some cases
Product: LibreOffice
Version: 6.3.0.0.alpha0+ Master
Hardware: All
OS: All
Status: UNCONFIRMED
Keywords: bibisected, bisected, regression
Severity: normal
Priority: medium
Component: Writer
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: ba...@caesar.elte.hu
CC: serge.k...@cib.de
Blocks: 120763

These are actually two somewhat different regressions originating from the same
commit. I'm reporting both here, but can split one off if it's more feasible.

1.
- Type some text in an empty document.
- Enable 'Protect form' Writer compatibility setting.
- Try typing some more text in the document.

=> Typing is possible. The document should be protected and uneditable (apart
from filling in forms).
After saving it in DOC(X) format, and reloading it, the document is protected
since the fresh fix to bug 123912 comment 2, but it should become protected
right away.

2.
- Open attachment 149778 from bug 123912, which contains a single drop-down
form field, and is form-protected.
- Position cursor before the dropdown, and press Enter to insert a line break.
- Move the cursor up, and start typing.

=> This specific typing is possible, while no typing should be possible.

Both of these regressions were introduced by the following commit. Adding Cc:
to Serge Krot, please take a look.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=0898595532d1e3f498c259b6dfee462249b00667
author Serge Krot 2018-12-17 17:07:23 +0100
committer Thorsten Behrens 2018-12-20
15:16:34 +0100

sw: DOCX: allow editing of unprotected areas in protected doc

Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=120763
[Bug 120763] [META] DOCX (OOXML) document protection-related issues/enhancement
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120763] [META] DOCX (OOXML) document protection-related issues/enhancement

https://bugs.documentfoundation.org/show_bug.cgi?id=120763

Aron Budea  changed:

   What|Removed |Added

 Depends on||124451


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=124451
[Bug 124451] 'Protect form' compatibility setting doesn't prevent editing in
some cases
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - readlicense_oo/license

 readlicense_oo/license/license.xml |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit aee8c0289e8dbec9b9d4c47a36059f22efed8a13
Author: Andras Timar 
AuthorDate: Sun Mar 31 00:25:34 2019 +0100
Commit: Andras Timar 
CommitDate: Sun Mar 31 00:26:51 2019 +0100

license: fix one more internal link

Change-Id: I22b33d80a65bc55765ff13f39459de6f68485caa

diff --git a/readlicense_oo/license/license.xml 
b/readlicense_oo/license/license.xml
index d6dbabb64d98..a1260a905b2a 100644
--- a/readlicense_oo/license/license.xml
+++ b/readlicense_oo/license/license.xml
@@ -2628,7 +2628,7 @@
 software is governed by the terms of the license below:
 Copyright (C) 2005 Friedel Wolff
 This library is free software; you can redistribute it and/or 
modify it under the terms of the GNU Lesser General Public 
License as published by the Free Software
+"#a__LGPL_version_2_1">GNU Lesser General Public License as 
published by the Free Software
 Foundation; either version 2.1 of the License, or (at your option) any 
later version.
 Albanian
 Spelling dictionary
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: readlicense_oo/license

 readlicense_oo/license/license.xml |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f42d729e41da918bc496d5feb5861a09737c438a
Author: Andras Timar 
AuthorDate: Sun Mar 31 00:25:34 2019 +0100
Commit: Andras Timar 
CommitDate: Sun Mar 31 00:25:34 2019 +0100

license: fix one more internal link

Change-Id: I22b33d80a65bc55765ff13f39459de6f68485caa

diff --git a/readlicense_oo/license/license.xml 
b/readlicense_oo/license/license.xml
index bab777ba1afc..27f3a641b154 100644
--- a/readlicense_oo/license/license.xml
+++ b/readlicense_oo/license/license.xml
@@ -2620,7 +2620,7 @@
 software is governed by the terms of the license below:
 Copyright (C) 2005 Friedel Wolff
 This library is free software; you can redistribute it and/or 
modify it under the terms of the GNU Lesser General Public 
License as published by the Free Software
+"#a__LGPL_version_2_1">GNU Lesser General Public License as 
published by the Free Software
 Foundation; either version 2.1 of the License, or (at your option) any 
later version.
 Albanian
 Spelling dictionary
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 58 commits - odk/Package_share_readme.mk readlicense_oo/CustomTarget_license.mk readlicense_oo/license readlicense_oo/Module_readlice

 Repository.mk |2 
 odk/Package_share_readme.mk   |8 
 readlicense_oo/CustomTarget_license.mk|   47 
 readlicense_oo/Module_readlicense_oo.mk   |9 
 readlicense_oo/Package_files.mk   |   14 
 readlicense_oo/Package_license.mk |   15 
 readlicense_oo/README |   31 
 readlicense_oo/license/LICENSE| 9320 
 readlicense_oo/license/LICENSE.fodt   | 6719 -
 readlicense_oo/license/LICENSE.html   | 9843 --
 readlicense_oo/license/license.xml| 6821 ++
 readlicense_oo/license/license_html.xsl   |   32 
 readlicense_oo/license/license_plain_text.xsl |   62 
 sfx2/source/appl/appserv.cxx  |2 
 solenv/bin/modules/installer/environment.pm   |2 
 15 files changed, 7017 insertions(+), 25910 deletions(-)

New commits:
commit 703af2e9c587e84ee1ebb3900358ae4171b2213c
Author: Andras Timar 
AuthorDate: Sat Mar 30 23:51:53 2019 +0100
Commit: Andras Timar 
CommitDate: Sat Mar 30 23:57:00 2019 +0100

license: fix a few internal links

Change-Id: I9139bb22881e7761028a7b78ac644bea4f83e35b

diff --git a/readlicense_oo/license/license.xml 
b/readlicense_oo/license/license.xml
index 028d3f99d451..d6dbabb64d98 100644
--- a/readlicense_oo/license/license.xml
+++ b/readlicense_oo/license/license.xml
@@ -670,7 +670,7 @@
 the terms of the license below:
 MPL 1.1 / LGPL v2+ / GPL v2+
 Jump to GPL Version 2
-Jump to LGPL Version 2
+Jump to LGPL Version 2
 Jump to MPL Version 1.1
 
 
@@ -679,7 +679,7 @@
 the terms of the license below:
 MPL 1.1 / LGPL v2+ / GPL v2+
 Jump to GPL Version 2
-Jump to LGPL Version 2
+Jump to LGPL Version 2
 Jump to MPL Version 1.1
 
 
@@ -967,7 +967,7 @@
 the terms of the license below:
 MPL 1.1 / LGPL v2+ / GPL v2+
 Jump to GPL Version 2
-Jump to LGPL Version 2
+Jump to LGPL Version 2
 Jump to MPL Version 1.1
 
 
@@ -1463,7 +1463,7 @@
 Network Security Services (NSS)
 The following software may be included in this product: Network 
Security Services (NSS). Use of any of this
 software is governed by the terms of the license below:
-Jump to MPL 1.1
+Jump to MPL 1.1
 
 
 OpenLDAP
@@ -2412,9 +2412,8 @@
 governed by the terms of the license below:
 Copyright (c) 2003-2008 SIL International (http://www.sil.org/;>http://www.sil.org/), with
 Reserved Font Names "Gentium" and "SIL".
-This Font Software is licensed under the SIL Open Font License, 
Version 1.1. This license is copied below, and is also available with a FAQ at: http://scripts.sil.org/OFL;>http://scripts.sil.org/OFL
+This Font Software is licensed under the SIL Open Font License, 
Version 1.1. This license is copied below,
+and is also available with a FAQ at: http://scripts.sil.org/OFL;>http://scripts.sil.org/OFL
 Jump to SIL Open 
Font License, Version 1.1
 
 KACST
@@ -2433,9 +2432,8 @@
 Liberation
 The following software may be included in this product: Liberation 
fonts. Use of any of this software is
 governed by the terms of the license below:
-This Font Software is licensed under the SIL Open Font License, 
Version 1.1. This license is copied below, and is also available with a FAQ at: http://scripts.sil.org/OFL;>http://scripts.sil.org/OFL
+This Font Software is licensed under the SIL Open Font License, 
Version 1.1. This license is copied below,
+and is also available with a FAQ at: http://scripts.sil.org/OFL;>http://scripts.sil.org/OFL
 Jump to SIL Open 
Font License, Version 1.1
 LICENSE AGREEMENT AND LIMITED PRODUCT WARRANTY
 LIBERATION FONT SOFTWARE
@@ -2679,7 +2677,7 @@
 Spelling dictionary
 The following software may be included in this product: Belarusian 
spelling dictionary. Use of any of this
 software is governed by the terms of the license below:
-Creative Commons CC-BY-SA
+Creative Commons CC-BY-SA
 Author: Mikalai Udodau mikalai.udo...@gmail.com
 Origin: Словазбор аўтарскі; арфаграфія паводле ТСБМ-2005
 Bengali
@@ -2811,9 +2809,9 @@
 http://www.stavekontrolden.dk/;>http://www.stavekontrolden.dk
 These files are published under the following open source 
licenses:
 
-GNU GPL version 2.0
+GNU GPL version 2.0
 GNU LGPL version 2.1
-Mozilla MPL version 
1.1
+Mozilla MPL version 1.1
 
 This dictionary is based on data from Det Danske Sprog- og 
Litteraturselskab
 (The Danish Society for Language and Literature),

[Libreoffice-bugs] [Bug 104523] [META] DOCX (OOXML) ActiveX and Legacy form control related issues

https://bugs.documentfoundation.org/show_bug.cgi?id=104523
Bug 104523 depends on bug 122186, which changed state.

Bug 122186 Summary: FILESAVE: Input fields saved in DOCX get corrupted
https://bugs.documentfoundation.org/show_bug.cgi?id=122186

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122186] FILESAVE: Input fields saved in DOCX get corrupted

https://bugs.documentfoundation.org/show_bug.cgi?id=122186

Aron Budea  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #5 from Aron Budea  ---
The fields inserted via the Fields dialog aren't supposed to behave like MS
Word's form fields (and export to DOC(X) formats "corretly"), the new way is
via the Form menu, after enabling 'Reorganize Forms menu to have it MS
compatible' among Writer's Compatibility options. The new feature is thanks to
Tamas, and have been implemented in his "MSForms" etc. commits recently.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115692] Input list field not imported as actual field from DOC(X)

https://bugs.documentfoundation.org/show_bug.cgi?id=115692

Aron Budea  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #5 from Aron Budea  ---
The fields inserted via the Fields dialog aren't supposed to behave like MS
Word's form fields (and export to DOC(X) formats "corretly"), the new way is
via the Form menu, after enabling 'Reorganize Forms menu to have it MS
compatible' among Writer's Compatibility options. The new feature is thanks to
Tamas, and have been implemented in his "MSForms" etc. commits recently.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112969] [META] DOCX (OOXML) field-related issues

https://bugs.documentfoundation.org/show_bug.cgi?id=112969
Bug 112969 depends on bug 115692, which changed state.

Bug 115692 Summary: Input list field not imported as actual field from DOC(X)
https://bugs.documentfoundation.org/show_bug.cgi?id=115692

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113200] [META] DOC (binary) field bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=113200
Bug 113200 depends on bug 115692, which changed state.

Bug 115692 Summary: Input list field not imported as actual field from DOC(X)
https://bugs.documentfoundation.org/show_bug.cgi?id=115692

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: readlicense_oo/license

 readlicense_oo/license/license.xml |   38 +
 1 file changed, 18 insertions(+), 20 deletions(-)

New commits:
commit bcd70deef2bbaa360b6d8ee6b9ec2925c0140fd7
Author: Andras Timar 
AuthorDate: Sat Mar 30 23:51:53 2019 +0100
Commit: Andras Timar 
CommitDate: Sat Mar 30 23:52:28 2019 +0100

license: fix a few internal links

Change-Id: I9139bb22881e7761028a7b78ac644bea4f83e35b

diff --git a/readlicense_oo/license/license.xml 
b/readlicense_oo/license/license.xml
index 3ce8bc6da859..bab777ba1afc 100644
--- a/readlicense_oo/license/license.xml
+++ b/readlicense_oo/license/license.xml
@@ -670,7 +670,7 @@
 the terms of the license below:
 MPL 1.1 / LGPL v2+ / GPL v2+
 Jump to GPL Version 2
-Jump to LGPL Version 2
+Jump to LGPL Version 2
 Jump to MPL Version 1.1
 
 
@@ -679,7 +679,7 @@
 the terms of the license below:
 MPL 1.1 / LGPL v2+ / GPL v2+
 Jump to GPL Version 2
-Jump to LGPL Version 2
+Jump to LGPL Version 2
 Jump to MPL Version 1.1
 
 
@@ -967,7 +967,7 @@
 the terms of the license below:
 MPL 1.1 / LGPL v2+ / GPL v2+
 Jump to GPL Version 2
-Jump to LGPL Version 2
+Jump to LGPL Version 2
 Jump to MPL Version 1.1
 
 
@@ -1463,7 +1463,7 @@
 Network Security Services (NSS)
 The following software may be included in this product: Network 
Security Services (NSS). Use of any of this
 software is governed by the terms of the license below:
-Jump to MPL 1.1
+Jump to MPL 1.1
 
 
 OpenLDAP
@@ -2412,9 +2412,8 @@
 governed by the terms of the license below:
 Copyright (c) 2003-2008 SIL International (http://www.sil.org/;>http://www.sil.org/), with
 Reserved Font Names "Gentium" and "SIL".
-This Font Software is licensed under the SIL Open Font License, 
Version 1.1. This license is copied below, and is also available with a FAQ at: http://scripts.sil.org/OFL;>http://scripts.sil.org/OFL
+This Font Software is licensed under the SIL Open Font License, 
Version 1.1. This license is copied below,
+and is also available with a FAQ at: http://scripts.sil.org/OFL;>http://scripts.sil.org/OFL
 Jump to SIL Open 
Font License, Version 1.1
 
 KACST
@@ -2425,9 +2424,8 @@
 Liberation
 The following software may be included in this product: Liberation 
fonts. Use of any of this software is
 governed by the terms of the license below:
-This Font Software is licensed under the SIL Open Font License, 
Version 1.1. This license is copied below, and is also available with a FAQ at: http://scripts.sil.org/OFL;>http://scripts.sil.org/OFL
+This Font Software is licensed under the SIL Open Font License, 
Version 1.1. This license is copied below,
+and is also available with a FAQ at: http://scripts.sil.org/OFL;>http://scripts.sil.org/OFL
 Jump to SIL Open 
Font License, Version 1.1
 LICENSE AGREEMENT AND LIMITED PRODUCT WARRANTY
 LIBERATION FONT SOFTWARE
@@ -2671,7 +2669,7 @@
 Spelling dictionary
 The following software may be included in this product: Belarusian 
spelling dictionary. Use of any of this
 software is governed by the terms of the license below:
-Creative Commons CC-BY-SA
+Creative Commons CC-BY-SA
 Author: Mikalai Udodau mikalai.udo...@gmail.com
 Origin: Словазбор аўтарскі; арфаграфія паводле ТСБМ-2005
 Bengali
@@ -2803,9 +2801,9 @@
 http://www.stavekontrolden.dk/;>http://www.stavekontrolden.dk
 These files are published under the following open source 
licenses:
 
-GNU GPL version 2.0
+GNU GPL version 2.0
 GNU LGPL version 2.1
-Mozilla MPL version 
1.1
+Mozilla MPL version 1.1
 
 This dictionary is based on data from Det Danske Sprog- og 
Litteraturselskab
 (The Danish Society for Language and Literature), http://www.dsl.dk/;>http://www.dsl.dk.
@@ -2816,9 +2814,9 @@
 The following software may be included in this product: Danish 
thesaurus. Use of any of this software is
 governed by the terms of the license below:
 
-GNU GPL version 2.0
+GNU GPL version 2.0
 GNU LGPL version 2.1
-Mozilla MPL version 
1.1
+Mozilla MPL version 1.1
 
 Stavekontrolden - Danish thesaurus files for OpenOffice.org 3.0.
 Den Danske Ordbog - Synonymer
@@ -2922,7 +2920,7 @@
 Public License as published by the Free Software Foundation; either 
version 2 of the License, or (at your
 option) any later version.
 Jump to GPL version 2
-English (Canada)
+English 
(Canada)
 Spelling dictionary
 The

[Libreoffice-bugs] [Bug 124443] AutoInput tooltip positioning is inconsistent when editing formula, covering different parts of UI

https://bugs.documentfoundation.org/show_bug.cgi?id=124443

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
 Blocks||114019
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
confirm in

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 5cb2db6dd7d234a610a6501668a9901af8472b7f
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-03-26_23:06:31
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114019
[Bug 114019] [META] Tooltip bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114019] [META] Tooltip bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=114019

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||124443


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=124443
[Bug 124443] AutoInput tooltip positioning is inconsistent when editing
formula, covering different parts of UI
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124450] Libreoffice Calc: Autofilter functions are slow

https://bugs.documentfoundation.org/show_bug.cgi?id=124450

--- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> ---
Created attachment 150418
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150418=edit
Saved ODS

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109072] [META] XLS (binary) format bug tracker

https://bugs.documentfoundation.org/show_bug.cgi?id=109072

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||124450


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=124450
[Bug 124450] Libreoffice Calc: Autofilter functions are slow
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124450] Libreoffice Calc: Autofilter functions are slow

https://bugs.documentfoundation.org/show_bug.cgi?id=124450

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   Keywords||filter:xls, perf
 Blocks||109072, 103512
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||79045_79...@mail.ru

--- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> ---
confirm in

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 5cb2db6dd7d234a610a6501668a9901af8472b7f
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-03-26_23:06:31
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded

after saving xlsm to ods and reopen ods in LO the problem still here

In Excel 2016 autofilter works very fast with file from attach


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103512
[Bug 103512] [META] AutoFilter-related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109072
[Bug 109072] [META] XLS (binary) format bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103512] [META] AutoFilter-related bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=103512

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||124450


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=124450
[Bug 124450] Libreoffice Calc: Autofilter functions are slow
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124292] KDE5: Fractional scaling makes most UI and rendered text look bad

https://bugs.documentfoundation.org/show_bug.cgi?id=124292

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.3.0|target:6.3.0 target:6.2.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124292] KDE5: Fractional scaling makes most UI and rendered text look bad

https://bugs.documentfoundation.org/show_bug.cgi?id=124292

--- Comment #11 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/c3eeb421526f284419e90d2c4c4da5b0d7bbcc0e%5E%21

tdf#124292 Qt5 / KDE5 disable Qt's HiDPI scaling

It will be available in 6.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/qt5 vcl/unx

2019-03-30 Thread Jan-Marek Glogowski (via logerrit)

 vcl/qt5/Qt5Graphics_GDI.cxx  |4 ++--
 vcl/qt5/Qt5Instance.cxx  |2 ++
 vcl/unx/kde5/KDE5SalGraphics.cxx |4 ++--
 vcl/unx/kde5/KDE5SalInstance.cxx |2 ++
 4 files changed, 8 insertions(+), 4 deletions(-)

New commits:
commit c3eeb421526f284419e90d2c4c4da5b0d7bbcc0e
Author: Jan-Marek Glogowski 
AuthorDate: Fri Mar 29 02:58:59 2019 +0100
Commit: Thorsten Behrens 
CommitDate: Sat Mar 30 23:45:41 2019 +0100

tdf#124292 Qt5 / KDE5 disable Qt's HiDPI scaling

LO does its own layouting and also all the scaling, so disable
the automatic HiDPI scaling explicitly. Otherwise fonts will be
rendered in LoDPI and just scaled as an image, if UI scaling is
enabled in KDE, resulting in really blocky / ugly fonts.

Change-Id: I38503ce27c1671e80d0749d21c6c6dcff1a808a6
Reviewed-on: https://gerrit.libreoffice.org/69941
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 
(cherry picked from commit b4698a2241ec26d796c66da3a814f7cc693785b6)
Reviewed-on: https://gerrit.libreoffice.org/69984
Reviewed-by: Thorsten Behrens 

diff --git a/vcl/qt5/Qt5Graphics_GDI.cxx b/vcl/qt5/Qt5Graphics_GDI.cxx
index 90baba36d3f0..851d222f0ab7 100644
--- a/vcl/qt5/Qt5Graphics_GDI.cxx
+++ b/vcl/qt5/Qt5Graphics_GDI.cxx
@@ -643,8 +643,8 @@ void Qt5Graphics::GetResolution(sal_Int32& rDPIX, 
sal_Int32& rDPIY)
 return;
 
 QScreen* pScreen = 
m_pFrame->GetQWidget()->window()->windowHandle()->screen();
-rDPIX = pScreen->logicalDotsPerInchX();
-rDPIY = pScreen->logicalDotsPerInchY();
+rDPIX = pScreen->logicalDotsPerInchX() * pScreen->devicePixelRatio() + 0.5;
+rDPIY = pScreen->logicalDotsPerInchY() * pScreen->devicePixelRatio() + 0.5;
 }
 
 sal_uInt16 Qt5Graphics::GetBitCount() const { return 
getFormatBits(m_pQImage->format()); }
diff --git a/vcl/qt5/Qt5Instance.cxx b/vcl/qt5/Qt5Instance.cxx
index adbe70bfb296..8de9fc7f5712 100644
--- a/vcl/qt5/Qt5Instance.cxx
+++ b/vcl/qt5/Qt5Instance.cxx
@@ -336,6 +336,8 @@ VCLPLUG_QT5_PUBLIC SalInstance* create_SalInstance()
 unsetenv("SESSION_MANAGER");
 }
 
+QApplication::setAttribute(Qt::AA_DisableHighDpiScaling);
+
 int* pFakeArgc = new int;
 *pFakeArgc = nFakeArgc;
 pQApplication = new QApplication(*pFakeArgc, pFakeArgv);
diff --git a/vcl/unx/kde5/KDE5SalGraphics.cxx b/vcl/unx/kde5/KDE5SalGraphics.cxx
index 290127d0526e..0b4b4283f0da 100644
--- a/vcl/unx/kde5/KDE5SalGraphics.cxx
+++ b/vcl/unx/kde5/KDE5SalGraphics.cxx
@@ -78,8 +78,8 @@ void KDE5SalGraphics::GetResolution(sal_Int32& rDPIX, 
sal_Int32& rDPIY)
 return;
 
 QScreen* pScreen = 
m_pFrame->GetQWidget()->window()->windowHandle()->screen();
-rDPIX = pScreen->logicalDotsPerInchX();
-rDPIY = pScreen->logicalDotsPerInchY();
+rDPIX = pScreen->logicalDotsPerInchX() * pScreen->devicePixelRatio() + 0.5;
+rDPIY = pScreen->logicalDotsPerInchY() * pScreen->devicePixelRatio() + 0.5;
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/unx/kde5/KDE5SalInstance.cxx b/vcl/unx/kde5/KDE5SalInstance.cxx
index 401afbcfa2dd..32998cdb36e3 100644
--- a/vcl/unx/kde5/KDE5SalInstance.cxx
+++ b/vcl/unx/kde5/KDE5SalInstance.cxx
@@ -144,6 +144,8 @@ VCLPLUG_KDE5_PUBLIC SalInstance* create_SalInstance()
 unsetenv("SESSION_MANAGER");
 }
 
+QApplication::setAttribute(Qt::AA_DisableHighDpiScaling);
+
 int* pFakeArgc = new int;
 *pFakeArgc = nFakeArgc;
 pQApplication = new QApplication(*pFakeArgc, pFakeArgv);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 53904] Readme file -- remove mention of LibreOffice 3.3 and review all platform requirements.

https://bugs.documentfoundation.org/show_bug.cgi?id=53904

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru

--- Comment #7 from Roman Kuznetsov <79045_79...@mail.ru> ---
Olivier, what do you think about this bug? It's actual now or already not?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/po loleaflet/src

 loleaflet/po/templates/loleaflet-ui.pot |4 ++--
 loleaflet/src/map/Map.js|4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit d07abfeb6785bb3e014db00368e6f4201e2c96d8
Author: Andras Timar 
AuthorDate: Sat Mar 30 23:14:45 2019 +0100
Commit: Andras Timar 
CommitDate: Sat Mar 30 23:14:45 2019 +0100

make these strings better localizable: minutes ago/seconds ago

Change-Id: Idf46c11bc4fccb14e4a3955e9ac88901ed94586b

diff --git a/loleaflet/po/templates/loleaflet-ui.pot 
b/loleaflet/po/templates/loleaflet-ui.pot
index 0c8e86667..bafb00801 100644
--- a/loleaflet/po/templates/loleaflet-ui.pot
+++ b/loleaflet/po/templates/loleaflet-ui.pot
@@ -982,11 +982,11 @@ msgid "Initializing..."
 msgstr ""
 
 #: src/map/Map.js:334
-msgid "seconds ago"
+msgid "%d seconds ago"
 msgstr ""
 
 #: src/map/Map.js:337
-msgid "minutes ago"
+msgid "%d minutes ago"
 msgstr ""
 
 #: src/map/Map.js:1033
diff --git a/loleaflet/src/map/Map.js b/loleaflet/src/map/Map.js
index eab327366..01da473b6 100644
--- a/loleaflet/src/map/Map.js
+++ b/loleaflet/src/map/Map.js
@@ -331,10 +331,10 @@ L.Map = L.Evented.extend({
 
var elapsed = Date.now() - dateTime;
if (elapsed < 6) {
-   dateValue = Math.round(elapsed / 1000) + ' ' + 
_('seconds ago');
+   dateValue = _('%d seconds ago').replace('%d', 
Math.round(elapsed / 1000));
timeout = 6000;
} else if (elapsed < 360) {
-   dateValue = Math.round(elapsed / 6) + ' ' + 
_('minutes ago');
+   dateValue = _('%d minutes ago').replace('%d', 
Math.round(elapsed / 6));
timeout = 6;
}
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124379] Calc does not sort category formatted columns by multiple Sort Criteria

https://bugs.documentfoundation.org/show_bug.cgi?id=124379

--- Comment #10 from sam3...@gmx.com ---
i did exactly what was said (search for whitespaces

should be possible with search & replace dialog -> regular expressions)
and I keep getting "search key not found" Could you tell me how to get rid of
the trailing spaces please?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/test qadevOOo/Jar_OOoRunner.mk qadevOOo/objdsc qadevOOo/tests sc/qa solenv/clang-format test/Library_subsequenttest.mk test/source

2019-03-30 Thread Jens Carl (via logerrit)

 include/test/helper/form.hxx  |   15 
 include/test/view/xformlayeraccess.hxx|   43 ++
 qadevOOo/Jar_OOoRunner.mk |1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScViewPaneObj.csv |4 
 qadevOOo/tests/java/mod/_sc/ScViewPaneObj.java|  174 --
 sc/qa/extras/scviewpaneobj.cxx|   65 ++-
 sc/qa/unoapi/sc_7.sce |1 
 solenv/clang-format/blacklist |1 
 test/Library_subsequenttest.mk|1 
 test/source/helper/form.cxx   |8 
 test/source/view/xformlayeraccess.cxx |   58 +++
 11 files changed, 171 insertions(+), 200 deletions(-)

New commits:
commit 2e0e7a15f66f5cb55f2a424fae6a9050c2c7f9ca
Author: Jens Carl 
AuthorDate: Fri Mar 29 22:06:59 2019 +
Commit: Jens Carl 
CommitDate: Sat Mar 30 22:40:23 2019 +0100

tdf#45904 Move XFormLayerAccess Java tests to C++

Move XFormLayerAccess Java tests to C++ for ScViewPaneObj.

Change-Id: I7ed6ff51d435b6f3de85daec99a13583e50a450a
Reviewed-on: https://gerrit.libreoffice.org/69942
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/include/test/helper/form.hxx b/include/test/helper/form.hxx
index f6e035d64fec..d84794cc5b6d 100644
--- a/include/test/helper/form.hxx
+++ b/include/test/helper/form.hxx
@@ -26,6 +26,19 @@ namespace helper
 {
 namespace form
 {
+/** @brief Create a XControlShape of kind "CommandButton".
+ *
+ * @param r_xComponent  The document.
+ * @param nXThe x-position of the shape.
+ * @param nYThe y-position of the shape.
+ * @param nHeight   The height of the shape.
+ * @param nWidthThe width of the shape.
+ * @return  The created XControlShape.
+ */
+css::uno::Reference OOO_DLLPUBLIC_TEST 
createCommandButton(
+const css::uno::Reference& r_xComponent, const 
sal_Int32 nX,
+const sal_Int32 nY, const sal_Int32 nHeight, const sal_Int32 nWidth);
+
 /** @brief Create a XControlShape
  *
  * @param r_xComponent  The document.
@@ -34,7 +47,7 @@ namespace form
  * @param nYThe y-position of the shape.
  * @param nHeight   The height of the shape.
  * @param nWidthThe width of the shape.
- * @return  The create XControlShape.
+ * @return  The created XControlShape.
  */
 css::uno::Reference OOO_DLLPUBLIC_TEST 
createControlShape(
 const css::uno::Reference& r_xComponent, const 
OUString& r_aKind,
diff --git a/include/test/view/xformlayeraccess.hxx 
b/include/test/view/xformlayeraccess.hxx
new file mode 100644
index ..ddd2542ab8ef
--- /dev/null
+++ b/include/test/view/xformlayeraccess.hxx
@@ -0,0 +1,43 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#ifndef INCLUDED_TEST_VIEW_XFORMLAYERACCESS_HXX
+#define INCLUDED_TEST_VIEW_XFORMLAYERACCESS_HXX
+
+#include 
+#include 
+
+#include 
+
+#include 
+
+namespace apitest
+{
+class OOO_DLLPUBLIC_TEST XFormLayerAccess
+{
+public:
+virtual css::uno::Reference init() = 0;
+void setForm(const css::uno::Reference& r_xForm) { 
m_xForm = r_xForm; }
+
+void testGetFormController();
+void testIsFormDesignMode();
+void testSetFormDesignMode();
+
+protected:
+~XFormLayerAccess() {}
+
+private:
+css::uno::Reference m_xForm;
+};
+
+} // namespace apitest
+
+#endif // INCLUDED_TEST_VIEW_XFORMLAYERACCESS_HXX
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/qadevOOo/Jar_OOoRunner.mk b/qadevOOo/Jar_OOoRunner.mk
index 3cb59e2c61de..3539ddbfce9d 100644
--- a/qadevOOo/Jar_OOoRunner.mk
+++ b/qadevOOo/Jar_OOoRunner.mk
@@ -975,7 +975,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\
 qadevOOo/tests/java/mod/_sc/ScTableSheetObj \
 qadevOOo/tests/java/mod/_sc/ScTableSheetsObj \
 qadevOOo/tests/java/mod/_sc/ScTabViewObj \
-qadevOOo/tests/java/mod/_sc/ScViewPaneObj \
 qadevOOo/tests/java/mod/_sc/XMLContentExporter \
 qadevOOo/tests/java/mod/_sc/XMLContentImporter \
 qadevOOo/tests/java/mod/_sc/XMLExporter \
diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScViewPaneObj.csv 
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScViewPaneObj.csv
deleted file mode 100644
index a4a3586f943f..
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScViewPaneObj.csv
+++ /dev/null
@@ -1,4 +0,0 @@
-"ScViewPaneObj";"com::sun::star::view::XFormLayerAccess#optional";"getFromController()"

[Libreoffice-bugs] [Bug 45904] move java based api tests to c++

https://bugs.documentfoundation.org/show_bug.cgi?id=45904

--- Comment #289 from Commit Notification 
 ---
Jens Carl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/2e0e7a15f66f5cb55f2a424fae6a9050c2c7f9ca%5E%21

tdf#45904 Move XFormLayerAccess Java tests to C++

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: kit/Kit.cpp net/ServerSocket.hpp net/Socket.cpp net/Socket.hpp wsd/LOOLWSD.cpp

 kit/Kit.cpp  |8 ---
 net/ServerSocket.hpp |   55 +--
 net/Socket.cpp   |  121 ++-
 net/Socket.hpp   |3 +
 wsd/LOOLWSD.cpp  |   13 +
 5 files changed, 131 insertions(+), 69 deletions(-)

New commits:
commit 201bcb0762c838e75b61f030725c9bf0ba59c1c3
Author: Michael Meeks 
AuthorDate: Sat Mar 30 21:07:58 2019 +
Commit: Michael Meeks 
CommitDate: Sat Mar 30 21:37:05 2019 +

Use peercreds to identify processes connecting rather than URL params.

Change-Id: I241e80962fb8cf2f3fff1bb4be81d9f0ee74c648

diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 819fb2698..ff4a3a7ed 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -2485,11 +2485,8 @@ void lokit_main(
 
 LOG_INF("Process is ready.");
 
-static const std::string pid = std::to_string(Process::id());
 std::string pathAndQuery(NEW_CHILD_URI);
-pathAndQuery.append("?pid=");
-pathAndQuery.append(pid);
-pathAndQuery.append("=");
+pathAndQuery.append("?jailid=");
 pathAndQuery.append(jailId);
 if (queryVersion)
 {
@@ -2522,7 +2519,6 @@ void lokit_main(
 
 // Dummies
 const std::string jailId = "jailid";
-const std::string pid = "101";
 
 #endif // MOBILEAPP
 
@@ -2530,7 +2526,7 @@ void lokit_main(
 mainKit.runOnClientThread(); // We will do the polling on this thread.
 
 std::shared_ptr websocketHandler =
-std::make_shared("child_ws_" + pid, loKit, 
jailId, mainKit);
+std::make_shared("child_ws", loKit, jailId, 
mainKit);
 #if !MOBILEAPP
 mainKit.insertNewUnixSocket(MasterLocation, pathAndQuery, 
websocketHandler);
 #else
diff --git a/net/ServerSocket.hpp b/net/ServerSocket.hpp
index 79a7795bc..dd07af4fe 100644
--- a/net/ServerSocket.hpp
+++ b/net/ServerSocket.hpp
@@ -61,58 +61,7 @@ public:
 /// Accepts an incoming connection (Servers only).
 /// Does not retry on error.
 /// Returns a valid Socket shared_ptr on success only.
-std::shared_ptr accept()
-{
-// Accept a connection (if any) and set it to non-blocking.
-// There still need the client's address to filter request from 
POST(call from REST) here.
-#if !MOBILEAPP
-struct sockaddr_in6 clientInfo;
-socklen_t addrlen = sizeof(clientInfo);
-const int rc = ::accept4(getFD(), (struct sockaddr *), 
, SOCK_NONBLOCK);
-#else
-const int rc = fakeSocketAccept4(getFD());
-#endif
-LOG_DBG("Accepted socket #" << rc << ", creating socket object.");
-try
-{
-// Create a socket object using the factory.
-if (rc != -1)
-{
-#if !MOBILEAPP
-char addrstr[INET6_ADDRSTRLEN];
-
-const void *inAddr;
-if (clientInfo.sin6_family == AF_INET)
-{
-auto ipv4 = (struct sockaddr_in *)
-inAddr = &(ipv4->sin_addr);
-}
-else
-{
-auto ipv6 = (struct sockaddr_in6 *)
-inAddr = &(ipv6->sin6_addr);
-}
-
-inet_ntop(clientInfo.sin6_family, inAddr, addrstr, 
sizeof(addrstr));
-std::shared_ptr _socket = _sockFactory->create(rc);
-_socket->setClientAddress(addrstr);
-LOG_DBG("Accepted socket has family " << 
clientInfo.sin6_family <<
-" address " << _socket->clientAddress());
-#else
-std::shared_ptr _socket = _sockFactory->create(rc);
-_socket->setClientAddress("dummy");
-#endif
-return _socket;
-}
-return std::shared_ptr(nullptr);
-}
-catch (const std::exception& ex)
-{
-LOG_SYS("Failed to create client socket #" << rc << ". Error: " << 
ex.what());
-}
-
-return nullptr;
-}
+virtual std::shared_ptr accept();
 
 int getPollEvents(std::chrono::steady_clock::time_point /* now */,
   int & /* timeoutMaxMs */) override
@@ -143,6 +92,7 @@ public:
 private:
 Socket::Type _type;
 SocketPoll& _clientPoller;
+protected:
 std::shared_ptr _sockFactory;
 };
 
@@ -155,6 +105,7 @@ public:
 {
 }
 virtual bool bind(Type, int) { assert(false); return false; }
+virtual std::shared_ptr accept() override;
 std::string bind();
 
 private:
diff --git a/net/Socket.cpp b/net/Socket.cpp
index a1762352e..02fb7f972 100644
--- a/net/Socket.cpp
+++ b/net/Socket.cpp
@@ -16,6 +16,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 #include 
@@ -398,7 +399,8 @@ void StreamSocket::dumpState(std::ostream& os)
 int events = getPollEvents(std::chrono::steady_clock::now(), timeoutMaxMs);
 os << "\t" << getFD() << "\t" << events << "\t"
<< _inBuffer.size() << "\t" << _outBuffer.size() << "\t"
-

[Libreoffice-commits] core.git: readlicense_oo/license

 readlicense_oo/license/license.xml |  100 +
 1 file changed, 79 insertions(+), 21 deletions(-)

New commits:
commit bcecc4a2943632030dcd71964bc0aa5690c03735
Author: Andras Timar 
AuthorDate: Sat Mar 30 22:34:45 2019 +0100
Commit: Andras Timar 
CommitDate: Sat Mar 30 22:35:26 2019 +0100

license: update 'Dictionaries' section

Change-Id: I18ec509ffac02bba0fd6191041a8f994034c8e74

diff --git a/readlicense_oo/license/license.xml 
b/readlicense_oo/license/license.xml
index a1d96581ce47..3ce8bc6da859 100644
--- a/readlicense_oo/license/license.xml
+++ b/readlicense_oo/license/license.xml
@@ -2624,6 +2624,11 @@
 This library is free software; you can redistribute it and/or 
modify it under the terms of the GNU Lesser General Public 
License as published by the Free Software
 Foundation; either version 2.1 of the License, or (at your option) any 
later version.
+Albanian
+Spelling dictionary
+The following software may be included in this product: Albanian 
spelling dictionary. Use of any of this
+software is governed by the terms of the license below:
+Jump to GNU GPL version 2.0
 Arabic
 Spelling dictionary
 The following software may be included in this product: Arabic 
spelling dictionary. Use of any of this
@@ -2674,6 +2679,12 @@
 The following software may be included in this product: Bengali 
spelling dictionary. Use of any of this
 software is governed by the terms of the license below:
 Jump to GNU GPL version 2.0
+Bosnian
+Spelling dictionary
+The following software may be included in this product: Bosnian 
spelling dictionary. Use of any of this
+software is governed by the terms of the license below:
+GPL 2.0/LGPL 2.1/MPL 
1.1
+tri-license
 Breton
 Spelling dictionary
 The following software may be included in this product: Breton 
spelling dictionary. Use of any of this
@@ -2721,13 +2732,23 @@
 Jump to GPL version 3
 Jump to LGPL version 3
 Czech
+Spelling dictionary
+The following software may be included in this product: Czech 
spelling dictionary. Use of any of this
+software is governed by the terms of the license below:
+Jump to GNU GPL version 2.0
+Hyphenation patterns
+The following software may be included in this product: Czech 
hyphenation patterns. Use of any of this
+software is governed by the terms of the license below:
+Jump to GNU GPL version 2.0
 Thesaurus
 The following software may be included in this product: Czech 
thesaurus. Use of any of this software is
 governed by the terms of the license below:
-Copyright (c) 1994,2008 Karel Pala, Jan Všianský
-p...@fi.muni.cz
-You can freely use the thesaurus in OpenOffice.org (or its 
derivatives). You can not modify it or use for
-commercial purposes without the author's approval.
+Origin: Generated from an English - Czech translation 
dictionary, https://www.svobodneslovniky.cz/;>https://www.svobodneslovniky.cz/
+License: GNU Free Documentation License 1.1 or later, details in https://gerrit.libreoffice.org/plugins/gitiles/dictionaries/+/master/cs_CZ/README_en.txt;>Appendix
 A
+The thesaurus is generated automatically via a script by Jan 
Holesovsky ke...@collabora.com, based
+on idea of Zdenek Zabokrtsky - big thanks!
 Croatian
 Spelling dictionary
 The following software may be included in this product: Croatian 
spelling dictionary. Use of any of this
@@ -3322,6 +3343,16 @@
 Spellchecker files (gl_ES.aff, gl_ES.dic) from Mar Castro Pereiro 
also developed for Mancomún.
 Distributed under the GPL License.
 Jump to GPL Version 3
+Guarani
+Spelling dictionary
+The following software may be included in this product: Guarani 
spelling dictionary. 
+Thesaurus
+The following software may be included in this product: Guarani 
thesaurus. Use of any of this software is
+governed by the terms of the license below:
+Permission is granted to copy, distribute and/or modify this 
document under the terms of the GNU Free
+Documentation License, Version 1.2 or any later version published by 
the Free Software Foundation; with no
+Invariant Sections, no Front-Cover Texts, and no Back-Cover Texts. A 
copy of the license is included in the
+section entitled "GNU Free Documentation License".
 Gujarati
 Spelling dictionary
 The following software may be included in this product: Gujarati 
spelling dictionary. Use of any of this
@@ -3350,18 +3381,16 @@
 Spelling dictionary
 The following software may be included in this product: Hungarian 
spelling dictionary. Use of any of this

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

https://bugs.documentfoundation.org/show_bug.cgi?id=123752

--- Comment #10 from Jouni Kosonen  ---
(In reply to Buovjaga from comment #9)
> (In reply to Jouni Kosonen from comment #8)
> > Both 6.1 and 6.2 have now been released with this behavior and I can't find
> > anything related in gerrit, is this being worked on or should I just try to
> > figure out some kind of a fix myself?
> 
> If you could do that, it would be great and I think Eike would be happy to
> review your patch.

That could take a while, not least because Gentoo Linux just pulled the 6.2.1.2
ebuild I've been using to tinker with this and the 6.2.2.2 they replaced it
with doesn't actually build.

As far as I can tell, the best way to fix this without breaking bug 42518 again
would be to process the group separator so that the formula parser never sees
it was there in the first place. I'll look into it but Ḯ'm not overly
optimistic.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124450] Libreoffice Calc: Autofilter functions are slow

https://bugs.documentfoundation.org/show_bug.cgi?id=124450

--- Comment #1 from Juhani Suhonen  ---
Created attachment 150417
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150417=edit
Just try to open Autofilter dropdown

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/src

 loleaflet/src/control/Control.Toolbar.js |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit dcf9559ecd7c6a38a196cf61a0ea4b46942b
Author: Henry Castro 
AuthorDate: Thu Mar 21 10:31:15 2019 -0400
Commit: Henry Castro 
CommitDate: Sat Mar 30 22:06:30 2019 +0100

loleaflet: add label "document modified" to the status bar

Change-Id: I4550b649fbb31da7e2d6dd2a9a3e5bd95b326d25
Reviewed-on: https://gerrit.libreoffice.org/69515
Reviewed-by: Henry Castro 
Tested-by: Henry Castro 

diff --git a/loleaflet/src/control/Control.Toolbar.js 
b/loleaflet/src/control/Control.Toolbar.js
index d28141eca..a61df519f 100644
--- a/loleaflet/src/control/Control.Toolbar.js
+++ b/loleaflet/src/control/Control.Toolbar.js
@@ -995,7 +995,7 @@ function initNormalToolbar() {
{type: 'button',  id: 'cancelsearch', img: 
'cancel', hint: _('Cancel the search'), hidden: true},
{type: 'html',  id: 'left'},
{type: 'html',  id: 'right'},
-   {type: 'html',  id: 'modifiedstatuslabel', 
hidden: true, html: '', mobile: false, tablet: false},
+   {type: 'html',  id: 'modifiedstatuslabel', 
html: '', mobile: 
false, tablet: false},
{type: 'break', id: 'modifiedstatuslabelbreak', 
mobile: false},
{type: 'drop', id: 'userlist', img: 'users', 
hidden: true, html: '' +
'' +
@@ -1683,7 +1683,7 @@ function onCommandStateChanged(e) {
var modifiedStatus = e.state === 'true';
var html;
if (modifiedStatus) {
-   html = 
$('#modifiedstatuslabel').html('').parent().html();
+   html = $('#modifiedstatuslabel').html('Document 
modified').parent().html();
w2ui['editbar'].set('save', {img:'savemodified'});
}
else {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124450] New: Libreoffice Calc: Autofilter functions are slow

https://bugs.documentfoundation.org/show_bug.cgi?id=124450

Bug ID: 124450
   Summary: Libreoffice Calc: Autofilter functions are slow
   Product: LibreOffice
   Version: 6.2.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: juhani.suhone...@gmail.com

Description:
Autofilter functions are really slow with large (>100.000 entries) lists. This
makes autofilters practically unusable. Improving sorting algorithm would
significantly speed up autofilters.

Steps to Reproduce:
1.Create spreadsheet with >100.000 lines
2.Apply Autofilter to first row
3.Try to open Autofilter dropdown menu -> Calc freezes for >60 seconds

Actual Results:
happens 100% of the time, regardless of OS and HW

Expected Results:
Eventually calc will resume, but slowness makes it unusable


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Simple sorting algorithm would speed up opening autofilters by factor of 1000.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/js

 loleaflet/js/global.js |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 68be4badb21e7fd2ae7ce36632383e008086c507
Author: Henry Castro 
AuthorDate: Sat Mar 30 16:40:35 2019 -0400
Commit: Henry Castro 
CommitDate: Sat Mar 30 16:58:08 2019 -0400

loleaflet: fix the prototype property of a constructor L.Socket

Change-Id: Ie0086b6e1129fa9aaba416e44d49829fe605ded6

diff --git a/loleaflet/js/global.js b/loleaflet/js/global.js
index 664a06e37..344ada470 100644
--- a/loleaflet/js/global.js
+++ b/loleaflet/js/global.js
@@ -127,7 +127,7 @@
}
 
global.socket.onmessage = function (event) {
-   if (global.L && global.socket instanceof L.Socket) {
+   if (global.L && global.socket instanceof 
global.L.Socket) {
global.socket._onMessage(event);
} else {
global.queueMsg.push(event.data);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 122263] Bad resolution for icons in LO Draw

https://bugs.documentfoundation.org/show_bug.cgi?id=122263

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de

--- Comment #9 from Michael Weghorn  ---
Hi Vera, could you please do a quick check whether this still happens with the
fix for bug 124292 applied?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124237] SAL_USE_VCLPLUGIN=kde5 renders everything aliased

https://bugs.documentfoundation.org/show_bug.cgi?id=124237

--- Comment #10 from Michael Weghorn  ---
Is this still reproducible with the fix for bug 124292 applied?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=102495
Bug 102495 depends on bug 124292, which changed state.

Bug 124292 Summary: KDE5: Fractional scaling makes most UI and rendered text 
look bad
https://bugs.documentfoundation.org/show_bug.cgi?id=124292

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124292] KDE5: Fractional scaling makes most UI and rendered text look bad

https://bugs.documentfoundation.org/show_bug.cgi?id=124292

Michael Weghorn  changed:

   What|Removed |Added

 Whiteboard||target:6.3.0
 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #10 from Michael Weghorn  ---
The patch has been cherry-picked to master in the meanwhile. It wasn't
referenced here automatically (probably because TDF bugzilla had some issues
last night)

https://gerrit.libreoffice.org/plugins/gitiles/core/+/b4698a2241ec26d796c66da3a814f7cc693785b6

commit b4698a2241ec26d796c66da3a814f7cc693785b6
Author: Jan-Marek Glogowski 
Date:   Fri Mar 29 02:58:59 2019 +0100

tdf#124292 Qt5 / KDE5 disable Qt's HiDPI scaling

LO does its own layouting and also all the scaling, so disable
the automatic HiDPI scaling explicitly. Otherwise fonts will be
rendered in LoDPI and just scaled as an image, if UI scaling is
enabled in KDE, resulting in really blocky / ugly fonts.

Change-Id: I38503ce27c1671e80d0749d21c6c6dcff1a808a6
Reviewed-on: https://gerrit.libreoffice.org/69941
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

-> fixed now, s.a. comment 8

Backport for 6.2: https://gerrit.libreoffice.org/#/c/69984/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: configure.ac

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit da2bdd62dac469d6ae06f6be2b197efff316cb18
Author: Henry Castro 
AuthorDate: Sat Mar 30 16:32:49 2019 -0400
Commit: Henry Castro 
CommitDate: Sat Mar 30 16:35:40 2019 -0400

configure: update links for directory "archived-packages"

Change-Id: Iea7d5f867b5a7a2f987b0513d33ffb675729de97

diff --git a/configure.ac b/configure.ac
index b99020a7a..91a90e984 100644
--- a/configure.ac
+++ b/configure.ac
@@ -678,7 +678,7 @@ AC_SUBST(ENABLE_SETCAP)
 AC_CONFIG_LINKS([discovery.xml:discovery.xml])
 AC_CONFIG_LINKS([loolkitconfig.xcu:loolkitconfig.xcu])
 AC_CONFIG_LINKS([loleaflet/package.json:loleaflet/package.json])
-AC_LINK_FILES([loleaflet/node_shrinkwrap], [loleaflet/node_shrinkwrap])
+AC_LINK_FILES([loleaflet/archived-packages], [loleaflet/archived-packages])
 
 AS_IF([test "$ENABLE_IOSAPP" = "true"],
   [
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124292] KDE5: Fractional scaling makes most UI and rendered text look bad

https://bugs.documentfoundation.org/show_bug.cgi?id=124292

--- Comment #9 from Michael Weghorn  ---
(In reply to Jan-Marek Glogowski from comment #7)
> [...]
> As you can see, nothing seem really consistent. Factors in this bug are:
> * Scaling on session start
> * Current scaling setting
> * QT_SCREEN_SCALE_FACTORS value
> [...]

This also explains why I couldn't reproduce. The QT_SCREEN_SCALE_FACTORS env
variable is set on login only.

When logging out and in again between steps 2 and 3 of the original
description, I can also reproduce when using a LibO version that doesn't have
the patch yet.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98140] FILEOPEN: open .pptx file - problem with SmartArt

https://bugs.documentfoundation.org/show_bug.cgi?id=98140

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
Summary|FILEOPEN: open .pptx file   |FILEOPEN: open .pptx file -
   |lost data in slides |problem with SmartArt
 Blocks||106547
   Keywords||filter:pptx

--- Comment #5 from Roman Kuznetsov <79045_79...@mail.ru> ---
I see all text on slides, it's correct. But I see also SmartArt problem there.

Change summary of the bug

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 5cb2db6dd7d234a610a6501668a9901af8472b7f
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-03-26_23:06:31
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106547
[Bug 106547] [META] OOXML SmartArt bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106547] [META] OOXML SmartArt bug tracker

https://bugs.documentfoundation.org/show_bug.cgi?id=106547

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||98140


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=98140
[Bug 98140] FILEOPEN: open .pptx file - problem with SmartArt
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/build loleaflet/src scripts/unocommands.py

 loleaflet/build/deps.js |2 +-
 scripts/unocommands.py  |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 59306e2f4c9b6d9ea2d669b5b9ae45573bbbc160
Author: Henry Castro 
AuthorDate: Sat Mar 30 16:09:59 2019 -0400
Commit: Henry Castro 
CommitDate: Sat Mar 30 16:22:32 2019 -0400

loleaflet: rename toolbar.js to Control.Toolbar.js

Change-Id: Ia8d0c3856ea40b4e342e5bec94c558c78464943f

diff --git a/loleaflet/build/deps.js b/loleaflet/build/deps.js
index 88f60116f..eea5545a2 100644
--- a/loleaflet/build/deps.js
+++ b/loleaflet/build/deps.js
@@ -292,7 +292,7 @@ var deps = {
},
 
ControlToolbar: {
-   src: ['control/toolbar.js'],
+   src: ['control/Control.Toolbar.js'],
heading: 'Controls',
desc: 'LibreOffice Online toolbar'
},
diff --git a/loleaflet/src/control/toolbar.js 
b/loleaflet/src/control/Control.Toolbar.js
similarity index 100%
rename from loleaflet/src/control/toolbar.js
rename to loleaflet/src/control/Control.Toolbar.js
diff --git a/scripts/unocommands.py b/scripts/unocommands.py
index df29ef8e5..3e5ec6bb8 100755
--- a/scripts/unocommands.py
+++ b/scripts/unocommands.py
@@ -122,7 +122,7 @@ def extractToolbarCommands(path):
 commands = []
 
 # extract from the menu specifications
-f = open(path + '/loleaflet/src/control/toolbar.js', 'r')
+f = open(path + '/loleaflet/src/control/Control.Toolbar.js', 'r')
 for line in f:
 if line.find("_UNO(") >= 0:
 commands += commandFromMenuLine(line)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104536] [Meta] Improvements to the annotation (pen) feature

https://bugs.documentfoundation.org/show_bug.cgi?id=104536

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||97484


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=97484
[Bug 97484] Presentation-mode: White/black screen - should be able to draw on
blank slide
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97484] Presentation-mode: White/black screen - should be able to draw on blank slide

https://bugs.documentfoundation.org/show_bug.cgi?id=97484

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||103610, 104536


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103610
[Bug 103610] [META] Slide show (presentation mode) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=104536
[Bug 104536] [Meta] Improvements to the annotation (pen) feature
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103610] [META] Slide show (presentation mode) bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=103610

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||97484


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=97484
[Bug 97484] Presentation-mode: White/black screen - should be able to draw on
blank slide
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62366] SLIDESHOW: Pen on the presenter console

https://bugs.documentfoundation.org/show_bug.cgi?id=62366

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||tobias.bur...@physik.fu-ber
   ||lin.de

--- Comment #14 from Roman Kuznetsov <79045_79...@mail.ru> ---
*** Bug 97482 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97482] Presentation-mode: Pen - drawing in presenter's view

https://bugs.documentfoundation.org/show_bug.cgi?id=97482

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #8 from Roman Kuznetsov <79045_79...@mail.ru> ---


*** This bug has been marked as a duplicate of bug 62366 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104536] [Meta] Improvements to the annotation (pen) feature

https://bugs.documentfoundation.org/show_bug.cgi?id=104536
Bug 104536 depends on bug 97482, which changed state.

Bug 97482 Summary: Presentation-mode: Pen - drawing in presenter's view
https://bugs.documentfoundation.org/show_bug.cgi?id=97482

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124438] [META] Presenter console bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=124438
Bug 124438 depends on bug 97482, which changed state.

Bug 97482 Summary: Presentation-mode: Pen - drawing in presenter's view
https://bugs.documentfoundation.org/show_bug.cgi?id=97482

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124438] [META] Presenter console bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=124438

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||97482


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=97482
[Bug 97482] Presentation-mode: Pen - drawing in presenter's view
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104536] [Meta] Improvements to the annotation (pen) feature

https://bugs.documentfoundation.org/show_bug.cgi?id=104536

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||97482


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=97482
[Bug 97482] Presentation-mode: Pen - drawing in presenter's view
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97482] Presentation-mode: Pen - drawing in presenter's view

https://bugs.documentfoundation.org/show_bug.cgi?id=97482

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||104536, 124438


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104536
[Bug 104536] [Meta] Improvements to the annotation (pen) feature
https://bugs.documentfoundation.org/show_bug.cgi?id=124438
[Bug 124438] [META] Presenter console bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97483] Presentation-mode: Context menu for current slide in presenter console

https://bugs.documentfoundation.org/show_bug.cgi?id=97483

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||124438
Summary|Presentation-mode: Context  |Presentation-mode: Context
   |menu for current slide in   |menu for current slide in
   |presenter's screen  |presenter console


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=124438
[Bug 124438] [META] Presenter console bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124438] [META] Presenter console bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=124438

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||97483


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=97483
[Bug 97483] Presentation-mode: Context menu for current slide in presenter
console
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97367] Editing white text has a white background fill (unseen in PDF and in slideshow)

https://bugs.documentfoundation.org/show_bug.cgi?id=97367

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||100373
 CC||79045_79...@mail.ru

--- Comment #8 from Roman Kuznetsov <79045_79...@mail.ru> ---
still repro with file from attach in

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 5cb2db6dd7d234a610a6501668a9901af8472b7f
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-03-26_23:06:31
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded

but white font on white background is in PDF and in presentation mode (F5) too.

For me it's just wrong formatting of title now and can be easy fix.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=100373
[Bug 100373] [META] Style issues in Draw/Impress
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 100373] [META] Style issues in Draw/Impress

https://bugs.documentfoundation.org/show_bug.cgi?id=100373

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||97367


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=97367
[Bug 97367] Editing white text has a white background fill (unseen in PDF and
in slideshow)
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 100373] [META] Style issues in Draw/Impress

https://bugs.documentfoundation.org/show_bug.cgi?id=100373

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||97367


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=97367
[Bug 97367] Editing white text has a white background fill (unseen in PDF and
in slideshow)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124326] Undo after drag changes the original formula

https://bugs.documentfoundation.org/show_bug.cgi?id=124326

--- Comment #3 from b.  ---
in ver.: 2019-03-30_02:16:1, unthreaded, win x64, with similar sheet after drag
and drop and undo formula is ok, but calculation not refreshed - 'repaint
problem'? - ctrl-shift-F9 works, and autocalculate works on further changes ...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93301] Font scaling is set to 400% if user input wrong character

https://bugs.documentfoundation.org/show_bug.cgi?id=93301

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 110746] [META] Options dialog's View settings bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=110746
Bug 110746 depends on bug 93301, which changed state.

Bug 93301 Summary: Font scaling is set to 400% if user input wrong character
https://bugs.documentfoundation.org/show_bug.cgi?id=93301

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93301] Font scaling is set to 400% if user input wrong character

https://bugs.documentfoundation.org/show_bug.cgi?id=93301

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
 Blocks||110746

--- Comment #6 from Roman Kuznetsov <79045_79...@mail.ru> ---
close as WONTFIX because scale options were delete from GUI


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=110746
[Bug 110746] [META] Options dialog's View settings bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 110746] [META] Options dialog's View settings bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=110746

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||93301


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=93301
[Bug 93301] Font scaling is set to 400% if user input wrong character
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

https://bugs.documentfoundation.org/show_bug.cgi?id=123752

--- Comment #9 from Buovjaga  ---
(In reply to Jouni Kosonen from comment #8)
> Both 6.1 and 6.2 have now been released with this behavior and I can't find
> anything related in gerrit, is this being worked on or should I just try to
> figure out some kind of a fix myself?

If you could do that, it would be great and I think Eike would be happy to
review your patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

https://bugs.documentfoundation.org/show_bug.cgi?id=123752

--- Comment #8 from Jouni Kosonen  ---
(In reply to Eike Rathke from comment #6)
> What happens is that 12_345,67 (here with '_' for the no-break space) is
> lexically tokenized to
> 
> 12
> _345
> ,67
> 
> which then leads to three numbers 12 and 345 (because there in the number
> parser the no-break space is just a leading space) and 0,67 (from which
> stems the extra 0 because a leading decimal separator is allowed), which
> then with the formula tokens concatenated as strings produces 123450,67

That would explain the extra zero and also the Err:509 afterwards, since that
ends up producing three numeric tokens with no operators in between.

It doesn't explain *why* this happens or why it *doesn't* happen when there is
a decimal separator but no group separator.

Both 6.1 and 6.2 have now been released with this behavior and I can't find
anything related in gerrit, is this being worked on or should I just try to
figure out some kind of a fix myself?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

2019-03-30 Thread Andrea Gelmini (via logerrit)

 sc/qa/uitest/calc_tests7/tdf123479.py |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3009f2eb2297e13cb3f802c7e3b78976f2f83b9d
Author: Andrea Gelmini 
AuthorDate: Sat Mar 30 17:24:46 2019 +
Commit: Jens Carl 
CommitDate: Sat Mar 30 20:17:24 2019 +0100

Fix typo

Change-Id: If908885fe642e0222f53d57e25ce9dab81bf27d5
Reviewed-on: https://gerrit.libreoffice.org/69973
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/sc/qa/uitest/calc_tests7/tdf123479.py 
b/sc/qa/uitest/calc_tests7/tdf123479.py
index dc346313d696..046bf83035a3 100644
--- a/sc/qa/uitest/calc_tests7/tdf123479.py
+++ b/sc/qa/uitest/calc_tests7/tdf123479.py
@@ -37,7 +37,7 @@ class tdf123479(UITestCase):
 edArg2 = xDialog.getChild("ED_ARG2")
 formulaRes = xDialog.getChild("formula_result")
 
-#check formula wizzard data
+#check formula wizard data
 self.assertEqual(get_state_as_dict(edArg1)["Text"], "CHAR(10)")
 self.assertEqual(get_state_as_dict(edArg2)["Text"], 
"OFFSET($Data.$A$2:$Data.$A$4,0,COLUMN()-3)")
 self.assertEqual(get_state_as_dict(formulaRes)["Text"], "{4;4;4}")
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124177] Non working menu entry - Help > Show shortcuts

https://bugs.documentfoundation.org/show_bug.cgi?id=124177

--- Comment #3 from Tor Lillqvist  ---
Probably we should not show such a menu entry in a mobile app. Perhaps not when
using server-based Online from a mobile device browser either. "Shortcut"
surely is a desktop concept.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123912] DOCX Text in protected form created in Writer is editable in Word

https://bugs.documentfoundation.org/show_bug.cgi?id=123912

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123912] DOCX Text in protected form created in Writer is editable in Word

https://bugs.documentfoundation.org/show_bug.cgi?id=123912

--- Comment #6 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/d9a6eab15a747cf4c8a3d04f4b21fe1a1c3d0721%5E%21

tdf#123912 ww8 export: re-protect implicit section

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa sw/source

2019-03-30 Thread Justin Luth (via logerrit)

 sw/qa/extras/ooxmlexport/data/tdf123912_protectedForm.odt |binary
 sw/qa/extras/ooxmlexport/ooxmlexport13.cxx|   16 ++
 sw/source/filter/ww8/wrtw8sty.cxx |6 -
 3 files changed, 21 insertions(+), 1 deletion(-)

New commits:
commit d9a6eab15a747cf4c8a3d04f4b21fe1a1c3d0721
Author: Justin Luth 
AuthorDate: Sat Mar 30 16:45:03 2019 +0300
Commit: Justin Luth 
CommitDate: Sat Mar 30 19:28:34 2019 +0100

tdf#123912 ww8 export: re-protect implicit section

Sections should retain their protected on/off status
regardless of the value of PROTECT_FORM. However, if there
ARE no sections, then the implicit section should use the
document settings. The same is true for the pseudo -1 section
which I believe can only be the last section (the fragment
of the implicit section that follows the last real section).

This is basically a revert of LO 6.2 commit
fa667b6dc410f3af57ef436cc117352c829f95e7, restoring
the previous behaviour in the case of the implicit section.

Change-Id: If0b473445e0add017504a3cb61b63116f92be5ce
Reviewed-on: https://gerrit.libreoffice.org/69957
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf123912_protectedForm.odt 
b/sw/qa/extras/ooxmlexport/data/tdf123912_protectedForm.odt
new file mode 100755
index ..34e87467ee3e
Binary files /dev/null and 
b/sw/qa/extras/ooxmlexport/data/tdf123912_protectedForm.odt differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
index 01e13fee05c7..6ca09581d1b5 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
@@ -16,6 +16,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -70,6 +71,21 @@ DECLARE_OOXMLEXPORT_TEST(testendingSectionProps, 
"endingSectionProps.docx")
 CPPUNIT_ASSERT_EQUAL_MESSAGE("Section Left Margin", sal_Int32(2540), 
getProperty(xSect, "SectionLeftMargin"));
 }
 
+DECLARE_OOXMLEXPORT_TEST(tdf123912_protectedForm, 
"tdf123912_protectedForm.odt")
+{
+SwXTextDocument* pTextDoc = dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+SwDoc* pDoc = pTextDoc->GetDocShell()->GetDoc();
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Compatibility: Protect form", true,
+ pDoc->getIDocumentSettingAccess().get( 
DocumentSettingId::PROTECT_FORM ) );
+
+uno::Reference 
xTextSectionsSupplier(mxComponent, uno::UNO_QUERY);
+uno::Reference 
xSections(xTextSectionsSupplier->getTextSections(), uno::UNO_QUERY);
+uno::Reference xSect(xSections->getByIndex(0), 
uno::UNO_QUERY);
+if ( xSect.is() )
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Section1 is protected", true, 
getProperty(xSect, "IsProtected"));
+}
+
 DECLARE_OOXMLEXPORT_TEST(testDateControl, "empty-date-control.odt")
 {
 // Check that we did not lost the date control
diff --git a/sw/source/filter/ww8/wrtw8sty.cxx 
b/sw/source/filter/ww8/wrtw8sty.cxx
index eb0cd1dc664d..f7bc5136e922 100644
--- a/sw/source/filter/ww8/wrtw8sty.cxx
+++ b/sw/source/filter/ww8/wrtw8sty.cxx
@@ -1526,7 +1526,11 @@ void MSWordExportBase::SectionProperties( const 
WW8_SepInfo& rSepInfo, WW8_PdAtt
 AttrOutput().SectFootnoteEndnotePr();
 
 // forms
-AttrOutput().SectionFormProtection( rSepInfo.IsProtected() );
+bool bFormProtection = rSepInfo.IsProtected();
+// use document settings when SepInfo has no protect settings (last 
section fragment or no sections at all)
+if ( !rSepInfo.pSectionFormat || 
(reinterpret_cast(sal_IntPtr(-1)) == rSepInfo.pSectionFormat) 
)
+bFormProtection |= m_pDoc->getIDocumentSettingAccess().get( 
DocumentSettingId::PROTECT_FORM );
+AttrOutput().SectionFormProtection( bFormProtection );
 
 // line numbers
 const SwLineNumberInfo& rLnNumInfo = m_pDoc->GetLineNumberInfo();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 90678] Microsoft Office 2007(2010) Excel opens already opened .xls and .xlsx file with LibreOffice

https://bugs.documentfoundation.org/show_bug.cgi?id=90678

Mike Kaganski  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
 Whiteboard||target:6.3.0
   Assignee|libreoffice-b...@lists.free |zolnaitamas2...@gmail.com
   |desktop.org |

--- Comment #4 from Mike Kaganski  ---
Writing MSO lockfiles is implemented in

https://git.libreoffice.org/core/+/5db1e20b8b0942dac2d50f3cd34532bb61147020
https://git.libreoffice.org/core/+/41dc917b9b55b8c0c4307ffc58a1fb7257df2b69
https://git.libreoffice.org/core/+/ad47e9b1c0d3f1720665b2786090e8c0927b5b45

A dedicated configuration option "[ ] Create MSO lock file" on
Options->Load/Save->Microsoft Office dialog controls this.

Closing RESOLVED FIXED. Tamás Zolnai, thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114300] [META] Bugs and enhancements involving lock files or file locking

https://bugs.documentfoundation.org/show_bug.cgi?id=114300
Bug 114300 depends on bug 90678, which changed state.

Bug 90678 Summary: Microsoft Office 2007(2010) Excel opens already opened .xls  
and .xlsx file with LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=90678

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109072] [META] XLS (binary) format bug tracker

https://bugs.documentfoundation.org/show_bug.cgi?id=109072
Bug 109072 depends on bug 90678, which changed state.

Bug 90678 Summary: Microsoft Office 2007(2010) Excel opens already opened .xls  
and .xlsx file with LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=90678

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108897] [META] XLSX (OOXML) bug tracker

https://bugs.documentfoundation.org/show_bug.cgi?id=108897
Bug 108897 depends on bug 90678, which changed state.

Bug 90678 Summary: Microsoft Office 2007(2010) Excel opens already opened .xls  
and .xlsx file with LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=90678

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124413] Crash on undo / redo in Basic IDE

https://bugs.documentfoundation.org/show_bug.cgi?id=124413

--- Comment #2 from Julien Nabet  ---
Created attachment 150416
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150416=edit
Valgrind trace

On pc Debian x86-64 with master sources updated today, I could reproduce this.
I attached Valgrind trace.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102307] F3 executes uno:RepeatSearch from the FindBar TextFind widget when not defined as the shortcut

https://bugs.documentfoundation.org/show_bug.cgi?id=102307

--- Comment #6 from mahfiaz  ---
It still happens in 6.2.2.2

svx/source/tbxctrls/tbunosearchcontrollers.cxx@269

// Execute the search when Return, Ctrl-G or F3 pressed
if ( KEY_RETURN == nCode || (bMod1 && (KEY_G == nCode)) || (KEY_F3
== nCode) )

should be:

// Execute the search when Return or Ctrl-G is pressed
if ( KEY_RETURN == nCode || (bMod1 && (KEY_G == nCode)) )

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102847] [META] Quick Find, Search and Replace

https://bugs.documentfoundation.org/show_bug.cgi?id=102847

raal  changed:

   What|Removed |Added

 Depends on||124248


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=124248
[Bug 124248] Search & Replace Font / Formatting in Impress
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124248] Search & Replace Font / Formatting in Impress

https://bugs.documentfoundation.org/show_bug.cgi?id=124248

raal  changed:

   What|Removed |Added

 CC||r...@post.cz
 Status|UNCONFIRMED |NEW
 Blocks||102847
 Ever confirmed|0   |1
 OS|Windows (All)   |All

--- Comment #1 from raal  ---
Setting to new


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102847
[Bug 102847] [META] Quick Find, Search and Replace
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56609] Chart with merged labels row needs non-numeric second line

https://bugs.documentfoundation.org/show_bug.cgi?id=56609

--- Comment #8 from mahfiaz  ---
Still an issue in 6.2.2.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Changes to 'refs/tags/3.4.4-1'

Tag '3.4.4-1' created by Andras Timar  at 
2019-03-30 17:34 +

3.4.4-1

Changes since 3.4.3-1-8:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: common/Common.hpp common/UnitHTTP.hpp kit/ForKit.cpp kit/Kit.cpp net/ServerSocket.hpp net/Socket.cpp net/Socket.hpp wsd/LOOLWSD.cpp

 common/Common.hpp|5 +
 common/UnitHTTP.hpp  |2 
 kit/ForKit.cpp   |6 +-
 kit/Kit.cpp  |   23 
 net/ServerSocket.hpp |   18 ++
 net/Socket.cpp   |  136 ---
 net/Socket.hpp   |   25 ++---
 wsd/LOOLWSD.cpp  |   68 +++--
 8 files changed, 194 insertions(+), 89 deletions(-)

New commits:
commit 81a27e26aab2fed410310c3cda46090b8a2c8a50
Author: Michael Meeks 
AuthorDate: Sat Mar 30 14:06:16 2019 +
Commit: Michael Meeks 
CommitDate: Sat Mar 30 16:51:06 2019 +

Switch local prisoner sockets to abstract UDS

Unix Domain Sockets are inaddressable remotely, and more efficient,
as well as allowing future SCM_CREDENTIALS / SCM_RIGHTS.

Change-Id: Ia2472260f75feb43e9022cdfa0fe005ccd489454

diff --git a/common/Common.hpp b/common/Common.hpp
index 013b30798..af37a77dd 100644
--- a/common/Common.hpp
+++ b/common/Common.hpp
@@ -7,12 +7,13 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
+#include 
+
 // Default values and other shared data between processes.
 #ifndef INCLUDED_COMMON_HPP
 #define INCLUDED_COMMON_HPP
 
 constexpr int DEFAULT_CLIENT_PORT_NUMBER = 9980;
-constexpr int DEFAULT_MASTER_PORT_NUMBER = 9981;
 
 constexpr int COMMAND_TIMEOUT_MS = 5000;
 constexpr long CHILD_TIMEOUT_MS = COMMAND_TIMEOUT_MS;
@@ -46,7 +47,7 @@ constexpr const char* WOPI_AGENT_STRING = "LOOLWSD WOPI Agent 
" LOOLWSD_VERSION;
 
 // The client port number, both loolwsd and the kits have this.
 extern int ClientPortNumber;
-extern int MasterPortNumber;
+extern std::string MasterLocation;
 
 #endif
 
diff --git a/common/UnitHTTP.hpp b/common/UnitHTTP.hpp
index d87ce8e3f..2eb1c629f 100644
--- a/common/UnitHTTP.hpp
+++ b/common/UnitHTTP.hpp
@@ -74,7 +74,7 @@ public:
 UnitHTTPServerRequest(UnitHTTPServerResponse& inResponse,
   const std::string& uri) :
 _response(inResponse),
-_serverAddress(MasterPortNumber)
+_serverAddress(9981) // FIXME: Unix Sockets now ...
 {
 setURI(uri);
 }
diff --git a/kit/ForKit.cpp b/kit/ForKit.cpp
index 38c15d215..1cbf59a13 100644
--- a/kit/ForKit.cpp
+++ b/kit/ForKit.cpp
@@ -60,7 +60,7 @@ static std::map childJails;
 
 #ifndef KIT_IN_PROCESS
 int ClientPortNumber = DEFAULT_CLIENT_PORT_NUMBER;
-int MasterPortNumber = DEFAULT_MASTER_PORT_NUMBER;
+std::string MasterLocation;
 #endif
 
 /// Dispatcher class to demultiplex requests from
@@ -401,7 +401,7 @@ int main(int argc, char** argv)
 ClientPortNumber = std::stoi(clientPort);
 static const char* masterPort = std::getenv("LOOL_TEST_MASTER_PORT");
 if (masterPort)
-MasterPortNumber = std::stoi(masterPort);
+MasterLocation = masterPort;
 #endif
 
 for (int i = 0; i < argc; ++i)
@@ -436,7 +436,7 @@ int main(int argc, char** argv)
 else if (std::strstr(cmd, "--masterport=") == cmd)
 {
 eq = std::strchr(cmd, '=');
-MasterPortNumber = std::stoll(std::string(eq+1));
+MasterLocation = std::string(eq+1);
 }
 else if (std::strstr(cmd, "--version") == cmd)
 {
diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index faf6ad4f8..819fb2698 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -2486,20 +2486,21 @@ void lokit_main(
 LOG_INF("Process is ready.");
 
 static const std::string pid = std::to_string(Process::id());
-
-Poco::URI uri("ws://127.0.0.1");
-uri.setPort(MasterPortNumber);
-uri.setPath(NEW_CHILD_URI);
-uri.addQueryParameter("pid", std::to_string(Process::id()));
-uri.addQueryParameter("jailid", jailId);
-
+std::string pathAndQuery(NEW_CHILD_URI);
+pathAndQuery.append("?pid=");
+pathAndQuery.append(pid);
+pathAndQuery.append("=");
+pathAndQuery.append(jailId);
 if (queryVersion)
 {
 char* versionInfo = loKit->getVersionInfo();
 std::string versionString(versionInfo);
 if (displayVersion)
 std::cout << "office version details: " << versionString << 
std::endl;
-uri.addQueryParameter("version", versionString);
+std::string encodedVersion;
+Poco::URI::encode(versionString, "?#/", encodedVersion);
+pathAndQuery.append("=");
+pathAndQuery.append(encodedVersion);
 free(versionInfo);
 }
 
@@ -2528,10 +2529,12 @@ void lokit_main(
 SocketPoll mainKit("kit");
 mainKit.runOnClientThread(); // We will do the polling on this thread.
 
+std::shared_ptr websocketHandler =
+std::make_shared("child_ws_" + pid, loKit, 
jailId, mainKit);
 #if !MOBILEAPP
-mainKit.insertNewWebSocketSync(uri, 
std::make_shared("child_ws_" + pid, loKit, jailId, 
mainKit));
+mainKit.insertNewUnixSocket(MasterLocation, pathAndQuery, 
websocketHandler);
 #else
-

[Libreoffice-commits] online.git: Branch 'refs/tags/3.4.4-1' - 0 commits -

Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 89827] Updating style options to another style

https://bugs.documentfoundation.org/show_bug.cgi?id=89827

mahfiaz  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #6 from mahfiaz  ---
Using parent style to inherit properties from solves this use case in a better
way (and is already present).

Closing this enhancement request, I think there are better things to work on.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3' - wsd/ClientSession.cpp wsd/DocumentBroker.cpp wsd/DocumentBroker.hpp wsd/LOOLWSD.cpp

 wsd/ClientSession.cpp  |5 -
 wsd/DocumentBroker.cpp |   23 +--
 wsd/DocumentBroker.hpp |   21 +
 wsd/LOOLWSD.cpp|   30 ++
 4 files changed, 52 insertions(+), 27 deletions(-)

New commits:
commit cca660af532d2bc3c94200454efa7872633554ed
Author: Michael Meeks 
AuthorDate: Sat Mar 2 16:41:47 2019 +0100
Commit: Andras Timar 
CommitDate: Sat Mar 30 18:31:53 2019 +0100

tdf#123482 - cleanup convert-to folder more reliably.

Change-Id: I029bb4136984e05485e462c92da80b92b00fdebc

also squashes:

Simpify DocumentBroker constructor.
Change-Id: I0bf29df9316b129d34862c7464bb6636d42a850d

Avoid using un-necessary reference.
Change-Id: Id5a9fed8fb790f2af8facac119e9e0da476b1e47

Change-Id: I40eb5ae5b4721ffd709db6ecc7754dff8106475d
Reviewed-on: https://gerrit.libreoffice.org/68623
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index 2eee1f797..cc325b44b 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -850,11 +850,6 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 
 // Now terminate.
 docBroker->stop("Finished saveas handler.");
-
-// Remove file and directory
-Poco::Path path = docBroker->getDocKey();
-Poco::File(path).remove();
-Poco::File(path.makeParent()).remove();
 }
 
 return true;
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 5b976caf3..465549c27 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -37,6 +37,7 @@
 #include "common/Message.hpp"
 #include "common/Protocol.hpp"
 #include "common/Unit.hpp"
+#include "common/FileUtil.hpp"
 
 #include 
 #include 
@@ -145,13 +146,11 @@ std::atomic DocumentBroker::DocBrokerId(1);
 
 DocumentBroker::DocumentBroker(const std::string& uri,
const Poco::URI& uriPublic,
-   const std::string& docKey,
-   const std::string& childRoot) :
+   const std::string& docKey) :
 _uriOrig(uri),
 _uriPublic(uriPublic),
 _docKey(docKey),
 _docId(Util::encodeId(DocBrokerId++, 3)),
-_childRoot(childRoot),
 _cacheRoot(getCachePath(uriPublic.toString())),
 _documentChangedInStorage(false),
 _lastSaveTime(std::chrono::steady_clock::now()),
@@ -171,10 +170,10 @@ DocumentBroker::DocumentBroker(const std::string& uri,
 _debugRenderedTileCount(0)
 {
 assert(!_docKey.empty());
-assert(!_childRoot.empty());
+assert(!LOOLWSD::ChildRoot.empty());
 
 LOG_INF("DocumentBroker [" << LOOLWSD::anonymizeUrl(_uriPublic.toString()) 
<<
-"] created with docKey [" << _docKey << "] and root [" << 
_childRoot << "]");
+"] created with docKey [" << _docKey << "]");
 }
 
 void DocumentBroker::startThread()
@@ -1027,7 +1026,7 @@ bool DocumentBroker::sendUnoSave(const std::string& 
sessionId, bool dontTerminat
 std::string DocumentBroker::getJailRoot() const
 {
 assert(!_jailId.empty());
-return Poco::Path(_childRoot, _jailId).toString();
+return Poco::Path(LOOLWSD::ChildRoot, _jailId).toString();
 }
 
 size_t DocumentBroker::addSession(const std::shared_ptr& 
session)
@@ -1826,6 +1825,18 @@ void DocumentBroker::getIOStats(uint64_t , uint64_t 
)
 }
 }
 
+ConvertToBroker::~ConvertToBroker()
+{
+if (!_uriOrig.empty())
+{
+// Remove source file and directory
+Poco::Path path = _uriOrig;
+Poco::File(path).remove();
+Poco::File(path.makeParent()).remove();
+FileUtil::removeFile(_uriOrig);
+}
+}
+
 void DocumentBroker::dumpState(std::ostream& os)
 {
 std::unique_lock lock(_mutex);
diff --git a/wsd/DocumentBroker.hpp b/wsd/DocumentBroker.hpp
index d0fc1a747..8a284f965 100644
--- a/wsd/DocumentBroker.hpp
+++ b/wsd/DocumentBroker.hpp
@@ -213,10 +213,9 @@ public:
 /// Construct DocumentBroker with URI, docKey, and root path.
 DocumentBroker(const std::string& uri,
const Poco::URI& uriPublic,
-   const std::string& docKey,
-   const std::string& childRoot);
+   const std::string& docKey);
 
-~DocumentBroker();
+virtual ~DocumentBroker();
 
 /// Start processing events
 void startThread();
@@ -393,8 +392,9 @@ private:
 /// Sum the I/O stats from all connected sessions
 void getIOStats(uint64_t , uint64_t );
 
-private:
+protected:
 const std::string _uriOrig;
+private:
 const Poco::URI _uriPublic;
 /// URL-based key. May be repeated during the lifetime of WSD.
 const std::string _docKey;
@@ -463,6 +463,19 @@ private:
 static std::atomic DocBrokerId;
 };
 
+class ConvertToBroker : public DocumentBroker
+{
+public:
+/// Construct

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4' - wsd/LOOLWSD.cpp

 wsd/LOOLWSD.cpp |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 8f77cd1abbe7d7cd44c544e05eaed18cd8da200d
Author: Michael Meeks 
AuthorDate: Sat Mar 30 11:38:17 2019 +
Commit: Andras Timar 
CommitDate: Sat Mar 30 18:31:05 2019 +0100

Only erase buffer if socket is not shutting down.

Change-Id: I23886db8d2fdb6297862947e031e14d7a485ecd7
Reviewed-on: https://gerrit.libreoffice.org/69955
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 9227f6f3f..a0a4eed48 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -2136,6 +2136,7 @@ private:
 << "\r\n";
 socket->send(oss.str());
 socket->shutdown();
+return;
 }
 }
 }
@@ -2154,6 +2155,7 @@ private:
 // NOTE: Check _wsState to choose between HTTP response or 
WebSocket (app-level) error.
 LOG_INF("#" << socket->getFD() << " Exception while processing 
incoming request: [" <<
 LOOLProtocol::getAbbreviatedMessage(socket->getInBuffer()) 
<< "]: " << exc.what());
+return;
 }
 
 // if we succeeded - remove the request from our input buffer
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'libreoffice-6-2' - wsd/LOOLWSD.cpp

 wsd/LOOLWSD.cpp |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 97a6b8e130ab5a461a964be6bcca4bef627f2b7f
Author: Michael Meeks 
AuthorDate: Sat Mar 30 11:38:17 2019 +
Commit: Andras Timar 
CommitDate: Sat Mar 30 18:31:18 2019 +0100

Only erase buffer if socket is not shutting down.

Change-Id: I23886db8d2fdb6297862947e031e14d7a485ecd7
Reviewed-on: https://gerrit.libreoffice.org/69954
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 34d3ff16a..a4a5533fe 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -2118,6 +2118,7 @@ private:
 << "\r\n";
 socket->send(oss.str());
 socket->shutdown();
+return;
 }
 }
 }
@@ -2136,6 +2137,7 @@ private:
 // NOTE: Check _wsState to choose between HTTP response or 
WebSocket (app-level) error.
 LOG_INF("#" << socket->getFD() << " Exception while processing 
incoming request: [" <<
 LOOLProtocol::getAbbreviatedMessage(socket->getInBuffer()) 
<< "]: " << exc.what());
+return;
 }
 
 // if we succeeded - remove the request from our input buffer
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3' - wsd/LOOLWSD.cpp