[Libreoffice-bugs] [Bug 115488] FILESAVE: FILEOPEN: Abnormally long open & save times, thought to arise from conditional formatting in spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=115488 --- Comment #10 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96706] Writer text boxes do not apply default style
https://bugs.documentfoundation.org/show_bug.cgi?id=96706 --- Comment #7 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116832] Process remains in background after closing LibreOffice if an extension prompts an error trying to be installed
https://bugs.documentfoundation.org/show_bug.cgi?id=116832 --- Comment #2 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116047] LO 6.0.1.1 (x64) calc windows, autofilter freezes
https://bugs.documentfoundation.org/show_bug.cgi?id=116047 --- Comment #6 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
CppCheck Report Update
A new cppcheck report is available at : http://dev-builds.libreoffice.org/cppcheck_reports/master/ Note: The script generating this report was run at : 2019-07-04 02:39:35 with user buildslave at host vm140 as /home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s /home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w /home/buildslave/tmp/www It can be found and improved here: https://gerrit.libreoffice.org/plugins/gitiles/dev-tools/+/master/cppcheck/cppcheck-report.sh ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Tagging text as being in arbitrary complex-script languages
https://wiki.documentfoundation.org/ReleaseNotes/5.4 says,
"The language list for text attribution now also displays BCP47
language tags provided by dictionaries if a language is not known in
the predefined set of languages. (Eike Rathke (Red Hat, Inc.))
Such additional language tags are placed in curly brackets /
braces, for example {en-DK}, and are displayed at the top of the
list after the [None] entry."
Is some additional information required in the .oxt file for the
dictionary if the script is not "Western text"? For example, I have
installed a dictionary (of my own devising) for language nod-TH, but it
only shows up (in LibreOffice 6.2.2.2) in the language list for
Western text. (The language is only written in CTL scripts - Thai
and Lanna.)
The work-around of manually editing the XML of a writer document to
insert the language and country still works.
Richard.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 70838] FILESAVE: doc: wrong size and position exporting rotated shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=70838 Commit Notification changed: What|Removed |Added Whiteboard|target:4.2.0 target:4.3.0 |target:4.2.0 target:4.3.0 |target:6.2.0 target:6.1.0.1 |target:6.2.0 target:6.1.0.1 ||target:6.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118375] FILEOPEN: wrong position of rotated shapes in DOC
https://bugs.documentfoundation.org/show_bug.cgi?id=118375 Commit Notification changed: What|Removed |Added Whiteboard||target:6.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118375] FILEOPEN: wrong position of rotated shapes in DOC
https://bugs.documentfoundation.org/show_bug.cgi?id=118375 --- Comment #7 from Commit Notification --- Regina Henschel committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/421e6fc3cd2e6fe37afbef341e2d0ad7b8edde37%5E%21 tdf#118375, tdf#70838 correct position of rotated shape in doc It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70838] FILESAVE: doc: wrong size and position exporting rotated shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=70838 --- Comment #37 from Commit Notification --- Regina Henschel committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/421e6fc3cd2e6fe37afbef341e2d0ad7b8edde37%5E%21 tdf#118375, tdf#70838 correct position of rotated shape in doc It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/ww8export/data/tdf118375_240degClockwise.doc |binary
sw/qa/extras/ww8export/ww8export3.cxx | 23 ++
sw/source/filter/ww8/wrtw8esh.cxx | 30 ++
sw/source/filter/ww8/ww8graf.cxx | 11 +
4 files changed, 64 insertions(+)
New commits:
commit 421e6fc3cd2e6fe37afbef341e2d0ad7b8edde37
Author: Regina Henschel
AuthorDate: Tue Apr 2 21:36:57 2019 +0200
Commit: Thorsten Behrens
CommitDate: Sun Apr 7 01:14:31 2019 +0200
tdf#118375, tdf#70838 correct position of rotated shape in doc
Word relates the position to the unrotated shape in legacy doc
format. Writer uses the rotated shape. The patch corrects the
difference on import and export.
Change-Id: I25537123656e62d6ffae5118ee8d621a4b5c5be0
Reviewed-on: https://gerrit.libreoffice.org/70152
Tested-by: Jenkins
Reviewed-by: Regina Henschel
diff --git a/sw/qa/extras/ww8export/data/tdf118375_240degClockwise.doc
b/sw/qa/extras/ww8export/data/tdf118375_240degClockwise.doc
new file mode 100644
index ..99d15e20cea5
Binary files /dev/null and
b/sw/qa/extras/ww8export/data/tdf118375_240degClockwise.doc differ
diff --git a/sw/qa/extras/ww8export/ww8export3.cxx
b/sw/qa/extras/ww8export/ww8export3.cxx
index ba99e05deb36..e62bcaf5a182 100644
--- a/sw/qa/extras/ww8export/ww8export3.cxx
+++ b/sw/qa/extras/ww8export/ww8export3.cxx
@@ -223,6 +223,29 @@ DECLARE_WW8EXPORT_TEST(testBtlrCell, "btlr-cell.doc")
CPPUNIT_ASSERT_EQUAL(text::WritingMode2::TB_RL,
getProperty(xC1, "WritingMode"));
}
+DECLARE_WW8EXPORT_TEST(testTdf118375export, "tdf118375_240degClockwise.doc")
+{
+// The input document has one custom shape, which is rotated 240deg. Check
+// that it has the same position as in Word.
+uno::Reference xDrawPagesSupplier(mxComponent,
+
uno::UNO_QUERY_THROW);
+CPPUNIT_ASSERT_MESSAGE("Could not get XDrawPagesSupplier",
xDrawPagesSupplier.is());
+uno::Reference
xDrawPages(xDrawPagesSupplier->getDrawPages());
+uno::Reference xDrawPage(xDrawPages->getByIndex(0),
uno::UNO_QUERY_THROW);
+CPPUNIT_ASSERT_MESSAGE("Could not get xDrawPage", xDrawPage.is());
+uno::Reference xShape(xDrawPage->getByIndex(0),
uno::UNO_QUERY);
+CPPUNIT_ASSERT_MESSAGE("Could not get xShape", xShape.is());
+uno::Reference xShapeProps(xShape, uno::UNO_QUERY);
+CPPUNIT_ASSERT_MESSAGE("Could not get the shape properties",
xShapeProps.is());
+sal_Int32 nPosX, nPosY;
+xShapeProps->getPropertyValue("HoriOrientPosition") >>= nPosX;
+xShapeProps->getPropertyValue("VertOrientPosition") >>= nPosY;
+// Allow some tolerance because rounding errors through integer arithmethic
+// in rotation.
+CPPUNIT_ASSERT_DOUBLES_EQUAL(5200.0, static_cast(nPosX), 1.0);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(1152.0, static_cast(nPosY), 1.0);
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/filter/ww8/wrtw8esh.cxx
b/sw/source/filter/ww8/wrtw8esh.cxx
index c3cb2d50a1e2..f713a9c2de88 100644
--- a/sw/source/filter/ww8/wrtw8esh.cxx
+++ b/sw/source/filter/ww8/wrtw8esh.cxx
@@ -659,6 +659,7 @@ void PlcDrawObj::WritePlc( WW8Export& rWrt ) const
WinwordAnchoring::ConvertPosition( rHOr, rVOr, rFormat );
Point aObjPos;
+bool bHasHeightWidthSwapped(false);
if (RES_FLYFRMFMT == rFormat.Which())
{
SwRect aLayRect(rFormat.FindLayoutRect(false, ));
@@ -694,6 +695,7 @@ void PlcDrawObj::WritePlc( WW8Export& rWrt ) const
const long nHeight = aRect.getHeight();
aRect.setWidth( nHeight );
aRect.setHeight( nWidth );
+bHasHeightWidthSwapped = true;
}
}
}
@@ -755,6 +757,34 @@ void PlcDrawObj::WritePlc( WW8Export& rWrt ) const
//Nasty swap for bidi if necessary
rWrt.MiserableRTLFrameFormatHack(nLeft, nRight, rFrameFormat);
+// tdf#70838. Word relates the position to the unrotated rectangle,
+// Writer to the rotated one. Because the rotation is around
center,
+// the difference counts half.
+if(pObj && pObj->GetRotateAngle())
+{
+SwTwips nXOff;
+SwTwips nYOff;
+SwTwips nSnapWidth = pObj->GetSnapRect().getWidth();
+SwTwips nSnapHeight = pObj->GetSnapRect().getHeight();
+SwTwips nLogicWidth = pObj->GetLogicRect().getWidth();
+SwTwips nLogicHeight = pObj->GetLogicRect().getHeight();
+// +1 for to compensate integer arithmetic rounding errors
+if(bHasHeightWidthSwapped)
+{
+nXOff = (nSnapWidth - nLogicHeight + 1)
[Libreoffice-bugs] [Bug 122751] Tabbed: Missing Some Required Functions from Previous Pop Up Toolbar in Tabbed interface
https://bugs.documentfoundation.org/show_bug.cgi?id=122751 andreas_k changed: What|Removed |Added Depends on|124583 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124583 [Bug 124583] notebookbar draw add shape related stuff -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102062] [META] Notebookbar: bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102062 andreas_k changed: What|Removed |Added Depends on||124583 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124583 [Bug 124583] notebookbar draw add shape related stuff -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124583] notebookbar draw add shape related stuff
https://bugs.documentfoundation.org/show_bug.cgi?id=124583 andreas_k changed: What|Removed |Added CC||kain...@gmail.com Blocks||122751 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122751 [Bug 122751] Tabbed: Missing Some Required Functions from Previous Pop Up Toolbar in Tabbed interface -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122751] Tabbed: Missing Some Required Functions from Previous Pop Up Toolbar in Tabbed interface
https://bugs.documentfoundation.org/show_bug.cgi?id=122751 andreas_k changed: What|Removed |Added Depends on||124583 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124583 [Bug 124583] notebookbar draw add shape related stuff -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124583] notebookbar draw add shape related stuff
https://bugs.documentfoundation.org/show_bug.cgi?id=124583 andreas_k changed: What|Removed |Added Blocks|122751 |102062 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102062 [Bug 102062] [META] Notebookbar: bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=122751 [Bug 122751] Tabbed: Missing Some Required Functions from Previous Pop Up Toolbar in Tabbed interface -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124583] New: notebookbar draw add shape related stuff
https://bugs.documentfoundation.org/show_bug.cgi?id=124583 Bug ID: 124583 Summary: notebookbar draw add shape related stuff Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kain...@gmail.com Shape related stuff need to be added to the NB UI like mergeshapes, ... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122751] Tabbed: Missing Some Required Functions from Previous Pop Up Toolbar in Tabbed interface
https://bugs.documentfoundation.org/show_bug.cgi?id=122751 andreas_k changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101396] VIEWING Font color changes when auto spellcheck is enabled and text is underlined due to spelling error (steps in comment 7)
https://bugs.documentfoundation.org/show_bug.cgi?id=101396 --- Comment #16 from Björn --- Still present in the current version: Version: 6.2.2.2 Build-ID: 2b840030fec2aae0fd2658d8d4f9548af4e3518d CPU-Threads: 4; BS: Mac OS X 10.14.4; UI-Render: Standard; VCL: osx; Gebietsschema: de-DE (de_DE.UTF-8); UI-Sprache: de-DE Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102062] [META] Notebookbar: bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102062 Bug 102062 depends on bug 122751, which changed state. Bug 122751 Summary: Tabbed: Missing Some Required Functions from Previous Pop Up Toolbar in Tabbed interface https://bugs.documentfoundation.org/show_bug.cgi?id=122751 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122751] Tabbed: Missing Some Required Functions from Previous Pop Up Toolbar in Tabbed interface
https://bugs.documentfoundation.org/show_bug.cgi?id=122751 --- Comment #6 from andreas_k --- thanks for reporting this bug. I add fontwork to draw tab/context menu and the bullet stuff to writer home dropdown menu. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76225] paragraph's numbering style inherited from template isn't applied
https://bugs.documentfoundation.org/show_bug.cgi?id=76225 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #13 from Roman Kuznetsov <79045_79...@mail.ru> --- >problem 1) paragraph style 'Outline & numbering' tab has 'Outline numbering' >(instead of specific name) in 'Numbering style' field, and that field is >grayed out, too. It isn't a problem. Paragraph with Outline level that not equal "Text body" should to have own "Chapter Numbering" style -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107642] [META] Paragraph dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107642 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||124582 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124582 [Bug 124582] Change drop-down item "Outline Numbering" to "Chapter Numbering" in dialog Paragraph Style -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124582] Change drop-down item "Outline Numbering" to "Chapter Numbering" in dialog Paragraph Style
https://bugs.documentfoundation.org/show_bug.cgi?id=124582 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||107642 Component|Writer |UI CC||tietze.he...@gmail.com Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107642 [Bug 107642] [META] Paragraph dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124582] New: Change drop-down item "Outline Numbering" to "Chapter Numbering" in dialog Paragraph Style
https://bugs.documentfoundation.org/show_bug.cgi?id=124582 Bug ID: 124582 Summary: Change drop-down item "Outline Numbering" to "Chapter Numbering" in dialog Paragraph Style Product: LibreOffice Version: 6.3.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: trivial Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: 79045_79...@mail.ru Description: Change drop-down item "Outline Numbering" to "Chapter Numbering" in dialog Paragraph Style on tab Outline & Numbering Because we don't have Outline Numbering dialog and menu item. It's "Chapter Numbering" now Steps to Reproduce: 1. Open Writer 2. Open Style section in Sidebar 3. Right click on "Heading 1" style 4. Select "Modify" item in context menu 5. In "Paragraph Style" dialog go to tab "Outline & Numbering" 6. Look at non active "Numbering style" drop-down list with "Outline Numbering" on it 7. If you move mouse point on drop-down you'll see tooltip with a reason for disabling of drop-down list like "This option is disabled when >>>chapter numbering<<< is assigned to a paragraph style". Actual Results: We have wrong legend on non active "Numbering style" drop-down list Expected Results: We have right legend on non active "Numbering style" drop-down list Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: framework/source
framework/source/layoutmanager/helpers.cxx | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
New commits:
commit 63497d3a60dfb045cafd6db9ce89c4bff0dc8507
Author: Matteo Casalin
AuthorDate: Wed Feb 27 08:08:53 2019 +0100
Commit: Matteo Casalin
CommitDate: Sat Apr 6 23:43:41 2019 +0200
Simplify: avoid OUString copy() and get just needed tokens
Change-Id: I708f222e408223cfaeaac56f87d68375f1d0503f
Reviewed-on: https://gerrit.libreoffice.org/69237
Tested-by: Jenkins
Reviewed-by: Matteo Casalin
diff --git a/framework/source/layoutmanager/helpers.cxx
b/framework/source/layoutmanager/helpers.cxx
index a5e4762f2e8b..7659be20cf04 100644
--- a/framework/source/layoutmanager/helpers.cxx
+++ b/framework/source/layoutmanager/helpers.cxx
@@ -197,11 +197,8 @@ OUString getElementTypeFromResourceURL( const OUString&
aResourceURL )
OUString aUIResourceURL( UIRESOURCE_URL );
if ( aResourceURL.startsWith( aUIResourceURL ) )
{
-sal_Int32 nIndex = 0;
-OUString aPathPart = aResourceURL.copy( aUIResourceURL.getLength() );
-aPathPart.getToken( 0, '/', nIndex );
-
-return aPathPart.getToken( 0, '/', nIndex );
+sal_Int32 nIndex{ aUIResourceURL.getLength() };
+return aResourceURL.getToken( 1, '/', nIndex );
}
return OUString();
@@ -212,12 +209,9 @@ void parseResourceURL( const OUString& aResourceURL,
OUString& aElementType, OUS
OUString aUIResourceURL( UIRESOURCE_URL );
if ( aResourceURL.startsWith( aUIResourceURL ) )
{
-sal_Int32 nIndex = 0;
-OUString aPathPart = aResourceURL.copy( aUIResourceURL.getLength() );
-aPathPart.getToken( 0, '/', nIndex );
-
-aElementType = aPathPart.getToken( 0, '/', nIndex );
-aElementName = aPathPart.getToken( 0, '/', nIndex );
+sal_Int32 nIndex{ aUIResourceURL.getLength() };
+aElementType = aResourceURL.getToken( 1, '/', nIndex );
+aElementName = aResourceURL.getToken( 0, '/', nIndex );
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: forms/source
forms/source/xforms/xpathlib/xpathlib.cxx | 24
1 file changed, 12 insertions(+), 12 deletions(-)
New commits:
commit 83f1068ff62f644bc38e54211c48c87362276012
Author: Matteo Casalin
AuthorDate: Mon Mar 4 16:29:53 2019 +0100
Commit: Matteo Casalin
CommitDate: Sat Apr 6 23:42:36 2019 +0200
Use char version of OString/OStringBuffer methods
Change-Id: I0222e6675f63797f870746fd34a29702ad190311
Reviewed-on: https://gerrit.libreoffice.org/69240
Tested-by: Jenkins
Reviewed-by: Matteo Casalin
diff --git a/forms/source/xforms/xpathlib/xpathlib.cxx
b/forms/source/xforms/xpathlib/xpathlib.cxx
index ac73ec7990df..6fd72e923bf0 100644
--- a/forms/source/xforms/xpathlib/xpathlib.cxx
+++ b/forms/source/xforms/xpathlib/xpathlib.cxx
@@ -234,22 +234,22 @@ static OString makeDateTimeString (const DateTime&
aDateTime)
{
OStringBuffer aDateTimeString;
aDateTimeString.append(static_cast(aDateTime.GetYear()));
-aDateTimeString.append("-");
-if (aDateTime.GetMonth()<10) aDateTimeString.append("0");
+aDateTimeString.append('-');
+if (aDateTime.GetMonth()<10) aDateTimeString.append('0');
aDateTimeString.append(static_cast(aDateTime.GetMonth()));
-aDateTimeString.append("-");
-if (aDateTime.GetDay()<10) aDateTimeString.append("0");
+aDateTimeString.append('-');
+if (aDateTime.GetDay()<10) aDateTimeString.append('0');
aDateTimeString.append(static_cast(aDateTime.GetDay()));
-aDateTimeString.append("T");
-if (aDateTime.GetHour()<10) aDateTimeString.append("0");
+aDateTimeString.append('T');
+if (aDateTime.GetHour()<10) aDateTimeString.append('0');
aDateTimeString.append(static_cast(aDateTime.GetHour()));
-aDateTimeString.append(":");
-if (aDateTime.GetMin()<10) aDateTimeString.append("0");
+aDateTimeString.append(':');
+if (aDateTime.GetMin()<10) aDateTimeString.append('0');
aDateTimeString.append(static_cast(aDateTime.GetMin()));
-aDateTimeString.append(":");
-if (aDateTime.GetSec()<10) aDateTimeString.append("0");
+aDateTimeString.append(':');
+if (aDateTime.GetSec()<10) aDateTimeString.append('0');
aDateTimeString.append(static_cast(aDateTime.GetSec()));
-aDateTimeString.append("Z");
+aDateTimeString.append('Z');
return aDateTimeString.makeStringAndClear();
}
@@ -305,7 +305,7 @@ static bool parseDateTime(const OUString& aString,
DateTime& aDateTime)
Date tmpDate(static_cast(nDay),
static_cast(nMonth), static_cast(nYear));
tools::Time tmpTime(nHour, nMinute, nSecond);
DateTime tmpDateTime(tmpDate, tmpTime);
-if (aString.indexOf("Z") < 0)
+if (aString.lastIndexOf('Z') < 0)
tmpDateTime.ConvertToUTC();
aDateTime = tmpDateTime;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: forms/source
forms/source/component/ListBox.cxx | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
New commits:
commit cca2e42926a14ec27c663cd0f495dccb7607d6f9
Author: Matteo Casalin
AuthorDate: Mon Mar 4 16:20:50 2019 +0100
Commit: Matteo Casalin
CommitDate: Sat Apr 6 23:41:12 2019 +0200
Use getTokenCount and indexed getToken
Change-Id: Id57a1771c897c69b05d02a359f22e5fb2b1f5a31
Reviewed-on: https://gerrit.libreoffice.org/69239
Tested-by: Jenkins
Reviewed-by: Matteo Casalin
diff --git a/forms/source/component/ListBox.cxx
b/forms/source/component/ListBox.cxx
index d6857dcfdcf8..fcf16abe66b4 100644
--- a/forms/source/component/ListBox.cxx
+++ b/forms/source/component/ListBox.cxx
@@ -42,6 +42,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -637,19 +638,12 @@ namespace frm
OUString sListSource;
_rxInStream >> sListSource;
-sal_Int32 nTokens = 1;
-const sal_Unicode* pStr = sListSource.getStr();
-while ( *pStr )
-{
-if ( *pStr == ';' )
-nTokens++;
-pStr++;
-}
+const sal_Int32 nTokens{
comphelper::string::getTokenCount(sListSource, ';') };
aListSourceSeq.realloc( nTokens );
+sal_Int32 nIdx{ 0 };
for (sal_Int32 i=0; ihttps://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: filter/source
filter/source/msfilter/msvbahelper.cxx |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
New commits:
commit 736a481af5c6b7e7d4a652048be14ad0ebbd45e4
Author: Matteo Casalin
AuthorDate: Wed Mar 13 23:45:42 2019 +0100
Commit: Matteo Casalin
CommitDate: Sat Apr 6 23:41:49 2019 +0200
Avoid using index for single getToken() call
Change-Id: I76eaf140b153199b62606ac3336d712a64205dcc
Reviewed-on: https://gerrit.libreoffice.org/69246
Tested-by: Jenkins
Reviewed-by: Matteo Casalin
diff --git a/filter/source/msfilter/msvbahelper.cxx
b/filter/source/msfilter/msvbahelper.cxx
index fa258ea7f93c..3a6e0a378706 100644
--- a/filter/source/msfilter/msvbahelper.cxx
+++ b/filter/source/msfilter/msvbahelper.cxx
@@ -115,9 +115,7 @@ static SfxObjectShell* findShellForUrl( const OUString&
sMacroURLOrPath )
uno::Reference< frame::XFrame > xFrame(
xModel->getCurrentController()->getFrame(), uno::UNO_QUERY_THROW );
uno::Reference< beans::XPropertySet > xProps( xFrame,
uno::UNO_QUERY_THROW );
xProps->getPropertyValue("Title") >>= aName;
-sal_Int32 pos = 0;
-aName = aName.getToken(0,'-',pos);
-aName = aName.trim();
+aName = aName.getToken(0, '-').trim();
if( sMacroURLOrPath.lastIndexOf( aName ) >= 0 )
{
pFoundShell = pShell;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93844] SIDEBAR: Style previews in Styles and Formatting tab in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=93844 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> --- *** Bug 107540 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103427] [META] Styles and Formatting sidebar deck and floating window
https://bugs.documentfoundation.org/show_bug.cgi?id=103427 Bug 103427 depends on bug 107540, which changed state. Bug 107540 Summary: UI: Sidebar doesn't show cell styles formatted with 'Show preview' checked. https://bugs.documentfoundation.org/show_bug.cgi?id=107540 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107540] UI: Sidebar doesn't show cell styles formatted with 'Show preview' checked.
https://bugs.documentfoundation.org/show_bug.cgi?id=107540 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC||79045_79...@mail.ru --- Comment #7 from Roman Kuznetsov <79045_79...@mail.ru> --- *** This bug has been marked as a duplicate of bug 93844 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107328] [META] Style preview bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107328 Bug 107328 depends on bug 107540, which changed state. Bug 107540 Summary: UI: Sidebar doesn't show cell styles formatted with 'Show preview' checked. https://bugs.documentfoundation.org/show_bug.cgi?id=107540 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107326] [META] Writer style bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107326 Bug 107326 depends on bug 115462, which changed state. Bug 115462 Summary: Draw styles should be accessible in Calc and Writer https://bugs.documentfoundation.org/show_bug.cgi?id=115462 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89369] Add support for drawing styles (shapes and textboxes) to Writer and Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=89369 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||tietze.he...@gmail.com --- Comment #15 from Roman Kuznetsov <79045_79...@mail.ru> --- *** Bug 115462 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115462] Draw styles should be accessible in Calc and Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=115462 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> --- *** This bug has been marked as a duplicate of bug 89369 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: download.lst
download.lst |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 86015855a98795d00a28f1bb65c41df947563d66 Author: Eike Rathke AuthorDate: Sat Apr 6 22:18:41 2019 +0200 Commit: Eike Rathke CommitDate: Sat Apr 6 23:29:05 2019 +0200 Upgrade to language-subtag-registry-2019-04-03 Change-Id: I4713b15061e831e1dfeccf8d59e46c0aa2ac4a18 Reviewed-on: https://gerrit.libreoffice.org/70351 Reviewed-by: Eike Rathke Tested-by: Jenkins diff --git a/download.lst b/download.lst index 4bcc0dda2bf7..82a2413da94d 100644 --- a/download.lst +++ b/download.lst @@ -132,8 +132,8 @@ export JFREEREPORT_SAC_SHA256SUM := 085f2112c51fa8c1783fac12fbd45265059641512134 export JFREEREPORT_SAC_TARBALL := 39bb3fcea1514f1369fcfc87542390fd-sacjava-1.3.zip export LIBJPEG_TURBO_SHA256SUM := b24890e2bb46e12e72a79f7e965f409f4e16466d00e1dd15d93d73ee6b592523 export LIBJPEG_TURBO_TARBALL := libjpeg-turbo-1.5.3.tar.gz -export LANGTAGREG_SHA256SUM := 14c21f4533ca74e3af9e09184d6756a750d0cd46099015ba8c595e48499aa878 -export LANGTAGREG_TARBALL := language-subtag-registry-2018-04-23.tar.bz2 +export LANGTAGREG_SHA256SUM := a1d7fb901764bb8f251d4f686cdf565764f9987d0fb5d9315d54a7366a84822d +export LANGTAGREG_TARBALL := language-subtag-registry-2019-04-03.tar.bz2 export LANGUAGETOOL_SHA256SUM := 48c87e41636783bba438b65fd895821e369ed139e1465fac654323ad93c5a82d export LANGUAGETOOL_TARBALL := b63e6340a02ff1cacfeadb2c42286161-JLanguageTool-1.7.0.tar.bz2 export LCMS2_SHA256SUM := 48c6fdf98396fa245ed86e622028caf49b96fa22f3e5734f853f806fbc8e7d20 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 106976] Can't paste english text as a filename when russian keyboard is on
https://bugs.documentfoundation.org/show_bug.cgi?id=106976 --- Comment #9 from Valentin <1vale...@gmail.com> --- (In reply to QA Administrators from comment #7) > ** Please read this message in its entirety before responding ** > > To make sure we're focusing on the bugs that affect our users today, > LibreOffice QA is asking bug reporters and confirmers to retest open, > confirmed bugs which have not been touched for over a year. > > There have been thousands of bug fixes and commits since anyone checked on > this bug report. During that time, it's possible that the bug has been > fixed, or the details of the problem have changed. We'd really appreciate > your help in getting confirmation that the bug is still present. > > If you have time, please do the following: > > Test to see if the bug is still present with the latest version of > LibreOffice from https://www.libreoffice.org/download/ > > If the bug is present, please leave a comment that includes the information > from Help - About LibreOffice. > > If the bug is NOT present, please set the bug's Status field to > RESOLVED-WORKSFORME and leave a comment that includes the information from > Help - About LibreOffice. > > Please DO NOT > > Update the version field > Reply via email (please reply directly on the bug tracker) > Set the bug's Status field to RESOLVED - FIXED (this status has a particular > meaning that is not > appropriate in this case) > > > If you want to do more to help you can test to see if your issue is a > REGRESSION. To do so: > 1. Download and install oldest version of LibreOffice (usually 3.3 unless > your bug pertains to a feature added after 3.3) from > http://downloadarchive.documentfoundation.org/libreoffice/old/ > > 2. Test your bug > 3. Leave a comment with your results. > 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; > 4b. If the bug was not present in 3.3 - add 'regression' to keyword > > > Feel free to come ask questions or to say hello in our QA chat: > https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa > > Thank you for helping us make LibreOffice even better for everyone! > > Warm Regards, > QA Team > > MassPing-UntouchedBug The problem is still there. Ver: 6.2.2.2 on Mac. ID: 2b840030fec2aae0fd2658d8d4f9548af4e3518d -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106976] Can't paste english text as a filename when russian keyboard is on
https://bugs.documentfoundation.org/show_bug.cgi?id=106976 --- Comment #8 from Valentin <1vale...@gmail.com> --- The problem is still there. Ver: 6.2.2.2 on Mac. ID: 2b840030fec2aae0fd2658d8d4f9548af4e3518d -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124559] LibreOffice 6.0? keeps taking forever to load or gives me a no response
https://bugs.documentfoundation.org/show_bug.cgi?id=124559 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #2 from m.a.riosv --- Reinstall doesn't modify the user profile. Please test through Menu/Help/Restart in Safe mode -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124572] tabs in calc (for sheets) and draw (for layer) style
https://bugs.documentfoundation.org/show_bug.cgi?id=124572 m.a.riosv changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70838] FILESAVE: doc: wrong size and position exporting rotated shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=70838 --- Comment #36 from Regina Henschel --- proposed patch for correct position on import and export is in https://gerrit.libreoffice.org/#/c/70152/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118375] FILEOPEN: wrong position of rotated shapes in DOC
https://bugs.documentfoundation.org/show_bug.cgi?id=118375 --- Comment #6 from Regina Henschel --- proposed patch for correct position on import and export is in https://gerrit.libreoffice.org/#/c/70152/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Gitiles VCS browser
It is telling that when I asked what you prefer, you answered that the extraneous information “doesn't hurt “. Your tolerance to noise may be higher than many, but it’s a well-established fact the less clutter in the UI, the faster it is for humans to use. Gitiles is fails here, takes longer to load, requires additional clicks, and is missing search tools and branch tags. -Luke ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 104403] Support multi-colored fonts using COLR/CPAL tables
https://bugs.documentfoundation.org/show_bug.cgi?id=104403 --- Comment #11 from Khaled Hosny (inactive) --- (In reply to Aleksandr Andreev from comment #10) > What's the status with this? How difficult would it be to support this now > that it is supported by HarfBuzz? For screen rendering they should already supported on Linux if you have FreeType 2.10.x and Cairo 1.16.x, and should be supported on recent enough macOS systems (disdn’t test that, though). On Windows it would require calling the relevant DirectWrite APIs (https://docs.microsoft.com/en-us/windows/desktop/directwrite/color-fonts#using-color-fonts-with-directwrite-and-direct2d) For PDF, we would need to call HarfBuzz to decompose the color glyph layers before writing them to the PDF, should be a couple of days work or so if someone is interested. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114801] EDITOR DOCX Cannot use the highlight 'bucket' function with docx file
https://bugs.documentfoundation.org/show_bug.cgi?id=114801 Commit Notification changed: What|Removed |Added Whiteboard||target:6.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114801] EDITOR DOCX Cannot use the highlight 'bucket' function with docx file
https://bugs.documentfoundation.org/show_bug.cgi?id=114801 --- Comment #6 from Commit Notification --- Tamás Zolnai committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/84d4125b28c384f9ac6285737a5bb9093978798e%5E%21 tdf#114801: Cannot use the highlight 'bucket' function with docx file It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/docvw/edtwin.cxx |2 +-
sw/source/uibase/inc/uitool.hxx | 12
sw/source/uibase/shells/textsh1.cxx | 26 +++---
sw/source/uibase/utlui/uitool.cxx | 34 ++
4 files changed, 50 insertions(+), 24 deletions(-)
New commits:
commit 84d4125b28c384f9ac6285737a5bb9093978798e
Author: Tamás Zolnai
AuthorDate: Sat Apr 6 18:16:24 2019 +0200
Commit: Tamás Zolnai
CommitDate: Sat Apr 6 22:01:48 2019 +0200
tdf#114801: Cannot use the highlight 'bucket' function with docx file
Change-Id: I00df0022a20e83d76484d7c6e7b903ecd3c54aa0
Reviewed-on: https://gerrit.libreoffice.org/70347
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai
diff --git a/sw/source/uibase/docvw/edtwin.cxx
b/sw/source/uibase/docvw/edtwin.cxx
index 846ffa63ad32..06dcaa126e8b 100644
--- a/sw/source/uibase/docvw/edtwin.cxx
+++ b/sw/source/uibase/docvw/edtwin.cxx
@@ -4778,7 +4778,7 @@ void SwEditWin::MouseButtonUp(const MouseEvent& rMEvt)
m_pApplyTempl->nUndo =
std::min(m_pApplyTempl->nUndo,
rSh.GetDoc()->GetIDocumentUndoRedo().GetUndoActionCount());
if (nId == RES_CHRATR_BACKGROUND)
-rSh.SetAttrItem( SvxBrushItem(
m_aWaterCanTextBackColor, nId ) );
+ApplyCharBackground(m_aWaterCanTextBackColor, rSh);
else
rSh.SetAttrItem( SvxColorItem( m_aWaterCanTextColor,
nId ) );
rSh.UnSetVisibleCursor();
diff --git a/sw/source/uibase/inc/uitool.hxx b/sw/source/uibase/inc/uitool.hxx
index 66791ac0ffc9..f237c83c0952 100644
--- a/sw/source/uibase/inc/uitool.hxx
+++ b/sw/source/uibase/inc/uitool.hxx
@@ -37,6 +37,7 @@ class SwFrameFormat;
class SwTabCols;
class DateTime;
class SfxViewFrame;
+class SwEditShell;
// switch a metric
SW_DLLPUBLIC void SetMetric(MetricFormatter& rCtrl, FieldUnit eUnit);
@@ -60,6 +61,17 @@ SW_DLLPUBLIC void ConvertAttrCharToGen(SfxItemSet& rSet);
**/
SW_DLLPUBLIC void ConvertAttrGenToChar(SfxItemSet& rSet, const SfxItemSet&
rOrigSet);
+
+/**
+* Apply characeter background on the shell. Need to use this to hide the mixed
+* charachter background and character highlighting attribute, which were
+* added for MSO compatibility where there are two kind of character background.
+*
+* @param[in] rBackgroundColorthe color to apply on the shell
+* @param[in,out] rShell the shell on which we apply the new
attirbute
+**/
+SW_DLLPUBLIC void ApplyCharBackground(const Color& rBackgroundColor,
SwWrtShell& rShell);
+
// SfxItemSets <-> PageDesc
void ItemSetToPageDesc( const SfxItemSet& rSet, SwPageDesc& rPageDesc );
void PageDescToItemSet( const SwPageDesc& rPageDesc, SfxItemSet& rSet);
diff --git a/sw/source/uibase/shells/textsh1.cxx
b/sw/source/uibase/shells/textsh1.cxx
index dfdde52dd3e7..630a0476715a 100644
--- a/sw/source/uibase/shells/textsh1.cxx
+++ b/sw/source/uibase/shells/textsh1.cxx
@@ -1206,11 +1206,9 @@ void SwTextShell::Execute(SfxRequest )
{
if (nSlot != SID_ATTR_CHAR_COLOR_EXT)
{
-rWrtSh.StartUndo( SwUndoId::INSATTR );
-
SfxItemSet aCoreSet( rWrtSh.GetView().GetPool(),
svl::Items<
- RES_CHRATR_BACKGROUND,
RES_CHRATR_BACKGROUND,
- RES_CHRATR_GRABBAG,
RES_CHRATR_GRABBAG>{} );
+ RES_CHRATR_BACKGROUND,
RES_CHRATR_BACKGROUND>{} );
+
rWrtSh.GetCurAttr( aCoreSet );
// Remove highlight if already set of the same color
@@ -1218,25 +1216,7 @@ void SwTextShell::Execute(SfxRequest )
if ( aSet == rBrushItem.GetColor() )
aSet = COL_TRANSPARENT;
-rWrtSh.SetAttrItem( SvxBrushItem(aSet,
RES_CHRATR_BACKGROUND) );
-
-// Remove MS specific highlight when background is set
-rWrtSh.SetAttrItem( SvxBrushItem(RES_CHRATR_HIGHLIGHT) );
-
-// Remove shading marker
-const SfxPoolItem *pTmpItem;
-if( SfxItemState::SET == aCoreSet.GetItemState(
RES_CHRATR_GRABBAG, false, ) )
-{
-SfxGrabBagItem aGrabBag(*static_cast(pTmpItem));
-std::map& rMap =
aGrabBag.GetGrabBag();
-auto aIterator = rMap.find("CharShadingMarker");
-if( aIterator != rMap.end() )
-{
-aIterator->second <<= false;
-}
-rWrtSh.SetAttrItem( aGrabBag );
-}
-rWrtSh.EndUndo( SwUndoId::INSATTR );
+ApplyCharBackground(aSet, rWrtSh);
}
else
[Libreoffice-commits] help.git: CustomTarget_html.mk help3xsl/links.txt.xsl help3xsl/online_transform.xsl
CustomTarget_html.mk | 17
help3xsl/links.txt.xsl| 1435 ++
help3xsl/online_transform.xsl |3
3 files changed, 1436 insertions(+), 19 deletions(-)
New commits:
commit 2d21ebb74b31546cf7dd133df9f8c4951d325c80
Author: Olivier Hallot
AuthorDate: Sat Apr 6 20:51:01 2019 +0100
Commit: Olivier Hallot
CommitDate: Sat Apr 6 21:52:57 2019 +0200
Revert "Create XSLT replacement table for missing icons"
This reverts commit 61f44912beec99f6211399ce567274aa369f817d.
Change-Id: Icd69ccd4f487a82426a00169728ec62bbff6d0b6
Reviewed-on: https://gerrit.libreoffice.org/70350
Tested-by: Jenkins
Reviewed-by: Olivier Hallot
diff --git a/CustomTarget_html.mk b/CustomTarget_html.mk
index 84e142c26..45d3f284b 100644
--- a/CustomTarget_html.mk
+++ b/CustomTarget_html.mk
@@ -13,7 +13,6 @@ $(eval $(call
gb_CustomTarget_CustomTarget,helpcontent2/help3xsl))
html_TREE_MODULES := sbasic scalc schart shared simpress smath swriter
html_TEXT_MODULES := $(html_TREE_MODULES) sdatabase sdraw
html_BMARK_MODULES := swriter:WRITER scalc:CALC simpress:IMPRESS sdraw:DRAW
shared/explorer/database:BASE smath:MATH schart:CHART sbasic:BASIC shared:SHARED
-ICON_FILE := $(SRCDIR)/icon-themes/colibre/links.txt
$(eval $(call gb_CustomTarget_register_targets,helpcontent2/help3xsl,\
hid2file.js \
@@ -109,21 +108,6 @@ $(call
gb_CustomTarget_get_workdir,helpcontent2/help3xsl)/%/contents.js :
) > $@ \
)
-$(call gb_CustomTarget_get_workdir,helpcontent2/help3xsl)/links.txt.xsl :
- $(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),ICO,2)
- $(call gb_Helper_abbreviate_dirs,\
- ( \
- echo "" \
- && echo "http://www.w3.org/1999/XSL/Transform\;>" \
- && echo "" \
- && echo "" \
- && echo "" \
- && grep -v "#" < $(ICON_FILE) | $(gb_AWK) 'NF' |
$(gb_AWK) -v q=\' '{printf ""
$$2 "\n"}' \
- && $(gb_AWK) 'BEGIN {printf
"\n"}' \
- && echo
"\n\n" \
- ) > $@ \
- )
-
$(call gb_CustomTarget_get_workdir,helpcontent2/help3xsl)/%/contents.part : \
$(SRCDIR)/helpcontent2/help3xsl/get_tree.xsl \
$(call gb_ExternalExecutable_get_dependencies,xsltproc)
@@ -142,7 +126,6 @@ $(call
gb_CustomTarget_get_workdir,helpcontent2/help3xsl)/%/contents.part : \
define html_gen_html_dep
$(call gb_CustomTarget_get_workdir,helpcontent2/help3xsl)/$(1)/html.text : \
- $(call gb_CustomTarget_get_workdir,helpcontent2/help3xsl)/links.txt.xsl
\
$(foreach module,$(html_TEXT_MODULES), \
$(if $(filter en-US,$(1)), \
$(call gb_AllLangHelp_get_helpfiles_target,$(module)), \
diff --git a/help3xsl/links.txt.xsl b/help3xsl/links.txt.xsl
new file mode 100644
index 0..797cb6e14
--- /dev/null
+++ b/help3xsl/links.txt.xsl
@@ -0,0 +1,1435 @@
+
+http://www.w3.org/1999/XSL/Transform;>
+
+
+
+cmd/sc_open.png
+cmd/sc_runbasic.png
+cmd/sc_mediapause.png
+cmd/sc_basicstop.png
+cmd/sc_mediarepeat.png
+cmd/sc_ok.png
+cmd/sc_mediamute.png
+cmd/lc_open.png
+cmd/lc_runbasic.png
+cmd/lc_mediapause.png
+cmd/lc_basicstop.png
+cmd/lc_mediarepeat.png
+cmd/lc_ok.png
+cmd/lc_mediamute.png
+cmd/sc_insertrowsafter.png
+cmd/sc_insertcolumnsafter.png
+cmd/sc_deleterows.png
+cmd/sc_deletecolumns.png
+cmd/sc_insertcellsright.png
+cmd/sc_insertcellsdown.png
+cmd/sc_insertcolumnsafter.png
+cmd/sc_insertcolumns.png
+cmd/sc_insertrowsbefore.png
+formula/res/refinp1.png
+cmd/lc_datefield.png
+cmd/lc_insertplugin.png
+cmd/lc_inserttable.png
+cmd/lc_inserttable.png
+cmd/sc_datefield.png
+cmd/sc_insertplugin.png
+cmd/sc_inserttable.png
+cmd/sc_inserttable.png
+cmd/lc_editannotation.png
+cmd/sc_editannotation.png
+cmd/lc_newdoc.png
+cmd/lc_togglesheetgrid.png
+cmd/lc_avmediaplayer.png
+cmd/lc_formattedfield.png
+cmd/lc_datefield.png
+cmd/lc_togglesheetgrid.png
+cmd/lc_dbviewaliases.png
+cmd/lc_edit.png
+cmd/lc_addfield.png
+cmd/lc_inserttable.png
+cmd/lc_open.png
+cmd/lc_formattedfield.png
+cmd/lc_checkbox.png
+cmd/lc_combobox.png
+cmd/lc_listbox.png
+cmd/lc_radiobutton.png
+cmd/lc_spinbutton.png
+cmd/lc_dbviewfunctions.png
+cmd/lc_scrollbar.png
+cmd/lc_insertframe.png
+cmd/lc_insertframe.png
+cmd/lc_drawchart.png
+cmd/lc_numberformatstandard.png
+cmd/lc_numberformatstandard.png
+cmd/lc_listbox.png
+cmd/lc_insertframe.png
+cmd/lc_insertmath.png
+cmd/lc_patternfield.png
+cmd/lc_pushbutton.png
+cmd/lc_insertpagebreak.png
+cmd/lc_togglesheetgrid.png
+cmd/lc_timefield.png
+cmd/sc_newdoc.png
+cmd/sc_togglesheetgrid.png
+cmd/sc_avmediaplayer.png
+cmd/sc_formattedfield.png
+cmd/sc_datefield.png
+cmd/sc_dbviewaliases.png
+cmd/sc_text.png
+cmd/sc_addfield.png
+cmd/sc_inserttable.png
+cmd/sc_open.png
+cmd/sc_formattedfield.png
+cmd/sc_checkbox.png
+cmd/sc_combobox.png
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 386c1835b1d1eed4f3b29b874deeb24df87e Author: Olivier Hallot AuthorDate: Sat Apr 6 20:51:01 2019 +0100 Commit: Gerrit Code Review CommitDate: Sat Apr 6 21:52:57 2019 +0200 Update git submodules * Update helpcontent2 from branch 'master' - Revert "Create XSLT replacement table for missing icons" This reverts commit 61f44912beec99f6211399ce567274aa369f817d. Change-Id: Icd69ccd4f487a82426a00169728ec62bbff6d0b6 Reviewed-on: https://gerrit.libreoffice.org/70350 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 12aff9b55df5..2d21ebb74b31 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 12aff9b55df5cfc0282ec9ee7d359fb843291a79 +Subproject commit 2d21ebb74b31546cf7dd133df9f8c4951d325c80 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 124581] New: Tabs deleting
https://bugs.documentfoundation.org/show_bug.cgi?id=124581 Bug ID: 124581 Summary: Tabs deleting Product: LibreOffice Version: 6.1.5.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: escoe.hawk...@gmail.com Description: When using the enter key to start a new paragraph, the tab or tabs that begin the paragraph delete and the paragraph has no tabs. Steps to Reproduce: 1.Tab over once or twice 2.type about one short sentence 3.hit enter to begin next line Actual Results: the line just typed has the tab or tabs removed. example: the world spins on its axis. Expected Results: what should have happened the world spins on its axis. next line. Reproducible: Sometimes User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 6.1.5.2 (x64) Build ID: 90f8dcf33c87b3705e78202e3df5142b201bd805 CPU threads: 4; OS: Windows 10.0; UI render: default; Locale: en-US (en_US); Calc: group threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104403] Support multi-colored fonts using COLR/CPAL tables
https://bugs.documentfoundation.org/show_bug.cgi?id=104403 --- Comment #10 from Aleksandr Andreev --- What's the status with this? How difficult would it be to support this now that it is supported by HarfBuzz? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/postwin.h
include/postwin.h | 11 --- 1 file changed, 11 deletions(-) New commits: commit e9ff7a041841b36e9db9d7cdfdef82ba2b0002b4 Author: Mike Kaganski AuthorDate: Sat Apr 6 18:45:35 2019 +0100 Commit: Mike Kaganski CommitDate: Sat Apr 6 21:21:29 2019 +0200 Remove obsolete checked defines These are always defined when WINVER >= 0x0400; and we have it set to 0x0601 in solenv/gbuild/platform/windows.mk. Change-Id: Ia1f6fa5589562fa710b4da3d288182d3f8a15e6b Reviewed-on: https://gerrit.libreoffice.org/70348 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/include/postwin.h b/include/postwin.h index 384950d68237..6b11c5827497 100644 --- a/include/postwin.h +++ b/include/postwin.h @@ -53,17 +53,6 @@ #undef Yield #undef mciSetCommand -/* new StretchBlt() Modes (simpler names) */ -#ifndef STRETCH_ANDSCANS -#define STRETCH_ANDSCANS1 -#endif -#ifndef STRETCH_ORSCANS -#define STRETCH_ORSCANS 2 -#endif -#ifndef STRETCH_DELETESCANS -#define STRETCH_DELETESCANS 3 -#endif - #if !defined INCLUDED_POSTWIN_H && defined __cplusplus #define INCLUDED_POSTWIN_H #endif ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 124510] Border for Section (single column) does not toggle on/off with its control in Application Colors, while multi-column Sections do not show their color boundaries at
https://bugs.documentfoundation.org/show_bug.cgi?id=124510 V Stuart Foote changed: What|Removed |Added Summary|Spurious border applied at |Border for Section (single |margins of paragraphs, |column) does not toggle |specific .ODT document |on/off with its control in ||Application Colors, while ||multi-column Sections do ||not show their color ||boundaries at all Version|6.0.7.3 release |3.5.0 release --- Comment #18 from V Stuart Foote --- In addition to not following the "Section boundaries" checkbox in Tools -> Options -> Application Colors dialog, the borders are not being shown when the Section is changed from Single column to multi-column. Done via the Format -> Sections... -> Options dialog's Columns tab, and where changes to the Background tab (None, Color, or Pattern) likewise do not affect the border. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 124510] Border for Section (single column) does not toggle on/off with its control in Application Colors, while multi-column Sections do not show their color boundaries at all
https://bugs.documentfoundation.org/show_bug.cgi?id=124510 V Stuart Foote changed: What|Removed |Added Summary|Spurious border applied at |Border for Section (single |margins of paragraphs, |column) does not toggle |specific .ODT document |on/off with its control in ||Application Colors, while ||multi-column Sections do ||not show their color ||boundaries at all Version|6.0.7.3 release |3.5.0 release --- Comment #18 from V Stuart Foote --- In addition to not following the "Section boundaries" checkbox in Tools -> Options -> Application Colors dialog, the borders are not being shown when the Section is changed from Single column to multi-column. Done via the Format -> Sections... -> Options dialog's Columns tab, and where changes to the Background tab (None, Color, or Pattern) likewise do not affect the border. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124580] XML MS EXCEL 2003 IMPORT PROBLEM
https://bugs.documentfoundation.org/show_bug.cgi?id=124580 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #1 from Regina Henschel --- I think, it is duplicate to bug 123880. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: dbaccess/source dbaccess/uiconfig include/sfx2 vcl/unx
dbaccess/source/ui/dlg/TablesSingleDlg.cxx | 22 --
dbaccess/source/ui/dlg/tablespage.cxx |1 -
dbaccess/source/ui/dlg/tablespage.hxx |2 +-
dbaccess/source/ui/inc/TablesSingleDlg.hxx |7 +++
dbaccess/source/ui/uno/TableFilterDlg.cxx |3 ++-
dbaccess/uiconfig/ui/tablesfilterpage.ui | 25 +++--
include/sfx2/basedlgs.hxx |1 +
vcl/unx/gtk3/gtk3gtkinst.cxx |8 +++-
8 files changed, 37 insertions(+), 32 deletions(-)
New commits:
commit 8387a0381af4b857035878f8f1bcc880cb823ba7
Author: Caolán McNamara
AuthorDate: Fri Apr 5 21:46:02 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Apr 6 20:46:36 2019 +0200
weld OTableSubscriptionDialog
Change-Id: Idf66a9e49471d6651c03deecc4fb2f9a722f512c
Reviewed-on: https://gerrit.libreoffice.org/70325
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/dbaccess/source/ui/dlg/TablesSingleDlg.cxx
b/dbaccess/source/ui/dlg/TablesSingleDlg.cxx
index 8673bcf25b5b..c6fcbc7c81d4 100644
--- a/dbaccess/source/ui/dlg/TablesSingleDlg.cxx
+++ b/dbaccess/source/ui/dlg/TablesSingleDlg.cxx
@@ -32,13 +32,13 @@ using namespace com::sun::star::beans;
using namespace com::sun::star::container;
// OTableSubscriptionDialog
-OTableSubscriptionDialog::OTableSubscriptionDialog(vcl::Window* pParent
+OTableSubscriptionDialog::OTableSubscriptionDialog(weld::Window* pParent
,const SfxItemSet* _pItems
,const Reference< XComponentContext >& _rxORB
,const css::uno::Any& _aDataSourceName)
-: SfxSingleTabDialog(pParent, _pItems, "TablesFilterDialog",
-"dbaccess/ui/tablesfilterdialog.ui")
-, m_pImpl( new ODbDataSourceAdministrationHelper( _rxORB, GetFrameWeld(),
pParent ? pParent->GetFrameWeld() : nullptr, this ) )
+: SfxSingleTabDialogController(pParent, _pItems,
+"dbaccess/ui/tablesfilterdialog.ui", "TablesFilterDialog")
+, m_pImpl(new ODbDataSourceAdministrationHelper(_rxORB, m_xDialog.get(),
pParent, this))
, m_bStopExecution(false)
{
m_pImpl->setDataSourceOrName(_aDataSourceName);
@@ -48,28 +48,22 @@
OTableSubscriptionDialog::OTableSubscriptionDialog(vcl::Window* pParent
m_pImpl->translateProperties(xDatasource, *m_pOutSet);
SetInputSet(m_pOutSet.get());
-VclPtrInstance pTabPage(get_content_area(),
*m_pOutSet, this);
+TabPageParent pPageParent(get_content_area(), this);
+auto pTabPage = VclPtrInstance(pPageParent,
*m_pOutSet, this);
pTabPage->SetServiceFactory(_rxORB);
SetTabPage(pTabPage);
}
OTableSubscriptionDialog::~OTableSubscriptionDialog()
{
-disposeOnce();
}
-void OTableSubscriptionDialog::dispose()
-{
-m_pOutSet.reset();
-SfxSingleTabDialog::dispose();
-}
-
-short OTableSubscriptionDialog::Execute()
+short OTableSubscriptionDialog::run()
{
short nRet = RET_CANCEL;
if ( !m_bStopExecution )
{
-nRet = SfxSingleTabDialog::Execute();
+nRet = SfxSingleTabDialogController::run();
if ( nRet == RET_OK )
{
m_pOutSet->Put(*GetOutputItemSet());
diff --git a/dbaccess/source/ui/dlg/tablespage.cxx
b/dbaccess/source/ui/dlg/tablespage.cxx
index d5b8ec000344..7ceacdc70d14 100644
--- a/dbaccess/source/ui/dlg/tablespage.cxx
+++ b/dbaccess/source/ui/dlg/tablespage.cxx
@@ -100,7 +100,6 @@ namespace dbaui
::comphelper::disposeComponent(m_xCurrentConnection);
}
catch (RuntimeException&) { }
-m_pTablesDlg.clear();
OGenericAdministrationPage::dispose();
}
diff --git a/dbaccess/source/ui/dlg/tablespage.hxx
b/dbaccess/source/ui/dlg/tablespage.hxx
index d432b1f917b6..9d92a8407b80 100644
--- a/dbaccess/source/ui/dlg/tablespage.hxx
+++ b/dbaccess/source/ui/dlg/tablespage.hxx
@@ -42,7 +42,7 @@ namespace dbaui
m_xCurrentConnection; /// valid as
long as the page is active
css::uno::Reference< css::i18n::XCollator >
m_xCollator;
-VclPtr m_pTablesDlg;
+OTableSubscriptionDialog* m_pTablesDlg;
std::unique_ptr m_xTables;
std::unique_ptr m_xTablesList;
diff --git a/dbaccess/source/ui/inc/TablesSingleDlg.hxx
b/dbaccess/source/ui/inc/TablesSingleDlg.hxx
index a72f70fe756c..135c1350e92a 100644
--- a/dbaccess/source/ui/inc/TablesSingleDlg.hxx
+++ b/dbaccess/source/ui/inc/TablesSingleDlg.hxx
@@ -39,7 +39,7 @@ namespace dbaui
{
class ODbDataSourceAdministrationHelper;
// OTableSubscriptionDialog
-class OTableSubscriptionDialog : public SfxSingleTabDialog, public
IItemSetHelper
+class OTableSubscriptionDialog : public SfxSingleTabDialogController,
public IItemSetHelper
{
std::unique_ptr m_pImpl;
bool m_bStopExecution; // set when the dialog should not be executed
@@ -47,13 +47,12 @@ class
[Libreoffice-bugs] [Bug 124321] Sluggish scrolling and high CPU while scrolling for document with (very) large table (7183 row)
https://bugs.documentfoundation.org/show_bug.cgi?id=124321 Telesto changed: What|Removed |Added Keywords||bibisectRequest, perf, ||possibleRegression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 124510] Spurious border applied at margins of paragraphs, specific .ODT document
https://bugs.documentfoundation.org/show_bug.cgi?id=124510 --- Comment #17 from Regina Henschel --- The relevant settings are in Tools > Options > LO > Application Colors. But I think, that they are buggy. In the section 'General' the setting 'Text boundaries' makes the gray corner ticks (non-printing characters off) or the solid line around the page text area (non-printing characters on). The section 'Text Document' has the additional setting 'section boundaries'. The document 'Sample 2' is not a simple document, but all text is in a section. To distinguish between the page text area and the section, you can set eye-catching colors in the options instead of the automatic gray. For better distinction you should put a single paragraph in 'Sample 1' in a section. Expected behavior: If 'Text boundaries' is on and non-printing characters is off, then the corner ticks of the page text area are visible. If non-printing characters in on, then the page text area is surrounded by a solid line. If 'Text boundaries' is off, neither corner ticks nor solid lines are drawn. The checkbox 'section boundaries' should toggle, whether section boundaries are shown or not. This setting is independent of the setting 'Text boundaries'. Errors are: 1) Unchecking 'section boundaries' in 'Application colors' does not work. 2) Setting 'text boundaries' affects sections too, but should not. It works in Apache OpenOffice, only that Apache OpenOffice has no corner ticks. In LO it is broken at least since LO 3.5. You cannot find it in the document, because it is a general user setting and no setting on document level. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 124510] Spurious border applied at margins of paragraphs, specific .ODT document
https://bugs.documentfoundation.org/show_bug.cgi?id=124510 --- Comment #17 from Regina Henschel --- The relevant settings are in Tools > Options > LO > Application Colors. But I think, that they are buggy. In the section 'General' the setting 'Text boundaries' makes the gray corner ticks (non-printing characters off) or the solid line around the page text area (non-printing characters on). The section 'Text Document' has the additional setting 'section boundaries'. The document 'Sample 2' is not a simple document, but all text is in a section. To distinguish between the page text area and the section, you can set eye-catching colors in the options instead of the automatic gray. For better distinction you should put a single paragraph in 'Sample 1' in a section. Expected behavior: If 'Text boundaries' is on and non-printing characters is off, then the corner ticks of the page text area are visible. If non-printing characters in on, then the page text area is surrounded by a solid line. If 'Text boundaries' is off, neither corner ticks nor solid lines are drawn. The checkbox 'section boundaries' should toggle, whether section boundaries are shown or not. This setting is independent of the setting 'Text boundaries'. Errors are: 1) Unchecking 'section boundaries' in 'Application colors' does not work. 2) Setting 'text boundaries' affects sections too, but should not. It works in Apache OpenOffice, only that Apache OpenOffice has no corner ticks. In LO it is broken at least since LO 3.5. You cannot find it in the document, because it is a general user setting and no setting on document level. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124580] New: XML MS EXCEL 2003 IMPORT PROBLEM
https://bugs.documentfoundation.org/show_bug.cgi?id=124580 Bug ID: 124580 Summary: XML MS EXCEL 2003 IMPORT PROBLEM Product: LibreOffice Version: 6.2.2.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ypene...@gmail.com Created attachment 150573 --> https://bugs.documentfoundation.org/attachment.cgi?id=150573=edit This file is originally a ms 2003 xml file, that it's extension is renamed to xls for automatic import to Libre I am producing xml files in ms excell 2003 xml format. There was no problem in importing this file up to LibreOffice 5.4.2.2 release, but with the releases of 6.*, not anymore. To experiment, I also exported one Libre spreadsheet to ms 2003 xml, then import to Libre back, but not working. Thanks. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: fpicker/source include/vcl vcl/source
fpicker/source/win32/asyncrequests.cxx |5 +
include/vcl/winscheduler.hxx |5 +
vcl/source/app/winscheduler.cxx| 12 +---
3 files changed, 19 insertions(+), 3 deletions(-)
New commits:
commit e3d737119fc7bdce224a173896486f376f95a417
Author: Mike Kaganski
AuthorDate: Sat Apr 6 17:04:06 2019 +0100
Commit: Mike Kaganski
CommitDate: Sat Apr 6 19:56:11 2019 +0200
tdf#124579: ensure to provide an event to wake up main loop when notifying
Without that, Request::waitProcessMessages might wait indefinitely for
Application::Yield() to return; while the latter would wait for a message
in GetMessage. If there's no visible LO window, the message might never
arrive by itself.
Co-authored-by: Jan-Marek Glogowski
Change-Id: Ie2622053a8d4467eb1cbd579d8496cb5ddef08aa
Reviewed-on: https://gerrit.libreoffice.org/70346
Reviewed-by: Mike Kaganski
Tested-by: Mike Kaganski
diff --git a/fpicker/source/win32/asyncrequests.cxx
b/fpicker/source/win32/asyncrequests.cxx
index 665c0d1d6dc7..cdcfb6d630e9 100644
--- a/fpicker/source/win32/asyncrequests.cxx
+++ b/fpicker/source/win32/asyncrequests.cxx
@@ -19,6 +19,7 @@
#include "asyncrequests.hxx"
#include
+#include
#include
namespace fpicker{
@@ -56,6 +57,10 @@ void Request::waitProcessMessages()
void Request::notify()
{
m_aJoiner.set();
+// Make sure that main loop receives at least this message to return from
GetMessage and recheck
+// the condition, even in case when there's no visible application windows
present, and thus no
+// other messages might arrive to the main loop.
+WinScheduler::PostDummyMessage();
}
AsyncRequests::AsyncRequests(const RequestHandlerRef& rHandler)
diff --git a/include/vcl/winscheduler.hxx b/include/vcl/winscheduler.hxx
index 02d86116bb38..6f77f3a7b082 100644
--- a/include/vcl/winscheduler.hxx
+++ b/include/vcl/winscheduler.hxx
@@ -31,6 +31,11 @@ struct VCL_DLLPUBLIC WinScheduler final
/// Hack for Windows native dialogs, which run the main loop, so we can't
/// use the direct processing shortcut.
static void SetForceRealTimer();
+
+// Posting a dummy messages might be needed to ensure that main loop
eventually returns from
+// GetMessage ("wakes up") in modes without a visible window. This, e.g.,
might be needed to
+// let main thread recheck a condition set from another thread.
+static void PostDummyMessage();
};
#endif // _WIN32
diff --git a/vcl/source/app/winscheduler.cxx b/vcl/source/app/winscheduler.cxx
index f8a90f3f638d..8ec11211cfe0 100644
--- a/vcl/source/app/winscheduler.cxx
+++ b/vcl/source/app/winscheduler.cxx
@@ -25,12 +25,18 @@
#include
#include
-void WinScheduler::SetForceRealTimer()
+namespace
{
-BOOL const ret
-= PostMessageW(GetSalData()->mpInstance->mhComWnd,
SAL_MSG_FORCE_REAL_TIMER, 0, 0);
+void PostMessageToComWnd(UINT nMsg)
+{
+BOOL const ret = PostMessageW(GetSalData()->mpInstance->mhComWnd, nMsg, 0,
0);
SAL_WARN_IF(0 == ret, "vcl.schedule", "ERROR: PostMessage() failed!");
}
+}
+
+void WinScheduler::SetForceRealTimer() {
PostMessageToComWnd(SAL_MSG_FORCE_REAL_TIMER); }
+
+void WinScheduler::PostDummyMessage() { PostMessageToComWnd(SAL_MSG_DUMMY); }
#endif // _WIN32
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: basctl/source basctl/uiconfig cui/source cui/uiconfig dbaccess/source dbaccess/uiconfig desktop/source desktop/uiconfig include/vcl sc/source sc/uiconfig sw/source sw/u
basctl/source/basicide/moduldl2.cxx |4
basctl/source/dlged/managelang.cxx|4
basctl/uiconfig/basicide/ui/defaultlanguage.ui|2
basctl/uiconfig/basicide/ui/importlibdialog.ui|2
cui/source/customize/SvxToolbarConfigPage.cxx | 14
cui/source/dialogs/hangulhanjadlg.cxx |4
cui/source/dialogs/multipat.cxx | 14
cui/source/dialogs/srchxtra.cxx |4
cui/source/inc/cfg.hxx|2
cui/source/options/certpath.cxx | 12
cui/source/options/optlingu.cxx | 28 -
cui/source/tabpages/autocdlg.cxx | 174 +++
cui/uiconfig/ui/accelconfigpage.ui|8
cui/uiconfig/ui/acoroptionspage.ui|2
cui/uiconfig/ui/applyautofmtpage.ui |4
cui/uiconfig/ui/applylocalizedpage.ui |6
cui/uiconfig/ui/certdialog.ui |2
cui/uiconfig/ui/hangulhanjaoptdialog.ui |2
cui/uiconfig/ui/menuassignpage.ui |2
cui/uiconfig/ui/multipathdialog.ui|2
cui/uiconfig/ui/optlingupage.ui |6
cui/uiconfig/ui/searchattrdialog.ui |2
cui/uiconfig/ui/smarttagoptionspage.ui|2
dbaccess/source/ui/browser/unodatbr.cxx |6
dbaccess/source/ui/control/dbtreelistbox.cxx |2
dbaccess/source/ui/control/tabletree.cxx | 446 ++
dbaccess/source/ui/dlg/tablespage.cxx | 254 --
dbaccess/source/ui/dlg/tablespage.hxx | 18
dbaccess/source/ui/inc/dbtreelistbox.hxx |3
dbaccess/source/ui/inc/imageprovider.hxx | 13
dbaccess/source/ui/inc/tabletree.hxx | 123
dbaccess/source/ui/misc/imageprovider.cxx | 53 ++
dbaccess/uiconfig/ui/tablesfilterpage.ui | 75 ++-
desktop/source/deployment/gui/dp_gui_updatedialog.cxx |8
desktop/uiconfig/ui/updatedialog.ui |2
include/vcl/svimpbox.hxx |1
include/vcl/svlbitm.hxx |5
include/vcl/treelistbox.hxx |4
include/vcl/weld.hxx | 29 -
sc/source/ui/dbgui/dpgroupdlg.cxx |6
sc/source/ui/dbgui/pvfundlg.cxx |6
sc/source/ui/dbgui/tpsubt.cxx | 12
sc/source/ui/miscdlgs/protectiondlg.cxx | 10
sc/source/ui/miscdlgs/solveroptions.cxx |4
sc/uiconfig/scalc/ui/datafieldoptionsdialog.ui|2
sc/uiconfig/scalc/ui/groupbydate.ui |2
sc/uiconfig/scalc/ui/protectsheetdlg.ui |2
sc/uiconfig/scalc/ui/solveroptionsdialog.ui |2
sc/uiconfig/scalc/ui/subtotalgrppage.ui |2
sw/source/ui/config/optload.cxx | 19
sw/source/ui/index/cnttab.cxx | 29 -
sw/uiconfig/swriter/ui/assignstylesdialog.ui | 22
sw/uiconfig/swriter/ui/optcaptionpage.ui |2
sw/uiconfig/swriter/ui/tocindexpage.ui|2
vcl/source/app/salvtables.cxx | 145 +
vcl/source/treelist/svlbitm.cxx | 28 +
vcl/source/treelist/treelistbox.cxx | 27 -
vcl/unx/gtk3/gtk3gtkinst.cxx | 116
58 files changed, 1376 insertions(+), 406 deletions(-)
New commits:
commit 5c32ba63163d9556ff89782a8074924cdf9dc554
Author: Caolán McNamara
AuthorDate: Thu Apr 4 14:30:03 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Apr 6 19:53:00 2019 +0200
weld OTableSubscriptionPage
Change-Id: I55c23448480384c9a7d78cd0bb4812ebde72
Reviewed-on: https://gerrit.libreoffice.org/70314
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/basctl/source/basicide/moduldl2.cxx
b/basctl/source/basicide/moduldl2.cxx
index 7494d288266b..9356357aa55f 100644
--- a/basctl/source/basicide/moduldl2.cxx
+++ b/basctl/source/basicide/moduldl2.cxx
@@ -795,7 +795,7 @@ void LibPage::InsertLib()
weld::TreeView& rView = xLibDlg->GetLibBox();
rView.append();
const int nRow = rView.n_children() - 1;
-rView.set_toggle(nRow, true, 0);
+rView.set_toggle(nRow, TRISTATE_TRUE, 0);
rView.set_text(nRow, aLibName, 1);
}
}
@@ -829,7 +829,7 @@ void LibPage::InsertLib()
weld::TreeView& rView = xLibDlg->GetLibBox();
for (int nLib = 0, nChildren = rView.n_children(); nLib <
nChildren; ++nLib)
{
-
[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)
https://bugs.documentfoundation.org/show_bug.cgi?id=112989 --- Comment #34 from Buovjaga --- Created attachment 150572 --> https://bugs.documentfoundation.org/attachment.cgi?id=150572=edit Perf flamegraph Arch Linux 64-bit Version: 6.3.0.0.alpha0+ Build ID: 558956dc811a1f0f07411e348f7081a467bbc3b5 CPU threads: 8; OS: Linux 5.0; UI render: default; VCL: gtk3; Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US Calc: threaded Built on 4 April 2019 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123668] Cursor focus moves outside Quick find bar when reaching results in Notes view
https://bugs.documentfoundation.org/show_bug.cgi?id=123668 Buovjaga changed: What|Removed |Added Blocks||108743 Summary|Text search can select text |Cursor focus moves outside |for replacement/deletion. |Quick find bar when ||reaching results in Notes ||view OS|Windows (All) |All CC||todven...@suomi24.fi Version|6.1.5.2 release |Inherited From OOo --- Comment #3 from Buovjaga --- It used to be worse: in 4.3.0 and older Enter replaces the text even in Slide view. Also repro on Linux. Potentially an accessibility issue, so keeping severity as normal. Arch Linux 64-bit Version: 6.3.0.0.alpha0+ Build ID: 558956dc811a1f0f07411e348f7081a467bbc3b5 CPU threads: 8; OS: Linux 5.0; UI render: default; VCL: gtk3; Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US Calc: threaded Built on 4 April 2019 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108743 [Bug 108743] [META] Find toolbar bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108743] [META] Find toolbar bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108743 Buovjaga changed: What|Removed |Added Depends on||123668 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=123668 [Bug 123668] Cursor focus moves outside Quick find bar when reaching results in Notes view -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116399] Sending a print job for a 400 paged document is rather slow
https://bugs.documentfoundation.org/show_bug.cgi?id=116399 --- Comment #4 from Telesto --- @Buovjaga Slightly opportunistic .. but I would love Noels perf magic in this area ;-). Not sure if it's within his expertise though.. because it's likely - based on bibisect - Harfbuzz related -> Opening the Print Preview Dialog -> Slow (not responding) -> Giving the print job to a virtual printer -> It can nearly see the dialog counts every page Yes: I'm biased like hell.. I'm the one complaining (I reported this bug and most of the duplicates of bug 112989) But the performance is quite horrific IMHO. And seems to me everybody would profit There quite something to gain here... IMHO -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123412] Base: Unwanted disonnection from Firebird data source error message "connection shutdown caused by isc_service_attach"
https://bugs.documentfoundation.org/show_bug.cgi?id=123412 --- Comment #10 from Tim --- When I restart LibreOffice and open the database file, it seems to work ok until I open some .ODT files and after a while then I can't access the tables within the database. As it's not immediate, I don't know how many .ODT files I have to open or for how long until the error comes up in the database. So what I've seemed to find put is that the database will work well as long as I don't open .ODT files. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: animations/source
animations/source/animcore/animcore.cxx |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
New commits:
commit 6f31c63e35abef03e6f938bbddc8778b70a62d43
Author: Arkadiy Illarionov
AuthorDate: Sat Apr 6 13:36:35 2019 +0300
Commit: Noel Grandin
CommitDate: Sat Apr 6 18:55:10 2019 +0200
clang-tidy modernize-avoid-c-arrays in animations
Change-Id: I3dc1c0e63bd90735c20a65b1af25b243e5a5eee5
Reviewed-on: https://gerrit.libreoffice.org/70341
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/animations/source/animcore/animcore.cxx
b/animations/source/animcore/animcore.cxx
index 4dd4868e70e5..d5bcb0c21b14 100644
--- a/animations/source/animcore/animcore.cxx
+++ b/animations/source/animcore/animcore.cxx
@@ -57,6 +57,7 @@
#include
#include
+#include
#include
#include
#include
@@ -287,7 +288,7 @@ private:
const sal_Int16 mnNodeType;
// for XTypeProvider
-static Sequence< Type >* mpTypes[12];
+static std::array*, 12> mpTypes;
// attributes for the XAnimationNode interface implementation
Any maBegin, maDuration, maEnd, maEndSync, maRepeatCount, maRepeatDuration;
@@ -388,7 +389,7 @@ Any SAL_CALL TimeContainerEnumeration::nextElement()
}
-Sequence< Type >* AnimationNode::mpTypes[] = { nullptr, nullptr, nullptr,
nullptr, nullptr, nullptr, nullptr, nullptr, nullptr, nullptr, nullptr };
+std::array*, 12> AnimationNode::mpTypes = { nullptr, nullptr,
nullptr, nullptr, nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
nullptr, nullptr };
AnimationNode::AnimationNode( sal_Int16 nNodeType )
: maChangeListener(maMutex),
@@ -418,7 +419,7 @@ AnimationNode::AnimationNode( sal_Int16 nNodeType )
mnIterateType( css::presentation::ShapeAnimationSubType::AS_WHOLE ),
mfIterateInterval(0.0)
{
-assert(nNodeType < int(SAL_N_ELEMENTS(mpTypes)));
+assert(nNodeType < int(mpTypes.size()));
}
AnimationNode::AnimationNode( const AnimationNode& rNode )
@@ -696,7 +697,7 @@ void AnimationNode::initTypeProvider( sal_Int16 nNodeType )
throw()
if(! mpTypes[nNodeType] )
{
-static const sal_Int32 type_numbers[] =
+static constexpr std::array type_numbers =
{
7, // CUSTOM
9, // PAR
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/ui/config/optcomp.cxx | 26 --
1 file changed, 24 insertions(+), 2 deletions(-)
New commits:
commit 1ac1fdbe5bb3139c81a331beb16c79e84d7c4f27
Author: Tamás Zolnai
AuthorDate: Sat Apr 6 13:25:27 2019 +0200
Commit: Tamás Zolnai
CommitDate: Sat Apr 6 18:41:30 2019 +0200
respect read-only config item: MSCompatibleFormsMenu
Change-Id: I4eacbe8ad2025a54c13f4c0fa06e30e5ab59b721
Reviewed-on: https://gerrit.libreoffice.org/70344
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai
diff --git a/sw/source/ui/config/optcomp.cxx b/sw/source/ui/config/optcomp.cxx
index 0eebed82220d..1f49688d6249 100644
--- a/sw/source/ui/config/optcomp.cxx
+++ b/sw/source/ui/config/optcomp.cxx
@@ -37,6 +37,8 @@
#include
#include
#include
+#include
+#include
using namespace ::com::sun::star::beans;
using namespace ::com::sun::star::document;
@@ -82,11 +84,31 @@ SwCompatibilityOptPage::SwCompatibilityOptPage(vcl::Window*
pParent, const SfxIt
m_pOptionsLB->SetStyle( m_pOptionsLB->GetStyle() | WB_HSCROLL |
WB_HIDESELECTION );
m_pOptionsLB->SetHighlightRange();
-SvTreeListEntry* pEntry = m_pGlobalOptionsCLB->SvTreeListBox::InsertEntry(
m_pGlobalOptionsLB->GetEntry( 0 ) );
+
+// Set MSOCompatibleFormsMenu entry attributes
+const bool bReadOnly =
officecfg::Office::Compatibility::View::MSCompatibleFormsMenu::isReadOnly();
+const bool bChecked = m_aViewConfigItem.HasMSOCompatibleFormsMenu();
+
+SvTreeListEntry* pEntry;
+if(bReadOnly)
+{
+pEntry = m_pGlobalOptionsCLB->SvTreeListBox::InsertEntry(
m_pGlobalOptionsLB->GetEntry( 0 ), nullptr, false,
+
TREELIST_APPEND, nullptr, SvLBoxButtonKind::DisabledCheckbox);
+}
+else
+{
+pEntry = m_pGlobalOptionsCLB->SvTreeListBox::InsertEntry(
m_pGlobalOptionsLB->GetEntry( 0 ) );
+}
+
if ( pEntry )
{
-m_pGlobalOptionsCLB->SetCheckButtonState( pEntry,
SvButtonState::Unchecked );
+SvLBoxButton* pButton =
static_cast(pEntry->GetFirstItem(SvLBoxItemType::Button));
+if(bChecked)
+pButton->SetStateChecked();
+else
+pButton->SetStateUnchecked();
}
+
m_pGlobalOptionsLB->Clear();
m_pGlobalOptionsCLB->SetStyle( m_pGlobalOptionsCLB->GetStyle() |
WB_HSCROLL | WB_HIDESELECTION );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 124579] Basic Macro hang up when using (operation system) filepicker/folderpicker
https://bugs.documentfoundation.org/show_bug.cgi?id=124579 Mike Kaganski changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | Status|NEW |ASSIGNED CC||glo...@fbihome.de --- Comment #4 from Mike Kaganski --- https://gerrit.libreoffice.org/70346 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124579] Basic Macro hang up when using (operation system) filepicker/folderpicker
https://bugs.documentfoundation.org/show_bug.cgi?id=124579 Mike Kaganski changed: What|Removed |Added Ever confirmed|0 |1 Keywords||bibisected, bisected, ||regression Status|UNCONFIRMED |NEW --- Comment #3 from Mike Kaganski --- Reproducible with current master on Windows 10 x64. Regression after https://git.libreoffice.org/core/+/0073101ec520e40727800f1d90b3b211fd6ec8d8. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124510] Spurious border applied at margins of paragraphs, specific .ODT document
https://bugs.documentfoundation.org/show_bug.cgi?id=124510 V Stuart Foote changed: What|Removed |Added Summary|Spurious border applied at |Spurious border applied at |margins of paragraphs |margins of paragraphs, ||specific .ODT document Severity|enhancement |normal --- Comment #16 from V Stuart Foote --- None of the LibreOffice GUI controls for Borders (column, paragraph, page) are set--and the borders end with the paragraphs on the last page, so does not seem to be part of page style or margin formatting. This ODF text document is weird. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 124510] Spurious border applied at margins of paragraphs, specific .ODT document
https://bugs.documentfoundation.org/show_bug.cgi?id=124510 V Stuart Foote changed: What|Removed |Added Summary|Spurious border applied at |Spurious border applied at |margins of paragraphs |margins of paragraphs, ||specific .ODT document Severity|enhancement |normal --- Comment #16 from V Stuart Foote --- None of the LibreOffice GUI controls for Borders (column, paragraph, page) are set--and the borders end with the paragraphs on the last page, so does not seem to be part of page style or margin formatting. This ODF text document is weird. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 124510] Spurious border applied at margins of paragraphs
https://bugs.documentfoundation.org/show_bug.cgi?id=124510 V Stuart Foote changed: What|Removed |Added Status|NEEDINFO|NEW Summary|OPTION DIALOG: Add option |Spurious border applied at |to show page margins|margins of paragraphs Keywords|needsUXEval | CC||rb.hensc...@t-online.de --- Comment #15 from V Stuart Foote --- @Regina, reviewing the content and style XML I can not figure out where the border being applied to all paragraphs of Sample 2 (attachment 150555) is coming from. Any insights? Thanks! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 124510] Spurious border applied at margins of paragraphs
https://bugs.documentfoundation.org/show_bug.cgi?id=124510 V Stuart Foote changed: What|Removed |Added Status|NEEDINFO|NEW Summary|OPTION DIALOG: Add option |Spurious border applied at |to show page margins|margins of paragraphs Keywords|needsUXEval | CC||rb.hensc...@t-online.de --- Comment #15 from V Stuart Foote --- @Regina, reviewing the content and style XML I can not figure out where the border being applied to all paragraphs of Sample 2 (attachment 150555) is coming from. Any insights? Thanks! -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 124579] Basic Macro hang up when using (operation system) filepicker/folderpicker
https://bugs.documentfoundation.org/show_bug.cgi?id=124579 --- Comment #2 from Hans-Werner --- Created attachment 150571 --> https://bugs.documentfoundation.org/attachment.cgi?id=150571=edit win cmd for starting macro -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124579] Basic Macro hang up when using (operation system) filepicker/folderpicker
https://bugs.documentfoundation.org/show_bug.cgi?id=124579 --- Comment #1 from Hans-Werner --- Created attachment 150569 --> https://bugs.documentfoundation.org/attachment.cgi?id=150569=edit macro for testing picker software -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124576] Print preview and printing bug
https://bugs.documentfoundation.org/show_bug.cgi?id=124576 --- Comment #3 from Oliver Brinzing --- Created attachment 150570 --> https://bugs.documentfoundation.org/attachment.cgi?id=150570=edit print_preview lo_6152 vs lo_6073 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124576] Print preview and printing bug
https://bugs.documentfoundation.org/show_bug.cgi?id=124576 Oliver Brinzing changed: What|Removed |Added OS|Linux (All) |All -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124576] Print preview and printing bug
https://bugs.documentfoundation.org/show_bug.cgi?id=124576 Oliver Brinzing changed: What|Removed |Added Ever confirmed|0 |1 CC||oliver.brinz...@gmx.de Status|UNCONFIRMED |NEW --- Comment #2 from Oliver Brinzing --- reproducible with Version: 6.1.5.2 (x64) Build-ID: 90f8dcf33c87b3705e78202e3df5142b201bd805 CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; Gebietsschema: de-DE (de_DE); Calc: but not with: Version: 6.0.7.3 (x64) Build-ID: dc89aa7a9eabfd848af146d5086077aeed2ae4a5 CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; Gebietsschema: de-DE (de_DE); Calc: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124572] tabs in calc (for sheets) and draw (for layer) style
https://bugs.documentfoundation.org/show_bug.cgi?id=124572 --- Comment #9 from andreas_k --- Between the separator should be the user defined color and maybe an horizontal line with the user defined color. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124579] New: Basic Macro hang up when using (operation system) filepicker/folderpicker
https://bugs.documentfoundation.org/show_bug.cgi?id=124579 Bug ID: 124579 Summary: Basic Macro hang up when using (operation system) filepicker/folderpicker Product: LibreOffice Version: 6.2.1.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hanswernerher...@t-online.de Description: When starting a macro, that uses (operation system) filepicker/folderpicker, by using an external command, macro hangs up. It could be, that only "Windows 7" is affected. Steps to Reproduce: 1. No LO running. 2. Start macro (TestPickerSW.txt) by using the external command (TestPickerSW.cmd) and select [1],[2],[3] or [4] (Macro InputBox). [1] = Macro uses "com.sun.star.ui.dialogs.OfficeFilePicker" [2] = Macro uses "com.sun.star.ui.dialogs.OfficeFolderPicker" [3] = Macro uses "com.sun.star.ui.dialogs.FilePicker" [4] = Macro uses "com.sun.star.ui.dialogs.FolderPicker" Actual Results: When selecting [1] or [2] no error occurs and macro ends with: "Last code line of macro ...". When selecting [3] or [4] macro will hang up (soffice.exe using 0% CPU). When in this situation soffice.exe is manually re-started by user, macro continues processing. Expected Results: Macro should not hang up. Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124578] New: LibreOffice will not open after April 2019 Windows 10 auto update
https://bugs.documentfoundation.org/show_bug.cgi?id=124578 Bug ID: 124578 Summary: LibreOffice will not open after April 2019 Windows 10 auto update Product: LibreOffice Version: 6.2.2.2 release Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: damonele...@gmail.com This may have more to do with Windows 10pro. I have it set for auto updates and after the last update LibreOffice nor any of its components would open. I reinstalled LO first opting for repair. That did not work. Tried again, removing LO this time then reinstalling it. This worked and everything now opens. No error messages appeared at any time. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Gitiles VCS browser
On 06.04.2019 17:18, Luke Benes wrote: > Mike, > That is not an apples to apples comparison. In your browser open and compare > side-by-side: > > https://git.libreoffice.org/core/+/6a9cf9ba2d37fee9b7c2f190b347e0d7c4a2676a > and > https://cgit.freedesktop.org/libreoffice/core/commit/?id=6a9cf9ba2d37fee9b7c2f190b347e0d7c4a2676a > > Do you really like all of the extraneous information? Do you mean the tree below? Well - it doesn't hurt me. But if it went away (with a link to easily reach the tree from that page), I'd not protest. > Do you like the missing search bar? It doesn't matter *for me*, because I don't use it anyway. But I can see how people might miss it. > Do you like having to scroll down several pages to see the relevant > information? I don't quite get that. Which information on that page requires to scroll down several pages in gitiles, which does not on cgit? > Do you like the lack of a search bar? This is not the fourth argument, but rather the second ;-) > Besides the fact, these are not what the commits look like on our bug > trackers. From > > https://git.libreoffice.org/core/+/bf2f0c913774c90e4c9a65119d0219187bb4498c%5E%21 > while the old cgit would be > https://cgit.freedesktop.org/libreoffice/core/commit/?id=bf2f0c913774c90e4c9a65119d0219187bb4498c > > Now try to copy the commit ID from the gitiles and do the same for the cgit > URL. Do you really prefer the random symbols appended to the end? I can tell > you git does not and will puke if you accidentally include any of them. For me, double-clicking commit number in the address bar in Chrome on Windows (e.g., between b and f in the URL above), selects the commit ID without the trailing part. Well - of course, if the commit diff were right on that initial page without ^! (after the changed files list), I'd also not protest. -- Best regards, Mike Kaganski ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 109324] [META] Calculate bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109324 Oliver Brinzing changed: What|Removed |Added Depends on||124577 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124577 [Bug 124577] Copying by dragging calculates false values (different every time) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124577] Copying by dragging calculates false values (different every time)
https://bugs.documentfoundation.org/show_bug.cgi?id=124577 Oliver Brinzing changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Blocks||109324, 114159 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||4270 --- Comment #4 from Oliver Brinzing --- setting to "NEW" even if i can not reproduce at the moment, but it sounds understandable and seems to be related to/a duplicate of: Editing: Err:522 on copying of rows with "Calc: threaded" enabled https://bugs.documentfoundation.org/show_bug.cgi?id=124270 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=109324 [Bug 109324] [META] Calculate bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=114159 [Bug 114159] [META] Calc Threaded Calculation bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124270] Editing: Err:522 on copying of rows with "Calc: threaded" enabled ( steps in comment 6 )
https://bugs.documentfoundation.org/show_bug.cgi?id=124270 Oliver Brinzing changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||4577 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114159] [META] Calc Threaded Calculation bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114159 Oliver Brinzing changed: What|Removed |Added Depends on||124577 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124577 [Bug 124577] Copying by dragging calculates false values (different every time) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50916] Allow more than 1024 columns in calc
https://bugs.documentfoundation.org/show_bug.cgi?id=50916 --- Comment #76 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/6db38ca2cc9cafb353dd2ca2f4a617d5fa3eb51d%5E%21 ofz#14093 bunch of new ofz detected crashes related to tdf#50916 It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa sc/source
sc/qa/unit/data/slk/pass/ofz14093-1.slk |1 +
sc/source/core/data/table2.cxx | 10 ++
2 files changed, 7 insertions(+), 4 deletions(-)
New commits:
commit 6db38ca2cc9cafb353dd2ca2f4a617d5fa3eb51d
Author: Caolán McNamara
AuthorDate: Sat Apr 6 14:03:11 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Apr 6 16:44:07 2019 +0200
ofz#14093 bunch of new ofz detected crashes related to tdf#50916
since...
commit 7282014e362a1529a36c88eb308df8ed359c2cfa
Date: Fri Feb 1 15:15:16 2019 +0100
tdf#50916 Makes numbers of columns dynamic.
Change-Id: I7588e34a9a52cde0d38dd9c1f15e6bbdb3601241
Reviewed-on: https://gerrit.libreoffice.org/70345
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/qa/unit/data/slk/pass/ofz14093-1.slk
b/sc/qa/unit/data/slk/pass/ofz14093-1.slk
new file mode 100644
index ..7667ddb0a00a
--- /dev/null
+++ b/sc/qa/unit/data/slk/pass/ofz14093-1.slk
@@ -0,0 +1 @@
+C;X152;K"
\ No newline at end of file
diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx
index a74fc3a9a289..b049ff193b66 100644
--- a/sc/source/core/data/table2.cxx
+++ b/sc/source/core/data/table2.cxx
@@ -1405,11 +1405,13 @@ bool ScTable::TestCopyScenarioTo( const ScTable*
pDestTab ) const
bool ScTable::SetString( SCCOL nCol, SCROW nRow, SCTAB nTabP, const OUString&
rString,
const ScSetStringParam * pParam )
{
-if (ValidColRow(nCol,nRow))
-return aCol[nCol].SetString(
-nRow, nTabP, rString, pDocument->GetAddressConvention(), pParam );
-else
+if (!ValidColRow(nCol,nRow))
+{
return false;
+}
+
+return CreateColumnIfNotExists(nCol).SetString(
+nRow, nTabP, rString, pDocument->GetAddressConvention(), pParam);
}
bool ScTable::SetEditText( SCCOL nCol, SCROW nRow,
std::unique_ptr pEditText )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 114159] [META] Calc Threaded Calculation bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114159 Oliver Brinzing changed: What|Removed |Added Depends on||124270 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124270 [Bug 124270] Editing: Err:522 on copying of rows with "Calc: threaded" enabled ( steps in comment 6 ) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124270] Editing: Err:522 on copying of rows with "Calc: threaded" enabled ( steps in comment 6 )
https://bugs.documentfoundation.org/show_bug.cgi?id=124270 Oliver Brinzing changed: What|Removed |Added Blocks||114159 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=114159 [Bug 114159] [META] Calc Threaded Calculation bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/inc vcl/source
vcl/inc/graphic/Manager.hxx|2 ++
vcl/source/graphic/Manager.cxx | 15 +++
2 files changed, 17 insertions(+)
New commits:
commit 5198a68d7e8e4fe8397fa188c19ba8be587e29f5
Author: Caolán McNamara
AuthorDate: Thu Apr 4 17:43:57 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Apr 6 16:42:48 2019 +0200
crashtesting, threading crash with bitmapinfoaccess_null_ptr_deref.sample
on export to .ods
Thread 1:
5 0x7f758fde4969 in raise () from /lib64/libc.so.6
6 0x7f758fde5f98 in abort () from /lib64/libc.so.6
7 0x7f758f485afd in __gnu_debug::_Error_formatter::_M_error (
this=0x7f7588872860 <__gnu_debug::_Error_formatter::_M_at(char const*,
unsigned int)::__formatter>)
at ../../../.././libstdc++-v3/src/c++11/debug.cc:1069
8 0x7f7587b42922 in
__gnu_debug::_Safe_iterator, std::__debug::unordered_set,
std::equal_to, std::allocator > >::operator++ (
this=0x7f755a58e440) at
/srv/crashtestdata/gccbuild/gcc8/include/c++/8.2.0/debug/safe_iterator.h:295
9 0x7f7587b415d5 in vcl::graphic::Manager::registerGraphic
(this=0x5fe9860,
pImpGraphic=std::shared_ptr (use count 1, weak count 0) =
{...})
at /home/buildslave/source/libo-core/vcl/source/graphic/Manager.cxx:123
10 0x7f7587b418e2 in vcl::graphic::Manager::newInstance (this=0x5fe9860)
at /home/buildslave/source/libo-core/vcl/source/graphic/Manager.cxx:156
11 0x7f758798c406 in Graphic::Graphic (this=0x7f755a58e6d0)
at /home/buildslave/source/libo-core/vcl/source/gdi/graph.cxx:187
12 0x7f758799c85a in ImpGraphic::loadPrepared (this=0x80d2500)
at /home/buildslave/source/libo-core/vcl/source/gdi/impgraph.cxx:1540
13 0x7f758799c999 in ImpGraphic::ImplSwapIn (this=0x80d2500)
at /home/buildslave/source/libo-core/vcl/source/gdi/impgraph.cxx:1561
14 0x7f758799c813 in ImpGraphic::ensureAvailable (this=0x80d2500)
and a bunch of other threads looking like they've just come from the same
family of methods
Change-Id: Ic13d3c7cb2fb4adaa2a0a6b8845fc2156d53005e
Reviewed-on: https://gerrit.libreoffice.org/70271
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/vcl/inc/graphic/Manager.hxx b/vcl/inc/graphic/Manager.hxx
index f6f24b47db6f..1f897ecf7146 100644
--- a/vcl/inc/graphic/Manager.hxx
+++ b/vcl/inc/graphic/Manager.hxx
@@ -23,6 +23,7 @@
#include
#include
+#include
#include
#include
@@ -35,6 +36,7 @@ namespace graphic
class Manager final
{
private:
+std::recursive_mutex maMutex; // instead of SolarMutex because graphics
can live past vcl main
std::unordered_set m_pImpGraphicList;
std::chrono::seconds mnAllowedIdleTime;
sal_Int64 mnMemoryLimit;
diff --git a/vcl/source/graphic/Manager.cxx b/vcl/source/graphic/Manager.cxx
index 405aa8928649..fe80fdf5aaa4 100644
--- a/vcl/source/graphic/Manager.cxx
+++ b/vcl/source/graphic/Manager.cxx
@@ -20,6 +20,7 @@
#include
#include
#include
+#include
#include
using namespace css;
@@ -72,6 +73,8 @@ Manager::Manager()
void Manager::reduceGraphicMemory()
{
+std::lock_guard aGuard(maMutex);
+
for (ImpGraphic* pEachImpGraphic : m_pImpGraphicList)
{
if (mnUsedSize < mnMemoryLimit * 0.7)
@@ -102,6 +105,8 @@ sal_Int64 Manager::getGraphicSizeBytes(const ImpGraphic*
pImpGraphic)
IMPL_LINK(Manager, SwapOutTimerHandler, Timer*, pTimer, void)
{
+std::lock_guard aGuard(maMutex);
+
pTimer->Stop();
reduceGraphicMemory();
pTimer->Start();
@@ -110,6 +115,8 @@ IMPL_LINK(Manager, SwapOutTimerHandler, Timer*, pTimer,
void)
void Manager::registerGraphic(const std::shared_ptr& pImpGraphic,
OUString const& /*rsContext*/)
{
+std::lock_guard aGuard(maMutex);
+
// make some space first
if (mnUsedSize > mnMemoryLimit)
reduceGraphicMemory();
@@ -139,6 +146,8 @@ void Manager::registerGraphic(const
std::shared_ptr& pImpGraphic,
void Manager::unregisterGraphic(ImpGraphic* pImpGraphic)
{
+std::lock_guard aGuard(maMutex);
+
mnUsedSize -= getGraphicSizeBytes(pImpGraphic);
m_pImpGraphicList.erase(pImpGraphic);
}
@@ -201,16 +210,22 @@ std::shared_ptr Manager::newInstance(const
GraphicExternalLink& rGra
void Manager::swappedIn(const ImpGraphic* pImpGraphic)
{
+std::lock_guard aGuard(maMutex);
+
mnUsedSize += getGraphicSizeBytes(pImpGraphic);
}
void Manager::swappedOut(const ImpGraphic* pImpGraphic)
{
+std::lock_guard aGuard(maMutex);
+
mnUsedSize -= getGraphicSizeBytes(pImpGraphic);
}
void Manager::changeExisting(const ImpGraphic* pImpGraphic, sal_Int64
nOldSizeBytes)
{
+std::lock_guard aGuard(maMutex);
+
mnUsedSize -= nOldSizeBytes;
mnUsedSize += getGraphicSizeBytes(pImpGraphic);
}
___
Libreoffice-commits mailing list
[Libreoffice-bugs] [Bug 124552] A Sentence selection UNO action not provided for assignment to keyboard use
https://bugs.documentfoundation.org/show_bug.cgi?id=124552 V Stuart Foote changed: What|Removed |Added See Also||https://bz.apache.org/ooo/s ||how_bug.cgi?id=20126 Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114220] [META] Drag and drop bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114220 Bug 114220 depends on bug 124326, which changed state. Bug 124326 Summary: Undo after drag changes the original formula https://bugs.documentfoundation.org/show_bug.cgi?id=124326 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108253] [META] Calc cell formula bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108253 Bug 108253 depends on bug 124326, which changed state. Bug 124326 Summary: Undo after drag changes the original formula https://bugs.documentfoundation.org/show_bug.cgi?id=124326 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Gitiles VCS browser
Mike, That is not an apples to apples comparison. In your browser open and compare side-by-side: https://git.libreoffice.org/core/+/6a9cf9ba2d37fee9b7c2f190b347e0d7c4a2676a and https://cgit.freedesktop.org/libreoffice/core/commit/?id=6a9cf9ba2d37fee9b7c2f190b347e0d7c4a2676a Do you really like all of the extraneous information? Do you like the missing search bar? Do you like having to scroll down several pages to see the relevant information? Do you like the lack of a search bar? Besides the fact, these are not what the commits look like on our bug trackers. From https://git.libreoffice.org/core/+/bf2f0c913774c90e4c9a65119d0219187bb4498c%5E%21 while the old cgit would be https://cgit.freedesktop.org/libreoffice/core/commit/?id=bf2f0c913774c90e4c9a65119d0219187bb4498c Now try to copy the commit ID from the gitiles and do the same for the cgit URL. Do you really prefer the random symbols appended to the end? I can tell you git does not and will puke if you accidentally include any of them. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 120717] Autoformat of bullets should match a default style
https://bugs.documentfoundation.org/show_bug.cgi?id=120717 --- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> --- Created attachment 150568 --> https://bugs.documentfoundation.org/attachment.cgi?id=150568=edit How it's looks in 6.3 now You can use signs "-" and "*" for create bullet list by AutoCorrect. If you create any from that bullet list then you can see that selectes bullet style "Bullet -" for both. But it's wrong selecting (see screenshot from attach) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104442] [META] OOXML shape (DrawingML and VML) related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104442 Bug 104442 depends on bug 114948, which changed state. Bug 114948 Summary: FILEOPEN: Wrong position of drawing in DOCX import for rl-tb writing mode https://bugs.documentfoundation.org/show_bug.cgi?id=114948 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
