[Libreoffice-bugs] [Bug 124754] FILEOPEN DOCX Hyperlink in text box does not get blue color

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124754

mulla.tasa...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #4 from mulla.tasa...@gmail.com ---
Thank you for reporting the bug.

I can confirm that the bug is present in

Version: 6.2.1.2 (x64)
Build ID: 7bcb35dc3024a62dea0caee87020152d1ee96e71
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: CL


Version: 6.3.0.0.alpha0+ (x64)
Build ID: 91cdf22b88a4f7bec243c8fb187627e766d3294c
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-03-08_00:38:10
Locale: en-US (en_US); UI-Language: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/CppunitTest_vcl_bitmap_render_test.mk vcl/qa

2019-04-15 Thread Tomaž Vajngerl (via logerrit)
 vcl/CppunitTest_vcl_bitmap_render_test.mk|5 +++
 vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx |   34 ++-
 2 files changed, 33 insertions(+), 6 deletions(-)

New commits:
commit d7263d05bdcbe7e219664e198154e31a986c68fc
Author: Tomaž Vajngerl 
AuthorDate: Tue Apr 16 13:10:11 2019 +0900
Commit: Tomaž Vajngerl 
CommitDate: Tue Apr 16 07:20:00 2019 +0200

Test drawing BitmapEx with an alpha channel on a VirtualDevice

This adds a test for drawing a BitmapEx which has an alpha channel
onto a VirtualDevice. Most important is that alpha blending is
done as we expect it (but it is prone to rounding error).

Change-Id: I41a16ca9da98d7a067ada9aafad8c9fc7c6484d5
Reviewed-on: https://gerrit.libreoffice.org/70804
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/vcl/CppunitTest_vcl_bitmap_render_test.mk 
b/vcl/CppunitTest_vcl_bitmap_render_test.mk
index 1d66e6a5aae4..3af9c9fafd51 100644
--- a/vcl/CppunitTest_vcl_bitmap_render_test.mk
+++ b/vcl/CppunitTest_vcl_bitmap_render_test.mk
@@ -13,6 +13,11 @@ $(eval $(call 
gb_CppunitTest_add_exception_objects,vcl_bitmap_render_test, \
 vcl/qa/cppunit/bitmaprender/BitmapRenderTest \
 ))
 
+$(eval $(call gb_CppunitTest_set_include,vcl_bitmap_render_test,\
+$$(INCLUDE) \
+-I$(SRCDIR)/vcl/inc \
+))
+
 $(eval $(call gb_CppunitTest_use_libraries,vcl_bitmap_render_test, \
comphelper \
cppu \
diff --git a/vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx 
b/vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx
index 531494205c14..5fc6c5b7b53c 100644
--- a/vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx
+++ b/vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx
@@ -13,7 +13,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 
 #include 
 #include 
@@ -21,6 +21,9 @@
 #include 
 #include 
 
+#include 
+#include 
+
 static OUString const gaDataUrl = "/vcl/qa/cppunit/bitmaprender/data/";
 
 class BitmapRenderTest : public test::BootstrapFixture
@@ -38,13 +41,13 @@ public:
 
 void testTdf104141();
 void testTdf113918();
-void testDrawBitmap32();
+void testDrawAlphaBitmapEx();
 void testTdf116888();
 
 CPPUNIT_TEST_SUITE(BitmapRenderTest);
 CPPUNIT_TEST(testTdf104141);
 CPPUNIT_TEST(testTdf113918);
-CPPUNIT_TEST(testDrawBitmap32);
+CPPUNIT_TEST(testDrawAlphaBitmapEx);
 CPPUNIT_TEST(testTdf116888);
 
 CPPUNIT_TEST_SUITE_END();
@@ -101,7 +104,7 @@ void BitmapRenderTest::testTdf113918()
 CPPUNIT_ASSERT(aColor.GetGreen() > 100);
 }
 
-void BitmapRenderTest::testDrawBitmap32()
+void BitmapRenderTest::testDrawAlphaBitmapEx()
 {
 ScopedVclPtrInstance pVDev;
 pVDev->SetOutputSizePixel(Size(8, 8));
@@ -117,10 +120,29 @@ void BitmapRenderTest::testDrawBitmap32()
 vcl::PngImageReader aPngReader(aFileStream);
 BitmapEx aBitmapEx;
 aPngReader.read(aBitmapEx);
+
+// Check backend capabilities, if the backend support 32-bit bitmap
+auto pBackendCapabilities = 
ImplGetSVData()->mpDefInst->GetBackendCapabilities();
+if (pBackendCapabilities->mbSupportsBitmap32)
+{
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(32), 
aBitmapEx.GetBitmap().GetBitCount());
+}
+else
+{
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(24), 
aBitmapEx.GetBitmap().GetBitCount());
+CPPUNIT_ASSERT_EQUAL(true, aBitmapEx.IsAlpha());
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(8), 
aBitmapEx.GetAlpha().GetBitCount());
+}
+
+// Check the bitmap has pixels we expect
+CPPUNIT_ASSERT_EQUAL(Color(0xFF, 0x00, 0x00, 0x00), 
aBitmapEx.GetPixelColor(0, 0));
+CPPUNIT_ASSERT_EQUAL(Color(0x00, 0xFF, 0xFF, 0x00), 
aBitmapEx.GetPixelColor(1, 1));
+CPPUNIT_ASSERT_EQUAL(Color(0x7F, 0x00, 0xFF, 0x00), 
aBitmapEx.GetPixelColor(2, 2));
+
 pVDev->DrawBitmapEx(Point(), aBitmapEx);
 
-CPPUNIT_ASSERT_EQUAL(COL_WHITE, pVDev->GetPixel(Point(0, 0)));
-CPPUNIT_ASSERT_EQUAL(COL_YELLOW, pVDev->GetPixel(Point(1, 1)));
+CPPUNIT_ASSERT_EQUAL(Color(0x00, 0xFF, 0xFF, 0xFF), 
pVDev->GetPixel(Point(0, 0)));
+CPPUNIT_ASSERT_EQUAL(Color(0x00, 0xFF, 0xFF, 0x00), 
pVDev->GetPixel(Point(1, 1)));
 
 // sometimes on Windows we get rounding error in blending so let's ignore this 
on Windows for now.
 #if !defined(_WIN32)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124763] New: unable to open *any* document if path includes %xx

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124763

Bug ID: 124763
   Summary: unable to open *any* document if path includes %xx
   Product: LibreOffice
   Version: 6.0.0.0.alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android Viewer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rien...@hotmail.com

If the path contains %3A or any other %xx value, the app is not able to open
any type of document. If you move/copy the document somewhere else, it works

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/CppunitTest_vcl_bitmap_test.mk vcl/qa vcl/source

2019-04-15 Thread Tomaž Vajngerl (via logerrit)
 vcl/CppunitTest_vcl_bitmap_test.mk |1 
 vcl/qa/cppunit/BitmapExTest.cxx|   74 +
 vcl/source/gdi/bitmapex.cxx|   17 +---
 3 files changed, 85 insertions(+), 7 deletions(-)

New commits:
commit 8d65b2bafa1ee000b2722c3c5e6d45a62b74c196
Author: Tomaž Vajngerl 
AuthorDate: Tue Apr 16 12:06:09 2019 +0900
Commit: Tomaž Vajngerl 
CommitDate: Tue Apr 16 06:52:47 2019 +0200

Add test for BitmapEx GetPixelColor for 24+8 and 32bit Bitmaps

Change-Id: I0c1b8447acd6681d8731c35412b90a00741274fa
Reviewed-on: https://gerrit.libreoffice.org/70803
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/vcl/CppunitTest_vcl_bitmap_test.mk 
b/vcl/CppunitTest_vcl_bitmap_test.mk
index bae00152c77d..3bb293cfc66d 100644
--- a/vcl/CppunitTest_vcl_bitmap_test.mk
+++ b/vcl/CppunitTest_vcl_bitmap_test.mk
@@ -11,6 +11,7 @@ $(eval $(call gb_CppunitTest_CppunitTest,vcl_bitmap_test))
 
 $(eval $(call gb_CppunitTest_add_exception_objects,vcl_bitmap_test, \
 vcl/qa/cppunit/BitmapTest \
+vcl/qa/cppunit/BitmapExTest \
 vcl/qa/cppunit/bitmapcolor \
 ))
 
diff --git a/vcl/qa/cppunit/BitmapExTest.cxx b/vcl/qa/cppunit/BitmapExTest.cxx
new file mode 100644
index ..4b45a3e88972
--- /dev/null
+++ b/vcl/qa/cppunit/BitmapExTest.cxx
@@ -0,0 +1,74 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+
+namespace
+{
+class BitmapExTest : public CppUnit::TestFixture
+{
+void testGetPixelColor24_8();
+void testGetPixelColor32();
+
+CPPUNIT_TEST_SUITE(BitmapExTest);
+CPPUNIT_TEST(testGetPixelColor24_8);
+CPPUNIT_TEST(testGetPixelColor32);
+CPPUNIT_TEST_SUITE_END();
+};
+
+void BitmapExTest::testGetPixelColor24_8()
+{
+Bitmap aBitmap(Size(3, 3), 24);
+{
+BitmapScopedWriteAccess pWriteAccess(aBitmap);
+pWriteAccess->Erase(Color(0x00, 0x00, 0xFF, 0x00));
+}
+AlphaMask aMask(Size(3, 3));
+{
+AlphaScopedWriteAccess pWriteAccess(aMask);
+pWriteAccess->Erase(Color(0x00, 0xAA, 0xAA, 0xAA));
+}
+
+BitmapEx aBitmapEx(aBitmap, aMask);
+
+CPPUNIT_ASSERT_EQUAL(Color(0xAA, 0x00, 0xFF, 0x00), 
aBitmapEx.GetPixelColor(0, 0));
+}
+
+void BitmapExTest::testGetPixelColor32()
+{
+// Check backend capabilities and return from the test successfully
+// if the backend doesn't support 32-bit bitmap
+auto pBackendCapabilities = 
ImplGetSVData()->mpDefInst->GetBackendCapabilities();
+if (!pBackendCapabilities->mbSupportsBitmap32)
+return;
+
+Bitmap aBitmap(Size(3, 3), 32);
+{
+BitmapScopedWriteAccess pWriteAccess(aBitmap);
+pWriteAccess->Erase(Color(0xAA, 0x00, 0xFF, 0x00));
+}
+
+BitmapEx aBitmapEx(aBitmap);
+
+CPPUNIT_ASSERT_EQUAL(Color(0xAA, 0x00, 0xFF, 0x00), 
aBitmapEx.GetPixelColor(0, 0));
+}
+
+} // namespace
+
+CPPUNIT_TEST_SUITE_REGISTRATION(BitmapExTest);
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/gdi/bitmapex.cxx b/vcl/source/gdi/bitmapex.cxx
index a6820872578e..3c0df290b217 100644
--- a/vcl/source/gdi/bitmapex.cxx
+++ b/vcl/source/gdi/bitmapex.cxx
@@ -748,17 +748,20 @@ sal_uInt8 BitmapEx::GetTransparency(sal_Int32 nX, 
sal_Int32 nY) const
 Color BitmapEx::GetPixelColor(sal_Int32 nX, sal_Int32 nY) const
 {
 Bitmap::ScopedReadAccess pReadAccess( const_cast(maBitmap) );
-assert( pReadAccess );
+assert(pReadAccess);
 
-Color aColor = pReadAccess->GetColor( nY, nX ).GetColor();
+Color aColor = pReadAccess->GetColor(nY, nX).GetColor();
 
-if( IsAlpha() )
+if (IsAlpha())
 {
-Bitmap::ScopedReadAccess pAlphaReadAccess( 
const_cast(maMask).AcquireReadAccess(), const_cast(maMask) );
-aColor.SetTransparency( pAlphaReadAccess->GetPixel( nY, nX 
).GetIndex() );
+AlphaMask aAlpha = GetAlpha();
+AlphaMask::ScopedReadAccess pAlphaReadAccess(aAlpha);
+aColor.SetTransparency(pAlphaReadAccess->GetPixel(nY, nX).GetIndex());
+}
+else if (maBitmap.GetBitCount() != 32)
+{
+aColor.SetTransparency(0);
 }
-else
-aColor.SetTransparency( 0 );
 return aColor;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124762] New: EDITING: LibreOffice crashes when creating a new table relationship in Base.

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124762

Bug ID: 124762
   Summary: EDITING: LibreOffice crashes when creating a new table
relationship in Base.
   Product: LibreOffice
   Version: 6.1.5.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: overflowsc...@outlook.com

Created attachment 150779
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150779=edit
Screenshot of Error Message

For the past several weeks LibreOffice will crash when I attempt to create a
relationship using the table relationship tool in Base.  I am using LO v.
6.1.52 in Mint 19.1 Cinnamon v. 4.0.10 Linux Kernal 4.15.0-47-generic.  My
system in x86 (AMD64).  I was able to recreate the crash after starting in safe
mode. I have been unable to tie it to any system or application update.  I was
creating a new small HSQLDB database registered in Base.  

Here are the steps to recreate the crash:
1. With the database open, open Tools>Relationships
2. With at least two tables added to the Relationship Editor, choose New
Relationship.
3. Using the table drop down field, choose any table.
4. Crash.

I think the following are important to note:
1. This crash occurs when using either an existing database with existing
tables or creating a new database and new tables.
2. I was able to recreate the crash in LO safe mode.
3. After uninstalling LO and Installing Apache Open Office, I was able to
recreate the crash in AOO.
4. The crash was not reported as a crash in the Mint System Reports.  However,
it was cited as a crash in the LibreOffice Recovery dialogue box (see
attachment).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

RE: libreoffice-6.2.2.2 component context fails to supply service com.sun.star.ui.ModuleUIConfigurationManager

2019-04-15 Thread John Frankish
> > $ rm -rf /home/tc/.config/libreoffice
> > 
> > $ libreoffice
> > Gtk-Message: GtkDialog mapped without a transient parent. This is 
> > discouraged.
> > LibreOffice 6.2 - Fatal Error: The application cannot be started.
> > component context fails to supply service 
> > com.sun.star.ui.ModuleUIConfigurationManager of type 
> > com.sun.star.ui.XModuleUIConfigurationManager2: an error occurred 
> > during file opening
> > 
> The `strace -f libreoffice` output following the `rm -rf ...` would be useful.
> 
Sorry, I should have thought of that.

Strace log attached



libreoffice.log1.tar.xz
Description: libreoffice.log1.tar.xz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 117001] cell not readed correctly - Tab as Separator

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117001

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116833] Unticking "Save preview image with this document" before resetting properties will make modified date appear after save & reload

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116833

--- Comment #16 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116850] The Undo command does not undo parts of the changes made by setting a DataArray from user code.

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116850

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/backendtest vcl/CppunitTest_vcl_backend_test.mk vcl/inc vcl/Library_vcl.mk vcl/Module_vcl.mk vcl/qa

2019-04-15 Thread Tomaž Vajngerl (via logerrit)
 vcl/CppunitTest_vcl_backend_test.mk  |   49 +++
 vcl/Library_vcl.mk   |2 
 vcl/Module_vcl.mk|1 
 vcl/backendtest/VisualBackendTest.cxx|   12 
 vcl/backendtest/outputdevice/common.cxx  |   16 -
 vcl/backendtest/outputdevice/line.cxx|4 
 vcl/backendtest/outputdevice/pixel.cxx   |4 
 vcl/backendtest/outputdevice/polygon.cxx |6 
 vcl/backendtest/outputdevice/polyline.cxx|4 
 vcl/backendtest/outputdevice/polyline_b2d.cxx|   50 +++
 vcl/backendtest/outputdevice/polypolygon.cxx |   10 
 vcl/backendtest/outputdevice/polypolygon_b2d.cxx |   65 
 vcl/backendtest/outputdevice/rectangle.cxx   |8 
 vcl/inc/test/outputdevice.hxx|   33 +-
 vcl/qa/cppunit/BackendTest.cxx   |  364 +++
 15 files changed, 595 insertions(+), 33 deletions(-)

New commits:
commit 3083fe569f96bf0289da1e9d0ef7da15ab22e2f6
Author: Tomaž Vajngerl 
AuthorDate: Mon Apr 15 21:52:46 2019 +0900
Commit: Tomaž Vajngerl 
CommitDate: Tue Apr 16 03:48:28 2019 +0200

Add backend tests as CPPUNIT tests

This (finally) adds backend tests as CPPUNIT tests too. In the
future they'll also be added into LibreOffice directly as a way
to test if the backend is OK, which will be useful especially
for the OpenGL backend, which draw quality depends on the driver.

Currently all the tests are ignored because of the bugs in the
backend, which need to be addressed first and tests then can
be enabled one by one.

The main reason for the test is to identify issues when drawing
is done at a wrong position, which is a very common problem. Also
other types of tests will be added in time, which will have a big
role in the refactoring of VCL that will happen in the future.

Change-Id: I92237d47d49fa0db01b73b8bc39f7a621b65961e
Reviewed-on: https://gerrit.libreoffice.org/70769
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/vcl/CppunitTest_vcl_backend_test.mk 
b/vcl/CppunitTest_vcl_backend_test.mk
new file mode 100644
index ..f146cb6238fe
--- /dev/null
+++ b/vcl/CppunitTest_vcl_backend_test.mk
@@ -0,0 +1,49 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_CppunitTest_CppunitTest,vcl_backend_test))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,vcl_backend_test, \
+vcl/qa/cppunit/BackendTest \
+))
+
+$(eval $(call gb_CppunitTest_use_libraries,vcl_backend_test, \
+   comphelper \
+   cppu \
+   cppuhelper \
+   sal \
+   svt \
+   test \
+   tl \
+   unotest \
+   vcl \
+))
+
+$(eval $(call gb_CppunitTest_use_sdk_api,vcl_backend_test))
+$(eval $(call gb_CppunitTest_use_ure,vcl_backend_test))
+$(eval $(call gb_CppunitTest_use_vcl,vcl_backend_test))
+
+$(eval $(call gb_CppunitTest_use_externals,vcl_backend_test,\
+boost_headers\
+))
+
+$(eval $(call gb_CppunitTest_set_include,vcl_backend_test,\
+$$(INCLUDE) \
+-I$(SRCDIR)/vcl/inc \
+))
+
+$(eval $(call gb_CppunitTest_use_components,vcl_backend_test,\
+configmgr/source/configmgr \
+i18npool/util/i18npool \
+ucb/source/core/ucb1 \
+))
+
+$(eval $(call gb_CppunitTest_use_configuration,vcl_backend_test))
+
+# vim: set noet sw=4 ts=4:
diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index 242af6a996fb..5b7733f6755f 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -446,7 +446,9 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
 vcl/backendtest/outputdevice/pixel \
 vcl/backendtest/outputdevice/polygon \
 vcl/backendtest/outputdevice/polypolygon \
+vcl/backendtest/outputdevice/polypolygon_b2d \
 vcl/backendtest/outputdevice/polyline \
+vcl/backendtest/outputdevice/polyline_b2d \
 vcl/backendtest/outputdevice/rectangle \
 ))
 
diff --git a/vcl/Module_vcl.mk b/vcl/Module_vcl.mk
index 7bfd4bed1cc9..314b54a7d520 100644
--- a/vcl/Module_vcl.mk
+++ b/vcl/Module_vcl.mk
@@ -209,6 +209,7 @@ $(eval $(call gb_Module_add_check_targets,vcl,\
CppunitTest_vcl_apitests \
CppunitTest_vcl_png_test \
CppunitTest_vcl_widget_definition_reader_test \
+   CppunitTest_vcl_backend_test \
 ))
 
 ifneq (,$(filter PDFIUM,$(BUILD_TYPE)))
diff --git a/vcl/backendtest/VisualBackendTest.cxx 
b/vcl/backendtest/VisualBackendTest.cxx
index b06610493073..398e5e2d3643 100644
--- a/vcl/backendtest/VisualBackendTest.cxx
+++ b/vcl/backendtest/VisualBackendTest.cxx
@@ -186,7 +186,7 @@ public:
 aRectangle = aRegions[index++];
 {
 vcl::test::OutputDeviceTestRect aOutDevTest;
-

[Libreoffice-bugs] [Bug 112119] LibreOffice installer doesn't add appropriate entries to TrackPoint TP4TABLE.DAT file

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112119

--- Comment #5 from MartinPC  ---
(In reply to Mike Kaganski from comment #2)

I don't know what handle will appear with this comment, but I used to be
MartinPC. I seem to recall that I stopped being able to log in with my old
credentials at some point. I no longer remember the details, except that the
reason was technical -- a change in hosting? -- not due to any abuse or
impropriety on my part.

> I don't think we can do that.

And this now seems reasonable to me, in light of all the particulars you
listed. 

I will say that it strikes me as highly questionable on the part of OEMs to
*not* make their pointing-stick APIs fully public and to *not* use standard
filenames and file locations for configuration files, within each major OS
family. Do they think every application developer in the world is going to get
in touch with them (and maybe pay them a little something, or cut them a
special wholesale price on bundling?) to get their applications included in the
pre-supplied pointing-stick configuration file, or to be given enough
information to appropriately edit the configuration file at the time the
applications are installed? For the life of me, I can't see a legitimate
rationale for keeping this information private.

(As someone with a modest background in antitrust, I *can* imagine an
*illegitimate* rationale, namely, a combination in restraint of trade to
unfairly promote some applications, e.g., Microsoft Office, and unfairly
disadvantage competing applications, e.g., LibreOffice. The Document Foundation
should ask the European Commission's Directorate General for Competition what
*they* think. I'm a US citizen and antitrust enforcement is all but dead over
here, so the ball is in LibreOffice's court on this one.)

I may have already tried to contact Lenovo and Synaptics about this problem
around the time I first posted this report. It was too long ago and I don't
remember. I can try contacting them again.

At any rate, I REALLY appreciate the effort and thoroughness Mike Kaganski put
into investigating this problem and putting it to rest. THANK YOU. The "bug" is
not LibreOffice's fault; it's the OEMs'.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - sw/inc sw/source

2019-04-15 Thread Michael Stahl (via logerrit)
 sw/inc/txtfld.hxx|2 -
 sw/source/core/doc/DocumentFieldsManager.cxx |4 ++-
 sw/source/core/fields/expfld.cxx |   32 ---
 sw/source/core/txtnode/atrfld.cxx|8 +-
 4 files changed, 29 insertions(+), 17 deletions(-)

New commits:
commit 5ed6c4ade72fc13b475e795769a5049ea9765048
Author: Michael Stahl 
AuthorDate: Mon Apr 15 15:03:14 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Tue Apr 16 00:37:31 2019 +0200

sw: fix recursive SwTextInputField::LockNotifyContentChange

(related: tdf#123968)

The assertion added in commit 742baabbe4d077e1ba913a7989300908f4637ac7
is triggered during ODF import of import fields associated with user
field types; there is a 3 level recursion of the SwUserFieldType for one
variable calling the SwInputFieldType calling SwUserFieldType of another
variable...

Change-Id: I54fc56733c7375cfdb6439b02cf21c4d852c2b4c
Reviewed-on: https://gerrit.libreoffice.org/70768
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 2eb92eaea9ad74b1488246af3c334c3829af36a1)
Reviewed-on: https://gerrit.libreoffice.org/70785
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/sw/inc/txtfld.hxx b/sw/inc/txtfld.hxx
index 11c13edeedc9..38ca9caa6251 100644
--- a/sw/inc/txtfld.hxx
+++ b/sw/inc/txtfld.hxx
@@ -87,7 +87,7 @@ public:
 
 virtual ~SwTextInputField() override;
 
-void LockNotifyContentChange();
+bool LockNotifyContentChange();
 void UnlockNotifyContentChange();
 virtual void NotifyContentChange( SwFormatField& rFormatField ) override;
 
diff --git a/sw/source/core/doc/DocumentFieldsManager.cxx 
b/sw/source/core/doc/DocumentFieldsManager.cxx
index 238e4ba71cf0..264ac6352f64 100644
--- a/sw/source/core/doc/DocumentFieldsManager.cxx
+++ b/sw/source/core/doc/DocumentFieldsManager.cxx
@@ -1258,7 +1258,9 @@ void DocumentFieldsManager::UpdateExpFieldsImpl(
 : dynamic_cast(pTextField));
 if (pInputField)
 {
-pInputField->LockNotifyContentChange();
+bool const tmp = pInputField->LockNotifyContentChange();
+(void) tmp;
+assert(tmp && "should not be locked here?");
 }
 ::comphelper::ScopeGuard g([pInputField]()
 {
diff --git a/sw/source/core/fields/expfld.cxx b/sw/source/core/fields/expfld.cxx
index 6a3bd6efb9e2..c9aceb9d9aaa 100644
--- a/sw/source/core/fields/expfld.cxx
+++ b/sw/source/core/fields/expfld.cxx
@@ -1263,23 +1263,29 @@ void SwInputField::applyFieldContent( const OUString& 
rNewFieldContent )
 if( pUserTyp )
 {
 pUserTyp->SetContent( rNewFieldContent );
-
-// trigger update of the corresponding User Fields and other 
related Input Fields
-if ( GetFormatField() != nullptr )
+if (!pUserTyp->IsModifyLocked())
 {
-SwTextInputField* pTextInputField = dynamic_cast< 
SwTextInputField* >(GetFormatField()->GetTextField());
-if ( pTextInputField != nullptr )
+// trigger update of the corresponding User Fields and other
+// related Input Fields
+bool bUnlock(false);
+if (GetFormatField() != nullptr)
 {
-pTextInputField->LockNotifyContentChange();
+SwTextInputField *const pTextInputField =
+
dynamic_cast(GetFormatField()->GetTextField());
+if (pTextInputField != nullptr)
+{
+bUnlock = pTextInputField->LockNotifyContentChange();
+}
 }
-}
-pUserTyp->UpdateFields();
-if ( GetFormatField() != nullptr )
-{
-SwTextInputField* pTextInputField = dynamic_cast< 
SwTextInputField* >(GetFormatField()->GetTextField());
-if ( pTextInputField != nullptr )
+pUserTyp->UpdateFields();
+if (bUnlock)
 {
-pTextInputField->UnlockNotifyContentChange();
+SwTextInputField *const pTextInputField =
+
dynamic_cast(GetFormatField()->GetTextField());
+if (pTextInputField != nullptr)
+{
+pTextInputField->UnlockNotifyContentChange();
+}
 }
 }
 }
diff --git a/sw/source/core/txtnode/atrfld.cxx 
b/sw/source/core/txtnode/atrfld.cxx
index e32003ae1ba4..96f33d243eaa 100644
--- a/sw/source/core/txtnode/atrfld.cxx
+++ b/sw/source/core/txtnode/atrfld.cxx
@@ -564,10 +564,14 @@ SwTextInputField::~SwTextInputField()
 {
 }
 
-void SwTextInputField::LockNotifyContentChange()
+bool SwTextInputField::LockNotifyContentChange()
 {

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sw/qa sw/source

2019-04-15 Thread Michael Stahl (via logerrit)
 sw/qa/extras/uiwriter/uiwriter2.cxx |   51 
 sw/source/core/undo/undel.cxx   |6 ++--
 sw/source/core/undo/undobj.cxx  |   18 +---
 3 files changed, 63 insertions(+), 12 deletions(-)

New commits:
commit 7bba93a99ebb4250f884a68a50aa1912d96f4ba8
Author: Michael Stahl 
AuthorDate: Fri Apr 12 18:10:49 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Tue Apr 16 00:37:19 2019 +0200

tdf#109376 sw: fix SwUndoDelete with end pos on SwTableNode crash

Commit 6ff263b837831d46d0c215963b70543a9ea5bd2a added a check in
SwUndoSaveContent::DelContentIndex() to avoid moving the anchor of a
FLY_AT_PARA if its new position would be a table node, because
SwFlyAtContentFrame::Modify() requires a SwTextNode to be the anchor.
However, that doesn't actually avoid moving the anchor - later,
SwNodes::RemoveNode() relocates the anchor to the next node regardless
of type!

It's probably better to just delete the fly in the situation when the
end position is a SwTableNode, which fixes the reported crash.

Unfortunately on Redo, the SwUndoDelete::UndoImpl() does not recreate
the nodes correctly, hence the fly then is inserted on the wrong node,
which later crashes again.

The problem is that due to the table node, a dummy SwTextNode is inserted,
which should be at the end of the range, but ends up at the start due to
an erroneous ++aPos.nNode; - the result is that the fly is inserted on
the dummy node and is immediately deleted again, triggering another
assert.  If there is a dummy node, it also doesn't make sense to call
SplitNode().

Yet another problem is that in SwUndoDelete::UndoImpl(), the frames for
the moved text nodes are not created, because the first node is skipped
with the wrong assumption that it already has frames.

Reportedly this started to crash with commit
e07feb9457f2ffb373ae69b73dda290140e4005f, previously it was just wrong.

Reviewed-on: https://gerrit.libreoffice.org/70683
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 80b73dcc06c671a49fbf238be58c1cd086c5c5f9)

Change-Id: I5094638e34c6ed52c836e57691d377b8cd1608f9
Reviewed-on: https://gerrit.libreoffice.org/70764
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx 
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index 2344aa743248..ba6caf3f8222 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -22,6 +22,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 #include 
 
 namespace
@@ -37,6 +39,7 @@ public:
 void testRedlineInHiddenSection();
 void testTdf101534();
 void testTdf54819();
+void testTdf109376();
 void testTdf108687_tabstop();
 void testTdf119571();
 void testTdf119019();
@@ -52,6 +55,7 @@ public:
 CPPUNIT_TEST(testRedlineInHiddenSection);
 CPPUNIT_TEST(testTdf101534);
 CPPUNIT_TEST(testTdf54819);
+CPPUNIT_TEST(testTdf109376);
 CPPUNIT_TEST(testTdf108687_tabstop);
 CPPUNIT_TEST(testTdf119571);
 CPPUNIT_TEST(testTdf119019);
@@ -251,6 +255,53 @@ void SwUiWriterTest2::testTdf54819()
  getProperty(getParagraph(1), 
"ParaStyleName"));
 }
 
+void SwUiWriterTest2::testTdf109376()
+{
+SwDoc* pDoc = createDoc();
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+CPPUNIT_ASSERT(pWrtShell);
+// need 2 paragraphs to get to the bMoveNds case
+pWrtShell->Insert("foo");
+pWrtShell->SplitNode();
+pWrtShell->Insert("bar");
+pWrtShell->SplitNode();
+pWrtShell->StartOfSection(false);
+
+// add AT_PARA fly at 1st to be deleted node
+SwFormatAnchor anchor(RndStdIds::FLY_AT_PARA);
+anchor.SetAnchor(pWrtShell->GetCursor()->GetPoint());
+SfxItemSet flySet(pDoc->GetAttrPool(),
+  svl::Items{});
+flySet.Put(anchor);
+SwFormatFrameSize size(ATT_MIN_SIZE, 1000, 1000);
+flySet.Put(size); // set a size, else we get 1 char per line...
+SwFrameFormat const* pFly = pWrtShell->NewFlyFrame(flySet, 
/*bAnchValid=*/true);
+CPPUNIT_ASSERT(pFly != nullptr);
+
+pWrtShell->SttEndDoc(false);
+SwInsertTableOptions tableOpt(SwInsertTableFlags::DefaultBorder, 0);
+const SwTable& rTable = pWrtShell->InsertTable(tableOpt, 1, 1);
+
+pWrtShell->StartOfSection(false);
+SwPaM pam(*pWrtShell->GetCursor()->GetPoint());
+pam.SetMark();
+pam.GetPoint()->nNode = *rTable.GetTableNode();
+pam.GetPoint()->nContent.Assign(nullptr, 0);
+pam.Exchange(); // same selection direction as in doc compare...
+
+// this used to assert/crash with m_pAnchoredFlys mismatch because the
+// fly was not deleted but its anchor was moved to the SwTableNode
+pDoc->getIDocumentContentOperations().DeleteRange(pam);
+CPPUNIT_ASSERT_EQUAL(size_t(0), 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sfx2/source

2019-04-15 Thread Caolán McNamara (via logerrit)
 sfx2/source/dialog/mgetempl.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit e160a29333af39151bf4ea520e1cc9e184ac3a8f
Author: Caolán McNamara 
AuthorDate: Mon Apr 15 19:59:23 2019 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Tue Apr 16 00:27:45 2019 +0200

tdf#124730 an attempt to remove entry that isn't there

Change-Id: If382f0419c8ea0a3b99c85942c05ee1e5a627e76
Reviewed-on: https://gerrit.libreoffice.org/70796
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/sfx2/source/dialog/mgetempl.cxx b/sfx2/source/dialog/mgetempl.cxx
index 90a66282d5d3..deb5f01f136e 100644
--- a/sfx2/source/dialog/mgetempl.cxx
+++ b/sfx2/source/dialog/mgetempl.cxx
@@ -281,7 +281,9 @@ void SfxManageStyleSheetPage::UpdateName_Impl( 
weld::ComboBox* pBox,
 {
 // it is the current entry, which name was modified
 const bool bSelect = pBox->get_active_text() == aBuf;
-pBox->remove_text(aBuf);
+int nOldIndex = pBox->find_text(aBuf);
+if (nOldIndex != -1)
+pBox->remove(nOldIndex);
 pBox->append_text(rNew);
 
 if (bSelect)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 92543] add ability to use non-native formulas (such as using English formulas in Italian locale)

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=92543

--- Comment #7 from Mike Kaganski  ---
Or alternative suggestion: add a button to left of formula bar, to toggle
English/localized names (=shortcut to the setting from comment 2, which would
allow doing that "on the fly")

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92543] add ability to use non-native formulas (such as using English formulas in Italian locale)

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=92543

--- Comment #6 from Mike Kaganski  ---
I'd say it would be nice to allow both sets of function names (localized *and*
English) simultaneously, without any decorations (i.e., for Russian locale, I's
like to be able to use both "=SUM(1;2;3)" and "=СУММА(1;2;3)") - is there some
problem here? are there localisations that reassign some names that are used
for English function names?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122247] [META] Icon requests

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122247
Bug 122247 depends on bug 124649, which changed state.

Bug 124649 Summary: Menubar: Show icons for the most important items
https://bugs.documentfoundation.org/show_bug.cgi?id=124649

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85811] [META] Main menu bar bugs and enhancements

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=85811
Bug 85811 depends on bug 124649, which changed state.

Bug 124649 Summary: Menubar: Show icons for the most important items
https://bugs.documentfoundation.org/show_bug.cgi?id=124649

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 124649] Menubar: Show icons for the most important items

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124649

andreas_k  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #12 from andreas_k  ---
All menubar files are updated

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: extensions/uiconfig

2019-04-15 Thread andreas kainz (via logerrit)
 extensions/uiconfig/sbibliography/menubar/menubar.xml |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 25a28cee10736e8a72b40b5ab2d11dea8d5254c3
Author: andreas kainz 
AuthorDate: Sun Apr 14 03:41:46 2019 +0200
Commit: andreas_kainz 
CommitDate: Mon Apr 15 22:50:57 2019 +0200

tdf#124649 bibliography menubar: show icons for most importent items

Change-Id: I4cc228db3edcacfb2f0b60c03a7eac0930a288f8
Reviewed-on: https://gerrit.libreoffice.org/70782
Tested-by: Jenkins
Reviewed-by: andreas_kainz 

diff --git a/extensions/uiconfig/sbibliography/menubar/menubar.xml 
b/extensions/uiconfig/sbibliography/menubar/menubar.xml
index b502c396e6ff..898d893a18b9 100644
--- a/extensions/uiconfig/sbibliography/menubar/menubar.xml
+++ b/extensions/uiconfig/sbibliography/menubar/menubar.xml
@@ -39,8 +39,8 @@
 
 
 
-
-
+
+
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 124649] Menubar: Show icons for the most important items

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124649

--- Comment #11 from Commit Notification 
 ---
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/25a28cee10736e8a72b40b5ab2d11dea8d5254c3%5E%21

tdf#124649 bibliography menubar: show icons for most importent items

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 49033] Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20)

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=49033

--- Comment #61 from V Stuart Foote  ---
(In reply to Justin L from comment #60)
> Most of the duplicates here are complaints that Sentence case was added to
> the Shift-F3 sequence in LO 6.1 
> 
> authorheiko tietze 2018-03-26 14:58:23 +0200
> commit84f8e28d092676aad830a9fbae8145a57c6301bc
> bug 116315 - Cycle Case including Sentence case
> Sentence case added at position #2 in the sequence

Well sure--it functioned as intended when only applied via menu action (now at
Format -> Text -> Sentence case). As Mike reported in OP, it was annoying then
that the transliteration did not honor a selection if made.

Addition to the Cycle Case sequence for bug 116315 brought it to a head.

Fundamentally the same issue--it does not honor Selection and expands to affect
entire sentence run. 

And, sidebar have a sneaking feeling that it is not using the ICU libs to
delimit sentence runs at correctly set bounds, kind expect CTL and CJK scripts
are not well handled but I've not dug deeply at them.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103182
Bug 103182 depends on bug 124730, which changed state.

Bug 124730 Summary: Writer Crashes when Creating New Style
https://bugs.documentfoundation.org/show_bug.cgi?id=124730

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107326] [META] Writer style bugs and enhancements

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107326
Bug 107326 depends on bug 124730, which changed state.

Bug 124730 Summary: Writer Crashes when Creating New Style
https://bugs.documentfoundation.org/show_bug.cgi?id=124730

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124736] XLSX Doesn't work filter by Date correct in Pivot table

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124736

Mike Kaganski  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com
   |desktop.org |

--- Comment #5 from Mike Kaganski  ---
https://gerrit.libreoffice.org/70800

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sfx2/source

2019-04-15 Thread Caolán McNamara (via logerrit)
 sfx2/source/dialog/mgetempl.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 32304eb0079079fe263b860573fa010656ab13c9
Author: Caolán McNamara 
AuthorDate: Mon Apr 15 19:59:23 2019 +0100
Commit: Caolán McNamara 
CommitDate: Mon Apr 15 22:24:50 2019 +0200

tdf#124730 an attempt to remove entry that isn't there

Change-Id: If382f0419c8ea0a3b99c85942c05ee1e5a627e76
Reviewed-on: https://gerrit.libreoffice.org/70795
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sfx2/source/dialog/mgetempl.cxx b/sfx2/source/dialog/mgetempl.cxx
index 67eb96db1cd8..836ca6de1164 100644
--- a/sfx2/source/dialog/mgetempl.cxx
+++ b/sfx2/source/dialog/mgetempl.cxx
@@ -282,7 +282,9 @@ void SfxManageStyleSheetPage::UpdateName_Impl( 
weld::ComboBox* pBox,
 {
 // it is the current entry, which name was modified
 const bool bSelect = pBox->get_active_text() == aBuf;
-pBox->remove_text(aBuf);
+int nOldIndex = pBox->find_text(aBuf);
+if (nOldIndex != -1)
+pBox->remove(nOldIndex);
 pBox->append_text(rNew);
 
 if (bSelect)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: cui/uiconfig

2019-04-15 Thread Caolán McNamara (via logerrit)
 cui/uiconfig/ui/gradientpage.ui |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit fad018d60d628355528deb0b0f8b3c396a691d69
Author: Caolán McNamara 
AuthorDate: Mon Apr 15 20:07:20 2019 +0100
Commit: Caolán McNamara 
CommitDate: Mon Apr 15 22:23:54 2019 +0200

ensure gtk creates a default label widget for the MenuButtons

Change-Id: Id8b6f11b4429c8029cacfc26592767625efb9674
Reviewed-on: https://gerrit.libreoffice.org/70798
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/uiconfig/ui/gradientpage.ui b/cui/uiconfig/ui/gradientpage.ui
index ba34727e60bc..75eca7e4194e 100644
--- a/cui/uiconfig/ui/gradientpage.ui
+++ b/cui/uiconfig/ui/gradientpage.ui
@@ -454,6 +454,7 @@
 False
 0
 True
+
 
   
 
@@ -485,6 +486,7 @@
 False
 0
 True
+
 
   
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 124748] PARAGRAPH BORDER: Modification border always adds a new border

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124748

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bz.apache.org/ooo/s
   ||how_bug.cgi?id=17758
URL||http://www.openoffice.org/s
   ||pecs/writer/compatibility/m
   ||erge-borders-and-shadow.sxw

--- Comment #8 from V Stuart Foote  ---
This affects rendering of borders Top/Bottom/Left/Right, but also the Shadow
constructed around the "merged" paragraphs.

The OOo era design document for this feature (see also aoo#17758) is here:

http://www.openoffice.org/specs/writer/compatibility/merge-borders-and-shadow.sxw

Seems it behaves as implemented.

=-ref-=

https://opengrok.libreoffice.org/xref/core/cui/source/tabpages/border.cxx?=4a6dc219#503

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 124748] PARAGRAPH BORDER: Modification border always adds a new border

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124748

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bz.apache.org/ooo/s
   ||how_bug.cgi?id=17758
URL||http://www.openoffice.org/s
   ||pecs/writer/compatibility/m
   ||erge-borders-and-shadow.sxw

--- Comment #8 from V Stuart Foote  ---
This affects rendering of borders Top/Bottom/Left/Right, but also the Shadow
constructed around the "merged" paragraphs.

The OOo era design document for this feature (see also aoo#17758) is here:

http://www.openoffice.org/specs/writer/compatibility/merge-borders-and-shadow.sxw

Seems it behaves as implemented.

=-ref-=

https://opengrok.libreoffice.org/xref/core/cui/source/tabpages/border.cxx?=4a6dc219#503

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124761] Crash in: chartcontrollerlo.dll Adding text box to chart causes crash (EDITING)

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124761

kni...@mailbox.org changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124761] Crash in: chartcontrollerlo.dll Adding text box to chart causes crash (EDITING)

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124761

kni...@mailbox.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124761] New: Crash in: chartcontrollerlo.dll Adding text box to chart causes crash (EDITING)

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124761

Bug ID: 124761
   Summary: Crash in: chartcontrollerlo.dll Adding text box to
chart causes crash (EDITING)
   Product: LibreOffice
   Version: 6.2.2.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kni...@mailbox.org

Created attachment 150778
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150778=edit
GIF to illustrate the reproduction steps

This bug was filed from the crash reporting server and is
br-7607f140-a790-4a0d-a944-230fa9964703.
=
Adding a text box from the drawing toolbox while being in the editing mode of a
chart causes LibreOffice to crash. This happens with other tools as well. The
purpose was to add an additional remark and the advice found recommended the
drawing toolbox
(https://ask.libreoffice.org/en/question/73927/is-it-possible-to-add-text-to-a-chart-in-calc/).

Steps to reproduce:
1) Create a chart.
2) Make sure "Drawing" is enabled in Toolbars.
3) Double-click on chart and select the text box.
4) Draw a box into the chart.

A GIF was attached to illustrate the crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124734] 'Format' windows in writer and calc on Ubuntu-Linux too wide

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124734

--- Comment #7 from Caolán McNamara  ---
Typically when this happens there is one combobox or *something* in one of the
pages that is abnormally wide which forces the whole dialog wide and we need to
identify which element has to have its width forcibly narrowed from its desired
width.

If that's what's happening here then it seems to be happening on another tab
page of the dialog shown in the screenshot.

Is this happening in new blank documents ? Or preexisting documents which might
have a long style names or long customized color name ? If you click on each
tab, is there any page which has a combobox or listbox which has a super long
string in it ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85976] Feature Request - Add "Remove Duplicates" button to LibreOffice / filtering showing duplicates is too complicated

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=85976

V Stuart Foote  changed:

   What|Removed |Added

 CC||openfo...@davidpbrown.co.uk

--- Comment #14 from V Stuart Foote  ---
*** Bug 124758 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124758] Advanced filter is not intuitive for simple removal of duplicates

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124758

V Stuart Foote  changed:

   What|Removed |Added

 Resolution|WONTFIX |DUPLICATE

--- Comment #2 from V Stuart Foote  ---
Seems this was open as an enhancement already...

*** This bug has been marked as a duplicate of bug 85976 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89102] PIVOTTABLE wont work if heading ends with asterisk

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89102

--- Comment #9 from HFM  ---
Bug still present in:

Version: 6.2.2.2
Build ID: 1:6.2.2-0ubuntu0.18.04.1~lo1
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: pt-BR (pt_BR.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 49033] Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20)

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=49033

--- Comment #60 from Justin L  ---
Most of the duplicates here are complaints that Sentence case was added to the
Shift-F3 sequence in LO 6.1 

author  heiko tietze 2018-03-26 14:58:23 +0200
commit  84f8e28d092676aad830a9fbae8145a57c6301bc
bug 116315 - Cycle Case including Sentence case
Sentence case added at position #2 in the sequence

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: dbaccess/uiconfig

2019-04-15 Thread andreas kainz (via logerrit)
 dbaccess/uiconfig/dbapp/menubar/menubar.xml  |   29 +++
 dbaccess/uiconfig/dbquery/menubar/menubar.xml|   17 +++--
 dbaccess/uiconfig/dbrelation/menubar/menubar.xml |   24 ++-
 dbaccess/uiconfig/dbtable/menubar/menubar.xml|   21 
 dbaccess/uiconfig/dbtdata/menubar/menubar.xml|   21 
 5 files changed, 59 insertions(+), 53 deletions(-)

New commits:
commit 4d2b9097494a1ba1b018f62f2e74b6ec41bb6137
Author: andreas kainz 
AuthorDate: Sun Apr 14 04:06:08 2019 +0200
Commit: andreas_kainz 
CommitDate: Mon Apr 15 21:20:06 2019 +0200

tdf#14649 dbaccess menubar: show icons for most importent items

Change-Id: I6eb682acd0616162837809a9f89dfb2c66efb505
Reviewed-on: https://gerrit.libreoffice.org/70787
Tested-by: Jenkins
Reviewed-by: andreas_kainz 

diff --git a/dbaccess/uiconfig/dbapp/menubar/menubar.xml 
b/dbaccess/uiconfig/dbapp/menubar/menubar.xml
index a394672faee5..9b254110b9af 100644
--- a/dbaccess/uiconfig/dbapp/menubar/menubar.xml
+++ b/dbaccess/uiconfig/dbapp/menubar/menubar.xml
@@ -24,23 +24,23 @@
   
   
   
-  
+  
   
   
   
-  
+  
   
-  
-  
-  
+  
+  
+  
   
   
   
 
-  
-  
+  
+  
   
-  
+  
 
   
   
@@ -56,7 +56,7 @@
   
   
   
-  
+  
   
   
   
@@ -86,8 +86,8 @@
   
   
   
-  
-  
+  
+  
   
   
   
@@ -128,11 +128,12 @@
   
   
   
+  
+  
 
   
-  
-  
-  
+  
+  
   
 
   
diff --git a/dbaccess/uiconfig/dbquery/menubar/menubar.xml 
b/dbaccess/uiconfig/dbquery/menubar/menubar.xml
index d6f562cef876..a7c26ead641f 100644
--- a/dbaccess/uiconfig/dbquery/menubar/menubar.xml
+++ b/dbaccess/uiconfig/dbquery/menubar/menubar.xml
@@ -23,15 +23,15 @@
   
   
   
-  
+  
   
   
   
-  
+  
   
-  
-  
-  
+  
+  
+  
   
   
 
@@ -82,11 +82,12 @@
   
   
   
+  
+  
 
   
-  
-  
-  
+  
+  
   
 
   
diff --git a/dbaccess/uiconfig/dbrelation/menubar/menubar.xml 
b/dbaccess/uiconfig/dbrelation/menubar/menubar.xml
index f0c1ab3776ea..7753a9d57b7d 100644
--- a/dbaccess/uiconfig/dbrelation/menubar/menubar.xml
+++ b/dbaccess/uiconfig/dbrelation/menubar/menubar.xml
@@ -24,14 +24,14 @@
   
   
   
-  
+  
   
   
-  
+  
   
-  
-  
-  
+  
+  
+  
   
   
 
@@ -44,8 +44,8 @@
   
   
 
-  
-  
+  
+  
 
   
   
@@ -59,17 +59,19 @@
   
 
   
-  
+  2
   
   
   
   
   
+  
+  
+  
 
   
-  
-  
-  
+  
+  
   
 
   
diff --git a/dbaccess/uiconfig/dbtable/menubar/menubar.xml 
b/dbaccess/uiconfig/dbtable/menubar/menubar.xml
index d68d6705cd7c..7a255d12214b 100644
--- a/dbaccess/uiconfig/dbtable/menubar/menubar.xml
+++ b/dbaccess/uiconfig/dbtable/menubar/menubar.xml
@@ -24,15 +24,15 @@
   
   
   
-  
+  
   
   
   
-  
+  
   
-  
-  
-  
+  
+  
+  
   
   
 
@@ -49,8 +49,8 @@
   
   
 
-  
-  
+  
+  
 
   
   
@@ -66,11 +66,12 @@
   
   
   
+  
+  
 
   
-  
-  
-  
+  
+  
   
 
   
diff --git a/dbaccess/uiconfig/dbtdata/menubar/menubar.xml 
b/dbaccess/uiconfig/dbtdata/menubar/menubar.xml
index e42874e2762c..cdd892b5baa5 100644
--- a/dbaccess/uiconfig/dbtdata/menubar/menubar.xml
+++ b/dbaccess/uiconfig/dbtdata/menubar/menubar.xml
@@ -24,15 +24,15 @@
   
   
   
-  
+  
   
   
   
-  
+  
   
-  
-  
-  
+  
+  
+  
   
   
 
@@ -56,8 +56,8 @@
   
   
 
-  
-  
+  
+  
 
   
   
@@ -91,11 +91,12 @@
   
   
   
+  
+  
 
   
-  
-  
-  
+  
+  
   
 
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 124649] Menubar: Show icons for the most important items

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124649

--- Comment #10 from Commit Notification 
 ---
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/683d71b35331868e43447c5209b07f25fdbe1186%5E%21

tdf#124649 framework menubar: show icons for most importent items

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 124649] Menubar: Show icons for the most important items

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124649

--- Comment #8 from Commit Notification 
 ---
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/48215d7be1e2f94711e947ffb2922e6dd791d062%5E%21

tdf#124649 sc menubar: show icons for most importent items

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

--- Comment #9 from Commit Notification 
 ---
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/7188a4d8b2ace8b428968f3ff73a3d74cd4a736d%5E%21

tdf#124649 chart2 menubar: show icons for most importent items

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 124649] Menubar: Show icons for the most important items

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124649

--- Comment #8 from Commit Notification 
 ---
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/48215d7be1e2f94711e947ffb2922e6dd791d062%5E%21

tdf#124649 sc menubar: show icons for most importent items

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: sw/uiconfig

2019-04-15 Thread andreas kainz (via logerrit)
 sw/uiconfig/sglobal/menubar/menubar.xml |2 +-
 sw/uiconfig/swriter/menubar/menubar.xml |2 +-
 sw/uiconfig/swxform/menubar/menubar.xml |2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit dbbf2ef3640c13704ed0f1d3d8b0aae609975cbf
Author: andreas kainz 
AuthorDate: Sun Apr 14 04:29:56 2019 +0200
Commit: andreas_kainz 
CommitDate: Mon Apr 15 21:13:35 2019 +0200

tdf#124665 ShadowCursor moved to Edit Mode

Change-Id: I4b6f5ea60cebf465cd3c47909f10aae9281d63c0
Reviewed-on: https://gerrit.libreoffice.org/70789
Tested-by: Jenkins
Reviewed-by: andreas_kainz 

diff --git a/sw/uiconfig/sglobal/menubar/menubar.xml 
b/sw/uiconfig/sglobal/menubar/menubar.xml
index c81d40f1bcc6..b139caf3829e 100644
--- a/sw/uiconfig/sglobal/menubar/menubar.xml
+++ b/sw/uiconfig/sglobal/menubar/menubar.xml
@@ -116,7 +116,6 @@
 
   
   
-  
   
   
   
@@ -165,6 +164,7 @@
   
   
   
+  
   
 
   
diff --git a/sw/uiconfig/swriter/menubar/menubar.xml 
b/sw/uiconfig/swriter/menubar/menubar.xml
index fd9c9f85927d..d077ffa776af 100644
--- a/sw/uiconfig/swriter/menubar/menubar.xml
+++ b/sw/uiconfig/swriter/menubar/menubar.xml
@@ -116,7 +116,6 @@
 
   
   
-  
   
   
   
@@ -165,6 +164,7 @@
   
   
   
+  
   
 
   
diff --git a/sw/uiconfig/swxform/menubar/menubar.xml 
b/sw/uiconfig/swxform/menubar/menubar.xml
index 88d877f250ae..a8009a00bc86 100644
--- a/sw/uiconfig/swxform/menubar/menubar.xml
+++ b/sw/uiconfig/swxform/menubar/menubar.xml
@@ -116,7 +116,6 @@
 
   
   
-  
   
   
   
@@ -165,6 +164,7 @@
   
   
   
+  
   
 
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: framework/uiconfig

2019-04-15 Thread andreas kainz (via logerrit)
 framework/uiconfig/startmodule/menubar/menubar.xml |   14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

New commits:
commit 683d71b35331868e43447c5209b07f25fdbe1186
Author: andreas kainz 
AuthorDate: Sun Apr 14 03:59:09 2019 +0200
Commit: andreas_kainz 
CommitDate: Mon Apr 15 21:12:43 2019 +0200

tdf#124649 framework menubar: show icons for most importent items

Change-Id: I2d94a7cf6fbaea952f9d802307202648587189f3
Reviewed-on: https://gerrit.libreoffice.org/70784
Tested-by: Jenkins
Reviewed-by: andreas_kainz 

diff --git a/framework/uiconfig/startmodule/menubar/menubar.xml 
b/framework/uiconfig/startmodule/menubar/menubar.xml
index 70d49f7e4359..96ac15d10f81 100644
--- a/framework/uiconfig/startmodule/menubar/menubar.xml
+++ b/framework/uiconfig/startmodule/menubar/menubar.xml
@@ -21,20 +21,20 @@
 
 
 
-
+
 
 
-
+
 
 
-
-
+
+
 
 
 
 
 
-
+
 
 
 
@@ -51,8 +51,8 @@
 
 
 
-
-
+
+
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: chart2/uiconfig

2019-04-15 Thread andreas kainz (via logerrit)
 chart2/uiconfig/menubar/menubar.xml |   18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

New commits:
commit 7188a4d8b2ace8b428968f3ff73a3d74cd4a736d
Author: andreas kainz 
AuthorDate: Sun Apr 14 03:35:10 2019 +0200
Commit: andreas_kainz 
CommitDate: Mon Apr 15 21:11:41 2019 +0200

tdf#124649 chart2 menubar: show icons for most importent items

Change-Id: I339c5a0777477c16ee85ace91e3611af40c06e31
Reviewed-on: https://gerrit.libreoffice.org/70781
Tested-by: Jenkins
Reviewed-by: andreas_kainz 

diff --git a/chart2/uiconfig/menubar/menubar.xml 
b/chart2/uiconfig/menubar/menubar.xml
index 7172dcf373f5..105d8c4fae7c 100644
--- a/chart2/uiconfig/menubar/menubar.xml
+++ b/chart2/uiconfig/menubar/menubar.xml
@@ -24,7 +24,7 @@
   
   
   
-  
+  
   
   
   
@@ -45,7 +45,7 @@
 
   
   
-  
+  
   
   
 
@@ -110,16 +110,16 @@
 
   
   
-
-
-
+
+
+
   
 
 
 
   
-  
-  
+  
+  
   
 
   
@@ -141,8 +141,8 @@
   
 
   
-  
-  
+  
+  
   
 
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg sc/uiconfig

2019-04-15 Thread andreas kainz (via logerrit)
 icon-themes/colibre/cmd/lc_deletecell.png  
|binary
 icon-themes/colibre/cmd/sc_accent1cellstyles.png   
|binary
 icon-themes/colibre/cmd/sc_accent2cellstyles.png   
|binary
 icon-themes/colibre/cmd/sc_accent3cellstyles.png   
|binary
 icon-themes/colibre/cmd/sc_deletecell.png  
|binary
 icon-themes/colibre/cmd/sc_errorcellstyles.png 
|binary
 icon-themes/colibre/cmd/sc_warningcellstyles.png   
|binary
 icon-themes/colibre/links.txt  
|5 
 icon-themes/colibre_svg/cmd/lc_deletecell.svg  
|   23 +
 icon-themes/colibre_svg/cmd/sc_accent1cellstyles.svg   
|   13 
 icon-themes/colibre_svg/cmd/sc_accent2cellstyles.svg   
|   13 
 icon-themes/colibre_svg/cmd/sc_accent3cellstyles.svg   
|   13 
 icon-themes/colibre_svg/cmd/sc_deletecell.svg  
|   17 
 icon-themes/colibre_svg/cmd/sc_errorcellstyles.svg 
|   10 
 icon-themes/colibre_svg/cmd/sc_flowchartshapes.flowchart-sequential-access.svg 
|2 
 icon-themes/colibre_svg/cmd/sc_warningcellstyles.svg   
|   10 
 sc/uiconfig/scalc/menubar/menubar.xml  
|  208 --
 17 files changed, 203 insertions(+), 111 deletions(-)

New commits:
commit 48215d7be1e2f94711e947ffb2922e6dd791d062
Author: andreas kainz 
AuthorDate: Sun Apr 14 03:28:45 2019 +0200
Commit: andreas_kainz 
CommitDate: Mon Apr 15 21:11:23 2019 +0200

tdf#124649 sc menubar: show icons for most importent items

Change-Id: I9e31f78a3d2d811088162f9dbac7fc92abf12c19
Reviewed-on: https://gerrit.libreoffice.org/70780
Tested-by: Jenkins
Reviewed-by: andreas_kainz 

diff --git a/icon-themes/colibre/cmd/lc_deletecell.png 
b/icon-themes/colibre/cmd/lc_deletecell.png
new file mode 100644
index ..fec89f69e6cb
Binary files /dev/null and b/icon-themes/colibre/cmd/lc_deletecell.png differ
diff --git a/icon-themes/colibre/cmd/sc_accent1cellstyles.png 
b/icon-themes/colibre/cmd/sc_accent1cellstyles.png
new file mode 100644
index ..1e65b9194d7f
Binary files /dev/null and b/icon-themes/colibre/cmd/sc_accent1cellstyles.png 
differ
diff --git a/icon-themes/colibre/cmd/sc_accent2cellstyles.png 
b/icon-themes/colibre/cmd/sc_accent2cellstyles.png
new file mode 100644
index ..cbaaecca359f
Binary files /dev/null and b/icon-themes/colibre/cmd/sc_accent2cellstyles.png 
differ
diff --git a/icon-themes/colibre/cmd/sc_accent3cellstyles.png 
b/icon-themes/colibre/cmd/sc_accent3cellstyles.png
new file mode 100644
index ..809ddb2555d9
Binary files /dev/null and b/icon-themes/colibre/cmd/sc_accent3cellstyles.png 
differ
diff --git a/icon-themes/colibre/cmd/sc_deletecell.png 
b/icon-themes/colibre/cmd/sc_deletecell.png
new file mode 100644
index ..ec3f2bb51564
Binary files /dev/null and b/icon-themes/colibre/cmd/sc_deletecell.png differ
diff --git a/icon-themes/colibre/cmd/sc_errorcellstyles.png 
b/icon-themes/colibre/cmd/sc_errorcellstyles.png
new file mode 100644
index ..397d6e2dafc6
Binary files /dev/null and b/icon-themes/colibre/cmd/sc_errorcellstyles.png 
differ
diff --git a/icon-themes/colibre/cmd/sc_warningcellstyles.png 
b/icon-themes/colibre/cmd/sc_warningcellstyles.png
new file mode 100644
index ..2586b82cb741
Binary files /dev/null and b/icon-themes/colibre/cmd/sc_warningcellstyles.png 
differ
diff --git a/icon-themes/colibre/links.txt b/icon-themes/colibre/links.txt
index ea76a4a2a1ba..421c508b0291 100644
--- a/icon-themes/colibre/links.txt
+++ b/icon-themes/colibre/links.txt
@@ -356,7 +356,6 @@ cmd/lc_dbreportdelete.png cmd/lc_delete.png
 cmd/lc_dbquerydelete.png cmd/lc_delete.png
 cmd/lc_dbformdelete.png cmd/lc_delete.png
 cmd/lc_dbclearquery.png cmd/lc_delete.png
-cmd/lc_deletecell.png cmd/lc_delete.png
 cmd/sc_deleteprintarea.png cmd/sc_delete.png
 cmd/sc_deleterecord.png cmd/sc_delete.png
 cmd/sc_dbtabledelete.png cmd/sc_delete.png
@@ -364,7 +363,6 @@ cmd/sc_dbreportdelete.png cmd/sc_delete.png
 cmd/sc_dbquerydelete.png cmd/sc_delete.png
 cmd/sc_dbformdelete.png cmd/sc_delete.png
 cmd/sc_dbclearquery.png cmd/sc_delete.png
-cmd/sc_deletecell.png cmd/sc_delete.png
 
 # Folder
 cmd/lc_dbtableopen.png cmd/lc_open.png
@@ -625,8 +623,6 @@ cmd/sc_linespacing.png cmd/sc_spacepara15.png
 # calc menu entries
 cmd/lc_functionbox.png cmd/lc_dbviewfunctions.png
 cmd/sc_datapilotmenu.png cmd/sc_datadatapilotrun.png
-cmd/sc_insertrowsmenu.png cmd/sc_insertrows.png
-cmd/sc_insertcolumnsmenu.png cmd/sc_insertcolumns.png
 cmd/sc_functiondialog.png cmd/sc_dbviewfunctions.png
 cmd/lc_functiondialog.png cmd/lc_dbviewfunctions.png
 

[Libreoffice-bugs] [Bug 124730] Writer Crashes when Creating New Style

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124730

Caolán McNamara  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |
 Status|UNCONFIRMED |ASSIGNED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 49033] Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20)

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=49033

V Stuart Foote  changed:

   What|Removed |Added

 CC||danilog...@gmail.com

--- Comment #59 from V Stuart Foote  ---
*** Bug 124760 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: desktop/source

2019-04-15 Thread Michael Meeks (via logerrit)
 desktop/source/lib/init.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 110ee112e17091cc8ca9b16ac73d4bfae286c91c
Author: Michael Meeks 
AuthorDate: Mon Apr 15 13:16:53 2019 +0100
Commit: Michael Meeks 
CommitDate: Mon Apr 15 20:54:55 2019 +0200

lok: rename - emitted as events not on stdout now.

Change-Id: Ie57c34eff1d917fada4e10e4b88b27adf8a34d1a
Reviewed-on: https://gerrit.libreoffice.org/70788
Tested-by: Jenkins
Reviewed-by: Michael Meeks 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index e6feceb595b2..327be8ab2bdd 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -4531,7 +4531,7 @@ static int lo_initialize(LibreOfficeKit* pThis, const 
char* pAppPath, const char
 
 // Did we do a pre-initialize
 static bool bPreInited = false;
-static bool bProfileZones = getenv("SAL_PROFILEZONE_STDOUT") != nullptr;
+static bool bProfileZones = getenv("SAL_PROFILEZONE_EVENTS") != nullptr;
 
 // What stage are we at ?
 if (pThis == nullptr)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124760] problemas ao usar o atalho shift+F3

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124760

V Stuart Foote  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||vstuart.fo...@utsa.edu
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from V Stuart Foote  ---
The Shift+F3 "cycle case" was modified to also include the "Sentence case"
format. Unfortunately "Sentence case" was designed to affect the full sentence
run.

Prior to that change, the "cycle case" would affect the word with the text
cursor. Or those words included in a text selection. That is still the
case--except that as the "Sentence case" is processed selection expands to the
full sentence bounds.

See duplicate bug 49033 for eventual resolution.

*** This bug has been marked as a duplicate of bug 49033 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2019-04-15 Thread Henry Castro (via logerrit)
 sw/source/uibase/uiview/viewdraw.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit 304425807e9172ac7a85d5f17fceba2735218409
Author: Henry Castro 
AuthorDate: Tue Apr 9 16:33:40 2019 -0400
Commit: Henry Castro 
CommitDate: Mon Apr 15 20:49:38 2019 +0200

sw lok: fix "Cannot deselect the shape after inserting the first in a...

document"

Change-Id: I976318fe299306b65190b4f5ae0ed2565830c6f7
Reviewed-on: https://gerrit.libreoffice.org/70475
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky 
Reviewed-by: Henry Castro 

diff --git a/sw/source/uibase/uiview/viewdraw.cxx 
b/sw/source/uibase/uiview/viewdraw.cxx
index 00b722710caa..05ac5537e2cc 100644
--- a/sw/source/uibase/uiview/viewdraw.cxx
+++ b/sw/source/uibase/uiview/viewdraw.cxx
@@ -347,6 +347,10 @@ void SwView::ExecDraw(SfxRequest& rReq)
 {
 m_pWrtShell->GotoObj(true);
 }
+else if (dynamic_cast(pTempFuncPtr))
+{
+pTempFuncPtr->CreateDefaultObject();
+}
 else
 {
 pTempFuncPtr->CreateDefaultObject();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105706] Update service does not show updates when detailed OS versions are sent.

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105706

--- Comment #8 from Georg Schölly  ---
The server script has not been changed so the bug still exists (check.php).

If someone could point me to the source code of
http://update.libreoffice.org/check.php I could try to fix it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124758] Advanced filter is not intuitive for simple removal of duplicates

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124758

V Stuart Foote  changed:

   What|Removed |Added

  Component|LibreOffice |Calc
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX
   Severity|normal  |enhancement
 CC||vstuart.fo...@utsa.edu

--- Comment #1 from V Stuart Foote  ---
Hmm, nothing here actionable. Guess OP is looking for an enhancement...

Otherwise it *is* an RTM issue.

https://ask.libreoffice.org/en/question/53569/delete-duplicates-in-calc/

or older OOo era

https://forum.openoffice.org/en/forum/viewtopic.php?f=9=5379#p35891
https://wiki.openoffice.org/wiki/Documentation/How_Tos/Removing_Duplicate_Rows

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124760] problemas ao usar o atalho shift+F3

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124760

Danilo  changed:

   What|Removed |Added

 OS|All |Windows (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124760] New: problemas ao usar o atalho shift+F3

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124760

Bug ID: 124760
   Summary: problemas ao usar o atalho shift+F3
   Product: LibreOffice
   Version: 6.2.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: danilog...@gmail.com

Description:
quando utilizo o atalho shift+F3 se for usado na mesma frase ele desfaz toda a
alteração já feita, 

Steps to Reproduce:
1.selecionar uma parte de uma frase 
2.alterar com o shift+F3
3.selecionar outra parte na mesma frase
4.alterar com o shift+F3

Actual Results:
desfez a alteração feita anteriormente

Expected Results:
deveria fazer todas as alterações solicitada pelo o atalho shift+F3 e não
desfazer as já feitas


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
na versão 5.4 não tinha esse problema de desfazer as alterações, funcionava
normalmente

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124663] FIREBIRD - Crash in: com::sun::star::uno::WeakReferenceHelper::get

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124663

--- Comment #15 from Mike Sapsard  ---
Removed and reinstalled LO6222 Fresh DEBS.

Then created simple single table as per the screenshots in the zip file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124663] FIREBIRD - Crash in: com::sun::star::uno::WeakReferenceHelper::get

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124663

--- Comment #14 from Mike Sapsard  ---
Created attachment 150777
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150777=edit
Zip file of screen shots

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123746] Allow VLOOKUP function to work on the left specifying a negative index

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123746

--- Comment #4 from gmoll...@us.es ---
Use ; and not , in Spain and other countries.
In Spain: =BUSCARV(2;ELEGIR({2;1};a1:a4;b1:b4);2;FALSO).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124737] LibreOffice Writer freezes when I try to open Tools>options

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124737

--- Comment #2 from Paul Patton  ---
The only circumstance I have observed the freezing problem is after selecting
'options' in the 'Tools'  menu.  I haven't searched extensively for other
circumstances that produce this problem, though I also haven't noticed any
other circumstances that produce the problem in routine use of LibreOffice
Writer.  Were you able to reproduce the problem from my description?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124759] New: First row missing from Base query results.

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124759

Bug ID: 124759
   Summary: First row missing from Base query results.
   Product: LibreOffice
   Version: 6.2.2.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kovacs.zsolt.san...@gmail.com

Description:
First row missing from Base query results.

Steps to Reproduce:
1.Write query
2.Run
3.Missing first row
4.Refresh
5.Wow, happy

Actual Results:
Missing first row.

Expected Results:
With refresh is good.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
[Information automatically included from LibreOffice]
Locale: hu
Module: QueryDesign
[Information guessed from browser]
OS: Windows 10
OS is 64bit: yes

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123746] Allow VLOOKUP function to work on the left specifying a negative index

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123746

--- Comment #3 from gmoll...@us.es ---
The solution is:
You can use for search: =VLOOKUP(2,CHOICE({2,1},a1:a4,b1:b4),2,FALSE) and you
obtain the result "b".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108827] [META] Calc functions bugs and enhancements

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108827
Bug 108827 depends on bug 124728, which changed state.

Bug 124728 Summary: Function CHOOSE doesn't allow to create matrix
https://bugs.documentfoundation.org/show_bug.cgi?id=124728

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124728] Function CHOOSE doesn't allow to create matrix

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124728

--- Comment #5 from gmoll...@us.es ---
Thanks, I did not know that {2\1} in other spreadsheets is {2;1} or {2,1} in
Calc.
All right.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124728] Function CHOOSE doesn't allow to create matrix

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124728

gmoll...@us.es changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124728] Function CHOOSE doesn't allow to create matrix

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124728

--- Comment #4 from Oliver Brinzing  ---
Created attachment 150776
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150776=edit
vlookup choose example

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 124748] PARAGRAPH BORDER: Modification border always adds a new border

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124748

--- Comment #7 from Dieter Praas  ---
(In reply to V Stuart Foote from comment #6)
> It is not a new border. Rather IIUC the border "merge" will only occur if
> the direct formatting, or style, of the Paragraph border's match. Change the
> border of the first and the second will show--but the third will not as it
> matches the second.

But if you change the border style you are in conflict with "keep with next
paragraph" rule. I'm confinced, that the actual result is not the result
"normal" users would expect.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 124748] PARAGRAPH BORDER: Modification border always adds a new border

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124748

--- Comment #7 from Dieter Praas  ---
(In reply to V Stuart Foote from comment #6)
> It is not a new border. Rather IIUC the border "merge" will only occur if
> the direct formatting, or style, of the Paragraph border's match. Change the
> border of the first and the second will show--but the third will not as it
> matches the second.

But if you change the border style you are in conflict with "keep with next
paragraph" rule. I'm confinced, that the actual result is not the result
"normal" users would expect.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123636] FILEOPEN DOCX with frame content on multiple pages is condensed to single page

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123636

--- Comment #4 from Justin L  ---
(In reply to Aron Budea from comment #0)
> interestingly text can only be added to the text frames.
This seems to be related to line spacing of zero.  In Word, going into the
paragraph properties forces a minimum of .06 in order to "OK"  Clearing the
paragraph style "fixes" the read-only aspect, showing a ---page break---.

> When opened in Writer, the frames are all on the same page.
A lost page-break, and it is not because of bRemove...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124758] New: Advanced filter is not intuitive for simple removal of duplicates

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124758

Bug ID: 124758
   Summary: Advanced filter is not intuitive for simple removal of
duplicates
   Product: LibreOffice
   Version: 6.0.7.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: openfo...@davidpbrown.co.uk

The simple removal of duplicates, should be trivial.

The Advanced filter than tempts that, is unusable the [Read Filter Criteria] is
a confusing element and unworkable in all the attempts I've made to make sense
of it. No, I don't want to read a manual just to action a simple data fix. It's
easier to export and sort+uniq on the commandline that within the product. Very
odd design for this.

Expecting this still affects later versions too.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 124748] PARAGRAPH BORDER: Modification border always adds a new border

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124748

--- Comment #6 from V Stuart Foote  ---
(In reply to Dieter Praas from comment #5)
> (In reply to V Stuart Foote from comment #4)
> > P15, P12, P11 all have border-top set to same border and color. They also
> > have the "Merge with next paragraph" value set--meaning the first
> > "border-top" will show. Subsequent do not.
> 
> I understand, but I don't understand, why a new border appears, if you try
> to change the top border. So for me it looks like, that in this case "keep
> with next paragraph" rule is ignored, although this option is enabled.
> 
> So for me it would be at least an enhancement to improve the relationship
> between paragraph border and "keep with next paragraph" option. I change the
> status back to UNCONFIRMED. Perhaps we can collect some other opinions.

It is not a new border. Rather IIUC the border "merge" will only occur if the
direct formatting, or style, of the Paragraph border's match. Change the border
of the first and the second will show--but the third will not as it matches the
second.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 124748] PARAGRAPH BORDER: Modification border always adds a new border

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124748

--- Comment #6 from V Stuart Foote  ---
(In reply to Dieter Praas from comment #5)
> (In reply to V Stuart Foote from comment #4)
> > P15, P12, P11 all have border-top set to same border and color. They also
> > have the "Merge with next paragraph" value set--meaning the first
> > "border-top" will show. Subsequent do not.
> 
> I understand, but I don't understand, why a new border appears, if you try
> to change the top border. So for me it looks like, that in this case "keep
> with next paragraph" rule is ignored, although this option is enabled.
> 
> So for me it would be at least an enhancement to improve the relationship
> between paragraph border and "keep with next paragraph" option. I change the
> status back to UNCONFIRMED. Perhaps we can collect some other opinions.

It is not a new border. Rather IIUC the border "merge" will only occur if the
direct formatting, or style, of the Paragraph border's match. Change the border
of the first and the second will show--but the third will not as it matches the
second.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2019-04-15 Thread Stephan Bergmann (via logerrit)
 sw/source/filter/ww8/ww8atr.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 6340daac7b99c65249363a4bb61c492de31ef5d6
Author: Stephan Bergmann 
AuthorDate: Mon Apr 15 18:32:01 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Mon Apr 15 18:32:01 2019 +0200

Revert broken loplugin:sequentialassign change

Reverting part of 1123a47c9771e0f4a680316c034e9878919a85d5
"loplugin:sequentialassign in sw" that had caused e.g. 
CppunitTest_chart2_export
to fail in UBSan builds like

> /sw/source/core/layout/frmtool.cxx:3540:77: runtime error: signed integer 
overflow: -47572123069180 * -47572123069180 cannot be represented in type 'long'
> #0 0x2b44b168eeaf in GetFrameOfModify(SwRootFrame const*, SwModify 
const&, SwFrameType, SwPosition const*, std::pair const*) 
/sw/source/core/layout/frmtool.cxx:3540:77
> #1 0x2b44b07eb3f0 in SwContentNode::FindLayoutRect(bool, Point 
const*) const /sw/source/core/docnode/node.cxx:1169:60
> #2 0x2b45266573da in 
AttributeOutputBase::TextFlyContent(SwFormatFlyCnt const&) 
/sw/source/filter/ww8/ww8atr.cxx:3229:34
> #3 0x2b45265ecf49 in AttributeOutputBase::OutputItem(SfxPoolItem 
const&) /sw/source/filter/ww8/ww8atr.cxx:5258:13

().

Change-Id: I580f6fb3fb2f561b1cf76f8cf113bfe20aead844

diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
index 160e0f931115..528634646659 100644
--- a/sw/source/filter/ww8/ww8atr.cxx
+++ b/sw/source/filter/ww8/ww8atr.cxx
@@ -3225,7 +3225,8 @@ void AttributeOutputBase::TextFlyContent( const 
SwFormatFlyCnt& rFlyContent )
 {
 if ( auto pTextNd = dynamic_cast< const SwContentNode *>( 
GetExport().m_pOutFormatNode )  )
 {
-Point aLayPos = pTextNd->FindLayoutRect( false,  ).Pos();
+Point aLayPos;
+aLayPos = pTextNd->FindLayoutRect( false,  ).Pos();
 
 SwPosition aPos( *pTextNd );
 ww8::Frame aFrame( *rFlyContent.GetFrameFormat(), aPos );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124757] Embedded MS Excel table is not converted correctly.

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124757

Drew Jensen  changed:

   What|Removed |Added

 CC||drewjensen.in...@gmail.com

--- Comment #2 from Drew Jensen  ---
Created attachment 150775
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150775=edit
File opened with LO 6.2.2

Attempted to confirm this using Ubuntu 18.04

Up to LO 6.0 (the Binary distributed by Ubuntu the file does not accurately
render in the application. There are missing columns in the first table. I also
think the table is supposed to have a background.

With LO versions 6.2 and 6.3Alpha the missing columns in the first table are
rendered, but the table still has a blank background.

I don't have a full blown MSO to check with, used the latest WPS application
(which uses MS libraries) to get an idea as to what MSO would display.

I won't set the status on the issue without hearing about the shading issue. If
that isn't expected then I would say this is now WFM, otherwise is should set
to new for the table background/shading issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: libreoffice-6.2.2.2 component context fails to supply service com.sun.star.ui.ModuleUIConfigurationManager

2019-04-15 Thread Stephan Bergmann

On 15/04/2019 17:13, John Frankish wrote:

$ rm -rf /home/tc/.config/libreoffice

$ libreoffice
Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.
LibreOffice 6.2 - Fatal Error: The application cannot be started.
component context fails to supply service 
com.sun.star.ui.ModuleUIConfigurationManager of type 
com.sun.star.ui.XModuleUIConfigurationManager2: an error occurred during file 
opening


The `strace -f libreoffice` output following the `rm -rf ...` would be 
useful.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 123234] Missing characters while exporting to PDF using certain fonts (IM fell from arch user repository)

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123234

Buovjaga  changed:

   What|Removed |Added

Version|4.3.0.4 release |4.2.0.4 release

--- Comment #8 from Buovjaga  ---
Repro in oldest commit of win32-4.3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117160] Solid color background on Impress and Draw leaves top and left 1px white/blank when exporting to PNG

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117160

Buovjaga  changed:

   What|Removed |Added

Version|4.3.0.4 release |4.2.0.4 release

--- Comment #19 from Buovjaga  ---
Now we have a 4.2-4.3 bibisect repo for Win, but unfortunately the bug is
already in the oldest commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101182] Sort destroys group information

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101182

--- Comment #6 from David F Smith  ---
This bug is still present in LibreOffice 6.2.2.2 under Windows 10 Pro
(10.0.17134).
There are no changes from the originally reported behavior.


Version: 6.2.2.2 (x64)
Build ID: 2b840030fec2aae0fd2658d8d4f9548af4e3518d
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123665] Inconsistent behavior of "find next" in slides and notes

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123665

David F Smith  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #6 from David F Smith  ---
I retested under 6.2.2.2, and I now see slightly similar, but slightly
different, behavior from my original report.

Immediately after starting LibreOffice, I opened my test presentation and
performed my test steps 1-5.  At step 4, the word "slide" was highlighted in
the note (as expected), but when I pressed Enter again to find the next
occurrence, the word "slide" was replaced by a newline, showing that it had
been selected for edit.

I undid that change (with Ctrl-Z) and repeated steps 1-5.  This time the
behavior at step 4 was as I originally reported: "slide" was not highlighted in
the note, and additional presses of Enter did nothing.

I closed the presentation and reopened it, and the same thing happened: first
time, "slide" was found on the first note but selected for editing/replacement;
second time, "slide" was not found on the note.

I closed the presentation, exited LibreOffice, restarted LibreOffice, opened
the presentation, and now the behavior is as I originally reported: "slide" is
not found on the first note, using the Enter key as "Find next."

I also noticed that if at step 4, when nothing is highlighted in the note, I
click the "find next" arrow, "slide" is highlighted in the note, but there is
also a blinking edit cursor after the word, so that if I press Enter, the word
is replaced.

My original report listed additional steps that use the "find next" arrow.  The
behavior that I see now is identical to what I reported originally: when "find
next" moves to the first note, "slide" is not highlighted.  A second click
highlights "slide" in the first note, but now I see that there is a blinking
cursor after the word, so that again, if I press Enter, the word is replaced.

Apologies for the lengthy comment.  In summary, the behavior that I see under
6.2.2.2 is very similar to what I originally reported and is not what I
consider to be correct.  "Find next," whether with the Enter key or the arrow,
acts inconsistently when switching from slides to notes.


Version: 6.2.2.2 (x64)
Build ID: 2b840030fec2aae0fd2658d8d4f9548af4e3518d
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83454] Aliases do not work in queries of a database connected to a *.mdb-file

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83454

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #27 from Buovjaga  ---
Tried with bibisect repo win32-4.3: the first commit already gives me failed
query.

The data content could not be loaded. Syntax error (missing operator) in query
expression '`Name` `Given Name`'

So this is 4.2.0.0alpha1 and I don't understand, why 4.2.8 would work.

I did not modify the SQL in any way.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - extensions/source

2019-04-15 Thread Tor Lillqvist (via logerrit)
 extensions/source/ole/unoconversionutilities.hxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 6d54ce9155c73b6b97c437234f97f4558166b69d
Author: Tor Lillqvist 
AuthorDate: Mon Apr 15 15:53:09 2019 +0300
Commit: Tor Lillqvist 
CommitDate: Mon Apr 15 15:53:09 2019 +0300

Turn an incoming VT_NULL when a STRING is wanted into an empty BSTR

Might help in some cases in the customer application.

Change-Id: Icdc13780d4623e9df8bc057760c1295d7d6ffd61

diff --git a/extensions/source/ole/unoconversionutilities.hxx 
b/extensions/source/ole/unoconversionutilities.hxx
index 771a15cc48b7..83066f338ea5 100644
--- a/extensions/source/ole/unoconversionutilities.hxx
+++ b/extensions/source/ole/unoconversionutilities.hxx
@@ -433,6 +433,8 @@ void UnoConversionUtilities::variantToAny( const 
VARIANTARG* pArg, Any& rAny,
 bFail = true;
 break;
 case TypeClass_STRING:  // UString
+if(var.vt == VT_NULL)
+var = CComBSTR("");
 if(SUCCEEDED(hr = VariantChangeType( & var, , 0, VT_BSTR)))
 variantToAny( & var, rAny);
 else if (hr == DISP_E_TYPEMISMATCH)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 122962] FILESAVE DOCX Missing shape after saving in LO

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122962

--- Comment #7 from Buovjaga  ---
*** Bug 122963 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104442] [META] OOXML shape (DrawingML and VML) related issues

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104442
Bug 104442 depends on bug 122963, which changed state.

Bug 122963 Summary: FILESAVE DOCX Shape changes size and position
https://bugs.documentfoundation.org/show_bug.cgi?id=122963

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122963] FILESAVE DOCX Shape changes size and position

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122963

Buovjaga  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #6 from Buovjaga  ---
After bibisect with win32-4.3, same blame as bug 122962. For the bad state, I
targeted both "gone" and "height decreased".

*** This bug has been marked as a duplicate of bug 122962 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

2019-04-15 Thread Jens Carl (via logerrit)
 sc/qa/extras/scheaderfieldsobj.cxx |   20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

New commits:
commit 8f13b0d3f1d72aab85665bccf409a3d6fdeb4272
Author: Jens Carl 
AuthorDate: Mon Apr 15 03:56:26 2019 +
Commit: Jens Carl 
CommitDate: Mon Apr 15 17:20:35 2019 +0200

Rename ScCellFieldsObj to ScHeaderFieldsObj

Correct class name to mirror the name of the object we are testing
against.

Change-Id: I72f29c765990b1693533de8150bfbededf045925
Reviewed-on: https://gerrit.libreoffice.org/70753
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/sc/qa/extras/scheaderfieldsobj.cxx 
b/sc/qa/extras/scheaderfieldsobj.cxx
index e38e88fc0080..c105d3a56437 100644
--- a/sc/qa/extras/scheaderfieldsobj.cxx
+++ b/sc/qa/extras/scheaderfieldsobj.cxx
@@ -33,18 +33,18 @@ using namespace css;
 
 namespace sc_apitest
 {
-class ScCellFieldsObj : public CalcUnoApiTest,
-public apitest::XEnumerationAccess,
-public apitest::XRefreshable
+class ScHeaderFieldsObj : public CalcUnoApiTest,
+  public apitest::XEnumerationAccess,
+  public apitest::XRefreshable
 {
 public:
-ScCellFieldsObj();
+ScHeaderFieldsObj();
 
 virtual uno::Reference init() override;
 virtual void setUp() override;
 virtual void tearDown() override;
 
-CPPUNIT_TEST_SUITE(ScCellFieldsObj);
+CPPUNIT_TEST_SUITE(ScHeaderFieldsObj);
 
 // XEnumerationAccess
 CPPUNIT_TEST(testCreateEnumeration);
@@ -58,12 +58,12 @@ private:
 uno::Reference m_xComponent;
 };
 
-ScCellFieldsObj::ScCellFieldsObj()
+ScHeaderFieldsObj::ScHeaderFieldsObj()
 : CalcUnoApiTest("/sc/qa/extras/testdocuments")
 {
 }
 
-uno::Reference ScCellFieldsObj::init()
+uno::Reference ScHeaderFieldsObj::init()
 {
 uno::Reference xDoc(m_xComponent, 
uno::UNO_QUERY_THROW);
 
@@ -87,20 +87,20 @@ uno::Reference ScCellFieldsObj::init()
 return xTFS->getTextFields();
 }
 
-void ScCellFieldsObj::setUp()
+void ScHeaderFieldsObj::setUp()
 {
 CalcUnoApiTest::setUp();
 // create calc document
 m_xComponent = loadFromDesktop("private:factory/scalc");
 }
 
-void ScCellFieldsObj::tearDown()
+void ScHeaderFieldsObj::tearDown()
 {
 closeDocument(m_xComponent);
 CalcUnoApiTest::tearDown();
 }
 
-CPPUNIT_TEST_SUITE_REGISTRATION(ScCellFieldsObj);
+CPPUNIT_TEST_SUITE_REGISTRATION(ScHeaderFieldsObj);
 
 } // namespace sc_apitest
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 34940] EDITING: Start on click not added correctly to movies

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=34940
Bug 34940 depends on bug 123653, which changed state.

Bug 123653 Summary: Media objects do not trigger effects.
https://bugs.documentfoundation.org/show_bug.cgi?id=123653

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123653] Media objects do not trigger effects.

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123653

Miklos Vajna  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #10 from Miklos Vajna  ---
Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 124748] PARAGRAPH BORDER: Modification border always adds a new border

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124748

Dieter Praas  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Resolution|NOTABUG |---
 Status|RESOLVED|UNCONFIRMED
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

--- Comment #5 from Dieter Praas  ---
(In reply to V Stuart Foote from comment #4)
> P15, P12, P11 all have border-top set to same border and color. They also
> have the "Merge with next paragraph" value set--meaning the first
> "border-top" will show. Subsequent do not.

I understand, but I don't understand, why a new border appears, if you try to
change the top border. So for me it looks like, that in this case "keep with
next paragraph" rule is ignored, although this option is enabled.

So for me it would be at least an enhancement to improve the relationship
between paragraph border and "keep with next paragraph" option. I change the
status back to UNCONFIRMED. Perhaps we can collect some other opinions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 119727] [META] Paragraph borders bugs and enhancements

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119727
Bug 119727 depends on bug 124748, which changed state.

Bug 124748 Summary: PARAGRAPH BORDER: Modification border always adds a new 
border
https://bugs.documentfoundation.org/show_bug.cgi?id=124748

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|NOTABUG |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124748] PARAGRAPH BORDER: Modification border always adds a new border

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124748

Dieter Praas  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Resolution|NOTABUG |---
 Status|RESOLVED|UNCONFIRMED
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

--- Comment #5 from Dieter Praas  ---
(In reply to V Stuart Foote from comment #4)
> P15, P12, P11 all have border-top set to same border and color. They also
> have the "Merge with next paragraph" value set--meaning the first
> "border-top" will show. Subsequent do not.

I understand, but I don't understand, why a new border appears, if you try to
change the top border. So for me it looks like, that in this case "keep with
next paragraph" rule is ignored, although this option is enabled.

So for me it would be at least an enhancement to improve the relationship
between paragraph border and "keep with next paragraph" option. I change the
status back to UNCONFIRMED. Perhaps we can collect some other opinions.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Tagging text as being in arbitrary complex-script languages

2019-04-15 Thread jonathon


On 4/15/19 12:26 PM, Eike Rathke wrote:
> Hi jonathon,
> 
> On Saturday, 2019-04-13 16:01:43 +, jonathon wrote:
> 
>> Does this mean that if a person is given a dictionary for, say, Ferangi,
>> as an extension, upon installing it, they won't need to make any other
>> changes, to be able to select Ferangi as the document language?
> 
> That's the purpose..
> It should be selectable as paragraph and character attribution in
> a document for spell-checking purposes.
> 
> Adding arbitrary dictionary languages (as long as they strictly follow
> the BCP 47 language tag specification) works since quite a while (2014?)
> already. New(er) in the mentioned mechanism is the ability to add
> a language also to the CTL or CJK sections where previously it was only
> possible to add to the (misnamed) "Western" section, and give the
> language list entries a proper UI name instead of showing just the
> language tag.
> 
> Note however that such extension language can't be set as default
> language for all documents under Tools -> Options -> Languages.


Thanks.
I wasn't aware that that functionality was present.

I'll play with over the next month or so, then write about in my
long-neglected blog.

jonathon

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

RE: libreoffice-6.2.2.2 component context fails to supply service com.sun.star.ui.ModuleUIConfigurationManager

2019-04-15 Thread John Frankish
> > Strace log attached.
> > 
> I guess the problem shows in lines like
> 
> 10691 access("/home/tc/.config/libreoffice/4/user/config/soffice.cfg", 
> F_OK) = -1 ENOENT (No such file or directory)
> 
> There is previous lines like
>
> 10691 mkdir("/home/tc/.config/libreoffice/4/user/psprint", 0777) = -1 
> EEXIST (File exists)
> 
> indicating that the user profile at ~/.config/libreoffice/4/ is present in 
> general
> (so has been generated by a previous run of soffice), but lacks important 
> parts like the
> user/config/soffice.cfg/ sub-dir.  What happens if you `rm -fr 
> ~/.config/libreoffice`
> before running soffice again?
> 
Thanks for the reply.

This distro (tinycorelinux) works like a live CD, so nothing is saved on reboot 
- it seems libreoffice-6.2.2.2 is creating the folders/files you mention:

$ ls -a /home/tc/.config
./   ../  gtk-3.0/

$ libreoffice
Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.
LibreOffice 6.2 - Fatal Error: The application cannot be started. 
component context fails to supply service 
com.sun.star.ui.ModuleUIConfigurationManager of type 
com.sun.star.ui.XModuleUIConfigurationManager2: an error occurred during file 
opening

$ ls -a /home/tc/.config/libreoffice
./  ../ 4/

$ libreoffice --version
LibreOffice 6.2.2.2 20(Build:2)

$ rm -rf /home/tc/.config/libreoffice

$ libreoffice
Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.
LibreOffice 6.2 - Fatal Error: The application cannot be started. 
component context fails to supply service 
com.sun.star.ui.ModuleUIConfigurationManager of type 
com.sun.star.ui.XModuleUIConfigurationManager2: an error occurred during file 
opening

$ ls -a /home/tc/.config/libreoffice
./  ../ 4/
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 124756] Media objects do not trigger effects.

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124756

Miklos Vajna  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #3 from Miklos Vajna  ---
Confirmed. Root cause seems to be that some vcl::Window paint idle is executed
in a way that it instantly re-schedules itself. The ugly solution is to just
not process idles in the non-GL case, a better one would be to find out why
that paint idle is re-scheduled again and again (only in case a media object is
on the slide, not otherwise).

I'll take a look.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Changes to 'private/mcecchetti/accessibility/paragraph'

2019-04-15 Thread Marco Cecchetti (via logerrit)
New branch 'private/mcecchetti/accessibility/paragraph' available with the 
following commits:
commit 0a9faf8014747c5b1bc5f2ff0c5b1c254b600ed6
Author: Marco Cecchetti 
Date:   Mon Apr 15 17:01:09 2019 +0200

[DRAFT] - lok: AT - get current paragraph with formatting

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: how to add .cxx file to be compiled and linked

2019-04-15 Thread Regis Perdreau
Ok, thanks.  It works...


Régis Perdreau



Le lun. 15 avr. 2019 à 16:39, Stephan Bergmann  a
écrit :

> On 15/04/2019 16:31, Regis Perdreau wrote:
> > I have added a file in, for example,  like
> > core/slideshow/engine/slide/test.cxx  with a method in it.
> > I have add with 'git add' to my work local branch repository
> > I expect that it will be compiled like the other files...but ... it
> > seems to be ignored
> > and  the linker fails because a method description is missing (include
> > test.hxx is ok)
> > Is there any something simple that i have forgotten ?
>
> You must add it to the gb_Library_add_exception_objects of some
> Library_*.mk, presumably slideshow/Library_slideshow.mk in your case.
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 107139] [META] Breeze icons

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107139
Bug 107139 depends on bug 123455, which changed state.

Bug 123455 Summary: Breeze Dark icon set is missing some icons
https://bugs.documentfoundation.org/show_bug.cgi?id=123455

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124198] move ImageMap from Edit to Tools menu

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124198

--- Comment #5 from andreas_k  ---
yes keep it open until help is fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124673] why toggle function DrawText, HyperlinkDialog and Horizontal Line

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124673

--- Comment #6 from andreas_k  ---
Created attachment 150773
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150773=edit
writer -> menubar -> insert -> toggle

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 124673] why toggle function DrawText, HyperlinkDialog and Horizontal Line

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124673

--- Comment #6 from andreas_k  ---
Created attachment 150773
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150773=edit
writer -> menubar -> insert -> toggle

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 124673] why toggle function DrawText, HyperlinkDialog and Horizontal Line

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124673

andreas_k  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #5 from andreas_k  ---
When I activate the toggle I would think that this command is activated and I
can draw an horizontal line, DrawText, but it's not activated when the toggle
is set, so I don't see an benefit of have the toggle.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 124757] Embedded MS Excel table is not converted correctly.

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124757

--- Comment #1 from Mohammed Saifullah  ---
Created attachment 150772
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150772=edit
Tables after conversion

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124673] why toggle function DrawText, HyperlinkDialog and Horizontal Line

2019-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124673

andreas_k  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #5 from andreas_k  ---
When I activate the toggle I would think that this command is activated and I
can draw an horizontal line, DrawText, but it's not activated when the toggle
is set, so I don't see an benefit of have the toggle.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

  1   2   3   4   >