[Libreoffice-commits] online.git: loolkitconfig.xcu
loolkitconfig.xcu |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 69995fa0f1f96ba91460272904de91f46520b260 Author: Ashod Nakashian AuthorDate: Tue Mar 12 11:06:49 2019 -0400 Commit: Andras Timar CommitDate: Tue Apr 23 07:47:04 2019 +0200 Move the Help URL to a new config path Change-Id: I76468d1c032689099b371449aedc0e5583f0ae2d Reviewed-on: https://gerrit.libreoffice.org/69107 Reviewed-by: Andras Timar Tested-by: Andras Timar Reviewed-on: https://gerrit.libreoffice.org/71087 diff --git a/loolkitconfig.xcu b/loolkitconfig.xcu index a9b7f0562..bbe1942d9 100644 --- a/loolkitconfig.xcu +++ b/loolkitconfig.xcu @@ -8,7 +8,7 @@ 11 -https://help.collaboraoffice.com/help.html? +https://help.collaboraoffice.com/help.html? true ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loolkitconfig.xcu
loolkitconfig.xcu |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit e8bcf063300f6032f79fd21d19fdfebbfa753a48 Author: Ashod Nakashian AuthorDate: Mon Mar 11 22:14:20 2019 -0400 Commit: Andras Timar CommitDate: Tue Apr 23 07:46:46 2019 +0200 Add help URL to loolkitconfig.xcu When blank the help button is hidden from all dialogs. Change-Id: Ibd43411bed496bfd3bc81056ebc8657fb77fb8fe Reviewed-on: https://gerrit.libreoffice.org/69072 Reviewed-by: Andras Timar Tested-by: Andras Timar Reviewed-on: https://gerrit.libreoffice.org/71086 diff --git a/loolkitconfig.xcu b/loolkitconfig.xcu index 8e00eabcc..a9b7f0562 100644 --- a/loolkitconfig.xcu +++ b/loolkitconfig.xcu @@ -5,7 +5,10 @@ false -11 +11 + + +https://help.collaboraoffice.com/help.html? true ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: bug 74702
Hi Adrien, On 22.04.2019 12:43, Adrien Ollier wrote: > sorry I meant impedit3.cxx, lines 2805 and 2806. > > Ok I'll try to make some changes in gerrit. Nice, looking forward to see it mentioned here in the thread. Please note that answering someone's answer directly, without CCing the mailing list, excludes the message from common discussion. E.g, consider how this your reply didn't allow others to also know that you actually meant impedit3, and that made others (see Jan-Marek's reply) to waste time again. Please always reply to list, or to all, instead of private replies. -- Best regards, Mike Kaganski ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/control/Control.Menubar.js |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 4f4bcbc9822f749072ebd90854cb01cae80fe512
Author: Ashod Nakashian
AuthorDate: Tue Mar 12 11:55:43 2019 -0400
Commit: Andras Timar
CommitDate: Tue Apr 23 07:46:22 2019 +0200
leaflet: do not disable the Close Document menu for read-only docs
Change-Id: I6a52b0bd807ae68ea6bf59e103c004375afae50b
Reviewed-on: https://gerrit.libreoffice.org/69110
Reviewed-by: Andras Timar
Tested-by: Andras Timar
Reviewed-on: https://gerrit.libreoffice.org/71088
diff --git a/loleaflet/src/control/Control.Menubar.js
b/loleaflet/src/control/Control.Menubar.js
index d0e8c5724..9a005f3f4 100644
--- a/loleaflet/src/control/Control.Menubar.js
+++ b/loleaflet/src/control/Control.Menubar.js
@@ -426,7 +426,7 @@ L.Control.Menubar = L.Control.extend({
allowedViewModeActions: [
'downloadas-pdf', 'downloadas-odt', 'downloadas-doc',
'downloadas-docx', 'downloadas-rtf', // file menu
'downloadas-odp', 'downloadas-ppt', 'downloadas-pptx',
'print', // file menu
- 'downloadas-ods', 'downloadas-xls', 'downloadas-xlsx',
// file menu
+ 'downloadas-ods', 'downloadas-xls', 'downloadas-xlsx',
'closedocument', // file menu
'fullscreen', 'zoomin', 'zoomout', 'zoomreset', // view
menu
'about', 'keyboard-shortcuts' // help menu
]
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 108897] [META] XLSX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=108897 Bug 108897 depends on bug 124231, which changed state. Bug 124231 Summary: Day function for creating date is off by one https://bugs.documentfoundation.org/show_bug.cgi?id=124231 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124231] Day function for creating date is off by one
https://bugs.documentfoundation.org/show_bug.cgi?id=124231 Aron Budea changed: What|Removed |Added Hardware|x86-64 (AMD64) |All Status|UNCONFIRMED |RESOLVED CC||ba...@caesar.elte.hu Resolution|--- |WONTFIX OS|Linux (All) |All --- Comment #3 from Aron Budea --- This is because of Calc's starting date counting being different from Excel's to account for Excel's 1900 leap year bug. For details please see bug 44453 comment 3. However, your usage of DAY(...) function is unnecessary, instead of DAY(21) you should just have 21 in there. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108827] [META] Calc functions bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108827 Bug 108827 depends on bug 124231, which changed state. Bug 124231 Summary: Day function for creating date is off by one https://bugs.documentfoundation.org/show_bug.cgi?id=124231 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109527] [META] Spell check dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109527 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||124893 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124893 [Bug 124893] Validity check on dictionary creation. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122457] Worse text rendering in newer versions of LibreOffice (OpenGL)
https://bugs.documentfoundation.org/show_bug.cgi?id=122457 --- Comment #18 from Lilly Watson --- The information is really very informative and provides some useful information about the newer versions of LibreOffice also can check https://uaetechnician.ae/acer-laptop-hard-disk-replacement for more information in detail. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124032] MacOSX: Macro-Dialog: Background-Color on TextBoxes don't show
https://bugs.documentfoundation.org/show_bug.cgi?id=124032 Tomaz Vajngerl changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124894] New: LibreOffice V6 slow response times Writer, Draw, Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=124894 Bug ID: 124894 Summary: LibreOffice V6 slow response times Writer, Draw, Impress Product: LibreOffice Version: 6.1.4.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ren_m...@hotmail.com Was using V5.4.7 LibreOffice Writer, Draw and Impress for many months with no problems. Upgraded to V6.1.4 and then V6.1.5 then V6.2.3. All V6 versions were very slow to repond to any input e.g. editing one page simple text file, opening the Tools -> Options settings). I have tried a number of things (disabled OpenGL, switched off JRE, reinstalls, start in safe mode ) but the response time remained unacceptable (10 to 20+ secs for many simple actions). I downgraded to standard V5.4.7 (using the MSI file from the previous installation) and all operations reverted to the original response times. Any suggestions on what actions I can take to get V6 to run with reasonable response times? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124235] Dialog theming/UX - List of entries of a select box is not "attached" to the widget and has an offset
https://bugs.documentfoundation.org/show_bug.cgi?id=124235 --- Comment #5 from Commit Notification --- Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/online/+/ede2c3432f1d25c1c74b94f8fd5686fd59750e7b%5E%21 tdf#124235: Fix the same problem on all platforms the same way -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/control/Control.LokDialog.js | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
New commits:
commit ede2c3432f1d25c1c74b94f8fd5686fd59750e7b
Author: Tor Lillqvist
AuthorDate: Sat Apr 20 23:32:37 2019 +0300
Commit: Ashod Nakashian
CommitDate: Tue Apr 23 04:52:05 2019 +0200
tdf#124235: Fix the same problem on all platforms the same way
Change-Id: Ie7ede59841898a0738af7e44a3c0fe89db1cd3ee
Reviewed-on: https://gerrit.libreoffice.org/71023
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/loleaflet/src/control/Control.LokDialog.js
b/loleaflet/src/control/Control.LokDialog.js
index a58fd6008..ce6940698 100644
--- a/loleaflet/src/control/Control.LokDialog.js
+++ b/loleaflet/src/control/Control.LokDialog.js
@@ -658,17 +658,7 @@ L.Control.LokDialog = L.Control.extend({
var dialogTitle = $('.lokdialog_notitle');
if (dialogTitle != null && dialogTitle.length == 0) {
var dialogTitleBar = $('.ui-dialog-titlebar');
- // tdf#124235: At least in the iOS app, multiplying with
- // L.getDpiScaleFactor() below causes the child of a
combo box to be
- // displaced from the fixed part. I see the same
problem also when using
- // Safari on a Retina Mac against normal online. But as
I don't know whether
- // it happens also for other browsers on other
platforms on hidpi displays,
- // I will fix this for the iOS app only for now.
- if (!window.ThisIsTheiOSApp) {
- top += dialogTitleBar.outerHeight() *
L.getDpiScaleFactor();
- } else {
- top += dialogTitleBar.outerHeight();
- }
+ top += dialogTitleBar.outerHeight();
}
floatingCanvas.id = strId + '-floating';
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 96625] FILEOPEN: Event "View Created" never happens
https://bugs.documentfoundation.org/show_bug.cgi?id=96625 --- Comment #8 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73526] bad PDF export of slide background with (specific?) gradients
https://bugs.documentfoundation.org/show_bug.cgi?id=73526 --- Comment #20 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 88474] EDITING: Selection Mode is Reset to ‘Standard selection’ with Esc
https://bugs.documentfoundation.org/show_bug.cgi?id=88474 --- Comment #6 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 95554] Copy of multiple cells in a column only copies the first cell
https://bugs.documentfoundation.org/show_bug.cgi?id=95554 --- Comment #5 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88474] EDITING: Selection Mode is Reset to ‘Standard selection’ with Esc
https://bugs.documentfoundation.org/show_bug.cgi?id=88474 --- Comment #6 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79404] EDITING: Undo after AutoCorrect removes the whole cell content instead of reverting just the autocorrect changes
https://bugs.documentfoundation.org/show_bug.cgi?id=79404 --- Comment #18 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: bundled/include kit/Kit.cpp
bundled/include/LibreOfficeKit/LibreOfficeKit.h |3 +++
bundled/include/LibreOfficeKit/LibreOfficeKit.hxx | 10 +++---
kit/Kit.cpp | 12 ++--
3 files changed, 16 insertions(+), 9 deletions(-)
New commits:
commit 83a73e24e0c8fb622e721b40fdde273ea003a195
Author: Ashod Nakashian
AuthorDate: Thu Jan 24 06:53:37 2019 -0500
Commit: Ashod Nakashian
CommitDate: Tue Apr 23 03:44:07 2019 +0200
wsd: set the language when creating a new view
This uses the new createViewWithOptions API to
set the language of the user at the point of
creating a new view.
Change-Id: Ibf3e0af1b0cc300126388c1217692d8d969be0f3
Reviewed-on: https://gerrit.libreoffice.org/67501
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/bundled/include/LibreOfficeKit/LibreOfficeKit.h
b/bundled/include/LibreOfficeKit/LibreOfficeKit.h
index f2c8dd40f..62bd3c429 100644
--- a/bundled/include/LibreOfficeKit/LibreOfficeKit.h
+++ b/bundled/include/LibreOfficeKit/LibreOfficeKit.h
@@ -375,6 +375,9 @@ struct _LibreOfficeKitDocumentClass
int nY,
int nOffset);
+/// @see lok::Document::createViewWithOptions().
+int (*createViewWithOptions) (LibreOfficeKitDocument* pThis, const char*
pOptions);
+
#endif // defined LOK_USE_UNSTABLE_API || defined LIBO_INTERNAL_ONLY
};
diff --git a/bundled/include/LibreOfficeKit/LibreOfficeKit.hxx
b/bundled/include/LibreOfficeKit/LibreOfficeKit.hxx
index 6bebf3661..7027298a1 100644
--- a/bundled/include/LibreOfficeKit/LibreOfficeKit.hxx
+++ b/bundled/include/LibreOfficeKit/LibreOfficeKit.hxx
@@ -440,13 +440,17 @@ public:
}
/**
- * Create a new view for an existing document.
+ * Create a new view for an existing document with
+ * options similar to documentLoadWithOptions.
* By default a loaded document has 1 view.
* @return the ID of the new view.
*/
-int createView()
+int createView(const char* pOptions = nullptr)
{
-return mpDoc->pClass->createView(mpDoc);
+if (LIBREOFFICEKIT_DOCUMENT_HAS(mpDoc, createViewWithOptions))
+return mpDoc->pClass->createViewWithOptions(mpDoc, pOptions);
+else
+return mpDoc->pClass->createView(mpDoc);
}
/**
diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 759e78e24..25050e04b 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -1571,6 +1571,10 @@ private:
{
const std::string sessionId = session->getId();
+std::string options;
+if (!lang.empty())
+options = "Language=" + lang;
+
std::unique_lock lock(_documentMutex);
if (!_loKitDocument)
@@ -1594,10 +1598,6 @@ private:
_jailedUrl = uri;
_isDocPasswordProtected = false;
-std::string options;
-if (!lang.empty())
-options = "Language=" + lang;
-
LOG_DBG("Calling lokit::documentLoad(" << uriAnonym << ", \"" <<
options << "\").");
Timestamp timestamp;
_loKitDocument.reset(_loKit->documentLoad(uri.c_str(),
options.c_str()));
@@ -1666,8 +1666,8 @@ private:
}
}
-LOG_INF("Creating view to url [" << uriAnonym << "] for session ["
<< sessionId << "].");
-_loKitDocument->createView();
+LOG_INF("Creating view to url [" << uriAnonym << "] for session ["
<< sessionId << "] with " << options << '.');
+_loKitDocument->createView(options.c_str());
LOG_TRC("View to url [" << uriAnonym << "] created.");
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - sd/source
sd/source/ui/view/drviews1.cxx |4
sd/source/ui/view/drviewse.cxx |6 ++
2 files changed, 10 insertions(+)
New commits:
commit 3e949896a0d2382c034a927c20da8f654f16630f
Author: Ashod Nakashian
AuthorDate: Wed Dec 12 10:46:13 2018 -0500
Commit: Ashod Nakashian
CommitDate: Tue Apr 23 03:41:37 2019 +0200
sd: LOK: publish statechange on entering master view
Change-Id: Ib736800544b9669e3708da0c01370af22cdf3e97
Reviewed-on: https://gerrit.libreoffice.org/69617
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/sd/source/ui/view/drviews1.cxx b/sd/source/ui/view/drviews1.cxx
index 405804acff33..1a3578945356 100644
--- a/sd/source/ui/view/drviews1.cxx
+++ b/sd/source/ui/view/drviews1.cxx
@@ -419,6 +419,10 @@ void DrawViewShell::ChangeEditMode(EditMode eEMode, bool
bIsLayerModeActive)
GetViewFrame()->SetChildWindow(
AnimationChildWindow::GetChildWindowId(), false );
+if (comphelper::LibreOfficeKit::isActive())
+
GetViewShell()->libreOfficeKitViewCallback(LOK_CALLBACK_STATE_CHANGED,
+
".uno:SlideMasterPage=true");
+
if (!mpActualPage)
{
// as long as there is no mpActualPage, take first
diff --git a/sd/source/ui/view/drviewse.cxx b/sd/source/ui/view/drviewse.cxx
index 96daaffc9334..3bfb5bed4ece 100644
--- a/sd/source/ui/view/drviewse.cxx
+++ b/sd/source/ui/view/drviewse.cxx
@@ -30,6 +30,7 @@
#include
#include
+#include
#include
#include
#include
@@ -1030,6 +1031,11 @@ void DrawViewShell::FuSupport(SfxRequest& rReq)
case SID_CLOSE_MASTER_VIEW:
{
+// Notify of disabling master view, which is enabled in
DrawViewShell::ChangeEditMode.
+if (comphelper::LibreOfficeKit::isActive())
+
GetViewShell()->libreOfficeKitViewCallback(LOK_CALLBACK_STATE_CHANGED,
+
".uno:SlideMasterPage=false");
+
Broadcast (
ViewShellHint(ViewShellHint::HINT_CHANGE_EDIT_MODE_START));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 124864] LibreOffice hangs when trying to create a new Writer or Impress document
https://bugs.documentfoundation.org/show_bug.cgi?id=124864 --- Comment #1 from Remy Gauthier --- Problem can be removed by going into Tools -> Options and selecting the paths TAB. There, remove the $HOME folder of the user in the list, save and restart. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113195] [META] Japanese language-specific CJK issues
https://bugs.documentfoundation.org/show_bug.cgi?id=113195 Bug 113195 depends on bug 101854, which changed state. Bug 101854 Summary: RENDERING: Poorman's bold not bold on Japanese font on macOS (see comment #13) https://bugs.documentfoundation.org/show_bug.cgi?id=101854 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101854] RENDERING: Poorman's bold not bold on Japanese font on macOS (see comment #13)
https://bugs.documentfoundation.org/show_bug.cgi?id=101854 Tomaz Vajngerl changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp wsd/TileCache.cpp
wsd/DocumentBroker.cpp |4 ++--
wsd/TileCache.cpp |2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit ca1a83f96b013e171130596dd1486b1416ddbea3
Author: Ashod Nakashian
AuthorDate: Mon Apr 22 12:03:49 2019 -0400
Commit: Ashod Nakashian
CommitDate: Tue Apr 23 03:02:36 2019 +0200
wsd: reduce tile logging from debug to trace level
These are very frequent and not very useful without
the ability to trace them across the system, which
are all done at trace level. So it's highly unlikely
that these would be used at debug.
Change-Id: I479f2ead1bbd2996b9972082e00ebf984072f785
Reviewed-on: https://gerrit.libreoffice.org/71073
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 53d3e2dbe..40465c0ce 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -1395,7 +1395,7 @@ void
DocumentBroker::handleTileCombinedRequest(TileCombined& tileCombined,
// Forward to child to render.
const std::string req = newTileCombined.serialize("tilecombine");
-LOG_DBG("Sending residual tilecombine: " << req);
+LOG_TRC("Sending uncached residual tilecombine request to Kit: " <<
req);
_childProcess->sendTextFrame(req);
}
@@ -1527,7 +1527,7 @@ void DocumentBroker::sendRequestedTiles(const
std::shared_ptr& se
// Forward to child to render.
const std::string req = newTileCombined.serialize("tilecombine");
-LOG_DBG("Some of the tiles were not prerendered. Sending residual
tilecombine: " << req);
+LOG_TRC("Some of the tiles were not prerendered. Sending residual
tilecombine: " << req);
_childProcess->sendTextFrame(req);
}
}
diff --git a/wsd/TileCache.cpp b/wsd/TileCache.cpp
index 287e0ba77..a4f16a5f0 100644
--- a/wsd/TileCache.cpp
+++ b/wsd/TileCache.cpp
@@ -311,7 +311,7 @@ void TileCache::invalidateTiles(int part, int x, int y, int
width, int height)
{
if (intersectsTile(it->first, part, x, y, width, height))
{
-LOG_DBG("Removing tile: " << it->first.serialize());
+LOG_TRC("Removing tile: " << it->first.serialize());
it = _cache.erase(it);
}
else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: kit/Kit.cpp
kit/Kit.cpp |5 +
1 file changed, 5 insertions(+)
New commits:
commit 2ec5023dbf4e8fd8d59a82f9040ad88933a10aa2
Author: Ashod Nakashian
AuthorDate: Mon Apr 22 12:02:58 2019 -0400
Commit: Ashod Nakashian
CommitDate: Tue Apr 23 03:02:09 2019 +0200
wsd: assert on 0-sized tiles
Change-Id: I10a20bb5a3ad31e368f554bdc5e1701a7ff6a22d
Reviewed-on: https://gerrit.libreoffice.org/71072
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index d098cd773..759e78e24 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -1080,6 +1080,11 @@ public:
LOG_TRC("Encoded tile #" << tileIndex << " at (" << positionX <<
"," << positionY << ") with oldWireId=" <<
tiles[tileIndex].getOldWireId() << ", hash=" << hash << "
wireId: " << wireId << " in " << imgSize << " bytes.");
+if (imgSize == 0)
+{
+LOG_ERR("Encoded 0-sized tile!");
+assert(!"0-sized tile enocded!");
+}
tiles[tileIndex].setWireId(wireId);
tiles[tileIndex].setImgSize(imgSize);
tileIndex++;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/core/Socket.js | 30 --
loleaflet/src/layer/tile/TileLayer.js | 11 ++-
2 files changed, 22 insertions(+), 19 deletions(-)
New commits:
commit c45dfe194bbcb10514761c3564f42a8ff7f3fc17
Author: Ashod Nakashian
AuthorDate: Mon Apr 22 12:00:19 2019 -0400
Commit: Ashod Nakashian
CommitDate: Tue Apr 23 03:01:46 2019 +0200
leaflet: process the most common message first
The 'tile:' message is the most common and most
latency sensitive message, so give it priority.
Change-Id: Id5790369cd493423a47acab8a3d5107ce91b0d39
Reviewed-on: https://gerrit.libreoffice.org/71071
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/loleaflet/src/core/Socket.js b/loleaflet/src/core/Socket.js
index b02b00943..464a1f1df 100644
--- a/loleaflet/src/core/Socket.js
+++ b/loleaflet/src/core/Socket.js
@@ -810,20 +810,22 @@ L.Socket = L.Class.extend({
this._map.fire('docloaded', {status: true});
}
- // these can arrive very early during the startup
- if (textMsg.startsWith('statusindicatorstart:')) {
- this._map.fire('statusindicator', {statusType :
'start'});
- return;
- }
- else if (textMsg.startsWith('statusindicatorsetvalue:')) {
- var value = textMsg.match(/\d+/g)[0];
- this._map.fire('statusindicator', {statusType :
'setvalue', value : value});
- return;
- }
- else if (textMsg.startsWith('statusindicatorfinish:')) {
- this._map.fire('statusindicator', {statusType :
'finish'});
- this._map._fireInitComplete('statusindicatorfinish');
- return;
+ // These can arrive very early during the startup, and never
again.
+ if (textMsg.startsWith('statusindicator')) {
+ if (textMsg.startsWith('statusindicatorstart:')) {
+ this._map.fire('statusindicator', {statusType :
'start'});
+ return;
+ }
+ else if
(textMsg.startsWith('statusindicatorsetvalue:')) {
+ var value = textMsg.match(/\d+/g)[0];
+ this._map.fire('statusindicator', {statusType :
'setvalue', value : value});
+ return;
+ }
+ else if (textMsg.startsWith('statusindicatorfinish:')) {
+ this._map.fire('statusindicator', {statusType :
'finish'});
+
this._map._fireInitComplete('statusindicatorfinish');
+ return;
+ }
}
if (this._map._docLayer) {
diff --git a/loleaflet/src/layer/tile/TileLayer.js
b/loleaflet/src/layer/tile/TileLayer.js
index 42c880e57..43256a15e 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -359,7 +359,11 @@ L.TileLayer = L.GridLayer.extend({
},
_onMessage: function (textMsg, img) {
- if (textMsg.startsWith('commandvalues:')) {
+ // 'tile:' is the most common message type; keep this the first.
+ if (textMsg.startsWith('tile:')) {
+ this._onTileMsg(textMsg, img);
+ }
+ else if (textMsg.startsWith('commandvalues:')) {
this._onCommandValuesMsg(textMsg);
}
else if (textMsg.startsWith('cursorvisible:')) {
@@ -447,9 +451,6 @@ L.TileLayer = L.GridLayer.extend({
else if (textMsg.startsWith('textselectionstart:')) {
this._onTextSelectionStartMsg(textMsg);
}
- else if (textMsg.startsWith('tile:')) {
- this._onTileMsg(textMsg, img);
- }
else if (textMsg.startsWith('windowpaint:')) {
this._onDialogPaintMsg(textMsg, img);
}
@@ -812,7 +813,7 @@ L.TileLayer = L.GridLayer.extend({
//first time document open, set last cursor position
if (this.lastCursorPos.lat === 0 && this.lastCursorPos.lng ===
0)
this.lastCursorPos = cursorPos;
-
+
var updateCursor = false;
if ((this.lastCursorPos.lat !== cursorPos.lat) ||
(this.lastCursorPos.lng !== cursorPos.lng)) {
updateCursor = true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: 2 commits - kit/Kit.cpp wsd/DocumentBroker.cpp wsd/TileDesc.hpp
kit/Kit.cpp| 13 ++--
wsd/DocumentBroker.cpp | 19 +++---
wsd/TileDesc.hpp | 50 -
3 files changed, 44 insertions(+), 38 deletions(-)
New commits:
commit c7ac68e8e31d2cf2179c12c817a09ad24c0cc22a
Author: Ashod Nakashian
AuthorDate: Sat Apr 20 14:58:48 2019 -0400
Commit: Ashod Nakashian
CommitDate: Tue Apr 23 03:01:30 2019 +0200
wsd: tile serializer now supports adding a suffix
Moves appending tokens into the serializer and
avoids making extra copies of itself.
Change-Id: I62d374e69d9c4a55643ea20cb5f8c2b9c75c88c5
Reviewed-on: https://gerrit.libreoffice.org/71022
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 76dddab46..d098cd773 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -121,9 +121,9 @@ static std::string ObfuscatedFileId;
#endif
#if ENABLE_DEBUG
-# define ADD_DEBUG_RENDERID(s) ((s)+ " renderid=" + Util::UniqueId())
+# define ADD_DEBUG_RENDERID (" renderid=" + Util::UniqueId() + '\n')
#else
-# define ADD_DEBUG_RENDERID(s) (s)
+# define ADD_DEBUG_RENDERID ("\n")
#endif
#if !MOBILEAPP
@@ -1098,9 +1098,9 @@ public:
std::string tileMsg;
if (combined)
-tileMsg =
ADD_DEBUG_RENDERID(tileCombined.serialize("tilecombine:")) + "\n";
+tileMsg = tileCombined.serialize("tilecombine:",
ADD_DEBUG_RENDERID);
else
-tileMsg = ADD_DEBUG_RENDERID(tiles[0].serialize("tile:")) + "\n";
+tileMsg = tiles[0].serialize("tile:", ADD_DEBUG_RENDERID);
LOG_TRC("Sending back painted tiles for " << tileMsg << " of size " <<
output.size() << " bytes) for: " << tileMsg);
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 8524725ff..53d3e2dbe 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -48,6 +48,12 @@ using namespace LOOLProtocol;
using Poco::JSON::Object;
+#if ENABLE_DEBUG
+# define ADD_DEBUG_RENDERID (" renderid=cached\n")
+#else
+# define ADD_DEBUG_RENDERID ("\n")
+#endif
+
void ChildProcess::setDocumentBroker(const std::shared_ptr&
docBroker)
{
assert(docBroker && "Invalid DocumentBroker instance.");
@@ -1335,11 +1341,7 @@ void DocumentBroker::handleTileRequest(TileDesc& tile,
TileCache::Tile cachedTile = _tileCache->lookupTile(tile);
if (cachedTile)
{
-#if ENABLE_DEBUG
-const std::string response = tile.serialize("tile:") + "
renderid=cached\n";
-#else
-const std::string response = tile.serialize("tile:") + '\n';
-#endif
+const std::string response = tile.serialize("tile:",
ADD_DEBUG_RENDERID);
session->sendTile(response, cachedTile);
return;
}
@@ -1452,7 +1454,6 @@ void DocumentBroker::sendRequestedTiles(const
std::shared_ptr& se
float tilesOnFlyUpperLimit = 0;
if (normalizedVisArea.hasSurface() && session->getTileWidthInTwips() != 0
&& session->getTileHeightInTwips() != 0)
{
-
const int tilesFitOnWidth = std::ceil(normalizedVisArea.getRight() /
session->getTileWidthInTwips()) -
std::ceil(normalizedVisArea.getLeft() /
session->getTileWidthInTwips()) + 1;
const int tilesFitOnHeight = std::ceil(normalizedVisArea.getBottom() /
session->getTileHeightInTwips()) -
@@ -1500,11 +1501,7 @@ void DocumentBroker::sendRequestedTiles(const
std::shared_ptr& se
if (cachedTile)
{
//TODO: Combine the response to reduce latency.
-#if ENABLE_DEBUG
-const std::string response = tile.serialize("tile:") + "
renderid=cached\n";
-#else
-const std::string response = tile.serialize("tile:") + "\n";
-#endif
+const std::string response = tile.serialize("tile:",
ADD_DEBUG_RENDERID);
session->sendTile(response, cachedTile);
}
else
diff --git a/wsd/TileDesc.hpp b/wsd/TileDesc.hpp
index abb922b3f..77fb46b26 100644
--- a/wsd/TileDesc.hpp
+++ b/wsd/TileDesc.hpp
@@ -29,20 +29,21 @@ typedef uint64_t TileBinaryHash;
class TileDesc
{
public:
-TileDesc(int part, int width, int height, int tilePosX, int tilePosY, int
tileWidth, int tileHeight, int ver, int imgSize, int id, bool broadcast) :
-_part(part),
-_width(width),
-_height(height),
-_tilePosX(tilePosX),
-_tilePosY(tilePosY),
-_tileWidth(tileWidth),
-_tileHeight(tileHeight),
-_ver(ver),
-_imgSize(imgSize),
-_id(id),
-_broadcast(broadcast),
-_oldWireId(0),
-_wireId(0)
+TileDesc(int part, int width, int height, int tilePosX, int tilePosY, int
tileWidth,
+ int tileHeight, int ver, int imgSize, int id, bool broadcast)
+: _part(part)
+, _width(width)
+, _height(height)
+, _tilePosX(tilePosX)
+, _tilePosY(tilePosY)
+,
[Libreoffice-commits] online.git: 2 commits - common/Png.hpp common/Util.cpp
common/Png.hpp |6 ++
common/Util.cpp |4 ++--
2 files changed, 8 insertions(+), 2 deletions(-)
New commits:
commit ed0efde542b9d48b0b48a733f12b302a8b36c0a0
Author: Ashod Nakashian
AuthorDate: Sat Apr 20 15:23:32 2019 -0400
Commit: Ashod Nakashian
CommitDate: Tue Apr 23 03:00:44 2019 +0200
wsd: use thread_local instead of __thread
The former is the standard C++ approach
and is reportedly faster than __thread
(at least with gcc).
Change-Id: Ibdefd32172774a280637f73dd062282b7bf62025
Reviewed-on: https://gerrit.libreoffice.org/71019
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/common/Util.cpp b/common/Util.cpp
index ab21e0c96..06a715320 100644
--- a/common/Util.cpp
+++ b/common/Util.cpp
@@ -497,7 +497,7 @@ namespace Util
return replace(r, "\n", " / ");
}
-static __thread char ThreadName[32] = {0};
+static thread_local char ThreadName[32] = {0};
void setThreadName(const std::string& s)
{
@@ -537,7 +537,7 @@ namespace Util
}
#ifdef __linux
-static __thread pid_t ThreadTid = 0;
+static thread_local pid_t ThreadTid = 0;
pid_t getThreadId()
#else
commit e76d27188ee11f1387d56b851dc73d83f093be48
Author: Ashod Nakashian
AuthorDate: Fri Apr 19 20:09:22 2019 -0400
Commit: Ashod Nakashian
CommitDate: Tue Apr 23 03:00:31 2019 +0200
wsd: use fast deflate level for png
The default deflate level of 6 is quite slow
and the benefits are hardly worth the high
latency that users experience.
Tested on a writer document with some small
images and a few pages of text:
Level 4 gives virtually identical compression
ratio to level 6, but is between 5-10% faster.
Level 3 runs almost twice as fast as level 6,
but the output is typically 2-3x larger.
Perhaps this should be exposed via config
so it would be possible to reduce latency
due to compression when CPU is scarce but
network bandwidth ample, and vice versa.
Change-Id: Iba88eea8f180d11458b33c68389e797234df1a60
Reviewed-on: https://gerrit.libreoffice.org/71018
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/common/Png.hpp b/common/Png.hpp
index 1cd03f085..d4e1c2cf5 100644
--- a/common/Png.hpp
+++ b/common/Png.hpp
@@ -136,6 +136,12 @@ bool encodeSubBufferToPNG(unsigned char* pixmap, size_t
startX, size_t startY,
#if MOBILEAPP
png_set_compression_level(png_ptr, Z_BEST_SPEED);
+#else
+// Level 4 gives virtually identical compression
+// ratio to level 6, but is between 5-10% faster.
+// Level 3 runs almost twice as fast, but the
+// output is typically 2-3x larger.
+png_set_compression_level(png_ptr, 4);
#endif
#ifdef IOS
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: common/Log.cpp common/Log.hpp
common/Log.cpp | 15 +++
common/Log.hpp | 35 ++-
2 files changed, 33 insertions(+), 17 deletions(-)
New commits:
commit ce78fec310ab5ab6aecabb73cad7d782afcb885f
Author: Ashod Nakashian
AuthorDate: Sat Apr 20 11:39:20 2019 -0400
Commit: Ashod Nakashian
CommitDate: Tue Apr 23 03:01:00 2019 +0200
wsd: reuse ostringstream when logging
This is faster and reduces memory fragmentation.
Also, cleans up the logging macros and implementation.
Change-Id: I7fb00da041d1261c694c4b48b67a3c66ad0cbf8d
Reviewed-on: https://gerrit.libreoffice.org/71020
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/common/Log.cpp b/common/Log.cpp
index b892c5b4b..46cfd6095 100644
--- a/common/Log.cpp
+++ b/common/Log.cpp
@@ -126,6 +126,21 @@ namespace Log
return buffer;
}
+// Reuse the same buffer to minimize memory fragmentation.
+static thread_local std::ostringstream Oss;
+
+std::ostringstream& begin(const char* level)
+{
+// Reset the oss.
+Oss.clear();
+Oss.seekp(0);
+
+// Output the prefix.
+char buffer[1024];
+Oss << Log::prefix(buffer, sizeof(buffer) - 1, level) <<
std::boolalpha;
+return Oss;
+}
+
void signalLogPrefix()
{
char buffer[1024];
diff --git a/common/Log.hpp b/common/Log.hpp
index bdc654b39..f4a51d8da 100644
--- a/common/Log.hpp
+++ b/common/Log.hpp
@@ -54,6 +54,9 @@ namespace Log
char* prefix(char* buffer, std::size_t len, const char* level);
+/// Starts logging by generating the prefix and returning an oss.
+std::ostringstream& begin(const char* level);
+
inline bool traceEnabled() { return logger().trace(); }
inline bool debugEnabled() { return logger().debug(); }
inline bool infoEnabled() { return logger().information(); }
@@ -237,31 +240,29 @@ namespace Log
#define LOG_FILE_NAME(f) (strrchr(f, '/')+1)
#endif
-#define LOG_END(LOG, FILEP) \
-do \
-{ \
-if (FILEP) \
-LOG << "| " << LOG_FILE_NAME(__FILE__) << ':' << __LINE__; \
+#define LOG_END(LOG, FILEP)
\
+do
\
+{
\
+if (FILEP)
\
+LOG << "| " << LOG_FILE_NAME(__FILE__) << ':' << __LINE__;
\
} while (false)
#ifdef __ANDROID__
-#define LOG_BODY_(LOG, PRIO, LVL, X, FILEP)
\
-char b_[1024];
\
-std::ostringstream oss_(Log::prefix(b_, sizeof(b_) - 1, LVL),
std::ostringstream::ate); \
-oss_ << std::boolalpha << X;
\
-LOG_END(oss_, FILEP);
\
+#define LOG_BODY_(LOG, PRIO, LVL, X, FILEP)
\
+std::ostringstream& oss_ = Log::begin(LVL);
\
+oss_ << X;
\
+LOG_END(oss_, FILEP);
\
((void)__android_log_print(ANDROID_LOG_DEBUG, "loolwsd", "%s %s", LVL,
oss_.str().c_str()))
#else
-#define LOG_BODY_(LOG, PRIO, LVL, X, FILEP)
\
-Poco::Message m_(LOG.name(), "", Poco::Message::PRIO_##PRIO);
\
-char b_[1024];
\
-std::ostringstream oss_(Log::prefix(b_, sizeof(b_) - 1, LVL),
std::ostringstream::ate); \
-oss_ << std::boolalpha << X;
\
-LOG_END(oss_, FILEP);
\
-m_.setText(oss_.str());
\
+#define LOG_BODY_(LOG, PRIO, LVL, X, FILEP)
\
+Poco::Message m_(LOG.name(), "", Poco::Message::PRIO_##PRIO);
\
+std::ostringstream& oss_ = Log::begin(LVL);
\
+oss_ << X;
\
+LOG_END(oss_, FILEP);
[Libreoffice-commits] core.git: desktop/source include/LibreOfficeKit include/vcl vcl/headless vcl/inc vcl/source
desktop/source/lib/init.cxx | 48 ---
include/LibreOfficeKit/LibreOfficeKit.h |6 +++
include/LibreOfficeKit/LibreOfficeKit.hxx| 19 ++
include/LibreOfficeKit/LibreOfficeKitTypes.h |6 +++
include/vcl/lok.hxx | 28 +++
vcl/headless/svpinst.cxx | 32 --
vcl/inc/headless/svpinst.hxx |3 -
vcl/inc/svdata.hxx |6 +++
vcl/source/app/svapp.cxx | 19 ++
9 files changed, 150 insertions(+), 17 deletions(-)
New commits:
commit b34786d2774b261be48de92f65a5d0aa3c32b289
Author: Ashod Nakashian
AuthorDate: Wed Apr 17 16:23:39 2019 +0100
Commit: Ashod Nakashian
CommitDate: Tue Apr 23 02:59:45 2019 +0200
Unipoll: add LibreOfficeKit API for polling, and an option to use it.
Change-Id: Iee7556ee52541ddbf1ef8f31e1ed4697f805a2ac
Reviewed-on: https://gerrit.libreoffice.org/70898
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 0842c98ed3e4..0853678a0008 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -39,6 +39,7 @@
#include
#include
+#include
#include
#include
#include
@@ -1513,6 +1514,11 @@ static bool lo_signDocument(LibreOfficeKit* pThis,
const unsigned char* pPrivateKeyBinary,
const int nPrivateKeyBinarySize);
+static void lo_runLoop(LibreOfficeKit* pThis,
+ LibreOfficeKitPollCallback pPollCallback,
+ LibreOfficeKitWakeCallback pWakeCallback,
+ void* pData);
+
LibLibreOffice_Impl::LibLibreOffice_Impl()
: m_pOfficeClass( gOfficeClass.lock() )
, maThread(nullptr)
@@ -1536,6 +1542,7 @@ LibLibreOffice_Impl::LibLibreOffice_Impl()
m_pOfficeClass->getVersionInfo = lo_getVersionInfo;
m_pOfficeClass->runMacro = lo_runMacro;
m_pOfficeClass->signDocument = lo_signDocument;
+m_pOfficeClass->runLoop = lo_runLoop;
gOfficeClass = m_pOfficeClass;
}
@@ -4491,6 +4498,16 @@ static void lo_startmain(void*)
Application::ReleaseSolarMutex();
}
+static void lo_runLoop(LibreOfficeKit* /*pThis*/,
+ LibreOfficeKitPollCallback pPollCallback,
+ LibreOfficeKitWakeCallback pWakeCallback,
+ void* pData)
+{
+SolarMutexGuard aGuard;
+vcl::lok::registerPollCallbacks(pPollCallback, pWakeCallback, pData);
+lo_startmain(nullptr);
+}
+
static bool bInitialized = false;
static void lo_status_indicator_callback(void *data,
comphelper::LibreOfficeKit::statusIndicatorCallbackType type, int percent)
@@ -4639,7 +4656,24 @@ static int lo_initialize(LibreOfficeKit* pThis, const
char* pAppPath, const char
// Did we do a pre-initialize
static bool bPreInited = false;
-static bool bProfileZones = getenv("SAL_PROFILEZONE_EVENTS") != nullptr;
+static bool bUnipoll = false;
+static bool bProfileZones = false;
+
+{ // cf. string lifetime for preinit
+std::vector aOpts;
+
+// ':' delimited options - avoiding ABI change for new parameters
+const char *pOptions = getenv("SAL_LOK_OPTIONS");
+if (pOptions)
+aOpts = comphelper::string::split(OUString(pOptions,
strlen(pOptions), RTL_TEXTENCODING_UTF8), ':');
+for (auto : aOpts)
+{
+if (it == "unipoll")
+bUnipoll = true;
+else if (it == "profile_events")
+bProfileZones = true;
+}
+}
// What stage are we at ?
if (pThis == nullptr)
@@ -4857,10 +4891,14 @@ static int lo_initialize(LibreOfficeKit* pThis, const
char* pAppPath, const char
RequestHandler::Enable(false);
SAL_INFO("lok", "Starting soffice_main");
RequestHandler::SetReady(false);
-pLib->maThread = osl_createThread(lo_startmain, nullptr);
-SAL_INFO("lok", "Waiting for RequestHandler");
-RequestHandler::WaitForReady();
-SAL_INFO("lok", "RequestHandler ready -- continuing");
+if (!bUnipoll)
+{
+// Start the main thread only in non-unipoll mode (i.e.
multithreaded).
+pLib->maThread = osl_createThread(lo_startmain, nullptr);
+SAL_INFO("lok", "Waiting for RequestHandler");
+RequestHandler::WaitForReady();
+SAL_INFO("lok", "RequestHandler ready -- continuing");
+}
}
if (eStage != SECOND_INIT)
diff --git a/include/LibreOfficeKit/LibreOfficeKit.h
b/include/LibreOfficeKit/LibreOfficeKit.h
index 0e596f5067ba..f2c8dd40f1b3 100644
--- a/include/LibreOfficeKit/LibreOfficeKit.h
+++ b/include/LibreOfficeKit/LibreOfficeKit.h
@@ -104,6
[Libreoffice-commits] online.git: 2 commits - bundled/include common/Png.hpp kit/ForKit.cpp kit/Kit.cpp net/Socket.cpp net/Socket.hpp
bundled/include/LibreOfficeKit/LibreOfficeKit.h |6 +
bundled/include/LibreOfficeKit/LibreOfficeKit.hxx| 19 +++
bundled/include/LibreOfficeKit/LibreOfficeKitTypes.h |6 +
common/Png.hpp |4
kit/ForKit.cpp |6 -
kit/Kit.cpp | 105 +++
net/Socket.cpp |2
net/Socket.hpp | 12 +-
8 files changed, 133 insertions(+), 27 deletions(-)
New commits:
commit 90c8dd41b94072f3712a0847553abb9b6b908697
Author: Ashod Nakashian
AuthorDate: Fri Apr 19 20:06:27 2019 -0400
Commit: Ashod Nakashian
CommitDate: Tue Apr 23 03:00:19 2019 +0200
wsd: logging, comments, and const correctness
Change-Id: Ibfbef282e951a80fb145239df4bbcc9f3e4c8e13
Reviewed-on: https://gerrit.libreoffice.org/71017
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/common/Png.hpp b/common/Png.hpp
index 726454d9c..1cd03f085 100644
--- a/common/Png.hpp
+++ b/common/Png.hpp
@@ -173,7 +173,9 @@ bool encodeSubBufferToPNG(unsigned char* pixmap, size_t
startX, size_t startY,
totalDuration += duration;
nCalls += 1;
-LOG_TRC("Average PNG compression time after " << std::to_string(nCalls) <<
" calls: " << (totalDuration / static_cast(nCalls)));
+LOG_TRC("PNG compression took " << duration << " ms (" << output.size()
+<< " bytes). Average after " <<
std::to_string(nCalls)
+<< " calls: " << (totalDuration /
static_cast(nCalls)));
png_destroy_write_struct(_ptr, _ptr);
diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 65d386b72..281853b42 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -430,7 +430,6 @@ private:
return _wireId;
}
} ;
-
size_t _cacheSize;
static const size_t CacheSizeSoftLimit = (1024 * 4 * 32); // 128k of cache
static const size_t CacheSizeHardLimit = CacheSizeSoftLimit * 2;
@@ -474,9 +473,9 @@ private:
for (auto it = _cache.begin(); it != _cache.end(); ++it)
avgHits += it->second.getHitCount();
-LOG_DBG("cache " << _cache.size() << " items total size " <<
-_cacheSize << " current hits " << avgHits << ", total hit
rate " <<
-(_cacheHits * 100. / _cacheTests) << "% at balance start");
+LOG_DBG("PNG cache has " << _cache.size() << " items, total size "
<<
+_cacheSize << ", current hits " << avgHits << ", total hit
rate " <<
+(_cacheHits * 100. / _cacheTests) << "% at balance
start.");
avgHits /= _cache.size();
for (auto it = _cache.begin(); it != _cache.end();)
@@ -502,8 +501,8 @@ private:
}
}
-LOG_DBG("cache " << _cache.size() << " items total size " <<
-_cacheSize << " after balance");
+LOG_DBG("PNG cache has " << _cache.size() << " items, total size "
<<
+_cacheSize << " after balance.");
}
}
commit 6b82d245faa3aa727c4e8b37be13e0746ca95f6c
Author: Ashod Nakashian
AuthorDate: Wed Apr 17 22:46:16 2019 +0100
Commit: Ashod Nakashian
CommitDate: Tue Apr 23 03:00:07 2019 +0200
Unipoll: integrate with the LOK mainloop in a single thread.
Unfortunately processing multiple events from the Kit socket
is causing massive document invalidations, for unknown
reasons. As such, for now we have to process one event
at a time, until the source of the invalidations is found
and fixed.
Without the invalidation, the average tile rendering
roundtrip is about 3x faster than with the invalidations
and the maximum roundrip is at least 2x faster.
Change-Id: Iafbf9ccc2b80656cb71c208b598080f72d201ca2
Reviewed-on: https://gerrit.libreoffice.org/70906
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/bundled/include/LibreOfficeKit/LibreOfficeKit.h
b/bundled/include/LibreOfficeKit/LibreOfficeKit.h
index 0e596f506..f2c8dd40f 100644
--- a/bundled/include/LibreOfficeKit/LibreOfficeKit.h
+++ b/bundled/include/LibreOfficeKit/LibreOfficeKit.h
@@ -104,6 +104,12 @@ struct _LibreOfficeKitClass
const int nCertificateBinarySize,
const unsigned char* pPrivateKeyBinary,
const int nPrivateKeyBinarySize);
+
+/// @see lok::Office::runLoop()
+void (*runLoop) (LibreOfficeKit* pThis,
+ LibreOfficeKitPollCallback pPollCallback,
+ LibreOfficeKitWakeCallback pWakeCallback,
+ void* pData);
};
#define LIBREOFFICEKIT_DOCUMENT_HAS(pDoc,member)
LIBREOFFICEKIT_HAS_MEMBER(LibreOfficeKitDocumentClass,member,(pDoc)->pClass->nSize)
diff --git
[Libreoffice-bugs] [Bug 124893] Validity check on dictionary creation.
https://bugs.documentfoundation.org/show_bug.cgi?id=124893 Ritchie Cunningham changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |ritchie.cunningham@protonma |desktop.org |il.com CC||ritchie.cunningham@protonma ||il.com -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124893] New: Validity check on dictionary creation.
https://bugs.documentfoundation.org/show_bug.cgi?id=124893 Bug ID: 124893 Summary: Validity check on dictionary creation. Product: LibreOffice Version: 6.3.0.0.alpha0+ Master Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ritchie.cunning...@protonmail.com Description: When creating a new dictionary, the 'Ok' button is active, allowing you to create a dictionary with no name. Found while fixing tdf#61076. While this doesn't present an issue of data loss it still seems like unexpected behaviour. Steps to Reproduce: -- Open LibreWriter -- Hit F7 -- Open 'Options' -- Click 'New' -- Press 'Ok'. Interestingly, if you type something into the field, and then remove it, the 'Ok' button does disable as is the expected behaviour. Actual Results: The 'Ok' button is enabled without text in the input field. Interestingly, if you type something into the field, and then remove it, the 'Ok' button does disable as is the expected behaviour. Expected Results: The 'Ok' Button should ideally be disabled when no text is in the field to avoid having an un-named dictionary. Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sw/uiconfig
sw/uiconfig/swriter/ui/tocindexpage.ui | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) New commits: commit 9a5e5c581eaf86ce0bbf293da40ba18c72fba1bd Author: Julien Nabet AuthorDate: Sat Mar 23 14:13:19 2019 +0100 Commit: Adolfo Jayme Barrientos CommitDate: Tue Apr 23 02:39:32 2019 +0200 tdf#124240: make type in TOC translatable Change-Id: Ie3e713786b096657571d0abe0806b1d45d2b5341 Reviewed-on: https://gerrit.libreoffice.org/69585 Tested-by: Jenkins Reviewed-by: Andras Timar (cherry picked from commit 1971c61ac750e76f33869c323a9e8abe8201cd99) Reviewed-on: https://gerrit.libreoffice.org/69645 Reviewed-by: Adolfo Jayme Barrientos diff --git a/sw/uiconfig/swriter/ui/tocindexpage.ui b/sw/uiconfig/swriter/ui/tocindexpage.ui index 9522028fc1d1..be562370f5ef 100644 --- a/sw/uiconfig/swriter/ui/tocindexpage.ui +++ b/sw/uiconfig/swriter/ui/tocindexpage.ui @@ -122,13 +122,13 @@ False start - Table of Contents - Alphabetical Index - Table of Figures - Index of Tables - User-Defined - Table of Objects - Bibliography + Table of Contents + Alphabetical Index + Table of Figures + Index of Tables + User-Defined + Table of Objects + Bibliography ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 124835] Context toolbar make jumping ui
https://bugs.documentfoundation.org/show_bug.cgi?id=124835 V Stuart Foote changed: What|Removed |Added CC||momonas...@gmail.com, ||s.mehrbr...@gmail.com --- Comment #9 from V Stuart Foote --- @Maxim, Samuel -- any thoughts on comment 3, idea of pushing toolbars activated as context onto a Sidebar content panel? User choice to Pop-up toolbars as now but provide option for context activated toolbar's buttons to show in Sidebar. Goal of holding the GUI and document zoom stable. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 124835] Context toolbar make jumping ui
https://bugs.documentfoundation.org/show_bug.cgi?id=124835 V Stuart Foote changed: What|Removed |Added CC||momonas...@gmail.com, ||s.mehrbr...@gmail.com --- Comment #9 from V Stuart Foote --- @Maxim, Samuel -- any thoughts on comment 3, idea of pushing toolbars activated as context onto a Sidebar content panel? User choice to Pop-up toolbars as now but provide option for context activated toolbar's buttons to show in Sidebar. Goal of holding the GUI and document zoom stable. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 124865] careful, crash after insert rows, file trashed after recovery, with version libo-master64~2019-04-16_03.05.57_LibreOfficeDev_6.3.0.0.alpha0_Win_x64
https://bugs.documentfoundation.org/show_bug.cgi?id=124865 --- Comment #4 from b. --- i can't find a newer version than the buggy one in https://dev-builds.libreoffice.org/daily/master/Win-x86_64@42/current/ :-( b. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124865] careful, crash after insert rows, file trashed after recovery, with version libo-master64~2019-04-16_03.05.57_LibreOfficeDev_6.3.0.0.alpha0_Win_x64
https://bugs.documentfoundation.org/show_bug.cgi?id=124865 --- Comment #3 from b. --- it looks as if this version additionally fu..ed some data in the process of copy a full sheet from one file, paste it in a new sheet in a new file, save the new file with a new name. formulas have been replaced with values. won't do any testing or investigation with that version, just info. reg. b. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99185] [UI] Breeze icons for folder and Form is identical
https://bugs.documentfoundation.org/show_bug.cgi?id=99185 --- Comment #4 from andreas_k --- how do I get this view? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 124835] Context toolbar make jumping ui
https://bugs.documentfoundation.org/show_bug.cgi?id=124835 --- Comment #8 from V Stuart Foote --- (In reply to andreas_k from comment #7) > and single line toolbar and sidebar don't have any connection to notebookbar. Sure they do, they're all MUFFIN (Glade XML as opposed to .src) Just some elements arrived earlier than others... the NB flavors just the latest. Some old (2015) discussion... https://smehrbrodt.wordpress.com/2015/11/24/improving-the-toolbars-in-libreoffice/ and see bug 92218, bug 101249, bug 106470 for how things evolved. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 124835] Context toolbar make jumping ui
https://bugs.documentfoundation.org/show_bug.cgi?id=124835 --- Comment #8 from V Stuart Foote --- (In reply to andreas_k from comment #7) > and single line toolbar and sidebar don't have any connection to notebookbar. Sure they do, they're all MUFFIN (Glade XML as opposed to .src) Just some elements arrived earlier than others... the NB flavors just the latest. Some old (2015) discussion... https://smehrbrodt.wordpress.com/2015/11/24/improving-the-toolbars-in-libreoffice/ and see bug 92218, bug 101249, bug 106470 for how things evolved. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124892] CRASH: inserting new lines and undoing
https://bugs.documentfoundation.org/show_bug.cgi?id=124892 Xisco Faulí changed: What|Removed |Added Crash report or||["SwLinePortion::Format(SwT crash signature||extFormatInfo &)"] CC||xiscofa...@libreoffice.org See Also||https://crashreport.libreof ||fice.org/stats/signature/Sw ||LinePortion::Format(SwTextF ||ormatInfo%20&) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124892] CRASH: inserting new lines and undoing
https://bugs.documentfoundation.org/show_bug.cgi?id=124892 Xisco Faulí changed: What|Removed |Added Keywords||wantBacktrace -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124892] New: CRASH: inserting new lines and undoing
https://bugs.documentfoundation.org/show_bug.cgi?id=124892 Bug ID: 124892 Summary: CRASH: inserting new lines and undoing Product: LibreOffice Version: 5.2 all versions Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: xiscofa...@libreoffice.org Steps to reproduce: 1. Open attachment 88768 from bug 71037 2. Hold Enter key for a few seconds -> Crash Reproduced in Version: 6.3.0.0.alpha0+ Build ID: e913727c7ee3af0bb4031c6829abfb3373306492 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded and Version: 5.2.0.0.alpha0+ Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53 Threads 4; Ver: 4.15; Render: default; -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123873] FILEOPEN DOCX Charts cover each other
https://bugs.documentfoundation.org/show_bug.cgi?id=123873 Luke changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||4703 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104703] FILEOPEN: Wrong Position of MS .docx Chart Object on Import
https://bugs.documentfoundation.org/show_bug.cgi?id=104703 Luke changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||3873 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123710] Unable to delete individual item from recent files and loading file time has extended considerably
https://bugs.documentfoundation.org/show_bug.cgi?id=123710 V Stuart Foote changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123710] Unable to delete individual item from recent files and loading file time has extended considerably
https://bugs.documentfoundation.org/show_bug.cgi?id=123710 --- Comment #11 from RichardB --- I have resolved this reported bug by deletion of the LibreOffice 6.2 Help Pack (English US ) from my system (see latest attachment dated 2019-04-22) . I had installed this in Feb 2019 and in retrospect this ties up with my observing a bug with Libre. I had installed this programme to have help available when I use LibreOffice but I it did not appear to work and I did not immediately uninstall it. Without trying to be obvious, this help programme has negatively affect the operation of LibreOffce for me and no doubt this programme either has a bug or bugs or it is not an appropriate one for the use I have for LibreOffice. I would appreciate feedback on this issue pls. Regards -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123710] Unable to delete individual item from recent files and loading file time has extended considerably
https://bugs.documentfoundation.org/show_bug.cgi?id=123710 --- Comment #10 from RichardB --- Created attachment 150930 --> https://bugs.documentfoundation.org/attachment.cgi?id=150930=edit copy of deleted Libre programme -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91690] FILEOPEN: Chart data in series with null/empty values in Docx file, imported on wrong columns
https://bugs.documentfoundation.org/show_bug.cgi?id=91690 Luke changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||4405 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124405] FILEOPEN DOCX Scatter chart with incomplete tables not imported correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=124405 Luke changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=91 ||690 --- Comment #9 from Luke --- The line chart version of this bug was fixed with https://cgit.freedesktop.org/libreoffice/core/commit/?id=4bcf1872bbe9db1388769485a7e4c0cbcce3d53c -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124405] FILEOPEN DOCX Scatter chart with incomplete tables not imported correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=124405 --- Comment #8 from Luke --- In Word, if you change the chart type from scatter to line, Writer correctly imports the blank row. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99496] [UI][SIDEBAR] The Sidebar icon ‘Manage Changes’ requires replacement
https://bugs.documentfoundation.org/show_bug.cgi?id=99496 andreas_k changed: What|Removed |Added Blocks|122247 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122247 [Bug 122247] [META] Icon requests -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122247] [META] Icon requests
https://bugs.documentfoundation.org/show_bug.cgi?id=122247 andreas_k changed: What|Removed |Added Depends on|99496 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=99496 [Bug 99496] [UI][SIDEBAR] The Sidebar icon ‘Manage Changes’ requires replacement -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124405] FILEOPEN DOCX Scatter chart with incomplete tables not imported correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=124405 Luke changed: What|Removed |Added Summary|FILEOPEN OOXML Scatter |FILEOPEN DOCX Scatter chart |chart with incomplete |with incomplete tables not |tables not imported |imported correctly |correctly | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123695] Change Layout Menu in Slides Bar to Be Graphical One
https://bugs.documentfoundation.org/show_bug.cgi?id=123695 andreas_k changed: What|Removed |Added CC||kain...@gmail.com --- Comment #6 from andreas_k --- I don't know how to show an graphic type layout in the menubar so for me it would be an improvement to sync the content of the graphic and text based layout. As written it's impossible to show useful icons on 16px icon size. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107144] CALC: Add icon for Show Comment on/off text button and change icon for Show Comments on/off and rename existing buttons
https://bugs.documentfoundation.org/show_bug.cgi?id=107144 --- Comment #14 from andreas_k --- I'd like to fix this bug, but in general I don't know what was needed for which uno command. So please add the list of uno commands here and I will see how to fix the icon issue. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124405] FILEOPEN DOCX Scatter chart with incomplete tables not imported correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=124405 --- Comment #7 from Luke --- Created attachment 150929 --> https://bugs.documentfoundation.org/attachment.cgi?id=150929=edit Same charts in DOCX incorrectly imported It seems that our internal data tables need support for blank rows. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 123695] Change Layout Menu in Slides Bar to Be Graphical One
https://bugs.documentfoundation.org/show_bug.cgi?id=123695 andreas_k changed: What|Removed |Added CC||kain...@gmail.com --- Comment #6 from andreas_k --- I don't know how to show an graphic type layout in the menubar so for me it would be an improvement to sync the content of the graphic and text based layout. As written it's impossible to show useful icons on 16px icon size. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 124405] FILEOPEN DOCX Scatter chart with incomplete tables not imported correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=124405 Luke changed: What|Removed |Added Attachment #150928|XLSX format also affected. |XLSX format Not affected. description|| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100366] [META] Impress/Draw table bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=100366 --- Comment #1 from Negro Lito --- Hola. Draw me resulta sumamente útil para maquetar formularios con las tablas. Pero no me permite crear mi propio estilo de tabla ni anular los estilos que vienen por defecto. Los mismo interfieren con el diseño cuando intento dividir una celda o me duplican el trabajo cada vez que quiero insertar una tabla. Gracias. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124405] FILEOPEN OOXML Scatter chart with incomplete tables not imported correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=124405 Luke changed: What|Removed |Added Summary|FILEOPEN DOCX Scatter chart |FILEOPEN OOXML Scatter |displayed incorrectly |chart with incomplete ||tables not imported ||correctly -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124405] FILEOPEN DOCX Scatter chart displayed incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=124405 --- Comment #6 from Luke --- Created attachment 150928 --> https://bugs.documentfoundation.org/attachment.cgi?id=150928=edit XLSX format also affected. When there are missing data points, scatter charts are not imported correctly. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] dev-tools.git: 6 commits - uitest/mass-testing
uitest/mass-testing/calc.py |2
uitest/mass-testing/run.py | 150 ++--
2 files changed, 94 insertions(+), 58 deletions(-)
New commits:
commit f631db9e5e83706ed2678fb4db737700dd623a1b
Author: Xisco Fauli
AuthorDate: Mon Apr 22 22:38:28 2019 +0200
Commit: Xisco Fauli
CommitDate: Mon Apr 22 22:38:28 2019 +0200
mass-uitesting: Get focus after closing preview
otherwise, it fails at times
diff --git a/uitest/mass-testing/calc.py b/uitest/mass-testing/calc.py
index 7aaa190..7217c3a 100755
--- a/uitest/mass-testing/calc.py
+++ b/uitest/mass-testing/calc.py
@@ -88,6 +88,8 @@ class massTesting(UITestCase):
self.xUITest.executeCommand(".uno:PrintPreview") #open print
preview
self.xUITest.executeCommand(".uno:ClosePreview") # close print
preview
+self.xUITest.getTopFocusWindow()
+
self.ui_test.close_doc()
def test_hide_column_and_undo(self):
commit 7eeaee26607180f22b4a374c9ee6747a6ec15401
Author: Xisco Fauli
AuthorDate: Mon Apr 22 22:33:07 2019 +0200
Commit: Xisco Fauli
CommitDate: Mon Apr 22 22:33:07 2019 +0200
mass-uitesting: ignore empty lines
diff --git a/uitest/mass-testing/run.py b/uitest/mass-testing/run.py
index db5aa0a..20bb101 100755
--- a/uitest/mass-testing/run.py
+++ b/uitest/mass-testing/run.py
@@ -143,24 +143,27 @@ def run_tests_and_get_results(liboPath, listFiles,
isDebug, isResume):
importantInfo = ''
isFailure = False
for line in outputLines:
-line = line.decode("utf-8")
+line = line.decode("utf-8").strip()
+
+if not line:
+continue
if isDebug:
print(line)
-if 'skipped' == line.strip().lower():
+if 'skipped' == line.lower():
logger.info("SKIP: " + fileName + " : " + importantInfo)
results['skip'] += 1
break
-if 'Execution time' in line.strip():
+if 'Execution time' in line:
-importantInfo = line.strip().split('for ')[1]
+importantInfo = line.split('for ')[1]
#Extend timeout
timeout = time.time() + timeoutTime
-elif importantInfo and 'error' == line.strip().lower() or
'fail' == line.strip().lower():
+elif importantInfo and 'error' == line.lower() or 'fail' ==
line.lower():
isFailure = True
if importantInfo:
commit 38a10c2f739f4630317acbdadf53905fd9d6e0e2
Author: Xisco Fauli
AuthorDate: Mon Apr 22 22:22:21 2019 +0200
Commit: Xisco Fauli
CommitDate: Mon Apr 22 22:22:21 2019 +0200
mass-uitesting: use a variable here
diff --git a/uitest/mass-testing/run.py b/uitest/mass-testing/run.py
index 98304ed..db5aa0a 100755
--- a/uitest/mass-testing/run.py
+++ b/uitest/mass-testing/run.py
@@ -120,8 +120,9 @@ def run_tests_and_get_results(liboPath, listFiles, isDebug,
isResume):
# Do not block on process.stdout
fcntl.fcntl(process.stdout.fileno(), fcntl.F_SETFL, os.O_NONBLOCK)
-# Kill the process if the test can't be executed in 20 seconds
-timeout = time.time() + 20
+# Kill the process if the test can't be executed in 'timeoutTime'
seconds
+timeoutTime = 20
+timeout = time.time() + timeoutTime
while True:
time.sleep(1)
@@ -157,7 +158,7 @@ def run_tests_and_get_results(liboPath, listFiles, isDebug,
isResume):
importantInfo = line.strip().split('for ')[1]
#Extend timeout
-timeout = time.time() + 20
+timeout = time.time() + timeoutTime
elif importantInfo and 'error' == line.strip().lower() or
'fail' == line.strip().lower():
isFailure = True
commit c4571964fd2814490d4539cb9ba305a0611da41a
Author: Xisco Fauli
AuthorDate: Mon Apr 22 22:15:59 2019 +0200
Commit: Xisco Fauli
CommitDate: Mon Apr 22 22:15:59 2019 +0200
mass-uitesting: handle failures correctly
diff --git a/uitest/mass-testing/run.py b/uitest/mass-testing/run.py
index 5408fcf..98304ed 100755
--- a/uitest/mass-testing/run.py
+++ b/uitest/mass-testing/run.py
@@ -122,11 +122,9 @@ def run_tests_and_get_results(liboPath, listFiles,
isDebug, isResume):
# Kill the process if the test can't be executed in 20 seconds
timeout = time.time() + 20
-isFailure = False
while True:
time.sleep(1)
-
if time.time() > timeout:
logger.info("TIMEOUT: " + fileName)
results['timeout'] += 1
@@ -142,6 +140,7 @@ def run_tests_and_get_results(liboPath, listFiles, isDebug,
isResume):
pass
importantInfo = ''
+isFailure = False
Change font size in UnoControlGridModel
I've developed a Calc Dialog with several controls including the dynamic
gridmodel control. The only font property I've been able to change
successfully is GridModel.TextColor. Other font properties have no
affect. Is there a specific syntax for setting the font size? I've tried
several alternative property settings, but nothing seems to work other
than the text color.
dlgmodel = oDialogInventory.getModel()
gridmodel =
oDialogInventory.getModel().createInstance("com.sun.star.awt.grid.UnoControlGridModel")
with gridmodel
.PositionX = 8
.PositionY = 33
.Width = 150
.Height = 55
.TextColor = RGB(255,0,0)
end with
Thank you..awm119
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 103238] [META] Customize dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103238 Bug 103238 depends on bug 124846, which changed state. Bug 124846 Summary: Tools -> Customize does not complete move of main Menu objects https://bugs.documentfoundation.org/show_bug.cgi?id=124846 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source
cui/source/customize/cfg.cxx |4 1 file changed, 4 insertions(+) New commits: commit 9f32d341b80e1f1ffe28542f33003bfe5750639b Author: Jim Raykowski AuthorDate: Fri Apr 19 17:51:28 2019 -0800 Commit: Muhammet Kara CommitDate: Mon Apr 22 22:03:27 2019 +0200 tdf#124846 Make main menu items really move when moved This patch also fixes the Move Menu dialog move up button being enabled when dialog is created. Change-Id: I8432bd8d582e8a9ef449bce1d5cba703b2404c75 Reviewed-on: https://gerrit.libreoffice.org/71001 Tested-by: Jenkins Reviewed-by: Heiko Tietze Tested-by: Heiko Tietze Reviewed-by: Muhammet Kara diff --git a/cui/source/customize/cfg.cxx b/cui/source/customize/cfg.cxx index 817622140b77..05c6e1fdacb6 100644 --- a/cui/source/customize/cfg.cxx +++ b/cui/source/customize/cfg.cxx @@ -1757,6 +1757,8 @@ SvxMainMenuOrganizerDialog::SvxMainMenuOrganizerDialog( m_xMoveUpButton->connect_clicked(LINK( this, SvxMainMenuOrganizerDialog, MoveHdl)); m_xMoveDownButton->connect_clicked(LINK( this, SvxMainMenuOrganizerDialog, MoveHdl)); + +UpdateButtonStates(); } SvxMainMenuOrganizerDialog::~SvxMainMenuOrganizerDialog() @@ -1818,6 +1820,8 @@ IMPL_LINK( SvxMainMenuOrganizerDialog, MoveHdl, weld::Button&, rButton, void ) m_xMenuListBox->insert(nTargetEntry, sEntry, , nullptr, nullptr); m_xMenuListBox->select(nTargetEntry); +std::swap(mpEntries->at(nSourceEntry), mpEntries->at(nTargetEntry)); + UpdateButtonStates(); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 124891] [META] Basic IDE bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=124891 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||66185, 77291, 94524, 94526, ||94527, 94528, 94529, 94530, ||116743, 121444, 123540 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=66185 [Bug 66185] Feature request: IDE - Code auto complete for writing macros https://bugs.documentfoundation.org/show_bug.cgi?id=77291 [Bug 77291] IDE: No way to break out of repeated syntax errors https://bugs.documentfoundation.org/show_bug.cgi?id=94524 [Bug 94524] IDE (Integrated Development Environment) Removing tailing spaces/tabs https://bugs.documentfoundation.org/show_bug.cgi?id=94526 [Bug 94526] IDE (Integrated Development Environment) Handling of case in variable names https://bugs.documentfoundation.org/show_bug.cgi?id=94527 [Bug 94527] IDE (Integrated Development Environment) Handling of case in constant names https://bugs.documentfoundation.org/show_bug.cgi?id=94528 [Bug 94528] IDE (Integrated Development Environment) Handling of case in reserved words https://bugs.documentfoundation.org/show_bug.cgi?id=94529 [Bug 94529] IDE (Integrated Development Environment) line formatting https://bugs.documentfoundation.org/show_bug.cgi?id=94530 [Bug 94530] IDE (Integrated Development Environment) Indenting automation https://bugs.documentfoundation.org/show_bug.cgi?id=116743 [Bug 116743] In the IDE of BASIC, scrolling down the macro will return to line 1 from line 1000. https://bugs.documentfoundation.org/show_bug.cgi?id=121444 [Bug 121444] IDE editor jumps to text cursor unexpectedly when using mouse wheel to scroll while UI tries to resize column displaying line numbers https://bugs.documentfoundation.org/show_bug.cgi?id=123540 [Bug 123540] Basic "Tutorials" library is missing in Basic IDE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94528] IDE (Integrated Development Environment) Handling of case in reserved words
https://bugs.documentfoundation.org/show_bug.cgi?id=94528 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||124891 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124891 [Bug 124891] [META] Basic IDE bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94530] IDE (Integrated Development Environment) Indenting automation
https://bugs.documentfoundation.org/show_bug.cgi?id=94530 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||124891 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124891 [Bug 124891] [META] Basic IDE bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116743] In the IDE of BASIC, scrolling down the macro will return to line 1 from line 1000.
https://bugs.documentfoundation.org/show_bug.cgi?id=116743 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||124891 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124891 [Bug 124891] [META] Basic IDE bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77291] IDE: No way to break out of repeated syntax errors
https://bugs.documentfoundation.org/show_bug.cgi?id=77291 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||124891 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124891 [Bug 124891] [META] Basic IDE bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94529] IDE (Integrated Development Environment) line formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=94529 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||124891 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124891 [Bug 124891] [META] Basic IDE bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121444] IDE editor jumps to text cursor unexpectedly when using mouse wheel to scroll while UI tries to resize column displaying line numbers
https://bugs.documentfoundation.org/show_bug.cgi?id=121444 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||124891 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124891 [Bug 124891] [META] Basic IDE bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94526] IDE (Integrated Development Environment) Handling of case in variable names
https://bugs.documentfoundation.org/show_bug.cgi?id=94526 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||124891 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124891 [Bug 124891] [META] Basic IDE bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94524] IDE (Integrated Development Environment) Removing tailing spaces/tabs
https://bugs.documentfoundation.org/show_bug.cgi?id=94524 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||124891 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124891 [Bug 124891] [META] Basic IDE bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123540] Basic "Tutorials" library is missing in Basic IDE
https://bugs.documentfoundation.org/show_bug.cgi?id=123540 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||124891 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124891 [Bug 124891] [META] Basic IDE bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94527] IDE (Integrated Development Environment) Handling of case in constant names
https://bugs.documentfoundation.org/show_bug.cgi?id=94527 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||124891 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124891 [Bug 124891] [META] Basic IDE bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66185] Feature request: IDE - Code auto complete for writing macros
https://bugs.documentfoundation.org/show_bug.cgi?id=66185 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||124891 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124891 [Bug 124891] [META] Basic IDE bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124891] New: [META] Basic IDE bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=124891 Bug ID: 124891 Summary: [META] Basic IDE bugs and enhancements Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: 79045_79...@mail.ru Description: There are many bugs and enhs for IDE. Let's collect it here Steps to Reproduce: - Actual Results: - Expected Results: - Reproducible: Always User Profile Reset: No Additional Info: - -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124844] After adding a caption to an image the text cursor disappears, making it unable to input text
https://bugs.documentfoundation.org/show_bug.cgi?id=124844 --- Comment #7 from JORGETECH --- I'll do it and send it when ready -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 124764] Paste structured text without format but with styles
https://bugs.documentfoundation.org/show_bug.cgi?id=124764 Cor Nouws changed: What|Removed |Added Status|NEW |NEEDINFO Component|framework |LibreOffice --- Comment #6 from Cor Nouws --- Hi Eric, (In reply to Eric L. from comment #0) > In all tools, especially Writer and Impress, but also the others, if you > cut text or objects from one document to the next, you get each time > new styles Default_1 etc, even if the two documents are actually different > versions of the same document that you are merging back, and the styles are > actually the same. I do not recognize this. In my experience: Copy from B to A: text with style X gets the formatting that is has in document A íf the style is already in use. > But even if you paste text from different documents/styles, you generally > want the final text to look all the same and not want e.g. "body" text to > look in 3 different ways in your text or presentation. Can you give some sample documents? version A and B of each in Writer and Impress please? What version did you see this? Greetings, Cor -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 124764] Paste structured text without format but with styles
https://bugs.documentfoundation.org/show_bug.cgi?id=124764 Cor Nouws changed: What|Removed |Added Status|NEW |NEEDINFO Component|framework |LibreOffice --- Comment #6 from Cor Nouws --- Hi Eric, (In reply to Eric L. from comment #0) > In all tools, especially Writer and Impress, but also the others, if you > cut text or objects from one document to the next, you get each time > new styles Default_1 etc, even if the two documents are actually different > versions of the same document that you are merging back, and the styles are > actually the same. I do not recognize this. In my experience: Copy from B to A: text with style X gets the formatting that is has in document A íf the style is already in use. > But even if you paste text from different documents/styles, you generally > want the final text to look all the same and not want e.g. "body" text to > look in 3 different ways in your text or presentation. Can you give some sample documents? version A and B of each in Writer and Impress please? What version did you see this? Greetings, Cor -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70882] FormulaResultType return VALUE for cells with formula result #DIV/0! or #NAME?
https://bugs.documentfoundation.org/show_bug.cgi?id=70882 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||107659 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107659 [Bug 107659] [META] Macro bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107659] [META] Macro bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107659 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||70882 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=70882 [Bug 70882] FormulaResultType return VALUE for cells with formula result #DIV/0! or #NAME? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107659] [META] Macro bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107659 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||70843 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=70843 [Bug 70843] Other: XFilePicker's setDisplayDirectory and setDefaultName do not work -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70843] Other: XFilePicker's setDisplayDirectory and setDefaultName do not work
https://bugs.documentfoundation.org/show_bug.cgi?id=70843 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||107659 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107659 [Bug 107659] [META] Macro bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108897] [META] XLSX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=108897 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||124231 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124231 [Bug 124231] Day function for creating date is off by one -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108827] [META] Calc functions bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108827 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||124231 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124231 [Bug 124231] Day function for creating date is off by one -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124231] Day function for creating date is off by one
https://bugs.documentfoundation.org/show_bug.cgi?id=124231 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||108827, 108897 Keywords||filter:xlsx Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108827 [Bug 108827] [META] Calc functions bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108897 [Bug 108897] [META] XLSX (OOXML) bug tracker -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 110456] Add icons to Beanshell Editor Toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=110456 --- Comment #5 from andreas_k --- please verify which icons are really needed cause otherwise I can't fix this bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121213] Autocorrection of Function Parameters and Static variables does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=121213 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||107659, 103341 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103341 [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=107659 [Bug 107659] [META] Macro bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103341 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||121213 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=121213 [Bug 121213] Autocorrection of Function Parameters and Static variables does not work -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107659] [META] Macro bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107659 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||121213 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=121213 [Bug 121213] Autocorrection of Function Parameters and Static variables does not work -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107659] [META] Macro bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107659 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||121101 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=121101 [Bug 121101] Function parameter can duplicate dimension variable declaration -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121101] Function parameter can duplicate dimension variable declaration
https://bugs.documentfoundation.org/show_bug.cgi?id=121101 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||107659 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107659 [Bug 107659] [META] Macro bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107659] [META] Macro bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107659 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||116676 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=116676 [Bug 116676] Function insertTextPortion() of XTextPortionAppend Interface doesn't work -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116676] Function insertTextPortion() of XTextPortionAppend Interface doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=116676 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||107659 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107659 [Bug 107659] [META] Macro bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97624] Icons for uppercase/lowercase and AutoCorrect commands are missing
https://bugs.documentfoundation.org/show_bug.cgi?id=97624 andreas_k changed: What|Removed |Added Resolution|--- |FIXED CC||kain...@gmail.com Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
