[Libreoffice-bugs] [Bug 124931] UI: in dialog Customize, a key stroke with the focus in the list Shortcut Keys doesn't select the key combination

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124931

raal  changed:

   What|Removed |Added

 CC||caol...@redhat.com,
   ||r...@post.cz
   Keywords|bibisectRequest |bibisected, bisected
 OS|Linux (All) |All

--- Comment #3 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Caolán McNamara ; Could you possibly take a look at this one?
Thanks
19b251a0d9518d8c4b5d7ba372198f21b21d7789 is the first bad commit
commit 19b251a0d9518d8c4b5d7ba372198f21b21d7789
Author: Jenkins Build User 
Date:   Wed Mar 6 02:08:26 2019 +0100

source sha:8ee19e3b6d8c1642da8377583482ca0fd4d30139

author  Caolán McNamara 2019-03-03 21:43:07 +
committer   Caolán McNamara 2019-03-05 17:34:34
+0100
commit  8ee19e3b6d8c1642da8377583482ca0fd4d30139 (patch)
tree1bad6d1ab971cd6b71f63af4076cab73e34e2ba7
parent  db8b4d8c58e808f645a5d854b73c8a8132e2d898 (diff)
weld SfxAcceleratorConfigPage

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - compilerplugins/clang

[Andrea Gelmini (via logerrit)]

 compilerplugins/clang/store/cascadingcondop.hxx|2 +-
 compilerplugins/clang/store/tutorial/tutorial1.hxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 15b8ffbe0d99606529dafebb33c529a091797286
Author: Andrea Gelmini 
AuthorDate: Wed Apr 24 13:21:17 2019 +
Commit: Julien Nabet 
CommitDate: Sun Apr 28 07:40:57 2019 +0200

Fix typo

Change-Id: Id6985abca7702039168381082da4e47603b9aaf3
Reviewed-on: https://gerrit.libreoffice.org/71451
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/compilerplugins/clang/store/tutorial/tutorial1.hxx 
b/compilerplugins/clang/store/tutorial/tutorial1.hxx
index 59f115147780..a296ab2cf27b 100644
--- a/compilerplugins/clang/store/tutorial/tutorial1.hxx
+++ b/compilerplugins/clang/store/tutorial/tutorial1.hxx
@@ -19,7 +19,7 @@ namespace loplugin
 
 // The class implementing the plugin action.
 class Tutorial1
-// Inherits from the Clang class that will allow examing the Clang AST 
tree (i.e. syntax tree).
+// Inherits from the Clang class that will allow examining the Clang AST 
tree (i.e. syntax tree).
 : public FilteringPlugin< Tutorial1 >
 {
 public:
commit 4f3c39b3953098cb0f93eb2ba1f0a20bb071e713
Author: Andrea Gelmini 
AuthorDate: Wed Apr 24 13:21:18 2019 +
Commit: Julien Nabet 
CommitDate: Sun Apr 28 07:40:46 2019 +0200

Fix typo

Change-Id: I8c928576919c9410eda0a7f33b2120d13c3bc6bf
Reviewed-on: https://gerrit.libreoffice.org/71450
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/compilerplugins/clang/store/cascadingcondop.hxx 
b/compilerplugins/clang/store/cascadingcondop.hxx
index 5bdf11093957..f2c995064eb4 100644
--- a/compilerplugins/clang/store/cascadingcondop.hxx
+++ b/compilerplugins/clang/store/cascadingcondop.hxx
@@ -21,7 +21,7 @@ struct WalkCounter;
 
 // The class implementing the plugin action.
 class CascadingCondOp
-// Inherits from the Clang class that will allow examing the Clang AST 
tree (i.e. syntax tree).
+// Inherits from the Clang class that will allow examining the Clang AST 
tree (i.e. syntax tree).
 : public FilteringPlugin< CascadingCondOp >
 {
 public:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: filter/source

[Andrea Gelmini (via logerrit)]

 filter/source/msfilter/msdffimp.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 3159ba99d16bf875c28b77c1219a794d9e9a6186
Author: Andrea Gelmini 
AuthorDate: Sat Apr 27 22:49:24 2019 +
Commit: Julien Nabet 
CommitDate: Sun Apr 28 07:41:49 2019 +0200

Removed duplicated include

Change-Id: Ia5809ac7ff74652e5d83ef2dbc176c4f586b7203
Reviewed-on: https://gerrit.libreoffice.org/71449
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/filter/source/msfilter/msdffimp.cxx 
b/filter/source/msfilter/msdffimp.cxx
index 389907baed39..0f0e52aab0d3 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -97,7 +97,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124729] Impress reliably crashes on THIS PowerPoint document in Linux

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124729

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #10 from raal  ---
No repro Version: 6.3.0.0.alpha0+
Build ID: e913727c7ee3af0bb4031c6829abfb3373306492
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3;

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124916] LibreOffice Calc keyboard stops working after "Delete cell" dialogue window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124916

--- Comment #1 from b.  ---
no repro with ver: 

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 35d9a2618dc0116378ab795a7b9277d248c5afd4
CPU threads: 8; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-04-05_04:55:04
Locale: de-DE (de_DE); UI-Language: en-US
Calc: *unthreaded*

*threaded* not tested, above ver. is known buggy in threaded, all subsequent
known for crashing, 

reg. 

b.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124939] editing cell does not follow edit line

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124939

--- Comment #5 from b.  ---
additional, don't know if intentional, 

in both above versions switch to overwrite mode is persistent from one edit to
the next for the edit-bar, but not! for a cell, cell edit always starts in
insert mode. 

reg. 

b.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124939] editing cell does not follow edit line

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124939

b.  changed:

   What|Removed |Added

 CC||newbie...@gmx.de

--- Comment #4 from b.  ---
funny thing, 

repro in: 

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 35d9a2618dc0116378ab795a7b9277d248c5afd4
CPU threads: 8; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-04-05_04:55:04
Locale: de-DE (de_DE); UI-Language: en-US
Calc: *unthreaded*

on first try it looked like 'no repro', started described behaviour after first
use of ctrl-shift-F2 to enter edit (first try had been just clicking in the
edit-bar) and persisted after that also when switching back to enter with
mouseclick. 

bibisection looks wrong, 

also repro with ver: 

Version: 4.1.6.2
Build ID: 40ff705089295be5be0aae9b15123f687c05b0a

but! ... not on first try, but on second!

used a new file and entered '=A1' in cell A3

reg. 

b.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124943] Copy to edit bar adds a suffix space, that is inconsistent with paste to cell.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124943

b.  changed:

   What|Removed |Added

 CC||newbie...@gmx.de

--- Comment #3 from b.  ---
repro with: 

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 35d9a2618dc0116378ab795a7b9277d248c5afd4
CPU threads: 8; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-04-05_04:55:04
Locale: de-DE (de_DE); UI-Language: en-US
Calc: *unthreaded*

that's fucking user data and building invisible traps, pls. remove this
'feature' afap. 

reg. 

b.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125006] New: UI: Table Tooltips not Displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125006

Bug ID: 125006
   Summary: UI: Table Tooltips not Displayed
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lukebe...@hotmail.com

Created attachment 151050
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151050=edit
Screenshot of OpenOffice Table Tooltips

None of the in-document table tooltips are displayed anymore. 

Steps to reproduce:
1. In writer, Insert table
2. Move mouse to edge or corner of table
3. Wait

Expected results
1. A tooltip pops up

Actual results:
1. Nothing

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: drawinglayer/source filter/source include/vcl sd/source slideshow/source svx/source vcl/source

[Tomaž Vajngerl (via logerrit)]

 drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx |   32 +--
 filter/source/graphicfilter/egif/egif.cxx|6 
 filter/source/graphicfilter/etiff/etiff.cxx  |4 
 include/vcl/animate/AnimationBitmap.hxx  |   49 +++--
 sd/source/ui/dlg/animobjs.cxx|   22 +-
 slideshow/source/engine/shapes/gdimtftools.cxx   |   34 ++--
 svx/source/dialog/_bmpmask.cxx   |   12 -
 svx/source/dialog/_contdlg.cxx   |4 
 svx/source/xoutdev/_xoutbmp.cxx  |   14 -
 vcl/source/animate/Animation.cxx |   90 +--
 vcl/source/animate/AnimationBitmap.cxx   |   16 -
 vcl/source/bitmap/bitmapfilter.cxx   |2 
 vcl/source/filter/igif/gifread.cxx   |   30 +--
 vcl/source/gdi/impanmvw.cxx  |   18 +-
 vcl/source/graphic/GraphicObject.cxx |   18 +-
 15 files changed, 181 insertions(+), 170 deletions(-)

New commits:
commit 6bcc4cb109b4ab6ec194a04c53cf1d545a7a7dfd
Author: Tomaž Vajngerl 
AuthorDate: Sat Apr 27 23:08:01 2019 +0900
Commit: Tomaž Vajngerl 
CommitDate: Sun Apr 28 05:31:16 2019 +0200

prefix member variables of AnimationBitmap

Change-Id: Ic84773399c95d61f843e4388fe01d00cd4facc5a
Reviewed-on: https://gerrit.libreoffice.org/71425
Reviewed-by: Tomaž Vajngerl 
Tested-by: Tomaž Vajngerl 

diff --git a/drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx 
b/drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx
index 5ad8ad359c0c..76dce81832ba 100644
--- a/drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx
+++ b/drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx
@@ -114,13 +114,13 @@ namespace drawinglayer
 
 sal_uInt32 generateStepTime(sal_uInt32 nIndex) const
 {
-const AnimationBitmap& rAnimBitmap = 
maAnimation.Get(sal_uInt16(nIndex));
-sal_uInt32 nWaitTime(rAnimBitmap.nWait * 10);
+const AnimationBitmap& rAnimationBitmap = 
maAnimation.Get(sal_uInt16(nIndex));
+sal_uInt32 nWaitTime(rAnimationBitmap.mnWait * 10);
 
 // Take care of special value for MultiPage TIFFs. ATM these 
shall just
 // show their first page. Later we will offer some switching 
when object
 // is selected.
-if (ANIMATION_TIMEOUT_ON_CLICK == rAnimBitmap.nWait)
+if (ANIMATION_TIMEOUT_ON_CLICK == rAnimationBitmap.mnWait)
 {
 // ATM the huge value would block the timer, so
 // use a long time to show first page (whole day)
@@ -233,14 +233,14 @@ namespace drawinglayer
 while (mnNextFrameToPrepare <= nTarget)
 {
 // prepare step
-const AnimationBitmap& rAnimBitmap = 
maAnimation.Get(sal_uInt16(mnNextFrameToPrepare));
+const AnimationBitmap& rAnimationBitmap = 
maAnimation.Get(sal_uInt16(mnNextFrameToPrepare));
 
-switch (rAnimBitmap.eDisposal)
+switch (rAnimationBitmap.meDisposal)
 {
 case Disposal::Not:
 {
-
maVirtualDevice->DrawBitmapEx(rAnimBitmap.aPosPix, rAnimBitmap.aBmpEx);
-Bitmap aMask = rAnimBitmap.aBmpEx.GetMask();
+
maVirtualDevice->DrawBitmapEx(rAnimationBitmap.maPositionPixel, 
rAnimationBitmap.maBitmapEx);
+Bitmap aMask = 
rAnimationBitmap.maBitmapEx.GetMask();
 
 if (aMask.IsEmpty())
 {
@@ -252,7 +252,7 @@ namespace drawinglayer
 else
 {
 BitmapEx aExpandVisibilityMask = 
BitmapEx(aMask, aMask);
-
maVirtualDeviceMask->DrawBitmapEx(rAnimBitmap.aPosPix, aExpandVisibilityMask);
+
maVirtualDeviceMask->DrawBitmapEx(rAnimationBitmap.maPositionPixel, 
aExpandVisibilityMask);
 }
 
 break;
@@ -260,15 +260,15 @@ namespace drawinglayer
 case Disposal::Back:
 {
 // #i70772# react on no mask, for primitives, 
too.
-const Bitmap 
aMask(rAnimBitmap.aBmpEx.GetMask());
-const Bitmap 
aContent(rAnimBitmap.aBmpEx.GetBitmap());
+const Bitmap 
aMask(rAnimationBitmap.maBitmapEx.GetMask());
+

[Libreoffice-commits] core.git: include/vcl solenv/clang-format vcl/source

[Tomaž Vajngerl (via logerrit)]

 include/vcl/animate/Animation.hxx   |  129 +++-
 include/vcl/animate/AnimationBitmap.hxx |   68 +---
 solenv/clang-format/blacklist   |4 
 vcl/source/animate/Animation.cxx|  486 +++-
 vcl/source/animate/AnimationBitmap.cxx  |   32 +-
 5 files changed, 339 insertions(+), 380 deletions(-)

New commits:
commit 9afa666120d8bb045f3569a77475a58c368c03a1
Author: Tomaž Vajngerl 
AuthorDate: Sat Apr 27 21:48:24 2019 +0900
Commit: Tomaž Vajngerl 
CommitDate: Sun Apr 28 05:29:54 2019 +0200

move Animation, AnimationBitmap out from clang-format blacklist

Change-Id: I95fd2d4e164bf04c4457b3e20401270227e21a8f
Reviewed-on: https://gerrit.libreoffice.org/71424
Reviewed-by: Tomaž Vajngerl 
Tested-by: Tomaž Vajngerl 

diff --git a/include/vcl/animate/Animation.hxx 
b/include/vcl/animate/Animation.hxx
index c642c3b283d9..b8b390bb0644 100644
--- a/include/vcl/animate/Animation.hxx
+++ b/include/vcl/animate/Animation.hxx
@@ -31,102 +31,85 @@ class ImplAnimView;
 class VCL_DLLPUBLIC Animation
 {
 public:
-Animation();
-Animation( const Animation& rAnimation );
-~Animation();
+Animation();
+Animation(const Animation& rAnimation);
+~Animation();
 
-Animation&  operator=( const Animation& rAnimation );
-booloperator==( const Animation& rAnimation ) const;
-booloperator!=( const Animation& rAnimation ) const
-{ return !(*this==rAnimation); }
+Animation& operator=(const Animation& rAnimation);
+bool operator==(const Animation& rAnimation) const;
+bool operator!=(const Animation& rAnimation) const { return !(*this == 
rAnimation); }
 
-voidClear();
+void Clear();
 
-boolStart(
-OutputDevice* pOutDev,
-const Point& rDestPt,
-const Size& rDestSz,
-long nExtraData,
-OutputDevice* pFirstFrameOutDev);
+bool Start(OutputDevice* pOutDev, const Point& rDestPt, const Size& 
rDestSz, long nExtraData,
+   OutputDevice* pFirstFrameOutDev);
 
-voidStop( OutputDevice* pOutDev = nullptr, long nExtraData = 0 
);
+void Stop(OutputDevice* pOutDev = nullptr, long nExtraData = 0);
 
-voidDraw( OutputDevice* pOutDev, const Point& rDestPt ) const;
-voidDraw( OutputDevice* pOutDev, const Point& rDestPt, const 
Size& rDestSz ) const;
+void Draw(OutputDevice* pOutDev, const Point& rDestPt) const;
+void Draw(OutputDevice* pOutDev, const Point& rDestPt, const Size& 
rDestSz) const;
 
-boolIsInAnimation() const { return mbIsInAnimation; }
-boolIsTransparent() const;
+bool IsInAnimation() const { return mbIsInAnimation; }
+bool IsTransparent() const;
 
-const Size& GetDisplaySizePixel() const { return maGlobalSize; }
-voidSetDisplaySizePixel( const Size& rSize ) { maGlobalSize = 
rSize; }
+const Size& GetDisplaySizePixel() const { return maGlobalSize; }
+void SetDisplaySizePixel(const Size& rSize) { maGlobalSize = rSize; }
 
 const BitmapEx& GetBitmapEx() const { return maBitmapEx; }
-voidSetBitmapEx( const BitmapEx& rBmpEx ) { maBitmapEx = 
rBmpEx; }
+void SetBitmapEx(const BitmapEx& rBmpEx) { maBitmapEx = rBmpEx; }
 
-sal_uInt32  GetLoopCount() const { return mnLoopCount; }
-voidSetLoopCount(const sal_uInt32 nLoopCount);
-voidResetLoopCount();
+sal_uInt32 GetLoopCount() const { return mnLoopCount; }
+void SetLoopCount(const sal_uInt32 nLoopCount);
+void ResetLoopCount();
 
-voidSetNotifyHdl( const Link& rLink ) { 
maNotifyLink = rLink; }
-const Link& GetNotifyHdl() const { return maNotifyLink; }
+void SetNotifyHdl(const Link& rLink) { maNotifyLink = 
rLink; }
+const Link& GetNotifyHdl() const { return maNotifyLink; }
 
-std::vector< std::unique_ptr >& GetAnimationFrames() { 
return maList; }
-size_t  Count() const { return maList.size(); }
-boolInsert( const AnimationBitmap& rAnimationBitmap );
-const AnimationBitmap&
-Get( sal_uInt16 nAnimation ) const;
-voidReplace( const AnimationBitmap& rNewAnimationBmp, 
sal_uInt16 nAnimation );
+std::vector>& GetAnimationFrames() { 
return maList; }
+size_t Count() const { return maList.size(); }
+bool Insert(const AnimationBitmap& rAnimationBitmap);
+const AnimationBitmap& Get(sal_uInt16 nAnimation) const;
+void Replace(const AnimationBitmap& rNewAnimationBmp, sal_uInt16 
nAnimation);
 
-sal_uLong   GetSizeBytes() const;
-BitmapChecksum  GetChecksum() const;
+sal_uLong GetSizeBytes() const;
+BitmapChecksum GetChecksum() const;
 
 public:
+void Convert(BmpConversion 

[Libreoffice-bugs] [Bug 93156] Middle-of-connector anchor doesn't update its targets when moved

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93156

--- Comment #11 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117284] Off centered app image in macOS lang pack image (dmg)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117284

--- Comment #3 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 40472] FORMATTING: Cannot format the DataPilot headers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=40472

--- Comment #8 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108582] NVDA Screen Review mode dropping letters and running together words when sounding, Object Review mode correctly sounds words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108582

--- Comment #25 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92628] EDITING: Double click in formula sometimes gets wrong word boundaries

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92628

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89565] Icon Transparency on the toolbar Mode is not available for all figures from the Drawing toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89565

--- Comment #8 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - accessibility/inc basctl/inc chart2/inc cppcanvas/inc cui/inc dbaccess/inc desktop/inc drawinglayer/source filter/source framework/inc include/svx include/v

[Tomaž Vajngerl (via logerrit)]

 accessibility/inc/pch/precompiled_acc.hxx|2 
 basctl/inc/pch/precompiled_basctl.hxx|2 
 chart2/inc/pch/precompiled_chartcontroller.hxx   |2 
 cppcanvas/inc/pch/precompiled_cppcanvas.hxx  |2 
 cui/inc/pch/precompiled_cui.hxx  |2 
 dbaccess/inc/pch/precompiled_dba.hxx |2 
 dbaccess/inc/pch/precompiled_dbmm.hxx|2 
 desktop/inc/pch/precompiled_sofficeapp.hxx   |2 
 drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx |2 
 filter/source/graphicfilter/ieps/ieps.cxx|2 
 filter/source/graphicfilter/itiff/itiff.cxx  |2 
 framework/inc/pch/precompiled_fwe.hxx|2 
 framework/inc/pch/precompiled_fwk.hxx|2 
 framework/inc/pch/precompiled_fwl.hxx|2 
 include/svx/bmpmask.hxx  |2 
 include/vcl/animate/Animation.hxx|   62 
 include/vcl/animate/AnimationBitmap.hxx  |   83 +++
 include/vcl/graph.hxx|2 
 oox/inc/pch/precompiled_oox.hxx  |2 
 reportdesign/inc/pch/precompiled_rpt.hxx |2 
 reportdesign/inc/pch/precompiled_rptui.hxx   |2 
 sc/inc/pch/precompiled_sc.hxx|2 
 sc/inc/pch/precompiled_scfilt.hxx|2 
 sd/inc/pch/precompiled_sdui.hxx  |2 
 slideshow/inc/pch/precompiled_slideshow.hxx  |2 
 slideshow/source/engine/shapes/gdimtftools.cxx   |2 
 solenv/clang-format/blacklist|6 
 svx/inc/pch/precompiled_svxcore.hxx  |2 
 sw/inc/pch/precompiled_msword.hxx|2 
 sw/inc/pch/precompiled_swui.hxx  |2 
 sw/inc/pch/precompiled_vbaswobj.hxx  |2 
 vbahelper/inc/pch/precompiled_msforms.hxx|2 
 vcl/Library_vcl.mk   |3 
 vcl/inc/graphic/Manager.hxx  |2 
 vcl/inc/impanmvw.hxx |2 
 vcl/source/animate/Animation.cxx |   33 
 vcl/source/animate/AnimationBitmap.cxx   |   54 +++
 vcl/source/bitmap/bitmapfilter.cxx   |2 
 vcl/source/graphic/GraphicObject2.cxx|2 
 39 files changed, 181 insertions(+), 126 deletions(-)

New commits:
commit 5c3ae69f03eee5deddcaa4673b4fbab062f6c66a
Author: Tomaž Vajngerl 
AuthorDate: Sat Apr 27 21:44:12 2019 +0900
Commit: Tomaž Vajngerl 
CommitDate: Sun Apr 28 04:14:22 2019 +0200

Separate AnimationBitmap from Animation.{hxx,cxx} source

Change-Id: I982a108b2241c049b595a13d6f39d24ef0266074
Reviewed-on: https://gerrit.libreoffice.org/71423
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/vcl/animate/Animation.hxx 
b/include/vcl/animate/Animation.hxx
index 8b40ddeaa71a..c642c3b283d9 100644
--- a/include/vcl/animate/Animation.hxx
+++ b/include/vcl/animate/Animation.hxx
@@ -22,64 +22,10 @@
 
 #include 
 #include 
-#include 
+#include 
 
 #define ANIMATION_TIMEOUT_ON_CLICK 2147483647L
 
-enum class Disposal
-{
-Not,
-Back,
-Previous
-};
-
-struct VCL_DLLPUBLIC AnimationBitmap
-{
-BitmapExaBmpEx;
-Point   aPosPix;
-SizeaSizePix;
-longnWait;
-DisposaleDisposal;
-boolbUserInput;
-
-AnimationBitmap()
-: nWait(0)
-, eDisposal(Disposal::Not)
-, bUserInput(false)
-{}
-
-AnimationBitmap(
-const BitmapEx& rBmpEx,
-const Point& rPosPix,
-const Size& rSizePix,
-long _nWait = 0,
-Disposal _eDisposal = Disposal::Not
-) :
-aBmpEx  ( rBmpEx ),
-aPosPix ( rPosPix ),
-aSizePix( rSizePix ),
-nWait   ( _nWait ),
-eDisposal   ( _eDisposal ),
-bUserInput  ( false )
-{}
-
-booloperator==( const AnimationBitmap& rAnimBmp ) const
-{
-return( rAnimBmp.aBmpEx == aBmpEx &&
-rAnimBmp.aPosPix == aPosPix &&
-rAnimBmp.aSizePix == 

Toner compatibili - listini di Primavera e grandi sconti - Chiedici un preventivo

[Toner compatibili a basso costo]

TONER COMPATIBILI DI ALTA QUALITA'

 

Prezzi molto bassi rispetto ai toner originali ma senza compromettere la 
qualita'

 

Selezioniamo i migliori Toner per offrirti la massima qualita', I nostri toner 
hanno qualita' e durata paragonabili agli originali e vengono supervisionati e 
testati per assicurarare la massima qualita'

 

Rispondi a questa email indicando il modello della tua stampante, ti invieremo 
un preventivo

 

Se rispondi a questa email ti invieremo anche tutti i nostri contatti aziendali 
e le nostre recensioni, cosi' potrai valutare la nostra serieta'.

 

 

Se hai ricevuto questa email per errore, per favore comunicacelo, Nel caso 
desideri essere cancellato rispondi a questa email con "cancellami" Oppure 
premi qui ed invia per cancellarti

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 125005] New: Formatting changed on document using 6.0 or later

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125005

Bug ID: 125005
   Summary: Formatting changed on document using 6.0 or later
   Product: LibreOffice
   Version: 6.0.0.3 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: beckx...@audtoo.com

Description:
I have a doc that I've used for many years. Only a change every year. Opened
often to print. Formatting correct in versions through 5.4.7.2. After that when
opened the formatting is wrecked on second page and another page is added. Fix
it using 6.0+ and it will print ok. But saving and reopening the file wrecks
the formatting worse. Opening this wrecked file in 5.4.7.2 shows a correctly
formatted file. I've had to revert all PCs back to 5.4.7.2 to be compatible. I
thought this would affect many people and would get fixed. But I guess not.

Steps to Reproduce:
1. Open my file
2.
3.

Actual Results:
Opens and or saves bad formatting of file

Expected Results:
I expected to open the file and have it be correct.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
I will provide the file for someone to fix it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125004] New: Multiple Sheet Windows Open ABENDS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125004

Bug ID: 125004
   Summary: Multiple Sheet Windows Open ABENDS
   Product: LibreOffice
   Version: 6.2.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: j...@higgs-tx.com

Mint 18

Open a calc document; open another window on that document or any other
document; application will break.

Open a calc document; open a presentation document; at some point, the
application will break.

At this point, you may have more than 30 logged errors as I do ask that the
program send them all to you.

Very frustrating, right?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108741] [META] Shapes bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108741

Aron Budea  changed:

   What|Removed |Added

 Depends on||124989


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=124989
[Bug 124989] Default shape name should refer to kind of shape instead of just
Shape
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 34828] Navigator item "Draw objects" in Calc does not show Draw objects without name (Writer fixed in the mean time..)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=34828

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||4989

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 34828] Navigator item "Draw objects" in Calc does not show Draw objects without name (Writer fixed in the mean time..)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=34828

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||4989

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124989] Default shape name should refer to kind of shape instead of just Shape

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124989

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=34
   ||828
Summary|default shape name  |Default shape name should
   ||refer to kind of shape
   ||instead of just Shape
 Status|UNCONFIRMED |NEW
 CC||ba...@caesar.elte.hu
 Blocks||108741
 Ever confirmed|0   |1

--- Comment #1 from Aron Budea  ---
Right, this has been brought up as part of bug 34828 (ie. see bug 34828 comment
10), but that ticket isn't particularly about this, so a separate bug report
seems appropriate.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108741
[Bug 108741] [META] Shapes bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103461] [META] Elements pane/dock/window/sidebar in Math

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103461
Bug 103461 depends on bug 124944, which changed state.

Bug 124944 Summary: Math Elements pane -> Attributes, the color name label 
strings localized using mixed CJK & western glyphs overlap, making GUI label 
unreadable (zh-CN)
https://bugs.documentfoundation.org/show_bug.cgi?id=124944

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71732
Bug 71732 depends on bug 124944, which changed state.

Bug 124944 Summary: Math Elements pane -> Attributes, the color name label 
strings localized using mixed CJK & western glyphs overlap, making GUI label 
unreadable (zh-CN)
https://bugs.documentfoundation.org/show_bug.cgi?id=124944

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124944] Math Elements pane -> Attributes, the color name label strings localized using mixed CJK & western glyphs overlap, making GUI label unreadable (zh-CN)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124944

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124944] Math Elements pane -> Attributes, the color name label strings localized using mixed CJK & western glyphs overlap, making GUI label unreadable (zh-CN)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124944

--- Comment #10 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/13e716b2cfce4d093d74b3a552251deb9f3b6832%5E%21

tdf#124944 don't directly adjust fallback layouts

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/source

[Jan-Marek Glogowski (via logerrit)]

 vcl/source/outdev/font.cxx |2 --
 1 file changed, 2 deletions(-)

New commits:
commit 13e716b2cfce4d093d74b3a552251deb9f3b6832
Author: Jan-Marek Glogowski 
AuthorDate: Sat Apr 27 21:38:56 2019 +0200
Commit: Jan-Marek Glogowski 
CommitDate: Sun Apr 28 00:51:52 2019 +0200

tdf#124944 don't directly adjust fallback layouts

These are adjusted via MultiSalLayout::AdjustLayout, as they
just know their own text width, but not the full text width of
the MultiSalLayout, so the adjustment is too large.

The correct adjustment is done by preparing a DXArray for all
glyphs, which is then passed to the individual font fallback
layouts for general adjustment.

Change-Id: I439527d03df4752e74ff94aee7775a95275be5e2
Reviewed-on: https://gerrit.libreoffice.org/71440
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/vcl/source/outdev/font.cxx b/vcl/source/outdev/font.cxx
index c3f7343bb823..65fb116ae047 100644
--- a/vcl/source/outdev/font.cxx
+++ b/vcl/source/outdev/font.cxx
@@ -1332,8 +1332,6 @@ std::unique_ptr 
OutputDevice::getFallbackLayout(
 return nullptr;
 }
 
-pFallback->AdjustLayout( rLayoutArgs );
-
 return pFallback;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124944] Math Elements pane -> Attributes, the color name label strings localized using mixed CJK & western glyphs overlap, making GUI label unreadable (zh-CN)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124944

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: starmath/source vcl/source

[Jan-Marek Glogowski (via logerrit)]

 starmath/source/ElementsDockingWindow.cxx |   15 ---
 vcl/source/outdev/text.cxx|5 +++--
 2 files changed, 11 insertions(+), 9 deletions(-)

New commits:
commit ee57d5253a2ee054b06a4158204bda1a8fc3b5dc
Author: Jan-Marek Glogowski 
AuthorDate: Sat Apr 27 20:43:37 2019 +
Commit: Jan-Marek Glogowski 
CommitDate: Sun Apr 28 00:49:02 2019 +0200

Minimize scope of variables

Change-Id: I6602c84b9bd7143e5e7b224c17559b083c9b7f9c
Reviewed-on: https://gerrit.libreoffice.org/71439
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/starmath/source/ElementsDockingWindow.cxx 
b/starmath/source/ElementsDockingWindow.cxx
index bb15c28d11a4..f093723daf2a 100644
--- a/starmath/source/ElementsDockingWindow.cxx
+++ b/starmath/source/ElementsDockingWindow.cxx
@@ -334,8 +334,6 @@ void 
SmElementsControl::LayoutOrPaintContents(vcl::RenderContext *pContext)
 }
 else
 {
-Size aSizePixel = LogicToPixel(Size(element->getNode()->GetWidth(),
-
element->getNode()->GetHeight()));
 if (mbVerticalMode)
 {
 if (y + boxY > nControlHeight)
@@ -363,14 +361,17 @@ void 
SmElementsControl::LayoutOrPaintContents(vcl::RenderContext *pContext)
 pContext->Pop();
 }
 
-Point location(x + ((boxX - aSizePixel.Width()) / 2),
-   y + ((boxY - aSizePixel.Height()) / 2));
+element->mBoxLocation = Point(x,y);
+element->mBoxSize = Size(boxX, boxY);
 
 if (pContext)
+{
+Size aSizePixel = 
LogicToPixel(Size(element->getNode()->GetWidth(),
+
element->getNode()->GetHeight()));
+Point location(x + ((boxX - aSizePixel.Width()) / 2),
+   y + ((boxY - aSizePixel.Height()) / 2));
 SmDrawingVisitor(*pContext, PixelToLogic(location), 
element->getNode().get());
-
-element->mBoxLocation = Point(x,y);
-element->mBoxSize = Size(boxX, boxY);
+}
 
 if (mbVerticalMode)
 y += boxY;
diff --git a/vcl/source/outdev/text.cxx b/vcl/source/outdev/text.cxx
index 68b7a4ffc250..fb3092739ffc 100644
--- a/vcl/source/outdev/text.cxx
+++ b/vcl/source/outdev/text.cxx
@@ -1264,14 +1264,15 @@ std::unique_ptr 
OutputDevice::ImplLayout(const OUString& rOrigStr,
 pLayoutCache = nullptr; // don't use cache with modified string!
 pGlyphs = nullptr;
 }
+
 DeviceCoordinate nPixelWidth = 
static_cast(nLogicalWidth);
-std::unique_ptr xDXPixelArray;
-DeviceCoordinate* pDXPixelArray(nullptr);
 if( nLogicalWidth && mbMap )
 {
 nPixelWidth = LogicWidthToDeviceCoordinate( nLogicalWidth );
 }
 
+std::unique_ptr xDXPixelArray;
+DeviceCoordinate* pDXPixelArray(nullptr);
 if( pDXArray)
 {
 if(mbMap)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

CppCheck Report Failure

[cppcheck.libreoff...@gmail.com]

The cppcheck job failed with message: "Failed to run cppcheck."


Note:
The script generating this report was run at :
2019-28-04 00:28:17 with user buildslave at host vm140 as 
/home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s 
/home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w 
/home/buildslave/tmp/www

It can be found and improved here:

https://gerrit.libreoffice.org/plugins/gitiles/dev-tools/+/master/cppcheck/cppcheck-report.sh




cppcheck-report.log.gz
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 114773] TOC: Remove additional space after chapter number in ToC

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114773

--- Comment #19 from Yvan Rose  ---
This issue was introduced with version 5.3 of LO. It's possible that OO had it
independently (I didn't verify) but LO 5.2.7 does not have this issue, while
every  subsequent version of LO has been affected by it to this day. If I
could, I would pay to see it gone, so I can start promoting LO again as the
best system to write long, structured documents (with ToCs and all).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 78916] Custom page size missing from print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78916

--- Comment #27 from huber.jos...@tx.rr.com ---
My version is

Version: 6.2.2.2
Build ID: 1:6.2.2-0ubuntu0.16.04.1~lo1

which is not that far behind the latest release of 6.2.3, but still newer than
the LTS version of 6.1.5.

Both my printers allow custom page size, and custom page sizes work fine with
other Ubuntu applications (such as the FireFox screenshot I showed), and with
Microsoft Office running both in both Windows and on Ubuntu via Wine.

I look forward to this issue being finally addressed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 78916] Custom page size missing from print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78916

--- Comment #27 from huber.jos...@tx.rr.com ---
My version is

Version: 6.2.2.2
Build ID: 1:6.2.2-0ubuntu0.16.04.1~lo1

which is not that far behind the latest release of 6.2.3, but still newer than
the LTS version of 6.1.5.

Both my printers allow custom page size, and custom page sizes work fine with
other Ubuntu applications (such as the FireFox screenshot I showed), and with
Microsoft Office running both in both Windows and on Ubuntu via Wine.

I look forward to this issue being finally addressed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124878] Libreoffice 6.2.3 writer will not open .odt files it has save from .docx file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124878

--- Comment #6 from Peter Allott  ---
The cause of the problem was a change to 
$HOME/.config/user-dirs.dirs
see
peter@laptop:~/.config$ diff bad.user-dirs.dirs user-dirs.dirs
10c10
< XDG_TEMPLATES_DIR="$HOME/"
---
> XDG_TEMPLATES_DIR="$HOME/Templates"

This was discovered by moving the home directory out of the way and starting
again with an empty home directory.

I am not sure of the cause of the change.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78916] Custom page size missing from print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78916

Cor Nouws  changed:

   What|Removed |Added

   Keywords||needsUXEval
   Hardware|x86 (IA32)  |All
   Severity|major   |enhancement
Version|3.5.7.2 release |Inherited From OOo
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #26 from Cor Nouws  ---
Hi Joseph,

(In reply to huber.joseph from comment #25)
> 3. File>Print... to make the Print dialog appear.  Writer picks the closest
(your screen prints are not the latest dialogs? but that's no problem.)

> page size known by the printer.  There is no place to enter a custom page
> size.  The page size is greyed out and cannot be changed.  Please see the
> attached screenshots. L1-L4.png
Nor is there an option "actual user defined size".
So yes, this definitely is a limitation. On the other hand, the printer (any
way mine) does not offer the option to set a free size either..
Set to enhancement. Is here from OOo times.

Maybe UX-advice has an suggestion for a solution?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 78916] Custom page size missing from print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78916

Cor Nouws  changed:

   What|Removed |Added

   Keywords||needsUXEval
   Hardware|x86 (IA32)  |All
   Severity|major   |enhancement
Version|3.5.7.2 release |Inherited From OOo
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #26 from Cor Nouws  ---
Hi Joseph,

(In reply to huber.joseph from comment #25)
> 3. File>Print... to make the Print dialog appear.  Writer picks the closest
(your screen prints are not the latest dialogs? but that's no problem.)

> page size known by the printer.  There is no place to enter a custom page
> size.  The page size is greyed out and cannot be changed.  Please see the
> attached screenshots. L1-L4.png
Nor is there an option "actual user defined size".
So yes, this definitely is a limitation. On the other hand, the printer (any
way mine) does not offer the option to set a free size either..
Set to enhancement. Is here from OOo times.

Maybe UX-advice has an suggestion for a solution?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 124939] editing cell does not follow edit line

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124939

Maxim Monastirsky  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #3 from Maxim Monastirsky  ---
(In reply to Xisco Faulí from comment #2)
> Regression introduced by:
> 
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=632bc11ce8fab1c4046ab24810b90a7ce9ac5914
Are you sure this has anything to do with this commit? I seem to reproduce the
same behavior with much older builds too (I tested 6.0.0.3, 5.4.3.2, 4.4.0.3).

Exact steps, just to make sure we're testing the same thing:

1. Open the file. Cell A3 is selected.
2. Press Shift+Ctrl+F2 to enter the input line.
3. Press Insert to activate overwrite mode.
4. Press ESC to leave the input line.
5. Press Shift+Ctrl+F2 to enter the input line again.
6. Move the cursor over the 'A' letter with the arrow keys.
7. Press 'b'.

Is these steps correct? If yes - could you please test again? It not - please
give exact steps, as I couldn't reproduce the problem in any other way.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: common/Log.cpp common/Log.hpp

[Libreoffice Gerrit user]

 common/Log.cpp |   16 
 common/Log.hpp |   35 +--
 2 files changed, 17 insertions(+), 34 deletions(-)

New commits:
commit 685709080d27d87ccb0f9bd5c8663003ea3cfb78
Author: Michael Meeks 
AuthorDate: Sat Apr 27 22:15:48 2019 +0100
Commit: Michael Meeks 
CommitDate: Sat Apr 27 23:18:11 2019 +0200

Revert attempts at re-using ostringstream

Cleaning up the thread variable with the shared string stream is
something of a nightmare, for a rather marginal gain.

==9296== Invalid write of size 1
...
==9296==by 0x738C092: str (sstream:195)
==9296==by 0x738C092: std::__cxx11::basic_ostringstream, std::allocator 
>::str(std::__cxx11::basic_string, 
std::allocator > const&) (sstream:649)
==9296==by 0x65383A: Log::beginLog[abi:cxx11](char const*) 
(Log.cpp:141)
==9296==by 0x551823: Admin::~Admin() (Admin.cpp:381)
==9296==by 0x7D9ECF7: __run_exit_handlers (exit.c:83)
==9296==by 0x7D9ED49: exit (exit.c:105)
==9296==by 0x7D86F50: (below main) (libc-start.c:342)
==9296==  Address 0x8ba41c0 is 0 bytes inside a block of size 513 free'd
==9296==at 0x4C2FA1D: operator delete(void*) 
(vg_replace_malloc.c:576)
...
==9296==by 0x738784A: ~basic_stringbuf (sstream:65)
==9296==by 0x738784A: std::__cxx11::basic_ostringstream, std::allocator >::~basic_ostringstream() 
(sstream:591)
==9296==by 0x7D9F27E: __call_tls_dtors 
(cxa_thread_atexit_impl.c:155)
==9296==by 0x7D9EC0A: __run_exit_handlers (exit.c:41)
==9296==by 0x7D9ED49: exit (exit.c:105)
==9296==by 0x7D86F50: (below main) (libc-start.c:342)

Good to log during shutdown / exit.

This reverts commit c315d219d5967f23fb1769e78021f61b8f9da6ec.
This reverts commit ce78fec310ab5ab6aecabb73cad7d782afcb885f.

Change-Id: Ia4a15be336d89d8d883530943724d48e4b0ec9fe
Reviewed-on: https://gerrit.libreoffice.org/71444
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

diff --git a/common/Log.cpp b/common/Log.cpp
index 6b263263a..b892c5b4b 100644
--- a/common/Log.cpp
+++ b/common/Log.cpp
@@ -126,22 +126,6 @@ namespace Log
 return buffer;
 }
 
-// Reuse the same buffer to minimize memory fragmentation.
-static thread_local std::ostringstream Oss;
-
-std::ostringstream& beginLog(const char* level)
-{
-// Reset the oss.
-Oss.clear();
-Oss.str(std::string());
-Oss.seekp(0);
-
-// Output the prefix.
-char buffer[1024];
-Oss << Log::prefix(buffer, sizeof(buffer) - 1, level) << 
std::boolalpha;
-return Oss;
-}
-
 void signalLogPrefix()
 {
 char buffer[1024];
diff --git a/common/Log.hpp b/common/Log.hpp
index cc4ef9d83..bdc654b39 100644
--- a/common/Log.hpp
+++ b/common/Log.hpp
@@ -54,9 +54,6 @@ namespace Log
 
 char* prefix(char* buffer, std::size_t len, const char* level);
 
-/// Starts logging by generating the prefix and returning an oss.
-std::ostringstream& beginLog(const char* level);
-
 inline bool traceEnabled() { return logger().trace(); }
 inline bool debugEnabled() { return logger().debug(); }
 inline bool infoEnabled() { return logger().information(); }
@@ -240,29 +237,31 @@ namespace Log
 #define LOG_FILE_NAME(f) (strrchr(f, '/')+1)
 #endif
 
-#define LOG_END(LOG, FILEP)
\
-do 
\
-{  
\
-if (FILEP) 
\
-LOG << "| " << LOG_FILE_NAME(__FILE__) << ':' << __LINE__; 
\
+#define LOG_END(LOG, FILEP) \
+do  \
+{   \
+if (FILEP)  \
+LOG << "| " << LOG_FILE_NAME(__FILE__) << ':' << __LINE__; \
 } while (false)
 
 #ifdef __ANDROID__
 
-#define LOG_BODY_(LOG, PRIO, LVL, X, FILEP)
\
-std::ostringstream& oss_ = Log::beginLog(LVL); 
   \
-oss_ << X; 
\
-LOG_END(oss_, FILEP);  
\
+#define LOG_BODY_(LOG, PRIO, LVL, X, FILEP)
 \
+char b_[1024]; 
 \
+std::ostringstream 

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4' - common/Log.cpp common/Log.hpp

[Libreoffice Gerrit user]

 common/Log.cpp |   16 
 common/Log.hpp |   26 --
 2 files changed, 12 insertions(+), 30 deletions(-)

New commits:
commit e1e22380f285329a0838d637cf94a2c7e6973493
Author: Michael Meeks 
AuthorDate: Sat Apr 27 22:12:57 2019 +0100
Commit: Michael Meeks 
CommitDate: Sat Apr 27 22:13:25 2019 +0100

Revert attempts at re-using ostringstream

Cleaning up the thread variable with the shared string stream is
something of a nightmare, for a rather marginal gain.

==9296== Invalid write of size 1
...
==9296==by 0x738C092: str (sstream:195)
==9296==by 0x738C092: std::__cxx11::basic_ostringstream, std::allocator 
>::str(std::__cxx11::basic_string, 
std::allocator > const&) (sstream:649)
==9296==by 0x65383A: Log::beginLog[abi:cxx11](char const*) (Log.cpp:141)
==9296==by 0x551823: Admin::~Admin() (Admin.cpp:381)
==9296==by 0x7D9ECF7: __run_exit_handlers (exit.c:83)
==9296==by 0x7D9ED49: exit (exit.c:105)
==9296==by 0x7D86F50: (below main) (libc-start.c:342)
==9296==  Address 0x8ba41c0 is 0 bytes inside a block of size 513 free'd
==9296==at 0x4C2FA1D: operator delete(void*) (vg_replace_malloc.c:576)
...
==9296==by 0x738784A: ~basic_stringbuf (sstream:65)
==9296==by 0x738784A: std::__cxx11::basic_ostringstream, std::allocator >::~basic_ostringstream() 
(sstream:591)
==9296==by 0x7D9F27E: __call_tls_dtors (cxa_thread_atexit_impl.c:155)
==9296==by 0x7D9EC0A: __run_exit_handlers (exit.c:41)
==9296==by 0x7D9ED49: exit (exit.c:105)
==9296==by 0x7D86F50: (below main) (libc-start.c:342)

Good to log during shutdown / exit.

This reverts commit bc67163a481d02d76266875372af5ff79a861d23.
This reverts commit 242df1594dd9283ba0501b141e176617b03cf3d9.

diff --git a/common/Log.cpp b/common/Log.cpp
index f1ed70dcb..a5f101e93 100644
--- a/common/Log.cpp
+++ b/common/Log.cpp
@@ -131,22 +131,6 @@ namespace Log
 return buffer;
 }
 
-// Reuse the same buffer to minimize memory fragmentation.
-static thread_local std::ostringstream Oss;
-
-std::ostringstream& beginLog(const char* level)
-{
-// Reset the oss.
-Oss.clear();
-Oss.str(std::string());
-Oss.seekp(0);
-
-// Output the prefix.
-char buffer[1024];
-Oss << Log::prefix(buffer, sizeof(buffer) - 1, level) << 
std::boolalpha;
-return Oss;
-}
-
 void signalLogPrefix()
 {
 char buffer[1024];
diff --git a/common/Log.hpp b/common/Log.hpp
index a17509317..bf05fc7ce 100644
--- a/common/Log.hpp
+++ b/common/Log.hpp
@@ -50,9 +50,6 @@ namespace Log
 
 char* prefix(char* buffer, std::size_t len, const char* level);
 
-/// Starts logging by generating the prefix and returning an oss.
-std::ostringstream& beginLog(const char* level);
-
 inline bool traceEnabled() { return logger().trace(); }
 inline bool debugEnabled() { return logger().debug(); }
 inline bool infoEnabled() { return logger().information(); }
@@ -236,19 +233,20 @@ namespace Log
 #define LOG_FILE_NAME(f) (strrchr(f, '/')+1)
 #endif
 
-#define LOG_END(LOG, FILEP)
\
-do 
\
-{  
\
-if (FILEP) 
\
-LOG << "| " << LOG_FILE_NAME(__FILE__) << ':' << __LINE__; 
\
+#define LOG_END(LOG, FILEP) \
+do  \
+{   \
+if (FILEP)  \
+LOG << "| " << LOG_FILE_NAME(__FILE__) << ':' << __LINE__; \
 } while (false)
 
-#define LOG_BODY_(LOG, PRIO, LVL, X, FILEP)
\
-Poco::Message m_(LOG.name(), "", Poco::Message::PRIO_##PRIO);  
\
-std::ostringstream& oss_ = Log::beginLog(LVL); 
   \
-oss_ << X; 
\
-LOG_END(oss_, FILEP);  
\
-m_.setText(oss_.str());
\
+#define LOG_BODY_(LOG, PRIO, LVL, X, FILEP)
 \
+Poco::Message m_(LOG.name(), "", Poco::Message::PRIO_##PRIO);  
 \
+char b_[1024]; 
 \
+std::ostringstream 

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4' - common/Log.cpp common/Log.hpp

[Libreoffice Gerrit user]

 common/Log.cpp |3 ++-
 common/Log.hpp |4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

New commits:
commit bc67163a481d02d76266875372af5ff79a861d23
Author: Michael Meeks 
AuthorDate: Sat Apr 27 22:00:51 2019 +0100
Commit: Michael Meeks 
CommitDate: Sat Apr 27 22:04:33 2019 +0100

Reset the stringstream properly.

Avoids some N^2 log-line explosion; also make the method name
more findable.

Change-Id: I3ee8c521f1ac98a939cd4d758c720b577d3bfa57
Reviewed-on: https://gerrit.libreoffice.org/71443
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

diff --git a/common/Log.cpp b/common/Log.cpp
index 3bedaa82e..f1ed70dcb 100644
--- a/common/Log.cpp
+++ b/common/Log.cpp
@@ -134,10 +134,11 @@ namespace Log
 // Reuse the same buffer to minimize memory fragmentation.
 static thread_local std::ostringstream Oss;
 
-std::ostringstream& begin(const char* level)
+std::ostringstream& beginLog(const char* level)
 {
 // Reset the oss.
 Oss.clear();
+Oss.str(std::string());
 Oss.seekp(0);
 
 // Output the prefix.
diff --git a/common/Log.hpp b/common/Log.hpp
index 9ded1425a..a17509317 100644
--- a/common/Log.hpp
+++ b/common/Log.hpp
@@ -51,7 +51,7 @@ namespace Log
 char* prefix(char* buffer, std::size_t len, const char* level);
 
 /// Starts logging by generating the prefix and returning an oss.
-std::ostringstream& begin(const char* level);
+std::ostringstream& beginLog(const char* level);
 
 inline bool traceEnabled() { return logger().trace(); }
 inline bool debugEnabled() { return logger().debug(); }
@@ -245,7 +245,7 @@ namespace Log
 
 #define LOG_BODY_(LOG, PRIO, LVL, X, FILEP)
\
 Poco::Message m_(LOG.name(), "", Poco::Message::PRIO_##PRIO);  
\
-std::ostringstream& oss_ = Log::begin(LVL);
\
+std::ostringstream& oss_ = Log::beginLog(LVL); 
   \
 oss_ << X; 
\
 LOG_END(oss_, FILEP);  
\
 m_.setText(oss_.str());
\
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: common/Log.cpp common/Log.hpp

[Libreoffice Gerrit user]

 common/Log.cpp |3 ++-
 common/Log.hpp |6 +++---
 2 files changed, 5 insertions(+), 4 deletions(-)

New commits:
commit c2c5bd0e3e04181bf0a21a65b83f8455b7486039
Author: Michael Meeks 
AuthorDate: Sat Apr 27 22:00:51 2019 +0100
Commit: Michael Meeks 
CommitDate: Sat Apr 27 23:03:16 2019 +0200

Reset the stringstream properly.

Avoids some N^2 log-line explosion; also make the method name
more findable.

Change-Id: I3ee8c521f1ac98a939cd4d758c720b577d3bfa57
Reviewed-on: https://gerrit.libreoffice.org/71443
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

diff --git a/common/Log.cpp b/common/Log.cpp
index 46cfd6095..6b263263a 100644
--- a/common/Log.cpp
+++ b/common/Log.cpp
@@ -129,10 +129,11 @@ namespace Log
 // Reuse the same buffer to minimize memory fragmentation.
 static thread_local std::ostringstream Oss;
 
-std::ostringstream& begin(const char* level)
+std::ostringstream& beginLog(const char* level)
 {
 // Reset the oss.
 Oss.clear();
+Oss.str(std::string());
 Oss.seekp(0);
 
 // Output the prefix.
diff --git a/common/Log.hpp b/common/Log.hpp
index f4a51d8da..cc4ef9d83 100644
--- a/common/Log.hpp
+++ b/common/Log.hpp
@@ -55,7 +55,7 @@ namespace Log
 char* prefix(char* buffer, std::size_t len, const char* level);
 
 /// Starts logging by generating the prefix and returning an oss.
-std::ostringstream& begin(const char* level);
+std::ostringstream& beginLog(const char* level);
 
 inline bool traceEnabled() { return logger().trace(); }
 inline bool debugEnabled() { return logger().debug(); }
@@ -250,7 +250,7 @@ namespace Log
 #ifdef __ANDROID__
 
 #define LOG_BODY_(LOG, PRIO, LVL, X, FILEP)
\
-std::ostringstream& oss_ = Log::begin(LVL);
\
+std::ostringstream& oss_ = Log::beginLog(LVL); 
   \
 oss_ << X; 
\
 LOG_END(oss_, FILEP);  
\
 ((void)__android_log_print(ANDROID_LOG_DEBUG, "loolwsd", "%s %s", LVL, 
oss_.str().c_str()))
@@ -259,7 +259,7 @@ namespace Log
 
 #define LOG_BODY_(LOG, PRIO, LVL, X, FILEP)
\
 Poco::Message m_(LOG.name(), "", Poco::Message::PRIO_##PRIO);  
\
-std::ostringstream& oss_ = Log::begin(LVL);
\
+std::ostringstream& oss_ = Log::beginLog(LVL); 
   \
 oss_ << X; 
\
 LOG_END(oss_, FILEP);  
\
 m_.setText(oss_.str());
\
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125003] New: Regression: flash of first spreadsheet page, unzoomed, when loading

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125003

Bug ID: 125003
   Summary: Regression: flash of first spreadsheet page, unzoomed,
when loading
   Product: LibreOffice
   Version: 6.2.3.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ddascalescu+freedesk...@gmail.com

Created attachment 151049
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151049=edit
Screencasst of the sheet flashing before Calc scrolls

I haven't seen this behavior in previous versions. The last Calc version I used
that loaded spreadsheets without flashing the A1 corner was 6.2.0.1 rc (which I
find impossible to download from anywhere and revert to :-/).

Anyway, reproduction steps:

1. Download https://bugs.documentfoundation.org/attachment.cgi?id=133113
2. Restart Calc in Safe Mode
3. Open the downloaded sheet

Notice how the first page of the sheet is shown for about a second before Calc
scrolls to the last position in the sheet and zooms to its last zoom level.

Also, if the zoom factor was different than 100%, the zoom will be visible in
this flash.

Module: SpreadsheetDocument

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120695] FILEOPEN unixODBC connection to sqlite database not working

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120695

Heinz Repp  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

--- Comment #21 from Heinz Repp  ---
To be clear: the bug is STILL PRESENT in the latest Libreoffice 6.2.3 on
Windows 10 64bit: when opening an odb file that has a ODBC database connection
to an sqlite3 database file via Ch. Werner's sqliteodbc driver, all tables
appear empty.

But: the workaround unchecking "Respect the result set type from the database
driver" works.

So: not the code has changed, the bug is still present - and not only with
unixODBC, with Windows ODBC also

So please:
Either uncheck "Respect the result set type from the database driver" by
default in all ODBC databases, or fix the bug. Reopening ...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104790] [META] Database connectivity interfaces (ODBC, JDBC..) and external databases

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104790
Bug 104790 depends on bug 120695, which changed state.

Bug 120695 Summary: FILEOPEN unixODBC connection to sqlite database not working
https://bugs.documentfoundation.org/show_bug.cgi?id=120695

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51145] FILEOPEN invalid .rtf causes useless ERRORMESSAGE

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=51145

Adolfo Jayme  changed:

   What|Removed |Added

 Blocks|40821   |34694


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=34694
[Bug 34694] [META] Improve usability of error messages
https://bugs.documentfoundation.org/show_bug.cgi?id=40821
[Bug 40821] [META] Replace useless "General Error" by useful information
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 40821] [META] Replace useless "General Error" by useful information

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=40821

Adolfo Jayme  changed:

   What|Removed |Added

 Depends on|51145   |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=51145
[Bug 51145] FILEOPEN invalid .rtf causes useless ERRORMESSAGE
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34694] [META] Improve usability of error messages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=34694

Adolfo Jayme  changed:

   What|Removed |Added

 Depends on||51145


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=51145
[Bug 51145] FILEOPEN invalid .rtf causes useless ERRORMESSAGE
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 99/ff40a4a156daf370ec931a83097a8d03143053

[Caolán McNamara (via logerrit)]

 99/ff40a4a156daf370ec931a83097a8d03143053 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit aa30fe3f7b9876be446ad081b396c8a7e9916ed8
Author: Caolán McNamara 
AuthorDate: Sat Apr 27 21:39:22 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Apr 27 21:39:22 2019 +0100

Notes added by 'git notes add'

diff --git a/99/ff40a4a156daf370ec931a83097a8d03143053 
b/99/ff40a4a156daf370ec931a83097a8d03143053
new file mode 100644
index ..8e5c182e7789
--- /dev/null
+++ b/99/ff40a4a156daf370ec931a83097a8d03143053
@@ -0,0 +1 @@
+ignore: aoo
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 48/20583166d892919fad9efea65288915fac1526

[Caolán McNamara (via logerrit)]

 48/20583166d892919fad9efea65288915fac1526 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 4c728b47312e8fa9b89be6cd4d64ddfad1b8e0f1
Author: Caolán McNamara 
AuthorDate: Sat Apr 27 21:38:48 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Apr 27 21:38:48 2019 +0100

Notes added by 'git notes add'

diff --git a/48/20583166d892919fad9efea65288915fac1526 
b/48/20583166d892919fad9efea65288915fac1526
new file mode 100644
index ..de6c5fe0075b
--- /dev/null
+++ b/48/20583166d892919fad9efea65288915fac1526
@@ -0,0 +1 @@
+prefer: 00657aef09d854c74fb426a935a3e8b1fc390bb0
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 00/c49664c07ebdf242a957f6f83446c6bb0d08a4

[Caolán McNamara (via logerrit)]

 00/c49664c07ebdf242a957f6f83446c6bb0d08a4 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 0e08ae1bbfde644dfa174f2d4832a41bfd8d8f26
Author: Caolán McNamara 
AuthorDate: Sat Apr 27 21:34:47 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Apr 27 21:34:47 2019 +0100

Notes added by 'git notes add'

diff --git a/00/c49664c07ebdf242a957f6f83446c6bb0d08a4 
b/00/c49664c07ebdf242a957f6f83446c6bb0d08a4
new file mode 100644
index ..de6c5fe0075b
--- /dev/null
+++ b/00/c49664c07ebdf242a957f6f83446c6bb0d08a4
@@ -0,0 +1 @@
+prefer: 00657aef09d854c74fb426a935a3e8b1fc390bb0
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 68/4c35380a72f81bd6a026615723b06b3e14fa6e

[Caolán McNamara (via logerrit)]

 68/4c35380a72f81bd6a026615723b06b3e14fa6e |1 +
 1 file changed, 1 insertion(+)

New commits:
commit e2260d8a4edfefd9f310c1a47d3ef98ee76f3224
Author: Caolán McNamara 
AuthorDate: Sat Apr 27 21:37:40 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Apr 27 21:37:40 2019 +0100

Notes added by 'git notes add'

diff --git a/68/4c35380a72f81bd6a026615723b06b3e14fa6e 
b/68/4c35380a72f81bd6a026615723b06b3e14fa6e
new file mode 100644
index ..7a848e7caba1
--- /dev/null
+++ b/68/4c35380a72f81bd6a026615723b06b3e14fa6e
@@ -0,0 +1 @@
+prefer: a1552a0ec3fcddd968db274ef41bc2452c50bed9
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - a5/02c1af0c545bdaf6a0eb8ecbf38c635ff6accb

[Caolán McNamara (via logerrit)]

 a5/02c1af0c545bdaf6a0eb8ecbf38c635ff6accb |1 +
 1 file changed, 1 insertion(+)

New commits:
commit ab22cfba162aacaf21bf0aefa66987525c93d0ce
Author: Caolán McNamara 
AuthorDate: Sat Apr 27 21:36:58 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Apr 27 21:36:58 2019 +0100

Notes added by 'git notes add'

diff --git a/a5/02c1af0c545bdaf6a0eb8ecbf38c635ff6accb 
b/a5/02c1af0c545bdaf6a0eb8ecbf38c635ff6accb
new file mode 100644
index ..de6c5fe0075b
--- /dev/null
+++ b/a5/02c1af0c545bdaf6a0eb8ecbf38c635ff6accb
@@ -0,0 +1 @@
+prefer: 00657aef09d854c74fb426a935a3e8b1fc390bb0
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 98/e7de2b1f23083332ac13245d81cff69d097fd6

[Caolán McNamara (via logerrit)]

 98/e7de2b1f23083332ac13245d81cff69d097fd6 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 075bacd1eb94fba2e5b7c7beacb5808f0bba49d5
Author: Caolán McNamara 
AuthorDate: Sat Apr 27 21:36:01 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Apr 27 21:36:01 2019 +0100

Notes added by 'git notes add'

diff --git a/98/e7de2b1f23083332ac13245d81cff69d097fd6 
b/98/e7de2b1f23083332ac13245d81cff69d097fd6
new file mode 100644
index ..de6c5fe0075b
--- /dev/null
+++ b/98/e7de2b1f23083332ac13245d81cff69d097fd6
@@ -0,0 +1 @@
+prefer: 00657aef09d854c74fb426a935a3e8b1fc390bb0
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 2 commits - 09/162b7d8d9afdbbcf03273db3ffa31bf2ac1b6c d0/6353475daf23b5afdaabf6784e0b7c26e8e350

[Caolán McNamara (via logerrit)]

 09/162b7d8d9afdbbcf03273db3ffa31bf2ac1b6c |1 +
 d0/6353475daf23b5afdaabf6784e0b7c26e8e350 |1 +
 2 files changed, 2 insertions(+)

New commits:
commit 880e1f7a63a20d8f305f56923854f77bcab184df
Author: Caolán McNamara 
AuthorDate: Sat Apr 27 21:33:12 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Apr 27 21:33:12 2019 +0100

Notes added by 'git notes add'

diff --git a/09/162b7d8d9afdbbcf03273db3ffa31bf2ac1b6c 
b/09/162b7d8d9afdbbcf03273db3ffa31bf2ac1b6c
new file mode 100644
index ..8e5c182e7789
--- /dev/null
+++ b/09/162b7d8d9afdbbcf03273db3ffa31bf2ac1b6c
@@ -0,0 +1 @@
+ignore: aoo
commit 197dc26391b376ae0feb168ce2b4f9602d0f169a
Author: Caolán McNamara 
AuthorDate: Sat Apr 27 21:32:59 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Apr 27 21:32:59 2019 +0100

Notes added by 'git notes add'

diff --git a/d0/6353475daf23b5afdaabf6784e0b7c26e8e350 
b/d0/6353475daf23b5afdaabf6784e0b7c26e8e350
new file mode 100644
index ..8e5c182e7789
--- /dev/null
+++ b/d0/6353475daf23b5afdaabf6784e0b7c26e8e350
@@ -0,0 +1 @@
+ignore: aoo
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 2 commits - 2b/61e66768284b8aa775425e2cbac4f7ef62a137 af/6fe636711841e1ebe22d7aa0c5a3712e5dcb09

[Caolán McNamara (via logerrit)]

 2b/61e66768284b8aa775425e2cbac4f7ef62a137 |1 +
 af/6fe636711841e1ebe22d7aa0c5a3712e5dcb09 |1 +
 2 files changed, 2 insertions(+)

New commits:
commit ff606744efec68eb5c2bc57da2d38f15f193de49
Author: Caolán McNamara 
AuthorDate: Sat Apr 27 21:34:12 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Apr 27 21:34:12 2019 +0100

Notes added by 'git notes add'

diff --git a/af/6fe636711841e1ebe22d7aa0c5a3712e5dcb09 
b/af/6fe636711841e1ebe22d7aa0c5a3712e5dcb09
new file mode 100644
index ..8e5c182e7789
--- /dev/null
+++ b/af/6fe636711841e1ebe22d7aa0c5a3712e5dcb09
@@ -0,0 +1 @@
+ignore: aoo
commit d0da0bc5c1a49a9e25290205dd42770552ee98b4
Author: Caolán McNamara 
AuthorDate: Sat Apr 27 21:34:02 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Apr 27 21:34:02 2019 +0100

Notes added by 'git notes add'

diff --git a/2b/61e66768284b8aa775425e2cbac4f7ef62a137 
b/2b/61e66768284b8aa775425e2cbac4f7ef62a137
new file mode 100644
index ..8e5c182e7789
--- /dev/null
+++ b/2b/61e66768284b8aa775425e2cbac4f7ef62a137
@@ -0,0 +1 @@
+ignore: aoo
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 2 commits - 8b/005725dea8f09cd4bb66b63f371f385268bdd3 b2/cdaf15f72c5f35e44ca0289e084750ebf22fbd

[Caolán McNamara (via logerrit)]

 8b/005725dea8f09cd4bb66b63f371f385268bdd3 |1 +
 b2/cdaf15f72c5f35e44ca0289e084750ebf22fbd |1 +
 2 files changed, 2 insertions(+)

New commits:
commit 991535579b2700fb32baca3cfcdddbd15f41aa38
Author: Caolán McNamara 
AuthorDate: Sat Apr 27 21:33:45 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Apr 27 21:33:45 2019 +0100

Notes added by 'git notes add'

diff --git a/b2/cdaf15f72c5f35e44ca0289e084750ebf22fbd 
b/b2/cdaf15f72c5f35e44ca0289e084750ebf22fbd
new file mode 100644
index ..8e5c182e7789
--- /dev/null
+++ b/b2/cdaf15f72c5f35e44ca0289e084750ebf22fbd
@@ -0,0 +1 @@
+ignore: aoo
commit 1a97e4d2c636fca978847471da17bae5129dea61
Author: Caolán McNamara 
AuthorDate: Sat Apr 27 21:33:32 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Apr 27 21:33:32 2019 +0100

Notes added by 'git notes add'

diff --git a/8b/005725dea8f09cd4bb66b63f371f385268bdd3 
b/8b/005725dea8f09cd4bb66b63f371f385268bdd3
new file mode 100644
index ..8e5c182e7789
--- /dev/null
+++ b/8b/005725dea8f09cd4bb66b63f371f385268bdd3
@@ -0,0 +1 @@
+ignore: aoo
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svx/source

[Mike Kaganski (via logerrit)]

 svx/source/sdr/primitive2d/sdrattributecreator.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit e300e8fbe891e23777ce95556488010f6f59c0e6
Author: Mike Kaganski 
AuthorDate: Sat Apr 27 20:06:18 2019 +0300
Commit: Mike Kaganski 
CommitDate: Sat Apr 27 22:27:00 2019 +0200

tdf#120703 PVS: re-read aPrefSize after updating it

V581 The conditional expressions of the 'if' statements situated
 alongside each other are identical. Check lines: 645, 655

Since commit 37aa7d81aacaae12dfe0fd2ade2779235bbf72f1

Change-Id: I7b4d2d58e51cf98ac6294d1feacd28c3a8761d81
Reviewed-on: https://gerrit.libreoffice.org/71431
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/svx/source/sdr/primitive2d/sdrattributecreator.cxx 
b/svx/source/sdr/primitive2d/sdrattributecreator.cxx
index 806d4038e7a4..fe657f5b4974 100644
--- a/svx/source/sdr/primitive2d/sdrattributecreator.cxx
+++ b/svx/source/sdr/primitive2d/sdrattributecreator.cxx
@@ -649,6 +649,7 @@ namespace drawinglayer
 {
 
aGraphic.SetPrefSize(aGraphic.GetBitmapEx().GetSizePixel());
 aGraphic.SetPrefMapMode(MapMode(MapUnit::MapPixel));
+aPrefSize = aGraphic.GetPrefSize();
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 120703] Bugs found by PVS-Studio static analyzer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120703

--- Comment #162 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/e300e8fbe891e23777ce95556488010f6f59c0e6%5E%21

tdf#120703 PVS: re-read aPrefSize after updating it

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

[Dennis Francis (via logerrit)]

 sc/qa/unit/ucalc.hxx |2 +
 sc/qa/unit/ucalc_formula.cxx |   65 +++
 2 files changed, 67 insertions(+)

New commits:
commit 22f4ad10ff9caef430ede01dc3acfe5fdf512d9b
Author: Dennis Francis 
AuthorDate: Sat Apr 27 22:14:43 2019 +0530
Commit: Dennis Francis 
CommitDate: Sat Apr 27 22:19:47 2019 +0200

unit-test for tdf#124326

Change-Id: Id3416e5631dcd6e427429ac475ac81b2ab70b9e5
Reviewed-on: https://gerrit.libreoffice.org/71429
Tested-by: Jenkins
Reviewed-by: Dennis Francis 

diff --git a/sc/qa/unit/ucalc.hxx b/sc/qa/unit/ucalc.hxx
index 3bc864734874..ba85b9b78042 100644
--- a/sc/qa/unit/ucalc.hxx
+++ b/sc/qa/unit/ucalc.hxx
@@ -162,6 +162,7 @@ public:
 void testFormulaRefUpdateMoveUndo3NonShared();
 void testFormulaRefUpdateMoveUndo3Shared();
 void testFormulaRefUpdateMoveUndoDependents();
+void testFormulaRefUpdateMoveUndo4();
 void testFormulaRefUpdateMoveToSheet();
 void testFormulaRefUpdateDeleteContent();
 void testFormulaRefUpdateDeleteAndShiftLeft();
@@ -601,6 +602,7 @@ public:
 CPPUNIT_TEST(testFormulaRefUpdateMoveUndo3NonShared);
 CPPUNIT_TEST(testFormulaRefUpdateMoveUndo3Shared);
 CPPUNIT_TEST(testFormulaRefUpdateMoveUndoDependents);
+CPPUNIT_TEST(testFormulaRefUpdateMoveUndo4);
 CPPUNIT_TEST(testFormulaRefUpdateMoveToSheet);
 CPPUNIT_TEST(testFormulaRefUpdateDeleteContent);
 CPPUNIT_TEST(testFormulaRefUpdateDeleteAndShiftLeft);
diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx
index ebc65177b301..8754239bbb2a 100644
--- a/sc/qa/unit/ucalc_formula.cxx
+++ b/sc/qa/unit/ucalc_formula.cxx
@@ -2871,6 +2871,71 @@ void Test::testFormulaRefUpdateMoveUndoDependents()
 m_pDoc->DeleteTab(0);
 }
 
+void Test::testFormulaRefUpdateMoveUndo4()
+{
+m_pDoc->InsertTab(0, "Test");
+
+sc::AutoCalcSwitch aACSwitch(*m_pDoc, true); // turn auto calc on.
+std::vector> aData = {
+{ "1",  nullptr,  "=B1", "=A1" },
+{ "2",  nullptr,  "=B2", "=A2" },
+};
+
+ScRange aOutRange = insertRangeData(m_pDoc, ScAddress(0,0,0), aData);
+
+std::vector> aCheckInitial = {
+{ "1",  nullptr,  "0", "1" },
+{ "2",  nullptr,  "0", "2" },
+};
+
+bool bGood = checkOutput(m_pDoc, aOutRange, aCheckInitial, "initial data");
+CPPUNIT_ASSERT(bGood);
+
+// Drag A1:A2 into B1:B2.
+ScDocFunc& rFunc = getDocShell().GetDocFunc();
+bool bMoved = rFunc.MoveBlock(ScRange(0, 0, 0, 0, 1, 0), ScAddress(1, 0, 
0), true, true, false, true);
+CPPUNIT_ASSERT(bMoved);
+
+std::vector> aCheckAfter = {
+{ nullptr, "1", "1", "1" },
+{ nullptr, "2", "2", "2" },
+};
+
+bGood = checkOutput(m_pDoc, aOutRange, aCheckAfter, "A1:A2 moved to 
B1:B2");
+CPPUNIT_ASSERT(bGood);
+
+ASSERT_FORMULA_EQUAL(*m_pDoc, ScAddress(2,0,0), "B1", "Wrong formula"); // 
C1
+ASSERT_FORMULA_EQUAL(*m_pDoc, ScAddress(2,1,0), "B2", "Wrong formula"); // 
C2
+ASSERT_FORMULA_EQUAL(*m_pDoc, ScAddress(3,0,0), "B1", "Wrong formula"); // 
D1
+ASSERT_FORMULA_EQUAL(*m_pDoc, ScAddress(3,1,0), "B2", "Wrong formula"); // 
D2
+
+// Undo the move.
+SfxUndoManager* pUndoMgr = m_pDoc->GetUndoManager();
+CPPUNIT_ASSERT(pUndoMgr);
+pUndoMgr->Undo();
+
+bGood = checkOutput(m_pDoc, aOutRange, aCheckInitial, "after undo");
+CPPUNIT_ASSERT(bGood);
+
+ASSERT_FORMULA_EQUAL(*m_pDoc, ScAddress(2,0,0), "B1", "Wrong formula"); // 
C1
+ASSERT_FORMULA_EQUAL(*m_pDoc, ScAddress(2,1,0), "B2", "Wrong formula"); // 
C2
+ASSERT_FORMULA_EQUAL(*m_pDoc, ScAddress(3,0,0), "A1", "Wrong formula"); // 
D1
+ASSERT_FORMULA_EQUAL(*m_pDoc, ScAddress(3,1,0), "A2", "Wrong formula"); // 
D2
+
+// Redo and check.
+pUndoMgr->Redo();
+
+bGood = checkOutput(m_pDoc, aOutRange, aCheckAfter, "after redo");
+CPPUNIT_ASSERT(bGood);
+
+ASSERT_FORMULA_EQUAL(*m_pDoc, ScAddress(2,0,0), "B1", "Wrong formula"); // 
C1
+ASSERT_FORMULA_EQUAL(*m_pDoc, ScAddress(2,1,0), "B2", "Wrong formula"); // 
C2
+ASSERT_FORMULA_EQUAL(*m_pDoc, ScAddress(3,0,0), "B1", "Wrong formula"); // 
D1
+ASSERT_FORMULA_EQUAL(*m_pDoc, ScAddress(3,1,0), "B2", "Wrong formula"); // 
D2
+
+m_pDoc->DeleteTab(0);
+}
+
 void Test::testFormulaRefUpdateMoveToSheet()
 {
 sc::AutoCalcSwitch aACSwitch(*m_pDoc, true); // turn auto calc on.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa

[Dennis Francis (via logerrit)]

 sc/qa/unit/ucalc.hxx |2 +
 sc/qa/unit/ucalc_formula.cxx |   65 +++
 2 files changed, 67 insertions(+)

New commits:
commit 511737f7e9de5d4d32bc6cfcf481655f5a9ed3f2
Author: Dennis Francis 
AuthorDate: Sat Apr 27 21:41:59 2019 +0530
Commit: Dennis Francis 
CommitDate: Sat Apr 27 22:18:01 2019 +0200

unit-test for tdf#120270

Change-Id: Icaa547ba5ef210ba721661242b2becd9f559f09a
Reviewed-on: https://gerrit.libreoffice.org/71428
Tested-by: Jenkins
Reviewed-by: Dennis Francis 

diff --git a/sc/qa/unit/ucalc.hxx b/sc/qa/unit/ucalc.hxx
index 90fc183d08fd..3bc864734874 100644
--- a/sc/qa/unit/ucalc.hxx
+++ b/sc/qa/unit/ucalc.hxx
@@ -161,6 +161,7 @@ public:
 void testFormulaRefUpdateMoveUndo2();
 void testFormulaRefUpdateMoveUndo3NonShared();
 void testFormulaRefUpdateMoveUndo3Shared();
+void testFormulaRefUpdateMoveUndoDependents();
 void testFormulaRefUpdateMoveToSheet();
 void testFormulaRefUpdateDeleteContent();
 void testFormulaRefUpdateDeleteAndShiftLeft();
@@ -599,6 +600,7 @@ public:
 CPPUNIT_TEST(testFormulaRefUpdateMoveUndo2);
 CPPUNIT_TEST(testFormulaRefUpdateMoveUndo3NonShared);
 CPPUNIT_TEST(testFormulaRefUpdateMoveUndo3Shared);
+CPPUNIT_TEST(testFormulaRefUpdateMoveUndoDependents);
 CPPUNIT_TEST(testFormulaRefUpdateMoveToSheet);
 CPPUNIT_TEST(testFormulaRefUpdateDeleteContent);
 CPPUNIT_TEST(testFormulaRefUpdateDeleteAndShiftLeft);
diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx
index 1248692f5a50..ebc65177b301 100644
--- a/sc/qa/unit/ucalc_formula.cxx
+++ b/sc/qa/unit/ucalc_formula.cxx
@@ -2806,6 +2806,71 @@ void Test::testFormulaRefUpdateMoveUndo3Shared()
 m_pDoc->DeleteTab(0);
 }
 
+void Test::testFormulaRefUpdateMoveUndoDependents()
+{
+m_pDoc->InsertTab(0, "Test");
+
+sc::AutoCalcSwitch aACSwitch(*m_pDoc, true); // turn auto calc on.
+std::vector> aData = {
+{ "1"   },
+{ "22"  },
+{ "3"   },
+{ "4"   },
+{ "5"   },
+{ "=SUM(C1:C5)" },
+{ "=C6" },
+};
+
+ScRange aOutRange = insertRangeData(m_pDoc, ScAddress(2,0,0), aData);
+
+std::vector> aCheckInitial = {
+{ "1"   },
+{ "22"  },
+{ "3"   },
+{ "4"   },
+{ "5"   },
+{ "35"  },
+{ "35"  },
+};
+
+bool bGood = checkOutput(m_pDoc, aOutRange, aCheckInitial, "initial data");
+CPPUNIT_ASSERT(bGood);
+
+// Drag C2 into D2.
+ScDocFunc& rFunc = getDocShell().GetDocFunc();
+bool bMoved = rFunc.MoveBlock(ScRange(2, 1, 0, 2, 1, 0), ScAddress(3, 1, 
0), true, true, false, true);
+CPPUNIT_ASSERT(bMoved);
+
+std::vector> aCheckAfter = {
+{ "1" },
+{ nullptr },
+{ "3" },
+{ "4" },
+{ "5" },
+{ "13"},
+{ "13"},
+};
+
+bGood = checkOutput(m_pDoc, aOutRange, aCheckAfter, "C2 moved to D2");
+CPPUNIT_ASSERT(bGood);
+
+// Undo the move.
+SfxUndoManager* pUndoMgr = m_pDoc->GetUndoManager();
+CPPUNIT_ASSERT(pUndoMgr);
+pUndoMgr->Undo();
+
+bGood = checkOutput(m_pDoc, aOutRange, aCheckInitial, "after undo");
+CPPUNIT_ASSERT(bGood);
+
+// Redo and check.
+pUndoMgr->Redo();
+
+bGood = checkOutput(m_pDoc, aOutRange, aCheckAfter, "after redo");
+CPPUNIT_ASSERT(bGood);
+
+m_pDoc->DeleteTab(0);
+}
+
 void Test::testFormulaRefUpdateMoveToSheet()
 {
 sc::AutoCalcSwitch aACSwitch(*m_pDoc, true); // turn auto calc on.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 123909] FILEOPEN PPTX: 5 Second Delay Added to Custom Animations Sound, No sound on preview

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123909

Buovjaga  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123909] FILEOPEN PPTX: 5 Second Delay Added to Custom Animations Sound, No sound on preview

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123909

Buovjaga  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||todven...@suomi24.fi
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 50916] Allow more than 1024 columns in calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=50916

--- Comment #79 from Mike Kaganski  ---
Created attachment 151048
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151048=edit
A spreadsheet with 10 000 empty sheets

FYI: LO with attached file takes 4 170 000 KB RAM with Version: 6.2.3.2 (x64)
Build ID: aecc05fe267cc68dde00352a451aa867b3b546ac
CPU threads: 12; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: CL

Today's master (dbgutil buiild) takes 1 600 000 KB.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78916] Custom page size missing from print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78916

--- Comment #25 from huber.jos...@tx.rr.com ---
Steps:

1. Open a new document
2. Go to Format>Page and set the page size to a custom page size, which is
something other than page sizes known by the printer.
3. File>Print... to make the Print dialog appear.  Writer picks the closest
page size known by the printer.  There is no place to enter a custom page size.
 The page size is greyed out and cannot be changed.  Please see the attached
screenshots. L1-L4.png

This is the same for all printers, and this behavior has been the same since
this bug was reported 5 years ago.  

See the screenshot from FireFox.  If you need a custom paper size, it is easy
to do. Please see FF1.png.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78916] Custom page size missing from print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78916

--- Comment #23 from huber.jos...@tx.rr.com ---
Created attachment 151046
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151046=edit
FireFox Print Screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78916] Custom page size missing from print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78916

--- Comment #24 from huber.jos...@tx.rr.com ---
Created attachment 151047
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151047=edit
Writer Print Screenshot 3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78916] Custom page size missing from print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78916

--- Comment #22 from huber.jos...@tx.rr.com ---
Created attachment 151045
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151045=edit
Writer Print Screenshot 2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78916] Custom page size missing from print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78916

--- Comment #21 from huber.jos...@tx.rr.com ---
Created attachment 151044
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151044=edit
Writer Print Screenshot 1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78916] Custom page size missing from print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78916

--- Comment #20 from huber.jos...@tx.rr.com ---
Created attachment 151043
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151043=edit
Write Format>Page screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source sw/source vcl/source

[Andrea Gelmini (via logerrit)]

 sc/source/ui/miscdlgs/acredlin.cxx |2 +-
 sw/source/uibase/misc/redlndlg.cxx |2 +-
 vcl/source/app/svmain.cxx  |2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 734b33b73dbd4bd65265bce2a17ee07cdb3a5042
Author: Andrea Gelmini 
AuthorDate: Sat Apr 27 14:25:15 2019 +
Commit: Caolán McNamara 
CommitDate: Sat Apr 27 21:46:31 2019 +0200

Fix typos

Change-Id: Id81e8db5a38b4e4a88cc21c50234c2338e9c41bf
Reviewed-on: https://gerrit.libreoffice.org/71421
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/source/ui/miscdlgs/acredlin.cxx 
b/sc/source/ui/miscdlgs/acredlin.cxx
index 54b029509c7b..5d4866fe8a18 100644
--- a/sc/source/ui/miscdlgs/acredlin.cxx
+++ b/sc/source/ui/miscdlgs/acredlin.cxx
@@ -1704,7 +1704,7 @@ void ScAcceptChgDlg::Initialize(SfxChildWinInfo* pInfo)
 aWidths.push_back(aEndPos[i] - aEndPos[i - 1]);
 
 // turn column end points back to column widths, ignoring the small
-// value used for the the expander column
+// value used for the expander column
 weld::TreeView& rTreeView = pTheView->GetWidget();
 rTreeView.set_column_fixed_widths(aWidths);
 }
diff --git a/sw/source/uibase/misc/redlndlg.cxx 
b/sw/source/uibase/misc/redlndlg.cxx
index fa6ea10926a1..1861bc292057 100644
--- a/sw/source/uibase/misc/redlndlg.cxx
+++ b/sw/source/uibase/misc/redlndlg.cxx
@@ -1174,7 +1174,7 @@ void SwRedlineAcceptDlg::Initialize(OUString& 
rExtraString)
 aWidths.push_back(aEndPos[i] - aEndPos[i - 1]);
 
 // turn column end points back to column widths, ignoring the 
small
-// value used for the the expander column
+// value used for the expander column
 weld::TreeView& rTreeView = m_pTable->GetWidget();
 rTreeView.set_column_fixed_widths(aWidths);
 }
diff --git a/vcl/source/app/svmain.cxx b/vcl/source/app/svmain.cxx
index e395e1a8634d..9372e74afc17 100644
--- a/vcl/source/app/svmain.cxx
+++ b/vcl/source/app/svmain.cxx
@@ -473,7 +473,7 @@ void DeInitVCL()
 
 pSVData->mpSettingsConfigItem.reset();
 
-// prevent unnessesary painting during Scheduler shutdown
+// prevent unnecessary painting during Scheduler shutdown
 // as this processes all pending events in debug builds.
 ImplGetSystemDependentDataManager().flushAll();
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: basctl/source

[Caolán McNamara (via logerrit)]

 basctl/source/basicide/bastype2.cxx |5 +++--
 basctl/source/basicide/moduldlg.cxx |4 ++--
 basctl/source/inc/bastype2.hxx  |4 +++-
 3 files changed, 8 insertions(+), 5 deletions(-)

New commits:
commit a83963b463df5c8737fba43d9fff7e1236d2670b
Author: Caolán McNamara 
AuthorDate: Sat Apr 27 19:30:34 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Apr 27 21:38:35 2019 +0200

Resolves: tdf#124984 organize basic macro new added module doesn't show up

Change-Id: I422131ab203eba62ed5cf6fb2e19e23325b43f6e
Reviewed-on: https://gerrit.libreoffice.org/71433
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/basctl/source/basicide/bastype2.cxx 
b/basctl/source/basicide/bastype2.cxx
index 2ed3e6d81804..2141278861b2 100644
--- a/basctl/source/basicide/bastype2.cxx
+++ b/basctl/source/basicide/bastype2.cxx
@@ -1351,10 +1351,11 @@ void SbTreeListBox::AddEntry(
 const OUString& rImage,
 const weld::TreeIter* pParent,
 bool bChildrenOnDemand,
-std::unique_ptr&& rUserData)
+std::unique_ptr&& rUserData,
+weld::TreeIter* pRet)
 {
 OUString 
sId(OUString::number(reinterpret_cast(rUserData.release(;
-m_xControl->insert(pParent, -1, , , nullptr, nullptr, , 
bChildrenOnDemand, nullptr);
+m_xControl->insert(pParent, -1, , , nullptr, nullptr, , 
bChildrenOnDemand, pRet);
 }
 
 void SbTreeListBox::SetEntryBitmaps(const weld::TreeIter& rIter, const 
OUString& rImage)
diff --git a/basctl/source/basicide/moduldlg.cxx 
b/basctl/source/basicide/moduldlg.cxx
index 4e96d7e16450..dda0bbf1581d 100644
--- a/basctl/source/basicide/moduldlg.cxx
+++ b/basctl/source/basicide/moduldlg.cxx
@@ -1116,8 +1116,8 @@ SbModule* createModImpl(weld::Window* pWin, const 
ScriptDocument& rDocument,
 bool bEntry = rBasicBox.FindEntry(aModName, 
OBJ_TYPE_MODULE, *xEntry);
 if (!bEntry)
 {
-rBasicBox.AddEntry(aModName, RID_BMP_MODULE, 
xEntry.get(), false,
-   
std::make_unique(OBJ_TYPE_MODULE));
+rBasicBox.AddEntry(aModName, RID_BMP_MODULE, 
xSubRootEntry.get(), false,
+   
std::make_unique(OBJ_TYPE_MODULE), xEntry.get());
 }
 rBasicBox.set_cursor(*xEntry);
 rBasicBox.select(*xEntry);
diff --git a/basctl/source/inc/bastype2.hxx b/basctl/source/inc/bastype2.hxx
index 881bddb4fa09..9777ba7ce26b 100644
--- a/basctl/source/inc/bastype2.hxx
+++ b/basctl/source/inc/bastype2.hxx
@@ -300,7 +300,9 @@ public:
 static ItemType ConvertType (EntryType eType);
 boolIsValidEntry(weld::TreeIter& rEntry);
 void AddEntry(const OUString& rText, const OUString& rImage,
-  const weld::TreeIter* pIter, bool bChildrenOnDemand, 
std::unique_ptr&& rUserData);
+  const weld::TreeIter* pParent, bool bChildrenOnDemand,
+  std::unique_ptr&& rUserData,
+  weld::TreeIter* pRet = nullptr);
 
 void connect_changed(const Link& rLink) { 
m_xControl->connect_changed(rLink); }
 std::unique_ptr make_iterator(const weld::TreeIter* pIter 
= nullptr) const { return m_xControl->make_iterator(pIter); }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 78916] Custom page size missing from print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78916

--- Comment #19 from Cor Nouws  ---
(In reply to huber.joseph from comment #18)
> The inability to print to custom page sizes is still present in
> Version: 6.2.2.2
> Build ID: 1:6.2.2-0ubuntu0.16.04.1~lo1
> 
> This is the latest version for my Linux distro.

That is sad. Since there is a new print dialog now, can you please describe the
precise steps/settings that you make? Thanks in advance, Cor

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114773] TOC: Remove additional space after chapter number in ToC

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114773

--- Comment #18 from Cor Nouws  ---

Patch introducing the problem is this one
 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=ce95e39f8e952159844e9dc04a1df402bb103634

Note: before that patch, there was no space between the chapter number and the
chapter text. Which is annoying and much more prevalent than the example of
this bug. It was a problem in OOo already (and is in AOO)
See bug 44282

File with the code is here
 
https://opengrok.libreoffice.org/xref/core/sw/source/core/tox/ToxTextGenerator.cxx?r=80cedb5d

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Myanmar dictionary

[Drew Jensen]

Just in case 64bit Linux is correct for you - if you start on the main
download page, find your OS and you will find a link to the language packs
there for your particular OS.

On Sat, Apr 27, 2019 at 3:18 PM Drew Jensen 
wrote:

> Howdy,
>
> If you are looking for Burmese there is a language pack listed on the
> download page.
> All available are listed here
>
> https://www.libreoffice.org/download/download/?type=deb-x86_64=6.2.3=pick
>
>
> Hope that helps.
>
> Best wishes,
>
> Drew
>
> On Sat, Apr 27, 2019 at 3:04 PM Cyrille  wrote:
>
>> Hello,
>> I'm currently helping a friend to use Libreoffice for the publication of
>> a book in Myanmar. But all the links for Myanmar/burmese in this page point
>> to very old package no more compatible with new LO release:
>> https://wiki.documentfoundation.org/Language_support_of_LibreOffice.
>> To type text the installation of the palauk font solve the problem on
>> Ubuntu.
>> For dictionary on this link
>> 
>> I found an old extension with an hunspell dic for OpenOffice and it is
>> probably possible to create a new extension for Libreoffice. I'm ready to
>> do the work, but I couldn't maintain it. Would it be possible to add it
>> directly to Libreoffice sources?
>> The same page says that the ui is translated but on Ubuntu I couldn't see
>> the translation with the "my" locale. the
>> http://thanlwinsoft.github.io/www.thanlwinsoft.org/ThanLwinSoft/Downloads/
>> page says too that graphite give this UI translation, then how to use it on
>> LO?
>>
>> Thanks for help.
>> Cyrille
>> ___
>> LibreOffice mailing list
>> LibreOffice@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Myanmar dictionary

[Drew Jensen]

Howdy,

If you are looking for Burmese there is a language pack listed on the
download page.
All available are listed here
https://www.libreoffice.org/download/download/?type=deb-x86_64=6.2.3=pick


Hope that helps.

Best wishes,

Drew

On Sat, Apr 27, 2019 at 3:04 PM Cyrille  wrote:

> Hello,
> I'm currently helping a friend to use Libreoffice for the publication of a
> book in Myanmar. But all the links for Myanmar/burmese in this page point
> to very old package no more compatible with new LO release:
> https://wiki.documentfoundation.org/Language_support_of_LibreOffice.
> To type text the installation of the palauk font solve the problem on
> Ubuntu.
> For dictionary on this link
> 
> I found an old extension with an hunspell dic for OpenOffice and it is
> probably possible to create a new extension for Libreoffice. I'm ready to
> do the work, but I couldn't maintain it. Would it be possible to add it
> directly to Libreoffice sources?
> The same page says that the ui is translated but on Ubuntu I couldn't see
> the translation with the "my" locale. the
> http://thanlwinsoft.github.io/www.thanlwinsoft.org/ThanLwinSoft/Downloads/
> page says too that graphite give this UI translation, then how to use it on
> LO?
>
> Thanks for help.
> Cyrille
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: libreofficekit/source

[Michael Meeks (via logerrit)]

 libreofficekit/source/gtk/lokdocview.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 85dc12a99b455126e8deae5637bf63c48ce8938e
Author: Michael Meeks 
AuthorDate: Fri Apr 26 21:40:05 2019 +0100
Commit: Michael Meeks 
CommitDate: Sat Apr 27 21:05:33 2019 +0200

lok: handle missing callback.

Change-Id: I13a200c9c9d8b0a8fde6dd15a71fe1a665d04e8d
Reviewed-on: https://gerrit.libreoffice.org/71432
Tested-by: Jenkins
Reviewed-by: Michael Meeks 

diff --git a/libreofficekit/source/gtk/lokdocview.cxx 
b/libreofficekit/source/gtk/lokdocview.cxx
index 36601e385173..3187daed6a41 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -1449,6 +1449,8 @@ callback (gpointer pData)
 case LOK_CALLBACK_INVALIDATE_HEADER:
 g_signal_emit(pCallback->m_pDocView, 
doc_view_signals[INVALIDATE_HEADER], 0, pCallback->m_aPayload.c_str());
 break;
+case LOK_CALLBACK_CONTEXT_CHANGED:
+break; // TODO
 default:
 g_assert(false);
 break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Myanmar dictionary

[Cyrille]

Hello,
I'm currently helping a friend to use Libreoffice for the publication of
a book in Myanmar. But all the links for Myanmar/burmese in this page
point to very old package no more compatible with new LO release:
https://wiki.documentfoundation.org/Language_support_of_LibreOffice.
To type text the installation of the palauk font solve the problem on
Ubuntu.
For dictionary on this link

I found an old extension with an hunspell dic for OpenOffice and it is
probably possible to create a new extension for Libreoffice. I'm ready
to do the work, but I couldn't maintain it. Would it be possible to add
it directly to Libreoffice sources?
The same page says that the ui is translated but on Ubuntu I couldn't
see the translation with the "my" locale. the
http://thanlwinsoft.github.io/www.thanlwinsoft.org/ThanLwinSoft/Downloads/
page says too that graphite give this UI translation, then how to use it
on LO?

Thanks for help.
Cyrille
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: cppu/source cui/source reportdesign/source sd/source

[Mike Kaganski (via logerrit)]

 cppu/source/uno/lbmap.cxx   |   19 +++-
 cui/source/tabpages/paragrph.cxx|7 +--
 reportdesign/source/ui/report/ReportSection.cxx |5 --
 sd/source/core/sdpage.cxx   |3 -
 sd/source/ui/remotecontrol/Receiver.cxx |   51 +++-
 sd/source/ui/view/presvish.cxx  |4 -
 6 files changed, 40 insertions(+), 49 deletions(-)

New commits:
commit ba57c3e041bb05ef49a3ea7940a4183f09775a18
Author: Mike Kaganski 
AuthorDate: Sat Apr 27 19:57:17 2019 +0300
Commit: Mike Kaganski 
CommitDate: Sat Apr 27 20:59:34 2019 +0200

tdf#120703 PVS: V581 ifs with identical conditions

V581 The conditional expressions of the 'if' statements situated
 alongside each other are identical.

Change-Id: I79c655a072faff0bdb2af031ed1328e684b83aac
Reviewed-on: https://gerrit.libreoffice.org/71430
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/cppu/source/uno/lbmap.cxx b/cppu/source/uno/lbmap.cxx
index fc093907c591..6979c74042f9 100644
--- a/cppu/source/uno/lbmap.cxx
+++ b/cppu/source/uno/lbmap.cxx
@@ -603,21 +603,18 @@ void SAL_CALL uno_getMapping(
 
 if (*ppMapping)
 return;
-}
 
-if (! aRet.is()) // try callback chain
-{
-MutexGuard aGuard( rData.aCallbacksMutex );
-for ( const auto& rCallback : rData.aCallbacks )
+// try callback chain
 {
-(*rCallback)( ppMapping, pFrom, pTo, aAddPurpose.pData );
-if (*ppMapping)
-return;
+MutexGuard aGuard(rData.aCallbacksMutex);
+for (const auto& rCallback : rData.aCallbacks)
+{
+(*rCallback)(ppMapping, pFrom, pTo, aAddPurpose.pData);
+if (*ppMapping)
+return;
+}
 }
-}
 
-if (! aRet.is())
-{
 aRet = loadExternalMapping( aFrom, aTo, aAddPurpose ); // direct try
 if (! aRet.is())
 aRet = getMediateMapping( aFrom, aTo, aAddPurpose ); // try via uno
diff --git a/cui/source/tabpages/paragrph.cxx b/cui/source/tabpages/paragrph.cxx
index 12372d0127bf..caa7a97b33c3 100644
--- a/cui/source/tabpages/paragrph.cxx
+++ b/cui/source/tabpages/paragrph.cxx
@@ -954,27 +954,28 @@ void SvxStdParagraphTabPage::PageCreated(const 
SfxAllItemSet& aSet)
 nWidth = pPageWidthItem->GetValue();
 
 if (pFlagSetItem )
+{
 if (( 0x0001 & pFlagSetItem->GetValue())== 0x0001 )
 EnableRelativeMode();
 
-if (pFlagSetItem)
 if (( 0x0002 & pFlagSetItem->GetValue())== 0x0002 )
 EnableRegisterMode();
 
-if (pFlagSetItem)
 if ( ( 0x0004 & pFlagSetItem->GetValue())== 0x0004 )
 EnableAutoFirstLine();
+}
 
 if(pLineDistItem)
 EnableAbsLineDist(pLineDistItem->GetValue());
 
 if (pFlagSetItem)
+{
 if  (( 0x0008 & pFlagSetItem->GetValue()) == 0x0008 )
 EnableNegativeMode();
 
-if (pFlagSetItem)
 if  (( 0x0010 & pFlagSetItem->GetValue()) == 0x0010 )
 EnableContextualMode();
+}
 }
 
 #define LASTLINEPOS_DEFAULT 0
diff --git a/reportdesign/source/ui/report/ReportSection.cxx 
b/reportdesign/source/ui/report/ReportSection.cxx
index 43814411a25f..909376cd21be 100644
--- a/reportdesign/source/ui/report/ReportSection.cxx
+++ b/reportdesign/source/ui/report/ReportSection.cxx
@@ -154,11 +154,8 @@ void OReportSection::Paint( vcl::RenderContext& 
rRenderContext, const tools::Rec
 // draw background self using wallpaper
 OutputDevice& rTargetOutDev = 
pTargetPaintWindow->GetTargetOutputDevice();
 rTargetOutDev.DrawWallpaper(rRect, 
Wallpaper(pPgView->GetApplicationDocumentColor()));
-}
 
-// do paint (unbuffered) and mark repaint end
-if(pPgView)
-{
+// do paint (unbuffered) and mark repaint end
 pPgView->DrawLayer(RPT_LAYER_FRONT, );
 pPgView->GetView().EndDrawLayers(*pTargetPaintWindow, true);
 }
diff --git a/sd/source/core/sdpage.cxx b/sd/source/core/sdpage.cxx
index a5903269364f..e37602afcf9e 100644
--- a/sd/source/core/sdpage.cxx
+++ b/sd/source/core/sdpage.cxx
@@ -564,10 +564,7 @@ SdrObject* SdPage::CreatePresObj(PresObjKind eObjKind, 
bool bVertical, const ::t
 if( bUndo )
 {
 
pUndoManager->AddUndoAction(getSdrModelFromSdrPage().GetSdrUndoFactory().CreateUndoNewObject(*pSdrObj));
-}
 
-if( bUndo )
-{
 pUndoManager->AddUndoAction( 
std::make_unique( *pSdrObj ) );
 pUndoManager->AddUndoAction( 
std::make_unique(*pSdrObj) );
 }
diff --git a/sd/source/ui/remotecontrol/Receiver.cxx 
b/sd/source/ui/remotecontrol/Receiver.cxx
index 04b50f9a3936..6a987a67e877 100644
--- a/sd/source/ui/remotecontrol/Receiver.cxx
+++ b/sd/source/ui/remotecontrol/Receiver.cxx
@@ -136,33 +136,32 @@ 

[Libreoffice-bugs] [Bug 120703] Bugs found by PVS-Studio static analyzer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120703

--- Comment #161 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/ba57c3e041bb05ef49a3ea7940a4183f09775a18%5E%21

tdf#120703 PVS: V581 ifs with identical conditions

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114773] TOC: Remove additional space after chapter number in ToC

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114773

--- Comment #17 from Cor Nouws  ---
(In reply to Cor Nouws from comment #2)
> (In reply to Thomas Lendo from comment #0)
> 
> Have you tested it with a different locale?
> The problem does not appear in my LibreOffice.

I see it now too in my version. Maybe I made a mistake first. Sorry in that
case.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92825] [META] Update help for all menu changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92825
Bug 92825 depends on bug 124198, which changed state.

Bug 124198 Summary: move ImageMap from Edit to Tools menu
https://bugs.documentfoundation.org/show_bug.cgi?id=124198

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124198] move ImageMap from Edit to Tools menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124198

Buovjaga  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED
 CC||todven...@suomi24.fi

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125001] Tip of day shows a different bulb icon everytime

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125001

--- Comment #2 from Heiko Tietze  ---
Btw, you can click "Next tip" to go through the list (in a random sequence).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125001] Tip of day shows a different bulb icon everytime

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125001

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Heiko Tietze  ---
Each tip can have its own icon. With the latest iteration I submitted
decorations with the tips when it's specific to a module. Meaning, Calc symbol
at the bulb is a tip for Calc, etc. And without it's a generic LibreOffice tip.
=> NAB

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124984] Organize basic macro: newly added module doesn't show up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124984

Caolán McNamara  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |ASSIGNED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108539] [META] Chart data table bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108539
Bug 108539 depends on bug 124975, which changed state.

Bug 124975 Summary: Modifying chart data range with mouse selection doesn't 
update range
https://bugs.documentfoundation.org/show_bug.cgi?id=124975

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/gtk3/gtk3gtkinst.cxx |   33 +++--
 1 file changed, 11 insertions(+), 22 deletions(-)

New commits:
commit 3ffb0373695a7b3a7f8cab8f2b8bf259c4300a7e
Author: Caolán McNamara 
AuthorDate: Sat Apr 27 16:06:22 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Apr 27 20:17:25 2019 +0200

Resolves: tdf#124975 toggle parent input blocked only in set_modal

since...

commit e54762baa8019d02cadd311e750f6ff0d276f67b
Author: Caolán McNamara 
Date:   Tue Apr 16 17:17:58 2019 +0100

weld ScTPValidationValue and ScValidationDlg

the inc/dev modality on show/hide isn't desirable anymore

Change-Id: I5bf908871986160de61508c9678495d0d5a8296d
Reviewed-on: https://gerrit.libreoffice.org/71426
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 2bb5a83abaa1..e2024dd6a2c6 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -2975,32 +2975,12 @@ public:
 return GtkToVcl(ret);
 }
 
-virtual void hide() override
-{
-if (!gtk_widget_get_visible(m_pWidget))
-return;
-gtk_widget_hide(m_pWidget);
-// if we hide the dialog while its running, then decrement the parent 
LibreOffice window
-// modal count, we expect the dialog to restored while its running and 
match up with
-// the inc_modal_count of show()
-//
-// This hide while running case is for the calc/chart dialogs which put
-// up an extra range chooser dialog, hides the original, the user can
-// select a range of cells and on completion the original dialog is
-// restored
-if (m_aDialogRun.loop_is_running())
-m_aDialogRun.dec_modal_count();
-}
-
 virtual void show() override
 {
 if (gtk_widget_get_visible(m_pWidget))
 return;
 
sort_native_button_order(GTK_BOX(gtk_dialog_get_action_area(m_pDialog)));
 gtk_widget_show(m_pWidget);
-// see hide comment
-if (m_aDialogRun.loop_is_running())
-m_aDialogRun.inc_modal_count();
 }
 
 virtual void set_modal(bool bModal) override
@@ -3008,8 +2988,17 @@ public:
 if (get_modal() == bModal)
 return;
 GtkInstanceWindow::set_modal(bModal);
-// see hide comment, but the modality-change example
-// is the validity dialog in calc
+/* if change the dialog modality while its running, then also change 
the parent LibreOffice window
+   modal count, we typically expect the dialog modality to be restored 
to its original state
+
+   This change modality while running case is for...
+
+   a) the calc/chart dialogs which put up an extra range chooser
+   dialog, hides the original, the user can select a range of cells and
+   on completion the original dialog is restored
+
+   b) the validity dialog in calc
+*/
 if (m_aDialogRun.loop_is_running())
 {
 if (bModal)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - libreofficekit/source

[Michael Meeks (via logerrit)]

 libreofficekit/source/gtk/lokdocview.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit a85221127ca3d9b805a3abff490a5ed7d8b5cbe5
Author: Michael Meeks 
AuthorDate: Fri Apr 26 21:40:05 2019 +0100
Commit: Michael Meeks 
CommitDate: Sat Apr 27 18:52:11 2019 +0100

lok: handle missing callback.

Change-Id: I13a200c9c9d8b0a8fde6dd15a71fe1a665d04e8d

diff --git a/libreofficekit/source/gtk/lokdocview.cxx 
b/libreofficekit/source/gtk/lokdocview.cxx
index 1dd109375481..eac27751eeb9 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -1448,6 +1448,8 @@ callback (gpointer pData)
 case LOK_CALLBACK_INVALIDATE_HEADER:
 g_signal_emit(pCallback->m_pDocView, 
doc_view_signals[INVALIDATE_HEADER], 0, pCallback->m_aPayload.c_str());
 break;
+case LOK_CALLBACK_CONTEXT_CHANGED:
+break; // TODO
 default:
 g_assert(false);
 break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124755] Crash - Hsqldb ODB file crashes office on opening from StartCenter

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124755

--- Comment #11 from Drew Jensen  ---
(In reply to Alex Thurgood from comment #10)
> No crash either when testing file on Linux ElementaryOS Juno with LO6073 or
> 6222(snap)

Same situation here (Ubuntu 18.04) along with trying LO6.0 - LO6.3 I tried
different Java packages:
Java-11-openjdk
jdk-10.0.2
jdk-8-openjdk

No problem with any of them.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123484] LibreOffice 6.2 shows duplicated items on the main top bar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123484

--- Comment #7 from huber.jos...@tx.rr.com ---
I am also affected by this bug. I am running
Version: 6.2.2.2
Build ID: 1:6.2.2-0ubuntu0.16.04.1~lo1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125002] [Styles] Tab stop settings get mixed up during editting them

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125002

Martin Sourada  changed:

   What|Removed |Added

 CC||martin.sour...@gmail.com

--- Comment #1 from Martin Sourada  ---
Created attachment 151042
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151042=edit
Short video showing the bug

I created a short screencast where the problem is shown.
I also noticed the bug is in GTK3 plugin, GTK2 works correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78916] Custom page size missing from print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78916

--- Comment #18 from huber.jos...@tx.rr.com ---
The inability to print to custom page sizes is still present in
Version: 6.2.2.2
Build ID: 1:6.2.2-0ubuntu0.16.04.1~lo1

This is the latest version for my Linux distro.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125002] New: [Styles] Tab stop settings get mixed up during editting them

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125002

Bug ID: 125002
   Summary: [Styles] Tab stop settings get mixed up during
editting them
   Product: LibreOffice
   Version: 6.2.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: martin.sour...@gmail.com

Description:
Tabs stops settings get all confused or even lost during editing them in
paragraph style.

Steps to Reproduce:
1. Prepare text with three tabs
2. Add three tabs stops with different settings in the used paragraph style
3. Press OK
4. Enter the paragraph style settings again
5. Switch to and fro between different positions in the Tabs tab
6. Press OK

Actual Results:
Tab stops settings get all mixed up

Expected Results:
Tab stops settings do not change


Reproducible: Always


User Profile Reset: No



Additional Info:
I am not able to reproduce in 6.1.5.2 so it seems to be a regression.

Version: 6.2.3.2
Build ID: aecc05fe267cc68dde00352a451aa867b3b546ac
CPU threads: 2; OS: Linux 5.0; UI render: default; VCL: gtk3; 
Locale: en-US (C); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - vcl/inc

[Matthias Seidel (via logerrit)]

 vcl/inc/unx/x11_cursors/airbrush_curs.h |   42 --
 vcl/inc/unx/x11_cursors/airbrush_mask.h |   42 --
 vcl/inc/unx/x11_cursors/ase_curs.h  |   42 --
 vcl/inc/unx/x11_cursors/ase_mask.h  |   41 +++---
 vcl/inc/unx/x11_cursors/asn_curs.h  |   42 --
 vcl/inc/unx/x11_cursors/asn_mask.h  |   42 --
 vcl/inc/unx/x11_cursors/asne_curs.h |   42 --
 vcl/inc/unx/x11_cursors/asne_mask.h |   42 --
 vcl/inc/unx/x11_cursors/asns_curs.h |   42 --
 vcl/inc/unx/x11_cursors/asns_mask.h |   42 --
 vcl/inc/unx/x11_cursors/asnswe_curs.h   |   42 --
 vcl/inc/unx/x11_cursors/asnswe_mask.h   |   42 --
 vcl/inc/unx/x11_cursors/asnw_curs.h |   42 --
 vcl/inc/unx/x11_cursors/asnw_mask.h |   42 --
 vcl/inc/unx/x11_cursors/ass_curs.h  |   42 --
 vcl/inc/unx/x11_cursors/ass_mask.h  |   42 --
 vcl/inc/unx/x11_cursors/asse_curs.h |   42 --
 vcl/inc/unx/x11_cursors/asse_mask.h |   42 --
 vcl/inc/unx/x11_cursors/assw_curs.h |   42 --
 vcl/inc/unx/x11_cursors/assw_mask.h |   42 --
 vcl/inc/unx/x11_cursors/asw_curs.h  |   42 --
 vcl/inc/unx/x11_cursors/asw_mask.h  |   42 --
 vcl/inc/unx/x11_cursors/aswe_curs.h |   42 --
 vcl/inc/unx/x11_cursors/aswe_mask.h |   42 --
 vcl/inc/unx/x11_cursors/chain_curs.h|   42 --
 vcl/inc/unx/x11_cursors/chain_mask.h|   44 --
 vcl/inc/unx/x11_cursors/chainnot_curs.h |   42 --
 vcl/inc/unx/x11_cursors/chainnot_mask.h |   44 --
 vcl/inc/unx/x11_cursors/chart_curs.h|   42 --
 vcl/inc/unx/x11_cursors/chart_mask.h|   42 --
 vcl/inc/unx/x11_cursors/copydata_curs.h |   44 --
 vcl/inc/unx/x11_cursors/copydata_mask.h |   44 --
 vcl/inc/unx/x11_cursors/copydlnk_curs.h |   44 --
 vcl/inc/unx/x11_cursors/copydlnk_mask.h |   44 --
 vcl/inc/unx/x11_cursors/copyfile_curs.h |   44 --
 vcl/inc/unx/x11_cursors/copyfile_mask.h |   44 --
 vcl/inc/unx/x11_cursors/copyfiles_curs.h|   44 --
 vcl/inc/unx/x11_cursors/copyfiles_mask.h|   44 --
 vcl/inc/unx/x11_cursors/copyflnk_curs.h |   44 --
 vcl/inc/unx/x11_cursors/copyflnk_mask.h |   44 --
 vcl/inc/unx/x11_cursors/crook_curs.h|   44 --
 vcl/inc/unx/x11_cursors/crook_mask.h|   46 ---
 vcl/inc/unx/x11_cursors/crop_curs.h |   44 --
 vcl/inc/unx/x11_cursors/crop_mask.h |   46 ---
 vcl/inc/unx/x11_cursors/detective_curs.h|   42 --
 vcl/inc/unx/x11_cursors/detective_mask.h|   42 --
 vcl/inc/unx/x11_cursors/drawarc_curs.h  |   44 --
 vcl/inc/unx/x11_cursors/drawarc_mask.h  |   46 ---
 vcl/inc/unx/x11_cursors/drawbezier_curs.h   |   44 --
 vcl/inc/unx/x11_cursors/drawbezier_mask.h   |   46 ---
 vcl/inc/unx/x11_cursors/drawcaption_curs.h  |   44 --
 vcl/inc/unx/x11_cursors/drawcaption_mask.h  |   46 ---
 vcl/inc/unx/x11_cursors/drawcirclecut_curs.h|   44 --
 vcl/inc/unx/x11_cursors/drawcirclecut_mask.h|   46 ---
 vcl/inc/unx/x11_cursors/drawconnect_curs.h  |   44 --
 vcl/inc/unx/x11_cursors/drawconnect_mask.h  |   46 ---
 vcl/inc/unx/x11_cursors/drawcrook_curs.h|   44 --
 vcl/inc/unx/x11_cursors/drawcrook_mask.h|   46 ---
 vcl/inc/unx/x11_cursors/drawcrop_curs.h |   44 --
 vcl/inc/unx/x11_cursors/drawcrop_mask.h |   46 ---
 vcl/inc/unx/x11_cursors/drawellipse_curs.h  |   44 --
 vcl/inc/unx/x11_cursors/drawellipse_mask.h  |   46 ---
 vcl/inc/unx/x11_cursors/drawfreehand_curs.h |   44 --
 vcl/inc/unx/x11_cursors/drawfreehand_mask.h |   46 ---
 vcl/inc/unx/x11_cursors/drawline_curs.h |   44 --
 vcl/inc/unx/x11_cursors/drawline_mask.h |   46 ---
 vcl/inc/unx/x11_cursors/drawmirror_curs.h   |   44 --
 vcl/inc/unx/x11_cursors/drawmirror_mask.h   |   46 ---
 vcl/inc/unx/x11_cursors/drawpie_curs.h  |   44 --
 vcl/inc/unx/x11_cursors/drawpie_mask.h  |   46 ---
 vcl/inc/unx/x11_cursors/drawpolygon_curs.h  |   44 --
 vcl/inc/unx/x11_cursors/drawpolygon_mask.h  |   46 ---
 vcl/inc/unx/x11_cursors/drawrect_curs.h |   44 --
 vcl/inc/unx/x11_cursors/drawrect_mask.h |   46 ---
 

[Libreoffice-bugs] [Bug 124994] Cell Formatting for URL websites, or other URI schemes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124994

--- Comment #2 from V Stuart Foote  ---
And should have noted that a "hyperlink", as entered currently in a cell, can
already be followed with a +click of the cell.

Seems like the "Open Hyperlink" should be available to assign as a shortcut in
customizing Calc, but does not match the +click mouse action.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 124994] Cell Formatting for URL websites, or other URI schemes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124994

--- Comment #2 from V Stuart Foote  ---
And should have noted that a "hyperlink", as entered currently in a cell, can
already be followed with a +click of the cell.

Seems like the "Open Hyperlink" should be available to assign as a shortcut in
customizing Calc, but does not match the +click mouse action.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: unoidl/IwyuFilter_unoidl.yaml

[Gabor Kelemen (via logerrit)]

 unoidl/IwyuFilter_unoidl.yaml |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit 30e619db016b59bd0c4c8aba518b20012f7ae829
Author: Gabor Kelemen 
AuthorDate: Thu Apr 25 16:13:28 2019 +0200
Commit: Caolán McNamara 
CommitDate: Sat Apr 27 17:46:09 2019 +0200

tdf#42949 Add filter file to unoidl/

Seems I forgot about this in commit
7f6a5b433988e80f7d404c67d6320116ecb28c06

Change-Id: Ic575292b99836374f179cbc1dbe182858415b63f
Reviewed-on: https://gerrit.libreoffice.org/71306
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/unoidl/IwyuFilter_unoidl.yaml b/unoidl/IwyuFilter_unoidl.yaml
new file mode 100644
index ..c0f74e5ffdd9
--- /dev/null
+++ b/unoidl/IwyuFilter_unoidl.yaml
@@ -0,0 +1,6 @@
+---
+assumeFilename: unoidl/source/unoidl.cxx
+blacklist:
+unoidl/source/unoidl-write.cxx:
+# Avoid loplugin:oslendian error
+- osl/endian.h
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits