[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

tommy27  changed:

   What|Removed |Added

   Priority|medium  |highest

--- Comment #35 from tommy27  ---
there's an important performance regression since the 6.2.x branch.

trying to load large autocorrect replacement tables  such as the one in
attachment 134684 causes freezing in LibO 6.2.0 and 6.2.3 final releases

that list can be loaded with no problems in latest 6.1.5 release.

this means that the autocorrect replacement table load option is completely
broken in 6.2.x so I have to raise the importance of this bug report.

this bug block upgrading from 6.1.x to 6.2.x to all users with large
autocorrect lists.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125209] New: Cannot search or download Firefox Themes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125209

Bug ID: 125209
   Summary: Cannot search or download Firefox Themes
   Product: LibreOffice
   Version: 6.2.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: frank...@goodhorse.idv.tw

Description:
In the menu Tools - Options - LibreOffice - Personalization, when choosing "Own
Theme" and "Select Theme", the dialog "Select Firefox Theme" was appeared. 
However in this dialog no matter I chose any category or directly paste a
specified Firefox theme URL and click "Find", always no result was found.

Steps to Reproduce:
1. Open LibreOffice (any component)
2. Choose "Tools" - "Options", in the LibreOffice section choose
"Personalization"
3. Choose "Own Theme" and click "Select Theme"
4. Change the item in the Category dropdown menu.  No results are found with
any Category.
5. Paste the URL of a specified Firefox theme (for example,
https://addons.mozilla.org/en/firefox/addon/tattoo-passion_27/) in the upper
box and click "Find", no results found either.

Actual Results:
Can not find any theme from Firefox.

Expected Results:
It should allow me to choose from a specified category or allow me to download
it directly.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.2.3.2
Build ID: aecc05fe267cc68dde00352a451aa867b3b546ac
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: kde5; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 119751] Microsoft 365 Support

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=119751

--- Comment #1 from rayanwarner44  ---
Get in touch with the experts at Office 365 Support in just one call. Reach for
these experts anytime to get resolution at whatever point you think you require
them the most.
Visit Here- https://www.microsoft-supportnumber.com/office-365-support

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125206] Edit mode password required in Excel is bypassed in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125206

raal  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102018] Toolbar mode switching slow on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102018

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125202] Fileopen: Lines from MSO xlsx are misplaced in LO calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125202

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #11 from Regina Henschel  ---
The problem is not with the lines, but the text has a different line spacing
than in Excel.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125206] Edit mode password required in Excel is bypassed in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125206

David  changed:

   What|Removed |Added

 CC||david.gen...@du.edu

--- Comment #2 from David  ---
Created attachment 151298
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151298=edit
Excel file named "Password issue"


Hello,
Attached is a file I just created in Excel. It requires the password 123456 to
open the file, and requires the password 654321 to leave Read Only mode to edit
the file.  This works correctly in Excel.  When I try to open the file in
LibreOffice Calc, the password 123456 is asked for to open the file, but if I
choose Edit Mode from the Edit menu, I can double click in a cell like B1 and
enter information without being asked to enter the password 654321 to exit Read
Only mode and enter Edit Mode to edit the document. Thanks for looking into
this. Great suite of programs.
Best,
David

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113944] [META] Options dialog's Writer settings bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113944
Bug 113944 depends on bug 125129, which changed state.

Bug 125129 Summary: Parts of text in Option's AutoCaption object list not 
visible when selected
https://bugs.documentfoundation.org/show_bug.cgi?id=125129

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125129] Parts of text in Option's AutoCaption object list not visible when selected

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125129

raal  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #4 from raal  ---


*** This bug has been marked as a duplicate of bug 125197 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121691] line callout doesn't draw in certain writer documents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121691

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #8 from raal  ---
bisected with bibisect-linux-64-6.1. Lots of crashes when place callout during
bibisect, and it looks like crashes started with
https://cgit.freedesktop.org/libreoffice/core/commit/?id=bf46b46a1d734348096936284fb8a76e977936d0
 (14.3.2018)
and  crash is fixed with
https://cgit.freedesktop.org/libreoffice/core/commit/?id=2dadf90aa7bb03d895abc05ec93ca116eb9bacbd
  (20.3.2018)

Before crash is callout correct and after crash is callout with bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125206] Edit mode password required in Excel is bypassed in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125206

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||r...@post.cz

--- Comment #1 from raal  ---
Hello,

Thank you for filing the bug. Please send us a sample document, as this makes
it easier for us to verify the bug. 
I have set the bug's status to 'NEEDINFO', so please do change it back to
'UNCONFIRMED' once you have attached a document.
(Please note that the attachment will be public, remove any sensitive
information before attaching it.)
How can I eliminate confidential data from a sample document?
https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F
Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113825] [META] Wizard bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113825
Bug 113825 depends on bug 124837, which changed state.

Bug 124837 Summary: Crash in "Minimize Presentation..." Wizard
https://bugs.documentfoundation.org/show_bug.cgi?id=124837

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124837] Crash in "Minimize Presentation..." Wizard

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124837

Julien Nabet  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #5 from Julien Nabet  ---
Let's put this one to WFM then since you don't reproduce this anymore.
About how it's been fixed, don't know and don't know too if it's a dup or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/uiconfig

[andreas kainz (via logerrit)]

 sw/uiconfig/swriter/ui/notebookbar_compact.ui |  540 +-
 sw/uiconfig/swriter/ui/notebookbar_single.ui  |  243 +--
 2 files changed, 472 insertions(+), 311 deletions(-)

New commits:
commit 95574416cf323b958c4be4d215dc9e9a7e5e6b1b
Author: andreas kainz 
AuthorDate: Fri May 10 21:45:48 2019 +0200
Commit: andreas_kainz 
CommitDate: Fri May 10 22:41:13 2019 +0200

NB writer: add RTL LTR support for notebookbar_compact _single

Change-Id: Ib1d5adedff17f6e250029fe8b20ad491aa2718b3
Reviewed-on: https://gerrit.libreoffice.org/72136
Tested-by: Jenkins
Reviewed-by: andreas_kainz 

diff --git a/sw/uiconfig/swriter/ui/notebookbar_compact.ui 
b/sw/uiconfig/swriter/ui/notebookbar_compact.ui
index 91d6973e3d1e..72d3d053bbf6 100644
--- a/sw/uiconfig/swriter/ui/notebookbar_compact.ui
+++ b/sw/uiconfig/swriter/ui/notebookbar_compact.ui
@@ -3208,7 +3208,7 @@
   
 False
 True
-0
+1
   
 
 
@@ -3245,24 +3245,7 @@
   
 False
 True
-1
-  
-
-
-  
-True
-False
-center
-5
-5
-True
-vertical
-  
-  
-False
-True
-5
-3
+2
   
 
   
@@ -3283,7 +3266,24 @@
 True
 False
 center
-True
+
+  
+True
+False
+end
+center
+5
+5
+True
+vertical
+  
+  
+False
+False
+5
+0
+  
+
 
   
 True
@@ -3318,11 +3318,23 @@
   
 False
 True
-0
+1
   
 
+  
+  
+False
+True
+0
+  
+
+
+  
+True
+False
+center
 
-  
+  
 True
 False
 end
@@ -3336,23 +3348,9 @@
 False
 False
 5
-end
-1
+0
   
 
-  
-  
-False
-True
-0
-  
-
-
-  
-True
-False
-center
-True
 
   
 True
@@ -3374,11 +3372,11 @@
   
 False
 True
-0
+1
   
 
 
-  
+  
 
   
   
@@ -3392,7 +3390,6 @@
 True
 False
 center
-True
 
   
 True
@@ -3415,30 +3412,11 @@
   
 False
 True
-0
-  
-
-
-

[Libreoffice-bugs] [Bug 125129] Parts of text in Option's AutoCaption object list not visible when selected

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125129

--- Comment #3 from Caolán McNamara  ---
Is this a duplicate of bug 125197 and fixed what that fix ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - include/svl offapi/com sc/qa sc/source

[Eike Rathke (via logerrit)]

 include/svl/zforlist.hxx |7 
 offapi/com/sun/star/util/NumberFormat.idl|7 
 sc/qa/unit/data/functions/statistical/fods/rank.fods |  739 +++
 sc/source/core/tool/interpr4.cxx |   21 
 sc/source/core/tool/interpr5.cxx |9 
 5 files changed, 317 insertions(+), 466 deletions(-)

New commits:
commit f01e31762b02b8b896e726238eb2475c0e01ef82
Author: Eike Rathke 
AuthorDate: Tue May 7 23:17:45 2019 +0200
Commit: Caolán McNamara 
CommitDate: Fri May 10 22:27:19 2019 +0200

Resolves: tdf#125099 round duration results in interpreter already

 This is a combination of 3 commits.

Resolves: tdf#125099 round duration results in interpreter already

So wall clock time formats less likely display a one-off value,
duration formats are too rarely used if the expected duration is
less than 24 hours.

Reviewed-on: https://gerrit.libreoffice.org/71909
Tested-by: Jenkins
Reviewed-by: Eike Rathke 
(cherry picked from commit 85c0521f01f5c726e9f754b3175a550121e566c8)

Test RANK(), not the underlying floating point representation of duration

The RANK() results depended on the floating point representation
of time differences (durations), which for visually equal MM:SS
display values don't have to be equal if similar durations result
from different start and end times. Change that to a well defined
duration in seconds.

b69a6b43f48abd2d4fe605021acfd2800e75b5e1
Reviewed-on: https://gerrit.libreoffice.org/71926
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit 8de7949050d63fd9f7ac41e1a2442849580b86fa)

Fix typed flags bitmask, tdf#125099 follow-up

25327cfcafc9e1f2e88b388677853c638dd9b0e6
Reviewed-on: https://gerrit.libreoffice.org/71946
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit d27ad84ec7a0aafb07d6a6152c686f4bc802f661)

Change-Id: I9b0872420699b17e3ed3f20993f8cfe02761f862
Reviewed-on: https://gerrit.libreoffice.org/71935
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/include/svl/zforlist.hxx b/include/svl/zforlist.hxx
index 143d14e03f50..cf7b1dec34a9 100644
--- a/include/svl/zforlist.hxx
+++ b/include/svl/zforlist.hxx
@@ -109,9 +109,14 @@ enum class SvNumFormatType : sal_Int16
  @since LibreOffice 5.1
   */
  EMPTY = css::util::NumberFormat::EMPTY, // 4096
+/** @internal selects a time duration format.
+8192 + TIME (4)
+@since LibreOffice 6.2
+ */
+ DURATION = css::util::NumberFormat::DURATION, // 8196
 };
 namespace o3tl {
-template<> struct typed_flags : 
is_typed_flags {};
+template<> struct typed_flags : 
is_typed_flags {};
 }
 
 /** enum values for SvNumberFormatter::GetFormatIndex
diff --git a/offapi/com/sun/star/util/NumberFormat.idl 
b/offapi/com/sun/star/util/NumberFormat.idl
index 2bc297aed425..e66a59d7e215 100644
--- a/offapi/com/sun/star/util/NumberFormat.idl
+++ b/offapi/com/sun/star/util/NumberFormat.idl
@@ -99,6 +99,13 @@ published constants NumberFormat
  */
 const short EMPTY = 4096;
 
+
+/** @internal selects a time duration format.
+8192 + TIME (4)
+@since LibreOffice 6.2
+ */
+const short DURATION = 8196;
+
 };
 
 
diff --git a/sc/qa/unit/data/functions/statistical/fods/rank.fods 
b/sc/qa/unit/data/functions/statistical/fods/rank.fods
index 880f3659032b..d12703d5ee55 100644
--- a/sc/qa/unit/data/functions/statistical/fods/rank.fods
+++ b/sc/qa/unit/data/functions/statistical/fods/rank.fods
@@ -1,12 +1,12 @@
 
 
 http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 

[Libreoffice-commits] core.git: 2 commits - sw/source vcl/source

[Caolán McNamara (via logerrit)]

 sw/source/ui/fldui/flddinf.cxx |6 +-
 vcl/source/window/dialog.cxx   |   36 ++--
 2 files changed, 15 insertions(+), 27 deletions(-)

New commits:
commit 243aad91e17960405b472eadd9f9976fec8b7028
Author: Caolán McNamara 
AuthorDate: Fri May 10 11:03:36 2019 +0100
Commit: Caolán McNamara 
CommitDate: Fri May 10 22:26:42 2019 +0200

Related: tdf#125198 centralize notifyWindow:created to one place

Change-Id: I2729cb85f156ddafec69cc3280e9d8544f7c6182
Reviewed-on: https://gerrit.libreoffice.org/72117
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/source/window/dialog.cxx b/vcl/source/window/dialog.cxx
index c1921d238c67..7f7fc3a9ef7d 100644
--- a/vcl/source/window/dialog.cxx
+++ b/vcl/source/window/dialog.cxx
@@ -752,23 +752,25 @@ void Dialog::StateChanged( StateChangedType nType )
 {
 if (nType == StateChangedType::InitShow)
 {
-if (comphelper::LibreOfficeKit::isActive() && !GetLOKNotifier())
+DoInitialLayout();
+
+const bool bKitActive = comphelper::LibreOfficeKit::isActive();
+if (bKitActive)
 {
-vcl::ILibreOfficeKitNotifier* pViewShell = 
mpDialogImpl->m_aInstallLOKNotifierHdl.Call(nullptr);
-if (pViewShell)
+if (!GetLOKNotifier())
+
SetLOKNotifier(mpDialogImpl->m_aInstallLOKNotifierHdl.Call(nullptr));
+
+if (const vcl::ILibreOfficeKitNotifier* pNotifier = 
GetLOKNotifier())
 {
-SetLOKNotifier(pViewShell);
 std::vector aItems;
 aItems.emplace_back("type", "dialog");
 aItems.emplace_back("size", GetSizePixel().toString());
 if (!GetText().isEmpty())
 aItems.emplace_back("title", GetText().toUtf8());
-pViewShell->notifyWindow(GetLOKWindowId(), "created", aItems);
+pNotifier->notifyWindow(GetLOKWindowId(), "created", aItems);
 }
 }
 
-DoInitialLayout();
-
 if ( !HasChildPathFocus() || HasFocus() )
 GrabFocusToFirstControl();
 if ( !(GetStyle() & WB_CLOSEABLE) )
@@ -889,12 +891,7 @@ bool Dialog::ImplStartExecute()
 if (bModal)
 {
 if (bKitActive && !GetLOKNotifier())
-{
-if (vcl::ILibreOfficeKitNotifier* pViewShell = 
mpDialogImpl->m_aInstallLOKNotifierHdl.Call(nullptr))
-{
-SetLOKNotifier(pViewShell);
-}
-}
+
SetLOKNotifier(mpDialogImpl->m_aInstallLOKNotifierHdl.Call(nullptr));
 
 switch ( Application::GetDialogCancelMode() )
 {
@@ -925,19 +922,6 @@ bool Dialog::ImplStartExecute()
 std::abort();
 }
 
-if (bKitActive)
-{
-if(const vcl::ILibreOfficeKitNotifier* pNotifier = 
GetLOKNotifier())
-{
-std::vector aItems;
-aItems.emplace_back("type", "dialog");
-aItems.emplace_back("size", GetSizePixel().toString());
-if (!GetText().isEmpty())
-aItems.emplace_back("title", GetText().toUtf8());
-pNotifier->notifyWindow(GetLOKWindowId(), "created", aItems);
-}
-}
-
 #ifdef DBG_UTIL
 vcl::Window* pParent = GetParent();
 if ( pParent )
commit 8da6a8fcf1a71588a22bf4afae8d5e54b7b0bcad
Author: Caolán McNamara 
AuthorDate: Fri May 10 16:21:46 2019 +0100
Commit: Caolán McNamara 
CommitDate: Fri May 10 22:26:30 2019 +0200

fix assert for expand_row while frozen

Change-Id: I78578cd1578317a16d2eb62e23ddcc01bc39347a
Reviewed-on: https://gerrit.libreoffice.org/72130
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/ui/fldui/flddinf.cxx b/sw/source/ui/fldui/flddinf.cxx
index 6ec3db4e8cf8..0603774eb127 100644
--- a/sw/source/ui/fldui/flddinf.cxx
+++ b/sw/source/ui/fldui/flddinf.cxx
@@ -126,6 +126,7 @@ void SwFieldDokInfPage::Reset(const SfxItemSet* )
 std::vector aLst;
 GetFieldMgr().GetSubTypes(TYP_DOCINFOFLD, aLst);
 std::unique_ptr xEntry(m_xTypeTLB->make_iterator());
+std::unique_ptr xExpandEntry;
 for(size_t i = 0; i < aLst.size(); ++i)
 {
 if (!IsFieldEdit() || nSubType == i)
@@ -155,7 +156,7 @@ void SwFieldDokInfPage::Reset(const SfxItemSet* )
 if (m_sOldCustomFieldName == sEntry)
 {
 m_xSelEntry = 
m_xTypeTLB->make_iterator(xEntry.get());
-m_xTypeTLB->expand_row(*xInfo);
+xExpandEntry = 
m_xTypeTLB->make_iterator(xInfo.get());
 }
 }
 }
@@ -176,6 +177,9 @@ void SwFieldDokInfPage::Reset(const SfxItemSet* )
 
 m_xTypeTLB->thaw();
 
+if (xExpandEntry)
+  

[Libreoffice-commits] core.git: libreofficekit/qa libreofficekit/source

[Michael Meeks (via logerrit)]

 libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx |   15 ++
 libreofficekit/qa/gtktiledviewer/gtv-application-window.hxx |2 
 libreofficekit/qa/gtktiledviewer/gtv-application.cxx|5 
 libreofficekit/source/gtk/lokdocview.cxx|   63 
 4 files changed, 81 insertions(+), 4 deletions(-)

New commits:
commit f29fded5a52f4c2fc1aae307e1f43326dd04108c
Author: Michael Meeks 
AuthorDate: Thu May 9 18:25:22 2019 +0100
Commit: Michael Meeks 
CommitDate: Fri May 10 22:16:42 2019 +0200

unipoll: add a --unipoll parameter to gtktiledviewer.

Arguably should be the default. Implementation is a bit cute -
re-starting the main-loop as a child of a callback from its
idle handler.

Change-Id: I95e87c8a4ae3de745d7ca1f636859dd1d8deca17
Reviewed-on: https://gerrit.libreoffice.org/72072
Tested-by: Jenkins
Reviewed-by: Michael Meeks 

diff --git a/libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx 
b/libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx
index 1de1aa94568d..564c1de137c6 100644
--- a/libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx
@@ -356,9 +356,18 @@ gtv_application_window_load_document(GtvApplicationWindow* 
window,
 *(priv->m_pRenderingArgs) = *aArgs;
 
 // setup lokdocview
-window->lokdocview = 
lok_doc_view_new_from_user_profile(priv->m_pRenderingArgs->m_aLoPath.c_str(),
-
priv->m_pRenderingArgs->m_aUserProfile.empty() ? nullptr : 
priv->m_pRenderingArgs->m_aUserProfile.c_str(),
-  nullptr, nullptr);
+const char *pUserProfile = priv->m_pRenderingArgs->m_aUserProfile.empty() ?
+nullptr : priv->m_pRenderingArgs->m_aUserProfile.c_str();
+
+window->lokdocview = GTK_WIDGET(
+g_initable_new(LOK_TYPE_DOC_VIEW, nullptr, nullptr,
+   "lopath", priv->m_pRenderingArgs->m_aLoPath.c_str(),
+   "unipoll", priv->m_pRenderingArgs->m_bUnipoll,
+   "userprofileurl", pUserProfile,
+   "halign", GTK_ALIGN_CENTER,
+   "valign", GTK_ALIGN_CENTER,
+   nullptr));
+
 gtk_container_add(GTK_CONTAINER(window->scrolledwindow), 
window->lokdocview);
 
 setupDocView(window);
diff --git a/libreofficekit/qa/gtktiledviewer/gtv-application-window.hxx 
b/libreofficekit/qa/gtktiledviewer/gtv-application-window.hxx
index 748195c5aff0..21508097e077 100644
--- a/libreofficekit/qa/gtktiledviewer/gtv-application-window.hxx
+++ b/libreofficekit/qa/gtktiledviewer/gtv-application-window.hxx
@@ -24,6 +24,7 @@ struct GtvRenderingArgs
 std::string m_aLoPath;
 std::string m_aUserProfile;
 bool m_bEnableTiledAnnotations;
+bool m_bUnipoll;
 
 std::string m_aBackgroundColor;
 bool m_bHidePageShadow;
@@ -31,6 +32,7 @@ struct GtvRenderingArgs
 
 GtvRenderingArgs()
 : m_bEnableTiledAnnotations(false),
+  m_bUnipoll(false),
   m_bHidePageShadow(false),
   m_bHideWhiteSpace(false)
 { }
diff --git a/libreofficekit/qa/gtktiledviewer/gtv-application.cxx 
b/libreofficekit/qa/gtktiledviewer/gtv-application.cxx
index 3d802ee325d4..15e5f15f1697 100644
--- a/libreofficekit/qa/gtktiledviewer/gtv-application.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtv-application.cxx
@@ -46,6 +46,7 @@ gtv_application_init(GtvApplication* app)
 {
 { "version", 0, 0, G_OPTION_ARG_NONE, nullptr, "Show LOkit version", 
nullptr },
 { "lo-path", 0, 0, G_OPTION_ARG_STRING, nullptr, "LO path", nullptr },
+{ "unipoll", 0, 0, G_OPTION_ARG_NONE, nullptr, "Enable unified polling 
loop", nullptr },
 { "user-profile", 0, 0, G_OPTION_ARG_STRING, nullptr, "User profile to 
use", nullptr },
 { "enable-tiled-annotations", 0, 0, G_OPTION_ARG_NONE, nullptr, 
"Whether tiled annotations should be enabled", nullptr },
 { "background-color", 0, 0, G_OPTION_ARG_STRING, nullptr, "Background 
color", nullptr },
@@ -92,11 +93,13 @@ gtv_application_handle_local_options(GApplication* app, 
GVariantDict* options)
 return 1; // Cannot afford to continue in absence of this param
 }
 
+if (g_variant_dict_contains(options, "unipoll"))
+priv->m_pRenderingArgs->m_bUnipoll = true;
+
 if (g_variant_dict_contains(options, "version"))
 {
 if (!priv->m_pRenderingArgs->m_aLoPath.empty())
 {
-// FIXME: Crashes for some reason
 GtkWidget* pDocView = 
lok_doc_view_new(priv->m_pRenderingArgs->m_aLoPath.c_str(), nullptr, nullptr);
 const gchar* versionInfo = 
lok_doc_view_get_version_info(LOK_DOC_VIEW(pDocView));
 if (versionInfo)
diff --git a/libreofficekit/source/gtk/lokdocview.cxx 
b/libreofficekit/source/gtk/lokdocview.cxx
index 

[Libreoffice-bugs] [Bug 119931] Fix accessibility warnings in .ui files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=119931

--- Comment #13 from Commit Notification 
 ---
Samuel Thibault committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/d422a9d0cb914260192fbc68305db088af022204%5E%21

tdf#119931 Fix a11y warnings in classificationdialog.ui

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: solenv/sanitizers svx/uiconfig

[Samuel Thibault (via logerrit)]

 solenv/sanitizers/ui/svx.false  |2 --
 svx/uiconfig/ui/classificationdialog.ui |8 +++-
 2 files changed, 7 insertions(+), 3 deletions(-)

New commits:
commit d422a9d0cb914260192fbc68305db088af022204
Author: Samuel Thibault 
AuthorDate: Thu May 9 14:39:27 2019 +0200
Commit: Katarina Behrens 
CommitDate: Fri May 10 22:19:19 2019 +0200

tdf#119931 Fix a11y warnings in classificationdialog.ui

Make "Content" a label for the drawing area

Change-Id: I2238ea42d33564d848376e3c33b9d9a46af094ae
Reviewed-on: https://gerrit.libreoffice.org/72045
Tested-by: Jenkins
Reviewed-by: Katarina Behrens 

diff --git a/solenv/sanitizers/ui/svx.false b/solenv/sanitizers/ui/svx.false
index e30560c59517..16af737bb931 100644
--- a/solenv/sanitizers/ui/svx.false
+++ b/solenv/sanitizers/ui/svx.false
@@ -1,6 +1,4 @@
 
svx/uiconfig/ui/classificationdialog.ui://GtkTreeViewColumn[@id='treeviewcolumn3']
 no-labelled-by
-svx/uiconfig/ui/classificationdialog.ui:GtkDialog[@id='AdvancedDocumentClassificationDialog']/GtkBox[@id='dialog-vbox1']/GtkGrid/GtkGrid/GtkLabel
 orphan-label
-svx/uiconfig/ui/classificationdialog.ui://GtkDrawingArea[@id='classificationEditWindow']
 no-labelled-by
 
svx/uiconfig/ui/classificationdialog.ui://GtkTreeViewColumn[@id='treeviewcolumn6']
 no-labelled-by
 
svx/uiconfig/ui/classificationdialog.ui://GtkTreeViewColumn[@id='treeviewcolumn4']
 no-labelled-by
 
diff --git a/svx/uiconfig/ui/classificationdialog.ui 
b/svx/uiconfig/ui/classificationdialog.ui
index e4c9c0299ae6..29690610e250 100644
--- a/svx/uiconfig/ui/classificationdialog.ui
+++ b/svx/uiconfig/ui/classificationdialog.ui
@@ -274,12 +274,15 @@
 True
 3
 
-  
+  
 True
 False
 Content
 0
 0
+
+  
+
   
   
 0
@@ -341,6 +344,9 @@
 True
 GDK_BUTTON_MOTION_MASK | 
GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | 
GDK_KEY_RELEASE_MASK | GDK_FOCUS_CHANGE_MASK | GDK_STRUCTURE_MASK
 True
+
+  
+
   
 
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 112521] [META] Message box dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112521

Aron Budea  changed:

   What|Removed |Added

 Depends on|121312  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121312
[Bug 121312] Autofilter "The range does not contain column headers." question
is missing in online
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121312] Autofilter "The range does not contain column headers." question is missing in online

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121312

Aron Budea  changed:

   What|Removed |Added

 Blocks|112521  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112521
[Bug 112521] [META] Message box dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125102] LO crashes upon trying to save a file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125102

--- Comment #5 from Christian Lehmann  ---
LO 6.1.5.2 installed under Kubuntu 18.04, KDE Plasma 5.12.7.
LO 6.1.6.3 installed under Ubuntu 18.04.2.
The file operations which, if called while an LO file is open, guarantee crash
of LO 6.1.5, appear to work well with LO 6.1.6.

It may be noted, however, that this is a very serious bug with which LO 6.1.5
should no longer be distributed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 69042] Add a "Release Notes/What's New" window to be shown upon first run

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=69042

--- Comment #29 from Emir Sarı (away)  ---
(In reply to V Stuart Foote from comment #28)
> (In reply to Heiko Tietze from comment #27)
> > 
> > Stephan suggested it the other way with What's-New in the infobar. Plus, the
> > Tip-Of-The-Day should have an appealing design with a supporting image.
> 
> Yes that is correct, and would be my preference as well--it would make sense
> to put a "What's New this release" message there. Rather than in a special
> pop-open "tip" that was just implemented..  
> 
> Looking at bug 83009, we use the Infobar to announce read only mode, hold
> the classification tool, and already place an icon notice for available
> update.  So, keeping it for sensible things, and see this  "What's new" at
> major release as sensible--even if just a URL link (hosted to New Help and
> bundled into the local help for offline users).

I see. Yes, it makes perfect sense now. +1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 121378] Writer/UI: Adding Captions to Images is very Unpractical (Width of Image Changes with Width of Frame, Does not use Default Frame Style etc)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121378

Heiko Tietze  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #8 from Heiko Tietze  ---
The caption requires a frame so the request is to have the initial frame width
like the page width (and not scale the image). I would expect "relative size"
and 100% does the trick but doesn't. Regina, any idea?

Second part is about the paragraph style "Figure" that is applied to above the
image and not the caption text. Reason here is that the figure that has no
break nor is anchored as character. I don't see a solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125208] New: Crash when selecting Read Online Help

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125208

Bug ID: 125208
   Summary: Crash when selecting Read Online Help
   Product: LibreOffice
   Version: 6.1.6.3 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: pedl...@gmail.com

LibreOffice 6.1.6.3 was installed on Ubuntu 16.04.5 x64 by extracting the DEBS
folder and running sudo dpkg -i *.deb in Terminal.
No Help package was installed.

Steps to reproduce:

1. Start any module (Writer, Calc, etc) or open Start Center and Create a new
document of any kind (from menu or button) or open any document
2. Click on menu Help, LibreOffice Help and then on any option (Read Help
Online or Cancel)

Result
LibreOffice crashes

Expected
Help is opened in Browser

Some curious details: 

1) if you open Start Center (without opening or creating any document) and
proceed to step 2 there is no crash and Help opens in Browser

2) if you press F1 instead of using the menus, there is no crash and Help opens
in Browser

3) if you create a new Impress document and click on the Help button on the
Template window, there is no crash and Help opens in Browser

Sample Crash Report
crashreport.libreoffice.org/stats/crash_details/dc0040dd-7901-4686-bcd4-fb5845b54526

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 121378] Writer/UI: Adding Captions to Images is very Unpractical (Width of Image Changes with Width of Frame, Does not use Default Frame Style etc)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121378

Heiko Tietze  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #8 from Heiko Tietze  ---
The caption requires a frame so the request is to have the initial frame width
like the page width (and not scale the image). I would expect "relative size"
and 100% does the trick but doesn't. Regina, any idea?

Second part is about the paragraph style "Figure" that is applied to above the
image and not the caption text. Reason here is that the figure that has no
break nor is anchored as character. I don't see a solution.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 121378] Writer/UI: Adding Captions to Images is very Unpractical (Width of Image Changes with Width of Frame, Does not use Default Frame Style etc)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121378

Heiko Tietze  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=87
   ||720

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87720] Default insert image anchor, wrapping, and spacing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87720

Heiko Tietze  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||1378

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 121378] Writer/UI: Adding Captions to Images is very Unpractical (Width of Image Changes with Width of Frame, Does not use Default Frame Style etc)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121378

Heiko Tietze  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=87
   ||720

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 87720] Default insert image anchor, wrapping, and spacing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87720

Heiko Tietze  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||1378

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 125183] Rounding Error in Formula Addition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125183

kit...@tutanota.com changed:

   What|Removed |Added

 CC||kit...@tutanota.com
 Ever confirmed|0   |1
 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

--- Comment #3 from kit...@tutanota.com ---
Sorry, but you've made a mistake.  By using your own sheet, you've failed to
make mine work or show how it could.  It does not by adding ROUND to the
beginning of the formula as you suggest.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/svl sc/source svl/source

[Eike Rathke (via logerrit)]

 include/svl/zforlist.hxx|2 +-
 sc/source/core/data/formulacell.cxx |5 +
 sc/source/core/tool/interpr4.cxx|5 -
 svl/source/numbers/zforlist.cxx |   34 ++
 4 files changed, 32 insertions(+), 14 deletions(-)

New commits:
commit d77495060016c5e97d6e367c2a44fec83cf441f2
Author: Eike Rathke 
AuthorDate: Fri May 10 17:26:57 2019 +0200
Commit: Eike Rathke 
CommitDate: Fri May 10 20:57:52 2019 +0200

Apply duration format for such newly entered formula cells

... and the cell didn't have a number format applied already,
[HH]:MM:SS instead of wall clock time format HH:MM:SS which comes
to a surprise anyway if the result is >=24h.

Related to tdf#125099

Change-Id: I6c19a86177f8714ac588d6798acf86e247a79b26
Reviewed-on: https://gerrit.libreoffice.org/72131
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/include/svl/zforlist.hxx b/include/svl/zforlist.hxx
index 8caa7fb3d276..032809b8f82e 100644
--- a/include/svl/zforlist.hxx
+++ b/include/svl/zforlist.hxx
@@ -640,7 +640,7 @@ public:
 bool IsSpecialStandardFormat( sal_uInt32 nFIndex, LanguageType eLnge );
 
 /** Return a time format that best matches fNumber. */
-sal_uInt32 GetTimeFormat( double fNumber, LanguageType eLnge );
+sal_uInt32 GetTimeFormat( double fNumber, LanguageType eLnge, bool 
bForceDuration );
 
 /** Return a format and type that best matches the value of fNumber if
 fNumber is assumed to be a date, time or datetime value, but unknown
diff --git a/sc/source/core/data/formulacell.cxx 
b/sc/source/core/data/formulacell.cxx
index 4b2a06fe548d..48cb55fae27a 100644
--- a/sc/source/core/data/formulacell.cxx
+++ b/sc/source/core/data/formulacell.cxx
@@ -2115,6 +2115,11 @@ void ScFormulaCell::InterpretTail( ScInterpreterContext& 
rContext, ScInterpretTa
 bChanged = true;
 }
 
+// Currently (2019-05-10) nothing else can cope with a duration
+// format type, change to time as it was before.
+if (nFormatType == SvNumFormatType::DURATION)
+nFormatType = SvNumFormatType::TIME;
+
 mbNeedsNumberFormat = false;
 }
 
diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index 286583e875c5..8cd191c6e00b 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -4667,11 +4667,6 @@ StackVar ScInterpreter::Interpret()
 else
 nRetFmtType = SvNumFormatType::NUMBER;
 
-// Currently (2019-05-06) nothing else can cope with a duration format
-// type, change to time as it was before.
-if (nRetFmtType == SvNumFormatType::DURATION)
-nRetFmtType = SvNumFormatType::TIME;
-
 if (nGlobalError != FormulaError::NONE && GetStackType() != svError )
 PushError( nGlobalError);
 
diff --git a/svl/source/numbers/zforlist.cxx b/svl/source/numbers/zforlist.cxx
index 01b9453ed9eb..705e0624c785 100644
--- a/svl/source/numbers/zforlist.cxx
+++ b/svl/source/numbers/zforlist.cxx
@@ -68,6 +68,7 @@ using namespace ::std;
 #define ZF_STANDARD_CURRENCY20
 #define ZF_STANDARD_DATE30
 #define ZF_STANDARD_TIME40
+#define ZF_STANDARD_DURATION(ZF_STANDARD_TIME + 4)
 #define ZF_STANDARD_DATETIME50
 #define ZF_STANDARD_SCIENTIFIC  60
 #define ZF_STANDARD_FRACTION65
@@ -1224,6 +1225,8 @@ bool SvNumberFormatter::IsCompatible(SvNumFormatType 
eOldType, SvNumFormatType e
 return false;
 }
 break;
+case SvNumFormatType::DURATION:
+return false;
 default:
 return false;
 }
@@ -1246,6 +1249,9 @@ sal_uInt32 SvNumberFormatter::ImpGetDefaultFormat( 
SvNumFormatType nType )
 case SvNumFormatType::DATETIME:
 nSearch = CLOffset + ZF_STANDARD_DATETIME;
 break;
+case SvNumFormatType::DURATION:
+nSearch = CLOffset + ZF_STANDARD_DURATION;
+break;
 case SvNumFormatType::PERCENT:
 nSearch = CLOffset + ZF_STANDARD_PERCENT;
 break;
@@ -1289,6 +1295,9 @@ sal_uInt32 SvNumberFormatter::ImpGetDefaultFormat( 
SvNumFormatType nType )
 case SvNumFormatType::DATETIME:
 nDefaultFormat = CLOffset + ZF_STANDARD_DATETIME;
 break;
+case SvNumFormatType::DURATION:
+nDefaultFormat = CLOffset + ZF_STANDARD_DURATION;
+break;
 case SvNumFormatType::PERCENT:
 nDefaultFormat = CLOffset + ZF_STANDARD_PERCENT+1;
 break;
@@ -1317,6 +1326,8 @@ sal_uInt32 SvNumberFormatter::GetStandardFormat( 
SvNumFormatType eType, Language
 {
 case SvNumFormatType::CURRENCY:
 return ( eLnge == LANGUAGE_SYSTEM ) ? 
ImpGetDefaultSystemCurrencyFormat() : ImpGetDefaultCurrencyFormat();
+case SvNumFormatType::DURATION :
+return GetFormatIndex( NF_TIME_HH_MMSS, eLnge);
 case 

[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102495
Bug 102495 depends on bug 119855, which changed state.

Bug 119855 Summary: kde5: Context menu doesn't collapse when it loses focus
https://bugs.documentfoundation.org/show_bug.cgi?id=119855

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 119855] kde5: Context menu doesn't collapse when it loses focus

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=119855

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #1 from Michael Weghorn  ---
I can no longer reproduce with a current master build. The context menu now
closes as expected.
-> WORKSFORME

Version: 6.3.0.0.alpha0+
Build ID: 425a570a114d9a087e5320f071604f64d43fcec1
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: kde5; 
Locale: en-GB (en_GB.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 69042] Add a "Release Notes/What's New" window to be shown upon first run

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=69042

--- Comment #27 from Heiko Tietze  ---
(In reply to Emir Sarı (away) from comment #26)
> I agree. For daily tips an info bar would be more appropriate. For release
> notes one-time windows suit better.

Stephan suggested it the other way with What's-New in the infobar. Plus, the
Tip-Of-The-Day should have an appealing design with a supporting image.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 125204] Not using the theme based icons for .UI of Customize dialogs on Windows builds

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125204

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
Summary|windows didn't use the  |Not using the theme based
   |icons in Customize dialog   |icons for .UI of Customize
   ||dialogs on Windows builds
 CC||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote  ---
Confirmed on Windows 10 Ent 64-bit en-US with recent master/6.3.0 build
Version: 6.3.0.0.alpha0+
Build ID: 85c0521f01f5c726e9f754b3175a550121e566c8
CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: CL

Looks like the stock UI icons used on Windows are old Industrial/Galaxy, maybe?
Or something earlier...

But IIUC don't think the button's assigned icons (image1 - gtk-go-up, image2 -
gtk-go-down, image3 - gtk-go-forward, image4 - gtk-go-back) come from UI
[1][2], rather they're linked from source. Where they are mapped to stock
SymbolType [3]. And I've no idea how the icon theme for os/DE gets picked up
for use there--if it can.


=-refs-=
[1] https://opengrok.libreoffice.org/xref/core/cui/uiconfig/ui
[2] https://opengrok.libreoffice.org/xref/core/cui/source/customize
[3]
https://opengrok.libreoffice.org/xref/core/vcl/source/window/builder.cxx?r=ed67b443#90

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125193] Draw tab of Tabbed menu become inactive in certain cases

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125193

Durgapriyanka  changed:

   What|Removed |Added

 OS|Linux (All) |All
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #1 from Durgapriyanka  ---
Thank you for reporting the bug. I can confirm the bug present in 

Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124644] Template manager broken since version 6.2.2.1 for Linux

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124644

--- Comment #9 from Peter  ---
well, yes the behavior should be fixed in LO.

But when I have a look closer at the contents of user-dirs.dirs, it looks very
much like this file was added later.
On my notebook 
XDG_TEMPLATE_DIR="$Home/Vorlagen"  the directory Vorlagen exists.
On my workstation
XDG_TEMPLATE_DIR="$Home/" there is no Vorlagen or Template directory.

Assuming that an OS-upgrade step adding the user-dirs.dirs file is propably
also analysing the existing directory structure - it is not finding "Vorlagen"
or "Templates" directory and therefor not adding the subdirectory to "$HOME/".
Maybe it will be a good idea to create the subdirectory and add it to the end
of XDG_TEMPLATE_DIR ...

regards

Peter

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102593
Bug 102593 depends on bug 124277, which changed state.

Bug 124277 Summary: Slower pasting of sheets
https://bugs.documentfoundation.org/show_bug.cgi?id=124277

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124277] Slower pasting of sheets

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124277

Telesto  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEEDINFO|RESOLVED

--- Comment #10 from Telesto  ---
(In reply to Xisco Faulí from comment #9)
> That build seems to be one month old. I would consider it master anymore...

It was master at the time when tested.. comment 7 is a month old ;-)

Anyway, no repro with
Version: 6.3.0.0.alpha0+
Build ID: 91b2239783dc716bd71ce7962bfd7e341dfe4175
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-05-08_09:49:32
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/uiconfig

[andreas kainz (via logerrit)]

 sw/uiconfig/swriter/ui/notebookbar_compact.ui | 2083 ++
 sw/uiconfig/swriter/ui/notebookbar_single.ui  |  590 ++-
 2 files changed, 2327 insertions(+), 346 deletions(-)

New commits:
commit df3e1af532d937229b5b2e6621e582d459760f6a
Author: andreas kainz 
AuthorDate: Fri May 10 12:05:50 2019 +0200
Commit: andreas_kainz 
CommitDate: Fri May 10 20:31:25 2019 +0200

NB writer: sync single and compact NB

Change-Id: Ic943faba4b042299dbe2fd8a38d5d27832e39aad
Reviewed-on: https://gerrit.libreoffice.org/72116
Tested-by: Jenkins
Reviewed-by: andreas_kainz 

diff --git a/sw/uiconfig/swriter/ui/notebookbar_compact.ui 
b/sw/uiconfig/swriter/ui/notebookbar_compact.ui
index d8c8d2fa2dc9..91d6973e3d1e 100644
--- a/sw/uiconfig/swriter/ui/notebookbar_compact.ui
+++ b/sw/uiconfig/swriter/ui/notebookbar_compact.ui
@@ -395,6 +395,166 @@
   
 
   
+  
+True
+False
+
+  
+True
+False
+.uno:Label
+  
+
+
+  
+True
+False
+.uno:Edit
+  
+
+
+  
+True
+False
+.uno:CheckBox
+  
+
+
+  
+True
+False
+.uno:RadioButton
+  
+
+
+  
+True
+False
+.uno:ListBox
+  
+
+
+  
+True
+False
+.uno:ComboBox
+  
+
+
+  
+True
+False
+  
+
+
+  
+True
+False
+.uno:Pushbutton
+  
+
+
+  
+True
+False
+.uno:Imagebutton
+  
+
+
+  
+True
+False
+  
+
+
+  
+True
+False
+.uno:FormattedField
+  
+
+
+  
+True
+False
+  
+
+
+  
+True
+False
+.uno:DateField
+  
+
+
+  
+True
+False
+.uno:TimeField
+  
+
+
+  
+True
+False
+.uno:NumericField
+  
+
+
+  
+True
+False
+.uno:CurrencyField
+  
+
+
+  
+True
+False
+.uno:PatternField
+  
+
+
+  
+True
+False
+  
+
+
+  
+True
+False
+.uno:ImageControl
+  
+
+
+  
+True
+False
+.uno:FileControl
+  
+
+
+  
+True
+False
+  
+
+
+  
+True
+False
+.uno:Grid
+  
+
+
+  
+True
+False
+.uno:NavigationBar
+  
+
+  
   
 True
 False
@@ -2946,7 +3106,7 @@
   
 True
 False
-File
+~File
 True
   
   
@@ -4452,7 +4612,7 @@
   
 True
 False
-Home
+~Home
 True
 
   
@@ -5476,7 +5636,7 @@
   
   
@@ -6247,7 +6407,7 @@
   
   
@@ -6682,7 +6842,7 @@
   
   
@@ -6701,7 +6861,7 @@
 center
 True
 
-  

[Libreoffice-ux-advise] [Bug 69042] Add a "Release Notes/What's New" window to be shown upon first run

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=69042

--- Comment #26 from Emir Sarı (away)  ---
(In reply to Stephan Bergmann from comment #25)
> Instead of a window, couldn't this be an info bar?  Would appear to be less
> annoying that way.

I agree. For daily tips an info bar would be more appropriate. For release
notes one-time windows suit better.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: chart2/source

[Stephan Bergmann (via logerrit)]

 chart2/source/model/main/FormattedString.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9929682da7c63f8cbdc4f833bce4a9410957607b
Author: Stephan Bergmann 
AuthorDate: Fri May 10 17:07:24 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Fri May 10 19:38:03 2019 +0200

Revert "Temporarily remove "final" from chart::FormattedString"

This reverts commit f43b5d1e6035e6ed619ab425009a7895ac271716, now that the
experiment is done.

Change-Id: I0f483023c7f9f4f5ae1edaa7abb7056e1c4e30a1
Reviewed-on: https://gerrit.libreoffice.org/72129
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/chart2/source/model/main/FormattedString.hxx 
b/chart2/source/model/main/FormattedString.hxx
index 91aab68d9189..9d17d5f3885a 100644
--- a/chart2/source/model/main/FormattedString.hxx
+++ b/chart2/source/model/main/FormattedString.hxx
@@ -43,7 +43,7 @@ typedef ::cppu::WeakImplHelper<
 FormattedString_Base;
 }
 
-class FormattedString :
+class FormattedString final :
 public MutexContainer,
 public impl::FormattedString_Base,
 public ::property::OPropertySet
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125207] extend "css:awt:XPrinterServer" with method getDefaultPrinterName()

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125207

Oliver Brinzing  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
 Ever confirmed|0   |1
 CC||oliver.brinz...@gmx.de
   Assignee|libreoffice-b...@lists.free |oliver.brinz...@gmx.de
   |desktop.org |

--- Comment #1 from Oliver Brinzing  ---
assigning to me, will try to implement

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125207] New: extend "css:awt:XPrinterServer" with method getDefaultPrinterName()

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125207

Bug ID: 125207
   Summary: extend "css:awt:XPrinterServer" with method
getDefaultPrinterName()
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: framework
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: oliver.brinz...@gmx.de

css:awt:XPrinterServer has a method to get a list of available printer names,
but there is no method to get the current default printer name.
https://api.libreoffice.org/docs/idl/ref/interfacecom_1_1sun_1_1star_1_1awt_1_1XPrinterServer.html

"Printer::GetDefaultPrinterName()" is already available in "vclxprinter.cxx".

steps to implement new interface "css::awt::XPrinterServer2":

- change "toolkit\awt\vclxprinter.cxx":
  +OUString VCLXPrinterServer::getDefaultPrinterName()
  +{
  +return Printer::GetDefaultPrinterName();
  +}

- change "include\toolkit\awt\vclxprinter.cxx":
  +OUString SAL_CALL getDefaultPrinterName() override;

- add "offapi\com\sun\star\awt\XPrinterServer2.idl"
  +published interface XPrinterServer2: ::com::sun::star::awt::XPrinterServer
  +{
  +   string getDefaultPrinterName();
  +};

- change "offapi\com\sun\star\awt\PrinterServer.idl"
  -service PrinterServer: com::sun::star::awt::XPrinterServer;
  +service PrinterServer: com::sun::star::awt::XPrinterServer2;

- change "\offapi\type_reference\offapi.idl"
  +published interface XPrinterServer2 {
  +  interface ::com::sun::star::awt::XPrinterServer;
  +  string getDefaultPrinterName();
  +};

- change "\offapi\unoApi_offapi.mk"
  + XPrinterServer2 \

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118544] Optional macro parameter defined as Integer has type Variant/String causing type errors in the macro

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=118544

himajin100...@gmail.com changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=59 |
   |327 |
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=36
   ||737

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118544] Optional macro parameter defined as Integer has type Variant/String causing type errors in the macro

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=118544

himajin100...@gmail.com changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=59 |
   |327 |
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=36
   ||737

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 59327] BASIC: A missing optional argument is treated as a not declared variable.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=59327

himajin100...@gmail.com changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=11 |
   |8544|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 59327] BASIC: A missing optional argument is treated as a not declared variable.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=59327

himajin100...@gmail.com changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||8544

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118544] Optional macro parameter defined as Integer has type Variant/String causing type errors in the macro

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=118544

himajin100...@gmail.com changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=59
   ||327

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4' - kit/Kit.cpp

[Libreoffice Gerrit user]

 kit/Kit.cpp |   15 ---
 1 file changed, 4 insertions(+), 11 deletions(-)

New commits:
commit d12d46ed02890f5533fbca6d506c1efac718d826
Author: Michael Meeks 
AuthorDate: Fri May 10 18:03:11 2019 +0100
Commit: Michael Meeks 
CommitDate: Fri May 10 18:07:12 2019 +0100

unipoll: remove now redundant SocketPoll parameters.

Change-Id: I8308a0b503db34ac43658a5461005a32132d392f

diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index dfa80055e..fa80d1a69 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -873,7 +873,6 @@ public:
  const std::string& docId,
  const std::string& url,
  std::shared_ptr tileQueue,
- SocketPoll& socketPoll,
  const std::shared_ptr& websocketHandler)
   : _loKit(loKit),
 _jailId(jailId),
@@ -882,7 +881,6 @@ public:
 _url(url),
 _obfuscatedFileId(Util::getFilenameFromURL(docKey)),
 _tileQueue(std::move(tileQueue)),
-_socketPoll(socketPoll),
 _websocketHandler(websocketHandler),
 _docPassword(""),
 _haveDocPassword(false),
@@ -2172,7 +2170,6 @@ private:
 
 std::shared_ptr _loKitDocument;
 std::shared_ptr _tileQueue;
-SocketPoll& _socketPoll;
 std::shared_ptr _websocketHandler;
 
 std::mutex _pngMutex;
@@ -2220,16 +2217,14 @@ class KitWebSocketHandler final : public 
WebSocketHandler, public std::enable_sh
 std::string _socketName;
 std::shared_ptr _loKit;
 std::string _jailId;
-SocketPoll& _socketPoll;
 
 public:
-KitWebSocketHandler(const std::string& socketName, const 
std::shared_ptr& loKit, const std::string& jailId, SocketPoll& 
socketPoll) :
+KitWebSocketHandler(const std::string& socketName, const 
std::shared_ptr& loKit, const std::string& jailId) :
 WebSocketHandler(/* isClient = */ true, /* isMasking */ false),
 _queue(std::make_shared()),
 _socketName(socketName),
 _loKit(loKit),
-_jailId(jailId),
-_socketPoll(socketPoll)
+_jailId(jailId)
 {
 }
 
@@ -2281,9 +2276,7 @@ protected:
 LOG_INF("New session [" << sessionId << "] request on url [" << 
url << "].");
 
 if (!document)
-{
-document = std::make_shared(_loKit, _jailId, docKey, 
docId, url, _queue, _socketPoll, shared_from_this());
-}
+document = std::make_shared(_loKit, _jailId, docKey, 
docId, url, _queue, shared_from_this());
 
 // Validate and create session.
 if (!(url == document->getUrl() && 
document->createSession(sessionId)))
@@ -2736,7 +2729,7 @@ void lokit_main(
 mainKit.runOnClientThread(); // We will do the polling on this thread.
 
 std::shared_ptr websocketHandler =
-std::make_shared("child_ws", loKit, jailId, 
mainKit);
+std::make_shared("child_ws", loKit, jailId);
 #if !MOBILEAPP
 mainKit.insertNewUnixSocket(MasterLocation, pathAndQuery, 
websocketHandler);
 #else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: kit/Kit.cpp

[Libreoffice Gerrit user]

 kit/Kit.cpp |   13 -
 1 file changed, 4 insertions(+), 9 deletions(-)

New commits:
commit 70eb802184b93560c100808fd154f25829c46d8f
Author: Michael Meeks 
AuthorDate: Fri May 10 18:03:11 2019 +0100
Commit: Michael Meeks 
CommitDate: Fri May 10 18:03:11 2019 +0100

unipoll: remove now redundant SocketPoll parameters.

Change-Id: I8308a0b503db34ac43658a5461005a32132d392f

diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 5152a80fd..89a259e39 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -873,7 +873,6 @@ public:
  const std::string& docId,
  const std::string& url,
  std::shared_ptr tileQueue,
- SocketPoll& /*socketPoll*/,
  const std::shared_ptr& websocketHandler)
   : _loKit(loKit),
 _jailId(jailId),
@@ -2209,16 +2208,14 @@ class KitWebSocketHandler final : public 
WebSocketHandler, public std::enable_sh
 std::string _socketName;
 std::shared_ptr _loKit;
 std::string _jailId;
-SocketPoll& _socketPoll;
 
 public:
-KitWebSocketHandler(const std::string& socketName, const 
std::shared_ptr& loKit, const std::string& jailId, SocketPoll& 
socketPoll) :
+KitWebSocketHandler(const std::string& socketName, const 
std::shared_ptr& loKit, const std::string& jailId) :
 WebSocketHandler(/* isClient = */ true, /* isMasking */ false),
 _queue(std::make_shared()),
 _socketName(socketName),
 _loKit(loKit),
-_jailId(jailId),
-_socketPoll(socketPoll)
+_jailId(jailId)
 {
 }
 
@@ -2269,9 +2266,7 @@ protected:
 LOG_INF("New session [" << sessionId << "] request on url [" << 
url << "].");
 
 if (!document)
-{
-document = std::make_shared(_loKit, _jailId, docKey, 
docId, url, _queue, _socketPoll, shared_from_this());
-}
+document = std::make_shared(_loKit, _jailId, docKey, 
docId, url, _queue, shared_from_this());
 
 // Validate and create session.
 if (!(url == document->getUrl() && 
document->createSession(sessionId)))
@@ -2720,7 +2715,7 @@ void lokit_main(
 mainKit.runOnClientThread(); // We will do the polling on this thread.
 
 std::shared_ptr websocketHandler =
-std::make_shared("child_ws", loKit, jailId, 
mainKit);
+std::make_shared("child_ws", loKit, jailId);
 #if !MOBILEAPP
 mainKit.insertNewUnixSocket(MasterLocation, pathAndQuery, 
websocketHandler);
 #else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: 3 commits - common/MessageQueue.hpp net/Socket.cpp net/Socket.hpp test/helpers.hpp test/test.cpp

[Libreoffice Gerrit user]

 common/MessageQueue.hpp |4 ++--
 net/Socket.cpp  |2 +-
 net/Socket.hpp  |2 +-
 test/helpers.hpp|   21 +++--
 test/test.cpp   |4 ++--
 5 files changed, 21 insertions(+), 12 deletions(-)

New commits:
commit 501caaa1647e1693a2c94c5020c086c1e5e14dcd
Author: Michael Meeks 
AuthorDate: Fri May 10 17:25:18 2019 +0100
Commit: Michael Meeks 
CommitDate: Fri May 10 17:38:08 2019 +0100

test: better zombie handling for more recent kernels.

Change-Id: I2ae0bcc4c42100ee08ee3fcf68cb7022f38aed7b

diff --git a/test/test.cpp b/test/test.cpp
index 31a248d84..b76bbb02d 100644
--- a/test/test.cpp
+++ b/test/test.cpp
@@ -202,10 +202,10 @@ std::vector getProcPids(const char* exec_filename, 
bool ignoreZombies = tru
 {
 switch (tokens[2].c_str()[0])
 {
-// Dead marker for old and new kernels.
+// Dead & zombie markers for old and new kernels.
 case 'x':
 case 'X':
-// Don't ignore zombies.
+case 'Z':
 break;
 default:
 pids.push_back(pid);
commit 638fb0316d7e41e842ca54c04815f0484c569c36
Author: Michael Meeks 
AuthorDate: Fri May 10 16:45:01 2019 +0100
Commit: Michael Meeks 
CommitDate: Fri May 10 17:37:59 2019 +0100

unipoll: restore missing asserts & some cleanup.

Change-Id: I4277b5e044ead54d91bc834ea05bec649a608678

diff --git a/common/MessageQueue.hpp b/common/MessageQueue.hpp
index f07b4be2a..bf5f6c950 100644
--- a/common/MessageQueue.hpp
+++ b/common/MessageQueue.hpp
@@ -83,7 +83,7 @@ public:
 Payload pop()
 {
 std::unique_lock lock(_mutex);
-if (!_queue.size())
+if (_queue.empty())
 return Payload();
 return get_impl();
 }
@@ -92,7 +92,7 @@ public:
 bool isEmpty()
 {
 std::unique_lock lock(_mutex);
-return _queue.size() == 0;
+return _queue.empty();
 }
 
 /// Thread safe removal of all the pending messages.
diff --git a/net/Socket.cpp b/net/Socket.cpp
index 0f2a68346..fb7e701ee 100644
--- a/net/Socket.cpp
+++ b/net/Socket.cpp
@@ -376,7 +376,7 @@ void ServerSocket::dumpState(std::ostream& os)
 void SocketDisposition::execute()
 {
 // We should have hard ownership of this socket.
-// assert(_socket->getThreadOwner() == std::this_thread::get_id());
+assert(_socket->getThreadOwner() == std::this_thread::get_id());
 if (_socketMove)
 {
 // Drop pretentions of ownership before _socketMove.
diff --git a/net/Socket.hpp b/net/Socket.hpp
index ded409804..c7712339e 100644
--- a/net/Socket.hpp
+++ b/net/Socket.hpp
@@ -470,7 +470,7 @@ public:
 Log::to_string(_owner) << " (" << Util::getThreadId() <<
 ") but called from " << std::this_thread::get_id() << ", 
stop: " << _stop);
 
-// assert(_stop || sameThread);
+assert(_stop || sameThread);
 }
 
 /// Poll the sockets for available data to read or buffer to write.
commit 47a0f836dd0e2ec49cd9f40c78a05f5c281dbdd6
Author: Michael Meeks 
AuthorDate: Mon May 6 20:02:52 2019 +0100
Commit: Michael Meeks 
CommitDate: Fri May 10 17:37:50 2019 +0100

tests: re-factor PNG save to allow easy re-use elsewhere.

Change-Id: Ic24f67d9a078ae49fa4ac187cc924fe36f482879

diff --git a/test/helpers.hpp b/test/helpers.hpp
index 0bbd3c686..c0f9d112c 100644
--- a/test/helpers.hpp
+++ b/test/helpers.hpp
@@ -586,6 +586,20 @@ inline void sendText(std::shared_ptr& 
socket, const std::string&
 }
 }
 
+inline void saveTileAs(const std::vector ,
+   const std::string ,
+   const std::string )
+{
+const std::string firstLine = LOOLProtocol::getFirstLine(tileResponse);
+std::vector res(tileResponse.begin() + firstLine.size() + 1, 
tileResponse.end());
+std::stringstream streamRes;
+std::copy(res.begin(), res.end(), std::ostream_iterator(streamRes));
+std::fstream outStream(filename, std::ios::out);
+outStream.write(res.data(), res.size());
+outStream.close();
+TST_LOG("Saved [" << firstLine << "] to [" << filename << "]");
+}
+
 inline std::vector getTileAndSave(std::shared_ptr& socket,
 const std::string& req,
 const std::string& filename,
@@ -603,12 +617,7 @@ inline std::vector 
getTileAndSave(std::shared_ptr& socket,
 std::copy(res.begin(), res.end(), std::ostream_iterator(streamRes));
 
 if (!filename.empty())
-{
-std::fstream outStream(filename, std::ios::out);
-outStream.write(res.data(), res.size());
-outStream.close();
-TST_LOG("Saved [" << firstLine << "] to [" << filename << "]");
-}
+

[Libreoffice-bugs] [Bug 109072] [META] XLS (binary) format bug tracker

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109072
Bug 109072 depends on bug 85470, which changed state.

Bug 85470 Summary: FILESAVE Very long time spent saving XLSX as XLS
https://bugs.documentfoundation.org/show_bug.cgi?id=85470

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107943] [META] Save bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107943
Bug 107943 depends on bug 85470, which changed state.

Bug 85470 Summary: FILESAVE Very long time spent saving XLSX as XLS
https://bugs.documentfoundation.org/show_bug.cgi?id=85470

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85470] FILESAVE Very long time spent saving XLSX as XLS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85470

Noel Grandin  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125164] CRASH: After editing the index and undoing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125164

Michael Stahl (CIB)  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |michael.st...@cib.de
   |desktop.org |

--- Comment #4 from Michael Stahl (CIB)  ---
resurrected some very borked code :(

fixed on master

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85470] FILESAVE Very long time spent saving XLSX as XLS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85470

--- Comment #15 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/a49f9359d27bf3ca38ddff7ad0920daac8e1bb8d%5E%21

tdf#85470 FILESAVE Very long time spent saving XLSX as XLS

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125164] CRASH: After editing the index and undoing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125164

--- Comment #3 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/eb8e03006d588f2d953c4fba4e47ced9b53ba6aa%5E%21

tdf#125164 sw: reimplement SwUndoTOXChange

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85470] FILESAVE Very long time spent saving XLSX as XLS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85470

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125164] CRASH: After editing the index and undoing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125164

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - sc/source sw/inc sw/source

[Noel Grandin (via logerrit)]

 sc/source/filter/excel/xestyle.cxx  |   42 +++-
 sc/source/filter/inc/xestyle.hxx|4 ++
 sw/inc/doc.hxx  |2 -
 sw/source/core/doc/doc.cxx  |   14 +++-
 sw/source/core/inc/SwUndoTOXChange.hxx  |   10 +++--
 sw/source/core/undo/SwUndoTOXChange.cxx |   56 ++--
 sw/source/uibase/index/toxmgr.cxx   |2 -
 7 files changed, 84 insertions(+), 46 deletions(-)

New commits:
commit a49f9359d27bf3ca38ddff7ad0920daac8e1bb8d
Author: Noel Grandin 
AuthorDate: Fri May 10 15:40:02 2019 +0200
Commit: Noel Grandin 
CommitDate: Fri May 10 18:40:29 2019 +0200

tdf#85470 FILESAVE Very long time spent saving XLSX as XLS

This takes the saving from (very long time, I lost patience), to around
2s on my machine.

Change-Id: Ife28a1616c0da65070f7e604b256134156af0e9a
Reviewed-on: https://gerrit.libreoffice.org/72123
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/source/filter/excel/xestyle.cxx 
b/sc/source/filter/excel/xestyle.cxx
index 6c8ba0549852..3ab025d0cb60 100644
--- a/sc/source/filter/excel/xestyle.cxx
+++ b/sc/source/filter/excel/xestyle.cxx
@@ -2666,17 +2666,24 @@ void XclExpXFBuffer::SaveXFXml( XclExpXmlStream& rStrm, 
XclExpXF& rXF )
 sal_uInt32 XclExpXFBuffer::FindXF( const ScPatternAttr& rPattern,
 sal_uInt32 nForceScNumFmt, sal_uInt16 nForceXclFont, bool 
bForceLineBreak ) const
 {
-for( size_t nPos = 0, nSize = maXFList.GetSize(); nPos < nSize; ++nPos )
+auto it = maXFFindMap.find(());
+if (it == maXFFindMap.end())
+return EXC_XFID_NOTFOUND;
+for (auto const & nPos : it->second)
 if( maXFList.GetRecord( nPos )->Equals( rPattern, nForceScNumFmt, 
nForceXclFont, bForceLineBreak ) )
-return static_cast< sal_uInt32 >( nPos );
+return nPos;
 return EXC_XFID_NOTFOUND;
 }
 
 sal_uInt32 XclExpXFBuffer::FindXF( const SfxStyleSheetBase& rStyleSheet ) const
 {
-for( size_t nPos = 0, nSize = maXFList.GetSize(); nPos < nSize; ++nPos )
+const SfxItemSet* pItemSet = _cast< SfxStyleSheetBase& >( 
rStyleSheet ).GetItemSet();
+auto it = maXFFindMap.find(pItemSet);
+if (it == maXFFindMap.end())
+return EXC_XFID_NOTFOUND;
+for (auto const & nPos : it->second)
 if( maXFList.GetRecord( nPos )->Equals( rStyleSheet ) )
-return static_cast< sal_uInt32 >( nPos );
+return nPos;
 return EXC_XFID_NOTFOUND;
 }
 
@@ -2707,9 +2714,15 @@ sal_uInt32 XclExpXFBuffer::InsertCellXF( const 
ScPatternAttr* pPattern, sal_Int1
 bool& rbPredefined = maBuiltInMap[ EXC_XF_DEFAULTCELL ].mbPredefined;
 if( rbPredefined )
 {
+// remove old entry in find-map
+auto & rPositions = 
maXFFindMap[maXFList.GetRecord(EXC_XF_DEFAULTCELL)->GetItemSet()];
+auto it = std::find(rPositions.begin(), rPositions.end(), 
EXC_XF_DEFAULTCELL);
+rPositions.erase(it);
 // replace default cell pattern
 XclExpXFRef xNewXF( new XclExpXF( GetRoot(), *pPattern, nScript ) 
);
 maXFList.ReplaceRecord( xNewXF, EXC_XF_DEFAULTCELL );
+// and add new entry in find-map
+maXFFindMap[xNewXF->GetItemSet()].push_back(EXC_XF_DEFAULTCELL);
 rbPredefined = false;
 }
 return GetDefCellXFId();
@@ -2721,10 +2734,12 @@ sal_uInt32 XclExpXFBuffer::InsertCellXF( const 
ScPatternAttr* pPattern, sal_Int1
 // not found - insert new cell XF
 if( maXFList.GetSize() < EXC_XFLIST_HARDLIMIT )
 {
-maXFList.AppendNewRecord( new XclExpXF(
-GetRoot(), *pPattern, nScript, nForceScNumFmt, nForceXclFont, 
bForceLineBreak ) );
+auto pNewExp = new XclExpXF(
+GetRoot(), *pPattern, nScript, nForceScNumFmt, nForceXclFont, 
bForceLineBreak );
+maXFList.AppendNewRecord( pNewExp );
 // do not set nXFId before the AppendNewRecord() call - it may 
insert 2 XFs (style+cell)
 nXFId = static_cast< sal_uInt32 >( maXFList.GetSize() - 1 );
+maXFFindMap[pNewExp->GetItemSet()].push_back(nXFId);
 }
 else
 {
@@ -2759,8 +2774,15 @@ sal_uInt32 XclExpXFBuffer::InsertStyleXF( const 
SfxStyleSheetBase& rStyleSheet )
 bool& rbPredefined = maBuiltInMap[ nXFId ].mbPredefined;
 if( rbPredefined )
 {
+// remove old entry in find-map
+auto & rPositions = 
maXFFindMap[maXFList.GetRecord(nXFId)->GetItemSet()];
+auto it = std::find(rPositions.begin(), rPositions.end(), 
nXFId);
+rPositions.erase(it);
 // replace predefined built-in style (ReplaceRecord() deletes 
old record)
-maXFList.ReplaceRecord( std::make_shared( GetRoot(), 
rStyleSheet ), nXFId );
+auto pNewExp = std::make_shared( GetRoot(), 

[Libreoffice-bugs] [Bug 36737] default values for optional parameters are not processed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=36737

Jens Carl  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |j.car...@gmx.de
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4' - 7 commits - common/MessageQueue.hpp kit/ForKit.cpp kit/Kit.cpp kit/TestStubs.cpp net/Socket.hpp test/helpers.hpp test/M

[Libreoffice Gerrit user]

 common/MessageQueue.hpp |   16 
 kit/ForKit.cpp  |6 +
 kit/Kit.cpp |  182 ++--
 kit/TestStubs.cpp   |   21 +
 net/Socket.hpp  |   10 +-
 test/Makefile.am|2 
 test/helpers.hpp|   21 +++--
 test/test.cpp   |4 -
 8 files changed, 212 insertions(+), 50 deletions(-)

New commits:
commit 95ceb19aa49e27bc0f7aaa50c88b614673df4123
Author: Michael Meeks 
AuthorDate: Fri May 10 17:25:18 2019 +0100
Commit: Michael Meeks 
CommitDate: Fri May 10 17:25:31 2019 +0100

test: better zombie handling for more recent kernels.

Change-Id: I2ae0bcc4c42100ee08ee3fcf68cb7022f38aed7b

diff --git a/test/test.cpp b/test/test.cpp
index 5ee19cf12..9745dda00 100644
--- a/test/test.cpp
+++ b/test/test.cpp
@@ -198,10 +198,10 @@ std::vector getProcPids(const char* exec_filename, 
bool ignoreZombies = tru
 {
 switch (tokens[2].c_str()[0])
 {
-// Dead marker for old and new kernels.
+// Dead & zombie markers for old and new kernels.
 case 'x':
 case 'X':
-// Don't ignore zombies.
+case 'Z':
 break;
 default:
 pids.push_back(pid);
commit 4308f138d7c0f3392103b66d08d8fcbc35531b8e
Author: Michael Meeks 
AuthorDate: Fri May 10 16:45:01 2019 +0100
Commit: Michael Meeks 
CommitDate: Fri May 10 16:45:01 2019 +0100

unipoll: restore missing asserts & some cleanup.

Change-Id: I4277b5e044ead54d91bc834ea05bec649a608678

diff --git a/common/MessageQueue.hpp b/common/MessageQueue.hpp
index d281fcedf..66a3131c3 100644
--- a/common/MessageQueue.hpp
+++ b/common/MessageQueue.hpp
@@ -83,7 +83,7 @@ public:
 Payload pop()
 {
 std::unique_lock lock(_mutex);
-if (!_queue.size())
+if (_queue.empty())
 return Payload();
 return get_impl();
 }
@@ -92,7 +92,7 @@ public:
 bool isEmpty()
 {
 std::unique_lock lock(_mutex);
-return _queue.size() == 0;
+return _queue.empty();
 }
 
 /// Thread safe removal of all the pending messages.
diff --git a/net/Socket.cpp b/net/Socket.cpp
index 505d95e86..dbab15d08 100644
--- a/net/Socket.cpp
+++ b/net/Socket.cpp
@@ -375,7 +375,7 @@ void ServerSocket::dumpState(std::ostream& os)
 void SocketDisposition::execute()
 {
 // We should have hard ownership of this socket.
-// assert(_socket->getThreadOwner() == std::this_thread::get_id());
+assert(_socket->getThreadOwner() == std::this_thread::get_id());
 if (_socketMove)
 {
 // Drop pretentions of ownership before _socketMove.
diff --git a/net/Socket.hpp b/net/Socket.hpp
index c73ace9ec..2fcc124d7 100644
--- a/net/Socket.hpp
+++ b/net/Socket.hpp
@@ -470,7 +470,7 @@ public:
 Log::to_string(_owner) << " (" << Util::getThreadId() <<
 ") but called from " << std::this_thread::get_id() << ", 
stop: " << _stop);
 
-// assert(_stop || sameThread);
+assert(_stop || sameThread);
 }
 
 /// Poll the sockets for available data to read or buffer to write.
commit cca1b968cc68cfd68b7cf4d6417bfbb0302c385d
Author: Michael Meeks 
AuthorDate: Mon May 6 20:02:52 2019 +0100
Commit: Michael Meeks 
CommitDate: Fri May 10 15:42:19 2019 +0100

tests: re-factor PNG save to allow easy re-use elsewhere.

Change-Id: Ic24f67d9a078ae49fa4ac187cc924fe36f482879

diff --git a/test/helpers.hpp b/test/helpers.hpp
index ccd29824d..0ee9f451d 100644
--- a/test/helpers.hpp
+++ b/test/helpers.hpp
@@ -586,6 +586,20 @@ inline void sendText(std::shared_ptr& 
socket, const std::string&
 }
 }
 
+inline void saveTileAs(const std::vector ,
+   const std::string ,
+   const std::string )
+{
+const std::string firstLine = LOOLProtocol::getFirstLine(tileResponse);
+std::vector res(tileResponse.begin() + firstLine.size() + 1, 
tileResponse.end());
+std::stringstream streamRes;
+std::copy(res.begin(), res.end(), std::ostream_iterator(streamRes));
+std::fstream outStream(filename, std::ios::out);
+outStream.write(res.data(), res.size());
+outStream.close();
+TST_LOG("Saved [" << firstLine << "] to [" << filename << "]");
+}
+
 inline std::vector getTileAndSave(std::shared_ptr& socket,
 const std::string& req,
 const std::string& filename,
@@ -603,12 +617,7 @@ inline std::vector 
getTileAndSave(std::shared_ptr& socket,
 std::copy(res.begin(), res.end(), std::ostream_iterator(streamRes));
 
 if (!filename.empty())
-{
-std::fstream outStream(filename, std::ios::out);
-outStream.write(res.data(), 

[Libreoffice-bugs] [Bug 123879] Nested Queries fail using mariadb JDBC connector (libmariadb-java) and mariadb server

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123879

--- Comment #29 from Robert Großkopf  ---
Don't think this is a bug of JDBC-Connector. The query-GUI should first test if
there is a nested query. If not it should send the query directly to the
database through the connector. Why is it send directly?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - desktop/qa desktop/source

[Miklos Vajna (via logerrit)]

 desktop/qa/desktop_lib/test_desktop_lib.cxx |   98 ++--
 desktop/source/lib/init.cxx |   10 ++
 2 files changed, 18 insertions(+), 90 deletions(-)

New commits:
commit d1bc69ad17ccd6eb97a06c67d97b9f8283d48c95
Author: Miklos Vajna 
AuthorDate: Thu May 9 18:13:20 2019 +0200
Commit: Michael Meeks 
CommitDate: Fri May 10 18:14:34 2019 +0200

CppunitTest_desktop_lib: close the document while LOK is still active

Otherwise the LOK notifiers won't be released (since LOK is not active),
and we leak vcl::Windows in GetLOKWindowsMap()::s_pLOKWindowsMap.

In dbgutil builds, this leads to an assertion failure if the sidebar is
active.

(cherry picked from commit da17ccaec39f50de68c3fdd431bc66a2bec04127)

On cp-6.0, this is a regression from the cp-6.0-only commit
49fe72fe93d6b292da275fd0508a01b49a86fa3b (sfx2: LOK: route the parent
sidebar window instead of the deck, 2018-10-10).

Conflicts:
desktop/qa/desktop_lib/test_desktop_lib.cxx

Change-Id: Idedb9578478ff4a9f2e17c0cfd203da6f007bdbd
Reviewed-on: https://gerrit.libreoffice.org/72098
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index c2bd188a3001..a00d59f54743 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -76,7 +76,11 @@ public:
 
 virtual void tearDown() override
 {
+if (m_pDocument)
+m_pDocument->pClass->registerCallback(m_pDocument.get(), nullptr, 
nullptr);
 closeDoc();
+comphelper::LibreOfficeKit::setActive(false);
+
 UnoApiTest::tearDown();
 };
 
@@ -211,6 +215,7 @@ public:
 osl::Condition m_aContextMenuCondition;
 boost::property_tree::ptree m_aContextMenuResult;
 
+std::unique_ptr m_pDocument;
 };
 
 static Control* GetFocusControl(vcl::Window const * pParent)
@@ -255,7 +260,8 @@ LibLODocument_Impl* DesktopLOKTest::loadDoc(const char* 
pName, LibreOfficeKitDoc
 {
 CPPUNIT_ASSERT(false);
 }
-return new LibLODocument_Impl(mxComponent);
+m_pDocument.reset(new LibLODocument_Impl(mxComponent));
+return m_pDocument.get();
 }
 
 void DesktopLOKTest::closeDoc()
@@ -367,7 +373,6 @@ void DesktopLOKTest::testGetStyles()
 CPPUNIT_FAIL("Unknown style family: " + rPair.first);
 }
 }
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 void DesktopLOKTest::testGetFonts()
@@ -389,7 +394,6 @@ void DesktopLOKTest::testGetFonts()
 CPPUNIT_ASSERT( rPair.second.size() > 0);
 }
 free(pJSON);
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 void DesktopLOKTest::testCreateView()
@@ -416,7 +420,6 @@ void DesktopLOKTest::testCreateView()
 
 pDocument->m_pDocumentClass->destroyView(pDocument, nId1);
 CPPUNIT_ASSERT_EQUAL(1, 
pDocument->m_pDocumentClass->getViewsCount(pDocument));
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 void DesktopLOKTest::testGetPartPageRectangles()
@@ -440,7 +443,6 @@ void DesktopLOKTest::testGetPartPageRectangles()
 CPPUNIT_ASSERT_EQUAL(static_cast(1), aRectangles.size());
 
 free(pRectangles);
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 void DesktopLOKTest::testGetFilterTypes()
@@ -456,7 +458,6 @@ void DesktopLOKTest::testGetFilterTypes()
 CPPUNIT_ASSERT(aTree.size() > 0);
 
CPPUNIT_ASSERT_EQUAL(std::string("application/vnd.oasis.opendocument.text"), 
aTree.get_child("writer8").get_child("MediaType").get_value());
 free(pJSON);
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 void DesktopLOKTest::testSearchCalc()
@@ -490,8 +491,6 @@ void DesktopLOKTest::testSearchCalc()
 CPPUNIT_ASSERT_EQUAL(static_cast(2), 
m_aSearchResultSelection.size());
 // Result is on the first sheet.
 CPPUNIT_ASSERT_EQUAL(0, m_aSearchResultPart[0]);
-
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 void DesktopLOKTest::testSearchAllNotificationsCalc()
@@ -516,8 +515,6 @@ void DesktopLOKTest::testSearchAllNotificationsCalc()
 CPPUNIT_ASSERT_EQUAL(0, m_nSelectionBeforeSearchResult);
 // But we do get the selection afterwards.
 CPPUNIT_ASSERT(m_nSelectionAfterSearchResult > 0);
-
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 void DesktopLOKTest::testPaintTile()
@@ -546,8 +543,6 @@ void DesktopLOKTest::testPaintTile()
 nTileHeight = 4000;
 aBuffer.resize(nCanvasWidth * nCanvasHeight * 4);
 pDocument->pClass->paintTile(pDocument, aBuffer.data(), nCanvasWidth, 
nCanvasHeight, nTilePosX, nTilePosY, nTileWidth, nTileHeight);
-
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 void DesktopLOKTest::testSaveAs()
@@ -558,8 +553,6 @@ void DesktopLOKTest::testSaveAs()
 utl::TempFile aTempFile;
 aTempFile.EnableKillingFile();
 CPPUNIT_ASSERT(pDocument->pClass->saveAs(pDocument, 

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - svx/source

[Miklos Vajna (via logerrit)]

 svx/source/svdraw/svdmrkv.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit a81b7eba6617d49767815c12347a881ce717207b
Author: Miklos Vajna 
AuthorDate: Thu May 9 11:32:56 2019 +0200
Commit: Michael Meeks 
CommitDate: Fri May 10 18:13:21 2019 +0200

svx lok: fix crash on select all when there is no mpMarkedObj yet

Fixes the online.git HTTPWSTest::testRenderShapeSelectionImpress()
testcase by reverting one hunk of commit
3fb298f673db169a38c1258d66ec24821386eb40 (lok: writer: svg export
transformed images, 2019-03-26).

This was probably meant to be a cleanup, but getting the sdr mark,
followed by getting the sdr object of the mark always gives us a shape,
while directly accessing mpMarkedObj does not.

Change-Id: Id733ba5c6fdf6fc86a3e9f7de62b4bdcbf9b06db
Reviewed-on: https://gerrit.libreoffice.org/72039
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

diff --git a/svx/source/svdraw/svdmrkv.cxx b/svx/source/svdraw/svdmrkv.cxx
index 08afd9d091df..abb25f5ffbe5 100644
--- a/svx/source/svdraw/svdmrkv.cxx
+++ b/svx/source/svdraw/svdmrkv.cxx
@@ -862,7 +862,8 @@ void SdrMarkView::SetMarkHandles(SfxViewShell* pOtherShell)
 {
 if (GetMarkedObjectCount())
 {
-SdrObject* pO = mpMarkedObj;
+SdrMark* pM = GetSdrMarkByIndex(0);
+SdrObject* pO = pM->GetMarkedSdrObj();
 long nRotAngle = pO->GetRotateAngle();
 // true if we are delaing with a RotGrfFlyFrame
 // (SwVirtFlyDrawObj with a SwGrfNode)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - sc/qa

[Miklos Vajna (via logerrit)]

 sc/qa/unit/tiledrendering/tiledrendering.cxx |  161 ---
 1 file changed, 77 insertions(+), 84 deletions(-)

New commits:
commit 42977af4e50974e907db8a981f16a79d5fceddad
Author: Miklos Vajna 
AuthorDate: Fri May 10 14:09:56 2019 +0200
Commit: Michael Meeks 
CommitDate: Fri May 10 18:14:59 2019 +0200

CppunitTest_sc_tiledrendering: close the document while LOK is still active

This is the same type of problem that was fixed for
CppunitTest_desktop_lib in commit
da17ccaec39f50de68c3fdd431bc66a2bec04127 (CppunitTest_desktop_lib: close
the document while LOK is still active, 2019-05-09).

(cherry picked from commit 6eac1c9e3f4e801a3cfa75f85f7bc3944c7cd21e)

On cp-6.0, this is a regression from the cp-6.0-only commit
49fe72fe93d6b292da275fd0508a01b49a86fa3b (sfx2: LOK: route the parent 
sidebar
window instead of the deck, 2018-10-10).

Conflicts:
sc/qa/unit/tiledrendering/tiledrendering.cxx

Change-Id: I2515e18713c9f20a4f70de478ab062bab5650608
Reviewed-on: https://gerrit.libreoffice.org/72127
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

diff --git a/sc/qa/unit/tiledrendering/tiledrendering.cxx 
b/sc/qa/unit/tiledrendering/tiledrendering.cxx
index 711d663b5892..d7cba12df804 100644
--- a/sc/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sc/qa/unit/tiledrendering/tiledrendering.cxx
@@ -157,7 +157,22 @@ void ScTiledRenderingTest::setUp()
 void ScTiledRenderingTest::tearDown()
 {
 if (mxComponent.is())
+{
+ScModelObj* pModelObj = static_cast(mxComponent.get());
+ScDocShell* pDocSh = dynamic_cast< ScDocShell* >( 
pModelObj->GetEmbeddedObject() );
+if (pDocSh)
+{
+ScTabViewShell* pViewShell = pDocSh->GetBestViewShell(false);
+if (pViewShell)
+{
+// The current view is unregistered here, multiple views have 
to be unregistered
+// in the test function itself.
+pViewShell->registerLibreOfficeKitViewCallback(nullptr, 
nullptr);
+}
+}
 mxComponent->dispose();
+}
+comphelper::LibreOfficeKit::setActive(false);
 
 test::BootstrapFixture::tearDown();
 }
@@ -309,8 +324,6 @@ void ScTiledRenderingTest::testRowColumnSelections()
 aResult = pModelObj->getTextSelection("text/plain;charset=utf-8", 
aUsedMimeType);
 aExpected = 
"1\t2\t3\t4\t5\t6\t7\t8\t9\t10\t11\t12\t13\t14\t15\t16\t17\t18\t19\t20\t21\n";
 CPPUNIT_ASSERT_EQUAL(aExpected, aResult);
-
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 void ScTiledRenderingTest::testSortAscendingDescending()
@@ -348,8 +361,6 @@ void ScTiledRenderingTest::testSortAscendingDescending()
 CPPUNIT_ASSERT_EQUAL(double(1), pDoc->GetValue(ScAddress(1, 0, 0)));
 CPPUNIT_ASSERT_EQUAL(double(3), pDoc->GetValue(ScAddress(1, 1, 0)));
 CPPUNIT_ASSERT_EQUAL(double(2), pDoc->GetValue(ScAddress(1, 2, 0)));
-
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 void ScTiledRenderingTest::testPartHash()
@@ -365,7 +376,6 @@ void ScTiledRenderingTest::testPartHash()
 
 // check part that it does not exists
 CPPUNIT_ASSERT(pModelObj->getPartHash(100).isEmpty());
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 void ScTiledRenderingTest::testDocumentSize()
@@ -396,8 +406,6 @@ void ScTiledRenderingTest::testDocumentSize()
 // 2 seconds
 aResult = m_aDocSizeCondition.wait(std::chrono::seconds(2));
 CPPUNIT_ASSERT_EQUAL(aResult, osl::Condition::result_ok);
-
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 void ScTiledRenderingTest::testEmptyColumnSelection()
@@ -417,8 +425,6 @@ void ScTiledRenderingTest::testEmptyColumnSelection()
 OString aResult = pModelObj->getTextSelection("text/plain;charset=utf-8", 
aUsedMimeType);
 // should be an empty string
 CPPUNIT_ASSERT_EQUAL(OString(), aResult);
-
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 /// A view callback tracks callbacks invoked on one specific view.
@@ -528,6 +534,7 @@ void ScTiledRenderingTest::testViewCursors()
 ScModelObj* pModelObj = createDoc("select-row-cols.ods");
 ViewCallback aView1;
 
SfxViewShell::Current()->registerLibreOfficeKitViewCallback(::callback,
 );
+int nView1 = SfxLokHelper::getView();
 SfxLokHelper::createView();
 
pModelObj->initializeForTiledRendering(uno::Sequence());
 ViewCallback aView2;
@@ -542,10 +549,8 @@ void ScTiledRenderingTest::testViewCursors()
 Scheduler::ProcessEventsToIdle();
 SfxLokHelper::destroyView(SfxLokHelper::getView());
 CPPUNIT_ASSERT(aView1.m_bViewCursorInvalidated);
-mxComponent->dispose();
-mxComponent.clear();
-
-comphelper::LibreOfficeKit::setActive(false);
+SfxLokHelper::setView(nView1);
+SfxViewShell::Current()->registerLibreOfficeKitViewCallback(nullptr, 
nullptr);
 }
 
 void lcl_dispatchCommand(const uno::Reference& xComponent, 
const OUString& rCommand, 

[Libreoffice-commits] core.git: sfx2/source sw/qa

[Miklos Vajna (via logerrit)]

 sfx2/source/view/viewsh.cxx|3 
 sw/qa/extras/tiledrendering/tiledrendering.cxx |  273 +
 2 files changed, 149 insertions(+), 127 deletions(-)

New commits:
commit c1486533818de626378ec67afa49845da164d00c
Author: Miklos Vajna 
AuthorDate: Fri May 10 16:41:11 2019 +0200
Commit: Miklos Vajna 
CommitDate: Fri May 10 18:04:42 2019 +0200

CppunitTest_sw_tiledrendering: close the document while LOK is still active

This is the same type of problem that was fixed for
CppunitTest_desktop_lib in commit
da17ccaec39f50de68c3fdd431bc66a2bec04127 (CppunitTest_desktop_lib: close
the document while LOK is still active, 2019-05-09).

Change-Id: I2fe050bf40d68dafa0334f4149e54958c492122d
Reviewed-on: https://gerrit.libreoffice.org/72126
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/sfx2/source/view/viewsh.cxx b/sfx2/source/view/viewsh.cxx
index a3e91f4ba261..aeb4931a48bb 100644
--- a/sfx2/source/view/viewsh.cxx
+++ b/sfx2/source/view/viewsh.cxx
@@ -1458,6 +1458,9 @@ void 
SfxViewShell::registerLibreOfficeKitViewCallback(LibreOfficeKitCallback pCa
 
 afterCallbackRegistered();
 
+if (!pCallback)
+return;
+
 // Ask other views to tell us about their cursors.
 SfxViewShell* pViewShell = SfxViewShell::GetFirst();
 while (pViewShell)
diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx 
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index 973d751e83d3..27e84046050c 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -57,6 +57,7 @@ class SwTiledRenderingTest : public SwModelTestBase
 {
 public:
 SwTiledRenderingTest();
+virtual void tearDown() override;
 void testRegisterCallback();
 void testPostKeyEvent();
 void testPostMouseEvent();
@@ -200,6 +201,27 @@ SwTiledRenderingTest::SwTiledRenderingTest()
 {
 }
 
+void SwTiledRenderingTest::tearDown()
+{
+if (mxComponent.is())
+{
+SwXTextDocument* pTextDocument = 
dynamic_cast(mxComponent.get());
+if (pTextDocument)
+{
+SwWrtShell* pWrtShell = 
pTextDocument->GetDocShell()->GetWrtShell();
+if (pWrtShell)
+{
+
pWrtShell->GetSfxViewShell()->registerLibreOfficeKitViewCallback(nullptr, 
nullptr);
+}
+}
+mxComponent->dispose();
+mxComponent.clear();
+}
+comphelper::LibreOfficeKit::setActive(false);
+
+test::BootstrapFixture::tearDown();
+}
+
 SwXTextDocument* SwTiledRenderingTest::createDoc(const char* pName)
 {
 if (!pName)
@@ -313,7 +335,6 @@ void SwTiledRenderingTest::testRegisterCallback()
 CPPUNIT_ASSERT(!m_aInvalidation.IsEmpty());
 tools::Rectangle aTopLeft(0, 0, 256*15, 256*15); // 1 px = 15 twips, 
assuming 96 DPI.
 CPPUNIT_ASSERT(m_aInvalidation.IsOver(aTopLeft));
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 void SwTiledRenderingTest::testPostKeyEvent()
@@ -349,7 +370,6 @@ void SwTiledRenderingTest::testPostMouseEvent()
 Scheduler::ProcessEventsToIdle();
 // The new cursor position must be before the first word.
 CPPUNIT_ASSERT_EQUAL(static_cast(0), 
pShellCursor->GetPoint()->nContent.GetIndex());
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 void SwTiledRenderingTest::testSetTextSelection()
@@ -408,8 +428,6 @@ void SwTiledRenderingTest::testGetTextSelection()
 ESelection aWordSelection(0, 0, 0, 5);
 rEditView.SetSelection(aWordSelection);
 CPPUNIT_ASSERT_EQUAL(OString("Shape"), 
pXTextDocument->getTextSelection("text/plain;charset=utf-8", aUsedFormat));
-
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 void SwTiledRenderingTest::testSetGraphicSelection()
@@ -481,8 +499,6 @@ void SwTiledRenderingTest::testInsertShape()
 
 // check that it is in the foreground layer
 CPPUNIT_ASSERT_EQUAL(rDrawModelAccess.GetHeavenId().get(), 
pObject->GetLayer().get());
-
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 static void lcl_search(bool bBackward)
@@ -535,8 +551,6 @@ void SwTiledRenderingTest::testSearch()
 CPPUNIT_ASSERT(!pWrtShell->GetDrawView()->GetTextEditObject());
 nActual = 
pWrtShell->getShellCursor(false)->Start()->nNode.GetNode().GetIndex();
 CPPUNIT_ASSERT_EQUAL(nNode + 1, nActual);
-
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 void SwTiledRenderingTest::testSearchViewArea()
@@ -579,8 +593,6 @@ void SwTiledRenderingTest::testSearchTextFrame()
 comphelper::dispatchCommand(".uno:ExecuteSearch", aPropertyValues);
 // This was empty: nothing was highlighted after searching for 'TextFrame'.
 CPPUNIT_ASSERT(!m_aTextSelection.isEmpty());
-
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 void SwTiledRenderingTest::testSearchTextFrameWrapAround()
@@ -616,7 +628,6 @@ void SwTiledRenderingTest::testDocumentSizeChanged()
 CPPUNIT_ASSERT_EQUAL(aSize.getWidth(), m_aDocumentSize.getWidth());
   

[Libreoffice-bugs] [Bug 125206] New: Edit mode password required in Excel is bypassed in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125206

Bug ID: 125206
   Summary: Edit mode password required in Excel is bypassed in
Calc
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: david.gen...@du.edu

Description:
I created a file in Excel that requires a password to open the file and another
password to leave read-only mode and edit the file.  When I use this same file
in Libre Calc, I am required to enter the password to open the file, but am
allowed to enter Edit mode without entering a second password to leave
read-only mode and edit the file.  Is this a bug or does Calc only require one
password to open as well as edit a file?

Actual Results:
Open a file with the two passwords listed above

Expected Results:
One password opens and allows edit.  This should not happen.


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: SpreadsheetDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123879] Nested Queries fail using mariadb JDBC connector (libmariadb-java) and mariadb server

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123879

--- Comment #28 from Robert Großkopf  ---
Tested this again with MariaDB and mariadb-java-client-2.4.1.jar and
mysql-connector-java-5.1.40-bin.jar. Nested queries fail with the
mariadb-connector, will work with the mysql-connector.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125129] Parts of text in Option's AutoCaption object list not visible when selected

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125129

raal  changed:

   What|Removed |Added

 CC||caol...@redhat.com,
   ||r...@post.cz
   Keywords|bibisectRequest,|bibisected, bisected,
   |possibleRegression  |regression

--- Comment #2 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to XXX ; Could you possibly take a look at this one?
Thanks

1891e6737e45bcbc435e179e2301eba30aca2267 is the first bad commit
commit 1891e6737e45bcbc435e179e2301eba30aca2267
Author: Jenkins Build User 
Date:   Sat Apr 6 20:49:19 2019 +0200

source sha:5c32ba63163d9556ff89782a8074924cdf9dc554

author  Caolán McNamara 2019-04-04 14:30:03 +0100
committer   Caolán McNamara 2019-04-06 19:53:00
+0200
commit  5c32ba63163d9556ff89782a8074924cdf9dc554 (patch)
tree66acbb3b4c298c9f0cbff75f9e36bf3d759b7a0f
parent  6f31c63e35abef03e6f938bbddc8778b70a62d43 (diff)
weld OTableSubscriptionPage

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120594] Crash attempting to open More Fields dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120594

Andreas Hirsch  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #27 from Andreas Hirsch  
---
I have installed Version: 6.2.3.2 (x64)
Build-ID: aecc05fe267cc68dde00352a451aa867b3b546ac

Same behavior as befor

Andreas

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: [Libreoffice-qa] QA:needsComment

[Ilmari Lauhakangas]

dgp-m...@gmx.de kirjoitti 10.5.2019 klo 17.31:

Hi Xisco,

QA:needsComment is a new entry in Whiteboard. What is the idea behind
and what are the criteria to set or remove it?


See here: 
https://wiki.documentfoundation.org/QA/GetInvolved#Unconfirmed_reports_without_comments


The automation likewise removes the entry after conditions are 
fulfilled. We should not need to manually set or remove it.


Ilmari
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 103427] [META] Styles and Formatting sidebar deck and floating window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103427
Bug 103427 depends on bug 119445, which changed state.

Bug 119445 Summary: When switching to a new paragraph in a big document, the 
display of the current paragraph style in the sidebar updates with a lag
https://bugs.documentfoundation.org/show_bug.cgi?id=119445

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|INSUFFICIENTDATA|---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 119445] When switching to a new paragraph in a big document, the display of the current paragraph style in the sidebar updates with a lag

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=119445

Buovjaga  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|RESOLVED|UNCONFIRMED
 Resolution|INSUFFICIENTDATA|---

--- Comment #10 from Buovjaga  ---
There are performance improvements being committed all the time, see for
example the latest QA report:
https://qa.blog.documentfoundation.org/2019/05/07/qa-report-april-2019/

The thing is, a developer cannot fix something they cannot see. An example
document is thus necessary.

Would be interesting, if you could test with a fresh master, which has all
sorts of improvements, also for image handling:
https://dev-builds.libreoffice.org/daily/master/Win-x86_64@42/current/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/qt5

[Katarina Behrens (via logerrit)]

 vcl/qt5/Qt5Frame.cxx |   20 +---
 1 file changed, 17 insertions(+), 3 deletions(-)

New commits:
commit 758c44f69f0a0ed4a501695de4f065824325e750
Author: Katarina Behrens 
AuthorDate: Wed May 8 14:02:37 2019 +0200
Commit: Katarina Behrens 
CommitDate: Fri May 10 17:24:44 2019 +0200

tdf#124484: avoid crash in fullscreen slideshow spanning all displays

This just stops the bleeding (crash) in a special case when screen
number argument of SalFrame::ShowFullScreen is -1 (meaning
'fullscreen spanning all available displays')

It doesn't yet extend the fullscreen window over all screens, this
will be done in a follow-up fix

Change-Id: I2cf48096a1fe1ec33c943f10acb41c59585b325f
Reviewed-on: https://gerrit.libreoffice.org/71965
Tested-by: Jenkins
Reviewed-by: Katarina Behrens 

diff --git a/vcl/qt5/Qt5Frame.cxx b/vcl/qt5/Qt5Frame.cxx
index 05e17932a93c..5ed722aad391 100644
--- a/vcl/qt5/Qt5Frame.cxx
+++ b/vcl/qt5/Qt5Frame.cxx
@@ -1069,12 +1069,26 @@ void Qt5Frame::SetScreenNumber(unsigned int nScreen)
 QList screens = QApplication::screens();
 if (static_cast(nScreen) < screens.size())
 {
-QWidget* const pWidget = m_pTopLevel ? m_pTopLevel : 
m_pQWidget;
-pWindow->setScreen(QApplication::screens()[nScreen]);
+bool bSpanAllScreens = (nScreen == static_cast(-1));
+QRect screenGeo;
+
+if (!bSpanAllScreens)
+{
+screenGeo = 
QApplication::desktop()->screenGeometry(nScreen);
+pWindow->setScreen(QApplication::screens()[nScreen]);
+}
+else // special case: fullscreen over all available screens
+{
+// left-most screen
+int nLeftScreen = 
QApplication::desktop()->screenNumber(QPoint(0, 0));
+// entire virtual desktop
+screenGeo = 
QApplication::screens()[nLeftScreen]->availableVirtualGeometry();
+pWindow->setScreen(QApplication::screens()[nLeftScreen]);
+}
 
 // setScreen by itself has no effect, explicitly move the 
widget to
 // the new screen
-QRect screenGeo = 
QApplication::desktop()->screenGeometry(nScreen);
+QWidget* const pWidget = m_pTopLevel ? m_pTopLevel : 
m_pQWidget;
 pWidget->move(screenGeo.topLeft());
 }
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2-4' - sd/source

[Caolán McNamara (via logerrit)]

 sd/source/ui/tools/PreviewRenderer.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit d20121b040eeac5aa56b0d42e5c09b0d4b306c55
Author: Caolán McNamara 
AuthorDate: Thu May 9 15:22:21 2019 +0100
Commit: Katarina Behrens 
CommitDate: Fri May 10 17:21:25 2019 +0200

Resolves: tdf#124927 crash on multiple drawing shapes in animation dialog

since...

SOSAW080: Added first bunch of basic changes to helpers
commit dfefe448c41921f2f1e54d3f69b8b9e89031d055
Date:   Thu Mar 1 15:54:32 2018 +0100

Change-Id: I9feba16b5efdbec5c817bebf2772e2f2882bdfe9
Reviewed-on: https://gerrit.libreoffice.org/72055
Reviewed-by: Michael Stahl 
Tested-by: Jenkins
(cherry picked from commit 6670ae80580a5f80d6042b7f9d49308862472c90)
Reviewed-on: https://gerrit.libreoffice.org/72081
Reviewed-by: Xisco Faulí 
Reviewed-by: Katarina Behrens 
Tested-by: Katarina Behrens 

diff --git a/sd/source/ui/tools/PreviewRenderer.cxx 
b/sd/source/ui/tools/PreviewRenderer.cxx
index c12930b10ece..44dceffde481 100644
--- a/sd/source/ui/tools/PreviewRenderer.cxx
+++ b/sd/source/ui/tools/PreviewRenderer.cxx
@@ -199,13 +199,16 @@ bool PreviewRenderer::Initialize (
 const Size& rPixelSize,
 const bool bObeyHighContrastMode)
 {
-if (pPage == nullptr)
+if (!pPage)
 return false;
 
 SetupOutputSize(*pPage, rPixelSize);
 SdDrawDocument& rDocument(static_cast< SdDrawDocument& 
>(pPage->getSdrModelFromSdrPage()));
 DrawDocShell* pDocShell = rDocument.GetDocSh();
 
+if (!pDocShell)
+return false;
+
 // Create view
 ProvideView (pDocShell);
 if (mpView == nullptr)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: chart2/source

[Stephan Bergmann (via logerrit)]

 chart2/source/model/main/FormattedString.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f43b5d1e6035e6ed619ab425009a7895ac271716
Author: Stephan Bergmann 
AuthorDate: Fri May 10 17:03:56 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Fri May 10 17:03:56 2019 +0200

Temporarily remove "final" from chart::FormattedString

...to check whether it has any effect on the strange Jenkins UBSan bot 
failures
that started with 

Change-Id: I9e7c8c89d3347feb0d5d56f67ac3495553acfc3e

diff --git a/chart2/source/model/main/FormattedString.hxx 
b/chart2/source/model/main/FormattedString.hxx
index 9d17d5f3885a..91aab68d9189 100644
--- a/chart2/source/model/main/FormattedString.hxx
+++ b/chart2/source/model/main/FormattedString.hxx
@@ -43,7 +43,7 @@ typedef ::cppu::WeakImplHelper<
 FormattedString_Base;
 }
 
-class FormattedString final :
+class FormattedString :
 public MutexContainer,
 public impl::FormattedString_Base,
 public ::property::OPropertySet
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124735] My Wish is Possibility to set the Backgroundcolor for the Tab-Pages in a Tab-Page-Container

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124735

Juergen Klatt  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Resolution|NOTABUG |---
 Status|RESOLVED|REOPENED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124831] Crash in: rtl_uString_newFromStr_WithLength FILEOPEN ODS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124831

--- Comment #4 from itsGord  ---
Upgraded two weeks ago to 6.1.5.2; have not yet seen a re-occurrence of the
problem while running this release.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123608] FILEOPEN | XLSX, Arrows change direction when opened in Calc.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123608

Timur  changed:

   What|Removed |Added

  Component|Writer  |Calc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123608] FILEOPEN | XLSX, Arrows change direction when opened in Calc.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123608

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||0751

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100751] FILEOPEN: Arrows in docx files sometimes rendered in reverse direction

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100751

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||3608

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125202] Fileopen: Lines from MSO xlsx are misplaced in LO calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125202

Timur  changed:

   What|Removed |Added

Summary|Lines in xlsx are misplaced |Fileopen: Lines from MSO
   |in LO calc  |xlsx are misplaced in LO
   ||calc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125202] Lines in xlsx are misplaced in LO calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125202

Timur  changed:

   What|Removed |Added

 OS|Linux (All) |All
 Status|NEEDINFO|NEW
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||3613,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4289

--- Comment #10 from Timur  ---
Repro LO 6.3+ in Windows. No time to check whether this is a duplicate.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123613] FILESAVE XLSX Arrows move and lose their text when saving xls file as xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123613

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||5202

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104289] FILEOPEN: XSLX - Arrow shapes imported with incorrect rotation and dimension

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104289

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||5202

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123136] [META] Tunneled dialog bugs and enhancements in LOOL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123136
Bug 123136 depends on bug 125198, which changed state.

Bug 125198 Summary: Find & Replace dialog doesn't appear in Online
https://bugs.documentfoundation.org/show_bug.cgi?id=125198

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 119445] When switching to a new paragraph in a big document, the display of the current paragraph style in the sidebar updates with a lag

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=119445

--- Comment #9 from Dr. Matthias Weisser  ---
I still have several different performance problems with LO. 

The problem is that those problems are only there when the memory is somehow
low.

When the laptop is newly started all is ok. So this is not so easy to replicate
- but surely there are problems !!!

I do not see such problems with older and less memory hungry programs.

No problem at all using PaintShop Pro. No problem using Eagle 5.12. No problem
using Dreamweaver 4.

More than a year ago I told that it seems to me that LO got too huge. I have
also seen loss of performance with newer versions. 

If this stays that way I am sorry to hope find a smaller program able to read
my odt files with the 14 books I made. I am very sorry - but I am more and more
frustrated now seeing that things are getting bigger and bigger but less
performance instead of more.

Yes - I really like working - but not with less and less performance and
spurious problems that nobody can find and fix. I know how hard it can be
finding such a problem. But anyway its not a solution waiting for just bigger
code now and less performance as I have seen in the past.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123879] Nested Queries fail using mariadb JDBC connector (libmariadb-java) and mariadb server

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123879

--- Comment #27 from t...@tim-passingham.co.uk ---
I have tested under Version: 6.2.3.2
Build ID: 1:6.2.3-0ubuntu0.19.04.1~lo1
CPU threads: 8; OS: Linux 5.0; UI render: default; VCL: x11; 
Locale: en-GB (en_GB.UTF-8); UI-Language: en-GB
Calc: threaded

with mariadb 10.3 built for ubuntu 19.04 (disco).

With mariadb jdbc (/usr/share/javamariadb-java-client-2.4.0.jar) and using
org.mariadb.jdbc.Driver the problem is still present.

I still don't seem to have any MySQL(Native) connector as a database connection
choice, even if I install the libreoffice-mysql-connector.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Changes to 'refs/tags/cd-4.0.4-1'

[Libreoffice Gerrit user]

Tag 'cd-4.0.4-1' created by Andras Timar  at 
2019-05-10 14:41 +

cd-4.0.4-1

Changes since cd-4.0.3-2-15:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 121378] Writer/UI: Adding Captions to Images is very Unpractical (Width of Image Changes with Width of Frame, Does not use Default Frame Style etc)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121378

--- Comment #7 from Timur  ---
I would like this to be as requested. But that would require a change in image
and frame logic.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: kit/Kit.cpp

[Libreoffice Gerrit user]

 kit/Kit.cpp |6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

New commits:
commit eb376d122f318ba02780b25a03bfd861281ed848
Author: Miklos Vajna 
AuthorDate: Fri May 10 16:39:10 2019 +0200
Commit: Miklos Vajna 
CommitDate: Fri May 10 16:39:10 2019 +0200

Fix recently introduced clang warnings

kit/Kit.cpp:2166:17: error: private field '_socketPoll' is not used 
[-Werror,-Wunused-private-field]


/usr/lib64/gcc/x86_64-suse-linux/7/../../../../include/c++/7/ext/new_allocator.h:140:22:
 error: destructor called on non-final 'Document' that has virtual functions 
but non-virtual destructor [-Werror,-Wdelete-non-abstract-non-virtual-dtor]

Change-Id: I47849db2b0bc64e811577e3a8cede0e2d2c0e2e6

diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 216c8d757..5152a80fd 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -873,7 +873,7 @@ public:
  const std::string& docId,
  const std::string& url,
  std::shared_ptr tileQueue,
- SocketPoll& socketPoll,
+ SocketPoll& /*socketPoll*/,
  const std::shared_ptr& websocketHandler)
   : _loKit(loKit),
 _jailId(jailId),
@@ -882,7 +882,6 @@ public:
 _url(url),
 _obfuscatedFileId(Util::getFilenameFromURL(docKey)),
 _tileQueue(std::move(tileQueue)),
-_socketPoll(socketPoll),
 _websocketHandler(websocketHandler),
 _docPassword(""),
 _haveDocPassword(false),
@@ -904,7 +903,7 @@ public:
 #endif
 }
 
-~Document()
+virtual ~Document()
 {
 LOG_INF("~Document dtor for [" << _docKey <<
 "] url [" << anonymizeUrl(_url) << "] on child [" << _jailId <<
@@ -2163,7 +2162,6 @@ private:
 
 std::shared_ptr _loKitDocument;
 std::shared_ptr _tileQueue;
-SocketPoll& _socketPoll;
 std::shared_ptr _websocketHandler;
 
 std::mutex _pngMutex;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 121378] Writer/UI: Adding Captions to Images is very Unpractical (Width of Image Changes with Width of Frame, Does not use Default Frame Style etc)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121378

--- Comment #7 from Timur  ---
I would like this to be as requested. But that would require a change in image
and frame logic.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - desktop/source vcl/source

[Michael Meeks (via logerrit)]

 desktop/source/lib/init.cxx |   27 +--
 vcl/source/app/svmain.cxx   |6 ++
 2 files changed, 15 insertions(+), 18 deletions(-)

New commits:
commit d48b54144b464a41bdc9cca8a8d766cc6aa525c2
Author: Michael Meeks 
AuthorDate: Thu May 9 18:24:18 2019 +0100
Commit: Jan Holesovsky 
CommitDate: Fri May 10 16:35:45 2019 +0200

unipoll: let InitVCL tolerate double init.

We need to get VCL initialized early in UniPoll mode, since the main
setup doesn't occur until runPoll is invoked, and we want to call lots
of virtual methods that take the SolarMutex before then - which requires
VCL to be initialized.

Change-Id: Id9c1b74c126cf7bb71d6560b7585d37327a9f5ef
Reviewed-on: https://gerrit.libreoffice.org/72069
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 626e37b87a1f..ba8ebed87b04 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -4974,24 +4974,6 @@ static int lo_initialize(LibreOfficeKit* pThis, const 
char* pAppPath, const char
 force_c_locale();
 }
 
-// We could use InitVCL() here -- and used to before using 
soffice_main,
-// however that now deals with the initialisation for us (and it's not
-// possible to try to set up VCL twice.
-
-// Instead VCL init is done for us by soffice_main in a separate 
thread,
-// however we specifically can't proceed until this setup is complete
-// (or you get segfaults trying to use VCL and/or deadlocks due to 
other
-//  setup within soffice_main). Specifically the various Application::
-// functions depend on VCL being ready -- the deadlocks would happen
-// if you try to use loadDocument too early.
-
-// The RequestHandler is specifically set to be ready when all the 
other
-// init in Desktop::Main (run from soffice_main) is done. We can enable
-// the RequestHandler here (without starting any IPC thread;
-// shortcutting the invocation in Desktop::Main that would start the 
IPC
-// thread), and can then use it to wait until we're definitely ready to
-// continue.
-
 if (eStage != PRE_INIT)
 {
 SAL_INFO("lok", "Re-initialize temp paths");
@@ -5001,6 +4983,13 @@ static int lo_initialize(LibreOfficeKit* pThis, const 
char* pAppPath, const char
 aOptions.SetTempPath(aNewTemp);
 desktop::Desktop::CreateTemporaryDirectory();
 
+// The RequestHandler is specifically set to be ready when all the 
other
+// init in Desktop::Main (run from soffice_main) is done. We can 
enable
+// the RequestHandler here (without starting any IPC thread;
+// shortcutting the invocation in Desktop::Main that would start 
the IPC
+// thread), and can then use it to wait until we're definitely 
ready to
+// continue.
+
 SAL_INFO("lok", "Enabling RequestHandler");
 RequestHandler::Enable(false);
 SAL_INFO("lok", "Starting soffice_main");
@@ -5013,6 +5002,8 @@ static int lo_initialize(LibreOfficeKit* pThis, const 
char* pAppPath, const char
 RequestHandler::WaitForReady();
 SAL_INFO("lok", "RequestHandler ready -- continuing");
 }
+else
+InitVCL();
 }
 
 if (eStage != SECOND_INIT)
diff --git a/vcl/source/app/svmain.cxx b/vcl/source/app/svmain.cxx
index cbf2f6b63054..e67197a0e0c8 100644
--- a/vcl/source/app/svmain.cxx
+++ b/vcl/source/app/svmain.cxx
@@ -376,6 +376,12 @@ namespace vclmain
 
 bool InitVCL()
 {
+if (isInitVCL())
+{
+SAL_INFO("vcl.app", "Double initialization of vcl");
+return true;
+}
+
 if( pExceptionHandler != nullptr )
 return false;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-qa] QA:needsComment

[dgp-mail]

Hi Xisco,

QA:needsComment is a new entry in Whiteboard. What is the idea behind
and what are the criteria to set or remove it?

Kind regards

Dieter

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-commits] core.git: sc/qa

[Miklos Vajna (via logerrit)]

 sc/qa/unit/tiledrendering/tiledrendering.cxx |  161 ---
 1 file changed, 77 insertions(+), 84 deletions(-)

New commits:
commit 6eac1c9e3f4e801a3cfa75f85f7bc3944c7cd21e
Author: Miklos Vajna 
AuthorDate: Fri May 10 14:09:56 2019 +0200
Commit: Miklos Vajna 
CommitDate: Fri May 10 16:24:01 2019 +0200

CppunitTest_sc_tiledrendering: close the document while LOK is still active

This is the same type of problem that was fixed for
CppunitTest_desktop_lib in commit
da17ccaec39f50de68c3fdd431bc66a2bec04127 (CppunitTest_desktop_lib: close
the document while LOK is still active, 2019-05-09).

Change-Id: I2515e18713c9f20a4f70de478ab062bab5650608
Reviewed-on: https://gerrit.libreoffice.org/72101
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/sc/qa/unit/tiledrendering/tiledrendering.cxx 
b/sc/qa/unit/tiledrendering/tiledrendering.cxx
index 4e0c99ad5f97..8bc981982af5 100644
--- a/sc/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sc/qa/unit/tiledrendering/tiledrendering.cxx
@@ -157,7 +157,22 @@ void ScTiledRenderingTest::setUp()
 void ScTiledRenderingTest::tearDown()
 {
 if (mxComponent.is())
+{
+ScModelObj* pModelObj = static_cast(mxComponent.get());
+ScDocShell* pDocSh = dynamic_cast< ScDocShell* >( 
pModelObj->GetEmbeddedObject() );
+if (pDocSh)
+{
+ScTabViewShell* pViewShell = pDocSh->GetBestViewShell(false);
+if (pViewShell)
+{
+// The current view is unregistered here, multiple views have 
to be unregistered
+// in the test function itself.
+pViewShell->registerLibreOfficeKitViewCallback(nullptr, 
nullptr);
+}
+}
 mxComponent->dispose();
+}
+comphelper::LibreOfficeKit::setActive(false);
 
 test::BootstrapFixture::tearDown();
 }
@@ -309,8 +324,6 @@ void ScTiledRenderingTest::testRowColumnSelections()
 aResult = pModelObj->getTextSelection("text/plain;charset=utf-8", 
aUsedMimeType);
 aExpected = 
"1\t2\t3\t4\t5\t6\t7\t8\t9\t10\t11\t12\t13\t14\t15\t16\t17\t18\t19\t20\t21\n";
 CPPUNIT_ASSERT_EQUAL(aExpected, aResult);
-
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 void ScTiledRenderingTest::testSortAscendingDescending()
@@ -348,8 +361,6 @@ void ScTiledRenderingTest::testSortAscendingDescending()
 CPPUNIT_ASSERT_EQUAL(double(1), pDoc->GetValue(ScAddress(1, 0, 0)));
 CPPUNIT_ASSERT_EQUAL(double(3), pDoc->GetValue(ScAddress(1, 1, 0)));
 CPPUNIT_ASSERT_EQUAL(double(2), pDoc->GetValue(ScAddress(1, 2, 0)));
-
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 void ScTiledRenderingTest::testPartHash()
@@ -365,7 +376,6 @@ void ScTiledRenderingTest::testPartHash()
 
 // check part that it does not exists
 CPPUNIT_ASSERT(pModelObj->getPartHash(100).isEmpty());
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 void ScTiledRenderingTest::testDocumentSize()
@@ -396,8 +406,6 @@ void ScTiledRenderingTest::testDocumentSize()
 // 2 seconds
 aResult = m_aDocSizeCondition.wait(std::chrono::seconds(2));
 CPPUNIT_ASSERT_EQUAL(osl::Condition::result_ok, aResult);
-
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 void ScTiledRenderingTest::testEmptyColumnSelection()
@@ -417,8 +425,6 @@ void ScTiledRenderingTest::testEmptyColumnSelection()
 OString aResult = pModelObj->getTextSelection("text/plain;charset=utf-8", 
aUsedMimeType);
 // should be an empty string
 CPPUNIT_ASSERT_EQUAL(OString(), aResult);
-
-comphelper::LibreOfficeKit::setActive(false);
 }
 
 /// A view callback tracks callbacks invoked on one specific view.
@@ -528,6 +534,7 @@ void ScTiledRenderingTest::testViewCursors()
 ScModelObj* pModelObj = createDoc("select-row-cols.ods");
 ViewCallback aView1;
 
SfxViewShell::Current()->registerLibreOfficeKitViewCallback(::callback,
 );
+int nView1 = SfxLokHelper::getView();
 SfxLokHelper::createView();
 
pModelObj->initializeForTiledRendering(uno::Sequence());
 ViewCallback aView2;
@@ -542,10 +549,8 @@ void ScTiledRenderingTest::testViewCursors()
 Scheduler::ProcessEventsToIdle();
 SfxLokHelper::destroyView(SfxLokHelper::getView());
 CPPUNIT_ASSERT(aView1.m_bViewCursorInvalidated);
-mxComponent->dispose();
-mxComponent.clear();
-
-comphelper::LibreOfficeKit::setActive(false);
+SfxLokHelper::setView(nView1);
+SfxViewShell::Current()->registerLibreOfficeKitViewCallback(nullptr, 
nullptr);
 }
 
 void lcl_dispatchCommand(const uno::Reference& xComponent, 
const OUString& rCommand, const uno::Sequence& rArguments)
@@ -570,6 +575,7 @@ void ScTiledRenderingTest::testTextViewSelection()
 ScModelObj* pModelObj = createDoc("select-row-cols.ods");
 ViewCallback aView1;
 
SfxViewShell::Current()->registerLibreOfficeKitViewCallback(::callback,
 );
+int nView1 = SfxLokHelper::getView();
 SfxLokHelper::createView();
 

[Libreoffice-bugs] [Bug 108816] [META] Writer toolbar bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108816
Bug 108816 depends on bug 121354, which changed state.

Bug 121354 Summary: In Writer the SAVE icon continues to show aftersaving
https://bugs.documentfoundation.org/show_bug.cgi?id=121354

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs