[Libreoffice-bugs] [Bug 107139] [META] Breeze icons
https://bugs.documentfoundation.org/show_bug.cgi?id=107139 Bug 107139 depends on bug 125879, which changed state. Bug 125879 Summary: Change Wrap Through Icon https://bugs.documentfoundation.org/show_bug.cgi?id=125879 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120946] [META] Karasa Jaga icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120946 Adolfo Jayme changed: What|Removed |Added Depends on||125879 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=125879 [Bug 125879] Change Wrap Through Icon -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120946] [META] Karasa Jaga icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120946 Bug 120946 depends on bug 125879, which changed state. Bug 125879 Summary: Change Wrap Through Icon https://bugs.documentfoundation.org/show_bug.cgi?id=125879 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125879] Change Wrap Through Icon
https://bugs.documentfoundation.org/show_bug.cgi?id=125879 Adolfo Jayme changed: What|Removed |Added Resolution|--- |FIXED Blocks||107139, 120949, 120946 Assignee|libreoffice-b...@lists.free |riz_17_...@yahoo.co.id |desktop.org | Status|NEW |RESOLVED Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107139 [Bug 107139] [META] Breeze icons https://bugs.documentfoundation.org/show_bug.cgi?id=120946 [Bug 120946] [META] Karasa Jaga icons https://bugs.documentfoundation.org/show_bug.cgi?id=120949 [Bug 120949] [META] Elementary icons -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120949] [META] Elementary icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120949 Adolfo Jayme changed: What|Removed |Added Depends on||125879 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=125879 [Bug 125879] Change Wrap Through Icon -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120949] [META] Elementary icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120949 Bug 120949 depends on bug 125879, which changed state. Bug 125879 Summary: Change Wrap Through Icon https://bugs.documentfoundation.org/show_bug.cgi?id=125879 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107139] [META] Breeze icons
https://bugs.documentfoundation.org/show_bug.cgi?id=107139 Adolfo Jayme changed: What|Removed |Added Depends on||125879 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=125879 [Bug 125879] Change Wrap Through Icon -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89991] Save ODT as DOCX turns on Show Changes when Record Changes also on
https://bugs.documentfoundation.org/show_bug.cgi?id=89991 --- Comment #30 from Justin L --- (In reply to László Németh from comment #28) > @Justin: I'm sorry, I have just seen, that you attached a patch, too. No problem. I never assigned the bug to myself and didn't have the knowledge needed to take my ideas to completion. So I'm glad you took over. Valuable information from your commit message: documents exported from MSO with DISABLED Show Changes and DISABLED Options -> Trust Center -> Trust Center Settings -> Privacy Options -> Make hidden markup visible when opening or saving. (Note: this last setting is also needed for MSO obeying the document's settings in order to open in "Final" mode without markup). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120047] Need harpoon symbol to express vectors in math
https://bugs.documentfoundation.org/show_bug.cgi?id=120047 Adolfo Jayme changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED Assignee|libreoffice-b...@lists.free |t...@fixedpoint.jp |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39750] [META] General Math formula editor improvements
https://bugs.documentfoundation.org/show_bug.cgi?id=39750 Bug 39750 depends on bug 120047, which changed state. Bug 120047 Summary: Need harpoon symbol to express vectors in math https://bugs.documentfoundation.org/show_bug.cgi?id=120047 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117497] [META] Colibre icons
https://bugs.documentfoundation.org/show_bug.cgi?id=117497 Bug 117497 depends on bug 125742, which changed state. Bug 125742 Summary: Colibre icons are misleading on the Track Changes toolbar https://bugs.documentfoundation.org/show_bug.cgi?id=125742 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125742] Colibre icons are misleading on the Track Changes toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=125742 Adolfo Jayme changed: What|Removed |Added Resolution|--- |FIXED Whiteboard||target:6.4.0 target:6.3.0.1 Assignee|libreoffice-b...@lists.free |riz_17_...@yahoo.co.id |desktop.org | Status|NEW |RESOLVED --- Comment #3 from Adolfo Jayme --- Addressed with commit 47d0dac4f4b165a7e18a09aa45a6984a6c1fce0e (master) and 8f21ab1af35b789feef66032e8efdf8cbb88d8d2 (cherry-pick to 6-3). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/inc sfx2/source
sfx2/inc/SfxRedactionHelper.hxx| 14 +-
sfx2/inc/autoredactdialog.hxx | 13 ++---
sfx2/source/doc/SfxRedactionHelper.cxx | 29 +
sfx2/source/doc/autoredactdialog.cxx | 22 ++
sfx2/source/doc/objserv.cxx| 12
5 files changed, 70 insertions(+), 20 deletions(-)
New commits:
commit b26489a8a30f2c3e299ef45f17ef4fc64102a0c7
Author: Muhammet Kara
AuthorDate: Wed Jun 12 21:21:26 2019 +0300
Commit: Muhammet Kara
CommitDate: Thu Jun 13 07:35:20 2019 +0200
Auto redaction dialog 6th iteration
* Binds everything together.
* The auto redaction process works end to end now.
* Only for case sensitive text content (no regex support yet)
Change-Id: I6edd67472d376e2c0d91ac4b1ff90d98c49b13ac
Reviewed-on: https://gerrit.libreoffice.org/73908
Tested-by: Jenkins
Reviewed-by: Muhammet Kara
diff --git a/sfx2/inc/SfxRedactionHelper.hxx b/sfx2/inc/SfxRedactionHelper.hxx
index 44a78ab9b877..9be54ca8ac22 100644
--- a/sfx2/inc/SfxRedactionHelper.hxx
+++ b/sfx2/inc/SfxRedactionHelper.hxx
@@ -31,6 +31,7 @@ class SfxStringItem;
class GDIMetaFile;
class DocumentToGraphicRenderer;
class SfxViewFrame;
+struct RedactionTarget;
struct PageMargins
{
@@ -66,10 +67,12 @@ public:
* Creates one shape and one draw page for each gdimetafile,
* and inserts the shapes into the newly created draw pages.
* */
-static void addPagesToDraw(uno::Reference& xComponent, const
sal_Int32& nPages,
- const std::vector& aMetaFiles,
- const std::vector<::Size>& aPageSizes,
- const PageMargins& aPageMargins);
+static void
+addPagesToDraw(uno::Reference& xComponent, const sal_Int32&
nPages,
+ const std::vector& aMetaFiles,
+ const std::vector<::Size>& aPageSizes, const PageMargins&
aPageMargins,
+ const std::vector>&
r_aTableTargets,
+ const bool& bIsAutoRedact);
/*
* Makes the Redaction toolbar visible to the user.
* Meant to be called after converting a document to a Draw doc
@@ -104,7 +107,8 @@ public:
* Search for the given term through the gdimetafile, which has the whole
content of a draw page,
* and draw redaction rectangles to the appropriate positions with
suitable sizes.
* */
-static void autoRedactPage(const OUString& sRedactionTerm, const
GDIMetaFile& rGDIMetaFile,
+static void autoRedactPage(const RedactionTarget* pRedactionTarget,
+ const GDIMetaFile& rGDIMetaFile,
uno::Reference& xPage,
uno::Reference& xComponent);
};
diff --git a/sfx2/inc/autoredactdialog.hxx b/sfx2/inc/autoredactdialog.hxx
index 2336d66c4063..bab00cf536a3 100644
--- a/sfx2/inc/autoredactdialog.hxx
+++ b/sfx2/inc/autoredactdialog.hxx
@@ -105,6 +105,7 @@ class SFX2_DLLPUBLIC SfxAutoRedactDialog : public
SfxDialogController
SfxObjectShellLock m_xDocShell;
std::vector> m_aTableTargets;
std::unique_ptr m_pFileDlg;
+bool m_bIsValidState;
std::unique_ptr m_xRedactionTargetsLabel;
std::unique_ptr m_xTargetsBox;
@@ -133,10 +134,16 @@ public:
SfxAutoRedactDialog(weld::Window* pParent);
virtual ~SfxAutoRedactDialog() override;
-/*
- * Check if the dialog has any valid redaction targets.
- */
+/// Check if the dialog has any valid redaction targets.
bool hasTargets() const;
+/// Check if the dialog is in a valid state.
+bool isValidState() const { return m_bIsValidState; }
+/** Literally moves targets into the given vector.
+ * At the end of the operation, m_aTableTargets vector becomes empty.
+ * The contents of the given vector will be erased before being filled in.
+ * Returns true if successfull.
+ */
+bool moveTargets(std::vector>&
r_aTargets);
// TODO: Some method(s) to check emptiness/validity
// TODO: Some method(s) to get the search params/objects
diff --git a/sfx2/source/doc/SfxRedactionHelper.cxx
b/sfx2/source/doc/SfxRedactionHelper.cxx
index 427972047c02..413cf3b0a84d 100644
--- a/sfx2/source/doc/SfxRedactionHelper.cxx
+++ b/sfx2/source/doc/SfxRedactionHelper.cxx
@@ -8,6 +8,7 @@
*/
#include
+#include
#include
#include
@@ -206,11 +207,12 @@ void
SfxRedactionHelper::getPageMetaFilesFromDoc(std::vector& aMeta
}
}
-void SfxRedactionHelper::addPagesToDraw(uno::Reference& xComponent,
-const sal_Int32& nPages,
-const std::vector&
aMetaFiles,
-const std::vector<::Size>& aPageSizes,
-const PageMargins& aPageMargins)
+void SfxRedactionHelper::addPagesToDraw(
+uno::Reference&
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - svx/source
svx/source/tbxctrls/tbcontrl.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 9dbaac23a1596358ceb84c92ba0357b332e9d76d
Author: Muhammet Kara
AuthorDate: Wed Jun 12 11:57:35 2019 +0300
Commit: Muhammet Kara
CommitDate: Thu Jun 13 07:34:41 2019 +0200
Resolves tdf#115858: More button should move the focus to 'Styles' window
Change-Id: I71c834733ff0f3d4b89ecaeecb12631609e84c1d
Reviewed-on: https://gerrit.libreoffice.org/73872
Tested-by: Jenkins
Reviewed-by: Muhammet Kara
(cherry picked from commit a025132839b19ba952558b9dbec454c8a34c6489)
Reviewed-on: https://gerrit.libreoffice.org/73895
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index d9d9bf0d8248..0b1c52b88acf 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -760,7 +760,7 @@ IMPL_STATIC_LINK_NOARG(SvxStyleBox_Impl, ShowMoreHdl,
void*, void)
if (!pViewFrm)
return;
pViewFrm->ShowChildWindow(SID_SIDEBAR);
-::sfx2::sidebar::Sidebar::ShowPanel("StyleListPanel",
pViewFrm->GetFrame().GetFrameInterface());
+::sfx2::sidebar::Sidebar::ShowPanel("StyleListPanel",
pViewFrm->GetFrame().GetFrameInterface(), true);
}
void SvxStyleBox_Impl::Select()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: RepositoryExternal.mk
RepositoryExternal.mk | 12
1 file changed, 12 deletions(-)
New commits:
commit 41a644dae966ecb958d1fe56cb14f3c091b0eceb
Author: Michael Weghorn
AuthorDate: Wed Jun 12 17:17:07 2019 +0200
Commit: Michael Weghorn
CommitDate: Thu Jun 13 07:31:15 2019 +0200
Drop '-Wno-shadow' previously set for qt5/kde5
The flag has been introduced with commit
9335945c7cb215f387ed1444e28533fac437c6e8 ("KF5 initial VCL plugin")
and was presumably just copy-pasted in commit
4d78cf97d7b1629556df68fc461922fda930d9ec.
The flag should no longer be necessary now; the only issue showing
up after removing the flag was fixed.
Change-Id: I65fe4d12bdf7d5888b75f8a5743bab6979a63295
Reviewed-on: https://gerrit.libreoffice.org/73892
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index 6b0c69b3c804..922347228b81 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -3092,12 +3092,6 @@ $(call gb_LinkTarget_add_libs,$(1),\
$(KF5_LIBS) \
)
-ifeq ($(COM),GCC)
-$(call gb_LinkTarget_add_cxxflags,$(1),\
- -Wno-shadow \
-)
-endif
-
endef
else # !ENABLE_KDE5
@@ -3126,12 +3120,6 @@ $(call gb_LinkTarget_add_libs,$(1),\
$(QT5_LIBS) \
)
-ifeq ($(COM),GCC)
-$(call gb_LinkTarget_add_cxxflags,$(1),\
- -Wno-shadow \
-)
-endif
-
endef
else # !ENABLE_QT5
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - vcl/qt5
vcl/qt5/Qt5SvpSurface.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 1a0cd8777a6d368ea1b03620cc8df6725d74ff72
Author: Michael Weghorn
AuthorDate: Wed Jun 12 17:07:56 2019 +0200
Commit: Michael Weghorn
CommitDate: Thu Jun 13 07:30:21 2019 +0200
qt5: Make it compile with '-Werror=shadow'
This fixes the following issue for the GCC build with '-Werror=shadow'
in place which does not show up in the default build setup since
compiler flag '-Wno-shadow' is currently being set in
'RepositoryExternal.mk' for qt5 and kde5.
(This will be dropped in a follow-up commit.)
.../libreoffice/vcl/qt5/Qt5SvpSurface.cxx: In constructor
‘cairo::Qt5SvpSurface::Qt5SvpSurface(const CairoSurfaceSharedPtr&)’:
.../libreoffice/vcl/qt5/Qt5SvpSurface.cxx:24:69: error: declaration of
‘m_pSurface’ shadows a member of ‘cairo::Qt5SvpSurface’ [-Werror=shadow]
Qt5SvpSurface::Qt5SvpSurface(const CairoSurfaceSharedPtr& m_pSurface)
^
In file included from .../libreoffice/vcl/qt5/Qt5SvpSurface.cxx:12:
.../libreoffice/vcl/inc/qt5/Qt5SvpSurface.hxx:27:27: note: shadowed
declaration is here
CairoSurfaceSharedPtr m_pSurface;
^~
cc1plus: all warnings being treated as errors
Change-Id: I501657447e02675f7c6b1c9aaca670ba81715590
Reviewed-on: https://gerrit.libreoffice.org/73891
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
(cherry picked from commit cc237438f6d1c7ee3a391b51402aaa71cd347b6b)
Reviewed-on: https://gerrit.libreoffice.org/73916
diff --git a/vcl/qt5/Qt5SvpSurface.cxx b/vcl/qt5/Qt5SvpSurface.cxx
index 62fa263c3a3c..00f6004bd2a0 100644
--- a/vcl/qt5/Qt5SvpSurface.cxx
+++ b/vcl/qt5/Qt5SvpSurface.cxx
@@ -21,10 +21,10 @@
namespace cairo
{
-Qt5SvpSurface::Qt5SvpSurface(const CairoSurfaceSharedPtr& m_pSurface)
+Qt5SvpSurface::Qt5SvpSurface(const CairoSurfaceSharedPtr& pSurface)
: m_pGraphics(nullptr)
, m_pCairoContext(nullptr)
-, m_pSurface(m_pSurface)
+, m_pSurface(pSurface)
{
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - vcl/qt5
vcl/qt5/Qt5Menu.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 221f27433900490e2b00bd4ed6957ab36ecadb33
Author: Jan-Marek Glogowski
AuthorDate: Thu Jun 13 02:33:20 2019 +
Commit: Jan-Marek Glogowski
CommitDate: Thu Jun 13 07:14:43 2019 +0200
Qt5 correctly hide menu bar in tabbed mode
Change-Id: I179780c2df5637b8a28c3a77b829319b1a64845b
Reviewed-on: https://gerrit.libreoffice.org/73924
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
(cherry picked from commit 9758b9b6e52e8e8a8a5cc24b51d62a853a3def82)
Reviewed-on: https://gerrit.libreoffice.org/73926
diff --git a/vcl/qt5/Qt5Menu.cxx b/vcl/qt5/Qt5Menu.cxx
index 435cc53363d4..9ca4d54d45a3 100644
--- a/vcl/qt5/Qt5Menu.cxx
+++ b/vcl/qt5/Qt5Menu.cxx
@@ -545,8 +545,8 @@ Qt5Menu* Qt5Menu::GetTopLevel()
void Qt5Menu::ShowMenuBar(bool bVisible)
{
-if (mpQMenuBar && (bVisible != mpQMenuBar->isVisible()))
-bVisible ? mpQMenuBar->show() : mpQMenuBar->hide();
+if (mpQMenuBar)
+mpQMenuBar->setVisible(bVisible);
}
const Qt5Frame* Qt5Menu::GetFrame() const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - vcl/inc vcl/qt5 vcl/source
vcl/inc/qt5/Qt5Frame.hxx |3 ---
vcl/inc/qt5/Qt5Object.hxx |2 ++
vcl/inc/salobj.hxx |7 ---
vcl/qt5/Qt5Frame.cxx | 24 ++--
vcl/qt5/Qt5Object.cxx | 12
vcl/source/window/syschild.cxx |6 --
6 files changed, 32 insertions(+), 22 deletions(-)
New commits:
commit a7ab534afee3d92d92c51759dcb733da6545d7a2
Author: Jan-Marek Glogowski
AuthorDate: Sun Jun 2 21:01:33 2019 +
Commit: Jan-Marek Glogowski
CommitDate: Thu Jun 13 07:00:03 2019 +0200
tdf#125692 SalObject always holds a SystemChildWindow
Let's just face reality and store it as a VclPtr.
And this is needed, because Qt, like VCL, uses deferred deletion,
and has no way to filter events to QObjects out of its event queue
easily. This way the qt5 plugin can report focus changes for
SalObjects without a crash, which happens when you close a
presentation with a video by click.
And in addition it reverts the workaround introduced in commit
e770bacc85a0 ("Qt5 workaround modal change after show bug"), as it
seems this bug is a use-after-free error, introduced by LO.
Thanks Michael Weghorn for catching that!
Maybe someone should also rename SalObject...
Change-Id: I0bc64ea64f95dfc7a838799c4a04de183adfefcf
Reviewed-on: https://gerrit.libreoffice.org/73567
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
(cherry picked from commit 2dc6bdd1d5789ace0500cad90f5d2eb930888bb9)
Reviewed-on: https://gerrit.libreoffice.org/73921
diff --git a/vcl/inc/qt5/Qt5Frame.hxx b/vcl/inc/qt5/Qt5Frame.hxx
index 3b590bd8e28c..c70171869aa8 100644
--- a/vcl/inc/qt5/Qt5Frame.hxx
+++ b/vcl/inc/qt5/Qt5Frame.hxx
@@ -111,9 +111,6 @@ class VCLPLUG_QT5_PUBLIC Qt5Frame : public QObject, public
SalFrame
void TriggerPaintEvent();
void TriggerPaintEvent(QRect aRect);
-private:
-void setVisible(bool);
-
Q_SIGNALS:
void tooltipRequest(const OUString& rTooltip);
diff --git a/vcl/inc/qt5/Qt5Object.hxx b/vcl/inc/qt5/Qt5Object.hxx
index e27d549ca51d..6bfdd81b0327 100644
--- a/vcl/inc/qt5/Qt5Object.hxx
+++ b/vcl/inc/qt5/Qt5Object.hxx
@@ -66,6 +66,8 @@ class Qt5ObjectWindow : public QWindow
Qt5Object& m_rParent;
bool event(QEvent*) override;
+void focusInEvent(QFocusEvent*) override;
+void focusOutEvent(QFocusEvent*) override;
void mousePressEvent(QMouseEvent*) override;
void mouseReleaseEvent(QMouseEvent*) override;
// keyPressEvent(QKeyEvent*) is handled via event(QEvent*); see comment in
Qt5Widget::event
diff --git a/vcl/inc/salobj.hxx b/vcl/inc/salobj.hxx
index 56ca04985a7d..83024fec339d 100644
--- a/vcl/inc/salobj.hxx
+++ b/vcl/inc/salobj.hxx
@@ -21,16 +21,17 @@
#define INCLUDED_VCL_INC_SALOBJ_HXX
#include
+#include
#include
#include "salwtype.hxx"
struct SystemEnvData;
-typedef void (*SALOBJECTPROC)( void* pInst, SalObjEvent nEvent );
+typedef void (*SALOBJECTPROC)(SystemChildWindow* pInst, SalObjEvent nEvent);
class VCL_PLUGIN_PUBLIC SalObject
{
-void* m_pInst;
+VclPtr m_pInst;
SALOBJECTPROC m_pCallback;
boolm_bMouseTransparent:1,
m_bEraseBackground:1;
@@ -54,7 +55,7 @@ public:
virtual const SystemEnvData*GetSystemData() const = 0;
-voidSetCallback( void* pInst, SALOBJECTPROC
pProc )
+voidSetCallback( SystemChildWindow* pInst,
SALOBJECTPROC pProc )
{ m_pInst = pInst; m_pCallback =
pProc; }
voidCallCallback( SalObjEvent nEvent )
{ if (m_pCallback) m_pCallback(
m_pInst, nEvent ); }
diff --git a/vcl/qt5/Qt5Frame.cxx b/vcl/qt5/Qt5Frame.cxx
index 541bb4b2e7ce..7a2c67b809d5 100644
--- a/vcl/qt5/Qt5Frame.cxx
+++ b/vcl/qt5/Qt5Frame.cxx
@@ -33,6 +33,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -360,8 +361,6 @@ void Qt5Frame::DrawMenuBar() { /* not needed */}
void Qt5Frame::SetExtendedFrameStyle(SalExtStyle /*nExtStyle*/) { /* not
needed */}
-void Qt5Frame::setVisible(bool bVisible) { asChild()->setVisible(bVisible); }
-
void Qt5Frame::Show(bool bVisible, bool /*bNoActivate*/)
{
assert(m_pQWidget);
@@ -371,7 +370,7 @@ void Qt5Frame::Show(bool bVisible, bool /*bNoActivate*/)
auto* pSalInst(static_cast(GetSalData()->m_pInstance));
assert(pSalInst);
-pSalInst->RunInMainThread([this, bVisible]() { setVisible(bVisible); });
+pSalInst->RunInMainThread([this, bVisible]() {
asChild()->setVisible(bVisible); });
}
void Qt5Frame::SetMinClientSize(long nWidth, long nHeight)
@@ -506,21 +505,18 @@ void Qt5Frame::SetModal(bool bModal)
auto* pSalInst(static_cast(GetSalData()->m_pInstance));
assert(pSalInst);
pSalInst->RunInMainThread([this, bModal]() {
-
[Libreoffice-commits] core.git: vcl/qt5
vcl/qt5/Qt5Menu.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 9758b9b6e52e8e8a8a5cc24b51d62a853a3def82
Author: Jan-Marek Glogowski
AuthorDate: Thu Jun 13 02:33:20 2019 +
Commit: Jan-Marek Glogowski
CommitDate: Thu Jun 13 06:31:40 2019 +0200
Qt5 correctly hide menu bar in tabbed mode
Change-Id: I179780c2df5637b8a28c3a77b829319b1a64845b
Reviewed-on: https://gerrit.libreoffice.org/73924
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/vcl/qt5/Qt5Menu.cxx b/vcl/qt5/Qt5Menu.cxx
index 435cc53363d4..9ca4d54d45a3 100644
--- a/vcl/qt5/Qt5Menu.cxx
+++ b/vcl/qt5/Qt5Menu.cxx
@@ -545,8 +545,8 @@ Qt5Menu* Qt5Menu::GetTopLevel()
void Qt5Menu::ShowMenuBar(bool bVisible)
{
-if (mpQMenuBar && (bVisible != mpQMenuBar->isVisible()))
-bVisible ? mpQMenuBar->show() : mpQMenuBar->hide();
+if (mpQMenuBar)
+mpQMenuBar->setVisible(bVisible);
}
const Qt5Frame* Qt5Menu::GetFrame() const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 113019] menu text/background color does not follows desktop's color's theme
https://bugs.documentfoundation.org/show_bug.cgi?id=113019 --- Comment #21 from Buovjaga --- opensuse.lietuviu.kalba: as Zion is broken, can you do more testing with other color schemes? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - vcl/inc vcl/qt5
vcl/inc/qt5/Qt5Frame.hxx |1
vcl/qt5/Qt5Frame.cxx | 123 ++-
2 files changed, 28 insertions(+), 96 deletions(-)
New commits:
commit d96d87b5043ed2a75ec7421d046d12568da3926d
Author: Jan-Marek Glogowski
AuthorDate: Sun Jun 2 15:38:25 2019 +
Commit: Jan-Marek Glogowski
CommitDate: Thu Jun 13 06:27:37 2019 +0200
Qt5 introduce Qt5Frame::asChild() helper
Just a little refactoring.
Gets rid of the common used idom in the code:
m_pTopLevel ? m_pTopLevel : m_pQWidget
Change-Id: I3e96687d9d02c0b1a5537c6b6cea53e1ca3a2067
Reviewed-on: https://gerrit.libreoffice.org/73414
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
(cherry picked from commit d8d8cdecdb760500b06cacef3d17c8e05332967d)
Reviewed-on: https://gerrit.libreoffice.org/73920
diff --git a/vcl/inc/qt5/Qt5Frame.hxx b/vcl/inc/qt5/Qt5Frame.hxx
index 16743edc0fc6..3b590bd8e28c 100644
--- a/vcl/inc/qt5/Qt5Frame.hxx
+++ b/vcl/inc/qt5/Qt5Frame.hxx
@@ -123,6 +123,7 @@ public:
QWidget* GetQWidget() const { return m_pQWidget; }
Qt5MainWindow* GetTopLevelWindow() const { return m_pTopLevel; }
+QWidget* asChild() const;
void Damage(sal_Int32 nExtentsX, sal_Int32 nExtentsY, sal_Int32
nExtentsWidth,
sal_Int32 nExtentsHeight) const;
diff --git a/vcl/qt5/Qt5Frame.cxx b/vcl/qt5/Qt5Frame.cxx
index 6d19d825fa1c..541bb4b2e7ce 100644
--- a/vcl/qt5/Qt5Frame.cxx
+++ b/vcl/qt5/Qt5Frame.cxx
@@ -139,13 +139,7 @@ Qt5Frame::Qt5Frame(Qt5Frame* pParent, SalFrameStyleFlags
nStyle, bool bUseCairo)
if (aWinFlags == Qt::Window)
{
-QWidget* pParentWidget = nullptr;
-if (m_pParent)
-{
-pParentWidget
-= (m_pParent->m_pTopLevel) ? m_pParent->m_pTopLevel :
m_pParent->m_pQWidget;
-}
-
+QWidget* pParentWidget = m_pParent ? m_pParent->asChild() : nullptr;
m_pTopLevel = new Qt5MainWindow(*this, pParentWidget, aWinFlags);
m_pQWidget = new Qt5Widget(*this, aWinFlags);
m_pTopLevel->setCentralWidget(m_pQWidget);
@@ -159,8 +153,7 @@ Qt5Frame::Qt5Frame(Qt5Frame* pParent, SalFrameStyleFlags
nStyle, bool bUseCairo)
if (pParent && !(pParent->m_nStyle & SalFrameStyleFlags::PLUG))
{
QWindow* pParentWindow =
pParent->GetQWidget()->window()->windowHandle();
-QWindow* pChildWindow = (m_pTopLevel ?
m_pTopLevel->window()->windowHandle()
- :
m_pQWidget->window()->windowHandle());
+QWindow* pChildWindow = asChild()->window()->windowHandle();
if (pParentWindow && pChildWindow && (pParentWindow != pChildWindow))
pChildWindow->setTransientParent(pParentWindow);
}
@@ -217,10 +210,7 @@ Qt5Frame::~Qt5Frame()
{
Qt5Instance* pInst = static_cast(GetSalData()->m_pInstance);
pInst->eraseFrame(this);
-if (m_pTopLevel)
-delete m_pTopLevel;
-else
-delete m_pQWidget;
+delete asChild();
m_aSystemData.aShellWindow = 0;
}
@@ -302,60 +292,31 @@ bool Qt5Frame::PostEvent(std::unique_ptr
pData)
return true;
}
-bool Qt5Frame::isWindow() const
-{
-if (m_pTopLevel)
-return m_pTopLevel->isWindow();
-else
-return m_pQWidget->isWindow();
-}
+QWidget* Qt5Frame::asChild() const { return m_pTopLevel ? m_pTopLevel :
m_pQWidget; }
+
+bool Qt5Frame::isWindow() const { return asChild()->isWindow(); }
QWindow* Qt5Frame::windowHandle() const
{
// set attribute 'Qt::WA_NativeWindow' first to make sure a window handle
actually exists
-if (m_pTopLevel)
-{
-m_pTopLevel->setAttribute(Qt::WA_NativeWindow);
-return m_pTopLevel->windowHandle();
-}
-else
-{
-m_pQWidget->setAttribute(Qt::WA_NativeWindow);
-return m_pQWidget->windowHandle();
-}
+QWidget* pChild = asChild();
+pChild->setAttribute(Qt::WA_NativeWindow);
+return pChild->windowHandle();
}
QScreen* Qt5Frame::screen() const
{
QWindow* const pWindow = windowHandle();
-if (pWindow)
-return pWindow->screen();
-else
-return nullptr;
+return pWindow ? pWindow->screen() : nullptr;
}
-bool Qt5Frame::isMinimized() const
-{
-if (m_pTopLevel)
-return m_pTopLevel->isMinimized();
-else
-return m_pQWidget->isMinimized();
-}
+bool Qt5Frame::isMinimized() const { return asChild()->isMinimized(); }
-bool Qt5Frame::isMaximized() const
-{
-if (m_pTopLevel)
-return m_pTopLevel->isMaximized();
-else
-return m_pQWidget->isMaximized();
-}
+bool Qt5Frame::isMaximized() const { return asChild()->isMaximized(); }
void Qt5Frame::SetWindowStateImpl(Qt::WindowStates eState)
{
-if (m_pTopLevel)
-m_pTopLevel->setWindowState(eState);
-else
-m_pQWidget->setWindowState(eState);
+return asChild()->setWindowState(eState);
}
void Qt5Frame::SetTitle(const OUString& rTitle)
@@
[Libreoffice-bugs] [Bug 125890] Slide-order can not be changed in print dialogue while printing handouts
https://bugs.documentfoundation.org/show_bug.cgi?id=125890 --- Comment #3 from i...@individual-it.net --- Works fine in Version: 6.3.0.0.beta1+ Build ID: 142696e71e15db3c112796c43630bdfa6c634fa0 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Building libreoffice headless
Hi James, Am 12.06.19 um 16:00 schrieb James Carbine: > We would really like to use either the --without-x or --disable-gui > options to build a headless LibreOffice. As shown here: > https://wiki.documentfoundation.org/Development/HeadlessBuild. I > recognize that, the time of this posting, it says `WARNING: This is > broken in master and 4.4! Unless you plan to fix it don't use it`. I > attempted looking into fixing it. But the truth is, I don't have the > knowledge to fix it. I know nothing about building LibreOffice. That info might be completely out of date. It refers to 4.4, which is a few years old. But then I never build without GUI. As you may know there is the LibreOffice Online version since a few years[1]. That can run in a docker container on a server. But I don't know if it really is build without any GUI libraries at all. I never used it. > Can any one either point me in the direction I need to go in order to > build LibreOffice without X (or any gui dependencies)? > > -or- > > Are there any maintainers that the company I work for(Atomic Jolt) can > pay to fix the headless build option? Please have a look at [2]. > We want to make sure there are no gui dependencies. It's not clear what that means for you. No gui libraries linked or no running gui reqired. On Linux, the X11 libs might be linked to our VCL library (LO's own toolkit), but X11 is not required to run even normal LO as a server background process. It runs just fine when started with the --headless parameter and the SVP VCL backend via SAL_USE_VCLPLUGIN=svp on a headless server. With the proper --accept parameter you can control it remotely via UNO. That's what the Java unit tests do. Start an background LO instance and control it. Same for Python an even UI tests. I used to run LO builds and tests on a headless server in a Tinderbox (a LO build bot). I even implemented headless for MacOS, so I could run the tests and builds via SSH without any windows, just bitmaps. But that was ~1.5 years ago - code might have bit-rotted since then. But this still required GUI libraries linked, as it's just a command line switch, which replaces the OS GUI parts for bitmaps, simplified. HTH Jan-Marek [1] https://www.libreoffice.org/download/libreoffice-online/ [2] https://www.libreoffice.org/get-help/professional-support/ [3] https://wiki.documentfoundation.org/Development/Tinderbox ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 125890] Slide-order can not be changed in print dialogue while printing handouts
https://bugs.documentfoundation.org/show_bug.cgi?id=125890 --- Comment #2 from i...@individual-it.net --- can reproduce it with Version: 6.0.7.3 Build ID: 1:6.0.7-0ubuntu0.18.04.6 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: de-DE (en_US.UTF-8); Calc: group When manually selecting "Slided per page" = "6" the sorting works correct, when leaving it to "According to layout" the order dropdown does not make any difference -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125841] Move HTML image embedding option to file export / save dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=125841 --- Comment #5 from Vladimir --- There is "Edit filter settings" option in the file dialog, which is grayed out for HTML. Isn't it the obvious place for such options? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 125841] Move HTML image embedding option to file export / save dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=125841 --- Comment #5 from Vladimir --- There is "Edit filter settings" option in the file dialog, which is grayed out for HTML. Isn't it the obvious place for such options? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 125891] HELP: Needed to add description on Math's new attribute harpoon/wideharpoon to help
https://bugs.documentfoundation.org/show_bug.cgi?id=125891 Takeshi Abe changed: What|Removed |Added Blocks||120200 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=120200 [Bug 120200] [META] Update or correct help for features -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120200] [META] Update or correct help for features
https://bugs.documentfoundation.org/show_bug.cgi?id=120200 Takeshi Abe changed: What|Removed |Added Depends on||125891 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=125891 [Bug 125891] HELP: Needed to add description on Math's new attribute harpoon/wideharpoon to help -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125891] New: HELP: Needed to add description on Math's new attribute harpoon/wideharpoon to help
https://bugs.documentfoundation.org/show_bug.cgi?id=125891 Bug ID: 125891 Summary: HELP: Needed to add description on Math's new attribute harpoon/wideharpoon to help Product: LibreOffice Version: 6.4.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: t...@fixedpoint.jp CC: olivier.hal...@documentfoundation.org Description: Help documentation has to be updated as implemented new attribute harpoon/wideharpoon of Math for tdf#120047. The following page is relevant, for example: https://help.libreoffice.org/Math/Attributes https://help.libreoffice.org/Math/Attributes_2 Steps to Reproduce: See the above help pages. Actual Results: No description about the new attribute. Expected Results: The above help pages should mention harpoon/wideharpoon. Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125746] Options menu takes too long to open
https://bugs.documentfoundation.org/show_bug.cgi?id=125746 --- Comment #14 from BogdanB --- If it is there an opion to show you more from logs or from somewhere please tell me and I will send you what you need. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125746] Options menu takes too long to open
https://bugs.documentfoundation.org/show_bug.cgi?id=125746 --- Comment #13 from BogdanB --- I made a new experiment now. In LO 6.1 that is loading in 3-4 secondsȘ - Help - Restart in Safe Mode and I choose Reset to factory settings and 3-4 seconds also, so it it not from icons, or bad profile or any settings I choose. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125879] Change Wrap Through Icon
https://bugs.documentfoundation.org/show_bug.cgi?id=125879 --- Comment #9 from Commit Notification --- Rizal Muttaqin committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/8f21ab1af35b789feef66032e8efdf8cbb88d8d2%5E%21 Colibre: tdf#125879 Change Wrap Through Icon, tdf#125888, clean SVG It will be available in 6.3.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125746] Options menu takes too long to open
https://bugs.documentfoundation.org/show_bug.cgi?id=125746 --- Comment #12 from BogdanB --- Created attachment 152148 --> https://bugs.documentfoundation.org/attachment.cgi?id=152148=edit another video with 3 tests Please see my new short video. I tested again: - SAL_USE_VCLPLUGIN=gen /opt/libreoffice6.1/program/soffice: INSTANT - SAL_USE_VCLPLUGIN=gtk /opt/libreoffice6.1/program/soffice: INSTANT - Than I Start normally the LibreOffice 6.1 and I get 3-4 seconds. I have no explanation. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125879] Change Wrap Through Icon
https://bugs.documentfoundation.org/show_bug.cgi?id=125879 --- Comment #8 from Commit Notification --- Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/47d0dac4f4b165a7e18a09aa45a6984a6c1fce0e%5E%21 Colibre: tdf#125879 Change Wrap Through Icon, tdf#125888, clean SVG It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - icon-themes/elementary icon-themes/elementary_svg
icon-themes/elementary/links.txt |3 --- 1 file changed, 3 deletions(-) New commits: commit 876e247e047bdacd5b0b98c19e96d2cdf3c30881 Author: Jens Carl AuthorDate: Fri Jun 7 00:04:18 2019 -0700 Commit: Rizal Muttaqin CommitDate: Thu Jun 13 05:20:42 2019 +0200 elementary: Rename icon toolsmacroedit to basicideappear The icon isn't needed at two places anymore and it's a follow up of daba09df247c09db715ca86a6b78365e49bfe034, which removed the menu entry toolsmacroedit. Also clean the links.txt file. Change-Id: I700aebab5f3049ab43b778de8ae6e3e3476ae2a1 Reviewed-on: https://gerrit.libreoffice.org/73642 Tested-by: Jenkins Reviewed-by: Jens Carl (cherry picked from commit ab09fa72f2b7b1ce9da00b4e9cb12bd0841f7820) Reviewed-on: https://gerrit.libreoffice.org/73918 Reviewed-by: Rizal Muttaqin diff --git a/icon-themes/elementary/cmd/32/toolsmacroedit.png b/icon-themes/elementary/cmd/32/basicideappear.png similarity index 100% rename from icon-themes/elementary/cmd/32/toolsmacroedit.png rename to icon-themes/elementary/cmd/32/basicideappear.png diff --git a/icon-themes/elementary/cmd/lc_toolsmacroedit.png b/icon-themes/elementary/cmd/lc_basicideappear.png similarity index 100% rename from icon-themes/elementary/cmd/lc_toolsmacroedit.png rename to icon-themes/elementary/cmd/lc_basicideappear.png diff --git a/icon-themes/elementary/cmd/sc_toolsmacroedit.png b/icon-themes/elementary/cmd/sc_basicideappear.png similarity index 100% rename from icon-themes/elementary/cmd/sc_toolsmacroedit.png rename to icon-themes/elementary/cmd/sc_basicideappear.png diff --git a/icon-themes/elementary/links.txt b/icon-themes/elementary/links.txt index d915ff854461..35026e85455a 100644 --- a/icon-themes/elementary/links.txt +++ b/icon-themes/elementary/links.txt @@ -1165,15 +1165,12 @@ cmd/sc_viewsidebarstyles.png cmd/sc_designerdialog.png # Macro cmd/32/macrodialog.png cmd/32/scriptorganizer.png cmd/32/macrosmenu.png cmd/32/choosemacro.png -cmd/32/basicideappear.png cmd/32/toolsmacroedit.png cmd/lc_macrodialog.png cmd/lc_scriptorganizer.png cmd/lc_macrosmenu.png cmd/lc_choosemacro.png -cmd/lc_basicideappear.png cmd/lc_toolsmacroedit.png cmd/sc_macrodialog.png cmd/sc_scriptorganizer.png cmd/sc_macrosmenu.png cmd/sc_choosemacro.png -cmd/sc_basicideappear.png cmd/sc_toolsmacroedit.png # Outline diff --git a/icon-themes/elementary_svg/cmd/32/toolsmacroedit.svg b/icon-themes/elementary_svg/cmd/32/basicideappear.svg similarity index 100% rename from icon-themes/elementary_svg/cmd/32/toolsmacroedit.svg rename to icon-themes/elementary_svg/cmd/32/basicideappear.svg diff --git a/icon-themes/elementary_svg/cmd/lc_toolsmacroedit.svg b/icon-themes/elementary_svg/cmd/lc_basicideappear.svg similarity index 100% rename from icon-themes/elementary_svg/cmd/lc_toolsmacroedit.svg rename to icon-themes/elementary_svg/cmd/lc_basicideappear.svg diff --git a/icon-themes/elementary_svg/cmd/sc_toolsmacroedit.svg b/icon-themes/elementary_svg/cmd/sc_basicideappear.svg similarity index 100% rename from icon-themes/elementary_svg/cmd/sc_toolsmacroedit.svg rename to icon-themes/elementary_svg/cmd/sc_basicideappear.svg ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120047] Need harpoon symbol to express vectors in math
https://bugs.documentfoundation.org/show_bug.cgi?id=120047 Commit Notification changed: What|Removed |Added Whiteboard||target:6.4.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120047] Need harpoon symbol to express vectors in math
https://bugs.documentfoundation.org/show_bug.cgi?id=120047 --- Comment #4 from Commit Notification --- Takeshi Abe committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/93eeaf0ad902214fb6b4205606b24046a458ee45%5E%21 tdf#120047 Support attribute harpoon/wideharpoon in Math It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: extras/source starmath/inc starmath/qa starmath/source starmath/uiconfig
extras/source/truetype/symbol/OpenSymbol.sfd| 25
starmath/inc/node.hxx |2 -
starmath/inc/strings.hrc|2 +
starmath/inc/strings.hxx|2 +
starmath/inc/token.hxx |4 ++-
starmath/inc/types.hxx |1
starmath/qa/cppunit/test_nodetotextvisitors.cxx |2 +
starmath/source/ElementsDockingWindow.cxx |4 ++-
starmath/source/mathmlexport.cxx|1
starmath/source/mathtype.cxx|2 +
starmath/source/node.cxx|3 ++
starmath/source/ooxmlexport.cxx |1
starmath/source/ooxmlimport.cxx |3 ++
starmath/source/parse.cxx |3 ++
starmath/source/rtfexport.cxx |1
starmath/uiconfig/smath/popupmenu/edit.xml |2 +
16 files changed, 51 insertions(+), 7 deletions(-)
New commits:
commit 93eeaf0ad902214fb6b4205606b24046a458ee45
Author: Takeshi Abe
AuthorDate: Mon May 27 00:12:28 2019 +0900
Commit: Takeshi Abe
CommitDate: Thu Jun 13 05:11:25 2019 +0200
tdf#120047 Support attribute harpoon/wideharpoon in Math
... for an alternative style of vectors.
They are vec/widevec analogs but with COMBINING RIGHT HARPOON ABOVE
(U+20D1). The new attribute names are deliberately long in order to
make fewer accidental collisions with variable names in formulae of
exising documents.
This also adds a glyph uni20D1 to OpenSymbol.
Change-Id: I31666e57808aa0e0327500916d3b862549891886
Reviewed-on: https://gerrit.libreoffice.org/72987
Tested-by: Jenkins
Reviewed-by: Takeshi Abe
diff --git a/extras/source/truetype/symbol/OpenSymbol.sfd
b/extras/source/truetype/symbol/OpenSymbol.sfd
index 35d4b01328b9..c9e9baad1707 100644
--- a/extras/source/truetype/symbol/OpenSymbol.sfd
+++ b/extras/source/truetype/symbol/OpenSymbol.sfd
@@ -3,8 +3,8 @@ FontName: OpenSymbol
FullName: OpenSymbol
FamilyName: OpenSymbol
Weight: Book
-Copyright: (c) 2009 Sun Microsystems Inc.\nTHERE DOES NOT EXIST (c) 2011
Julien Nabet\nPRECEDES <-> DOES NOT SUCCEED (c) 2011 Olivier Hallot\nPRIME <->
TRIPLE PRIME (c) 2013 Mathias Hasselmann\nphi <-> phi1 (c) 2015 Khaled
Hosny\n(c) 2016 Mike Kaganski\nzero, one, two, three, four, five, six, seven,
eight, nine, question, underscore, copyright, registered, uni2215, angle,
therefore, lozenge (c) 2010 Google Corporation
-Version: 102.10
+Copyright: (c) 2009 Sun Microsystems Inc.\nTHERE DOES NOT EXIST (c) 2011
Julien Nabet\nPRECEDES <-> DOES NOT SUCCEED (c) 2011 Olivier Hallot\nPRIME <->
TRIPLE PRIME (c) 2013 Mathias Hasselmann\nphi <-> phi1 (c) 2015 Khaled
Hosny\n(c) 2016 Mike Kaganski\nzero, one, two, three, four, five, six, seven,
eight, nine, question, underscore, copyright, registered, uni2215, angle,
therefore, lozenge (c) 2010 Google Corporation\nuni20D1 (c) 2019 Takeshi Abe
+Version: 102.11
ItalicAngle: 0
UnderlinePosition: -143
UnderlineWidth: 20
@@ -20,7 +20,7 @@ OS2Version: 0
OS2_WeightWidthSlopeOnly: 0
OS2_UseTypoMetrics: 1
CreationTime: 1144938807
-ModificationTime: 1479754802
+ModificationTime: 1558881510
PfmFamily: 81
TTFWeight: 400
TTFWidth: 5
@@ -784,7 +784,7 @@ FitToEm: 1
WinInfo: 0 34 12
BeginPrivate: 0
EndPrivate
-BeginChars: 1052 1052
+BeginChars: 1053 1053
StartChar: Alpha
Encoding: 0 913 0
@@ -108707,5 +108707,22 @@ SplineSet
508 1286 l 1,6,-1
EndSplineSet
EndChar
+
+StartChar: uni20D1
+Encoding: 1052 8401 1052
+Width: 1056
+Flags: W
+HStem: 1313 112<98 686>
+LayerCount: 2
+Fore
+SplineSet
+98 1313 m 1,0,-1
+ 98 1425 l 1,1,-1
+ 686 1425 l 1,2,-1
+ 645 1575 l 1,3,-1
+ 1026 1313 l 1,4,-1
+ 98 1313 l 1,0,-1
+EndSplineSet
+EndChar
EndChars
EndSplineFont
diff --git a/starmath/inc/node.hxx b/starmath/inc/node.hxx
index da67e9bdece6..73bfb17132c9 100644
--- a/starmath/inc/node.hxx
+++ b/starmath/inc/node.hxx
@@ -1019,7 +1019,7 @@ public:
/** Attribute node
*
* Used to give an attribute to another node. Used for commands such as:
- * UNDERLINE, OVERLINE, OVERSTRIKE, WIDEVEC, WIDEHAT and WIDETILDE.
+ * UNDERLINE, OVERLINE, OVERSTRIKE, WIDEVEC, WIDEHARPOON, WIDEHAT and
WIDETILDE.
*
* Children:
* 0: Attribute
diff --git a/starmath/inc/strings.hrc b/starmath/inc/strings.hrc
index eec600990ba0..f12677d26eca 100644
--- a/starmath/inc/strings.hrc
+++ b/starmath/inc/strings.hrc
@@ -165,6 +165,7 @@
#define RID_HATX_HELP NC_("RID_HATX_HELP", "Circumflex" )
#define RID_TILDEX_HELP NC_("RID_TILDEX_HELP", "Tilde" )
#define RID_VECX_HELP NC_("RID_VECX_HELP", "Vector
Arrow" )
+#define RID_HARPOONX_HELP NC_("RID_HARPOONX_HELP", "Harpoon"
)
#define RID_UNDERLINEX_HELP NC_("RID_UNDERLINEX_HELP", "Line
Below" )
#define RID_OVERLINEX_HELP
[Libreoffice-bugs] [Bug 125746] Options menu takes too long to open
https://bugs.documentfoundation.org/show_bug.cgi?id=125746 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125562] LibreOffice fonts aren't installed with LibreOffice 6.2.4.2
https://bugs.documentfoundation.org/show_bug.cgi?id=125562 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 125065] Enhancement: I want an entry field added to be able to change the default amount of indent for the Increase Indent button in LibreOffice Writer, Calc, and any othe
https://bugs.documentfoundation.org/show_bug.cgi?id=125065 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 125862] Cálculo erróneo (Miscalculation)
https://bugs.documentfoundation.org/show_bug.cgi?id=125862 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120575] With LibreOffice Calc, the 'Find All' button sometimes fails.
https://bugs.documentfoundation.org/show_bug.cgi?id=120575 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125862] Cálculo erróneo (Miscalculation)
https://bugs.documentfoundation.org/show_bug.cgi?id=125862 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120575] With LibreOffice Calc, the 'Find All' button sometimes fails.
https://bugs.documentfoundation.org/show_bug.cgi?id=120575 --- Comment #3 from QA Administrators --- Dear steve, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125065] Enhancement: I want an entry field added to be able to change the default amount of indent for the Increase Indent button in LibreOffice Writer, Calc, and any other Lib
https://bugs.documentfoundation.org/show_bug.cgi?id=125065 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119267] Can not connect LibreOffice from Linux to a Samba server share via IP address of the server
https://bugs.documentfoundation.org/show_bug.cgi?id=119267 --- Comment #11 from QA Administrators --- Dear kivi, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98360] [META] CMIS bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=98360 Bug 98360 depends on bug 112298, which changed state. Bug 112298 Summary: FILEOPEN: General input error when disconnecting Google Drive https://bugs.documentfoundation.org/show_bug.cgi?id=112298 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125746] Options menu takes too long to open
https://bugs.documentfoundation.org/show_bug.cgi?id=125746 --- Comment #11 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112298] FILEOPEN: General input error when disconnecting Google Drive
https://bugs.documentfoundation.org/show_bug.cgi?id=112298 --- Comment #5 from QA Administrators --- Dear Emil Tanev, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113884] Add Fields sometimes wrong when based on * query of underlying query with Alias field name
https://bugs.documentfoundation.org/show_bug.cgi?id=113884 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121048] UI freezes when you scroll up and down past page with cursor
https://bugs.documentfoundation.org/show_bug.cgi?id=121048 --- Comment #3 from QA Administrators --- Dear sam, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91448] FILESAVE: XLSX data bar chart gradient fill is not preserved after RT.
https://bugs.documentfoundation.org/show_bug.cgi?id=91448 --- Comment #5 from QA Administrators --- Dear darshan.gandhi, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113884] Add Fields sometimes wrong when based on * query of underlying query with Alias field name
https://bugs.documentfoundation.org/show_bug.cgi?id=113884 --- Comment #17 from QA Administrators --- Dear Howard Johnson, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112298] FILEOPEN: General input error when disconnecting Google Drive
https://bugs.documentfoundation.org/show_bug.cgi?id=112298 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121048] UI freezes when you scroll up and down past page with cursor
https://bugs.documentfoundation.org/show_bug.cgi?id=121048 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108244] Cell Comments Often Loss when Saving in FODS Format. Steps to reproduce in comment 5
https://bugs.documentfoundation.org/show_bug.cgi?id=108244 --- Comment #12 from QA Administrators --- Dear John Carlson, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118106] Unsuccessful record search causes form to change focus to previous record, but displays empty fields where pre-existing data should appear
https://bugs.documentfoundation.org/show_bug.cgi?id=118106 --- Comment #4 from QA Administrators --- Dear David C Mckenna, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116720] LibreOffice Calc does not read its own HTML attributes (save as)
https://bugs.documentfoundation.org/show_bug.cgi?id=116720 --- Comment #7 from QA Administrators --- Dear chris, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91477] FILEOPEN: XLSX Databar color is different than in Word 2010
https://bugs.documentfoundation.org/show_bug.cgi?id=91477 --- Comment #8 from QA Administrators --- Dear darshan.gandhi, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118084] "File does not exist" all due it exists, might be a problem with special characters.
https://bugs.documentfoundation.org/show_bug.cgi?id=118084 --- Comment #5 from QA Administrators --- Dear snackbarian, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91298] Standard Filter: Value changes to serial number
https://bugs.documentfoundation.org/show_bug.cgi?id=91298 --- Comment #4 from QA Administrators --- Dear HD, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117826] Pattern is off (dashes at instead of solid horizontal lines) in Presentation mode with OpenGL
https://bugs.documentfoundation.org/show_bug.cgi?id=117826 --- Comment #12 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 38356] Saving formula in Excel XML format is invalid
https://bugs.documentfoundation.org/show_bug.cgi?id=38356 --- Comment #9 from QA Administrators --- Dear Yogurt, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81809] Certain writer tables with merged cells cannot be formatted
https://bugs.documentfoundation.org/show_bug.cgi?id=81809 --- Comment #7 from QA Administrators --- Dear Matthew Francis, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93202] When merging cells formula is lost
https://bugs.documentfoundation.org/show_bug.cgi?id=93202 --- Comment #10 from QA Administrators --- Dear grofaty, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116261] CALC FORMATTING changing the format of some characters of a text cell (interpreted as formula?)
https://bugs.documentfoundation.org/show_bug.cgi?id=116261 --- Comment #10 from QA Administrators --- Dear Elyse Cordeau, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - avmedia/source
avmedia/source/gstreamer/gstplayer.cxx | 24
1 file changed, 16 insertions(+), 8 deletions(-)
New commits:
commit 142696e71e15db3c112796c43630bdfa6c634fa0
Author: Jan-Marek Glogowski
AuthorDate: Wed Jun 12 00:54:04 2019 +0200
Commit: Jan-Marek Glogowski
CommitDate: Thu Jun 13 04:26:46 2019 +0200
tdf#125821 don't crash on missing gstreamer plugins
If GStreamer can't auto-detect an audio sink via "autoaudiosink",
it'll return a nullptr. If the volume plugin is missing, then this
currently also results in a crash.
So check the gst_element_factory_make results before using the
objects and change some wrong mpPlaybin checks to the right
mpVolumeControl ones.
This works for me without any audio and volume plugins. Since we
are linked against libgstaudio, I assume the bin is always there.
Change-Id: Ide526363d810ea48d0a62539c0a435553783e34a
Reviewed-on: https://gerrit.libreoffice.org/73848
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
(cherry picked from commit 5e6af47dc87a55fea595c952ea3e59c93d0620db)
Reviewed-on: https://gerrit.libreoffice.org/73919
diff --git a/avmedia/source/gstreamer/gstplayer.cxx
b/avmedia/source/gstreamer/gstplayer.cxx
index b2e5382353f9..250f924f5096 100644
--- a/avmedia/source/gstreamer/gstplayer.cxx
+++ b/avmedia/source/gstreamer/gstplayer.cxx
@@ -665,11 +665,18 @@ void Player::preparePlaybin( const OUString& rURL,
GstElement *pSink )
mpVolumeControl = gst_element_factory_make( "volume", nullptr );
GstElement *pAudioSink = gst_element_factory_make( "autoaudiosink",
nullptr );
GstElement* pAudioOutput = gst_bin_new("audio-output-bin");
-gst_bin_add_many(GST_BIN(pAudioOutput), mpVolumeControl, pAudioSink,
nullptr);
-gst_element_link(mpVolumeControl, pAudioSink);
-GstPad *pPad = gst_element_get_static_pad(mpVolumeControl, "sink");
-gst_element_add_pad(GST_ELEMENT(pAudioOutput), gst_ghost_pad_new("sink",
pPad));
-gst_object_unref(GST_OBJECT(pPad));
+assert(pAudioOutput);
+if (pAudioSink)
+gst_bin_add(GST_BIN(pAudioOutput), pAudioSink);
+if (mpVolumeControl)
+{
+gst_bin_add(GST_BIN(pAudioOutput), mpVolumeControl);
+if (pAudioSink)
+gst_element_link(mpVolumeControl, pAudioSink);
+GstPad *pPad = gst_element_get_static_pad(mpVolumeControl, "sink");
+gst_element_add_pad(GST_ELEMENT(pAudioOutput),
gst_ghost_pad_new("sink", pPad));
+gst_object_unref(GST_OBJECT(pPad));
+}
g_object_set(G_OBJECT(mpPlaybin), "audio-sink", pAudioOutput, nullptr);
if( pSink != nullptr ) // used for getting preferred size etc.
@@ -848,7 +855,7 @@ void SAL_CALL Player::setMute( sal_Bool bSet )
SAL_INFO( "avmedia.gstreamer", AVVERSION "set mute: " << bSet << " muted:
" << mbMuted << " unmuted volume: " << mnUnmutedVolume );
// change the volume to 0 or the unmuted volume
-if( mpPlaybin && mbMuted != bool(bSet) )
+if (mpVolumeControl && mbMuted != bool(bSet))
{
double nVolume = mnUnmutedVolume;
if( bSet )
@@ -880,7 +887,7 @@ void SAL_CALL Player::setVolumeDB( sal_Int16 nVolumeDB )
SAL_INFO( "avmedia.gstreamer", AVVERSION "set volume: " << nVolumeDB << "
gst volume: " << mnUnmutedVolume );
// change volume
-if( !mbMuted && mpPlaybin )
+if (mpVolumeControl && !mbMuted)
{
g_object_set( G_OBJECT( mpVolumeControl ), "volume", mnUnmutedVolume,
nullptr );
}
@@ -893,7 +900,8 @@ sal_Int16 SAL_CALL Player::getVolumeDB()
sal_Int16 nVolumeDB(0);
-if( mpPlaybin ) {
+if (mpVolumeControl)
+{
double nGstVolume = 0.0;
g_object_get( G_OBJECT( mpVolumeControl ), "volume", ,
nullptr );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125517] LO Impress: Can't stop presentation with video and go to the next slide
https://bugs.documentfoundation.org/show_bug.cgi?id=125517 Commit Notification changed: What|Removed |Added Whiteboard|target:6.4.0|target:6.4.0 target:6.3.0.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125517] LO Impress: Can't stop presentation with video and go to the next slide
https://bugs.documentfoundation.org/show_bug.cgi?id=125517 --- Comment #9 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/03352dc301bb7e67445e81d017376aa24264e9a3%5E%21 tdf#125517 Qt5 implement a minimal Qt5ObjectWindow It will be available in 6.3.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - vcl/inc vcl/qt5
vcl/inc/qt5/Qt5Object.hxx| 20 -
vcl/inc/qt5/Qt5Widget.hxx| 45 +-
vcl/qt5/Qt5Object.cxx| 35 +--
vcl/qt5/Qt5OpenGLContext.cxx |3 +-
vcl/qt5/Qt5Widget.cxx| 63 +--
5 files changed, 122 insertions(+), 44 deletions(-)
New commits:
commit 03352dc301bb7e67445e81d017376aa24264e9a3
Author: Jan-Marek Glogowski
AuthorDate: Thu May 30 13:39:11 2019 +
Commit: Jan-Marek Glogowski
CommitDate: Thu Jun 13 03:56:19 2019 +0200
tdf#125517 Qt5 implement a minimal Qt5ObjectWindow
Since we can't use an input and visual transparent widget, like a
GtkGrid, we have to implement input forwarding in the QWindow.
Using a Qt5Widget directly results in other problems on Qt 5.12+,
like these warnings (depending on the tested Qt::WA_* flags):
* Attempted flush to non-raster surface QWidgetWindow(0xa386c10,
name="QWidgetClassWindow") of type QSurface::OpenGLSurface
(consider using Qt::WA_PaintOnScreen to exclude from
backingstore sync)
* QWidget::paintEngine: Should no longer be called
So the current QWidget::createWindowContainer has to stay and key
and mouse handling must be implemented as in Qt5Widget. And the
QWindow is strangely not accessible through the windowHandle() of
the container QWwidget.
As a result this patch is mostly boilerplate code, publishing the
Qt5Widget mouse and key handling as static functions.
Change-Id: I5be5f5fa1379c6bdefab0f96604251801c252b38
Reviewed-on: https://gerrit.libreoffice.org/73566
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
(cherry picked from commit 25edbded9946801effd117b9c46de0f8b4bc5632)
Reviewed-on: https://gerrit.libreoffice.org/73917
diff --git a/vcl/inc/qt5/Qt5Object.hxx b/vcl/inc/qt5/Qt5Object.hxx
index 88cd8baa78da..e27d549ca51d 100644
--- a/vcl/inc/qt5/Qt5Object.hxx
+++ b/vcl/inc/qt5/Qt5Object.hxx
@@ -24,10 +24,10 @@
#include
#include
+#include
class Qt5Frame;
class QWidget;
-class QWindow;
class Qt5Object : public QObject, public SalObject
{
@@ -44,6 +44,10 @@ class Qt5Object : public QObject, public SalObject
public:
Qt5Object(Qt5Frame* pParent, bool bShow);
+Qt5Frame* frame() const { return m_pParent; }
+QWidget* widget() const { return m_pQWidget; }
+QWindow* windowHandle() const { return m_pQWindow; }
+
virtual void ResetClipRegion() override;
virtual void BeginSetClipRegion(sal_uInt32 nRects) override;
virtual void UnionClipRegion(long nX, long nY, long nWidth, long nHeight)
override;
@@ -57,4 +61,18 @@ public:
virtual const SystemEnvData* GetSystemData() const override { return
_aSystemData; }
};
+class Qt5ObjectWindow : public QWindow
+{
+Qt5Object& m_rParent;
+
+bool event(QEvent*) override;
+void mousePressEvent(QMouseEvent*) override;
+void mouseReleaseEvent(QMouseEvent*) override;
+// keyPressEvent(QKeyEvent*) is handled via event(QEvent*); see comment in
Qt5Widget::event
+void keyReleaseEvent(QKeyEvent*) override;
+
+public:
+explicit Qt5ObjectWindow(Qt5Object& rParent);
+};
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/inc/qt5/Qt5Widget.hxx b/vcl/inc/qt5/Qt5Widget.hxx
index ce4e068cbbec..8ead4b3ec945 100644
--- a/vcl/inc/qt5/Qt5Widget.hxx
+++ b/vcl/inc/qt5/Qt5Widget.hxx
@@ -27,17 +27,6 @@
class Qt5Frame;
class Qt5Object;
-class QEvent;
-class QFocusEvent;
-class QInputMethodEvent;
-class QKeyEvent;
-class QMouseEvent;
-class QMoveEvent;
-class QPaintEvent;
-class QResizeEvent;
-class QShowEvent;
-class QWheelEvent;
-class QVariant;
class Qt5Widget : public QWidget
{
@@ -48,9 +37,15 @@ class Qt5Widget : public QWidget
int m_nDeltaX;
int m_nDeltaY;
-bool handleKeyEvent(QKeyEvent*, bool);
-void handleMouseButtonEvent(QMouseEvent*, bool);
-void commitText(const QString& aText) const;
+enum class ButtonKeyState
+{
+Pressed,
+Released
+};
+
+static void commitText(Qt5Frame&, const QString& aText);
+static bool handleKeyEvent(Qt5Frame&, const QWidget&, QKeyEvent*, const
ButtonKeyState);
+static void handleMouseButtonEvent(const Qt5Frame&, QMouseEvent*, const
ButtonKeyState);
virtual bool event(QEvent*) override;
@@ -84,6 +79,28 @@ public:
Qt5Frame& getFrame() const { return m_rFrame; }
void startDrag(sal_Int8 nSourceActions);
void endExtTextInput();
+
+static bool handleEvent(Qt5Frame&, const QWidget&, QEvent*);
+// key events might be propagated further down => call base on false
+static inline bool handleKeyReleaseEvent(Qt5Frame&, const QWidget&,
QKeyEvent*);
+// mouse events are always accepted
+static inline void handleMousePressEvent(const Qt5Frame&, QMouseEvent*);
+static inline void handleMouseReleaseEvent(const Qt5Frame&, QMouseEvent*);
};
+bool
[Libreoffice-bugs] [Bug 125709] FORMAT NUMBER DIALOG: Crash when changing language of date field
https://bugs.documentfoundation.org/show_bug.cgi?id=125709 --- Comment #17 from Jan-Marek Glogowski --- (In reply to Julien Nabet from comment #16) > Another thing I noticed in the last bt retrieved is "Breeze". > > Just for the test, could you try to reproduce this with another UI theme > (options/tools/display, icon style)? The breeze.so is the Qt style - that is independent from the icon set in use by LO. You could check if setting an other style in KDE fixes the crash, but I doubt it. Currently I suspect either a Qt or KDE bug or generally a memory corruption. Would be interesting to know if master also fails: https://dev-builds.libreoffice.org/daily/ More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Or install valgrind and set "export VALGRIND=memcheck" and start soffice (will be very slow) and attach the logs. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113019] menu text/background color does not follows desktop's color's theme
https://bugs.documentfoundation.org/show_bug.cgi?id=113019 Jan-Marek Glogowski changed: What|Removed |Added Status|NEW |NEEDINFO CC||glo...@fbihome.de --- Comment #20 from Jan-Marek Glogowski --- Can someone retest this please with 6.3 or master with kde5 / qt5? Zion is unusable for me on Debian Buster, either with LO or with kate. Both menus are broken (black on dark gray). And I realized that menus don't follow style change events. I always had to restart the application. Since we now use native Qt menus (not for popups!), it should follow KDE's style. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119202] LibreOffice apps should not change their WM_CLASS values after being launched
https://bugs.documentfoundation.org/show_bug.cgi?id=119202 Jan-Marek Glogowski changed: What|Removed |Added CC||glo...@fbihome.de --- Comment #7 from Jan-Marek Glogowski --- What is missing in all the comments is the VCL plugin in use (just copy "About LibreOffice"), but I guess it's not kde5. Because for me it's currently just $ SAL_USE_VCLPLUGIN=kde5 soffice --writer $ xprop WM_CLASS WM_CLASS(STRING) = "soffice.bin", "soffice.bin" And that actually never changes. $ SAL_USE_VCLPLUGIN=gtk3 soffice --writer $ xprop WM_CLASS WM_CLASS(STRING) = "libreoffice", "libreoffice-writer" And since gtk3_kde5 is just gtk3 + kde5 file picker as an external app, it's gtk3 from the code => same problem. And I'm not sure anything regarding gtk3 should be fixed. If the user chooses to run the gtk3 backend on KDE, because currently kde5 has much more bugs and problems then gtk3, then the user have cope with that fallout. IMHO we don't want special desktop handling in each backend. BTW: LO has an internal fallback list of plugins so it tries hard to always start up. Always check "About LibreOffice" for the real plugin in use! Even SAL_USE_VCLPLUGIN is just a preference. Now probably we should change the WM_CLASS to libreoffice for kde5? After reading all the stuff / bugs I'm not sure about it. What is the expected behavior here? Should there be different grouping for different LO document types, except the icons in the group list? And I couldn't find any Qt Core function to change the WM_CLASS. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: avmedia/source
avmedia/source/gstreamer/gstplayer.cxx | 24
1 file changed, 16 insertions(+), 8 deletions(-)
New commits:
commit 5e6af47dc87a55fea595c952ea3e59c93d0620db
Author: Jan-Marek Glogowski
AuthorDate: Wed Jun 12 00:54:04 2019 +0200
Commit: Jan-Marek Glogowski
CommitDate: Thu Jun 13 01:47:48 2019 +0200
tdf#125821 don't crash on missing gstreamer plugins
If GStreamer can't auto-detect an audio sink via "autoaudiosink",
it'll return a nullptr. If the volume plugin is missing, then this
currently also results in a crash.
So check the gst_element_factory_make results before using the
objects and change some wrong mpPlaybin checks to the right
mpVolumeControl ones.
This works for me without any audio and volume plugins. Since we
are linked against libgstaudio, I assume the bin is always there.
Change-Id: Ide526363d810ea48d0a62539c0a435553783e34a
Reviewed-on: https://gerrit.libreoffice.org/73848
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/avmedia/source/gstreamer/gstplayer.cxx
b/avmedia/source/gstreamer/gstplayer.cxx
index 63c88b712424..f88addd0cfef 100644
--- a/avmedia/source/gstreamer/gstplayer.cxx
+++ b/avmedia/source/gstreamer/gstplayer.cxx
@@ -580,11 +580,18 @@ void Player::preparePlaybin( const OUString& rURL,
GstElement *pSink )
mpVolumeControl = gst_element_factory_make( "volume", nullptr );
GstElement *pAudioSink = gst_element_factory_make( "autoaudiosink",
nullptr );
GstElement* pAudioOutput = gst_bin_new("audio-output-bin");
-gst_bin_add_many(GST_BIN(pAudioOutput), mpVolumeControl, pAudioSink,
nullptr);
-gst_element_link(mpVolumeControl, pAudioSink);
-GstPad *pPad = gst_element_get_static_pad(mpVolumeControl, "sink");
-gst_element_add_pad(GST_ELEMENT(pAudioOutput), gst_ghost_pad_new("sink",
pPad));
-gst_object_unref(GST_OBJECT(pPad));
+assert(pAudioOutput);
+if (pAudioSink)
+gst_bin_add(GST_BIN(pAudioOutput), pAudioSink);
+if (mpVolumeControl)
+{
+gst_bin_add(GST_BIN(pAudioOutput), mpVolumeControl);
+if (pAudioSink)
+gst_element_link(mpVolumeControl, pAudioSink);
+GstPad *pPad = gst_element_get_static_pad(mpVolumeControl, "sink");
+gst_element_add_pad(GST_ELEMENT(pAudioOutput),
gst_ghost_pad_new("sink", pPad));
+gst_object_unref(GST_OBJECT(pPad));
+}
g_object_set(G_OBJECT(mpPlaybin), "audio-sink", pAudioOutput, nullptr);
if( pSink != nullptr ) // used for getting preferred size etc.
@@ -759,7 +766,7 @@ void SAL_CALL Player::setMute( sal_Bool bSet )
SAL_INFO( "avmedia.gstreamer", AVVERSION "set mute: " << bSet << " muted:
" << mbMuted << " unmuted volume: " << mnUnmutedVolume );
// change the volume to 0 or the unmuted volume
-if( mpPlaybin && mbMuted != bool(bSet) )
+if (mpVolumeControl && mbMuted != bool(bSet))
{
double nVolume = mnUnmutedVolume;
if( bSet )
@@ -791,7 +798,7 @@ void SAL_CALL Player::setVolumeDB( sal_Int16 nVolumeDB )
SAL_INFO( "avmedia.gstreamer", AVVERSION "set volume: " << nVolumeDB << "
gst volume: " << mnUnmutedVolume );
// change volume
-if( !mbMuted && mpPlaybin )
+if (mpVolumeControl && !mbMuted)
{
g_object_set( G_OBJECT( mpVolumeControl ), "volume", mnUnmutedVolume,
nullptr );
}
@@ -804,7 +811,8 @@ sal_Int16 SAL_CALL Player::getVolumeDB()
sal_Int16 nVolumeDB(0);
-if( mpPlaybin ) {
+if (mpVolumeControl)
+{
double nGstVolume = 0.0;
g_object_get( G_OBJECT( mpVolumeControl ), "volume", ,
nullptr );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Bug 102495 depends on bug 125821, which changed state. Bug 125821 Summary: Crash on insertion of video https://bugs.documentfoundation.org/show_bug.cgi?id=125821 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125633] Error import formula from MS Office
https://bugs.documentfoundation.org/show_bug.cgi?id=125633 Aron Budea changed: What|Removed |Added Version|4.4 all versions|4.1.0.4 release Keywords|bibisectRequest |bibisected, bisected CC||ba...@caesar.elte.hu --- Comment #7 from Aron Budea --- Bibisected to the following range using repo bibisect-41max, commits failed to build in between: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=406dfa3240249d3611743ec2cee1b644a3c56291..3326a85ae6ad417b37d52fd9a806f42004ba In this range three commits from Luboš Luňák are related to DOCX formulas, and only one seems to be relevant during import. Reverting it confirmed this commit is responsible: https://cgit.freedesktop.org/libreoffice/core/commit/?id=a75adeae36d96d507a774b91eb586e89f8035c3e author Luboš Luňák2013-03-26 16:07:52 +0100 committer Luboš Luňák2013-03-26 17:19:58 +0100 m:nor and m:lit math docx tags lead to quoting -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125890] Slide-order can not be changed in print dialogue while printing handouts
https://bugs.documentfoundation.org/show_bug.cgi?id=125890 --- Comment #1 from umsonster+bugzi...@gmail.com --- Created attachment 152147 --> https://bugs.documentfoundation.org/attachment.cgi?id=152147=edit Error in print windows -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125890] New: Slide-order can not be changed in print dialogue while printing handouts
https://bugs.documentfoundation.org/show_bug.cgi?id=125890 Bug ID: 125890 Summary: Slide-order can not be changed in print dialogue while printing handouts Product: LibreOffice Version: 6.0.6.2 release Hardware: x86 (IA32) OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: umsonster+bugzi...@gmail.com Description: When trying to print handouts the order of slides remains "down first, then right" even after changing the option. This occurs, when six slides are chosen for one page. Steps to Reproduce: 1. Open file 2. Open print dialogue 3. Select "Handouts" Actual Results: Slide order down, right Expected Results: Slide order right, down Reproducible: Always User Profile Reset: Yes Additional Info: Slide-order does not change, when election ist changed. When different number of slides is selected the printing windows closes and reopens with the renewed preview. When selecting a different order, no closing or renewing of preview occurs. Version: 6.0.6.2 Build-ID: 0c292870b25a325b5ed35f6b45599d2ea4458e77 CPU-Threads: 4; BS: Mac OS X 10.14.5; UI-Render: Standard; Gebietsschema: de-DE (de_DE.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124755] Crash - Hsqldb ODB file crashes office on opening from StartCenter
https://bugs.documentfoundation.org/show_bug.cgi?id=124755 --- Comment #26 from Scott --- @Et Al - I have some follow up information that might be helpful but not sure of protocol. I am listing it here. Please advise if it should go elsewhere. Thinking back through the initial installation of LO on this system, I chose to install via flatpak. I don't remember my exact reasoning but it may have been around upgrading to the most recent version, I decided to install LO via PPA and not flatpak. And I ran both for a short while until I removed the flatpak version. Maybe that's helpful...maybe I just crushed your world. Either way...let me know. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125870] (LibreOffice-Flatpak) xdg-user-dirs are not displayed within GTK File Chooser (in my case xdg-user-dirs are set to be outside /home)
https://bugs.documentfoundation.org/show_bug.cgi?id=125870 antistress changed: What|Removed |Added Resolution|--- |INVALID Status|UNCONFIRMED |RESOLVED --- Comment #2 from antistress --- (In reply to Stephan Bergmann from comment #1) > I cannot reproduce your issue You're right: I've checked my ~/.config/user-dirs.dirs and it seems it has been reset Once my ~/.config/user-dirs.dirs restored, they're shown within LibreOffice File Chooser. Sorry for the annoyance Thanks -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115534] [META] LibreOffice Flatpak package bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=115534 Bug 115534 depends on bug 125870, which changed state. Bug 125870 Summary: (LibreOffice-Flatpak) xdg-user-dirs are not displayed within GTK File Chooser (in my case xdg-user-dirs are set to be outside /home) https://bugs.documentfoundation.org/show_bug.cgi?id=125870 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Bug 102495 depends on bug 125517, which changed state. Bug 125517 Summary: LO Impress: Can't stop presentation with video and go to the next slide https://bugs.documentfoundation.org/show_bug.cgi?id=125517 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125517] LO Impress: Can't stop presentation with video and go to the next slide
https://bugs.documentfoundation.org/show_bug.cgi?id=125517 Jan-Marek Glogowski changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Bug 102495 depends on bug 125692, which changed state. Bug 125692 Summary: kde5: Impress crashes when closing after using presentation minimizer https://bugs.documentfoundation.org/show_bug.cgi?id=125692 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/inc vcl/unx
vcl/inc/unx/gtk/gtkframe.hxx |2 +-
vcl/unx/gtk3/gtk3gtkframe.cxx | 13 +
2 files changed, 6 insertions(+), 9 deletions(-)
New commits:
commit 7bc1418a463fe233fbd8c27dec70a1f92474db65
Author: Caolán McNamara
AuthorDate: Tue Jun 11 17:10:25 2019 +0100
Commit: Michael Weghorn
CommitDate: Wed Jun 12 23:23:36 2019 +0200
Resolves: rhbz#1719378 wrong signature for GtkGestureLongPress::pressed
Change-Id: Ib4c47189d5c9c89433f0c7de194ebb9777dc7bac
Reviewed-on: https://gerrit.libreoffice.org/73831
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx
index a77c7c61686b..732a637eda81 100644
--- a/vcl/inc/unx/gtk/gtkframe.hxx
+++ b/vcl/inc/unx/gtk/gtkframe.hxx
@@ -271,7 +271,7 @@ class GtkSalFrame : public SalFrame
guint time, gpointer frame);
static void gestureSwipe(GtkGestureSwipe* gesture, gdouble
velocity_x, gdouble velocity_y, gpointer frame);
-static void gestureLongPress(GtkGestureLongPress* gesture,
gpointer frame);
+static void gestureLongPress(GtkGestureLongPress* gesture, gdouble
x, gdouble y, gpointer frame);
#else
static gboolean signalExpose( GtkWidget*, GdkEventExpose*, gpointer );
void askForXEmbedFocus( sal_Int32 nTimecode );
diff --git a/vcl/unx/gtk3/gtk3gtkframe.cxx b/vcl/unx/gtk3/gtk3gtkframe.cxx
index adcde282e3b1..95898a0f827e 100644
--- a/vcl/unx/gtk3/gtk3gtkframe.cxx
+++ b/vcl/unx/gtk3/gtk3gtkframe.cxx
@@ -2893,17 +2893,14 @@ void GtkSalFrame::gestureSwipe(GtkGestureSwipe*
gesture, gdouble velocity_x, gdo
}
}
-void GtkSalFrame::gestureLongPress(GtkGestureLongPress* gesture, gpointer
frame)
+void GtkSalFrame::gestureLongPress(GtkGestureLongPress* gesture, gdouble x,
gdouble y, gpointer frame)
{
-GtkSalFrame* pThis = static_cast(frame);
-
-if(pThis)
+GdkEventSequence *sequence =
gtk_gesture_single_get_current_sequence(GTK_GESTURE_SINGLE(gesture));
+if (gtk_gesture_get_point(GTK_GESTURE(gesture), sequence, , ))
{
-SalLongPressEvent aEvent;
+GtkSalFrame* pThis = static_cast(frame);
-gdouble x, y;
-GdkEventSequence *sequence =
gtk_gesture_single_get_current_sequence(GTK_GESTURE_SINGLE(gesture));
-gtk_gesture_get_point(GTK_GESTURE(gesture), sequence, , );
+SalLongPressEvent aEvent;
aEvent.mnX = x;
aEvent.mnY = y;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/inc vcl/qt5 vcl/source
vcl/inc/qt5/Qt5Frame.hxx |3 ---
vcl/inc/qt5/Qt5Object.hxx |2 ++
vcl/inc/salobj.hxx |7 ---
vcl/qt5/Qt5Frame.cxx | 13 +
vcl/qt5/Qt5Object.cxx | 12
vcl/source/window/syschild.cxx |6 --
6 files changed, 23 insertions(+), 20 deletions(-)
New commits:
commit 2dc6bdd1d5789ace0500cad90f5d2eb930888bb9
Author: Jan-Marek Glogowski
AuthorDate: Wed Jun 5 17:39:45 2019 +
Commit: Jan-Marek Glogowski
CommitDate: Wed Jun 12 23:22:56 2019 +0200
tdf#125692 SalObject always holds a SystemChildWindow
Let's just face reality and store it as a VclPtr.
And this is needed, because Qt, like VCL, uses deferred deletion,
and has no way to filter events to QObjects out of its event queue
easily. This way the qt5 plugin can report focus changes for
SalObjects without a crash, which happens when you close a
presentation with a video by click.
And in addition it reverts the workaround introduced in commit
e770bacc85a0 ("Qt5 workaround modal change after show bug"), as it
seems this bug is a use-after-free error, introduced by LO.
Thanks Michael Weghorn for catching that!
Maybe someone should also rename SalObject...
Change-Id: I0bc64ea64f95dfc7a838799c4a04de183adfefcf
Reviewed-on: https://gerrit.libreoffice.org/73567
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/vcl/inc/qt5/Qt5Frame.hxx b/vcl/inc/qt5/Qt5Frame.hxx
index 3b590bd8e28c..c70171869aa8 100644
--- a/vcl/inc/qt5/Qt5Frame.hxx
+++ b/vcl/inc/qt5/Qt5Frame.hxx
@@ -111,9 +111,6 @@ class VCLPLUG_QT5_PUBLIC Qt5Frame : public QObject, public
SalFrame
void TriggerPaintEvent();
void TriggerPaintEvent(QRect aRect);
-private:
-void setVisible(bool);
-
Q_SIGNALS:
void tooltipRequest(const OUString& rTooltip);
diff --git a/vcl/inc/qt5/Qt5Object.hxx b/vcl/inc/qt5/Qt5Object.hxx
index e27d549ca51d..6bfdd81b0327 100644
--- a/vcl/inc/qt5/Qt5Object.hxx
+++ b/vcl/inc/qt5/Qt5Object.hxx
@@ -66,6 +66,8 @@ class Qt5ObjectWindow : public QWindow
Qt5Object& m_rParent;
bool event(QEvent*) override;
+void focusInEvent(QFocusEvent*) override;
+void focusOutEvent(QFocusEvent*) override;
void mousePressEvent(QMouseEvent*) override;
void mouseReleaseEvent(QMouseEvent*) override;
// keyPressEvent(QKeyEvent*) is handled via event(QEvent*); see comment in
Qt5Widget::event
diff --git a/vcl/inc/salobj.hxx b/vcl/inc/salobj.hxx
index 56ca04985a7d..83024fec339d 100644
--- a/vcl/inc/salobj.hxx
+++ b/vcl/inc/salobj.hxx
@@ -21,16 +21,17 @@
#define INCLUDED_VCL_INC_SALOBJ_HXX
#include
+#include
#include
#include "salwtype.hxx"
struct SystemEnvData;
-typedef void (*SALOBJECTPROC)( void* pInst, SalObjEvent nEvent );
+typedef void (*SALOBJECTPROC)(SystemChildWindow* pInst, SalObjEvent nEvent);
class VCL_PLUGIN_PUBLIC SalObject
{
-void* m_pInst;
+VclPtr m_pInst;
SALOBJECTPROC m_pCallback;
boolm_bMouseTransparent:1,
m_bEraseBackground:1;
@@ -54,7 +55,7 @@ public:
virtual const SystemEnvData*GetSystemData() const = 0;
-voidSetCallback( void* pInst, SALOBJECTPROC
pProc )
+voidSetCallback( SystemChildWindow* pInst,
SALOBJECTPROC pProc )
{ m_pInst = pInst; m_pCallback =
pProc; }
voidCallCallback( SalObjEvent nEvent )
{ if (m_pCallback) m_pCallback(
m_pInst, nEvent ); }
diff --git a/vcl/qt5/Qt5Frame.cxx b/vcl/qt5/Qt5Frame.cxx
index 8e63a35cc5c8..270885249298 100644
--- a/vcl/qt5/Qt5Frame.cxx
+++ b/vcl/qt5/Qt5Frame.cxx
@@ -362,8 +362,6 @@ void Qt5Frame::DrawMenuBar() { /* not needed */}
void Qt5Frame::SetExtendedFrameStyle(SalExtStyle /*nExtStyle*/) { /* not
needed */}
-void Qt5Frame::setVisible(bool bVisible) { asChild()->setVisible(bVisible); }
-
void Qt5Frame::Show(bool bVisible, bool /*bNoActivate*/)
{
assert(m_pQWidget);
@@ -373,7 +371,7 @@ void Qt5Frame::Show(bool bVisible, bool /*bNoActivate*/)
auto* pSalInst(static_cast(GetSalData()->m_pInstance));
assert(pSalInst);
-pSalInst->RunInMainThread([this, bVisible]() { setVisible(bVisible); });
+pSalInst->RunInMainThread([this, bVisible]() {
asChild()->setVisible(bVisible); });
}
void Qt5Frame::SetMinClientSize(long nWidth, long nHeight)
@@ -514,16 +512,7 @@ void Qt5Frame::SetModal(bool bModal)
// modality change is only effective if the window is hidden
if (bWasVisible)
-{
pChild->hide();
-if (QGuiApplication::platformName() == "xcb")
-{
-SAL_WARN("vcl.qt5", "SetModal called after Show - apply
delay");
-// give QXcbConnection some time to recover
[Libreoffice-commits] core.git: vcl/inc vcl/qt5
vcl/inc/qt5/Qt5Object.hxx| 20 -
vcl/inc/qt5/Qt5Widget.hxx| 45 +-
vcl/qt5/Qt5Object.cxx| 35 +--
vcl/qt5/Qt5OpenGLContext.cxx |3 +-
vcl/qt5/Qt5Widget.cxx| 63 +--
5 files changed, 122 insertions(+), 44 deletions(-)
New commits:
commit 25edbded9946801effd117b9c46de0f8b4bc5632
Author: Jan-Marek Glogowski
AuthorDate: Thu May 30 13:39:11 2019 +
Commit: Jan-Marek Glogowski
CommitDate: Wed Jun 12 23:22:06 2019 +0200
tdf#125517 Qt5 implement a minimal Qt5ObjectWindow
Since we can't use an input and visual transparent widget, like a
GtkGrid, we have to implement input forwarding in the QWindow.
Using a Qt5Widget directly results in other problems on Qt 5.12+,
like these warnings (depending on the tested Qt::WA_* flags):
* Attempted flush to non-raster surface QWidgetWindow(0xa386c10,
name="QWidgetClassWindow") of type QSurface::OpenGLSurface
(consider using Qt::WA_PaintOnScreen to exclude from
backingstore sync)
* QWidget::paintEngine: Should no longer be called
So the current QWidget::createWindowContainer has to stay and key
and mouse handling must be implemented as in Qt5Widget. And the
QWindow is strangely not accessible through the windowHandle() of
the container QWwidget.
As a result this patch is mostly boilerplate code, publishing the
Qt5Widget mouse and key handling as static functions.
Change-Id: I5be5f5fa1379c6bdefab0f96604251801c252b38
Reviewed-on: https://gerrit.libreoffice.org/73566
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/vcl/inc/qt5/Qt5Object.hxx b/vcl/inc/qt5/Qt5Object.hxx
index 88cd8baa78da..e27d549ca51d 100644
--- a/vcl/inc/qt5/Qt5Object.hxx
+++ b/vcl/inc/qt5/Qt5Object.hxx
@@ -24,10 +24,10 @@
#include
#include
+#include
class Qt5Frame;
class QWidget;
-class QWindow;
class Qt5Object : public QObject, public SalObject
{
@@ -44,6 +44,10 @@ class Qt5Object : public QObject, public SalObject
public:
Qt5Object(Qt5Frame* pParent, bool bShow);
+Qt5Frame* frame() const { return m_pParent; }
+QWidget* widget() const { return m_pQWidget; }
+QWindow* windowHandle() const { return m_pQWindow; }
+
virtual void ResetClipRegion() override;
virtual void BeginSetClipRegion(sal_uInt32 nRects) override;
virtual void UnionClipRegion(long nX, long nY, long nWidth, long nHeight)
override;
@@ -57,4 +61,18 @@ public:
virtual const SystemEnvData* GetSystemData() const override { return
_aSystemData; }
};
+class Qt5ObjectWindow : public QWindow
+{
+Qt5Object& m_rParent;
+
+bool event(QEvent*) override;
+void mousePressEvent(QMouseEvent*) override;
+void mouseReleaseEvent(QMouseEvent*) override;
+// keyPressEvent(QKeyEvent*) is handled via event(QEvent*); see comment in
Qt5Widget::event
+void keyReleaseEvent(QKeyEvent*) override;
+
+public:
+explicit Qt5ObjectWindow(Qt5Object& rParent);
+};
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/inc/qt5/Qt5Widget.hxx b/vcl/inc/qt5/Qt5Widget.hxx
index ce4e068cbbec..8ead4b3ec945 100644
--- a/vcl/inc/qt5/Qt5Widget.hxx
+++ b/vcl/inc/qt5/Qt5Widget.hxx
@@ -27,17 +27,6 @@
class Qt5Frame;
class Qt5Object;
-class QEvent;
-class QFocusEvent;
-class QInputMethodEvent;
-class QKeyEvent;
-class QMouseEvent;
-class QMoveEvent;
-class QPaintEvent;
-class QResizeEvent;
-class QShowEvent;
-class QWheelEvent;
-class QVariant;
class Qt5Widget : public QWidget
{
@@ -48,9 +37,15 @@ class Qt5Widget : public QWidget
int m_nDeltaX;
int m_nDeltaY;
-bool handleKeyEvent(QKeyEvent*, bool);
-void handleMouseButtonEvent(QMouseEvent*, bool);
-void commitText(const QString& aText) const;
+enum class ButtonKeyState
+{
+Pressed,
+Released
+};
+
+static void commitText(Qt5Frame&, const QString& aText);
+static bool handleKeyEvent(Qt5Frame&, const QWidget&, QKeyEvent*, const
ButtonKeyState);
+static void handleMouseButtonEvent(const Qt5Frame&, QMouseEvent*, const
ButtonKeyState);
virtual bool event(QEvent*) override;
@@ -84,6 +79,28 @@ public:
Qt5Frame& getFrame() const { return m_rFrame; }
void startDrag(sal_Int8 nSourceActions);
void endExtTextInput();
+
+static bool handleEvent(Qt5Frame&, const QWidget&, QEvent*);
+// key events might be propagated further down => call base on false
+static inline bool handleKeyReleaseEvent(Qt5Frame&, const QWidget&,
QKeyEvent*);
+// mouse events are always accepted
+static inline void handleMousePressEvent(const Qt5Frame&, QMouseEvent*);
+static inline void handleMouseReleaseEvent(const Qt5Frame&, QMouseEvent*);
};
+bool Qt5Widget::handleKeyReleaseEvent(Qt5Frame& rFrame, const QWidget&
rWidget, QKeyEvent* pEvent)
+{
+return handleKeyEvent(rFrame,
[Libreoffice-bugs] [Bug 125517] LO Impress: Can't stop presentation with video and go to the next slide
https://bugs.documentfoundation.org/show_bug.cgi?id=125517 Commit Notification changed: What|Removed |Added Whiteboard||target:6.4.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125517] LO Impress: Can't stop presentation with video and go to the next slide
https://bugs.documentfoundation.org/show_bug.cgi?id=125517 --- Comment #8 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/25edbded9946801effd117b9c46de0f8b4bc5632%5E%21 tdf#125517 Qt5 implement a minimal Qt5ObjectWindow It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - dbaccess/uiconfig
dbaccess/uiconfig/ui/textconnectionsettings.ui |1 + 1 file changed, 1 insertion(+) New commits: commit 527ea6c085e22576096a056f2c84e47e96ad69dd Author: Caolán McNamara AuthorDate: Tue Jun 11 10:44:46 2019 +0100 Commit: Michael Weghorn CommitDate: Wed Jun 12 23:20:58 2019 +0200 has_default needs can_default Change-Id: Id841d214b8d88a986c07d2827b281e5805c3c941 Reviewed-on: https://gerrit.libreoffice.org/73812 Tested-by: Jenkins Reviewed-by: Michael Weghorn diff --git a/dbaccess/uiconfig/ui/textconnectionsettings.ui b/dbaccess/uiconfig/ui/textconnectionsettings.ui index c19184429637..10f01e82dfdf 100644 --- a/dbaccess/uiconfig/ui/textconnectionsettings.ui +++ b/dbaccess/uiconfig/ui/textconnectionsettings.ui @@ -28,6 +28,7 @@ gtk-ok True True +True True True True ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: shell/Library_kde5be.mk vcl/Library_vclplug_kde5.mk vcl/Library_vclplug_qt5.mk
shell/Library_kde5be.mk |2 +-
vcl/Library_vclplug_kde5.mk |2 +-
vcl/Library_vclplug_qt5.mk |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 66b856dc557168a5839c256e7134c895985a908a
Author: Michael Weghorn
AuthorDate: Wed Jun 12 16:32:53 2019 +0200
Commit: Michael Weghorn
CommitDate: Wed Jun 12 23:15:42 2019 +0200
Use 'gb_Library_add_cxxflags' for '-include chrono'
Rationale is the same as in described in commit
4aa60490622cc10f8d3a31489c62a5622d240c83
("gbuild: treat $({QT,KF}5_CFLAGS) as cxxflags, not defines").
Change-Id: I1253e33118956b72561bd56bbc668ca345006c37
Reviewed-on: https://gerrit.libreoffice.org/73700
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/shell/Library_kde5be.mk b/shell/Library_kde5be.mk
index 39fdaf884409..a89892dee17f 100644
--- a/shell/Library_kde5be.mk
+++ b/shell/Library_kde5be.mk
@@ -32,7 +32,7 @@ $(eval $(call gb_Library_add_exception_objects,kde5be1,\
# Workaround for clang+icecream (clang's -frewrite-includes
# doesn't handle Qt5's QT_HAS_INCLUDE that Qt5 uses for ).
ifeq ($(COM_IS_CLANG),TRUE)
-$(eval $(call gb_Library_add_defs,kde5be1, \
+$(eval $(call gb_Library_add_cxxflags,kde5be1, \
-include chrono \
))
endif
diff --git a/vcl/Library_vclplug_kde5.mk b/vcl/Library_vclplug_kde5.mk
index 181a318ab797..8b5804185b3e 100644
--- a/vcl/Library_vclplug_kde5.mk
+++ b/vcl/Library_vclplug_kde5.mk
@@ -94,7 +94,7 @@ endif
# Workaround for clang+icecream (clang's -frewrite-includes
# doesn't handle Qt5's QT_HAS_INCLUDE that Qt5 uses for ).
ifeq ($(COM_IS_CLANG),TRUE)
-$(eval $(call gb_Library_add_defs,vclplug_kde5, \
+$(eval $(call gb_Library_add_cxxflags,vclplug_kde5, \
-include chrono \
))
endif
diff --git a/vcl/Library_vclplug_qt5.mk b/vcl/Library_vclplug_qt5.mk
index 543a4569ceb9..1a0546488bcd 100644
--- a/vcl/Library_vclplug_qt5.mk
+++ b/vcl/Library_vclplug_qt5.mk
@@ -123,7 +123,7 @@ endif
# Workaround for clang+icecream (clang's -frewrite-includes
# doesn't handle Qt5's QT_HAS_INCLUDE that Qt5 uses for ).
ifeq ($(COM_IS_CLANG),TRUE)
-$(eval $(call gb_Library_add_defs,vclplug_qt5, \
+$(eval $(call gb_Library_add_cxxflags,vclplug_qt5, \
-include chrono \
))
endif
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 90be6c5cbde6d86da10960e2fee13164c43b9d14 Author: Michael Weghorn AuthorDate: Wed Jun 12 17:25:59 2019 +0200 Commit: Michael Weghorn CommitDate: Wed Jun 12 23:15:04 2019 +0200 configure.ac: Drop extra '/' for KF5 includes Drop the extra '/' resulting in the include in path, like e.g. '-isystem /usr/include//KF5/KCoreAddons'. Change-Id: I6b1814b91c17926309b5a0567d4d1338a691e92e Reviewed-on: https://gerrit.libreoffice.org/73894 Tested-by: Jenkins Reviewed-by: Michael Weghorn diff --git a/configure.ac b/configure.ac index fa58f9ff3591..2586ca81c1bf 100644 --- a/configure.ac +++ b/configure.ac @@ -11182,7 +11182,7 @@ then kf5_haiku_libdirs="`findpaths -c ' ' -a $haiku_arch B_FIND_PATH_DEVELOP_LIB_DIRECTORY`" fi -kf5_incdirs="$KF5INC /usr/include/ $kf5_haiku_incdirs $x_includes" +kf5_incdirs="$KF5INC /usr/include $kf5_haiku_incdirs $x_includes" kf5_libdirs="$KF5LIB /usr/lib /usr/lib/kf5 /usr/lib/kf5/devel $kf5_haiku_libdirs $x_libraries" if test -n "$supports_multilib"; then kf5_libdirs="$kf5_libdirs /usr/lib64 /usr/lib64/kf5 /usr/lib64/kf5/devel" ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125746] Options menu takes too long to open
https://bugs.documentfoundation.org/show_bug.cgi?id=125746 --- Comment #10 from sergio.calleg...@gmail.com --- Cannot start gtk2 (if I try to use it, I get kde5), but tried gen (x11), gtk3 and kde5 and I see the same issue. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122891] Improve bookmarks
https://bugs.documentfoundation.org/show_bug.cgi?id=122891 --- Comment #10 from Cor Nouws --- (In reply to Heiko Tietze from comment #9) > Created attachment 152128 [details] > Mockup for context menu Thanks. It doesn't make me enthusiastic Heiko. There's enough of space for the buttons. And visible buttons improve usability and accessibility. I don't see the point, really, for this mini-changes that hide functions. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117462] FORMATING: Rendering of svg file (LO-Logo) is incorrect and corrupt after rotation
https://bugs.documentfoundation.org/show_bug.cgi?id=117462 --- Comment #11 from Micha --- Created attachment 152146 --> https://bugs.documentfoundation.org/attachment.cgi?id=152146=edit Screenshot of Libreoffice logo svg in LO 3.3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 125841] Move HTML image embedding option to file export / save dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=125841 --- Comment #4 from Cor Nouws --- (In reply to Heiko Tietze from comment #3) > .. So this ... have to find space in the file dialog, > which is totally awkward. There are options. So is this an argument? > Plus, when you add the image per link you are told > it wont be stored with the document independently from the format. => WFM Update Help? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 125841] Move HTML image embedding option to file export / save dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=125841 --- Comment #4 from Cor Nouws --- (In reply to Heiko Tietze from comment #3) > .. So this ... have to find space in the file dialog, > which is totally awkward. There are options. So is this an argument? > Plus, when you add the image per link you are told > it wont be stored with the document independently from the format. => WFM Update Help? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117462] FORMATING: Rendering of svg file (LO-Logo) is incorrect and corrupt after rotation
https://bugs.documentfoundation.org/show_bug.cgi?id=117462 --- Comment #10 from Micha --- Tested with 3.3 as suggested. Rendering with 3.3 does not work at all. LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 Not sure if this is now inherited from OO or not as never worked - but got better in LO. With 3.3 the file the preview test.odp does not even work. In presentation mode the svgs are missing. When the svgs are added again from the filesystem they look absolutely different ( e.g. red (wtf)). However rotation of the defective rendering works in presentation mode. Screenshot will be added -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/qt5
vcl/qt5/Qt5SvpSurface.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit cc237438f6d1c7ee3a391b51402aaa71cd347b6b
Author: Michael Weghorn
AuthorDate: Wed Jun 12 17:07:56 2019 +0200
Commit: Michael Weghorn
CommitDate: Wed Jun 12 23:06:33 2019 +0200
qt5: Make it compile with '-Werror=shadow'
This fixes the following issue for the GCC build with '-Werror=shadow'
in place which does not show up in the default build setup since
compiler flag '-Wno-shadow' is currently being set in
'RepositoryExternal.mk' for qt5 and kde5.
(This will be dropped in a follow-up commit.)
.../libreoffice/vcl/qt5/Qt5SvpSurface.cxx: In constructor
‘cairo::Qt5SvpSurface::Qt5SvpSurface(const CairoSurfaceSharedPtr&)’:
.../libreoffice/vcl/qt5/Qt5SvpSurface.cxx:24:69: error: declaration of
‘m_pSurface’ shadows a member of ‘cairo::Qt5SvpSurface’ [-Werror=shadow]
Qt5SvpSurface::Qt5SvpSurface(const CairoSurfaceSharedPtr& m_pSurface)
^
In file included from .../libreoffice/vcl/qt5/Qt5SvpSurface.cxx:12:
.../libreoffice/vcl/inc/qt5/Qt5SvpSurface.hxx:27:27: note: shadowed
declaration is here
CairoSurfaceSharedPtr m_pSurface;
^~
cc1plus: all warnings being treated as errors
Change-Id: I501657447e02675f7c6b1c9aaca670ba81715590
Reviewed-on: https://gerrit.libreoffice.org/73891
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/vcl/qt5/Qt5SvpSurface.cxx b/vcl/qt5/Qt5SvpSurface.cxx
index 62fa263c3a3c..00f6004bd2a0 100644
--- a/vcl/qt5/Qt5SvpSurface.cxx
+++ b/vcl/qt5/Qt5SvpSurface.cxx
@@ -21,10 +21,10 @@
namespace cairo
{
-Qt5SvpSurface::Qt5SvpSurface(const CairoSurfaceSharedPtr& m_pSurface)
+Qt5SvpSurface::Qt5SvpSurface(const CairoSurfaceSharedPtr& pSurface)
: m_pGraphics(nullptr)
, m_pCairoContext(nullptr)
-, m_pSurface(m_pSurface)
+, m_pSurface(pSurface)
{
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
