[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - RepositoryExternal.mk
RepositoryExternal.mk | 12
1 file changed, 12 deletions(-)
New commits:
commit bed1cab257bdc9f8e1b6fb52fd8dcd531a2e1431
Author: Michael Weghorn
AuthorDate: Wed Jun 12 17:17:07 2019 +0200
Commit: Michael Weghorn
CommitDate: Fri Jun 14 07:58:11 2019 +0200
Drop '-Wno-shadow' previously set for qt5/kde5
The flag has been introduced with commit
9335945c7cb215f387ed1444e28533fac437c6e8 ("KF5 initial VCL plugin")
and was presumably just copy-pasted in commit
4d78cf97d7b1629556df68fc461922fda930d9ec.
The flag should no longer be necessary now; the only issue showing
up after removing the flag was fixed.
Change-Id: I65fe4d12bdf7d5888b75f8a5743bab6979a63295
Reviewed-on: https://gerrit.libreoffice.org/73892
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
(cherry picked from commit 41a644dae966ecb958d1fe56cb14f3c091b0eceb)
Reviewed-on: https://gerrit.libreoffice.org/73996
diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index b039484338a8..a75ca5097b62 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -3092,12 +3092,6 @@ $(call gb_LinkTarget_add_libs,$(1),\
$(KF5_LIBS) \
)
-ifeq ($(COM),GCC)
-$(call gb_LinkTarget_add_cxxflags,$(1),\
- -Wno-shadow \
-)
-endif
-
endef
else # !ENABLE_KDE5
@@ -3126,12 +3120,6 @@ $(call gb_LinkTarget_add_libs,$(1),\
$(QT5_LIBS) \
)
-ifeq ($(COM),GCC)
-$(call gb_LinkTarget_add_cxxflags,$(1),\
- -Wno-shadow \
-)
-endif
-
endef
else # !ENABLE_QT5
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sc/source
sc/source/core/tool/compiler.cxx |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
New commits:
commit 4ca3ac84912ab387b27d3f6c1a288a1ba12eb730
Author: Eike Rathke
AuthorDate: Thu Jun 13 20:25:49 2019 +0200
Commit: Michael Weghorn
CommitDate: Fri Jun 14 07:51:17 2019 +0200
Resolves: tdf#113541 handle external reference in Excel syntax
... not only OOXML. This wasn't only a problem when creating a
reference by clicking or travelling to a cell in the external
document, but also when editing an external reference in Excel_A1
or Excel_R1C1 reference syntax.
Change-Id: Iee3d529ff9834e5013a61c2056238277f33356fe
Reviewed-on: https://gerrit.libreoffice.org/73979
Reviewed-by: Eike Rathke
Tested-by: Jenkins
(cherry picked from commit 69903b5c5f9b9015c88931c0eb8a47b52ea3de12)
Reviewed-on: https://gerrit.libreoffice.org/73988
Reviewed-by: Michael Weghorn
diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index 7ed3845f967e..edb4f9fadb0b 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -2125,11 +2125,14 @@ Label_MaskStateMachine:
}
else if( nMask & ScCharFlags::Char )
{
-// '[' is a special case in OOXML, it can start an external
-// reference ID like [1]Sheet1!A1 that needs to be scanned
+// '[' is a special case in Excel syntax, it can start an
+// external reference, ID in OOXML like [1]Sheet1!A1 or
+// Excel_A1 [filename]Sheet!A1 or Excel_R1C1
+// [filename]Sheet!R1C1 that needs to be scanned
// entirely, or can be ocTableRefOpen, of which the first
// transforms an ocDBArea into an ocTableRef.
-if (c == '[' && FormulaGrammar::isOOXML( meGrammar) &&
eLastOp != ocDBArea && maTableRefs.empty())
+if (c == '[' && FormulaGrammar::isExcelSyntax( meGrammar)
+&& eLastOp != ocDBArea && maTableRefs.empty())
{
nMask &= ~ScCharFlags::Char;
goto Label_MaskStateMachine;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sw/source
sw/source/uibase/shells/textfld.cxx |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
New commits:
commit 6a1248e86feb2722843133c1d75be82c811b9d30
Author: Maxim Monastirsky
AuthorDate: Wed Jun 12 01:32:38 2019 +0300
Commit: Adolfo Jayme Barrientos
CommitDate: Fri Jun 14 07:38:52 2019 +0200
tdf#125146 Disable the reply command in UI
... when the focus isn't inside a comment. That's likely
a regression of 6e463381b43d888a632e652a873f2b5abe7e5458
("lok: Allow to reply to comments using postit id"),
which enabled the command also in the text context.
The current solution is to only enable the command when
lok is active, which is where it's used. This is similar
to what is done in the code nearby for FN_REDLINE_COMMENT.
If that turns out to not be enough (e.g. executing the
command useful outside lok), another possible solution
might be to add FastCall = TRUE; to FN_REPLY in
_textsh.sdi. That will allow executing the command via
api even when disabled in ui.
Change-Id: Ibf2248a82599801af63a169fc2d34b27d080c048
Reviewed-on: https://gerrit.libreoffice.org/73972
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky
(cherry picked from commit 4d11c44673e46b134231ea825c1be36c15f8b263)
Reviewed-on: https://gerrit.libreoffice.org/73994
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/sw/source/uibase/shells/textfld.cxx
b/sw/source/uibase/shells/textfld.cxx
index a71969f6acfb..cc5887255159 100644
--- a/sw/source/uibase/shells/textfld.cxx
+++ b/sw/source/uibase/shells/textfld.cxx
@@ -899,12 +899,16 @@ void SwTextShell::StateField( SfxItemSet )
break;
case FN_REPLY:
+if (!comphelper::LibreOfficeKit::isActive())
+rSet.DisableItem(nWhich);
+break;
+
case FN_POSTIT :
case FN_JAVAEDIT :
{
bool bCurField = false;
pField = rSh.GetCurField();
-if(nWhich == FN_POSTIT || nWhich == FN_REPLY)
+if(nWhich == FN_POSTIT)
bCurField = pField && pField->GetTyp()->Which() ==
SwFieldIds::Postit;
else
bCurField = pField && pField->GetTyp()->Which() ==
SwFieldIds::Script;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sw/source
sw/source/uibase/docvw/AnnotationMenuButton.cxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 630bda1b424ff262d084c000be4a8d266d0f35d8
Author: Maxim Monastirsky
AuthorDate: Fri Jun 7 12:06:13 2019 +0300
Commit: Adolfo Jayme Barrientos
CommitDate: Fri Jun 14 07:38:26 2019 +0200
tdf#125146 Use correct id for reply command item
This was overlooked in commit
a10b4fd2bc08651d47bdb19bb8ab9c1f8f3d4851
("convert annotation menu to .ui").
Change-Id: Ia9e44460394e60f9c2ae767fbb2a07414fa07cf7
Reviewed-on: https://gerrit.libreoffice.org/73971
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky
(cherry picked from commit 1b39bae5debe3bf952449bd7d2910defcea92b9e)
Reviewed-on: https://gerrit.libreoffice.org/73992
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/sw/source/uibase/docvw/AnnotationMenuButton.cxx
b/sw/source/uibase/docvw/AnnotationMenuButton.cxx
index 51a7d809d7cc..c8996bdc3554 100644
--- a/sw/source/uibase/docvw/AnnotationMenuButton.cxx
+++ b/sw/source/uibase/docvw/AnnotationMenuButton.cxx
@@ -102,7 +102,7 @@ void AnnotationMenuButton::MouseButtonDown( const
MouseEvent& rMEvt )
if (mrSidebarWin.IsProtected())
{
-pButtonPopup->EnableItem(FN_REPLY, false);
+pButtonPopup->EnableItem(pButtonPopup->GetItemId("reply"), false);
}
else
{
@@ -118,11 +118,11 @@ void AnnotationMenuButton::MouseButtonDown( const
MouseEvent& rMEvt )
// do not allow to reply to ourself and no answer possible if this
note is in a protected section
if (sAuthor == mrSidebarWin.GetAuthor())
{
-pButtonPopup->EnableItem(FN_REPLY, false);
+pButtonPopup->EnableItem(pButtonPopup->GetItemId("reply"), false);
}
else
{
-pButtonPopup->EnableItem(FN_REPLY);
+pButtonPopup->EnableItem(pButtonPopup->GetItemId("reply"));
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: framework/source
framework/source/fwe/classes/actiontriggerseparatorpropertyset.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit af64c87144bcb951f789553a0490297ec8c4dc38
Author: Andrea Gelmini
AuthorDate: Mon Jun 10 16:56:19 2019 +
Commit: Julien Nabet
CommitDate: Fri Jun 14 07:37:41 2019 +0200
Fix typo
Change-Id: Ibd59292948c23eede5968c4a62df3dca0899d0d5
Reviewed-on: https://gerrit.libreoffice.org/74010
Reviewed-by: Julien Nabet
Tested-by: Julien Nabet
diff --git a/framework/source/fwe/classes/actiontriggerseparatorpropertyset.cxx
b/framework/source/fwe/classes/actiontriggerseparatorpropertyset.cxx
index 5f6700a68a70..d05d8a173160 100644
--- a/framework/source/fwe/classes/actiontriggerseparatorpropertyset.cxx
+++ b/framework/source/fwe/classes/actiontriggerseparatorpropertyset.cxx
@@ -180,7 +180,7 @@ void SAL_CALL
ActionTriggerSeparatorPropertySet::getFastPropertyValue(
{
// Define static member to give structure of properties to baseclass
"OPropertySetHelper".
// "impl_getStaticPropertyDescriptor" is a non exported and static
function, who will define a static propertytable.
-// "rrue" say: Table is sorted by name.
+// "true" indicates: Table is sorted by name.
static OPropertyArrayHelper ourInfoHelper(
impl_getStaticPropertyDescriptor(), true );
return ourInfoHelper;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sfx2/inc
sfx2/inc/autoredactdialog.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e9897b670a129b5ac4c602bc0727de59a2a529c4 Author: Andrea Gelmini AuthorDate: Thu Jun 13 23:11:42 2019 +0200 Commit: Julien Nabet CommitDate: Fri Jun 14 07:36:27 2019 +0200 Fix typo Change-Id: I84170be79725bca9bfd29bd25fdd299af8f56577 Reviewed-on: https://gerrit.libreoffice.org/73989 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/sfx2/inc/autoredactdialog.hxx b/sfx2/inc/autoredactdialog.hxx index bab00cf536a3..3b6b45c99032 100644 --- a/sfx2/inc/autoredactdialog.hxx +++ b/sfx2/inc/autoredactdialog.hxx @@ -141,7 +141,7 @@ public: /** Literally moves targets into the given vector. * At the end of the operation, m_aTableTargets vector becomes empty. * The contents of the given vector will be erased before being filled in. - * Returns true if successfull. + * Returns true if successful. */ bool moveTargets(std::vector>& r_aTargets); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: framework/source
framework/source/accelerators/acceleratorconfiguration.cxx |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit f3559bd58efff190a7b3d02445b75d2bd04a47c1
Author: Andrea Gelmini
AuthorDate: Mon Jun 10 16:56:25 2019 +
Commit: Julien Nabet
CommitDate: Fri Jun 14 07:36:11 2019 +0200
Fix typo
Change-Id: I97b448c65c68df81d195c9790eb13d7bd6bd79a0
Reviewed-on: https://gerrit.libreoffice.org/74005
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/framework/source/accelerators/acceleratorconfiguration.cxx
b/framework/source/accelerators/acceleratorconfiguration.cxx
index f828aaa34dbb..9d68e124d13c 100644
--- a/framework/source/accelerators/acceleratorconfiguration.cxx
+++ b/framework/source/accelerators/acceleratorconfiguration.cxx
@@ -67,7 +67,7 @@ namespace framework
static OUString lcl_getKeyString(const css::awt::KeyEvent& aKeyEvent)
{
-const sal_Int32 nBeginIndex = 4; // "KEY_" is the prefix of a
identifier...
+const sal_Int32 nBeginIndex = 4; // "KEY_" is the prefix of an
identifier...
OUStringBuffer
sKeyBuffer((KeyMapping::get().mapCodeToIdentifier(aKeyEvent.KeyCode)).copy(nBeginIndex));
if ( (aKeyEvent.Modifiers & css::awt::KeyModifier::SHIFT) ==
css::awt::KeyModifier::SHIFT )
@@ -459,7 +459,7 @@ AcceleratorCache&
XMLBasedAcceleratorConfiguration::impl_getCFG(bool bWriteAcces
}
// in case, we have a writeable cache, we use it for reading too!
-// Otherwise the API user can't find its own changes ...
+// Otherwise the API user can't find its own changes...
if (m_pWriteCache)
return *m_pWriteCache;
else
@@ -1296,7 +1296,7 @@ AcceleratorCache&
XCUBasedAcceleratorConfiguration::impl_getCFG(bool bPreferred,
}
// in case, we have a writeable cache, we use it for reading too!
-// Otherwise the API user can't find its own changes ...
+// Otherwise the API user can't find its own changes...
if (m_pPrimaryWriteCache)
return *m_pPrimaryWriteCache;
else
@@ -1313,7 +1313,7 @@ AcceleratorCache&
XCUBasedAcceleratorConfiguration::impl_getCFG(bool bPreferred,
}
// in case, we have a writeable cache, we use it for reading too!
-// Otherwise the API user can't find its own changes ...
+// Otherwise the API user can't find its own changes...
if (m_pSecondaryWriteCache)
return *m_pSecondaryWriteCache;
else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125460] LibreOffice freezes in attempt to open specific docx-file
https://bugs.documentfoundation.org/show_bug.cgi?id=125460 ar...@jankaritech.com changed: What|Removed |Added CC||ar...@jankaritech.com, ||noelgran...@gmail.com --- Comment #3 from ar...@jankaritech.com --- commit that broke the opening of LO completely with the given document. Since this commit the progress bar does not even start moving https://gerrit.libreoffice.org/plugins/gitiles/core/+/848058625c7fad21e2469c95c2a2078678925a5a%5E!/ author Noel Grandin Fri May 24 11:49:44 2019 +0200 committer Noel Grandin Fri May 24 14:20:24 2019 +0200 tree8836a8cd5cb470529bc5609df545da3c138caa25 use vcl::Timer in StatusIndicatorFactory Added CC: to Noel Grandin -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125867] [LOCALHELP] Add a link for the description of hierarchies in a pivot table
https://bugs.documentfoundation.org/show_bug.cgi?id=125867 Markus Elfring changed: What|Removed |Added Blocks||103381 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103381 [Bug 103381] [META] Pivot table (aka Data Pilot) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125460] LibreOffice freezes in attempt to open specific docx-file
https://bugs.documentfoundation.org/show_bug.cgi?id=125460 ar...@jankaritech.com changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125853] Improve indications for folded data groups in a pivot table
https://bugs.documentfoundation.org/show_bug.cgi?id=125853 Markus Elfring changed: What|Removed |Added Blocks||103381 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103381 [Bug 103381] [META] Pivot table (aka Data Pilot) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125864] Safer application of options for each filter criterium in a pivot table
https://bugs.documentfoundation.org/show_bug.cgi?id=125864 Markus Elfring changed: What|Removed |Added Blocks||103381 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103381 [Bug 103381] [META] Pivot table (aka Data Pilot) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103381] [META] Pivot table (aka Data Pilot) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103381 Markus Elfring changed: What|Removed |Added Depends on||125834, 125836, 125853, ||125864, 125867 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=125834 [Bug 125834] Extend context menu in a pivot table with mark actions https://bugs.documentfoundation.org/show_bug.cgi?id=125836 [Bug 125836] Extend context menu in a pivot table with direct change actions https://bugs.documentfoundation.org/show_bug.cgi?id=125853 [Bug 125853] Improve indications for folded data groups in a pivot table https://bugs.documentfoundation.org/show_bug.cgi?id=125864 [Bug 125864] Safer application of options for each filter criterium in a pivot table https://bugs.documentfoundation.org/show_bug.cgi?id=125867 [Bug 125867] [LOCALHELP] Add a link for the description of hierarchies in a pivot table -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125834] Extend context menu in a pivot table with mark actions
https://bugs.documentfoundation.org/show_bug.cgi?id=125834 Markus Elfring changed: What|Removed |Added Blocks||103381 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103381 [Bug 103381] [META] Pivot table (aka Data Pilot) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125836] Extend context menu in a pivot table with direct change actions
https://bugs.documentfoundation.org/show_bug.cgi?id=125836 Markus Elfring changed: What|Removed |Added Blocks||103381 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103381 [Bug 103381] [META] Pivot table (aka Data Pilot) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - framework/source sw/qa
framework/source/accelerators/storageholder.cxx |2 +-
sw/qa/extras/ooxmlexport/ooxmlexport2.cxx |5 +
2 files changed, 6 insertions(+), 1 deletion(-)
New commits:
commit 21c5ef43ee51b4c9f4181b59a8926a48ea35e651
Author: Andrea Gelmini
AuthorDate: Mon Jun 10 16:56:23 2019 +
Commit: Julien Nabet
CommitDate: Fri Jun 14 07:23:46 2019 +0200
Fix typo
Change-Id: I5e6ac32d6a0fca10362aa6a07186101e71e398eb
Reviewed-on: https://gerrit.libreoffice.org/74006
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/framework/source/accelerators/storageholder.cxx
b/framework/source/accelerators/storageholder.cxx
index ca807eabf684..567c7af65220 100644
--- a/framework/source/accelerators/storageholder.cxx
+++ b/framework/source/accelerators/storageholder.cxx
@@ -105,7 +105,7 @@ css::uno::Reference< css::embed::XStorage >
StorageHolder::openPath(const OUStri
aReadLock.reset();
// If we found an already open storage ... we must increase
-// its use count. Otherwise it will may be closed to early :-)
+// its use count. Otherwise it will may be closed too early :-)
TPath2StorageInfo::iterator pCheck = m_lStorages.find(sCheckPath);
TStorageInfo* pInfo = nullptr;
if (pCheck != m_lStorages.end())
commit eec6989574a1bc51ac5eb9c764d4d6b5aa8bbf9b
Author: Justin Luth
AuthorDate: Thu Jun 13 13:01:44 2019 +0300
Commit: Justin Luth
CommitDate: Fri Jun 14 07:23:24 2019 +0200
add unit test to ensure revisionView is not added where unneeded
related to tdf#89991.
This is just a fail-safe to ensure that we don't start hiding
"show changes" where we don't intend to.
The default for a document that has recorded changes is to
show the markup.
Change-Id: I8c8b50b7947b9eea1e6dbedcbed091b2af9b5e87
Reviewed-on: https://gerrit.libreoffice.org/73951
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport2.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport2.cxx
index 6090a0591bf4..2f7955c6c41e 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport2.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport2.cxx
@@ -596,6 +596,11 @@ DECLARE_OOXMLEXPORT_TEST(testFdo64826, "fdo64826.docx")
{
// 'Track-Changes' (Track Revisions) wasn't exported.
CPPUNIT_ASSERT_EQUAL(true, getProperty(mxComponent,
"RecordChanges"));
+// 'Show-Changes' should not be exported - default is true.
+if (xmlDocPtr pXmlSettings = parseExport("word/settings.xml"))
+{
+assertXPath(pXmlSettings, "/w:settings/w:revisionView", 0);
+}
}
DECLARE_OOXMLEXPORT_TEST(testPageBackground, "page-background.docx")
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: framework/source
framework/source/classes/framecontainer.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 9ddda67db9bae50d20b093a39e4b7b52e8351ae4
Author: Andrea Gelmini
AuthorDate: Mon Jun 10 16:56:22 2019 +
Commit: Julien Nabet
CommitDate: Fri Jun 14 07:22:55 2019 +0200
Fix typo
Change-Id: Iab0b5ce94c090f93260c9b29519d41426913fc5d
Reviewed-on: https://gerrit.libreoffice.org/74007
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/framework/source/classes/framecontainer.cxx
b/framework/source/classes/framecontainer.cxx
index 94893ce3198a..f1d7fd1ea018 100644
--- a/framework/source/classes/framecontainer.cxx
+++ b/framework/source/classes/framecontainer.cxx
@@ -164,7 +164,7 @@ css::uno::Reference< css::frame::XFrame >
FrameContainer::operator[]( sal_uInt32
try
{
// Get element form container WITH automatic test of ranges!
-// If index not valid, a out_of_range exception is thrown.
+// If index not valid, an out_of_range exception is thrown.
SolarMutexGuard g;
xFrame = m_aContainer.at( nIndex );
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125857] Improve indications for excluded data in a pivot table
https://bugs.documentfoundation.org/show_bug.cgi?id=125857 Markus Elfring changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #2 from Markus Elfring --- (In reply to Roman Kuznetsov from comment #1) * How often would you like to see in the graphical user interface that filtered data are presented by a specific pivot table? * Can the display of filter criteria be helpful besides the computation report? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: framework/source
framework/source/dispatch/dispatchprovider.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit bef53853a5f6df36dbd4c0a71ce1051d795390ad Author: Andrea Gelmini AuthorDate: Mon Jun 10 16:56:20 2019 + Commit: Julien Nabet CommitDate: Fri Jun 14 07:12:53 2019 +0200 Fix typo Change-Id: I168842ab68c8d4c3066786d9bd1beba935b9aa01 Reviewed-on: https://gerrit.libreoffice.org/74009 Reviewed-by: Julien Nabet Tested-by: Julien Nabet diff --git a/framework/source/dispatch/dispatchprovider.cxx b/framework/source/dispatch/dispatchprovider.cxx index 480953f0cb3c..57fcb9972d0e 100644 --- a/framework/source/dispatch/dispatchprovider.cxx +++ b/framework/source/dispatch/dispatchprovider.cxx @@ -149,7 +149,7 @@ css::uno::Sequence< css::uno::Reference< css::frame::XDispatch > > SAL_CALL Disp /** @short helper for queryDispatch() @descr Every member of the frame tree (frame, desktop) must handle such request -in another way. So we implement different specialized methods for every one. +in another way. So we implement different specialized methods for everyone. @threadsafe yes */ @@ -393,7 +393,7 @@ css::uno::Reference< css::frame::XDispatch > DispatchProvider::implts_queryFrame // Attention: Found target is our own owner frame! // Don't ask him for his dispatcher. We know it already - it's our self dispatch helper. // Otherwise we can start a never ending recursiv call. Why? -// Somewere called our owner frame - he called some interceptor objects - and may by this dispatch provider +// Somewhere called our owner frame - he called some interceptor objects - and may by this dispatch provider // is called. If wa use queryDispatch() on our owner frame again - we start this call stack again ... and again. if (xFoundFrame==xFrame) xDispatcher = implts_getOrCreateDispatchHelper( E_SELFDISPATCHER, xFrame ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: filter/source
filter/source/xslt/import/wordml/wordml2ooo_field.xsl |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9283da0c028c112e82ed2b2fa37394a5fc004fad Author: Andrea Gelmini AuthorDate: Mon Jun 10 16:56:32 2019 + Commit: Julien Nabet CommitDate: Fri Jun 14 07:12:13 2019 +0200 Fix typo Change-Id: I679707594b40e35ea5c503c0c0a6f37520eedce6 Reviewed-on: https://gerrit.libreoffice.org/74000 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/filter/source/xslt/import/wordml/wordml2ooo_field.xsl b/filter/source/xslt/import/wordml/wordml2ooo_field.xsl index 0fae0efa4ccd..590a97283662 100644 --- a/filter/source/xslt/import/wordml/wordml2ooo_field.xsl +++ b/filter/source/xslt/import/wordml/wordml2ooo_field.xsl @@ -1228,7 +1228,7 @@ - + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: framework/source
framework/source/classes/taskcreator.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 9bd21bbe0d1bc3462aa86066c96dcf184aa2bdf7
Author: Andrea Gelmini
AuthorDate: Mon Jun 10 16:56:21 2019 +
Commit: Julien Nabet
CommitDate: Fri Jun 14 07:10:21 2019 +0200
Fix typo
Change-Id: Ibd90e56fb863d65204373d1cc57efc1116a865b5
Reviewed-on: https://gerrit.libreoffice.org/74008
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/framework/source/classes/taskcreator.cxx
b/framework/source/classes/taskcreator.cxx
index f9b6cac2842f..3ff36e0e9734 100644
--- a/framework/source/classes/taskcreator.cxx
+++ b/framework/source/classes/taskcreator.cxx
@@ -79,7 +79,7 @@ css::uno::Reference< css::frame::XFrame >
TaskCreator::createTask( const OUStrin
catch(const css::uno::Exception&)
{}
-// no catch here ... without an task creator service we can't open ANY
document window within the office.
+// no catch here ... without a task creator service we can't open ANY
document window within the office.
// That's IMHO not a good idea. Then we should accept the stacktrace
showing us the real problem.
// BTW: The used fallback creator service
(IMPLEMENTATIONNAME_FWK_TASKCREATOR) is implemented in the same
// library then these class here ... Why we should not be able to create
it ?
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: framework/qa
framework/qa/complex/contextMenuInterceptor/ContextMenuInterceptor.java |2
+-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 3a6b10e0bc8dde60fde8e643930fa2e8d89f5ee4
Author: Andrea Gelmini
AuthorDate: Mon Jun 10 16:56:29 2019 +
Commit: Julien Nabet
CommitDate: Fri Jun 14 07:09:55 2019 +0200
Fix typo
Change-Id: I6933975c919f32cfda38624fc65b59b1b0ef821e
Reviewed-on: https://gerrit.libreoffice.org/74003
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git
a/framework/qa/complex/contextMenuInterceptor/ContextMenuInterceptor.java
b/framework/qa/complex/contextMenuInterceptor/ContextMenuInterceptor.java
index fdf2259c2f88..7496b58e080b 100644
--- a/framework/qa/complex/contextMenuInterceptor/ContextMenuInterceptor.java
+++ b/framework/qa/complex/contextMenuInterceptor/ContextMenuInterceptor.java
@@ -111,7 +111,7 @@ public class ContextMenuInterceptor implements
XContextMenuInterceptor
catch (com.sun.star.beans.UnknownPropertyException ex)
{
// do something useful
-// we used a unknown property
+// we used an unknown property
}
catch (com.sun.star.lang.IndexOutOfBoundsException ex)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 68755] Need field for first/last ${referencetext} for a style (Live header)
https://bugs.documentfoundation.org/show_bug.cgi?id=68755 Dieter Praas changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 68755] Need field for first/last ${referencetext} for a style (Live header)
https://bugs.documentfoundation.org/show_bug.cgi?id=68755 Dieter Praas changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125673] KDE5: Calc sheet tab's context menu has unexpected highlighting
https://bugs.documentfoundation.org/show_bug.cgi?id=125673 Commit Notification changed: What|Removed |Added Whiteboard|target:6.4.0 target:6.3.0.1 |target:6.4.0 target:6.3.0.1 ||target:6.2.5 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125907] Libre Office (Writer) Text Selection
https://bugs.documentfoundation.org/show_bug.cgi?id=125907 raal changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||r...@post.cz Ever confirmed|0 |1 --- Comment #1 from raal --- Hello, Thank you for filing the bug. For the test, could you rename your LibreOffice directory profile (see https://wiki.documentfoundation.org/UserProfile) and give it a new try? Thank you -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125673] KDE5: Calc sheet tab's context menu has unexpected highlighting
https://bugs.documentfoundation.org/show_bug.cgi?id=125673 --- Comment #10 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/5ee408eb4c9f55d3438426290e91ac31d04821de%5E%21 tdf#125673 KDE5 implement a KDE5SalVirtualDevice It will be available in 6.2.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/headless vcl/inc vcl/source vcl/unx
vcl/headless/svpvd.cxx| 10 ++---
vcl/inc/headless/svpvd.hxx|5
vcl/source/window/bufferdevice.cxx|2 -
vcl/unx/kde5/KDE5SalGraphics.cxx |2 -
vcl/unx/kde5/KDE5SalInstance.cxx | 18 -
vcl/unx/kde5/KDE5SalInstance.hxx |4 +++
vcl/unx/kde5/KDE5SalVirtualDevice.hxx | 36 ++
7 files changed, 71 insertions(+), 6 deletions(-)
New commits:
commit 5ee408eb4c9f55d3438426290e91ac31d04821de
Author: Jan-Marek Glogowski
AuthorDate: Fri Jun 7 19:09:18 2019 +0200
Commit: Michael Weghorn
CommitDate: Fri Jun 14 06:09:43 2019 +0200
tdf#125673 KDE5 implement a KDE5SalVirtualDevice
We just need AcquireGraphics() to return a KDE5Graphics.
Otherwise the BufferDevice's SVP will use a SvpSalGraphics
instead of the KDE5Graphics, which knows about Qt's theming.
Reviewed-on: https://gerrit.libreoffice.org/73673
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
(cherry picked from commit 2cb6a591b643a0f65dc58f060f60cc707ad3589c)
Reviewed-on: https://gerrit.libreoffice.org/73722
Change-Id: I0ea646df260f2067d61c753f03dee01a003f382a
Reviewed-on: https://gerrit.libreoffice.org/73963
Reviewed-by: Michael Weghorn
Tested-by: Jenkins
diff --git a/vcl/headless/svpvd.cxx b/vcl/headless/svpvd.cxx
index eeccf2c014a9..a1e415739d6b 100644
--- a/vcl/headless/svpvd.cxx
+++ b/vcl/headless/svpvd.cxx
@@ -45,14 +45,18 @@ SvpSalVirtualDevice::~SvpSalVirtualDevice()
cairo_surface_destroy(m_pRefSurface);
}
-SalGraphics* SvpSalVirtualDevice::AcquireGraphics()
+SvpSalGraphics* SvpSalVirtualDevice::AddGraphics(SvpSalGraphics* pGraphics)
{
-SvpSalGraphics* pGraphics = new SvpSalGraphics();
pGraphics->setSurface(m_pSurface, m_aFrameSize);
-m_aGraphics.push_back( pGraphics );
+m_aGraphics.push_back(pGraphics);
return pGraphics;
}
+SalGraphics* SvpSalVirtualDevice::AcquireGraphics()
+{
+return AddGraphics(new SvpSalGraphics());
+}
+
void SvpSalVirtualDevice::ReleaseGraphics( SalGraphics* pGraphics )
{
m_aGraphics.erase(std::remove(m_aGraphics.begin(), m_aGraphics.end(),
dynamic_cast(pGraphics)), m_aGraphics.end());
diff --git a/vcl/inc/headless/svpvd.hxx b/vcl/inc/headless/svpvd.hxx
index 776cee7cde15..3da74b5e1ba8 100644
--- a/vcl/inc/headless/svpvd.hxx
+++ b/vcl/inc/headless/svpvd.hxx
@@ -21,6 +21,8 @@
#define INCLUDED_VCL_INC_HEADLESS_SVPVD_HXX
#include
+#include
+#include
#include
@@ -35,6 +37,9 @@ class VCL_DLLPUBLIC SvpSalVirtualDevice : public
SalVirtualDevice
basegfx::B2IVector m_aFrameSize;
std::vector< SvpSalGraphics* > m_aGraphics;
+protected:
+SvpSalGraphics* AddGraphics(SvpSalGraphics* aGraphics);
+
public:
SvpSalVirtualDevice(DeviceFormat eFormat, cairo_surface_t* pRefSurface);
virtual ~SvpSalVirtualDevice() override;
diff --git a/vcl/source/window/bufferdevice.cxx
b/vcl/source/window/bufferdevice.cxx
index 5db4cfff458a..d1480588d48f 100644
--- a/vcl/source/window/bufferdevice.cxx
+++ b/vcl/source/window/bufferdevice.cxx
@@ -12,7 +12,7 @@
namespace vcl
{
BufferDevice::BufferDevice(const VclPtr& pWindow,
vcl::RenderContext& rRenderContext)
-: m_pBuffer(VclPtr::Create())
+: m_pBuffer(VclPtr::Create(rRenderContext))
, m_pWindow(pWindow)
, m_rRenderContext(rRenderContext)
{
diff --git a/vcl/unx/kde5/KDE5SalGraphics.cxx b/vcl/unx/kde5/KDE5SalGraphics.cxx
index 6e30b9599740..268f8331f7e7 100644
--- a/vcl/unx/kde5/KDE5SalGraphics.cxx
+++ b/vcl/unx/kde5/KDE5SalGraphics.cxx
@@ -40,7 +40,7 @@ static void QImage2BitmapBuffer(QImage* pImg, BitmapBuffer*
pBuf)
}
KDE5SalGraphics::KDE5SalGraphics(Qt5Frame* pFrame)
-: Qt5SvpGraphics(pFrame->GetQWidget())
+: Qt5SvpGraphics(pFrame ? pFrame->GetQWidget() : nullptr)
, m_pFrame(pFrame)
{
}
diff --git a/vcl/unx/kde5/KDE5SalInstance.cxx b/vcl/unx/kde5/KDE5SalInstance.cxx
index cbbf40f87a4d..96d1501cca19 100644
--- a/vcl/unx/kde5/KDE5SalInstance.cxx
+++ b/vcl/unx/kde5/KDE5SalInstance.cxx
@@ -35,7 +35,7 @@
#include "KDE5FilePicker.hxx"
#include "KDE5SalData.hxx"
#include "KDE5SalInstance.hxx"
-#include "KDE5SalFrame.hxx"
+#include "KDE5SalVirtualDevice.hxx"
using namespace com::sun::star;
@@ -89,6 +89,22 @@ KDE5SalInstance::createFolderPicker(const
uno::Reference
bool KDE5SalInstance::IsMainThread() const { return qApp->thread() ==
QThread::currentThread(); }
+std::unique_ptr
KDE5SalInstance::CreateVirtualDevice(SalGraphics* pGraphics,
+ long&
nDX, long& nDY,
+
DeviceFormat eFormat,
+ const
SystemGraphicsData*)
+{
+std::unique_ptr pVD;
+assert(pGraphics);
+RunInMainThread([&]() {
+KDE5SalGraphics* pKDE5Graphics =
[Libreoffice-bugs] [Bug 107742] [META] Form control bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107742 raal changed: What|Removed |Added Depends on||125598 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=125598 [Bug 125598] FILESAVE calc scrollbars don't save correctly in ms formats -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125598] FILESAVE calc scrollbars don't save correctly in ms formats
https://bugs.documentfoundation.org/show_bug.cgi?id=125598 raal changed: What|Removed |Added Blocks||107742 Keywords||filter:xlsx Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107742 [Bug 107742] [META] Form control bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104309] Scrollbar form element is lost entirely when saving as xlsx
https://bugs.documentfoundation.org/show_bug.cgi?id=104309 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #6 from raal --- Please retest. See bug 125598 - scrollbar is not missing, but doesn't works in excel -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125598] FILESAVE calc scrollbars don't save correctly in ms formats
https://bugs.documentfoundation.org/show_bug.cgi?id=125598 raal changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #9 from raal --- Confirm with Version: 6.3.0.0.beta1+ Build ID: 4904391e125eb66304a5c029def8d4c1a150952d CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; in 4.1 is slider completely missing in LO. In 6.3 the slider is visible in LO, but in excel2010 error message "Excel completed file level validation and repair. Some parts of this workbook may have been repaired or discarded" and slider is removed upon open. Steps: open file save as xlsx -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125460] LibreOffice freezes in attempt to open specific docx-file
https://bugs.documentfoundation.org/show_bug.cgi?id=125460 ar...@jankaritech.com changed: What|Removed |Added CC||t...@libreoffice.org --- Comment #2 from ar...@jankaritech.com --- Regression introduced by: https://gerrit.libreoffice.org/plugins/gitiles/core/+/3272c1eb5563f3bda2caa24f32b1018372622109%5E!/ author Thorsten Behrens Mon Oct 01 03:21:59 2018 +0200 committer Thorsten Behrens Mon Jan 07 17:49:44 2019 +0100 treeb4b948fd36ed53b1d8399babf2dbe701469da412 parent 5dfd5755c709e91d2903bd7be4582f7832e89780 related tdf#100074: prepare group shapes text input via writerfilter Bisected with: bibisect-linux64-6.3 Added CC: to Thorsten Behrens Since this commit the file cannot be opened, but the load bar does do some progress. In the versions that have been reported initially the progress bar does not move at all. Will bibisect again to find that point -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125910] Not calculating formula in existing sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=125910 raal changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||r...@post.cz Ever confirmed|0 |1 --- Comment #1 from raal --- Hello, Thank you for filing the bug. Please send us a sample document, as this makes it easier for us to verify the bug. I have set the bug's status to 'NEEDINFO', so please do change it back to 'UNCONFIRMED' once you have attached a document. (Please note that the attachment will be public, remove any sensitive information before attaching it.) How can I eliminate confidential data from a sample document? https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F Thank you -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70641] No connection to KDE address book possible (see comment 10)
https://bugs.documentfoundation.org/show_bug.cgi?id=70641 --- Comment #17 from Buovjaga --- (In reply to Jan-Marek Glogowski from comment #16) > IMH(In reply to Julien Nabet from comment #15) > > (In reply to Buovjaga from comment #14) > > > Comment 10 explains things, so let's make it clear in the summary. > > > > Comment 10 is from 2015. Since we dumped kde4, I don't think we should try > > to implement kde4 address book management. > > So I'd be ok with Robert for WONTFIX > > (just my personal opinion) > > This is not about a particular KDE version. IMHO KDE PIM in KDE3 was quite > popular, so someone implemented a DB driver to access its address book from > LO. In KDE4 - still IMHO - PIM was a disaster to use; I gave up on it. Now > there is KDE5. I have no idea about the quality of PIM in there. > > As it stands some functionality was removed from LO, as it became obsoleted > and nobody was interested in porting it to a newer version of KDE. Somebody > might want to implement a DB driver for KDE5, so I think an enhancement > report is still valid. Yep, was coming here to say KDE5 is still valid. https://userbase.kde.org/KAddressBook PIM is still being actively worked on: https://www.dvratil.cz/2019/05/march-and-april-in-kde-pim/ Quote: "KAddressBook Volker also worked on preparing the KContacts library, a vCard standard implementation, to be moved to KDE Frameworks alongside KCalCore. You can read about this on his blog as well. Improvements As part of his code cleanup, Volker has removed the DataMatrix from contact display, so we only display the QR code now (Volker Krause, KDE Applications 19.08), and did massive clean up of the contact display code. When displaying contact address on a map, KAddressBook now defaults to OpenStreetMaps (Volker Krause, KDE Applications 19.08). Thanks to Laurent Montel it is now also possible to send SMS messages from KAddressBook through KDE Connect (KDE Applications 19.08). Bugfixes Fixed dialing contact’s phone-number from KAddressBook through KDE Connect (Volker Krause, D20353)" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 68755] Need field for first/last ${referencetext} for a style (Live header)
https://bugs.documentfoundation.org/show_bug.cgi?id=68755 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 120041] Can't select line type on cell properties side panel
https://bugs.documentfoundation.org/show_bug.cgi?id=120041 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125595] FORMATTING: Validity cell range with invisible characters (e.g. newline) stripped
https://bugs.documentfoundation.org/show_bug.cgi?id=125595 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51966] Format brush tool moves selection anchor to a random(?) cell
https://bugs.documentfoundation.org/show_bug.cgi?id=51966 --- Comment #12 from QA Administrators --- Dear OfficeUser, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 68755] Need field for first/last ${referencetext} for a style (Live header)
https://bugs.documentfoundation.org/show_bug.cgi?id=68755 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 106044] EDITING: The table borders dialog doesn't preview/show the top border of the selected table row
https://bugs.documentfoundation.org/show_bug.cgi?id=106044 --- Comment #5 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125286] FIREBIRD - Base not usable under Windows account with Chinese user name (UTF character support)
https://bugs.documentfoundation.org/show_bug.cgi?id=125286 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125485] inserting ne TextField.URL failed with expection __main__.IllegalArgumentException
https://bugs.documentfoundation.org/show_bug.cgi?id=125485 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125596] DOCX: Writer misidentify text language (and appropriate font) in MS Word file (MSO2019)
https://bugs.documentfoundation.org/show_bug.cgi?id=125596 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68755] Need field for first/last ${referencetext} for a style (Live header)
https://bugs.documentfoundation.org/show_bug.cgi?id=68755 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120041] Can't select line type on cell properties side panel
https://bugs.documentfoundation.org/show_bug.cgi?id=120041 --- Comment #5 from QA Administrators --- Dear Tamás Zolnai, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68755] Need field for first/last ${referencetext} for a style (Live header)
https://bugs.documentfoundation.org/show_bug.cgi?id=68755 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53298] TABLE borders do not terminate correctly when mixing border types.
https://bugs.documentfoundation.org/show_bug.cgi?id=53298 --- Comment #11 from QA Administrators --- Dear rm42, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125913] Off-Line Help inaccessible - Always opens web browser
https://bugs.documentfoundation.org/show_bug.cgi?id=125913 V Stuart Foote changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG CC||vstuart.fo...@utsa.edu --- Comment #1 from V Stuart Foote --- You'll notice the "off-line" help has been refactored to use your system default Web browser rather than a OOo era HTML view mode. You can tell by local on file system URLs', e.g. file:///C:/Program%20Files/LibreOffice/help/en-UK on Windows builds. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - framework/qa
framework/qa/complex/api_internal/CheckAPI.java |2 +-
framework/qa/complex/path_settings/PathSettingsTest.java |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit c067c56c5b7067f712519f96c03bf0015465a195
Author: Andrea Gelmini
AuthorDate: Mon Jun 10 16:56:26 2019 +
Commit: Jens Carl
CommitDate: Fri Jun 14 04:08:16 2019 +0200
Fix typo
Change-Id: Id0f271e577732b8960228157d2e08fb04cdcae0a
Reviewed-on: https://gerrit.libreoffice.org/74004
Tested-by: Jenkins
Reviewed-by: Jens Carl
diff --git a/framework/qa/complex/path_settings/PathSettingsTest.java
b/framework/qa/complex/path_settings/PathSettingsTest.java
index c9aa25a666c1..236b6e46695a 100644
--- a/framework/qa/complex/path_settings/PathSettingsTest.java
+++ b/framework/qa/complex/path_settings/PathSettingsTest.java
@@ -110,7 +110,7 @@ public class PathSettingsTest
aListOfWorkingProperty = new ArrayList();
-// get intitial values and create new ones
+// get initial values and create new ones
for (int i = 0; i < xPropertyInfoOfPathSettings.length; i++)
{
final String sName = xPropertyInfoOfPathSettings[i].Name;
commit 53fa488104b8723ba6de2063338e14544cb13da3
Author: Andrea Gelmini
AuthorDate: Mon Jun 10 16:56:30 2019 +
Commit: Jens Carl
CommitDate: Fri Jun 14 04:07:54 2019 +0200
Fix typo
Change-Id: I7c6f8478b95fa3904b1cec0cf5dbfc6885fd2810
Reviewed-on: https://gerrit.libreoffice.org/74002
Tested-by: Jenkins
Reviewed-by: Jens Carl
diff --git a/framework/qa/complex/api_internal/CheckAPI.java
b/framework/qa/complex/api_internal/CheckAPI.java
index 8ee5b1f06c05..cd17f4a6917f 100644
--- a/framework/qa/complex/api_internal/CheckAPI.java
+++ b/framework/qa/complex/api_internal/CheckAPI.java
@@ -41,7 +41,7 @@ import com.sun.star.uno.UnoRuntime;
/**
* This test executes the API tests internally in LibreOffice. Prerequisite is
- * that a OOoRunner.jar is registered inside of LibreOffice. Adjust the joblist
+ * that an OOoRunner.jar is registered inside of LibreOffice. Adjust the
joblist
* inside of the CheckAPI.props to determine which tests will be executed.
*/
public class CheckAPI {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: framework/inc
framework/inc/services/desktop.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f3fe9ddfcfb7bae86f53eb26fb65e41b5946af2b Author: Andrea Gelmini AuthorDate: Mon Jun 10 16:56:31 2019 + Commit: Jens Carl CommitDate: Fri Jun 14 04:07:33 2019 +0200 Fix typo Change-Id: I3a1ac3d9799629ddeaeebea1ad152c0f4deaa592 Reviewed-on: https://gerrit.libreoffice.org/74001 Tested-by: Jenkins Reviewed-by: Jens Carl diff --git a/framework/inc/services/desktop.hxx b/framework/inc/services/desktop.hxx index faf93a6e0126..fd952e74f348 100644 --- a/framework/inc/services/desktop.hxx +++ b/framework/inc/services/desktop.hxx @@ -382,7 +382,7 @@ class Desktop : private cppu::BaseMutex, */ bool m_bIsTerminated; -/** when true, the call came form session manager +/** when true, the call came from session manager * the method is Desktop::terminateQuickstarterToo() * this the only one place where set this to true * In this case, when one frame break, not make ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - 2 commits - sc/source
sc/source/core/tool/compiler.cxx |9 ++---
sc/source/ui/app/inputhdl.cxx| 23 ---
2 files changed, 18 insertions(+), 14 deletions(-)
New commits:
commit eb7729d7740b2b16a7111d8fec15b268a03a1f44
Author: Eike Rathke
AuthorDate: Thu Jun 13 21:41:14 2019 +0200
Commit: Eike Rathke
CommitDate: Fri Jun 14 02:49:35 2019 +0200
Related: tdf#113541 use reference syntax of the document being edited
When creating a formula referencing an external document by
travelling (clicking in) to that document, the reference was
created using the reference syntax of the referenced document,
which may be different if the syntax was changed for only one of
the documents after being opened. Use the reference syntax of the
document being edited instead so the created reference is correct
and can be compiled.
Change-Id: I07d0ce9cd911ac8e62576b4cdabdfd2569336fbf
Reviewed-on: https://gerrit.libreoffice.org/73983
Reviewed-by: Eike Rathke
Tested-by: Jenkins
(cherry picked from commit 2d36e43d3d3ac69f4cacd532308cfc8c81982864)
Reviewed-on: https://gerrit.libreoffice.org/73995
diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx
index cadf157bdc0d..eb8142a913cf 100644
--- a/sc/source/ui/app/inputhdl.cxx
+++ b/sc/source/ui/app/inputhdl.cxx
@@ -3046,15 +3046,16 @@ void ScInputHandler::SetReference( const ScRange& rRef,
const ScDocument* pDoc )
{
HideTip();
-bool bOtherDoc = ( pRefViewSh &&
-pRefViewSh->GetViewData().GetDocument() != pDoc );
-if (bOtherDoc)
-if (!pDoc->GetDocumentShell()->HasName())
-{
-// References to unnamed document; that doesn't work
-// SetReference should not be called, then
-return;
-}
+const ScDocument* pThisDoc = nullptr;
+bool bOtherDoc = (pRefViewSh && ((pThisDoc =
pRefViewSh->GetViewData().GetDocument()) != pDoc));
+if (bOtherDoc && !pDoc->GetDocumentShell()->HasName())
+{
+// References to unnamed document; that doesn't work
+// SetReference should not be called, then
+return;
+}
+if (!pThisDoc)
+pThisDoc = pDoc;
UpdateActiveView();
if (!pTableView && !pTopView)
@@ -3089,9 +3090,9 @@ void ScInputHandler::SetReference( const ScRange& rRef,
const ScDocument* pDoc )
}
}
-// Create string from reference
+// Create string from reference, in the syntax of the document being
edited.
OUString aRefStr;
-const ScAddress::Details aAddrDetails( pDoc, aCursorPos );
+const ScAddress::Details aAddrDetails( pThisDoc, aCursorPos );
if (bOtherDoc)
{
// Reference to other document
commit 6e68110a916500a92a15357b6bf90e62dc631a01
Author: Eike Rathke
AuthorDate: Thu Jun 13 20:25:49 2019 +0200
Commit: Eike Rathke
CommitDate: Fri Jun 14 02:49:21 2019 +0200
Resolves: tdf#113541 handle external reference in Excel syntax
... not only OOXML. This wasn't only a problem when creating a
reference by clicking or travelling to a cell in the external
document, but also when editing an external reference in Excel_A1
or Excel_R1C1 reference syntax.
Change-Id: Iee3d529ff9834e5013a61c2056238277f33356fe
Reviewed-on: https://gerrit.libreoffice.org/73979
Reviewed-by: Eike Rathke
Tested-by: Jenkins
(cherry picked from commit 69903b5c5f9b9015c88931c0eb8a47b52ea3de12)
Reviewed-on: https://gerrit.libreoffice.org/73987
diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index 320198151ef3..23788b707d3a 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -2134,11 +2134,14 @@ Label_MaskStateMachine:
}
else if( nMask & ScCharFlags::Char )
{
-// '[' is a special case in OOXML, it can start an external
-// reference ID like [1]Sheet1!A1 that needs to be scanned
+// '[' is a special case in Excel syntax, it can start an
+// external reference, ID in OOXML like [1]Sheet1!A1 or
+// Excel_A1 [filename]Sheet!A1 or Excel_R1C1
+// [filename]Sheet!R1C1 that needs to be scanned
// entirely, or can be ocTableRefOpen, of which the first
// transforms an ocDBArea into an ocTableRef.
-if (c == '[' && FormulaGrammar::isOOXML( meGrammar) &&
eLastOp != ocDBArea && maTableRefs.empty())
+if (c == '[' && FormulaGrammar::isExcelSyntax( meGrammar)
+&& eLastOp != ocDBArea && maTableRefs.empty())
{
nMask &= ~ScCharFlags::Char;
goto Label_MaskStateMachine;
___
Libreoffice-commits mailing list
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - filter/source
filter/source/xslt/odf2xhtml/export/xhtml/opendoc2xhtml.xsl | 18 ++-- 1 file changed, 9 insertions(+), 9 deletions(-) New commits: commit 9782b15a45de5bc64a31fd61cb3385cf5dcd2deb Author: Matthias Seidel AuthorDate: Thu Jun 13 22:10:33 2019 + Commit: Matthias Seidel CommitDate: Thu Jun 13 22:10:33 2019 + Changed branding OpenOffice.org -> Apache OpenOffice, fixed typos diff --git a/filter/source/xslt/odf2xhtml/export/xhtml/opendoc2xhtml.xsl b/filter/source/xslt/odf2xhtml/export/xhtml/opendoc2xhtml.xsl index 2e566b52605f..df04b39d94dc 100644 --- a/filter/source/xslt/odf2xhtml/export/xhtml/opendoc2xhtml.xsl +++ b/filter/source/xslt/odf2xhtml/export/xhtml/opendoc2xhtml.xsl @@ -1,6 +1,6 @@ http://www.w3.org/1999/XSL/Transform; @@ -103,7 +103,7 @@ +This URL session is used for example when links to graphics are created by XSLT. Otherwise the user has to log in again for every graphic he likes to see. --> @@ -113,12 +113,12 @@ - + - @@ -150,7 +150,7 @@ - This file was converted to xhtml by OpenOffice.org - see http://xml.openoffice.org/odf2xhtml for more info. + This file was converted to xhtml by Apache OpenOffice - see https://xml.openoffice.org/odf2xhtml for more info. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 108988] [META] Validity-related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108988 Aron Budea changed: What|Removed |Added Depends on||125914 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=125914 [Bug 125914] XLSX Validation with cells referencing themselves always gives error -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125914] New: XLSX Validation with cells referencing themselves always gives error
https://bugs.documentfoundation.org/show_bug.cgi?id=125914 Bug ID: 125914 Summary: XLSX Validation with cells referencing themselves always gives error Product: LibreOffice Version: 4.0.0.3 release Hardware: All OS: All Status: UNCONFIRMED Keywords: filter:xlsx Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@caesar.elte.hu Blocks: 108897, 108988 Created attachment 152179 --> https://bugs.documentfoundation.org/attachment.cgi?id=152179=edit Sample XLSX Open the attached spreadsheet, created in Excel. In the B column, next to the description validation criteria is set with "equal to" setting that refers to the cell itself. This means only the basic criteria is taken into account (whole number, decimal, date, time), and any such entry can be entered. Enter values like: - 645789 - -1956.56 - 1999-08-31 - 23:59 These are all allowed in Excel, but none of them is allowed in Calc. Note that in Excel the value criteria can be a cell reference, however Calc shows cell references as values (eg. "B1" instead of "=B1"), and doesn't allow selecting a referenced cell. Observed using LO 6.4.0.0.alpha0+ (95462a02a3aee1e3e7f9aa8fc50ba25fee3fa592), 4.0.0.3 / Windows 7. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108897 [Bug 108897] [META] XLSX (OOXML) bug tracker https://bugs.documentfoundation.org/show_bug.cgi?id=108988 [Bug 108988] [META] Validity-related bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108897] [META] XLSX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=108897 Aron Budea changed: What|Removed |Added Depends on||125914 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=125914 [Bug 125914] XLSX Validation with cells referencing themselves always gives error -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125912] Pasted Style not Formatting Properly
https://bugs.documentfoundation.org/show_bug.cgi?id=125912 --- Comment #2 from pmb --- Created attachment 152178 --> https://bugs.documentfoundation.org/attachment.cgi?id=152178=edit shows difference in text pasted and typed in -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125913] New: Off-Line Help inaccessible - Always opens web browser
https://bugs.documentfoundation.org/show_bug.cgi?id=125913 Bug ID: 125913 Summary: Off-Line Help inaccessible - Always opens web browser Product: LibreOffice Version: 6.2.3.1 rc Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: linux_help_o...@protonmail.com Description: The Help option takes me to my web browser constantly. I am using "English U.K." and through research I found an article about locales and co-ordination. Nothing I do in English U.K. and raise the off-line help. The only abnormality is that my KDE reports "United Kingdom - British English (en_GB). My locale reports LANG=en_GB.UTF-8 / LANGUAGE=en_GB. I have downloaded all three modules including the en_gb three times. Same results. Steps to Reproduce: 1. Click on Help 2. Should use off-line file 2. Takes me to web browser 3. Actual Results: see above Expected Results: The off-line help should be used Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 6.2.4.2 Build ID: 2412653d852ce75f65fbfa83fb7e7b669a126d64 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: kde5; Locale: en-GB (en_GB.UTF-8); UI-Language: en-GB Calc: threaded Note: This bug report seems to keep advising me to enter the version number. I did many times. The only way around the issue was to choose another version. My real version is 6.2.4.2. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125912] Pasted Style not Formatting Properly
https://bugs.documentfoundation.org/show_bug.cgi?id=125912 --- Comment #1 from pmb --- I bypassed the error message by choosing another version. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125912] New: Pasted Style not Formatting Properly
https://bugs.documentfoundation.org/show_bug.cgi?id=125912 Bug ID: 125912 Summary: Pasted Style not Formatting Properly Product: LibreOffice Version: 6.2.4.1 rc Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: linux_help_o...@protonmail.com Description: I was using the styles in a Table of Contents context. I prepared a Heading 1 and pasted some text (Text Body) into the page. The text appeared as expected but the line spacing was 'normal'. I ran through a few of the styles to kick start the formatting but when I returned to Text Body the line spacing was as normal. I wrote out the pasted text and it formatted as expected with slightly larger line spacing than normal. I have images but I cannot find a way of adding them. Steps to Reproduce: 1. While using the styles, paste text into the page 2. 3. Actual Results: Created a Heading 1 Pasted text from a text editor into the page The drop down menu lists the text as Text Body but the line spacing is not formatted Text Body Expected Results: The pasted text would not format as Text Body although everything in style drop box tells me it is Text Body Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: The text should display as Text Body along with all the subtle changes from normal text Libreoffice v. 6.2.4.2 Build ID: 2412653d852ce75f65fbfa83fb7e7b669a126d64 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: kde5; Locale: en-GB (en_GB.UTF-8); UI-Language: en-GB Calc: threaded Note: I am trying to submit the bug report but an error message tells me to check version box, "You must select/enter a version." . I am doing that but it doesn't seem to matter. My version is 6.2.4.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: configure.ac Repository.mk shell/Library_spsupp.mk shell/Library_spsupp_x86.mk shell/Module_shell.mk solenv/gbuild
Repository.mk | 12 +++- configure.ac|2 ++ shell/Library_spsupp_x86.mk | 16 +--- shell/Module_shell.mk | 12 +++- solenv/gbuild/Library.mk|1 + 5 files changed, 34 insertions(+), 9 deletions(-) New commits: commit 58ef8c188b6bb2ed307f5e825cc7e475c33d0c33 Author: Mike Kaganski AuthorDate: Tue May 7 21:22:08 2019 +0300 Commit: Mike Kaganski CommitDate: Fri Jun 14 01:16:22 2019 +0200 Make spsupp*.dll usable on 64-bit Windows Build spsupp for both x64 and x86, regardless of target platform. This allows to install the ActiveX component to be used by both 64-bit and 32-bit applications on 64-bit systems (especially IE, which runs both 64-bit and 32-bit processes simultaneously at least on Win10), no matter which LO (32/64) was installed. Move the DLLs from activex feature to ooo, to copy unconditionally. Registration of LO-specific component will be also unconditional; registration of replacement of MSO component will need own feature. This doesn't yet register the component in system: TODO later. Change-Id: Iccf5e73dfae306cb777f844d40611e23c4520a13 Reviewed-on: https://gerrit.libreoffice.org/71925 Reviewed-by: Mike Kaganski Tested-by: Mike Kaganski diff --git a/Repository.mk b/Repository.mk index a0faa0d2a026..33cc24fd6881 100644 --- a/Repository.mk +++ b/Repository.mk @@ -665,16 +665,26 @@ $(eval $(call gb_Helper_register_libraries_for_install,PLAINLIBS_OOO,activexbina $(eval $(call gb_Helper_register_libraries_for_install,PLAINLIBS_OOO,activex, \ so_activex \ - spsupp \ )) ifneq ($(BUILD_X64),) $(eval $(call gb_Helper_register_libraries_for_install,PLAINLIBS_OOO,activexwin64, \ so_activex_x64 \ +)) +endif + +ifneq ($(CXX_X64_BINARY),) +$(eval $(call gb_Helper_register_libraries_for_install,PLAINLIBS_OOO,ooo, \ spsupp_x64 \ )) endif +ifneq ($(CXX_X86_BINARY),) +$(eval $(call gb_Helper_register_libraries_for_install,PLAINLIBS_OOO,ooo, \ + spsupp_x86 \ +)) +endif + $(eval $(call gb_Helper_register_libraries_for_install,PLAINLIBS_OOO,ooobinarytable, \ $(if $(WINDOWS_SDK_HOME),\ instooofiltmsi \ diff --git a/configure.ac b/configure.ac index 56485ac37f6d..5a34fe080c33 100644 --- a/configure.ac +++ b/configure.ac @@ -3581,6 +3581,8 @@ if test "$_os" = "WINNT"; then AC_MSG_RESULT([not found]) AC_MSG_WARN([Installation set will not contain 64-bit Explorer extensions]) fi +else +CXX_X64_BINARY=$MSVC_CXX fi AC_SUBST(BUILD_X64) diff --git a/shell/Library_spsupp.mk b/shell/Library_spsupp_x86.mk similarity index 63% rename from shell/Library_spsupp.mk rename to shell/Library_spsupp_x86.mk index 1963bbfaebda..ba101b7bb4ec 100644 --- a/shell/Library_spsupp.mk +++ b/shell/Library_spsupp_x86.mk @@ -7,18 +7,20 @@ # file, You can obtain one at http://mozilla.org/MPL/2.0/. # -$(eval $(call gb_Library_Library,spsupp)) +$(eval $(call gb_Library_Library,spsupp_x86)) -$(eval $(call gb_Library_use_custom_headers,spsupp,\ +$(eval $(call gb_Library_set_x86,spsupp_x86,YES)) + +$(eval $(call gb_Library_use_custom_headers,spsupp_x86,\ shell/source/win32/spsupp/idl \ )) -$(eval $(call gb_Library_set_include,spsupp,\ +$(eval $(call gb_Library_set_include,spsupp_x86,\ -I$(SRCDIR)/shell/inc/spsupp \ $$(INCLUDE) \ )) -$(eval $(call gb_Library_use_system_win32_libs,spsupp,\ +$(eval $(call gb_Library_use_system_win32_libs,spsupp_x86,\ advapi32 \ kernel32 \ ole32 \ @@ -26,13 +28,13 @@ $(eval $(call gb_Library_use_system_win32_libs,spsupp,\ user32 \ )) -$(eval $(call gb_Library_add_nativeres,spsupp,spsupp)) +$(eval $(call gb_Library_add_nativeres,spsupp_x86,spsupp)) -$(eval $(call gb_Library_add_ldflags,spsupp,\ +$(eval $(call gb_Library_add_ldflags,spsupp_x86,\ /DEF:$(SRCDIR)/shell/source/win32/spsupp/spsupp.def \ )) -$(eval $(call gb_Library_add_exception_objects,spsupp,\ +$(eval $(call gb_Library_add_exception_objects,spsupp_x86,\ shell/source/win32/spsupp/COMOpenDocuments \ shell/source/win32/spsupp/registrar \ shell/source/win32/spsupp/spsuppClassFactory \ diff --git a/shell/Module_shell.mk b/shell/Module_shell.mk index c0c42cc5bea5..a03e020bf4f7 100644 --- a/shell/Module_shell.mk +++ b/shell/Module_shell.mk @@ -56,7 +56,6 @@ $(eval $(call gb_Module_add_targets,shell,\ StaticLibrary_xmlparser \ WinResTarget_shlxthdl \ CustomTarget_spsupp_idl \ - Library_spsupp \ WinResTarget_spsupp \ WinResTarget_spsupp_dlg \ )) @@ -74,10 +73,21 @@ $(eval $(call gb_Module_add_targets,shell,\ Library_shlxthdl_x64 \ StaticLibrary_shlxthandler_common_x64 \ StaticLibrary_xmlparser_x64 \ +)) +endif + +ifneq ($(CXX_X64_BINARY),) +$(eval $(call gb_Module_add_targets,shell,\
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - vcl/source
vcl/source/window/window2.cxx |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
New commits:
commit 845743131b733b52eb913048f55f5efdd013b24f
Author: Jan-Marek Glogowski
AuthorDate: Thu Jun 6 06:22:00 2019 +0200
Commit: Jan-Marek Glogowski
CommitDate: Fri Jun 14 00:57:28 2019 +0200
VCL make horizontal scrolling depend on RTL
This is easiest to test in calc. We have two test cases, because
the document and the GUI can either have different or equal RTL
settings. This fixes the horizontal border scrolling for me on
Linux with gen, gtk / gtk3 and qt5 /kde5.
It looks a bit strange that this inverts the delta, if the RTL
settings are equal, but it seems not all toolkits invert the
delta in RTL mode, like Qt does.
I also tried to implement this inside ScrollBar::ImplScroll, but
the Scrollbar has no idea of the wheel event origin, the only one
which must be inverted.
Change-Id: I239cf6528de95ad581834ec77a13f582aeff5a91
Reviewed-on: https://gerrit.libreoffice.org/73923
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
(cherry picked from commit dc326926b0adc35b6ebefa7705ee5a3f133f5c88)
Reviewed-on: https://gerrit.libreoffice.org/73993
diff --git a/vcl/source/window/window2.cxx b/vcl/source/window/window2.cxx
index a5174bb8e367..c38d0f7cdefc 100644
--- a/vcl/source/window/window2.cxx
+++ b/vcl/source/window/window2.cxx
@@ -665,10 +665,9 @@ bool Window::HandleScrollCommand( const CommandEvent& rCmd,
nLines = pData->GetNotchDelta() * nScrollLines;
if ( nLines )
{
-ImplHandleScroll( nullptr,
- 0L,
- pData->IsHorz() ? pHScrl : pVScrl,
- nLines );
+ImplHandleScroll(nullptr, 0L, pData->IsHorz() ?
pHScrl : pVScrl,
+pData->IsHorz() && pHScrl &&
(AllSettings::GetLayoutRTL() == pHScrl->IsRTLEnabled())
+? -nLines : nLines);
bRet = true;
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 118276] FILEOPEN XLSX Basic code with Validity and Sheets does not work in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=118276 Aron Budea changed: What|Removed |Added Blocks||108908 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108908 [Bug 108908] [META] Visual Basic for Applications (VBA) macro issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108908] [META] Visual Basic for Applications (VBA) macro issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108908 Aron Budea changed: What|Removed |Added Depends on||118276 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=118276 [Bug 118276] FILEOPEN XLSX Basic code with Validity and Sheets does not work in Calc -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125911] New: formatImage menu depends on approach
https://bugs.documentfoundation.org/show_bug.cgi?id=125911 Bug ID: 125911 Summary: formatImage menu depends on approach Product: LibreOffice Version: 6.2.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tor...@yahoo.com Created attachment 152177 --> https://bugs.documentfoundation.org/attachment.cgi?id=152177=edit figure with image Open Image.odt; Procedure_0: The figure is not selected; click the image (inner frame), format it (~o>i): Image submenu has all 8 items active. hit Esc thrice to cancel. Procedure_1: click the figure (outer frame), then (with the 4-arrow cursor) click the image (inner frame; The figure is de-selected.), format the image: now, only one menu item (Filter) is active. Why is the outcome different? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - officecfg/registry sd/uiconfig
officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu | 14 ++ sd/uiconfig/sdraw/menubar/menubar.xml | 14 -- 2 files changed, 15 insertions(+), 13 deletions(-) New commits: commit 85a98a5f755eb4fa8051d7ce3adcd445b303c656 Author: Maxim Monastirsky AuthorDate: Fri May 3 17:58:46 2019 +0300 Commit: Maxim Monastirsky CommitDate: Fri Jun 14 00:38:33 2019 +0200 Make .uno:Objects3DToolbox item work in menus Similar to the other insert shape group commands. Change-Id: I67524c1d521246b76d953ed9a8aff506535bf550 Reviewed-on: https://gerrit.libreoffice.org/73970 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky (cherry picked from commit 7fb6f10c92d21681e9b0fa722ac9329cf3b8e5a2) Reviewed-on: https://gerrit.libreoffice.org/73990 diff --git a/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu b/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu index 0370cfb8bb9e..722df647ce3b 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu @@ -495,6 +495,20 @@ choosemodebar + + + .uno:Objects3DToolbox + + + + + + com.sun.star.comp.framework.ToolbarAsMenuController + + + 3dobjectsbar + + diff --git a/sd/uiconfig/sdraw/menubar/menubar.xml b/sd/uiconfig/sdraw/menubar/menubar.xml index 0815d8595b28..f59c6d510849 100644 --- a/sd/uiconfig/sdraw/menubar/menubar.xml +++ b/sd/uiconfig/sdraw/menubar/menubar.xml @@ -482,19 +482,7 @@ - - - - - - - - - - - - - + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125910] New: Not calculating formula in existing sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=125910 Bug ID: 125910 Summary: Not calculating formula in existing sheet Product: LibreOffice Version: 6.2.4.2 release Hardware: All OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: fabianosid...@swissonline.ch Description: In an already existing sheet (with data imported from CSV) I have in cell D2: 20.12.1982 When I enter this formula in another cell =DATE(RIGHT(D2,4), RIGHT(LEFT(D2,5), 2), LEFT(D2,2)) it's not calculated, but rather placed as text into that cell. When I fill in the same value into D2 of a new sheet and the formula as well, it works as expected and the cell shows: 12/20/82 Steps to Reproduce: As written in the description Actual Results: As written in the description Expected Results: As written in the description Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125908] Enhancement request: Backport 6.3 FILESAVE dialog to 6.2
https://bugs.documentfoundation.org/show_bug.cgi?id=125908 m.a.riosv changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125909] New: Change tracking: add a notification when it's hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=125909 Bug ID: 125909 Summary: Change tracking: add a notification when it's hidden Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikekagan...@hotmail.com Hidden tracking of changes might in some cases be a security issue, if one sends a document which contains tracked information not supposed to be available for recipient. Possibly when opening a document with hidden change tracking, an infobar could be displayed, or a status bar icon (this still be mostly unnoticed imo), or some other way of informing user about the mode (and how to proceed)? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Building libreoffice headless
Am 13.06.19 um 20:07 schrieb James Carbine: > >> That info might be completely out of date. It refers to 4.4, which is a few >> years old. But then I never build without GUI. As you may know there is the >> LibreOffice Online version since a few years[1]. That can run in a docker >> container on a server. But I don't know if it really is build without any GUI >> libraries at all. I never used it. > I tried building with the flag and it failed. But it is also entirely > possible that I did it wrong. I was told today that for 6.3 the build used to work with --disable-gui (I still didn't test this). From "./configure --help": Disable use of X11 or Wayland to reduce dependencies. Not related to the --headless command-line option. Not related to LibreOffice Online functionality. Don't use unless you are certain you need to. Nobody will help you if you insist on trying this and run into problems. Doesn't sound encouraging. >> It's not clear what that means for you. No gui libraries linked or no running >> gui reqired. > > We are deploying to a shared machine that does not have the X11 > libraries available(or rather are prohibited). We are trying to build > LibreOffice without X in a way that we can then replicate for a Debian > package build that does not require X11 as a dependency. The resulting > package will be deployed to a headless server environment. I see. Then I think it's the best to contract some LO professional support, if you don't plan to do the development yourself. It would be nice to get this fixed and supported upstream without this "scary" help comment :-) Jan-Marek ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92083] Color bar should be included in the View menu
https://bugs.documentfoundation.org/show_bug.cgi?id=92083 Maxim Monastirsky changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||4642 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124642] remove formular toolbar from writer -> view -> toolbars
https://bugs.documentfoundation.org/show_bug.cgi?id=124642 Maxim Monastirsky changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||083 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124642] remove formular toolbar from writer -> view -> toolbars
https://bugs.documentfoundation.org/show_bug.cgi?id=124642 Maxim Monastirsky changed: What|Removed |Added CC||momonas...@gmail.com --- Comment #9 from Maxim Monastirsky --- (In reply to Roman Kuznetsov from comment #8) > It isn't that simple. It needs to change uno:AvailableToolbars. Do you know > some codepoints for it? https://opengrok.libreoffice.org/xref/core/framework/source/uielement/toolbarsmenucontroller.cxx?r=32eeb405#410 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70641] No connection to KDE address book possible (see comment 10)
https://bugs.documentfoundation.org/show_bug.cgi?id=70641 --- Comment #16 from Jan-Marek Glogowski --- IMH(In reply to Julien Nabet from comment #15) > (In reply to Buovjaga from comment #14) > > Comment 10 explains things, so let's make it clear in the summary. > > Comment 10 is from 2015. Since we dumped kde4, I don't think we should try > to implement kde4 address book management. > So I'd be ok with Robert for WONTFIX > (just my personal opinion) This is not about a particular KDE version. IMHO KDE PIM in KDE3 was quite popular, so someone implemented a DB driver to access its address book from LO. In KDE4 - still IMHO - PIM was a disaster to use; I gave up on it. Now there is KDE5. I have no idea about the quality of PIM in there. As it stands some functionality was removed from LO, as it became obsoleted and nobody was interested in porting it to a newer version of KDE. Somebody might want to implement a DB driver for KDE5, so I think an enhancement report is still valid. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125607] URL to folder / directory no longer working in LO 6.2.4.2 for Mac
https://bugs.documentfoundation.org/show_bug.cgi?id=125607 --- Comment #9 from Thomas Maeder --- Created attachment 152176 --> https://bugs.documentfoundation.org/attachment.cgi?id=152176=edit Example applescripts & results ...Please see the attached file, as I experienced some formatting problems copying to the commend area. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125607] URL to folder / directory no longer working in LO 6.2.4.2 for Mac
https://bugs.documentfoundation.org/show_bug.cgi?id=125607 --- Comment #8 from Thomas Maeder --- ... file type:" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: avmedia/Library_avmediagst.mk avmedia/source config_host/config_vclplug.h.in config_host.mk.in configure.ac include/vcl vcl/inc vcl/Library_vclplug_gtk3_kde5.mk vcl/Lib
avmedia/Library_avmediagst.mk | 20
avmedia/source/gstreamer/gstplayer.cxx | 161 ++---
avmedia/source/gstreamer/gstplayer.hxx |9 -
config_host.mk.in |6 -
config_host/config_vclplug.h.in|3
configure.ac | 30 +++---
include/vcl/syschild.hxx |2
vcl/Library_vclplug_gtk3.mk|1
vcl/Library_vclplug_gtk3_kde5.mk |1
vcl/Library_vclplug_qt5.mk |7 -
vcl/inc/qt5/Qt5Instance.hxx|2
vcl/inc/salinst.hxx|3
vcl/inc/unx/gstsink.hxx| 27 +
vcl/inc/unx/gtk/gtkinst.hxx|4
vcl/qt5/Qt5Instance.cxx| 38 +++
vcl/source/window/syschild.cxx |5 +
vcl/unx/gtk3/gtk3gtkinst.cxx | 33 ++
17 files changed, 193 insertions(+), 159 deletions(-)
New commits:
commit a6201725d760cbce832d4de029b418bb7334df6a
Author: Jan-Marek Glogowski
AuthorDate: Mon Jun 10 21:40:33 2019 +0200
Commit: Jan-Marek Glogowski
CommitDate: Thu Jun 13 23:45:09 2019 +0200
Don't link avmediagst with gtk3 and qt5
While the VCL plugins are dynamically loaded and therefore just
load their depending toolkit libraries, the GStreamer avmedia
backend now links against Qt and GTK+. The GStreamer API itself
is toolkit agnostic and the toolkit setup just uses a single
GStreamer symbol to create the specific video sink.
So the toolkit binding can simply be moved into the VCL plugin.
At the point of the GStreamer toolkit setup call the GStreamer
library is loaded by avmediagst, so the dlsym lookup should
never fail.
I also dropped the special GtkWidget handling. Using g_object_get
will increase the refcount of the widget. A g_object_unref after
adding it to the container seems to destroy it correctly.
Change-Id: I693947e441bceb4b09bc38920e308e39142d0a35
Reviewed-on: https://gerrit.libreoffice.org/73849
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/avmedia/Library_avmediagst.mk b/avmedia/Library_avmediagst.mk
index 027123911e87..7ed6cc451a24 100644
--- a/avmedia/Library_avmediagst.mk
+++ b/avmedia/Library_avmediagst.mk
@@ -21,26 +21,6 @@ $(eval $(call gb_Library_add_libs,avmediagst,\
$(GSTREAMER_1_0_LIBS) \
))
-ifneq ($(ENABLE_GTK3),)
-$(eval $(call gb_Library_add_cxxflags,avmediagst,\
-$$(GTK3_CFLAGS) \
-))
-
-$(eval $(call gb_Library_add_libs,avmediagst,\
-$(GTK3_LIBS) \
-))
-endif
-
-ifneq ($(ENABLE_QT5),)
-$(eval $(call gb_Library_add_cxxflags,avmediagst,\
-$$(QT5_CFLAGS) \
-))
-
-$(eval $(call gb_Library_add_libs,avmediagst,\
-$(QT5_LIBS) \
-))
-endif
-
$(eval $(call gb_Library_use_external,avmediagst,boost_headers))
$(eval $(call gb_Library_use_sdk_api,avmediagst))
diff --git a/avmedia/source/gstreamer/gstplayer.cxx
b/avmedia/source/gstreamer/gstplayer.cxx
index f88addd0cfef..35feb8ad5ea2 100644
--- a/avmedia/source/gstreamer/gstplayer.cxx
+++ b/avmedia/source/gstreamer/gstplayer.cxx
@@ -42,10 +42,6 @@
#include "gstframegrabber.hxx"
#include "gstwindow.hxx"
-#if ENABLE_QT5
-#include
-#endif
-
#include
#define AVMEDIA_GST_PLAYER_IMPLEMENTATIONNAME
"com.sun.star.comp.avmedia.Player_GStreamer"
#define AVMEDIA_GST_PLAYER_SERVICENAME
"com.sun.star.media.Player_GStreamer"
@@ -287,9 +283,6 @@ Player::Player() :
GstPlayer_BASE( m_aMutex ),
mpPlaybin( nullptr ),
mpVolumeControl( nullptr ),
-#if ENABLE_GTK3
-mpGtkWidget( nullptr ),
-#endif
mbUseGtkSink( false ),
mbFakeVideo (false ),
mnUnmutedVolume( 0 ),
@@ -347,14 +340,6 @@ void SAL_CALL Player::disposing()
// Release the elements and pipeline
if( mbInitialized )
{
-#if ENABLE_GTK3
-if (mpGtkWidget)
-{
-gtk_widget_destroy(mpGtkWidget);
-mpGtkWidget = nullptr;
-}
-#endif
-
if( mpPlaybin )
{
gst_element_set_state( mpPlaybin, GST_STATE_NULL );
@@ -557,14 +542,6 @@ GstBusSyncReply Player::processSyncMessage( GstMessage
*message )
void Player::preparePlaybin( const OUString& rURL, GstElement *pSink )
{
-#if ENABLE_GTK3
-if (mpGtkWidget)
-{
-gtk_widget_destroy(mpGtkWidget);
-mpGtkWidget = nullptr;
-}
-#endif
-
if (mpPlaybin != nullptr)
{
gst_element_set_state( mpPlaybin, GST_STATE_NULL );
@@ -870,98 +847,64 @@ uno::Reference< ::media::XPlayerWindow > SAL_CALL
Player::createPlayerWindow( co
if( aSize.Width > 0 && aSize.Height > 0 )
{
::avmedia::gstreamer::Window* pWindow = new
::avmedia::gstreamer::Window;
+if (rArguments.getLength() <= 2)
+{
+xRet = pWindow;
+return xRet;
+}
-xRet = pWindow;
+sal_IntPtr pIntPtr = 0;
+rArguments[ 2 ] >>= pIntPtr;
+SystemChildWindow *pParentWindow =
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Bug 102495 depends on bug 122239, which changed state. Bug 122239 Summary: Primary selection does not work under KDE https://bugs.documentfoundation.org/show_bug.cgi?id=122239 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - filter/source include/vcl sw/qa vcl/inc vcl/source
filter/source/msfilter/msdffimp.cxx |8 --
include/vcl/graphicfilter.hxx|2 -
sw/qa/extras/ww8import/ww8import.cxx |9 +++
vcl/inc/impgraph.hxx |2 -
vcl/source/filter/graphicfilter.cxx |5 ++--
vcl/source/gdi/impgraph.cxx | 42 ---
6 files changed, 44 insertions(+), 24 deletions(-)
New commits:
commit a21e297b1229dd389c691893ddc48605e9471db0
Author: Miklos Vajna
AuthorDate: Tue Jun 11 08:09:14 2019 +0200
Commit: Xisco Faulí
CommitDate: Thu Jun 13 23:35:27 2019 +0200
tdf#125591 DOC import: lazy-load metafiles with explicit size
Regression from commit 69b62cfcbd364d7f62142149c2f690104b217ca1
(tdf#125281 DOC import: fix size of lazy-loaded metafiles, 2019-05-27),
the problem is that setting the preferred size of a Graphic swaps it in.
Avoid this by extending ImportUnloadedGraphic(): if a size hint is
provided, then that will be used instead of info from the graphic
descriptor (which is usually only meaningful for bitmaps).
This way we maintain the correct size and we're back to lazy-loading
metafiles from binary MSO files as well.
(cherry picked from commit acb803b730f2c6bd82e39beab58949ec14f85eb0)
and:
CppunitTest_sw_ww8import: disable failing assert on Windows
It fails only sometimes, it's yet clear why.
(cherry picked from commit b5d624c4af1085d4670149e9c1d280da7bc9add0)
Change-Id: Ide12d12166110e98ea47b5347dd24fb203b22da3
Reviewed-on: https://gerrit.libreoffice.org/73961
Tested-by: Jenkins
Reviewed-by: Xisco Faulí
diff --git a/filter/source/msfilter/msdffimp.cxx
b/filter/source/msfilter/msdffimp.cxx
index b6898f1478fb..5eb3249628bc 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -6557,11 +6557,13 @@ bool SvxMSDffManager::GetBLIPDirect( SvStream&
rBLIPStream, Graphic& rData, tool
// which may be very large if the whole document is large. Limit
the read
// size to the size of this record.
sal_uInt64 maxSize = pGrStream == ? nLength : 0;
-Graphic aGraphic = rGF.ImportUnloadedGraphic(*pGrStream, maxSize);
+Graphic aGraphic;
-// Size available in metafile header, set that here.
+// Size available in metafile header.
if (aMtfSize100.getWidth() && aMtfSize100.getHeight())
-aGraphic.SetPrefSize(aMtfSize100);
+aGraphic = rGF.ImportUnloadedGraphic(*pGrStream, maxSize,
);
+else
+aGraphic = rGF.ImportUnloadedGraphic(*pGrStream, maxSize);
if (aGraphic)
{
diff --git a/include/vcl/graphicfilter.hxx b/include/vcl/graphicfilter.hxx
index db3d78371480..5ef927761f97 100644
--- a/include/vcl/graphicfilter.hxx
+++ b/include/vcl/graphicfilter.hxx
@@ -295,7 +295,7 @@ public:
WmfExternal const *pExtHeader = nullptr );
// Setting sizeLimit limits how much will be read from the stream.
-Graphic ImportUnloadedGraphic(SvStream& rIStream, sal_uInt64 sizeLimit =
0);
+Graphic ImportUnloadedGraphic(SvStream& rIStream, sal_uInt64 sizeLimit =
0, Size* pSizeHint = nullptr);
const FilterErrorEx&GetLastError() const { return *pErrorEx;}
voidResetLastError();
diff --git a/sw/qa/extras/ww8import/ww8import.cxx
b/sw/qa/extras/ww8import/ww8import.cxx
index fdc816088f62..0b68d83eb753 100644
--- a/sw/qa/extras/ww8import/ww8import.cxx
+++ b/sw/qa/extras/ww8import/ww8import.cxx
@@ -164,6 +164,10 @@ DECLARE_WW8IMPORT_TEST(testTdf112346, "tdf112346.doc")
DECLARE_WW8IMPORT_TEST(testTdf125281, "tdf125281.doc")
{
+#if !defined(_WIN32)
+// Windows fails with actual == 26171 for some reason; also lazy load
isn't lazy in Windows
+// debug builds, reason is not known at the moment.
+
// Load a .doc file which has an embedded .emf image.
SwXTextDocument* pTextDoc =
dynamic_cast(mxComponent.get());
SwDoc* pDoc = pTextDoc->GetDocShell()->GetDoc();
@@ -176,6 +180,11 @@ DECLARE_WW8IMPORT_TEST(testTdf125281, "tdf125281.doc")
// an actual Paint() was performed (and even then, it was wrong).
long nExpected = 25664;
CPPUNIT_ASSERT_EQUAL(nExpected, rGraphic.GetPrefSize().getWidth());
+
+// Without the accompanying fix in place, this test would have failed, as
setting the pref size
+// swapped the image in.
+CPPUNIT_ASSERT(!rGraphic.isAvailable());
+#endif
}
DECLARE_WW8IMPORT_TEST(testTdf110987, "tdf110987")
diff --git a/vcl/inc/impgraph.hxx b/vcl/inc/impgraph.hxx
index f24c6fe34255..30c88594c5d6 100644
--- a/vcl/inc/impgraph.hxx
+++ b/vcl/inc/impgraph.hxx
@@ -111,7 +111,7 @@ public:
ImpGraphic( const GDIMetaFile& rMtf );
~ImpGraphic();
-void ImplSetPrepared(bool bAnimated);
+void ImplSetPrepared(bool bAnimated, Size* pSizeHint);
[Libreoffice-bugs] [Bug 125607] URL to folder / directory no longer working in LO 6.2.4.2 for Mac
https://bugs.documentfoundation.org/show_bug.cgi?id=125607
--- Comment #7 from Thomas Maeder ---
(In reply to Stephan Bergmann from comment #6)
I cannot judge on how LO works on other platforms, but MS Excel (which I still
have to use at the office...) behaves in a similar way on both Mac and Windows:
while it does not let you select a folder in all implementations, links to
folders have (up to now) always worked as expected on both platforms.
As for the security issue, it seems it is possible to detect applications. Two
examples using Applescript (simple folder vs application) to get their info are
given below. Looking at both resulting attribute sets:
- Both applications and folders indeed have the "folder" attribute (your
concern).
- Applications names have the ".app" ending, folders don't.
- The file type of apps is "APPL", that of folders is an empty string "".
- Applications (+ others) are bundles (the "package folder" attribute), not
folders.
Other attributes may be used, such as "kind", but, as seen in the example, the
returned value is localised (in French in this example), making it harder to
write generic code.
A safe way to differentiate seems to me to check for the "APPL" attribute. One
could also possibly ban opening bundles. What do you think?
--
1) Folder: Desktop
1a) Script
set elem to "Desktop" as alias
get info for elem
1b) Result
{name:"Desktop", creation date:date "lundi, 10 décembre 2007 à 22:05:00",
modification date:date "jeudi, 16 décembre 2010 à 15:22:36", size:6148,
folder:true, alias:false, package folder:false, visible:true, extension
hidden:false, name extension:missing value, displayed name:"Bureau", default
application:alias "Hobbes:System:Library:CoreServices:Finder.app:",
kind:"Dossier", folder window:{0, 0, 0, 0}, file type:"
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85811] [META] Main menu bar bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=85811 Bug 85811 depends on bug 125146, which changed state. Bug 125146 Summary: Function “Reply Comment” should be consistent for self replies in Edit menu and drop-down menu https://bugs.documentfoundation.org/show_bug.cgi?id=125146 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106179] [META] Writer comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106179 Bug 106179 depends on bug 125146, which changed state. Bug 125146 Summary: Function “Reply Comment” should be consistent for self replies in Edit menu and drop-down menu https://bugs.documentfoundation.org/show_bug.cgi?id=125146 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125146] Function “Reply Comment” should be consistent for self replies in Edit menu and drop-down menu
https://bugs.documentfoundation.org/show_bug.cgi?id=125146 Maxim Monastirsky changed: What|Removed |Added Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |momonas...@gmail.com |desktop.org | Status|NEW |RESOLVED --- Comment #7 from Maxim Monastirsky --- Turns out both parts were regressions, so I changed them back to how they were in older builds. Cherry-picked to 6-3 branch too (in gerrit). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117331] Remove Split Package for Java 9 compatibility
https://bugs.documentfoundation.org/show_bug.cgi?id=117331 --- Comment #8 from Rick Heckadon --- Sorry that this took so long, but I was finally able to merge all the required jars into one jar, included it into the program, and the program finally compiled and worked! I believe this is the solution to this problem. Would a merged jar be possible in future updates of LibreOffice? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/app/inputhdl.cxx | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
New commits:
commit 2d36e43d3d3ac69f4cacd532308cfc8c81982864
Author: Eike Rathke
AuthorDate: Thu Jun 13 21:41:14 2019 +0200
Commit: Eike Rathke
CommitDate: Thu Jun 13 23:24:21 2019 +0200
Related: tdf#113541 use reference syntax of the document being edited
When creating a formula referencing an external document by
travelling (clicking in) to that document, the reference was
created using the reference syntax of the referenced document,
which may be different if the syntax was changed for only one of
the documents after being opened. Use the reference syntax of the
document being edited instead so the created reference is correct
and can be compiled.
Change-Id: I07d0ce9cd911ac8e62576b4cdabdfd2569336fbf
Reviewed-on: https://gerrit.libreoffice.org/73983
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx
index cadf157bdc0d..eb8142a913cf 100644
--- a/sc/source/ui/app/inputhdl.cxx
+++ b/sc/source/ui/app/inputhdl.cxx
@@ -3046,15 +3046,16 @@ void ScInputHandler::SetReference( const ScRange& rRef,
const ScDocument* pDoc )
{
HideTip();
-bool bOtherDoc = ( pRefViewSh &&
-pRefViewSh->GetViewData().GetDocument() != pDoc );
-if (bOtherDoc)
-if (!pDoc->GetDocumentShell()->HasName())
-{
-// References to unnamed document; that doesn't work
-// SetReference should not be called, then
-return;
-}
+const ScDocument* pThisDoc = nullptr;
+bool bOtherDoc = (pRefViewSh && ((pThisDoc =
pRefViewSh->GetViewData().GetDocument()) != pDoc));
+if (bOtherDoc && !pDoc->GetDocumentShell()->HasName())
+{
+// References to unnamed document; that doesn't work
+// SetReference should not be called, then
+return;
+}
+if (!pThisDoc)
+pThisDoc = pDoc;
UpdateActiveView();
if (!pTableView && !pTopView)
@@ -3089,9 +3090,9 @@ void ScInputHandler::SetReference( const ScRange& rRef,
const ScDocument* pDoc )
}
}
-// Create string from reference
+// Create string from reference, in the syntax of the document being
edited.
OUString aRefStr;
-const ScAddress::Details aAddrDetails( pDoc, aCursorPos );
+const ScAddress::Details aAddrDetails( pThisDoc, aCursorPos );
if (bOtherDoc)
{
// Reference to other document
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125141] found syllabification error in German
https://bugs.documentfoundation.org/show_bug.cgi?id=125141 --- Comment #4 from Katrin --- @ Dieter Praas: Thanks for your agreement. @ Thomas Lendo: I just know the German books of law, but in the most cases there are more than one capital in one word without space. For exemple OWiG. And the most of it have also just one vowel - like the Y in PsychKG, VerschG, StPO. Maybe there's a way to make a rule, the program detects therms like that. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125146] Function “Reply Comment” should be consistent for self replies in Edit menu and drop-down menu
https://bugs.documentfoundation.org/show_bug.cgi?id=125146 --- Comment #6 from Commit Notification --- Maxim Monastirsky committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/4d11c44673e46b134231ea825c1be36c15f8b263%5E%21 tdf#125146 Disable the reply command in UI It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/qt5
vcl/qt5/Qt5Clipboard.cxx | 68 +++
1 file changed, 34 insertions(+), 34 deletions(-)
New commits:
commit cc82a2e92ae99a6cf5ae304e2b9b8dcffa3f514d
Author: Jan-Marek Glogowski
AuthorDate: Sun Jun 9 14:43:59 2019 +
Commit: Thorsten Behrens
CommitDate: Thu Jun 13 23:21:00 2019 +0200
Qt5 move boilerplate clipboard code to the end...
... in the implementation file.
Change-Id: I1f6fae0eb7c5d6973ce44320ff6d977e40d54a72
Reviewed-on: https://gerrit.libreoffice.org/73734
Tested-by: Jenkins
Reviewed-by: Aleksei Nikiforov
Reviewed-by: Thorsten Behrens
diff --git a/vcl/qt5/Qt5Clipboard.cxx b/vcl/qt5/Qt5Clipboard.cxx
index 50126e6d3d4e..8db5dd2ce97c 100644
--- a/vcl/qt5/Qt5Clipboard.cxx
+++ b/vcl/qt5/Qt5Clipboard.cxx
@@ -69,21 +69,6 @@ void Qt5Clipboard::flushClipboard()
});
}
-OUString Qt5Clipboard::getImplementationName()
-{
-return OUString("com.sun.star.datatransfer.Qt5Clipboard");
-}
-
-css::uno::Sequence Qt5Clipboard::getSupportedServiceNames()
-{
-return { "com.sun.star.datatransfer.clipboard.SystemClipboard" };
-}
-
-sal_Bool Qt5Clipboard::supportsService(const OUString& ServiceName)
-{
-return cppu::supportsService(this, ServiceName);
-}
-
css::uno::Reference
Qt5Clipboard::getContents()
{
osl::MutexGuard aGuard(m_aMutex);
@@ -135,25 +120,6 @@ void Qt5Clipboard::setContents(
xOldOwner->lostOwnership(this, xOldContents);
}
-OUString Qt5Clipboard::getName() { return m_aClipboardName; }
-
-sal_Int8 Qt5Clipboard::getRenderingCapabilities() { return 0; }
-
-void Qt5Clipboard::addClipboardListener(
-const
css::uno::Reference& listener)
-{
-osl::MutexGuard aGuard(m_aMutex);
-m_aListeners.push_back(listener);
-}
-
-void Qt5Clipboard::removeClipboardListener(
-const
css::uno::Reference& listener)
-{
-osl::MutexGuard aGuard(m_aMutex);
-m_aListeners.erase(std::remove(m_aListeners.begin(), m_aListeners.end(),
listener),
- m_aListeners.end());
-}
-
void Qt5Clipboard::handleChanged(QClipboard::Mode aMode)
{
if (aMode != m_aClipboardMode)
@@ -184,6 +150,40 @@ void Qt5Clipboard::handleChanged(QClipboard::Mode aMode)
listener->changedContents(aEv);
}
+OUString Qt5Clipboard::getImplementationName()
+{
+return OUString("com.sun.star.datatransfer.Qt5Clipboard");
+}
+
+css::uno::Sequence Qt5Clipboard::getSupportedServiceNames()
+{
+return { "com.sun.star.datatransfer.clipboard.SystemClipboard" };
+}
+
+sal_Bool Qt5Clipboard::supportsService(const OUString& ServiceName)
+{
+return cppu::supportsService(this, ServiceName);
+}
+
+OUString Qt5Clipboard::getName() { return m_aClipboardName; }
+
+sal_Int8 Qt5Clipboard::getRenderingCapabilities() { return 0; }
+
+void Qt5Clipboard::addClipboardListener(
+const
css::uno::Reference& listener)
+{
+osl::MutexGuard aGuard(m_aMutex);
+m_aListeners.push_back(listener);
+}
+
+void Qt5Clipboard::removeClipboardListener(
+const
css::uno::Reference& listener)
+{
+osl::MutexGuard aGuard(m_aMutex);
+m_aListeners.erase(std::remove(m_aListeners.begin(), m_aListeners.end(),
listener),
+ m_aListeners.end());
+}
+
bool Qt5Clipboard::isSupported(const QClipboard::Mode aMode)
{
const QClipboard* pClipboard = QApplication::clipboard();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/shells/textfld.cxx |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
New commits:
commit 4d11c44673e46b134231ea825c1be36c15f8b263
Author: Maxim Monastirsky
AuthorDate: Wed Jun 12 01:32:38 2019 +0300
Commit: Maxim Monastirsky
CommitDate: Thu Jun 13 23:20:43 2019 +0200
tdf#125146 Disable the reply command in UI
... when the focus isn't inside a comment. That's likely
a regression of 6e463381b43d888a632e652a873f2b5abe7e5458
("lok: Allow to reply to comments using postit id"),
which enabled the command also in the text context.
The current solution is to only enable the command when
lok is active, which is where it's used. This is similar
to what is done in the code nearby for FN_REDLINE_COMMENT.
If that turns out to not be enough (e.g. executing the
command useful outside lok), another possible solution
might be to add FastCall = TRUE; to FN_REPLY in
_textsh.sdi. That will allow executing the command via
api even when disabled in ui.
Change-Id: Ibf2248a82599801af63a169fc2d34b27d080c048
Reviewed-on: https://gerrit.libreoffice.org/73972
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky
diff --git a/sw/source/uibase/shells/textfld.cxx
b/sw/source/uibase/shells/textfld.cxx
index 54b674e6ed38..376fdb2f269c 100644
--- a/sw/source/uibase/shells/textfld.cxx
+++ b/sw/source/uibase/shells/textfld.cxx
@@ -900,12 +900,16 @@ void SwTextShell::StateField( SfxItemSet )
break;
case FN_REPLY:
+if (!comphelper::LibreOfficeKit::isActive())
+rSet.DisableItem(nWhich);
+break;
+
case FN_POSTIT :
case FN_JAVAEDIT :
{
bool bCurField = false;
pField = rSh.GetCurField();
-if(nWhich == FN_POSTIT || nWhich == FN_REPLY)
+if(nWhich == FN_POSTIT)
bCurField = pField && pField->GetTyp()->Which() ==
SwFieldIds::Postit;
else
bCurField = pField && pField->GetTyp()->Which() ==
SwFieldIds::Script;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125146] Function “Reply Comment” should be consistent for self replies in Edit menu and drop-down menu
https://bugs.documentfoundation.org/show_bug.cgi?id=125146 Commit Notification changed: What|Removed |Added Whiteboard||target:6.4.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125146] Function “Reply Comment” should be consistent for self replies in Edit menu and drop-down menu
https://bugs.documentfoundation.org/show_bug.cgi?id=125146 --- Comment #5 from Commit Notification --- Maxim Monastirsky committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/1b39bae5debe3bf952449bd7d2910defcea92b9e%5E%21 tdf#125146 Use correct id for reply command item It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/window/window2.cxx |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
New commits:
commit dc326926b0adc35b6ebefa7705ee5a3f133f5c88
Author: Jan-Marek Glogowski
AuthorDate: Thu Jun 6 06:22:00 2019 +0200
Commit: Jan-Marek Glogowski
CommitDate: Thu Jun 13 23:19:36 2019 +0200
VCL make horizontal scrolling depend on RTL
This is easiest to test in calc. We have two test cases, because
the document and the GUI can either have different or equal RTL
settings. This fixes the horizontal border scrolling for me on
Linux with gen, gtk / gtk3 and qt5 /kde5.
It looks a bit strange that this inverts the delta, if the RTL
settings are equal, but it seems not all toolkits invert the
delta in RTL mode, like Qt does.
I also tried to implement this inside ScrollBar::ImplScroll, but
the Scrollbar has no idea of the wheel event origin, the only one
which must be inverted.
Change-Id: I239cf6528de95ad581834ec77a13f582aeff5a91
Reviewed-on: https://gerrit.libreoffice.org/73923
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/vcl/source/window/window2.cxx b/vcl/source/window/window2.cxx
index a5174bb8e367..c38d0f7cdefc 100644
--- a/vcl/source/window/window2.cxx
+++ b/vcl/source/window/window2.cxx
@@ -665,10 +665,9 @@ bool Window::HandleScrollCommand( const CommandEvent& rCmd,
nLines = pData->GetNotchDelta() * nScrollLines;
if ( nLines )
{
-ImplHandleScroll( nullptr,
- 0L,
- pData->IsHorz() ? pHScrl : pVScrl,
- nLines );
+ImplHandleScroll(nullptr, 0L, pData->IsHorz() ?
pHScrl : pVScrl,
+pData->IsHorz() && pHScrl &&
(AllSettings::GetLayoutRTL() == pHScrl->IsRTLEnabled())
+? -nLines : nLines);
bRet = true;
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/inc vcl/qt5
vcl/inc/qt5/Qt5Clipboard.hxx| 56 ++ vcl/inc/qt5/Qt5Transferable.hxx | 90 -- vcl/qt5/Qt5Clipboard.cxx| 338 +++--- vcl/qt5/Qt5Instance.cxx | 13 - vcl/qt5/Qt5Transferable.cxx | 355 +--- 5 files changed, 513 insertions(+), 339 deletions(-) New commits: commit bcca1cf28cbd6c961d59bd8b8a8e58184dfc3823 Author: Jan-Marek Glogowski AuthorDate: Fri May 31 16:40:34 2019 + Commit: Thorsten Behrens CommitDate: Thu Jun 13 23:18:58 2019 +0200 tdf#122239 Qt5 implement lazy clipboard handling This changes the Qt5Clipboard to a lazy loading one, which will just deliver data on read requests. This fixes not only the PRIMARY selection problems with Writer, but will generally speed up C'n'P, inside LO, because the data has not to be copied or transferred via QMimeData. This is mainly done by implementing the "mirror" interface of the Qt5Transferable, the Qt5MimeData using the retrieveData override. To prevent clipboard loss on shutdown, this sets a deep copied QMimeData of the current XTransferable, to make it persistent. This code explicitly doesn't use any of the QMimeData convenience functions and relies completely on LO's string handling, so we won't mix in eventual Qt bugs; all bugs are ours... Change-Id: I43d92a95df8fcac88dc41b00021cea0b5f040413 Reviewed-on: https://gerrit.libreoffice.org/73288 Tested-by: Jenkins Reviewed-by: Michael Weghorn Reviewed-by: Thorsten Behrens diff --git a/vcl/inc/qt5/Qt5Clipboard.hxx b/vcl/inc/qt5/Qt5Clipboard.hxx index 2c2bb93f5016..93ad36a0e672 100644 --- a/vcl/inc/qt5/Qt5Clipboard.hxx +++ b/vcl/inc/qt5/Qt5Clipboard.hxx @@ -20,7 +20,14 @@ #include -class Qt5Clipboard +/** + * This implementation has two main functions, which handle the clipboard content: + * the XClipboard::setContent function and the QClipboard::change signal handler. + * + * The first just sets the respective clipboard to the expected content from LO, + * the latter will handle any reported changes. + **/ +class Qt5Clipboard final : public QObject, public cppu::WeakComponentImplHelper m_aContents; +// the owner of the current contents, which must be informed on content change css::uno::Reference m_aOwner; std::vector> m_aListeners; -OUString m_aClipboardName; -QClipboard::Mode m_aClipboardMode; -// custom MIME type to detect whether clipboard content was added by self or externally -const QString m_sMimeTypeUuid = "application/x-libreoffice-clipboard-uuid"; -const QByteArray m_aUuid; + +static bool isOwner(const QClipboard::Mode aMode); +static bool isSupported(const QClipboard::Mode aMode); + +explicit Qt5Clipboard(const OUString& aModeString, const QClipboard::Mode aMode); private Q_SLOTS: -void handleClipboardChange(QClipboard::Mode mode); +void handleChanged(QClipboard::Mode mode); public: -explicit Qt5Clipboard(const OUString& aModeString); -virtual ~Qt5Clipboard() override; - -/* - * XServiceInfo - */ +// factory function to construct only valid Qt5Clipboard objects by name +static css::uno::Reference create(const OUString& aModeString); +// XServiceInfo virtual OUString SAL_CALL getImplementationName() override; virtual sal_Bool SAL_CALL supportsService(const OUString& ServiceName) override; virtual css::uno::Sequence SAL_CALL getSupportedServiceNames() override; -/* - * XClipboard - */ - +// XClipboard virtual css::uno::Reference SAL_CALL getContents() override; - virtual void SAL_CALL setContents( const css::uno::Reference& xTrans, const css::uno::Reference& xClipboardOwner) override; - virtual OUString SAL_CALL getName() override; -/* - * XClipboardEx - */ - +// XClipboardEx virtual sal_Int8 SAL_CALL getRenderingCapabilities() override; -/* - * XFlushableClipboard - */ +// XFlushableClipboard virtual void SAL_CALL flushClipboard() override; -/* - * XClipboardNotifier - */ +// XClipboardNotifier virtual void SAL_CALL addClipboardListener( const css::uno::Reference& listener) override; - virtual void SAL_CALL removeClipboardListener( const css::uno::Reference& listener) override; diff --git a/vcl/inc/qt5/Qt5Transferable.hxx b/vcl/inc/qt5/Qt5Transferable.hxx index edc14904f769..f36216eed121 100644 --- a/vcl/inc/qt5/Qt5Transferable.hxx +++ b/vcl/inc/qt5/Qt5Transferable.hxx @@ -13,44 +13,110 @@ #include #include +#include +#include #include /** - * Abstract XTransferable used for clipboard and D'n'D transfers + * Qt5Transferable classes are used to read QMimeData via the XTransferable + * interface. All the functionality is already implemented in the
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/docvw/AnnotationMenuButton.cxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 1b39bae5debe3bf952449bd7d2910defcea92b9e
Author: Maxim Monastirsky
AuthorDate: Fri Jun 7 12:06:13 2019 +0300
Commit: Maxim Monastirsky
CommitDate: Thu Jun 13 23:18:34 2019 +0200
tdf#125146 Use correct id for reply command item
This was overlooked in commit
a10b4fd2bc08651d47bdb19bb8ab9c1f8f3d4851
("convert annotation menu to .ui").
Change-Id: Ia9e44460394e60f9c2ae767fbb2a07414fa07cf7
Reviewed-on: https://gerrit.libreoffice.org/73971
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky
diff --git a/sw/source/uibase/docvw/AnnotationMenuButton.cxx
b/sw/source/uibase/docvw/AnnotationMenuButton.cxx
index 51a7d809d7cc..c8996bdc3554 100644
--- a/sw/source/uibase/docvw/AnnotationMenuButton.cxx
+++ b/sw/source/uibase/docvw/AnnotationMenuButton.cxx
@@ -102,7 +102,7 @@ void AnnotationMenuButton::MouseButtonDown( const
MouseEvent& rMEvt )
if (mrSidebarWin.IsProtected())
{
-pButtonPopup->EnableItem(FN_REPLY, false);
+pButtonPopup->EnableItem(pButtonPopup->GetItemId("reply"), false);
}
else
{
@@ -118,11 +118,11 @@ void AnnotationMenuButton::MouseButtonDown( const
MouseEvent& rMEvt )
// do not allow to reply to ourself and no answer possible if this
note is in a protected section
if (sAuthor == mrSidebarWin.GetAuthor())
{
-pButtonPopup->EnableItem(FN_REPLY, false);
+pButtonPopup->EnableItem(pButtonPopup->GetItemId("reply"), false);
}
else
{
-pButtonPopup->EnableItem(FN_REPLY);
+pButtonPopup->EnableItem(pButtonPopup->GetItemId("reply"));
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: officecfg/registry sd/uiconfig
officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu | 14 ++ sd/uiconfig/sdraw/menubar/menubar.xml | 14 -- 2 files changed, 15 insertions(+), 13 deletions(-) New commits: commit 7fb6f10c92d21681e9b0fa722ac9329cf3b8e5a2 Author: Maxim Monastirsky AuthorDate: Fri May 3 17:58:46 2019 +0300 Commit: Maxim Monastirsky CommitDate: Thu Jun 13 23:15:46 2019 +0200 Make .uno:Objects3DToolbox item work in menus Similar to the other insert shape group commands. Change-Id: I67524c1d521246b76d953ed9a8aff506535bf550 Reviewed-on: https://gerrit.libreoffice.org/73970 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky diff --git a/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu b/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu index 0370cfb8bb9e..722df647ce3b 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu @@ -495,6 +495,20 @@ choosemodebar + + + .uno:Objects3DToolbox + + + + + + com.sun.star.comp.framework.ToolbarAsMenuController + + + 3dobjectsbar + + diff --git a/sd/uiconfig/sdraw/menubar/menubar.xml b/sd/uiconfig/sdraw/menubar/menubar.xml index 0815d8595b28..f59c6d510849 100644 --- a/sd/uiconfig/sdraw/menubar/menubar.xml +++ b/sd/uiconfig/sdraw/menubar/menubar.xml @@ -482,19 +482,7 @@ - - - - - - - - - - - - - + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125902] [META] Impress Bullets New Dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=125902 Bug 125902 depends on bug 125903, which changed state. Bug 125903 Summary: Level selection behavior KO https://bugs.documentfoundation.org/show_bug.cgi?id=125903 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125774] Double selecting of level in list in new dialog B in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=125774 Andras Timar changed: What|Removed |Added CC||bureautiquelibre@nantesmetr ||opole.fr --- Comment #2 from Andras Timar --- *** Bug 125903 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125903] Level selection behavior KO
https://bugs.documentfoundation.org/show_bug.cgi?id=125903 Andras Timar changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #2 from Andras Timar --- We have a patch for this: https://gerrit.libreoffice.org/#/c/73747/ It will be merged ASAP. *** This bug has been marked as a duplicate of bug 125774 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125598] FILESAVE calc scrollbars don't save correctly in ms formats
https://bugs.documentfoundation.org/show_bug.cgi?id=125598 Bartosz changed: What|Removed |Added Summary|calc scrollbars don't save |FILESAVE calc scrollbars |correctly in ms formats |don't save correctly in ms ||formats -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/compiler.cxx |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
New commits:
commit 69903b5c5f9b9015c88931c0eb8a47b52ea3de12
Author: Eike Rathke
AuthorDate: Thu Jun 13 20:25:49 2019 +0200
Commit: Eike Rathke
CommitDate: Thu Jun 13 23:07:31 2019 +0200
Resolves: tdf#113541 handle external reference in Excel syntax
... not only OOXML. This wasn't only a problem when creating a
reference by clicking or travelling to a cell in the external
document, but also when editing an external reference in Excel_A1
or Excel_R1C1 reference syntax.
Change-Id: Iee3d529ff9834e5013a61c2056238277f33356fe
Reviewed-on: https://gerrit.libreoffice.org/73979
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index 6e8f9e402a4f..440a229c947d 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -2134,11 +2134,14 @@ Label_MaskStateMachine:
}
else if( nMask & ScCharFlags::Char )
{
-// '[' is a special case in OOXML, it can start an external
-// reference ID like [1]Sheet1!A1 that needs to be scanned
+// '[' is a special case in Excel syntax, it can start an
+// external reference, ID in OOXML like [1]Sheet1!A1 or
+// Excel_A1 [filename]Sheet!A1 or Excel_R1C1
+// [filename]Sheet!R1C1 that needs to be scanned
// entirely, or can be ocTableRefOpen, of which the first
// transforms an ocDBArea into an ocTableRef.
-if (c == '[' && FormulaGrammar::isOOXML( meGrammar) &&
eLastOp != ocDBArea && maTableRefs.empty())
+if (c == '[' && FormulaGrammar::isExcelSyntax( meGrammar)
+&& eLastOp != ocDBArea && maTableRefs.empty())
{
nMask &= ~ScCharFlags::Char;
goto Label_MaskStateMachine;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
