[Libreoffice-bugs] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 Dieter Praas changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #18 from Dieter Praas --- (In reply to Todd from comment #16) > On your test document, Default style is indeed Portrait. I can page break > Landscape or Portrait (Default) from any page. Hmmm, now I have a > workaround template. That's the intended behaviour for working with styles. If you need more informations you should have a look into documentation: https://wiki.documentfoundation.org/images/b/b6/WG6009-WorkingWithStyles.odt => RESOLVED WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/sidebar/SidebarController.cxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit b25284244a4a0e5ff480538133ee18f471a4bfc8
Author: Samuel Mehrbrodt
AuthorDate: Tue Jul 30 11:18:45 2019 +0200
Commit: Samuel Mehrbrodt
CommitDate: Wed Jul 31 07:12:13 2019 +0200
tdf#126508 Fix crash when changing icon style
Regression from b58aa94f1f365c746135470bceb97cc182c289bc
Change-Id: I253447c197d8b333e26f243e26794e775f3edcee
Reviewed-on: https://gerrit.libreoffice.org/76589
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
diff --git a/sfx2/source/sidebar/SidebarController.cxx
b/sfx2/source/sidebar/SidebarController.cxx
index 4dd30f0b1a71..f2f532ff12b2 100644
--- a/sfx2/source/sidebar/SidebarController.cxx
+++ b/sfx2/source/sidebar/SidebarController.cxx
@@ -729,6 +729,8 @@ void SidebarController::SwitchToDeck (
const DeckDescriptor& rDeckDescriptor,
const Context& rContext)
{
+maFocusManager.Clear();
+
const bool bForceNewDeck
((mnRequestedForceFlags_ForceNewDeck)!=0);
const bool bForceNewPanels
((mnRequestedForceFlags_ForceNewPanels)!=0);
mnRequestedForceFlags = SwitchFlag_NoForce;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 117199] FILEOPEN Grouping of shapes are not imported to LO Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=117199 Bartosz changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |gan...@poczta.onet.pl |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117199] FILEOPEN Grouping of shapes are not imported to LO Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=117199 --- Comment #13 from Bartosz --- Created attachment 153062 --> https://bugs.documentfoundation.org/attachment.cgi?id=153062=edit Grouped and ungrouped shapes in Visio15 format -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124141] Create a document analyser for LibreOffice triage and QA
https://bugs.documentfoundation.org/show_bug.cgi?id=124141 --- Comment #4 from Ebrain Mirambeau --- I took a look at ipshii1...@gmail.com 's solution and I think that it's both incomplete and written in Python. I would like to work on it. Any objections? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88481] Editing : Value become zero on DDE Link Break on reopen
https://bugs.documentfoundation.org/show_bug.cgi?id=88481 Buovjaga changed: What|Removed |Added Resolution|WORKSFORME |--- Status|RESOLVED|NEW --- Comment #7 from Buovjaga --- Not fixed, still repro by breaking link in odt, saving & reloading. Arch Linux 64-bit Version: 6.4.0.0.alpha0+ Build ID: 4bd1b38633d6cb288eb559afc0ac6b961538ae60 CPU threads: 8; OS: Linux 5.2; UI render: default; VCL: gtk3; Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US Calc: threaded Built on 24 July 2019 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126503] Gridlines within tree widgets on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=126503 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109231] FILEOPEN: XML: General Error up to LO 6.0 and wrong data from 6.1 when the data contains a < symbol
https://bugs.documentfoundation.org/show_bug.cgi?id=109231 --- Comment #13 from QA Administrators --- Dear Oleg K, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122299] Base/Writer MailMerge: Saved "Label Document": Error Message "The data source was not found."
https://bugs.documentfoundation.org/show_bug.cgi?id=122299 --- Comment #5 from QA Administrators --- Dear OldIronSides1797, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121760] Can't delete wrong file in extensions (LO Draw)
https://bugs.documentfoundation.org/show_bug.cgi?id=121760 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70111] CSV files to keep the original text delimiters and separators
https://bugs.documentfoundation.org/show_bug.cgi?id=70111 --- Comment #7 from QA Administrators --- Dear oliver nadj, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97166] Fileopen: .docx: Some formulas with wrong syntax aren't correctly imported (OK in Word)
https://bugs.documentfoundation.org/show_bug.cgi?id=97166 --- Comment #12 from QA Administrators --- Dear Rolle, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118640] Editing a Base file results in unreadable total record count.
https://bugs.documentfoundation.org/show_bug.cgi?id=118640 --- Comment #9 from QA Administrators --- Dear mitchell93210, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121760] Can't delete wrong file in extensions (LO Draw)
https://bugs.documentfoundation.org/show_bug.cgi?id=121760 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - sc/source
sc/source/core/data/table2.cxx |2 +-
sc/source/ui/unoobj/fmtuno.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit dec9dec4d2a51612c301019f4becd41227b56df4
Author: Aron Budea
AuthorDate: Sun Jul 28 05:51:40 2019 +0200
Commit: Aron Budea
CommitDate: Wed Jul 31 04:26:29 2019 +0200
tdf#125800: accessing cond format props in UNO throws error
These conditions were always evaluated to true: OR should
become AND when negated.
Regression from 8c637b47d9de4b3a64c33a9c2ffe7ed220be2467
Change-Id: I87038319ed27eff2bed2412da49e01f73ec0a79c
Reviewed-on: https://gerrit.libreoffice.org/76493
Reviewed-by: Gülşah Köse
Reviewed-by: Aron Budea
Tested-by: Aron Budea
(cherry picked from commit 9ad8f83912e6cf14d7b3b3e1cb2a79d819247c82)
Reviewed-on: https://gerrit.libreoffice.org/76705
Tested-by: Jenkins CollaboraOffice
diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx
index 632f53d43d99..d5217874a7c3 100644
--- a/sc/source/core/data/table2.cxx
+++ b/sc/source/core/data/table2.cxx
@@ -2160,7 +2160,7 @@ void ScTable::FindMaxRotCol( RowInfo* pRowInfo, SCSIZE
nArrCount, SCCOL nX1, SCC
for (size_t nEntry=0; nEntryGetEntry(nEntry);
-if(pEntry->GetType() !=
ScFormatEntry::Type::Condition ||
+if(pEntry->GetType() !=
ScFormatEntry::Type::Condition &&
pEntry->GetType() !=
ScFormatEntry::Type::ExtCondition)
continue;
diff --git a/sc/source/ui/unoobj/fmtuno.cxx b/sc/source/ui/unoobj/fmtuno.cxx
index 22dda7d06faf..84354f2b404f 100644
--- a/sc/source/ui/unoobj/fmtuno.cxx
+++ b/sc/source/ui/unoobj/fmtuno.cxx
@@ -159,7 +159,7 @@ ScTableConditionalFormat::ScTableConditionalFormat(
{
ScCondFormatEntryItem aItem;
const ScFormatEntry* pFrmtEntry = pFormat->GetEntry(i);
-if(pFrmtEntry->GetType() != ScFormatEntry::Type::Condition
||
+if(pFrmtEntry->GetType() != ScFormatEntry::Type::Condition
&&
pFrmtEntry->GetType() !=
ScFormatEntry::Type::ExtCondition)
continue;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125800] Properties .ConditionalFormat, .ConditionalFormatXML, .ConditionalFormatLocal of a SheetCellRange wrongly show .Count=0
https://bugs.documentfoundation.org/show_bug.cgi?id=125800 Aron Budea changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED Assignee|libreoffice-b...@lists.free |ba...@caesar.elte.hu |desktop.org | --- Comment #3 from Aron Budea --- This should be fixed now. Backports to 6.3 and 6.3.0 are in gerrit, let's hope they arrive in time for 6.3.0.3. There's no unit test for now, I might add one sometimes, we'll see. Nevertheless, let's close this now. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104742] [META] Network-involved bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=104742 Bug 104742 depends on bug 126241, which changed state. Bug 126241 Summary: Trying to switching to edit mode with a document in use isn't informative https://bugs.documentfoundation.org/show_bug.cgi?id=126241 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3-0' - sw/source
sw/source/core/doc/docedt.cxx|3 ++-
sw/source/core/txtnode/ndtxt.cxx |3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
New commits:
commit d929e17d4274e569bf2453a3263c76691a89acb9
Author: Michael Stahl
AuthorDate: Mon Jul 22 19:27:11 2019 +0200
Commit: Thorsten Behrens
CommitDate: Wed Jul 31 03:55:43 2019 +0200
tdf#126340 sw_redlinehide: only move merged frames in JoinPrev
The problem was that the first and second node were not actually merged
by a redline, so moving the frames doesn't make sense.
(regression from 41d8ca9686c7c184f586e99674b443c34bfd4f33)
Change-Id: Ib401e4b0b2b207666f65c038ab5c346807bfea92
Reviewed-on: https://gerrit.libreoffice.org/76125
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 91b344b0346347ac40d2d6fa03a03e92d2e9f252)
Reviewed-on: https://gerrit.libreoffice.org/76149
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
(cherry picked from commit 680c4eac7a39b7e039d7828a3cac839395b9a36e)
Reviewed-on: https://gerrit.libreoffice.org/76533
Reviewed-by: Christian Lohmaier
Reviewed-by: Xisco Faulí
Reviewed-by: Thorsten Behrens
Tested-by: Thorsten Behrens
diff --git a/sw/source/core/doc/docedt.cxx b/sw/source/core/doc/docedt.cxx
index baf32805d516..791736f41a04 100644
--- a/sw/source/core/doc/docedt.cxx
+++ b/sw/source/core/doc/docedt.cxx
@@ -414,7 +414,8 @@ bool sw_JoinText( SwPaM& rPam, bool bJoinPrev )
}
// delete the Node, at last!
SwNode::Merge const
eOldMergeFlag(pOldTextNd->GetRedlineMergeFlag());
-if (eOldMergeFlag == SwNode::Merge::First)
+if (eOldMergeFlag == SwNode::Merge::First
+&& !pTextNd->IsCreateFrameWhenHidingRedlines())
{
sw::MoveDeletedPrevFrames(*pOldTextNd, *pTextNd);
}
diff --git a/sw/source/core/txtnode/ndtxt.cxx b/sw/source/core/txtnode/ndtxt.cxx
index 691c20f6490b..cced7186d49e 100644
--- a/sw/source/core/txtnode/ndtxt.cxx
+++ b/sw/source/core/txtnode/ndtxt.cxx
@@ -1126,7 +1126,8 @@ void SwTextNode::JoinPrev()
pDoc->CorrAbs( aIdx, SwPosition( *this ), nLen, true );
}
SwNode::Merge const eOldMergeFlag(pTextNode->GetRedlineMergeFlag());
-if (eOldMergeFlag == SwNode::Merge::First)
+if (eOldMergeFlag == SwNode::Merge::First
+&& !IsCreateFrameWhenHidingRedlines())
{
sw::MoveDeletedPrevFrames(*pTextNode, *this);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: dbaccess/source
dbaccess/source/core/dataaccess/datasource.cxx | 16 +++-
dbaccess/source/ui/dlg/dbwizsetup.cxx |1 +
2 files changed, 16 insertions(+), 1 deletion(-)
New commits:
commit 77ef0a92b3bd19f836d0fcb2a41af5e643129283
Author: Xisco Fauli
AuthorDate: Mon Jul 15 17:52:23 2019 +0200
Commit: Thorsten Behrens
CommitDate: Wed Jul 31 03:49:17 2019 +0200
tdf#121599, tdf#123099: ignore migration dialog when
1. a new HSQLDB database is created
2. the HSQLDB database is not opened interactively
Change-Id: I7287e467e06be5eec1e5c661123e1332cdaeef9b
Reviewed-on: https://gerrit.libreoffice.org/75643
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
Tested-by: Thorsten Behrens
diff --git a/dbaccess/source/core/dataaccess/datasource.cxx
b/dbaccess/source/core/dataaccess/datasource.cxx
index c3b6214e7bc8..d2afd8cc78aa 100644
--- a/dbaccess/source/core/dataaccess/datasource.cxx
+++ b/dbaccess/source/core/dataaccess/datasource.cxx
@@ -602,8 +602,22 @@ Reference< XConnection >
ODatabaseSource::buildLowLevelConnection(const OUString
Reference< XDriverManager > xManager;
#if ENABLE_FIREBIRD_SDBC
+bool bIgnoreMigration = false;
bool bNeedMigration = false;
-if(m_pImpl->m_sConnectURL == "sdbc:embedded:hsqldb")
+Reference< XModel > xModel = m_pImpl->getModel_noCreate();
+if ( xModel)
+{
+//See ODbTypeWizDialogSetup::SaveDatabaseDocument
+::comphelper::NamedValueCollection aArgs( xModel->getArgs() );
+aArgs.get("IgnoreFirebirdMigration") >>= bIgnoreMigration;
+}
+else
+{
+//ignore when we don't have a model. E.g. Mailmerge, data sources,
fields...
+bIgnoreMigration = true;
+}
+
+if(!bIgnoreMigration && m_pImpl->m_sConnectURL == "sdbc:embedded:hsqldb")
{
Reference const xRootStorage =
m_pImpl->getOrCreateRootStorage();
OUString sMigrEnvVal;
diff --git a/dbaccess/source/ui/dlg/dbwizsetup.cxx
b/dbaccess/source/ui/dlg/dbwizsetup.cxx
index 5076997c30ed..76405e537cfe 100644
--- a/dbaccess/source/ui/dlg/dbwizsetup.cxx
+++ b/dbaccess/source/ui/dlg/dbwizsetup.cxx
@@ -681,6 +681,7 @@ bool ODbTypeWizDialogSetup::SaveDatabaseDocument()
aArgs.put( "Overwrite", true );
aArgs.put( "InteractionHandler", xHandler );
aArgs.put( "MacroExecutionMode", MacroExecMode::USE_CONFIG );
+aArgs.put( "IgnoreFirebirdMigration", true );
OUString sPath =
ODbDataSourceAdministrationHelper::getDocumentUrl( *m_pOutSet );
xStore->storeAsURL( sPath, aArgs.getPropertyValues() );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/drivers/firebird/PreparedStatement.cxx |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit 54028dc503fc08eb12e287919d5e2850cff05b73
Author: Xisco Fauli
AuthorDate: Tue Jul 16 15:34:53 2019 +0200
Commit: Thorsten Behrens
CommitDate: Wed Jul 31 03:46:51 2019 +0200
tdf#123591: truncate and round to 'scale' number of decimal places
otherwise the number will be incorrectly converted to OUString
if scale < number of decimals
See https://bugs.documentfoundation.org/show_bug.cgi?id=123591#c25
Change-Id: Ie32c9c6ab339d6907e9a4e2645d6f19bad9e67c8
Reviewed-on: https://gerrit.libreoffice.org/75727
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
Tested-by: Thorsten Behrens
diff --git a/connectivity/source/drivers/firebird/PreparedStatement.cxx
b/connectivity/source/drivers/firebird/PreparedStatement.cxx
index 69ce91f42da1..71a43454f315 100644
--- a/connectivity/source/drivers/firebird/PreparedStatement.cxx
+++ b/connectivity/source/drivers/firebird/PreparedStatement.cxx
@@ -18,6 +18,7 @@
*/
#include
+#include
#include
@@ -729,7 +730,8 @@ void SAL_CALL OPreparedStatement::setObjectWithInfo(
sal_Int32 parameterIndex, c
OUString sValue;
if( x >>= dbValue )
{
-sValue = OUString::number( dbValue );
+// truncate and round to 'scale' number of decimal places
+sValue = OUString::number( std::floor((dbValue *
pow10Integer(scale)) + .5) / pow10Integer(scale) );
}
else
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126475] Incorrect displaying of context menu during mutliple cells (range) selection
https://bugs.documentfoundation.org/show_bug.cgi?id=126475 --- Comment #6 from Guilhem Moulin --- (In reply to Konstantin Tkachenko from comment #4) > Created attachment 152898 [details] > Screenshots of bug Unfortunately the attachment was lost due to a database corruption on our end. Could you please upload it again? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89631] TOC: Auto select levels control when switching to styles tab
https://bugs.documentfoundation.org/show_bug.cgi?id=89631 --- Comment #4 from Jim Raykowski --- Don't know what I did here to deserve credit? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 89631] TOC: Auto select levels control when switching to styles tab
https://bugs.documentfoundation.org/show_bug.cgi?id=89631 --- Comment #4 from Jim Raykowski --- Don't know what I did here to deserve credit? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 105013] time of digital signature is zero in File > Properties > General
https://bugs.documentfoundation.org/show_bug.cgi?id=105013 Terrence Enger changed: What|Removed |Added Status|RESOLVED|VERIFIED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105605 Bug 105605 depends on bug 105013, which changed state. Bug 105013 Summary: time of digital signature is zero in File > Properties > General https://bugs.documentfoundation.org/show_bug.cgi?id=105013 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105013] time of digital signature is zero in File > Properties > General
https://bugs.documentfoundation.org/show_bug.cgi?id=105013 Terrence Enger changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #11 from Terrence Enger --- I too see the expected time of signature in local build of master from 2019-07-15. I am setting status VERIFIED WORKSFORME. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #17 from Todd --- Do you have a tool where you can binary view the document I posted and your document too and compare the headers? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106427] failure to diagnose invalid file: URL
https://bugs.documentfoundation.org/show_bug.cgi?id=106427 --- Comment #11 from Terrence Enger --- I get results like Drew Jensen (comment # 9) with ... a local build of commit f34a525a, 2019-07-15, configured CC=ccache /usr/bin/gcc CXX=ccache /usr/bin/g++ CCFLAGS=-Wshadow --with-jdk-home=/usr/lib/jvm/default-java --enable-split-debug --enable-gdb-index --enable-ld=gold --enable-option-checking=fatal #--enable-dbgutil --enable-debug --without-system-postgresql --without-myspell-dicts --with-extra-buildid --without-doxygen --with-external-tar=/home/terry/lo_hacking/git/src --without-package-format built and running on debian-buster. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #16 from Todd --- On your test document, Default style is indeed Portrait. I can page break Landscape or Portrait (Default) from any page. Hmmm, now I have a workaround template. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #15 from Todd --- Created attachment 153061 --> https://bugs.documentfoundation.org/attachment.cgi?id=153061=edit Manual Break Style Dropdown Portrait no where to be found. Also used the down arrow key to make sure something wasn't hiding under the list, but it just went to the top of the list after hitting the bottom. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #14 from Todd --- (In reply to Dieter Praas from comment #13) > (In reply to Todd from comment #12) > > (In reply to Dieter Praas from comment #11) > > > Created attachment 153053 [details] > > > Example of landscape and portrait > > > See attachment. > > > > EVERYTHING in your example is Landscape. > > I don't understand, why it works perfect for me. Perhaps there's a problem > with your user profile. Could you please try it in Save Mode?(Last idea I > have) Are you running Linux or Windows? First, my bad, I had not scrolled properly on your test document and it indeed was landscape first and portrait second is both normal and safe mode. $ libreoffice6.2 --safe-mode Now in safe mode, I tested by first setting the initial page to Landscape, then doing the manual page break thing. No joy. Default was still Landscape and no Portrait in the drop down. I will post a screen shot of the drop down. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117750] Some of the image filters aren't working (like Aging or Relief)
https://bugs.documentfoundation.org/show_bug.cgi?id=117750 --- Comment #4 from Regina Henschel --- The filters "Smooth", "Solarize" and "Sepia" do not work in Version: 6.4.0.0.alpha0+ (x64) Build ID: 9105b85c708f42024ce063b9a944466c0afdfe9a CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-06-28_22:42:37 Locale: de-DE (en_US); UI-Language: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: qadevOOo/tests registry/source
qadevOOo/tests/java/ifc/text/_XTextContent.java |2 +-
qadevOOo/tests/java/ifc/text/_XTextRangeCompare.java|4 ++--
qadevOOo/tests/java/ifc/ucb/_XContentIdentifierFactory.java |2 +-
qadevOOo/tests/java/ifc/ui/_XUIConfiguration.java |2 +-
qadevOOo/tests/java/ifc/util/_XStringSubstitution.java |4 ++--
qadevOOo/tests/java/ifc/view/_XScreenCursor.java|2 +-
qadevOOo/tests/java/mod/_defreg/NestedRegistry.java |4 ++--
qadevOOo/tests/java/mod/_fwk/JobExecutor.java |2 +-
qadevOOo/tests/java/mod/_fwk/JobHandler.java|2 +-
qadevOOo/tests/java/mod/_fwk/ModuleManager.java |2 +-
qadevOOo/tests/java/mod/_nestedreg/uno/NestedRegistry.java |4 ++--
qadevOOo/tests/java/mod/_sc/ScTabViewObj.java |6 +++---
qadevOOo/tests/java/mod/_sch/ChXDiagram.java|2 +-
registry/source/keyimpl.cxx |2 +-
14 files changed, 20 insertions(+), 20 deletions(-)
New commits:
commit ca6df519a78e5bfc96030c916f242b86306194e5
Author: Andrea Gelmini
AuthorDate: Tue Jul 30 08:03:32 2019 +0200
Commit: Andrea Gelmini
CommitDate: Tue Jul 30 23:47:47 2019 +0200
Fix typos
Change-Id: Ia5fba032635adbf85bdfcb1eb0b3ffb9cf9d4a6a
Reviewed-on: https://gerrit.libreoffice.org/76548
Reviewed-by: Julien Nabet
Tested-by: Andrea Gelmini
diff --git a/qadevOOo/tests/java/ifc/text/_XTextContent.java
b/qadevOOo/tests/java/ifc/text/_XTextContent.java
index 3b6a5e0a4578..bcb65b806343 100644
--- a/qadevOOo/tests/java/ifc/text/_XTextContent.java
+++ b/qadevOOo/tests/java/ifc/text/_XTextContent.java
@@ -52,7 +52,7 @@ public class _XTextContent extends MultiMethodTest {
/**
* Tries to get the anchor of the text content
* an XTextRange is returned.
- * The test is OK if an not null text range is returned
+ * The test is OK if a not null text range is returned
*/
public void _getAnchor() {
log.println("getAnchor()");
diff --git a/qadevOOo/tests/java/ifc/text/_XTextRangeCompare.java
b/qadevOOo/tests/java/ifc/text/_XTextRangeCompare.java
index 4dedd74cf6d9..47d389c9a4af 100644
--- a/qadevOOo/tests/java/ifc/text/_XTextRangeCompare.java
+++ b/qadevOOo/tests/java/ifc/text/_XTextRangeCompare.java
@@ -67,7 +67,7 @@ public class _XTextRangeCompare extends MultiMethodTest {
/**
* Retrieves XText interface from relation 'TEXTDOC'
* or from 'TEXT'.
- * @throws StatusException If neither 'TEXTDOC' nore 'TEXT'
+ * @throws StatusException If neither 'TEXTDOC' nor 'TEXT'
* relation exists.
*/
@Override
@@ -87,7 +87,7 @@ public class _XTextRangeCompare extends MultiMethodTest {
if (oText == null) {
throw new StatusException(Status.failed
-("Neither 'TEXTDOC' nore 'TEXT' relation not found")) ;
+("Neither 'TEXTDOC' nor 'TEXT' relation not found")) ;
}
}
diff --git a/qadevOOo/tests/java/ifc/ucb/_XContentIdentifierFactory.java
b/qadevOOo/tests/java/ifc/ucb/_XContentIdentifierFactory.java
index d129579e1ff4..6a66dae9ee63 100644
--- a/qadevOOo/tests/java/ifc/ucb/_XContentIdentifierFactory.java
+++ b/qadevOOo/tests/java/ifc/ucb/_XContentIdentifierFactory.java
@@ -43,7 +43,7 @@ public class _XContentIdentifierFactory extends
MultiMethodTest {
/**
* Calls the tested method with a file url and
* gets an identifier.
- * Has OK status if content identifier an provider sheme are
+ * Has OK status if content identifier and provider scheme are
* proper.
*/
public void _createContentIdentifier() {
diff --git a/qadevOOo/tests/java/ifc/ui/_XUIConfiguration.java
b/qadevOOo/tests/java/ifc/ui/_XUIConfiguration.java
index 8b880e67cf7c..73290288c89c 100644
--- a/qadevOOo/tests/java/ifc/ui/_XUIConfiguration.java
+++ b/qadevOOo/tests/java/ifc/ui/_XUIConfiguration.java
@@ -63,7 +63,7 @@ public class _XUIConfiguration extends MultiMethodTest {
}
/**
- * adds a listener an fire an event
+ * adds a listener and fires an event
* Has OK status if listener was called
*/
public void _addConfigurationListener() {
diff --git a/qadevOOo/tests/java/ifc/util/_XStringSubstitution.java
b/qadevOOo/tests/java/ifc/util/_XStringSubstitution.java
index a19ecbaf467c..77d5fe5fbb43 100644
--- a/qadevOOo/tests/java/ifc/util/_XStringSubstitution.java
+++ b/qadevOOo/tests/java/ifc/util/_XStringSubstitution.java
@@ -37,7 +37,7 @@ public class _XStringSubstitution extends MultiMethodTest {
tRes.tested("getSubstituteVariableValue()",false);
}
try {
-log.println("try to get a invalid variable...");
+log.println("try to get an invalid variable...");
String toCheck = "$(ThisVariableShouldNoExist)";
oObj.getSubstituteVariableValue(toCheck);
[Libreoffice-commits] core.git: editeng/source
editeng/source/editeng/impedit.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 682be3766c50a648883cd4c7cd4e24cdab29a075 Author: Andrea Gelmini AuthorDate: Tue Jul 30 18:53:54 2019 +0200 Commit: Andrea Gelmini CommitDate: Tue Jul 30 23:47:18 2019 +0200 Removed duplicated include Change-Id: I2b1b7bb2cd88be4be518d045d54a0f0ee8583b8b Reviewed-on: https://gerrit.libreoffice.org/76713 Reviewed-by: Julien Nabet Tested-by: Andrea Gelmini diff --git a/editeng/source/editeng/impedit.cxx b/editeng/source/editeng/impedit.cxx index 5b7de9ae81e3..a827c87d8d4b 100644 --- a/editeng/source/editeng/impedit.cxx +++ b/editeng/source/editeng/impedit.cxx @@ -40,7 +40,6 @@ #include #include #include -#include #include #include #include ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126631] New: [REGRESSION] Iterating objects in a slide with an image fails
https://bugs.documentfoundation.org/show_bug.cgi?id=126631 Bug ID: 126631 Summary: [REGRESSION] Iterating objects in a slide with an image fails Product: LibreOffice Version: 6.4.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hi-an...@yandex.ru Created attachment 153060 --> https://bugs.documentfoundation.org/attachment.cgi?id=153060=edit Script that simply connects to Impress and iterates over 1st slide objects On current master, if a slide has an image (tested with PNG and JPG), iterating over slide objects and accessing ShapeType property results in __main__.RuntimeException: Binary URP bridge disposed during call # Steps to reproduce: 1. Run `soffice.bin --impress --accept="socket,host=localhost,port=2002;urp;StarOffice.ServiceManager"` (an Impress window should appear) 2. Copy this image to the new presentation https://wiki.documentfoundation.org/images/8/8c/BHS_large_6.3_RC2.png 3. Run the attached script as `python test.py` ## Expected No output ## Actual Script fails as: $ python test.py Traceback (most recent call last): File "test.py", line 30, in [item for item in slide if item.ShapeType == 'com.sun.star.drawing.TableShape'] File "test.py", line 30, in [item for item in slide if item.ShapeType == 'com.sun.star.drawing.TableShape'] __main__.RuntimeException: Binary URP bridge disposed during call # Additional information Info for a version without the problem Version: 6.2.5.2 Build ID: 6.2.5-1 CPU threads: 4; OS: Linux 5.2; UI render: default; VCL: gtk3; Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US Calc: threaded Info for a version where the problem is present: Version: 6.4.0.0.alpha0+ Build ID: 236593a0544ea41e37d35b8fac83b31d0e7c5b67 CPU threads: 4; OS: Linux 5.2; UI render: default; VCL: gtk3; Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: qadevOOo/runner qadevOOo/tests testtools/source
qadevOOo/runner/helper/APIDescGetter.java |2 +-
qadevOOo/tests/java/mod/_connector/uno/package.html |2 +-
qadevOOo/tests/java/mod/_connectr/package.html |2 +-
testtools/source/performance/ubtest.cxx |2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
New commits:
commit 7166b64c9ac101a0dc1363c31f892095a2097cbe
Author: Andrea Gelmini
AuthorDate: Tue Jul 30 07:43:51 2019 +0200
Commit: Julien Nabet
CommitDate: Tue Jul 30 23:04:38 2019 +0200
Fix typo in code
"connectr"
Please look at:
https://gerrit.libreoffice.org/#/c/76543/1
Change-Id: I3862780f92b8ce4583d642e3f653389a4ef3cc22
Reviewed-on: https://gerrit.libreoffice.org/76575
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/qadevOOo/runner/helper/APIDescGetter.java
b/qadevOOo/runner/helper/APIDescGetter.java
index 25a2db220357..65f8da05c99d 100644
--- a/qadevOOo/runner/helper/APIDescGetter.java
+++ b/qadevOOo/runner/helper/APIDescGetter.java
@@ -942,7 +942,7 @@ public class APIDescGetter extends DescGetter
ArrayList removed = new ArrayList();
removed.add("acceptor");
removed.add("brdgfctr");
-removed.add("connectr");
+removed.add("connector");
removed.add("corefl");
removed.add("cpld");
removed.add("defreg");
diff --git a/qadevOOo/tests/java/mod/_connector/uno/package.html
b/qadevOOo/tests/java/mod/_connector/uno/package.html
index e4d67d4bdd8c..c9ff7b2b5596 100644
--- a/qadevOOo/tests/java/mod/_connector/uno/package.html
+++ b/qadevOOo/tests/java/mod/_connector/uno/package.html
@@ -18,6 +18,6 @@
-->
-Contains all test cases for the module 'connectr'.
+Contains all test cases for the module 'connector'.
diff --git a/qadevOOo/tests/java/mod/_connectr/package.html
b/qadevOOo/tests/java/mod/_connectr/package.html
index e4d67d4bdd8c..c9ff7b2b5596 100644
--- a/qadevOOo/tests/java/mod/_connectr/package.html
+++ b/qadevOOo/tests/java/mod/_connectr/package.html
@@ -18,6 +18,6 @@
-->
-Contains all test cases for the module 'connectr'.
+Contains all test cases for the module 'connector'.
diff --git a/testtools/source/performance/ubtest.cxx
b/testtools/source/performance/ubtest.cxx
index cc17f097d1b8..283e73d699c9 100644
--- a/testtools/source/performance/ubtest.cxx
+++ b/testtools/source/performance/ubtest.cxx
@@ -342,7 +342,7 @@ static void createInstance( Reference< T > & rxOut,
xMgr, Reference< XRegistryKey >() ) ) );
// connector
xSet->insert( makeAny( loadLibComponentFactory(
-OUString("connectr"),
+OUString("connector"),
OUString("com.sun.star.comp.stoc.Connector"),
xMgr, Reference< XRegistryKey >() ) ) );
// iiop bridge
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126611] XML Form Document: instance Data Navigator isn't shown in toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=126611 --- Comment #13 from andreas_k --- thanks for reporting the bug. Form feedback is rare and always welcome. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126611] XML Form Document: instance Data Navigator isn't shown in toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=126611 andreas_k changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126629] Writer reads some n-dashes as words - Editing
https://bugs.documentfoundation.org/show_bug.cgi?id=126629 V Stuart Foote changed: What|Removed |Added Blocks||102345 CC||vstuart.fo...@utsa.edu Status|UNCONFIRMED |NEW Severity|normal |trivial Ever confirmed|0 |1 --- Comment #2 from V Stuart Foote --- In OOXML the run is "Earth – not" Which on filter import to Writer gives a text run of U+0020 U+00AD U+2013 U+0020 So, seems the filter assigned U+00AD (SOFT HYPHEN) in combination with the (EN DASH) and bounded by spaces is treated as an edit engine word, increasing the word count. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102345 [Bug 102345] [META] Formatting marks (aka Non-printing characters) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102345] [META] Formatting marks (aka Non-printing characters) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102345 V Stuart Foote changed: What|Removed |Added Depends on||126629 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=126629 [Bug 126629] Writer reads some n-dashes as words - Editing -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126630] New: Tela preta em algumas janelas do pacote LibreOfiice
https://bugs.documentfoundation.org/show_bug.cgi?id=126630 Bug ID: 126630 Summary: Tela preta em algumas janelas do pacote LibreOfiice Product: LibreOffice Version: 6.3.0.1 rc Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: wsalmei...@gmail.com Description: Estou usando libre office versão Pacote: libreoffice (1: 6.3.0 ~ rc2-1) no Debian porém percebi algumas telas estão com fundo preto. Steps to Reproduce: 1.Abre um aplicativo do libre office 2. clique em ajuda depois sobre 3. a Janela exibida fica com fundo preto Actual Results: Abra um aplicativo da suite, na barra de ferramentas clique em ajuda, depois sobre. Expected Results: Janela está com fundo preto Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Abrir a janela na cor padrão do sistema. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91472] ODF export; Impress fields do not contain the expanded field value
https://bugs.documentfoundation.org/show_bug.cgi?id=91472 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #8 from Regina Henschel --- Still as described in Version: 6.4.0.0.alpha0+ (x64) Build ID: 9105b85c708f42024ce063b9a944466c0afdfe9a CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-06-28_22:42:37 Locale: de-DE (en_US); UI-Language: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126609] LibreOffice Calc seems to struggle to handle field graphs.
https://bugs.documentfoundation.org/show_bug.cgi?id=126609 guillaume.amel...@gmail.com changed: What|Removed |Added Status|NEEDINFO|REOPENED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126609] LibreOffice Calc seems to struggle to handle field graphs.
https://bugs.documentfoundation.org/show_bug.cgi?id=126609 --- Comment #3 from guillaume.amel...@gmail.com --- Hi m.a.riosv, I tried with LibreOffice 6.2.5.2 on Windows 10, with openCL activated. The result is the same. something like 5 minutes to save or exit the editing mode on the graph on "Map" sheet. Thank you for your advice about replacing INDIRECT with INDEX. I will take a closer look at this. On the other hand, the culprit is definitely the graph because when you delete it, saving the file only takes few seconds. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121045] FILEOPEN DOCX OLE form control checkbox is larger than in Word
https://bugs.documentfoundation.org/show_bug.cgi?id=121045 Gabor Kelemen changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||472 Summary|OLE form control checkbox |FILEOPEN DOCX OLE form |is larger than in Word |control checkbox is larger ||than in Word Blocks||104523 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104523 [Bug 104523] [META] DOCX (OOXML) ActiveX and Legacy form control related issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119021] Finalized configuration item Calc - Formula - Syntax still editable
https://bugs.documentfoundation.org/show_bug.cgi?id=119021 Gabor Kelemen changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |kelem...@ubuntu.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104523] [META] DOCX (OOXML) ActiveX and Legacy form control related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104523 Gabor Kelemen changed: What|Removed |Added Depends on||121045 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=121045 [Bug 121045] FILEOPEN DOCX OLE form control checkbox is larger than in Word -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92472] FILEOPEN: First legacy checkbox in row has too large dimensions on docx import
https://bugs.documentfoundation.org/show_bug.cgi?id=92472 Gabor Kelemen changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||1045 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90253] Drawing a textbox in Impress doesnt retain its height
https://bugs.documentfoundation.org/show_bug.cgi?id=90253 --- Comment #7 from Regina Henschel --- The problem still exists as described in Version: 6.4.0.0.alpha0+ (x64) Build ID: 9105b85c708f42024ce063b9a944466c0afdfe9a CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-06-28_22:42:37 Locale: de-DE (en_US); UI-Language: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117651] AutoCorrect does not change preexisting text inside /slashes/ to italics, nor change -strikethrough-
https://bugs.documentfoundation.org/show_bug.cgi?id=117651 --- Comment #8 from Regina Henschel --- The error still exists in Version: 6.4.0.0.alpha0+ (x64) Build ID: 9105b85c708f42024ce063b9a944466c0afdfe9a CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-06-28_22:42:37 Locale: de-DE (en_US); UI-Language: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - compilerplugins/clang cui/source include/svx solenv/clang-format svx/Library_svxcore.mk svx/source sw/source
compilerplugins/clang/constantparam.booleans.results |8
compilerplugins/clang/overrideparam.cxx |4
cui/source/options/optfltr.cxx | 22 +-
include/svx/checklbx.hxx | 68
solenv/clang-format/blacklist|4
svx/Library_svxcore.mk |1
svx/source/dialog/checklbx.cxx | 161 ---
sw/source/uibase/inc/optcomp.hxx |1
sw/source/uibase/inc/optload.hxx |1
9 files changed, 13 insertions(+), 257 deletions(-)
New commits:
commit ee0613bd9ed3a9539f1ebb58b51962c9ccd13376
Author: Caolán McNamara
AuthorDate: Tue Jul 30 16:43:44 2019 +0100
Commit: Caolán McNamara
CommitDate: Tue Jul 30 21:14:29 2019 +0200
bFirst means 1st vs 2nd column, and needs to alternate on each loop
this went wrong at...
commit f423ac2d3bdba4263f1f41e31e7e2b7715afdd6e
Date: Tue Mar 5 15:16:16 2019 +0200
remove sal_IntPtr in OfaMSFilterTabPage2
and just use a scoped enum
Change-Id: I74bcca9ffee9faf4600da64b3c409dbf19a1290e
Reviewed-on: https://gerrit.libreoffice.org/76619
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/cui/source/options/optfltr.cxx b/cui/source/options/optfltr.cxx
index d11c655a472f..54d7e5817fe2 100644
--- a/cui/source/options/optfltr.cxx
+++ b/cui/source/options/optfltr.cxx
@@ -210,12 +210,14 @@ bool OfaMSFilterTabPage2::FillItemSet( SfxItemSet* )
::SetSmartArt2Shape },
};
-bool bCheck, bFirst = true;
+bool bFirstCol = true;
for( const ChkCBoxEntries & rEntry : aChkArr )
{
-sal_uInt16 nCol = bFirst ? 1 : 2;
-if (bFirst)
-bFirst = false;
+// we loop through the list, alternating reading the first/second
column,
+// each row appears twice in the list (except for smartart, which is
import
+// only
+sal_uInt16 nCol = bFirstCol ? 1 : 2;
+bFirstCol = !bFirstCol;
SvTreeListEntry* pEntry = GetEntry4Type( rEntry.eType );
if( pEntry )
{
@@ -223,7 +225,7 @@ bool OfaMSFilterTabPage2::FillItemSet( SfxItemSet* )
if (rItem.GetType() == SvLBoxItemType::Button)
{
SvItemStateFlags nButtonFlags = rItem.GetButtonFlags();
-bCheck = SvButtonState::Checked ==
+bool bCheck = SvButtonState::Checked ==
SvLBoxButtonData::ConvertToButtonState( nButtonFlags );
if( bCheck != (rOpt.*rEntry.FnIs)() )
@@ -283,12 +285,14 @@ void OfaMSFilterTabPage2::Reset( const SfxItemSet* )
{ MSFltrPg2_CheckBoxEntries::SmartArt,
::IsSmartArt2Shape },
};
-bool bFirst = true;
+bool bFirstCol = true;
for( const ChkCBoxEntries & rArr : aChkArr )
{
-sal_uInt16 nCol = bFirst ? 1 : 2;
-if (bFirst)
-bFirst = false;
+// we loop through the list, alternating reading the first/second
column,
+// each row appears twice in the list (except for smartart, which is
import
+// only
+sal_uInt16 nCol = bFirstCol ? 1 : 2;
+bFirstCol = !bFirstCol;
SvTreeListEntry* pEntry = GetEntry4Type( rArr.eType );
if( pEntry )
{
commit 588f50ac41666e73a7c73c13e677a9927bad991f
Author: Caolán McNamara
AuthorDate: Tue Jul 30 16:05:55 2019 +0100
Commit: Caolán McNamara
CommitDate: Tue Jul 30 21:14:11 2019 +0200
remove newly unused SvxCheckListBox
Change-Id: I6a5f4dfea9fbb34f02c1752140e04d1d0a8a67a7
Reviewed-on: https://gerrit.libreoffice.org/76617
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/compilerplugins/clang/constantparam.booleans.results
b/compilerplugins/clang/constantparam.booleans.results
index 39637cd6b887..a39ccbc292a8 100644
--- a/compilerplugins/clang/constantparam.booleans.results
+++ b/compilerplugins/clang/constantparam.booleans.results
@@ -254,10 +254,6 @@ cui/source/inc/hangulhanjadlg.hxx:60
class rtl::OUString svx::SuggestionDisplay::GetEntry(unsigned short) const
unsigned short nPos
0
-cui/source/inc/radiobtnbox.hxx:40
-void svx::SvxRadioButtonListBox::SvxRadioButtonListBox(class
SvSimpleTableContainer &,long)
-long nBits
-0
cui/source/inc/scriptdlg.hxx:122
void SvxScriptOrgDialog::insertEntry(const class rtl::OUString &,const
class rtl::OUString &,const class weld::TreeIter *,_Bool,class
std::unique_ptr >
&&,const class rtl::OUString &,_Bool)
_Bool bChildrenOnDemand
@@ -1114,10 +1110,6 @@ include/svx/algitem.hxx:39
void SvxOrientationItem::SvxOrientationItem(int,_Bool,const unsigned short)
const unsigned short nId
0
-include/svx/checklbx.hxx:55
-void SvxCheckListBox::SelectEntryPos(unsigned
[Libreoffice-commits] core.git: extras/source solenv/bin svx/source sw/source sw/uiconfig
extras/source/glade/libreoffice-catalog.xml.in |3
solenv/bin/native-code.py |1
svx/source/dialog/checklbx.cxx |2
sw/source/ui/config/optcomp.cxx| 144 ---
sw/source/uibase/inc/optcomp.hxx | 24 +--
sw/uiconfig/swriter/ui/optcompatpage.ui| 152 -
6 files changed, 188 insertions(+), 138 deletions(-)
New commits:
commit 37c01754ae0a9daaa2f37bd9c1cc9f3b3a84ce21
Author: Caolán McNamara
AuthorDate: Tue Jul 30 16:03:10 2019 +0100
Commit: Caolán McNamara
CommitDate: Tue Jul 30 21:13:56 2019 +0200
weld SwCompatibilityOptPage
Change-Id: Id66751642a631d033385c3da9ba5cd484ba9dcf6
Reviewed-on: https://gerrit.libreoffice.org/76616
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/extras/source/glade/libreoffice-catalog.xml.in
b/extras/source/glade/libreoffice-catalog.xml.in
index 1c69d1c76388..4ada0543e8ad 100644
--- a/extras/source/glade/libreoffice-catalog.xml.in
+++ b/extras/source/glade/libreoffice-catalog.xml.in
@@ -150,9 +150,6 @@
-
diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py
index 9679d3d26d01..d6d90b3caac1 100755
--- a/solenv/bin/native-code.py
+++ b/solenv/bin/native-code.py
@@ -498,7 +498,6 @@ custom_widgets = [
'SvtURLBox',
'Svx3DPreviewControl',
'SvxCharViewControl',
-'SvxCheckListBox',
'SvxColorListBox',
'SvxColorValueSet',
'SvxFillAttrBox',
diff --git a/svx/source/dialog/checklbx.cxx b/svx/source/dialog/checklbx.cxx
index 3f3c5581280e..1a9c63ad1134 100644
--- a/svx/source/dialog/checklbx.cxx
+++ b/svx/source/dialog/checklbx.cxx
@@ -31,8 +31,6 @@ SvxCheckListBox::SvxCheckListBox( vcl::Window* pParent,
WinBits nWinStyle ) :
Init_Impl();
}
-VCL_BUILDER_FACTORY_CONSTRUCTOR(SvxCheckListBox, WB_TABSTOP)
-
SvxCheckListBox::~SvxCheckListBox()
{
disposeOnce();
diff --git a/sw/source/ui/config/optcomp.cxx b/sw/source/ui/config/optcomp.cxx
index c400441c6b08..b527bf6a989f 100644
--- a/sw/source/ui/config/optcomp.cxx
+++ b/sw/source/ui/config/optcomp.cxx
@@ -52,97 +52,65 @@ struct SwCompatibilityOptPage_Impl
std::vector< SvtCompatibilityEntry > m_aList;
};
-SwCompatibilityOptPage::SwCompatibilityOptPage(vcl::Window* pParent, const
SfxItemSet& rSet)
-: SfxTabPage(pParent, "OptCompatPage",
"modules/swriter/ui/optcompatpage.ui", )
+SwCompatibilityOptPage::SwCompatibilityOptPage(TabPageParent pParent, const
SfxItemSet& rSet)
+: SfxTabPage(pParent, "modules/swriter/ui/optcompatpage.ui",
"OptCompatPage", )
, m_pWrtShell(nullptr)
, m_pImpl(new SwCompatibilityOptPage_Impl)
, m_nSavedOptions(0)
, m_bSavedMSFormsMenuOption(false)
+, m_xMain(m_xBuilder->weld_frame("compatframe"))
+, m_xGlobalOptionsFrame(m_xBuilder->weld_frame("globalcompatframe"))
+, m_xFormattingLB(m_xBuilder->weld_combo_box("format"))
+, m_xGlobalOptionsLB(m_xBuilder->weld_combo_box("globaloptions"))
+, m_xOptionsLB(m_xBuilder->weld_tree_view("options"))
+, m_xGlobalOptionsCLB(m_xBuilder->weld_tree_view("globaloptioncheckbox"))
+, m_xDefaultPB(m_xBuilder->weld_button("default"))
{
-get(m_pMain, "compatframe");
-get(m_pGlobalOptionsFrame, "globalcompatframe");
-get(m_pFormattingLB, "format");
-get(m_pGlobalOptionsLB, "globaloptions");
-get(m_pOptionsLB, "options");
-get(m_pGlobalOptionsCLB, "globaloptioncheckbox");
-get(m_pDefaultPB, "default");
+std::vector aWidths;
+aWidths.push_back(m_xOptionsLB->get_checkbox_column_width());
+m_xOptionsLB->set_column_fixed_widths(aWidths);
+m_xGlobalOptionsCLB->set_column_fixed_widths(aWidths);
+int nPos = 0;
for ( int i = static_cast(SvtCompatibilityEntry::Index::Module) + 1;
i < static_cast(SvtCompatibilityEntry::Index::INVALID); ++i )
{
int nCoptIdx = i - 2; /* Do not consider "Name" & "Module" indexes */
-const OUString sEntry = m_pFormattingLB->GetEntry( nCoptIdx );
-SvTreeListEntry* pEntry = m_pOptionsLB->SvTreeListBox::InsertEntry(
sEntry );
-if ( pEntry )
-{
-m_pOptionsLB->SetCheckButtonState( pEntry,
SvButtonState::Unchecked );
-}
+const OUString sEntry = m_xFormattingLB->get_text(nCoptIdx);
+m_xOptionsLB->append();
+m_xOptionsLB->set_toggle(nPos, TRISTATE_FALSE, 0);
+m_xOptionsLB->set_text(nPos, sEntry, 1);
+++nPos;
}
-m_sUserEntry =
m_pFormattingLB->GetEntry(m_pFormattingLB->GetEntryCount()-1);
-
-m_pFormattingLB->Clear();
-
-m_pOptionsLB->SetStyle( m_pOptionsLB->GetStyle() | WB_HSCROLL |
WB_HIDESELECTION );
-m_pOptionsLB->SetHighlightRange();
+m_sUserEntry = m_xFormattingLB->get_text(m_xFormattingLB->get_count() - 1);
+m_xFormattingLB->clear();
// Set MSOCompatibleFormsMenu entry attributes
const bool bReadOnly =
[Libreoffice-commits] core.git: vcl/source
vcl/source/app/IconThemeScanner.cxx|4 ++--
vcl/source/app/i18nhelp.cxx|2 +-
vcl/source/app/salvtables.cxx |2 +-
vcl/source/control/field.cxx |2 +-
vcl/source/control/field2.cxx |4 ++--
vcl/source/control/fmtfield.cxx|2 +-
vcl/source/control/imp_listbox.cxx |2 +-
vcl/source/filter/igif/gifread.cxx |2 +-
vcl/source/filter/ipdf/pdfdocument.cxx |2 +-
vcl/source/filter/png/pngread.cxx |2 +-
vcl/source/font/PhysicalFontCollection.cxx |2 +-
vcl/source/fontsubset/sft.cxx |6 +++---
vcl/source/gdi/bitmap3.cxx |2 +-
vcl/source/gdi/gdimetafiletools.cxx|2 +-
vcl/source/gdi/pdfextoutdevdata.cxx|2 +-
vcl/source/gdi/pdfwriter_impl.hxx |2 +-
vcl/source/gdi/print.cxx |2 +-
vcl/source/gdi/salgdilayout.cxx|2 +-
vcl/source/gdi/scrptrun.cxx|4 ++--
vcl/source/outdev/font.cxx |2 +-
vcl/source/outdev/text.cxx |2 +-
vcl/source/treelist/imap.cxx |2 +-
vcl/source/treelist/svtabbx.cxx|4 ++--
vcl/source/window/accessibility.cxx|2 +-
vcl/source/window/builder.cxx |2 +-
vcl/source/window/menu.cxx |2 +-
vcl/source/window/split.cxx|2 +-
vcl/source/window/splitwin.cxx |2 +-
vcl/source/window/stacking.cxx |4 ++--
vcl/source/window/toolbox.cxx |2 +-
vcl/source/window/window.cxx |4 ++--
31 files changed, 39 insertions(+), 39 deletions(-)
New commits:
commit f93a345ab5d35aadb5bbbd501df10ff2521c8104
Author: Andrea Gelmini
AuthorDate: Tue Jul 30 07:54:09 2019 +0200
Commit: Andrea Gelmini
CommitDate: Tue Jul 30 20:58:56 2019 +0200
Fix typos
Change-Id: Ib737ff364f627b9e4d0dc2a9903a07a0af36a8ae
Reviewed-on: https://gerrit.libreoffice.org/76551
Tested-by: Jenkins
Reviewed-by: Andrea Gelmini
diff --git a/vcl/source/app/IconThemeScanner.cxx
b/vcl/source/app/IconThemeScanner.cxx
index 0e290eaf0617..0eba21837245 100644
--- a/vcl/source/app/IconThemeScanner.cxx
+++ b/vcl/source/app/IconThemeScanner.cxx
@@ -48,7 +48,7 @@ OUString convert_to_absolute_path(const OUString& path)
SAL_WARN("vcl.app", "Could not resolve path '" << path << "' to search
for icon themes.");
if (rc == osl::FileBase::E_MULTIHOP)
{
-throw std::runtime_error("Provided a recursive symlink to a icon
theme directory that could not be resolved.");
+throw std::runtime_error("Provided a recursive symlink to an icon
theme directory that could not be resolved.");
}
}
return resolver.m_aStatus.getFileURL();
@@ -143,7 +143,7 @@ IconThemeScanner::ReadIconThemesFromPath(const OUString&
dir)
/*static*/ bool
IconThemeScanner::FileIsValidIconTheme(const OUString& filename)
{
-// check whether we can construct a IconThemeInfo from it
+// check whether we can construct an IconThemeInfo from it
if (!IconThemeInfo::UrlCanBeParsed(filename)) {
SAL_INFO("vcl.app", "File '" << filename << "' does not seem to be an
icon theme.");
return false;
diff --git a/vcl/source/app/i18nhelp.cxx b/vcl/source/app/i18nhelp.cxx
index a84f07386d58..ae7eed0e2fba 100644
--- a/vcl/source/app/i18nhelp.cxx
+++ b/vcl/source/app/i18nhelp.cxx
@@ -84,7 +84,7 @@ static bool is_formatting_mark( sal_Unicode c )
/* #i100057# filter formatting marks out of strings before passing them to
the transliteration. The real solution would have been an additional
TransliterationModule
- to ignore these marks during transliteration; however changin the code in
i18npool that actually
+ to ignore these marks during transliteration; however changing the code in
i18npool that actually
implements this could produce unwanted side effects.
Of course this copying around is not really good, but looking at i18npool,
one more time
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index bf50e7bc6ce2..3f77e9220f83 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -679,7 +679,7 @@ public:
virtual VclPtr create_virtual_device() const override
{
-// create with (annoying) seperate alpha layer that LibreOffice itself
uses
+// create with (annoying) separate alpha layer that LibreOffice itself
uses
return VclPtr::Create(*Application::GetDefaultDevice(),
DeviceFormat::DEFAULT, DeviceFormat::DEFAULT);
}
diff --git a/vcl/source/control/field.cxx b/vcl/source/control/field.cxx
index 5b343b5a83f4..be87437c06a2 100644
--- a/vcl/source/control/field.cxx
+++ b/vcl/source/control/field.cxx
@@ -1576,7 +1576,7 @@ void MetricField::SetLast( sal_Int64 nNewLast, FieldUnit
eInUnit )
[Libreoffice-bugs] [Bug 126629] Writer reads some n-dashes as words - Editing
https://bugs.documentfoundation.org/show_bug.cgi?id=126629 --- Comment #1 from stephen.sott...@inbox.com --- Created attachment 153059 --> https://bugs.documentfoundation.org/attachment.cgi?id=153059=edit Shows example of a dash that is not counted as a word and one that is. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126629] New: Writer reads some n-dashes as words - Editing
https://bugs.documentfoundation.org/show_bug.cgi?id=126629 Bug ID: 126629 Summary: Writer reads some n-dashes as words - Editing Product: LibreOffice Version: 6.2.5.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: stephen.sott...@inbox.com Description: I found when checking word count in a long document that Writer always was 10 words longer. I finally traced it to Writer counting some dashes as words. Neither MS Word nor Softmaker Textmaker reads these as words in their count. I can provide a document that demonstrates the difference, but it doesn't reproduce in an online form. Steps to Reproduce: 1.Not sure how the dashes that are counted were made. 2. 3. Actual Results: Some dashes are counted as words Expected Results: The count should have ignored the dashes. Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3-0' - sfx2/source
sfx2/source/sidebar/SidebarController.cxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit 63ccc97e1699d90da2532e4294cdaff670ad1a3f
Author: Samuel Mehrbrodt
AuthorDate: Tue Jul 30 11:18:45 2019 +0200
Commit: Adolfo Jayme Barrientos
CommitDate: Tue Jul 30 19:38:31 2019 +0200
tdf#126508 Fix crash when changing icon style
Regression from b58aa94f1f365c746135470bceb97cc182c289bc
Change-Id: I253447c197d8b333e26f243e26794e775f3edcee
Reviewed-on: https://gerrit.libreoffice.org/76590
Tested-by: Jenkins
Reviewed-by: Xisco Faulí
(cherry picked from commit 857f68d68b3d0092f109845cfd93482871a0793d)
Reviewed-on: https://gerrit.libreoffice.org/76613
Reviewed-by: Julien Nabet
Reviewed-by: Adolfo Jayme Barrientos
Tested-by: Adolfo Jayme Barrientos
diff --git a/sfx2/source/sidebar/SidebarController.cxx
b/sfx2/source/sidebar/SidebarController.cxx
index 24660ef3dc2f..fce4732706b5 100644
--- a/sfx2/source/sidebar/SidebarController.cxx
+++ b/sfx2/source/sidebar/SidebarController.cxx
@@ -681,6 +681,8 @@ void SidebarController::SwitchToDeck (
const DeckDescriptor& rDeckDescriptor,
const Context& rContext)
{
+maFocusManager.Clear();
+
const bool bForceNewDeck
((mnRequestedForceFlags_ForceNewDeck)!=0);
const bool bForceNewPanels
((mnRequestedForceFlags_ForceNewPanels)!=0);
mnRequestedForceFlags = SwitchFlag_NoForce;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126536] LibreOffice WRITER: Proposal to operate on several Styles simultaneously
https://bugs.documentfoundation.org/show_bug.cgi?id=126536 --- Comment #5 from Adalbert Hanßen --- (In reply to Heiko Tietze from comment #4) > ... > So the right solution is to put everything underneath a new item and change > this. Works perfectly for me and no multiselection is needed. How do I put several styles underneath one after I have created it? Of course, modifying each one separately in the section Organizer and telling to which one it is subordinate, that's an awkward solution. And how can one easily get rid off a whole bunch of unneeded styles? By the way: the multiselection it already there. My first picture shows several styles selected at once. The only thing that is missing is the function to operate on the selected bunch of styles, e.g. delete them (to get rid of such a plethora as the one introduced through the OCR process). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56120] Popup toolbar in impress position change
https://bugs.documentfoundation.org/show_bug.cgi?id=56120 Adolfo Jayme changed: What|Removed |Added Resolution|FIXED |INVALID -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77866] Filesave: Unused bitmap fill image files are kept in the document
https://bugs.documentfoundation.org/show_bug.cgi?id=77866 Adolfo Jayme changed: What|Removed |Added Resolution|FIXED |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88481] Editing : Value become zero on DDE Link Break on reopen
https://bugs.documentfoundation.org/show_bug.cgi?id=88481 Adolfo Jayme changed: What|Removed |Added Resolution|FIXED |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115251] LibreOffice draw hangs with 100% CPU after opening a pdf file
https://bugs.documentfoundation.org/show_bug.cgi?id=115251 --- Comment #12 from Miklos Vajna --- It's fine for me either way. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115251] LibreOffice draw hangs with 100% CPU after opening a pdf file
https://bugs.documentfoundation.org/show_bug.cgi?id=115251 --- Comment #11 from Telesto --- (In reply to Miklos Vajna from comment #10) > But that always worked like this, so then let's not call this a regression. > Basically Noel already did what I would have done when it comes to fixing > the perf regression. Thanks. > > (After all, first we want to be correct, and only then we want to be fast, > right? :-) ) A new bug report seems the smarter choice. It only causes trouble & confusion tracking the bug; IMHO -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57351] Calc: "Insert columns" is not available in the context menu if an autofilter to hide rows is applied
https://bugs.documentfoundation.org/show_bug.cgi?id=57351 --- Comment #24 from MattP --- Still present. Version: 6.2.5.2 Build ID: 1ec314fa52f458adc18c4f025c545a4e8b22c159 CPU threads: 8; OS: Mac OS X 10.14.5; UI render: default; VCL: osx; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded Context menu when no filter: https://imgur.com/APPfEc1.png Context menu when filtered: https://imgur.com/wK62BYq.png Menu > Sheet > Insert Columns (when filtered): https://imgur.com/9XRYx6Q.png -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126588] EDITING: Firebird: View could be executed, but crashes when trying to save
https://bugs.documentfoundation.org/show_bug.cgi?id=126588 Xisco Faulí changed: What|Removed |Added CC||noelgran...@gmail.com, ||xiscofa...@libreoffice.org Hardware|x86-64 (AMD64) |All Keywords||bibisected, bisected OS|Linux (All) |All --- Comment #3 from Xisco Faulí --- Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=d425658bd9fd8e315e4931afb544bc845da0360e author Noel Grandin 2018-12-19 16:10:51 +0200 committer Noel Grandin 2018-12-21 08:26:15 +0100 commit d425658bd9fd8e315e4931afb544bc845da0360e (patch) treea35679686a7df2a504b9088ba6807b60c52067fc parent 526387b96e9bc2c04b0dc26744bf6b88ea7c0521 (diff) pass OSQLParseNode around by unique_ptr Bisected with: bibisect-linux64-6.3 Adding Cc: to Noel Grandin -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: desktop/qa desktop/source sfx2/source
desktop/qa/desktop_lib/test_desktop_lib.cxx |4
desktop/source/lib/init.cxx | 16
sfx2/source/sidebar/SidebarChildWindow.cxx | 10 +++---
3 files changed, 27 insertions(+), 3 deletions(-)
New commits:
commit 70d3bbe11e56f12a339a5b8759b53a96b4fe84ab
Author: Ashod Nakashian
AuthorDate: Thu May 2 23:16:30 2019 -0400
Commit: Noel Grandin
CommitDate: Tue Jul 30 18:52:48 2019 +0200
sfx2: Enable sidebar on calc and writer, but not in impress
Added by Noel to this commit:
And add a special deregister mode to doc_registerCallback
so we can unregister stack-based callback objects in the
presence of multiple views.
Reviewed-on: https://gerrit.libreoffice.org/71715
Reviewed-by: Jan Holesovsky
Tested-by: Jan Holesovsky
(cherry picked from commit fba6d4267b3f827269d6550dcb003cc56b31e493)
Change-Id: I8d846bc1f794cf16fd45486fd83ef87f43fd52c7
Reviewed-on: https://gerrit.libreoffice.org/76555
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index e0647da2f6af..112f29f4c59e 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -1939,6 +1939,7 @@ void DesktopLOKTest::testWriterCommentInsertCursor()
CPPUNIT_ASSERT(aView1.m_aOwnCursor.IsEmpty());
Scheduler::ProcessEventsToIdle();
+pDocument->m_pDocumentClass->registerCallback(pDocument, nullptr,
reinterpret_cast(1));
}
#if HAVE_MORE_FONTS
@@ -2210,6 +2211,8 @@ void DesktopLOKTest::testCommentsCallbacksWriter()
CPPUNIT_ASSERT(!aStream.str().empty());
boost::property_tree::read_json(aStream, aTree);
CPPUNIT_ASSERT_EQUAL(static_cast(5),
aTree.get_child("comments").size());
+
+pDocument->m_pDocumentClass->registerCallback(pDocument, nullptr,
reinterpret_cast(1));
}
void DesktopLOKTest::testRunMacro()
@@ -2629,6 +2632,7 @@ void DesktopLOKTest::testShowHideDialog()
Scheduler::ProcessEventsToIdle();
CPPUNIT_ASSERT_EQUAL(std::string("invalidate"),
aView.m_aCallbackWindowResult.get("action"));
+pDocument->m_pDocumentClass->registerCallback(pDocument, nullptr,
reinterpret_cast(1));
}
namespace {
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index f8d93534f44a..89078209ef43 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -2828,6 +2828,22 @@ static void doc_registerCallback(LibreOfficeKitDocument*
pThis,
LibLODocument_Impl* pDocument = static_cast(pThis);
+// This is used by unit-tests to unregister stack-local callback objects
where we have multiple views
+// so we cannot rely on SfxLokHelper::getView
+if (pCallback == nullptr && pData != nullptr)
+{
+for (auto& pair1 : pDocument->mpCallbackFlushHandlers)
+{
+int nView = pair1.first;
+for (auto& pair2 : pDocument->mpCallbackFlushHandlers)
+{
+pair2.second->removeViewStates(nView);
+}
+pDocument->mpCallbackFlushHandlers[nView].reset(new
CallbackFlushHandler(pThis, nullptr, nullptr));
+}
+return;
+}
+
int nView = SfxLokHelper::getView();
if (nView < 0)
return;
diff --git a/sfx2/source/sidebar/SidebarChildWindow.cxx
b/sfx2/source/sidebar/SidebarChildWindow.cxx
index 678c5538aa0b..b958d840dd3b 100644
--- a/sfx2/source/sidebar/SidebarChildWindow.cxx
+++ b/sfx2/source/sidebar/SidebarChildWindow.cxx
@@ -33,7 +33,7 @@ SFX_IMPL_DOCKINGWINDOW_WITHID(SidebarChildWindow,
SID_SIDEBAR);
SidebarChildWindow::SidebarChildWindow(vcl::Window* pParentWindow, sal_uInt16
nId,
SfxBindings* pBindings,
SfxChildWinInfo* pInfo)
: SfxChildWindow(pParentWindow, nId)
-, mbSidebarVisibleInLOK(pInfo && pInfo->aModule == "simpress")
+, mbSidebarVisibleInLOK(pInfo && (pInfo->aModule == "scalc" ||
pInfo->aModule == "swriter"))
{
auto pDockWin = VclPtr::Create(
pBindings, *this, pParentWindow, WB_STDDOCKWIN |
WB_OWNERDRAWDECORATION | WB_CLIPCHILDREN
@@ -53,8 +53,12 @@ SidebarChildWindow::SidebarChildWindow(vcl::Window*
pParentWindow, sal_uInt16 nI
// HACK: unfortunately I haven't found a clean solution to do
// this, so do it this way:
//
-pDockWin->SetSizePixel(Size(TabBar::GetDefaultWidth() *
GetWindow()->GetDPIScaleFactor(),
-pDockWin->GetSizePixel().Height()));
+if (!comphelper::LibreOfficeKit::isActive())
+{
+pDockWin->SetSizePixel(
+Size(TabBar::GetDefaultWidth() *
GetWindow()->GetDPIScaleFactor(),
+ pDockWin->GetSizePixel().Height()));
+}
}
pDockWin->Initialize(pInfo);
___
Libreoffice-commits mailing list
[Libreoffice-bugs] [Bug 80177] PIVOTTABLE: Date format PostgreSQL
https://bugs.documentfoundation.org/show_bug.cgi?id=80177 --- Comment #20 from mshi...@uzerp.com --- Chaps Have tested using both and ods and postgreSQL as a source. Bug is still present. Concur with comment 18 that the filter section of the report shows the values as dates Version: 6.0.7.3 Build ID: 1:6.0.7-0ubuntu0.18.04.8 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: en-GB (en_GB.UTF-8); Calc: group Regs Martyn -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left (aka Complex Text Layout) language issues (RTL/CTL)
https://bugs.documentfoundation.org/show_bug.cgi?id=43808 Bug 43808 depends on bug 126605, which changed state. Bug 126605 Summary: Sidebar: Setting textbox directionality with Hebrew text crashes Impress https://bugs.documentfoundation.org/show_bug.cgi?id=126605 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/qa svx/source
sd/qa/uitest/impress_tests/tdf126605.py | 28
svx/source/svdraw/svdedtv1.cxx |2 --
2 files changed, 28 insertions(+), 2 deletions(-)
New commits:
commit 6eae30f631ec9b0f2b1415c06f4c36a3d6e13055
Author: Xisco Fauli
AuthorDate: Tue Jul 30 15:51:58 2019 +0200
Commit: Xisco Faulí
CommitDate: Tue Jul 30 18:39:26 2019 +0200
tdf#126605: Do not end TextEdit when changing an attribute
otherwise, pTextEditOutlinerView becomes nullptr in
svx/source/svdraw/svdedxv.cxx:2184
Regression from e6c7a018a0cfee395ce2886d41c908a2447ef5cc
Change-Id: I9d0645f637dc92b50d01682d119c0db60238e921
Reviewed-on: https://gerrit.libreoffice.org/76606
Tested-by: Jenkins
Reviewed-by: Xisco Faulí
diff --git a/sd/qa/uitest/impress_tests/tdf126605.py
b/sd/qa/uitest/impress_tests/tdf126605.py
new file mode 100644
index ..744324717a6b
--- /dev/null
+++ b/sd/qa/uitest/impress_tests/tdf126605.py
@@ -0,0 +1,28 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+from uitest.framework import UITestCase
+from libreoffice.uno.propertyvalue import mkPropertyValues
+
+class tdf126605(UITestCase):
+
+ def test_run(self):
+self.ui_test.create_doc_in_start_center("impress")
+xTemplateDlg = self.xUITest.getTopFocusWindow()
+xCancelBtn = xTemplateDlg.getChild("cancel")
+self.ui_test.close_dialog_through_button(xCancelBtn)
+
+xDoc = self.xUITest.getTopFocusWindow()
+xEdit = xDoc.getChild("impress_win")
+xEdit.executeAction("TYPE", mkPropertyValues({"TEXT":"test"}))
+
+# Without the accompanying fix in place, it would crash at this point
+self.xUITest.executeCommand(".uno:ParaRightToLeft")
+self.xUITest.executeCommand(".uno:ParaLeftToRight")
+
+self.ui_test.close_doc()
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/svx/source/svdraw/svdedtv1.cxx b/svx/source/svdraw/svdedtv1.cxx
index 44c4b2fe5201..b75099094576 100644
--- a/svx/source/svdraw/svdedtv1.cxx
+++ b/svx/source/svdraw/svdedtv1.cxx
@@ -765,8 +765,6 @@ void SdrEditView::SetNotPersistAttrToMarked(const
SfxItemSet& rAttr)
}
const bool bUndo = IsUndoEnabled();
-if( bUndo )
-EndTextEditAllViews();
// TODO: check if WhichRange is necessary.
const size_t nMarkCount=GetMarkedObjectCount();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126309] Opening RTF document with Hebrew RLT (right to left) text is shown with the text written from left to right
https://bugs.documentfoundation.org/show_bug.cgi?id=126309 Xisco Faulí changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=94 ||435, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=86 ||182 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126309] Opening RTF document with Hebrew RLT (right to left) text is shown with the text written from left to right
https://bugs.documentfoundation.org/show_bug.cgi?id=126309 Xisco Faulí changed: What|Removed |Added Ever confirmed|0 |1 Keywords||bibisected, bisected, ||regression CC||vmik...@collabora.com, ||xiscofa...@libreoffice.org Whiteboard| QA:needsComment| Status|UNCONFIRMED |NEW Version|6.2.4.2 release |5.0 all versions OS|Linux (All) |All --- Comment #4 from Xisco Faulí --- Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=4ee2a882dddb395a816cd54004b634d57cfb2446 author Miklos Vajna 2015-04-17 10:44:47 +0200 committer Miklos Vajna 2015-04-17 11:35:27 +0200 commit 4ee2a882dddb395a816cd54004b634d57cfb2446 (patch) tree5214a7e75d9a185d56f22538af4317798778 parent 7e5980ccf39b54240524f059a65497b766af91cc (diff) tdf#86182 RTF import: fix handling of \rtlpar Bisected with: bibisect-50max Adding Cc: to Miklos Vajna -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74861] [Spreadsheet] Exporting A4-sized ODS to PDF with '--headless' creates Letter-sized PDF (where manual export via GUI creates A4)
https://bugs.documentfoundation.org/show_bug.cgi?id=74861 --- Comment #52 from himajin100...@gmail.com --- hmmm, it seems my guess in previous comment is wrong. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126619] Embedded Draw object in Writer does not show content after load of document
https://bugs.documentfoundation.org/show_bug.cgi?id=126619 Xisco Faulí changed: What|Removed |Added Ever confirmed|0 |1 CC||xiscofa...@libreoffice.org Status|UNCONFIRMED |NEEDINFO --- Comment #2 from Xisco Faulí --- Thank you for reporting the bug. Please attach a sample document, as this makes it easier for us to verify the bug. (Please note that the attachment will be public, remove any sensitive information before attaching it. See https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F for help on how to do so.) I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126233] Breeze: Change table border to be more cell-like
https://bugs.documentfoundation.org/show_bug.cgi?id=126233 Xisco Faulí changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |riz_17_...@yahoo.co.id |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126251] Colibre: Change Minimize Presentation icon from image to be slide
https://bugs.documentfoundation.org/show_bug.cgi?id=126251 Xisco Faulí changed: What|Removed |Added Ever confirmed|0 |1 CC||xiscofa...@libreoffice.org Assignee|libreoffice-b...@lists.free |riz_17_...@yahoo.co.id |desktop.org | Status|UNCONFIRMED |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126233] Breeze: Change table border to be more cell-like
https://bugs.documentfoundation.org/show_bug.cgi?id=126233 Xisco Faulí changed: What|Removed |Added Ever confirmed|0 |1 CC||xiscofa...@libreoffice.org Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126581] FORMATTING - Date format default changes
https://bugs.documentfoundation.org/show_bug.cgi?id=126581 Oliver Brinzing changed: What|Removed |Added CC||xoano...@yahoo.com --- Comment #3 from Oliver Brinzing --- *** Bug 126606 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126606] LibreOffice Calc 6.2.5.2 (x64) automatically changes date format upon entering new data.
https://bugs.documentfoundation.org/show_bug.cgi?id=126606 Oliver Brinzing changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||oliver.brinz...@gmx.de Resolution|--- |DUPLICATE --- Comment #1 from Oliver Brinzing --- *** This bug has been marked as a duplicate of bug 126581 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122890] Launching LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=122890 Oliver Brinzing changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #4 from Oliver Brinzing --- this issue is still reproducible with LO 6.1.6.3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: extras/source
extras/source/glade/libreoffice-catalog.xml.in |3 --- 1 file changed, 3 deletions(-) New commits: commit 4289b91d490b40420cb69d585937c892b2cb6261 Author: Caolán McNamara AuthorDate: Tue Jul 30 15:19:10 2019 +0100 Commit: Caolán McNamara CommitDate: Tue Jul 30 18:05:15 2019 +0200 svxlo-SvxCheckListBox doesn't exist, svxcorelo-SvxCheckListBox does Change-Id: I2aca664de328381e5beda5fb70bd58aa40f68abf Reviewed-on: https://gerrit.libreoffice.org/76612 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/extras/source/glade/libreoffice-catalog.xml.in b/extras/source/glade/libreoffice-catalog.xml.in index a6d14e665c5a..1c69d1c76388 100644 --- a/extras/source/glade/libreoffice-catalog.xml.in +++ b/extras/source/glade/libreoffice-catalog.xml.in @@ -191,9 +191,6 @@ - ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115251] LibreOffice draw hangs with 100% CPU after opening a pdf file
https://bugs.documentfoundation.org/show_bug.cgi?id=115251 Miklos Vajna changed: What|Removed |Added Keywords|bibisected, bisected, | |regression | --- Comment #10 from Miklos Vajna --- OK, let's do that. So I profiled this with callgrind and as far as I see the next thing we could do is to improve the sdext/ code to produce flat ODF which has no replacement graphics, since it'll be just discarded on ODF import anyway. But that always worked like this, so then let's not call this a regression. Basically Noel already did what I would have done when it comes to fixing the perf regression. Thanks. (After all, first we want to be correct, and only then we want to be fast, right? :-) ) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125800] Properties .ConditionalFormat, .ConditionalFormatXML, .ConditionalFormatLocal of a SheetCellRange wrongly show .Count=0
https://bugs.documentfoundation.org/show_bug.cgi?id=125800 --- Comment #2 from Commit Notification --- Aron Budea committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/9ad8f83912e6cf14d7b3b3e1cb2a79d819247c82%5E%21 tdf#125800: accessing cond format props in UNO throws error It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - cui/uiconfig sc/source
cui/uiconfig/ui/bulletandposition.ui | 368 ---
sc/source/core/data/table2.cxx |2
sc/source/ui/unoobj/fmtuno.cxx |2
3 files changed, 174 insertions(+), 198 deletions(-)
New commits:
commit 9ad8f83912e6cf14d7b3b3e1cb2a79d819247c82
Author: Aron Budea
AuthorDate: Sun Jul 28 05:51:40 2019 +0200
Commit: Aron Budea
CommitDate: Tue Jul 30 18:03:33 2019 +0200
tdf#125800: accessing cond format props in UNO throws error
These conditions were always evaluated to true: OR should
become AND when negated.
Regression from 8c637b47d9de4b3a64c33a9c2ffe7ed220be2467
Change-Id: I87038319ed27eff2bed2412da49e01f73ec0a79c
Reviewed-on: https://gerrit.libreoffice.org/76493
Reviewed-by: Gülşah Köse
Reviewed-by: Aron Budea
Tested-by: Aron Budea
diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx
index 5b182c897b4b..09aa36d30f53 100644
--- a/sc/source/core/data/table2.cxx
+++ b/sc/source/core/data/table2.cxx
@@ -2191,7 +2191,7 @@ void ScTable::FindMaxRotCol( RowInfo* pRowInfo, SCSIZE
nArrCount, SCCOL nX1, SCC
for (size_t nEntry=0; nEntryGetEntry(nEntry);
-if(pEntry->GetType() !=
ScFormatEntry::Type::Condition ||
+if(pEntry->GetType() !=
ScFormatEntry::Type::Condition &&
pEntry->GetType() !=
ScFormatEntry::Type::ExtCondition)
continue;
diff --git a/sc/source/ui/unoobj/fmtuno.cxx b/sc/source/ui/unoobj/fmtuno.cxx
index 51f271d42b91..484b011d57b7 100644
--- a/sc/source/ui/unoobj/fmtuno.cxx
+++ b/sc/source/ui/unoobj/fmtuno.cxx
@@ -161,7 +161,7 @@ ScTableConditionalFormat::ScTableConditionalFormat(
{
ScCondFormatEntryItem aItem;
const ScFormatEntry* pFrmtEntry = pFormat->GetEntry(i);
-if(pFrmtEntry->GetType() != ScFormatEntry::Type::Condition
||
+if(pFrmtEntry->GetType() != ScFormatEntry::Type::Condition
&&
pFrmtEntry->GetType() !=
ScFormatEntry::Type::ExtCondition)
continue;
commit 392fe03c2622a69c078adb9b993b5589e8b01d09
Author: Gülşah Köse
AuthorDate: Tue Jul 30 11:55:55 2019 +0300
Commit: Gülşah Köse
CommitDate: Tue Jul 30 18:03:28 2019 +0200
tdf#125642 Fix layout issues for Bullet dialog.
Change-Id: Ieacd060a8bfe4e2123e6973e30789e029ab02ca6
Reviewed-on: https://gerrit.libreoffice.org/76587
Tested-by: Jenkins
Reviewed-by: Gülşah Köse
diff --git a/cui/uiconfig/ui/bulletandposition.ui
b/cui/uiconfig/ui/bulletandposition.ui
index c27d72e5dd4e..8e90e6219aab 100644
--- a/cui/uiconfig/ui/bulletandposition.ui
+++ b/cui/uiconfig/ui/bulletandposition.ui
@@ -403,73 +403,63 @@
0
none
-
+
True
False
-12
+6
-
-350
+
True
False
+Before:
+True
+prefix
+0
+
+
+0
+0
+
+
+
+
+130
+True
+True
start
-6
-17
-
-
-True
-False
-Before:
-True
-prefix
-0
-
-
-False
-True
-0
-
-
[Libreoffice-bugs] [Bug 125800] Properties .ConditionalFormat, .ConditionalFormatXML, .ConditionalFormatLocal of a SheetCellRange wrongly show .Count=0
https://bugs.documentfoundation.org/show_bug.cgi?id=125800 Commit Notification changed: What|Removed |Added Whiteboard||target:6.4.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125902] [META] Impress Bullets New Dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=125902 Bug 125902 depends on bug 125642, which changed state. Bug 125642 Summary: Layout issues of new Bullet & Numbering dialog in Impress when VCL plugin is not gtk https://bugs.documentfoundation.org/show_bug.cgi?id=125642 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99746] [META] PDF import filter in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=99746 Bug 99746 depends on bug 115251, which changed state. Bug 115251 Summary: LibreOffice draw hangs with 100% CPU after opening a pdf file https://bugs.documentfoundation.org/show_bug.cgi?id=115251 What|Removed |Added Status|RESOLVED|NEW Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115251] LibreOffice draw hangs with 100% CPU after opening a pdf file
https://bugs.documentfoundation.org/show_bug.cgi?id=115251 Xisco Faulí changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|NEW --- Comment #9 from Xisco Faulí --- These are my findings: in Version: 5.3.0.0.alpha1+ Build ID: 4136757b4e51c4e6f7cb4132c95538a7f831ef2c CPU Threads: 4; OS Version: Linux 4.15; UI Render: default; VCL: gtk3; Layout Engine: new; Locale: ca-ES (ca_ES.UTF-8); Calc: group it takes real0m10,072s user0m9,171s sys 0m0,250s in Version: 6.2.0.0.alpha1+ Build ID: a20a2d7e0d28658f2d9089da076961a599833a28 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded it takes real1m54,790s user1m50,198s sys 0m0,787s and in Version: 6.4.0.0.alpha0+ Build ID: 850693273970be2662cce8f4d2710b3657a02f65 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded it takes real0m40,405s user0m36,665s sys 0m0,444s so in master and 6.3 it's much better than 6.2, but not as good as it was in 5.4 ( 4 times slower for me ). I think it's fair to keep it open -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126628] Default Font for shapes is Liberation Sans and in Text Style it's Noto Sans
https://bugs.documentfoundation.org/show_bug.cgi?id=126628 andreas_k changed: What|Removed |Added Keywords||needsUXEval CC||kain...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126628] New: Default Font for shapes is Liberation Sans and in Text Style it's Noto Sans
https://bugs.documentfoundation.org/show_bug.cgi?id=126628 Bug ID: 126628 Summary: Default Font for shapes is Liberation Sans and in Text Style it's Noto Sans Product: LibreOffice Version: 6.4.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kain...@gmail.com Styles support in Draw is not that good available as in writer, but there are even some styles. for example there is an font style Text A4 or Text A0 the problem is if you draw an textbox the default font style is Liberation Sans and 18px hight. If you select Text A4 style you get Noto Sans 10px. I don't have an issue with Noto Sans, but if you forget only at one Textbox to change the Text to Text A4 Style, than you have an mix of different fonts on one page. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74861] [Spreadsheet] Exporting A4-sized ODS to PDF with '--headless' creates Letter-sized PDF (where manual export via GUI creates A4)
https://bugs.documentfoundation.org/show_bug.cgi?id=74861 --- Comment #51 from himajin100...@gmail.com --- I wonder what if a new page style other than "Default" is created and such page style is applied to the file. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/Library_cui.mk cui/source
cui/Library_cui.mk |1
cui/source/inc/radiobtnbox.hxx | 53 --
cui/source/options/optjava.cxx |1
cui/source/options/radiobtnbox.cxx | 86 -
4 files changed, 141 deletions(-)
New commits:
commit f356fbd7585ab2a41bcc6554a65b8a51588d0469
Author: Caolán McNamara
AuthorDate: Tue Jul 30 13:08:11 2019 +0100
Commit: Caolán McNamara
CommitDate: Tue Jul 30 17:45:22 2019 +0200
drop newly unused SvxRadioButtonListBox
Change-Id: Idb80fa73fad6e4bb2a1eaa3d55d7fe90e86c8965
Reviewed-on: https://gerrit.libreoffice.org/76605
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/cui/Library_cui.mk b/cui/Library_cui.mk
index 620d3de8fa69..df4a94126a63 100644
--- a/cui/Library_cui.mk
+++ b/cui/Library_cui.mk
@@ -182,7 +182,6 @@ $(eval $(call gb_Library_add_exception_objects,cui,\
cui/source/options/optupdt \
$(call gb_Helper_optional,DESKTOP,\
cui/source/options/personalization) \
-cui/source/options/radiobtnbox \
cui/source/options/sdbcdriverenum \
cui/source/options/securityoptions \
cui/source/options/treeopt \
diff --git a/cui/source/inc/radiobtnbox.hxx b/cui/source/inc/radiobtnbox.hxx
deleted file mode 100644
index b9af0af621a0..
--- a/cui/source/inc/radiobtnbox.hxx
+++ /dev/null
@@ -1,53 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed
- * with this work for additional information regarding copyright
- * ownership. The ASF licenses this file to you under the Apache
- * License, Version 2.0 (the "License"); you may not use this file
- * except in compliance with the License. You may obtain a copy of
- * the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-#ifndef INCLUDED_CUI_SOURCE_INC_RADIOBTNBOX_HXX
-#define INCLUDED_CUI_SOURCE_INC_RADIOBTNBOX_HXX
-
-#include
-
-namespace svx {
-
-// class SvxRadioButtonListBox ---
-
-class SvxRadioButtonListBox : public SvSimpleTable
-{
-using SvSimpleTable::SetTabs;
-
-private:
-Point m_aCurMousePoint;
-
-protected:
-virtual voidMouseButtonUp( const MouseEvent& _rMEvt ) override;
-virtual voidKeyInput( const KeyEvent& rKEvt ) override;
-
-public:
-SvxRadioButtonListBox(SvSimpleTableContainer& rParent, WinBits nBits);
-
-voidHandleEntryChecked( SvTreeListEntry* _pEntry );
-
-const Point&GetCurMousePoint() const { return m_aCurMousePoint;}
-
-longGetControlColumnWidth() const;
-};
-
-} // end of namespace ::svx
-
-#endif // INCLUDED_CUI_SOURCE_INC_RADIOBTNBOX_HXX
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/cui/source/options/optjava.cxx b/cui/source/options/optjava.cxx
index 23b61e7e8184..654d96ac879a 100644
--- a/cui/source/options/optjava.cxx
+++ b/cui/source/options/optjava.cxx
@@ -29,7 +29,6 @@
#include "optjava.hxx"
#include
#include
-#include
#include
#include
diff --git a/cui/source/options/radiobtnbox.cxx
b/cui/source/options/radiobtnbox.cxx
deleted file mode 100644
index 555232026a3e..
--- a/cui/source/options/radiobtnbox.cxx
+++ /dev/null
@@ -1,86 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed
- * with this work for additional information regarding copyright
- * ownership. The ASF licenses this file to you under the Apache
- * License, Version 2.0 (the "License"); you may not use this file
- * except in compliance with the License. You may obtain a copy of
- * the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-#include
-
-#include
-#include
-
-namespace svx {
-
-// class SvxRadioButtonListBox
-
-SvxRadioButtonListBox::SvxRadioButtonListBox(SvSimpleTableContainer& rParent,
WinBits nBits)
-: SvSimpleTable(rParent, nBits)
-
[Libreoffice-bugs] [Bug 126627] CRASH: undoing redlinehide deletion
https://bugs.documentfoundation.org/show_bug.cgi?id=126627 Xisco Faulí changed: What|Removed |Added Keywords||bibisected, bisected, ||regression Crash report or||["sw::GotoNextLayoutTextFra crash signature||me(SwNodeIndex ||&,SwRootFrame const *)"] Status|UNCONFIRMED |NEW See Also||https://crashreport.libreof ||fice.org/stats/signature/sw ||::GotoNextLayoutTextFrame(S ||wNodeIndex%20&,SwRootFrame% ||20const%20*) CC||michael.st...@cib.de, ||xiscofa...@libreoffice.org Ever confirmed|0 |1 Version|6.4.0.0.alpha0+ Master |6.2.0.0.beta1+ --- Comment #1 from Xisco Faulí --- This started to crash after https://cgit.freedesktop.org/libreoffice/core/commit/?id=6b3d7e1d10912c7ed5d12256e6d02cbe414b3e50 author Michael Stahl 2018-10-26 17:22:48 +0200 committer Michael Stahl 2018-11-15 15:10:03 +0100 commit 6b3d7e1d10912c7ed5d12256e6d02cbe414b3e50 (patch) treed7f6fc608a9f2c18e2ed39abcdd40921ba8d96b6 parent 4d472b9b80a5c62338b7f080d5654d741c75e532 (diff) sw_redlinehide_3: adapt even more SwEditShell Num Bisected with: bibisect-linux64-6.3 Adding Cc: to Michael Stahl -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sfx2/source
sfx2/source/view/viewfrm.cxx | 56 ---
1 file changed, 56 deletions(-)
New commits:
commit 4236bb79017795bb743035d7d34690ed0df627fd
Author: Andras Timar
AuthorDate: Sun Jul 14 20:28:13 2019 +0200
Commit: Andras Timar
CommitDate: Tue Jul 30 17:44:57 2019 +0200
[cp] remove donate and community involvement infobars
Change-Id: I37c9c76eb88dea4effa786b62755ea8738efc3e0
Reviewed-on: https://gerrit.libreoffice.org/75600
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Andras Timar
diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx
index ee298b2bc55c..e623ce9a6304 100644
--- a/sfx2/source/view/viewfrm.cxx
+++ b/sfx2/source/view/viewfrm.cxx
@@ -1271,62 +1271,6 @@ void SfxViewFrame::Notify( SfxBroadcaster& /*rBC*/,
const SfxHint& rHint )
rBind.Invalidate( SID_RELOAD );
rBind.Invalidate( SID_EDITDOC );
-// inform about the community involvement
-const sal_Int64 nLastGetInvolvedShown =
officecfg::Setup::Product::LastTimeGetInvolvedShown::get();
-const sal_Int64 nNow =
std::chrono::duration_cast(std::chrono::system_clock::now().time_since_epoch()).count();
-const sal_Int64 nPeriodSec(60 * 60 * 24 * 180); // 180 days in
seconds
-bool bUpdateLastTimeGetInvolvedShown = false;
-
-if (nLastGetInvolvedShown == 0)
-bUpdateLastTimeGetInvolvedShown = true;
-else if (nPeriodSec < nNow && nLastGetInvolvedShown < (nNow +
nPeriodSec/2) - nPeriodSec) // 90d alternating with donation
-{
-bUpdateLastTimeGetInvolvedShown = true;
-
-VclPtr pInfoBar =
AppendInfoBar("getinvolved", SfxResId(STR_GET_INVOLVED_TEXT),
InfoBarType::Info);
-
-VclPtrInstance
xGetInvolvedButton(());
-
xGetInvolvedButton->SetText(SfxResId(STR_GET_INVOLVED_BUTTON));
-
xGetInvolvedButton->SetSizePixel(xGetInvolvedButton->GetOptimalSize());
-xGetInvolvedButton->SetClickHdl(LINK(this, SfxViewFrame,
GetInvolvedHandler));
-pInfoBar->addButton(xGetInvolvedButton);
-}
-
-if (bUpdateLastTimeGetInvolvedShown
-&&
!officecfg::Setup::Product::LastTimeGetInvolvedShown::isReadOnly())
-{
-std::shared_ptr
batch(comphelper::ConfigurationChanges::create());
-
officecfg::Setup::Product::LastTimeGetInvolvedShown::set(nNow, batch);
-batch->commit();
-}
-
-// inform about donations
-const sal_Int64 nLastDonateShown =
officecfg::Setup::Product::LastTimeDonateShown::get();
-bool bUpdateLastTimeDonateShown = false;
-
-if (nLastDonateShown == 0)
-bUpdateLastTimeDonateShown = true;
-else if (nPeriodSec < nNow && nLastDonateShown < nNow -
nPeriodSec) // 90d alternating with getinvolved
-{
-bUpdateLastTimeDonateShown = true;
-
-VclPtr pInfoBar =
AppendInfoBar("getdonate", SfxResId(STR_GET_DONATE_TEXT), InfoBarType::Info);
-
-VclPtrInstance xGetDonateButton(());
-xGetDonateButton->SetText(SfxResId(STR_GET_DONATE_BUTTON));
-
xGetDonateButton->SetSizePixel(xGetDonateButton->GetOptimalSize());
-xGetDonateButton->SetClickHdl(LINK(this, SfxViewFrame,
GetDonateHandler));
-pInfoBar->addButton(xGetDonateButton);
-}
-
-if (bUpdateLastTimeDonateShown
-&&
!officecfg::Setup::Product::LastTimeDonateShown::isReadOnly())
-{
-std::shared_ptr
batch(comphelper::ConfigurationChanges::create());
-officecfg::Setup::Product::LastTimeDonateShown::set(nNow,
batch);
-batch->commit();
-}
-
// read-only infobar if necessary
const SfxViewShell *pVSh;
const SfxShell *pFSh;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126627] New: CRASH: undoing redlinehide deletion
https://bugs.documentfoundation.org/show_bug.cgi?id=126627 Bug ID: 126627 Summary: CRASH: undoing redlinehide deletion Product: LibreOffice Version: 6.4.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: xiscofa...@libreoffice.org Steps to reproduce: 1. Open attachment 152718 from bug 126340 2. Place the cursor before 'bar' 3. Hit backspace 4 times -> Foo and bar are together 4. Undo once -> Crash Reproduced in Version: 6.4.0.0.alpha0+ Build ID: 850693273970be2662cce8f4d2710b3657a02f65 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103309] [META] Print dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103309 Dieter Praas changed: What|Removed |Added Depends on||126622 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=126622 [Bug 126622] DOCX PRINTING: Duplicate lines from footer in center second page document (preview in print dialog) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126622] DOCX PRINTING: Duplicate lines from footer in center second page document (preview in print dialog)
https://bugs.documentfoundation.org/show_bug.cgi?id=126622 Dieter Praas changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Blocks||103309 CC||dgp-m...@gmx.de Summary|Duplicate lines from footer |DOCX PRINTING: Duplicate |in center second page |lines from footer in center |document|second page document ||(preview in print dialog) --- Comment #2 from Dieter Praas --- I confirm it with Version: 6.2.5.2 (x64) Build-ID: 1ec314fa52f458adc18c4f025c545a4e8b22c159 CPU-Threads: 4; BS: Windows 10.0; UI-Render: GL; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: threaded and Version: 6.4.0.0.alpha0+ (x64) Build ID: 8f98a7c4e5b1f0b249c026577805a378b8a533d5 CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-07-23_00:30:19 Locale: de-DE (de_DE); UI-Language: en-US Calc: threaded I can't see additional lines in File => Print preview. I can see additional lines on page 2 in print preview of the printing dalog Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103309 [Bug 103309] [META] Print dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104930] please handle 'hang' baseline feature of OpenType fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=104930 --- Comment #28 from Volga --- (In reply to Elie Roux from comment #13) > To support the BASE table in LO, the BASE table must first be exposed by > Harfbuzz, it's not the case yet, but see > > https://github.com/behdad/harfbuzz/issues/418 This is fixed, so we are able to fix if HarfBuzz released a new version. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source cui/uiconfig
cui/source/options/personalization.cxx | 51 -
cui/source/options/personalization.hxx | 11 +++
cui/uiconfig/ui/personalization_tab.ui |9 +++--
3 files changed, 31 insertions(+), 40 deletions(-)
New commits:
commit af20b49acb34694febf2a3ba79207b25a70a68cd
Author: Caolán McNamara
AuthorDate: Tue Jul 30 15:02:05 2019 +0100
Commit: Caolán McNamara
CommitDate: Tue Jul 30 17:19:14 2019 +0200
weld SvxPersonalizationTabPage
Change-Id: I5240fc4237d8b471b2c23a8bc776cffa46a53285
Reviewed-on: https://gerrit.libreoffice.org/76607
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/cui/source/options/personalization.cxx
b/cui/source/options/personalization.cxx
index e7c68fccb495..cdb6d805f525 100644
--- a/cui/source/options/personalization.cxx
+++ b/cui/source/options/personalization.cxx
@@ -44,45 +44,35 @@ using namespace ::com::sun::star::uno;
using namespace ::com::sun::star::ucb;
using namespace ::com::sun::star::beans;
-SvxPersonalizationTabPage::SvxPersonalizationTabPage(vcl::Window* pParent,
const SfxItemSet& rSet)
-: SfxTabPage(pParent, "PersonalizationTabPage",
"cui/ui/personalization_tab.ui", )
+// persona
+SvxPersonalizationTabPage::SvxPersonalizationTabPage(TabPageParent pParent,
const SfxItemSet& rSet)
+: SfxTabPage(pParent, "cui/ui/personalization_tab.ui",
"PersonalizationTabPage", )
+, m_xNoPersona(m_xBuilder->weld_radio_button("no_persona"))
+, m_xDefaultPersona(m_xBuilder->weld_radio_button("default_persona"))
{
-// persona
-get(m_pNoPersona, "no_persona");
-get(m_pDefaultPersona, "default_persona");
-
for (sal_uInt32 i = 0; i < MAX_DEFAULT_PERSONAS; ++i)
{
-OUString sDefaultId("default" + OUString::number(i));
-get(m_vDefaultPersonaImages[i], OUStringToOString(sDefaultId,
RTL_TEXTENCODING_UTF8));
-m_vDefaultPersonaImages[i]->SetClickHdl(
+OString sDefaultId("default" + OString::number(i));
+m_vDefaultPersonaImages[i] = m_xBuilder->weld_button(sDefaultId);
+m_vDefaultPersonaImages[i]->connect_clicked(
LINK(this, SvxPersonalizationTabPage, DefaultPersona));
}
LoadDefaultImages();
}
-SvxPersonalizationTabPage::~SvxPersonalizationTabPage() { disposeOnce(); }
-
-void SvxPersonalizationTabPage::dispose()
-{
-m_pNoPersona.clear();
-m_pDefaultPersona.clear();
-for (VclPtr& i : m_vDefaultPersonaImages)
-i.clear();
-SfxTabPage::dispose();
-}
+SvxPersonalizationTabPage::~SvxPersonalizationTabPage() {}
VclPtr SvxPersonalizationTabPage::Create(TabPageParent pParent,
const SfxItemSet* rSet)
{
-return VclPtr::Create(pParent.pParent, *rSet);
+return VclPtr::Create(pParent, *rSet);
}
bool SvxPersonalizationTabPage::FillItemSet(SfxItemSet*)
{
// persona
OUString aPersona("default");
-if (m_pNoPersona->IsChecked())
+if (m_xNoPersona->get_active())
aPersona = "no";
bool bModified = false;
@@ -128,9 +118,9 @@ void SvxPersonalizationTabPage::Reset(const SfxItemSet*)
}
if (aPersona == "no")
-m_pNoPersona->Check();
+m_xNoPersona->set_active(true);
else
-m_pDefaultPersona->Check();
+m_xDefaultPersona->set_active(true);
}
void SvxPersonalizationTabPage::LoadDefaultImages()
@@ -164,22 +154,21 @@ void SvxPersonalizationTabPage::LoadDefaultImages()
INetURLObject aURLObj(gallery + aPreviewFile);
aFilter.ImportGraphic(aGraphic, aURLObj);
-BitmapEx aBmp = aGraphic.GetBitmapEx();
-m_vDefaultPersonaImages[nIndex]->SetModeImage(Image(aBmp));
-m_vDefaultPersonaImages[nIndex]->SetQuickHelpText(aName);
-m_vDefaultPersonaImages[nIndex++]->Show();
+m_vDefaultPersonaImages[nIndex]->set_image(aGraphic.GetXGraphic());
+m_vDefaultPersonaImages[nIndex]->set_tooltip_text(aName);
+m_vDefaultPersonaImages[nIndex++]->show();
foundOne = true;
}
-m_pDefaultPersona->Enable(foundOne);
+m_xDefaultPersona->set_sensitive(foundOne);
}
-IMPL_LINK(SvxPersonalizationTabPage, DefaultPersona, Button*, pButton, void)
+IMPL_LINK(SvxPersonalizationTabPage, DefaultPersona, weld::Button&, rButton,
void)
{
-m_pDefaultPersona->Check();
+m_xDefaultPersona->set_active(true);
for (sal_Int32 nIndex = 0; nIndex < MAX_DEFAULT_PERSONAS; ++nIndex)
{
-if (pButton == m_vDefaultPersonaImages[nIndex])
+if ( == m_vDefaultPersonaImages[nIndex].get())
m_aPersonaSettings = m_vDefaultPersonaSettings[nIndex];
}
}
diff --git a/cui/source/options/personalization.hxx
b/cui/source/options/personalization.hxx
index 7930016f5d62..09fb7956003e 100644
--- a/cui/source/options/personalization.hxx
+++ b/cui/source/options/personalization.hxx
@@ -20,18 +20,17 @@ class SvxPersonalizationTabPage : public SfxTabPage
using SfxTabPage::DeactivatePage;
private:
-
[Libreoffice-commits] core.git: cui/source cui/uiconfig
cui/source/options/optjava.cxx | 300 +
cui/source/options/optjava.hxx | 63 ---
cui/uiconfig/ui/optadvancedpage.ui | 235 +---
3 files changed, 280 insertions(+), 318 deletions(-)
New commits:
commit 1aa246a8e8c7d974ab0f7bdfa16cda36cb700e03
Author: Caolán McNamara
AuthorDate: Tue Jul 30 12:59:20 2019 +0100
Commit: Caolán McNamara
CommitDate: Tue Jul 30 17:18:43 2019 +0200
weld SvxJavaOptionsPage
Change-Id: Ib37f6f554a890bd6397ae7b6c56f1615cd12b6b1
Reviewed-on: https://gerrit.libreoffice.org/76604
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/cui/source/options/optjava.cxx b/cui/source/options/optjava.cxx
index f5bcb94e0137..23b61e7e8184 100644
--- a/cui/source/options/optjava.cxx
+++ b/cui/source/options/optjava.cxx
@@ -68,113 +68,69 @@ using namespace ::com::sun::star::ucb;
using namespace ::com::sun::star::ui::dialogs;
using namespace ::com::sun::star::uno;
-class SvxJavaListBox : public svx::SvxRadioButtonListBox
-{
-private:
-const OUString m_sAccessibilityText;
-public:
-SvxJavaListBox(SvSimpleTableContainer& rParent, const OUString
)
-: SvxRadioButtonListBox(rParent, 0)
-, m_sAccessibilityText(rAccessibilityText)
-{
-}
-void setColSizes()
-{
-HeaderBar = GetTheHeaderBar();
-if (rBar.GetItemCount() < 4)
-return;
-long nCheckWidth = std::max(GetControlColumnWidth() + 12,
-rBar.LogicToPixel(Size(15, 0),
MapMode(MapUnit::MapAppFont)).Width());
-long nVersionWidth = 12 +
-std::max(rBar.GetTextWidth(rBar.GetItemText(3)),
-GetTextWidth("0.0.0_00-icedtea"));
-long nFeatureWidth = 12 +
-std::max(rBar.GetTextWidth(rBar.GetItemText(4)),
-GetTextWidth(m_sAccessibilityText));
-long nVendorWidth =
-std::max(GetSizePixel().Width() - (nCheckWidth + nVersionWidth +
nFeatureWidth),
-6 + std::max(rBar.GetTextWidth(rBar.GetItemText(2)),
-GetTextWidth("Sun Microsystems Inc.")));
-long aStaticTabs[]= { 0, 0, 0, 0 };
-aStaticTabs[1] = nCheckWidth;
-aStaticTabs[2] = aStaticTabs[1] + nVendorWidth;
-aStaticTabs[3] = aStaticTabs[2] + nVersionWidth;
-SvSimpleTable::SetTabs(SAL_N_ELEMENTS(aStaticTabs), aStaticTabs,
MapUnit::MapPixel);
-}
-virtual void Resize() override
-{
-svx::SvxRadioButtonListBox::Resize();
-setColSizes();
-}
-};
-
// class SvxJavaOptionsPage --
-
-SvxJavaOptionsPage::SvxJavaOptionsPage( vcl::Window* pParent, const
SfxItemSet& rSet )
-: SfxTabPage(pParent, "OptAdvancedPage", "cui/ui/optadvancedpage.ui",
)
+SvxJavaOptionsPage::SvxJavaOptionsPage(TabPageParent pParent, const
SfxItemSet& rSet)
+: SfxTabPage(pParent, "cui/ui/optadvancedpage.ui", "OptAdvancedPage",
)
, m_aResetIdle("cui options SvxJavaOptionsPage Reset")
, xDialogListener(new ::svt::DialogClosedListener())
-{
-get(m_pJavaEnableCB, "javaenabled");
-get(m_pJavaBox, "javabox");
-get(m_pJavaPathText, "javapath");
-m_sInstallText = m_pJavaPathText->GetText();
-get(m_pAddBtn, "add");
-get(m_pParameterBtn, "parameters");
-get(m_pClassPathBtn, "classpath");
-get(m_pExperimentalCB, "experimental");
-get(m_pMacroCB, "macrorecording");
-get(m_pExpertConfigBtn, "expertconfig");
-m_pParentDlg.reset(
dynamic_cast(getNonLayoutParent(pParent)) );
-m_sAccessibilityText = get("a11y")->GetText();
-m_sAddDialogText = get("selectruntime")->GetText();
-
-SvSimpleTableContainer *pJavaListContainer =
get("javas");
-Size aControlSize(177, 60);
-aControlSize = LogicToPixel(aControlSize, MapMode(MapUnit::MapAppFont));
-pJavaListContainer->set_width_request(aControlSize.Width());
-pJavaListContainer->set_height_request(aControlSize.Height());
-m_pJavaList = VclPtr::Create(*pJavaListContainer,
m_sAccessibilityText);
-
-long const aStaticTabs[]= { 0, 0, 0, 0 };
-m_pJavaList->SvSimpleTable::SetTabs( SAL_N_ELEMENTS(aStaticTabs),
aStaticTabs );
-
-OUString sHeader ( "\t" + get("vendor")->GetText() +
-"\t" + get("version")->GetText() +
-"\t" + get("features")->GetText() +
-"\t" );
-m_pJavaList->InsertHeaderEntry(sHeader, HEADERBAR_APPEND,
HeaderBarItemBits::LEFT);
-m_pJavaList->setColSizes();
-
-m_pJavaEnableCB->SetClickHdl( LINK( this, SvxJavaOptionsPage,
EnableHdl_Impl ) );
-m_pJavaList->SetCheckButtonHdl( LINK( this, SvxJavaOptionsPage,
CheckHdl_Impl ) );
-m_pJavaList->SetSelectHdl( LINK( this, SvxJavaOptionsPage, SelectHdl_Impl
) );
-m_pAddBtn->SetClickHdl( LINK( this, SvxJavaOptionsPage, AddHdl_Impl ) );
-m_pParameterBtn->SetClickHdl( LINK( this, SvxJavaOptionsPage,
ParameterHdl_Impl ) );
-m_pClassPathBtn->SetClickHdl( LINK(
[Libreoffice-bugs] [Bug 99746] [META] PDF import filter in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=99746 Bug 99746 depends on bug 115251, which changed state. Bug 115251 Summary: LibreOffice draw hangs with 100% CPU after opening a pdf file https://bugs.documentfoundation.org/show_bug.cgi?id=115251 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115251] LibreOffice draw hangs with 100% CPU after opening a pdf file
https://bugs.documentfoundation.org/show_bug.cgi?id=115251 Miklos Vajna changed: What|Removed |Added Status|NEW |RESOLVED CC||noelgran...@gmail.com Resolution|--- |FIXED --- Comment #8 from Miklos Vajna --- This improved a lot in the 6.2 -> 6.3 timeframe. Oldest 6.3 is around 50s for me, newest 6.3 is rather in the 20s range. Reverse bisecting points out: commit bd44b3eef62f4325a189539d6ab1b90ca63cfc28 Author: Noel Grandin Date: Wed Apr 24 13:40:59 2019 +0200 tdf#89522 PERF FILEOPEN xlsx, part 1 Inherit from tools::WeakBase non-virtually, so that we can use a static_cast in tools::WeakReference::get instead of a dynamic_cast. This takes the file-open time from 1m21 to 40s for me. Add a clang plugin to make sure we don't accidentally end up inheriting from tools::WeakBase more than once. Change-Id: I9c7c3640f99094e1f9d8cce2ecd9200377f9 Reviewed-on: https://gerrit.libreoffice.org/71231 Reviewed-by: Noel Grandin Tested-by: Noel Grandin Thanks Noel. :-) I guess we can close this, then. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
