[Libreoffice-ux-advise] [Bug 127066] UI: Font size in input line (formular bar) larger than in other UI elements
https://bugs.documentfoundation.org/show_bug.cgi?id=127066 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Heiko Tietze --- How about an (expert) option here? The general approach would be something like Browsers offer where you can zoom into the content. We could do the same for font size and maybe kind reintroduce bug 101646 (UI scaling), which receives a lot of interest, but per control vs. per application. Though, this sounds like an overkill to me. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 127066] UI: Font size in input line (formular bar) larger than in other UI elements
https://bugs.documentfoundation.org/show_bug.cgi?id=127066 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Heiko Tietze --- How about an (expert) option here? The general approach would be something like Browsers offer where you can zoom into the content. We could do the same for font size and maybe kind reintroduce bug 101646 (UI scaling), which receives a lot of interest, but per control vs. per application. Though, this sounds like an overkill to me. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/qa
0 files changed New commits: commit dd7d90055545cb20aa5c12c0be44cccaefdeac47 Author: Andrea Gelmini AuthorDate: Thu Aug 22 22:23:26 2019 +0200 Commit: Julien Nabet CommitDate: Fri Aug 23 07:24:45 2019 +0200 Removed executable permission on file Change-Id: Icc51eaef76e48e3acdbc9602720a3e12902a Reviewed-on: https://gerrit.libreoffice.org/77981 Reviewed-by: Julien Nabet Tested-by: Julien Nabet diff --git a/sd/qa/unit/data/odp/testLegacyShapeAutofit.odp b/sd/qa/unit/data/odp/testLegacyShapeAutofit.odp old mode 100755 new mode 100644 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vbahelper/source
vbahelper/source/vbahelper/vbaapplicationbase.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit b47f733178335779283152f9a24381644cf9c5a6
Author: Andrea Gelmini
AuthorDate: Thu Aug 22 22:23:15 2019 +0200
Commit: Julien Nabet
CommitDate: Fri Aug 23 07:24:19 2019 +0200
Fix typo
Change-Id: I94efc4ce7e197fb8dc68840939ed75393983be1c
Reviewed-on: https://gerrit.libreoffice.org/77980
Reviewed-by: Julien Nabet
Tested-by: Julien Nabet
diff --git a/vbahelper/source/vbahelper/vbaapplicationbase.cxx
b/vbahelper/source/vbahelper/vbaapplicationbase.cxx
index 87c82e472d7c..94c3419f6e2a 100644
--- a/vbahelper/source/vbahelper/vbaapplicationbase.cxx
+++ b/vbahelper/source/vbahelper/vbaapplicationbase.cxx
@@ -472,7 +472,7 @@ void VbaApplicationBase::Quit()
{
// This is the case of a call from an (OLE) Automation client.
-// When an Automation client itself asks the proces to quit, it should
obey it.
+// When an Automation client itself asks the process to quit, it
should obey it.
AsyncQuitHandler::instance().SetForceQuit();
// TODO: Probably we should just close any document windows open by
the "application"
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/inc sw/qa sw/source
sw/inc/doc.hxx |3
sw/inc/fesh.hxx |2
sw/qa/extras/uiwriter/data2/tdf126784_distributeSelectedColumns.odt |binary
sw/qa/extras/uiwriter/uiwriter2.cxx | 29
+
sw/source/core/docnode/ndtbl1.cxx | 32
+-
sw/source/core/frmedt/fetab.cxx |4 -
sw/source/uibase/shells/tabsh.cxx |3
7 files changed, 50 insertions(+), 23 deletions(-)
New commits:
commit d0e268ca18ec0d907980ca608c97fe8f727d20df
Author: Justin Luth
AuthorDate: Wed Aug 21 19:41:17 2019 +0300
Commit: Justin Luth
CommitDate: Fri Aug 23 07:18:24 2019 +0200
tdf#126784 sw: only distribute across selected columns
partial revert of LO6.2 commit ab18c17d70e1dcf5cf9db38256d35e6af479373e
because MERGED cells had a very unexpected effect on the
columns that were altered. Unselected columns are INCLUDED
in the calculation IF they extend over the selected columns
when SwTableSearchType::Col uses the entire table column.
The last table in the unit test demonstrates why the regressive behaviour
was included. A user can make an ugly layout if they don't choose a
good set of columns.
However, the merged cell really changes the way the calculation
works, and since giving power to the user is ultimately the best,
just revert the portion that tries to save the user from themself.
I struggled then and now to get a good enough understanding
to improve the documentation - which really is needed
since reading it didn't help me a lot.
However, since my understanding was and is obviously flawed,
I'll just revert back to the original wording.
Change-Id: Icf8f01f095652e2a023e0398852f43aa6b90332f
Reviewed-on: https://gerrit.libreoffice.org/77976
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/sw/inc/doc.hxx b/sw/inc/doc.hxx
index b5a5d3bb1139..af2e97aa9985 100644
--- a/sw/inc/doc.hxx
+++ b/sw/inc/doc.hxx
@@ -1498,8 +1498,7 @@ public:
/// Adjusts selected cell widths in such a way, that their content does
not need to be wrapped (if possible).
/// bBalance evenly re-distributes the available space regardless of
content or wrapping.
/// bNoShrink keeps table size the same by distributing excess space
proportionately.
-/// bColumnWidth tests the entire column for content width, not just
selected cells.
-void AdjustCellWidth( const SwCursor& rCursor, const bool bBalance, const
bool bNoShrink, const bool bColumnWidth );
+void AdjustCellWidth( const SwCursor& rCursor, const bool bBalance, const
bool bNoShrink );
SwChainRet Chainable( const SwFrameFormat , const SwFrameFormat
);
SwChainRet Chain( SwFrameFormat , const SwFrameFormat );
diff --git a/sw/inc/fesh.hxx b/sw/inc/fesh.hxx
index 25bf062c1e82..6f6a5e860802 100644
--- a/sw/inc/fesh.hxx
+++ b/sw/inc/fesh.hxx
@@ -710,7 +710,7 @@ public:
bool IsInRepeatedHeadline() const { return CheckHeadline( true ); }
bool IsInHeadline() const { return CheckHeadline( false ); }
-void AdjustCellWidth( bool bBalance, const bool bNoShrink, const bool
bColumnWidth );
+void AdjustCellWidth( const bool bBalance, const bool bNoShrink );
/// Not allowed if only empty cells are selected.
bool IsAdjustCellWidthAllowed( bool bBalance = false ) const;
diff --git
a/sw/qa/extras/uiwriter/data2/tdf126784_distributeSelectedColumns.odt
b/sw/qa/extras/uiwriter/data2/tdf126784_distributeSelectedColumns.odt
new file mode 100644
index ..90c23c56a32d
Binary files /dev/null and
b/sw/qa/extras/uiwriter/data2/tdf126784_distributeSelectedColumns.odt differ
diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index 0d35c0cec77f..eb85d96d25fe 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -16,6 +16,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -627,6 +628,34 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest2,
testTdf64242_optimizeTable)
CPPUNIT_ASSERT_EQUAL_MESSAGE("Row set to auto-height", double(0),
minimalRowHeight);
}
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf126784_distributeSelectedColumns)
+{
+SwDoc* pDoc = createDoc("tdf126784_distributeSelectedColumns.odt");
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+
+uno::Reference xTablesSupplier(mxComponent,
uno::UNO_QUERY);
+uno::Reference xModel(mxComponent, uno::UNO_QUERY);
+uno::Reference
xTables(xTablesSupplier->getTextTables(),
+uno::UNO_QUERY);
+uno::Reference xTextTable(xTables->getByIndex(0),
uno::UNO_QUERY);
+uno::Reference xTableRows = xTextTable->getRows();
+
+auto aSeq =
[Libreoffice-bugs] [Bug 127051] FILEOPEN: XLSX: Large White Square objects several levels deep appear in the upper left corner of some sheets in the workbook
https://bugs.documentfoundation.org/show_bug.cgi?id=127051 tom1willi...@yandex.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #7 from tom1willi...@yandex.com --- This document has been around for many years and gets updated twice per year by multiple people. Most of the company now uses MSO 365 which updates itself automatically. It is safe to assume that at some time in its lifespan this document was edited by MSO 2010, 2015, 2016 and 365 on both Mac and Windows. But the main point is my LO 6.2.6.2 put in these empty frames and once they were in the document they stay in the document no matter what software opens it. I am guessing that when I edit certain sheets and hit FILESAVE it puts in an empty frame. If I saved 5 times after different edits on a given sheet there may be 5 empty frames on top of one another on that sheet the next time the document is opened. At least that is my best guess as to what might be happening. Thank you for your help!! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[ANN] orcus 0.15.1 on master
Hi there, Just a quick announcement that I have updated the version of orcus library on the master branch from 0.15.0 to 0.15.1. This version is primarily to address build issues on 32-bit debian systems (as Rene reported) as well as to finally fix the memory mis- handling issues in the XML mapping code used in Calc's XML Source feature. I've used Stephan's patch as a starting point to hopefully overhaul the way object life cycles were handled. Obviously this was a long standing issue that I never had a chance to look at since 2012, which may have been a root cause of occasional crashes... Anyway, it's good to finally give it proper treatment. Best, Kohei -- Kohei Yoshida, LibreOffice Calc volunteer hacker ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 122218] After Update to 6.1.4 on macOS fonts are blurred on retina display
https://bugs.documentfoundation.org/show_bug.cgi?id=122218 --- Comment #34 from bunkem --- The font problem is fixed in the build: https://dev-builds.libreoffice.org/daily/libreoffice-6-3/MacOSX-x86_64@49-TDF/2019-08-21_17.28.20/ - that was done with XCode 9 Version: 6.3.2.0.0+ Build ID: ad2fde8797bd7753987dc1bbbae35fb1cc5ce1df CPU threads: 8; OS: Mac OS X 10.14.6; UI render: default; VCL: osx; TinderBox: MacOSX-x86_64@49-TDF, Branch:libreoffice-6-3, Time: 2019-08-21_17:28:20 Locale: en-CA (en_CA.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: download.lst external/liborcus
download.lst |4 -
external/liborcus/UnpackedTarball_liborcus.mk |1
external/liborcus/create-element.patch.0 | 55 --
3 files changed, 2 insertions(+), 58 deletions(-)
New commits:
commit 52800fd6d9867252b795b6afacce19f66b5a5107
Author: Kohei Yoshida
AuthorDate: Thu Aug 22 16:48:50 2019 -0400
Commit: Kohei Yoshida
CommitDate: Fri Aug 23 01:41:23 2019 +0200
Update orcus to 0.15.1.
Change-Id: Ifd945d03719bf2ed1fb145b405f1ea9297ebeb68
Reviewed-on: https://gerrit.libreoffice.org/77983
Tested-by: Jenkins
Reviewed-by: Kohei Yoshida
diff --git a/download.lst b/download.lst
index c0217d93b9d0..1b2d943defe8 100644
--- a/download.lst
+++ b/download.lst
@@ -194,8 +194,8 @@ export OPENLDAP_SHA256SUM :=
cdd6cffdebcd95161a73305ec13fc7a78e9707b46ca9f84fb89
export OPENLDAP_TARBALL := openldap-2.4.45.tgz
export OPENSSL_SHA256SUM :=
ae51d08bba8a83958e894946f15303ff894d75c2b8bbd44a852b64e3fe11d0d6
export OPENSSL_TARBALL := openssl-1.0.2r.tar.gz
-export ORCUS_SHA256SUM :=
06ec7567896d76ca579efada794cc281a5d6b427195def01cbcfd79795e8a944
-export ORCUS_TARBALL := liborcus-0.15.0.tar.gz
+export ORCUS_SHA256SUM :=
ab835e131c861401d52a30a74d0c83f175650f3f45460ae95bbf95493cab2579
+export ORCUS_TARBALL := liborcus-0.15.1.tar.gz
export OWNCLOUD_ANDROID_LIB_SHA256SUM :=
b18b3e3ef7fae6a79b62f2bb43cc47a5346b6330f6a383dc4be34439aca5e9fb
export OWNCLOUD_ANDROID_LIB_TARBALL :=
owncloud-android-library-0.9.4-no-binary-deps.tar.gz
export PAGEMAKER_SHA256SUM :=
66adacd705a7d19895e08eac46d1e851332adf2e736c566bef1164e7a442519d
diff --git a/external/liborcus/UnpackedTarball_liborcus.mk
b/external/liborcus/UnpackedTarball_liborcus.mk
index 834b8128d39f..e1aef32edcf7 100644
--- a/external/liborcus/UnpackedTarball_liborcus.mk
+++ b/external/liborcus/UnpackedTarball_liborcus.mk
@@ -22,7 +22,6 @@ $(eval $(call gb_UnpackedTarball_add_patches,liborcus,\
external/liborcus/rpath.patch.0 \
external/liborcus/gcc9.patch.0 \
external/liborcus/libtool.patch.0 \
- external/liborcus/create-element.patch.0 \
))
ifeq ($(OS),WNT)
diff --git a/external/liborcus/create-element.patch.0
b/external/liborcus/create-element.patch.0
deleted file mode 100644
index b1012e5c90d8..
--- a/external/liborcus/create-element.patch.0
+++ /dev/null
@@ -1,55 +0,0 @@
src/liborcus/xml_map_tree.cpp
-+++ src/liborcus/xml_map_tree.cpp
-@@ -723,35 +723,28 @@
- element* elem = r.first;
- bool created = r.second;
-
--if (created)
--{
--// No element of that name exists.
--elem->elem_type = element_linked;
--elem->ref_type = ref_type;
--}
--else
-+if (!created)
- {
- // This element already exists. Check if this is already linked.
- if (elem->ref_type != reference_unknown || elem->elem_type !=
element_unlinked)
- throw xpath_error("This element is already linked. You can't
link the same element twice.");
--
--// Turn this existing non-linked element into a linked one.
--delete elem->child_elements;
--elem->elem_type = element_linked;
--elem->ref_type = ref_type;
--switch (ref_type)
--{
--case reference_cell:
--elem->cell_ref = new cell_reference;
--break;
--case reference_range_field:
--elem->field_ref = new field_in_range;
--break;
--default:
--throw general_error("Unknown reference type in
xml_map_tree::get_element_stack.");
--}
--
- }
-+
-+// Turn this existing non-linked element into a linked one.
-+delete elem->child_elements;
-+elem->elem_type = element_linked;
-+elem->ref_type = ref_type;
-+switch (ref_type)
-+{
-+case reference_cell:
-+elem->cell_ref = new cell_reference;
-+break;
-+case reference_range_field:
-+elem->field_ref = new field_in_range;
-+break;
-+default:
-+throw general_error("Unknown reference type in
xml_map_tree::get_element_stack.");
-+}
-
- ret.elem_stack.push_back(elem);
- ret.node = elem;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 127090] FILESAVE: PPTX: Text in pieWedge shape rotates with shape instead of staying upright
https://bugs.documentfoundation.org/show_bug.cgi?id=127090 Gerald Pfeifer changed: What|Removed |Added Summary|FILESAVE: PPTX: Text in |FILESAVE: PPTX: Text in |quarter circles rotated |pieWedge shape rotates with |arbitrarily |shape instead of staying ||upright --- Comment #5 from Gerald Pfeifer --- (In reply to Regina Henschel from comment #4) > I wonder, how you have generated the file. The preset shape "pieWedge" does > not belong to shapes, which are available in the UI, neither in LibreOffice > nor in PowerPoint. And rotating text inside a custom shape has no UI in > LibreOffice. This came from a PPTX I got. The PPTX to ODP path went surprisingly okay-ish (no undesired rotations). Just when then saving as PPTX since a colleague could not handle the ODP did this materialize. (Nice analysis, by the way. Thank you!) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127100] Formula font size cannot be changed when using new Tabbed UI in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=127100 Benedikt Bieringer <2xb.cod...@wwu.de> changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #2 from Benedikt Bieringer <2xb.cod...@wwu.de> --- Roman: Yes, it is an OLE element. Since the Tabbed UI replaces the menu bar with tabs, selecting the menu "Format" is no longer possible. Probably when in OLE mode there should be an OLE tab containing e.g. the "Format" menu, but there is not. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127102] FILEOPEN Combined Chart of type stacked area + stacked column loses column stacking
https://bugs.documentfoundation.org/show_bug.cgi?id=127102 --- Comment #2 from Durgapriyanka --- Thank you for reporting this bug. I can reproduce this in Version: 6.3.0.0.alpha0+ Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04 Locale: en-US (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: shell/source
shell/source/backends/kf5be/kf5backend.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit ff398785bede2b403f8f8e6391ce07538f6cc213
Author: Michael Weghorn
AuthorDate: Thu Aug 22 19:09:46 2019 +0200
Commit: Michael Weghorn
CommitDate: Thu Aug 22 22:58:41 2019 +0200
kf5backend.cxx: Use 'free()' instead of 'delete'
'strdup' doc [1] mentions:
"The returned pointer must be passed to 'free' to avoid a memory leak."
This silences a "Mismatched free() / delete / delete []" error that
valgrind outputs.
[1] https://en.cppreference.com/w/c/experimental/dynamic/strdup
Change-Id: I28877be762256a7b995c09415a8ad9977b7998c4
Reviewed-on: https://gerrit.libreoffice.org/77974
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/shell/source/backends/kf5be/kf5backend.cxx
b/shell/source/backends/kf5be/kf5backend.cxx
index a2cae6c6c4fd..f55a5150bd3f 100644
--- a/shell/source/backends/kf5be/kf5backend.cxx
+++ b/shell/source/backends/kf5be/kf5backend.cxx
@@ -190,7 +190,7 @@ void initQApp(std::map>& rSettings
std::unique_ptr app(new QApplication(nFakeArgc, pFakeArgv));
QObject::connect(app.get(), ::destroyed, app.get(), [nFakeArgc,
pFakeArgv]() {
for (int i = 0; i < nFakeArgc; ++i)
-delete pFakeArgv[i];
+free(pFakeArgv[i]);
delete[] pFakeArgv;
});
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126902] ^m (default) does not un-bold
https://bugs.documentfoundation.org/show_bug.cgi?id=126902 Durgapriyanka changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Durgapriyanka --- Thank you for reporting the bug. I can confirm the bug present in Version: 6.3.0.0.alpha0+ Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04 Locale: en-US (en_US); UI-Language: en-US Calc: threaded and LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127073] Redaction done right
https://bugs.documentfoundation.org/show_bug.cgi?id=127073 --- Comment #2 from Muhammet Kara --- (In reply to Ulrich Windl from comment #0) > (the current implementation is basically the digital version of "print it, > blacken it, scan it again to make a new document"). That's exactly how it was designed. (In reply to Roman Kuznetsov from comment #1) > I think it's WONTFIX > > Muhammet, what do you think? What the reporter describes might be a nice (but risky -check the internet for security incidents of similar implementations-) implementation of a redaction feature, but not this one. Unless there is a strong will, and necessary resources to implement another version of the redaction feature, this is a WONTFIX for me. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104442] [META] DOCX (OOXML) shape (DrawingML and VML) related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104442 Regina Henschel changed: What|Removed |Added Depends on||127090 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=127090 [Bug 127090] FILESAVE: PPTX: Text in quarter circles rotated arbitrarily -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127090] FILESAVE: PPTX: Text in quarter circles rotated arbitrarily
https://bugs.documentfoundation.org/show_bug.cgi?id=127090 Regina Henschel changed: What|Removed |Added Blocks||104442 CC||rb.hensc...@t-online.de Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #4 from Regina Henschel --- The text does not rotate arbitrarily but follows the shape rotation. The problem is, that LibreOffice does not support the needed attribute "upright" of the element in OOXML. And OOXML does not support the additional text rotation of text inside a custom shape of ODF. So a proper fix would be to make LibreOffice able to transform the "upright" attribute into a suitable text rotation on import and transform the text rotation back to attribute "upright" on export. A similar problem exists as bug 104290 for Calc. I wonder, how you have generated the file. The preset shape "pieWedge" does not belong to shapes, which are available in the UI, neither in LibreOffice nor in PowerPoint. And rotating text inside a custom shape has no UI in LibreOffice. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104442 [Bug 104442] [META] DOCX (OOXML) shape (DrawingML and VML) related issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127107] New: Will not print documents
https://bugs.documentfoundation.org/show_bug.cgi?id=127107 Bug ID: 127107 Summary: Will not print documents Product: LibreOffice Version: 6.2.0.1 rc Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: fred...@gmail.com Description: Since your last update, every time I click print, Libre Writer, routes my document to "One Note", so I uninstalled Libre Office, I had no other choice. I cannot uninstall "One Note". Actual Results: No results.. Expected Results: Nothing Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127104] CALC: One COPY and Multiple PASTES
https://bugs.documentfoundation.org/show_bug.cgi?id=127104 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from m.a.riosv --- I can't reproduce with Version: 6.2.6.2 (x64) Build ID: 684e730861356e74889dfe6dbddd3562aae2e6ad CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; Locale: es-ES (es_ES); UI-Language: en-US Calc: CL The reported version 3.5.4 it's a really old version, please could you try with 6.2 or 6.3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/doc/objmisc.cxx | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
New commits:
commit 7a6f8baa738c7ec0348015f5c423802e10a524fd
Author: Stephan Bergmann
AuthorDate: Thu Aug 22 17:34:42 2019 +0200
Commit: Stephan Bergmann
CommitDate: Thu Aug 22 21:54:52 2019 +0200
Replace use of INetURLObject::GetNewAbsURL with rtl::Uri::convertRelToAbs
Change-Id: Ida2a0553ede3d6d9d7ff4a50bca6256a70286bc2
Reviewed-on: https://gerrit.libreoffice.org/77970
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/sfx2/source/doc/objmisc.cxx b/sfx2/source/doc/objmisc.cxx
index df52c23c0b7c..33341b58a3a3 100644
--- a/sfx2/source/doc/objmisc.cxx
+++ b/sfx2/source/doc/objmisc.cxx
@@ -80,6 +80,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -1477,10 +1478,12 @@ void SfxHeaderAttributes_Impl::SetAttribute( const
SvKeyValue& rKV )
pDoc->getDocProperties());
if( aURL.startsWithIgnoreAsciiCase( "url=" ) )
{
-INetURLObject aObj;
-INetURLObject( pDoc->GetMedium()->GetName() ).GetNewAbsURL(
aURL.copy( 4 ), );
-xDocProps->setAutoloadURL(
-aObj.GetMainURL( INetURLObject::DecodeMechanism::NONE ) );
+try {
+xDocProps->setAutoloadURL(
+rtl::Uri::convertRelToAbs(pDoc->GetMedium()->GetName(),
aURL.copy( 4 )) );
+} catch (rtl::MalformedUriException &) {
+TOOLS_WARN_EXCEPTION("sfx", "");
+}
}
try
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 127106] New: No icons in the menus of Libreoffice 6.3.0.4
https://bugs.documentfoundation.org/show_bug.cgi?id=127106 Bug ID: 127106 Summary: No icons in the menus of Libreoffice 6.3.0.4 Product: LibreOffice Version: 6.3.0.4 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jeanpaul.th...@cegetel.net Description: No icons in the menus even if, in the options of Libreoffice 6.3.0.4, -> Display -> Icons in the menus -> Show is chosen Steps to Reproduce: 1.Choose : Options of Libreoffice 6.3.0.4 2.Choose : -> Display 3.Choose : -> Icons in the menus 4.Choose : -> Show Actual Results: There no icons in the menus Expected Results: Icons in the menus Reproducible: Always User Profile Reset: Yes Additional Info: LibreOffice Version: 6.3.0.4 Build ID: 057fc023c990d676a43019934386b85b21a9ee99 Threads CPU : 2; OS : Linux 4.15; UI Render : par défaut; VCL: gtk3; Locale : fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127105] New: Threaded comments support (OOXML) in XLSX
https://bugs.documentfoundation.org/show_bug.cgi?id=127105 Bug ID: 127105 Summary: Threaded comments support (OOXML) in XLSX Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tbertels+bugzi...@gmail.com Since "newer versions of Excel", there is a new "threaded comments" feature. It's also simply known as "comments" while the old comments are now known as "notes".[1] When viewing a comment saved by a recent version of Excel in LibreOffice, we see a message "[Threaded comment] This threaded comment can be viewed, but not edited(...)"[2] By the way, this kind of feature could be added to a future version of OpenDocument, if not already planned in OpenDocument 1.3. [1] https://support.office.com/en-us/article/the-difference-between-threaded-comments-and-notes-75a51eec-4092-42ab-abf8-7669077b7be3 [2] https://support.office.com/en-us/article/this-threaded-comment-can-be-viewed-but-not-edited-17b3eb02-efa7-4934-9e8e-b8916482bf41?ui=en-US=en-US=US -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127104] New: CALC: One COPY and Multiple PASTES
https://bugs.documentfoundation.org/show_bug.cgi?id=127104 Bug ID: 127104 Summary: CALC: One COPY and Multiple PASTES Product: LibreOffice Version: 3.5.4 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: neilhmur...@yahoo.com Description: I was trying to do multiple PASTEs of the same row. The second one failed. I had done an insert row between the first and second PASTE. I went back and issued a COPY then a PASTE. That worked. Steps to Reproduce: 1.COPY 2.PASTE 3.PASTE Actual Results: #3 Didn't work=row was still blank Expected Results: #3 would have the same contents as #2 Reproducible: Didn't try User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127073] Redaction done right
https://bugs.documentfoundation.org/show_bug.cgi?id=127073 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru, ||muhammet.k...@collabora.com --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- But then any enemy (or journalists) will delete your shapes using good PDF Editor and will see your secret info. Export to bitmap PDF will guarantee us that our secret info will remain secret. I think it's WONTFIX Muhammet, what do you think? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: extensions/source
extensions/source/dbpilots/controlwizard.cxx |2 +-
extensions/source/dbpilots/controlwizard.hxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit d9d096a567653d8daddedf88ec40d13113354c3b
Author: Caolán McNamara
AuthorDate: Thu Aug 22 16:25:18 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Aug 22 21:09:27 2019 +0200
OControlWizard->vcl::Window
Change-Id: Ibb007621aca910cd2fd983b2f255e93160bddb5c
Reviewed-on: https://gerrit.libreoffice.org/77968
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/extensions/source/dbpilots/controlwizard.cxx
b/extensions/source/dbpilots/controlwizard.cxx
index 6589b2bb2f25..e02dbbfb2c24 100644
--- a/extensions/source/dbpilots/controlwizard.cxx
+++ b/extensions/source/dbpilots/controlwizard.cxx
@@ -74,7 +74,7 @@ namespace dbp
OAccessRegulator() { }
};
-OControlWizardPage::OControlWizardPage( OControlWizard* _pParent, const
OString& rID, const OUString& rUIXMLDescription )
+OControlWizardPage::OControlWizardPage( vcl::Window* _pParent, const
OString& rID, const OUString& rUIXMLDescription )
:OControlWizardPage_Base( _pParent, rID, rUIXMLDescription )
,m_pFormDatasourceLabel(nullptr)
,m_pFormDatasource(nullptr)
diff --git a/extensions/source/dbpilots/controlwizard.hxx
b/extensions/source/dbpilots/controlwizard.hxx
index d84babbfc250..68b0551d1780 100644
--- a/extensions/source/dbpilots/controlwizard.hxx
+++ b/extensions/source/dbpilots/controlwizard.hxx
@@ -65,7 +65,7 @@ namespace dbp
css::uno::Reference< css::sdbc::XConnection >
getFormConnection() const;
public:
-OControlWizardPage( OControlWizard* _pParent, const OString& rID,
const OUString& rUIXMLDescription );
+OControlWizardPage( vcl::Window* _pParent, const OString& rID, const
OUString& rUIXMLDescription );
virtual ~OControlWizardPage() override;
virtual void dispose() override;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126990] Colours inverted in video played in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=126990 --- Comment #3 from Jan-Marek Glogowski --- It works correct in gen and qt5, but is broken in kf5 and gtk3, which IMHO looks like the cairo canvas bug, as it also works correctly in Impress edit mode. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127091] TVM Formula, Begin & end mode decryption is wrong.
https://bugs.documentfoundation.org/show_bug.cgi?id=127091 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru, ||er...@redhat.com --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Eike, please look at this -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127098] Functions to Track and View Changes should really become Useful
https://bugs.documentfoundation.org/show_bug.cgi?id=127098 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||83946 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=83946 [Bug 83946] [META] Tracking changes issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83946 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||127098 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=127098 [Bug 127098] Functions to Track and View Changes should really become Useful -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107237] [META] Notebookbar Tabbed
https://bugs.documentfoundation.org/show_bug.cgi?id=107237 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||127100 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=127100 [Bug 127100] Formula font size cannot be changed when using new Tabbed UI in Impress -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127100] Formula font size cannot be changed when using new Tabbed UI in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=127100 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||107237 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107237 [Bug 107237] [META] Notebookbar Tabbed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127100] Formula font size cannot be changed when using new Tabbed UI in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=127100 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Benedikt, how did you add your formula? If you used Insert->OLE Object->Formula then you can't change font size from Impress UI. You should enter to Edit formula mode (double click) and then select menu Format->Font size and set up font size there. Or you can use extension https://extensions.libreoffice.org/extensions/formatting-of-all-math-formulas -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/ui/dbui/mmaddressblockpage.cxx |8
sw/source/ui/dbui/mmgreetingspage.cxx |2
sw/source/ui/dbui/mmresultdialogs.cxx |2
sw/source/uibase/dbui/mailmergehelper.cxx | 252 --
sw/source/uibase/inc/mailmergehelper.hxx | 56 --
5 files changed, 11 insertions(+), 309 deletions(-)
New commits:
commit 43a394e111a579b1d01ab2703101eabe6abfffbf
Author: Caolán McNamara
AuthorDate: Thu Aug 22 17:26:21 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Aug 22 20:40:25 2019 +0200
drop newly unused SwAddressPreview
Change-Id: I84cf6570d048df86b4690cb70cc3e7a256303951
Reviewed-on: https://gerrit.libreoffice.org/77972
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sw/source/ui/dbui/mmaddressblockpage.cxx
b/sw/source/ui/dbui/mmaddressblockpage.cxx
index 0edb9bddee1f..f4b7359be648 100644
--- a/sw/source/ui/dbui/mmaddressblockpage.cxx
+++ b/sw/source/ui/dbui/mmaddressblockpage.cxx
@@ -246,7 +246,7 @@ IMPL_LINK_NOARG(SwMailMergeAddressBlockPage,
AddressBlockSelectHdl_Impl, LinkPar
const sal_uInt16 nSel = m_xSettings->GetSelectedAddress();
const uno::Sequence< OUString> aBlocks =
m_pWizard->GetConfigItem().GetAddressBlocks();
-m_xPreview->SetAddress(SwAddressPreview::FillData(aBlocks[nSel],
+m_xPreview->SetAddress(AddressPreview::FillData(aBlocks[nSel],
m_pWizard->GetConfigItem()));
m_pWizard->GetConfigItem().SetCurrentAddressBlockIndex( nSel );
GetWizard()->UpdateRoadmap();
@@ -291,7 +291,7 @@ void
SwMailMergeAddressBlockPage::InsertDataHdl(weld::Button* pButton)
const sal_uInt16 nSel = m_xSettings->GetSelectedAddress();
const uno::Sequence< OUString> aBlocks =
m_pWizard->GetConfigItem().GetAddressBlocks();
-m_xPreview->SetAddress(SwAddressPreview::FillData(aBlocks[nSel],
rConfig));
+m_xPreview->SetAddress(AddressPreview::FillData(aBlocks[nSel],
rConfig));
}
}
m_xPrevSetIB->set_sensitive(bEnable);
@@ -569,7 +569,7 @@ IMPL_LINK(SwCustomizeAddressBlockDialog,
ListBoxSelectHdl_Impl, weld::TreeView&,
IMPL_LINK_NOARG(SwCustomizeAddressBlockDialog, EditModifyHdl_Impl,
AddressMultiLineEdit&, void)
{
-m_xPreview->SetAddress(SwAddressPreview::FillData(GetAddress(),
m_rConfigItem));
+m_xPreview->SetAddress(AddressPreview::FillData(GetAddress(),
m_rConfigItem));
UpdateImageButtons_Impl();
}
@@ -1026,7 +1026,7 @@ IMPL_LINK_NOARG(SwAssignFieldsDialog, OkHdl_Impl,
weld::Button&, void)
IMPL_LINK_NOARG(SwAssignFieldsDialog, AssignmentModifyHdl_Impl,
LinkParamNone*, void)
{
uno::Sequence< OUString > aAssignments = CreateAssignments();
-const OUString sPreview = SwAddressPreview::FillData(
+const OUString sPreview = AddressPreview::FillData(
m_rPreviewString, m_rConfigItem, );
m_xPreview->SetAddress(sPreview);
}
diff --git a/sw/source/ui/dbui/mmgreetingspage.cxx
b/sw/source/ui/dbui/mmgreetingspage.cxx
index b80cc86480d7..92ae163f 100644
--- a/sw/source/ui/dbui/mmgreetingspage.cxx
+++ b/sw/source/ui/dbui/mmgreetingspage.cxx
@@ -173,7 +173,7 @@ void SwMailMergeGreetingsPage::UpdatePreview()
OUString sPreview = bFemale ? m_xFemaleLB->get_active_text() :
bNoValue ? m_xNeutralCB->get_active_text() :
m_xMaleLB->get_active_text();
-sPreview = SwAddressPreview::FillData(sPreview, m_rConfigItem);
+sPreview = AddressPreview::FillData(sPreview, m_rConfigItem);
m_xPreview->SetAddress(sPreview);
}
diff --git a/sw/source/ui/dbui/mmresultdialogs.cxx
b/sw/source/ui/dbui/mmresultdialogs.cxx
index f107758feda0..912cb9a3f8cd 100644
--- a/sw/source/ui/dbui/mmresultdialogs.cxx
+++ b/sw/source/ui/dbui/mmresultdialogs.cxx
@@ -1134,7 +1134,7 @@ IMPL_LINK_NOARG(SwMMResultEmailDialog,
SendDocumentsHdl_Impl, weld::Button&, voi
SwMailMergeConfigItem::FEMALE :
SwMailMergeConfigItem::MALE;
-sGreeting = SwAddressPreview::FillData(
+sGreeting = AddressPreview::FillData(
xConfigItem->GetGreetings(eGenderType)
[xConfigItem->GetCurrentGreeting(eGenderType)],
*xConfigItem);
diff --git a/sw/source/uibase/dbui/mailmergehelper.cxx
b/sw/source/uibase/dbui/mailmergehelper.cxx
index bbf60a49dd63..4d1aa49f3445 100644
--- a/sw/source/uibase/dbui/mailmergehelper.cxx
+++ b/sw/source/uibase/dbui/mailmergehelper.cxx
@@ -180,257 +180,7 @@ struct SwAddressPreview_Impl
}
};
-SwAddressPreview::SwAddressPreview(vcl::Window* pParent, WinBits nStyle)
-: Window( pParent, nStyle )
-, aVScrollBar(VclPtr::Create(this, WB_VSCROLL))
-, pImpl(new SwAddressPreview_Impl())
-{
-aVScrollBar->SetScrollHdl(LINK(this, SwAddressPreview, ScrollHdl));
-
[Libreoffice-commits] core.git: 2 commits - extras/source sfx2/source solenv/bin sw/source sw/uiconfig vcl/source
extras/source/glade/libreoffice-catalog.xml.in |3
sfx2/source/dialog/backingcomp.cxx | 10 +
solenv/bin/native-code.py |1
sw/source/ui/dbui/mailmergewizard.cxx |2
sw/source/ui/dbui/mmaddressblockpage.cxx | 201 -
sw/source/ui/dbui/mmaddressblockpage.hxx | 59 ---
sw/source/uibase/dbui/mailmergehelper.cxx |9 +
sw/source/uibase/inc/mailmergehelper.hxx |5
sw/uiconfig/swriter/ui/mmaddressblockpage.ui | 38
vcl/source/control/button.cxx | 10 +
vcl/source/window/bufferdevice.cxx |2
vcl/source/window/bufferdevice.hxx |1
vcl/source/window/menubarwindow.cxx| 16 +
13 files changed, 218 insertions(+), 139 deletions(-)
New commits:
commit b5f2f32defd22c8ec0c47c0100836a8d5bb132ea
Author: Caolán McNamara
AuthorDate: Thu Aug 22 17:15:44 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Aug 22 20:40:07 2019 +0200
weld SwMailMergeAddressBlockPage
Change-Id: Ib3383f1ae590766ecb1371cab2ccdb7c835c95a8
Reviewed-on: https://gerrit.libreoffice.org/77971
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/extras/source/glade/libreoffice-catalog.xml.in
b/extras/source/glade/libreoffice-catalog.xml.in
index eef7bdd744b6..a86845bd17d1 100644
--- a/extras/source/glade/libreoffice-catalog.xml.in
+++ b/extras/source/glade/libreoffice-catalog.xml.in
@@ -159,9 +159,6 @@
-
diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py
index a58a30654a06..45a3fee13118 100755
--- a/solenv/bin/native-code.py
+++ b/solenv/bin/native-code.py
@@ -512,7 +512,6 @@ custom_widgets = [
'SvxRelativeField',
'SvxTextEncodingBox',
'SvxTextEncodingBox',
-'SwAddressPreview',
'SwNavHelpToolBox',
'TableValueSet',
'TemplateDefaultView',
diff --git a/sw/source/ui/dbui/mailmergewizard.cxx
b/sw/source/ui/dbui/mailmergewizard.cxx
index 49ea7c661fc9..6ca8822cbfc3 100644
--- a/sw/source/ui/dbui/mailmergewizard.cxx
+++ b/sw/source/ui/dbui/mailmergewizard.cxx
@@ -106,7 +106,7 @@ VclPtr SwMailMergeWizard::createPage(WizardState
_nState)
SetRoadmapHelpId("modules/swriter/ui/mmoutputtypepage/MMOutputTypePage");
break;
case MM_ADDRESSBLOCKPAGE :
-pRet = VclPtr::Create(this);
+pRet = VclPtr::Create(this,
TabPageParent(this));
SetRoadmapHelpId("modules/swriter/ui/mmaddressblockpage/MMAddressBlockPage");
break;
case MM_GREETINGSPAGE :
diff --git a/sw/source/ui/dbui/mmaddressblockpage.cxx
b/sw/source/ui/dbui/mmaddressblockpage.cxx
index dd12860e54ca..0edb9bddee1f 100644
--- a/sw/source/ui/dbui/mmaddressblockpage.cxx
+++ b/sw/source/ui/dbui/mmaddressblockpage.cxx
@@ -57,46 +57,46 @@ using namespace ::com::sun::star::sdb;
using namespace ::com::sun::star::sdbc;
using namespace ::com::sun::star::sdbcx;
-SwMailMergeAddressBlockPage::SwMailMergeAddressBlockPage( SwMailMergeWizard*
_pParent) :
-vcl::OWizardPage(_pParent, "MMAddressBlockPage",
-"modules/swriter/ui/mmaddressblockpage.ui")
-, m_pWizard(_pParent)
-{
-get(m_pAddressListPB, "addresslist");
-get(m_pCurrentAddressFI, "currentaddress");
-get(m_pStep2, "step2");
-get(m_pStep3, "step3");
-get(m_pStep4, "step4");
-get(m_pSettingsFI, "settingsft");
-get(m_pAddressCB, "address");
-get(m_pSettingsWIN, "settingspreview");
+SwMailMergeAddressBlockPage::SwMailMergeAddressBlockPage(SwMailMergeWizard*
pWizard, TabPageParent pParent)
+: vcl::OWizardPage(pParent, "modules/swriter/ui/mmaddressblockpage.ui",
"MMAddressBlockPage")
+, m_pWizard(pWizard)
+, m_xAddressListPB(m_xBuilder->weld_button("addresslist"))
+, m_xCurrentAddressFI(m_xBuilder->weld_label("currentaddress"))
+, m_xStep2(m_xBuilder->weld_container("step2"))
+, m_xStep3(m_xBuilder->weld_container("step3"))
+, m_xStep4(m_xBuilder->weld_container("step4"))
+, m_xSettingsFI(m_xBuilder->weld_label("settingsft"))
+, m_xAddressCB(m_xBuilder->weld_check_button("address"))
+, m_xSettingsPB(m_xBuilder->weld_button("settings"))
+, m_xHideEmptyParagraphsCB(m_xBuilder->weld_check_button("hideempty"))
+, m_xAssignPB(m_xBuilder->weld_button("assign"))
+, m_xDocumentIndexFI(m_xBuilder->weld_label("documentindex"))
+, m_xPrevSetIB(m_xBuilder->weld_button("prev"))
+, m_xNextSetIB(m_xBuilder->weld_button("next"))
+, m_xDifferentlist(m_xBuilder->weld_label("differentlist"))
+, m_xSettings(new
AddressPreview(m_xBuilder->weld_scrolled_window("settingspreviewwin")))
+, m_xPreview(new
AddressPreview(m_xBuilder->weld_scrolled_window("addresspreviewwin")))
+, m_xSettingsWIN(new weld::CustomWeld(*m_xBuilder, "settingspreview",
*m_xSettings))
+, m_xPreviewWIN(new weld::CustomWeld(*m_xBuilder, "addresspreview",
*m_xPreview))
+{
[Libreoffice-bugs] [Bug 120965] Phantom control point line in Bézier curve
https://bugs.documentfoundation.org/show_bug.cgi?id=120965 --- Comment #12 from Commit Notification --- Regina Henschel committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/46c7341014870b4d2c9babd91c14dfed4422f93a%5E%21 tdf#126271 Revert "tdf120965 Simplify SdrPathObj::AddToHdlList()" It will be available in 6.2.7. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126271] Selecting of control points of curves not working correctly for combined polygons
https://bugs.documentfoundation.org/show_bug.cgi?id=126271 Commit Notification changed: What|Removed |Added Whiteboard|target:6.4.0 target:6.3.2 |target:6.4.0 target:6.3.2 ||target:6.2.7 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126271] Selecting of control points of curves not working correctly for combined polygons
https://bugs.documentfoundation.org/show_bug.cgi?id=126271 --- Comment #13 from Commit Notification --- Regina Henschel committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/46c7341014870b4d2c9babd91c14dfed4422f93a%5E%21 tdf#126271 Revert "tdf120965 Simplify SdrPathObj::AddToHdlList()" It will be available in 6.2.7. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120965] Phantom control point line in Bézier curve
https://bugs.documentfoundation.org/show_bug.cgi?id=120965 Commit Notification changed: What|Removed |Added Whiteboard|target:6.2.0 target:6.4.0 |target:6.2.0 target:6.4.0 |target:6.3.2|target:6.3.2 target:6.2.7 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - svx/source
svx/source/svdraw/svdopath.cxx | 71 +
1 file changed, 44 insertions(+), 27 deletions(-)
New commits:
commit 46c7341014870b4d2c9babd91c14dfed4422f93a
Author: Regina Henschel
AuthorDate: Wed Aug 21 14:11:23 2019 +0200
Commit: Caolán McNamara
CommitDate: Thu Aug 22 20:39:24 2019 +0200
tdf#126271 Revert "tdf120965 Simplify SdrPathObj::AddToHdlList()"
This reverts commit 26001f4f84b0d921c8612d56613735ba5314.
Change-Id: Ib4df476b405e65be9203ab376c9c68b03198c040
Reviewed-on: https://gerrit.libreoffice.org/77882
Tested-by: Regina Henschel
Reviewed-by: Regina Henschel
(cherry picked from commit 59189f3e02acbdf4e5bbd35fc278252b30022f43)
Reviewed-on: https://gerrit.libreoffice.org/77940
Tested-by: Jenkins
diff --git a/svx/source/svdraw/svdopath.cxx b/svx/source/svdraw/svdopath.cxx
index 63481a141248..eda7c34db46a 100644
--- a/svx/source/svdraw/svdopath.cxx
+++ b/svx/source/svdraw/svdopath.cxx
@@ -2008,45 +2008,62 @@ void SdrPathObj::AddToHdlList(SdrHdlList& rHdlList)
const
void SdrPathObj::AddToPlusHdlList(SdrHdlList& rHdlList, SdrHdl& rHdl) const
{
-// exclude some error situations
-const XPolyPolygon aPathPolyPolygon(GetPathPoly());
+// keep old stuff to be able to keep old SdrHdl stuff, too
+const XPolyPolygon aOldPathPolygon(GetPathPoly());
+sal_uInt16 nPnt = static_cast(rHdl.GetPointNum());
sal_uInt16 nPolyNum = static_cast(rHdl.GetPolyNum());
-if (nPolyNum>=aPathPolyPolygon.Count())
-return;
-const XPolygon& rXPoly = aPathPolyPolygon[nPolyNum];
-sal_uInt16 nPntCount = rXPoly.GetPointCount();
-if (nPntCount<=0)
+if (nPolyNum>=aOldPathPolygon.Count())
return;
-sal_uInt16 nPnt = static_cast(rHdl.GetPointNum());
-if (nPnt>=nPntCount)
-return;
+const XPolygon& rXPoly = aOldPathPolygon[nPolyNum];
+sal_uInt16 nPntMax = rXPoly.GetPointCount();
-if (rXPoly.IsControl(nPnt))
+if (nPntMax<=0)
+return;
+nPntMax--;
+if (nPnt>nPntMax)
return;
-// segment before
-if (nPnt==0 && IsClosed())
-nPnt=nPntCount-1;
-if (nPnt>0 && rXPoly.IsControl(nPnt-1))
+// calculate the number of plus points
+sal_uInt16 nCnt = 0;
+if (rXPoly.GetFlags(nPnt)!=PolyFlags::Control)
{
-std::unique_ptr pHdl(new SdrHdlBezWgt());
-pHdl->SetPos(rXPoly[nPnt-1]);
-pHdl->SetPointNum(nPnt-1);
-pHdl->SetSourceHdlNum(rHdl.GetSourceHdlNum());
-pHdl->SetPlusHdl(true);
-rHdlList.AddHdl(std::move(pHdl));
+if (nPnt==0 && IsClosed())
+nPnt=nPntMax;
+if (nPnt>0 && rXPoly.GetFlags(nPnt-1)==PolyFlags::Control)
+nCnt++;
+if (nPnt==nPntMax && IsClosed())
+nPnt=0;
+if (nPnt(rHdl.GetPointNum());
std::unique_ptr pHdl(new SdrHdlBezWgt());
-pHdl->SetPos(rXPoly[nPnt+1]);
-pHdl->SetPointNum(nPnt+1);
+pHdl->SetPolyNum(rHdl.GetPolyNum());
+
+if (nPnt==0 && IsClosed())
+nPnt=nPntMax;
+if (nPnt>0 && rXPoly.GetFlags(nPnt-1)==PolyFlags::Control &&
nPlusNum==0)
+{
+pHdl->SetPos(rXPoly[nPnt-1]);
+pHdl->SetPointNum(nPnt-1);
+}
+else
+{
+if (nPnt==nPntMax && IsClosed())
+nPnt=0;
+if (nPntSetPos(rXPoly[nPnt+1]);
+pHdl->SetPointNum(nPnt+1);
+}
+}
+
pHdl->SetSourceHdlNum(rHdl.GetSourceHdlNum());
pHdl->SetPlusHdl(true);
rHdlList.AddHdl(std::move(pHdl));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Bug 102495 depends on bug 126560, which changed state. Bug 126560 Summary: KDE-integration (Plasma 5): shifting/inserting rows with Alt+Shift not working correctly https://bugs.documentfoundation.org/show_bug.cgi?id=126560 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 127066] UI: Font size in input line (formular bar) larger than in other UI elements
https://bugs.documentfoundation.org/show_bug.cgi?id=127066 --- Comment #2 from Mike Kaganski --- A transcript from #libreoffice IRC chat: > Marqeaux has joined > Marqeaux: Hi everybody. I want to ask a question about the formula bar in > Calc. The font size in the formula bar has been increased for better > readability. Is there a way to make the font size in the formula bar smaller > again, just like it was in previous versions of LibreOffice? > Marqeaux: Oh, I'm using LibreOffice 6.3.0. I forgot to mention that piece of > information... > quikee[m]: Marqeaux: interesting ... it's the same size for me > Marqeaux: I got LibreOffice 6.3.0. on more machines installed. The formula > bar shows a bigger font (too big for my taste), and the formula bar is also > increased in height. It used to have the same height as the cell bar (where > you see in which cell you are)... > Marqeaux: I prefer the situation like it was in LO 6.2. (the formula bar, I > mean...) > Marqeaux: ;) > mikekaganski: Marqeaux: I confirm font size increase in 6.3 > quikee[m]: maybe it manifests in windows. I was looking in Linux with gtk3 > backend > quikee[m]: we modified the scrollbars of the formula bar.. could be that has > influenced the size > mikekaganski: quikee[m]: /me bisects > Marqeaux: Is there a way in the expert configuration to alter the size of the > fonts in the formula bar, and also the height of the formula bar? > quikee[m]: Marqeaux: no, I don't think so... increase is also not intentional > so it looks like you "found" a bug > mikekaganski: Marqeaux: ... which needs a bug report > mikekaganski: quikee[m]: 04b60370a73b79e3aa0a04bc7cff45dff1db6286 > Marqeaux: I made a screenshot of what I see (on multiple machines, not only > on Xubuntu): https://mupload.nl/img/edk3kknwn.png > mikekaganski: Marqeaux: so it was intentional in the end: tdf#101443 > Marqeaux: I guess it's intentional, because more and more software follow the > GTK3 guidelines. I think it's awful, because GTK3 makes everything big and > bold, and with no borders. I looks like a "Fischer-Price" kinda of > approach > mikekaganski: Marqeaux: it wasn't because of "GTK3" (and most LO users are on > Windows btw); it was because of the previous font was unreadable on some > macOS (not using GTK3 also) > mikekaganski: Marqeaux: "In addition to inputline redesign, character size > has been increased to 120% of original size. This prevents very small / > unreadable inputline character sizes on some OS X resolutions" > Marqeaux: Ah, alright. But anyway I takes up too much space now. It's > fine that the fonts in the formula bar are bigger, but I hope that there's a > way to make it "normal" again... > mikekaganski: Marqeaux: the commit mentioned above has the min font size > fixed (16, strange size for UI actually). You may file an enhancement request > to make it user-configurable or smaller. > Marqeaux: Yes, I also found it a very strange decission to make it that big. > It just doesn't fit into the GUI. I think it's better to make it > user-configurable, rather than to leave it "hard-coded". Although my eyes > aren't that good (I wear glasses and I'm middle aged), but I never had > trouble reading the formula bar as it was before. > Marqeaux: Where can I file an enhancement request? > mikekaganski: Marqeaux: I already wrote a comment there in the original bug. > I gave you the link to the bug, and that's the site where we write and track > reports. > mikekaganski: Marqeaux: please file your request separately regardless of my > comment: it would help to provide arguments when needed. Please put the > mentioned bug to See Also in the new report. Thanks. > Marqeaux: Thanks for the advice. I will report it, along with my arguments. > Thank you too! ;) > Marqeaux has disconnected: Quit: Ik ben weg! Tot ziens allemaal! I still think that it's easy to make a smll tweak - just to make this little thingie a bit bigger... and then do another tiny tweak to change that a little... and so on. But if there's a problem with readability of some text size that is used throughout our application, and there's no such problems in other applications on that OS, then that means that either we use wrong text size *universally* in our app (which means we don't get correct size from OS), or (if we use proper size) that we render text wrong (blurry?). And tweaking text size in one specific control to workaround is just wrong. A fix is needed, but in a different place. Please don't enrich the codebase with hacks that would make it a PITA later to find why something works differently and unexpectedly. And in general - that patch included *different* fixes - something that is *never* a good thing, e.g. in case when you need to revert one change, but not another. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list
[Libreoffice-bugs] [Bug 127066] UI: Font size in input line (formular bar) larger than in other UI elements
https://bugs.documentfoundation.org/show_bug.cgi?id=127066 --- Comment #2 from Mike Kaganski --- A transcript from #libreoffice IRC chat: > Marqeaux has joined > Marqeaux: Hi everybody. I want to ask a question about the formula bar in > Calc. The font size in the formula bar has been increased for better > readability. Is there a way to make the font size in the formula bar smaller > again, just like it was in previous versions of LibreOffice? > Marqeaux: Oh, I'm using LibreOffice 6.3.0. I forgot to mention that piece of > information... > quikee[m]: Marqeaux: interesting ... it's the same size for me > Marqeaux: I got LibreOffice 6.3.0. on more machines installed. The formula > bar shows a bigger font (too big for my taste), and the formula bar is also > increased in height. It used to have the same height as the cell bar (where > you see in which cell you are)... > Marqeaux: I prefer the situation like it was in LO 6.2. (the formula bar, I > mean...) > Marqeaux: ;) > mikekaganski: Marqeaux: I confirm font size increase in 6.3 > quikee[m]: maybe it manifests in windows. I was looking in Linux with gtk3 > backend > quikee[m]: we modified the scrollbars of the formula bar.. could be that has > influenced the size > mikekaganski: quikee[m]: /me bisects > Marqeaux: Is there a way in the expert configuration to alter the size of the > fonts in the formula bar, and also the height of the formula bar? > quikee[m]: Marqeaux: no, I don't think so... increase is also not intentional > so it looks like you "found" a bug > mikekaganski: Marqeaux: ... which needs a bug report > mikekaganski: quikee[m]: 04b60370a73b79e3aa0a04bc7cff45dff1db6286 > Marqeaux: I made a screenshot of what I see (on multiple machines, not only > on Xubuntu): https://mupload.nl/img/edk3kknwn.png > mikekaganski: Marqeaux: so it was intentional in the end: tdf#101443 > Marqeaux: I guess it's intentional, because more and more software follow the > GTK3 guidelines. I think it's awful, because GTK3 makes everything big and > bold, and with no borders. I looks like a "Fischer-Price" kinda of > approach > mikekaganski: Marqeaux: it wasn't because of "GTK3" (and most LO users are on > Windows btw); it was because of the previous font was unreadable on some > macOS (not using GTK3 also) > mikekaganski: Marqeaux: "In addition to inputline redesign, character size > has been increased to 120% of original size. This prevents very small / > unreadable inputline character sizes on some OS X resolutions" > Marqeaux: Ah, alright. But anyway I takes up too much space now. It's > fine that the fonts in the formula bar are bigger, but I hope that there's a > way to make it "normal" again... > mikekaganski: Marqeaux: the commit mentioned above has the min font size > fixed (16, strange size for UI actually). You may file an enhancement request > to make it user-configurable or smaller. > Marqeaux: Yes, I also found it a very strange decission to make it that big. > It just doesn't fit into the GUI. I think it's better to make it > user-configurable, rather than to leave it "hard-coded". Although my eyes > aren't that good (I wear glasses and I'm middle aged), but I never had > trouble reading the formula bar as it was before. > Marqeaux: Where can I file an enhancement request? > mikekaganski: Marqeaux: I already wrote a comment there in the original bug. > I gave you the link to the bug, and that's the site where we write and track > reports. > mikekaganski: Marqeaux: please file your request separately regardless of my > comment: it would help to provide arguments when needed. Please put the > mentioned bug to See Also in the new report. Thanks. > Marqeaux: Thanks for the advice. I will report it, along with my arguments. > Thank you too! ;) > Marqeaux has disconnected: Quit: Ik ben weg! Tot ziens allemaal! I still think that it's easy to make a smll tweak - just to make this little thingie a bit bigger... and then do another tiny tweak to change that a little... and so on. But if there's a problem with readability of some text size that is used throughout our application, and there's no such problems in other applications on that OS, then that means that either we use wrong text size *universally* in our app (which means we don't get correct size from OS), or (if we use proper size) that we render text wrong (blurry?). And tweaking text size in one specific control to workaround is just wrong. A fix is needed, but in a different place. Please don't enrich the codebase with hacks that would make it a PITA later to find why something works differently and unexpectedly. And in general - that patch included *different* fixes - something that is *never* a good thing, e.g. in case when you need to revert one change, but not another. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list
[Libreoffice-bugs] [Bug 125696] Introduce CSS preprocessor
https://bugs.documentfoundation.org/show_bug.cgi?id=125696 Buovjaga changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #5 from Buovjaga --- I don't think there is much need for a preprocessor nowadays. Responding to some points in the raygun.com blog: 1. https://caniuse.com/#feat=css-variables 2. @import causing multiple requests is a non-problem in the age of HTTP/2: https://discourse.wicg.io/t/is-css-import-still-considered-as-an-anti-pattern/1967/5 3. Whole article in general, but as a comment to mixins: https://cathydutton.co.uk/posts/why-i-stopped-using-sass/ "CSS custom properties can do more than just replace pre processor variables, they have the added bonus of being updated dynamically (instead of compiled at build). This allows values to be altered at run time with Javascript and to be scoped without the need for mixins and functions to outwit the cascade." 5. https://caniuse.com/#feat=calc Postprocessing [1] might be more useful, but it is always a danger to introduce more moving parts and complicate the build process. [1] https://postcss.org/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: dbaccess/source
dbaccess/source/ui/dlg/dbwiz.cxx| 70 +++-
dbaccess/source/ui/inc/dbwiz.hxx|5 --
dbaccess/source/ui/uno/DBTypeWizDlg.cxx |4 -
3 files changed, 38 insertions(+), 41 deletions(-)
New commits:
commit 055c249847548a5c28ab5b29f3603ffbe74fe1f0
Author: Caolán McNamara
AuthorDate: Thu Aug 22 16:01:01 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Aug 22 18:31:16 2019 +0200
weld ODbTypeWizDialog
Change-Id: Ie85e8f7a9a7551078e3108e7be9747ae4501d5eb
Reviewed-on: https://gerrit.libreoffice.org/77966
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/dbaccess/source/ui/dlg/dbwiz.cxx b/dbaccess/source/ui/dlg/dbwiz.cxx
index d36da8d5c0e0..9e6fef02f0e6 100644
--- a/dbaccess/source/ui/dlg/dbwiz.cxx
+++ b/dbaccess/source/ui/dlg/dbwiz.cxx
@@ -62,14 +62,11 @@ using namespace com::sun::star::container;
#define ADDITIONAL_PAGE_MYSQL_NATIVE 12
// ODbTypeWizDialog
-ODbTypeWizDialog::ODbTypeWizDialog(vcl::Window* _pParent
- ,SfxItemSet const * _pItems
- ,const Reference< XComponentContext >& _rxORB
- ,const css::uno::Any& _aDataSourceName
- )
-:OWizardMachine(_pParent, WizardButtonFlags::NEXT |
WizardButtonFlags::PREVIOUS | WizardButtonFlags::FINISH |
WizardButtonFlags::CANCEL | WizardButtonFlags::HELP )
+ODbTypeWizDialog::ODbTypeWizDialog(weld::Window* _pParent, SfxItemSet const *
_pItems,
+ const Reference< XComponentContext >&
_rxORB, const css::uno::Any& _aDataSourceName)
+: WizardMachine(_pParent, WizardButtonFlags::NEXT |
WizardButtonFlags::PREVIOUS | WizardButtonFlags::FINISH |
WizardButtonFlags::CANCEL | WizardButtonFlags::HELP )
{
-m_pImpl.reset(new ODbDataSourceAdministrationHelper(_rxORB,GetFrameWeld(),
_pParent ? _pParent->GetFrameWeld() : nullptr, this));
+m_pImpl.reset(new ODbDataSourceAdministrationHelper(_rxORB,
m_xAssistant.get(), _pParent, this));
m_pImpl->setDataSourceOrName(_aDataSourceName);
Reference< XPropertySet > xDatasource = m_pImpl->getCurrentDataSource();
m_pOutSet.reset(new SfxItemSet( *_pItems->GetPool(), _pItems->GetRanges()
));
@@ -77,15 +74,14 @@ ODbTypeWizDialog::ODbTypeWizDialog(vcl::Window* _pParent
m_pImpl->translateProperties(xDatasource, *m_pOutSet);
m_eType =
dbaui::ODbDataSourceAdministrationHelper::getDatasourceType(*m_pOutSet);
-SetPageSizePixel(LogicToPixel(::Size(PAGE_X, PAGE_Y),
MapMode(MapUnit::MapAppFont)));
defaultButton(WizardButtonFlags::NEXT);
enableButtons(WizardButtonFlags::FINISH, false);
enableAutomaticNextButtonState();
-m_pPrevPage->SetHelpId(HID_DBWIZ_PREVIOUS);
-m_pNextPage->SetHelpId(HID_DBWIZ_NEXT);
-m_pCancel->SetHelpId(HID_DBWIZ_CANCEL);
-m_pFinish->SetHelpId(HID_DBWIZ_FINISH);
+m_xPrevPage->set_help_id(HID_DBWIZ_PREVIOUS);
+m_xNextPage->set_help_id(HID_DBWIZ_NEXT);
+m_xCancel->set_help_id(HID_DBWIZ_CANCEL);
+m_xFinish->set_help_id(HID_DBWIZ_FINISH);
// no local resources needed anymore
const DbuTypeCollectionItem& rCollectionItem = dynamic_cast(*_pItems->GetItem(DSID_TYPECOLLECTION));
@@ -93,17 +89,12 @@ ODbTypeWizDialog::ODbTypeWizDialog(vcl::Window* _pParent
ActivatePage();
setTitleBase(DBA_RES(STR_DATABASE_TYPE_CHANGE));
-}
-ODbTypeWizDialog::~ODbTypeWizDialog()
-{
-disposeOnce();
+m_xAssistant->set_current_page(0);
}
-void ODbTypeWizDialog::dispose()
+ODbTypeWizDialog::~ODbTypeWizDialog()
{
-m_pOutSet.reset();
-vcl::OWizardMachine::dispose();
}
IMPL_LINK(ODbTypeWizDialog, OnTypeSelected, OGeneralPage&, _rTabPage, void)
@@ -232,50 +223,56 @@ VclPtr ODbTypeWizDialog::createPage(WizardState
_nState)
{
const char* pStringId = STR_PAGETITLE_ADVANCED;
VclPtr pPage;
+
+OString sIdent(OString::number(_nState));
+weld::Container* pPageContainer = m_xAssistant->append_page(sIdent);
+// TODO eventually pass DialogController as distinct argument instead of
bundling into TabPageParent
+TabPageParent aParent(pPageContainer, this);
+
switch(_nState)
{
case START_PAGE: // start state
{
-pPage = VclPtr::Create(this,*m_pOutSet);
+pPage = VclPtr::Create(aParent, *m_pOutSet);
OGeneralPage* pGeneralPage = static_cast< OGeneralPage* >(
pPage.get() );
pGeneralPage->SetTypeSelectHandler( LINK( this, ODbTypeWizDialog,
OnTypeSelected));
pStringId = STR_PAGETITLE_GENERAL;
}
break;
case CONNECTION_PAGE:
-pPage = OConnectionTabPage::Create(this,m_pOutSet.get());
+pPage = OConnectionTabPage::Create(aParent, m_pOutSet.get());
pStringId = STR_PAGETITLE_CONNECTION;
break;
case ADDITIONAL_PAGE_DBASE:
-pPage =
[Libreoffice-commits] core.git: chart2/source chart2/uiconfig dbaccess/source dbaccess/uiconfig dbaccess/UIConfig_dbaccess.mk include/vcl vcl/source vcl/uiconfig vcl/UIConfig_vcl.mk vcl/unx
chart2/source/controller/dialogs/dlg_CreationWizard.cxx | 51 +---
chart2/source/controller/dialogs/dlg_CreationWizard_UNO.cxx | 69
chart2/source/controller/dialogs/dlg_DataSource.cxx |4
chart2/source/controller/dialogs/tp_DataSource.cxx | 24
chart2/source/controller/dialogs/tp_DataSource.hxx |3
chart2/source/controller/dialogs/tp_RangeChooser.cxx| 24
chart2/source/controller/dialogs/tp_RangeChooser.hxx|4
chart2/source/controller/inc/dlg_CreationWizard.hxx |6 -
chart2/source/controller/inc/dlg_CreationWizard_UNO.hxx |4
chart2/uiconfig/ui/tp_RangeChooser.ui |1
chart2/uiconfig/ui/wizelementspage.ui |4
dbaccess/UIConfig_dbaccess.mk |1
dbaccess/source/ui/dlg/dbwizsetup.cxx |9 +
dbaccess/source/ui/inc/dbwizsetup.hxx |1
dbaccess/source/ui/uno/DBTypeWizDlgSetup.cxx|5
include/vcl/roadmapwizard.hxx |2
include/vcl/weld.hxx|2
vcl/UIConfig_vcl.mk |1
vcl/source/app/salvtables.cxx |5
vcl/source/control/roadmapwizard.cxx|6 -
vcl/source/control/wizardmachine.cxx|4
vcl/uiconfig/ui/wizard.ui |5
vcl/unx/gtk3/gtk3gtkinst.cxx| 17 ++
23 files changed, 112 insertions(+), 140 deletions(-)
New commits:
commit d661cb17610af93b1607025284f23187c6d2fc06
Author: Caolán McNamara
AuthorDate: Thu Aug 22 11:15:57 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Aug 22 18:26:41 2019 +0200
weld chart CreationWizard
Change-Id: I7ee88c1e1b0eca5c2510a4bbba8b60c0d8a4e3e8
Reviewed-on: https://gerrit.libreoffice.org/77954
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/chart2/source/controller/dialogs/dlg_CreationWizard.cxx
b/chart2/source/controller/dialogs/dlg_CreationWizard.cxx
index db54937be38c..58a744980556 100644
--- a/chart2/source/controller/dialogs/dlg_CreationWizard.cxx
+++ b/chart2/source/controller/dialogs/dlg_CreationWizard.cxx
@@ -22,6 +22,7 @@
#include
#include
#include
+#include
#include "tp_ChartType.hxx"
#include "tp_RangeChooser.hxx"
@@ -30,9 +31,6 @@
#include "ChartTypeTemplateProvider.hxx"
#include "DialogModel.hxx"
-#define CHART_WIZARD_PAGEWIDTH 250
-#define CHART_WIZARD_PAGEHEIGHT 170
-
using namespace css;
namespace chart
@@ -45,14 +43,14 @@ namespace chart
#define STATE_OBJECTS 3
#define STATE_LAST STATE_OBJECTS
-CreationWizard::CreationWizard(vcl::Window* pParent, const
uno::Reference& xChartModel,
+CreationWizard::CreationWizard(weld::Window* pParent, const
uno::Reference& xChartModel,
const uno::Reference&
xContext)
-: vcl::RoadmapWizard(pParent)
-, m_xChartModel(xChartModel,uno::UNO_QUERY)
-, m_xComponentContext(xContext)
-, m_pTemplateProvider(nullptr)
-, m_aTimerTriggeredControllerLock(xChartModel)
-, m_bCanTravel(true)
+: vcl::RoadmapWizardMachine(pParent)
+, m_xChartModel(xChartModel,uno::UNO_QUERY)
+, m_xComponentContext(xContext)
+, m_pTemplateProvider(nullptr)
+, m_aTimerTriggeredControllerLock(xChartModel)
+, m_bCanTravel(true)
{
m_pDialogModel.reset(new DialogModel(m_xChartModel, m_xComponentContext));
defaultButton(WizardButtonFlags::FINISH);
@@ -69,12 +67,6 @@ CreationWizard::CreationWizard(vcl::Window* pParent, const
uno::ReferencegetModel().isDataFromSpreadsheet())
{
@@ -84,6 +76,16 @@ CreationWizard::CreationWizard(vcl::Window* pParent, const
uno::Referenceset_current_page(0);
+}
+
+short CreationWizard::run()
+{
+int nRet = vcl::RoadmapWizardMachine::run();
+if (nRet == static_cast(WizardButtonFlags::FINISH))
+return ui::dialogs::ExecutableDialogResults::OK;
+return ui::dialogs::ExecutableDialogResults::CANCEL;
}
CreationWizard::~CreationWizard() = default;
@@ -91,12 +93,18 @@ CreationWizard::~CreationWizard() = default;
VclPtr CreationWizard::createPage(WizardState nState)
{
VclPtr pRet;
+
+OString sIdent(OString::number(nState));
+weld::Container* pPageContainer = m_xAssistant->append_page(sIdent);
+// TODO eventually pass DialogController as distinct argument instead of
bundling into TabPageParent
+TabPageParent aParent(pPageContainer, this);
+
switch( nState )
{
case STATE_CHARTTYPE:
{
m_aTimerTriggeredControllerLock.startTimer();
-VclPtrInstance pChartTypeTabPage(this,m_xChartModel);
+VclPtrInstance pChartTypeTabPage(aParent,
[Libreoffice-bugs] [Bug 127099] CppUnitTest_sc_dataprovider fails on ppc64le
https://bugs.documentfoundation.org/show_bug.cgi?id=127099 --- Comment #4 from Jonathan Brielmaier --- How could I/we further debug this? So you assume it's a compiler bug (on ppc64le). Did I understand that correctly? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: package/source
package/source/manifest/ManifestExport.cxx | 105 +++
package/source/xstor/ocompinstream.cxx | 109 +++
package/source/xstor/owriteablestream.cxx | 345 ++---
package/source/xstor/xfactory.cxx | 27 +
package/source/xstor/xstorage.cxx | 277
package/source/zippackage/ZipPackage.cxx | 114 +++-
package/source/zippackage/ZipPackageStream.cxx |6
package/source/zippackage/zipfileaccess.cxx|4
8 files changed, 441 insertions(+), 546 deletions(-)
New commits:
commit 38001018fa06f721cf87edae923b54ce9a5ab5a7
Author: Arkadiy Illarionov
AuthorDate: Sat Aug 10 18:34:33 2019 +0300
Commit: Arkadiy Illarionov
CommitDate: Thu Aug 22 18:03:16 2019 +0200
Simplify Sequence iterations in package
Use range-based loops, STL and comphelper functions
Change-Id: Ibd836b9b2df2f30b42f2d7a621188d78f5b53196
Reviewed-on: https://gerrit.libreoffice.org/77246
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-by: Arkadiy Illarionov
diff --git a/package/source/manifest/ManifestExport.cxx
b/package/source/manifest/ManifestExport.cxx
index f8c2d0399d4f..4b4d57ce9294 100644
--- a/package/source/manifest/ManifestExport.cxx
+++ b/package/source/manifest/ManifestExport.cxx
@@ -111,33 +111,30 @@ ManifestExport::ManifestExport( uno::Reference<
xml::sax::XDocumentHandler > con
const OUString sPGP_Name( PGP_NAME );
::comphelper::AttributeList * pRootAttrList = new
::comphelper::AttributeList;
-const uno::Sequence < beans::PropertyValue > *pSequence =
rManList.getConstArray();
-const sal_uInt32 nManLength = rManList.getLength();
// find the mediatype of the document if any
OUString aDocMediaType;
OUString aDocVersion;
-sal_Int32 nRootFolderPropIndex=-1;
-for (sal_uInt32 nInd = 0; nInd < nManLength ; nInd++ )
+const uno::Sequence* pRootFolderPropSeq = nullptr;
+for (const uno::Sequence < beans::PropertyValue >& rSequence : rManList)
{
OUString aMediaType;
OUString aPath;
OUString aVersion;
-const beans::PropertyValue *pValue = pSequence[nInd].getConstArray();
-for (sal_uInt32 j = 0, nNum = pSequence[nInd].getLength(); j < nNum;
j++, pValue++)
+for (const beans::PropertyValue& rValue : rSequence)
{
-if (pValue->Name == sMediaTypeProperty )
+if (rValue.Name == sMediaTypeProperty )
{
-pValue->Value >>= aMediaType;
+rValue.Value >>= aMediaType;
}
-else if (pValue->Name == sFullPathProperty )
+else if (rValue.Name == sFullPathProperty )
{
-pValue->Value >>= aPath;
+rValue.Value >>= aPath;
}
-else if (pValue->Name == sVersionProperty )
+else if (rValue.Name == sVersionProperty )
{
-pValue->Value >>= aVersion;
+rValue.Value >>= aVersion;
}
if ( !aPath.isEmpty() && !aMediaType.isEmpty() &&
!aVersion.isEmpty() )
@@ -148,7 +145,7 @@ ManifestExport::ManifestExport( uno::Reference<
xml::sax::XDocumentHandler > con
{
aDocMediaType = aMediaType;
aDocVersion = aVersion;
-nRootFolderPropIndex = nInd;
+pRootFolderPropSeq =
break;
}
}
@@ -217,15 +214,13 @@ ManifestExport::ManifestExport( uno::Reference<
xml::sax::XDocumentHandler > con
xHandler->startElement( sManifestElement, xRootAttrList );
const uno::Any *pKeyInfoProperty = nullptr;
-if ( nRootFolderPropIndex >= 0 )
+if ( pRootFolderPropSeq )
{
// do we have package-wide encryption info?
-const beans::PropertyValue *pValue =
-pSequence[nRootFolderPropIndex].getConstArray();
-for (sal_uInt32 j = 0, nNum =
pSequence[nRootFolderPropIndex].getLength(); j < nNum; j++, pValue++)
+for (const beans::PropertyValue& rValue : *pRootFolderPropSeq)
{
-if (pValue->Name == sKeyInfo )
-pKeyInfoProperty = >Value;
+if (rValue.Name == sKeyInfo )
+pKeyInfoProperty =
}
if ( pKeyInfoProperty )
@@ -242,22 +237,19 @@ ManifestExport::ManifestExport( uno::Reference<
xml::sax::XDocumentHandler > con
uno::Sequence< uno::Sequence < beans::NamedValue > >
aKeyInfoSequence;
*pKeyInfoProperty >>= aKeyInfoSequence;
-const uno::Sequence < beans::NamedValue > *pKeyInfoSequence =
aKeyInfoSequence.getConstArray();
-const sal_uInt32 nKeyInfoLength = aKeyInfoSequence.getLength();
-for (sal_uInt32 nInd = 0; nInd < nKeyInfoLength ; nInd++ )
+for (const uno::Sequence& rKeyInfoSequence :
std::as_const(aKeyInfoSequence))
{
uno::Sequence
[Libreoffice-bugs] [Bug 127103] New: Typo in tip of the day
https://bugs.documentfoundation.org/show_bug.cgi?id=127103 Bug ID: 127103 Summary: Typo in tip of the day Product: LibreOffice Version: 6.3.0.0.alpha1+ Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: trivial Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: emo_asse...@yahoo.com Created attachment 153584 --> https://bugs.documentfoundation.org/attachment.cgi?id=153584=edit screenshot Install the product on a clean machine where there has not been any previous installation Open Calc Issue: Grammar/typo in tip of the day "To temporarily starts with a fresh user profile" Should be "To temporarily start with a fresh user profile" Version: 6.3.0.4 (x64) Build ID: 057fc023c990d676a43019934386b85b21a9ee99 CPU threads: 1; OS: Windows 6.3; UI render: default; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/ooxmlexport/ooxmlexport13.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 3a2eeafc30b6b6cf3dafc6d3b94144ba54a8b48b
Author: Tamás Zolnai
AuthorDate: Thu Aug 22 15:55:54 2019 +0200
Commit: Tamás Zolnai
CommitDate: Thu Aug 22 17:37:32 2019 +0200
This is an export test.
Change-Id: Idad907f192c7a4e536bd1b8ca899fc6f9d55bbdf
Reviewed-on: https://gerrit.libreoffice.org/77962
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
index 5666f4fae730..f8bafc76d47c 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
@@ -502,7 +502,7 @@ DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf121663,
"tdf121663.docx")
assertXPath(pXmlDoc, "//w:lnNumType", "distance", "283");
}
-DECLARE_OOXMLIMPORT_TEST(testInvalidDateFormField,
"invalid_date_form_field.docx")
+DECLARE_OOXMLEXPORT_TEST(testInvalidDateFormField,
"invalid_date_form_field.docx")
{
SwXTextDocument* pTextDoc = dynamic_cast(mxComponent.get());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 127102] FILEOPEN Combined Chart of type stacked area + stacked column loses column stacking
https://bugs.documentfoundation.org/show_bug.cgi?id=127102 --- Comment #1 from Gabor Kelemen --- Created attachment 153583 --> https://bugs.documentfoundation.org/attachment.cgi?id=153583=edit Screenshot of the original document side by side in Word and Writer -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127102] New: FILEOPEN Combined Chart of type stacked area + stacked column loses column stacking
https://bugs.documentfoundation.org/show_bug.cgi?id=127102 Bug ID: 127102 Summary: FILEOPEN Combined Chart of type stacked area + stacked column loses column stacking Product: LibreOffice Version: 6.4.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Chart Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kelem...@ubuntu.com CC: libreoff...@nisz.hu, nem...@numbertext.org Blocks: 75057 Created attachment 153582 --> https://bugs.documentfoundation.org/attachment.cgi?id=153582=edit Example file from Word Opening a simple combined chart with stacked area and stacked columns loses the stacked setting for the columns, displaying them grouped. Steps to reproduce: 1. Insert a chart in Word 2. Change its type to Combined, select one data series to be stacked area and two to be stacked column 3. Save as docx, open it in Writer Actual results: The column components appear grouped instead of stacked. Expected results: Stacking remains unchanged. LibreOffice details: Version: 6.4.0.0.alpha0+ (x86) Build ID: 382aceb80d3c0f420d51762e1f88eee2334ff11b CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-07-21_23:45:18 Locale: hu-HU (hu_HU); UI-Language: en-US Calc: CL Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=75057 [Bug 75057] [META] OOXML Chart object issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75057] [META] OOXML Chart object issues
https://bugs.documentfoundation.org/show_bug.cgi?id=75057 Gabor Kelemen changed: What|Removed |Added Depends on||127102 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=127102 [Bug 127102] FILEOPEN Combined Chart of type stacked area + stacked column loses column stacking -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: oox/source sw/qa
oox/source/export/drawingml.cxx | 10 +++---
sw/qa/extras/ooxmlexport/data/tdf127085.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport13.cxx |7 +++
3 files changed, 14 insertions(+), 3 deletions(-)
New commits:
commit 505cbb9c3d2771a12c989515663cc1eb73dd0c2f
Author: Tamás Zolnai
AuthorDate: Thu Aug 22 15:57:41 2019 +0200
Commit: Tamás Zolnai
CommitDate: Thu Aug 22 17:21:19 2019 +0200
tdf#127085: FILESAVE: Transparency is lost after RT
Change-Id: I22ba83b5cc00f84112a3755898ee2be58337afd6
Reviewed-on: https://gerrit.libreoffice.org/77963
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai
diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index d4b35c8988f6..6f975a298e50 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -1274,14 +1274,18 @@ void
DrawingML::WriteImageBrightnessContrastTransparence(uno::Reference();
if (GetProperty(rXPropSet, "AdjustContrast"))
nContrast = mAny.get();
-if (GetProperty(rXPropSet, "Transparency"))
-nTransparence = mAny.get();
+// Used for shapes with picture fill
+if (GetProperty(rXPropSet, "FillTransparence"))
+nTransparence = mAny.get();
+// Used for pictures
+if (nTransparence == 0 && GetProperty(rXPropSet, "Transparency"))
+nTransparence = static_cast(mAny.get());
if (nBright || nContrast)
diff --git a/sw/qa/extras/ooxmlexport/data/tdf127085.docx
b/sw/qa/extras/ooxmlexport/data/tdf127085.docx
new file mode 100644
index ..65556fe38abd
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf127085.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
index e59e65e19312..5666f4fae730 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
@@ -579,6 +579,13 @@ DECLARE_OOXMLIMPORT_TEST(testInvalidDateFormField,
"invalid_date_form_field.docx
CPPUNIT_ASSERT_EQUAL(int(3), nIndex);
}
+DECLARE_OOXMLEXPORT_TEST(tdf127085, "tdf127085.docx")
+{
+// Fill transparency was lost during export
+uno::Reference xShape(getShape(1), uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(sal_Int16(50), getProperty(xShape,
"FillTransparence"));
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 127101] EDITING Rejecting direct formatting removes former direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=127101 --- Comment #2 from Gabor Kelemen --- Created attachment 153580 --> https://bugs.documentfoundation.org/attachment.cgi?id=153580=edit The example file with changed character formatting and joined paragraphs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127101] EDITING Rejecting direct formatting removes former direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=127101 --- Comment #3 from Gabor Kelemen --- Created attachment 153581 --> https://bugs.documentfoundation.org/attachment.cgi?id=153581=edit The example file after rejecting the changes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127101] EDITING Rejecting direct formatting removes former direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=127101 --- Comment #1 from Gabor Kelemen --- Created attachment 153579 --> https://bugs.documentfoundation.org/attachment.cgi?id=153579=edit The example file with character formatting and paragraph formatting applied -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83946 Gabor Kelemen changed: What|Removed |Added Depends on||127101 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=127101 [Bug 127101] EDITING Rejecting direct formatting removes former direct formatting -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127101] New: EDITING Rejecting direct formatting removes former direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=127101 Bug ID: 127101 Summary: EDITING Rejecting direct formatting removes former direct formatting Product: LibreOffice Version: 6.4.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kelem...@ubuntu.com CC: libreoff...@nisz.hu, nem...@numbertext.org Blocks: 83946 Created attachment 153578 --> https://bugs.documentfoundation.org/attachment.cgi?id=153578=edit Example file from Writer If a paragraph has direct text formatting then we add another formatting as tracked change and reject it, then the text formatting is reset to the default settings instead of the formatting set before the tracked format change. The same happens when we reject a paragraph join that was consequence of a deletion and has modified the paragraph style. The second paragraph gets the style of the first one, but upon rejecting the change does not get its former style back. Steps to reproduce: 1. Open attached file. It has some character formatting set for the first paragraph: bold, underline, superscript, highlight color, hyperlink. Change tracking is enabled. 2. Set the whole first paragraph as underlined. 3. Reject this change. For the paragraph join part: 1. Delete the end of the paragraph formatted as Heading 1 and the beginning of the paragraph formatted as Quotations 2. The style of the second paragraph becomes Heading 1 3. Reject this change. The second paragraphs style remains Heading 1 instead of reverting to Quotations. Actual results: The original character format settings are not restored. Expected results: Rejecting Character formatting should restore former character formatting. LibreOffice details: Version: 6.4.0.0.alpha0+ (x64) Build ID: 3e64065612acec2eb29aa21e2b515953422256d7 CPU threads: 4; OS: Windows 6.3; UI render: GL; VCL: win; TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2019-08-15_22:57:26 Locale: hu-HU (hu_HU); UI-Language: en-US Calc: CL Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=83946 [Bug 83946] [META] Tracking changes issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127100] New: Formula font size cannot be changed when using new Tabbed UI in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=127100 Bug ID: 127100 Summary: Formula font size cannot be changed when using new Tabbed UI in Impress Product: LibreOffice Version: 6.3.0.4 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Formula Editor Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: 2xb.cod...@wwu.de Open LibreOffice Impress, enable Tabbed UI (View -> User Interface -> Tabbed), add a formula and try changing the font size of that formula (i.e. navigate to the tab "Home" and change the font size). The Tab UI is then greyed out instead of the font size being changed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122218] After Update to 6.1.4 on macOS fonts are blurred on retina display
https://bugs.documentfoundation.org/show_bug.cgi?id=122218 --- Comment #33 from di...@gelios.net --- Fonts are not blurry with this build for me. https://dev-builds.libreoffice.org/daily/libreoffice-6-3/MacOSX-x86_64@49-TDF/2019-08-21_17.28.20/libreoffice-6-3~2019-08-21_17.28.20_LibreOfficeDev_6.3.2.0.0_MacOS_x86-64.dmg -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127099] CppUnitTest_sc_dataprovider fails on ppc64le
https://bugs.documentfoundation.org/show_bug.cgi?id=127099 --- Comment #3 from Noel Grandin --- This looks like some kind of shutdown/C++ destructor problem, probably because the order of destruction of C++ global objects is undefined, and the order slightly different on your machine, and some global object is attempting to access another global object during shutdown, but the accessee is already dead. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127099] CppUnitTest_sc_dataprovider fails on ppc64le
https://bugs.documentfoundation.org/show_bug.cgi?id=127099 --- Comment #2 from Caolán McNamara --- yeah, crash on cleanup of globals on exit, I doubt its a specific LibreOffice bug personally. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Reverting patch
Hi Michael, Michael Weghorn schrieb am 22-Aug-19 um 13:21: Hi Regina, On 22/08/2019 13.12, Regina Henschel wrote: Hi Michael, I need help with some basics. Michael Weghorn schrieb am 22-Aug-19 um 08:41: If you want to explicitly test this actually works as expected, you can build the respective branch How to "build the respective branch" ? After you have checked out the gerrit patch, you can build it the same way as you build master, i.e. run './autogen.sh' and then 'make'. The checkout will be the branch that the gerrit patch has been cherry-picked to, e.g. the libreoffice-6-3 branch for [1] + your patch on top, so you can test whether this works as expected for LibreOffice 6.3. Thank you. I have realized now, that I have to use "check-out" and not "cherry-pick". I have finally got a build 6.3.2.0 and have tested the patch. Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - vcl/inc vcl/qt5 vcl/unx
vcl/inc/qt5/Qt5DragAndDrop.hxx | 21 +
vcl/inc/qt5/Qt5Frame.hxx| 10 +-
vcl/inc/qt5/Qt5Tools.hxx|3
vcl/inc/qt5/Qt5Transferable.hxx |2
vcl/inc/qt5/Qt5Widget.hxx |2
vcl/qt5/Qt5DragAndDrop.cxx | 93
vcl/qt5/Qt5Frame.cxx| 153
vcl/qt5/Qt5Tools.cxx| 12 +++
vcl/qt5/Qt5Widget.cxx | 32 +---
vcl/unx/kde5/KDE5SalFrame.hxx |4 -
10 files changed, 174 insertions(+), 158 deletions(-)
New commits:
commit 658ab1db3abce8941352d8d9def1468496985a60
Author: Jan-Marek Glogowski
AuthorDate: Thu Aug 8 17:59:20 2019 +
Commit: Michael Weghorn
CommitDate: Thu Aug 22 16:38:04 2019 +0200
tdf#126560 Qt5 fix D'n'D key-modifier handling
The patch has still one problem: the key-modifier state isn't
reflected by the cursor, unless the user moves the mouse. There is
an upstream Qt bug, reported in 2016-09 against Qt 5.6.1! It is
supposed to be fixed in Qt 5.12, according to the bug report at
https://bugreports.qt.io/browse/QTBUG-56218, which is still open.
I thought about adding a configure test, but I couldn't imagine
any realistic way to write it. And after Michael Weghorn found the
bug is actually not fixed, as claimed in one of the comments, I
decided to drop the warning.
Change-Id: Ice8ebc4ea149282b4c1551e755efe3d4856cf782
Reviewed-on: https://gerrit.libreoffice.org/77174
Reviewed-by: Michael Weghorn
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
(cherry picked from commit 3355be0616c24c5e44b71e7623c4191ed9c69074)
Reviewed-on: https://gerrit.libreoffice.org/77956
diff --git a/vcl/inc/qt5/Qt5DragAndDrop.hxx b/vcl/inc/qt5/Qt5DragAndDrop.hxx
index dcd6cb5e4048..0ec9ce5bbcb2 100644
--- a/vcl/inc/qt5/Qt5DragAndDrop.hxx
+++ b/vcl/inc/qt5/Qt5DragAndDrop.hxx
@@ -25,7 +25,6 @@ class Qt5DragSource
osl::Mutex m_aMutex;
Qt5Frame* m_pFrame;
css::uno::Reference
m_xListener;
-css::uno::Reference m_xTrans;
public:
Qt5DragSource()
@@ -55,17 +54,7 @@ public:
css::uno::Sequence SAL_CALL getSupportedServiceNames() override;
-void dragFailed();
-void fire_dragEnd(sal_Int8 nAction);
-
-static Qt5DragSource* m_ActiveDragSource;
-static bool m_bDropSuccessSet;
-static bool m_bDropSuccess;
-
-css::uno::Reference const&
GetTransferable() const
-{
-return m_xTrans;
-}
+void fire_dragEnd(sal_Int8 nAction, bool bSuccessful);
};
class Qt5DropTarget
@@ -76,11 +65,11 @@ class Qt5DropTarget
{
osl::Mutex m_aMutex;
Qt5Frame* m_pFrame;
-sal_Int8 mnDragAction;
-sal_Int8 mnDropAction;
+sal_Int8 m_nDropAction;
bool m_bActive;
sal_Int8 m_nDefaultActions;
std::vector>
m_aListeners;
+bool m_bDropSuccessful;
public:
Qt5DropTarget();
@@ -115,10 +104,12 @@ public:
css::uno::Sequence SAL_CALL getSupportedServiceNames() override;
void fire_dragEnter(const
css::datatransfer::dnd::DropTargetDragEnterEvent& dtde);
+void fire_dragExit(const css::datatransfer::dnd::DropTargetEvent& dte);
void fire_dragOver(const css::datatransfer::dnd::DropTargetDragEnterEvent&
dtde);
void fire_drop(const css::datatransfer::dnd::DropTargetDropEvent& dtde);
-sal_Int8 proposedDragAction() const { return mnDragAction; }
+sal_Int8 proposedDropAction() const { return m_nDropAction; }
+bool dropSuccessful() const { return m_bDropSuccessful; }
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/inc/qt5/Qt5Frame.hxx b/vcl/inc/qt5/Qt5Frame.hxx
index 4c94b846bc93..e296ce92db29 100644
--- a/vcl/inc/qt5/Qt5Frame.hxx
+++ b/vcl/inc/qt5/Qt5Frame.hxx
@@ -56,6 +56,8 @@ class Qt5MainWindow;
class Qt5Menu;
class Qt5SvpGraphics;
+class QDragMoveEvent;
+class QDropEvent;
class QImage;
class QMimeData;
class QPaintDevice;
@@ -159,10 +161,10 @@ public:
virtual void deregisterDragSource(Qt5DragSource const* pDragSource);
virtual void registerDropTarget(Qt5DropTarget* pDropTarget);
virtual void deregisterDropTarget(Qt5DropTarget const* pDropTarget);
-void draggingStarted(const int x, const int y, Qt::DropActions eActions,
- Qt::KeyboardModifiers eKeyMod, const QMimeData*
pQMimeData);
-void dropping(const int x, const int y, Qt::KeyboardModifiers eKeyMod,
- const QMimeData* pQMimeData);
+
+void handleDragLeave();
+void handleDragMove(QDragMoveEvent* pEvent);
+void handleDrop(QDropEvent* pEvent);
virtual void SetExtendedFrameStyle(SalExtStyle nExtStyle) override;
virtual void Show(bool bVisible, bool bNoActivate = false) override;
diff --git a/vcl/inc/qt5/Qt5Tools.hxx b/vcl/inc/qt5/Qt5Tools.hxx
index 6b1fb1adcc7e..697b703e28f4 100644
--- a/vcl/inc/qt5/Qt5Tools.hxx
+++ b/vcl/inc/qt5/Qt5Tools.hxx
@@ -70,6 +70,7 @@ inline QColor toQColor(const Color& rColor)
[Libreoffice-commits] core.git: cui/source dbaccess/source dbaccess/uiconfig dbaccess/UIConfig_dbaccess.mk include/svtools include/tools include/vcl vcl/source vcl/unx
cui/source/dialogs/about.cxx | 28 - cui/source/inc/about.hxx | 11 dbaccess/UIConfig_dbaccess.mk |1 dbaccess/source/ui/dlg/adminpages.cxx |4 dbaccess/source/ui/dlg/dbwizsetup.cxx | 88 +-- dbaccess/source/ui/dlg/generalpage.cxx| 44 - dbaccess/source/ui/dlg/generalpage.hxx|6 dbaccess/source/ui/dlg/sqlmessage.cxx |2 dbaccess/source/ui/inc/dbwizsetup.hxx |5 dbaccess/source/ui/uno/DBTypeWizDlgSetup.cxx |6 dbaccess/uiconfig/ui/authentificationpage.ui |4 dbaccess/uiconfig/ui/databasewizard.ui| 18 dbaccess/uiconfig/ui/dbasepage.ui |4 dbaccess/uiconfig/ui/dbwizconnectionpage.ui |5 dbaccess/uiconfig/ui/dbwizmysqlintropage.ui |5 dbaccess/uiconfig/ui/dbwizmysqlnativepage.ui |8 dbaccess/uiconfig/ui/dbwizspreadsheetpage.ui | 39 - dbaccess/uiconfig/ui/dbwiztextpage.ui |8 dbaccess/uiconfig/ui/finalpagewizard.ui | 23 dbaccess/uiconfig/ui/generalpagewizard.ui | 67 +- dbaccess/uiconfig/ui/jdbcconnectionpage.ui|3 dbaccess/uiconfig/ui/ldapconnectionpage.ui|4 dbaccess/uiconfig/ui/specialjdbcconnectionpage.ui |5 include/svtools/helpids.h |3 include/tools/wintypes.hxx|5 include/vcl/roadmapwizard.hxx | 146 + include/vcl/vclenum.hxx | 15 include/vcl/weld.hxx | 42 + include/vcl/wizardmachine.hxx | 251 - vcl/source/app/salvtables.cxx | 293 ++ vcl/source/control/button.cxx |3 vcl/source/control/roadmapwizard.cxx | 356 - vcl/source/control/wizardmachine.cxx | 598 +- vcl/unx/gtk3/gtk3gtkinst.cxx | 399 -- 34 files changed, 2219 insertions(+), 280 deletions(-) New commits: commit 69057064d8957804c76e623d57c103c3413b7cbc Author: Caolán McNamara AuthorDate: Mon Aug 5 17:26:53 2019 +0100 Commit: Caolán McNamara CommitDate: Thu Aug 22 16:37:16 2019 +0200 weld ODbTypeWizDialogSetup split up RoadmapWizard to sit its wizard logic on top of a a native GtkAssistant a) awkwardly GtkAssistant is not a GtkDialog, but derives directly from GtkWindow so some shuffling around required due to that b) hidden/unused pages are shuffled to the end of the list of pages and their titles turned off in order to hide them from the roadmap c) some nonstandard hackery required to get the gtk roadmap titles to wrap Change-Id: I0d2346c489fef744136a2785f33c846d97bd8dc6 Reviewed-on: https://gerrit.libreoffice.org/76876 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/cui/source/dialogs/about.cxx b/cui/source/dialogs/about.cxx index a9617f7a8381..da2e4d2b4e2d 100644 --- a/cui/source/dialogs/about.cxx +++ b/cui/source/dialogs/about.cxx @@ -68,13 +68,13 @@ AboutDialog::AboutDialog(weld::Window* pParent) m_xDialog->add_button(CuiResId(RID_SVXSTR_ABOUT_WEBSITE), 102); m_xDialog->add_button(CuiResId(RID_SVXSTR_ABOUT_RELEASE_NOTES), 103); -m_pCreditsButton = m_xDialog->get_widget_for_response(101); -m_pCreditsButton->set_secondary(true); -m_pWebsiteButton = m_xDialog->get_widget_for_response(102); -m_pWebsiteButton->set_secondary(true); -m_pReleaseNotesButton = m_xDialog->get_widget_for_response(103); -m_pReleaseNotesButton->set_secondary(true); -m_pCloseButton = m_xDialog->get_widget_for_response(RET_CLOSE); +m_xCreditsButton.reset(m_xDialog->weld_widget_for_response(101)); +m_xCreditsButton->set_secondary(true); +m_xWebsiteButton.reset(m_xDialog->weld_widget_for_response(102)); +m_xWebsiteButton->set_secondary(true); +m_xReleaseNotesButton.reset(m_xDialog->weld_widget_for_response(103)); +m_xReleaseNotesButton->set_secondary(true); +m_xCloseButton.reset(m_xDialog->weld_widget_for_response(RET_CLOSE)); m_buildIdLinkString = m_xDialog->get_website_label(); @@ -88,10 +88,10 @@ AboutDialog::AboutDialog(weld::Window* pParent) m_xDialog->connect_size_allocate(LINK(this, AboutDialog, SizeAllocHdl)); // Connect all handlers -m_pCreditsButton->connect_clicked( LINK( this, AboutDialog, HandleClick ) ); -m_pWebsiteButton->connect_clicked( LINK( this, AboutDialog, HandleClick ) ); -m_pReleaseNotesButton->connect_clicked( LINK( this, AboutDialog, HandleClick ) ); -m_pCloseButton->grab_focus(); +m_xCreditsButton->connect_clicked( LINK( this, AboutDialog, HandleClick ) ); +m_xWebsiteButton->connect_clicked( LINK( this, AboutDialog, HandleClick ) ); +
[Libreoffice-qa] ESC meeting 2019-08-22 minutes
* Present: + Michael W, Olivier, Christian, Stephan, Caolan, Sophie, Thorsten, Miklos, Heiko * Completed Action Items: + Package Silesian (szl) - ready to be used as UI language (Cloph) [ done locally, but not yet pushed ] + Emoji toolbar control out of experimental (Heiko) + https://bugs.documentfoundation.org/show_bug.cgi?id=105689#c28 [ looked, something wrong on Windows – will investigate more ] [ but punted the idea for later ] * Pending Action Items: + Change behavior of Previous/Next Change commands: look at https://gerrit.libreoffice.org/#/c/76719/, decide if it’s safe or not (Kendy) + Talk to Markus about showing just dll name in crash reporting (Xisco) [ mail sent, but the issue not sorted out yet ] + Check with Italo wrt. LibOCon Hackfest wiki page (Sophie) + 6.4 release plan (Christian) * Release Engineering update (Christian) + 6.2 – no releases end of Sep + would prefer a next bugfix release earlier than 60 days (Caolan) AI: came up with a proposal (Cloph) + 6.3 + 6.3.1 RC1 is late, RC2 will be delayed a bit (Cloph) + Remotes + Android viewer + Online + daily builds – people are asking (Thorsten) + Xisco now has the know-how (Cloph) + Linux and macOS is sorted out, but Windows is a bit more complicated + bibisect is also an option * Documentation (Olivier) + New Help + Investigating xapian-omega for search engine in online version + Helpcontents2 + Several fixes in Help (ohallot) + QR Code Help page (S. Goyal) + Many refactoring in pages after bug triaging + Guides + More work on Calc and Draw guide + GSDOC + Tech writer bonding phase – Start work next week * UX Update (Heiko) + Bugzilla (topicUI) statistics 238(238) (topicUI) bugs open, 204(204) (needsUXEval) needs to be evaluated by the UXteam + Updates: BZ changes 1 week1 month 3 months 12 months added 6(-2) 17(-1)34(0) 77(-1) commented 64(-89) 282(-4) 552(4) 1583(30) removed 1(1) 2(0) 3(1) 21(1) resolved 7(-11)36(5) 48(4) 149(5) + top 10 contributors: Heiko Tietze made 189 changes in 1 month, and 299 changes in 1 year Foote, V Stuart made 81 changes in 1 month, and 260 changes in 1 year Kainz, Andreas made 48 changes in 1 month, and 235 changes in 1 year Todd made 42 changes in 1 month, and 42 changes in 1 year Dieter Praas made 31 changes in 1 month, and 149 changes in 1 year Cor Nouws made 22 changes in 1 month, and 130 changes in 1 year Thomas Lendo made 21 changes in 1 month, and 249 changes in 1 year Xisco Faulí made 21 changes in 1 month, and 277 changes in 1 year Kaganski, Mike made 20 changes in 1 month, and 40 changes in 1 year Henschel, Regina made 19 changes in 1 month, and 39 changes in 1 year + New needsUXEval between Aug/15-22 * Deleting the source CSV file of an Address List should delete it from data sources + https://bugs.documentfoundation.org/show_bug.cgi?id=125331 * Searching in comments doesn't work + https://bugs.documentfoundation.org/show_bug.cgi?id=125974 => NAB/WF/WFM * More explanatory title for "Compare documents" file select dialog + https://bugs.documentfoundation.org/show_bug.cgi?id=126618 -> * FONT EFFECTS: strikethrough enhancements + https://bugs.documentfoundation.org/show_bug.cgi?id=127053 => NEW + be careful, perhaps the actual rendering is not trivial (Miklos) + it’s in ODF after all (Heiko) * Sheet tab list position should be remembered across sessions + https://bugs.documentfoundation.org/show_bug.cgi?id=125112 * Paragraph Style Inheritance Bug: Derived styles of Heading 1..10 missing "Chapter Numbering" List Style used by Chapter Numbering Feature + https://bugs.documentfoundation.org/show_bug.cgi?id=126887 * Add DRAW templates to LibreOffice + https://bugs.documentfoundation.org/show_bug.cgi?id=127028 * Cannot find special character if does not know character name but number + https://bugs.documentfoundation.org/show_bug.cgi?id=111816 * Font size in input line (formular bar) lager than in other UI elements + https://bugs.documentfoundation.org/show_bug.cgi?id=127066 => unconfirmed/in discussion * Crash Testing (Caolan) + 0(-1) import failure, 1(-6) export failures + 51 (+2) coverity issues + other eyes welcome now + Google / ossfuzz + 15 issues (15 Timeouts, 1 OOM) * Crash Reporting (Xisco) + https://crashreport.libreoffice.org/stats/version/6.2.5.2 + 1865 (+57) 1808 + https://crashreport.libreoffice.org/stats/version/6.2.6.2 + 246 (+234) 12 +
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - svx/source
svx/source/svdraw/svdopath.cxx | 71 +
1 file changed, 44 insertions(+), 27 deletions(-)
New commits:
commit 6f9e19c85ffc290e600084b33d9a929db28c144d
Author: Regina Henschel
AuthorDate: Wed Aug 21 14:11:23 2019 +0200
Commit: Caolán McNamara
CommitDate: Thu Aug 22 16:36:14 2019 +0200
tdf#126271 Revert "tdf120965 Simplify SdrPathObj::AddToHdlList()"
This reverts commit 26001f4f84b0d921c8612d56613735ba5314.
Change-Id: Ib4df476b405e65be9203ab376c9c68b03198c040
Reviewed-on: https://gerrit.libreoffice.org/77882
Tested-by: Regina Henschel
Reviewed-by: Regina Henschel
(cherry picked from commit 59189f3e02acbdf4e5bbd35fc278252b30022f43)
Reviewed-on: https://gerrit.libreoffice.org/77939
Tested-by: Jenkins
diff --git a/svx/source/svdraw/svdopath.cxx b/svx/source/svdraw/svdopath.cxx
index 12a7b2c1af39..9b4e5f060310 100644
--- a/svx/source/svdraw/svdopath.cxx
+++ b/svx/source/svdraw/svdopath.cxx
@@ -2008,45 +2008,62 @@ void SdrPathObj::AddToHdlList(SdrHdlList& rHdlList)
const
void SdrPathObj::AddToPlusHdlList(SdrHdlList& rHdlList, SdrHdl& rHdl) const
{
-// exclude some error situations
-const XPolyPolygon aPathPolyPolygon(GetPathPoly());
+// keep old stuff to be able to keep old SdrHdl stuff, too
+const XPolyPolygon aOldPathPolygon(GetPathPoly());
+sal_uInt16 nPnt = static_cast(rHdl.GetPointNum());
sal_uInt16 nPolyNum = static_cast(rHdl.GetPolyNum());
-if (nPolyNum>=aPathPolyPolygon.Count())
-return;
-const XPolygon& rXPoly = aPathPolyPolygon[nPolyNum];
-sal_uInt16 nPntCount = rXPoly.GetPointCount();
-if (nPntCount<=0)
+if (nPolyNum>=aOldPathPolygon.Count())
return;
-sal_uInt16 nPnt = static_cast(rHdl.GetPointNum());
-if (nPnt>=nPntCount)
-return;
+const XPolygon& rXPoly = aOldPathPolygon[nPolyNum];
+sal_uInt16 nPntMax = rXPoly.GetPointCount();
-if (rXPoly.IsControl(nPnt))
+if (nPntMax<=0)
+return;
+nPntMax--;
+if (nPnt>nPntMax)
return;
-// segment before
-if (nPnt==0 && IsClosed())
-nPnt=nPntCount-1;
-if (nPnt>0 && rXPoly.IsControl(nPnt-1))
+// calculate the number of plus points
+sal_uInt16 nCnt = 0;
+if (rXPoly.GetFlags(nPnt)!=PolyFlags::Control)
{
-std::unique_ptr pHdl(new SdrHdlBezWgt());
-pHdl->SetPos(rXPoly[nPnt-1]);
-pHdl->SetPointNum(nPnt-1);
-pHdl->SetSourceHdlNum(rHdl.GetSourceHdlNum());
-pHdl->SetPlusHdl(true);
-rHdlList.AddHdl(std::move(pHdl));
+if (nPnt==0 && IsClosed())
+nPnt=nPntMax;
+if (nPnt>0 && rXPoly.GetFlags(nPnt-1)==PolyFlags::Control)
+nCnt++;
+if (nPnt==nPntMax && IsClosed())
+nPnt=0;
+if (nPnt(rHdl.GetPointNum());
std::unique_ptr pHdl(new SdrHdlBezWgt());
-pHdl->SetPos(rXPoly[nPnt+1]);
-pHdl->SetPointNum(nPnt+1);
+pHdl->SetPolyNum(rHdl.GetPolyNum());
+
+if (nPnt==0 && IsClosed())
+nPnt=nPntMax;
+if (nPnt>0 && rXPoly.GetFlags(nPnt-1)==PolyFlags::Control &&
nPlusNum==0)
+{
+pHdl->SetPos(rXPoly[nPnt-1]);
+pHdl->SetPointNum(nPnt-1);
+}
+else
+{
+if (nPnt==nPntMax && IsClosed())
+nPnt=0;
+if (nPntSetPos(rXPoly[nPnt+1]);
+pHdl->SetPointNum(nPnt+1);
+}
+}
+
pHdl->SetSourceHdlNum(rHdl.GetSourceHdlNum());
pHdl->SetPlusHdl(true);
rHdlList.AddHdl(std::move(pHdl));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120965] Phantom control point line in Bézier curve
https://bugs.documentfoundation.org/show_bug.cgi?id=120965 Commit Notification changed: What|Removed |Added Whiteboard|target:6.2.0 target:6.4.0 |target:6.2.0 target:6.4.0 ||target:6.3.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126271] Selecting of control points of curves not working correctly for combined polygons
https://bugs.documentfoundation.org/show_bug.cgi?id=126271 --- Comment #12 from Commit Notification --- Regina Henschel committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/6f9e19c85ffc290e600084b33d9a929db28c144d%5E%21 tdf#126271 Revert "tdf120965 Simplify SdrPathObj::AddToHdlList()" It will be available in 6.3.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120965] Phantom control point line in Bézier curve
https://bugs.documentfoundation.org/show_bug.cgi?id=120965 --- Comment #11 from Commit Notification --- Regina Henschel committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/6f9e19c85ffc290e600084b33d9a929db28c144d%5E%21 tdf#126271 Revert "tdf120965 Simplify SdrPathObj::AddToHdlList()" It will be available in 6.3.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126271] Selecting of control points of curves not working correctly for combined polygons
https://bugs.documentfoundation.org/show_bug.cgi?id=126271 Commit Notification changed: What|Removed |Added Whiteboard|target:6.4.0|target:6.4.0 target:6.3.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122218] After Update to 6.1.4 on macOS fonts are blurred on retina display
https://bugs.documentfoundation.org/show_bug.cgi?id=122218 --- Comment #32 from Christian Lohmaier --- To rule out (or confirm) XCode 10 being the issue or not: could you please try with the build from https://dev-builds.libreoffice.org/daily/libreoffice-6-3/MacOSX-x86_64@49-TDF/2019-08-21_17.28.20/ - that was done with XCode 9 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127066] UI: Font size in input line (formular bar) larger than in other UI elements
https://bugs.documentfoundation.org/show_bug.cgi?id=127066 --- Comment #1 from Thorsten Wagner --- Calc input line is a special widget which is used in Calc only. In relation to other UI widgets this widget may contain a lot of text like direct input to Calc cells. It's only a small effort to revert font size equal to the other UI elements, but this will restore worse readability especially with larger amounts of text. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 127066] UI: Font size in input line (formular bar) larger than in other UI elements
https://bugs.documentfoundation.org/show_bug.cgi?id=127066 --- Comment #1 from Thorsten Wagner --- Calc input line is a special widget which is used in Calc only. In relation to other UI widgets this widget may contain a lot of text like direct input to Calc cells. It's only a small effort to revert font size equal to the other UI elements, but this will restore worse readability especially with larger amounts of text. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3-desktop' - sw/source
sw/source/filter/ww8/ww8par.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit d8458569709e5bf5a05630b735f6e6d4b9b135ff Author: Andras Timar AuthorDate: Thu Aug 22 16:32:18 2019 +0200 Commit: Andras Timar CommitDate: Thu Aug 22 16:32:18 2019 +0200 build fix Change-Id: Iecb4be601fe1cb4d3774795be66a1a0f8c33ca3b diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx index afdacbdcb732..b304a40367af 100644 --- a/sw/source/filter/ww8/ww8par.cxx +++ b/sw/source/filter/ww8/ww8par.cxx @@ -5490,8 +5490,8 @@ sal_uLong SwWW8ImplReader::CoreLoad(WW8Glossary *pGloss) UpdateFields(); -m_xWFlyPara.reset(); -m_xSFlyPara.reset(); +DELETEZ(m_pWFlyPara); +DELETEZ(m_pSFlyPara); // delete the pam before the call for hide all redlines (Bug 73683) if (m_bNewDoc) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126968] Save as PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=126968 Commit Notification changed: What|Removed |Added Whiteboard||target:6.4.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126968] Save as PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=126968 --- Comment #2 from Commit Notification --- Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/online/+/634be102c71305f0f35fe86e980ccabb381ae766%5E%21 tdf#126968: Implement "Save as PDF" in the iOS app -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: kit/ChildSession.cpp loleaflet/src
kit/ChildSession.cpp | 10 ++
loleaflet/src/control/Control.Menubar.js |6 ++
loleaflet/src/control/Toolbar.js |3 ++-
3 files changed, 18 insertions(+), 1 deletion(-)
New commits:
commit 634be102c71305f0f35fe86e980ccabb381ae766
Author: Tor Lillqvist
AuthorDate: Thu Aug 22 15:47:12 2019 +0300
Commit: Tor Lillqvist
CommitDate: Thu Aug 22 16:25:14 2019 +0200
tdf#126968: Implement "Save as PDF" in the iOS app
For now, add an entry "Save as PDF" to the File menu in the iOS app.
Handle in an iOS-specific way in ChildSession::downloadAs(). The PDF
is saved in the app's document directory on the device. The name of
the PDF is the basename of the document being edited with the "pdf"
extension.
Change-Id: Ib0059a86b03b978996eb4cadf230ba7f0abcba62
Reviewed-on: https://gerrit.libreoffice.org/77961
Reviewed-by: Tor Lillqvist
Tested-by: Tor Lillqvist
diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp
index fadbca1ea..6d7751fdc 100644
--- a/kit/ChildSession.cpp
+++ b/kit/ChildSession.cpp
@@ -879,6 +879,15 @@ bool ChildSession::downloadAs(const char* /*buffer*/, int
/*length*/, const std:
filterOptions += std::string(",Watermark=") + getWatermarkText() +
std::string("WATERMARKEND");
}
+#ifdef IOS
+NSArray *pathComponents = [[NSURL URLWithString:[NSString
stringWithUTF8String:getDocURL().c_str()]] pathComponents];
+NSString *baseName = [[pathComponents lastObject]
stringByDeletingPathExtension];
+NSURL *documentDirectory = [NSFileManager.defaultManager
URLsForDirectory:NSDocumentDirectory inDomains:NSUserDomainMask][0];
+NSURL *pdfURL = [documentDirectory URLByAppendingPathComponent:[baseName
stringByAppendingString:@".pdf"]];
+getLOKitDocument()->saveAs([[pdfURL absoluteString] UTF8String],
+ format.empty() ? nullptr : format.c_str(),
+ filterOptions.empty() ? nullptr :
filterOptions.c_str());
+#else
// The file is removed upon downloading.
const std::string tmpDir = FileUtil::createRandomDir(JAILED_DOCUMENT_ROOT);
// Prevent user inputting anything funny here.
@@ -898,6 +907,7 @@ bool ChildSession::downloadAs(const char* /*buffer*/, int
/*length*/, const std:
sendTextFrame("downloadas: jail=" + _jailId + " dir=" + tmpDir + " name="
+ name +
" port=" + std::to_string(ClientPortNumber) + " id=" + id);
+#endif
return true;
}
diff --git a/loleaflet/src/control/Control.Menubar.js
b/loleaflet/src/control/Control.Menubar.js
index 41120cfc2..c71fee473 100644
--- a/loleaflet/src/control/Control.Menubar.js
+++ b/loleaflet/src/control/Control.Menubar.js
@@ -27,6 +27,7 @@ L.Control.Menubar = L.Control.extend({
{name: _('Word 2003 Document (.doc)'),
id: 'downloadas-doc', type: 'action'},
{name: _('Word Document (.docx)'), id:
'downloadas-docx', type: 'action'},
{name: _('Rich Text (.rtf)'), id:
'downloadas-rtf', type: 'action'}]},
+ {name: _('Save as PDF'), id: 'downloadas-pdf',
mobileapp: true, type: 'action'},
{name: _('Sign document'), id: 'signdocument',
type: 'action'},
{type: 'separator'},
{name: _('Close document'), id:
'closedocument', type: 'action'}
@@ -250,6 +251,7 @@ L.Control.Menubar = L.Control.extend({
{name: _('ODF presentation (.odp)'),
id: 'downloadas-odp', type: 'action'},
{name: _('PowerPoint 2003 Presentation
(.ppt)'), id: 'downloadas-ppt', type: 'action'},
{name: _('PowerPoint Presentation
(.pptx)'), id: 'downloadas-pptx', type: 'action'}]},
+ {name: _('Save as PDF'), id: 'downloadas-pdf',
mobileapp: true, type: 'action'},
{type: 'separator'},
{name: _('Close document'), id:
'closedocument', type: 'action'}
]},
@@ -338,6 +340,7 @@ L.Control.Menubar = L.Control.extend({
{name: _('ODF spreadsheet (.ods)'), id:
'downloadas-ods', type: 'action'},
{name: _('Excel 2003 Spreadsheet
(.xls)'), id: 'downloadas-xls', type: 'action'},
{name: _('Excel Spreadsheet (.xlsx)'),
id: 'downloadas-xlsx', type: 'action'}]},
+ {name: _('Save as PDF'), id: 'downloadas-pdf',
mobileapp: true, type: 'action'},
{type: 'separator'},
{name: _('Close document'), id:
'closedocument', type: 'action'}
]},
@@ -996,6 +999,9 @@ L.Control.Menubar =
[Libreoffice-bugs] [Bug 125514] Bad text rendering within data source view
https://bugs.documentfoundation.org/show_bug.cgi?id=125514 --- Comment #8 from Thorsten Wagner --- Created attachment 153577 --> https://bugs.documentfoundation.org/attachment.cgi?id=153577=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125514] Bad text rendering within data source view
https://bugs.documentfoundation.org/show_bug.cgi?id=125514 Thorsten Wagner changed: What|Removed |Added Resolution|WORKSFORME |--- Status|RESOLVED|UNCONFIRMED --- Comment #7 from Thorsten Wagner --- Unfortunately issue still exists (see screenshot attached). Retest has been taken place on macOS 10.14.6 with following LO release: Version: 6.3.0.4 Build ID: 057fc023c990d676a43019934386b85b21a9ee99 CPU threads: 8; OS: Mac OS X 10.14.6; UI render: default; VCL: osx; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded BTW: Close button closes whole Writer application. Probably this is not intended. Furthermore horizontal scrolling moves to the wrong direction now. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127099] CppUnitTest_sc_dataprovider fails on ppc64le
https://bugs.documentfoundation.org/show_bug.cgi?id=127099 --- Comment #1 from Jonathan Brielmaier --- Created attachment 153576 --> https://bugs.documentfoundation.org/attachment.cgi?id=153576=edit Valgrind log for CppUnitTest_sc_dataprovider_test -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127099] New: CppUnitTest_sc_dataprovider fails on ppc64le
https://bugs.documentfoundation.org/show_bug.cgi?id=127099 Bug ID: 127099 Summary: CppUnitTest_sc_dataprovider fails on ppc64le Product: LibreOffice Version: 6.3.0.4 release Hardware: PowerPC OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jbrielma...@suse.de Created attachment 153575 --> https://bugs.documentfoundation.org/attachment.cgi?id=153575=edit Debug log for CppUnitTest_sc_dataprovider_test I'm running the unit tests on a Tumbleweed ppc64le machine and the CppUnitTest_sc_dataprovider_test test fails: """ ScDataProvidersTest::testCSVImport finished in: 1810ms [New Thread 0x7fffac59f160 (LWP 22385)] [Thread 0x7fffac59f160 (LWP 22385) exited] ScDataProvidersTest::testDataLargerThanDB finished in: 4ms [New Thread 0x7fffac59f160 (LWP 22386)] [Thread 0x7fffac59f160 (LWP 22386) exited] ScDataProvidersTest::testHTMLImport finished in: 4ms [New Thread 0x7fffac59f160 (LWP 22387)] [Thread 0x7fffac59f160 (LWP 22387) exited] ScDataProvidersTest::testXMLImport finished in: 139ms OK (4) Thread 1 "cppunittester" received signal SIGSEGV, Segmentation fault. 0x7fffad6d42bc in ?? () #0 0x7fffad6d42bc in () #1 0x7fffb785b114 in __run_exit_handlers () at /lib64/libc.so.6 #2 0x7fffb785b308 in exit () at /lib64/libc.so.6 #3 0x7fffb78382a0 in generic_start_main.isra () at /lib64/libc.so.6 #4 0x7fffb7838484 in __libc_start_main () at /lib64/libc.so.6 #5 0x in () A debugging session is active. Inferior 1 [process 22381] will be killed. Quit anyway? (y or n) [answered Y; input not from terminal] """ For me it looks like the actual tests passes, but the unittester segfaults. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3-desktop' - writerfilter/source
writerfilter/source/ooxml/OOXMLStreamImpl.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 1d2fa036f92938dbb386f2301fd0f8eab385761f
Author: Andras Timar
AuthorDate: Thu Aug 22 16:04:27 2019 +0200
Commit: Andras Timar
CommitDate: Thu Aug 22 16:04:27 2019 +0200
build fix
Change-Id: I82ae070fd1597fcdeae420b28f506347eb47b005
diff --git a/writerfilter/source/ooxml/OOXMLStreamImpl.cxx
b/writerfilter/source/ooxml/OOXMLStreamImpl.cxx
index 3398c216093f..0ee4e73dd7f2 100644
--- a/writerfilter/source/ooxml/OOXMLStreamImpl.cxx
+++ b/writerfilter/source/ooxml/OOXMLStreamImpl.cxx
@@ -319,7 +319,7 @@ bool OOXMLStreamImpl::lcl_getTarget(const
uno::Reference xPart =
xFac->parse(sMyTarget);
uno::Reference xAbs =
xFac->makeAbsolute(xBase, xPart, true,
uri::RelativeUriExcessParentSegments_RETAIN);
-if (!xAbs)
+if (!xAbs.is())
{
//it was invalid gibberish
bFound = false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 127085] PPTX: FILESAVE: Transparency is lost after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=127085 Tamás Zolnai changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |zolnaitamas2...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sc/source
sc/source/ui/docshell/docsh.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit bc19862ab3b13f55e9364ba5cfe8547bf30adac7
Author: Julien Nabet
AuthorDate: Wed Aug 21 22:13:58 2019 +0200
Commit: Kohei Yoshida
CommitDate: Thu Aug 22 15:55:17 2019 +0200
Fix full url for calc/styles by adding missing '/'
warn:sc:1272:1272:sc/source/filter/orcus/orcusfiltersimpl.cxx:149: Unable
to load styles from xml file! boost::filesystem::file_size: Aucun fichier ou
dossier de ce type
Thread 1 "soffice.bin" hit Breakpoint 2, (anonymous namespace)::lookup
(file=0x556435a0, mode=(anonymous namespace)::LOOKUP_MODE_NORMAL,
override=false, key="BRAND_BASE_DIRshare", requestStack=0x0)
at /home/julien/lo/libreoffice/sal/rtl/bootstrap.cxx:860
860OUString v;
(gdb) bt
0 0x77f2ae45 in (anonymous namespace)::lookup(Bootstrap_Impl
const*, (anonymous namespace)::LookupMode, bool, rtl::OUString const&,
(anonymous namespace)::ExpandRequestLink const*)
(file=0x556435a0, mode=(anonymous namespace)::LOOKUP_MODE_NORMAL,
override=false, key="BRAND_BASE_DIRshare", requestStack=0x0) at
/home/julien/lo/libreoffice/sal/rtl/bootstrap.cxx:860
1 0x77f2b7f6 in (anonymous namespace)::expandMacros(Bootstrap_Impl
const*, rtl::OUString const&, (anonymous namespace)::LookupMode, (anonymous
namespace)::ExpandRequestLink const*)
(file=0x556435a0, text="$BRAND_BASE_DIRshare/calc/styles.xml",
mode=(anonymous namespace)::LOOKUP_MODE_NORMAL, requestStack=0x0) at
/home/julien/lo/libreoffice/sal/rtl/bootstrap.cxx:995
2 0x77f2aa0d in
rtl_bootstrap_expandMacros_from_handle(rtlBootstrapHandle, rtl_uString**)
(handle=0x556435a0, macro=0x7ffefb90) at
/home/julien/lo/libreoffice/sal/rtl/bootstrap.cxx:791
3 0x77f2aa60 in rtl_bootstrap_expandMacros(rtl_uString**)
(macro=0x7ffefb90) at /home/julien/lo/libreoffice/sal/rtl/bootstrap.cxx:797
4 0x7fffde89e675 in rtl::Bootstrap::expandMacros(rtl::OUString&)
(macro="$BRAND_BASE_DIRshare/calc/styles.xml") at
/home/julien/lo/libreoffice/include/rtl/bootstrap.hxx:131
5 0x7fffde890d5f in ScDocShell::Load(SfxMedium&) (this=0x58034760,
rMedium=...) at /home/julien/lo/libreoffice/sc/source/ui/docshell/docsh.cxx:613
Change-Id: I5e4019c730f25d32b431dbd01c5668189be6cc66
Reviewed-on: https://gerrit.libreoffice.org/77936
Tested-by: Jenkins
Reviewed-by: Kohei Yoshida
(cherry picked from commit 86d55aaad49a3f83b61894afd81f195b37a142af)
Reviewed-on: https://gerrit.libreoffice.org/77955
diff --git a/sc/source/ui/docshell/docsh.cxx b/sc/source/ui/docshell/docsh.cxx
index 48b0532f73a7..372686daacbc 100644
--- a/sc/source/ui/docshell/docsh.cxx
+++ b/sc/source/ui/docshell/docsh.cxx
@@ -604,7 +604,7 @@ bool ScDocShell::Load( SfxMedium& rMedium )
{
/* Create styles that are imported through Orcus */
-OUString aURL("$BRAND_BASE_DIR" LIBO_SHARE_FOLDER
"/calc/styles.xml");
+OUString aURL("$BRAND_BASE_DIR/" LIBO_SHARE_FOLDER
"/calc/styles.xml");
rtl::Bootstrap::expandMacros(aURL);
OUString aPath;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3-desktop' - 3 commits - filter/source sd/source
filter/source/msfilter/msdffimp.cxx | 26 ++
sd/source/filter/ppt/pptin.cxx |2 +-
2 files changed, 19 insertions(+), 9 deletions(-)
New commits:
commit c61ed488f9ed8375e02d8fd41fbe3a0901cd311a
Author: Caolán McNamara
AuthorDate: Sun Nov 26 20:45:10 2017 +
Commit: Andras Timar
CommitDate: Thu Aug 22 15:54:41 2019 +0200
ofz#4436 check if seek succeeded
Change-Id: I56d9692647b28c706b56ccacf08d494b3d830d94
Reviewed-on: https://gerrit.libreoffice.org/45296
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 765ff606426251f90aff5d1fc89f01ed7594ed59)
diff --git a/filter/source/msfilter/msdffimp.cxx
b/filter/source/msfilter/msdffimp.cxx
index 1e4023c4d021..a3d1b2909fb6 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -6046,7 +6046,10 @@ bool SvxMSDffManager::GetShapeGroupContainerData(
SvStream& rSt,
return false;
}
else
-rSt.SeekRel( nLength );
+{
+if (!checkSeek(rSt, rSt.Tell() + nLength))
+return false;
+}
nReadSpGrCont += nLength;
}
while( nReadSpGrCont < nLenShapeGroupCont );
diff --git a/sd/source/filter/ppt/pptin.cxx b/sd/source/filter/ppt/pptin.cxx
index f54b6afe0d2e..b29156594855 100644
--- a/sd/source/filter/ppt/pptin.cxx
+++ b/sd/source/filter/ppt/pptin.cxx
@@ -854,7 +854,7 @@ bool ImplSdPPTImport::Import()
bool bSuccess = aHd.SeekToEndOfRecord(rStCtrl);
if (!bSuccess)
{
-SAL_WARN("filter.ms", "Count not seek to end of
record");
+SAL_WARN("filter.ms", "Could not seek to end of
record");
break;
}
}
commit 74d737aecd0821a255f5ba98be3239a6ff1df984
Author: Caolán McNamara
AuthorDate: Sat Apr 8 20:31:35 2017 +0100
Commit: Andras Timar
CommitDate: Thu Aug 22 15:54:21 2019 +0200
limit symbol visibility
Change-Id: I54d5fbe1cd9d5ae94cb134f08fc00593c802ebee
(cherry picked from commit 79890a6d1bccbba8c40e42566c3d437d7a1aaace)
diff --git a/filter/source/msfilter/msdffimp.cxx
b/filter/source/msfilter/msdffimp.cxx
index 720fac503635..1e4023c4d021 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -222,10 +222,13 @@ DffPropertyReader::DffPropertyReader( const
SvxMSDffManager& rMan )
InitializePropSet( DFF_msofbtOPT );
}
-bool checkSeek(SvStream , sal_uInt32 nOffset)
+namespace
{
-const sal_uInt64 nMaxSeek(rSt.Tell() + rSt.remainingSize());
-return (nOffset <= nMaxSeek && rSt.Seek(nOffset) == nOffset);
+bool checkSeek(SvStream , sal_uInt32 nOffset)
+{
+const sal_uInt64 nMaxSeek(rSt.Tell() + rSt.remainingSize());
+return (nOffset <= nMaxSeek && rSt.Seek(nOffset) == nOffset);
+}
}
void DffPropertyReader::SetDefaultPropSet( SvStream& rStCtrl, sal_uInt32
nOffsDgg ) const
commit 17afdae82f7c9968a372cb70e5792547b50c10ac
Author: Caolán McNamara
AuthorDate: Fri Apr 7 20:49:52 2017 +0100
Commit: Andras Timar
CommitDate: Thu Aug 22 15:54:06 2019 +0200
check escher seeks
Change-Id: I4cb523e8654defa25e75ebd54f1e125ea02e1cf9
Reviewed-on: https://gerrit.libreoffice.org/36281
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
(cherry picked from commit a1147a34d85742fd5d9410efac6fc59ac2fd1574)
diff --git a/filter/source/msfilter/msdffimp.cxx
b/filter/source/msfilter/msdffimp.cxx
index 508bee068d02..720fac503635 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -222,13 +222,20 @@ DffPropertyReader::DffPropertyReader( const
SvxMSDffManager& rMan )
InitializePropSet( DFF_msofbtOPT );
}
+bool checkSeek(SvStream , sal_uInt32 nOffset)
+{
+const sal_uInt64 nMaxSeek(rSt.Tell() + rSt.remainingSize());
+return (nOffset <= nMaxSeek && rSt.Seek(nOffset) == nOffset);
+}
+
void DffPropertyReader::SetDefaultPropSet( SvStream& rStCtrl, sal_uInt32
nOffsDgg ) const
{
delete pDefaultPropSet;
sal_uInt32 nMerk = rStCtrl.Tell();
-rStCtrl.Seek( nOffsDgg );
+bool bOk = checkSeek(rStCtrl, nOffsDgg);
DffRecordHeader aRecHd;
-bool bOk = ReadDffRecordHeader( rStCtrl, aRecHd );
+if (bOk)
+bOk = ReadDffRecordHeader( rStCtrl, aRecHd );
if (bOk && aRecHd.nRecType == DFF_msofbtDggContainer)
{
if ( SvxMSDffManager::SeekToRec( rStCtrl, DFF_msofbtOPT,
aRecHd.GetRecEndFilePos() ) )
@@ -5839,13 +5846,10 @@ void SvxMSDffManager::CheckTxBxStoryChain()
and remembering the File-Offsets for each Blip
**/
-void SvxMSDffManager::GetCtrlData( sal_uInt32 nOffsDgg_ )
+void
[Libreoffice-commits] core.git: 2 commits - include/test include/toolkit include/unotest toolkit/source
include/test/sheet/xcellrangereferrer.hxx |2 +-
include/test/sheet/xformulaquery.hxx |2 +-
include/test/table/xtablecolumns.hxx |2 +-
include/toolkit/awt/vclxwindows.hxx |4 ++--
include/unotest/bootstrapfixturebase.hxx |4 ++--
toolkit/source/awt/vclxwindow.cxx |4 ++--
toolkit/source/awt/vclxwindows.cxx|4 ++--
7 files changed, 11 insertions(+), 11 deletions(-)
New commits:
commit e724f245e9652230d4c1f58c353be150006affcd
Author: Noel Grandin
AuthorDate: Thu Aug 22 13:41:58 2019 +0200
Commit: Noel Grandin
CommitDate: Thu Aug 22 15:46:24 2019 +0200
loplugin:constmethod in test
Change-Id: I15aa90d962b9d428a911f4b47a06d55318b42ba4
Reviewed-on: https://gerrit.libreoffice.org/77953
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/test/sheet/xcellrangereferrer.hxx
b/include/test/sheet/xcellrangereferrer.hxx
index f840a6bd1355..949f6b12eb7e 100644
--- a/include/test/sheet/xcellrangereferrer.hxx
+++ b/include/test/sheet/xcellrangereferrer.hxx
@@ -24,7 +24,7 @@ public:
virtual css::uno::Reference< css::uno::XInterface > init() = 0;
void setCellRange(css::table::CellRangeAddress aCellRange) { m_aCellRange
= aCellRange; }
-const css::table::CellRangeAddress & getCellRange() { return m_aCellRange;
}
+const css::table::CellRangeAddress & getCellRange() const { return
m_aCellRange; }
void testGetReferredCells();
protected:
diff --git a/include/test/sheet/xformulaquery.hxx
b/include/test/sheet/xformulaquery.hxx
index 7beb944e192c..662bc6c90fc6 100644
--- a/include/test/sheet/xformulaquery.hxx
+++ b/include/test/sheet/xformulaquery.hxx
@@ -35,7 +35,7 @@ public:
virtual css::uno::Reference init() = 0;
virtual css::uno::Reference getXSpreadsheet() = 0;
void setXCell(css::uno::Reference xCell) { m_xCell =
xCell; }
-css::uno::Reference const& getXCell() { return m_xCell;
}
+css::uno::Reference const& getXCell() const { return
m_xCell; }
void testQueryDependents();
void testQueryPrecedents();
diff --git a/include/test/table/xtablecolumns.hxx
b/include/test/table/xtablecolumns.hxx
index 204fb2860aa2..169eac9dbc77 100644
--- a/include/test/table/xtablecolumns.hxx
+++ b/include/test/table/xtablecolumns.hxx
@@ -25,7 +25,7 @@ class OOO_DLLPUBLIC_TEST XTableColumns
public:
virtual css::uno::Reference init() = 0;
-void setXSpreadsheet(css::uno::Reference&
r_xSheet)
+void setXSpreadsheet(const css::uno::Reference&
r_xSheet)
{
m_xSheet = r_xSheet;
}
diff --git a/include/unotest/bootstrapfixturebase.hxx
b/include/unotest/bootstrapfixturebase.hxx
index 0a967d34d736..85f270b02c2c 100644
--- a/include/unotest/bootstrapfixturebase.hxx
+++ b/include/unotest/bootstrapfixturebase.hxx
@@ -59,9 +59,9 @@ public:
virtual ~BootstrapFixtureBase() override;
const css::uno::Reference&
- getComponentContext() { return m_xContext; }
+ getComponentContext() const { return m_xContext; }
const css::uno::Reference&
- getMultiServiceFactory() { return m_xSFactory; }
+ getMultiServiceFactory() const { return m_xSFactory; }
virtual void setUp() override;
virtual void tearDown() override;
commit 8a82dca5bd43080f0f5597b915d1433b1c0f141a
Author: Noel Grandin
AuthorDate: Thu Aug 22 13:41:08 2019 +0200
Commit: Noel Grandin
CommitDate: Thu Aug 22 15:46:16 2019 +0200
loplugin:constmethod in toolkit
Change-Id: Id80ee487d7083da5c1f1c4d012d6339700471204
Reviewed-on: https://gerrit.libreoffice.org/77952
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/toolkit/awt/vclxwindows.hxx
b/include/toolkit/awt/vclxwindows.hxx
index 202d5974c8f9..eba13e505a41 100644
--- a/include/toolkit/awt/vclxwindows.hxx
+++ b/include/toolkit/awt/vclxwindows.hxx
@@ -608,7 +608,7 @@ public:
/// @throws css::uno::RuntimeException
void setMinimum( sal_Int32 n );
/// @throws css::uno::RuntimeException
-sal_Int32 getMinimum( );
+sal_Int32 getMinimum( ) const;
// css::awt::VclWindowPeer
void SAL_CALL setProperty( const OUString& PropertyName, const
css::uno::Any& Value ) override;
@@ -889,7 +889,7 @@ public:
voidSetFormatter( FormatterBase* pFormatter ) { mpFormatter =
pFormatter; }
voidsetStrictFormat( bool bStrict );
-boolisStrictFormat();
+boolisStrictFormat() const;
// css::awt::VclWindowPeer
void SAL_CALL setProperty( const OUString& PropertyName, const
css::uno::Any& Value ) override;
diff --git a/toolkit/source/awt/vclxwindow.cxx
b/toolkit/source/awt/vclxwindow.cxx
index d632fc13036b..58afca500b80 100644
--- a/toolkit/source/awt/vclxwindow.cxx
+++ b/toolkit/source/awt/vclxwindow.cxx
@@ -156,11 +156,11 @@ public:
/** synchronously mbEnableVisible
*/
voidsetEnableVisible( bool bEnableVisible ) {
[Libreoffice-ux-advise] [Bug 122007] Support for multiple selection of list entries in data series selection
https://bugs.documentfoundation.org/show_bug.cgi?id=122007 Buovjaga changed: What|Removed |Added Resolution|--- |WORKSFORME Status|REOPENED|RESOLVED CC||todven...@suomi24.fi -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 122007] Support for multiple selection of list entries in data series selection
https://bugs.documentfoundation.org/show_bug.cgi?id=122007 Buovjaga changed: What|Removed |Added Resolution|--- |WORKSFORME Status|REOPENED|RESOLVED CC||todven...@suomi24.fi -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108538] [META] Chart feature enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108538 Bug 108538 depends on bug 122007, which changed state. Bug 122007 Summary: Support for multiple selection of list entries in data series selection https://bugs.documentfoundation.org/show_bug.cgi?id=122007 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125834] Extend context menu in a pivot table with mark actions
https://bugs.documentfoundation.org/show_bug.cgi?id=125834 Buovjaga changed: What|Removed |Added Resolution|--- |WORKSFORME Status|REOPENED|RESOLVED CC||todven...@suomi24.fi -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103381] [META] Pivot table (aka Data Pilot) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103381 Bug 103381 depends on bug 125834, which changed state. Bug 125834 Summary: Extend context menu in a pivot table with mark actions https://bugs.documentfoundation.org/show_bug.cgi?id=125834 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86349] [META] Context menu bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=86349 Bug 86349 depends on bug 125834, which changed state. Bug 125834 Summary: Extend context menu in a pivot table with mark actions https://bugs.documentfoundation.org/show_bug.cgi?id=125834 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103381] [META] Pivot table (aka Data Pilot) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103381 Bug 103381 depends on bug 125864, which changed state. Bug 125864 Summary: Safer application of options for each filter criterium in a pivot table https://bugs.documentfoundation.org/show_bug.cgi?id=125864 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125864] Safer application of options for each filter criterium in a pivot table
https://bugs.documentfoundation.org/show_bug.cgi?id=125864 Buovjaga changed: What|Removed |Added Status|REOPENED|RESOLVED Keywords|needsUXEval | CC||todven...@suomi24.fi Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127098] New: Functions to Track and View Changes should really become Useful
https://bugs.documentfoundation.org/show_bug.cgi?id=127098 Bug ID: 127098 Summary: Functions to Track and View Changes should really become Useful Product: LibreOffice Version: 6.4.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: adalbert.hans...@gmx.de This proposal refers to experiences with LibreOfficeWriter Development up to Version: 6.4.0.0.alpha0+ Build ID: 8387a6db641b29e6ff3c2f4cdc4688f538cbe35f CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk3; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-08-09_06:28:42 Locale: de-DE (de_DE.UTF-8); UI-Language: en-US Calc: threaded and earlier versions. The functions to track and view changes in a document are not really practical. Therefore they should be improved. Steps to reproduce 1. provide a document of a few pages length. 2. Switch on Edit>Track Changes>Record but do not switch on View>Track Changes at this point. 3. Apply a quite few changes in the document. 4. Apply some more changes to the document, but do this out of order from top to bottom of the document, just one change here, the other one there and so on. 5. Correct some typos in the document. 6. Add some format changes to it, e.g. adding tabs, deleting multiple white spaces. 7. Make some format changes. e.g. setting some words to italics, underlines or bold. 8. Mark some lines as headlines of different order. If you have the impression that you have touched in total 20-30% of the text somehow, this is a good example. 9. Now switch on View>Track Changes. If you have applied enough changes, the whole document looks to be completely changed and you have difficulties to keep an overview of what has happened to it. Therefore I propose to enhance the already existing functions of the track changes, namely View>Track Changes and Edit>Track Changes>Manage Changes, which already has a tab Filter. It gives access to select changes in its List tab. Only changes meeting certain criteria dealing with Author, Action or Comment defined in the Filter tab are shown in the List tab. Using the category Comment (which has nothing to do to add Comments to the text itself during the revision process) might be useful if there is a strict agreement among the revisors to categorize changes by type and assign e.g. letters to the different changes (e.g. O=optional, B=might be left out for brevity, S plus a number=superfluous, the number characterizing the duplicate where the topic is also dealt with). Using Comment requires very much discipline among the involved people however. The Action tab lets one choose between Insertion/Deletion/Format/Table Changes. Unfortunately, selection only has an influence on the list shown in the List tab of Edit>Track Changes>Manage Changes, not on the document window. That would really provide a great benefit! The Filter criteria should also influence the display of changes in the document window, this would be the right place to deselect all format changes in View>Track Changes. It does not make much sense to select either Insertions or Deletions. At least one should have a chance to select Insertions or Deletions. Often one wants to view the document with the text changes emphasized (by color). Selecting Insertions or Deletions would be the right thing then. However, corrections of typos (typically done by using the spell check functions or by typing over a marked part in a word and only changing a few characters, namely transposing a few of them or adding missing ones or deleting duplicatd ones - but not exchanging digits in a number! - would also be something which should be possible to select or deselect for View>Track Changes. I propose to categorize all this as “typos”. Of course, proceed to the previous or next correction or accept all corrections should only operate on those which are selected (presently it is that way, but they are only highlighted in Edit>Track Changes>Manage Changes List tab and one can click on them to get to the proper place in the document window). Of course currently you can proceed to the next or previous meeting the filter criterion and accept the current one or reject it or accept all or reject all selected changes. Expected result: 9. View>Track Changes should have two basic choices: simple Text changes (insertions or deletions) typos white spaces (insertions or deletions) format changes complex (see Edit>Track Changes>Manage Changes>Filter) If one checks simple, one should be able to select among the four subcategories (0 to 4 check marks). If one selects complex, one should be able to select like in the current Edit>Track Changes>Manage Changes>Filter tab, however with the addition of being able
[Libreoffice-ux-advise] [Bug 125864] Safer application of options for each filter criterium in a pivot table
https://bugs.documentfoundation.org/show_bug.cgi?id=125864 Buovjaga changed: What|Removed |Added Status|REOPENED|RESOLVED Keywords|needsUXEval | CC||todven...@suomi24.fi Resolution|--- |WORKSFORME -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: package/source
package/source/zippackage/ZipPackage.cxx |9 -
1 file changed, 4 insertions(+), 5 deletions(-)
New commits:
commit 0ec0ba24f0f28deef7993e430682bf4a5d9f3271
Author: Ashod Nakashian
AuthorDate: Mon Mar 25 10:29:38 2019 -0400
Commit: Ashod Nakashian
CommitDate: Thu Aug 22 15:33:15 2019 +0200
oox: typos, comments, formatting
Change-Id: I6bb138be2a8da91a85248e85d408f54a9b885f9b
Reviewed-on: https://gerrit.libreoffice.org/77686
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian
diff --git a/package/source/zippackage/ZipPackage.cxx
b/package/source/zippackage/ZipPackage.cxx
index f5d8ca351ba9..574b7a434f5c 100644
--- a/package/source/zippackage/ZipPackage.cxx
+++ b/package/source/zippackage/ZipPackage.cxx
@@ -713,9 +713,9 @@ void SAL_CALL ZipPackage::initialize( const uno::Sequence<
Any >& aArguments )
}
else if ( aNamedValue.Value >>= nFormatID )
{
-if ( nFormatID != embed::StorageFormats::PACKAGE
- && nFormatID != embed::StorageFormats::ZIP
- && nFormatID != embed::StorageFormats::OFOPXML )
+if (nFormatID != embed::StorageFormats::PACKAGE
+&& nFormatID != embed::StorageFormats::ZIP
+&& nFormatID != embed::StorageFormats::OFOPXML)
throw lang::IllegalArgumentException(THROW_WHERE,
uno::Reference< uno::XInterface >(), 1 );
m_nFormat = nFormatID;
@@ -1088,8 +1088,7 @@ void ZipPackage::WriteContentTypes( ZipOutputStream&
aZipOut, const vector< uno:
pEntry->nSize = pEntry->nCompressedSize = -1;
pEntry->nTime = ZipOutputStream::getCurrentDosTime();
-// Convert vector into a uno::Sequence
-// TODO/LATER: use Default entries in future
+// Add default entries, the count must be updated manually when appending.
uno::Sequence< beans::StringPair > aDefaultsSequence(4);
// Add at least the standard default entries.
aDefaultsSequence[0].First = "xml";
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 124365] FORMATTING Opening 2 separate "Cell Style Modify" windows disables input on all windows
https://bugs.documentfoundation.org/show_bug.cgi?id=124365 Buovjaga changed: What|Removed |Added Resolution|FIXED |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3-desktop' - filter/source
filter/source/xsltfilter/OleHandler.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 3bf20599bb3afe03086e602ccebabd77b8896f71
Author: Andras Timar
AuthorDate: Thu Aug 22 15:31:45 2019 +0200
Commit: Andras Timar
CommitDate: Thu Aug 22 15:31:45 2019 +0200
build fix
Change-Id: Ic0be0c6fd0d498b3f0512461480f166ad3f7b5f8
diff --git a/filter/source/xsltfilter/OleHandler.cxx
b/filter/source/xsltfilter/OleHandler.cxx
index 057b69ada620..807a8a04fed1 100644
--- a/filter/source/xsltfilter/OleHandler.cxx
+++ b/filter/source/xsltfilter/OleHandler.cxx
@@ -97,7 +97,7 @@ namespace XSLT
OString SAL_CALL
OleHandler::encodeSubStorage(const OUString& streamName)
{
-if (!m_storage || !m_storage->hasByName(streamName))
+if (!m_storage.is() || !m_storage->hasByName(streamName))
{
return "Not Found:";// + streamName;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
