[Libreoffice-bugs] [Bug 107805] [META] Writer master document issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107805 Dieter Praas changed: What|Removed |Added Depends on||127629 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=127629 [Bug 127629] UI: Question to open links when opening a master document in English but different UI language -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127629] UI: Question to open links when opening a master document in English but different UI language
https://bugs.documentfoundation.org/show_bug.cgi?id=127629 Dieter Praas changed: What|Removed |Added CC||dgp-m...@gmx.de Keywords||bibisectRequest, ||possibleRegression Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Blocks||107805 --- Comment #1 from Dieter Praas --- I confirm it with Version: 6.4.0.0.alpha0+ (x64) Build-ID: f0c832acb53326ccc9a8c1a47401fbc9e1081feb CPU-Threads: 4; BS: Windows 10.0; UI-Render: GL; VCL: win; TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2019-09-11_05:46:53 Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: threaded but not with Version: 6.3.2.2 (x64) Build-ID: 98b30e735bda24bc04ab42594c85f7fd8be07b9c CPU-Threads: 4; BS: Windows 10.0; UI-Render: GL; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107805 [Bug 107805] [META] Writer master document issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125257] [META] Tip of the day
https://bugs.documentfoundation.org/show_bug.cgi?id=125257 Bug 125257 depends on bug 127400, which changed state. Bug 127400 Summary: Allow to show tip of the day again https://bugs.documentfoundation.org/show_bug.cgi?id=127400 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: basctl/uiconfig chart2/uiconfig cui/inc cui/source dbaccess/uiconfig extensions/uiconfig framework/uiconfig include/sfx2 officecfg/registry reportdesign/uiconfig sc/uic
basctl/uiconfig/basicide/menubar/menubar.xml |1
chart2/uiconfig/menubar/menubar.xml |1
cui/inc/tipoftheday.hrc |1
cui/source/dialogs/tipofthedaydlg.cxx| 31
+-
cui/source/inc/tipofthedaydlg.hxx|6 -
dbaccess/uiconfig/dbapp/menubar/menubar.xml |1
dbaccess/uiconfig/dbquery/menubar/menubar.xml|1
dbaccess/uiconfig/dbrelation/menubar/menubar.xml |1
dbaccess/uiconfig/dbtable/menubar/menubar.xml|1
dbaccess/uiconfig/dbtdata/menubar/menubar.xml|1
extensions/uiconfig/sbibliography/menubar/menubar.xml|1
framework/uiconfig/startmodule/menubar/menubar.xml |1
include/sfx2/sfxsids.hrc |2
officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu | 14
officecfg/registry/schema/org/openoffice/Office/Common.xcs |6 +
reportdesign/uiconfig/dbreport/menubar/menubar.xml |1
sc/uiconfig/scalc/menubar/menubar.xml|1
sd/uiconfig/sdraw/menubar/menubar.xml|1
sd/uiconfig/simpress/menubar/menubar.xml |1
sfx2/sdi/appslots.sdi|4 +
sfx2/sdi/sfx.sdi | 17
+
sfx2/source/appl/appserv.cxx |9 ++
sfx2/source/view/viewfrm.cxx | 10 ---
starmath/uiconfig/smath/menubar/menubar.xml |1
sw/uiconfig/sglobal/menubar/menubar.xml |1
sw/uiconfig/sweb/menubar/menubar.xml |1
sw/uiconfig/swform/menubar/menubar.xml |1
sw/uiconfig/swreport/menubar/menubar.xml |1
sw/uiconfig/swriter/menubar/menubar.xml |1
sw/uiconfig/swxform/menubar/menubar.xml |1
30 files changed, 95 insertions(+), 25 deletions(-)
New commits:
commit 97bcd0e416b1fb725b5aaade811e80d46fdaf1e2
Author: Heiko Tietze
AuthorDate: Fri Sep 6 10:34:54 2019 +0200
Commit: Heiko Tietze
CommitDate: Mon Sep 23 07:51:01 2019 +0200
Resolves tdf#127400 - Allow to show tip of the day again
* UNO command TipOfTheDay and slot SID_TIPOFTHEDAY
introduced and added to help menus
* Tip ID introduced to keep the current tip over the day
* Tip ID updates after 24h
* Randomization of tips replaced by sequential order
* Tip ID added to the dialog title
Change-Id: I69b72b80d6d6afa25a1c4f01fa05bc60b5741db8
Reviewed-on: https://gerrit.libreoffice.org/78693
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/basctl/uiconfig/basicide/menubar/menubar.xml
b/basctl/uiconfig/basicide/menubar/menubar.xml
index 290bb6a7de36..ac59065c9daf 100644
--- a/basctl/uiconfig/basicide/menubar/menubar.xml
+++ b/basctl/uiconfig/basicide/menubar/menubar.xml
@@ -159,6 +159,7 @@
+
diff --git a/chart2/uiconfig/menubar/menubar.xml
b/chart2/uiconfig/menubar/menubar.xml
index d3dbf57b54a5..354ebbc1903a 100644
--- a/chart2/uiconfig/menubar/menubar.xml
+++ b/chart2/uiconfig/menubar/menubar.xml
@@ -160,6 +160,7 @@
+
diff --git a/cui/inc/tipoftheday.hrc b/cui/inc/tipoftheday.hrc
index 16f79af26497..8977f718f945 100644
--- a/cui/inc/tipoftheday.hrc
+++ b/cui/inc/tipoftheday.hrc
@@ -263,6 +263,7 @@ const std::tuple
TIPOFTHEDAY_STRINGARRAY[] =
#define STR_HELP_LINK NC_("STR_HELP_LINK", "%PRODUCTNAME
Help")
#define STR_MORE_LINK NC_("STR_MORE_LINK", "More info")
+#define STR_TITLE NC_("STR_TITLE", "Tip of the Day")
#endif //INCLUDED_CUI_INC_TIPOFTHEDAY_HRC
diff --git a/cui/source/dialogs/tipofthedaydlg.cxx
b/cui/source/dialogs/tipofthedaydlg.cxx
index 2ee5518c5274..55e9b51b9003 100644
--- a/cui/source/dialogs/tipofthedaydlg.cxx
+++ b/cui/source/dialogs/tipofthedaydlg.cxx
@@ -28,7 +28,6 @@
#include
#include
#include
-#include
TipOfTheDayDialog::TipOfTheDayDialog(weld::Window* pParent)
: GenericDialogController(pParent, "cui/ui/tipofthedaydialog.ui",
"TipOfTheDayDialog")
@@ -38,11 +37,17 @@ TipOfTheDayDialog::TipOfTheDayDialog(weld::Window* pParent)
, m_pNext(m_xBuilder->weld_button("btnNext"))
, m_pLink(m_xBuilder->weld_link_button("btnLink"))
{
-m_pShowTip->connect_toggled(LINK(this,
[Libreoffice-bugs] [Bug 127688] Dotted chapter numbering crashes Writer under Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=127688 --- Comment #4 from Wolfgang Glas --- My previous comment was wrong, you have to change chapter numbering from '1,2,...' to '1.,2.,...' in order to provoke the CPU loop. Sorry for any inconvenience, Wolfgang -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 127324] Search-Function: Make comments searchable by default, if shown.
https://bugs.documentfoundation.org/show_bug.cgi?id=127324 --- Comment #6 from Dieter Praas --- (In reply to Thomas Lendo from comment #5) > I see a problem in moving the cursor to a hidden comment without any > feedback. This should be enhanced. Maybe a text at the position of 'Reached > the end of the document' with the alert 'Search result in a hidden comment' > or something similar. Is it technically possible to see if a search result > is in a hidden comment? I agree. But I also would expect, that searching within commments is activ, if comments are displayed. > I don't like an automatism in the search dialog to include or not include > the comments in a search action. But we have this automatism actaually: Comments are not included. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 127688] Dotted chapter numbering crashes Writer under Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=127688 --- Comment #3 from Wolfgang Glas --- Created attachment 154376 --> https://bugs.documentfoundation.org/attachment.cgi?id=154376=edit File with plain chapter numbering to demonstrate CPU loop When changing the chapter numbering in the attached document from '1.,2.,...' to '1,2,...', LibO under debian Linux goes into a 100% CPU loop and the soffice.bin process can only be killed with 'kill -9'. Maybe this effect is easier to trace then the initially reported crash. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127324] Search-Function: Make comments searchable by default, if shown.
https://bugs.documentfoundation.org/show_bug.cgi?id=127324 --- Comment #6 from Dieter Praas --- (In reply to Thomas Lendo from comment #5) > I see a problem in moving the cursor to a hidden comment without any > feedback. This should be enhanced. Maybe a text at the position of 'Reached > the end of the document' with the alert 'Search result in a hidden comment' > or something similar. Is it technically possible to see if a search result > is in a hidden comment? I agree. But I also would expect, that searching within commments is activ, if comments are displayed. > I don't like an automatism in the search dialog to include or not include > the comments in a search action. But we have this automatism actaually: Comments are not included. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127080] Improve handling of user-defined colors
https://bugs.documentfoundation.org/show_bug.cgi?id=127080 --- Comment #8 from Heiko Tietze --- User-defined colors are stored in an extra palette, just select the Custom palette. There you can single click on entries and get the respective RGB/Hex values right hand. If you expect the picker itself (the floating widget that shows up on click at the sidebar) to behave like this I disagree. Its purpose is to select quickly a color and not to manage it. The idea of RGB values in the tooltip makes sense and has been file in bug 84579 (maybe other as well). Here is the blog post when we started with the work https://design.blog.documentfoundation.org/2015/12/22/area-fill-options-made-consistent/ (In reply to Ulrich Windl from comment #5) > Created attachment 154124 [details] > Color selector offered in Tools->Options This is a left-over from the not yet finished work. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 127080] Improve handling of user-defined colors
https://bugs.documentfoundation.org/show_bug.cgi?id=127080 --- Comment #8 from Heiko Tietze --- User-defined colors are stored in an extra palette, just select the Custom palette. There you can single click on entries and get the respective RGB/Hex values right hand. If you expect the picker itself (the floating widget that shows up on click at the sidebar) to behave like this I disagree. Its purpose is to select quickly a color and not to manage it. The idea of RGB values in the tooltip makes sense and has been file in bug 84579 (maybe other as well). Here is the blog post when we started with the work https://design.blog.documentfoundation.org/2015/12/22/area-fill-options-made-consistent/ (In reply to Ulrich Windl from comment #5) > Created attachment 154124 [details] > Color selector offered in Tools->Options This is a left-over from the not yet finished work. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 127706] New: Clearing direct formatting breaks undo
https://bugs.documentfoundation.org/show_bug.cgi?id=127706 Bug ID: 127706 Summary: Clearing direct formatting breaks undo Product: LibreOffice Version: 3.5.0 release Hardware: All OS: All Status: UNCONFIRMED Keywords: regression Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikekagan...@hotmail.com 1. In a new text document, add a lorem ipsum text. 2. Select all (Ctrl+A), and set font size to 18. 3. Select a single word (e.g., double-click it), and apply italic direct formatting (Ctrl+I). 4. Select another word in the same paragraph (double-click it) and clear direct formatting (Ctrl+M). 5. Undo (Ctrl+Z), undo again (Ctrl+Z). Expected: all text has font size 18, not italic (since the effects of both Ctrl+M and Ctrl+I were undone, but not setting font size 18). Actual: the word that was made italic at step 3 has now font size 12. Undoing once after step 4 gives expected result, so it is likely step 5 that breaks the undo. Reproducible with current master (toward 6.4), and with LibreOffice 3.5.0rc3 Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735. Not reproducible with LibreOffice 3.5.0rc3 Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127174] Search dialog doesn't support "whole word only" option
https://bugs.documentfoundation.org/show_bug.cgi?id=127174 --- Comment #14 from Heiko Tietze --- (In reply to Thomas Lendo from comment #11) > ...an algorithm should be > introduced that breaks the checkboxes into a second line in a logical and > visually good way. Objection. Multi-line check-/radio buttons are common on macOS but violate HIG on Windows and (all/most/some?) Linux WMs. The only solution is to make functions simple and easy to understand with a few words. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/undo/unattr.cxx |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
New commits:
commit c8e2675ebde04ab814fe0bc8f800a502280f4689
Author: Mike Kaganski
AuthorDate: Sun Sep 22 21:48:02 2019 +0200
Commit: Mike Kaganski
CommitDate: Mon Sep 23 04:55:20 2019 +0200
Simplify SwUndoResetAttr::SetAttrs using operator=
Change-Id: Icb958e4800219ddb4fb8e90d082595e6b14b8ac2
Reviewed-on: https://gerrit.libreoffice.org/79358
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sw/source/core/undo/unattr.cxx b/sw/source/core/undo/unattr.cxx
index 5b93949d2bc5..b880309dfb24 100644
--- a/sw/source/core/undo/unattr.cxx
+++ b/sw/source/core/undo/unattr.cxx
@@ -648,8 +648,7 @@ void SwUndoResetAttr::RepeatImpl(::sw::RepeatContext &
rContext)
void SwUndoResetAttr::SetAttrs( const std::set )
{
-m_Ids.clear();
-m_Ids.insert( rAttrs.begin(), rAttrs.end() );
+m_Ids = rAttrs;
}
SwUndoAttr::SwUndoAttr( const SwPaM& rRange, const SfxPoolItem& rAttr,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 127681] Installation of LibreOffice 6.3.1 fails when changing installation path
https://bugs.documentfoundation.org/show_bug.cgi?id=127681 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127416] [FORMATTING] Can't use Icon set in Conditional Formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=127416 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127433] Use transparent "frame" for Windows preview thumbnail icons
https://bugs.documentfoundation.org/show_bug.cgi?id=127433 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127681] Installation of LibreOffice 6.3.1 fails when changing installation path
https://bugs.documentfoundation.org/show_bug.cgi?id=127681 --- Comment #10 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112213] Documents based on templates which have ODF property "Open file read-only" are not editable
https://bugs.documentfoundation.org/show_bug.cgi?id=112213 --- Comment #6 from QA Administrators --- Dear Harald Koester, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114043] Small delay when (re)opening a file
https://bugs.documentfoundation.org/show_bug.cgi?id=114043 --- Comment #6 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114462] Slow scrolling and high CPU utilization in the expert configuration with specific content (for example histories)
https://bugs.documentfoundation.org/show_bug.cgi?id=114462 --- Comment #5 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120024] Writer table - letters get cut off on bottom row of page
https://bugs.documentfoundation.org/show_bug.cgi?id=120024 --- Comment #6 from QA Administrators --- Dear Andrew, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83720] PIVOTTABLE: Wrong date format in column field
https://bugs.documentfoundation.org/show_bug.cgi?id=83720 --- Comment #14 from QA Administrators --- Dear Jens S, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69094] HTML documentation: link to inherited member should go to inherited interface
https://bugs.documentfoundation.org/show_bug.cgi?id=69094 --- Comment #5 from QA Administrators --- Dear Lionel Elie Mamane, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106622] PIVOT TABLE: wrong selected fields of Page Fields after updating table
https://bugs.documentfoundation.org/show_bug.cgi?id=106622 --- Comment #8 from QA Administrators --- Dear f.rr, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69972] FILESAVE: Undo opens "Save document", although there are no changes to save
https://bugs.documentfoundation.org/show_bug.cgi?id=69972 --- Comment #12 from QA Administrators --- Dear Thomas Hackert, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104627] FILEOPEN: very slow-loading of .docx file
https://bugs.documentfoundation.org/show_bug.cgi?id=104627 --- Comment #9 from QA Administrators --- Dear Buovjaga, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127295] Unable to snapshot an Impress full page diaporama
https://bugs.documentfoundation.org/show_bug.cgi?id=127295 --- Comment #4 from Claude Charest --- Comment on attachment 154375 --> https://bugs.documentfoundation.org/attachment.cgi?id=154375 Copy-Paste of a full screen slide whitout snipping tool Today I tried something different: do not use the snippig windows tools, use only copy-paste - Open my "2019 11 Punta Cana.odp" file (Impress) - Push the F5 button to get a full screen view of page 1 - Hit the "Control-Print Screen" windows button --> At this point I still got an full screen view of page 1 - Open Gimp 1.10.12 - Hit "Control-V" (paste) and I got this file (Capture.jpg) ! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127295] Unable to snapshot an Impress full page diaporama
https://bugs.documentfoundation.org/show_bug.cgi?id=127295 --- Comment #3 from Claude Charest --- Created attachment 154375 --> https://bugs.documentfoundation.org/attachment.cgi?id=154375=edit Copy-Paste of a full screen slide whitout snipping tool -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79845] Mac OS X mdimporter for .odt files with tabulations doesn't import all text
https://bugs.documentfoundation.org/show_bug.cgi?id=79845 --- Comment #10 from Dave Huang --- (In reply to QA Administrators from comment #9) > There have been thousands of bug fixes and commits since anyone checked on > this bug report. During that time, it's possible that the bug has been > fixed, or the details of the problem have changed. We'd really appreciate > your help in getting confirmation that the bug is still present. But it looks like only two commits that affect the mdimporter, neither of which claim to fix this problem... Perhaps someone could try out my proposed patch? Or if someone could just build it for me, I can try it myself. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127705] Layout disorder after copy/pasted into a new Writer file
https://bugs.documentfoundation.org/show_bug.cgi?id=127705 --- Comment #2 from zexcel --- Created attachment 154374 --> https://bugs.documentfoundation.org/attachment.cgi?id=154374=edit The screenshots show the layout change -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127705] Layout disorder after copy/pasted into a new Writer file
https://bugs.documentfoundation.org/show_bug.cgi?id=127705 --- Comment #1 from zexcel --- Created attachment 154373 --> https://bugs.documentfoundation.org/attachment.cgi?id=154373=edit test bed for copy/paste to a new Writer file LO need a normalization function somewhere to drop all uncopiable factors, no matter where they come from historically. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127705] New: Layout disorder after copy/pasted into a new Writer file
https://bugs.documentfoundation.org/show_bug.cgi?id=127705 Bug ID: 127705 Summary: Layout disorder after copy/pasted into a new Writer file Product: LibreOffice Version: 6.3.1.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: aist0...@gmail.com Description: It is well known that the layout of a file looks different between LO and MS office. However, it also changes even when copy/pasted on the same machine, unexpected, as shown in attachments. Steps to Reproduce: 1.copy: Ctrl+a -> Ctrl+c 2.paste to a new file: Ctrl+n -> Ctrl+v Actual Results: The pasted part looks different from its original. Expected Results: The pasted part should be the same as its original. Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: ja Module: TextDocument [Information guessed from browser] OS: Linux (All) OS is 64bit: yes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - sfx2/source xmlsecurity/CppunitTest_xmlsecurity_signing.mk xmlsecurity/qa
sfx2/source/doc/objstor.cxx | 30 +-
xmlsecurity/CppunitTest_xmlsecurity_signing.mk |4
xmlsecurity/qa/unit/signing/data/tdf42316.ott |binary
xmlsecurity/qa/unit/signing/data/tdf42316_odt12.ott |binary
xmlsecurity/qa/unit/signing/signing.cxx | 246 +++-
5 files changed, 271 insertions(+), 9 deletions(-)
New commits:
commit c21f9769b96e1dddfe0b1005bca4c4a55f508860
Author: Jan-Marek Glogowski
AuthorDate: Fri Jul 19 15:28:45 2019 +0200
Commit: Thorsten Behrens
CommitDate: Mon Sep 23 02:43:19 2019 +0200
tdf#42316 preserve macro signature of templates
When comparing the filter of the current and the target document
we have to strip the '_template' from the filter name.
Still this won't preserve the signature of the document attached
to tdf#42316, as this is a ODF 1.0 OTT, which doesn't have a
valid signature in ODF 1.2, as the signature doesn't match the ODF
1.2 namespace for signatures and the default LO ODF version is ODF
1.2 extended.
In theory the signature itself could even be converted most times,
but that can be done in an additional patch, if needed.
Since the code literally saves a template to an internal document,
SfxObjectShell::DoSaveCompleted must keep the signature of the
template. Eventually it'll be dropped on save of the template as
a document later.
The signing tests check "OTT 1.0 => ODT 1.0: preserve", "OTT 1.2
=> ODT 1.2: preserve" and "OTT 1.0 => ODT 1.2: drop".
Reviewed-on: https://gerrit.libreoffice.org/75958
Tested-by: Jenkins
Reviewed-by: Michael Stahl
Reviewed-by: Thorsten Behrens
(cherry picked from commit c3a1c83ff5af05d34f433ac808adbe85f47e8c18)
Reviewed-on: https://gerrit.libreoffice.org/77112
Conflicts:
xmlsecurity/qa/unit/signing/signing.cxx
Change-Id: I2263093687f5a0568ea781ce3ac9b114c9599add
Reviewed-on: https://gerrit.libreoffice.org/79371
Reviewed-by: Thorsten Behrens
Tested-by: Thorsten Behrens
diff --git a/sfx2/source/doc/objstor.cxx b/sfx2/source/doc/objstor.cxx
index 716455cda9ae..fa08ceb42a4a 100644
--- a/sfx2/source/doc/objstor.cxx
+++ b/sfx2/source/doc/objstor.cxx
@@ -1160,10 +1160,18 @@ bool SfxObjectShell::SaveTo_Impl
{}
// preserve only if the same filter has been used
-bTryToPreserveScriptSignature = pMedium->GetFilter() && pFilter &&
pMedium->GetFilter()->GetFilterName() == pFilter->GetFilterName();
-
+// for templates, strip the _template from the filter name for
comparison
+OUString aMediumFilter = pMedium->GetFilter()->GetFilterName();
+if (aMediumFilter.endsWith("_template"))
+aMediumFilter = aMediumFilter.copy(0,
aMediumFilter.getLength() - 9);
+bTryToPreserveScriptSignature = pMedium->GetFilter() && pFilter &&
aMediumFilter == pFilter->GetFilterName();
+
+// signatures were specified in ODF 1.2 but were used since much
longer.
+// LO will still correctly validate an old style signature on an
ODF 1.2
+// document, but technically this is not correct, so this prevents
old
+// signatures to be copied over to a version 1.2 document
bNoPreserveForOasis = (
- (aODFVersion == ODFVER_012_TEXT && nVersion
== SvtSaveOptions::ODFVER_011) ||
+ (aODFVersion == ODFVER_012_TEXT && nVersion
< SvtSaveOptions::ODFVER_012) ||
(aODFVersion.isEmpty() && nVersion >=
SvtSaveOptions::ODFVER_012)
);
}
@@ -2026,13 +2034,21 @@ bool SfxObjectShell::DoSaveCompleted( SfxMedium*
pNewMed, bool bRegisterRecent )
{}
}
+const SfxBoolItem* pTemplateItem =
SfxItemSet::GetItem(pMedium->GetItemSet(), SID_TEMPLATE, false);
+bool bTemplate = pTemplateItem && pTemplateItem->GetValue();
+
// before the title regenerated the document must lose the
signatures
pImpl->nDocumentSignatureState = SignatureState::NOSIGNATURES;
-pImpl->nScriptingSignatureState =
pNewMed->GetCachedSignatureState_Impl();
-OSL_ENSURE( pImpl->nScriptingSignatureState !=
SignatureState::BROKEN, "The signature must not be broken at this place" );
+if (!bTemplate)
+{
+pImpl->nScriptingSignatureState =
pNewMed->GetCachedSignatureState_Impl();
+OSL_ENSURE( pImpl->nScriptingSignatureState !=
SignatureState::BROKEN, "The signature must not be broken at this place" );
-// TODO/LATER: in future the medium must control own signature
state, not the document
-pNewMed->SetCachedSignatureState_Impl(
SignatureState::NOSIGNATURES ); // set the default value back
+//
[Libreoffice-bugs] [Bug 127704] Gallery add Theme and views on bottom
https://bugs.documentfoundation.org/show_bug.cgi?id=127704 andreas_k changed: What|Removed |Added Keywords||needsUXEval CC||kain...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127704] New: Gallery add Theme and views on bottom
https://bugs.documentfoundation.org/show_bug.cgi?id=127704 Bug ID: 127704 Summary: Gallery add Theme and views on bottom Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kain...@gmail.com Created attachment 154372 --> https://bugs.documentfoundation.org/attachment.cgi?id=154372=edit Gallery Sidebar The idea is to arrange all the "settings" stuff on bottom. I will also recommend to have an link to the extension webpage or at least to the extension dialog where you have the link to the extension page. however styles, navigator has settings on bottom. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svgio/source
svgio/source/svgreader/svgusenode.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 30c5aead03b10b4dc0497c1d799dbfb903ee140b Author: Xisco Fauli AuthorDate: Sun Sep 22 21:46:17 2019 +0200 Commit: Xisco Faulí CommitDate: Sun Sep 22 23:41:29 2019 +0200 SVGIO: Use correct type for elements Since it was rebased in 44cfc7cb6533d827fd2d6e586d92c61d7d7f7a70 Change-Id: I2845367a9017b24f4623138d5501384e5ed81d7d Reviewed-on: https://gerrit.libreoffice.org/79359 Tested-by: Jenkins Reviewed-by: Xisco Faulí diff --git a/svgio/source/svgreader/svgusenode.cxx b/svgio/source/svgreader/svgusenode.cxx index a54c9fb46c3e..74b38a3e9b89 100644 --- a/svgio/source/svgreader/svgusenode.cxx +++ b/svgio/source/svgreader/svgusenode.cxx @@ -28,7 +28,7 @@ namespace svgio SvgUseNode::SvgUseNode( SvgDocument& rDocument, SvgNode* pParent) -: SvgNode(SVGTokenG, rDocument, pParent), +: SvgNode(SVGTokenUse, rDocument, pParent), maSvgStyleAttributes(*this), maX(), maY(), ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 127703] Striketrough has no shortcut and impossible to turn off for multiple cells
https://bugs.documentfoundation.org/show_bug.cgi?id=127703 appelvla...@gmail.com changed: What|Removed |Added Version|unspecified |6.0.7.3 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127703] New: Striketrough has no shortcut and impossible to turn off for multiple cells
https://bugs.documentfoundation.org/show_bug.cgi?id=127703 Bug ID: 127703 Summary: Striketrough has no shortcut and impossible to turn off for multiple cells Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: appelvla...@gmail.com Striketrough has no shortcut which makes it cumbersome to work with. When more cells are selected and you want to turn off the function striketrough it doesn't work for multiple empty cells. It only works for one single cell. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127174] Search dialog doesn't support "whole word only" option
https://bugs.documentfoundation.org/show_bug.cgi?id=127174 --- Comment #13 from Thomas Lendo --- (In reply to Eyal Rozenberg from comment #12) > (In reply to Thomas Lendo from comment #11) > > When implementing this feature, an algorithm should be > > introduced that breaks the checkboxes into a second line in a logical and > > visually good way. > Is there a separate bug page for that? Haven't found any yet. https://bugs.documentfoundation.org/showdependencytree.cgi?id=113136_resolved=0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127080] Improve handling of user-defined colors
https://bugs.documentfoundation.org/show_bug.cgi?id=127080 --- Comment #7 from Cor Nouws --- (In reply to Thomas Lendo from comment #6) > > Solutions: > > A single click in the palette dialog selects the color without closing the > > dialog, while a double-click will select and close. > Your suggestion seems to be a behavior that users are not familiar with. In > other programs it behaves as LibreOffice does now. Yes, I see the same problem, Ulrich. I think the current little inconvenience is better then changing the behavior. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112876] Make use of scroll lock for navigation configurable (it conflicts with system use as keyboard layout indicator)
https://bugs.documentfoundation.org/show_bug.cgi?id=112876 Serhiy changed: What|Removed |Added Version|5.3.0.3 release |6.3.1.2 release OS|Linux (All) |All --- Comment #26 from Serhiy --- Please, make this option configurable, because as for now after so many years i can't use LibreOffice :( I have HP ZBook laptop and on Windows 10 I can not turn on ScrollLock. After research I managed to turn on ScrollLock using onscreen keyboard, and now I can move cell selection by arrow keys only up and down, but left and right arrows move a sheet itself, instead of cell selection. That's very pity and make the navigation to be very hard, I can't work in LO like this, sorry. LO 6.3.1.2 (64 bit), Windows 10 Pro, HP ZBook 15. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 127080] Improve handling of user-defined colors
https://bugs.documentfoundation.org/show_bug.cgi?id=127080 --- Comment #7 from Cor Nouws --- (In reply to Thomas Lendo from comment #6) > > Solutions: > > A single click in the palette dialog selects the color without closing the > > dialog, while a double-click will select and close. > Your suggestion seems to be a behavior that users are not familiar with. In > other programs it behaves as LibreOffice does now. Yes, I see the same problem, Ulrich. I think the current little inconvenience is better then changing the behavior. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
Re: Relevance of PPT export filter
Hi Ilmari, you wrote: > In concrete terms, should we declare bug bankruptcy on PPT export > issues and move any new reports to WONTFIX from now on? > Hmm. So from a user/product POV, there's probably still legitimate use cases for that filter (from edge cases, where a presentation still imports better on the other side using PPT, to backend servers converting to PPT inside bespoke filter chains). Is there a middle ground, which still lowers QA burden? Like default-low priority, or exclusion from certain queries or metrics? Cheers, -- Thorsten signature.asc Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Relevance of PPT export filter
Hi, On Sun, Sep 22, 2019 at 3:24 PM Ilmari Lauhakangas < ilmari.lauhakan...@libreoffice.org> wrote: > In https://bugs.documentfoundation.org/show_bug.cgi?id=89853#c18 Regina > has a good point: > > "do we really want to work on _export_ filters for an old binary file > format? We have already dropped export to the binary StarDivision > formats (.sdd) and to the XML-formats of OpenOffice.org1.0 (.sxi)." > > AFAIK the reason StarDivision binary formats were dropped because the implementation was tightly coupled with the core and was a maintenance burden. The idea was to re-implement the filters properly if it will be necessary (it wasn't). The OpenOffice.org1.0 export was dropped because ODF filter is actually as good or better. So for PPT I'm actually not convinced that OOXML PPTX filter is in such a good state that we can declare it unsupported (for export). I really don't want to see that people that previously used PPT then saved as PPTX and would had some regressions because something in OOXML isn't as good or different as in PPT filter. Continuing working on PPT export is another thing however, I wouldn't bother too much about the PPT export but I would make sure the same functionality in OOXML works correctly. We need to come up with a strategy how to convince people to convert from old binmary MS formats to OOXML or ODF. In concrete terms, should we declare bug bankruptcy on PPT export issues > and move any new reports to WONTFIX from now on? > No. I would reclassify them in some way that a check (in form of a roundtrip test) in OOXML filter for the same bug is necessary. > Ilmari Tomaž ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 127634] Context menu does not show spelling corrections if cell set wrap text
https://bugs.documentfoundation.org/show_bug.cgi?id=127634 Thomas Lendo changed: What|Removed |Added CC||thomas.le...@gmail.com --- Comment #2 from Thomas Lendo --- I can't reproduce that. Spelling corrections are also offered in cells with wrapped content. Version: 6.4.0.0.alpha0+ Build ID: c2c0bcfc64c5fc0b8299e3143ced482d481d2df0 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-09-18_02:53:35 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127702] New: Support setting quantitative font features relatively to underlying paragraph style
https://bugs.documentfoundation.org/show_bug.cgi?id=127702 Bug ID: 127702 Summary: Support setting quantitative font features relatively to underlying paragraph style Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyal...@technion.ac.il I often want to define a character style with features which relative to the paragraph style by some ratio. For example: A 125% font size; or 2x the inter-character space. Now, I can achieve this with setting the font size or the space in points - but then I need to define a separate character style for each paragraph style, which is annoying and difficult to maintain. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127341] FORMATTING: Right-click on a cell with hyperlink should show 'Format Cells...' command
https://bugs.documentfoundation.org/show_bug.cgi?id=127341 Thomas Lendo changed: What|Removed |Added Blocks||86349 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=86349 [Bug 86349] [META] Context menu bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86349] [META] Context menu bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=86349 Thomas Lendo changed: What|Removed |Added Depends on||127341 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=127341 [Bug 127341] FORMATTING: Right-click on a cell with hyperlink should show 'Format Cells...' command -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 127324] Search-Function: Make comments searchable by default, if shown.
https://bugs.documentfoundation.org/show_bug.cgi?id=127324 --- Comment #5 from Thomas Lendo --- I see a problem in moving the cursor to a hidden comment without any feedback. This should be enhanced. Maybe a text at the position of 'Reached the end of the document' with the alert 'Search result in a hidden comment' or something similar. Is it technically possible to see if a search result is in a hidden comment? I don't like an automatism in the search dialog to include or not include the comments in a search action. What if a user wants the opposite? After reopening the dialog, the setting is reset -- or when should it be reset after a user change? Never? After program restart? Seems also confusing. BTW I don't like the navigation commands in the search bar because they make the toolbar so long that the search help text isn't visible if the window isn't fullscreen. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 127324] Search-Function: Make comments searchable by default, if shown.
https://bugs.documentfoundation.org/show_bug.cgi?id=127324 --- Comment #5 from Thomas Lendo --- I see a problem in moving the cursor to a hidden comment without any feedback. This should be enhanced. Maybe a text at the position of 'Reached the end of the document' with the alert 'Search result in a hidden comment' or something similar. Is it technically possible to see if a search result is in a hidden comment? I don't like an automatism in the search dialog to include or not include the comments in a search action. What if a user wants the opposite? After reopening the dialog, the setting is reset -- or when should it be reset after a user change? Never? After program restart? Seems also confusing. BTW I don't like the navigation commands in the search bar because they make the toolbar so long that the search help text isn't visible if the window isn't fullscreen. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127174] Search dialog doesn't support "whole word only" option
https://bugs.documentfoundation.org/show_bug.cgi?id=127174 --- Comment #12 from Eyal Rozenberg --- (In reply to Thomas Lendo from comment #11) > When implementing this feature, an algorithm should be > introduced that breaks the checkboxes into a second line in a logical and > visually good way. Is there a separate bug page for that? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127174] Search dialog doesn't support "whole word only" option
https://bugs.documentfoundation.org/show_bug.cgi?id=127174 --- Comment #11 from Thomas Lendo --- (In reply to Eyal Rozenberg from comment #10) > ... and isn't that already a problem with the existing checkboxes? Yes. Now the dialog is for example much wider in German than in English what looks not good. When implementing this feature, an algorithm should be introduced that breaks the checkboxes into a second line in a logical and visually good way. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/doc/docfmt.cxx | 18 --
1 file changed, 4 insertions(+), 14 deletions(-)
New commits:
commit 438d7ee30809478d9bc790fedbf90b4b76cfeab8
Author: Mike Kaganski
AuthorDate: Sun Sep 22 21:30:16 2019 +0200
Commit: Mike Kaganski
CommitDate: Sun Sep 22 22:13:36 2019 +0200
Simplify item set creation
Change-Id: I9ed4e3e2dcd36851f6f5263b55dc40324d31243a
Reviewed-on: https://gerrit.libreoffice.org/79357
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sw/source/core/doc/docfmt.cxx b/sw/source/core/doc/docfmt.cxx
index be514788ec6a..12d1cad9563e 100644
--- a/sw/source/core/doc/docfmt.cxx
+++ b/sw/source/core/doc/docfmt.cxx
@@ -333,20 +333,10 @@ void SwDoc::ResetAttrs( const SwPaM ,
pStt, pEnd, pHst, nullptr, pLayout);
// mst: not including META here; it seems attrs with CH_TXTATR are omitted
-sal_uInt16 const aResetableSetRange[] {
-RES_FRMATR_BEGIN, RES_FRMATR_END-1,
-RES_CHRATR_BEGIN, RES_CHRATR_END-1,
-RES_PARATR_BEGIN, RES_PARATR_END-1,
-RES_PARATR_LIST_BEGIN, RES_PARATR_LIST_END-1,
-RES_TXTATR_INETFMT, RES_TXTATR_INETFMT,
-RES_TXTATR_CHARFMT, RES_TXTATR_CHARFMT,
-RES_TXTATR_CJK_RUBY, RES_TXTATR_CJK_RUBY,
-RES_TXTATR_UNKNOWN_CONTAINER, RES_TXTATR_UNKNOWN_CONTAINER,
-RES_UNKNOWNATR_BEGIN, RES_UNKNOWNATR_END-1,
-0
-};
-
-SfxItemSet aDelSet( GetAttrPool(), aResetableSetRange );
+SfxItemSet aDelSet(GetAttrPool(), svl::Items{});
if( !rAttrs.empty() )
{
for( std::set::const_reverse_iterator it =
rAttrs.rbegin(); it != rAttrs.rend(); ++it )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 73843] FORMATTING: Wrong placement of images with captions in master document
https://bugs.documentfoundation.org/show_bug.cgi?id=73843 --- Comment #10 from Thomas Lendo --- Same as in comment 8. Master document and subdocument both looks wrong. So it's no master document bug anymore but an image problem? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108293] Edit paragraph style: area and borders tab causes unwanted changes
https://bugs.documentfoundation.org/show_bug.cgi?id=108293 --- Comment #5 from Thomas Lendo --- The two issues I can reproduce is 1) when going to Highlighting tab, select 'Color' and select 'None' again. This activates 'Automatic,Transparent' in the 'Organizer' tab. And 2) when going to Area tab, select something and then 'None' again which causes 'None' to be in the 'Organizer' tab. Are these additional texts in 'Contains' still bugs or is this technically necessary? I would say it's only necessary after clicking 'OK' or 'Apply' and not before. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96382] Edit character style - background color and border shadow are applied unwantedly
https://bugs.documentfoundation.org/show_bug.cgi?id=96382 --- Comment #13 from Thomas Lendo --- Tested with Version: 6.4.0.0.alpha0+ Build ID: c2c0bcfc64c5fc0b8299e3143ced482d481d2df0 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-09-18_02:53:35 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96382] Edit character style - background color and border shadow are applied unwantedly
https://bugs.documentfoundation.org/show_bug.cgi?id=96382 --- Comment #12 from Thomas Lendo --- The only issue I can reproduce is when going to Highlighting tab, select 'Color' and select 'None' again. This activates 'Automatic,Transparent' in the 'Organizer' tab which it shouldn't. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113688] Cannot set data series filling to pattern
https://bugs.documentfoundation.org/show_bug.cgi?id=113688 --- Comment #11 from Thomas Lendo --- Issue fixed when using chart dialogs but still not finally fixed when using Sidebar. Then 'Bitmap' is selected. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127682] New Print dialog: Crash selecting (*) Even Pages
https://bugs.documentfoundation.org/show_bug.cgi?id=127682 raal changed: What|Removed |Added CC||r...@post.cz Keywords|bibisectRequest |bibisected --- Comment #6 from raal --- one of these commits: git log 78b5211f3464d7374b2888f2078da387f5a01ae6 commit 78b5211f3464d7374b2888f2078da387f5a01ae6 Author: Jenkins Build User Date: Thu Nov 29 23:49:03 2018 +0100 source sha:bc0146c2ae43256552c276d2dd86291c98556c42 source sha:bc0146c2ae43256552c276d2dd86291c98556c42 source sha:6686eaa079f5557d0f3bbe92781ad9854d8a5ef6 source sha:86c60a6af62bf50d5a6e7bc59bb29bfc1983584a source sha:8cbdc6a068ad88fc43a98bd0f88fcb7c4ad3ebd9 source sha:faf2b0f165e9d9e3160e5d54e3d2e9973facf0b8 source sha:07e4261ceaea31a20ab2bc1a76df722ed0bd54c4 source sha:cff219f792085645a13b4a703882a8984ce78ddc source sha:b368e4043582e6785a88b444e148fdffdc2aece1 source sha:b4601ff6d9261d185cd440ebdbca8d78f3b5d459 source sha:a0f02b8856fce1ee0eb5f1748c7c7fc04bd568a6 source sha:952e4a6ffd95b49d421b6477b3f8e33a6550097f source sha:e1bb5b2cd8ecc4db760b1d413e28edc388da5c3e source sha:ef9e16fd1720249620c628da66ec856a5629ff2a source sha:ff4896a2af1df6138e9246fe1588dfe8c3748f1a source sha:1a2ebd24e5daaefa209dea7f4b1889a8295b5794 source sha:bc34eaa0a87ff89b07581551991ac83d69f64d63 source sha:226ede405ed4549b7652c9a8421af37511e0046a source sha:76e22667625ce8d16dfaa8617a199b774e987a70 source sha:5c7fb4b4cd9409f8b92a4bb3fe288ba83ced2502 source sha:cb443d07d54d6698eff51b5be2c6b56323f10315 repro in gtk3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/jsdialogs' - 2 commits - include/vcl vcl/source
include/vcl/button.hxx|2 ++
include/vcl/layout.hxx|2 ++
vcl/source/control/button.cxx |7 +++
vcl/source/window/layout.cxx | 18 ++
vcl/source/window/window.cxx |4 +++-
5 files changed, 32 insertions(+), 1 deletion(-)
New commits:
commit 31d141e0c9570b06d86327b794cbbc555bb5c312
Author: Szymon Kłos
AuthorDate: Sun Sep 22 17:06:38 2019 +0200
Commit: Szymon Kłos
CommitDate: Sun Sep 22 21:07:27 2019 +0200
jsdialogs: export more properties
Change-Id: Iaabe560867025c30c1478d4b33357231e67b0b57
diff --git a/include/vcl/button.hxx b/include/vcl/button.hxx
index 71a8401cce10..14bb9d89567c 100644
--- a/include/vcl/button.hxx
+++ b/include/vcl/button.hxx
@@ -93,6 +93,8 @@ public:
virtual FactoryFunction GetUITestFactory() const override;
+virtual boost::property_tree::ptree DumpAsPropertyTree() override;
+
protected:
/// Handler for click, in case we want the button to handle uno commands
(.uno:Something).
diff --git a/include/vcl/layout.hxx b/include/vcl/layout.hxx
index 22730520363b..cfc2b444eaef 100644
--- a/include/vcl/layout.hxx
+++ b/include/vcl/layout.hxx
@@ -322,6 +322,7 @@ private:
Size calculateRequisitionForSpacings(sal_Int32 nRowSpacing, sal_Int32
nColSpacing) const;
virtual Size calculateRequisition() const override;
virtual void setAllocation(const Size ) override;
+virtual boost::property_tree::ptree DumpAsPropertyTree() override;
public:
VclGrid(vcl::Window *pParent)
: VclContainer(pParent)
diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx
index d2151c7018a2..b568e8e98f99 100644
--- a/vcl/source/control/button.cxx
+++ b/vcl/source/control/button.cxx
@@ -577,6 +577,13 @@ FactoryFunction Button::GetUITestFactory() const
return ButtonUIObject::create;
}
+boost::property_tree::ptree Button::DumpAsPropertyTree()
+{
+boost::property_tree::ptree aTree(Control::DumpAsPropertyTree());
+aTree.put("text", GetText());
+return aTree;
+}
+
IMPL_STATIC_LINK( Button, dispatchCommandHandler, Button*, pButton, void )
{
if (pButton == nullptr)
diff --git a/vcl/source/window/layout.cxx b/vcl/source/window/layout.cxx
index 21e844d4acf6..cb8f311cdd0b 100644
--- a/vcl/source/window/layout.cxx
+++ b/vcl/source/window/layout.cxx
@@ -1437,6 +1437,17 @@ void VclGrid::setAllocation(const Size& rAllocation)
}
}
+boost::property_tree::ptree VclGrid::DumpAsPropertyTree()
+{
+boost::property_tree::ptree aTree(VclContainer::DumpAsPropertyTree());
+array_type A = assembleGrid(*this);
+sal_Int32 nMaxX = A.shape()[0];
+sal_Int32 nMaxY = A.shape()[1];
+aTree.put("cols", nMaxX);
+aTree.put("rows", nMaxY);
+return aTree;
+}
+
bool toBool(const OUString )
{
return (!rValue.isEmpty() && (rValue[0] == 't' || rValue[0] == 'T' ||
rValue[0] == '1'));
diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index c83cae49b227..3dd8d1167f67 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -3347,13 +3347,15 @@ boost::property_tree::ptree Window::DumpAsPropertyTree()
aTree.put("id", get_id()); // TODO could be missing - sort out
aTree.put("type", windowTypeName(GetType()));
aTree.put("text", GetText());
+aTree.put("enabled", IsEnabled());
boost::property_tree::ptree aChildren;
if (vcl::Window* pChild = mpWindowImpl->mpFirstChild)
{
while (pChild)
{
-aChildren.push_back(std::make_pair("",
pChild->DumpAsPropertyTree()));
+if (pChild->IsVisible())
+aChildren.push_back(std::make_pair("",
pChild->DumpAsPropertyTree()));
pChild = pChild->mpWindowImpl->mpNext;
}
aTree.add_child("children", aChildren);
commit 61c0b2c48919a9f898cf1a68b5890f9a00c31de2
Author: Szymon Kłos
AuthorDate: Thu Sep 19 16:16:46 2019 +0200
Commit: Szymon Kłos
CommitDate: Sun Sep 22 21:07:21 2019 +0200
jsdialogs: export vertical property for Boxes
Change-Id: I377638b0e9c5575e41ea3f3714541cc94f61a92b
diff --git a/include/vcl/layout.hxx b/include/vcl/layout.hxx
index fa8765277488..22730520363b 100644
--- a/include/vcl/layout.hxx
+++ b/include/vcl/layout.hxx
@@ -90,6 +90,7 @@ public:
m_bHomogeneous = bHomogeneous;
}
virtual bool set_property(const OString , const OUString )
override;
+virtual boost::property_tree::ptree DumpAsPropertyTree() override;
protected:
virtual sal_uInt16 getDefaultAccessibleRole() const override;
void accumulateMaxes(const Size , Size ) const;
diff --git a/vcl/source/window/layout.cxx b/vcl/source/window/layout.cxx
index f5beadaf0a9f..21e844d4acf6 100644
--- a/vcl/source/window/layout.cxx
+++ b/vcl/source/window/layout.cxx
@@ -501,6 +501,13 @@ bool VclBox::set_property(const OString , const
OUString )
return true;
}
+boost::property_tree::ptree VclBox::DumpAsPropertyTree()
+{
+
[Libreoffice-commits] online.git: loleaflet/po
loleaflet/po/templates/loleaflet-ui.pot |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 272e0779a3f404203a46f1e183d35376748ab533 Author: Andras Timar AuthorDate: Sun Sep 22 21:07:34 2019 +0200 Commit: Andras Timar CommitDate: Sun Sep 22 21:07:34 2019 +0200 typo: necesary -> necessary Change-Id: Ic53690df33f37892993fca5a3024cf38d5309de0 diff --git a/loleaflet/po/templates/loleaflet-ui.pot b/loleaflet/po/templates/loleaflet-ui.pot index 490d2f391..223b9ecf8 100644 --- a/loleaflet/po/templates/loleaflet-ui.pot +++ b/loleaflet/po/templates/loleaflet-ui.pot @@ -1052,7 +1052,7 @@ msgstr "" #: src/map/Clipboard.js:782 msgid "" "If you would like to share larger elements of your document with other " -"applications it is necesary to first download them onto your device. To do " +"applications it is necessary to first download them onto your device. To do " "that press the \"Start download\" button below, and when complete click " "\"Confirm copy to clipboard\".If you are copy and pasting between " "documents inside %productName, there is no need to download." ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 127080] Improve handling of user-defined colors
https://bugs.documentfoundation.org/show_bug.cgi?id=127080 Thomas Lendo changed: What|Removed |Added CC||c...@nouenoff.nl, ||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval --- Comment #6 from Thomas Lendo --- Adding needsUXEval. (In reply to Ulrich Windl from comment #0) > Then the color is selected and the dialog closes. (even on single-click) > So you have to open the dialog again and select "user-defined color" to see > the values of the color you selected last. > That's quit uncomfortable. I don't see any benefit for the most users if the dialog keeps open which would result in an additional action for all users that don't want this behavior. > Solutions: > A single click in the palette dialog selects the color without closing the > dialog, while a double-click will select and close. Your suggestion seems to be a behavior that users are not familiar with. In other programs it behaves as LibreOffice does now. > Independent of that when hovering over a color (currently the name is being > shown), detailed color information (like RGB, Lch (HSB), CMYK, etc.) could > be added to the hover box. See bug 108751. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 127080] Improve handling of user-defined colors
https://bugs.documentfoundation.org/show_bug.cgi?id=127080 Thomas Lendo changed: What|Removed |Added CC||c...@nouenoff.nl, ||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval --- Comment #6 from Thomas Lendo --- Adding needsUXEval. (In reply to Ulrich Windl from comment #0) > Then the color is selected and the dialog closes. (even on single-click) > So you have to open the dialog again and select "user-defined color" to see > the values of the color you selected last. > That's quit uncomfortable. I don't see any benefit for the most users if the dialog keeps open which would result in an additional action for all users that don't want this behavior. > Solutions: > A single click in the palette dialog selects the color without closing the > dialog, while a double-click will select and close. Your suggestion seems to be a behavior that users are not familiar with. In other programs it behaves as LibreOffice does now. > Independent of that when hovering over a color (currently the name is being > shown), detailed color information (like RGB, Lch (HSB), CMYK, etc.) could > be added to the hover box. See bug 108751. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/map/Clipboard.js |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 3eed2b4d34058e5b84617e33404647b45b00576c
Author: Andras Timar
AuthorDate: Wed Aug 7 10:40:17 2019 +0200
Commit: Andras Timar
CommitDate: Sun Sep 22 21:04:33 2019 +0200
typo: necesary -> necessary
Change-Id: Ie1da1e2cbd874eb947d71db045bbf06d38851917
diff --git a/loleaflet/src/map/Clipboard.js b/loleaflet/src/map/Clipboard.js
index d079b57d5..2637c78cb 100644
--- a/loleaflet/src/map/Clipboard.js
+++ b/loleaflet/src/map/Clipboard.js
@@ -780,7 +780,7 @@ L.Clipboard = L.Class.extend({
var self = this;
var msg = _('If you would like to share larger elements of
your document with other applications ' +
- 'it is necesary to first download them onto your
device. To do that press the ' +
+ 'it is necessary to first download them onto your
device. To do that press the ' +
'"Start download" button below, and when complete
click "Confirm copy to clipboard".' +
'If you are copy and pasting between documents
inside %productName, ' +
'there is no need to download.');
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 127701] New: Zoom factor percentage calculating fault
https://bugs.documentfoundation.org/show_bug.cgi?id=127701 Bug ID: 127701 Summary: Zoom factor percentage calculating fault Product: LibreOffice Version: 6.3.1.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: yan...@gmail.com Description: If you right-click to zoom factor percentage and choose the one of "Entire Page", "Page Width" or "Optimal Width" options twice, it becomes "0%". Steps to Reproduce: 1. Run Writer 2. Right-click to zoom factor percentage and choose the current options among "Entire Page", "Page Width" or "Optimal Width", or choose one of them twice. Actual Results: It becomes "0%" Expected Results: It should continue to be the correct percentage. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 6.3.1.2 (x64) Build ID: b79626edf0065ac373bd1df5c28bd630b4424273 CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; Locale: tr-TR (en_US); UI-Language: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115738] Odd size calculation for watermark
https://bugs.documentfoundation.org/show_bug.cgi?id=115738 --- Comment #3 from Thomas Lendo --- Still reproducible. Version: 6.4.0.0.alpha0+ Build-ID: c2c0bcfc64c5fc0b8299e3143ced482d481d2df0 CPU-Threads: 4; BS: Linux 4.15; UI-Render: Standard; VCL: gtk3; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-09-18_02:53:35 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127325] Rendering (stamping) of rotated text is incorrect with OpenGL rendering enabled - severe clipping of glyphs on Vertical ruler, and rotated table cell text
https://bugs.documentfoundation.org/show_bug.cgi?id=127325 Khaled Hosny changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=71732 Bug 71732 depends on bug 127325, which changed state. Bug 127325 Summary: Rendering (stamping) of rotated text is incorrect with OpenGL rendering enabled - severe clipping of glyphs on Vertical ruler, and rotated table cell text https://bugs.documentfoundation.org/show_bug.cgi?id=127325 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93529] [META] VCL/OpenGL rendering tracker bug for 5.0+
https://bugs.documentfoundation.org/show_bug.cgi?id=93529 Bug 93529 depends on bug 127325, which changed state. Bug 127325 Summary: Rendering (stamping) of rotated text is incorrect with OpenGL rendering enabled - severe clipping of glyphs on Vertical ruler, and rotated table cell text https://bugs.documentfoundation.org/show_bug.cgi?id=127325 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113213] "Resume numbering" does not cancel "restart numbering" on enumerated list
https://bugs.documentfoundation.org/show_bug.cgi?id=113213 --- Comment #6 from Thomas Lendo --- I can't reproduce because if I insert parts of another list (direct formatted lists or list with styles formatting) the original list numbering isn't pasted. Therefore I can't resume nor deselect a numbering restart. Ulrich, please retest. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: configure.ac
configure.ac | 14 ++ 1 file changed, 14 insertions(+) New commits: commit 90188d07c17048291b6a64d461a982129a3f8837 Author: Ashod Nakashian AuthorDate: Sat Sep 21 16:29:56 2019 -0400 Commit: Ashod Nakashian CommitDate: Sun Sep 22 20:26:25 2019 +0200 configure: support sanitizers It is now possible to run ./configure --with-sanitizer=address (or any least of valid sanitizers) to build with sanitizers. When --with-sanitizer is specified, we build with -O1 and don't omit frame-pointer. We also enable RTTI (which should be enabled anyway, but just in case). UBSan (undefined) sanitizer can cause 'typeinfo' errors. Fixing the source is best, but as a workaround, disabling vptr sanitizer works. Just pass -fno-sanitize=vptr to CFLAGS and CXXFLAGS. Change-Id: I4031aa872b1b1ef779703135394f3733952e5cd1 Reviewed-on: https://gerrit.libreoffice.org/79329 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/configure.ac b/configure.ac index 711de7d01..c3ab7c195 100644 --- a/configure.ac +++ b/configure.ac @@ -184,6 +184,10 @@ AC_ARG_WITH([max-documents], AS_HELP_STRING([--with-max-documents], [Set the limit on the total number of documents. Def: 10, Min: 2.])) +AC_ARG_WITH([sanitizer], + AS_HELP_STRING([--with-sanitizer], + [Enable one or more compatible sanitizers. E.g. --with-sanitizer=address,undefined,leak])) + AC_ARG_WITH([compiler-plugins], AS_HELP_STRING([--with-compiler-plugins=], [Experimental! Unlikely to work for anyone except Noel! Enable compiler plugins that will perform additional checks during @@ -460,6 +464,16 @@ else AC_MSG_RESULT([no]) fi +AC_MSG_CHECKING([whether to turn sanitizers on]) +if test "x$with_sanitizer" != "x"; then +AC_MSG_RESULT([yes ($with_sanitizer)]) +SANITIZER_FLAGS="-O1 -fno-omit-frame-pointer -fsanitize=$with_sanitizer -frtti -static-libasan" +CXXFLAGS="$CXXFLAGS $SANITIZER_FLAGS" +CFLAGS="$CFLAGS $SANITIZER_FLAGS" +else +AC_MSG_RESULT([no]) +fi + # check for C++11 support HAVE_CXX11= AC_MSG_CHECKING([whether $CXX supports C++14 or C++11]) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: test/fakesockettest.cpp
test/fakesockettest.cpp |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 45a7dccbf894e9b80c7af5a2e9d5649e36885128 Author: Ashod Nakashian AuthorDate: Sat Sep 21 22:21:30 2019 -0400 Commit: Ashod Nakashian CommitDate: Sun Sep 22 20:25:28 2019 +0200 wsd: test: don't leak the test listener Change-Id: Ibc658ff68696f865071a4ef0c78e1886d8bf0d2c Reviewed-on: https://gerrit.libreoffice.org/79353 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/test/fakesockettest.cpp b/test/fakesockettest.cpp index c3243570f..49fd97754 100644 --- a/test/fakesockettest.cpp +++ b/test/fakesockettest.cpp @@ -287,7 +287,8 @@ int main(int, char**) controller.addListener(); CPPUNIT_NS::BriefTestProgressListener progress; controller.addListener(); -controller.addListener(new CPPUNIT_NS::TextTestProgressListener()); +CPPUNIT_NS::TextTestProgressListener listener; +controller.addListener(); CPPUNIT_NS::Test* testRegistry = CPPUNIT_NS::TestFactoryRegistry::getRegistry().makeTest(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: common/Png.hpp
common/Png.hpp | 66 +
1 file changed, 43 insertions(+), 23 deletions(-)
New commits:
commit f7bd2c7e1df5c2f1e17ae2b8e1658f9013704648
Author: Ashod Nakashian
AuthorDate: Sat Sep 21 21:10:18 2019 -0400
Commit: Ashod Nakashian
CommitDate: Sun Sep 22 20:24:36 2019 +0200
wsd: fix variable might be clobbered by ‘longjmp’ or ‘vfork’
As the comment details, this avoids having C++ objects
in the same frame as setjmp, which may reset their
contents without the dtor getting called.
Change-Id: I851ae8bffb4356d465a25dfc815a1fecb489fa30
Reviewed-on: https://gerrit.libreoffice.org/79338
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/common/Png.hpp b/common/Png.hpp
index d4e1c2cf5..d629158c2 100644
--- a/common/Png.hpp
+++ b/common/Png.hpp
@@ -111,13 +111,17 @@ unpremultiply_data (png_structp /*png*/, png_row_infop
row_info, png_bytep data)
}
}
-// Sadly, older libpng headers don't use const for the pixmap pointer
parameter to
-// png_write_row(), so can't use const here for pixmap.
-inline
-bool encodeSubBufferToPNG(unsigned char* pixmap, size_t startX, size_t startY,
- int width, int height,
- int bufferWidth, int bufferHeight,
- std::vector& output, LibreOfficeKitTileMode
mode)
+/// This function uses setjmp which may clobbers non-trivial objects.
+/// So we can't use logging or create complex C++ objects in this frame.
+/// Specifically, logging uses std::string objects, and GCC gives the
following:
+/// error: variable ‘__capacity’ might be clobbered by ‘longjmp’ or ‘vfork’
[-Werror=clobbered]
+/// In practice, this is bogus, since __capacity is has a trivial type, but
this error
+/// shows up with the sanitizers. But technically we shouldn't mix C++ objects
with setjmp.
+/// Sadly, older libpng headers don't use const for the pixmap pointer
parameter to
+/// png_write_row(), so can't use const here for pixmap.
+inline bool impl_encodeSubBufferToPNG(unsigned char* pixmap, size_t startX,
size_t startY,
+ int width, int height, int bufferWidth,
int bufferHeight,
+ std::vector& output,
LibreOfficeKitTileMode mode)
{
if (bufferWidth < width || bufferHeight < height)
{
@@ -148,7 +152,8 @@ bool encodeSubBufferToPNG(unsigned char* pixmap, size_t
startX, size_t startY,
auto initialSize = output.size();
#endif
-png_set_IHDR(png_ptr, info_ptr, width, height, 8,
PNG_COLOR_TYPE_RGB_ALPHA, PNG_INTERLACE_NONE, PNG_COMPRESSION_TYPE_DEFAULT,
PNG_FILTER_TYPE_DEFAULT);
+png_set_IHDR(png_ptr, info_ptr, width, height, 8,
PNG_COLOR_TYPE_RGB_ALPHA, PNG_INTERLACE_NONE,
+ PNG_COMPRESSION_TYPE_DEFAULT, PNG_FILTER_TYPE_DEFAULT);
png_set_write_fn(png_ptr, , user_write_fn, user_flush_fn);
png_set_write_status_fn(png_ptr, user_write_status_fn);
@@ -160,8 +165,6 @@ bool encodeSubBufferToPNG(unsigned char* pixmap, size_t
startX, size_t startY,
png_set_write_user_transform_fn (png_ptr, unpremultiply_data);
}
-auto a = std::chrono::steady_clock::now();
-
for (int y = 0; y < height; ++y)
{
size_t position = ((startY + y) * bufferWidth * 4) + (startX * 4);
@@ -170,19 +173,6 @@ bool encodeSubBufferToPNG(unsigned char* pixmap, size_t
startX, size_t startY,
png_write_end(png_ptr, info_ptr);
-auto b = std::chrono::steady_clock::now();
-
-std::chrono::milliseconds::rep duration =
std::chrono::duration_cast(b-a).count();
-
-static std::chrono::milliseconds::rep totalDuration = 0;
-static int nCalls = 0;
-
-totalDuration += duration;
-nCalls += 1;
-LOG_TRC("PNG compression took " << duration << " ms (" << output.size()
-<< " bytes). Average after " <<
std::to_string(nCalls)
-<< " calls: " << (totalDuration /
static_cast(nCalls)));
-
png_destroy_write_struct(_ptr, _ptr);
#ifdef IOS
@@ -198,6 +188,36 @@ bool encodeSubBufferToPNG(unsigned char* pixmap, size_t
startX, size_t startY,
return true;
}
+/// Sadly, older libpng headers don't use const for the pixmap pointer
parameter to
+/// png_write_row(), so can't use const here for pixmap.
+inline bool encodeSubBufferToPNG(unsigned char* pixmap, size_t startX, size_t
startY, int width,
+ int height, int bufferWidth, int bufferHeight,
+ std::vector& output,
LibreOfficeKitTileMode mode)
+{
+const auto start = std::chrono::steady_clock::now();
+
+const bool res = impl_encodeSubBufferToPNG(pixmap, startX, startY, width,
height, bufferWidth,
+ bufferHeight, output, mode);
+if (Log::traceEnabled())
+{
+const auto end = std::chrono::steady_clock::now();
+
+
[Libreoffice-commits] online.git: wsd/Storage.cpp
wsd/Storage.cpp |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
New commits:
commit 9c21408112a48aaded3e27e1257e54f1d8e53364
Author: Ashod Nakashian
AuthorDate: Sat Sep 21 21:49:58 2019 -0400
Commit: Ashod Nakashian
CommitDate: Sun Sep 22 20:25:04 2019 +0200
wsd: close iconv after converting
Change-Id: Idc0894362d0839449f7b1e1ae8c52c3ddb1dff45
Reviewed-on: https://gerrit.libreoffice.org/79352
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/wsd/Storage.cpp b/wsd/Storage.cpp
index 992f4a0d3..c96bd208f 100644
--- a/wsd/Storage.cpp
+++ b/wsd/Storage.cpp
@@ -733,9 +733,10 @@ StorageBase::SaveResult
WopiStorage::saveLocalFileToStorage(const Authorization&
{
// the suggested target has to be in UTF-7; default to extension
// only when the conversion fails
-std::string suggestedTarget = "." +
Poco::Path(saveAsFilename).getExtension();
+std::string suggestedTarget = '.' +
Poco::Path(saveAsFilename).getExtension();
-iconv_t cd = iconv_open("UTF-7", "UTF-8");
+//TODO: Perhaps we should cache this descriptor and reuse, as
iconv_open might be expensive.
+const iconv_t cd = iconv_open("UTF-7", "UTF-8");
if (cd == (iconv_t) -1)
LOG_ERR("Failed to initialize iconv for UTF-7 conversion,
using '" << suggestedTarget << "'.");
else
@@ -756,6 +757,8 @@ StorageBase::SaveResult
WopiStorage::saveLocalFileToStorage(const Authorization&
suggestedTarget = std::string([0], buffer.size() -
out_left);
LOG_TRC("Converted '" << saveAsFilename << "' to UTF-7 as
'" << suggestedTarget << "'.");
}
+
+iconv_close(cd);
}
if (isRename)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: test/test.cpp
test/test.cpp | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
New commits:
commit 3c52aff8cfc4c9b9a965dc1723c14de6c6f9fe58
Author: Ashod Nakashian
AuthorDate: Sun Sep 22 12:37:32 2019 -0400
Commit: Ashod Nakashian
CommitDate: Sun Sep 22 20:23:49 2019 +0200
wsd: test: support test command-line args in any order
No longer is it necessary to run with --verbose
in case we need --debugrun.
Also, by default the log level is now warning instead
of error, which should hopefully be more useful in
troubleshooting issues (or at least to force us
better categorize log messages).
Change-Id: Iad4279ecf3bf77780adcd786d4f46d9c964f302d
Reviewed-on: https://gerrit.libreoffice.org/79351
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/test/test.cpp b/test/test.cpp
index 8df5d1e79..d5c85710c 100644
--- a/test/test.cpp
+++ b/test/test.cpp
@@ -69,10 +69,21 @@ static bool IsDebugrun = false;
int main(int argc, char** argv)
{
-const bool verbose = (argc > 1 && std::string("--verbose") == argv[1]);
-IsDebugrun = (argc > 2 && std::string("--debugrun") == argv[2]);
-const char* loglevel = verbose ? "trace" : "error";
+bool verbose = false;
+for (int i = 1; i < argc; ++i)
+{
+const std::string arg(argv[i]);
+if (arg == "--verbose")
+{
+verbose = true;
+}
+else if (arg == "--debugrun")
+{
+IsDebugrun = true;
+}
+}
+const char* loglevel = verbose ? "trace" : "warning";
Log::initialize("tst", loglevel, true, false, {});
return runClientTests(true, verbose)? 0: 1;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: kit/ForKit.cpp kit/Kit.cpp kit/Kit.hpp test/test.cpp test/test.hpp wsd/LOOLWSD.cpp
kit/ForKit.cpp |9 ++---
kit/Kit.cpp |9 +
kit/Kit.hpp |5 +++--
test/test.cpp | 22 --
test/test.hpp |7 ++-
wsd/LOOLWSD.cpp |2 +-
6 files changed, 37 insertions(+), 17 deletions(-)
New commits:
commit 720c26176a09d8622cb7a8414b555b6f4f986d58
Author: Ashod Nakashian
AuthorDate: Sat Sep 21 14:39:32 2019 -0400
Commit: Ashod Nakashian
CommitDate: Sun Sep 22 20:23:27 2019 +0200
wsd: improved kit thread naming
Now the wsd docbroker thread and its peer kit
thread are trivial to match, since they are called
docbroker_xxx and kitbroker_xxx (where xxx is the
instance ID) respectively.
Also, label spare kit instances as kit_spare_xxx
to differentiate from ones with actual documents,
where xxx is a running counter to differentiate
spare instances from one another.
Now we are able to easily see (and count) the number
of spare kit instances, and match wsd and kit threads
handling a given document.
Unit-test logic updated to reflect the new thread
naming scheme.
Change-Id: I154dc8f200fbe0e65f3f5984e6dad2cef1b52e22
Reviewed-on: https://gerrit.libreoffice.org/79328
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/kit/ForKit.cpp b/kit/ForKit.cpp
index 81bff060e..2eea47725 100644
--- a/kit/ForKit.cpp
+++ b/kit/ForKit.cpp
@@ -250,7 +250,10 @@ static int createLibreOfficeKit(const std::string&
childRoot,
// Generate a jail ID to be used for in the jail path.
const std::string jailId = Util::rng::getFilename(16);
-LOG_DBG("Forking a loolkit process with jailId: " << jailId << ".");
+// Used to label the spare kit instances
+static size_t spareKitId = 0;
+++spareKitId;
+LOG_DBG("Forking a loolkit process with jailId: " << jailId << " as spare
loolkit #" << spareKitId << ".");
const Process::PID pid = fork();
if (!pid)
@@ -277,9 +280,9 @@ static int createLibreOfficeKit(const std::string&
childRoot,
}
#ifndef KIT_IN_PROCESS
-lokit_main(childRoot, jailId, sysTemplate, loTemplate, loSubPath,
NoCapsForKit, NoSeccomp, queryVersion, DisplayVersion);
+lokit_main(childRoot, jailId, sysTemplate, loTemplate, loSubPath,
NoCapsForKit, NoSeccomp, queryVersion, DisplayVersion, spareKitId);
#else
-lokit_main(childRoot, jailId, sysTemplate, loTemplate, loSubPath,
true, true, queryVersion, DisplayVersion);
+lokit_main(childRoot, jailId, sysTemplate, loTemplate, loSubPath,
true, true, queryVersion, DisplayVersion, spareKitId);
#endif
}
else
diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index beebb8aa2..b2a4a8b23 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -490,7 +490,6 @@ public:
// Shrink cache when we exceed the size to maximize
// the chance of hitting these entries in the future.
_cacheSize -= it->second.getData()->size();
-
it = _cache.erase(it);
}
else
@@ -2262,6 +2261,7 @@ protected:
std::string url;
URI::decode(docKey, url);
LOG_INF("New session [" << sessionId << "] request on url [" <<
url << "].");
+Util::setThreadName("kitbroker_" + docId);
if (!document)
document = std::make_shared(_loKit, _jailId, docKey,
docId, url, _queue, shared_from_this());
@@ -2428,11 +2428,12 @@ void lokit_main(
bool noCapabilities,
bool noSeccomp,
bool queryVersion,
-bool displayVersion
+bool displayVersion,
#else
const std::string& documentUri,
-int docBrokerSocket
+int docBrokerSocket,
#endif
+size_t spareKitId
)
{
#if !MOBILEAPP
@@ -2442,7 +2443,7 @@ void lokit_main(
SigUtil::setTerminationSignals();
#endif
-Util::setThreadName("loolkit");
+Util::setThreadName("kit_spare_" + Util::encodeId(spareKitId, 3));
// Reinitialize logging when forked.
const bool logToFile = std::getenv("LOOL_LOGFILE");
diff --git a/kit/Kit.hpp b/kit/Kit.hpp
index 0f8d90d6c..5c94c1342 100644
--- a/kit/Kit.hpp
+++ b/kit/Kit.hpp
@@ -35,11 +35,12 @@ void lokit_main(
bool noCapabilities,
bool noSeccomp,
bool queryVersionInfo,
-bool displayVersion
+bool displayVersion,
#else
const std::string& documentUri,
-int docBrokerSocket
+int docBrokerSocket,
#endif
+size_t spareKitId
);
bool globalPreinit(const std::string& loTemplate);
diff --git a/test/test.cpp b/test/test.cpp
index f5824b1d1..8df5d1e79 100644
--- a/test/test.cpp
+++ b/test/test.cpp
@@ -181,7 +181,7 @@ std::vector getProcPids(const char* exec_filename)
[Libreoffice-commits] online.git: 2 commits - loleaflet/src
loleaflet/src/control/Control.Menubar.js |4 +++-
loleaflet/src/unocommands.js |1 +
2 files changed, 4 insertions(+), 1 deletion(-)
New commits:
commit 08d7ddcb22a09583b7026e01079f6a0b3ff836e0
Author: Henry Castro
AuthorDate: Wed Feb 6 17:07:16 2019 -0400
Commit: Andras Timar
CommitDate: Sun Sep 22 20:21:44 2019 +0200
loleaflet: add menu item Format→Section
Change-Id: Iad9150b16f56e9460a9286f29813419fc50de90c
Reviewed-on: https://gerrit.libreoffice.org/67477
Reviewed-by: Jan Holesovsky
Tested-by: Jan Holesovsky
diff --git a/loleaflet/src/control/Control.Menubar.js
b/loleaflet/src/control/Control.Menubar.js
index fc1af8738..05a82e229 100644
--- a/loleaflet/src/control/Control.Menubar.js
+++ b/loleaflet/src/control/Control.Menubar.js
@@ -187,6 +187,7 @@ L.Control.Menubar = L.Control.extend({
{uno: '.uno:ParagraphDialog'},
{uno: '.uno:OutlineBullet'},
{uno: '.uno:PageDialog'},
+ {uno: '.uno:EditRegion'},
{type: 'separator'},
{uno: '.uno:TransformDialog'},
{uno: '.uno:FormatLine'},
diff --git a/loleaflet/src/unocommands.js b/loleaflet/src/unocommands.js
index 005f666b9..4a5e4812d 100644
--- a/loleaflet/src/unocommands.js
+++ b/loleaflet/src/unocommands.js
@@ -68,6 +68,7 @@ var unoCommandsArray = {
DuplicateSlide:{presentation:{menu:_('Duplicate ~Slide'),},},
EditHeaderAndFooter:{spreadsheet:{menu:_('~Headers and Footers...'),},},
EditMenu:{global:{menu:_('~Edit'),},},
+ EditRegion:{text:{menu:_('~Sections...'),}},
EditStyle:{global:{menu:_('~Edit
Style...'),},presentation:{menu:_('E~dit Style...'),},},
EntireCell:{text:{menu:_('C~ell'),},},
EntireColumn:{presentation:{menu:_('Select
Column'),},text:{menu:_('~Column'),},},
commit 18c97f1fd2f58382fdb1cd06b188402f4994f3fd
Author: merttumer
AuthorDate: Tue Jan 29 16:33:48 2019 +0300
Commit: Andras Timar
CommitDate: Sun Sep 22 20:21:44 2019 +0200
Added "Table of Contents, Index or Biblography" option to insert menu
Change-Id: I6ee18c90ef2c254ca11387e5792412c21faa502b
Signed-off-by: merttumer
Reviewed-on: https://gerrit.libreoffice.org/67076
Reviewed-by: Michael Meeks
Tested-by: Michael Meeks
diff --git a/loleaflet/src/control/Control.Menubar.js
b/loleaflet/src/control/Control.Menubar.js
index 5c49b01c3..fc1af8738 100644
--- a/loleaflet/src/control/Control.Menubar.js
+++ b/loleaflet/src/control/Control.Menubar.js
@@ -111,7 +111,8 @@ L.Control.Menubar = L.Control.extend({
{uno: '.uno:InsertRLM'}]},
{name: _UNO('.uno:IndexesMenu', 'text'), type:
'menu', menu: [
{uno: '.uno:InsertIndexesEntry'},
- {uno: '.uno:InsertAuthoritiesEntry'}]},
+ {uno: '.uno:InsertAuthoritiesEntry'},
+ {uno: '.uno:InsertMultiIndex'}]},
]},
{name: _UNO('.uno:FormatMenu', 'text'), id: 'format',
type: 'menu', menu: [
{name: _UNO('.uno:FormatTextMenu', 'text'),
type: 'menu', menu: [
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: common/Util.cpp
common/Util.cpp | 28
1 file changed, 20 insertions(+), 8 deletions(-)
New commits:
commit 82a34a6cb4452f9ab8e50f9b7c095d6ff65b82e8
Author: Ashod Nakashian
AuthorDate: Sat Sep 21 14:38:04 2019 -0400
Commit: Ashod Nakashian
CommitDate: Sun Sep 22 20:21:18 2019 +0200
wsd: improved logging of thread renaming
The thread name helps one track threads in logs.
When renaming threads it's important to log the process
and previous thread name (if any), so grepping is more
fruitful and tracking is easier.
Change-Id: I47a948d77629b387cc1e9fd58fdd88e1ae1168df
Reviewed-on: https://gerrit.libreoffice.org/79327
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/common/Util.cpp b/common/Util.cpp
index 9df234edd..4433fe6d2 100644
--- a/common/Util.cpp
+++ b/common/Util.cpp
@@ -530,19 +530,30 @@ namespace Util
return replace(r, "\n", " / ");
}
+// prctl(2) supports names of up to 16 characters, including
null-termination.
+// Although in practice on linux more than 16 chars is supported.
static thread_local char ThreadName[32] = {0};
+static_assert(sizeof(ThreadName) >= 16, "ThreadName should have a
statically known size, and not be a pointer.");
void setThreadName(const std::string& s)
{
-strncpy(ThreadName, s.c_str(), 31);
-ThreadName[31] = '\0';
+// Copy the current name.
+const std::string knownAs
+= ThreadName[0] ? "known as [" + std::string(ThreadName) + "]" :
"unnamed";
+
+// Set the new name.
+strncpy(ThreadName, s.c_str(), sizeof(ThreadName) - 1);
+ThreadName[sizeof(ThreadName) - 1] = '\0';
#ifdef __linux
if (prctl(PR_SET_NAME, reinterpret_cast(s.c_str()), 0,
0, 0) != 0)
-LOG_SYS("Cannot set thread name of " << getThreadId() << " (" <<
std::hex <<
-std::this_thread::get_id() << std::dec << ") to [" << s <<
"].");
+LOG_SYS("Cannot set thread name of "
+<< getThreadId() << " (" << std::hex <<
std::this_thread::get_id() << std::dec
+<< ") of process " << getpid() << " currently " << knownAs
<< " to [" << s
+<< "].");
else
-LOG_INF("Thread " << getThreadId() << " (" << std::hex <<
-std::this_thread::get_id() << std::dec << ") is now called
[" << s << "].");
+LOG_INF("Thread " << getThreadId() << " (" << std::hex <<
std::this_thread::get_id()
+ << std::dec << ") of process " << getpid() << "
formerly " << knownAs
+ << " is now called [" << s << "].");
#elif defined IOS
[[NSThread currentThread] setName:[NSString
stringWithUTF8String:ThreadName]];
LOG_INF("Thread " << getThreadId() <<
@@ -556,13 +567,14 @@ namespace Util
if (ThreadName[0] == '\0')
{
#ifdef __linux
+// prctl(2): The buffer should allow space for up to 16 bytes; the
returned string will be null-terminated.
if (prctl(PR_GET_NAME, reinterpret_cast(ThreadName), 0, 0, 0) != 0)
strncpy(ThreadName, "", sizeof(ThreadName) - 1);
#elif defined IOS
const char *const name = [[[NSThread currentThread] name]
UTF8String];
-strncpy(ThreadName, name, 31);
-ThreadName[31] = '\0';
+strncpy(ThreadName, name, sizeof(ThreadName) - 1);
#endif
+ThreadName[sizeof(ThreadName) - 1] = '\0';
}
// Avoid so many redundant system calls
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: wsd/Admin.cpp wsd/LOOLWSD.cpp wsd/LOOLWSD.hpp
wsd/Admin.cpp |4 ++--
wsd/LOOLWSD.cpp |4 ++--
wsd/LOOLWSD.hpp |6 +++---
3 files changed, 7 insertions(+), 7 deletions(-)
New commits:
commit 477d6714d995a78e1c5f501541eeb7d72fe7513f
Author: Ashod Nakashian
AuthorDate: Sat Sep 21 14:15:37 2019 -0400
Commit: Ashod Nakashian
CommitDate: Sun Sep 22 20:20:24 2019 +0200
wsd: SessionId -> ConnectionId
"Session" is too generic and can be misleading.
This is really a connection ID, or a connection-session ID,
so it's more sensible to call it ConnectionId to
signify that it's a connection-specific ID.
Change-Id: I0f12b1cf80d4853a27535101093ef6b7a3e0d438
Reviewed-on: https://gerrit.libreoffice.org/79326
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/wsd/Admin.cpp b/wsd/Admin.cpp
index cb8c43ceb..319503b69 100644
--- a/wsd/Admin.cpp
+++ b/wsd/Admin.cpp
@@ -274,7 +274,7 @@ AdminSocketHandler::AdminSocketHandler(Admin* adminManager,
_isAuthenticated(false)
{
// Different session id pool for admin sessions (?)
-_sessionId = Util::decodeId(LOOLWSD::GenSessionId());
+_sessionId = Util::decodeId(LOOLWSD::GetConnectionId());
}
AdminSocketHandler::AdminSocketHandler(Admin* adminManager)
@@ -282,7 +282,7 @@ AdminSocketHandler::AdminSocketHandler(Admin* adminManager)
_admin(adminManager),
_isAuthenticated(true)
{
-_sessionId = Util::decodeId(LOOLWSD::GenSessionId());
+_sessionId = Util::decodeId(LOOLWSD::GetConnectionId());
}
void AdminSocketHandler::sendTextFrame(const std::string& message)
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index f84a73238..bc971eb38 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -688,7 +688,7 @@ inline std::string getAdminURI(const
Poco::Util::LayeredConfiguration )
#endif // MOBILEAPP
-std::atomic LOOLWSD::NextSessionId;
+std::atomic LOOLWSD::NextConnectionId(1);
#ifndef KIT_IN_PROCESS
std::atomic LOOLWSD::ForKitWritePipe(-1);
@@ -2077,7 +2077,7 @@ private:
/// Set the socket associated with this ResponseClient.
void onConnect(const std::shared_ptr& socket) override
{
-_id = LOOLWSD::GenSessionId();
+_id = LOOLWSD::GetConnectionId();
_socket = socket;
LOG_TRC("#" << socket->getFD() << " Connected to
ClientRequestDispatcher.");
}
diff --git a/wsd/LOOLWSD.hpp b/wsd/LOOLWSD.hpp
index f8708b63d..0253d08b2 100644
--- a/wsd/LOOLWSD.hpp
+++ b/wsd/LOOLWSD.hpp
@@ -46,7 +46,7 @@ public:
// An Application is a singleton anyway,
// so just keep these as statics.
-static std::atomic NextSessionId;
+static std::atomic NextConnectionId;
static unsigned int NumPreSpawnedChildren;
static bool NoCapsForKit;
static bool NoSeccomp;
@@ -85,9 +85,9 @@ public:
/// For testing only [!] DocumentBrokers are mostly single-threaded with
their own thread
static std::vector> getBrokersTestOnly();
-static std::string GenSessionId()
+static std::string GetConnectionId()
{
-return Util::encodeId(++NextSessionId, 4);
+return Util::encodeId(NextConnectionId++, 3);
}
static bool isSSLEnabled()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp
wsd/DocumentBroker.cpp | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
New commits:
commit fd5581e7a314d343e628315d054aaaf5efd9795c
Author: Ashod Nakashian
AuthorDate: Thu Sep 19 23:42:13 2019 -0400
Commit: Ashod Nakashian
CommitDate: Sun Sep 22 20:19:41 2019 +0200
wsd: log before killing slow-loading docs
Change-Id: I85f045d1431feb51cb9ad093833c32a39ac38215
Reviewed-on: https://gerrit.libreoffice.org/79325
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index dffe5ea7f..ab71fe5ba 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -277,8 +277,8 @@ void DocumentBroker::pollThread()
auto lastBWUpdateTime = std::chrono::steady_clock::now();
auto lastClipboardHashUpdateTime = std::chrono::steady_clock::now();
-int limit_load_secs =
LOOLWSD::getConfigValue("per_document.limit_load_secs", 100);
-auto loadDeadline = std::chrono::steady_clock::now() +
std::chrono::seconds(limit_load_secs);
+const int limit_load_secs =
LOOLWSD::getConfigValue("per_document.limit_load_secs", 100);
+const auto loadDeadline = std::chrono::steady_clock::now() +
std::chrono::seconds(limit_load_secs);
#endif
auto last30SecCheckTime = std::chrono::steady_clock::now();
@@ -294,7 +294,14 @@ void DocumentBroker::pollThread()
{
// Brutal but effective.
if (_childProcess)
+{
+LOG_WRN("Doc [" << _docKey << "] is taking too long to load.
Will kill process ["
+<< _childProcess->getPid()
+<< "]. per_document.limit_load_secs set to "
<< limit_load_secs
+<< " secs.");
_childProcess->terminate();
+}
+
stop("Load timed out");
continue;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: net/Socket.cpp
net/Socket.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 68d834ac4fea7405acffa547da3436afc7648cbd
Author: Ashod Nakashian
AuthorDate: Thu Sep 19 10:08:45 2019 -0400
Commit: Ashod Nakashian
CommitDate: Sun Sep 22 20:18:51 2019 +0200
wsd: asan: stack-use-after-scope
Change-Id: Ia14e67f36b22ab45782cf0d1808b71e37b834104
Reviewed-on: https://gerrit.libreoffice.org/79324
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/net/Socket.cpp b/net/Socket.cpp
index f5661c3dd..345e1d652 100644
--- a/net/Socket.cpp
+++ b/net/Socket.cpp
@@ -693,7 +693,7 @@ bool StreamSocket::parseHeader(const char *clientName,
if (map)
map->_messageSize += contentLength;
-const std::string& expect = request.get("Expect", "");
+const std::string expect = request.get("Expect", "");
bool getExpectContinue = !expect.empty() && Poco::icompare(expect,
"100-continue") == 0;
if (getExpectContinue && !_sentHTTPContinue)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 77764] Do not display correctly on different operating systems.
https://bugs.documentfoundation.org/show_bug.cgi?id=77764 Thomas Lendo changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED CC||thomas.le...@gmail.com --- Comment #6 from Thomas Lendo --- This is not a right bug report. Nobody will ever 'fix' this (except by accident with fixing other bugs) as description of what is wrong is missing or steps to reproduce. A bug mix is not the right way to get something fixed. Closing as INVALID due to the age. Please reopen as NEW if you've other opinion with steps to reproduce ond a file created with a current version of LibreOffice that shows this bug(s). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76237] Wrong padding values at LO Math formula objects
https://bugs.documentfoundation.org/show_bug.cgi?id=76237 Thomas Lendo changed: What|Removed |Added Blocks||39750 CC||thomas.le...@gmail.com --- Comment #6 from Thomas Lendo --- Can't reproduce with border padding. Border line width can't be smaller than 0,05 pt. Version: 6.4.0.0.alpha0+ Build-ID: c2c0bcfc64c5fc0b8299e3143ced482d481d2df0 CPU-Threads: 4; BS: Linux 4.15; UI-Render: Standard; VCL: gtk3; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-09-18_02:53:35 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=39750 [Bug 39750] [META] General Math formula editor improvements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39750] [META] General Math formula editor improvements
https://bugs.documentfoundation.org/show_bug.cgi?id=39750 Thomas Lendo changed: What|Removed |Added Depends on||76237 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=76237 [Bug 76237] Wrong padding values at LO Math formula objects -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127681] Installation of LibreOffice 6.3.1 fails when changing installation path
https://bugs.documentfoundation.org/show_bug.cgi?id=127681 --- Comment #9 from Thorsten --- Created attachment 154371 --> https://bugs.documentfoundation.org/attachment.cgi?id=154371=edit Second log file you requested Unfortunately the second try has a file similar to the first try. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - 12 commits - cui/uiconfig desktop/inc desktop/source desktop/unx distro-configs/LibreOfficeiOS.conf distro-configs/LibreOfficeiOS_Sim
cui/uiconfig/ui/transparencytabpage.ui |2
desktop/inc/app.hxx|4
desktop/source/app/app.cxx |2
desktop/source/app/cmdlineargs.cxx |8
desktop/source/app/sofficemain.cxx |2
desktop/unx/source/splashx.c |3
distro-configs/LibreOfficeiOS.conf | 11
distro-configs/LibreOfficeiOS_Sim.conf | 32 ++
framework/source/fwe/helper/titlehelper.cxx|4
include/vcl/opengl/OpenGLWrapper.hxx | 13
sc/source/core/data/table2.cxx |2
sc/source/ui/unoobj/fmtuno.cxx |2
scp2/source/ooo/module_hidden_ooo.scp |2
sfx2/source/doc/guisaveas.cxx |5
solenv/gbuild/gbuild.mk|5
sw/inc/doc.hxx |8
sw/qa/extras/odfimport/odfimport.cxx |4
sw/qa/extras/ooxmlexport/data/tdf123636_newlinePageBreak.docx |binary
sw/qa/extras/ooxmlexport/data/tdf123636_newlinePageBreak2.docx |binary
sw/qa/extras/ooxmlexport/data/tdf123636_newlinePageBreak3.docx |binary
sw/qa/extras/ooxmlexport/data/tdf123636_newlinePageBreak4.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport11.cxx | 27 ++
sw/qa/extras/ooxmlexport/ooxmlexport6.cxx |2
sw/source/core/doc/doc.cxx |9
sw/source/core/doc/docnew.cxx |1
sw/source/core/txtnode/txtedt.cxx | 18 +
sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx | 30 +-
vcl/headless/svpinst.cxx | 22 -
vcl/inc/svsys.h|4
vcl/source/control/listctrl.cxx| 10
vcl/source/edit/vclmedit.cxx |8
vcl/source/salmain/salmain.cxx |5
vcl/source/treelist/svimpbox.cxx | 11
writerfilter/source/dmapper/DomainMapper.cxx | 23 +
xmlsecurity/Library_xsec_xmlsec.mk |1
xmlsecurity/source/helper/documentsignaturemanager.cxx |7
xmlsecurity/source/xmlsec/nss/nssinitializer.cxx | 131
+-
xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx | 56 ++--
xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx | 23 -
xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.hxx |2
xmlsecurity/source/xmlsec/nss/xmlsignature_nssimpl.cxx | 24 -
41 files changed, 383 insertions(+), 140 deletions(-)
New commits:
commit 9fc3d2261ef9d2daccde96c1f18c30144985ea3e
Author: Szymon Kłos
AuthorDate: Thu Jan 24 11:22:22 2019 +0100
Commit: Andras Timar
CommitDate: Sun Sep 22 19:08:57 2019 +0200
tdf#86731 Don't show 'start from beginning' when dictionary is missing
Change-Id: I160e4b15e3c636be0e23dd5bbb2da62dfa6a42ef
diff --git a/sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx
b/sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx
index 9f6863ae6e96..4761ee310f05 100644
--- a/sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx
+++ b/sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx
@@ -175,6 +175,8 @@ svx::SpellPortions
SwSpellDialogChildWindow::GetNextWrongSentence(bool bRecheck)
SwWrtShell* pWrtShell = GetWrtShell_Impl();
if(pWrtShell)
{
+bool bNoDictionaryAvailable =
pWrtShell->GetDoc()->IsDictionaryMissing();
+
if (!bRecheck)
{
// first set continuation point for spell/grammar check to the
@@ -379,7 +381,7 @@ The code below would only be part of the solution.
OSL_ENSURE(m_pSpellState->m_bDrawingsSpelled &&
m_pSpellState->m_bOtherSpelled &&
m_pSpellState->m_bBodySpelled,
"not all parts of the document are already spelled");
-if(m_pSpellState->m_xStartRange.is())
+if( m_pSpellState->m_xStartRange.is() && !bNoDictionaryAvailable )
{
LockFocusNotification( true );
std::unique_ptr
xBox(Application::CreateMessageDialog(GetWindow()->GetFrameWeld(),
@@ -405,7 +407,6 @@ The code below would only be part of the solution.
bCloseMessage = false; // no closing message if a wrap
around has been denied
}
}
-bool bNoDictionaryAvailable =
pWrtShell->GetDoc()->IsDictionaryMissing();
if( aRet.empty() && bCloseMessage && !bNoDictionaryAvailable )
{
[Libreoffice-bugs] [Bug 127681] Installation of LibreOffice 6.3.1 fails when changing installation path
https://bugs.documentfoundation.org/show_bug.cgi?id=127681 --- Comment #8 from Thorsten --- Hi, Thank you for your response but this is the result. I made a second screen video for, see https://www.screencast.com/t/PYymQBhZ The file I sent you does not have more lines. I'm going to send you the second result. With the previous version and the versions before, I did not have any issues, only with the latest one. Maybe I can install in standard directory on disk c:\ but I do not want to do this. Something is wrong with the latest installation process. Cheers, Thorsten -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127700] New behaviour of ALEA() and ALEA.ENTRE.BORNES(a; b)
https://bugs.documentfoundation.org/show_bug.cgi?id=127700 --- Comment #2 from kouka...@gmail.com --- There are going to be more users when upgrading to >6.2 to agree as to how much of an antifeature this change was for them. Speaking for myself: this is disastrous, I can't upgrade until fixed. I have suggested in https://bugs.documentfoundation.org/show_bug.cgi?id=102257 for one or two new functions: randnv and randbetweennv (nv meaning non-volatile). This way old users can do a find-replace in their old spreadsheets and move on with their lives. My previous comments: https://bugs.documentfoundation.org/show_bug.cgi?id=102257#c12 https://bugs.documentfoundation.org/show_bug.cgi?id=102257#c13 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127201] Screenreader accessibility issue with LibreOffice extension manager
https://bugs.documentfoundation.org/show_bug.cgi?id=127201 William Gathoye changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9ea9c7c5edafbc9c41d1604e42c46a6d55a034c9 Author: Andras Timar AuthorDate: Mon Jan 28 13:36:54 2019 +0100 Commit: Gerrit Code Review CommitDate: Sun Sep 22 18:45:36 2019 +0200 Update git submodules * Update translations from branch 'distro/collabora/cp-6.2' - [cp] Revert rename of Master Slide Design Change-Id: Ia8a6f8f16a7bc725a6184a627d65ba8a914d8c29 - [cp] Collabora support link Change-Id: Ief8aea81549070308fceb7feeb2ed38f94488474 - update translations for 6.2.7 and force-fix errors using pocheck Change-Id: Ie4f27c58ff9e329beeafef4c4b6f70a8378742f9 - update translations for 6.2.6 rc2 and force-fix errors using pocheck Change-Id: I2201f5c7ad2536af77fd0f68f9cd671e0e3ae75e - update translations for 6.2.6 rc1 and force-fix errors using pocheck Change-Id: I7008bede6d657b2e5a7017acaca04edbc7d0a063 - update translations for 6.2.5 rc2 and force-fix errors using pocheck Change-Id: I900cf02ffb00a83388f79c8c6045aacae01bbf32 diff --git a/translations b/translations index cd209b9e5908..0ae0feaa840b 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit cd209b9e5908240054c1d058899b1ae4a16b51c9 +Subproject commit 0ae0feaa840bdd8cf01d83536195963ba81c9fd7 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 50278] Provide separate dock icons for each component on macOS instead of or in addition to the global launcher aka make components single apps
https://bugs.documentfoundation.org/show_bug.cgi?id=50278 --- Comment #14 from steve -_- --- Adding notes from https://bugs.documentfoundation.org//show_bug.cgi?id=97946 Discussed this in the ESC meeting Jul/18 2019 and there was agreement to modify the installer. + only a matter of adding launchers (Christian) + provide a template and pull it into your dock easily + D installer gets you 1 application + perhaps a folder with some templates you can drag → launcher + no LibO code-change necessary. + lets find some volunteer that cares to write it (Michael) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50278] Provide separate dock icons for each component on macOS instead of or in addition to the global launcher aka make components single apps
https://bugs.documentfoundation.org/show_bug.cgi?id=50278 steve -_- changed: What|Removed |Added CC||l...@disr.it --- Comment #13 from steve -_- --- *** Bug 97946 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50278] Provide separate dock icons for each component on macOS instead of or in addition to the global launcher aka make components single apps
https://bugs.documentfoundation.org/show_bug.cgi?id=50278 steve -_- changed: What|Removed |Added Summary|Provide separate dock icons |Provide separate dock icons |for each component on Mac |for each component on macOS |OS X instead of or in |instead of or in addition |addition to the global |to the global launcher aka |launcher|make components single apps -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97946] LibreOffice components should be single apps on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=97946 steve -_- changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from steve -_- --- *** This bug has been marked as a duplicate of bug 50278 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127700] New behaviour of ALEA() and ALEA.ENTRE.BORNES(a; b)
https://bugs.documentfoundation.org/show_bug.cgi?id=127700 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #1 from m.a.riosv --- *** This bug has been marked as a duplicate of bug 102257 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - officecfg/registry
officecfg/registry/schema/org/openoffice/Office/Common.xcs |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0b1092742c270ee3ee0f063d8b00fa52d8c70587 Author: Andras Timar AuthorDate: Sun Sep 22 18:35:02 2019 +0200 Commit: Andras Timar CommitDate: Sun Sep 22 18:35:02 2019 +0200 [cp] switch to Collabora's help instance Change-Id: I70df6d7b7601f47b923c922c97436b0a826fc32e diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs b/officecfg/registry/schema/org/openoffice/Office/Common.xcs index c9202282b482..dde788c15c7b 100644 --- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs +++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs @@ -3597,7 +3597,7 @@ Specifies the root URL to the Office help pages. Blank disables Help buttons on dialogs in LibreOffice Online. -https://help.libreoffice.com/help.html? +https://help.collaboraoffice.com/help.html? ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 51330] FILEOPEN: Vertical Text in .pptx becomes horizontal when imported
https://bugs.documentfoundation.org/show_bug.cgi?id=51330 Buovjaga changed: What|Removed |Added CC||todven...@suomi24.fi Version|3.5.3 release |Inherited From OOo --- Comment #15 from Buovjaga --- Still confirmed Version: 6.4.0.0.alpha0+ (x64) Build ID: bda1d88f2bfa21202725ab9c567b3cccba3c1f0b CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-09-15_04:18:20 Locale: fi-FI (fi_FI); UI-Language: en-US Calc: threaded 3.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49920] FILEOPEN PPTX Colors of gradient are wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=49920 Buovjaga changed: What|Removed |Added Summary|[Impress] Colors of |FILEOPEN PPTX Colors of |gradient in pptx imported |gradient are wrong |wrong (thus borders of | |unselected layout elements | |are not visible)| Severity|major |normal --- Comment #11 from Buovjaga --- (In reply to Roman Kuznetsov from comment #9) > Created attachment 145143 [details] > Impress 6.2 alpha 0 24-09-2018 > > I see text and border of layout, but gradient is still some wrong in Still confirmed Version: 6.4.0.0.alpha0+ (x64) Build ID: bda1d88f2bfa21202725ab9c567b3cccba3c1f0b CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-09-15_04:18:20 Locale: fi-FI (fi_FI); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44949] FILESAVE: Demo file from wiki damaged when saved with LibO in Powerpoint 2007/2010 format
https://bugs.documentfoundation.org/show_bug.cgi?id=44949 Buovjaga changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #6 from Buovjaga --- Many shapes damaged, but not all Version: 6.4.0.0.alpha0+ (x64) Build ID: bda1d88f2bfa21202725ab9c567b3cccba3c1f0b CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-09-15_04:18:20 Locale: fi-FI (fi_FI); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41253] FILEOPEN PPTX Shadows for characters missing
https://bugs.documentfoundation.org/show_bug.cgi?id=41253 Buovjaga changed: What|Removed |Added Severity|normal |minor CC||todven...@suomi24.fi Summary|FILEOPEN pptx shadows for |FILEOPEN PPTX Shadows for |characters missing |characters missing Version|3.3.3 release |Inherited From OOo --- Comment #9 from Buovjaga --- Still confirmed Version: 6.4.0.0.alpha0+ (x64) Build ID: bda1d88f2bfa21202725ab9c567b3cccba3c1f0b CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-09-15_04:18:20 Locale: fi-FI (fi_FI); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
