date:20191017

[Libreoffice-bugs] [Bug 128213] FILESAVE PPTX roundtrip with z-rotated text produces additional shape rotation

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128213

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||xiscofa...@libreoffice.org
   Hardware|x86-64 (AMD64)  |All
 OS|Windows (All)   |All

--- Comment #1 from Xisco Faulí  ---
Reproduced in

Version: 6.4.0.0.alpha1+
Build ID: 01d28b0b85f99590c0581e4bbf636bc9281e0571
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

and MSO 2010

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128213] FILESAVE PPTX roundtrip with z-rotated text produces additional shape rotation

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128213

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||filter:pptx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104442] [META] DOCX (OOXML) shape (DrawingML and VML) related issues

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104442
Bug 104442 depends on bug 126001, which changed state.

Bug 126001 Summary: FILEOPEN DOCX Text box with rotated text jumps from middle 
of page to top
https://bugs.documentfoundation.org/show_bug.cgi?id=126001

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104449] [META] DOCX (OOXML) textbox-related issues

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104449
Bug 104449 depends on bug 126001, which changed state.

Bug 126001 Summary: FILEOPEN DOCX Text box with rotated text jumps from middle 
of page to top
https://bugs.documentfoundation.org/show_bug.cgi?id=126001

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126001] FILEOPEN DOCX Text box with rotated text jumps from middle of page to top

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=126001

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||xiscofa...@libreoffice.org
 Resolution|--- |WORKSFORME

--- Comment #12 from Xisco Faulí  ---
Verified in

Versión: 6.3.3.1 (x86)
Id. de compilación: f41f4c7f9507aeca13cb9df51f34d80e8ba30a99
Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; VCL: win; 
Configuración regional: es-ES (es_ES); Idioma de IU: es-ES
Calc: threaded

Closing as RESOLVED WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123325] FILEOPEN | DOCX, Shape text loses its rotation and resizes shape.

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=123325

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||5918

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125918] FILEOPEN DOCX Rotated long text in text box is not broken to fit text box size

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=125918

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||3325

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125918] FILEOPEN DOCX Rotated long text in text box is not broken to fit text box size

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=125918

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #6 from Xisco Faulí  ---
This seems the same issue as bug 123325.
Verified in

Versión: 6.3.3.1 (x86)
Id. de compilación: f41f4c7f9507aeca13cb9df51f34d80e8ba30a99
Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; VCL: win; 
Configuración regional: es-ES (es_ES); Idioma de IU: es-ES
Calc: threaded

Please, create a follow-up bug for the frame's size issue...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104449] [META] DOCX (OOXML) textbox-related issues

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104449
Bug 104449 depends on bug 125918, which changed state.

Bug 125918 Summary: FILEOPEN DOCX Rotated long text in text box is not broken 
to fit text box size
https://bugs.documentfoundation.org/show_bug.cgi?id=125918

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128202] Last used position in dialog Tools > Options not remembered

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128202

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from Xisco Faulí  ---
I can't reproduce it in

Version: 6.4.0.0.alpha1+
Build ID: 01d28b0b85f99590c0581e4bbf636bc9281e0571
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

could you please try with a clean profile ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128201] changing expert configuration not saved

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128201

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
I can't reproduce it in

Version: 6.4.0.0.alpha1+
Build ID: 01d28b0b85f99590c0581e4bbf636bc9281e0571
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

could you please try with a clean profile ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-qa] ESC meeting minutes: 2019-10-17

2019-10-17 Thread Stephan Bergmann


* Present:
 + Cloph, Ilmari, Sophie, Heiko, Eike, Caolan, Michael W., Xisco, 
Olivier,

   Michael S., Stephan


* Completed Action Items:

* Pending Action Items:
+ Collect summary / pictures for each GSoC project (Heiko)
  [ No updates from mentors yet; probably drop if there’s no input from
mentors! ]
  + draft: https://nextcloud.documentfoundation.org/s/XyMs94pqw5T44GW
  + still looking for input from everybody (except from Kendy and 
Heiko)

  + Propose new certified developers (Kendy, Stephan, Thorsten)

* Release Engineering update (Cloph)
+ 6.4 alpha: tagged yesterday, builds still running
  + branch-off is planned for mid-November
+ 6.3.3 status
  + notarization issues on macOS 10.15, not clear what the exact 
issue is

yet
+ 6.2.8 released today (last of the 8.2 line)
+ Remotes
   + Android remote: fresh release pending, incl. Building on newer SDK
+ Android viewer
   + Issue when opening any document? (Xisco)
 + Should be fixed (Cloph)
+ Online

* Documentation (Olivier)
+ New Help
   + Finishing touches for online Help & xapian (ohallot)
+ Helpcontent2
   + Housekeeping, after translation review (ohallot)
   + Untangling some complex help pages for macros (ohallot)
+ Google seasons of Doc
   + progressing
+ Guides
   + On going
+ OOo Developer Guide, not available in LO wiki (Ilmari)
   + Do we want to maintain it?
   + Definitively useful (Michael S.)
   + Ilmari happy to work on it to the side (esp. converting images
 to editable forms)
   + make that an EasyHack even? (Xisco)
   + more important to have a workflow how to do it than rather
 doing it quickly, as few will probably ever be updated
 (Michael S)
   + Even more useful OOo documentation (Olivier)

* UX Update (Heiko)
+ Bugzilla (topicUI) statistics
230(230) (topicUI) bugs open, 235(235) (needsUXEval) needs to 
be evaluated by the UXteam

+ Updates:
BZ changes   1 week   1 month   3 months   12 months
 added  9(2) 16(-4)43(-5)  99(-1)
 commented 79(2)278(13)   806(12)2007(45)
   removed  0(0)  0(0)  0(-1)  17(0)
  resolved  7(-2)36(2) 94(5)  190(5)
+ top 10 contributors:
  Heiko Tietze made 163 changes in 1 month, and 657 changes in 
1 year
  Foote, V Stuart made 75 changes in 1 month, and 342 changes 
in 1 year
  Dieter Praas made 58 changes in 1 month, and 245 changes in 1 
year
  Thomas Lendo made 41 changes in 1 month, and 319 changes in 1 
year
  Kainz, Andreas made 37 changes in 1 month, and 231 changes in 
1 year

  Xisco Faulí made 33 changes in 1 month, and 324 changes in 1 year
  Cor Nouws made 25 changes in 1 month, and 159 changes in 1 year
  *UNKNOWN* made 22 changes in 1 month, and 26 changes in 1 year
  Roman Kuznetsov made 20 changes in 1 month, and 274 changes 
in 1 year

  *UNKNOWN* made 15 changes in 1 month, and 15 changes in 1 year

+ New tickets with needsUXEval Oct/10-17

  * Better line/paragraph numbering
+ https://bugs.documentfoundation.org/show_bug.cgi?id=128163
  * FORMATTING: Page Number field inserts without its proper 
character style

+ https://bugs.documentfoundation.org/show_bug.cgi?id=128146
  * allow each deck to keep its own width in the sidebar
+ https://bugs.documentfoundation.org/show_bug.cgi?id=128180
  * Dash type should not respect draw:style="rect" item for draw:name
+ https://bugs.documentfoundation.org/show_bug.cgi?id=127509
  * [Sifr theme] Change Navigator's Update icon in Master document mode
(Writer)
+ https://bugs.documentfoundation.org/show_bug.cgi?id=127976
  * file Open type menu has about 175 items, please organize
+ https://bugs.documentfoundation.org/show_bug.cgi?id=128113
  => unconfirmed, in discussion, needinfo

   -> * Mouse pointer/cursor does not change its shape over selected text
+ https://bugs.documentfoundation.org/show_bug.cgi?id=127835
+ code pointers would be nice
  * Create Native Mac OS X Full Screen Mode
+ https://bugs.documentfoundation.org/show_bug.cgi?id=128186
  * [Sifr theme] Create good icons for Set reminder, Header, Footer and
Headings level show icons in Navigator
+ https://bugs.documentfoundation.org/show_bug.cgi?id=127977
   -> * WRITER TABLES: Sort warning needed or some form of protection
+ https://bugs.documentfoundation.org/show_bug.cgi?id=128090
+ new confirmation dialog like in Calc suggested
  * Frames around dialog widgets
+ https://bugs.documentfoundation.org/show_bug.cgi?id=125508
   -> * UI: Option to open all heading branches at once
+

[Libreoffice-bugs] [Bug 125918] FILEOPEN DOCX Rotated long text in text box is not broken to fit text box size

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=125918

--- Comment #5 from NISZ LibreOffice Team  ---
Created attachment 155091
  --> https://bugs.documentfoundation.org/attachment.cgi?id=155091=edit
Screenshot of the document in current Writer master

Looks pretty good in:

Version: 6.4.0.0.alpha1+ (x86)
Build ID: f0340d58cc0f2808ce8003099ff2a0495360f267
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; 
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/source cui/uiconfig

2019-10-17 Thread Caolán McNamara (via logerrit)

 cui/source/tabpages/border.cxx |4 ++--
 cui/uiconfig/ui/borderpage.ui  |   40 
 2 files changed, 6 insertions(+), 38 deletions(-)

New commits:
commit da50f3e15e38474a51361bdddbc0951dec5674bf
Author: Caolán McNamara 
AuthorDate: Wed Oct 16 11:57:02 2019 +0100
Commit: Heiko Tietze 
CommitDate: Thu Oct 17 16:32:02 2019 +0200

tdf#125508 remove border frame from shadows and presets

Change-Id: I022f64188e49553bd7bef38cdd51620dfa0b90cd
Reviewed-on: https://gerrit.libreoffice.org/80883
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 

diff --git a/cui/source/tabpages/border.cxx b/cui/source/tabpages/border.cxx
index 57534beb059c..84bdcd8f92c1 100644
--- a/cui/source/tabpages/border.cxx
+++ b/cui/source/tabpages/border.cxx
@@ -245,7 +245,7 @@ SvxBorderTabPage::SvxBorderTabPage(weld::Container* pPage, 
weld::DialogControlle
 , mbSync(true)
 , mbRemoveAdjacentCellBorders(false)
 , bIsCalcDoc(false)
-, m_xWndPresets(new 
SvtValueSet(m_xBuilder->weld_scrolled_window("presetswin")))
+, m_xWndPresets(new SvtValueSet(nullptr))
 , m_xWndPresetsWin(new weld::CustomWeld(*m_xBuilder, "presets", 
*m_xWndPresets))
 , m_xUserDefFT(m_xBuilder->weld_label("userdefft"))
 , m_xFrameSelWin(new weld::CustomWeld(*m_xBuilder, "framesel", 
m_aFrameSel))
@@ -263,7 +263,7 @@ SvxBorderTabPage::SvxBorderTabPage(weld::Container* pPage, 
weld::DialogControlle
 , m_xBottomMF(m_xBuilder->weld_metric_spin_button("bottommf", 
FieldUnit::MM))
 , m_xSynchronizeCB(m_xBuilder->weld_check_button("sync"))
 , m_xShadowFrame(m_xBuilder->weld_container("shadow"))
-, m_xWndShadows(new 
SvtValueSet(m_xBuilder->weld_scrolled_window("shadowswin")))
+, m_xWndShadows(new SvtValueSet(nullptr))
 , m_xWndShadowsWin(new weld::CustomWeld(*m_xBuilder, "shadows", 
*m_xWndShadows))
 , m_xFtShadowSize(m_xBuilder->weld_label("distanceft"))
 , m_xEdShadowSize(m_xBuilder->weld_metric_spin_button("distancemf", 
FieldUnit::MM))
diff --git a/cui/uiconfig/ui/borderpage.ui b/cui/uiconfig/ui/borderpage.ui
index 5cc25655f7ef..d81f70ae2fd8 100644
--- a/cui/uiconfig/ui/borderpage.ui
+++ b/cui/uiconfig/ui/borderpage.ui
@@ -122,26 +122,10 @@
   
 
 
-  
+  
 True
 True
-start
-never
-never
-in
-
-  
-True
-False
-
-  
-True
-True
-GDK_BUTTON_PRESS_MASK 
| GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK | 
GDK_STRUCTURE_MASK
-  
-
-  
-
+GDK_BUTTON_PRESS_MASK | 
GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK | 
GDK_STRUCTURE_MASK
   
   
 0
@@ -522,26 +506,10 @@
 True
 6
 
-  
+  
 True
 True
-start
-never
-never
-in
-
-  
-True
-False
-
-  
-True
-False
-GDK_BUTTON_PRESS_MASK 
| GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK | 
GDK_STRUCTURE_MASK
-  
-
-  
-
+GDK_BUTTON_PRESS_MASK | 
GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK | 
GDK_STRUCTURE_MASK
   
   
 0
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

ESC meeting minutes: 2019-10-17

2019-10-17 Thread Stephan Bergmann


* Present:
 + Cloph, Ilmari, Sophie, Heiko, Eike, Caolan, Michael W., Xisco, 
Olivier,

   Michael S., Stephan


* Completed Action Items:

* Pending Action Items:
+ Collect summary / pictures for each GSoC project (Heiko)
  [ No updates from mentors yet; probably drop if there’s no input from
mentors! ]
  + draft: https://nextcloud.documentfoundation.org/s/XyMs94pqw5T44GW
  + still looking for input from everybody (except from Kendy and 
Heiko)

  + Propose new certified developers (Kendy, Stephan, Thorsten)

* Release Engineering update (Cloph)
+ 6.4 alpha: tagged yesterday, builds still running
  + branch-off is planned for mid-November
+ 6.3.3 status
  + notarization issues on macOS 10.15, not clear what the exact 
issue is

yet
+ 6.2.8 released today (last of the 8.2 line)
+ Remotes
   + Android remote: fresh release pending, incl. Building on newer SDK
+ Android viewer
   + Issue when opening any document? (Xisco)
 + Should be fixed (Cloph)
+ Online

* Documentation (Olivier)
+ New Help
   + Finishing touches for online Help & xapian (ohallot)
+ Helpcontent2
   + Housekeeping, after translation review (ohallot)
   + Untangling some complex help pages for macros (ohallot)
+ Google seasons of Doc
   + progressing
+ Guides
   + On going
+ OOo Developer Guide, not available in LO wiki (Ilmari)
   + Do we want to maintain it?
   + Definitively useful (Michael S.)
   + Ilmari happy to work on it to the side (esp. converting images
 to editable forms)
   + make that an EasyHack even? (Xisco)
   + more important to have a workflow how to do it than rather
 doing it quickly, as few will probably ever be updated
 (Michael S)
   + Even more useful OOo documentation (Olivier)

* UX Update (Heiko)
+ Bugzilla (topicUI) statistics
230(230) (topicUI) bugs open, 235(235) (needsUXEval) needs to 
be evaluated by the UXteam

+ Updates:
BZ changes   1 week   1 month   3 months   12 months
 added  9(2) 16(-4)43(-5)  99(-1)
 commented 79(2)278(13)   806(12)2007(45)
   removed  0(0)  0(0)  0(-1)  17(0)
  resolved  7(-2)36(2) 94(5)  190(5)
+ top 10 contributors:
  Heiko Tietze made 163 changes in 1 month, and 657 changes in 
1 year
  Foote, V Stuart made 75 changes in 1 month, and 342 changes 
in 1 year
  Dieter Praas made 58 changes in 1 month, and 245 changes in 1 
year
  Thomas Lendo made 41 changes in 1 month, and 319 changes in 1 
year
  Kainz, Andreas made 37 changes in 1 month, and 231 changes in 
1 year

  Xisco Faulí made 33 changes in 1 month, and 324 changes in 1 year
  Cor Nouws made 25 changes in 1 month, and 159 changes in 1 year
  *UNKNOWN* made 22 changes in 1 month, and 26 changes in 1 year
  Roman Kuznetsov made 20 changes in 1 month, and 274 changes 
in 1 year

  *UNKNOWN* made 15 changes in 1 month, and 15 changes in 1 year

+ New tickets with needsUXEval Oct/10-17

  * Better line/paragraph numbering
+ https://bugs.documentfoundation.org/show_bug.cgi?id=128163
  * FORMATTING: Page Number field inserts without its proper 
character style

+ https://bugs.documentfoundation.org/show_bug.cgi?id=128146
  * allow each deck to keep its own width in the sidebar
+ https://bugs.documentfoundation.org/show_bug.cgi?id=128180
  * Dash type should not respect draw:style="rect" item for draw:name
+ https://bugs.documentfoundation.org/show_bug.cgi?id=127509
  * [Sifr theme] Change Navigator's Update icon in Master document mode
(Writer)
+ https://bugs.documentfoundation.org/show_bug.cgi?id=127976
  * file Open type menu has about 175 items, please organize
+ https://bugs.documentfoundation.org/show_bug.cgi?id=128113
  => unconfirmed, in discussion, needinfo

   -> * Mouse pointer/cursor does not change its shape over selected text
+ https://bugs.documentfoundation.org/show_bug.cgi?id=127835
+ code pointers would be nice
  * Create Native Mac OS X Full Screen Mode
+ https://bugs.documentfoundation.org/show_bug.cgi?id=128186
  * [Sifr theme] Create good icons for Set reminder, Header, Footer and
Headings level show icons in Navigator
+ https://bugs.documentfoundation.org/show_bug.cgi?id=127977
   -> * WRITER TABLES: Sort warning needed or some form of protection
+ https://bugs.documentfoundation.org/show_bug.cgi?id=128090
+ new confirmation dialog like in Calc suggested
  * Frames around dialog widgets
+ https://bugs.documentfoundation.org/show_bug.cgi?id=125508
   -> * UI: Option to open all heading branches at once
+

[Libreoffice-bugs] [Bug 128212] FILEOPEN PPTX text with z-Rotation has wrong position

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128212

Xisco Faulí  changed:

   What|Removed |Added

 OS|Windows (All)   |All
   Keywords||filter:pptx
 Ever confirmed|0   |1
   Hardware|x86-64 (AMD64)  |All
 Status|UNCONFIRMED |NEW
 CC||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Reproduced in

Version: 6.4.0.0.alpha1+
Build ID: 01d28b0b85f99590c0581e4bbf636bc9281e0571
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126001] FILEOPEN DOCX Text box with rotated text jumps from middle of page to top

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=126001

--- Comment #11 from NISZ LibreOffice Team  ---
Created attachment 155090
  --> https://bugs.documentfoundation.org/attachment.cgi?id=155090=edit
Screenshot of the document in current Writer master

Looks pretty good in:

Version: 6.4.0.0.alpha1+ (x86)
Build ID: f0340d58cc0f2808ce8003099ff2a0495360f267
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; 
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc: CL

Text box is still a bit too large, but position and rotation are now fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128187] Offer to open AppleWorks documents (.cwk / application/x-appleworks-document)

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128187

--- Comment #1 from Nate Graham  ---
Note that this is about AppleWorks documents, not iWork documents. AppleWorks
was Apple's office suite prior to iWork. It was a re-branding/fork of
ClarisWorks (hence inheriting the .cwk filename extension).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/skia' - 3 commits - bin/update_pch config_host/config_skia.h.in configure.ac external/skia RepositoryExternal.mk vcl/skia

2019-10-17 Thread Luboš Luňák (via logerrit)

Rebased ref, commits from common ancestor:
commit 62ab63e34774c444bb03d91c59fadbf952406688
Author: Luboš Luňák 
AuthorDate: Thu Oct 17 15:56:46 2019 +0200
Commit: Luboš Luňák 
CommitDate: Thu Oct 17 16:17:56 2019 +0200

update PCH for Skia

Change-Id: Iece4d90774890576bd3d84ed2218de56def96077

diff --git a/bin/update_pch b/bin/update_pch
index aaf97e4ccd4b..47d4da870e07 100755
--- a/bin/update_pch
+++ b/bin/update_pch
@@ -439,9 +439,20 @@ def filter_ignore(line, module):
 'dirent.h', # unix-specific
 'pthread.h',
 'unistd.h',
+'sys/stat.h',
 'ft2build.h',
 'fontconfig/fontconfig.h',
-'GL/glx.h'
+'GL/glx.h',
+'src/Transform_inl.h',
+'src/c/sk_c_from_to.h',
+'src/c/sk_types_priv.h',
+'src/core/SkBlitBWMaskTemplate.h',
+'src/sfnt/SkSFNTHeader.h',
+'src/opts/',
+'src/core/SkCubicSolver.h',
+'src/sksl/SkSLCPP.h',
+'src/gpu/vk/GrVkAMDMemoryAllocator.h',
+'src/gpu/GrUtil.h'
 ]
 
 for i in ignore_list:
diff --git a/external/skia/inc/pch/precompiled_skia.hxx 
b/external/skia/inc/pch/precompiled_skia.hxx
index 5f40d7a38273..3d87068fcaa9 100644
--- a/external/skia/inc/pch/precompiled_skia.hxx
+++ b/external/skia/inc/pch/precompiled_skia.hxx
@@ -13,7 +13,7 @@
  manual changes will be rewritten by the next run of update_pch.sh (which 
presumably
  also fixes all possible problems, so it's usually better to use it).
 
- Generated on 2019-09-26 11:31:14 using:
+ Generated on 2019-10-17 15:51:12 using:
  ./bin/update_pch external/skia skia --cutoff=1 --exclude:system 
--include:module --include:local
 
  If after updating build fails, use the following command to locate 
conflicting headers:
@@ -109,7 +109,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -227,8 +226,9 @@
 #include 
 #include 
 #include 
+#include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -612,6 +612,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -642,13 +643,23 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
 #include 
 #include 
+#include 
+#include 
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
 #include 
 #include 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -852,7 +863,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -947,7 +958,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -964,6 +974,10 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
+#include 
 #include 
 #endif // PCH_LEVEL >= 3
 #if PCH_LEVEL >= 4
commit 74926d7515f197e225a91cd351ae7caf17b56a9e
Author: Luboš Luňák 
AuthorDate: Thu Oct 17 12:56:31 2019 +0200
Commit: Luboš Luňák 
CommitDate: Thu Oct 17 16:17:55 2019 +0200

fix Skia enabling (disabling and it should not be enabled by default)

Change-Id: I96bd8565a2a311d556ca96d868feccaf00a9cfe3

diff --git a/vcl/skia/SkiaHelper.cxx b/vcl/skia/SkiaHelper.cxx
index 84291a3d1899..278d19bd8d52 100644
--- a/vcl/skia/SkiaHelper.cxx
+++ b/vcl/skia/SkiaHelper.cxx
@@ -18,6 +18,14 @@ bool SkiaHelper::isVCLSkiaEnabled() { return false; }
 
 #else
 
+static bool supportsVCLSkia()
+{
+static bool bDisableSkia = !!getenv("SAL_DISABLESKIA");
+bool bBlacklisted = false; // TODO isDeviceBlacklisted();
+
+return !bDisableSkia && !bBlacklisted;
+}
+
 bool SkiaHelper::isVCLSkiaEnabled()
 {
 /**
@@ -50,7 +58,7 @@ bool SkiaHelper::isVCLSkiaEnabled()
 "SAL_FORCESKIA"); // TODO SKIA || 
officecfg::Office::Common::VCL::ForceOpenGL::get();
 
 bool bRet = false;
-bool bSupportsVCLSkia = true; // TODO SKIA supportsVCLOpenGL();
+bool bSupportsVCLSkia = supportsVCLSkia();
 // TODO SKIA always call supportsVCLOpenGL to de-zombie the glxtest child 
process on X11
 if (bForceSkia)
 {
@@ -63,7 +71,6 @@ bool SkiaHelper::isVCLSkiaEnabled()
 bEnable = bEnableSkiaEnv;
 
 // TODO SKIAif 
(officecfg::Office::Common::VCL::UseOpenGL::get())
-bEnable = true;
 
 // Force disable in safe mode
 if (Application::IsSafeModeEnabled())
commit b7ce49c66fc9dd181b1858d9b0ebad6c9654b4c2
Author: Luboš Luňák 
AuthorDate: Thu Oct 17 12:07:48 2019 +0200
Commit: Luboš Luňák 
CommitDate: Thu Oct 17 16:17:48 2019 +0200

use the same config file for skia build and using it

So that the setup is consistent.

Change-Id: Ia113c7bf79036e3ec7585263ed70da68e461fbac

diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index 73be1e7e09a8..049ab3dbe317 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -114,15 +114,20 @@ endif
 ifneq ($(ENABLE_SKIA),)
 define gb_LinkTarget__use_skia
 $(call gb_LinkTarget_set_include,$(1),\
-   -I$(call

[Libreoffice-commits] core.git: Branch 'feature/skia' - 3 commits - bin/update_pch config_host/config_skia.h.in external/skia vcl/skia

2019-10-17 Thread Luboš Luňák (via logerrit)

 bin/update_pch |   13 +++-
 config_host/config_skia.h.in   |   45 +
 external/skia/inc/pch/precompiled_skia.hxx |   24 ---
 vcl/skia/SkiaHelper.cxx|   11 +--
 4 files changed, 85 insertions(+), 8 deletions(-)

New commits:
commit f8218d8f35030b26b3be7aff47600b71702b2bf6
Author: Luboš Luňák 
AuthorDate: Thu Oct 17 15:56:46 2019 +0200
Commit: Luboš Luňák 
CommitDate: Thu Oct 17 16:16:16 2019 +0200

update PCH for Skia

Change-Id: Iece4d90774890576bd3d84ed2218de56def96077

diff --git a/bin/update_pch b/bin/update_pch
index aaf97e4ccd4b..47d4da870e07 100755
--- a/bin/update_pch
+++ b/bin/update_pch
@@ -439,9 +439,20 @@ def filter_ignore(line, module):
 'dirent.h', # unix-specific
 'pthread.h',
 'unistd.h',
+'sys/stat.h',
 'ft2build.h',
 'fontconfig/fontconfig.h',
-'GL/glx.h'
+'GL/glx.h',
+'src/Transform_inl.h',
+'src/c/sk_c_from_to.h',
+'src/c/sk_types_priv.h',
+'src/core/SkBlitBWMaskTemplate.h',
+'src/sfnt/SkSFNTHeader.h',
+'src/opts/',
+'src/core/SkCubicSolver.h',
+'src/sksl/SkSLCPP.h',
+'src/gpu/vk/GrVkAMDMemoryAllocator.h',
+'src/gpu/GrUtil.h'
 ]
 
 for i in ignore_list:
diff --git a/external/skia/inc/pch/precompiled_skia.hxx 
b/external/skia/inc/pch/precompiled_skia.hxx
index 5f40d7a38273..3d87068fcaa9 100644
--- a/external/skia/inc/pch/precompiled_skia.hxx
+++ b/external/skia/inc/pch/precompiled_skia.hxx
@@ -13,7 +13,7 @@
  manual changes will be rewritten by the next run of update_pch.sh (which 
presumably
  also fixes all possible problems, so it's usually better to use it).
 
- Generated on 2019-09-26 11:31:14 using:
+ Generated on 2019-10-17 15:51:12 using:
  ./bin/update_pch external/skia skia --cutoff=1 --exclude:system 
--include:module --include:local
 
  If after updating build fails, use the following command to locate 
conflicting headers:
@@ -109,7 +109,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -227,8 +226,9 @@
 #include 
 #include 
 #include 
+#include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -612,6 +612,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -642,13 +643,23 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
 #include 
 #include 
+#include 
+#include 
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
 #include 
 #include 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -852,7 +863,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -947,7 +958,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -964,6 +974,10 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
+#include 
 #include 
 #endif // PCH_LEVEL >= 3
 #if PCH_LEVEL >= 4
commit 04df4cad3e235133d4e3704d0034977e806be0ed
Author: Luboš Luňák 
AuthorDate: Thu Oct 17 12:56:31 2019 +0200
Commit: Luboš Luňák 
CommitDate: Thu Oct 17 16:16:11 2019 +0200

fix Skia enabling (disabling and it should not be enabled by default)

Change-Id: I96bd8565a2a311d556ca96d868feccaf00a9cfe3

diff --git a/vcl/skia/SkiaHelper.cxx b/vcl/skia/SkiaHelper.cxx
index 84291a3d1899..278d19bd8d52 100644
--- a/vcl/skia/SkiaHelper.cxx
+++ b/vcl/skia/SkiaHelper.cxx
@@ -18,6 +18,14 @@ bool SkiaHelper::isVCLSkiaEnabled() { return false; }
 
 #else
 
+static bool supportsVCLSkia()
+{
+static bool bDisableSkia = !!getenv("SAL_DISABLESKIA");
+bool bBlacklisted = false; // TODO isDeviceBlacklisted();
+
+return !bDisableSkia && !bBlacklisted;
+}
+
 bool SkiaHelper::isVCLSkiaEnabled()
 {
 /**
@@ -50,7 +58,7 @@ bool SkiaHelper::isVCLSkiaEnabled()
 "SAL_FORCESKIA"); // TODO SKIA || 
officecfg::Office::Common::VCL::ForceOpenGL::get();
 
 bool bRet = false;
-bool bSupportsVCLSkia = true; // TODO SKIA supportsVCLOpenGL();
+bool bSupportsVCLSkia = supportsVCLSkia();
 // TODO SKIA always call supportsVCLOpenGL to de-zombie the glxtest child 
process on X11
 if (bForceSkia)
 {
@@ -63,7 +71,6 @@ bool SkiaHelper::isVCLSkiaEnabled()
 bEnable = bEnableSkiaEnv;
 
 // TODO SKIAif 
(officecfg::Office::Common::VCL::UseOpenGL::get())
-bEnable = true;
 
 // Force disable in safe mode
 if (Application::IsSafeModeEnabled())
commit 46b60cf079e4389a18639ca075cc21ec7b4b89f1
Author: Luboš Luňák 
AuthorDate: Thu Oct 17 12:07:48 2019 +0200
Commit: Luboš Luňák 
CommitDate: Thu Oct 17 16:16:06 2019 +0200

use the same config file for skia build and using it

So that the setup is consistent.

Change-Id: Ia113c7bf79036e3ec7585263ed70da68e461fbac

diff --git

[Libreoffice-commits] online.git: loleaflet/images

2019-10-17 Thread Pedro (via logerrit)

 loleaflet/images/lc_fullscreen-presentation.svg |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit df87bcbc46e20c285923d7a3199890f19e9cbaba
Author: Pedro 
AuthorDate: Thu Oct 17 14:39:51 2019 +0200
Commit: Szymon Kłos 
CommitDate: Thu Oct 17 16:07:38 2019 +0200

Hamburger menu: Impress: Use proper icon for Fullscreen Presentation instead

Change-Id: I5440d9994daa15465cbec676829e701442fb2074
Reviewed-on: https://gerrit.libreoffice.org/80946
Reviewed-by: Szymon Kłos 
Tested-by: Szymon Kłos 

diff --git a/loleaflet/images/lc_fullscreen-presentation.svg 
b/loleaflet/images/lc_fullscreen-presentation.svg
index a788d66a9..f7d561a22 100644
--- a/loleaflet/images/lc_fullscreen-presentation.svg
+++ b/loleaflet/images/lc_fullscreen-presentation.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg;>
\ No newline at end of file
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sd/CppunitTest_sd_uimpress.mk sd/Library_sd.mk

2019-10-17 Thread Michael Weghorn (via logerrit)

 sd/CppunitTest_sd_uimpress.mk |3 ++-
 sd/Library_sd.mk  |3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

New commits:
commit 24004cdf9e2582d429b8987a40eb82af6926013c
Author: Michael Weghorn 
AuthorDate: Thu Oct 17 14:18:20 2019 +0200
Commit: Michael Weghorn 
CommitDate: Thu Oct 17 16:04:19 2019 +0200

gbuild: Treat 'DBUS_GLIB_CFLAGS' as includes, not defines

Since that variable holds the relevant includes, using
'gb_LinkTarget_set_include' makes sure that those
flags end up in the correct section, e.g. when generating
IDE integration using 'gbuild-to-ide'.

E.g. for the 'qtcreator-ide-integraton' make target, this
makes sure that they end up in the 'INCLUDES' section in
'sd/sd.pro' and not the 'DEFINES' section, which previously
led to an "error: macro name must be an identifier" being
shown when editing files underneath 'sd/' in Qt Creator with
the Clang Code Model plugin enabled, s.a. commit
4aa60490622cc10f8d3a31489c62a5622d240c83
("gbuild: treat $({QT,KF}5_CFLAGS) as cxxflags, not defines").

Corresponding entry in my config_host.mk.in on Debian
bullseye/testing:

export DBUS_GLIB_CFLAGS=$(gb_SPACE)-I/usr/include/glib-2.0 
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include

Change-Id: I9af9a58fdc05ce6648221c00a20859be777843f9
Reviewed-on: https://gerrit.libreoffice.org/80944
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/sd/CppunitTest_sd_uimpress.mk b/sd/CppunitTest_sd_uimpress.mk
index 94229cc2c8e3..93426dfc3a55 100644
--- a/sd/CppunitTest_sd_uimpress.mk
+++ b/sd/CppunitTest_sd_uimpress.mk
@@ -80,7 +80,8 @@ $(eval $(call gb_CppunitTest_use_externals,sd_uimpress,\
 ))
 
 ifneq ($(DBUS_HAVE_GLIB),)
-$(eval $(call gb_CppunitTest_add_defs,sd_uimpress,\
+$(eval $(call gb_CppunitTest_set_include,sd_uimpress,\
+   $$(INCLUDE) \
$(DBUS_GLIB_CFLAGS) \
 ))
 $(eval $(call gb_CppunitTest_add_libs,sd_uimpress,\
diff --git a/sd/Library_sd.mk b/sd/Library_sd.mk
index e8afd204c308..410f3c782b29 100644
--- a/sd/Library_sd.mk
+++ b/sd/Library_sd.mk
@@ -110,7 +110,8 @@ $(eval $(call gb_Library_use_externals,sd,\
 ))
 
 ifneq ($(DBUS_HAVE_GLIB),)
-$(eval $(call gb_Library_add_defs,sd,\
+$(eval $(call gb_Library_set_include,sd,\
+   $$(INCLUDE) \
$(DBUS_GLIB_CFLAGS) \
 ))
 $(eval $(call gb_Library_add_libs,sd,\
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/css loleaflet/images

2019-10-17 Thread Pedro (via logerrit)

 loleaflet/css/mobilewizard.css |6 ++
 loleaflet/images/lc_downloadas-pdf.svg |1 +
 2 files changed, 7 insertions(+)

New commits:
commit 27c935c516e5fb8ac10c85710bbffe6454227ea0
Author: Pedro 
AuthorDate: Thu Oct 17 15:20:39 2019 +0200
Commit: Szymon Kłos 
CommitDate: Thu Oct 17 16:05:14 2019 +0200

Hamburger menu: add missing downloadaspdf icon and disable other filetype 
icons

Change-Id: I78115ec3ad75d556140987b94015dafc1ddf5379
Reviewed-on: https://gerrit.libreoffice.org/80950
Reviewed-by: Szymon Kłos 
Tested-by: Szymon Kłos 

diff --git a/loleaflet/css/mobilewizard.css b/loleaflet/css/mobilewizard.css
index a16d2c2cf..d79dfb93b 100644
--- a/loleaflet/css/mobilewizard.css
+++ b/loleaflet/css/mobilewizard.css
@@ -35,3 +35,9 @@ span#main-menu-btn-icon {
 #leadingzeroes .spinfieldimage, #decimalplaces .spinfieldimage{
display: none;
 }
+.ui-header.level-1.mobile-wizard.ui-widget img[src^="images/lc_downloadas"] {
+   visibility: hidden;
+}
+.ui-header.level-1.mobile-wizard.ui-widget 
img[src="images/lc_downloadas-pdf.svg"]{
+   visibility: visible;
+}
diff --git a/loleaflet/images/lc_downloadas-pdf.svg 
b/loleaflet/images/lc_downloadas-pdf.svg
new file mode 100644
index 0..9c0b9ebc3
--- /dev/null
+++ b/loleaflet/images/lc_downloadas-pdf.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3-3' - bridges/Library_cpp_uno.mk config_host.mk.in configure.ac

2019-10-17 Thread Stephan Bergmann (via logerrit)

 bridges/Library_cpp_uno.mk |9 -
 config_host.mk.in  |1 +
 configure.ac   |   11 +++
 3 files changed, 20 insertions(+), 1 deletion(-)

New commits:
commit d5e7b39f863ce697f7c29c08b5e59919bd9b3156
Author: Stephan Bergmann 
AuthorDate: Fri Oct 11 23:50:19 2019 +0200
Commit: Caolán McNamara 
CommitDate: Thu Oct 17 16:03:57 2019 +0200

aarch64 callVirtualFunction needs to be compiled w/o 
-fstack-clash-protection

At least when doing an aarch64 Flatpak build against 
org.freedesktop.Sdk//19.08,
which uses GCC 9.2.0 and passes in `CXXFLAGS=-O2 -g -pipe
-Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions
-fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables
-fstack-clash-protection`, callVirtualMethod (in
bridges/source/cpp_uno/gcc3_linux_aarch64/callvirtualfunction.cxx) would
decrement the stack pointer another 16 bytes after the

  stackargs = alloca(...);

and before the asm block, so in the called virtual function, arguments read 
from
the stack would read garbage (and CustomTarget_testtools/uno_test would fail
with SIGSEGV at

> #0  0xb733eb48 in rtl::OUString::operator= (this=0xf9c1ac30, 
str=...) at /run/build/libreoffice/include/rtl/ustring.hxx:453
> #1  0xb733a7bc in bridge_object::assign (rData=..., bBool=true, 
cChar=64 u'@', nByte=17 '\021', nShort=4660, nUShort=65244, nLong=305419896, 
nULong=4275878552, nHyper=0, nUHyper=187651311381888, fFloat=17.0814991, 
fDouble=3.141592635899, eEnum=-1698898192, rStr=..., xTest=..., rAny=...) 
at /run/build/libreoffice/testtools/source/bridgetest/cppobj.cxx:99
> #2  0xb733a87c in bridge_object::assign (rData=..., bBool=true, 
cChar=64 u'@', nByte=17 '\021', nShort=4660, nUShort=65244, nLong=305419896, 
nULong=4275878552, nHyper=0, nUHyper=187651311381888, fFloat=17.0814991, 
fDouble=3.141592635899, eEnum=-1698898192, rStr=..., xTest=..., rAny=..., 
rSequence=...) at 
/run/build/libreoffice/testtools/source/bridgetest/cppobj.cxx:115
> #3  0xb733ade4 in bridge_object::Test_Impl::setValues 
(this=0xf9c1abb0, bBool=1 '\001', cChar=64 u'@', nByte=17 '\021', 
nShort=4660, nUShort=65244, nLong=305419896, nULong=4275878552, nHyper=0, 
nUHyper=187651311381888, fFloat=17.0814991, fDouble=3.141592635899, 
eEnum=-1698898192, rStr=..., xTest=..., rAny=..., rSequence=..., rStruct=...) 
at /run/build/libreoffice/testtools/source/bridgetest/cppobj.cxx:548
> #4  0xb740bff4 in callVirtualFunction (function=281473755360772, 
gpr=0xd1ab1f28, fpr=0xd1ab1f68, stack=0xd1ab1d40, sp=8, 
ret=0xd1ab22c0) at 
/run/build/libreoffice/bridges/source/cpp_uno/gcc3_linux_aarch64/callvirtualfunction.cxx:63
> #5  0xb740ca70 in (anonymous namespace)::call 
(proxy=0xf9c291c0, slot=..., returnType=0xf9c00770, count=17, 
parameters=0xf9c3a210, returnValue=0xd1ab22c0, 
arguments=0xd1ab2230, exception=0xd1ab2370) at 
/run/build/libreoffice/bridges/source/cpp_uno/gcc3_linux_aarch64/uno2cpp.cxx:178
> #6  0xb740d4c4 in 
bridges::cpp_uno::shared::unoInterfaceProxyDispatch (pUnoI=0xf9c291c0, 
pMemberDescr=0xf9c55950, pReturn=0xd1ab22c0, pArgs=0xd1ab2230, 
ppException=0xd1ab2370) at 
/run/build/libreoffice/bridges/source/cpp_uno/gcc3_linux_aarch64/uno2cpp.cxx:361
> #7  0xb740720c in (anonymous namespace)::call 
(proxy=0xf9c549c0, description=..., returnType=0xf9c00770, count=17, 
parameters=0xf9c3a210, gpr=0xd1ab2510, fpr=0xd1ab2550, 
stack=0xd1ab2590, indirectRet=0xb7d24790) at 
/run/build/libreoffice/bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx:120
> #8  0xb74079a0 in (anonymous namespace)::vtableCall 
(functionIndex=40, vtableOffset=0, gpr=0xd1ab2510, fpr=0xd1ab2550, 
stack=0xd1ab2590, indirectRet=0xb7d24790) at 
/run/build/libreoffice/bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx:291
> #9  0xb7407b00 in (anonymous namespace)::vtableSlotCall 
(gpr0=187651311618536, gpr1=1, gpr2=64, gpr3=17, gpr4=4660, gpr5=65244, 
gpr6=305419896, gpr7=4275878552, fpr0=5.4321266044931319e-315, 
fpr1=3.141592635899, fpr2=0, fpr3=4.0039072046065485, fpr4=0, 
fpr5=4.003911019303815, fpr6=8.9589789687541617e+102, 
fpr7=-4.4588500238274385e-308) at 
/run/build/libreoffice/bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx:348
> #10 0xb739e60c in bridge_test::performTest (xContext=..., 
xLBT=..., noCurrentContext=false) at 
/run/build/libreoffice/testtools/source/bridgetest/bridgetest.cxx:378
> #11 0xb73a3d58 in bridge_test::TestBridgeImpl::run 
(this=0xf9c18550, rArgs=...) at 
/run/build/libreoffice/testtools/source/bridgetest/bridgetest.cxx:1162
> #12 0xd292a3ec in sal_main () at 
/run/build/libreoffice/cpputools/source/unoexe/unoexe.cxx:509
> #13 0xd29297a0 in

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sc/source

2019-10-17 Thread Caolán McNamara (via logerrit)

 sc/source/ui/inc/namedlg.hxx  |1 -
 sc/source/ui/inc/namemgrtable.hxx |   17 +
 sc/source/ui/namedlg/namedlg.cxx  |   10 ++
 sc/source/ui/namedlg/namemgrtable.cxx |   13 +++--
 4 files changed, 34 insertions(+), 7 deletions(-)

New commits:
commit 8f79126d4fb7014a81c799db776991d4c2d06fa2
Author: Caolán McNamara 
AuthorDate: Mon Oct 14 19:40:47 2019 +0100
Commit: Caolán McNamara 
CommitDate: Thu Oct 17 16:03:07 2019 +0200

Resolves: tdf#128137 cursor jumping during edit, etc.

The mbNeedUpdate hackery to block changes caused by the
user was subverted by the async handling of the treeview selection.

a) add a call to wait and process outstanding async events within
the protected block

b) move the needupdate down to the range manager to block updates during
this block in CheckForFormulaString too

c) when updating the visible rows, also update the selected rows even if 
they
are not visible.

Change-Id: I4c67d6cd2780f55d5eab5f856f6fda21703b4977
Reviewed-on: https://gerrit.libreoffice.org/80797
Tested-by: Jenkins
Tested-by: Xisco Faulí 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/source/ui/inc/namedlg.hxx b/sc/source/ui/inc/namedlg.hxx
index 09effbb234af..14149008dd90 100644
--- a/sc/source/ui/inc/namedlg.hxx
+++ b/sc/source/ui/inc/namedlg.hxx
@@ -46,7 +46,6 @@ private:
 ScDocument* mpDoc;
 const ScAddress maCursorPos;
 
-bool mbNeedUpdate;
 bool mbDataChanged;
 //ugly hack to call DefineNames from ManageNames
 bool mbCloseWithoutUndo;
diff --git a/sc/source/ui/inc/namemgrtable.hxx 
b/sc/source/ui/inc/namemgrtable.hxx
index 324ceef03657..d25a9e799d90 100644
--- a/sc/source/ui/inc/namemgrtable.hxx
+++ b/sc/source/ui/inc/namemgrtable.hxx
@@ -45,6 +45,8 @@ private:
 
 int m_nId;
 
+bool mbNeedUpdate;
+
 void GetLine(ScRangeNameLine& aLine, weld::TreeIter& rEntry);
 void Init();
 const ScRangeData* findRangeData(const ScRangeNameLine& rLine);
@@ -70,6 +72,21 @@ public:
 void GetCurrentLine(ScRangeNameLine& rLine);
 bool IsMultiSelection();
 std::vector GetSelectedEntries();
+
+void BlockUpdate()
+{
+mbNeedUpdate = false;
+}
+
+bool UpdatesBlocked() const
+{
+return !mbNeedUpdate;
+}
+
+void UnblockUpdate()
+{
+mbNeedUpdate = true;
+}
 };
 
 #endif
diff --git a/sc/source/ui/namedlg/namedlg.cxx b/sc/source/ui/namedlg/namedlg.cxx
index de92dedaa9be..cdb9e5b18077 100644
--- a/sc/source/ui/namedlg/namedlg.cxx
+++ b/sc/source/ui/namedlg/namedlg.cxx
@@ -33,6 +33,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 
@@ -55,7 +56,6 @@ ScNameDlg::ScNameDlg( SfxBindings* pB, SfxChildWindow* pCW, 
weld::Window* pParen
 , mpViewData(ptrViewData)
 , mpDoc(ptrViewData->GetDocument())
 , maCursorPos(aCursorPos)
-, mbNeedUpdate(true)
 , mbDataChanged(false)
 , mbCloseWithoutUndo(false)
 
@@ -379,7 +379,7 @@ void ScNameDlg::NameModified()
 sal_uInt16 nIndex = (aNewScope != aOldScope ? 0 : pData->GetIndex());
 
 pOldRangeName->erase(*pData);
-mbNeedUpdate = false;
+m_xRangeManagerTable->BlockUpdate();
 m_xRangeManagerTable->DeleteSelectedEntries();
 ScRangeData::Type nType = ScRangeData::Type::Name;
 if ( m_xBtnRowHeader->get_active() ) nType |= 
ScRangeData::Type::RowHeader;
@@ -395,7 +395,9 @@ void ScNameDlg::NameModified()
 aLine.aExpression = aExpr;
 aLine.aScope = aNewScope;
 m_xRangeManagerTable->addEntry(aLine, true);
-mbNeedUpdate = true;
+// tdf#128137 process pending async row change events while 
UpdatesBlocked in place
+Application::Reschedule(true);
+m_xRangeManagerTable->UnblockUpdate();
 mbDataChanged = true;
 }
 }
@@ -403,7 +405,7 @@ void ScNameDlg::NameModified()
 void ScNameDlg::SelectionChanged()
 {
 //don't update if we have just modified due to user input
-if (!mbNeedUpdate)
+if (m_xRangeManagerTable->UpdatesBlocked())
 {
 return;
 }
diff --git a/sc/source/ui/namedlg/namemgrtable.cxx 
b/sc/source/ui/namedlg/namemgrtable.cxx
index 9c4895a11a40..3567e9a94c72 100644
--- a/sc/source/ui/namedlg/namemgrtable.cxx
+++ b/sc/source/ui/namedlg/namemgrtable.cxx
@@ -60,6 +60,7 @@ 
ScRangeManagerTable::ScRangeManagerTable(std::unique_ptr xTreeVi
 , m_RangeMap(rRangeMap)
 , maPos( rPos )
 , m_nId(0)
+, mbNeedUpdate(true)
 {
 auto nColWidth = m_xTreeView->get_size_request().Width() / 7;
 std::vector aWidths;
@@ -91,7 +92,10 @@ const ScRangeData* ScRangeManagerTable::findRangeData(const 
ScRangeNameLine& rLi
 
 void ScRangeManagerTable::CheckForFormulaString()
 {
-m_xTreeView->visible_foreach([this](weld::TreeIter& rEntry){
+if (UpdatesBlocked())
+return;
+
+auto lambda = [this](weld::TreeIter& rEntry){

[Libreoffice-bugs] [Bug 128211] FILEOPEN DOCX Tracked changes appear accepted in header with Link to Previous set

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128211

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
Summary|ILEOPEN DOCX Tracked|FILEOPEN DOCX Tracked
   |changes appear accepted in  |changes appear accepted in
   |header with Link to |header with Link to
   |Previous set|Previous set

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 119139] Mysql timestamp fields not displayed in table data entry mode with mysql jdbc-connector ConnectorJ 8.x

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=119139

--- Comment #28 from Alex Thurgood  ---
Still not working with:

Version: 6.3.2.2
Build ID: 98b30e735bda24bc04ab42594c85f7fd8be07b9c
Threads CPU : 4; OS : Mac OS X 10.15; UI Render : par défaut; VCL: osx; 
Locale : fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR
Calc: threaded

and Mysql Connector/J 8.0.18

Any table that contains a timestamp field defined as :

timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP

does not display the timestamp field column or data held therein in the LO UI
in table data edit mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106638] FILEOPEN PPTX Arial (Corps) changed to Wingdings

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=106638

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||difficultyBeginner,
   ||skillCpp, topicDebug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/src

2019-10-17 Thread Tamás Zolnai (via logerrit)

 loleaflet/src/control/Control.Menubar.js |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit f4569760748bbf110464977f081c4c86a296b3e8
Author: Tamás Zolnai 
AuthorDate: Thu Oct 17 15:56:55 2019 +0200
Commit: Tamás Zolnai 
CommitDate: Thu Oct 17 15:56:55 2019 +0200

mobile-menu: Fix copy-paste error.

Change-Id: I428d3fbd09c878ed0d6ab819babaf7b44bdf364d

diff --git a/loleaflet/src/control/Control.Menubar.js 
b/loleaflet/src/control/Control.Menubar.js
index a13a44116..1f7ab55f1 100644
--- a/loleaflet/src/control/Control.Menubar.js
+++ b/loleaflet/src/control/Control.Menubar.js
@@ -549,9 +549,9 @@ L.Control.Menubar = L.Control.extend({
]},
{name: !window.ThisIsAMobileApp ? _('Download as') : 
_('Export as'), id:'downloadas', type: 'menu', menu: [
{name: _('PDF Document (.pdf)'), id: 
'downloadas-pdf', type: 'action'},
-   {name: _('ODF spreadsheet (.ods)'), id: 
'downloadas-ods', type: 'action'},
-   {name: _('Excel 2003 Spreadsheet (.xls)'), id: 
'downloadas-xls', type: 'action'},
-   {name: _('Excel Spreadsheet (.xlsx)'), id: 
'downloadas-xlsx', type: 'action'}
+   {name: _('ODF presentation (.odp)'), id: 
'downloadas-odp', type: 'action'},
+   {name: _('PowerPoint 2003 Presentation 
(.ppt)'), id: 'downloadas-ppt', type: 'action'},
+   {name: _('PowerPoint Presentation (.pptx)'), 
id: 'downloadas-pptx', type: 'action'},
]},
{name: _UNO('.uno:EditMenu', 'spreadsheet'), type: 
'menu', menu: [
{uno: '.uno:Undo'},
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

2019-10-17 Thread Stephan Bergmann (via logerrit)

 sc/source/filter/excel/impop.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 556832332ce2e26ec727d6dffebefe53786f84cd
Author: Stephan Bergmann 
AuthorDate: Thu Oct 17 15:06:44 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Thu Oct 17 15:54:46 2019 +0200

Don't use uninitialized memory when reading from the stream fails

Valgrind'ing CppunitTest_sc_filters_test failed with

> Conditional jump or move depends on uninitialised value(s)
>at 0x21175CE0: XclRange::GetColCount() const 
(/sc/source/filter/inc/xladdress.hxx:73)
>by 0x2117048D: ImportExcel::ReadDimensions() 
(/sc/source/filter/excel/impop.cxx:248)
>by 0x21188E78: ImportExcel8::Read() 
(/sc/source/filter/excel/read.cxx:1108)
>by 0x21123C3F: ScFormatFilterPluginImpl::ScImportExcel(SfxMedium&, 
ScDocument*, EXCIMPFORMAT) (/sc/source/filter/excel/excel.cxx:137)
[...]

when loading sc/qa/unit/data/xls/pass/CVE-2006-3086-1.xls.

As there appears to be no error-handling concept in 
ImportExcel::ReadDimensions,
at least zero-initialize the relevant variables.

Change-Id: I11dbd2a1032ecc723f65a563ef022d7eb3c970ff
Reviewed-on: https://gerrit.libreoffice.org/80948
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sc/source/filter/excel/impop.cxx b/sc/source/filter/excel/impop.cxx
index 1bebd26143bf..03c6c73706f4 100644
--- a/sc/source/filter/excel/impop.cxx
+++ b/sc/source/filter/excel/impop.cxx
@@ -222,7 +222,7 @@ sal_uInt16 ImportExcel::ReadXFIndex( const ScAddress& 
rScPos, bool bBiff2 )
 
 void ImportExcel::ReadDimensions()
 {
-XclRange aXclUsedArea( ScAddress::UNINITIALIZED );
+XclRange aXclUsedArea;
 if( (maStrm.GetRecId() == EXC_ID2_DIMENSIONS) || (GetBiff() <= EXC_BIFF5) )
 {
 maStrm >> aXclUsedArea;
@@ -240,7 +240,7 @@ void ImportExcel::ReadDimensions()
 }
 else
 {
-sal_uInt32 nXclRow1, nXclRow2;
+sal_uInt32 nXclRow1 = 0, nXclRow2 = 0;
 nXclRow1 = maStrm.ReaduInt32();
 nXclRow2 = maStrm.ReaduInt32();
 aXclUsedArea.maFirst.mnCol = maStrm.ReaduInt16();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

2019-10-17 Thread Stephan Bergmann (via logerrit)

 sc/source/filter/qpro/qproform.cxx |   14 +-
 1 file changed, 9 insertions(+), 5 deletions(-)

New commits:
commit 2704b9e3783aae9d8372f2e3ad3253a2cb49ae87
Author: Stephan Bergmann 
AuthorDate: Thu Oct 17 14:52:16 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Thu Oct 17 15:53:08 2019 +0200

Don't use uninitialized memory when reading from the stream fails

Flathub arm builds (but not other arches) had often (but not always) failed 
when
processing sc/qa/unit/data/qpro/pass/ofz14090-1.wb2 in
CppunitTest_sc_filters_test (e.g.,
:

> Test name: ScFiltersTest::testCVEs
> equality assertion failed
> - Expected: 1
> - Actual  : 0
> - file:///run/build/libreoffice/sc/qa/unit/data/qpro/pass/ofz14090-1.wb2

)  Valgrind revealed that this was due to using unintialized memory when the
various maIn.Read... in QProToSc::Convert failed, starting with the use of
uninitialized nFmla[i] after

  maIn.ReadUChar( nFmla[i] );

At least make things deterministic by setting the relevant variables to 
zero.
(Another approach could be returning early with some ConvErr status.)

Change-Id: I4c06aa8da5f777170cdc7bbe3ca1d61b23d3f326
Reviewed-on: https://gerrit.libreoffice.org/80947
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sc/source/filter/qpro/qproform.cxx 
b/sc/source/filter/qpro/qproform.cxx
index 89904a27d49c..0d8bc41426f2 100644
--- a/sc/source/filter/qpro/qproform.cxx
+++ b/sc/source/filter/qpro/qproform.cxx
@@ -190,15 +190,14 @@ do { \
 
 ConvErr QProToSc::Convert( std::unique_ptr& pArray )
 {
-sal_uInt8 nFmla[ nBufSize ], nArg;
+sal_uInt8 nFmla[ nBufSize ];
 sal_uInt8 nArgArray[ nBufSize ] = {0};
 sal_Int8 nCol, nPage;
-sal_uInt16 nInt, nIntCount = 0, nStringCount = 0, nFloatCount = 0, 
nDLLCount = 0, nArgCount = 0;
+sal_uInt16 nIntCount = 0, nStringCount = 0, nFloatCount = 0, nDLLCount = 
0, nArgCount = 0;
 sal_uInt16 nIntArray[ nBufSize ] = {0};
 OUString sStringArray[ nBufSize ];
-sal_uInt16 nDummy, nDLLId;
 sal_uInt16 nDLLArray[ nBufSize ] = {0};
-sal_uInt16 nNote, nRef, nRelBits;
+sal_uInt16 nNote, nRelBits;
 TokenId nPush;
 ScComplexRefData aCRD;
 ScSingleRefData aSRD;
@@ -209,16 +208,19 @@ ConvErr QProToSc::Convert( std::unique_ptr& 
pArray )
 
 aCRD.InitFlags();
 aSRD.InitFlags();
+sal_uInt16 nRef = 0;
 maIn.ReadUInt16( nRef );
 
 if( nRef < nBufSize )
 {
 for( sal_uInt16 i=0; i < nRef; i++)
 {
+nFmla[i] = 0;
 maIn.ReadUChar( nFmla[i] );
 
 if( nFmla[ i ] == 0x05 )
 {
+sal_uInt16 nInt = 0;
 maIn.ReadUInt16( nInt );
 nIntArray[ nIntCount ] = nInt;
 SAFEDEC_OR_RET(nRef, 2, ConvErr::Count);
@@ -227,7 +229,7 @@ ConvErr QProToSc::Convert( std::unique_ptr& 
pArray )
 
 if( nFmla[ i ] == 0x00 )
 {
-double nFloat;
+double nFloat = 0;
 maIn.ReadDouble( nFloat );
 nFloatArray[ nFloatCount ] = nFloat;
 SAFEDEC_OR_RET(nRef, 8, ConvErr::Count);
@@ -236,6 +238,8 @@ ConvErr QProToSc::Convert( std::unique_ptr& 
pArray )
 
 if( nFmla[ i ] == 0x1a )
 {
+sal_uInt8 nArg = 0;
+sal_uInt16 nDummy, nDLLId = 0;
 maIn.ReadUChar( nArg ).ReadUInt16( nDummy ).ReadUInt16( nDLLId 
);
 nArgArray[ nArgCount ] = nArg;
 nDLLArray[ nDLLCount ] = nDLLId;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 52926] Format changes from "#10 Envelope" to "User" with different height, margin-top, and offset (Canon & Brother printers)

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=52926

--- Comment #17 from ecomer  ---
I have changed printer since my original post, although it is also a Brother. I
still see the same problem where #10 envelope opens as a "User" size instead of
the #10 envelope.

My current LibreOffice about box is:
Version: 6.3.2.2
Build ID: 6.3.2-2
CPU threads: 2; OS: Linux 5.3; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.utf8); UI-Language: en-US
Calc: threaded

lpinfo --make-and-model "Brother MFC-L2710DW series" -m
driverless:ipp://BRW485F9924BB66.local:631/ipp/print Brother MFC-L2710DW
series, driverless, cups-filters 1.25.11
everywhere IPP Everywhere

$ uname -a
Linux asrock 5.3.6-1-MANJARO #1 SMP PREEMPT Sat Oct 12 09:30:05 UTC 2019 x86_64
GNU/Linux

$ lsb_release -a
LSB Version:n/a
Distributor ID: ManjaroLinux
Description:Manjaro Linux
Release:18.1.1
Codename:   Juhraya

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3-3' - sw/source

2019-10-17 Thread Michael Stahl (via logerrit)

 sw/source/core/crsr/findattr.cxx |9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

New commits:
commit 9a5fd659873450a59309f71082a67fa9e74fcf47
Author: Michael Stahl 
AuthorDate: Mon Oct 14 14:56:48 2019 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu Oct 17 15:52:09 2019 +0200

tdf#128138 sw_redlinehide: fix infinite loop in FindAttrsImpl()

The code looked wrong previously, always assigning the end of the text
node regardless of direction, but it turns out the improvement caused an
infinite loop... let's just swap things after the loop, seems simpler
than adding another if at the assignments.

(regression from 4caef398af256be5f0c2a159129b528ee3702e5c)

Change-Id: I098f5265fa86d6a2511a80a02230899a7a303a88
Reviewed-on: https://gerrit.libreoffice.org/80774
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 4e0241697371c40f4348bdfb6585a872d4cbcbf6)
Reviewed-on: https://gerrit.libreoffice.org/80876
Reviewed-by: Xisco Faulí 
Reviewed-by: Michael Weghorn 
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/sw/source/core/crsr/findattr.cxx b/sw/source/core/crsr/findattr.cxx
index c77dc2065979..47c1f676ecb5 100644
--- a/sw/source/core/crsr/findattr.cxx
+++ b/sw/source/core/crsr/findattr.cxx
@@ -1198,9 +1198,12 @@ static bool FindAttrsImpl(SwPaM & rSearchPam,
 }
 }
 
-// if backward search, switch point and mark
-if( bFound && !bSrchForward )
-rSearchPam.Exchange();
+// in search direction, mark precedes point, because the next iteration
+// starts at point
+if (bFound)
+{
+rSearchPam.Normalize(!bSrchForward);
+}
 
 return bFound;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106638] FILEOPEN PPTX Arial (Corps) changed to Wingdings

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=106638

Mark Hung  changed:

   What|Removed |Added

   Keywords||easyHack

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126409] LibreOffice does not launch normally on macOS 10.15 Catalina

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=126409

--- Comment #25 from Alex Thurgood  ---
(In reply to Christian Lohmaier from comment #24)

In syslog, I also see multiple entries for :

Oct 17 14:25:10 MACMINIMMO soffice[16610]: assertion failed: 19A602:
libxpc.dylib + 86780 [2E9076CD-6C0E-38B6-8403-B2DDCE125FBF]: 0x89
Oct 17 14:26:05 MACMINIMMO soffice[16616]: assertion failed: 19A602:
libxpc.dylib + 86780 [2E9076CD-6C0E-38B6-8403-B2DDCE125FBF]: 0x89
Oct 17 14:27:25 MACMINIMMO soffice[16635]: assertion failed: 19A602:
libxpc.dylib + 86780 [2E9076CD-6C0E-38B6-8403-B2DDCE125FBF]: 0x89

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128200] Wrong translations of formula function names and identifiers

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128200

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #2 from Xisco Faulí  ---
Hi Eike,
is it something you're working on? Otherwsise, can we turn it into an easyhack
?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128086] Some icons of GUI elements are missing in the iOS app

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128086

Tor Lillqvist  changed:

   What|Removed |Added

 CC||t...@iki.fi

--- Comment #3 from Tor Lillqvist  ---
Yep, even more "branding" SVG files were missing. Will be present in the next
build.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123325] FILEOPEN | DOCX, Shape text loses its rotation and resizes shape.

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=123325

--- Comment #6 from Xisco Faulí  ---
(In reply to NISZ LibreOffice Team from comment #5)
> Created attachment 155089 [details]
> Screenshot of the document in current Writer master
> 
> Indeed the rotation is fine. In current master only the text box size is
> larger than expected.
> 
> Version: 6.4.0.0.alpha0+ (x64)
> Build ID: 137e14ec4c3d3258df3802426b5ffe469f7fbde3
> CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; 
> Locale: hu-HU (hu_HU); UI-Language: en-US
> Calc: CL

Not sure if it's already reported.
Could you please check? if not, could you please create a new report ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/sot sot/source

2019-10-17 Thread Caolán McNamara (via logerrit)

 include/sot/stg.hxx  |1 
 sot/source/sdstor/storage.cxx|   15 ++---
 sot/source/sdstor/ucbstorage.cxx |   42 ++-
 3 files changed, 6 insertions(+), 52 deletions(-)

New commits:
commit 6a8a73566c475c945e45e40e269765959d93164d
Author: Caolán McNamara 
AuthorDate: Thu Oct 17 13:08:01 2019 +0100
Commit: Caolán McNamara 
CommitDate: Thu Oct 17 15:30:51 2019 +0200

ofz#18280 remove LinkedFile support

The code to create these "linked files" added by:

commit 6f2f7e3091504e8e58d9be603ed3739f6f2cd68e
Author: Mathias Bauer 
Date:   Fri Jul 6 14:03:59 2001 +

#89377#: new StorageMode for creating unpacked files

use of creating them then introduced in:

commit 53fe2691a3fb65110e7f5aee2919f7d8d559ff02
Author: Mathias Bauer 
Date:   Fri Jul 6 13:55:57 2001 +

#88062#: some optimizations

that use then commented out in:

commit 762dd2b15bfd201b2271b460efa72a5b68d6fb2a
Author: Kurt Zenker 
Date:   Mon Oct 4 19:53:11 2004 +

and the unused code to create them removed in:

commit 8a91528a3e03fe6e2923c33327b687ecf57adb0b
Author: Stephan Bergmann 
Date:   Thu May 7 10:37:27 2015 +0200

StorageMode::CreateUnpacked is never used

It seems to me that there is no need to keep support for reading them as 
they
seem to have been temporary files rather than something still existant

Change-Id: I783cae63dc078a7e843729d3ca13f45c18168f4c
Reviewed-on: https://gerrit.libreoffice.org/80943
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/include/sot/stg.hxx b/include/sot/stg.hxx
index d692403b9a72..32bd476422f9 100644
--- a/include/sot/stg.hxx
+++ b/include/sot/stg.hxx
@@ -246,7 +246,6 @@ protected:
 virtual ~UCBStorage() override;
 public:
 static bool IsStorageFile( SvStream* );
-static OUString GetLinkedFile( SvStream& );
 
 UCBStorage( const ::ucbhelper::Content& 
rContent,
 const OUString& rName,
diff --git a/sot/source/sdstor/storage.cxx b/sot/source/sdstor/storage.cxx
index 16d1a976b577..f15fb22dd9f1 100644
--- a/sot/source/sdstor/storage.cxx
+++ b/sot/source/sdstor/storage.cxx
@@ -318,18 +318,9 @@ void SotStorage::CreateStorage( bool bForceUCBStorage, 
StreamMode nMode )
 
 if ( bIsUCBStorage )
 {
-if ( !(UCBStorage::GetLinkedFile( *m_pStorStm ).isEmpty()) )
-{
-// detect special unpacked storages
-m_pOwnStg = new UCBStorage( *m_pStorStm, true );
-m_bDelStm = true;
-}
-else
-{
-// UCBStorage always works directly on the UCB content, so 
discard the stream first
-DELETEZ( m_pStorStm );
-m_pOwnStg = new UCBStorage( m_aName, nMode, true, 
true/*bIsRoot*/ );
-}
+// UCBStorage always works directly on the UCB content, so 
discard the stream first
+DELETEZ( m_pStorStm );
+m_pOwnStg = new UCBStorage( m_aName, nMode, true, 
true/*bIsRoot*/ );
 }
 else
 {
diff --git a/sot/source/sdstor/ucbstorage.cxx b/sot/source/sdstor/ucbstorage.cxx
index 5edae19704cb..5340f841454c 100644
--- a/sot/source/sdstor/ucbstorage.cxx
+++ b/sot/source/sdstor/ucbstorage.cxx
@@ -1363,22 +1363,9 @@ sal_uLong UCBStorageStream::GetSize() const
 
 UCBStorage::UCBStorage( SvStream& rStrm, bool bDirect )
 {
-OUString aURL = GetLinkedFile( rStrm );
-if ( !aURL.isEmpty() )
-{
-StreamMode nMode = StreamMode::READ;
-if( rStrm.IsWritable() )
-nMode = StreamMode::READ | StreamMode::WRITE;
-
-::ucbhelper::Content aContent( aURL, Reference < XCommandEnvironment 
>(), comphelper::getProcessComponentContext() );
-pImp = new UCBStorage_Impl( aContent, aURL, nMode, this, bDirect, true 
);
-}
-else
-{
-// pImp must be initialized in the body, because otherwise the vtable 
of the stream is not initialized
-// to class UCBStorage !
-pImp = new UCBStorage_Impl( rStrm, this, bDirect );
-}
+// pImp must be initialized in the body, because otherwise the vtable of 
the stream is not initialized
+// to class UCBStorage !
+pImp = new UCBStorage_Impl( rStrm, this, bDirect );
 
 pImp->AddFirstRef();
 pImp->Init();
@@ -2870,27 +2857,4 @@ bool UCBStorage::IsStorageFile( SvStream* pFile )
 return bRet;
 }
 
-OUString UCBStorage::GetLinkedFile( SvStream  )
-{
-OUString aString;
-sal_uInt64 nPos = rStream.Tell();
-if ( !rStream.TellEnd() )
-return aString;
-
-rStream.Seek(0);
-sal_uInt32 nBytes;
-

[Libreoffice-bugs] [Bug 127979] Spanish translation is missing in LO Draw 6.3.2.2, Spanish Version, View Menu> User Interface Sub-Menu> options: “Tabbed Compact” and “Contextual Single”

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=127979

--- Comment #5 from Julien Nabet  ---
Sophie gave me rights to make the change on Weblate, I put:
"Contextual, sencilla" since there was a first translation like this.
and "Contextual single".

See https://weblate.documentfoundation.org/languages/es/libo_ui-master/#history

BTW, I don't know if it's replicated in sub "es", like es_US, es_419, etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123325] FILEOPEN | DOCX, Shape text loses its rotation and resizes shape.

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=123325

--- Comment #5 from NISZ LibreOffice Team  ---
Created attachment 155089
  --> https://bugs.documentfoundation.org/attachment.cgi?id=155089=edit
Screenshot of the document in current Writer master

Indeed the rotation is fine. In current master only the text box size is larger
than expected.

Version: 6.4.0.0.alpha0+ (x64)
Build ID: 137e14ec4c3d3258df3802426b5ffe469f7fbde3
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; 
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127950] iOS (regression): table resize handles not visible

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=127950

--- Comment #7 from Tor Lillqvist  ---
Ah, the problem was missing "branding" SVG files for the resize handles, as
Nicolas guessed. The way the "branding" of the app is set up is somewhat
ad-hoc, and the branding is kept in a different repository, which explains why
even when building core and online from the exact commits in 4.1.61, the
handles still did not show up. Will be present again in future builds.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124107] [META] Problem with Apple iWork Office Suite files

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=124107

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||128187


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=128187
[Bug 128187] Offer to open AppleWorks documents (.cwk /
application/x-appleworks-document)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 119808] FILEOPEN DOCX Chart title custom position reset to centered

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=119808

Balázs Varga  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |balazs.varga...@gmail.com
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128187] Offer to open AppleWorks documents (.cwk / application/x-appleworks-document)

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128187

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||124107


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=124107
[Bug 124107] [META] Problem with Apple iWork Office Suite files
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124588] FILEOPEN DOC DOCX RTF: U+00AD should not be treated as soft hyphen in Word documents

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=124588

--- Comment #9 from Khaled Hosny  ---
(In reply to Xisco Faulí from comment #8)
> @Khaled, I thought you might be interested in this issue...

What Word doing is not Unicode-conformant and is probably some legacy behavior
kept for backward compatibility. What LibreOffice should do when reading Word
files is not something I’m qualified to answer.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113213] "Resume numbering" does not cancel "restart numbering" on enumerated list

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113213

--- Comment #7 from Ulrich Windl  ---
Created attachment 155088
  --> https://bugs.documentfoundation.org/attachment.cgi?id=155088=edit
Example document

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128212] FILEOPEN PPTX text with z-Rotation has wrong position

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128212

Regina Henschel  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||6060

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104526] [META] DOCX (OOXML) formula-related issues

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104526

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||128205


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=128205
[Bug 128205] FILEOPEN: DOCX: Formula frame's alignment not imported
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128205] FILEOPEN: DOCX: Formula frame's alignment not imported

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128205

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
 Status|UNCONFIRMED |NEW
 Blocks||104526
 Ever confirmed|0   |1

--- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> ---
confirm in

Версия: 6.4.0.0.alpha0+ (x64)
ID сборки: ccfbe8b478f3daa8b5ec07a7e48dd5fbf8556811
Потоков ЦП: 4; ОС:Windows 10.0 Build 18362; Отрисовка ИП: по умолчанию; VCL:
win; 
Локаль: ru-RU (ru_RU); Язык интерфейса: ru-RU
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104526
[Bug 104526] [META] DOCX (OOXML) formula-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128213] FILESAVE PPTX roundtrip with z-rotated text produces additional shape rotation

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128213

Regina Henschel  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||6060

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128210] EDITING: Crash in: SfxItemSet::Get(unsigned short, bool)

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128210

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||79045_79...@mail.ru

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
Can you update your LibreOffice to 6.2.8 or 6.3.3 version and try retest your
problem?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128194] [META] DOCX: Aggressive Competitors

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128194

--- Comment #1 from Xisco Faulí  ---
First round of issues done.
Once they are fixed, the should look pretty much the same

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128213] New: FILESAVE PPTX roundtrip with z-rotated text produces additional shape rotation

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128213

Bug ID: 128213
   Summary: FILESAVE PPTX roundtrip with z-rotated text produces
additional shape rotation
   Product: LibreOffice
   Version: 6.4.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Created attachment 155087
  --> https://bugs.documentfoundation.org/attachment.cgi?id=155087=edit
VerticalByZrotation.pptx contains shape with z-rotation of the text

Open attached file and resave it immediately to pptx without any changes. Open
the resulted file and the original file in PowerPoint and compare.
Error: The rectangle is rotated.

(The wrong text position is in bug 128216.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82627] FILEOPEN DOCX: Text Not Rotated in Text Boxes with Rotation

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=82627

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
 OS|Windows (All)   |All
 Blocks||128194
   Hardware|Other   |All


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=128194
[Bug 128194] [META] DOCX: Aggressive Competitors
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128194] [META] DOCX: Aggressive Competitors

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128194

Xisco Faulí  changed:

   What|Removed |Added

 Depends on||82627


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=82627
[Bug 82627] FILEOPEN DOCX: Text Not Rotated in Text Boxes with Rotation
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104449] [META] DOCX (OOXML) textbox-related issues

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104449
Bug 104449 depends on bug 121515, which changed state.

Bug 121515 Summary: DOCX TextBox in Shape is not rotated
https://bugs.documentfoundation.org/show_bug.cgi?id=121515

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82627] FILEOPEN DOCX: Text Not Rotated in Text Boxes with Rotation

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=82627

--- Comment #13 from Xisco Faulí  ---
*** Bug 121515 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128194] [META] DOCX: Aggressive Competitors

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128194

Xisco Faulí  changed:

   What|Removed |Added

 Depends on|121515  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121515
[Bug 121515] DOCX TextBox in Shape is not rotated
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121515] DOCX TextBox in Shape is not rotated

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121515

Xisco Faulí  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Blocks|128194  |
 Status|NEW |RESOLVED

--- Comment #7 from Xisco Faulí  ---
This clearly seems like a dupe of bug 82627

*** This bug has been marked as a duplicate of bug 82627 ***


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=128194
[Bug 128194] [META] DOCX: Aggressive Competitors
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121515] DOCX TextBox in Shape is not rotated

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121515

Xisco Faulí  changed:

   What|Removed |Added

 Blocks||128194


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=128194
[Bug 128194] [META] DOCX: Aggressive Competitors
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128194] [META] DOCX: Aggressive Competitors

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128194

Xisco Faulí  changed:

   What|Removed |Added

 Depends on||121515


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121515
[Bug 121515] DOCX TextBox in Shape is not rotated
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121515] DOCX TextBox in Shape is not rotated

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121515

--- Comment #6 from Xisco Faulí  ---
Created attachment 155086
  --> https://bugs.documentfoundation.org/attachment.cgi?id=155086=edit
another sample

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105875] FILEOPEN: DOCX: Shape rotation is wrong (see comment 3)

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105875

--- Comment #6 from Xisco Faulí  ---
Still reproducible in

Version: 6.4.0.0.alpha1+
Build ID: 01d28b0b85f99590c0581e4bbf636bc9281e0571
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128212] New: FILEOPEN PPTX text with z-Rotation has wrong position

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128212

Bug ID: 128212
   Summary: FILEOPEN PPTX text with z-Rotation has wrong position
   Product: LibreOffice
   Version: 6.4.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Created attachment 155085
  --> https://bugs.documentfoundation.org/attachment.cgi?id=155085=edit
VerticalByZrotation.pptx contains shape and image

This is a followup to bug 126060, where import of the z-rotation of the 3D text
transformation was implemented.

Open attached file. On the left side is the shape, where the text has been
rotated by z-Rotation. On the right side is an image, who it looks in
PowerPoint.

Error: The text is rotated but has a wrong position.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123325] FILEOPEN | DOCX, Shape text loses its rotation and resizes shape.

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=123325

Xisco Faulí  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128208] OOoSpotlightImporter.mdimporter causes segfault in mdworker macOS 10.15 Catalina with particular empty ODB file

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128208

--- Comment #3 from Alex Thurgood  ---
Created attachment 155084
  --> https://bugs.documentfoundation.org/attachment.cgi?id=155084=edit
Crash log

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104442] [META] DOCX (OOXML) shape (DrawingML and VML) related issues

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104442
Bug 104442 depends on bug 123325, which changed state.

Bug 123325 Summary: FILEOPEN | DOCX, Shape text loses its rotation and resizes 
shape.
https://bugs.documentfoundation.org/show_bug.cgi?id=123325

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123325] FILEOPEN | DOCX, Shape text loses its rotation and resizes shape.

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=123325

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #4 from Xisco Faulí  ---
Text rotation fixed in

Versión: 6.3.3.1 (x86)
Id. de compilación: f41f4c7f9507aeca13cb9df51f34d80e8ba30a99
Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; VCL: win; 
Configuración regional: es-ES (es_ES); Idioma de IU: es-ES
Calc: threaded

Closing as RESOLVED WORKSFORME

Most likely related to bug 127825

*** This bug has been marked as a duplicate of bug 127825 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - chart2/source solenv/clang-format

2019-10-17 Thread Muhammet Kara (via logerrit)

 chart2/source/controller/dialogs/ChangingResource.cxx  |2 +-
 chart2/source/controller/dialogs/ChartTypeDialogController.cxx |2 +-
 chart2/source/controller/dialogs/dlg_CreationWizard.cxx|2 +-
 chart2/source/controller/dialogs/dlg_DataSource.cxx|2 +-
 chart2/source/controller/dialogs/tp_ChartType.hxx  |4 ++--
 chart2/source/controller/dialogs/tp_DataSource.cxx |2 +-
 chart2/source/controller/dialogs/tp_RangeChooser.cxx   |2 +-
 chart2/source/inc/ChartTypeDialogController.hxx|2 +-
 solenv/clang-format/blacklist  |6 +++---
 9 files changed, 12 insertions(+), 12 deletions(-)

New commits:
commit 6f7034aa89c75b705b2e575493cbc82ab37d8299
Author: Muhammet Kara 
AuthorDate: Wed Oct 16 22:05:18 2019 +0300
Commit: Muhammet Kara 
CommitDate: Thu Oct 17 14:45:28 2019 +0200

chart2: Move some headers to inc

So that they will be accessible from
inside the sidebar dir.

Change-Id: Iaf7b1a800a3b35a5c497d8122f68c97c8cdc9eff
Reviewed-on: https://gerrit.libreoffice.org/80922
Reviewed-by: Muhammet Kara 
Tested-by: Muhammet Kara 

diff --git a/chart2/source/controller/dialogs/ChangingResource.cxx 
b/chart2/source/controller/dialogs/ChangingResource.cxx
index 6e1ba1c67274..c50f274dadd4 100644
--- a/chart2/source/controller/dialogs/ChangingResource.cxx
+++ b/chart2/source/controller/dialogs/ChangingResource.cxx
@@ -17,7 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include "ChangingResource.hxx"
+#include 
 
 namespace chart
 {
diff --git a/chart2/source/controller/dialogs/ChartTypeDialogController.cxx 
b/chart2/source/controller/dialogs/ChartTypeDialogController.cxx
index 56a7a2173c88..3c34c96982f3 100644
--- a/chart2/source/controller/dialogs/ChartTypeDialogController.cxx
+++ b/chart2/source/controller/dialogs/ChartTypeDialogController.cxx
@@ -17,7 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include "ChartTypeDialogController.hxx"
+#include 
 #include 
 #include 
 #include 
diff --git a/chart2/source/controller/dialogs/dlg_CreationWizard.cxx 
b/chart2/source/controller/dialogs/dlg_CreationWizard.cxx
index c9da0b2227e7..60fbf69c289a 100644
--- a/chart2/source/controller/dialogs/dlg_CreationWizard.cxx
+++ b/chart2/source/controller/dialogs/dlg_CreationWizard.cxx
@@ -27,7 +27,7 @@
 #include "tp_RangeChooser.hxx"
 #include "tp_Wizard_TitlesAndObjects.hxx"
 #include "tp_DataSource.hxx"
-#include "ChartTypeTemplateProvider.hxx"
+#include 
 #include "DialogModel.hxx"
 
 #define CHART_WIZARD_PAGEWIDTH  250
diff --git a/chart2/source/controller/dialogs/dlg_DataSource.cxx 
b/chart2/source/controller/dialogs/dlg_DataSource.cxx
index 86651bcfd6bd..fdbafd92b693 100644
--- a/chart2/source/controller/dialogs/dlg_DataSource.cxx
+++ b/chart2/source/controller/dialogs/dlg_DataSource.cxx
@@ -20,7 +20,7 @@
 #include 
 #include 
 #include 
-#include "ChartTypeTemplateProvider.hxx"
+#include 
 #include 
 #include 
 #include "DialogModel.hxx"
diff --git a/chart2/source/controller/dialogs/tp_ChartType.hxx 
b/chart2/source/controller/dialogs/tp_ChartType.hxx
index 4470ed60443d..22b354a22ad3 100644
--- a/chart2/source/controller/dialogs/tp_ChartType.hxx
+++ b/chart2/source/controller/dialogs/tp_ChartType.hxx
@@ -22,8 +22,8 @@
 
 #include 
 
-#include "ChartTypeDialogController.hxx"
-#include "ChartTypeTemplateProvider.hxx"
+#include 
+#include 
 #include 
 
 #include 
diff --git a/chart2/source/controller/dialogs/tp_DataSource.cxx 
b/chart2/source/controller/dialogs/tp_DataSource.cxx
index 758664428019..16c2d7f59222 100644
--- a/chart2/source/controller/dialogs/tp_DataSource.cxx
+++ b/chart2/source/controller/dialogs/tp_DataSource.cxx
@@ -21,7 +21,7 @@
 #include 
 #include 
 #include 
-#include "ChartTypeTemplateProvider.hxx"
+#include 
 #include 
 #include 
 #include 
diff --git a/chart2/source/controller/dialogs/tp_RangeChooser.cxx 
b/chart2/source/controller/dialogs/tp_RangeChooser.cxx
index 130ab64df371..c809f757125d 100644
--- a/chart2/source/controller/dialogs/tp_RangeChooser.cxx
+++ b/chart2/source/controller/dialogs/tp_RangeChooser.cxx
@@ -20,7 +20,7 @@
 #include "tp_RangeChooser.hxx"
 #include 
 #include 
-#include "ChartTypeTemplateProvider.hxx"
+#include 
 #include "DialogModel.hxx"
 #include 
 #include 
diff --git a/chart2/source/controller/dialogs/ChangingResource.hxx 
b/chart2/source/inc/ChangingResource.hxx
similarity index 100%
rename from chart2/source/controller/dialogs/ChangingResource.hxx
rename to chart2/source/inc/ChangingResource.hxx
diff --git a/chart2/source/controller/dialogs/ChartTypeDialogController.hxx 
b/chart2/source/inc/ChartTypeDialogController.hxx
similarity index 99%
rename from chart2/source/controller/dialogs/ChartTypeDialogController.hxx
rename to chart2/source/inc/ChartTypeDialogController.hxx
index 2985d31b10db..4a38768e9f77 100644
---

[Libreoffice-bugs] [Bug 115709] [META] DOCX (OOXML) Tracking changes-related issues

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115709

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Depends on||128211


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=128211
[Bug 128211] ILEOPEN DOCX Tracked changes appear accepted in header with Link
to Previous set
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128211] ILEOPEN DOCX Tracked changes appear accepted in header with Link to Previous set

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128211

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Blocks||115709
 CC||kelem...@ubuntu.com,
   ||nem...@numbertext.org


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115709
[Bug 115709] [META] DOCX (OOXML) Tracking changes-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128211] ILEOPEN DOCX Tracked changes appear accepted in header with Link to Previous set

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128211

--- Comment #2 from NISZ LibreOffice Team  ---
Created attachment 155082
  --> https://bugs.documentfoundation.org/attachment.cgi?id=155082=edit
Screenshot of the original document in Word

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128211] ILEOPEN DOCX Tracked changes appear accepted in header with Link to Previous set

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128211

--- Comment #3 from NISZ LibreOffice Team  ---
Created attachment 155083
  --> https://bugs.documentfoundation.org/attachment.cgi?id=155083=edit
Screenshot of the original document in Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128211] New: ILEOPEN DOCX Tracked changes appear accepted in header with Link to Previous set

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128211

Bug ID: 128211
   Summary: ILEOPEN DOCX Tracked changes appear accepted in header
with Link to Previous set
   Product: LibreOffice
   Version: 6.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: libreoff...@nisz.hu

Description:
Attached document contains change tracked text in the first pages header and
footer. The second pages header and footer has the “Link to Previous” setting
turned on in Word, which makes the change tracked texts of the first page
appear in the second pages header/footer too.
In Writer the text in the second pages header/footer is not marked as change
tracked, unlike in the first or third pages header/footer.

Steps to Reproduce:
1. Create a multi page document in Word with header / footer enabled
2. Add two Section breaks of type New Page to the first and the second page
3. Set the second pages header / footer to Linked to Previous, but unlink
the third
4. Enable change tracking and add some text to the first pages header /
footer
5. The second pages header / footer will contain the same text as tracked
change. Add some text to the third pages header / footer too
6. Save the file and open it in Writer

Actual Results:
The second pages header/footer contains the same text as the first but not as
tracked change.


Expected Results:
The second pages header/footer contains the text as tracked change.


Reproducible: Always


User Profile Reset: No



Additional Info:
LibreOffice details:
Version: 6.4.0.0.alpha1+ (x86)
Build ID: f0340d58cc0f2808ce8003099ff2a0495360f267
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; 
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128211] ILEOPEN DOCX Tracked changes appear accepted in header with Link to Previous set

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128211

--- Comment #1 from NISZ LibreOffice Team  ---
Created attachment 155081
  --> https://bugs.documentfoundation.org/attachment.cgi?id=155081=edit
Example file from Word

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127950] iOS (regression): table resize handles not visible

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=127950

--- Comment #6 from Tor Lillqvist  ---
Weird. If I build the app, core and online parts, from exactly the same commits
as in 4.1.61, I still don't get the resize handles.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: extras/source include/svx solenv/bin svx/source

2019-10-17 Thread Caolán McNamara (via logerrit)

 extras/source/glade/libreoffice-catalog.xml.in |4 -
 include/svx/langbox.hxx|   18 --
 solenv/bin/native-code.py  |1 
 svx/source/dialog/langbox.cxx  |   70 -
 4 files changed, 93 deletions(-)

New commits:
commit 6a902b238324d4d0c3c45819c2b23e6973d40a29
Author: Caolán McNamara 
AuthorDate: Mon Oct 14 11:22:46 2019 +0100
Commit: Caolán McNamara 
CommitDate: Thu Oct 17 14:35:57 2019 +0200

SvxLanguageBox is now unused

Change-Id: I5aafb53bb9885b8b0b43161f1afc79852b1d89a3
Reviewed-on: https://gerrit.libreoffice.org/80767
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/extras/source/glade/libreoffice-catalog.xml.in 
b/extras/source/glade/libreoffice-catalog.xml.in
index 4ecc596ffec1..a370ccbf8041 100644
--- a/extras/source/glade/libreoffice-catalog.xml.in
+++ b/extras/source/glade/libreoffice-catalog.xml.in
@@ -136,10 +136,6 @@
 generic-name="PropertyControl" parent="GtkComboBoxText"
 icon-name="widget-gtk-comboboxtext"/>
 
-
-
 
diff --git a/include/svx/langbox.hxx b/include/svx/langbox.hxx
index 9f93df3ea341..ad686bf39cd0 100644
--- a/include/svx/langbox.hxx
+++ b/include/svx/langbox.hxx
@@ -89,24 +89,6 @@ protected:
 SVX_DLLPRIVATE virtual sal_Int32ImplGetEntryPos( const void* pData ) 
const = 0;
 };
 
-
-class SVX_DLLPUBLIC SvxLanguageBox : public ListBox, public SvxLanguageBoxBase
-{
-public:
-SvxLanguageBox( vcl::Window* pParent, WinBits nBits );
-
-private:
-SVX_DLLPRIVATE virtual sal_Int32ImplInsertImgEntry( const OUString& 
rEntry, sal_Int32  nPos, bool bChecked ) override;
-
-SVX_DLLPRIVATE virtual void ImplClear() override;
-SVX_DLLPRIVATE virtual sal_Int32ImplInsertEntry( const OUString& 
rEntry, sal_Int32 nPos ) override;
-SVX_DLLPRIVATE virtual void ImplSetEntryData( sal_Int32 nPos, 
void* pData ) override;
-SVX_DLLPRIVATE virtual sal_Int32ImplGetSelectedEntryPos() const 
override;
-SVX_DLLPRIVATE virtual void*ImplGetEntryData( sal_Int32 nPos ) 
const override;
-SVX_DLLPRIVATE virtual void ImplSelectEntryPos( sal_Int32 nPos, 
bool bSelect ) override;
-SVX_DLLPRIVATE virtual sal_Int32ImplGetEntryPos( const void* pData ) 
const override;
-};
-
 class SVX_DLLPUBLIC LanguageBox
 {
 public:
diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py
index 8f37e476d0e6..eb3fc15740bb 100755
--- a/solenv/bin/native-code.py
+++ b/solenv/bin/native-code.py
@@ -505,7 +505,6 @@ custom_widgets = [
 'SvxColorValueSet',
 'SvxFillAttrBox',
 'SvxFillTypeBox',
-'SvxLanguageBox',
 'SvxLightCtl3D',
 'SvxRelativeField',
 'SwNavHelpToolBox',
diff --git a/svx/source/dialog/langbox.cxx b/svx/source/dialog/langbox.cxx
index eb099005d2e6..8403b67fdbe9 100644
--- a/svx/source/dialog/langbox.cxx
+++ b/svx/source/dialog/langbox.cxx
@@ -33,7 +33,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 
 using namespace ::com::sun::star::util;
@@ -65,10 +64,7 @@ OUString GetDicInfoStr( const OUString& rName, const 
LanguageType nLang, bool bN
 return aTmp;
 }
 
-
 //  misc local helper functions
-
-
 static std::vector< LanguageType > lcl_LocaleSeqToLangSeq( Sequence< 
css::lang::Locale > const  )
 {
 sal_Int32 nCount = rSeq.getLength();
@@ -83,28 +79,12 @@ static std::vector< LanguageType > lcl_LocaleSeqToLangSeq( 
Sequence< css::lang::
 return aLangs;
 }
 
-
 static bool lcl_SeqHasLang( const Sequence< sal_Int16 > & rLangSeq, sal_Int16 
nLang )
 {
 return rLangSeq.hasElements()
 && std::find(rLangSeq.begin(), rLangSeq.end(), nLang) != 
rLangSeq.end();
 }
 
-extern "C" SAL_DLLPUBLIC_EXPORT void makeSvxLanguageBox(VclPtr & 
rRet, const VclPtr & pParent, VclBuilder::stringmap & rMap)
-{
-
static_assert(std::is_same_v,
- decltype(makeSvxLanguageBox)>);
-WinBits nBits = WB_LEFT|WB_VCENTER|WB_3DLOOK|WB_TABSTOP;
-bool bDropdown = BuilderUtils::extractDropdown(rMap);
-if (bDropdown)
-nBits |= WB_DROPDOWN;
-else
-nBits |= WB_BORDER;
-VclPtrInstance pLanguageBox(pParent, nBits);
-pLanguageBox->EnableAutoSize(true);
-rRet = pLanguageBox;
-}
-
 SvxLanguageBoxBase::SvxLanguageBoxBase()
 : m_bWithCheckmark(false)
 {
@@ -706,56 +686,6 @@ LanguageBox::LanguageBox(std::unique_ptr 
pControl)
 m_xControl->connect_changed(LINK(this, LanguageBox, ChangeHdl));
 }
 
-SvxLanguageBox::SvxLanguageBox( vcl::Window* pParent, WinBits nBits )
-: ListBox( pParent, nBits )
-, SvxLanguageBoxBase()
-{
-// display entries sorted
-SetStyle( GetStyle() | WB_SORT );
-
-ImplLanguageBoxBaseInit();
-}
-
-sal_Int32 SvxLanguageBox::ImplInsertImgEntry( const OUString& rEntry, 
sal_Int32 nPos, bool bChecked )
-{
-return InsertEntry( rEntry, (bChecked ? m_aCheckedImage :

[Libreoffice-commits] core.git: vcl/unx

2019-10-17 Thread Caolán McNamara (via logerrit)

 vcl/unx/gtk3/gtk3gtkinst.cxx |   45 +++
 1 file changed, 45 insertions(+)

New commits:
commit d1b8b1a22136228dd6c31a44c1d19840c27c0cf7
Author: Caolán McNamara 
AuthorDate: Thu Oct 17 11:36:50 2019 +0100
Commit: Caolán McNamara 
CommitDate: Thu Oct 17 14:35:40 2019 +0200

Resolves: tdf#128129 add support for left/right expand/collapse

Change-Id: I6c8f11e1e2b4192933541e754a078c4d0ff58206
Reviewed-on: https://gerrit.libreoffice.org/80938
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index f178acd4fc5a..79a5ce12d750 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -7726,6 +7726,7 @@ private:
 gulong m_nPopupMenuSignalId;
 gulong m_nDragBeginSignalId;
 gulong m_nDragEndSignalId;
+gulong m_nKeyPressSignalId;
 ImplSVEvent* m_pChangeEvent;
 
 DECL_LINK(async_signal_changed, void*, void);
@@ -8104,6 +8105,48 @@ private:
 g_DragSource = nullptr;
 }
 
+gboolean signal_key_press(GdkEventKey* pEvent)
+{
+if (pEvent->keyval != GDK_KEY_Left && pEvent->keyval != GDK_KEY_Right)
+return false;
+
+GtkInstanceTreeIter aIter(nullptr);
+if (!get_cursor())
+return false;
+
+if (pEvent->keyval == GDK_KEY_Right)
+{
+if (iter_has_child(aIter) && !get_row_expanded(aIter))
+{
+expand_row(aIter);
+return true;
+}
+return false;
+}
+
+if (iter_has_child(aIter) && get_row_expanded(aIter))
+{
+collapse_row(aIter);
+return true;
+}
+
+if (iter_parent(aIter))
+{
+unselect_all();
+set_cursor(aIter);
+select(aIter);
+return true;
+}
+
+return false;
+}
+
+static gboolean signalKeyPress(GtkWidget*, GdkEventKey* pEvent, gpointer 
widget)
+{
+GtkInstanceTreeView* pThis = static_cast(widget);
+return pThis->signal_key_press(pEvent);
+}
+
 public:
 GtkInstanceTreeView(GtkTreeView* pTreeView, GtkInstanceBuilder* pBuilder, 
bool bTakeOwnership)
 : GtkInstanceContainer(GTK_CONTAINER(pTreeView), pBuilder, 
bTakeOwnership)
@@ -8121,6 +8164,7 @@ public:
 , m_nPopupMenuSignalId(g_signal_connect(pTreeView, "popup-menu", 
G_CALLBACK(signalPopupMenu), this))
 , m_nDragBeginSignalId(g_signal_connect(pTreeView, "drag-begin", 
G_CALLBACK(signalDragBegin), this))
 , m_nDragEndSignalId(g_signal_connect(pTreeView, "drag-end", 
G_CALLBACK(signalDragEnd), this))
+, m_nKeyPressSignalId(g_signal_connect(pTreeView, "key-press-event", 
G_CALLBACK(signalKeyPress), this))
 , m_pChangeEvent(nullptr)
 {
 m_pColumns = gtk_tree_view_get_columns(m_pTreeView);
@@ -9514,6 +9558,7 @@ public:
 {
 if (m_pChangeEvent)
 Application::RemoveUserEvent(m_pChangeEvent);
+g_signal_handler_disconnect(m_pTreeView, m_nKeyPressSignalId);
 g_signal_handler_disconnect(m_pTreeView, m_nDragEndSignalId);
 g_signal_handler_disconnect(m_pTreeView, m_nDragBeginSignalId);
 g_signal_handler_disconnect(m_pTreeView, m_nPopupMenuSignalId);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 128209] CRASH: Opening file with rotated text

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128209

Xisco Faulí  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||6060
 Status|UNCONFIRMED |NEW
   Keywords||bibisected, bisected,
   ||regression
 CC||gulsah.k...@collabora.com,
   ||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

https://git.libreoffice.org/core/commit/c50e44b270bc3048ff9c1a000c3afed1dab9e0bf

author  Gülşah Köse  2019-10-03 08:37:00 +0300
committer   Gülşah Köse  2019-10-16 10:44:00
+0200
commit  c50e44b270bc3048ff9c1a000c3afed1dab9e0bf (patch)
treed152dc897d7a54e0e01a1b594b1830f9a45f1e19
parent  e1b08d46d1861bfca88af5d8c7137419bcc131aa (diff)
tdf#126060 Handle text camera z rotation while pptx import.

Bisected with: bibisect-linux64-6.4

Adding Cc: to Gülşah Köse

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128210] New: EDITING: Crash in: SfxItemSet::Get(unsigned short, bool)

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128210

Bug ID: 128210
   Summary: EDITING: Crash in: SfxItemSet::Get(unsigned
short,bool)
   Product: LibreOffice
   Version: 6.0.6.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: traw...@gmail.com

This bug was filed from the crash reporting server and is
br-d518197b-858e-458a-a565-c76a80cf0f43.
=

The file with which it happened cannot be provided as it contains private data.

I cannot even reproduce the crash, but the steps involved:
- copying cell (or its formula, to have the data returned based on correct
cells),
- pasting it above some other cells with other formulas (this probably isn't
relevant),
- writing one-word-text in the cell to the left of the aformentioned one,
- moving vertically the 2x3 array of cells while holding the left-Alt button to
move them correctly,
- maybe changing the formatting of some cells to be centered, either here or
before the previous step, or both,
- going back and forth with ctrl-z, ctrl-y and moving the cells in between.

At some action in the last step it crashed.
Or it was during ctrl-s saving, but I can't be sure. I know it was saved like
this a few moments before and it was fine.

There was another calc document opened in the background, and both were closed
due to the crash (don't know if calc always does this or if it indicates some
kind of problem that's going on here).

I don't think I will be able to provide any further info.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128209] New: CRASH: Opening file with rotated text

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128209

Bug ID: 128209
   Summary: CRASH: Opening file with rotated text
   Product: LibreOffice
   Version: 6.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Steps to reproduce:
1. Open attachment 111823 from bug 88091

-> Crash

Reproduced in

Version: 6.4.0.0.alpha1+
Build ID: 01d28b0b85f99590c0581e4bbf636bc9281e0571
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101912] [META] Accessibility (a11y) bugs and enhancements

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101912
Bug 101912 depends on bug 81168, which changed state.

Bug 81168 Summary: Remove placeholder names for accessible objects
https://bugs.documentfoundation.org/show_bug.cgi?id=81168

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81168] Remove placeholder names for accessible objects

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=81168

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED

--- Comment #12 from Heiko Tietze  ---
Following comment 11 we should resolve the request as WF.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 81168] Remove placeholder names for accessible objects

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=81168

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED

--- Comment #12 from Heiko Tietze  ---
Following comment 11 we should resolve the request as WF.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 128090] WRITER TABLES: Sort warning needed or some form of protection

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128090

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #5 from Heiko Tietze  ---
If we can detect that not the whole table is selected (and show a warning
then), we could also provide means to extend it. So let's go with the Calc
solution and show a confirmation box with Keep, Extend, and Cancel (focused).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 128090] WRITER TABLES: Sort warning needed or some form of protection

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128090

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #5 from Heiko Tietze  ---
If we can detect that not the whole table is selected (and show a warning
then), we could also provide means to extend it. So let's go with the Calc
solution and show a confirmation box with Keep, Extend, and Cancel (focused).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128208] OOoSpotlightImporter.mdimporter causes segfault in mdworker macOS 10.15 Catalina with particular empty ODB file

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128208

--- Comment #2 from Alex Thurgood  ---
The file is a basic empty ODB file with no tables or queries, created with the
wizard in an earlier version of LO (can't remember which one).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128208] OOoSpotlightImporter.mdimporter causes segfault in mdworker macOS 10.15 Catalina

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128208

--- Comment #1 from Alex Thurgood  ---
Created attachment 155080
  --> https://bugs.documentfoundation.org/attachment.cgi?id=155080=edit
File causing LO Spotlight mdimporter to crash

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128208] OOoSpotlightImporter.mdimporter causes segfault in mdworker macOS 10.15 Catalina with particular empty ODB file

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128208

Alex Thurgood  changed:

   What|Removed |Added

Summary|OOoSpotlightImporter.mdimpo |OOoSpotlightImporter.mdimpo
   |rter causes segfault in |rter causes segfault in
   |mdworker macOS 10.15|mdworker macOS 10.15
   |Catalina|Catalina with particular
   ||empty ODB file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125508] Frames around dialog widgets

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=125508

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Keywords|needsUXEval |
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |
 Ever confirmed|0   |1
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #12 from Heiko Tietze  ---
Let's submit Caolan's patch and see if it has drawbacks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 128058] UI: Option to open all heading branches at once

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128058

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
   Assignee|libreoffice-b...@lists.free |rayk...@gmail.com
   |desktop.org |
 CC||heiko.tietze@documentfounda
   ||tion.org

--- Comment #12 from Heiko Tietze  ---
Jim is implementing the * plus context menu solution.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 125508] Frames around dialog widgets

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=125508

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Keywords|needsUXEval |
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |
 Ever confirmed|0   |1
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #12 from Heiko Tietze  ---
Let's submit Caolan's patch and see if it has drawbacks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] online.git: loleaflet/src

2019-10-17 Thread Tamás Zolnai (via logerrit)

 loleaflet/src/control/Control.Menubar.js |   36 +++
 1 file changed, 18 insertions(+), 18 deletions(-)

New commits:
commit bc28618d83e20480eb387e9d30556650c2a9f588
Author: Tamás Zolnai 
AuthorDate: Thu Oct 17 14:26:15 2019 +0200
Commit: Tamás Zolnai 
CommitDate: Thu Oct 17 14:26:54 2019 +0200

mobile-menu: Fix code identation

Change-Id: I0f4e897a1e7ca79a0b72cdc7d72a8b64b39f1dee

diff --git a/loleaflet/src/control/Control.Menubar.js 
b/loleaflet/src/control/Control.Menubar.js
index 8aa500195..a13a44116 100644
--- a/loleaflet/src/control/Control.Menubar.js
+++ b/loleaflet/src/control/Control.Menubar.js
@@ -611,19 +611,19 @@ L.Control.Menubar = L.Control.extend({
{id: 'inserttable', type: 'action', 
name: _('Insert table')},
{type: 'separator'},
{name: _UNO('.uno:InsertField', 
'text'), type: 'menu', menu: [
-{uno: '.uno:InsertPageNumberField'},
-{uno: '.uno:InsertPageCountField'},
-{uno: '.uno:InsertDateField'},
-{uno: '.uno:InsertTimeField'},
-{uno: '.uno:InsertTitleField'},
-{uno: '.uno:InsertAuthorField'},
-{uno: '.uno:InsertTopicField'}
+   {uno: 
'.uno:InsertPageNumberField'},
+   {uno: 
'.uno:InsertPageCountField'},
+   {uno: '.uno:InsertDateField'},
+   {uno: '.uno:InsertTimeField'},
+   {uno: '.uno:InsertTitleField'},
+   {uno: '.uno:InsertAuthorField'},
+   {uno: '.uno:InsertTopicField'}
]},
{name: 
_UNO('.uno:InsertHeaderFooterMenu', 'text'), type: 'menu', menu: [
-{name: _UNO('.uno:InsertPageHeader', 'text'), type: 
'menu', menu: [
-{name: _('All'), disabled: true, id: 
'insertheader', tag: '_ALL_', uno: '.uno:InsertPageHeader?'}]},
-{name: _UNO('.uno:InsertPageFooter', 'text'), type: 
'menu', menu: [
-{name: _('All'), disabled: true, id: 
'insertfooter', tag: '_ALL_', uno: '.uno:InsertPageFooter?'}]}
+   {name: 
_UNO('.uno:InsertPageHeader', 'text'), type: 'menu', menu: [
+   {name: _('All'), 
disabled: true, id: 'insertheader', tag: '_ALL_', uno: 
'.uno:InsertPageHeader?'}]},
+   {name: 
_UNO('.uno:InsertPageFooter', 'text'), type: 'menu', menu: [
+   {name: _('All'), 
disabled: true, id: 'insertfooter', tag: '_ALL_', uno: 
'.uno:InsertPageFooter?'}]}
]},
{uno: '.uno:InsertFootnote'},
{uno: '.uno:InsertEndnote'},
@@ -634,13 +634,13 @@ L.Control.Menubar = L.Control.extend({
{name: _UNO('.uno:HyperlinkDialog'), 
id: 'inserthyperlink', type: 'action'},
{name: _('Insert Shape'), id: 
'insertshape', type: 'action' },
{name: _UNO('.uno:FormattingMarkMenu', 
'text'), type: 'menu', menu: [
-{uno: '.uno:InsertNonBreakingSpace'},
-{uno: '.uno:InsertHardHyphen'},
-{uno: '.uno:InsertSoftHyphen'},
-{uno: '.uno:InsertZWSP'},
-{uno: '.uno:InsertZWNBSP'},
-{uno: '.uno:InsertLRM'},
-{uno: '.uno:InsertRLM'}]},
+   {uno: 
'.uno:InsertNonBreakingSpace'},
+   {uno: '.uno:InsertHardHyphen'},
+   {uno: '.uno:InsertSoftHyphen'},
+   {uno: '.uno:InsertZWSP'},
+   {uno: '.uno:InsertZWNBSP'},
+   {uno: '.uno:InsertLRM'},
+   {uno: '.uno:InsertRLM'}]},
]
},
spreadsheet : {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 128058] UI: Option to open all heading branches at once

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128058

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
   Assignee|libreoffice-b...@lists.free |rayk...@gmail.com
   |desktop.org |
 CC||heiko.tietze@documentfounda
   ||tion.org

--- Comment #12 from Heiko Tietze  ---
Jim is implementing the * plus context menu solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: [Libreoffice-commits] core.git: Rename OUStringLiteral1 to OUStringChar

2019-10-17 Thread Stephan Bergmann


FYI:

On 17/10/2019 07:30, Stephan Bergmann (via logerrit) wrote:

New commits:
commit 8b4719c29fc9bd7e198ad6ced301e1ff7a350f16
Author: Stephan Bergmann 
AuthorDate: Wed Oct 16 15:06:23 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Thu Oct 17 07:28:49 2019 +0200

 Rename OUStringLiteral1 to OUStringChar
 
 It started out as a wrapper around character literals, but has by now become a

 wrapper around arbitrary single characters.  Besides updating the 
documentation,
 this change is a mechanical
 
   for i in $(git grep -Fl OUStringLiteral1); do sed -i -e s/OUStringLiteral1/OUStringChar/g "$i"; done
 
 Change-Id: I1b9eaa4b3fbc9025ce4a4bffea3db1c16188b76f

 Reviewed-on: https://gerrit.libreoffice.org/80892
 Tested-by: Jenkins
 Reviewed-by: Stephan Bergmann 


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 128206] FILEOPEN PPTX text z-Rotation does not work together with shape rotation

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128206

Xisco Faulí  changed:

   What|Removed |Added

 CC||gulsah.k...@collabora.com

--- Comment #2 from Xisco Faulí  ---
@Gülşah Köse, I thought you might be interested in this issue after fixing bug
126060

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Minutes from the UX/design meeting 2019-OCT-17

2019-10-17 Thread Heiko Tietze

Present: Heiko

Tickets

 * UI: Hyperlink dialog should remember last used view
   + https://bugs.documentfoundation.org/show_bug.cgi?id=90496
   + as a general guideline, store the tab position per session (Heiko)
   + user configuration (Thomas)
   => let's put it on the pile of 109265 and remembered the last tab

 * UI: Option to open all heading branches at once
   + https://bugs.documentfoundation.org/show_bug.cgi?id=128058
   + use a context menu and * to expand all
   => Jim is working on it

 * Frames around dialog widgets
   + https://bugs.documentfoundation.org/show_bug.cgi?id=125508
   + GtkScrolledWindow uses decoration under Windows/macOS (Caolan)
   => apply Caolan's patch and see if that has drawbacks

 * FORMATTING feature request: error bars style => error box
   + https://bugs.documentfoundation.org/show_bug.cgi?id=90180
   + probably too early to discuss
   => postponed/discussion on BZ

 * WRITER TABLES: Sort warning needed or some form of protection
   + https://bugs.documentfoundation.org/show_bug.cgi?id=128090
   + adopt the Calc workflow; in advance of the search criteria or afterwards
   + OP suggests to show a warning first, but then we could also allow 
 to extend the selection
   => add the confirmation box with Keep, Extend, [Cancel]

 * Remove placeholder names for accessible objects
   + https://bugs.documentfoundation.org/show_bug.cgi?id=81168
   => WF as names are needed for the Navigator




signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-qa] Minutes from the UX/design meeting 2019-OCT-17

2019-10-17 Thread Heiko Tietze

Present: Heiko

Tickets

 * UI: Hyperlink dialog should remember last used view
   + https://bugs.documentfoundation.org/show_bug.cgi?id=90496
   + as a general guideline, store the tab position per session (Heiko)
   + user configuration (Thomas)
   => let's put it on the pile of 109265 and remembered the last tab

 * UI: Option to open all heading branches at once
   + https://bugs.documentfoundation.org/show_bug.cgi?id=128058
   + use a context menu and * to expand all
   => Jim is working on it

 * Frames around dialog widgets
   + https://bugs.documentfoundation.org/show_bug.cgi?id=125508
   + GtkScrolledWindow uses decoration under Windows/macOS (Caolan)
   => apply Caolan's patch and see if that has drawbacks

 * FORMATTING feature request: error bars style => error box
   + https://bugs.documentfoundation.org/show_bug.cgi?id=90180
   + probably too early to discuss
   => postponed/discussion on BZ

 * WRITER TABLES: Sort warning needed or some form of protection
   + https://bugs.documentfoundation.org/show_bug.cgi?id=128090
   + adopt the Calc workflow; in advance of the search criteria or afterwards
   + OP suggests to show a warning first, but then we could also allow 
 to extend the selection
   => add the confirmation box with Keep, Extend, [Cancel]

 * Remove placeholder names for accessible objects
   + https://bugs.documentfoundation.org/show_bug.cgi?id=81168
   => WF as names are needed for the Navigator




signature.asc
Description: OpenPGP digital signature
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-ux-advise] [Bug 90496] UI: Hyperlink dialog should remember last used view

2019-10-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=90496

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #11 from Heiko Tietze  ---
Benefit of the session only solution is that different scenarios require
different workflows and therefore it makes sense to start with a default. But
the general rule as requested in the meta bug 109265 makes also sense. So let's
remember the last used tab position and restore it at the next session.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

< 1 2 3 4 5 >

201 - 300 of 497 matches

Mail list logo