[Libreoffice-bugs] [Bug 128201] changing expert configuration not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=128201 Oliver Brinzing changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from Oliver Brinzing --- (In reply to Oliver Brinzing from comment #3) > expert config shows only i cannot confirm this with: Version: 6.5.0.0.alpha0+ (x64) Build ID: d04eef858250f97690f32dba17f42d157a8767fc CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win; Locale: de-DE (de_DE); UI-Language: en-US Calc: threaded > try Save(As) > SystemDialog still in use > Look again in Expert config > UseSystemFileDialog is still 'true' seems to be fixed, changing values works too and this was a different issue: > - set macro security from "Low" to "High" > - restart LO > - macro security is "Very high" Bug 128749 - Macro security level not displayed correctly in non-gtk3 backends -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128837] PDF-EXPORT: More informations are needed about Tagged-PDF option (see comment 4)
https://bugs.documentfoundation.org/show_bug.cgi?id=128837
Jens Radloff changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
Ever confirmed|0 |1
--- Comment #6 from Jens Radloff ---
(In reply to Dieter Praas from comment #5)
> Jens, you can change outline level as follows:
> 1. Open paragraph styles in sidebar
> 2. Choos Modify in context menu
> 3. Change outline level in outline and numbering style
Hi Dieter, thanks for your information to resolve this issue. I am not using
the LO Writer Sidebar due to the limited size of my screen (laptop screen), it
is permanently closed on my computer. One alternatively can access that option
to change the outline to level 1 by right-clicking a heading, then "Paragraph",
then "Edit style".
The user behind the mail adress sdc.bla...@youmail.dk already informed me about
how to solve this issue by email to my mail adress yesterday because he or she
thought that I reported this issue to receive help here. Many thanks to
sdc.bla...@youmail.dk.
> So for me it's a lack of information in documentation [1].
Yes, I agree with you.
> [1]
> https://help.libreoffice.org/6.4/en-US/text/shared/01/ref_pdf_export.
> html?System=WIN=WRITER=filter/ui/pdfgeneralpage/
> PdfGeneralPage#bm_id1033968
How about additionally creating a How-To with a title like "How to manually
create an element ("bookmark") of an index heading in the document structure of
PDF files"?
> Jens, if you agree, please change satus to NEW
Yes, I will do that, thanks.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: qadevOOo/tests
qadevOOo/tests/java/ifc/frame/_XController.java |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 335852ffcf72e2ef6c4b02ebe645492bb7bc36d3
Author: Andrea Gelmini
AuthorDate: Sat Nov 16 23:01:58 2019 +0100
Commit: Julien Nabet
CommitDate: Sun Nov 17 08:44:14 2019 +0100
Fix typo
Change-Id: I59877df3c75d8423ae81a7d877b3144e65526253
Reviewed-on: https://gerrit.libreoffice.org/83007
Reviewed-by: Julien Nabet
Tested-by: Julien Nabet
diff --git a/qadevOOo/tests/java/ifc/frame/_XController.java
b/qadevOOo/tests/java/ifc/frame/_XController.java
index 0419976a8ca2..48ecad772f07 100644
--- a/qadevOOo/tests/java/ifc/frame/_XController.java
+++ b/qadevOOo/tests/java/ifc/frame/_XController.java
@@ -67,7 +67,7 @@ public class _XController extends MultiMethodTest {
* previously obtained object relation 'Frame'.
* The following method tests are to be completed successfully before:
*
-*attachFrame() : attachs frame obtained object
+*attachFrame() : attaches frame obtained object
* relation 'Frame'
*
*/
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - compilerplugins/clang cui/source sd/qa
compilerplugins/clang/consttobool.cxx |2 +-
cui/source/customize/cfg.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit bde2137d6efa7966672916ae5a0b8020bec7dbc4
Author: Andrea Gelmini
AuthorDate: Sat Nov 16 16:21:07 2019 +0100
Commit: Julien Nabet
CommitDate: Sun Nov 17 08:32:43 2019 +0100
Removed executable permission on file pptx
Change-Id: I93dd9533fc4f4d2acc1afe282754af0c78a25f73
Reviewed-on: https://gerrit.libreoffice.org/82985
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/sd/qa/unit/data/pptx/tdf128684.pptx
b/sd/qa/unit/data/pptx/tdf128684.pptx
old mode 100755
new mode 100644
commit 4e053538db0e701f444a4dd81bfc0de2ca053c18
Author: Andrea Gelmini
AuthorDate: Fri Nov 15 18:50:29 2019 +0100
Commit: Julien Nabet
CommitDate: Sun Nov 17 08:32:34 2019 +0100
Fix typos
Change-Id: I9251205c47f26be7695496b5887b849fcf1335f1
Reviewed-on: https://gerrit.libreoffice.org/82814
Reviewed-by: Julien Nabet
Tested-by: Julien Nabet
diff --git a/compilerplugins/clang/consttobool.cxx
b/compilerplugins/clang/consttobool.cxx
index a3c57d704b26..c7ebd6b2a162 100644
--- a/compilerplugins/clang/consttobool.cxx
+++ b/compilerplugins/clang/consttobool.cxx
@@ -153,7 +153,7 @@ public:
{
l1 =
compiler.getSourceManager().getImmediateMacroCallerLoc(l1);
}
-// For exmaple, /usr/include/glib-2.0/glib/gmacros.h from
+// For example, /usr/include/glib-2.0/glib/gmacros.h from
// glib2-devel-2.62.1-1.fc31.x86_64 has
//
// #define TRUE (!FALSE)
diff --git a/cui/source/customize/cfg.cxx b/cui/source/customize/cfg.cxx
index 0f0f6dc7b1f9..4e084ce21951 100644
--- a/cui/source/customize/cfg.cxx
+++ b/cui/source/customize/cfg.cxx
@@ -3180,7 +3180,7 @@ sal_Int8
SvxConfigPageFunctionDropTarget::AcceptDrop(const AcceptDropEvent& rEvt
sal_Int8 SvxConfigPageFunctionDropTarget::ExecuteDrop( const ExecuteDropEvent&
rEvt )
{
weld::TreeView* pSource = m_rTreeView.get_drag_source();
-// only draging within the same widget allowed
+// only dragging within the same widget allowed
if (!pSource || pSource != _rTreeView)
return DND_ACTION_NONE;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128837] PDF-EXPORT: More informations are needed about Tagged-PDF option (see comment 4)
https://bugs.documentfoundation.org/show_bug.cgi?id=128837 Dieter Praas changed: What|Removed |Added Blocks||103378 CC||dgp-m...@gmx.de, ||olivier.hallot@libreoffice. ||org Summary|Export as PDF: Index|PDF-EXPORT: More |headings are not shown as |informations are needed |elements in navigation area |about Tagged-PDF option |/ document structure of PDF |(see comment 4) |viewer | Component|Writer |Documentation --- Comment #5 from Dieter Praas --- Jens, you can change outline level as follows: 1. Open paragraph styles in sidebar 2. Choos Modify in context menu 3. Change outline level in outline and numbering style So for me it's a lack of information in documentation [1]. [1] https://help.libreoffice.org/6.4/en-US/text/shared/01/ref_pdf_export.html?System=WIN=WRITER=filter/ui/pdfgeneralpage/PdfGeneralPage#bm_id1033968 Jens, if you agree, please change satus to NEW Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103378 [Bug 103378] [META] PDF export bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 Dieter Praas changed: What|Removed |Added Depends on||128837 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=128837 [Bug 128837] PDF-EXPORT: More informations are needed about Tagged-PDF option (see comment 4) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126954] Image cropping bug in Writer 6.2.5.2
https://bugs.documentfoundation.org/show_bug.cgi?id=126954 --- Comment #6 from Dieter Praas --- Created attachment 155886 --> https://bugs.documentfoundation.org/attachment.cgi?id=155886=edit PDF of attachment 155857 I can't confirm it with Version: 6.4.0.0.beta1 (x64) Build ID: 4d7e5b0c40ed843384704eca3ce21981d4e98920 CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; Locale: de-DE (de_DE); UI-Language: en-US Calc: threaded I opened attachment 155857 and everything looks fine. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125925] Qt5 VCL UI Fonts are small
https://bugs.documentfoundation.org/show_bug.cgi?id=125925 Dieter Praas changed: What|Removed |Added Depends on||128838 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=128838 [Bug 128838] AUTO-REDACT: Uneditable target -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128838] AUTO-REDACT: Uneditable target
https://bugs.documentfoundation.org/show_bug.cgi?id=128838 Dieter Praas changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Blocks||125925 OS|Linux (All) |All Summary|Auto-redact: uneditable |AUTO-REDACT: Uneditable |target |target --- Comment #1 from Dieter Praas --- I confirm, that the warning "All fields are required" appears, but I'm able to switch content field to text box Version: 6.4.0.0.beta1 (x64) Build ID: 4d7e5b0c40ed843384704eca3ce21981d4e98920 CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; Locale: de-DE (de_DE); UI-Language: en-US Calc: threaded => NEW because of the warning Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=125925 [Bug 125925] Qt5 VCL UI Fonts are small -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109232] [META] Special character dialog and toolbar group button bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109232 Dieter Praas changed: What|Removed |Added Depends on||128850 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=128850 [Bug 128850] SPECIAL CHARACTER: Add Exclusive-or symbol -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128850] SPECIAL CHARACTER: Add Exclusive-or symbol
https://bugs.documentfoundation.org/show_bug.cgi?id=128850 Dieter Praas changed: What|Removed |Added Summary|Exclusive-or symbol |SPECIAL CHARACTER: Add ||Exclusive-or symbol Blocks||109232 CC||dgp-m...@gmx.de Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=109232 [Bug 109232] [META] Special character dialog and toolbar group button bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang vcl/inc
compilerplugins/clang/unusedmethods.py |2 compilerplugins/clang/unusedmethods.results| 144 - compilerplugins/clang/unusedmethods.unused-returns.results | 34 +-- vcl/inc/svimpbox.hxx |1 4 files changed, 66 insertions(+), 115 deletions(-) New commits: commit f10b43f9d1b4e14441a9204bc0c79003645f0f98 Author: Noel Grandin AuthorDate: Sat Nov 16 11:10:38 2019 +0200 Commit: Noel Grandin CommitDate: Sun Nov 17 07:15:22 2019 +0100 loplugin:unusedmethods Change-Id: I04deb5a1dee5b8a9a4508d28552ffe0b67288993 Reviewed-on: https://gerrit.libreoffice.org/82977 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/compilerplugins/clang/unusedmethods.py b/compilerplugins/clang/unusedmethods.py index d4af2f712bf7..8497719b8f77 100755 --- a/compilerplugins/clang/unusedmethods.py +++ b/compilerplugins/clang/unusedmethods.py @@ -1,4 +1,4 @@ -#!/usr/bin/python +#!/usr/bin/python2 import sys import re diff --git a/compilerplugins/clang/unusedmethods.results b/compilerplugins/clang/unusedmethods.results index 76a8b3d457b9..6f41c1d5b301 100644 --- a/compilerplugins/clang/unusedmethods.results +++ b/compilerplugins/clang/unusedmethods.results @@ -66,6 +66,8 @@ connectivity/source/inc/OTypeInfo.hxx:47 _Bool connectivity::OTypeInfo::operator!=(const struct connectivity::OTypeInfo &) const cui/source/dialogs/SpellAttrib.hxx:73 _Bool svx::SpellErrorDescription::operator==(const struct svx::SpellErrorDescription &) const +cui/source/inc/cfg.hxx:333 +class rtl::OUString SvxMenuEntriesListBox::get_text(int) cui/source/inc/cfgutil.hxx:142 _Bool CuiConfigFunctionListBox::get_iter_first(class weld::TreeIter &) const cui/source/inc/cfgutil.hxx:144 @@ -144,14 +146,6 @@ editeng/inc/edtspell.hxx:109 class __gnu_debug::_Safe_iterator > >, class std::__debug::vector >, struct std::random_access_iterator_tag> WrongList::end() const extensions/source/scanner/scanner.hxx:86 void ScannerManager::SetData(void *) -fpicker/source/office/iodlgimp.hxx:194 -void SvtExpFileDlg_Impl::SetNoFilterListSelection() -fpicker/source/office/PlacesListBox.hxx:59 -const class weld::Button & PlacesListBox::GetAddButton() const -fpicker/source/office/PlacesListBox.hxx:60 -const class weld::Button & PlacesListBox::GetDeleteButton() const -fpicker/source/office/PlacesListBox.hxx:61 -class weld::TreeView & PlacesListBox::GetPlacesListBox() hwpfilter/source/mzstring.h:99 class MzString & MzString::operator<<(unsigned char) hwpfilter/source/mzstring.h:101 @@ -496,7 +490,7 @@ include/i18nlangtag/languagetag.hxx:263 enum LanguageTag::ScriptType LanguageTag::getScriptType() const include/o3tl/any.hxx:155 class boost::optional o3tl::tryAccess(const class com::sun::star::uno::Any &) -include/o3tl/cow_wrapper.hxx:310 +include/o3tl/cow_wrapper.hxx:323 type-parameter-?-? * o3tl::cow_wrapper::get() include/o3tl/enumarray.hxx:105 typename type-parameter-?-?::value_type * o3tl::enumarray_iterator::operator->() const @@ -544,8 +538,6 @@ include/opencl/openclconfig.hxx:57 _Bool OpenCLConfig::ImplMatcher::operator!=(const struct OpenCLConfig::ImplMatcher &) const include/opencl/OpenCLZone.hxx:47 _Bool OpenCLZone::isInInitialTest() -include/sfx2/basedlgs.hxx:102 - SfxFloatingWindow::SfxFloatingWindow(class SfxBindings *,class SfxChildWindow *,class vcl::Window *,const class rtl::OString &,const class rtl::OUString &,const class com::sun::star::uno::Reference &) include/sfx2/charwin.hxx:64 void SvxCharView::connect_focus_in(const class Link &) include/sfx2/charwin.hxx:65 @@ -568,16 +560,6 @@ include/svl/lockfilecommon.hxx:58 void svt::LockFileCommon::SetURL(const class rtl::OUString &) include/svtools/DocumentToGraphicRenderer.hxx:106 _Bool DocumentToGraphicRenderer::isImpress() const -include/svtools/imagemgr.hxx:128 -class Image SvFileInformationManager::GetFolderImage(const struct svtools::VolumeInfo &) -include/svtools/inettbc.hxx:68 -void SvtURLBox::SetBaseURL(const class rtl::OUString &) -include/svtools/inettbc.hxx:72 -void SvtURLBox::SetOnlyDirectories(_Bool) -include/svtools/inettbc.hxx:73 -void SvtURLBox::SetNoURLSelection(_Bool) -include/svtools/inettbc.hxx:82 -void SvtURLBox::EnableAutocompletion(_Bool) include/svx/autoformathelper.hxx:145 _Bool AutoFormatBase::operator==(const class AutoFormatBase &) include/svx/ClassificationEditView.hxx:38 @@ -698,8 +680,6 @@ include/vcl/animate/AnimationBitmap.hxx:69 _Bool AnimationBitmap::operator!=(const struct AnimationBitmap &) const include/vcl/BitmapColor.hxx:39 void BitmapColor::SetAlpha(unsigned char) -include/vcl/builder.hxx:475 -_Bool VclBuilderContainer::hasBuilder() const include/vcl/ColorMask.hxx:113 void ColorMask::GetColorFor16BitMSB(class BitmapColor &,const unsigned char *) const
[Libreoffice-bugs] [Bug 128850] New: Exclusive-or symbol
https://bugs.documentfoundation.org/show_bug.cgi?id=128850 Bug ID: 128850 Summary: Exclusive-or symbol Product: LibreOffice Version: 6.3.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: contest...@aol.com Description: Can you add the exclusive-or symbol to the special characters in OpenOffice Writer? The HTML code is It looks like a circle with a plus sign in it. Steps to Reproduce: Not applicable. Actual Results: Not applicable. Expected Results: Not applicable. Reproducible: Always User Profile Reset: No Additional Info: The list of special characters does not have the exclusive-or symbol, a circle with a + inside. It also lacks a circle with an x inside . These symbols are used for addition and multiplication in a mathematical ring. I have had to use the 5-character combination blank-X-O-R-blank which wrecks readability. I have tried copying the symbol from other documents, but that doesn't work. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118849] Impress hang when input multibyte character.
https://bugs.documentfoundation.org/show_bug.cgi?id=118849 --- Comment #6 from Naruhiko Ogasawara --- Not reproducible: Version: 6.5.0.0.alpha0+ Build ID: 84322944980f6e2f9d4a531de7a6803797156968 CPU threads: 4; OS:Linux 5.3; UI render: default; VCL: x11; Locale: ja-JP (ja_JP.UTF-8); UI-Language: ja-JP Calc: threaded with Ubuntu 19.10, - ibus 1.5.21-1~exp2ubuntu2 - ibus-mozc 2.23.2815.102+dfsg-7 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
6 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1455745: API usage errors (STREAM_FORMAT_STATE)
/include/tools/color.hxx: 323 in operator <<>(std::basic_ostream &, const Color &)()
*** CID 1455745: API usage errors (STREAM_FORMAT_STATE)
/include/tools/color.hxx: 323 in operator <<>(std::basic_ostream &, const Color &)()
317 constexpr ::Color COL_AUTHOR9_NORMAL ( 255, 226, 185 );
318 constexpr ::Color COL_AUTHOR9_LIGHT ( 255, 231, 199 );
319
320 template
321 inline std::basic_ostream& operator
<<(std::basic_ostream& rStream, const Color& rColor)
322 {
>>> CID 1455745: API usage errors (STREAM_FORMAT_STATE)
>>> Changing format state of stream "rStream" for categories basefield,
>>> fill without later restoring it.
323 return rStream << "c[" << std::hex << std::setfill ('0')
324<< std::setw(2) << static_cast(rColor.GetRed())
325<< std::setw(2) <<
static_cast(rColor.GetGreen())
326<< std::setw(2) << static_cast(rColor.GetBlue())
327<< std::setw(2) <<
static_cast(rColor.GetTransparency()) << "]";
328 }
329
330 #endif
331
To view the defects in Coverity Scan visit,
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB73RtgzoPcQtNNP5dkHLuV1E-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpy2-2BfzNN3ayqncvFf9qePhxnJQ-2BplIIKc-2F8QR9EP7-2FyFNMqSp-2FMoHMiOQ1-2FBf0HKmTkiYKTKCiA1Vi5CDLXqQbZu38YKHaqum4nDMcCt2eJyo6OC1hx2-2FWBSihNR-2FmfFYCrDy-2BLWAiLK5Yqewg5Jm5141Ttz5urtmJGsVO-2F-2FZbdTI-3D
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 128830] FILEOPEN: text box rotated, saved as .doc .docx, is corrupted when file is reopened
https://bugs.documentfoundation.org/show_bug.cgi?id=128830 arawat changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128842] SLIDESHOW: presenter console overlaps presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=128842 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47746] "Code folding" for Writer / Collapse or expand parts of a document
https://bugs.documentfoundation.org/show_bug.cgi?id=47746 --- Comment #23 from kocj --- me-too I am also waiting for this future -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125364] Unable to download latest update
https://bugs.documentfoundation.org/show_bug.cgi?id=125364 --- Comment #2 from QA Administrators --- Dear David, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68715] RTF import still screwing up some text and tables
https://bugs.documentfoundation.org/show_bug.cgi?id=68715 --- Comment #14 from QA Administrators --- Dear Robert, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124833] words overlaied
https://bugs.documentfoundation.org/show_bug.cgi?id=124833 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128551] Build loolwsd Debian 10 package against libglx-mesa0
https://bugs.documentfoundation.org/show_bug.cgi?id=128551 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121438] FILEOPEN DOCX, Word document contains text before footnote number below the line, opened in Writer the text is after the footnote
https://bugs.documentfoundation.org/show_bug.cgi?id=121438 --- Comment #6 from QA Administrators --- Dear NISZ LibreOffice Team, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120397] FILESAVE doesn't save all the text in text box control
https://bugs.documentfoundation.org/show_bug.cgi?id=120397 --- Comment #5 from QA Administrators --- Dear conman53095, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128553] Shouldn't it be possible to apply multiple styles simultaneously?
https://bugs.documentfoundation.org/show_bug.cgi?id=128553 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124833] words overlaied
https://bugs.documentfoundation.org/show_bug.cgi?id=124833 --- Comment #3 from QA Administrators --- Dear HM Liu, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120655] EDITING: Shared spreadsheet, after put something in a cell and change cell background in another, format change is saved when it shouldn't.
https://bugs.documentfoundation.org/show_bug.cgi?id=120655 --- Comment #2 from QA Administrators --- Dear m.a.riosv, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89944] Please unify indication of "[NatNum5]#, ## 0"
https://bugs.documentfoundation.org/show_bug.cgi?id=89944 --- Comment #5 from QA Administrators --- Dear HD, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115376] Lists exported to EPUB are generating p elements instead of ol/ul + li
https://bugs.documentfoundation.org/show_bug.cgi?id=115376 --- Comment #4 from QA Administrators --- Dear Daniel Glazman, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116134] Misalignment & wrong direction of Arabic contents in output EPUB when export from office to EPUB
https://bugs.documentfoundation.org/show_bug.cgi?id=116134 --- Comment #6 from QA Administrators --- Dear yousifjkadom, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117322] Unwanted code present when exporting to ePub in 6.0.2.1 from Writer - Windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=117322 --- Comment #8 from QA Administrators --- Dear Azrael Arocha, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121186] A section has white background, but reports as having no fill in a specific document
https://bugs.documentfoundation.org/show_bug.cgi?id=121186 --- Comment #2 from QA Administrators --- Dear Mike Kaganski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128830] FILEOPEN: text box rotated, saved as .doc .docx, is corrupted when file is reopened
https://bugs.documentfoundation.org/show_bug.cgi?id=128830 --- Comment #2 from arawat --- Not a bug; .docx (or .doc) does not support rotated text boxes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128849] New: Add new Breeze-Dark SVG / Sifr-Dark SVG icons
https://bugs.documentfoundation.org/show_bug.cgi?id=128849 Bug ID: 128849 Summary: Add new Breeze-Dark SVG / Sifr-Dark SVG icons Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: herzensch...@gmail.com Description: A user named Carla Rossetti over the Facebook group "KDE Neon Users" modified Breeze SVG and Sifr SVG to create correspondent dark versions for their own use (because the non-SVG version wouldn't look correct under 4K resolution). They are okay with it being upstreamed to LibreOffice. Please take a look: https://github.com/primuladimaggio/libreoffice-dark-icons-svg Actual Results: Expected Results: Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127491] Enter a half-width character at begining of line , The Language change from Japanese to English.
https://bugs.documentfoundation.org/show_bug.cgi?id=127491 --- Comment #2 from Naruhiko Ogasawara --- Confirmed with: Version: 6.3.3.2.0+ Build ID: libreoffice-6.3.3.2-snap1 CPU threads: 4; OS: Linux 5.3; UI render: default; VCL: gtk3; Locale: ja-JP (ja_JP.UTF-8); UI-Language: en-US Calc: threaded But I'm not sure if this behavior is a bug or specification. Even if the default paragraph language setting is Japanese, the paragraph language will be English when I enter English as the first character. Then I enter Japanese, the entire paragraph language will be Japanese. However, the language shown in the status bar seems to be indicated "for selection," not a "for paragraph," and I guess it is correct that the "for selection" language changes depending on whether the characters are Japanese or English. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/ooxmlexport/ooxmlexport14.cxx | 20
1 file changed, 20 insertions(+)
New commits:
commit 8e7d89295c0b9e0515baab88d99c05ac293ac645
Author: Mike Kaganski
AuthorDate: Sat Nov 16 22:57:18 2019 +0200
Commit: Mike Kaganski
CommitDate: Sun Nov 17 03:17:48 2019 +0100
tdf#128820: improve unit test to not depend on opening bad file failing
... also test exported XML directly
Change-Id: I50237593dd111e7c7974452769c8d49c22012713
Reviewed-on: https://gerrit.libreoffice.org/83005
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
index 8178d249d399..c8c95d1cd132 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
@@ -146,6 +146,26 @@ DECLARE_OOXMLEXPORT_TEST(testTdf124367, "tdf124367.docx")
DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf128820, "tdf128820.fodt")
{
// Import of exported DOCX failed because of wrong namespase used for wsp
element
+// Now test the exported XML, in case we stop failing opening invalid files
+xmlDocPtr pXml = parseExport("word/document.xml");
+CPPUNIT_ASSERT(pXml);
+// The parent wpg:wgp element has three children: wpg:cNvGrpSpPr,
wpg:grpSpPr, and wpg:wsp
+// (if we start legitimately exporting additional children, this needs to
be adjusted to check
+// all those, to make sure we don't export wrong elements).
+assertXPathChildren(pXml,
+
"/w:document/w:body/w:p/w:r/mc:AlternateContent/mc:Choice/w:drawing/"
+"wp:inline/a:graphic/a:graphicData/wpg:wgp",
+3);
+assertXPath(pXml,
+
"/w:document/w:body/w:p/w:r/mc:AlternateContent/mc:Choice/w:drawing/wp:inline/"
+"a:graphic/a:graphicData/wpg:wgp/wpg:cNvGrpSpPr");
+assertXPath(pXml,
+
"/w:document/w:body/w:p/w:r/mc:AlternateContent/mc:Choice/w:drawing/wp:inline/"
+"a:graphic/a:graphicData/wpg:wgp/wpg:grpSpPr");
+// This one was pic:wsp instead of wps:wsp
+assertXPath(pXml,
+
"/w:document/w:body/w:p/w:r/mc:AlternateContent/mc:Choice/w:drawing/wp:inline/"
+"a:graphic/a:graphicData/wpg:wgp/wps:wsp");
}
CPPUNIT_PLUGIN_IMPLEMENT();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93441] EDITING: cursor jumps to different horizontal position when moving to a different line with Up / Down
https://bugs.documentfoundation.org/show_bug.cgi?id=93441 Aron Budea changed: What|Removed |Added Version|5.0.0.5 release |4.4.0.3 release See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=38 ||884, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||9635 CC||ba...@caesar.elte.hu, ||juergen.funk...@cib.de Keywords|bibisectRequest |bibisected, bisected --- Comment #5 from Aron Budea --- Bibisected to the following commit using repo bibisect-44max. Found bug 119635 as a similar issue. (possible dupe?) Adding Cc: to Juergen Funk. https://cgit.freedesktop.org/libreoffice/core/commit/?id=d58bea0ffa2a2fe79103ab7aa743aea63e27a0fd author Juergen Funk2014-09-17 16:31:20 +0200 committer Samuel Mehrbrodt 2014-09-22 08:01:57 + Fix fdo#38884 Improve Up/Down movement in writer -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119635] Writer: incorrect cursor placement when moving to next paragraph after deleting text
https://bugs.documentfoundation.org/show_bug.cgi?id=119635 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=93 ||441 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
CppCheck Report Update
A new cppcheck report is available at : http://dev-builds.libreoffice.org/cppcheck_reports/master/ Note: The script generating this report was run at : 2019-17-11 03:05:06 with user buildslave at host vm140 as /home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s /home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w /home/buildslave/tmp/www It can be found and improved here: https://gerrit.libreoffice.org/plugins/gitiles/dev-tools/+/master/cppcheck/cppcheck-report.sh ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 128848] Cannot open for edit or save files on networked drive in Kubuntu/
https://bugs.documentfoundation.org/show_bug.cgi?id=128848 --- Comment #1 from Ted --- Version 6.2.8.2 exhibits the same problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128848] New: Cannot open for edit or save files on networked drive in Kubuntu/
https://bugs.documentfoundation.org/show_bug.cgi?id=128848 Bug ID: 128848 Summary: Cannot open for edit or save files on networked drive in Kubuntu/ Product: LibreOffice Version: 6.3.2.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rail.b...@att.net Description: When a file is opened on a network drive a locked by unknown user pops up and the option given to open read only or open a copy. When the copy is saved to the network drive an error occurs. If a locally created document is saved to the network drive the same error occurs. The setup is two computers running Kubuntu 19.10 on both machines. NFS network share over hardwired LAN shares drives on Computer A with Computer B. LibreOffice 6.3.2.2 was included in the distro. LibreOffice works fine on the local drives on both machines. Other applications including KiCAD, LibreCAD, Arduino and Kate can read/write over the network with no problems. There are NO .~lock files anywhere on either computer. Permissions are all good. The exports and fstab entries are all RW. FYI These two computers had been running Kubuntu 16:10 with the LibreOffice that came with it set up in a nearly identical network arrangement and it worked great. I just upgraded hard drives in both machines and did clean installs of the OS and apps. Steps to Reproduce: 1.Open file on networked drive. OR 2. Save file to networked drive. 3. Actual Results: Error message. Option to open read only or open copy. Error message on save. Expected Results: File would open for edit. Edited file would be saved. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Only Writer and Calc have been tested. As stated in description this set up worked with previous version of Kubuntu and LibreOffice. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128847] OutputDevice::GetPixel() not returning color on MacOS
https://bugs.documentfoundation.org/show_bug.cgi?id=128847 Chris Sherlock changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |chris.sherloc...@gmail.com |desktop.org | Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128847] New: OutputDevice::GetPixel() not returning color on MacOS
https://bugs.documentfoundation.org/show_bug.cgi?id=128847 Bug ID: 128847 Summary: OutputDevice::GetPixel() not returning color on MacOS Product: LibreOffice Version: unspecified Hardware: All OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: graphics stack Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: chris.sherloc...@gmail.com Description: It appears that for some time now we have not been able to use OutputDevice::GetPixel() on MacOS (I can say from at least Mojave, maybe longer). In fact, we have unit tests that show this already in vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx and vcl/qa/cppunit/outdev.cxx I am filing this as a bug. Steps to Reproduce: Without the #ifdefs around the tests to exclude MacOS, running make CppunitTest_vcl_bitmap_render_test with fail. Actual Results: GetPixel() returns wrong colour. Expected Results: GetPixel() should returns right colour. Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128827] 90 degree rotation of a table with a 1 cell text fails to rotate all characters.
https://bugs.documentfoundation.org/show_bug.cgi?id=128827 Regina Henschel changed: What|Removed |Added Ever confirmed|0 |1 CC||rb.hensc...@t-online.de Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Regina Henschel --- "rotate a table" is not possible in Writer. So please describe more exact what you are doing and please attach an example document. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128828] negative numbers (preceded by a -) are not wrapped correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=128828 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #2 from Regina Henschel --- In case you will not calculate with the numbers, you can use a 'non-breaking' hyphen with Ctrl+Shift+- or you use a true minus character, sign U+2212 from the subset 'Mathematical Operators'. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128846] Inconsistent behaviour of option "Expand References..."
https://bugs.documentfoundation.org/show_bug.cgi?id=128846 --- Comment #1 from Andreas Säger --- Created attachment 155885 --> https://bugs.documentfoundation.org/attachment.cgi?id=155885=edit Spreadsheet with total and a calculated field of running totals. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128846] New: Inconsistent behaviour of option "Expand References..."
https://bugs.documentfoundation.org/show_bug.cgi?id=128846 Bug ID: 128846 Summary: Inconsistent behaviour of option "Expand References..." Product: LibreOffice Version: 6.0 all versions Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ville...@t-online.de The following used to be the correct behaviour since the beginning of OpenOffice.org: WITHOUT option "Expand References" -- any insertion at the first row of the referenced range shifts down the reference. -- any insertion directly below the referenced just inserts cells _below_ the reference without affecting the reference. WITH option "Expand References" -- any insertion at the first row of the referenced range expands the reference. -- any insertion directly below the referenced expands the reference. In both cases any insertion between row #2 and the last row expands the reference. ### So far LibreOffice behaves consistently, nevertheless some flaw has been introduced in version 6, may be earlier. OpenOffice used to preserve the formulas adjacent to the inserted cells whereas LibreOffice consequently expands all references which flaws some calculated fields such as running totals. In the attached document, the last reference of the running total expands beyond the current row if "Expand References" is set. Formula in B11 =SUM($A$6:A11) becomes =SUM($A6:A12) although the cell B11 does not move. The not adjacent formula cell in B2 which calculates the overall =SUM($A$6:$A$11) expands to =SUM($A$6:$A$12) which is perfectly wanted behaviour. However, the adjacent calculated field should not change. This becomes more apparent when you turn on the R1C1 formula view. The entire calculated field is calculated as =SUM(R6C1:RC[-1]) describing the sum from absolute Row6,Col1 until THIS row, previous column. After inserting a new row, the last formula changes to =SUM(R6C1:R[1]C[-1]) describing the sum from absolute Row6,Col1 until NEXT row,previous column. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128829] a rotated table fails to retain the width, which then becomes length.
https://bugs.documentfoundation.org/show_bug.cgi?id=128829 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Regina Henschel --- "Rotate a table" is not possible in Writer. So the description is not clear. Please attach an example document. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126022] crash in drawinglayer when converting docx to odt
https://bugs.documentfoundation.org/show_bug.cgi?id=126022 Thorsten Behrens (CIB) changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |t...@libreoffice.org |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127234] I can't save result of QR-code generator to PNG with good quality
https://bugs.documentfoundation.org/show_bug.cgi?id=127234 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu Version|6.4.0.0.alpha1+ |4.2.0.4 release --- Comment #6 from Aron Budea --- Started in 4.2, but I can't start a lot of builds in that repo now, I get the following error message, and it quits: javaldx: Could not find a Java Runtime Environment! Warning: failed to read path from javaldx All I can say, the exported PNG is already bad at this commit: 6c3a09b3b3ca9ad0c81a55efaaedad35c39de767 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89241] Search arrows are disabled while the search field contains a string
https://bugs.documentfoundation.org/show_bug.cgi?id=89241 Muhammet Kara changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from Muhammet Kara --- Cannot reproduce with Version: 6.5.0.0.alpha0+ Build ID: 32c39e510aba585fd6675e3497e158efab74b8a4 CPU threads: 16; OS: Linux 5.3; UI render: default; VCL: x11; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded and Version: 6.5.0.0.alpha0+ Build ID: 32c39e510aba585fd6675e3497e158efab74b8a4 CPU threads: 16; OS: Linux 5.3; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded Seems like fixed at some point. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81545] Manual column break misplaced after copy-paste
https://bugs.documentfoundation.org/show_bug.cgi?id=81545 --- Comment #10 from Jean-Baptiste Faure --- Still reproducible in LO 6.3.4.0.0+ and LO 6.4.0.0.beta1+, both built at home under Ubuntu 18.04 x86-64. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128558] Firebird Embedded : Auto-numbering can be overwritten
https://bugs.documentfoundation.org/show_bug.cgi?id=128558 Robert Großkopf changed: What|Removed |Added CC||rob...@familiegrosskopf.de --- Comment #5 from Robert Großkopf --- Please don't mix different bug descriptions here. Autovalue could be overwritten: I tested the same with Base and MariaDB. You could set new values for a autoincremented value. Same with the internal HSQLDB. Problem I see in Firebird: If you change the value it isn't recognized by the incremented value. It won't be start with the new value +1. So there will appear an error if the value will get a duplicate. The incremented value will be set to value + 1 after this error. Comment 3 is a new bug. I would prefer to close this one and open two new descriptions. One for the duplicate, which will appear sometimes and on for the autoincrement, which won't count the same as MariaDB and HSQLDB. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125917] calc freezes when using data validity
https://bugs.documentfoundation.org/show_bug.cgi?id=125917 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu, ||caol...@redhat.com Version|6.2.4.2 release |5.3.0.3 release Keywords|bibisectRequest |bibisected, bisected --- Comment #6 from Aron Budea --- As a regression, this started with the following commit (bibisected using repo bibisect-linux-64-5.3). https://cgit.freedesktop.org/libreoffice/core/commit/?id=6b9f42ea1dc0926bc445982ad57bf93561f1bd03 author Caolán McNamara 2016-07-07 10:39:00 +0100 committer Caolán McNamara 2016-07-07 15:57:01 + "Resolves: rhbz#1351224 wayland grab related crashes" However, my opinion is that the original flow of events isn't correct, because previously this is what happened after entering a wrong value, and choosing one from the list: - right away, nothing, - after clicking away, a dialog popped up: Invalid value, - after pressing OK, the chosen value was entered in the cell. My expectation would be: - the chosen value is entered in the cell, and no error popup is displayed, as it's a valid value. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123489] Customized ~ "Automatically move to the next one after joining", "Do not repeat"
https://bugs.documentfoundation.org/show_bug.cgi?id=123489 Muhammet Kara changed: What|Removed |Added CC||heiko.tietze@documentfounda ||tion.org, ||muhammet.k...@collabora.com Keywords||needsUXEval --- Comment #4 from Muhammet Kara --- I would call these behavior design rather than feature. Actually we have the "do not repeat" part in menus, but not in toolbars, and that is by choice. So should we move to the next item on the functions list after an "add" operation? We need to decide that. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 3 commits - bean/com sc/source vcl/source
bean/com/sun/star/comp/beans/OOoBean.java |6 +-
sc/source/filter/excel/xistring.cxx |2 +-
vcl/source/gdi/FileDefinitionWidgetDraw.cxx |7 ++-
3 files changed, 12 insertions(+), 3 deletions(-)
New commits:
commit 46920005f74edcb70acfb8dd1a0ffb9553e5c2b2
Author: Caolán McNamara
AuthorDate: Sat Nov 16 17:22:22 2019 +
Commit: Caolán McNamara
CommitDate: Sat Nov 16 20:25:07 2019 +0100
cid#1448516 silence Dereference null return value
Change-Id: Ifb7e14183e97c225ed7e68f93e6142d10c4a87b0
Reviewed-on: https://gerrit.libreoffice.org/82991
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/bean/com/sun/star/comp/beans/OOoBean.java
b/bean/com/sun/star/comp/beans/OOoBean.java
index 0345d48ca45e..3475447368e4 100644
--- a/bean/com/sun/star/comp/beans/OOoBean.java
+++ b/bean/com/sun/star/comp/beans/OOoBean.java
@@ -291,12 +291,16 @@ public class OOoBean
// avoid concurrent access from multiple threads
final OfficeConnection iConn = getOOoConnection();
+com.sun.star.uno.XComponentContext xComponentContext =
iConn.getComponentContext();
+if (xComponentContext == null)
+throw new NoConnectionException();
+
Thread aConnectorThread = new Thread("getServiceManager") {
@Override
public void run()
{
com.sun.star.lang.XMultiComponentFactory aFactory =
-iConn.getComponentContext().getServiceManager();
+xComponentContext.getServiceManager();
xServiceFactory = UnoRuntime.queryInterface(
com.sun.star.lang.XMultiServiceFactory.class, aFactory
);
}
commit 9aab980711f82471b012b1691699d9a28ef836f5
Author: Tomaž Vajngerl
AuthorDate: Sat Nov 16 11:01:38 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Sat Nov 16 20:25:02 2019 +0100
widget theme: allow for default "stacked" spinbuttons
Change-Id: I2943616a641de72a615f57784e8a9927c12edcf7
Reviewed-on: https://gerrit.libreoffice.org/82979
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
index 0eb0484d4cbe..3d650719eb79 100644
--- a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
+++ b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
@@ -737,9 +737,14 @@ bool FileDefinitionWidgetDraw::getNativeControlRegion(
auto const& pEntirePart
= m_pWidgetDefinition->getDefinition(eType,
ControlPart::Entire);
+
OString sOrientation = pEntirePart->msOrientation;
-if (sOrientation.isEmpty() || sOrientation ==
"decrease-edit-increase")
+if (sOrientation.isEmpty() || sOrientation == "stacked")
+{
+return false;
+}
+else if (sOrientation == "decrease-edit-increase")
{
if (ePart == ControlPart::ButtonUp)
{
commit d6f00ac943fbcdc56e828db0c9ff96337c1e74f7
Author: Caolán McNamara
AuthorDate: Sat Nov 16 17:44:17 2019 +
Commit: Caolán McNamara
CommitDate: Sat Nov 16 20:24:51 2019 +0100
cid#1448453 Untrusted value as argument
coverity doesn't warn about XclImpString::ReadFormats
Change-Id: Ide6285f39fed09a1767c2a2272f30ec213a20106
Reviewed-on: https://gerrit.libreoffice.org/82993
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/filter/excel/xistring.cxx
b/sc/source/filter/excel/xistring.cxx
index 4b06f3447978..096507ba8351 100644
--- a/sc/source/filter/excel/xistring.cxx
+++ b/sc/source/filter/excel/xistring.cxx
@@ -80,7 +80,7 @@ void XclImpString::Read( XclImpStream& rStrm, XclStrFlags
nFlags )
maString = rStrm.ReadRawUniString( nChars, b16Bit );
// --- formatting ---
-if( nRunCount > 0 )
+if (nRunCount)
ReadFormats( rStrm, maFormats, nRunCount );
// --- extended (FarEast) information ---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: bean/com
bean/com/sun/star/comp/beans/OOoBean.java |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
New commits:
commit cd173ae7d6646eec21bc3937fc23676b3daab0ff
Author: Caolán McNamara
AuthorDate: Sat Nov 16 17:52:23 2019 +
Commit: Caolán McNamara
CommitDate: Sat Nov 16 20:23:44 2019 +0100
cid#1448226 silence RV: Bad use of return value
Change-Id: Ie85ea159ebed117c11a1d5d67c4292be8ca5b8e8
Reviewed-on: https://gerrit.libreoffice.org/82994
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/bean/com/sun/star/comp/beans/OOoBean.java
b/bean/com/sun/star/comp/beans/OOoBean.java
index 742b7dc2e32b..0345d48ca45e 100644
--- a/bean/com/sun/star/comp/beans/OOoBean.java
+++ b/bean/com/sun/star/comp/beans/OOoBean.java
@@ -655,7 +655,10 @@ public class OOoBean
{
// reactivate old document
if ( aFrame != null && aFrame.getController() != null )
-aFrame.getController().suspend(false);
+{
+boolean bResult =
aFrame.getController().suspend(false);
+dbgPrint( "loadFromURL() .. suspend() -> " +
bResult );
+}
aDocument.setModified(true);
// throw exception
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 3 commits - chart2/source qadevOOo/tests sfx2/source
chart2/source/controller/dialogs/dlg_CreationWizard.cxx |7 ---
qadevOOo/tests/java/ifc/frame/_XController.java |3 ++-
sfx2/source/control/request.cxx | 14 +-
3 files changed, 15 insertions(+), 9 deletions(-)
New commits:
commit 31fd3641b363c81ab23e10e6425a39e27a224c3d
Author: Caolán McNamara
AuthorDate: Sat Nov 16 16:40:33 2019 +
Commit: Caolán McNamara
CommitDate: Sat Nov 16 20:24:33 2019 +0100
cid#1453998 Wrapper object use after free
Change-Id: I1dc733e72ba63db1eaa20113a7599ea7580eef31
Reviewed-on: https://gerrit.libreoffice.org/82988
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/chart2/source/controller/dialogs/dlg_CreationWizard.cxx
b/chart2/source/controller/dialogs/dlg_CreationWizard.cxx
index ccf2cdc5221f..2bdedc962856 100644
--- a/chart2/source/controller/dialogs/dlg_CreationWizard.cxx
+++ b/chart2/source/controller/dialogs/dlg_CreationWizard.cxx
@@ -68,6 +68,10 @@ CreationWizard::CreationWizard(weld::Window* pParent, const
uno::Reference(GetOrCreatePage(STATE_CHARTTYPE));
+assert(m_pTemplateProvider && "must exist");
+m_pDialogModel->setTemplate(m_pTemplateProvider->getCurrentTemplate());
+
SetRoadmapHelpId(HID_SCH_WIZARD_ROADMAP);
if (!m_pDialogModel->getModel().isDataFromSpreadsheet())
@@ -97,9 +101,6 @@ std::unique_ptr
CreationWizard::createPage(WizardState nState)
{
m_aTimerTriggeredControllerLock.startTimer();
xRet = std::make_unique(pPageContainer, this,
m_xChartModel);
-m_pTemplateProvider = static_cast(xRet.get());
-if (m_pDialogModel)
-m_pDialogModel->setTemplate(
m_pTemplateProvider->getCurrentTemplate());
break;
}
case STATE_SIMPLE_RANGE:
commit 591c305541306d41d3777ad5e2c92f875072e2d9
Author: Caolán McNamara
AuthorDate: Sat Nov 16 17:54:26 2019 +
Commit: Caolán McNamara
CommitDate: Sat Nov 16 20:24:16 2019 +0100
cid#1448447 silence RV: Bad use of return value
Change-Id: If24d5fffb4ecf86fa6a43d824b5e40fcef29a691
Reviewed-on: https://gerrit.libreoffice.org/82995
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/qadevOOo/tests/java/ifc/frame/_XController.java
b/qadevOOo/tests/java/ifc/frame/_XController.java
index af467456e9e6..0419976a8ca2 100644
--- a/qadevOOo/tests/java/ifc/frame/_XController.java
+++ b/qadevOOo/tests/java/ifc/frame/_XController.java
@@ -153,7 +153,8 @@ public class _XController extends MultiMethodTest {
log.println("as expected, see #82938");
}
tRes.tested("attachModel()", result);
-oObj.attachModel(firstModel);
+boolean bResult = oObj.attachModel(firstModel);
+log.println("attachModel() --> " + bResult);
}
/**
commit 2d6f56e4f7e492ba5394a86f13bc710bf6c68335
Author: Caolán McNamara
AuthorDate: Sat Nov 16 16:30:59 2019 +
Commit: Caolán McNamara
CommitDate: Sat Nov 16 20:24:02 2019 +0100
cid#1455212 Uncaught exception
Change-Id: I75956bfc3dccdf3ef400c3b9dcea40606abb8504
Reviewed-on: https://gerrit.libreoffice.org/82987
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sfx2/source/control/request.cxx b/sfx2/source/control/request.cxx
index fcdb5c036f32..ec3d36eb4467 100644
--- a/sfx2/source/control/request.cxx
+++ b/sfx2/source/control/request.cxx
@@ -74,7 +74,7 @@ struct SfxRequest_Impl: public SfxListener
SfxViewFrame* pViewFrame;
css::uno::Reference< css::frame::XDispatchRecorder > xRecorder;
-css::uno::Reference< uno::XComponentContext > xContext;
+css::uno::Reference< css::util::XURLTransformer > xTransform;
explicit SfxRequest_Impl( SfxRequest *pOwner )
: pAnti( pOwner)
@@ -88,7 +88,6 @@ struct SfxRequest_Impl: public SfxListener
, nCallMode( SfxCallMode::SYNCHRON )
, bAllowRecording( false )
, pViewFrame(nullptr)
-, xContext(comphelper::getProcessComponentContext())
{
}
@@ -167,6 +166,8 @@ SfxRequest::SfxRequest
{
pImpl->SetPool( >pShell->GetPool() );
pImpl->xRecorder = SfxRequest::GetMacroRecorder(pImpl->pViewFrame);
+if (pImpl->xRecorder)
+pImpl->xTransform =
util::URLTransformer::create(comphelper::getProcessComponentContext());
pImpl->aTarget = pImpl->pShell->GetName();
}
else
@@ -206,6 +207,8 @@ SfxRequest::SfxRequest
{
pImpl->SetPool( >pShell->GetPool() );
pImpl->xRecorder = SfxRequest::GetMacroRecorder( pViewFrame );
+if (pImpl->xRecorder)
+pImpl->xTransform =
util::URLTransformer::create(comphelper::getProcessComponentContext());
pImpl->aTarget = pImpl->pShell->GetName();
}
else
@@ -333,10 +336,11 @@ void SfxRequest_Impl::Record
*/
[Libreoffice-commits] core.git: accessibility/source compilerplugins/clang include/vcl vcl/inc vcl/source
accessibility/source/extended/accessibletablistboxtable.cxx | 56 --
compilerplugins/clang/singlevalfields.could-be-bool.results | 18
compilerplugins/clang/singlevalfields.py|2
compilerplugins/clang/singlevalfields.results | 280 ++--
include/vcl/svtabbx.hxx |2
include/vcl/treelistbox.hxx |2
vcl/inc/svimpbox.hxx|3
vcl/source/treelist/svimpbox.cxx|1
vcl/source/treelist/svtabbx.cxx | 45 -
vcl/source/treelist/treelistbox.cxx | 10
10 files changed, 171 insertions(+), 248 deletions(-)
New commits:
commit 5b374877b573cf716123a0d0c04a84ccc91e8c86
Author: Noel Grandin
AuthorDate: Sat Nov 16 13:49:37 2019 +0200
Commit: Noel Grandin
CommitDate: Sat Nov 16 20:19:54 2019 +0100
loplugin:singlevalfields
Change-Id: I31fd6b251dee9d1ee1a9ac59964034d0136e1f3e
Reviewed-on: https://gerrit.libreoffice.org/82978
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/accessibility/source/extended/accessibletablistboxtable.cxx
b/accessibility/source/extended/accessibletablistboxtable.cxx
index 20548bab8b6a..0ae2fa008a92 100644
--- a/accessibility/source/extended/accessibletablistboxtable.cxx
+++ b/accessibility/source/extended/accessibletablistboxtable.cxx
@@ -105,29 +105,8 @@ namespace accessibility
Reference< XAccessible > xChild =
m_pTabListBox->CreateAccessibleCell( nRow,
nCol );
uno::Any aOldValue, aNewValue;
-
-if ( m_pTabListBox->IsTransientChildrenDisabled() )
-{
-aNewValue <<= AccessibleStateType::FOCUSED;
-TriState eState = TRISTATE_INDET;
-if ( m_pTabListBox->IsCellCheckBox( nRow,
nCol, eState ) )
-{
-AccessibleCheckBoxCell* pCell =
-static_cast< AccessibleCheckBoxCell*
>( xChild.get() );
-pCell->commitEvent(
AccessibleEventId::STATE_CHANGED, aNewValue, aOldValue );
-}
-else
-{
-AccessibleBrowseBoxTableCell* pCell =
-static_cast<
AccessibleBrowseBoxTableCell* >( xChild.get() );
-pCell->commitEvent(
AccessibleEventId::STATE_CHANGED, aNewValue, aOldValue );
-}
-}
-else
-{
-aNewValue <<= xChild;
-commitEvent(
AccessibleEventId::ACTIVE_DESCENDANT_CHANGED, aNewValue, aOldValue );
-}
+aNewValue <<= xChild;
+commitEvent(
AccessibleEventId::ACTIVE_DESCENDANT_CHANGED, aNewValue, aOldValue );
}
}
break;
@@ -215,37 +194,6 @@ namespace accessibility
case VclEventId::TableCellNameChanged :
{
-if ( m_pTabListBox->IsTransientChildrenDisabled() )
-{
-commitEvent( AccessibleEventId::SELECTION_CHANGED,
Any(), Any() );
-TabListBoxEventData* pData = static_cast<
TabListBoxEventData* >( rVclWindowEvent.GetData() );
-SvTreeListEntry* pEntry = pData != nullptr ?
pData->m_pEntry : nullptr;
-if ( pEntry )
-{
-sal_Int32 nRow = m_pTabListBox->GetEntryPos(
pEntry );
-sal_uInt16 nCol = pData->m_nColumn;
-Reference< XAccessible > xChild =
-m_pTabListBox->CreateAccessibleCell( nRow,
nCol );
-uno::Any aOldValue, aNewValue;
-aOldValue <<= pData->m_sOldText;
-OUString sNewText( m_pTabListBox->GetCellText(
nRow, nCol ) );
-aNewValue <<= sNewText;
-TriState eState = TRISTATE_INDET;
-
-if ( m_pTabListBox->IsCellCheckBox( nRow, nCol,
eState ) )
-{
-AccessibleCheckBoxCell* pCell =
-static_cast< AccessibleCheckBoxCell* >(
xChild.get() );
-pCell->commitEvent(
AccessibleEventId::NAME_CHANGED, aNewValue, aOldValue );
-
[Libreoffice-bugs] [Bug 128845] EDITING: cannot modify a bibliography entry after creating it
https://bugs.documentfoundation.org/show_bug.cgi?id=128845 aldr...@yahoo.com changed: What|Removed |Added Ever confirmed|0 |1 Version|unspecified |6.3.1.2 release Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128845] New: EDITING: cannot modify a bibliography entry after creating it
https://bugs.documentfoundation.org/show_bug.cgi?id=128845 Bug ID: 128845 Summary: EDITING: cannot modify a bibliography entry after creating it Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: aldr...@yahoo.com 1. insert bibliography entry, choose "from document content", click "New" 2. fill-in the short name and type 3. click OK then Insert. Now you have a bibliography entry. If you want to modify it (like fill-in a new field) it doesn't work: 1. right-click on the bibliography entry created above 2. choose "bibliography entry" from the menu 3. click edit and fill-in a new field or modify an already filled-in one. 4. click OK, click Apply. At this point your modifications should be saved in the entry, but in fact, they are ignored. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sax/source sw/qa writerfilter/source
sax/source/fastparser/fastparser.cxx | 14
sw/qa/extras/ooxmlexport/data/tdf128820.fodt | 1353 --
writerfilter/source/dmapper/DomainMapper_Impl.cxx | 13
writerfilter/source/dmapper/PropertyMap.cxx | 11
4 files changed, 41 insertions(+), 1350 deletions(-)
New commits:
commit 9fdf8c0a5cc036ea9bd1e11dd8f2c1a6e601fae2
Author: Mike Kaganski
AuthorDate: Sat Nov 16 16:34:25 2019 +0300
Commit: Mike Kaganski
CommitDate: Sat Nov 16 20:13:40 2019 +0100
Also consider saved exceptions when terminating parse
As with previous commit 18ae77a065cb8ae6940d4067f6ab7e99a3f74047, this
will start showing parse errors on invalid files which previously just
opened without warnings, silently losing the invalid stream part. Any
bug bisected to this commit is not a regression from this commit! The
real problem was already before, and was just disclosed by this (which
is the actual goal).
Also simplify unit test data for tdf#128820, which will now be enough
after the change.
A unit test (testN779627) revealed unexpected throws when parsing; this
was fixed.
Change-Id: I5a21b9001874ec6e3b8273c10043ef930bf1cc82
Reviewed-on: https://gerrit.libreoffice.org/82981
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sax/source/fastparser/fastparser.cxx
b/sax/source/fastparser/fastparser.cxx
index 7383b8c339ea..9b35c1682be5 100644
--- a/sax/source/fastparser/fastparser.cxx
+++ b/sax/source/fastparser/fastparser.cxx
@@ -175,6 +175,8 @@ struct Entity : public ParserData
css::uno::Any maSavedException;
osl::Mutex maSavedExceptionMutex;
void saveException( const Any & e );
+// Thread-safe check if maSavedException has value
+bool hasException();
void throwException( const ::rtl::Reference< FastLocatorImpl >
,
bool mbDuringParse );
@@ -622,6 +624,12 @@ void Entity::saveException( const Any & e )
}
}
+bool Entity::hasException()
+{
+osl::MutexGuard g(maSavedExceptionMutex);
+return maSavedException.hasValue();
+}
+
} // namespace
namespace sax_fastparser {
@@ -1040,6 +1048,8 @@ void FastSaxParserImpl::parse()
{
if( xmlParseChunk( rEntity.mpParser, reinterpret_cast(seqOut.getConstArray()), 0, 1 ) != XML_ERR_OK )
rEntity.throwException( mxDocumentLocator, true );
+if (rEntity.hasException())
+rEntity.throwException(mxDocumentLocator, true);
}
break;
}
@@ -1068,10 +1078,8 @@ void FastSaxParserImpl::parse()
{
rEntity.throwException( mxDocumentLocator, true );
}
-osl::ClearableMutexGuard g(rEntity.maSavedExceptionMutex);
-if (rEntity.maSavedException.hasValue())
+if (rEntity.hasException())
{
-g.clear();
rEntity.throwException( mxDocumentLocator, true );
}
} while( nRead > 0 );
diff --git a/sw/qa/extras/ooxmlexport/data/tdf128820.fodt
b/sw/qa/extras/ooxmlexport/data/tdf128820.fodt
index bb39fee02534..576fd966e28d 100644
--- a/sw/qa/extras/ooxmlexport/data/tdf128820.fodt
+++ b/sw/qa/extras/ooxmlexport/data/tdf128820.fodt
@@ -1,1353 +1,16 @@
-http://openoffice.org/2004/office;
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0"
xmlns:xlink="http://www.w3.org/1999/xlink;
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0"
xmlns:dc="http://purl.org/dc/elements/1.1/;
xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0"
xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0"
xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0"
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0"
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0"
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0"
xmlns:rpt="http://openoffice.org/2005/report;
xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0"
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0"
xmlns:ooow="http://openoffice.org/200
4/writer" xmlns:oooc="http://openoffice.org/2004/calc;
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2"
xmlns:css3t="http://www.w3.org/TR/css3-text/;
xmlns:tableooo="http://openoffice.org/2009/table;
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
xmlns:drawooo="http://openoffice.org/2010/draw;
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
xmlns:grddl="http://www.w3.org/2003/g/data-view#;
xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0"
xmlns:math="http://www.w3.org/1998/Math/MathML;
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0"
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0"
xmlns:dom="http://www.w3.org/2001/xml-events;
[Libreoffice-bugs] [Bug 121412] Minimal extensions no longer shows its toolbar and menu config
https://bugs.documentfoundation.org/show_bug.cgi?id=121412 --- Comment #6 from Thorsten Behrens (CIB) --- Anyone still planning to change this? Otherwise, let's close as WONTFIX, at least the starter extension is adapted now. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128257] Impress bullets dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128257 --- Comment #6 from Heiko Tietze --- 6.4 / 6.5 are quite mixed here. Backport the latest patch and resolve as fixed? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128257] Impress bullets dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128257 --- Comment #6 from Heiko Tietze --- 6.4 / 6.5 are quite mixed here. Backport the latest patch and resolve as fixed? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 128841] In the dialog windoe "tip of the day" the text in in one line, no markup.
https://bugs.documentfoundation.org/show_bug.cgi?id=128841 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Heiko Tietze --- Yes, the patch didn't make it into the 6.3 branch (done now) and we got a lot of duplicate issues on this. Thanks for reporting. *** This bug has been marked as a duplicate of bug 128524 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128842] SLIDESHOW: presenter console overlaps presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=128842 Robert Großkopf changed: What|Removed |Added Keywords||regression Ever confirmed|0 |1 CC||rob...@familiegrosskopf.de Status|UNCONFIRMED |NEW --- Comment #1 from Robert Großkopf --- Could confirm the buggy behaviour. Have tested with a simple impress-file and LO 6.3.3.2., VCL:kde5. Slide show settings have been set to "Presentation display: Auto External(Display 2) - but nothing could be seen there. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/control/Control.PartsPreview.js | 46 +-
1 file changed, 24 insertions(+), 22 deletions(-)
New commits:
commit acb4f87bd48b71386afeb4b92ba5f8e827415411
Author: Henry Castro
AuthorDate: Sat Nov 16 13:01:58 2019 -0400
Commit: Henry Castro
CommitDate: Sat Nov 16 19:28:44 2019 +0100
loleaflet: defer request preview thumbnail task
When mCustomScrollbar fires onScroll then queue the task to run as soon
as the current synchronizing code.
Change-Id: I761937a0ad181a42b592ad953cc7b83ea73a1b21
Reviewed-on: https://gerrit.libreoffice.org/82990
Reviewed-by: Henry Castro
Tested-by: Henry Castro
diff --git a/loleaflet/src/control/Control.PartsPreview.js
b/loleaflet/src/control/Control.PartsPreview.js
index 1dfa77f84..9a52aeb10 100644
--- a/loleaflet/src/control/Control.PartsPreview.js
+++ b/loleaflet/src/control/Control.PartsPreview.js
@@ -393,34 +393,36 @@ L.Control.PartsPreview = L.Control.extend({
},
_onScroll: function (e) {
- var scrollOffset = 0;
- if (e) {
- var prevScrollY = this._scrollY;
- this._scrollY = this._direction === 'x' ? -e.mcs.left :
-e.mcs.top;
- scrollOffset = this._scrollY - prevScrollY;
- }
+ setTimeout(L.bind(function (e) {
+ var scrollOffset = 0;
+ if (e) {
+ var prevScrollY = this._scrollY;
+ this._scrollY = this._direction === 'x' ?
-e.mcs.left : -e.mcs.top;
+ scrollOffset = this._scrollY - prevScrollY;
+ }
- var previewContBB =
this._partsPreviewCont.getBoundingClientRect();
- var extra = this._direction === 'x' ? previewContBB.width :
previewContBB.height;
- var topBound = this._previewContTop - (scrollOffset < 0 ? extra
: extra / 2);
- var bottomBound = this._previewContTop + extra + (scrollOffset
> 0 ? extra : extra / 2);
- for (var i = 0; i < this._previewTiles.length; ++i) {
- var img = this._previewTiles[i];
- if (img && img.parentNode && !img.fetched) {
- var previewFrameBB =
img.parentNode.getBoundingClientRect();
- if (this._direction === 'x') {
- if ((previewFrameBB.left >= topBound &&
previewFrameBB.left <= bottomBound)
- || (previewFrameBB.right >= topBound &&
previewFrameBB.right <= bottomBound)) {
+ var previewContBB =
this._partsPreviewCont.getBoundingClientRect();
+ var extra = this._direction === 'x' ?
previewContBB.width : previewContBB.height;
+ var topBound = this._previewContTop - (scrollOffset < 0
? extra : extra / 2);
+ var bottomBound = this._previewContTop + extra +
(scrollOffset > 0 ? extra : extra / 2);
+ for (var i = 0; i < this._previewTiles.length; ++i) {
+ var img = this._previewTiles[i];
+ if (img && img.parentNode && !img.fetched) {
+ var previewFrameBB =
img.parentNode.getBoundingClientRect();
+ if (this._direction === 'x') {
+ if ((previewFrameBB.left >=
topBound && previewFrameBB.left <= bottomBound)
+ || (previewFrameBB.right >=
topBound && previewFrameBB.right <= bottomBound)) {
+ this._map.getPreview(i,
i, this.options.maxWidth, this.options.maxHeight, {autoUpdate:
this.options.autoUpdate});
+ img.fetched = true;
+ }
+ } else if ((previewFrameBB.top >=
topBound && previewFrameBB.top <= bottomBound)
+ || (previewFrameBB.bottom >=
topBound && previewFrameBB.bottom <= bottomBound)) {
this._map.getPreview(i, i,
this.options.maxWidth, this.options.maxHeight, {autoUpdate:
this.options.autoUpdate});
img.fetched = true;
}
- } else if ((previewFrameBB.top >= topBound &&
previewFrameBB.top <= bottomBound)
- || (previewFrameBB.bottom >= topBound
&& previewFrameBB.bottom <= bottomBound)) {
- this._map.getPreview(i, i,
this.options.maxWidth, this.options.maxHeight, {autoUpdate:
this.options.autoUpdate});
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/control/Control.PartsPreview.js |1 -
loleaflet/src/layer/tile/ImpressTileLayer.js | 10 +-
2 files changed, 5 insertions(+), 6 deletions(-)
New commits:
commit 0d734b2aaeae6cb6154b3cdbd3d2093ad9ef3a8f
Author: Henry Castro
AuthorDate: Sat Nov 16 13:49:58 2019 -0400
Commit: Henry Castro
CommitDate: Sat Nov 16 19:29:15 2019 +0100
loleaflet: avoid using $.data jquery function
I am personally not agree to use "jquery" functions in src/* source
code, but there are some "jquery" library components (i.e.
"mCustomScrollbar") that it is dependent it, however let's minimize the
use of "jquery" functions.
Change-Id: Ic64c12d966a6215acfa900cdc05e5ddb84026f79
Reviewed-on: https://gerrit.libreoffice.org/82996
Reviewed-by: Henry Castro
Tested-by: Henry Castro
diff --git a/loleaflet/src/control/Control.PartsPreview.js
b/loleaflet/src/control/Control.PartsPreview.js
index 9a52aeb10..ddc9c6041 100644
--- a/loleaflet/src/control/Control.PartsPreview.js
+++ b/loleaflet/src/control/Control.PartsPreview.js
@@ -58,7 +58,6 @@ L.Control.PartsPreview = L.Control.extend({
}
}
});
- $(this._partsPreviewCont).data('preview', this);
},
_updateDisabled: function (e) {
diff --git a/loleaflet/src/layer/tile/ImpressTileLayer.js
b/loleaflet/src/layer/tile/ImpressTileLayer.js
index d35df5aaa..632dc51ce 100644
--- a/loleaflet/src/layer/tile/ImpressTileLayer.js
+++ b/loleaflet/src/layer/tile/ImpressTileLayer.js
@@ -10,6 +10,7 @@ L.ImpressTileLayer = L.TileLayer.extend({
initialize: function (url, options) {
L.TileLayer.prototype.initialize.call(this, url, options);
+ this._preview = L.control.partsPreview();
if (window.mode.isMobile()) {
this._addButton = L.control.mobileSlide();
@@ -37,7 +38,7 @@ L.ImpressTileLayer = L.TileLayer.extend({
},
beforeAdd: function (map) {
- map.addControl(L.control.partsPreview());
+ map.addControl(this._preview);
map.on('zoomend', this._onAnnotationZoom, this);
map.on('updateparts', this.onUpdateParts, this);
map.on('updatepermission', this.onUpdatePermission, this);
@@ -425,18 +426,17 @@ L.ImpressTileLayer = L.TileLayer.extend({
onOrientationChange: function () {
var container = L.DomUtil.get('presentation-controls-wrapper');
var preview = L.DomUtil.get('slide-sorter');
- var control = $(preview).data('preview');
- if (!container || !preview || !control) {
+ if (!container || !preview) {
return;
}
if (L.DomUtil.isPortrait() && $(preview).data('mCS').opt.axis
!== 'x') {
$(preview).mCustomScrollbar('destroy');
- control.createScrollbar('x');
+ this._preview.createScrollbar('x');
} else if (L.DomUtil.isLandscape() &&
$(preview).data('mCS').opt.axis !== 'y') {
$(preview).mCustomScrollbar('destroy');
- control.createScrollbar('y');
+ this._preview.createScrollbar('y');
}
},
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: 2 commits - loleaflet/js
loleaflet/js/jquery.mCustomScrollbar.js | 44 +---
1 file changed, 24 insertions(+), 20 deletions(-)
New commits:
commit 59d3c2d20da32049b62293c01a5329e07bac0895
Author: Henry Castro
AuthorDate: Fri Nov 15 10:14:25 2019 -0400
Commit: Henry Castro
CommitDate: Sat Nov 16 19:28:13 2019 +0100
mCustomScrollbar: remove unnecessary access to Window top property
When the frame is null, it is referring to a container frame window that
it is always not accessible.
Change-Id: Ie96a05327928b2b72ce5577409e368061b2afa1e
Reviewed-on: https://gerrit.libreoffice.org/82798
Reviewed-by: Henry Castro
Tested-by: Henry Castro
diff --git a/loleaflet/js/jquery.mCustomScrollbar.js
b/loleaflet/js/jquery.mCustomScrollbar.js
index d91b86108..b2c91c88e 100644
--- a/loleaflet/js/jquery.mCustomScrollbar.js
+++ b/loleaflet/js/jquery.mCustomScrollbar.js
@@ -1544,10 +1544,6 @@ and dependencies (minified).
_canAccessIFrame=function(iframe){
var html=null;
if(!iframe){
- try{
- var doc=top.document;
- html=doc.body.innerHTML;
- }catch(err){/* do nothing */}
return(html!==null);
}else{
try{
commit cb7813ef351fd44b265f96bdb646cb4cfe89fd65
Author: Henry Castro
AuthorDate: Fri Nov 15 09:18:32 2019 -0400
Commit: Henry Castro
CommitDate: Sat Nov 16 19:28:01 2019 +0100
mCustomScrollbar: reduce the number of _coordinates function calls
The _coordinates function is called several times to compute
the same coordinate value.
Change-Id: I6e187b74709515ddde77d60649e564cb2b484fb4
Reviewed-on: https://gerrit.libreoffice.org/82797
Reviewed-by: Henry Castro
Tested-by: Henry Castro
diff --git a/loleaflet/js/jquery.mCustomScrollbar.js
b/loleaflet/js/jquery.mCustomScrollbar.js
index 14bf9d9a2..d91b86108 100644
--- a/loleaflet/js/jquery.mCustomScrollbar.js
+++ b/loleaflet/js/jquery.mCustomScrollbar.js
@@ -1218,7 +1218,8 @@ and dependencies (minified).
_iframe(false); /* enable scrollbar dragging
over iframes by disabling their events */
_stop($this);
draggable=$(this);
- var
offset=draggable.offset(),y=_coordinates(e)[0]-offset.top,x=_coordinates(e)[1]-offset.left,
+ var coordinates = _coordinates(e);
+ var
offset=draggable.offset(),y=coordinates[0]-offset.top,x=coordinates[1]-offset.left,
h=draggable.height()+offset.top,w=draggable.width()+offset.left;
if(y0 && x0){
dragY=y;
@@ -1228,12 +1229,14 @@ and dependencies (minified).
}).bind("touchmove."+namespace,function(e){
e.stopImmediatePropagation();
e.preventDefault();
- var
offset=draggable.offset(),y=_coordinates(e)[0]-offset.top,x=_coordinates(e)[1]-offset.left;
+ var coordinates = _coordinates(e);
+ var
offset=draggable.offset(),y=coordinates[0]-offset.top,x=coordinates[1]-offset.left;
_drag(dragY,dragX,y,x);
});
$(document).add(eds).bind("mousemove."+namespace+"
pointermove."+namespace+" MSPointerMove."+namespace,function(e){
if(draggable){
- var
offset=draggable.offset(),y=_coordinates(e)[0]-offset.top,x=_coordinates(e)[1]-offset.left;
+ var coordinates = _coordinates(e);
+ var
offset=draggable.offset(),y=coordinates[0]-offset.top,x=coordinates[1]-offset.left;
if(dragY===y && dragX===x){return;} /*
has it really moved? */
_drag(dragY,dragX,y,x);
}
@@ -1313,26 +1316,28 @@ and dependencies (minified).
});
}
function _onTouchstart(e){
- if(!_pointerTouch(e) || touchActive ||
_coordinates(e)[2]){touchable=0; return;}
+ var coordinates = _coordinates(e);
+ if(!_pointerTouch(e) || touchActive ||
coordinates[2]){touchable=0; return;}
touchable=1; touchDrag=0; docDrag=0;
draggable=1;
$this.removeClass("mCS_touch_action");
[Libreoffice-commits] online.git: loleaflet/js
loleaflet/js/jquery.mCustomScrollbar.js | 25 +++--
1 file changed, 19 insertions(+), 6 deletions(-)
New commits:
commit 2644c113c2b6c839793c9221d735de5e21cc76ed
Author: Henry Castro
AuthorDate: Fri Nov 15 10:13:10 2019 -0400
Commit: Henry Castro
CommitDate: Sat Nov 16 19:28:31 2019 +0100
mCustomScrollbar: add event listener to pointer or touch events
Some mobile devices support both pointer and touch events,
so if we add event listener it will fire 2 times.
Change-Id: Ida9862e9ee24e47ccbe3963b5c4ff18a173fffe0
Reviewed-on: https://gerrit.libreoffice.org/82799
Reviewed-by: Henry Castro
Tested-by: Henry Castro
diff --git a/loleaflet/js/jquery.mCustomScrollbar.js
b/loleaflet/js/jquery.mCustomScrollbar.js
index b2c91c88e..42876a14e 100644
--- a/loleaflet/js/jquery.mCustomScrollbar.js
+++ b/loleaflet/js/jquery.mCustomScrollbar.js
@@ -1267,7 +1267,24 @@ and dependencies (minified).
},
/* */
-
+ _getTouchEvents=function(namespace){
+ var eventStart, eventMove, eventEnd;
+ if ('ontouchstart' in window){
+ eventStart = "touchstart."+namespace;
+ eventMove = "touchmove."+namespace;
+ eventEnd = "touchend."+namespace;
+ } else if (window.MSPointerEvent){
+ eventStart = "MSPointerDown."+namespace;
+ eventMove = "MSPointerMove."+namespace;
+ eventEnd = "MSPointerUp."+namespace;
+ } else if (window.PointerEvent){
+ eventStart = "pointerdown."+namespace;
+ eventMove = "pointermove."+namespace;
+ eventEnd = "pointerup."+namespace;
+ }
+ return [eventStart, eventMove, eventEnd];
+ },
+
/*
TOUCH SWIPE EVENTS
scrolls content via touch swipe
@@ -1282,11 +1299,7 @@ and dependencies (minified).
draggable,dragY,dragX,touchStartY,touchStartX,touchMoveY=[],touchMoveX=[],startTime,runningTime,endTime,distance,speed,amount,
durA=0,durB,overwrite=o.axis==="yx" ? "none" :
"all",touchIntent=[],touchDrag,docDrag,
iframe=mCSB_container.find("iframe"),
- events=[
- "touchstart."+namespace+"
pointerdown."+namespace+" MSPointerDown."+namespace, //start
- "touchmove."+namespace+"
pointermove."+namespace+" MSPointerMove."+namespace, //move
- "touchend."+namespace+"
pointerup."+namespace+" MSPointerUp."+namespace //end
- ],
+ events=_getTouchEvents(namespace),
touchAction=document.body.style.touchAction!==undefined;
mCSB_container.bind(events[0],function(e){
_onTouchstart(e);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: oox/source
oox/source/core/filterbase.cxx | 23 +++
1 file changed, 7 insertions(+), 16 deletions(-)
New commits:
commit cbfc87cb39406045e6f561a178bec3c7d10fae02
Author: Vasily Melenchuk
AuthorDate: Sun Oct 13 21:29:24 2019 +0300
Commit: Thorsten Behrens
CommitDate: Sat Nov 16 19:19:40 2019 +0100
oox: avoid control freeze on exception
If exception happens somewhere in exportDocument() or later,
document controls could be remain locked and later cause crash
due to missing exception handler.
Use scope guard to avoid this problem on exception.
(cherry picked from commit ce684e7d06fc37ac6b672f5676e6113fcf41a03e)
Change-Id: I1ce4e487833ddc4b1f1b708f3a7e10bb299ef354
Reviewed-on: https://gerrit.libreoffice.org/80752
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
diff --git a/oox/source/core/filterbase.cxx b/oox/source/core/filterbase.cxx
index c99c77ba870f..b7acbe084a5c 100644
--- a/oox/source/core/filterbase.cxx
+++ b/oox/source/core/filterbase.cxx
@@ -30,6 +30,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -159,8 +160,6 @@ struct FilterBaseImpl
/// @throws IllegalArgumentException
voidsetDocumentModel( const Reference< XComponent >&
rxComponent );
-
-voidinitializeFilter();
};
FilterBaseImpl::FilterBaseImpl( const Reference< XComponentContext >&
rxContext ) :
@@ -185,18 +184,6 @@ void FilterBaseImpl::setDocumentModel( const Reference<
XComponent >& rxComponen
}
}
-void FilterBaseImpl::initializeFilter()
-{
-try
-{
-// lock the model controllers
-mxModel->lockControllers();
-}
-catch( Exception& )
-{
-}
-}
-
FilterBase::FilterBase( const Reference< XComponentContext >& rxContext ) :
mxImpl( new FilterBaseImpl( rxContext ) )
{
@@ -472,7 +459,12 @@ sal_Bool SAL_CALL FilterBase::filter( const Sequence<
PropertyValue >& rMediaDes
DocumentOpenedGuard aOpenedGuard( mxImpl->maFileUrl );
if( aOpenedGuard.isValid() || mxImpl->maFileUrl.isEmpty() )
{
-mxImpl->initializeFilter();
+Reference xTempModel = mxImpl->mxModel;
+xTempModel->lockControllers();
+comphelper::ScopeGuard const lockControllersGuard([xTempModel]() {
+xTempModel->unlockControllers();
+});
+
switch( mxImpl->meDirection )
{
case FILTERDIRECTION_UNKNOWN:
@@ -492,7 +484,6 @@ sal_Bool SAL_CALL FilterBase::filter( const Sequence<
PropertyValue >& rMediaDes
}
break;
}
-mxImpl->mxModel->unlockControllers();
}
return bRet;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/rtfexport.cxx | 12
1 file changed, 4 insertions(+), 8 deletions(-)
New commits:
commit 87b9b9cbffd788c67b195e0ad54ca425ac259e0c
Author: Michael Stahl
AuthorDate: Fri Nov 15 16:24:04 2019 +0100
Commit: Michael Stahl
CommitDate: Sat Nov 16 19:09:15 2019 +0100
sw: RTF export: only enable \formprot if there is actually a section
... that is protected; Writer can also protect the content of text
frames, which doesn't(?) appear to be possible in Word.
Form protection has annoying side effects like disabling field UI for
the whole document, even inside sections that are unprotected via
\sectunlocked1.
Change-Id: I2bf9503202779f5cb7c6e27ea7f533b2e3acb9d2
Reviewed-on: https://gerrit.libreoffice.org/82804
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/source/filter/ww8/rtfexport.cxx
b/sw/source/filter/ww8/rtfexport.cxx
index 9b98ce3bd4aa..787833bbac71 100644
--- a/sw/source/filter/ww8/rtfexport.cxx
+++ b/sw/source/filter/ww8/rtfexport.cxx
@@ -745,16 +745,12 @@ ErrCode RtfExport::ExportDocument_Impl()
// enable it on a per-section basis. OTOH don't always enable it as it
// breaks moving of drawings - so write it only in case there is really a
// protected section in the document.
+for (auto const& pSectionFormat : m_pDoc->GetSections())
{
-const SfxItemPool& rPool = m_pDoc->GetAttrPool();
-for (const SfxPoolItem* pItem2 : rPool.GetItemSurrogates(RES_PROTECT))
+if (!pSectionFormat->IsInUndo() &&
pSectionFormat->GetProtect().IsContentProtected())
{
-auto pProtect = dynamic_cast(pItem2);
-if (pProtect && pProtect->IsContentProtected())
-{
-Strm().WriteCharPtr(OOO_STRING_SVTOOLS_RTF_FORMPROT);
-break;
-}
+Strm().WriteCharPtr(OOO_STRING_SVTOOLS_RTF_FORMPROT);
+break;
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/undo/SwUndoTOXChange.cxx | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
New commits:
commit 32c39e510aba585fd6675e3497e158efab74b8a4
Author: Caolán McNamara
AuthorDate: Sat Nov 16 16:50:03 2019 +
Commit: Caolán McNamara
CommitDate: Sat Nov 16 18:51:06 2019 +0100
cid#1448525 Dereference null return value
Change-Id: I0dae9e73e85cef74f041535f3787e3afb45bb94d
Reviewed-on: https://gerrit.libreoffice.org/82989
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sw/source/core/undo/SwUndoTOXChange.cxx
b/sw/source/core/undo/SwUndoTOXChange.cxx
index 4296aa23d35f..c88182b7a522 100644
--- a/sw/source/core/undo/SwUndoTOXChange.cxx
+++ b/sw/source/core/undo/SwUndoTOXChange.cxx
@@ -24,12 +24,22 @@
#include
#include
+namespace
+{
+sal_uLong GetSectionNodeIndex(SwTOXBaseSection const& rTOX)
+{
+const SwSectionNode* pSectNd = rTOX.GetFormat()->GetSectionNode();
+assert(pSectNd);
+return pSectNd->GetIndex();
+}
+}
+
SwUndoTOXChange::SwUndoTOXChange(const SwDoc *pDoc,
SwTOXBaseSection const& rTOX, SwTOXBase const& rNew)
: SwUndo(SwUndoId::TOXCHANGE, pDoc)
, m_Old(rTOX)
, m_New(rNew)
-, m_nNodeIndex(rTOX.GetFormat()->GetSectionNode()->GetIndex())
+, m_nNodeIndex(GetSectionNodeIndex(rTOX))
{
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128844] : Compatibilty between different platforms
https://bugs.documentfoundation.org/show_bug.cgi?id=128844 V Stuart Foote changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID CC||vstuart.fo...@utsa.edu --- Comment #1 from V Stuart Foote --- Work out your ext4 mounting issues (either Samba SMB/CIFS, or NFS, or perhaps directly with FUSE on you macOS client). Sort that, and LibreOffice ODF files are cross platform compatible. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125817] Zero-width lines invisible on MacBook
https://bugs.documentfoundation.org/show_bug.cgi?id=125817 --- Comment #7 from brian.bj.parke...@gmail.com --- Yes, this has been fixed in the latest version. Version: 6.3.3.2 (In reply to Alex Thurgood from comment #6) > No repro in > > Version: 6.3.2.2 > Build ID: 98b30e735bda24bc04ab42594c85f7fd8be07b9c > Threads CPU : 4; OS : Mac OS X 10.15.1; UI Render : par défaut; VCL: osx; > Locale : fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR > Calc: threaded > > The default line width is 0.5pt and is visible in a new Draw document for > e.g. a straight line drawn with the corresponding tool from the toolbar. > > Closing as WFM -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128201] changing expert configuration not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=128201 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu --- Comment #4 from Aron Budea --- Is this still reproducible? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128841] In the dialog windoe "tip of the day" the text in in one line, no markup.
https://bugs.documentfoundation.org/show_bug.cgi?id=128841 V Stuart Foote changed: What|Removed |Added Summary|In the dialog windoe "tip |In the dialog windoe "tip |of the day" the text in in |of the day" the text in in |one line, no makeup.|one line, no markup. CC||heiko.tietze@documentfounda ||tion.org, ||vstuart.fo...@utsa.edu See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||7994 --- Comment #1 from V Stuart Foote --- Can not confirm with 6.3.3.2 on Windows 10 Home 64-bit en-US (1903) Also dialog has been reworkd for 6.4.0 alpha1, where we have relaunching the Tip-of-the-day dialog from the Help menu: The dialog now shows 2, 3, and 4 lines (of 50 characters) for tips the occasional URL link. Patches for bug 127994 (setting max dialog width to 350px) will land in 6.3.4, due out soon. With that and changes at 6.4 this IMHO => WFM @Hieko? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128844] New: : Compatibilty between different platforms
https://bugs.documentfoundation.org/show_bug.cgi?id=128844 Bug ID: 128844 Summary: : Compatibilty between different platforms Product: LibreOffice Version: 6.3.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: uf...@aim.com Saving a file to a server (Ext4 format) is not readable between Linux and Mac sierra platforms any solution appreciated looking for a cross platform office software -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128843] New: enhancement: if text is already in a section, ask for confirmation before linking a file in the section
https://bugs.documentfoundation.org/show_bug.cgi?id=128843 Bug ID: 128843 Summary: enhancement: if text is already in a section, ask for confirmation before linking a file in the section Product: LibreOffice Version: 6.4.0.0.alpha1+ Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sdc.bla...@youmail.dk Problem: Linking a file into a section replaces text that was previously in the section. Not possible to "undo" (e.g. Ctrl-Z). Therefore enhancement proposal for a confirmation warning. Procedure to see problem: 1. Insert > Section 2. Enter text in section 3. Right click - Edit Section 4. Choose Link, enter filename, and OK 5. Text entered in step 2 is lost with loading of linked text. Additional information 1. Not possible to "Undo" 2. The unsuspecting user who then unlinks the file (hoping to recover the lost text) will see that only the file remains, not the original text. 3. This happens even if the section was marked previously as write-protected (i.e., false protection). Suggestion: Version 1: Before linking an external file, pop-up a confirmation box that warns that all contents of the section will be lost(or replaced). Version 2: If it is easy/possible to evaluate whether the section is empty, then only pop-up confirmation when there is actually something to be lost. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128834] UI Pop-up menu for fast access
https://bugs.documentfoundation.org/show_bug.cgi?id=128834 V Stuart Foote changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Severity|normal |enhancement Keywords||needsUXEval --- Comment #4 from V Stuart Foote --- Sure it does: +C then, +V ...poof popup. Otherwise the +V will paste All (formatting, formula, text/value). IMHO => NAB, and nothing to fix for enhancement. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 128834] UI Pop-up menu for fast access
https://bugs.documentfoundation.org/show_bug.cgi?id=128834 V Stuart Foote changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Severity|normal |enhancement Keywords||needsUXEval --- Comment #4 from V Stuart Foote --- Sure it does: +C then, +V ...poof popup. Otherwise the +V will paste All (formatting, formula, text/value). IMHO => NAB, and nothing to fix for enhancement. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: solenv/CompilerTest_compilerplugins_clang.mk
solenv/CompilerTest_compilerplugins_clang.mk | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit a6dfb4164dbb808ec4b5752e05c8f22655d1757a Author: Stephan Bergmann AuthorDate: Sat Nov 16 17:23:39 2019 +0100 Commit: Stephan Bergmann CommitDate: Sat Nov 16 18:06:25 2019 +0100 sort items Change-Id: Ia55b9ce67b22f9cc012ce02208f501580d9f4634 Reviewed-on: https://gerrit.libreoffice.org/82986 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/solenv/CompilerTest_compilerplugins_clang.mk b/solenv/CompilerTest_compilerplugins_clang.mk index e429d1bc00fa..318bf8c69d0a 100644 --- a/solenv/CompilerTest_compilerplugins_clang.mk +++ b/solenv/CompilerTest_compilerplugins_clang.mk @@ -20,8 +20,8 @@ $(eval $(call gb_CompilerTest_add_exception_objects,compilerplugins_clang, \ compilerplugins/clang/test/commaoperator \ compilerplugins/clang/test/conditionalstring \ $(if $(filter-out WNT,$(OS)),compilerplugins/clang/test/constfields) \ -compilerplugins/clang/test/constparams \ compilerplugins/clang/test/constmethod \ +compilerplugins/clang/test/constparams \ compilerplugins/clang/test/consttobool \ compilerplugins/clang/test/constvars \ compilerplugins/clang/test/convertlong \ @@ -32,10 +32,9 @@ $(eval $(call gb_CompilerTest_add_exception_objects,compilerplugins_clang, \ compilerplugins/clang/test/dodgyswitch \ compilerplugins/clang/test/doubleconvert \ compilerplugins/clang/test/emptyif \ +compilerplugins/clang/test/expressionalwayszero \ compilerplugins/clang/test/external \ compilerplugins/clang/test/externvar \ -compilerplugins/clang/test/expressionalwayszero \ -compilerplugins/clang/test/intvsfloat \ compilerplugins/clang/test/faileddyncast \ compilerplugins/clang/test/fakebool \ compilerplugins/clang/test/finalprotected \ @@ -43,11 +42,12 @@ $(eval $(call gb_CompilerTest_add_exception_objects,compilerplugins_clang, \ compilerplugins/clang/test/fragiledestructor \ compilerplugins/clang/test/getstr \ compilerplugins/clang/test/indentation \ +compilerplugins/clang/test/intvsfloat \ compilerplugins/clang/test/logexceptionnicely \ compilerplugins/clang/test/loopvartoosmall \ -compilerplugins/clang/test/nullptr \ compilerplugins/clang/test/mapindex \ compilerplugins/clang/test/noexceptmove \ +compilerplugins/clang/test/nullptr \ compilerplugins/clang/test/oncevar \ compilerplugins/clang/test/oslendian-1 \ compilerplugins/clang/test/oslendian-2 \ @@ -67,8 +67,8 @@ $(eval $(call gb_CompilerTest_add_exception_objects,compilerplugins_clang, \ compilerplugins/clang/test/sallogareas \ compilerplugins/clang/test/salunicodeliteral \ compilerplugins/clang/test/selfinit \ -compilerplugins/clang/test/sequentialassign \ compilerplugins/clang/test/sequenceloop \ +compilerplugins/clang/test/sequentialassign \ compilerplugins/clang/test/shouldreturnbool \ compilerplugins/clang/test/simplifybool \ compilerplugins/clang/test/simplifyconstruct \ @@ -91,9 +91,9 @@ $(eval $(call gb_CompilerTest_add_exception_objects,compilerplugins_clang, \ compilerplugins/clang/test/unoany \ compilerplugins/clang/test/unoquery \ compilerplugins/clang/test/unreffun \ -compilerplugins/clang/test/unusedindex \ compilerplugins/clang/test/unusedenumconstants \ compilerplugins/clang/test/unusedfields \ +compilerplugins/clang/test/unusedindex \ compilerplugins/clang/test/unusedvariablecheck \ compilerplugins/clang/test/unusedvariablemore \ compilerplugins/clang/test/useuniqueptr \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128793] unoidl.com.sun.star.table.XTableColumns.removeByIndex() removes row instead of column in the CLI version of the SDK.
https://bugs.documentfoundation.org/show_bug.cgi?id=128793 --- Comment #7 from Oliver Brinzing --- added a beanshell and macro example, also tried with java using remote connection (LO 6.3.3.2) - scripts will always remove columns. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128398] "Don't Save" string untranslated in LO 6.4.0 alpha
https://bugs.documentfoundation.org/show_bug.cgi?id=128398 Julien Nabet changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #4 from Julien Nabet --- Thank you for your feedback. Let's put this one to FIXED then. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128793] unoidl.com.sun.star.table.XTableColumns.removeByIndex() removes row instead of column in the CLI version of the SDK.
https://bugs.documentfoundation.org/show_bug.cgi?id=128793 --- Comment #6 from Oliver Brinzing --- Created attachment 155884 --> https://bugs.documentfoundation.org/attachment.cgi?id=155884=edit removeColByIndex.ots -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128793] unoidl.com.sun.star.table.XTableColumns.removeByIndex() removes row instead of column in the CLI version of the SDK.
https://bugs.documentfoundation.org/show_bug.cgi?id=128793 --- Comment #5 from Oliver Brinzing --- Created attachment 155883 --> https://bugs.documentfoundation.org/attachment.cgi?id=155883=edit removeColByIndex.bsh -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128842] New: SLIDESHOW: presenter console overlaps presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=128842 Bug ID: 128842 Summary: SLIDESHOW: presenter console overlaps presentation Product: LibreOffice Version: 6.2.0.1 rc Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mark.wen...@gmx.net Description: I tried to show the presenter console on one display and the presentation on an other display under opensuse 15.1 with libreoffice 6.2.7.1. This results in only showing presenter console. The presentation will be displayed in the background of the presenter console. So the presentation is invisible. I can change between both views with Alt-Tab. I tried several Versions of libreoffice to find out which version is affected. All Versions from 6.2.0 on are affected. Steps to Reproduce: 1. Use computer with two displays 2. Use opensuse Leap 15.1 with plasma desktop or icewm desktop 3. activate presenter console in libreoffice 4. open presentation 5. start presentation (F5) Actual Results: 1. Presenter console shows up on presenter (first) display. 2. Presentation shows is invisible and located behind presenter console on presenter (first) display. 3. presentation (second) display shows normal background wallpaper Expected Results: 1. Presenter console shows up on presenter (first) display. 2. Presentation shows on presentation (second) display. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 6.2.7.1 Build-ID: 20(Build:1) CPU-Threads: 12; BS: Linux 4.12; UI-Render: Standard; VCL: kde5; Gebietsschema: de-DE (de_DE.UTF-8); UI-Sprache: de-DE Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/sfx2 sfx2/source
include/sfx2/request.hxx|2 +-
sfx2/source/control/request.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit b7b13ff527f8e726ada907634ca1f1ddd4c4699e
Author: Caolán McNamara
AuthorDate: Fri Nov 15 19:41:39 2019 +
Commit: Caolán McNamara
CommitDate: Sat Nov 16 17:39:04 2019 +0100
revert cid#1455212 Uncaught exception
doesn't help in this case, so drop it
Change-Id: I1837c08b604cd74ca07793d5d31eb60364381d8f
Reviewed-on: https://gerrit.libreoffice.org/82964
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/include/sfx2/request.hxx b/include/sfx2/request.hxx
index 3dde592b244e..90058a5b1f7f 100644
--- a/include/sfx2/request.hxx
+++ b/include/sfx2/request.hxx
@@ -64,7 +64,7 @@ public:
SfxRequest(sal_uInt16 nSlot, SfxCallMode nCallMode,
const SfxAllItemSet& rSfxArgs);
SfxRequest( sal_uInt16 nSlot, SfxCallMode nCallMode,
const SfxAllItemSet& rSfxArgs, const SfxAllItemSet& rSfxInternalArgs );
SfxRequest( const SfxRequest& rOrig );
-virtual ~SfxRequest() COVERITY_NOEXCEPT_FALSE override;
+virtual ~SfxRequest() override;
sal_uInt16 GetSlot() const { return nSlot; }
voidSetSlot(sal_uInt16 nNewSlot) { nSlot = nNewSlot; }
diff --git a/sfx2/source/control/request.cxx b/sfx2/source/control/request.cxx
index e9aced895cc3..fcdb5c036f32 100644
--- a/sfx2/source/control/request.cxx
+++ b/sfx2/source/control/request.cxx
@@ -118,7 +118,7 @@ void SfxRequest_Impl::SetPool( SfxItemPool *pNewPool )
}
-SfxRequest::~SfxRequest() COVERITY_NOEXCEPT_FALSE
+SfxRequest::~SfxRequest()
{
// Leave out Done() marked requests with 'rem'
if ( pImpl->xRecorder.is() && !pImpl->bDone && !pImpl->bIgnored )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128836] Cannot toggle edit mode on New (unsaved) Documents.
https://bugs.documentfoundation.org/show_bug.cgi?id=128836 sdc.bla...@youmail.dk changed: What|Removed |Added Summary|Cannot toggle edit mode |Cannot toggle edit mode on ||New (unsaved) Documents. --- Comment #2 from sdc.bla...@youmail.dk --- I believe I understand now that only new, unsaved documents cannot toggle Edit Mode. Was confused by it not appearing. So let this report be understood as query about whether it should appear that way. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128834] UI Pop-up menu for fast access
https://bugs.documentfoundation.org/show_bug.cgi?id=128834 --- Comment #3 from sebick --- Thanks, but that doesn't help if you use shortcuts to copy & paste (as most people do). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128841] New: In the dialog windoe "tip of the day" the text in in one line, no makeup.
https://bugs.documentfoundation.org/show_bug.cgi?id=128841 Bug ID: 128841 Summary: In the dialog windoe "tip of the day" the text in in one line, no makeup. Product: LibreOffice Version: 6.3.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rudn...@posteo.de Description: You cannot read the second (and the following) line(s) of the help text in the window "tip of the day", because there is obly one line. Steps to Reproduce: 1. Open a document 2. 3. Actual Results: Open a document while LibreOffice is running Expected Results: The text ist (if longer than one line) showed in two or more lines. Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128840] New: Crash in: libgobject-2.0.so.0.4800.2
https://bugs.documentfoundation.org/show_bug.cgi?id=128840 Bug ID: 128840 Summary: Crash in: libgobject-2.0.so.0.4800.2 Product: LibreOffice Version: 6.2.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eden...@talktalk.net This bug was filed from the crash reporting server and is br-aa395c75-385d-499c-97ec-b6712a08f947. = EDITING Open Impress presentation and open .doc or .docx file (using LibreOffice). COPY text from .doc file then switch to Impress (in order to paste text) LibreOffice crashes. Sent various anonymous crash reports 15 Nov 2019 when this started happening. Decided to file BUG when it occurred again today. Version: 6.2.5.2 Build ID: 1ec314fa52f458adc18c4f025c545a4e8b22c159 CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: en-GB (en_GB.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128398] "Don't Save" string untranslated in LO 6.4.0 alpha
https://bugs.documentfoundation.org/show_bug.cgi?id=128398 --- Comment #3 from mil...@sorbzilla.de --- Hi, the bug is fixed in LO 6.4.0 beta1. You can mark this bug as resolved. Thanks. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang solenv/CompilerTest_compilerplugins_clang.mk
compilerplugins/clang/readability-redundant-pp.cxx |8
compilerplugins/clang/test/redundantpreprocessor.cxx | 15 +++
solenv/CompilerTest_compilerplugins_clang.mk |1 +
3 files changed, 20 insertions(+), 4 deletions(-)
New commits:
commit 24b69e95c699ca595775f657244498a0cebe1faf
Author: Stephan Bergmann
AuthorDate: Sat Nov 16 15:42:32 2019 +0100
Commit: Stephan Bergmann
CommitDate: Sat Nov 16 16:55:36 2019 +0100
Improve loplugin:redundantpreprocessor performance a bit
...and add a minimal test for it
Change-Id: Ia6c61e41a7e60fd01c639e893c34bd9d215c1513
Reviewed-on: https://gerrit.libreoffice.org/82983
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/compilerplugins/clang/readability-redundant-pp.cxx
b/compilerplugins/clang/readability-redundant-pp.cxx
index e1c284b99c63..dcfd70247ff8 100644
--- a/compilerplugins/clang/readability-redundant-pp.cxx
+++ b/compilerplugins/clang/readability-redundant-pp.cxx
@@ -69,9 +69,9 @@ void RedundantPreprocessor::Ifdef(clang::SourceLocation aLoc,
const clang::Token
if (ignoreLocation(aLoc))
return;
+std::string aMacroName = m_rPP.getSpelling(rMacroNameTok);
if (m_rPP.getSourceManager().isInMainFile(aLoc))
{
-std::string aMacroName = m_rPP.getSpelling(rMacroNameTok);
for (const auto& rEntry : m_aDefStack)
{
if (rEntry.m_aMacroName == aMacroName)
@@ -84,7 +84,7 @@ void RedundantPreprocessor::Ifdef(clang::SourceLocation aLoc,
const clang::Token
Entry aEntry;
aEntry.m_aLoc = aLoc;
-aEntry.m_aMacroName = m_rPP.getSpelling(rMacroNameTok);
+aEntry.m_aMacroName = aMacroName;
m_aDefStack.push_back(aEntry);
}
@@ -94,9 +94,9 @@ void RedundantPreprocessor::Ifndef(clang::SourceLocation
aLoc, const clang::Toke
if (ignoreLocation(aLoc))
return;
+std::string aMacroName = m_rPP.getSpelling(rMacroNameTok);
if (m_rPP.getSourceManager().isInMainFile(aLoc))
{
-std::string aMacroName = m_rPP.getSpelling(rMacroNameTok);
for (const auto& rEntry : m_aNotDefStack)
{
if (rEntry.m_aMacroName == aMacroName)
@@ -109,7 +109,7 @@ void RedundantPreprocessor::Ifndef(clang::SourceLocation
aLoc, const clang::Toke
Entry aEntry;
aEntry.m_aLoc = aLoc;
-aEntry.m_aMacroName = m_rPP.getSpelling(rMacroNameTok);
+aEntry.m_aMacroName = aMacroName;
m_aNotDefStack.push_back(aEntry);
}
diff --git a/compilerplugins/clang/test/redundantpreprocessor.cxx
b/compilerplugins/clang/test/redundantpreprocessor.cxx
new file mode 100644
index ..18ab10559f67
--- /dev/null
+++ b/compilerplugins/clang/test/redundantpreprocessor.cxx
@@ -0,0 +1,15 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4;
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#ifdef __clang__ // expected-note {{previous ifdef
[loplugin:redundantpreprocessor]}}
+#ifdef __clang__ // expected-error {{nested ifdef
[loplugin:redundantpreprocessor]}}
+#endif
+#endif
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s
cinkeys+=0=break: */
diff --git a/solenv/CompilerTest_compilerplugins_clang.mk
b/solenv/CompilerTest_compilerplugins_clang.mk
index 226d0686dd52..e429d1bc00fa 100644
--- a/solenv/CompilerTest_compilerplugins_clang.mk
+++ b/solenv/CompilerTest_compilerplugins_clang.mk
@@ -59,6 +59,7 @@ $(eval $(call
gb_CompilerTest_add_exception_objects,compilerplugins_clang, \
compilerplugins/clang/test/redundantfcast \
compilerplugins/clang/test/redundantinline \
compilerplugins/clang/test/redundantpointerops \
+compilerplugins/clang/test/redundantpreprocessor \
compilerplugins/clang/test/refcounting \
compilerplugins/clang/test/referencecasting \
compilerplugins/clang/test/returnconstval \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: oox/source sw/qa
oox/source/export/shapes.cxx | 35
sw/qa/extras/ooxmlexport/data/tdf128820.fodt | 1353 +++
sw/qa/extras/ooxmlexport/ooxmlexport14.cxx |5
3 files changed, 1376 insertions(+), 17 deletions(-)
New commits:
commit b699a693cabf307418d3aa2c159d58a4bedd43a4
Author: Mike Kaganski
AuthorDate: Sat Nov 16 15:02:35 2019 +0300
Commit: Mike Kaganski
CommitDate: Sat Nov 16 16:55:19 2019 +0100
tdf#128820: use wps namespace for simple text shapes
Without that, simple text shapes inside groups were written in
elements, with many child elements also having pic::
prefix.
Change-Id: I114cf3499e03aa5ca042211d7b134aaf5b0e7fbf
Reviewed-on: https://gerrit.libreoffice.org/82980
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/oox/source/export/shapes.cxx b/oox/source/export/shapes.cxx
index ebab46728bef..9f69e316cbec 100644
--- a/oox/source/export/shapes.cxx
+++ b/oox/source/export/shapes.cxx
@@ -381,6 +381,14 @@ awt::Size ShapeExport::MapSize( const awt::Size& rSize )
const
return awt::Size( aRetSize.Width(), aRetSize.Height() );
}
+static bool IsNonEmptySimpleText(const Reference& xIface)
+{
+if (Reference xText{ xIface, UNO_QUERY })
+return xText->getString().getLength();
+
+return false;
+}
+
bool ShapeExport::NonEmptyText( const Reference< XInterface >& xIface )
{
Reference< XPropertySet > xPropSet( xIface, UNO_QUERY );
@@ -414,12 +422,7 @@ bool ShapeExport::NonEmptyText( const Reference<
XInterface >& xIface )
}
}
-Reference< XSimpleText > xText( xIface, UNO_QUERY );
-
-if( xText.is() )
-return xText->getString().getLength();
-
-return false;
+return IsNonEmptySimpleText(xIface);
}
ShapeExport& ShapeExport::WritePolyPolygonShape( const Reference< XShape >&
xShape, const bool bClosed )
@@ -529,7 +532,11 @@ ShapeExport& ShapeExport::WriteGroupShape(const
uno::Reference&
uno::Reference xServiceInfo(xChild,
uno::UNO_QUERY_THROW);
if (GetDocumentType() == DOCUMENT_DOCX)
{
-if
(xServiceInfo->supportsService("com.sun.star.drawing.GraphicObjectShape"))
+// tdf#128820: WriteGraphicObjectShapePart calls WriteTextShape
for non-empty simple
+// text objects, which needs writing into wps::wsp element, so
make sure to use wps
+// namespace for those objects
+if
(xServiceInfo->supportsService("com.sun.star.drawing.GraphicObjectShape")
+&& !IsNonEmptySimpleText(xChild))
mnXmlNamespace = XML_pic;
else
mnXmlNamespace = XML_wps;
@@ -1165,19 +1172,13 @@ void ShapeExport::WriteGraphicObjectShapePart( const
Reference< XShape >& xShape
{
SAL_INFO("oox.shape", "write graphic object shape");
-if( NonEmptyText( xShape ) )
+if (IsNonEmptySimpleText(xShape))
{
-// avoid treating all 'IsPresentationObject' objects as having text.
-Reference< XSimpleText > xText( xShape, UNO_QUERY );
+SAL_INFO("oox.shape", "graphicObject: wrote only text");
-if( xText.is() && !xText->getString().isEmpty() )
-{
-SAL_INFO("oox.shape", "graphicObject: wrote only text");
+WriteTextShape(xShape);
-WriteTextShape( xShape );
-
-return;
-}
+return;
}
SAL_INFO("oox.shape", "graphicObject without text");
diff --git a/sw/qa/extras/ooxmlexport/data/tdf128820.fodt
b/sw/qa/extras/ooxmlexport/data/tdf128820.fodt
new file mode 100644
index ..bb39fee02534
--- /dev/null
+++ b/sw/qa/extras/ooxmlexport/data/tdf128820.fodt
@@ -0,0 +1,1353 @@
+
+
+http://openoffice.org/2004/office;
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0"
xmlns:xlink="http://www.w3.org/1999/xlink;
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0"
xmlns:dc="http://purl.org/dc/elements/1.1/;
xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0"
xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0"
xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0"
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0"
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0"
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0"
xmlns:rpt="http://openoffice.org/2005/report;
xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0"
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0"
xmlns:ooow="http://openoffice.org/200
4/writer" xmlns:oooc="http://openoffice.org/2004/calc;
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2"
xmlns:css3t="http://www.w3.org/TR/css3-text/;
xmlns:tableooo="http://openoffice.org/2009/table;
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
xmlns:drawooo="http://openoffice.org/2010/draw;
[Libreoffice-bugs] [Bug 128833] Font Family dropdown list has no vertical scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=128833 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #1 from V Stuart Foote --- Can not confirm on Windows builds. The 'Font' tab's listbox shows a v.scrollbar. Windows 10 Home 64-bit en-US (1903) with Version: 6.3.3.2 (x64) Build ID: a64200df03143b798afd1ec74a12ab50359878ed CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: threaded nor with current master/6.5.0alpha0+ Version: 6.5.0.0.alpha0+ (x64) Build ID: 8c85782bbe46963e2be32c3cb406982f1790fc2f CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: GL; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/duplicate-defines.cxx| 10 +-
compilerplugins/clang/readability-redundant-pp.cxx | 10 +-
2 files changed, 10 insertions(+), 10 deletions(-)
New commits:
commit ab8fc2603c647754d7954b77c1347123402c8b7b
Author: Stephan Bergmann
AuthorDate: Sat Nov 16 15:39:12 2019 +0100
Commit: Stephan Bergmann
CommitDate: Sat Nov 16 16:48:33 2019 +0100
Fix loplugin::Entry ODR violation
(caused crashes with CLANGDEBUG=1 in compilerplugins/Makefile-clang.mk)
Change-Id: I43ba276f03c87c97b624a59f2b368422fd5b0a7b
Reviewed-on: https://gerrit.libreoffice.org/82982
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/compilerplugins/clang/duplicate-defines.cxx
b/compilerplugins/clang/duplicate-defines.cxx
index 0209d0893a36..21caf90a96dd 100644
--- a/compilerplugins/clang/duplicate-defines.cxx
+++ b/compilerplugins/clang/duplicate-defines.cxx
@@ -23,17 +23,17 @@
/// Finds duplicated preprocessor defines, which generally indicate that some
definition
/// needs to be centralised somewhere.
-namespace loplugin
+namespace
{
struct Entry
{
clang::SourceLocation m_aLoc;
};
-class DuplicateDefines : public clang::PPCallbacks, public Plugin
+class DuplicateDefines : public clang::PPCallbacks, public loplugin::Plugin
{
public:
-explicit DuplicateDefines(const InstantiationData& data);
+explicit DuplicateDefines(const loplugin::InstantiationData& data);
virtual void run() override;
void MacroDefined(const Token& MacroNameTok, const MacroDirective* MD)
override;
void MacroUndefined(const Token& MacroNameTok, const MacroDefinition& MD,
@@ -48,7 +48,7 @@ private:
std::unordered_map m_aDefMap;
};
-DuplicateDefines::DuplicateDefines(const InstantiationData& data)
+DuplicateDefines::DuplicateDefines(const loplugin::InstantiationData& data)
: Plugin(data)
, m_rPP(compiler.getPreprocessor())
{
@@ -99,7 +99,7 @@ void DuplicateDefines::MacroUndefined(const Token&
rMacroNameTok, const MacroDef
m_aDefMap.erase(aMacroName);
}
-static Plugin::Registration X("duplicatedefines", false);
+loplugin::Plugin::Registration X("duplicatedefines", false);
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/compilerplugins/clang/readability-redundant-pp.cxx
b/compilerplugins/clang/readability-redundant-pp.cxx
index 2411dfb75f62..e1c284b99c63 100644
--- a/compilerplugins/clang/readability-redundant-pp.cxx
+++ b/compilerplugins/clang/readability-redundant-pp.cxx
@@ -22,7 +22,7 @@
/// Finds preprocessor usage which is redundant (only #ifndef for now).
-namespace loplugin
+namespace
{
struct Entry
{
@@ -30,10 +30,10 @@ struct Entry
std::string m_aMacroName;
};
-class RedundantPreprocessor : public clang::PPCallbacks, public Plugin
+class RedundantPreprocessor : public clang::PPCallbacks, public
loplugin::Plugin
{
public:
-explicit RedundantPreprocessor(const InstantiationData& data);
+explicit RedundantPreprocessor(const loplugin::InstantiationData& data);
virtual void run() override;
void Ifndef(clang::SourceLocation aLoc, const clang::Token& rMacroNameTok,
const clang::MacroDefinition& rMacroDefinition) override;
@@ -51,7 +51,7 @@ private:
std::vector m_aNotDefStack;
};
-RedundantPreprocessor::RedundantPreprocessor(const InstantiationData& data)
+RedundantPreprocessor::RedundantPreprocessor(const
loplugin::InstantiationData& data)
: Plugin(data)
, m_rPP(compiler.getPreprocessor())
{
@@ -127,7 +127,7 @@ void RedundantPreprocessor::Endif(clang::SourceLocation
/*aLoc*/, clang::SourceL
}
}
-static Plugin::Registration X("redundantpreprocessor");
+loplugin::Plugin::Registration
X("redundantpreprocessor");
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128839] New: Appending new character in Impress always follow the previous direct formatting.
https://bugs.documentfoundation.org/show_bug.cgi?id=128839 Bug ID: 128839 Summary: Appending new character in Impress always follow the previous direct formatting. Product: LibreOffice Version: 6.2.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mark...@gmail.com Steps to reproduce: 1. Create a new slide in impress. 2. Select a text box and press F2 to edit. 3. Change the font to Wingding, type and see symbols. 4. Ctrl+shift+M ( without highlight any text. ) 5. Enter . Expected result: Direct formatting should be cleared and text use the default font. Actual result: The appended text still use Wingding. If you press Ctrl+M in Writer at the end of a paragraph, text appended later do not have any direct formatting. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128834] UI Pop-up menu for fast access
https://bugs.documentfoundation.org/show_bug.cgi?id=128834 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #2 from V Stuart Foote --- Created attachment 155882 --> https://bugs.documentfoundation.org/attachment.cgi?id=155882=edit calc context sub-menu 'Paste special' Already exists. Default offerings on the Context menu (R-mouse, +F10, or keyboard MENU key) -> 'Paste Special' submenu. While the actual Paste Special dialog handles additional data types depending on the source. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
