[Libreoffice-bugs] [Bug 105830] [META] Infobar behaviour and appearance issues
https://bugs.documentfoundation.org/show_bug.cgi?id=105830 Bug 105830 depends on bug 97926, which changed state. Bug 97926 Summary: Infobar should have an UNO API https://bugs.documentfoundation.org/show_bug.cgi?id=97926 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - vcl/inc vcl/qa vcl/source
vcl/inc/widgetdraw/WidgetDefinition.hxx |7 +++
vcl/qa/cppunit/widgetdraw/WidgetDefinitionReaderTest.cxx | 28 +-
vcl/qa/cppunit/widgetdraw/data/definitionSettings1.xml |5 ++
vcl/qa/cppunit/widgetdraw/data/definitionSettings2.xml |6 +++
vcl/qa/cppunit/widgetdraw/data/definitionSettings3.xml |6 +++
vcl/source/gdi/FileDefinitionWidgetDraw.cxx | 12 +-
vcl/source/gdi/WidgetDefinition.cxx |2 -
vcl/source/gdi/WidgetDefinitionReader.cxx| 30 +++
8 files changed, 93 insertions(+), 3 deletions(-)
New commits:
commit f8ca5fb82db18a22f077a01fb1daf8056ab15ef4
Author: Tomaž Vajngerl
AuthorDate: Mon Nov 18 22:50:46 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Tue Nov 19 08:57:05 2019 +0100
widget theme: add centeredTabs setting to theme definition file
Change-Id: I714a44d40a99e0bb5ff48e3d36ded73db60af5a0
Reviewed-on: https://gerrit.libreoffice.org/83133
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit b234743dd26e0be4be272d2d2c82f90c67e192b7)
Reviewed-on: https://gerrit.libreoffice.org/83155
Tested-by: Jenkins CollaboraOffice
diff --git a/vcl/inc/widgetdraw/WidgetDefinition.hxx
b/vcl/inc/widgetdraw/WidgetDefinition.hxx
index acaac53bfacf..1c76645b55c0 100644
--- a/vcl/inc/widgetdraw/WidgetDefinition.hxx
+++ b/vcl/inc/widgetdraw/WidgetDefinition.hxx
@@ -198,6 +198,12 @@ public:
std::vector> maStates;
};
+class VCL_DLLPUBLIC WidgetDefinitionSettings
+{
+public:
+OString msCenteredTabs;
+};
+
class VCL_DLLPUBLIC WidgetDefinitionStyle
{
public:
@@ -260,6 +266,7 @@ class VCL_DLLPUBLIC WidgetDefinition
{
public:
std::shared_ptr mpStyle;
+std::shared_ptr mpSettings;
std::unordered_map> maDefinitions;
std::shared_ptr getDefinition(ControlType eType,
ControlPart ePart);
};
diff --git a/vcl/qa/cppunit/widgetdraw/WidgetDefinitionReaderTest.cxx
b/vcl/qa/cppunit/widgetdraw/WidgetDefinitionReaderTest.cxx
index 843f449b7901..4c507ec1c5da 100644
--- a/vcl/qa/cppunit/widgetdraw/WidgetDefinitionReaderTest.cxx
+++ b/vcl/qa/cppunit/widgetdraw/WidgetDefinitionReaderTest.cxx
@@ -29,18 +29,44 @@ private:
public:
void testRead();
+void testReadSettings();
CPPUNIT_TEST_SUITE(WidgetDefinitionReaderTest);
CPPUNIT_TEST(testRead);
+CPPUNIT_TEST(testReadSettings);
CPPUNIT_TEST_SUITE_END();
};
+void WidgetDefinitionReaderTest::testReadSettings()
+{
+{
+vcl::WidgetDefinition aDefinition;
+vcl::WidgetDefinitionReader
aReader(getFullUrl("definitionSettings1.xml"), getFullUrl(""));
+CPPUNIT_ASSERT(aReader.read(aDefinition));
+CPPUNIT_ASSERT_EQUAL(OString(""),
aDefinition.mpSettings->msCenteredTabs);
+}
+
+{
+vcl::WidgetDefinition aDefinition;
+vcl::WidgetDefinitionReader
aReader(getFullUrl("definitionSettings2.xml"), getFullUrl(""));
+CPPUNIT_ASSERT(aReader.read(aDefinition));
+CPPUNIT_ASSERT_EQUAL(OString("true"),
aDefinition.mpSettings->msCenteredTabs);
+}
+
+{
+vcl::WidgetDefinition aDefinition;
+vcl::WidgetDefinitionReader
aReader(getFullUrl("definitionSettings3.xml"), getFullUrl(""));
+CPPUNIT_ASSERT(aReader.read(aDefinition));
+CPPUNIT_ASSERT_EQUAL(OString("false"),
aDefinition.mpSettings->msCenteredTabs);
+}
+}
+
void WidgetDefinitionReaderTest::testRead()
{
vcl::WidgetDefinition aDefinition;
vcl::WidgetDefinitionReader aReader(getFullUrl("definition1.xml"),
getFullUrl(""));
-aReader.read(aDefinition);
+CPPUNIT_ASSERT(aReader.read(aDefinition));
CPPUNIT_ASSERT_EQUAL(OUString("123456"),
aDefinition.mpStyle->maFaceColor.AsRGBHexString());
CPPUNIT_ASSERT_EQUAL(OUString("234567"),
aDefinition.mpStyle->maCheckedColor.AsRGBHexString());
diff --git a/vcl/qa/cppunit/widgetdraw/data/definitionSettings1.xml
b/vcl/qa/cppunit/widgetdraw/data/definitionSettings1.xml
new file mode 100644
index ..9ca7f894f29d
--- /dev/null
+++ b/vcl/qa/cppunit/widgetdraw/data/definitionSettings1.xml
@@ -0,0 +1,5 @@
+
+
+
+
+
diff --git a/vcl/qa/cppunit/widgetdraw/data/definitionSettings2.xml
b/vcl/qa/cppunit/widgetdraw/data/definitionSettings2.xml
new file mode 100644
index ..0d6d6e11151a
--- /dev/null
+++ b/vcl/qa/cppunit/widgetdraw/data/definitionSettings2.xml
@@ -0,0 +1,6 @@
+
+
+
+
+
+
diff --git a/vcl/qa/cppunit/widgetdraw/data/definitionSettings3.xml
b/vcl/qa/cppunit/widgetdraw/data/definitionSettings3.xml
new file mode 100644
index ..20541b2a219e
--- /dev/null
+++ b/vcl/qa/cppunit/widgetdraw/data/definitionSettings3.xml
@@ -0,0 +1,6 @@
+
+
+
+
+
+
diff --git a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
index 4b913fa495d4..34707ea751cc 100644
--- a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
+++
[Libreoffice-bugs] [Bug 84183] [Infobar] Wrong appearance of clicked close button
https://bugs.documentfoundation.org/show_bug.cgi?id=84183 --- Comment #6 from Commit Notification --- Samuel Mehrbrodt committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/60c0874227201310c099fb717c0a665dbcf5bb33 tdf#84183 Give infobar close btn some 'clicked' state It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84183] [Infobar] Wrong appearance of clicked close button
https://bugs.documentfoundation.org/show_bug.cgi?id=84183 Commit Notification changed: What|Removed |Added Whiteboard||target:6.5.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - include/sfx2 include/vcl offapi/com offapi/UnoApi_offapi.mk sc/source sfx2/source vcl/source
include/sfx2/classificationhelper.hxx |2
include/sfx2/infobar.hxx | 38 +++---
include/sfx2/sfxbasecontroller.hxx | 13 ++
include/sfx2/viewfrm.hxx | 13 +-
include/vcl/button.hxx |5
offapi/UnoApi_offapi.mk|2
offapi/com/sun/star/frame/InfobarType.idl | 38 ++
offapi/com/sun/star/frame/XInfobarProvider.idl | 104 +
sc/source/ui/docshell/docsh4.cxx |2
sfx2/source/dialog/infobar.cxx | 105 +++--
sfx2/source/doc/objserv.cxx| 18 +--
sfx2/source/view/classificationhelper.cxx | 22 +--
sfx2/source/view/sfxbasecontroller.cxx | 64 ++
sfx2/source/view/viewfrm.cxx | 23 ++-
vcl/source/control/button.cxx | 148 -
15 files changed, 430 insertions(+), 167 deletions(-)
New commits:
commit 60c0874227201310c099fb717c0a665dbcf5bb33
Author: Samuel Mehrbrodt
AuthorDate: Mon Nov 18 13:33:31 2019 +0100
Commit: Samuel Mehrbrodt
CommitDate: Tue Nov 19 08:51:55 2019 +0100
tdf#84183 Give infobar close btn some 'clicked' state
Slightly smaller cross when the button is clicked on to have
some feedback for the user
Change-Id: If0486319e9816378b2011bbb366b4c577c1ad84a
Reviewed-on: https://gerrit.libreoffice.org/83087
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
diff --git a/include/vcl/button.hxx b/include/vcl/button.hxx
index c39c466d1afe..b0b2884c9ad0 100644
--- a/include/vcl/button.hxx
+++ b/include/vcl/button.hxx
@@ -47,8 +47,6 @@ private:
Button (const Button &) = delete;
Button & operator= (const Button &) =
delete;
public:
-SAL_DLLPRIVATE DrawButtonFlags ImplGetButtonState() const;
-SAL_DLLPRIVATE DrawButtonFlags& ImplGetButtonState();
SAL_DLLPRIVATE DrawTextFlagsImplGetTextStyle( WinBits nWinStyle,
DrawFlags nDrawFlags );
SAL_DLLPRIVATE void ImplDrawAlignedImage(OutputDevice* pDev,
Point& rPos, Size& rSize,
sal_uLong nImageSep,
@@ -81,6 +79,9 @@ public:
boolHasImage() const;
voidSetImageAlign( ImageAlign eAlign );
ImageAlign GetImageAlign() const;
+DrawButtonFlags GetButtonState() const;
+DrawButtonFlags&GetButtonState();
+
boolIsSmallSymbol() const;
voidSetSmallSymbol();
diff --git a/sfx2/source/dialog/infobar.cxx b/sfx2/source/dialog/infobar.cxx
index a1c9ef21cbee..ea99fc6b67d3 100644
--- a/sfx2/source/dialog/infobar.cxx
+++ b/sfx2/source/dialog/infobar.cxx
@@ -23,6 +23,7 @@
#include
#include
#include
+#include
using namespace std;
using namespace drawinglayer::geometry;
@@ -114,11 +115,15 @@ public:
void SfxCloseButton::Paint(vcl::RenderContext& rRenderContext, const
::tools::Rectangle&)
{
+Point aBtnPos(0, 0);
+if (GetButtonState() & DrawButtonFlags::Pressed)
+aBtnPos.Move(Size(1, 1));
+
const ViewInformation2D aNewViewInfos;
const unique_ptr pProcessor(
createBaseProcessor2DFromOutputDevice(rRenderContext,
aNewViewInfos));
-const ::tools::Rectangle aRect(Point(0, 0), PixelToLogic(GetSizePixel()));
+const ::tools::Rectangle aRect(aBtnPos, PixelToLogic(GetSizePixel()));
drawinglayer::primitive2d::Primitive2DContainer aSeq(2);
diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx
index 6eb27669f306..53eaa3ff6b0c 100644
--- a/vcl/source/control/button.cxx
+++ b/vcl/source/control/button.cxx
@@ -480,12 +480,12 @@ const tools::Rectangle& Button::ImplGetFocusRect() const
return mpButtonData->maFocusRect;
}
-DrawButtonFlags& Button::ImplGetButtonState()
+DrawButtonFlags& Button::GetButtonState()
{
return mpButtonData->mnButtonState;
}
-DrawButtonFlags Button::ImplGetButtonState() const
+DrawButtonFlags Button::GetButtonState() const
{
return mpButtonData->mnButtonState;
}
@@ -588,7 +588,7 @@ void PushButton::ImplInit( vcl::Window* pParent, WinBits
nStyle )
Button::ImplInit( pParent, nStyle, nullptr );
if ( nStyle & WB_NOLIGHTBORDER )
-ImplGetButtonState() |= DrawButtonFlags::NoLightBorder;
+GetButtonState() |= DrawButtonFlags::NoLightBorder;
ImplInitSettings( true );
}
@@ -792,7 +792,7 @@ void PushButton::ImplDrawPushButtonContent(OutputDevice*
pDev, DrawFlags nDrawFl
}
else
{
-aColor = isAction() ? ((ImplGetButtonState() &
DrawButtonFlags::Default)
+aColor = isAction() ? ((GetButtonState() & DrawButtonFlags::Default)
?
rStyleSettings.GetDefaultActionButtonTextColor()
: rStyleSettings.GetActionButtonTextColor())
[Libreoffice-bugs] [Bug 121470] After pressing the "Reset Properties" button - when pressing the "OK" button the time on the "Created" field is being reset again (on Properties - General)
https://bugs.documentfoundation.org/show_bug.cgi?id=121470 --- Comment #3 from Oliver Brinzing --- reproducible with: Version: 6.5.0.0.alpha0+ (x64) Build ID: d04eef858250f97690f32dba17f42d157a8767fc CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win; Locale: de-DE (de_DE); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128883] FORMATTING A custom character style with regular text, applied to a word in a custom paragraph style with bold text: the word remains bold.
https://bugs.documentfoundation.org/show_bug.cgi?id=128883 --- Comment #3 from Mike Kaganski --- I cannot reproduce creating a correct "not bold" character style. 1. Create a new CS (right-clicking in a whitespace in the style manager and choosing New) 2. Make sure that on Organizer tab, it has no parent, and that nothing is shown under "Contains" initially: the originally created style has nothing in it 3. Switch to Font tab; select Bold in Style selector 4. Switch back to Organizer tab, and see that "Contains" now has "Western text: bold", because we had that control changed from the original default value 5. Switch to Font tab; select Regular in Style selector 6. Switch back to Organizer tab, and see that "Contains" now has "Western text: normal", because we had that control changed from the original default value, and setting it back to old value still considers its value changed Now save the style and use normally. The bug here is not that we save or not save something, but lack of indication of changed state of any control, and also lack of ability to revert a selected control (not the whole tab) into "unset" state. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128857] wraparound isn't possible
https://bugs.documentfoundation.org/show_bug.cgi?id=128857 --- Comment #10 from sagarikanev --- Wrap around time depends on the number of sequence number and bandwidth. As the ... But this is not possible and we are going to use wrap around concept. >> https://www.pcsleek.com -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128723] Options Print Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128723 --- Comment #4 from Commit Notification --- andreas kainz committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/4a82bafda542daa34cf52c34cdd1f13ff61b371c tdf#128723 Options Print Dialog update It will be available in 6.4.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127927] Make Writer Character Dialog HIG conform
https://bugs.documentfoundation.org/show_bug.cgi?id=127927 Commit Notification changed: What|Removed |Added Whiteboard|target:6.4.0 target:6.5.0 |target:6.4.0 target:6.5.0 ||target:6.4.0.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128723] Options Print Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128723 Commit Notification changed: What|Removed |Added Whiteboard|target:6.5.0|target:6.5.0 target:6.4.0.1 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 128723] Options Print Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128723 Commit Notification changed: What|Removed |Added Whiteboard|target:6.5.0|target:6.5.0 target:6.4.0.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - cui/uiconfig
cui/uiconfig/ui/paragalignpage.ui | 121 -- 1 file changed, 52 insertions(+), 69 deletions(-) New commits: commit 1987c98926a85a483a32ea78e460e563a6ea4705 Author: andreas kainz AuthorDate: Sun Nov 17 22:36:25 2019 +0100 Commit: Heiko Tietze CommitDate: Tue Nov 19 08:31:30 2019 +0100 Paragraph Align Tab fix Change-Id: Ied02b9db154bd007399b8b3d567d692d4973d382 Reviewed-on: https://gerrit.libreoffice.org/83040 Tested-by: Jenkins Reviewed-by: andreas_kainz (cherry picked from commit bc9b046fbd1d68016ae6c53c990fce97b57eb663) Reviewed-on: https://gerrit.libreoffice.org/83058 Reviewed-by: Heiko Tietze diff --git a/cui/uiconfig/ui/paragalignpage.ui b/cui/uiconfig/ui/paragalignpage.ui index 289585fa390c..c1f0a78cee2d 100644 --- a/cui/uiconfig/ui/paragalignpage.ui +++ b/cui/uiconfig/ui/paragalignpage.ui @@ -5,8 +5,6 @@ True False -start -True 6 12 24 @@ -55,10 +53,6 @@ True False -start -start -True -True 12 @@ -76,7 +70,7 @@ True False -6 +3 _Left @@ -176,33 +170,15 @@ - + True False -12 +True - -True + False -13 -vertical - - -True -False -12 -True -_Last line: -True -comboLB_LASTLINE -0 - - -False -True -0 - - +Righ_t/Bottom +True False @@ -211,16 +187,11 @@ - -True + False -0 - - Start - Start - Centered - Justified - +5 +_Left/Top +True False @@ -231,43 +202,58 @@ 0 -4 +7 - + True False -True - - -False -Righ_t/Bottom -True - - -False -True -0 - - +18 - + +True False -5 -_Left/Top -True +6 + + +True +False +_Last line: +True +comboLB_LASTLINE +0 + + +False +True +0 + + + + +True +
[Libreoffice-bugs] [Bug 127927] Make Writer Character Dialog HIG conform
https://bugs.documentfoundation.org/show_bug.cgi?id=127927 --- Comment #19 from Commit Notification --- andreas kainz committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/35a55533728fb3ee5746ef8f9f45762164f03902 tdf#127927 Character Dialog effect preview Alignment It will be available in 6.4.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128888] Transparent objects causing excessive CPU usage when exporting PNG from LO Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=12 --- Comment #2 from mwtjunkm...@gmail.com --- Sorry, I mistyped. I'm using Windows 10 Pro 1909 build 18363.476, not 1901, as stated originally. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128723] Options Print Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128723 --- Comment #4 from Commit Notification --- andreas kainz committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/4a82bafda542daa34cf52c34cdd1f13ff61b371c tdf#128723 Options Print Dialog update It will be available in 6.4.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - sfx2/uiconfig
sfx2/uiconfig/ui/optprintpage.ui | 743 ++- 1 file changed, 425 insertions(+), 318 deletions(-) New commits: commit 4a82bafda542daa34cf52c34cdd1f13ff61b371c Author: andreas kainz AuthorDate: Mon Nov 11 23:52:39 2019 +0100 Commit: Heiko Tietze CommitDate: Tue Nov 19 08:30:37 2019 +0100 tdf#128723 Options Print Dialog update Change-Id: I2910a39602a596ed6afb7b5e80dd5290663f7ff6 Reviewed-on: https://gerrit.libreoffice.org/82474 Tested-by: Jenkins Reviewed-by: andreas_kainz (cherry picked from commit bf88b78ee61936bb5e4b79d4ea1ab3ee049993e0) Reviewed-on: https://gerrit.libreoffice.org/83012 Reviewed-by: Heiko Tietze diff --git a/sfx2/uiconfig/ui/optprintpage.ui b/sfx2/uiconfig/ui/optprintpage.ui index c1f8eff54273..ad464b7bb59d 100644 --- a/sfx2/uiconfig/ui/optprintpage.ui +++ b/sfx2/uiconfig/ui/optprintpage.ui @@ -9,13 +9,12 @@ 1 10 - + True False -True 6 -vertical -12 +12 +24 True @@ -23,67 +22,96 @@ 0 none - + True False 6 12 - + True False -6 +3 - + +_Printer True -False -18 - - -_Printer -True -True -False -True -0 -True -True - - -1 -0 - - - - -Print to _file -True -True -False -True -0 -True -printer - - -2 -0 - - - - -True -False -Settings for: -True -printer -0 - - -0 -0 - - +True +False +True +0 +True +True + + +0 +0 + + + + +Print to _file +True +True +False +True +0 +True +printer + + +0 +1 + + + + + + + + +True +False +Settings for +True +0 + + + + + + + +0 +0 + + + + +True +False +0 +none + + +True +False +6 +12 + + +True +False +3 + + +P_aper size +True +True +False +True +0 +True 0 @@ -91,25 +119,130 @@ - + +Pap_er orientation +True +True +False +True +0 +True + + +0 +1 + + + + +_Transparency +True +True +False +True +0 +True + + +0 +2
[Libreoffice-bugs] [Bug 128857] wraparound isn't possible
https://bugs.documentfoundation.org/show_bug.cgi?id=128857 Dieter Praas changed: What|Removed |Added Blocks||103152 --- Comment #9 from Dieter Praas --- (In reply to helmut from comment #8) > My problem existed at a new document created by LO 6.5.0.0. So it was possible for you in earlier versions? @Bogdan: Could you please attach the document of your video? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103152 [Bug 103152] [META] Writer image bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - cui/uiconfig
cui/uiconfig/ui/effectspage.ui |2 ++ 1 file changed, 2 insertions(+) New commits: commit 35a55533728fb3ee5746ef8f9f45762164f03902 Author: andreas kainz AuthorDate: Sun Nov 17 14:58:43 2019 +0100 Commit: Heiko Tietze CommitDate: Tue Nov 19 08:31:05 2019 +0100 tdf#127927 Character Dialog effect preview Alignment Change-Id: If4bf99711b09c61d00dafb65ba76f4673c99246b Reviewed-on: https://gerrit.libreoffice.org/83019 Tested-by: Jenkins Reviewed-by: andreas_kainz (cherry picked from commit 52d0027332ecd9ea9d941113c7fbe66ebc3cf48a) Reviewed-on: https://gerrit.libreoffice.org/83057 Reviewed-by: Heiko Tietze diff --git a/cui/uiconfig/ui/effectspage.ui b/cui/uiconfig/ui/effectspage.ui index cdea5a4e2580..9a5cb1a89fe1 100644 --- a/cui/uiconfig/ui/effectspage.ui +++ b/cui/uiconfig/ui/effectspage.ui @@ -14,7 +14,9 @@ True False +end True +True 6 12 12 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 103152] [META] Writer image bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103152 Dieter Praas changed: What|Removed |Added Depends on||128857 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=128857 [Bug 128857] wraparound isn't possible -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128888] Transparent objects causing excessive CPU usage when exporting PNG from LO Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=12 mwtjunkm...@gmail.com changed: What|Removed |Added CC||mwtjunkm...@gmail.com --- Comment #1 from mwtjunkm...@gmail.com --- Created attachment 155934 --> https://bugs.documentfoundation.org/attachment.cgi?id=155934=edit test file For the attached LO draw file to test with for exporting PNGs: 1. Slide 1 exports normally 2. Slide 2 exports normally 3. Slide 3 has a transparent text converted to a curve and hinders export 4. Slide 4 exports normally 5. Slide 5 has a transparent text converted to a polygon and hinders export 6. Slide 6 exports normally having a transparent square on it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128316] FIELDS: Allow date field with lower case letters
https://bugs.documentfoundation.org/show_bug.cgi?id=128316 Heiko Tietze changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #16 from Heiko Tietze --- (In reply to Mike Kaganski from comment #15) > Aren't "LOWER" function in Calc and Format->Text->Lowercase in Writer > cross-platform? To my knowledge there is no lower() (or any similar) function in Writer - except using a macro. > > => WF > > Disagree. That's why I added you to CC :-) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128316] FIELDS: Allow date field with lower case letters
https://bugs.documentfoundation.org/show_bug.cgi?id=128316 Heiko Tietze changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #16 from Heiko Tietze --- (In reply to Mike Kaganski from comment #15) > Aren't "LOWER" function in Calc and Format->Text->Lowercase in Writer > cross-platform? To my knowledge there is no lower() (or any similar) function in Writer - except using a macro. > > => WF > > Disagree. That's why I added you to CC :-) -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 128888] New: Transparent objects causing excessive CPU usage when exporting PNG from LO Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=12 Bug ID: 12 Summary: Transparent objects causing excessive CPU usage when exporting PNG from LO Draw Product: LibreOffice Version: 6.3.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mwtjunkm...@gmail.com Description: When I export a slide to PNG from Draw having text converted to a curve or polygon and the text is set transparent, Windows Task Manager shows "VERY HIGH" for power usage for LO both while the PNG export dialog is preparing to display on the screen and then again while saving. The saving process takes considerably longer than slides without transparency (or with transparency and exporting via TIFF). This does not occur when exporting TIFF files. Note: This does not happen with other transparent objects, just text that's been converted to a curve (OR POLYGON) and that curve/polygon made transparent. Text converted to a curve/polygon but not made transparent does not hinder the export process. Steps to Reproduce: 1. Open LO Draw 2. Import a picture 3. On top of that picture, type some text. 4. Convert text to a curve 5. Set the text's transparency to something other than 0. 6. Export the slide as PNG Actual Results: Manager shows "VERY HIGH" for power usage for LO both while the PNG export dialog is on the screen and then again while saving. Expected Results: Power usage and export time should be essentially no different for transparent objects on a slide when exporting to PNG as opposed to another format like TIFF. Reproducible: Always User Profile Reset: No Additional Info: Windows 10 Pro Version 1901 Build 19363.476 nVIdia GTX 1050 with driver version 441.20 released Nov 12 2019. 32GB RAM 3770 K I7 64 Bit Processor What I experienced happens regardless if hardware acceleration is on or off or if Open GL is used. I usually work with Open GL off and with hardware acceleration and anti-aliasing on. Because I have not been using transparent text until now, I do not know whether this is something new with 6.3.3.2 or would have been happening in earlier versions. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128883] FORMATTING A custom character style with regular text, applied to a word in a custom paragraph style with bold text: the word remains bold.
https://bugs.documentfoundation.org/show_bug.cgi?id=128883 Heiko Tietze changed: What|Removed |Added Ever confirmed|0 |1 CC||mikekagan...@hotmail.com Status|UNCONFIRMED |NEW --- Comment #2 from Heiko Tietze --- When you create a new CS based on content with bold weight it works to set regular. It doesn't when regular is not explicitly selected such as for Emphasis (Italic but though not bold it keeps what PS defines). So the issue is a bug to me. We store only changed attributes (see the organizer) and do not apply unmodified attributes, here related to Default CS/PS. Possible solution is to introduce radioboxes for font weight "(x) Regular" "( ) Bold" "( ) Italic" "( ) Bold, Italic" but we run into trouble with 4 or more variants (see also bug 35538). Perhaps we just have to consider Regular as on by default - and put all non-changed values into the document. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122197] Font sizes are not exhibited in Find & Replace window nor applied.
https://bugs.documentfoundation.org/show_bug.cgi?id=122197 Dieter Praas changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/inc vcl/qa vcl/source
vcl/inc/widgetdraw/WidgetDefinition.hxx |7 +++
vcl/qa/cppunit/widgetdraw/WidgetDefinitionReaderTest.cxx | 28 +-
vcl/qa/cppunit/widgetdraw/data/definitionSettings1.xml |5 ++
vcl/qa/cppunit/widgetdraw/data/definitionSettings2.xml |6 +++
vcl/qa/cppunit/widgetdraw/data/definitionSettings3.xml |6 +++
vcl/source/gdi/FileDefinitionWidgetDraw.cxx | 12 +-
vcl/source/gdi/WidgetDefinition.cxx |2 -
vcl/source/gdi/WidgetDefinitionReader.cxx| 30 +++
8 files changed, 93 insertions(+), 3 deletions(-)
New commits:
commit b234743dd26e0be4be272d2d2c82f90c67e192b7
Author: Tomaž Vajngerl
AuthorDate: Mon Nov 18 22:50:46 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Tue Nov 19 08:17:29 2019 +0100
widget theme: add centeredTabs setting to theme definition file
Change-Id: I714a44d40a99e0bb5ff48e3d36ded73db60af5a0
Reviewed-on: https://gerrit.libreoffice.org/83133
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/inc/widgetdraw/WidgetDefinition.hxx
b/vcl/inc/widgetdraw/WidgetDefinition.hxx
index 7c0259468328..50a853a6c1a6 100644
--- a/vcl/inc/widgetdraw/WidgetDefinition.hxx
+++ b/vcl/inc/widgetdraw/WidgetDefinition.hxx
@@ -201,6 +201,12 @@ public:
std::vector> maStates;
};
+class VCL_DLLPUBLIC WidgetDefinitionSettings
+{
+public:
+OString msCenteredTabs;
+};
+
class VCL_DLLPUBLIC WidgetDefinitionStyle
{
public:
@@ -263,6 +269,7 @@ class VCL_DLLPUBLIC WidgetDefinition
{
public:
std::shared_ptr mpStyle;
+std::shared_ptr mpSettings;
std::unordered_map> maDefinitions;
std::shared_ptr getDefinition(ControlType eType,
ControlPart ePart);
};
diff --git a/vcl/qa/cppunit/widgetdraw/WidgetDefinitionReaderTest.cxx
b/vcl/qa/cppunit/widgetdraw/WidgetDefinitionReaderTest.cxx
index 9cf818932c38..cd7945fba82c 100644
--- a/vcl/qa/cppunit/widgetdraw/WidgetDefinitionReaderTest.cxx
+++ b/vcl/qa/cppunit/widgetdraw/WidgetDefinitionReaderTest.cxx
@@ -28,18 +28,44 @@ private:
public:
void testRead();
+void testReadSettings();
CPPUNIT_TEST_SUITE(WidgetDefinitionReaderTest);
CPPUNIT_TEST(testRead);
+CPPUNIT_TEST(testReadSettings);
CPPUNIT_TEST_SUITE_END();
};
+void WidgetDefinitionReaderTest::testReadSettings()
+{
+{
+vcl::WidgetDefinition aDefinition;
+vcl::WidgetDefinitionReader
aReader(getFullUrl("definitionSettings1.xml"), getFullUrl(""));
+CPPUNIT_ASSERT(aReader.read(aDefinition));
+CPPUNIT_ASSERT_EQUAL(OString(""),
aDefinition.mpSettings->msCenteredTabs);
+}
+
+{
+vcl::WidgetDefinition aDefinition;
+vcl::WidgetDefinitionReader
aReader(getFullUrl("definitionSettings2.xml"), getFullUrl(""));
+CPPUNIT_ASSERT(aReader.read(aDefinition));
+CPPUNIT_ASSERT_EQUAL(OString("true"),
aDefinition.mpSettings->msCenteredTabs);
+}
+
+{
+vcl::WidgetDefinition aDefinition;
+vcl::WidgetDefinitionReader
aReader(getFullUrl("definitionSettings3.xml"), getFullUrl(""));
+CPPUNIT_ASSERT(aReader.read(aDefinition));
+CPPUNIT_ASSERT_EQUAL(OString("false"),
aDefinition.mpSettings->msCenteredTabs);
+}
+}
+
void WidgetDefinitionReaderTest::testRead()
{
vcl::WidgetDefinition aDefinition;
vcl::WidgetDefinitionReader aReader(getFullUrl("definition1.xml"),
getFullUrl(""));
-aReader.read(aDefinition);
+CPPUNIT_ASSERT(aReader.read(aDefinition));
CPPUNIT_ASSERT_EQUAL(OUString("123456"),
aDefinition.mpStyle->maFaceColor.AsRGBHexString());
CPPUNIT_ASSERT_EQUAL(OUString("234567"),
aDefinition.mpStyle->maCheckedColor.AsRGBHexString());
diff --git a/vcl/qa/cppunit/widgetdraw/data/definitionSettings1.xml
b/vcl/qa/cppunit/widgetdraw/data/definitionSettings1.xml
new file mode 100644
index ..9ca7f894f29d
--- /dev/null
+++ b/vcl/qa/cppunit/widgetdraw/data/definitionSettings1.xml
@@ -0,0 +1,5 @@
+
+
+
+
+
diff --git a/vcl/qa/cppunit/widgetdraw/data/definitionSettings2.xml
b/vcl/qa/cppunit/widgetdraw/data/definitionSettings2.xml
new file mode 100644
index ..0d6d6e11151a
--- /dev/null
+++ b/vcl/qa/cppunit/widgetdraw/data/definitionSettings2.xml
@@ -0,0 +1,6 @@
+
+
+
+
+
+
diff --git a/vcl/qa/cppunit/widgetdraw/data/definitionSettings3.xml
b/vcl/qa/cppunit/widgetdraw/data/definitionSettings3.xml
new file mode 100644
index ..20541b2a219e
--- /dev/null
+++ b/vcl/qa/cppunit/widgetdraw/data/definitionSettings3.xml
@@ -0,0 +1,6 @@
+
+
+
+
+
+
diff --git a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
index d6f827de3938..580f3783143b 100644
--- a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
+++ b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
@@ -85,6 +85,15 @@ std::shared_ptr const&
getWidgetDefinitionForTheme(OUString co
return spDefinition;
}
+bool
[Libreoffice-bugs] [Bug 128314] Obscure and unmanageable long month name capitalization rules in date formats (ru-RU)
https://bugs.documentfoundation.org/show_bug.cgi?id=128314 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||8316 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128316] FIELDS: Allow date field with lower case letters
https://bugs.documentfoundation.org/show_bug.cgi?id=128316 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||8314 --- Comment #15 from Mike Kaganski --- (In reply to Heiko Tietze from comment #14) > The request is to introduce some kind of auto_un_capitalization. In > particular with fields I doubt it's possible cross-plattform Aren't "LOWER" function in Calc and Format->Text->Lowercase in Writer cross-platform? > and -application. Do you actively limit LibreOffice to only be a common subset of other office suites? How about limiting ourselves to what notepad offers? > => WF Disagree. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124380] Writer loses indenting of paragraphs on paragraph space change
https://bugs.documentfoundation.org/show_bug.cgi?id=124380 --- Comment #7 from Dieter Praas --- I also can't confirm it with Version: 6.4.0.0.beta1 (x64) Build ID: 4d7e5b0c40ed843384704eca3ce21981d4e98920 CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; Locale: de-DE (de_DE); UI-Language: en-US Calc: threaded Does it also happen in save mode (Heplp => Restart in Save Mode)? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128316] FIELDS: Allow date field with lower case letters
https://bugs.documentfoundation.org/show_bug.cgi?id=128316 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||8314 --- Comment #15 from Mike Kaganski --- (In reply to Heiko Tietze from comment #14) > The request is to introduce some kind of auto_un_capitalization. In > particular with fields I doubt it's possible cross-plattform Aren't "LOWER" function in Calc and Format->Text->Lowercase in Writer cross-platform? > and -application. Do you actively limit LibreOffice to only be a common subset of other office suites? How about limiting ourselves to what notepad offers? > => WF Disagree. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 128316] FIELDS: Allow date field with lower case letters
https://bugs.documentfoundation.org/show_bug.cgi?id=128316 Heiko Tietze changed: What|Removed |Added CC||mikekagan...@hotmail.com --- Comment #14 from Heiko Tietze --- (In reply to Dieter Praas from comment #13) > Suggestion: Add an option to Format Number dialog. (In reply to Eike Rathke from comment #5) > Formatted date fields' day and month names are taken from locale data as is, > there is no auto-capitalization. The request is to introduce some kind of auto_un_capitalization. In particular with fields I doubt it's possible cross-plattform and -application. => WF -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 128882] LO64b1 on macOS: crashing upon opening/creating a document
https://bugs.documentfoundation.org/show_bug.cgi?id=128882 Xisco Faulí changed: What|Removed |Added CC||sberg...@redhat.com --- Comment #4 from Xisco Faulí --- @Stephan, do you reproduce this issue with a local build ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128316] FIELDS: Allow date field with lower case letters
https://bugs.documentfoundation.org/show_bug.cgi?id=128316 Heiko Tietze changed: What|Removed |Added CC||mikekagan...@hotmail.com --- Comment #14 from Heiko Tietze --- (In reply to Dieter Praas from comment #13) > Suggestion: Add an option to Format Number dialog. (In reply to Eike Rathke from comment #5) > Formatted date fields' day and month names are taken from locale data as is, > there is no auto-capitalization. The request is to introduce some kind of auto_un_capitalization. In particular with fields I doubt it's possible cross-plattform and -application. => WF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128460] Exported Writer input fields are not imported correctly from docx
https://bugs.documentfoundation.org/show_bug.cgi?id=128460 Michael Weghorn changed: What|Removed |Added Status|RESOLVED|VERIFIED CC||m.wegh...@posteo.de --- Comment #6 from Michael Weghorn --- (In reply to Oliver Brinzing from comment #3) > Is it possible to backport this fix to LO 6.3? The patch for 6.3 just landed. Setting status to VERIFIED FIXED according to comment 4 and comment 5. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128460] Exported Writer input fields are not imported correctly from docx
https://bugs.documentfoundation.org/show_bug.cgi?id=128460 --- Comment #5 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/commit/90424d0b6d316998ff3e2632add0f0c8da55e3a2 tdf#128460 import SwInputField from DOCX FILLIN It will be available in 6.3.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128460] Exported Writer input fields are not imported correctly from docx
https://bugs.documentfoundation.org/show_bug.cgi?id=128460 Commit Notification changed: What|Removed |Added Whiteboard|target:6.4.0|target:6.4.0 target:6.3.4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - writerfilter/source
writerfilter/source/dmapper/DomainMapper_Impl.cxx | 23 +++---
1 file changed, 12 insertions(+), 11 deletions(-)
New commits:
commit 90424d0b6d316998ff3e2632add0f0c8da55e3a2
Author: Jan-Marek Glogowski
AuthorDate: Tue Oct 29 14:39:05 2019 +0100
Commit: Michael Weghorn
CommitDate: Tue Nov 19 08:09:08 2019 +0100
tdf#128460 import SwInputField from DOCX FILLIN
Actually the whole FILLIN handling is not that correct, because
the value can actually be formatted in any way in Word, as it's
just defined as a range of runs with formating, while Writer just
applies the character formatitng to the whole field.
But this at least allows for a round trip of the exported Writer
type input field after commit 62d156ef ("tdf#125103 Writer:
input fields will be exported to docx") changed this.
Change-Id: I6389b4a2ff9d2b62e1e4a00f1c1e112c199377b5
Regression-from: 62d156ef0daccd2680161ef8b9b99d8a7bc0
Reviewed-on: https://gerrit.libreoffice.org/81686
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
(cherry picked from commit 5e279f175289234b91f272bbbf48e70315fff5ac)
Reviewed-on: https://gerrit.libreoffice.org/83039
Reviewed-by: Michael Weghorn
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index a24eadd95aa0..96352aab7b99 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -5012,7 +5012,9 @@ bool DomainMapper_Impl::IsFieldResultAsString()
OSL_ENSURE( pContext.get(), "no field context available");
if( pContext.get() )
{
-bRet = pContext->GetTextField().is() || pContext->GetFieldId() ==
FIELD_FORMDROPDOWN;
+bRet = pContext->GetTextField().is()
+|| pContext->GetFieldId() == FIELD_FORMDROPDOWN
+|| pContext->GetFieldId() == FIELD_FILLIN;
}
if (!bRet)
@@ -5183,19 +5185,18 @@ void DomainMapper_Impl::SetFieldResult(OUString const&
rResult)
else
{
uno::Reference< beans::XPropertySet >
xFieldProperties( xTextField, uno::UNO_QUERY_THROW);
-// In case of SetExpression, the field result contains
the content of the variable.
uno::Reference
xServiceInfo(xTextField, uno::UNO_QUERY);
-bool bIsSetExpression =
xServiceInfo->supportsService("com.sun.star.text.TextField.SetExpression");
-// If we already have content set, then use the
current presentation
-OUString sValue;
-if (bIsSetExpression)
-{ // this will throw for field types without Content
-uno::Any aValue(xFieldProperties->getPropertyValue(
-getPropertyName(PROP_CONTENT)));
-aValue >>= sValue;
+OUString sContent;
+bool bCanHaveContent = false;
+try
+{ // this will throw for field types without Content
property
+uno::Any
aValue(xFieldProperties->getPropertyValue(getPropertyName(PROP_CONTENT)));
+bCanHaveContent = true;
+aValue >>= sContent;
}
+catch (...) {}
xFieldProperties->setPropertyValue(
-getPropertyName(bIsSetExpression &&
sValue.isEmpty()? PROP_CONTENT : PROP_CURRENT_PRESENTATION),
+getPropertyName(bCanHaveContent &&
sContent.isEmpty()? PROP_CONTENT : PROP_CURRENT_PRESENTATION),
uno::makeAny( rResult ));
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 122197] Font sizes are not exhibited in Find & Replace window nor applied.
https://bugs.documentfoundation.org/show_bug.cgi?id=122197 Dieter Praas changed: What|Removed |Added CC||dgp-m...@gmx.de Blocks||113136 --- Comment #13 from Dieter Praas --- Ricky, perhaps it is related to bug 126527, that is fixed in LO 6.4. So could you give it a try with 6.4.0.0.beta1? => NEEDINFO Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113136 [Bug 113136] [META] Find & Replace Dialog -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113136] [META] Find & Replace Dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=113136 Dieter Praas changed: What|Removed |Added Depends on||122197 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122197 [Bug 122197] Font sizes are not exhibited in Find & Replace window nor applied. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128882] LO64b1 on macOS: crashing upon opening/creating a document
https://bugs.documentfoundation.org/show_bug.cgi?id=128882 --- Comment #3 from Xisco Faulí --- Same problem is safe mode -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104444] [META] DOCX (OOXML) table-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=10 Bug 10 depends on bug 119054, which changed state. Bug 119054 Summary: FILEOPEN DOCX Paragraph style in a table appears without the set spacing below https://bugs.documentfoundation.org/show_bug.cgi?id=119054 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107831] [META] Paragraph-level bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107831 Bug 107831 depends on bug 119054, which changed state. Bug 119054 Summary: FILEOPEN DOCX Paragraph style in a table appears without the set spacing below https://bugs.documentfoundation.org/show_bug.cgi?id=119054 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119054] FILEOPEN DOCX Paragraph style in a table appears without the set spacing below
https://bugs.documentfoundation.org/show_bug.cgi?id=119054 László Németh changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128882] LO64b1 on macOS: crashing upon opening/creating a document
https://bugs.documentfoundation.org/show_bug.cgi?id=128882 --- Comment #2 from Xisco Faulí --- Not reproduced in Version: 6.4.0.0.alpha1+ Build ID: 9bc848cf0d301aa57eabcffa101a1cf87bad6470 CPU threads: 8; OS: Mac OS X 10.14.6; UI render: default; VCL: osx; Locale: en-US (en_ES.UTF-8); UI-Language: en-US Calc: threaded (libreoffice-6-4-branch-point) so I believe the problem is with the packaging? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128887] New: TP Link Login | +18442458772 | TP Link Router Login | Tplinklogin
https://bugs.documentfoundation.org/show_bug.cgi?id=128887 Bug ID: 128887 Summary: TP Link Login | +18442458772 | TP Link Router Login | Tplinklogin Product: cppunit Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: General Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: noah2536...@gmail.com CC: markus.mohrh...@googlemail.com Using the default TP Link router IP address, one can easily perform the login procedure. Although, there are some hindrances which can take you back from using the router’s dashboard. Password failure is the biggest issue. To know how to resolve T p link router login issues, simply dial our toll-free number and get your issues fixed right away. A pool of experts are waiting for your call. When you call us, we will give your call to experts. You can sit back and enjoy your cup of tea as our tech experts will remotely handle everything. All you have to dial is our +1-844-245-8772 toll-free number or yo |u can also send us an email. To know more about Tplink-login, visit our website. https://routerfixiya.com/tp-link-login/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107739] [META] Field bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107739 Dieter Praas changed: What|Removed |Added Depends on|128316 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=128316 [Bug 128316] FIELDS: Allow date field with lower case letters -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128316] FIELDS: Allow date field with lower case letters
https://bugs.documentfoundation.org/show_bug.cgi?id=128316 Dieter Praas changed: What|Removed |Added Summary|turn off autocapitalisation |FIELDS: Allow date field |for date and whatever |with lower case letters |locale | Blocks|107739 |114039 Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #13 from Dieter Praas --- itt 788, yes I understand your request. Perhaps "autocapitalisation" leeds to a wrong direction. I changed bug title and I think it's an enhancement request. Steps to reproduce: 1. Open a document 2. Open fields dialog (strg+2) 3. Document => date: You can't choose a date with lower case letters 4. Additional formats: You can't choose a date with lower case letters Suggestion: Add an option to Format Number dialog. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107739 [Bug 107739] [META] Field bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=114039 [Bug 114039] [META] Field dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114039] [META] Field dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114039 Dieter Praas changed: What|Removed |Added Depends on||128316 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=128316 [Bug 128316] FIELDS: Allow date field with lower case letters -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128316] FIELDS: Allow date field with lower case letters
https://bugs.documentfoundation.org/show_bug.cgi?id=128316 Dieter Praas changed: What|Removed |Added Summary|turn off autocapitalisation |FIELDS: Allow date field |for date and whatever |with lower case letters |locale | Blocks|107739 |114039 Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #13 from Dieter Praas --- itt 788, yes I understand your request. Perhaps "autocapitalisation" leeds to a wrong direction. I changed bug title and I think it's an enhancement request. Steps to reproduce: 1. Open a document 2. Open fields dialog (strg+2) 3. Document => date: You can't choose a date with lower case letters 4. Additional formats: You can't choose a date with lower case letters Suggestion: Add an option to Format Number dialog. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107739 [Bug 107739] [META] Field bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=114039 [Bug 114039] [META] Field dialog bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 128882] LO64b1 on macOS: crashing upon opening/creating a document
https://bugs.documentfoundation.org/show_bug.cgi?id=128882 Xisco Faulí changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Priority|high|highest CC||xiscofa...@libreoffice.org --- Comment #1 from Xisco Faulí --- Indeed, I can reproduce it in Version: 6.4.0.0.beta1 Build ID: 4d7e5b0c40ed843384704eca3ce21981d4e98920 CPU threads: 8; OS: Mac OS X 10.14.6; UI render: default; VCL: osx; Locale: en-US (en_ES.UTF-8); UI-Language: en-US Calc: threaded but not in Version: 6.4.0.0.beta1+ Build ID: c2097477e3a43d75c170a6f7a5daf5dcb2169329 CPU threads: 8; OS: Mac OS X 10.14.6; UI render: default; VCL: osx; Locale: en-US (en_ES.UTF-8); UI-Language: en-US Calc: threaded (bisect repo) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtk3gtkinst.cxx | 98 +--
1 file changed, 67 insertions(+), 31 deletions(-)
New commits:
commit e18e244dd7f352817116cfdc8720d684d55679ee
Author: Stephan Bergmann
AuthorDate: Mon Nov 18 23:10:28 2019 +0100
Commit: Stephan Bergmann
CommitDate: Tue Nov 19 07:59:17 2019 +0100
Improved loplugin:external, handling class types
...plus follow-up loplugin:fakebool and renaming the non-external (moved to
unnamed namespace) three-parameter load_icon_by_name overload to
load_icon_by_name_theme_lang, because it would otherwise hide the
one-parameter
load_icon_by_name
Change-Id: Ie01151c1b4648bd797cc455ec092281448ed4637
Reviewed-on: https://gerrit.libreoffice.org/83134
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 398a194230b6..61ba40b9fa1c 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -605,6 +605,8 @@ sal_Bool SAL_CALL
GtkTransferable::isDataFlavorSupported(const css::datatransfer
return std::any_of(aAll.begin(), aAll.end(), DataFlavorEq(rFlavor));
}
+namespace {
+
class GtkClipboardTransferable : public GtkTransferable
{
private:
@@ -739,6 +741,8 @@ public:
void OwnerPossiblyChanged(GtkClipboard *clipboard);
};
+}
+
OUString VclGtkClipboard::getImplementationName()
{
return "com.sun.star.datatransfer.VclGtkClipboard";
@@ -1338,6 +1342,8 @@ Reference< XInterface > GtkInstance::CreateDragSource()
return Reference< XInterface >( static_cast(new
GtkDragSource()) );
}
+namespace {
+
class GtkOpenGLContext : public OpenGLContext
{
GLWindow m_aGLWin;
@@ -1598,6 +1604,8 @@ private:
}
};
+}
+
OpenGLContext* GtkInstance::CreateOpenGLContext()
{
return new GtkOpenGLContext;
@@ -1620,10 +1628,11 @@ bool DLSYM_GDK_IS_X11_DISPLAY(GdkDisplay* pDisplay)
return G_TYPE_CHECK_INSTANCE_TYPE(pDisplay, get_type());
}
-class GtkInstanceBuilder;
-
namespace
{
+
+class GtkInstanceBuilder;
+
void set_help_id(const GtkWidget *pWidget, const OString& rHelpId)
{
gchar *helpid = g_strdup(rHelpId.getStr());
@@ -1778,6 +1787,8 @@ namespace
}
}
+namespace {
+
class GtkInstanceWidget : public virtual weld::Widget
{
protected:
@@ -2609,7 +2620,7 @@ public:
m_aSizeAllocateHdl.Call(Size(nWidth, nHeight));
}
-gboolean signal_key(const GdkEventKey* pEvent)
+bool signal_key(const GdkEventKey* pEvent)
{
if (pEvent->type == GDK_KEY_PRESS && m_aKeyPressHdl.IsSet())
{
@@ -2790,6 +2801,8 @@ public:
}
};
+}
+
IMPL_LINK_NOARG(GtkInstanceWidget, async_signal_focus_in, void*, void)
{
m_pFocusInEvent = nullptr;
@@ -2886,7 +2899,7 @@ namespace
return pixbuf;
}
-GdkPixbuf* load_icon_by_name(const OUString& rIconName, const OUString&
rIconTheme, const OUString& rUILang)
+GdkPixbuf* load_icon_by_name_theme_lang(const OUString& rIconName, const
OUString& rIconTheme, const OUString& rUILang)
{
auto xMemStm = ImageTree::get().getImageStream(rIconName, rIconTheme,
rUILang);
if (!xMemStm)
@@ -2899,7 +2912,7 @@ GdkPixbuf* load_icon_by_name(const OUString& rIconName)
{
OUString sIconTheme =
Application::GetSettings().GetStyleSettings().DetermineIconTheme();
OUString sUILang =
Application::GetSettings().GetUILanguageTag().getBcp47();
-return load_icon_by_name(rIconName, sIconTheme, sUILang);
+return load_icon_by_name_theme_lang(rIconName, sIconTheme, sUILang);
}
namespace
@@ -2973,7 +2986,6 @@ namespace
}
return pImage;
}
-}
class MenuHelper
{
@@ -3212,8 +3224,6 @@ public:
}
};
-namespace
-{
class ChildFrame : public WorkWindow
{
public:
@@ -3228,7 +3238,6 @@ namespace
pChild->SetPosSizePixel(Point(0, 0), GetSizePixel());
}
};
-}
class GtkInstanceContainer : public GtkInstanceWidget, public virtual
weld::Container
{
@@ -3302,6 +3311,8 @@ public:
}
};
+}
+
std::unique_ptr GtkInstanceWidget::weld_parent() const
{
GtkWidget* pParent = gtk_widget_get_parent(m_pWidget);
@@ -3310,6 +3321,8 @@ std::unique_ptr
GtkInstanceWidget::weld_parent() const
return std::make_unique(GTK_CONTAINER(pParent),
m_pBuilder, false);
}
+namespace {
+
class GtkInstanceBox : public GtkInstanceContainer, public virtual weld::Box
{
private:
@@ -3331,8 +3344,6 @@ public:
}
};
-namespace
-{
void set_cursor(GtkWidget* pWidget, const char *pName)
{
if (!gtk_widget_get_realized(pWidget))
@@ -3466,7 +3477,6 @@ namespace
if (GTK_IS_CONTAINER(pItem))
gtk_container_forall(GTK_CONTAINER(pItem),
do_collect_screenshot_data, data);
}
-}
class GtkInstanceWindow : public GtkInstanceContainer, public virtual
weld::Window
{
@@ -3882,6 +3892,8 @@ struct DialogRunner
}
};
+}
+
typedef
[Libreoffice-bugs] [Bug 119054] FILEOPEN DOCX Paragraph style in a table appears without the set spacing below
https://bugs.documentfoundation.org/show_bug.cgi?id=119054 --- Comment #6 from Commit Notification --- László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6100909c84550036932d031f4d2f652e158a1a0a tdf#119054 DOCX: fix not table style based bottom margin It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf119054.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport6.cxx| 12
writerfilter/source/dmapper/DomainMapperTableHandler.cxx | 45 ---
writerfilter/source/dmapper/DomainMapperTableHandler.hxx |3 +
writerfilter/source/dmapper/DomainMapper_Impl.cxx| 22 +++
writerfilter/source/dmapper/DomainMapper_Impl.hxx| 11 +++
6 files changed, 71 insertions(+), 22 deletions(-)
New commits:
commit 6100909c84550036932d031f4d2f652e158a1a0a
Author: László Németh
AuthorDate: Fri Nov 15 15:44:55 2019 +0100
Commit: László Németh
CommitDate: Tue Nov 19 07:53:26 2019 +0100
tdf#119054 DOCX: fix not table style based bottom margin
in table cells, ie. using paragraph styles with bottom
margin setting or direct paragraph formatting of bottom
margin. Both of them overwrite the table style based
bottom margin.
Change-Id: I527b16c24fe47df8412291089ff86fadd3f9430b
Reviewed-on: https://gerrit.libreoffice.org/82800
Reviewed-by: László Németh
Tested-by: László Németh
diff --git a/sw/qa/extras/ooxmlexport/data/tdf119054.docx
b/sw/qa/extras/ooxmlexport/data/tdf119054.docx
new file mode 100644
index ..9c3657c24a97
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf119054.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
index 9e0859f028e7..d460679b50ba 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
@@ -468,6 +468,18 @@ DECLARE_OOXMLEXPORT_TEST(testTdf128752, "tdf128752.docx")
assertXPath(pXmlDoc,
"/w:document/w:body/w:tbl/w:tr[1]/w:tc[1]/w:p[1]/w:pPr/w:spacing", "after",
"0");
}
+DECLARE_OOXMLEXPORT_TEST(testTdf119054, "tdf119054.docx")
+{
+xmlDocPtr pXmlDoc = parseExport();
+if (!pXmlDoc)
+return;
+// Don't overwrite before and after spacing of Heading2 by table style
+assertXPathNoAttribute(pXmlDoc,
"/w:document/w:body/w:tbl/w:tr[1]/w:tc[1]/w:p[1]/w:pPr/w:spacing", "before");
+assertXPathNoAttribute(pXmlDoc,
"/w:document/w:body/w:tbl/w:tr[1]/w:tc[1]/w:p[1]/w:pPr/w:spacing", "after");
+// Use table style based single line spacing instead of the docDefaults'
254
+assertXPath(pXmlDoc,
"/w:document/w:body/w:tbl/w:tr[1]/w:tc[1]/w:p[1]/w:pPr/w:spacing", "line",
"240");
+}
+
DECLARE_OOXMLEXPORT_TEST(testFdo69636, "fdo69636.docx")
{
/*
diff --git a/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
b/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
index d80f4b36518d..3996df51d8e4 100644
--- a/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
+++ b/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
@@ -809,6 +809,9 @@ CellPropertyValuesSeq_t
DomainMapperTableHandler::endTableGetCellProperties(Tabl
// Remove properties from style/row that aren't allowed in
cells
pAllCellProps->Erase( PROP_HEADER_ROW_COUNT );
pAllCellProps->Erase( PROP_TBL_HEADER );
+// Remove paragraph properties from style/row that paragraph
style can overwrite
+pAllCellProps->Erase( PROP_PARA_BOTTOM_MARGIN );
+pAllCellProps->Erase( PROP_PARA_LINE_SPACING );
// Then add the cell properties
pAllCellProps->InsertProps(*aCellIterator);
@@ -974,6 +977,36 @@ css::uno::Sequence
DomainMapperTableHandler::endTabl
return aRowProperties;
}
+// table style has got bigger precedence than docDefault style,
+// but lower precedence than the paragraph styles and direct paragraph
formatting
+void DomainMapperTableHandler::ApplyParaProperty(css::beans::PropertyValues
aTableProperties, PropertyIds eId)
+{
+OUString sPropertyName = getPropertyName(eId);
+auto pTableProp = std::find_if(aTableProperties.begin(),
aTableProperties.end(),
+[&](const beans::PropertyValue& rProp) { return rProp.Name ==
sPropertyName; });
+if (pTableProp != aTableProperties.end())
+{
+uno::Any aValue = pTableProp->Value;
+for (const auto& rParaProp : m_rDMapper_Impl.m_aParagraphsToEndTable)
+{
+// there is no direct paragraph formatting
+if (!rParaProp.m_pPropertyMap->isSet(eId))
+{
+OUString sParaStyleName;
+rParaProp.m_rPropertySet->getPropertyValue("ParaStyleName")
>>= sParaStyleName;
+StyleSheetEntryPtr pEntry =
m_rDMapper_Impl.GetStyleSheetTable()->FindStyleSheetByConvertedStyleName(sParaStyleName);
+uno::Any aMargin =
m_rDMapper_Impl.GetPropertyFromStyleSheet(eId, pEntry, true, true);
+uno::Any aMarginDocDefault =
m_rDMapper_Impl.GetPropertyFromStyleSheet(eId, nullptr, true, true);
+// use table style only when 1) both values are empty (no
docDefault and paragraph style definitions) or
+
[Libreoffice-bugs] [Bug 119054] FILEOPEN DOCX Paragraph style in a table appears without the set spacing below
https://bugs.documentfoundation.org/show_bug.cgi?id=119054 Commit Notification changed: What|Removed |Added Whiteboard||target:6.5.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: emfio/inc framework/inc include/drawinglayer include/editeng include/i18nutil
emfio/inc/mtftools.hxx |2 -
framework/inc/classes/actiontriggercontainer.hxx |2 -
framework/inc/classes/actiontriggerpropertyset.hxx | 20
+-
framework/inc/classes/imagewrapper.hxx |3 -
framework/inc/classes/protocolhandlercache.hxx |2 -
framework/inc/classes/rootactiontriggercontainer.hxx |2 -
framework/inc/helper/mischelper.hxx|2 -
framework/inc/helper/propertysetcontainer.hxx |2 -
framework/inc/helper/shareablemutex.hxx|2 -
framework/inc/uielement/itemcontainer.hxx |2 -
framework/inc/xml/menudocumenthandler.hxx | 13 +++---
framework/inc/xml/statusbardocumenthandler.hxx |4 +-
framework/inc/xml/toolboxdocumenthandler.hxx |4 +-
framework/inc/xml/xmlnamespaces.hxx|2 -
include/drawinglayer/primitive3d/hatchtextureprimitive3d.hxx |2 -
include/drawinglayer/primitive3d/hiddengeometryprimitive3d.hxx |2 -
include/drawinglayer/primitive3d/polygonprimitive3d.hxx|2 -
include/drawinglayer/primitive3d/polygontubeprimitive3d.hxx|2 -
include/drawinglayer/primitive3d/shadowprimitive3d.hxx |2 -
include/drawinglayer/primitive3d/textureprimitive3d.hxx| 10 ++---
include/drawinglayer/processor3d/geometry2dextractor.hxx |2 -
include/drawinglayer/processor3d/shadow3dextractor.hxx |2 -
include/drawinglayer/texture/texture.hxx | 20
+-
include/drawinglayer/texture/texture3d.hxx |8 ++--
include/editeng/misspellrange.hxx |4 +-
include/editeng/section.hxx|2 -
include/i18nutil/oneToOneMapping.hxx |2 -
27 files changed, 60 insertions(+), 62 deletions(-)
New commits:
commit 4a19260d74c335fc6eb9216aacbf2d5bfbfc95aa
Author: Noel Grandin
AuthorDate: Fri Nov 15 14:37:48 2019 +0200
Commit: Noel Grandin
CommitDate: Tue Nov 19 07:52:24 2019 +0100
make some classes module-private
Change-Id: I53809ab01d5e8eb091305c3cb618a64920ad22ad
Reviewed-on: https://gerrit.libreoffice.org/82783
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/emfio/inc/mtftools.hxx b/emfio/inc/mtftools.hxx
index 736b1da2fe74..e335dc99fbf1 100644
--- a/emfio/inc/mtftools.hxx
+++ b/emfio/inc/mtftools.hxx
@@ -455,7 +455,7 @@ namespace emfio
{}
};
-class EMFIO_DLLPUBLIC MtfTools
+class MtfTools
{
MtfTools(MtfTools const &) = delete;
MtfTools& operator =(MtfTools const &) = delete;
diff --git a/framework/inc/classes/actiontriggercontainer.hxx
b/framework/inc/classes/actiontriggercontainer.hxx
index aa0b52a3ec6d..8bce32fa5e24 100644
--- a/framework/inc/classes/actiontriggercontainer.hxx
+++ b/framework/inc/classes/actiontriggercontainer.hxx
@@ -32,7 +32,7 @@
namespace framework
{
-class FWE_DLLPUBLIC ActionTriggerContainer :public PropertySetContainer,
+class ActionTriggerContainer :public PropertySetContainer,
public css::lang::XMultiServiceFactory,
public css::lang::XServiceInfo,
public css::lang::XTypeProvider
diff --git a/framework/inc/classes/actiontriggerpropertyset.hxx
b/framework/inc/classes/actiontriggerpropertyset.hxx
index be40992c8e5b..f1f730fd799c 100644
--- a/framework/inc/classes/actiontriggerpropertyset.hxx
+++ b/framework/inc/classes/actiontriggerpropertyset.hxx
@@ -44,22 +44,22 @@ class ActionTriggerPropertySet : private cppu::BaseMutex,
public ::cppu::OWeakObject
{
public:
-FWE_DLLPUBLIC ActionTriggerPropertySet();
-FWE_DLLPUBLIC virtual ~ActionTriggerPropertySet() override;
+ActionTriggerPropertySet();
+virtual ~ActionTriggerPropertySet() override;
// XInterface
-virtual FWE_DLLPUBLIC css::uno::Any SAL_CALL queryInterface( const
css::uno::Type& aType ) override;
-virtual FWE_DLLPUBLIC void SAL_CALL acquire() throw () override;
-virtual FWE_DLLPUBLIC void SAL_CALL release() throw () override;
+virtual css::uno::Any SAL_CALL queryInterface( const css::uno::Type&
aType ) override;
+virtual void SAL_CALL acquire() throw () override;
+virtual void SAL_CALL release() throw () override;
// XServiceInfo
-virtual FWE_DLLPUBLIC OUString SAL_CALL getImplementationName( )
override;
-virtual FWE_DLLPUBLIC sal_Bool SAL_CALL supportsService( const
OUString& ServiceName ) override;
-virtual FWE_DLLPUBLIC css::uno::Sequence< OUString > SAL_CALL
getSupportedServiceNames( ) override;
+virtual
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - writerfilter/source
writerfilter/source/dmapper/DomainMapperTableHandler.cxx | 30 ---
1 file changed, 30 deletions(-)
New commits:
commit 966188a11f2bb9545ed2ec8ae27f06bf1388617d
Author: László Németh
AuthorDate: Fri Nov 15 11:58:01 2019 +0100
Commit: László Németh
CommitDate: Tue Nov 19 07:52:10 2019 +0100
DOCX: clean-up paragraph bottom handling of table style
Revert of commit 17e904ed66c3caf87e658b9d3a18d7b13f4a0b52
("bnc#816593 DOCX filter: import paragraph spacing from table style),
keeping only the working unit test.
Change-Id: I735744aadb071ef2f0d939cb637d83cfc5716fe4
Reviewed-on: https://gerrit.libreoffice.org/82776
Tested-by: Jenkins
Reviewed-by: László Németh
(cherry picked from commit 00eeb7b3f765a51f51f7911a116982fbfb83efb7)
Reviewed-on: https://gerrit.libreoffice.org/83098
diff --git a/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
b/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
index efbaf3a0ffc3..d80f4b36518d 100644
--- a/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
+++ b/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
@@ -19,8 +19,6 @@
#include "DomainMapperTableHandler.hxx"
#include "DomainMapper_Impl.hxx"
#include "StyleSheetTable.hxx"
-#include
-#include
#include
#include
#include
@@ -976,23 +974,6 @@ css::uno::Sequence
DomainMapperTableHandler::endTabl
return aRowProperties;
}
-// Apply paragraph property to each paragraph within a cell.
-static void lcl_ApplyCellParaProps(uno::Reference const& xCell,
-const uno::Any& rBottomMargin)
-{
-uno::Reference xEnumerationAccess(xCell,
uno::UNO_QUERY);
-uno::Reference xEnumeration =
xEnumerationAccess->createEnumeration();
-while (xEnumeration->hasMoreElements())
-{
-uno::Reference
xParagraph(xEnumeration->nextElement(), uno::UNO_QUERY);
-uno::Reference xPropertyState(xParagraph,
uno::UNO_QUERY);
-// Don't apply in case direct formatting is already present.
-// TODO: probably paragraph style has priority over table style here.
-if (xPropertyState.is() &&
xPropertyState->getPropertyState("ParaBottomMargin") ==
beans::PropertyState_DEFAULT_VALUE)
-xParagraph->setPropertyValue("ParaBottomMargin", rBottomMargin);
-}
-}
-
void DomainMapperTableHandler::endTable(unsigned int nestedTableLevel, bool
bTableStartsAtCellStart)
{
#ifdef DBG_UTIL
@@ -1096,20 +1077,9 @@ void DomainMapperTableHandler::endTable(unsigned int
nestedTableLevel, bool bTab
[](const beans::PropertyValue& rProp) { return rProp.Name
== "ParaBottomMargin"; });
if (pTableProp != aTableInfo.aTableProperties.end())
{
-uno::Reference xCellRange(xTable,
uno::UNO_QUERY);
uno::Any aBottomMargin = pTableProp->Value;
-sal_Int32 nRows = aCellProperties.getLength();
-
for (const auto& rParaProp :
m_rDMapper_Impl.m_aPendingParaProp )
rParaProp->setPropertyValue("ParaBottomMargin",
aBottomMargin );
-
-for (sal_Int32 nRow = 0; nRow < nRows; ++nRow)
-{
-const uno::Sequence< beans::PropertyValues >
aCurrentRow = aCellProperties[nRow];
-sal_Int32 nCells = aCurrentRow.getLength();
-for (sal_Int32 nCell = 0; nCell < nCells; ++nCell)
-
lcl_ApplyCellParaProps(xCellRange->getCellByPosition(nCell, nRow),
aBottomMargin);
-}
}
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - chart2/source
chart2/source/model/template/ChartTypeTemplate.cxx |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
New commits:
commit c506720874cedc4999d0c0e4d680914a3100b832
Author: Balazs Varga
AuthorDate: Wed Nov 13 16:14:31 2019 +0100
Commit: László Németh
CommitDate: Tue Nov 19 07:51:39 2019 +0100
tdf#12 fix "CrossBetween" for not imported combined chart
Set the ShiftedCategoryPosition for true in case of combined chart.
See also commit 111c260ab2883b7906f1a66e222dbf4dc3c58c4f 'tdf#12
OOXML chart export: fix "CrossBetween" for not imported charts
Change-Id: I52fdcdc52e75ac15c85e04c2982b25cc180d7815
Reviewed-on: https://gerrit.libreoffice.org/82617
Tested-by: Jenkins
Reviewed-by: László Németh
Tested-by: László Németh
(cherry picked from commit 071007d83d9d29fa7879b71b0e7b396da70963a5)
Reviewed-on: https://gerrit.libreoffice.org/83097
Reviewed-by: Balazs Varga
diff --git a/chart2/source/model/template/ChartTypeTemplate.cxx
b/chart2/source/model/template/ChartTypeTemplate.cxx
index c18851796ada..afd9eb0f048a 100644
--- a/chart2/source/model/template/ChartTypeTemplate.cxx
+++ b/chart2/source/model/template/ChartTypeTemplate.cxx
@@ -626,7 +626,10 @@ void ChartTypeTemplate::adaptScales(
Reference< XChartType >
xChartType(getChartTypeForNewSeries(Sequence< Reference< XChartType > >()));
if( aData.AxisType == AxisType::CATEGORY )
{
-aData.ShiftedCategoryPosition =
::chart::ChartTypeHelper::shiftCategoryPosAtXAxisPerDefault(xChartType);
+if( !m_aServiceName.endsWith("ColumnWithLine")
)
+aData.ShiftedCategoryPosition =
::chart::ChartTypeHelper::shiftCategoryPosAtXAxisPerDefault(xChartType);
+else
+aData.ShiftedCategoryPosition = true;
}
bool bSupportsDates =
::chart::ChartTypeHelper::isSupportingDateAxis( xChartType, nDimensionX );
if( aData.AxisType != AxisType::CATEGORY && (
aData.AxisType != AxisType::DATE || !bSupportsDates) )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: desktop/source
desktop/source/app/app.cxx | 13 +
1 file changed, 13 insertions(+)
New commits:
commit 2d2a76dd0ada087c168134c0a873e0f9a98eea05
Author: Mike Kaganski
AuthorDate: Tue Nov 19 00:54:46 2019 +0200
Commit: Mike Kaganski
CommitDate: Tue Nov 19 07:47:14 2019 +0100
tdf#128523: drop cache directory when restart manager initiates restart
This would allow to re-create cached elements that could be broken.
Restarts include those after a version upgrade (with bugfixes); using
safe mode dialog (after crashes/problems); some configuration changes.
An example of issue fixed by this is bad cached icons from versions
affected by tdf#119020, that still make troubles to users after a year
after the reason of generation of bad icons had been fixed [1, 2, 3].
[1] https://ask.libreoffice.org/en/question/211759
[2] https://ask.libreoffice.org/en/question/215263
[3] https://ask.libreoffice.org/en/question/217831
Change-Id: I2362547c25f8f265915efafa4e224435eda03e20
Reviewed-on: https://gerrit.libreoffice.org/83138
Reviewed-by: Mike Kaganski
Tested-by: Mike Kaganski
diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx
index 31f7abbf9b4e..82422c835210 100644
--- a/desktop/source/app/app.cxx
+++ b/desktop/source/app/app.cxx
@@ -96,6 +96,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -327,6 +328,15 @@ void DoRestartActionsIfNecessary(bool quickstart) {
}
}
+void RemoveIconCacheDirectory()
+{
+// See getIconCacheUrl in vcl/source/image/ImplImageTree.cxx
+OUString sUrl = "${$BRAND_BASE_DIR/" LIBO_ETC_FOLDER
+"/" SAL_CONFIGFILE("bootstrap") ":UserInstallation}/cache";
+rtl::Bootstrap::expandMacros(sUrl);
+utl::UCBContentHelper::Kill(sUrl);
+}
+
}
namespace {
@@ -1678,6 +1688,9 @@ int Desktop::doShutdown()
if (pExecGlobals->bRestartRequested)
{
+// tdf#128523
+RemoveIconCacheDirectory();
+
// a restart is already requested, usually due to a configuration
change
// that needs a restart to get active. If this is the case, do not try
// to use SecureUserConfig to safe this still untested new
configuration
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: i18npool/source
i18npool/source/transliteration/transliterationImpl.cxx | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
New commits:
commit 153aa090db6ae6fb9809305f56b06056865c69f4
Author: Stephan Bergmann
AuthorDate: Mon Nov 18 23:05:10 2019 +0100
Commit: Stephan Bergmann
CommitDate: Tue Nov 19 07:30:28 2019 +0100
Improved loplugin:external, handling class types
...renaming type as TMList to avoid ambiguity between i18npool::TMlist and
i18npool::(anonymous namespace)::TMlist
Change-Id: I712fca9a9a7023e5a217c019195e3aa51e858f81
Reviewed-on: https://gerrit.libreoffice.org/83132
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/i18npool/source/transliteration/transliterationImpl.cxx
b/i18npool/source/transliteration/transliterationImpl.cxx
index 195f7a789643..6a1c13d2b677 100644
--- a/i18npool/source/transliteration/transliterationImpl.cxx
+++ b/i18npool/source/transliteration/transliterationImpl.cxx
@@ -48,12 +48,18 @@ namespace i18npool {
#define TmItem2( name ) \
{TransliterationModules(0), TransliterationModulesNew_##name, #name}
+namespace {
+
// Ignore Module list
-static struct TMlist {
+struct TMList {
TransliterationModulestm;
TransliterationModulesNew tmn;
const sal_Char *implName;
-} const TMlist[] = {// Modules ModulesNew
+};
+
+}
+
+static TMList const TMlist[] = {// Modules ModulesNew
TmItem1 (IGNORE_CASE),// 0. (1<<8256) (7)
TmItem1 (IGNORE_WIDTH), // 1. (1<<9512) (8)
TmItem1 (IGNORE_KANA),// 2. (1<<10 1024) (9)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - libreofficekit/qa libreofficekit/source vcl/unx
libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx |8 +-
libreofficekit/source/gtk/lokdocview.cxx| 38 +++-
vcl/unx/gtk3/gtk3gloactiongroup.cxx |9 +-
3 files changed, 35 insertions(+), 20 deletions(-)
New commits:
commit 38f4df895ebcaceb4107a42a59006420633a29b3
Author: Stephan Bergmann
AuthorDate: Mon Nov 18 21:19:13 2019 +0100
Commit: Stephan Bergmann
CommitDate: Tue Nov 19 07:30:07 2019 +0100
Improved loplugin:external, handling class types
...plus follow-up loplugin:fakebool and loplugin:consttobool findings
Change-Id: I4b4045439fc9b19c42f6915b158540d2daf4cafb
Reviewed-on: https://gerrit.libreoffice.org/83123
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/vcl/unx/gtk3/gtk3gloactiongroup.cxx
b/vcl/unx/gtk3/gtk3gloactiongroup.cxx
index 80f932ace1a1..c6d5eaf03fc5 100644
--- a/vcl/unx/gtk3/gtk3gloactiongroup.cxx
+++ b/vcl/unx/gtk3/gtk3gloactiongroup.cxx
@@ -20,20 +20,23 @@
#define G_TYPE_LO_ACTION(g_lo_action_get_type
())
#define G_LO_ACTION(inst)
(G_TYPE_CHECK_INSTANCE_CAST ((inst), \
G_TYPE_LO_ACTION,
GLOAction))
+namespace {
struct GLOAction
{
GObject parent_instance;
gintitem_id;// Menu item ID.
-gbooleansubmenu;// TRUE if action is a submenu action.
-gbooleanenabled;// TRUE if action is enabled.
+boolsubmenu;// TRUE if action is a submenu action.
+boolenabled;// TRUE if action is enabled.
GVariantType* parameter_type; // A GVariantType with the action
parameter type.
GVariantType* state_type; // A GVariantType with item state type
GVariant* state_hint; // A GVariant with state hints.
GVariant* state; // A GVariant with current item state
};
+}
+
typedef GObjectClass GLOActionClass;
#ifdef __GNUC__
@@ -60,7 +63,7 @@ static void
g_lo_action_init (GLOAction *action)
{
action->item_id = -1;
-action->submenu = FALSE;
+action->submenu = false;
action->enabled = true;
action->parameter_type = nullptr;
action->state_type = nullptr;
commit e3a3a931fe23eee9a70ffd807bc00a6ba4aad731
Author: Stephan Bergmann
AuthorDate: Mon Nov 18 21:12:02 2019 +0100
Commit: Stephan Bergmann
CommitDate: Tue Nov 19 07:29:56 2019 +0100
Improved loplugin:external, handling class types
...plus follow-up loplugin:fakebool and loplugin:consttobool findings
Change-Id: I2b19d80f7313d3d5b0e502581b39fe20147bdfcc
Reviewed-on: https://gerrit.libreoffice.org/83121
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx
b/libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx
index a527ad88f9a1..9d448f467ff2 100644
--- a/libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx
@@ -26,6 +26,8 @@
#include
#include
+namespace {
+
struct GtvApplicationWindowPrivate
{
GtkWidget* container;
@@ -34,8 +36,8 @@ struct GtvApplicationWindowPrivate
GtkWidget* scrolledwindowcontainer;
GtkWidget* lokDialog;
-gboolean toolbarBroadcast;
-gboolean partSelectorBroadcast;
+bool toolbarBroadcast;
+bool partSelectorBroadcast;
GList* m_pChildWindows;
@@ -43,6 +45,8 @@ struct GtvApplicationWindowPrivate
GtvRenderingArgs* m_pRenderingArgs;
};
+}
+
#if defined __clang__
#if __has_warning("-Wdeprecated-volatile")
#pragma clang diagnostic push
diff --git a/libreofficekit/source/gtk/lokdocview.cxx
b/libreofficekit/source/gtk/lokdocview.cxx
index bec07e862538..8dc4516d0ca5 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -47,6 +47,8 @@
/// This is expected to be locked during setView(), doSomethingElse() LOK
calls.
static std::mutex g_aLOKMutex;
+namespace {
+
/// Same as a GdkRectangle, but also tracks in which part the rectangle is.
struct ViewRectangle
{
@@ -81,11 +83,11 @@ struct LOKDocViewPrivateImpl
std::string m_aDocPath;
std::string m_aRenderingArguments;
gdouble m_nLoadProgress;
-gboolean m_bIsLoading;
-gboolean m_bInit; // initializeForRendering() has been called
-gboolean m_bCanZoomIn;
-gboolean m_bCanZoomOut;
-gboolean m_bUnipoll;
+bool m_bIsLoading;
+bool m_bInit; // initializeForRendering() has been called
+bool m_bCanZoomIn;
+bool m_bCanZoomOut;
+bool m_bUnipoll;
LibreOfficeKit* m_pOffice;
LibreOfficeKitDocument* m_pDocument;
@@ -96,7 +98,7 @@ struct LOKDocViewPrivateImpl
glong m_nDocumentWidthTwips;
glong m_nDocumentHeightTwips;
/// View
[Libreoffice-bugs] [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103341 tommy27 changed: What|Removed |Added Depends on||128659 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=128659 [Bug 128659] Cannot add AutoCorrect entries once the user/autocorr/acor_xx-XX.dat file is created -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128659] Cannot add AutoCorrect entries once the user/autocorr/acor_xx-XX.dat file is created
https://bugs.documentfoundation.org/show_bug.cgi?id=128659 tommy27 changed: What|Removed |Added CC||ba...@quipo.it Keywords||bibisectRequest, regression Severity|normal |major Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Priority|medium |high Blocks||103341 --- Comment #1 from tommy27 --- I confirm issue under Win10 x64 using LibO 6.3.3.2 which I tested under 2 different machines even with a clean user profile. as an additional note I can tell that even adding new autocorrect entries from the right click menu fails, not only from the replacement table. autocorrect works fine in 6.1.6 (I haven't tried yet any of the 6.2.x version) so it a regression. needs bibisecting. I raise priority to major since it makes autocorrect function unreliable... data entered by the user are not stored so no autocorrection of the manually entered entries take place when you type those mistakes another time. this means that autocorrect is broken in 6.3.x Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103341 [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127782] New Print dialog is too high
https://bugs.documentfoundation.org/show_bug.cgi?id=127782 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g --- Comment #24 from BogdanB --- The last print dialog is very nice and compact. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128317] numbers in foreign numerals
https://bugs.documentfoundation.org/show_bug.cgi?id=128317 itt...@yandex.com changed: What|Removed |Added Whiteboard||QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128317] numbers in foreign numerals
https://bugs.documentfoundation.org/show_bug.cgi?id=128317 itt...@yandex.com changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127977] [Sifr theme] Create good icons for Set reminder, Header, Footer and Headings level show icons in Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=127977 BogdanB changed: What|Removed |Added Status|RESOLVED|VERIFIED CC||buzea.bog...@libreoffice.or ||g --- Comment #9 from BogdanB --- Verified in Version: 6.4.0.0.beta1 Build ID: 4d7e5b0c40ed843384704eca3ce21981d4e98920 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ro-RO (ro_RO.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128692] Problems saving new edits.
https://bugs.documentfoundation.org/show_bug.cgi?id=128692 Stanislaus J. Pinasthika changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #5 from Stanislaus J. Pinasthika --- Okay, so I can change it to RESOLVED. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128317] numbers in foreign numerals
https://bugs.documentfoundation.org/show_bug.cgi?id=128317 --- Comment #1 from itt...@yandex.com --- Is there no one at all concerned by numerals in foreign language? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128316] turn off autocapitalisation for date and whatever locale
https://bugs.documentfoundation.org/show_bug.cgi?id=128316 --- Comment #12 from itt...@yandex.com --- it seems i have not explicitly precised that i was talking of the "date" field that LO will replace with "today's" or another date if set by the user with the option to set the style (DD/MM/ or DD/MM/YY ... or literal date). I think the "date" field in a spreadsheet cell is technically different. In my case it's for the one that is available in the fields list for the footer or header for example. I tried the suggested solution "file => properties => custom properties => add a property ..." This is not a solution. My request is just about removing the forced capitalisation in the "date" field when set to be displayed with a "literal" style. There is no place where people should be forced to use capital letters. This kind of things should not exist in text processing software or office tools. Therefore i personally consider it as a bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128879] PDF Export Problems in LO 6.3.3 but working in 6.2.6
https://bugs.documentfoundation.org/show_bug.cgi?id=128879 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g OS|Windows (All) |All Keywords|bibisectRequest |bibisected --- Comment #5 from BogdanB --- Bibisected with 6.3 d61a43fff034b038fe2ca3fedb844074b534 is the first bad commit commit d61a43fff034b038fe2ca3fedb844074b534 Author: Jenkins Build User Date: Thu Sep 26 02:47:46 2019 +0200 source sha:92267cdb1a45e1f40199136849feb692f7e06d0e source sha:92267cdb1a45e1f40199136849feb692f7e06d0e :04 04 31416364166b0bbfd7bce30b2c5db92a46f39c0e e6368b319137759bb893742c1e0ea178c605b67d M instdir -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sc/source
sc/source/core/data/table2.cxx | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
New commits:
commit d5036b0e2bc50c991858e85760a8580cdf08629e
Author: Noel Grandin
AuthorDate: Mon Nov 18 15:35:18 2019 +0200
Commit: Noel Grandin
CommitDate: Tue Nov 19 06:42:15 2019 +0100
crashtesting fdo78617-2.ods
as a consequence of
commit feec8e3c34e08b621098a17f1011dccd0b4f7f4c
Date: Tue Nov 12 16:00:55 2019 +0200
reduce iteration in ScViewData::GetScrPos
Change-Id: Iec539c33bd80b9ad2d2a3698d443c5cec81f8f85
Reviewed-on: https://gerrit.libreoffice.org/83093
Tested-by: Jenkins
Reviewed-by: Noel Grandin
(cherry picked from commit 00e1adec49c50f9128dd02ae721e62ae3e729ad6)
Reviewed-on: https://gerrit.libreoffice.org/83120
Tested-by: Jenkins CollaboraOffice
diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx
index e86f3d215778..c80d08602b15 100644
--- a/sc/source/core/data/table2.cxx
+++ b/sc/source/core/data/table2.cxx
@@ -3178,17 +3178,20 @@ sal_uLong ScTable::GetScaledRowHeight( SCROW nStartRow,
SCROW nEndRow, double fS
// round-down a single height value, multiply resulting
(pixel) values
const sal_uLong nOneHeight = static_cast(
aData.mnValue * fScale );
-SCROW nRowsInSegment = nSegmentEnd + 1 - nRow;
-if (pnMaxHeight)
+// sometimes scaling results in zero height
+if (nOneHeight)
{
-nRowsInSegment = std::min(nRowsInSegment,
static_cast(*pnMaxHeight / nOneHeight + 1));
-nHeight += nOneHeight * nRowsInSegment;
-if (nHeight > *pnMaxHeight)
-return nHeight;
+SCROW nRowsInSegment = nSegmentEnd + 1 - nRow;
+if (pnMaxHeight)
+{
+nRowsInSegment = std::min(nRowsInSegment,
static_cast(*pnMaxHeight / nOneHeight + 1));
+nHeight += nOneHeight * nRowsInSegment;
+if (nHeight > *pnMaxHeight)
+return nHeight;
+}
+else
+nHeight += nOneHeight * nRowsInSegment;
}
-else
-nHeight += nOneHeight * nRowsInSegment;
-
nRow = nSegmentEnd + 1;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128886] New: LibreOffice Calc stops updating link to external after about 40 minutes.
https://bugs.documentfoundation.org/show_bug.cgi?id=128886 Bug ID: 128886 Summary: LibreOffice Calc stops updating link to external after about 40 minutes. Product: LibreOffice Version: 6.1.5.2 release Hardware: All OS: other Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: craig.san...@comcast.net Description: Working on a Raspberry Pi with LibreOffice 6.1.5.2 I set up a link from one calc sheet (link to external) to another calc sheet in a different file. Set to update every 5 seconds. This works fine for a while, but if I leave the spreadsheet unattended for 60 minutes the link no longer updates. Steps to Reproduce: 1.Open a fresh calc sheet enter 1 in "A1" and name the cell and save the sheet. 2.Open a second sheet and in cell "A1" link to the named cell in 1st sheet, with 5 second update. 3.Test link. (It will work fine.) Walk away for 60 minutes. Retest. It will fail. Actual Results: It works for a while and then left unattended it fails. Expected Results: I expect it to work as long as the file is open and running. Reproducible: Always User Profile Reset: No Additional Info: This failure occurs on LibreOffice 6.1.5.2 running on a Raspberry Pi. Failed on both RPi 2 and RPi 4. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128884] frame line where they shouldn't be
https://bugs.documentfoundation.org/show_bug.cgi?id=128884 Katrin changed: What|Removed |Added Severity|trivial |enhancement -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128885] New: search and replace with makros
https://bugs.documentfoundation.org/show_bug.cgi?id=128885 Bug ID: 128885 Summary: search and replace with makros Product: LibreOffice Version: 6.2.6.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: katmel...@googlemail.com Description: I realy would be very relieved, if I can write makros for searching and replacing in long texts. In one case, I have to replace in my texts 54 diffrent passages, two times for all letteres of the german alphabet (a-z, ä, ü and ö, except sharp s). Now I have to search and replace one after the other. It would be a big relief to me just start a Makro and not to search all the passages one by one 54 times! (for example: a1 will be replaced by A1, a2 - A1, b1 - B1, b2 - B2, and this for 27 letters!) Steps to Reproduce: 1. the command "search and replace" is not supported in makros 2. 3. Actual Results: I have to search and replace one by one Expected Results: I make a makro with all I need, just click it and I have not the worry anymore, I could missout something Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: de Module: TextDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: no -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124596] found syllabification error in German
https://bugs.documentfoundation.org/show_bug.cgi?id=124596 --- Comment #2 from Katrin --- I prefer da-rum. Isn't there a way, if both is right, so set the preference? I'm an author of novels, a creative one. I'm not a pupil anymore, I don't have to say "YEAH!" to all rules. In german we call it "Kreative Freiheit", creative freedom. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125022] found syllabification error in German
https://bugs.documentfoundation.org/show_bug.cgi?id=125022 --- Comment #2 from Katrin --- @Buovjaga: Don't understand what you mean. Under Language settings (Spracheinstellungen) I just have Sprachen (languages) / Linguistik (linguistic) and Englische satzkontrolle (sometink like english sentence controle). And there's nowhere an option to report someting or set special rules. Maybe what you mean is not integrated in the german Version or for the german language. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128884] New: frame line where they shouldn't be
https://bugs.documentfoundation.org/show_bug.cgi?id=128884 Bug ID: 128884 Summary: frame line where they shouldn't be Product: LibreOffice Version: 6.2.8.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: trivial Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: katmel...@googlemail.com Description: I made lines in colour to markup text for correction. I made it by mark a paragraph and set an upper line above it by using the frame option in context menu under paragraph. Then I did it a few paragraphs below with the under-line, too. Now, after open the document again the next day, I have two lines more, I didn't made. They are at the beginning of the page unter the first line and at the end of the last page before the second line. It disturbed my concentration. Is there maybe a better way to mark up longer test by lines? Or could I deactivate the new lines somehow? (I use a german version. Sorry if I use the wrong translation on settings) Steps to Reproduce: 1. write long text (A few pages long), mark up a part of it 2. select in context menu paragraph, select rider Border and select just the upper line. 3. do it a few paragraphs below and select just the down line. 4. Close the text and open it again, maybe fter a cold start of Libre office. Actual Results: there lines I don't want to have them Expected Results: there should be just the lines I made by myself Reproducible: Didn't try User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: de Module: TextDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: no -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127482] Draw should remember the last file format exported each time in a given session
https://bugs.documentfoundation.org/show_bug.cgi?id=127482 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128829] a rotated table fails to retain the width, which then becomes length.
https://bugs.documentfoundation.org/show_bug.cgi?id=128829 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128829] a rotated table fails to retain the width, which then becomes length.
https://bugs.documentfoundation.org/show_bug.cgi?id=128829 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128876] Crash in: mergedlo.dll FILESAVE
https://bugs.documentfoundation.org/show_bug.cgi?id=128876 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128590] [LOCALHELP] Add Auto-redact help page
https://bugs.documentfoundation.org/show_bug.cgi?id=128590 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128587] Set scalable fonts for column and row references
https://bugs.documentfoundation.org/show_bug.cgi?id=128587 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126139] Outlining Text and a Color Fill function
https://bugs.documentfoundation.org/show_bug.cgi?id=126139 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 126139] Outlining Text and a Color Fill function
https://bugs.documentfoundation.org/show_bug.cgi?id=126139 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 126018] Libreoffice Draw Large poster split printing adds adhesive line
https://bugs.documentfoundation.org/show_bug.cgi?id=126018 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128827] 90 degree rotation of a table with a 1 cell text fails to rotate all characters.
https://bugs.documentfoundation.org/show_bug.cgi?id=128827 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128876] Crash in: mergedlo.dll FILESAVE
https://bugs.documentfoundation.org/show_bug.cgi?id=128876 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 127482] Draw should remember the last file format exported each time in a given session
https://bugs.documentfoundation.org/show_bug.cgi?id=127482 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 128871] Crash when viewing ppsx files
https://bugs.documentfoundation.org/show_bug.cgi?id=128871 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 126018] Libreoffice Draw Large poster split printing adds adhesive line
https://bugs.documentfoundation.org/show_bug.cgi?id=126018 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 128827] 90 degree rotation of a table with a 1 cell text fails to rotate all characters.
https://bugs.documentfoundation.org/show_bug.cgi?id=128827 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125434] Windows Installer doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=125434 --- Comment #4 from QA Administrators --- Dear Kenzo, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113513] Plot xy scatter - x error bar endings do not scale when width is increased
https://bugs.documentfoundation.org/show_bug.cgi?id=113513 --- Comment #8 from QA Administrators --- Dear uno_wos, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121470] After pressing the "Reset Properties" button - when pressing the "OK" button the time on the "Created" field is being reset again (on Properties - General)
https://bugs.documentfoundation.org/show_bug.cgi?id=121470 --- Comment #2 from QA Administrators --- Dear Liad Skiva, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125442] Calc - change the Character Color to green and change it back to black the next bottom box will write often in green
https://bugs.documentfoundation.org/show_bug.cgi?id=125442 --- Comment #2 from QA Administrators --- Dear weakbit, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121254] You cannot access the Floating Frame interface from a macro.
https://bugs.documentfoundation.org/show_bug.cgi?id=121254 --- Comment #3 from QA Administrators --- Dear Kadet, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121382] Very Long Save Time Bug has returned
https://bugs.documentfoundation.org/show_bug.cgi?id=121382 --- Comment #6 from QA Administrators --- Dear Kevin, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128791] Libre doesn't install with latest 11-2019 Windows update
https://bugs.documentfoundation.org/show_bug.cgi?id=128791 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
