[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - officecfg/registry
officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e9b1955b0d8540968a3796166ddf3694335d Author: Takeshi Abe AuthorDate: Thu Nov 21 19:00:20 2019 +0900 Commit: Xisco Faulí CommitDate: Sat Nov 23 08:57:36 2019 +0100 tdf#128892 Give menu "Rename Sheet" an alternative mnemonic H ... to avoid the duplicate R for "Insert Rows". Change-Id: Ie2e0faf566ba5f85e4b2a72c289a4320e580f7f9 Reviewed-on: https://gerrit.libreoffice.org/83368 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos (cherry picked from commit 017c6150e94a3a621f6f3e789fe72cac90a7bf11) Reviewed-on: https://gerrit.libreoffice.org/83510 diff --git a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu index 5fc352c50f8c..099c1f249d21 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu @@ -1928,7 +1928,7 @@ - ~Rename Sheet... + Rename S~heet... 1 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128960] Editing: Add a more direct way to clear character styles
https://bugs.documentfoundation.org/show_bug.cgi?id=128960 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||8973 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128973] New: Create a per-document "Paragraph style used by default" setting
https://bugs.documentfoundation.org/show_bug.cgi?id=128973 Bug ID: 128973 Summary: Create a per-document "Paragraph style used by default" setting Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Keywords: needsUXEval Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikekagan...@hotmail.com Using styles properly in Writer, among other things, means not using Default paragraph style directly (which is almost never a good idea, because Default style is the root of the inheritance hierarchy, and so fine-tuning it to satisfy "main text body" requirements would propagate those changes on all styles in the hierarchy which don't explicitly override them). But currently not only shipped templates start with the Default style, but also: 1. A document created without any templates (= from pre-compiled defaults) starts with the Default paragraph style (despite having normal set of styles); 2. Using "Clear formatting" from "Set Paragraph Style" drop-down in the toolbar resets to Default style; 3. Using Alt+Enter to leave the last cell of a table makes the following paragraph use the Default style; ... there are more. The proposal is to add a configurable per-document "Use this style by default", which would make all cases where we reset to Default now, to reset to that chosen style instead. In the documents created without a template, it should be the "Text Body" style. The style marked that way should be marked (e.g., by a green checkmark) in the styles list; is should be made "used" in the document (and not deletable). It should not be a style's property (or else it would introduce uncertainties when copying such styles from one document to another with own defaults, and provoke bugs with multiple defaults), but the document's property. This needs no changes to the ODF (because it only requires a setting that modifies controls behaviour, not document/styles behaviour; it should be in under "ooo:configuration-settings"). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128960] Editing: Add a more direct way to clear character styles
https://bugs.documentfoundation.org/show_bug.cgi?id=128960 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||8973 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 125359] Cannot display multiple infobars
https://bugs.documentfoundation.org/show_bug.cgi?id=125359 Commit Notification changed: What|Removed |Added Whiteboard|target:6.5.0|target:6.5.0 target:6.4.0.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125359] Cannot display multiple infobars
https://bugs.documentfoundation.org/show_bug.cgi?id=125359 --- Comment #6 from Commit Notification --- Samuel Mehrbrodt committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/e275ef9db490a4dcb7d8bfbe8f3a06c7ff2ee1b1 tdf#125359 Don't overlap multiple infobars It will be available in 6.4.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - 2 commits - sfx2/source
sfx2/source/dialog/infobar.cxx | 33 +++--
sfx2/source/view/sfxbasecontroller.cxx |6 ++
2 files changed, 13 insertions(+), 26 deletions(-)
New commits:
commit e275ef9db490a4dcb7d8bfbe8f3a06c7ff2ee1b1
Author: Samuel Mehrbrodt
AuthorDate: Mon Nov 18 15:25:11 2019 +0100
Commit: Xisco Faulí
CommitDate: Sat Nov 23 08:51:35 2019 +0100
tdf#125359 Don't overlap multiple infobars
Change-Id: Ieda7dce84daec2e94501c69584f3df21d63d60bb
Reviewed-on: https://gerrit.libreoffice.org/83101
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
(cherry picked from commit 1562e094fc6a57cd9738109d5202497bcc043d80)
Reviewed-on: https://gerrit.libreoffice.org/83505
Reviewed-by: Xisco Faulí
diff --git a/sfx2/source/dialog/infobar.cxx b/sfx2/source/dialog/infobar.cxx
index ea99fc6b67d3..8dd52ed32a92 100644
--- a/sfx2/source/dialog/infobar.cxx
+++ b/sfx2/source/dialog/infobar.cxx
@@ -339,7 +339,7 @@ void SfxInfoBarWindow::Resize()
m_pSecondaryMessage->SetPosSizePixel(aSecondaryMessagePosition,
aSecondaryTextSize);
m_pImage->SetPosSizePixel(Point(4, 4), Size(32 * fScaleFactor, 32 *
fScaleFactor));
-SetPosSizePixel(Point(0, 0), Size(nWidth, INFO_BAR_BASE_HEIGHT *
fScaleFactor + aExtraHeight * fScaleFactor));
+SetPosSizePixel(GetPosPixel(), Size(nWidth, INFO_BAR_BASE_HEIGHT *
fScaleFactor + aExtraHeight * fScaleFactor));
}
void SfxInfoBarWindow::Update( const OUString& sPrimaryMessage, const
OUString& sSecondaryMessage, InfobarType eType )
@@ -387,8 +387,6 @@ SfxInfoBarContainerWindow::appendInfoBar(const OUString&
sId, const OUString& sP
const OUString& sSecondaryMessage,
InfobarType ibType,
WinBits nMessageStyle, bool
bShowCloseButton)
{
-Size aSize = GetSizePixel();
-
auto pInfoBar = VclPtr::Create(this, sId,
sPrimaryMessage, sSecondaryMessage,
ibType, nMessageStyle,
bShowCloseButton);
@@ -398,14 +396,9 @@ SfxInfoBarContainerWindow::appendInfoBar(const OUString&
sId, const OUString& sP
GetInfoBarColors(ibType,aBackgroundColor,aForegroundColor,aMessageColor);
pInfoBar->m_aBackgroundColor = aBackgroundColor;
pInfoBar->m_aForegroundColor = aForegroundColor;
-
-pInfoBar->SetPosPixel(Point(0, aSize.getHeight()));
-pInfoBar->Show();
m_pInfoBars.push_back(pInfoBar);
-long nHeight = pInfoBar->GetSizePixel().getHeight();
-aSize.setHeight(aSize.getHeight() + nHeight);
-SetSizePixel(aSize);
+Resize();
return pInfoBar;
}
@@ -434,24 +427,13 @@ void
SfxInfoBarContainerWindow::removeInfoBar(VclPtr const & p
m_pInfoBars.erase(it);
}
-// Resize
-long nY = 0;
-for (auto const& infoBar : m_pInfoBars)
-{
-infoBar->SetPosPixel(Point(0, nY));
-nY += infoBar->GetSizePixel().getHeight();
-}
-
-Size aSize = GetSizePixel();
-aSize.setHeight(nY);
-SetSizePixel(aSize);
+Resize();
m_pChildWin->Update();
}
void SfxInfoBarContainerWindow::Resize()
{
-// Only need to change the width of the infobars
long nWidth = GetSizePixel().getWidth();
long nHeight = 0;
@@ -459,14 +441,13 @@ void SfxInfoBarContainerWindow::Resize()
{
Size aSize = rxInfoBar->GetSizePixel();
aSize.setWidth(nWidth);
-rxInfoBar->SetSizePixel(aSize);
+Point aPos(0, nHeight);
+rxInfoBar->SetPosSizePixel(aPos, aSize);
rxInfoBar->Resize();
+rxInfoBar->Show();
// Stretch to fit the infobar(s)
-if (aSize.getHeight() > nHeight)
-{
-nHeight = aSize.getHeight();
-}
+nHeight += aSize.getHeight();
}
SetSizePixel(Size(nWidth, nHeight));
commit 5d7be7fdbd1f94b2056f8b4adc7722addb9e7fc9
Author: Samuel Mehrbrodt
AuthorDate: Wed Nov 20 07:49:23 2019 +0100
Commit: Xisco Faulí
CommitDate: Sat Nov 23 08:51:13 2019 +0100
Add SolarMutexGuard to infobar api methods
Change-Id: If7fab7df7566b1db770437090115b064b98257c6
Reviewed-on: https://gerrit.libreoffice.org/83255
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
(cherry picked from commit 9c9c047f42637c274b246fb4020ed0df4ee39ded)
Reviewed-on: https://gerrit.libreoffice.org/83506
Reviewed-by: Xisco Faulí
diff --git a/sfx2/source/view/sfxbasecontroller.cxx
b/sfx2/source/view/sfxbasecontroller.cxx
index f4cf6768a8b3..22ec268c9518 100644
--- a/sfx2/source/view/sfxbasecontroller.cxx
+++ b/sfx2/source/view/sfxbasecontroller.cxx
@@ -1477,6 +1477,8 @@ void SAL_CALL SfxBaseController::appendInfobar(const
OUString& sId, const OUStri
const Sequence&
actionButtons,
sal_Bool bShowCloseButton)
{
+SolarMutexGuard aGuard;
+
if (aInfobarType < static_cast(InfobarType::INFO)
[Libreoffice-commits] core.git: offapi/com
offapi/com/sun/star/frame/InfobarType.idl |2 +-
offapi/com/sun/star/frame/XInfobarProvider.idl |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit a96fd458a41eb0abcb6b02e0039189c877d4a502
Author: Xisco Fauli
AuthorDate: Fri Nov 22 16:49:01 2019 +0100
Commit: Xisco Faulí
CommitDate: Sat Nov 23 08:50:41 2019 +0100
tdf#97926: Update @since tags
Since it was backported to libreoffice-6-4
Change-Id: I832c252678b132c743f868688abbe702eb1293b2
Reviewed-on: https://gerrit.libreoffice.org/83512
Reviewed-by: Adolfo Jayme Barrientos
Tested-by: Jenkins
diff --git a/offapi/com/sun/star/frame/InfobarType.idl
b/offapi/com/sun/star/frame/InfobarType.idl
index 6c410d654b2a..4b579987f1d5 100644
--- a/offapi/com/sun/star/frame/InfobarType.idl
+++ b/offapi/com/sun/star/frame/InfobarType.idl
@@ -14,7 +14,7 @@ module com { module sun { module star { module frame {
/** Infobar types.
-@since LibreOffice 6.5
+@since LibreOffice 6.4
*/
constants InfobarType
{
diff --git a/offapi/com/sun/star/frame/XInfobarProvider.idl
b/offapi/com/sun/star/frame/XInfobarProvider.idl
index 68278c50ab4e..1fbaa4657188 100644
--- a/offapi/com/sun/star/frame/XInfobarProvider.idl
+++ b/offapi/com/sun/star/frame/XInfobarProvider.idl
@@ -20,7 +20,7 @@ module com { module sun { module star { module frame {
This interface can be obtained via com::sun::star::frame::XController.
-@since LibreOffice 6.5
+@since LibreOffice 6.4
*/
interface XInfobarProvider: uno::XInterface
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - sc/qa
sc/qa/unit/data/xlsx/shared-formula/refupdate.xlsx |binary
sc/qa/unit/filters-test.cxx| 31 +
2 files changed, 31 insertions(+)
New commits:
commit a297c6a8c71a8cb07ede3b2305760a1d41b9fb6a
Author: Dennis Francis
AuthorDate: Thu Nov 21 14:17:22 2019 +0530
Commit: Xisco Faulí
CommitDate: Sat Nov 23 08:50:11 2019 +0100
tdf#128894: unit test for the bugfix
Change-Id: Ic6d3910f12409f5af541c887760caefcb78b30f9
Reviewed-on: https://gerrit.libreoffice.org/83362
Tested-by: Jenkins
Reviewed-by: Dennis Francis
(cherry picked from commit 626d1527267ab856e516f2424173104f781b8f09)
Reviewed-on: https://gerrit.libreoffice.org/83514
Reviewed-by: Xisco Faulí
diff --git a/sc/qa/unit/data/xlsx/shared-formula/refupdate.xlsx
b/sc/qa/unit/data/xlsx/shared-formula/refupdate.xlsx
new file mode 100644
index ..fa386d3a4384
Binary files /dev/null and b/sc/qa/unit/data/xlsx/shared-formula/refupdate.xlsx
differ
diff --git a/sc/qa/unit/filters-test.cxx b/sc/qa/unit/filters-test.cxx
index d747edcbd7a2..4551ee4d9fb7 100644
--- a/sc/qa/unit/filters-test.cxx
+++ b/sc/qa/unit/filters-test.cxx
@@ -68,6 +68,7 @@ public:
void testContentGnumeric();
void testSharedFormulaXLS();
void testSharedFormulaXLSX();
+void testSharedFormulaRefUpdateXLSX();
void testSheetNamesXLSX();
void testLegacyCellAnchoredRotatedShape();
void testEnhancedProtectionXLS();
@@ -92,6 +93,7 @@ public:
CPPUNIT_TEST(testContentGnumeric);
CPPUNIT_TEST(testSharedFormulaXLS);
CPPUNIT_TEST(testSharedFormulaXLSX);
+CPPUNIT_TEST(testSharedFormulaRefUpdateXLSX);
CPPUNIT_TEST(testSheetNamesXLSX);
CPPUNIT_TEST(testLegacyCellAnchoredRotatedShape);
CPPUNIT_TEST(testEnhancedProtectionXLS);
@@ -419,6 +421,35 @@ void ScFiltersTest::testSharedFormulaXLSX()
xDocSh->DoClose();
}
+void ScFiltersTest::testSharedFormulaRefUpdateXLSX()
+{
+ScDocShellRef xDocSh = loadDoc("shared-formula/refupdate.", FORMAT_XLSX);
+ScDocument& rDoc = xDocSh->GetDocument();
+sc::AutoCalcSwitch aACSwitch(rDoc, true); // turn auto calc on.
+rDoc.DeleteRow(ScRange(0, 4, 0, rDoc.MaxCol(), 4, 0)); // delete row 5.
+
+struct TestCase {
+ScAddress aPos;
+const char* pExpectedFormula;
+const char* pErrorMsg;
+};
+
+TestCase aCases[4] = {
+{ ScAddress(1, 0, 0), "B29+1", "Wrong formula in B1" },
+{ ScAddress(2, 0, 0), "C29+1", "Wrong formula in C1" },
+{ ScAddress(3, 0, 0), "D29+1", "Wrong formula in D1" },
+{ ScAddress(4, 0, 0), "E29+1", "Wrong formula in E1" },
+};
+
+for (size_t nIdx = 0; nIdx < 4; ++nIdx)
+{
+TestCase& rCase = aCases[nIdx];
+ASSERT_FORMULA_EQUAL(rDoc, rCase.aPos, rCase.pExpectedFormula,
rCase.pErrorMsg);
+}
+
+xDocSh->DoClose();
+}
+
void ScFiltersTest::testSheetNamesXLSX()
{
ScDocShellRef xDocSh = loadDoc("sheet-names.", FORMAT_XLSX);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sc/qa
sc/qa/unit/data/xlsx/shared-formula/refupdate.xlsx |binary
sc/qa/unit/filters-test.cxx| 31 +
2 files changed, 31 insertions(+)
New commits:
commit 88f0de823bb9bd186f7d9ef69041b64969531056
Author: Dennis Francis
AuthorDate: Thu Nov 21 14:17:22 2019 +0530
Commit: Xisco Faulí
CommitDate: Sat Nov 23 08:49:46 2019 +0100
tdf#128894: unit test for the bugfix
Reviewed-on: https://gerrit.libreoffice.org/83362
Tested-by: Jenkins
Reviewed-by: Dennis Francis
(cherry picked from commit 626d1527267ab856e516f2424173104f781b8f09)
Change-Id: Ic6d3910f12409f5af541c887760caefcb78b30f9
Reviewed-on: https://gerrit.libreoffice.org/83515
Tested-by: Jenkins
Reviewed-by: Xisco Faulí
diff --git a/sc/qa/unit/data/xlsx/shared-formula/refupdate.xlsx
b/sc/qa/unit/data/xlsx/shared-formula/refupdate.xlsx
new file mode 100644
index ..fa386d3a4384
Binary files /dev/null and b/sc/qa/unit/data/xlsx/shared-formula/refupdate.xlsx
differ
diff --git a/sc/qa/unit/filters-test.cxx b/sc/qa/unit/filters-test.cxx
index d747edcbd7a2..4952f9a3547a 100644
--- a/sc/qa/unit/filters-test.cxx
+++ b/sc/qa/unit/filters-test.cxx
@@ -68,6 +68,7 @@ public:
void testContentGnumeric();
void testSharedFormulaXLS();
void testSharedFormulaXLSX();
+void testSharedFormulaRefUpdateXLSX();
void testSheetNamesXLSX();
void testLegacyCellAnchoredRotatedShape();
void testEnhancedProtectionXLS();
@@ -92,6 +93,7 @@ public:
CPPUNIT_TEST(testContentGnumeric);
CPPUNIT_TEST(testSharedFormulaXLS);
CPPUNIT_TEST(testSharedFormulaXLSX);
+CPPUNIT_TEST(testSharedFormulaRefUpdateXLSX);
CPPUNIT_TEST(testSheetNamesXLSX);
CPPUNIT_TEST(testLegacyCellAnchoredRotatedShape);
CPPUNIT_TEST(testEnhancedProtectionXLS);
@@ -419,6 +421,35 @@ void ScFiltersTest::testSharedFormulaXLSX()
xDocSh->DoClose();
}
+void ScFiltersTest::testSharedFormulaRefUpdateXLSX()
+{
+ScDocShellRef xDocSh = loadDoc("shared-formula/refupdate.", FORMAT_XLSX);
+ScDocument& rDoc = xDocSh->GetDocument();
+sc::AutoCalcSwitch aACSwitch(rDoc, true); // turn auto calc on.
+rDoc.DeleteRow(ScRange(0, 4, 0, MAXCOL, 4, 0)); // delete row 5.
+
+struct TestCase {
+ScAddress aPos;
+const char* pExpectedFormula;
+const char* pErrorMsg;
+};
+
+TestCase aCases[4] = {
+{ ScAddress(1, 0, 0), "B29+1", "Wrong formula in B1" },
+{ ScAddress(2, 0, 0), "C29+1", "Wrong formula in C1" },
+{ ScAddress(3, 0, 0), "D29+1", "Wrong formula in D1" },
+{ ScAddress(4, 0, 0), "E29+1", "Wrong formula in E1" },
+};
+
+for (size_t nIdx = 0; nIdx < 4; ++nIdx)
+{
+TestCase& rCase = aCases[nIdx];
+ASSERT_FORMULA_EQUAL(rDoc, rCase.aPos, rCase.pExpectedFormula,
rCase.pErrorMsg);
+}
+
+xDocSh->DoClose();
+}
+
void ScFiltersTest::testSheetNamesXLSX()
{
ScDocShellRef xDocSh = loadDoc("sheet-names.", FORMAT_XLSX);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128960] Editing: Add a more direct way to clear character styles
https://bugs.documentfoundation.org/show_bug.cgi?id=128960
--- Comment #6 from Mike Kaganski ---
Even without the "difficulty" and "distrust" feelings caused by unwanted
large-scale changes editing the Default style, the obvious consequence of this
in user learning is "understanding" that all styles should be "disconnected"
from the Default style (user would need to re-define all the properties in
inheritance tree leafs), thus making the inheritance concept less useful and
more of a hassle ("Why is everything inherited from Default? It makes things so
much harder!"). The very first encounter with the style inheritance concept,
instead of giving a useful and handy tool to user, becomes "meet this useless
and awkward thing that stays on your way" moment.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128960] Editing: Add a more direct way to clear character styles
https://bugs.documentfoundation.org/show_bug.cgi?id=128960
--- Comment #6 from Mike Kaganski ---
Even without the "difficulty" and "distrust" feelings caused by unwanted
large-scale changes editing the Default style, the obvious consequence of this
in user learning is "understanding" that all styles should be "disconnected"
from the Default style (user would need to re-define all the properties in
inheritance tree leafs), thus making the inheritance concept less useful and
more of a hassle ("Why is everything inherited from Default? It makes things so
much harder!"). The very first encounter with the style inheritance concept,
instead of giving a useful and handy tool to user, becomes "meet this useless
and awkward thing that stays on your way" moment.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 128779] Create some APIs for QR Code Generator in LibreOffice BASIC
https://bugs.documentfoundation.org/show_bug.cgi?id=128779 Volga changed: What|Removed |Added Summary|Add some API for QR Code|Create some APIs for QR |Generator in LibreOffice|Code Generator in |BASIC |LibreOffice BASIC -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128960] Editing: Add a more direct way to clear character styles
https://bugs.documentfoundation.org/show_bug.cgi?id=128960 --- Comment #5 from Mike Kaganski --- At risk of being off-topic here (since the request was about character styles(!)), I have to describe my PoV. While the imaginary "Default character style" (internally = don't use any character style, and use what is defined in paragraph style) is perfectly reasonable in any sense (and would be most used in ~any stylistically consistent document), Default paragraph style (an actual style, which might - and often should - be modified - consciously) is a *root* of most pre-defined styles, and thus its direct use is wrong from the proper styles use PoV. Of course, using it is not wrong from the programmatic PoV, but its default use in templates is just an unfortunate implementation detail that needs fixing. So making means to directly use it even more prominent than now is a bad thing. Specifically, using "Default paragraph style" in documents, and then starting use styles, would mean that a novice user has main text in that "Default style", and also applies, say, Heading N; also using headers/footers and tables automatically uses relevant styles in those elements. And when user then wants to edit the main style (Default!), this will propagate inherited settings to all the styles right and left - which might be (and often is) not what user needs. The inheritance levels are there for a reason: e.g., if user wants font face to be consistent across all used styles, user sets that in the lowest possible inheritance level; if user needs some paragraphs have indents or spacings, that wouldn't make sense to do at lowest level. Forcing users to start with base-of-everything Default style provokes each style edit to have too widescale (potentially destructive) consequences. We have too much of that Default paragraph style usage in our controls/templates: being the default in the templates; being set when e.g. Alt+Enter'ing out of a table; resetting to it when using the "Clear formatting" item in style list in toolbar... please don't create another prominent way to promote logically inconsistent workflow! It goes against the overall architecture of LibreOffice being built around using styles; and it makes learning using styles much more difficult for beginners (who try simple things like editing the used styles, and suddenly see unwanted results all over the document, which would cause distrust in the tool). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128960] Editing: Add a more direct way to clear character styles
https://bugs.documentfoundation.org/show_bug.cgi?id=128960 --- Comment #5 from Mike Kaganski --- At risk of being off-topic here (since the request was about character styles(!)), I have to describe my PoV. While the imaginary "Default character style" (internally = don't use any character style, and use what is defined in paragraph style) is perfectly reasonable in any sense (and would be most used in ~any stylistically consistent document), Default paragraph style (an actual style, which might - and often should - be modified - consciously) is a *root* of most pre-defined styles, and thus its direct use is wrong from the proper styles use PoV. Of course, using it is not wrong from the programmatic PoV, but its default use in templates is just an unfortunate implementation detail that needs fixing. So making means to directly use it even more prominent than now is a bad thing. Specifically, using "Default paragraph style" in documents, and then starting use styles, would mean that a novice user has main text in that "Default style", and also applies, say, Heading N; also using headers/footers and tables automatically uses relevant styles in those elements. And when user then wants to edit the main style (Default!), this will propagate inherited settings to all the styles right and left - which might be (and often is) not what user needs. The inheritance levels are there for a reason: e.g., if user wants font face to be consistent across all used styles, user sets that in the lowest possible inheritance level; if user needs some paragraphs have indents or spacings, that wouldn't make sense to do at lowest level. Forcing users to start with base-of-everything Default style provokes each style edit to have too widescale (potentially destructive) consequences. We have too much of that Default paragraph style usage in our controls/templates: being the default in the templates; being set when e.g. Alt+Enter'ing out of a table; resetting to it when using the "Clear formatting" item in style list in toolbar... please don't create another prominent way to promote logically inconsistent workflow! It goes against the overall architecture of LibreOffice being built around using styles; and it makes learning using styles much more difficult for beginners (who try simple things like editing the used styles, and suddenly see unwanted results all over the document, which would cause distrust in the tool). -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 127922] 'Droid Sans Thai' font shows numeric characters incorrectly.
https://bugs.documentfoundation.org/show_bug.cgi?id=127922 Ming Hua changed: What|Removed |Added CC||ming.v@qq.com --- Comment #12 from Ming Hua --- As the reporter of bug 126248, I was looking into this bug to see if they are related, but I have no experience in Thai or Thai fonts. After downloading Droid Sans Thai font from Internet (TTF format, 35584 bytes), I tried to preview it on Windows, and noticed that it doesn't show the same numeric characters as Nukool's "correct" screenshot. @Nukool: Would you please clarify where is your Droid Sans Thai font from? (Fedora package?) And can you attach the font or provide a download link if possible? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101100] Impress doesn't display properly some PPTX binary equations created with Microsoft Equation, image stretched (OK if resaved in MSO)
https://bugs.documentfoundation.org/show_bug.cgi?id=101100 --- Comment #20 from Volga --- Reproduced again with: 版本: 6.5.0.0.alpha0+ (x64) Build ID: 32dcf3f0fdafcf44457842a8aa4f54d30d856ca9 CPU 线程: 4; 操作系统: Windows 10.0 Build 18362; UI 渲染: 默认; VCL: win; 区域语言: zh-CN (zh_CN); UI 语言: zh-CN Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1455968:(UNCAUGHT_EXCEPT)
/canvas/workben/canvasdemo.cxx: 616 in ::DemoApp::Main()()
/canvas/workben/canvasdemo.cxx: 616 in ::DemoApp::Main()()
*** CID 1455968:(UNCAUGHT_EXCEPT)
/canvas/workben/canvasdemo.cxx: 616 in ::DemoApp::Main()()
610 void Init() override;
611 void DeInit() override;
612 };
613
614 }
615
>>> CID 1455968:(UNCAUGHT_EXCEPT)
>>> In function "::DemoApp::Main()" an exception of type
>>> "com::sun::star::uno::RuntimeException" is thrown and never caught.
616 int DemoApp::Main()
617 {
618 bool bHelp = false;
619
620 for( unsigned int i = 0; i < GetCommandLineParamCount(); i++ )
621 {
/canvas/workben/canvasdemo.cxx: 616 in ::DemoApp::Main()()
610 void Init() override;
611 void DeInit() override;
612 };
613
614 }
615
>>> CID 1455968:(UNCAUGHT_EXCEPT)
>>> In function "::DemoApp::Main()" an exception of type
>>> "com::sun::star::uno::RuntimeException" is thrown and never caught.
616 int DemoApp::Main()
617 {
618 bool bHelp = false;
619
620 for( unsigned int i = 0; i < GetCommandLineParamCount(); i++ )
621 {
To view the defects in Coverity Scan visit,
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB73RtgzoPcQtNNP5dkHLuV1E-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyw-2FarYZgYbx3ZoJZgLEuwIqrWh-2BnV9zk15ohhFOBNFilz75HEatn5GBCfMku9L00PjVPfauqb0G4sdclHhZVRR7gzsyyx5-2Bl3Gl2eEaAa0c7nzSzC1x8jWbzVahhxG8FO8tdRAjAqFHfX688JZx5BYtY-2B7IYc8F6b-2FT8GRQtzKkg-3D
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-ux-advise] [Bug 128960] Editing: Add a more direct way to clear character styles
https://bugs.documentfoundation.org/show_bug.cgi?id=128960 --- Comment #4 from V Stuart Foote --- (In reply to Mike Kaganski from comment #3) > Please don't extend this to paragraph styles. Doing that would emphasize > usage of Default paragraph style - which is bad. Would it? Not so sure... For most users now--majority of their documents are already going to be in default style(s) as that is what the document type templates open with. While here, goal of having the controls prominent is to get the document content back to a known state--either selecting a word, a text run, a full paragraph, or the full document and resetting its style. Seems the efficient work flow is to first set the selection back to the template defaults for paragraph and character styles (or to the default style(s) as modified in current document). Making it ready to apply new style(s), in a second step if other than defaults is desired. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 128960] Editing: Add a more direct way to clear character styles
https://bugs.documentfoundation.org/show_bug.cgi?id=128960 --- Comment #4 from V Stuart Foote --- (In reply to Mike Kaganski from comment #3) > Please don't extend this to paragraph styles. Doing that would emphasize > usage of Default paragraph style - which is bad. Would it? Not so sure... For most users now--majority of their documents are already going to be in default style(s) as that is what the document type templates open with. While here, goal of having the controls prominent is to get the document content back to a known state--either selecting a word, a text run, a full paragraph, or the full document and resetting its style. Seems the efficient work flow is to first set the selection back to the template defaults for paragraph and character styles (or to the default style(s) as modified in current document). Making it ready to apply new style(s), in a second step if other than defaults is desired. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128956] Switching between two versions of LibreOffice resets user profile
https://bugs.documentfoundation.org/show_bug.cgi?id=128956 --- Comment #4 from V Stuart Foote --- (In reply to Alex Thurgood from comment #3) > 1) The change in behavior is pretty recent, it has worked fine up til now, > so hardly an "old" way of parallel installing. > Sorry, I was not clear on that, was referring to the methods in the Wiki for 'installing in parallel'. And in fact, both the 'new' macOS method of a helper script setting a PROFILE_DIR environment variable; or the 'old' method of manual edit of bootstraprc and setting the internal 'UserInstallation' variable to internal $ORIGIN path work with a unique profile for each LibreOffice installation. Either method is intended to allow you to keep your operational user profile separate from your testing profile--so as to not corrupt your user profile, and reduce the frequency of needing to reset profile to restore function. But that is not really the main issue of the comment 0 which is about your Java runtime. For that I can not confirm as each install I perform receives its own newly configured default profile. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125257] [META] Tip of the day
https://bugs.documentfoundation.org/show_bug.cgi?id=125257 Bug 125257 depends on bug 124238, which changed state. Bug 124238 Summary: Show a Tip-Of-The-Day dialog on startup https://bugs.documentfoundation.org/show_bug.cgi?id=124238 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128960] Editing: Add a more direct way to clear character styles
https://bugs.documentfoundation.org/show_bug.cgi?id=128960 --- Comment #3 from Mike Kaganski --- Please don't extend this to paragraph styles. Doing that would emphasize usage of Default paragraph style - which is bad. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128960] Editing: Add a more direct way to clear character styles
https://bugs.documentfoundation.org/show_bug.cgi?id=128960 --- Comment #3 from Mike Kaganski --- Please don't extend this to paragraph styles. Doing that would emphasize usage of Default paragraph style - which is bad. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - sc/qa sc/source
sc/qa/unit/bugfix-test.cxx | 28
sc/source/ui/unoobj/cellsuno.cxx |9 -
sc/source/ui/unoobj/servuno.cxx |3 ++-
3 files changed, 38 insertions(+), 2 deletions(-)
New commits:
commit 7eac47252e03bd7072f62cc1a23d441171619d57
Author: Mike Kaganski
AuthorDate: Fri Nov 22 13:53:46 2019 +0300
Commit: Mike Kaganski
CommitDate: Sat Nov 23 06:40:51 2019 +0100
tdf#128951: restore passing nullptr to ScTableSheetObj when not inserted yet
This partially reverts 009e7a54f40ebacd9dd4a394504c277789699801
Change-Id: I5a9605ff9d0ff1cd825968fb247b2a3bf4b2902a
Reviewed-on: https://gerrit.libreoffice.org/83464
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
(cherry picked from commit 2a16decdcccf36f9fa4a1764f68e59c33517b892)
Reviewed-on: https://gerrit.libreoffice.org/83516
diff --git a/sc/qa/unit/bugfix-test.cxx b/sc/qa/unit/bugfix-test.cxx
index 994dbe2ad2e9..a23ba743d829 100644
--- a/sc/qa/unit/bugfix-test.cxx
+++ b/sc/qa/unit/bugfix-test.cxx
@@ -38,6 +38,7 @@ public:
void testRhbz1390776();
void testTdf104310();
void testTdf31231();
+void testTdf128951();
CPPUNIT_TEST_SUITE(ScFiltersTest);
CPPUNIT_TEST(testTdf64229);
@@ -53,6 +54,7 @@ public:
CPPUNIT_TEST(testRhbz1390776);
CPPUNIT_TEST(testTdf104310);
CPPUNIT_TEST(testTdf31231);
+CPPUNIT_TEST(testTdf128951);
CPPUNIT_TEST_SUITE_END();
private:
uno::Reference m_xCalcComponent;
@@ -297,6 +299,32 @@ void ScFiltersTest::testTdf31231()
xDocSh->DoClose();
}
+void ScFiltersTest::testTdf128951()
+{
+css::uno::Reference xDesktop
+=
css::frame::Desktop::create(::comphelper::getProcessComponentContext());
+CPPUNIT_ASSERT(xDesktop.is());
+
+// 1. Create spreadsheet
+css::uno::Sequence aHiddenArgList(1);
+aHiddenArgList[0].Name = "Hidden";
+aHiddenArgList[0].Value <<= true;
+
+css::uno::Reference xComponent
+= xDesktop->loadComponentFromURL("private:factory/scalc", "_blank", 0,
aHiddenArgList);
+CPPUNIT_ASSERT(xComponent.is());
+
+// 2. Create a new sheet instance
+css::uno::Reference xFac(xComponent,
+
css::uno::UNO_QUERY_THROW);
+auto xSheet = xFac->createInstance("com.sun.star.sheet.Spreadsheet");
+
+// 3. Insert sheet into the spreadsheet (was throwing
IllegalArgumentException)
+css::uno::Reference xDoc(xComponent,
+
css::uno::UNO_QUERY_THROW);
+CPPUNIT_ASSERT_NO_THROW(xDoc->getSheets()->insertByName("mustNotThrow",
css::uno::Any(xSheet)));
+}
+
ScFiltersTest::ScFiltersTest()
: ScBootstrapFixture( "sc/qa/unit/data" )
{
diff --git a/sc/source/ui/unoobj/cellsuno.cxx b/sc/source/ui/unoobj/cellsuno.cxx
index 34aba2fd2769..0f3bf54e3765 100644
--- a/sc/source/ui/unoobj/cellsuno.cxx
+++ b/sc/source/ui/unoobj/cellsuno.cxx
@@ -6564,8 +6564,15 @@ sal_Int16 SAL_CALL ScCellObj::resetActionLocks()
return nRet;
}
+static ScRange MaxDocRange(ScDocShell* pDocSh, SCTAB nTab)
+{
+const SCCOL nMaxcol = pDocSh ? pDocSh->GetDocument().MaxCol() : MAXCOL;
+const SCROW nMaxRow = pDocSh ? pDocSh->GetDocument().MaxRow() : MAXROW;
+return ScRange(0, 0, nTab, nMaxcol, nMaxRow, nTab);
+}
+
ScTableSheetObj::ScTableSheetObj( ScDocShell* pDocSh, SCTAB nTab ) :
-ScCellRangeObj( pDocSh, ScRange(0,0,nTab, pDocSh->GetDocument().MaxCol(),
pDocSh->GetDocument().MaxRow(),nTab) ),
+ScCellRangeObj( pDocSh, MaxDocRange(pDocSh, nTab) ),
pSheetPropSet(lcl_GetSheetPropertySet())
{
}
diff --git a/sc/source/ui/unoobj/servuno.cxx b/sc/source/ui/unoobj/servuno.cxx
index 23c7c4b93d27..e778247eaa4f 100644
--- a/sc/source/ui/unoobj/servuno.cxx
+++ b/sc/source/ui/unoobj/servuno.cxx
@@ -401,7 +401,8 @@ uno::Reference
ScServiceProvider::MakeInstance(
switch (nType)
{
case Type::SHEET:
-xRet.set(static_cast(new
ScTableSheetObj(pDocShell,0)));
+// not inserted yet - DocShell=Null
+xRet.set(static_cast(new
ScTableSheetObj(nullptr,0)));
break;
case Type::URLFIELD:
case Type::PAGEFIELD:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128970] Can not open LO in Mac
https://bugs.documentfoundation.org/show_bug.cgi?id=128970 Alex Thurgood changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Alex Thurgood --- *** This bug has been marked as a duplicate of bug 126409 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126409] LibreOffice does not launch normally on macOS 10.15 Catalina
https://bugs.documentfoundation.org/show_bug.cgi?id=126409 Alex Thurgood changed: What|Removed |Added CC||gunilla.kar...@me.com --- Comment #36 from Alex Thurgood --- *** Bug 128970 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: About replacing some "C-Array" into std::array
On 23 Nov 2019, at 5:05 am, Luboš Luňák wrote: > > On Friday 22 of November 2019, julien2412 wrote: >> The goal is to replace some loops with std:: . Of course, I don't >> want to use std:: if I need to add a complicated lambda. >> About "don't fix what is not broken", I disagree here. >> What about removing unused parts and optimizing? After all unused parts and >> not optimized parts don't break anything that's not a reason for not >> modifying them. > > That depends on definition of "broken". Unused or slow code may fit that. > > You asked for a guideline, not for a hard rule. I said I'm not against it per > se. > >> - time to build the whole code > > Note that STL usage generally makes compilation slower, so this argument > doesn't fit here as an argument for this topic. > >>> [**] Which is not that hard given how clunky STL usage can be. I would >>> personally consider converting that transfer.cxx line to std::fill() to >>> be a >>> regression in readability. If STL, then it should be std::array::fill(). >> >> So if you consider replacing: >> for (sal_Bool & rb : pToAccept) >> rb = false; >> by >>std::fill_n(pToAccept, 128, false); >> is a readability regression > > I didn't think of std::fill_n(). I wrote std::fill() and here "std::fill( > pToAccept.begin(), pToAccept.end(), false )" is worse. But even the > std::fill_n() case is debatable because of the need to specify size. Which is > why I said that std::array with its fill() would actually fit better here. > > -- > Luboš Luňák > l.lu...@collabora.com I thought that std::fill was used to try to avoid bounds errors. In particular, the example given in the CppCoreGuidelines is to replace memset. Chris ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 128956] Switching between two versions of LibreOffice resets user profile
https://bugs.documentfoundation.org/show_bug.cgi?id=128956 --- Comment #3 from Alex Thurgood --- 1) The change in behavior is pretty recent, it has worked fine up til now, so hardly an "old" way of parallel installing. 2) The app bundle names are different, for example: LibreOffice LibreOfficeDev LO6282 LO5472 LO6132 etc 3) The whole point of parallel installation using the same profile is to: - keep one's user profile settings intact while switching between versions - be able to test the impact of one's user settings on different versions to report on any issues Given that QA often recommends installing a parallel version to normal people reporting issues, do you really think that your suggestion to modify bootstraprc is going to have huge uptake? Especially since they will then have to separately copy over the bits of the user profile they want, or else configure them manually again. 4) I imagine that tampering with the bootstraprc file might void the notarisation process on Catalina (haven't tested). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [ABANDONED] Remove some excessive log formatting
> On 23 Nov 2019, at 2:11 am, Stephan Bergmann wrote: > > On 22/11/2019 14:55, Luboš Luňák wrote: >> SAL_LOG=+INFO.sal.osl-INFO.sal.osl.noisyarea . Problem solved :). > > Sure, if one is willing to invest in adding sal.osl.noisyarea and > reclassifying existing uses. Which is typically not the case when you do a > one-off SAL_LOG=... debug run. Which is where judicious use of the facility > by code authors pays off. But this brings us back to the use case that you had identified - using SAL_LOG wasn’t the original issue in the patch, incidentally, the issue was use of the tabs in the SAL_LOG. That appears to have been the “misuse” of the logging facility. Those who are trying to identify and resolve issues in EMF+ code are reliant on logging, so it does seem to me that there is no other facility than SAL_LOG that we can use. I certainly don’t want to litter the code with fprintfs to stderr. Chris ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 128972] 'Recent used:' box in Database Wizard is narraw and not expandable
https://bugs.documentfoundation.org/show_bug.cgi?id=128972 --- Comment #1 from Nukool Chompuparn --- Created attachment 156056 --> https://bugs.documentfoundation.org/attachment.cgi?id=156056=edit 'Recent used:' box -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128972] New: 'Recent used:' box in Database Wizard is narraw and not expandable
https://bugs.documentfoundation.org/show_bug.cgi?id=128972 Bug ID: 128972 Summary: 'Recent used:' box in Database Wizard is narraw and not expandable Product: LibreOffice Version: 6.2.8.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: trivial Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nuk...@gmail.com Description: 'Recent used:' box size is not enough for long name of database Steps to Reproduce: 1.Open Base application 2. 3. Actual Results: 'Recent used:' box is narrow Expected Results: Modify the Database Wizard panel in order to have more space to expand 'Recent used:' box. Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128971] Current Library box is too narrow and not expandable
https://bugs.documentfoundation.org/show_bug.cgi?id=128971 --- Comment #1 from Nukool Chompuparn --- Created attachment 156055 --> https://bugs.documentfoundation.org/attachment.cgi?id=156055=edit Narrow Current Library box -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128971] New: Current Library box is too narrow and not expandable
https://bugs.documentfoundation.org/show_bug.cgi?id=128971 Bug ID: 128971 Summary: Current Library box is too narrow and not expandable Product: LibreOffice Version: 6.2.8.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: trivial Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nuk...@gmail.com Description: In BASIC editor,'Current Library' box is too narrow and not expandable Steps to Reproduce: 1.Tools > Macros > Organize Macros > LibreOffice BASIC > select a module > Edit 2. 3. Actual Results: 'Current Library' box is too narrow and not expandable even when the screen is wide. Expected Results: Expandable or auto fit Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101630] Google Drive two-factor authentication (2FA) not working again
https://bugs.documentfoundation.org/show_bug.cgi?id=101630 Luis Alberto Hernández Monroy changed: What|Removed |Added Version|5.2.0.4 release |6.3.3.2 release Keywords||accessibility OS|All |Mac OS X (All) --- Comment #56 from Luis Alberto Hernández Monroy --- Google Drive two-factor authentication not working on 6.3.3.2 I'm getting the "The specified device is invalid." when trying to setup the connection. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127922] 'Droid Sans Thai' font shows numeric characters incorrectly.
https://bugs.documentfoundation.org/show_bug.cgi?id=127922 --- Comment #11 from Nukool Chompuparn --- Created attachment 156054 --> https://bugs.documentfoundation.org/attachment.cgi?id=156054=edit Format cells : Font -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127922] 'Droid Sans Thai' font shows numeric characters incorrectly.
https://bugs.documentfoundation.org/show_bug.cgi?id=127922 --- Comment #10 from Nukool Chompuparn --- Created attachment 156053 --> https://bugs.documentfoundation.org/attachment.cgi?id=156053=edit Language settings -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127922] 'Droid Sans Thai' font shows numeric characters incorrectly.
https://bugs.documentfoundation.org/show_bug.cgi?id=127922 --- Comment #9 from Nukool Chompuparn --- (In reply to Kevin Suo from comment #8) > Nukool Chompuparn: would you check and see whether this is a duplicate of > bug 126248? Dear Kevin, Sorry, I think it is different. Please see my Thai language settings from images attached right after this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126607] undocked find doesn't get focus on KDE
https://bugs.documentfoundation.org/show_bug.cgi?id=126607 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128946] Libre Office Calc crashed with search in selected column
https://bugs.documentfoundation.org/show_bug.cgi?id=128946 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128950] With LO Base 6.2, it is no longer possible to change the Database connection type in "MySQL (Native)"
https://bugs.documentfoundation.org/show_bug.cgi?id=128950 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128895] Hidden Columns but keep reappearing! Unlike Rows which will stay hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=128895 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128965] Error: Database connection failed when opening. Database has lost ALL information.
https://bugs.documentfoundation.org/show_bug.cgi?id=128965 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128946] Libre Office Calc crashed with search in selected column
https://bugs.documentfoundation.org/show_bug.cgi?id=128946 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127815] Non-breaking spaces not inserted when LibreOffice-KDE5 is installed, since Libo 6.3.x (French typo)
https://bugs.documentfoundation.org/show_bug.cgi?id=127815 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128895] Hidden Columns but keep reappearing! Unlike Rows which will stay hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=128895 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80949] Previous selection of "Bullets and Numbering" type lost if dialog opened again
https://bugs.documentfoundation.org/show_bug.cgi?id=80949 --- Comment #9 from QA Administrators --- Dear Hans Deragon, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128671] master branch cannot be built without manual hacks with Aarch64 distro config
https://bugs.documentfoundation.org/show_bug.cgi?id=128671 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128965] Error: Database connection failed when opening. Database has lost ALL information.
https://bugs.documentfoundation.org/show_bug.cgi?id=128965 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113512] 1.15 Line spacing is missing in Format Spacing menu
https://bugs.documentfoundation.org/show_bug.cgi?id=113512 --- Comment #8 from QA Administrators --- Dear Jim Raykowski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108272] FILEOPEN: SAXException: [word/document.xml line 2]: unknown error for .docx with floating table in header
https://bugs.documentfoundation.org/show_bug.cgi?id=108272 --- Comment #8 from QA Administrators --- Dear Frederic Parrenin, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68752] Error while "Save as"/Export as XML using "LibreOffice Calc" if there are 3 empty rows
https://bugs.documentfoundation.org/show_bug.cgi?id=68752 --- Comment #13 from QA Administrators --- Dear arnosn, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source
cui/source/options/treeopt.cxx | 41 +
1 file changed, 13 insertions(+), 28 deletions(-)
New commits:
commit 32dcf3f0fdafcf44457842a8aa4f54d30d856ca9
Author: Michael Weghorn
AuthorDate: Fri Nov 22 10:51:20 2019 +0100
Commit: Michael Weghorn
CommitDate: Sat Nov 23 01:48:55 2019 +0100
treeopt.cxx: Simplify 'ModuleMap' handling
Use 'OUString' instead of 'const char*' for
'ModuleToGroupNameMap_Impl.m_pModule', and
simplify the iteration using range-based for.
Change-Id: I1756bc6ac8b163a68b79d6900738362db010d8a9
Reviewed-on: https://gerrit.libreoffice.org/83488
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/cui/source/options/treeopt.cxx b/cui/source/options/treeopt.cxx
index f2a4fd4bb2d7..0195856932c7 100644
--- a/cui/source/options/treeopt.cxx
+++ b/cui/source/options/treeopt.cxx
@@ -134,11 +134,10 @@ namespace {
struct ModuleToGroupNameMap_Impl
{
-const char* m_pModule;
+OUStringm_pModule;
OUStringm_sGroupName;
sal_uInt16 m_nNodeId;
};
-
}
static ModuleToGroupNameMap_Impl ModuleMap[] =
@@ -155,40 +154,30 @@ static ModuleToGroupNameMap_Impl ModuleMap[] =
{ "Draw", OUString(), SID_SD_GRAPHIC_OPTIONS },
{ "Charts", OUString(), SID_SCH_EDITOPTIONS },
{ "Base", OUString(), SID_SB_STARBASEOPTIONS },
-
-{ nullptr, OUString(), 0x }
};
static void setGroupName( const OUString& rModule, const OUString& rGroupName )
{
-sal_uInt16 nIndex = 0;
-while ( ModuleMap[ nIndex ].m_pModule )
+for (ModuleToGroupNameMap_Impl& rEntry : ModuleMap)
{
-OUString sTemp =
-OUString::createFromAscii( ModuleMap[ nIndex ].m_pModule );
-if ( sTemp == rModule )
+if ( rEntry.m_pModule == rModule )
{
-ModuleMap[ nIndex ].m_sGroupName = rGroupName;
+rEntry.m_sGroupName = rGroupName;
break;
}
-++nIndex;
}
}
static OUString getGroupName( const OUString& rModule, bool bForced )
{
OUString sGroupName;
-sal_uInt16 nIndex = 0;
-while ( ModuleMap[ nIndex ].m_pModule )
+for (const ModuleToGroupNameMap_Impl& rEntry : ModuleMap)
{
-OUString sTemp =
-OUString::createFromAscii( ModuleMap[ nIndex ].m_pModule );
-if ( sTemp == rModule )
+if ( rEntry.m_pModule == rModule )
{
-sGroupName = ModuleMap[ nIndex ].m_sGroupName;
+sGroupName = rEntry.m_sGroupName;
break;
}
-++nIndex;
}
if ( sGroupName.isEmpty() && bForced )
@@ -213,24 +202,20 @@ static OUString getGroupName( const OUString& rModule,
bool bForced )
static void deleteGroupNames()
{
-sal_uInt16 nIndex = 0;
-while ( ModuleMap[ nIndex ].m_pModule )
-ModuleMap[ nIndex++ ].m_sGroupName.clear();
+for (ModuleToGroupNameMap_Impl& rEntry : ModuleMap)
+rEntry.m_sGroupName.clear();
}
static sal_uInt16 getGroupNodeId( const OUString& rModule )
{
-sal_uInt16 nNodeId = 0x, nIndex = 0;
-while ( ModuleMap[ nIndex ].m_pModule )
+sal_uInt16 nNodeId = 0x;
+for (const ModuleToGroupNameMap_Impl& rEntry : ModuleMap)
{
-OUString sTemp =
-OUString::createFromAscii( ModuleMap[ nIndex ].m_pModule );
-if ( sTemp == rModule )
+if ( rEntry.m_pModule == rModule )
{
-nNodeId = ModuleMap[ nIndex ].m_nNodeId;
+nNodeId = rEntry.m_nNodeId;
break;
}
-++nIndex;
}
return nNodeId;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cui/source
cui/source/options/treeopt.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 5ac711f83bc795bbcc459c9d56bf9ee91b78fd3c
Author: Michael Weghorn
AuthorDate: Fri Nov 22 10:23:32 2019 +0100
Commit: Michael Weghorn
CommitDate: Sat Nov 23 01:48:33 2019 +0100
Use const OUString instead of const char[]
'SvtViewOptions::GetUserItem' and
'SvtViewOptions::SetUserItem' take a
'const OUString&' param anyway.
Change-Id: Icdc4c578516c9fe1307b64eecdf3270142b4e823
Reviewed-on: https://gerrit.libreoffice.org/83487
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/cui/source/options/treeopt.cxx b/cui/source/options/treeopt.cxx
index 8b7c32b051bd..f2a4fd4bb2d7 100644
--- a/cui/source/options/treeopt.cxx
+++ b/cui/source/options/treeopt.cxx
@@ -114,7 +114,7 @@ using namespace ::com::sun::star::util;
LastPageSaver* OfaTreeOptionsDialog::pLastPageSaver = nullptr;
// some stuff for easier changes for SvtViewOptions
-static char const VIEWOPT_DATANAME[] = "page data";
+static const OUString VIEWOPT_DATANAME = "page data";
static void SetViewOptUserItem( SvtViewOptions& rOpt, const OUString& rData )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 119888] [META] DOCX (OOXML) object-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=119888 Bug 119888 depends on bug 76513, which changed state. Bug 76513 Summary: FILEOPEN: Very bad positioning of drawing objects on writer throughout the document in docx https://bugs.documentfoundation.org/show_bug.cgi?id=76513 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76513] FILEOPEN: Very bad positioning of drawing objects on writer throughout the document in docx
https://bugs.documentfoundation.org/show_bug.cgi?id=76513 Afrim Hoxha changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1035a02ff49accc5582fe02166e3bf263eb3f0af Author: Olivier Hallot AuthorDate: Fri Nov 22 20:50:20 2019 -0300 Commit: Gerrit Code Review CommitDate: Sat Nov 23 01:01:05 2019 +0100 Update git submodules * Update helpcontent2 from branch 'libreoffice-6-4' - Fix div position for Online Help The condition was masking the div. Now the condition mask the contents Change-Id: I270e20f3ae17a16d4425698f24e674763320fade Reviewed-on: https://gerrit.libreoffice.org/83541 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 06c41e39f822..57c5e2761675 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 06c41e39f82240bd9e16d0c10155d07b152bb52d +Subproject commit 57c5e2761675d20ec5df1b55300a60e3aa0d7a47 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 336908d5e17fa678fb5433a5dbaddc53fa1c54f7 Author: Olivier Hallot AuthorDate: Fri Nov 22 20:50:20 2019 -0300 Commit: Gerrit Code Review CommitDate: Sat Nov 23 01:00:29 2019 +0100 Update git submodules * Update helpcontent2 from branch 'master' - Fix div position for Online Help The condition was masking the div. Now the condition mask the contents Change-Id: I270e20f3ae17a16d4425698f24e674763320fade Reviewed-on: https://gerrit.libreoffice.org/83540 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index af707d225992..759f36366848 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit af707d225992401f672bb19c77a5bc3001b62c3c +Subproject commit 759f363668485dab912dafa684934dbc152e7b8d ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Branch 'libreoffice-6-4' - help3xsl/online_transform.xsl
help3xsl/online_transform.xsl | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) New commits: commit 57c5e2761675d20ec5df1b55300a60e3aa0d7a47 Author: Olivier Hallot AuthorDate: Fri Nov 22 20:50:20 2019 -0300 Commit: Olivier Hallot CommitDate: Sat Nov 23 01:01:05 2019 +0100 Fix div position for Online Help The condition was masking the div. Now the condition mask the contents Change-Id: I270e20f3ae17a16d4425698f24e674763320fade Reviewed-on: https://gerrit.libreoffice.org/83541 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/help3xsl/online_transform.xsl b/help3xsl/online_transform.xsl index 12d0807de..f22262780 100644 --- a/help3xsl/online_transform.xsl +++ b/help3xsl/online_transform.xsl @@ -221,23 +221,25 @@ - + + - - - - + + + + + https://www.libreoffice.org/donate/?pk_campaign=help; target ="_blank"> - - + + https://www.libreoffice.org/imprint; target="_blank">Impressum (Legal Info) | https://www.libreoffice.org/privacy; target="_blank">Privacy Policy | https://www.documentfoundation.org/statutes.pdf; target="_blank">Statutes (non-binding English translation) - https://www.documentfoundation.org/satzung.pdf; target="_blank">Satzung (binding German version) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the https://www.libreoffice.org/download/license/; target="_blank">Mozilla Public License v2.0. “LibreOffice” and “The Document Foundation” are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our https://wiki.documentfoundation.org/TradeMark_Policy; target="_blank">trademark policy. LibreOffice was based on OpenOffice.org. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2aea75df55e3230e3d5e7e8552de488aa351cc64 Author: Ilmari Lauhakangas AuthorDate: Sun Nov 3 13:36:42 2019 +0200 Commit: Gerrit Code Review CommitDate: Sat Nov 23 00:59:39 2019 +0100 Update git submodules * Update helpcontent2 from branch 'master' - Improve the help for old Fontwork The old Fontwork functionality continues to be very useful. Some see it as even more useful than the new Fontwork. I changed the text to make it more understandable what it is all about. Change-Id: I05f073a7cdb23d5aa1470fd7a19386f444010d7e Reviewed-on: https://gerrit.libreoffice.org/81961 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index b01173d32549..af707d225992 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit b01173d325490f19537e67193bd383d475a55237 +Subproject commit af707d225992401f672bb19c77a5bc3001b62c3c ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: help3xsl/online_transform.xsl
help3xsl/online_transform.xsl | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) New commits: commit 759f363668485dab912dafa684934dbc152e7b8d Author: Olivier Hallot AuthorDate: Fri Nov 22 20:50:20 2019 -0300 Commit: Olivier Hallot CommitDate: Sat Nov 23 01:00:29 2019 +0100 Fix div position for Online Help The condition was masking the div. Now the condition mask the contents Change-Id: I270e20f3ae17a16d4425698f24e674763320fade Reviewed-on: https://gerrit.libreoffice.org/83540 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/help3xsl/online_transform.xsl b/help3xsl/online_transform.xsl index 12d0807de..f22262780 100644 --- a/help3xsl/online_transform.xsl +++ b/help3xsl/online_transform.xsl @@ -221,23 +221,25 @@ - + + - - - - + + + + + https://www.libreoffice.org/donate/?pk_campaign=help; target ="_blank"> - - + + https://www.libreoffice.org/imprint; target="_blank">Impressum (Legal Info) | https://www.libreoffice.org/privacy; target="_blank">Privacy Policy | https://www.documentfoundation.org/statutes.pdf; target="_blank">Statutes (non-binding English translation) - https://www.documentfoundation.org/satzung.pdf; target="_blank">Satzung (binding German version) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the https://www.libreoffice.org/download/license/; target="_blank">Mozilla Public License v2.0. “LibreOffice” and “The Document Foundation” are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our https://wiki.documentfoundation.org/TradeMark_Policy; target="_blank">trademark policy. LibreOffice was based on OpenOffice.org. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/shared/01/0528.xhp | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) New commits: commit af707d225992401f672bb19c77a5bc3001b62c3c Author: Ilmari Lauhakangas AuthorDate: Sun Nov 3 13:36:42 2019 +0200 Commit: Olivier Hallot CommitDate: Sat Nov 23 00:59:39 2019 +0100 Improve the help for old Fontwork The old Fontwork functionality continues to be very useful. Some see it as even more useful than the new Fontwork. I changed the text to make it more understandable what it is all about. Change-Id: I05f073a7cdb23d5aa1470fd7a19386f444010d7e Reviewed-on: https://gerrit.libreoffice.org/81961 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/shared/01/0528.xhp b/source/text/shared/01/0528.xhp index 9e86f0a60..fe853fa45 100644 --- a/source/text/shared/01/0528.xhp +++ b/source/text/shared/01/0528.xhp @@ -34,17 +34,12 @@ -Fontwork Dialog (Previous Version) -Edits Fontwork effects of the selected object that has been created with the previous Fontwork dialog.UFI: this old dialog is still available to edit old docs containing old Fontwork objects. See "Fontwork_ui" spec doc. -This Fontwork dialog is only available for Fontwork in old Writer text documents that were created prior to OpenOffice.org 2.0. You must first call Tools - Customize to add a menu command or an icon to open this dialog.UFI: the command is in Customize dialog at Format-Fontwork +Fontwork Dialog (for putting text along a curve) +Simple tool for putting text along a curve without any fancy effects.UFI: see "Fontwork_ui" spec doc. +This Fontwork dialog is meant for making text follow a curve. Draw a curve, double-click it and type text into it. With the curve selected, you can now activate the Fontwork command. In Writer, you can access the dialog by choosing Format - Text Box and Shape - Fontwork. In other applications, you must first call Tools - Customize to add a menu command or a toolbar button to open the dialog. The Fontwork command is found in the Format category of the Customize dialog. -You can change the shape of the text baseline to match semicircles, arcs, circles, and freeform lines. Alignment icons - -Click the shape of the baseline that you want to use for the text. -The top row contains the following baseline shapes: Upper Semicircle, Lower Semicircle, Left Semicircle and Right Semicircle. -The middle row contains the following baseline shapes: Upper Arc, Lower Arc, Left Arc and Right Arc. -The bottom row contains the following baseline shapes: Open Circle, Closed Circle, Closed Circle II, and Open Circle Vertical. For the best results, the drawing object must contain more than two lines of text. +You can make text follow any shape. Most of the custom shapes available in the Drawing toolbar need to be converted to a different type before you can use them with Fontwork. In Impress or Draw, right-click the shape and select Convert - To Curve/Polygon/Contour. If you wish, you can now copy and paste the converted shape into Writer for use with Fontwork. Shapes in the Legacy Circles and Ovals and Legacy Rectangles toolbars do not need to be converted. The Arc included in the basic shapes is also a legacy shape. Removes baseline formatting. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128895] Hidden Columns but keep reappearing! Unlike Rows which will stay hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=128895 --- Comment #5 from Mark Mclean --- I hide columns that I do not use, Like column w to amj! I tried to leave a file, but didn't understand it to well, hope its there, if not here is how I share it. http://bit.ly/faithalone -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82091] Spelling dialog correction of Calc cells does not remove red wavy underline, but context menu spelling correction does
https://bugs.documentfoundation.org/show_bug.cgi?id=82091 --- Comment #21 from rpr --- Reproducible in LibreOffice Calc 6.3.3.2 (running on Ubuntu 18.04). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128895] Hidden Columns but keep reappearing! Unlike Rows which will stay hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=128895 --- Comment #4 from m.a.riosv --- What columns were hidden that are visible on opening? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128970] Can not open LO in Mac
https://bugs.documentfoundation.org/show_bug.cgi?id=128970 Julien Nabet changed: What|Removed |Added CC||ipla...@tuta.io, ||serval2...@yahoo.fr --- Comment #3 from Julien Nabet --- Alex: thought you might be interested in this one. Isn't it the pb on Catalina or Mojave and new security rules from Apple? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128965] Error: Database connection failed when opening. Database has lost ALL information.
https://bugs.documentfoundation.org/show_bug.cgi?id=128965 --- Comment #3 from Ronald --- - database connection: through java, no msql server - connection is alive for days or a week, no specific time - database now is on the internal network (NAS), but in previous situations on the same harddrive as LibreOffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128950] With LO Base 6.2, it is no longer possible to change the Database connection type in "MySQL (Native)"
https://bugs.documentfoundation.org/show_bug.cgi?id=128950
Julien Nabet changed:
What|Removed |Added
CC||btom...@gmail.com
--- Comment #8 from Julien Nabet ---
Pb is due to this part
118 // skip mysql connection variations. It is handled in another window.
119 if(sURLPrefix.startsWith("sdbc:mysql:") &&
!sURLPrefix.startsWith("sdbc:mysql:jdbc:"))
120 continue;
Commenting this block makes Mysql Native Mysql ODBC appear
(see
https://cgit.freedesktop.org/libreoffice/core/commit/?id=b2cefc2e36925b4384eb0aea54aa2c6bcfb018a8)
Tamás: any thoughts here?
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - oox/source sd/qa
oox/source/export/drawingml.cxx |2 +-
sd/qa/unit/data/pptx/tdf128952.pptx |binary
sd/qa/unit/export-tests-ooxml1.cxx | 17 +
3 files changed, 18 insertions(+), 1 deletion(-)
New commits:
commit 2dc030922eb7991befcc9ea02ef2e400fca65141
Author: Gülşah Köse
AuthorDate: Fri Nov 22 14:05:24 2019 +0300
Commit: Andras Timar
CommitDate: Fri Nov 22 23:18:55 2019 +0100
tdf#128952 Set the position of shape for 180 deg.
If the rotation value is 180, 540, 900... degree with mirror
pShape->GetRotateAngle() returns 0. In that control 0 means
no rotation but that is not true. For that cases (180, 540, 900)
after the angle conversition GetRotateAngle() returns 0. We should
recalculate the position for 0 too.
Change-Id: I14e981235b2d6cd8382d4c9e151bccd2e73a3fd9
Reviewed-on: https://gerrit.libreoffice.org/83468
Tested-by: Jenkins
Reviewed-by: Gülşah Köse
(cherry picked from commit aca2e4d270f472b2cbdb9084a55f1855529ea705)
Reviewed-on: https://gerrit.libreoffice.org/83535
Reviewed-by: Andras Timar
diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index 60b674287a43..9e5b3f2648f4 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -1621,7 +1621,7 @@ void DrawingML::WriteShapeTransformation( const
Reference< XShape >& rXShape, sa
{
SdrObject* pShape = GetSdrObjectFromXShape( rXShape );
nRotation = pShape ? pShape->GetRotateAngle() : 0;
-if ( nRotation != 0 && GetDocumentType() != DOCUMENT_DOCX )
+if ( GetDocumentType() != DOCUMENT_DOCX )
{
int faccos=bFlipV ? -1 : 1;
int facsin=bFlipH ? -1 : 1;
diff --git a/sd/qa/unit/data/pptx/tdf128952.pptx
b/sd/qa/unit/data/pptx/tdf128952.pptx
new file mode 100644
index ..242a3ee9ace5
Binary files /dev/null and b/sd/qa/unit/data/pptx/tdf128952.pptx differ
diff --git a/sd/qa/unit/export-tests-ooxml1.cxx
b/sd/qa/unit/export-tests-ooxml1.cxx
index a0cd3b837af3..6048cb850e2e 100644
--- a/sd/qa/unit/export-tests-ooxml1.cxx
+++ b/sd/qa/unit/export-tests-ooxml1.cxx
@@ -103,6 +103,7 @@ public:
void testParaMarginAndindentation();
void testTdf111884();
void testTdf112633();
+void testTdf128952();
void testCustomXml();
void testTdf94238();
void testPictureTransparency();
@@ -136,6 +137,7 @@ public:
CPPUNIT_TEST(testParaMarginAndindentation);
CPPUNIT_TEST(testTdf111884);
CPPUNIT_TEST(testTdf112633);
+CPPUNIT_TEST(testTdf128952);
CPPUNIT_TEST(testCustomXml);
CPPUNIT_TEST(testTdf94238);
CPPUNIT_TEST(testTdf125554);
@@ -829,6 +831,21 @@ void SdOOXMLExportTest1::testTdf112633()
CPPUNIT_ASSERT_EQUAL(true,
bool(xNameAccess->hasByName("ppt/media/hdphoto1.wdp")));
}
+void SdOOXMLExportTest1::testTdf128952()
+{
+::sd::DrawDocShellRef xDocShRef =
loadURL(m_directories.getURLFromSrc("sd/qa/unit/data/pptx/tdf128952.pptx"),
PPTX);
+utl::TempFile tempFile;
+xDocShRef = saveAndReload(xDocShRef.get(), PPTX, );
+xDocShRef->DoClose();
+
+xmlDocPtr pXmlDoc = parseExport(tempFile, "ppt/slides/slide1.xml");
+
+assertXPath(pXmlDoc, "/p:sld/p:cSld/p:spTree/p:sp/p:spPr/a:xfrm/a:off",
"x", "360");
+assertXPath(pXmlDoc, "/p:sld/p:cSld/p:spTree/p:sp/p:spPr/a:xfrm/a:off",
"y", "-360");
+assertXPath(pXmlDoc, "/p:sld/p:cSld/p:spTree/p:sp/p:spPr/a:xfrm/a:ext",
"cx", "1919880");
+assertXPath(pXmlDoc, "/p:sld/p:cSld/p:spTree/p:sp/p:spPr/a:xfrm/a:ext",
"cy", "1462680");
+}
+
void SdOOXMLExportTest1::testCustomXml()
{
// Load document and export it to a temporary file
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - oox/source sd/qa
oox/source/export/drawingml.cxx |2 +-
sd/qa/unit/data/pptx/tdf128952.pptx |binary
sd/qa/unit/export-tests-ooxml1.cxx | 17 +
3 files changed, 18 insertions(+), 1 deletion(-)
New commits:
commit be2a1c28573bb6de0def84b69c15f1079b76bdb5
Author: Gülşah Köse
AuthorDate: Fri Nov 22 14:05:24 2019 +0300
Commit: Andras Timar
CommitDate: Fri Nov 22 23:18:37 2019 +0100
tdf#128952 Set the position of shape for 180 deg.
If the rotation value is 180, 540, 900... degree with mirror
pShape->GetRotateAngle() returns 0. In that control 0 means
no rotation but that is not true. For that cases (180, 540, 900)
after the angle conversition GetRotateAngle() returns 0. We should
recalculate the position for 0 too.
Change-Id: I14e981235b2d6cd8382d4c9e151bccd2e73a3fd9
Reviewed-on: https://gerrit.libreoffice.org/83468
Tested-by: Jenkins
Reviewed-by: Gülşah Köse
(cherry picked from commit aca2e4d270f472b2cbdb9084a55f1855529ea705)
Reviewed-on: https://gerrit.libreoffice.org/83534
Reviewed-by: Andras Timar
diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index 2cc160d05b57..6ca1e78d3dfb 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -1647,7 +1647,7 @@ void DrawingML::WriteShapeTransformation( const
Reference< XShape >& rXShape, sa
{
SdrObject* pShape = GetSdrObjectFromXShape( rXShape );
nRotation = pShape ? pShape->GetRotateAngle() : 0;
-if ( nRotation != 0 && GetDocumentType() != DOCUMENT_DOCX )
+if ( GetDocumentType() != DOCUMENT_DOCX )
{
int faccos=bFlipV ? -1 : 1;
int facsin=bFlipH ? -1 : 1;
diff --git a/sd/qa/unit/data/pptx/tdf128952.pptx
b/sd/qa/unit/data/pptx/tdf128952.pptx
new file mode 100644
index ..242a3ee9ace5
Binary files /dev/null and b/sd/qa/unit/data/pptx/tdf128952.pptx differ
diff --git a/sd/qa/unit/export-tests-ooxml1.cxx
b/sd/qa/unit/export-tests-ooxml1.cxx
index 05d7d3aff31b..ddc41b563c99 100644
--- a/sd/qa/unit/export-tests-ooxml1.cxx
+++ b/sd/qa/unit/export-tests-ooxml1.cxx
@@ -80,6 +80,7 @@ public:
void testParaMarginAndindentation();
void testTdf111884();
void testTdf112633();
+void testTdf128952();
void testCustomXml();
void testTdf94238();
void testPictureTransparency();
@@ -116,6 +117,7 @@ public:
CPPUNIT_TEST(testParaMarginAndindentation);
CPPUNIT_TEST(testTdf111884);
CPPUNIT_TEST(testTdf112633);
+CPPUNIT_TEST(testTdf128952);
CPPUNIT_TEST(testCustomXml);
CPPUNIT_TEST(testTdf94238);
CPPUNIT_TEST(testTdf125554);
@@ -812,6 +814,21 @@ void SdOOXMLExportTest1::testTdf112633()
CPPUNIT_ASSERT_EQUAL(true,
bool(xNameAccess->hasByName("ppt/media/hdphoto1.wdp")));
}
+void SdOOXMLExportTest1::testTdf128952()
+{
+::sd::DrawDocShellRef xDocShRef =
loadURL(m_directories.getURLFromSrc("sd/qa/unit/data/pptx/tdf128952.pptx"),
PPTX);
+utl::TempFile tempFile;
+xDocShRef = saveAndReload(xDocShRef.get(), PPTX, );
+xDocShRef->DoClose();
+
+xmlDocPtr pXmlDoc = parseExport(tempFile, "ppt/slides/slide1.xml");
+
+assertXPath(pXmlDoc, "/p:sld/p:cSld/p:spTree/p:sp/p:spPr/a:xfrm/a:off",
"x", "360");
+assertXPath(pXmlDoc, "/p:sld/p:cSld/p:spTree/p:sp/p:spPr/a:xfrm/a:off",
"y", "-360");
+assertXPath(pXmlDoc, "/p:sld/p:cSld/p:spTree/p:sp/p:spPr/a:xfrm/a:ext",
"cx", "1919880");
+assertXPath(pXmlDoc, "/p:sld/p:cSld/p:spTree/p:sp/p:spPr/a:xfrm/a:ext",
"cy", "1462680");
+}
+
void SdOOXMLExportTest1::testCustomXml()
{
// Load document and export it to a temporary file
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - oox/source sd/qa
oox/source/export/drawingml.cxx |2 +-
sd/qa/unit/data/pptx/tdf128952.pptx |binary
sd/qa/unit/export-tests-ooxml1.cxx | 17 +
3 files changed, 18 insertions(+), 1 deletion(-)
New commits:
commit fe9545f05a5d5ad871564a24a395d9893fe00da4
Author: Gülşah Köse
AuthorDate: Fri Nov 22 14:05:24 2019 +0300
Commit: Andras Timar
CommitDate: Fri Nov 22 23:18:22 2019 +0100
tdf#128952 Set the position of shape for 180 deg.
If the rotation value is 180, 540, 900... degree with mirror
pShape->GetRotateAngle() returns 0. In that control 0 means
no rotation but that is not true. For that cases (180, 540, 900)
after the angle conversition GetRotateAngle() returns 0. We should
recalculate the position for 0 too.
Change-Id: I14e981235b2d6cd8382d4c9e151bccd2e73a3fd9
Reviewed-on: https://gerrit.libreoffice.org/83468
Tested-by: Jenkins
Reviewed-by: Gülşah Köse
(cherry picked from commit aca2e4d270f472b2cbdb9084a55f1855529ea705)
Reviewed-on: https://gerrit.libreoffice.org/83536
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Andras Timar
diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index 7962c41f6406..9ac4fd744963 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -1576,7 +1576,7 @@ void DrawingML::WriteShapeTransformation( const
Reference< XShape >& rXShape, sa
{
SdrObject* pShape = GetSdrObjectFromXShape( rXShape );
nRotation = pShape ? pShape->GetRotateAngle() : 0;
-if ( nRotation != 0 && GetDocumentType() != DOCUMENT_DOCX )
+if ( GetDocumentType() != DOCUMENT_DOCX )
{
int faccos=bFlipV ? -1 : 1;
int facsin=bFlipH ? -1 : 1;
diff --git a/sd/qa/unit/data/pptx/tdf128952.pptx
b/sd/qa/unit/data/pptx/tdf128952.pptx
new file mode 100644
index ..242a3ee9ace5
Binary files /dev/null and b/sd/qa/unit/data/pptx/tdf128952.pptx differ
diff --git a/sd/qa/unit/export-tests-ooxml1.cxx
b/sd/qa/unit/export-tests-ooxml1.cxx
index 601497cee2b3..59795b9f3c22 100644
--- a/sd/qa/unit/export-tests-ooxml1.cxx
+++ b/sd/qa/unit/export-tests-ooxml1.cxx
@@ -100,6 +100,7 @@ public:
void testParaMarginAndindentation();
void testTdf111884();
void testTdf112633();
+void testTdf128952();
void testCustomXml();
void testPictureTransparency();
void testTdf94238();
@@ -132,6 +133,7 @@ public:
CPPUNIT_TEST(testParaMarginAndindentation);
CPPUNIT_TEST(testTdf111884);
CPPUNIT_TEST(testTdf112633);
+CPPUNIT_TEST(testTdf128952);
CPPUNIT_TEST(testCustomXml);
CPPUNIT_TEST(testPictureTransparency);
CPPUNIT_TEST(testTdf94238);
@@ -836,6 +838,21 @@ void SdOOXMLExportTest1::testTdf112633()
CPPUNIT_ASSERT_EQUAL(true,
bool(xNameAccess->hasByName("ppt/media/hdphoto1.wdp")));
}
+void SdOOXMLExportTest1::testTdf128952()
+{
+::sd::DrawDocShellRef xDocShRef =
loadURL(m_directories.getURLFromSrc("sd/qa/unit/data/pptx/tdf128952.pptx"),
PPTX);
+utl::TempFile tempFile;
+xDocShRef = saveAndReload(xDocShRef.get(), PPTX, );
+xDocShRef->DoClose();
+
+xmlDocPtr pXmlDoc = parseExport(tempFile, "ppt/slides/slide1.xml");
+
+assertXPath(pXmlDoc, "/p:sld/p:cSld/p:spTree/p:sp/p:spPr/a:xfrm/a:off",
"x", "360");
+assertXPath(pXmlDoc, "/p:sld/p:cSld/p:spTree/p:sp/p:spPr/a:xfrm/a:off",
"y", "-360");
+assertXPath(pXmlDoc, "/p:sld/p:cSld/p:spTree/p:sp/p:spPr/a:xfrm/a:ext",
"cx", "1919880");
+assertXPath(pXmlDoc, "/p:sld/p:cSld/p:spTree/p:sp/p:spPr/a:xfrm/a:ext",
"cy", "1462680");
+}
+
void SdOOXMLExportTest1::testCustomXml()
{
// Load document and export it to a temporary file
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128895] Hidden Columns but keep reappearing! Unlike Rows which will stay hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=128895 --- Comment #3 from Mark Mclean --- Created attachment 156052 --> https://bugs.documentfoundation.org/attachment.cgi?id=156052=edit All sheets locked, no password needed to unlock. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/fontsubset/cff.cxx |7 +++
1 file changed, 7 insertions(+)
New commits:
commit 2679c012115424e2728cfe79f7c6b5b243739b4e
Author: Julien Nabet
AuthorDate: Fri Nov 22 22:28:51 2019 +0100
Commit: Julien Nabet
CommitDate: Fri Nov 22 23:09:35 2019 +0100
GCC trunk towards GCC 9 still emits a bogus -Wstringop-truncation
Change-Id: I14ff82099107302f5e99f22735c37901f68934e9
Reviewed-on: https://gerrit.libreoffice.org/83537
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/vcl/source/fontsubset/cff.cxx b/vcl/source/fontsubset/cff.cxx
index c1b4724d3db0..208264e7346a 100644
--- a/vcl/source/fontsubset/cff.cxx
+++ b/vcl/source/fontsubset/cff.cxx
@@ -1631,7 +1631,14 @@ void Type1Emitter::setSubsetName( const char*
pSubsetName)
{
maSubsetName[0] = '\0';
if( pSubsetName)
+#if defined __GNUC__ && (__GNUC__ == 8 || __GNUC__ == 9) && !defined __clang__
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wstringop-truncation"
+#endif
strncpy( maSubsetName, pSubsetName, sizeof(maSubsetName));
+#if defined __GNUC__ && (__GNUC__ == 8 || __GNUC__ == 9) && !defined __clang__
+#pragma GCC diagnostic pop
+#endif
maSubsetName[sizeof(maSubsetName)-1] = '\0';
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128950] With LO Base 6.2, it is no longer possible to change the Database connection type in "MySQL (Native)"
https://bugs.documentfoundation.org/show_bug.cgi?id=128950 Julien Nabet changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #7 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I could reproduce this. If I create MYSQL/JDBC file then try to change it to Mysql Native, it doesn't appear. Sorry I had misread the initial comment. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128963] WRITER, IMPRESS: When printing, font size ist reduced to 255pt max
https://bugs.documentfoundation.org/show_bug.cgi?id=128963 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 --- Comment #1 from m.a.riosv --- Please attach a sample file to reproduce the issue, with 6.4 the limit seems to be 999,9. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128950] With LO Base 6.2, it is no longer possible to change the Database connection type in "MySQL (Native)"
https://bugs.documentfoundation.org/show_bug.cgi?id=128950 --- Comment #6 from Stang --- Created attachment 156051 --> https://bugs.documentfoundation.org/attachment.cgi?id=156051=edit on Ubuntu 18.04 with LO 6.3.3.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128950] With LO Base 6.2, it is no longer possible to change the Database connection type in "MySQL (Native)"
https://bugs.documentfoundation.org/show_bug.cgi?id=128950 --- Comment #5 from Stang --- Have seen the same with recent versions and currently on Ubuntu 18.04 with: Version: 6.3.3.2 Build ID: a64200df03143b798afd1ec74a12ab50359878ed CPU threads: 8; OS: Linux 5.0; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded There is no other selection from Edit / Database> / Connection Type... Will attach screenshot. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128895] Hidden Columns but keep reappearing! Unlike Rows which will stay hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=128895 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 --- Comment #2 from m.a.riosv --- Please attach a sample file and detail the steps to reproduce the issue. And copy the information on Menu/Help/About LibreOffice. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/core/opencl/formulagroupcl.cxx | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 6636712f5d7929aaffec96736d1f45dd9a402bdc
Author: Andrea Gelmini
AuthorDate: Fri Nov 22 21:16:54 2019 +0100
Commit: Julien Nabet
CommitDate: Fri Nov 22 22:31:10 2019 +0100
Fix typo
Change-Id: Ibf2e90ff53f201d7b1f279c11eb8238eb403c05e
Reviewed-on: https://gerrit.libreoffice.org/83533
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/sc/source/core/opencl/formulagroupcl.cxx
b/sc/source/core/opencl/formulagroupcl.cxx
index 12eb62bbe1eb..233ebaea14a3 100644
--- a/sc/source/core/opencl/formulagroupcl.cxx
+++ b/sc/source/core/opencl/formulagroupcl.cxx
@@ -1626,7 +1626,7 @@ public:
// set work group size and execute
size_t global_work_size[] = { 256, static_cast(w) };
size_t const local_work_size[] = { 256, 1 };
-SAL_INFO("sc.opencl", "Enqueing kernel " << redKernel);
+SAL_INFO("sc.opencl", "Enqueuing kernel " << redKernel);
err = clEnqueueNDRangeKernel(kEnv.mpkCmdQueue, redKernel, 2, nullptr,
global_work_size, local_work_size, 0, nullptr, nullptr);
if (CL_SUCCESS != err)
@@ -1684,7 +1684,7 @@ public:
// set work group size and execute
size_t global_work_size1[] = { 256, static_cast(w) };
size_t const local_work_size1[] = { 256, 1 };
-SAL_INFO("sc.opencl", "Enqueing kernel " << redKernel);
+SAL_INFO("sc.opencl", "Enqueuing kernel " << redKernel);
err = clEnqueueNDRangeKernel(kEnv.mpkCmdQueue, redKernel, 2,
nullptr,
global_work_size1, local_work_size1, 0, nullptr, nullptr);
if (CL_SUCCESS != err)
@@ -2398,7 +2398,7 @@ public:
// set work group size and execute
size_t global_work_size[] = { 256,
static_cast(nVectorWidth) };
size_t const local_work_size[] = { 256, 1 };
-SAL_INFO("sc.opencl", "Enqueing kernel " << redKernel);
+SAL_INFO("sc.opencl", "Enqueuing kernel " << redKernel);
err = clEnqueueNDRangeKernel(kEnv.mpkCmdQueue, redKernel, 2,
nullptr,
global_work_size, local_work_size, 0, nullptr, nullptr);
if (CL_SUCCESS != err)
@@ -2481,7 +2481,7 @@ public:
// set work group size and execute
size_t global_work_size[] = { 256,
static_cast(nVectorWidth) };
size_t const local_work_size[] = { 256, 1 };
-SAL_INFO("sc.opencl", "Enqueing kernel " << redKernel);
+SAL_INFO("sc.opencl", "Enqueuing kernel " << redKernel);
err = clEnqueueNDRangeKernel(kEnv.mpkCmdQueue, redKernel, 2,
nullptr,
global_work_size, local_work_size, 0, nullptr, nullptr);
if (CL_SUCCESS != err)
@@ -4083,7 +4083,7 @@ void DynamicKernel::Launch( size_t nr )
// The rest of buffers
mSyms.Marshal(mpKernel, nr, mpProgram);
size_t global_work_size[] = { nr };
-SAL_INFO("sc.opencl", "Enqueing kernel " << mpKernel);
+SAL_INFO("sc.opencl", "Enqueuing kernel " << mpKernel);
err = clEnqueueNDRangeKernel(kEnv.mpkCmdQueue, mpKernel, 1, nullptr,
global_work_size, nullptr, 0, nullptr, nullptr);
if (CL_SUCCESS != err)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128916] FORMATTING: Several issues regarding indents in numbered chapter headings in a Table of Contents (TOC)
https://bugs.documentfoundation.org/show_bug.cgi?id=128916 --- Comment #2 from Timur --- Please search for existing ToC bugs. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128940] Bad layout of Remote Files / Add Service button on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=128940 Caolán McNamara changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | Status|NEW |ASSIGNED --- Comment #5 from Caolán McNamara --- This was the one and only MenuButton used in 472 dialog has its own little non-standard dual-mode behavior, the idea was to use a toolbar which "naturally" supported the kind of split concept. I presume the color and background color widgets in e.g. the writer toolbar have a drop down arrow area of equal size ? Maybe the easiest thing here would be to make it a normal MenuButton in the first place rather than some dual-mode thing. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128939] Libo does not start in Fedora
https://bugs.documentfoundation.org/show_bug.cgi?id=128939 Timur changed: What|Removed |Added Severity|normal |critical Summary|Libo does not start |Libo does not start in ||Fedora -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128949] After the update from 6.2.7 to 6.3.3 the bibliography entries are missing (entries from the document)
https://bugs.documentfoundation.org/show_bug.cgi?id=128949 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||8845 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128845] EDITING: cannot modify a bibliography entry after creating it
https://bugs.documentfoundation.org/show_bug.cgi?id=128845 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||8949 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sc/qa svl/qa tools/qa tools/source ucb/Library_ucpfile1.mk ucb/source
sc/qa/unit/subsequent_export-test.cxx | 10 --
svl/qa/unit/test_URIHelper.cxx|5 +
tools/qa/cppunit/test_urlobj.cxx | 34 +-
tools/source/fsys/urlobj.cxx | 11 +++
ucb/Library_ucpfile1.mk |1 -
ucb/source/ucp/file/prov.cxx | 19 ---
6 files changed, 53 insertions(+), 27 deletions(-)
New commits:
commit 4b951ba18019b3c5daeb692d812b4b98fc2029e4
Author: Stephan Bergmann
AuthorDate: Thu Nov 21 17:52:01 2019 +0100
Commit: Caolán McNamara
CommitDate: Fri Nov 22 21:29:44 2019 +0100
tdf#128598: Revert "Move dubious file: -> smb: conversion from...
INetURLObject to file UCP"
It turns out that there is lots of code in and around e.g.
SfxMedium::LockOrigFileOnDemand (sfx2/source/doc/docfile.cxx) that treats
document URLs non-generically and treats file URLs specially. That means
that
it does not work to transparently rewrite a file URL as an smb URL in the
underlying UCB layer. So for libreoffice-6-4 revert the change again. (For
master towards LO 6.5, I plan to instead completely drop the feature of
silently
treating certain forms of file URLs on Linux as smb URLs.)
This reverts commit 46c645bf4e9909f5296e75028f1f5434e83942d2.
Change-Id: I94ac0637115bea36924099951efd8542854a727d
Reviewed-on: https://gerrit.libreoffice.org/83396
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
Reviewed-on: https://gerrit.libreoffice.org/83411
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/qa/unit/subsequent_export-test.cxx
b/sc/qa/unit/subsequent_export-test.cxx
index e8d4978259b4..35ccd32d0fe1 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -4189,12 +4189,18 @@ void ScExportTest::testTdf118990()
// file:///share/lookupsource.xlsx - which is incorrect, since it points
to local filesystem
// and not to Windows network share.
+#if defined LINUX // following INetURLObject::setAbsURIRef
+#define TDF118990_SCHEME "smb:"
+#else // for Windows and macOS
+#define TDF118990_SCHEME "file:"
+#endif
+
ASSERT_FORMULA_EQUAL(rDoc, ScAddress(0, 1, 0),
-
"VLOOKUP(B1,'file://192.168.1.1/share/lookupsource.xlsx'#$Sheet1.A1:B5,2)",
+ "VLOOKUP(B1,'" TDF118990_SCHEME
"//192.168.1.1/share/lookupsource.xlsx'#$Sheet1.A1:B5,2)",
"Wrong Windows share (using host IP) URL in A2");
ASSERT_FORMULA_EQUAL(rDoc, ScAddress(0, 2, 0),
-
"VLOOKUP(B1,'file://NETWORKHOST/share/lookupsource.xlsx'#$Sheet1.A1:B5,2)",
+ "VLOOKUP(B1,'" TDF118990_SCHEME
"//NETWORKHOST/share/lookupsource.xlsx'#$Sheet1.A1:B5,2)",
"Wrong Windows share (using hostname) URL in A3");
xDocSh->DoClose();
diff --git a/svl/qa/unit/test_URIHelper.cxx b/svl/qa/unit/test_URIHelper.cxx
index a30de1540af9..233b812a54c7 100644
--- a/svl/qa/unit/test_URIHelper.cxx
+++ b/svl/qa/unit/test_URIHelper.cxx
@@ -300,7 +300,12 @@ void Test::testFindFirstURLInText() {
"ftp://bla.bla.bla/blubber/;, 3, 29 },
{ "..\\ftp://bla.bla.bla/blubber/...;, nullptr, 0, 0 },
{ "..\\ftp:bla.bla.bla\\blubber/...",
+//Sync with tools/source/fsys/urlobj.cxx and changeScheme
+#ifdef LINUX
+ "smb://bla.bla.bla/blubber%2F", 7, 29 },
+#else
"file://bla.bla.bla/blubber%2F", 7, 29 },
+#endif
{ "http://sun.com;, "http://sun.com/;, 0, 14 },
{ "http://sun.com/;, "http://sun.com/;, 0, 15 },
{ "http://www.xerox@www.pcworld.com/go/3990332.htm;, nullptr, 0, 0
},
diff --git a/tools/qa/cppunit/test_urlobj.cxx b/tools/qa/cppunit/test_urlobj.cxx
index 2c391fbf513d..581a19478e67 100644
--- a/tools/qa/cppunit/test_urlobj.cxx
+++ b/tools/qa/cppunit/test_urlobj.cxx
@@ -49,7 +49,11 @@ namespace tools_urlobj
void urlobjTest_001( )
{
INetURLObject aUrl( OUString(
"file://10.10.1.1/sampledir/sample.file" ) );
-CPPUNIT_ASSERT_EQUAL(INetProtocol::File, aUrl.GetProtocol());
+#ifdef LINUX
+
CPPUNIT_ASSERT_EQUAL(OUString("smb://10.10.1.1/sampledir/sample.file"),
+
aUrl.GetMainURL(INetURLObject::DecodeMechanism::NONE));
+CPPUNIT_ASSERT_EQUAL(INetProtocol::Smb, aUrl.GetProtocol());
+#endif
CPPUNIT_ASSERT_EQUAL(OUString("10.10.1.1"),
aUrl.GetHost(INetURLObject::DecodeMechanism::NONE));
CPPUNIT_ASSERT_EQUAL(OUString("/sampledir/sample.file"),
@@ -66,7 +70,11 @@ namespace tools_urlobj
aUrl.
setFSysPath( "137.65.170.24\\c$\\Img0001.jpg",
FSysStyle::Detect );
-CPPUNIT_ASSERT_EQUAL(INetProtocol::File, aUrl.GetProtocol());
+#ifdef LINUX
+
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - solenv/flatpak-manifest.in
solenv/flatpak-manifest.in |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 3b8c91900c41c0f35476c7d672815e59d6811e66
Author: Stephan Bergmann
AuthorDate: Fri Nov 22 17:23:32 2019 +0100
Commit: Caolán McNamara
CommitDate: Fri Nov 22 21:30:05 2019 +0100
Adapt solenv/flatpak-manifest.in to 28e52c49452320ac76489d0f93ca5692456e5331
..."poppler: upgrade to release 0.82.0"
Change-Id: Ic333e22856e8ace114776b93b339e7c4e8de01ff
Reviewed-on: https://gerrit.libreoffice.org/83521
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
(cherry picked from commit 0d63a1e27233f815a16d90b20b6b10069c3e92dc)
Reviewed-on: https://gerrit.libreoffice.org/83532
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/solenv/flatpak-manifest.in b/solenv/flatpak-manifest.in
index 98e66c931716..a22d5f578b0a 100644
--- a/solenv/flatpak-manifest.in
+++ b/solenv/flatpak-manifest.in
@@ -375,10 +375,10 @@
"dest-filename": "external/tarballs/liborcus-0.14.1.tar.gz"
},
{
-"url":
"https://dev-www.libreoffice.org/src/poppler-0.74.0.tar.xz;,
-"sha256":
"92e09fd3302567fd36146b36bb707db43ce436e8841219025a82ea9fb0076b2f",
+"url":
"https://dev-www.libreoffice.org/src/poppler-0.82.0.tar.xz;,
+"sha256":
"234f8e573ea57fb6a008e7c1e56bfae1af5d1adf0e65f47555e1ae103874e4df",
"type": "file",
-"dest-filename": "external/tarballs/poppler-0.74.0.tar.xz"
+"dest-filename": "external/tarballs/poppler-0.82.0.tar.xz"
},
{
"url":
"https://dev-www.libreoffice.org/src/postgresql-9.2.24.tar.bz2;,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - vcl/unx
vcl/unx/gtk3/gtk3gtkinst.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ab15169b523a3d84b09a7b3177473efc3e8cca05 Author: Caolán McNamara AuthorDate: Fri Nov 22 16:08:42 2019 + Commit: Caolán McNamara CommitDate: Fri Nov 22 21:29:00 2019 +0100 wrong delete signal id Change-Id: I4aecd3c8f5d40c3256d2d2816a79f8809db6cedb Reviewed-on: https://gerrit.libreoffice.org/83519 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx index 064322e9cae9..9238651b44ef 100644 --- a/vcl/unx/gtk3/gtk3gtkinst.cxx +++ b/vcl/unx/gtk3/gtk3gtkinst.cxx @@ -6170,7 +6170,7 @@ void GtkInstanceDialog::asyncresponse(gint ret) g_signal_handler_disconnect(m_pDialog, nResponseSignalId); if (nCancelSignalId) g_signal_handler_disconnect(m_pDialog, nCancelSignalId); -if (m_nSignalDeleteId) +if (nSignalDeleteId) g_signal_handler_disconnect(m_pDialog, nSignalDeleteId); xDialogController.reset(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtk3gtkinst.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 515e4323b33bd72d82140f2b64383bd9aa1719e5 Author: Caolán McNamara AuthorDate: Fri Nov 22 16:08:42 2019 + Commit: Caolán McNamara CommitDate: Fri Nov 22 21:28:51 2019 +0100 wrong delete signal id Change-Id: I4aecd3c8f5d40c3256d2d2816a79f8809db6cedb Reviewed-on: https://gerrit.libreoffice.org/83518 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx index 8b944e23432b..ffbf5e11446d 100644 --- a/vcl/unx/gtk3/gtk3gtkinst.cxx +++ b/vcl/unx/gtk3/gtk3gtkinst.cxx @@ -6195,7 +6195,7 @@ void GtkInstanceDialog::asyncresponse(gint ret) g_signal_handler_disconnect(m_pDialog, nResponseSignalId); if (nCancelSignalId) g_signal_handler_disconnect(m_pDialog, nCancelSignalId); -if (m_nSignalDeleteId) +if (nSignalDeleteId) g_signal_handler_disconnect(m_pDialog, nSignalDeleteId); xDialogController.reset(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128970] Can not open LO in Mac
https://bugs.documentfoundation.org/show_bug.cgi?id=128970 Timur changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #2 from Timur --- Please see if a duplicate of https://bugs.documentfoundation.org/show_bug.cgi?id=93331 and use Vanilla. And search before opening a bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: oox/source sd/qa
oox/source/export/drawingml.cxx |2 +-
sd/qa/unit/data/pptx/tdf128952.pptx |binary
sd/qa/unit/export-tests-ooxml1.cxx | 17 +
3 files changed, 18 insertions(+), 1 deletion(-)
New commits:
commit aca2e4d270f472b2cbdb9084a55f1855529ea705
Author: Gülşah Köse
AuthorDate: Fri Nov 22 14:05:24 2019 +0300
Commit: Gülşah Köse
CommitDate: Fri Nov 22 21:16:22 2019 +0100
tdf#128952 Set the position of shape for 180 deg.
If the rotation value is 180, 540, 900... degree with mirror
pShape->GetRotateAngle() returns 0. In that control 0 means
no rotation but that is not true. For that cases (180, 540, 900)
after the angle conversition GetRotateAngle() returns 0. We should
recalculate the position for 0 too.
Change-Id: I14e981235b2d6cd8382d4c9e151bccd2e73a3fd9
Reviewed-on: https://gerrit.libreoffice.org/83468
Tested-by: Jenkins
Reviewed-by: Gülşah Köse
diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index 5dc696259649..3585fbda6c12 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -1647,7 +1647,7 @@ void DrawingML::WriteShapeTransformation( const
Reference< XShape >& rXShape, sa
{
SdrObject* pShape = GetSdrObjectFromXShape( rXShape );
nRotation = pShape ? pShape->GetRotateAngle() : 0;
-if ( nRotation != 0 && GetDocumentType() != DOCUMENT_DOCX )
+if ( GetDocumentType() != DOCUMENT_DOCX )
{
int faccos=bFlipV ? -1 : 1;
int facsin=bFlipH ? -1 : 1;
diff --git a/sd/qa/unit/data/pptx/tdf128952.pptx
b/sd/qa/unit/data/pptx/tdf128952.pptx
new file mode 100644
index ..242a3ee9ace5
Binary files /dev/null and b/sd/qa/unit/data/pptx/tdf128952.pptx differ
diff --git a/sd/qa/unit/export-tests-ooxml1.cxx
b/sd/qa/unit/export-tests-ooxml1.cxx
index 05d7d3aff31b..ddc41b563c99 100644
--- a/sd/qa/unit/export-tests-ooxml1.cxx
+++ b/sd/qa/unit/export-tests-ooxml1.cxx
@@ -80,6 +80,7 @@ public:
void testParaMarginAndindentation();
void testTdf111884();
void testTdf112633();
+void testTdf128952();
void testCustomXml();
void testTdf94238();
void testPictureTransparency();
@@ -116,6 +117,7 @@ public:
CPPUNIT_TEST(testParaMarginAndindentation);
CPPUNIT_TEST(testTdf111884);
CPPUNIT_TEST(testTdf112633);
+CPPUNIT_TEST(testTdf128952);
CPPUNIT_TEST(testCustomXml);
CPPUNIT_TEST(testTdf94238);
CPPUNIT_TEST(testTdf125554);
@@ -812,6 +814,21 @@ void SdOOXMLExportTest1::testTdf112633()
CPPUNIT_ASSERT_EQUAL(true,
bool(xNameAccess->hasByName("ppt/media/hdphoto1.wdp")));
}
+void SdOOXMLExportTest1::testTdf128952()
+{
+::sd::DrawDocShellRef xDocShRef =
loadURL(m_directories.getURLFromSrc("sd/qa/unit/data/pptx/tdf128952.pptx"),
PPTX);
+utl::TempFile tempFile;
+xDocShRef = saveAndReload(xDocShRef.get(), PPTX, );
+xDocShRef->DoClose();
+
+xmlDocPtr pXmlDoc = parseExport(tempFile, "ppt/slides/slide1.xml");
+
+assertXPath(pXmlDoc, "/p:sld/p:cSld/p:spTree/p:sp/p:spPr/a:xfrm/a:off",
"x", "360");
+assertXPath(pXmlDoc, "/p:sld/p:cSld/p:spTree/p:sp/p:spPr/a:xfrm/a:off",
"y", "-360");
+assertXPath(pXmlDoc, "/p:sld/p:cSld/p:spTree/p:sp/p:spPr/a:xfrm/a:ext",
"cx", "1919880");
+assertXPath(pXmlDoc, "/p:sld/p:cSld/p:spTree/p:sp/p:spPr/a:xfrm/a:ext",
"cy", "1462680");
+}
+
void SdOOXMLExportTest1::testCustomXml()
{
// Load document and export it to a temporary file
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128970] Can not open LO in Mac
https://bugs.documentfoundation.org/show_bug.cgi?id=128970 Timur changed: What|Removed |Added Summary|Can not open|Can not open LO in Mac -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128522] path is not an absolute uRL...: misleading diagnostic
https://bugs.documentfoundation.org/show_bug.cgi?id=128522 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||8969 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128969] File is not an absolute URL that can be passed to an external application to open it
https://bugs.documentfoundation.org/show_bug.cgi?id=128969 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||8522 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121740] PPT (1, 2 MB) with Equation 3.0 objects is slow to load (was better with OO and previous LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=121740 --- Comment #21 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/90ea305110e5881256ba272800074a2a9f6b613d tdf#121740 cache font data to speed up PPT load It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - chart2/source include/oox include/sfx2 include/svx include/vcl include/xmloff include/xmlscript oox/inc pyuno/inc reportdesign/inc sc/inc sc/source sd/inc s
chart2/source/inc/OPropertySet.hxx |2 include/oox/crypto/CryptTools.hxx |4 - include/oox/crypto/DocumentDecryption.hxx |2 include/oox/crypto/DocumentEncryption.hxx |2 include/oox/helper/binaryoutputstream.hxx |4 - include/oox/helper/binarystreambase.hxx|2 include/oox/ole/vbaproject.hxx |2 include/oox/vml/vmlformatting.hxx |2 include/oox/vml/vmlshape.hxx |2 include/sfx2/DocumentMetadataAccess.hxx|2 include/sfx2/recentdocsview.hxx|2 include/sfx2/sidebar/ControlFactory.hxx|2 include/sfx2/sidebar/ControllerFactory.hxx |2 include/sfx2/sidebar/Tools.hxx |2 include/svx/ClassificationEditView.hxx |2 include/svx/ColorSets.hxx |2 include/svx/CommonStylePreviewRenderer.hxx |2 include/svx/ParaSpacingControl.hxx |4 - include/svx/dbcharsethelper.hxx|2 include/svx/dialcontrol.hxx|2 include/svx/legacyitem.hxx | 18 ++--- include/svx/nbdtmg.hxx |6 - include/svx/sdr/contact/viewcontactofpageobj.hxx |2 include/svx/sdr/contact/viewobjectcontactofpageobj.hxx |2 include/svx/sdr/overlay/overlayobjectcell.hxx |2 include/svx/sdr/overlay/overlaytriangle.hxx|2 include/svx/sidebar/SidebarDialControl.hxx |2 include/svx/svdotable.hxx |2 include/svx/tbxcolorupdate.hxx |2 include/vcl/font/Feature.hxx |4 - include/vcl/imagerepository.hxx|2 include/vcl/mnemonicengine.hxx |2 include/vcl/ppdparser.hxx |6 - include/xmloff/fasttokenhandler.hxx|2 include/xmlscript/xml_helper.hxx |2 oox/inc/drawingml/fillproperties.hxx |2 oox/inc/drawingml/lineproperties.hxx |2 pyuno/inc/pyuno.hxx|2 reportdesign/inc/UndoActions.hxx | 16 ++--- sc/inc/NumberFormatControl.hxx |2 sc/inc/formulagroup.hxx|2 sc/inc/scopetools.hxx |6 - sc/inc/sortparam.hxx |2 sc/source/ui/inc/datatransformation.hxx|2 sd/inc/helper/simplereferencecomponent.hxx |4 - sd/inc/undo/undomanager.hxx|2 sd/source/ui/inc/TemplateScanner.hxx |3 sd/source/ui/inc/WindowUpdater.hxx |5 - sd/source/ui/inc/drawview.hxx |2 svtools/inc/table/tablecontrol.hxx | 18 ++--- svx/inc/sdr/contact/viewobjectcontactofe3dscene.hxx|2 svx/inc/sdr/contact/viewobjectcontactofgroup.hxx |2 svx/inc/sdr/contact/viewobjectcontactofsdrpage.hxx | 22 +++ svx/inc/sdr/overlay/overlayhandle.hxx |2 svx/source/inc/formtoolbars.hxx|2 sw/inc/calbck.hxx |4 - sw/inc/frmfmt.hxx | 18 ++--- sw/inc/legacyitem.hxx |6 - vcl/inc/BitmapScaleConvolutionFilter.hxx |2 vcl/inc/font/OpenTypeFeatureDefinitonList.hxx |2 vcl/inc/fontinstance.hxx |1 vcl/inc/headless/CustomWidgetDraw.hxx |2 vcl/inc/unx/printergfx.hxx |4 - vcl/inc/unx/wmadaptor.hxx |2 vcl/inc/widgetdraw/WidgetDefinition.hxx|2 vcl/inc/win/winlayout.hxx |1 vcl/win/gdi/winlayout.cxx | 53 +++-- 67 files changed, 171 insertions(+), 128 deletions(-) New commits: commit 90ea305110e5881256ba272800074a2a9f6b613d Author: Noel Grandin AuthorDate: Fri Nov 22 13:32:17 2019 +0200 Commit: Noel Grandin CommitDate: Fri Nov 22 20:31:37 2019 +0100 tdf#121740 cache font data to speed up PPT load takes the load time from 24s to 21s for me. The cache was determined experimentally for this document. Change-Id: I34c78d1ff99cb8e72b274a201ded61d23e66941a Reviewed-on: https://gerrit.libreoffice.org/83470 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/vcl/inc/fontinstance.hxx
[Libreoffice-bugs] [Bug 121740] PPT (1, 2 MB) with Equation 3.0 objects is slow to load (was better with OO and previous LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=121740 Commit Notification changed: What|Removed |Added Whiteboard|target:6.4.0 target:6.3.0.2 |target:6.4.0 target:6.3.0.2 ||target:6.5.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa
sw/qa/uitest/writer_tests6/tdf126168.py | 52
1 file changed, 52 insertions(+)
New commits:
commit f394ea0b6b58ed516977803f00c0147bb0facc25
Author: Zdeněk Crhonek
AuthorDate: Fri Nov 22 18:51:43 2019 +0100
Commit: Zdenek Crhonek
CommitDate: Fri Nov 22 20:12:13 2019 +0100
uitest for bug tdf#126168
Change-Id: I35b7235b7f53789d781a567efe15f13be16f7193
Reviewed-on: https://gerrit.libreoffice.org/83530
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek
diff --git a/sw/qa/uitest/writer_tests6/tdf126168.py
b/sw/qa/uitest/writer_tests6/tdf126168.py
new file mode 100644
index ..d25ae711e49d
--- /dev/null
+++ b/sw/qa/uitest/writer_tests6/tdf126168.py
@@ -0,0 +1,52 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+from uitest.framework import UITestCase
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.uihelper.common import get_state_as_dict, type_text
+from uitest.uihelper.common import select_pos
+import time
+from uitest.debug import sleep
+#Bug 126168 - Crash in: rtl_uString_acquire: frame style undo redo
+
+class tdf126168(UITestCase):
+
+ def test_tdf126168_frame_undo_redo_crash(self):
+self.ui_test.create_doc_in_start_center("writer")
+document = self.ui_test.get_component()
+xWriterDoc = self.xUITest.getTopFocusWindow()
+xWriterEdit = xWriterDoc.getChild("writer_edit")
+
+#2) Menu > Insert > Frame > Frame
+#3) Press OK in Frame dialog
+self.ui_test.execute_dialog_through_command(".uno:InsertFrame") #
insert frame
+xDialog = self.xUITest.getTopFocusWindow()
+xokbtn = xDialog.getChild("ok")
+self.ui_test.close_dialog_through_button(xokbtn)
+self.assertEqual(document.TextFrames.getCount(), 1)
+#New Style from Selection [uno:StyleNewByExample]
+self.ui_test.execute_dialog_through_command(".uno:StyleNewByExample")
+#5) Enter a name in the Create Style dialog and press OK
+xDialog = self.xUITest.getTopFocusWindow()
+stylename = xDialog.getChild("stylename")
+stylename.executeAction("TYPE", mkPropertyValues({"TEXT":"a"}))
+xokbtn = xDialog.getChild("ok")
+self.ui_test.close_dialog_through_button(xokbtn)
+#6) ctrl+z 3 times
+self.xUITest.executeCommand(".uno:Undo")
+self.xUITest.executeCommand(".uno:Undo")
+self.xUITest.executeCommand(".uno:Undo")
+self.assertEqual(document.TextFrames.getCount(), 0)
+#7) shift+ctrl+z 3 times
+self.xUITest.executeCommand(".uno:Redo")
+self.xUITest.executeCommand(".uno:Redo")
+self.xUITest.executeCommand(".uno:Redo")
+
+#Results: crash
+self.assertEqual(document.CurrentController.PageCount, 1)
+
+self.ui_test.close_doc()
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128940] Bad layout of Remote Files / Add Service button on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=128940 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Keywords||bibisectRequest, regression CC||79045_79...@mail.ru, ||caol...@redhat.com --- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> --- confirm in Version: 6.5.0.0.alpha0+ Build ID: d04eef858250f97690f32dba17f42d157a8767fc CPU threads: 4; OS: Mac OS X 10.15.1; UI render: default; VCL: osx; Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US Calc: threaded Caolan, may be you'll can look at it? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128958] No tags in macos when saving as .odt
https://bugs.documentfoundation.org/show_bug.cgi?id=128958 --- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> --- Created attachment 156050 --> https://bugs.documentfoundation.org/attachment.cgi?id=156050=edit Screenshot from Finder -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128958] No tags in macos when saving as .odt
https://bugs.documentfoundation.org/show_bug.cgi?id=128958 --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- don't repro in Version: 6.5.0.0.alpha0+ Build ID: d04eef858250f97690f32dba17f42d157a8767fc CPU threads: 4; OS: Mac OS X 10.15.1; UI render: default; VCL: osx; Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US Calc: threaded I can add any tags to ODT file when I save it -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
