[Libreoffice-bugs] [Bug 128595] Document difference for words and characters and spaces when copying and pasting text
https://bugs.documentfoundation.org/show_bug.cgi?id=128595 --- Comment #20 from contest...@aol.com --- I don't know what you mean by "use case." I copy text so that I don't have to retype it and re-establish its characteristics such as font, size, bold, italic or special characters. It is often much faster to copy the text than to scroll through the dropdown list of fonts. It is not reasonable to send you my entire document, which is now around 115 pages, so I have isolated the problems for you and sent you examples, with explanations of how I got the results. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121543] Selected sell deleted in assistant
https://bugs.documentfoundation.org/show_bug.cgi?id=121543 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Keywords||needsUXEval CC||79045_79...@mail.ru, ||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #5 from Roman Kuznetsov <79045_79...@mail.ru> --- behavior repro in Версия: 6.5.0.0.alpha0+ (x64) ID сборки: 32dcf3f0fdafcf44457842a8aa4f54d30d856ca9 Потоков ЦП: 4; ОС:Windows 10.0 Build 17763; Отрисовка ИП: GL; VCL: win; Локаль: ru-RU (ru_RU); Язык интерфейса: ru-RU Calc: threaded I'm not sure it's a bug UX-team what do you think? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 121543] Selected sell deleted in assistant
https://bugs.documentfoundation.org/show_bug.cgi?id=121543 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Keywords||needsUXEval CC||79045_79...@mail.ru, ||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #5 from Roman Kuznetsov <79045_79...@mail.ru> --- behavior repro in Версия: 6.5.0.0.alpha0+ (x64) ID сборки: 32dcf3f0fdafcf44457842a8aa4f54d30d856ca9 Потоков ЦП: 4; ОС:Windows 10.0 Build 17763; Отрисовка ИП: GL; VCL: win; Локаль: ru-RU (ru_RU); Язык интерфейса: ru-RU Calc: threaded I'm not sure it's a bug UX-team what do you think? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 114309] FILESAVE: RTF: columns/section lost after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=114309 --- Comment #5 from Roman Kuznetsov <79045_79...@mail.ru> --- still repro in Версия: 6.5.0.0.alpha0+ (x64) ID сборки: 32dcf3f0fdafcf44457842a8aa4f54d30d856ca9 Потоков ЦП: 4; ОС:Windows 10.0 Build 17763; Отрисовка ИП: GL; VCL: win; Локаль: ru-RU (ru_RU); Язык интерфейса: ru-RU Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54021] EDITING: Fields in tablecontrols of a form could not be moved/sorted
https://bugs.documentfoundation.org/show_bug.cgi?id=54021 --- Comment #41 from Robert Großkopf --- With LO 6.3.3.2 on OpenSUSE 15.1 64bit rpm Linux the fields could be copied: Set the mouse on the column-header. Click left button of the mouse. Move the mouse - a "+" appears here. Release the left button of the mouse. The field has been "copied". Note: Only the data-connection will be copied. All formats of the original fields will be lost. So nothing has been changed for this bug. Moving of fields in a tablecontrol is still impossible. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108235] Pivot table update on undo lags a step behind
https://bugs.documentfoundation.org/show_bug.cgi?id=108235 --- Comment #6 from Roman Kuznetsov <79045_79...@mail.ru> --- still repro in Версия: 6.5.0.0.alpha0+ (x64) ID сборки: 32dcf3f0fdafcf44457842a8aa4f54d30d856ca9 Потоков ЦП: 4; ОС:Windows 10.0 Build 17763; Отрисовка ИП: GL; VCL: win; Локаль: ru-RU (ru_RU); Язык интерфейса: ru-RU Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121740] PPT (1, 2 MB) with Equation 3.0 objects is slow to load (was better with OO and previous LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=121740 --- Comment #22 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/29d2024e16ce3cb81ad7f5b5f7e1b93378a93199 tdf#121740 cache font data to speed up PPT load It will be available in 6.4.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121740] PPT (1, 2 MB) with Equation 3.0 objects is slow to load (was better with OO and previous LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=121740 Commit Notification changed: What|Removed |Added Whiteboard|target:6.4.0 target:6.3.0.2 |target:6.4.0 target:6.3.0.2 |target:6.5.0|target:6.5.0 target:6.4.0.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - vcl/inc vcl/win
vcl/inc/fontinstance.hxx |1
vcl/inc/win/winlayout.hxx |1
vcl/win/gdi/winlayout.cxx | 53 +-
3 files changed, 50 insertions(+), 5 deletions(-)
New commits:
commit 29d2024e16ce3cb81ad7f5b5f7e1b93378a93199
Author: Noel Grandin
AuthorDate: Fri Nov 22 13:32:17 2019 +0200
Commit: Noel Grandin
CommitDate: Sun Nov 24 08:44:51 2019 +0100
tdf#121740 cache font data to speed up PPT load
takes the load time from 24s to 21s for me.
The cache was determined experimentally for this document.
Change-Id: I34c78d1ff99cb8e72b274a201ded61d23e66941a
Reviewed-on: https://gerrit.libreoffice.org/83470
Tested-by: Jenkins
Reviewed-by: Noel Grandin
(cherry picked from commit 90ea305110e5881256ba272800074a2a9f6b613d)
Reviewed-on: https://gerrit.libreoffice.org/83542
diff --git a/vcl/inc/fontinstance.hxx b/vcl/inc/fontinstance.hxx
index ed4d92e8ef57..b4d7da663090 100644
--- a/vcl/inc/fontinstance.hxx
+++ b/vcl/inc/fontinstance.hxx
@@ -71,6 +71,7 @@ public: // TODO: make data members private
const FontSelectPattern& GetFontSelectPattern() const { return
m_aFontSelData; }
const PhysicalFontFace* GetFontFace() const { return m_pFontFace.get(); }
+PhysicalFontFace* GetFontFace() { return m_pFontFace.get(); }
const ImplFontCache* GetFontCache() const { return mpFontCache; }
bool GetGlyphBoundRect(sal_GlyphId, tools::Rectangle&, bool) const;
diff --git a/vcl/inc/win/winlayout.hxx b/vcl/inc/win/winlayout.hxx
index 991c68f15b66..035998e2bcd9 100644
--- a/vcl/inc/win/winlayout.hxx
+++ b/vcl/inc/win/winlayout.hxx
@@ -164,6 +164,7 @@ public:
void SetHFONT(HFONT hFont) { m_hFont = hFont; }
const WinFontFace * GetFontFace() const { return static_cast(LogicalFontInstance::GetFontFace()); }
+WinFontFace * GetFontFace() { return static_cast(LogicalFontInstance::GetFontFace()); }
bool CacheGlyphToAtlas(HDC hDC, HFONT hFont, int nGlyphIndex, SalGraphics&
rGraphics, const GenericSalLayout& rLayout);
OpenGLGlyphCache& GetOpenGLGlyphCache() { return maOpenGLGlyphCache; }
diff --git a/vcl/win/gdi/winlayout.cxx b/vcl/win/gdi/winlayout.cxx
index b67f191c0b47..9f4da1950245 100644
--- a/vcl/win/gdi/winlayout.cxx
+++ b/vcl/win/gdi/winlayout.cxx
@@ -1,3 +1,4 @@
+
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
@@ -44,6 +45,7 @@
#include
+#include
#include
#include
@@ -327,16 +329,53 @@ float WinFontInstance::getHScale() const
return nWidth / nHeight;
}
+struct BlobReference
+{
+hb_blob_t* mpBlob;
+BlobReference(hb_blob_t* pBlob) : mpBlob(pBlob)
+{
+hb_blob_reference(mpBlob);
+}
+BlobReference(BlobReference const & other)
+: mpBlob(other.mpBlob)
+{
+hb_blob_reference(mpBlob);
+}
+~BlobReference() { hb_blob_destroy(mpBlob); }
+};
+using BlobCacheKey = std::pair, hb_tag_t>;
+struct BlobCacheKeyHash
+{
+std::size_t operator()(BlobCacheKey const& rKey) const
+{
+std::size_t seed = 0;
+boost::hash_combine(seed, rKey.first.get());
+boost::hash_combine(seed, rKey.second);
+return seed;
+}
+};
+
static hb_blob_t* getFontTable(hb_face_t* /*face*/, hb_tag_t nTableTag, void*
pUserData)
{
-sal_uLong nLength = 0;
-unsigned char* pBuffer = nullptr;
+static o3tl::lru_map
gCache(50);
+
WinFontInstance* pFont = static_cast(pUserData);
HDC hDC = pFont->GetGraphics()->getHDC();
HFONT hFont = pFont->GetHFONT();
assert(hDC);
assert(hFont);
+BlobCacheKey cacheKey {
rtl::Reference(pFont->GetFontFace()), nTableTag };
+auto it = gCache.find(cacheKey);
+if (it != gCache.end())
+{
+hb_blob_reference(it->second.mpBlob);
+return it->second.mpBlob;
+}
+
+sal_uLong nLength = 0;
+unsigned char* pBuffer = nullptr;
+
HGDIOBJ hOrigFont = SelectObject(hDC, hFont);
nLength = ::GetFontData(hDC, OSL_NETDWORD(nTableTag), 0, nullptr, 0);
if (nLength > 0 && nLength != GDI_ERROR)
@@ -346,10 +385,14 @@ static hb_blob_t* getFontTable(hb_face_t* /*face*/,
hb_tag_t nTableTag, void* pU
}
SelectObject(hDC, hOrigFont);
-hb_blob_t* pBlob = nullptr;
-if (pBuffer != nullptr)
-pBlob = hb_blob_create(reinterpret_cast(pBuffer),
nLength, HB_MEMORY_MODE_READONLY,
+if (!pBuffer)
+return nullptr;
+
+hb_blob_t* pBlob = hb_blob_create(reinterpret_cast(pBuffer),
nLength, HB_MEMORY_MODE_READONLY,
pBuffer, [](void* data){ delete[]
static_cast(data); });
+if (!pBlob)
+return pBlob;
+gCache.insert({cacheKey, BlobReference(pBlob)});
return pBlob;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 100920] FILEOPEN DOCX Text box position (absolute position right to column and below paragraph) wrong in LO (left to paragraph and top to margin)
https://bugs.documentfoundation.org/show_bug.cgi?id=100920 --- Comment #9 from Timur --- Created attachment 156070 --> https://bugs.documentfoundation.org/attachment.cgi?id=156070=edit Sample compared in MSO and LO Repro Lo 6.5+. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125286] FIREBIRD - Base not usable under Windows account with Chinese user name (UTF character support)
https://bugs.documentfoundation.org/show_bug.cgi?id=125286 --- Comment #6 from Ming Hua --- Both problems are still reproducible in 6.4.0 beta1. Version: 6.4.0.0.beta1 (x64) Build ID: 4d7e5b0c40ed843384704eca3ce21981d4e98920 CPU threads: 2; OS: Windows 10.0 Build 18363; UI render: default; VCL: win; Locale: zh-CN (zh_CN); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128868] In LibreOffice Impress Console view, clicking on the scroll bar or control buttons advances the slide
https://bugs.documentfoundation.org/show_bug.cgi?id=128868 --- Comment #6 from Timur --- Daily master is at https://dev-builds.libreoffice.org/daily/master/. It will not interfere with working LO. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128522] path is not an absolute uRL...: misleading diagnostic
https://bugs.documentfoundation.org/show_bug.cgi?id=128522 Timur changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #5 from Timur --- Please don't assume that someone will guess what you meant, and explain steps, experienced and expected results. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128969] File is not an absolute URL that can be passed to an external application to open it
https://bugs.documentfoundation.org/show_bug.cgi?id=128969 Timur changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #2 from Timur --- 'Save URL relative to File system' checked by default. But regardless, even if I uncheck, the same message. I don't see "relative" working. This might also be https://bugs.documentfoundation.org/show_bug.cgi?id=125607#c2. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: bin/update
bin/update/create_partial_update.py |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 4dc85b98d7d84ac0d50f6f64833b667fb48236c7
Author: Jens Carl
AuthorDate: Sun Nov 17 10:55:15 2019 -0800
Commit: Jens Carl
CommitDate: Sun Nov 24 07:41:58 2019 +0100
Fix 'is' operator for comparison
The 'is' operator should not be used for comparison on some types of
literals. In CPython this works by accident and CPython 3.8 introduced a
SyntaxWarning (see https://bugs.python.org/issue34850).
Change-Id: I5cb7470132b26d87848c2bdc382b05477eb56afb
Reviewed-on: https://gerrit.libreoffice.org/83032
Tested-by: Jenkins
Reviewed-by: Jens Carl
diff --git a/bin/update/create_partial_update.py
b/bin/update/create_partial_update.py
index 28e6cf510c42..9412bcd6e962 100755
--- a/bin/update/create_partial_update.py
+++ b/bin/update/create_partial_update.py
@@ -58,7 +58,7 @@ def download_mar_for_update_channel_and_platform(config,
platform, temp_dir):
base_url = config.server_url + "update/partial-targets/1/"
url = base_url + platform + "/" + config.channel
r = requests.get(url)
-if r.status_code is not 200:
+if r.status_code != 200:
print(r.content)
raise Exception("download failed")
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 94712] EPSIs don't print to PS or export to PDF properly
https://bugs.documentfoundation.org/show_bug.cgi?id=94712 --- Comment #14 from ted.carnev...@yale.edu --- Bug is still present, using the latest LibreOffice--6.3.3.2. Doesn't that mean that its status is "unresolved"? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125455] Content in sections disappear and formatting gets distorted after reopening the file
https://bugs.documentfoundation.org/show_bug.cgi?id=125455 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128926] PPS files will not play with Libre Office Impress 6.2.8
https://bugs.documentfoundation.org/show_bug.cgi?id=128926 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128687] Internal leading not receiving same rounding as other font metrics
https://bugs.documentfoundation.org/show_bug.cgi?id=128687 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125455] Content in sections disappear and formatting gets distorted after reopening the file
https://bugs.documentfoundation.org/show_bug.cgi?id=125455 --- Comment #8 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128522] path is not an absolute uRL...: misleading diagnostic
https://bugs.documentfoundation.org/show_bug.cgi?id=128522 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128926] PPS files will not play with Libre Office Impress 6.2.8
https://bugs.documentfoundation.org/show_bug.cgi?id=128926 --- Comment #9 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124780] PPTX Exported Impress Slide looks completely different
https://bugs.documentfoundation.org/show_bug.cgi?id=124780 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=108226 Bug 108226 depends on bug 124780, which changed state. Bug 124780 Summary: PPTX Exported Impress Slide looks completely different https://bugs.documentfoundation.org/show_bug.cgi?id=124780 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128944] LibreOffice Crash using LXQT 0.14.1
https://bugs.documentfoundation.org/show_bug.cgi?id=128944 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128944] LibreOffice Crash using LXQT 0.14.1
https://bugs.documentfoundation.org/show_bug.cgi?id=128944 --- Comment #13 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128522] path is not an absolute uRL...: misleading diagnostic
https://bugs.documentfoundation.org/show_bug.cgi?id=128522 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113820] FILEOPEN: PPTX: Bold Flash animation does nothing
https://bugs.documentfoundation.org/show_bug.cgi?id=113820 --- Comment #4 from QA Administrators --- Dear Xisco Faulí, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105373] FILEOPEN: Broken view of docx with images and floating table
https://bugs.documentfoundation.org/show_bug.cgi?id=105373 --- Comment #10 from QA Administrators --- Dear Peter, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124780] PPTX Exported Impress Slide looks completely different
https://bugs.documentfoundation.org/show_bug.cgi?id=124780 --- Comment #7 from QA Administrators --- Dear Christian, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54021] EDITING: Fields in tablecontrols of a form could not be moved/sorted
https://bugs.documentfoundation.org/show_bug.cgi?id=54021 --- Comment #40 from QA Administrators --- Dear robert, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100920] FILEOPEN DOCX Text box position (absolute position right to column and below paragraph) wrong in LO (left to paragraph and top to margin)
https://bugs.documentfoundation.org/show_bug.cgi?id=100920 --- Comment #8 from QA Administrators --- Dear Alankrit, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120405] EDITING: Clicking at 'Open' in the concordance file button in the ToC dialog vanishes the 'Edit...' command
https://bugs.documentfoundation.org/show_bug.cgi?id=120405 --- Comment #2 from QA Administrators --- Dear Thomas Lendo, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108367] XHTML Export: Some Images are missing after export
https://bugs.documentfoundation.org/show_bug.cgi?id=108367 --- Comment #10 from QA Administrators --- Dear mmaurer, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119987] FILEOPEN FILESAVE DOCX The MultiSelect property of the list box ActiveX control is incorrectly imported/exported
https://bugs.documentfoundation.org/show_bug.cgi?id=119987 --- Comment #4 from QA Administrators --- Dear Gabor Kelemen, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114309] FILESAVE: RTF: columns/section lost after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=114309 --- Comment #4 from QA Administrators --- Dear Xisco Faulí, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113821] FILEOPEN: PPTX: Bold reveal animation does nothing
https://bugs.documentfoundation.org/show_bug.cgi?id=113821 --- Comment #5 from QA Administrators --- Dear Xisco Faulí, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121636] The last angle of poly polygon line is shown as rotation angle
https://bugs.documentfoundation.org/show_bug.cgi?id=121636 --- Comment #2 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121680] On html filter import nested span with font style garbles font of following text
https://bugs.documentfoundation.org/show_bug.cgi?id=121680 --- Comment #3 from QA Administrators --- Dear aze, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99458] Interactive crop handles are covered by header drop-down button
https://bugs.documentfoundation.org/show_bug.cgi?id=99458 --- Comment #6 from QA Administrators --- Dear Stanislav Horacek, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100979] Complex Line displayed as 'single' and hiding text line below
https://bugs.documentfoundation.org/show_bug.cgi?id=100979 --- Comment #8 from QA Administrators --- Dear Alankrit, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108235] Pivot table update on undo lags a step behind
https://bugs.documentfoundation.org/show_bug.cgi?id=108235 --- Comment #5 from QA Administrators --- Dear Aron Budea, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121543] Selected sell deleted in assistant
https://bugs.documentfoundation.org/show_bug.cgi?id=121543 --- Comment #4 from QA Administrators --- Dear hug.charlo...@gmail.com, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104194] MathML not rendered by the equation edito
https://bugs.documentfoundation.org/show_bug.cgi?id=104194 --- Comment #11 from QA Administrators --- Dear Denis J. Navas, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
CppCheck Report Update
A new cppcheck report is available at : http://dev-builds.libreoffice.org/cppcheck_reports/master/ Note: The script generating this report was run at : 2019-24-11 04:19:16 with user buildslave at host vm140 as /home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s /home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w /home/buildslave/tmp/www It can be found and improved here: https://gerrit.libreoffice.org/plugins/gitiles/dev-tools/+/master/cppcheck/cppcheck-report.sh ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 128938] [NAVIGATOR] Some drawing objects don't show in Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=128938 --- Comment #3 from Aron Budea --- Confirmed in LO 6.5.0.0.alpha0+ (d273ea2a43886138be553514218c0c3ffda5900f) / Ubuntu. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128938] [NAVIGATOR] Some drawing objects don't show in Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=128938 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu Resolution|DUPLICATE |--- Ever confirmed|0 |1 Blocks||103030 Status|RESOLVED|NEW --- Comment #2 from Aron Budea --- (In reply to Rania Amina from comment #1) > *** This bug has been marked as a duplicate of bug 103216 *** This bug is about the objects not appearing in the Navigator at all, while bug 130216 is about those objects not having a rename entry in their context menu, thus this is not a duplicate. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103030 [Bug 103030] [META] Navigator sidebar deck and floating window -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window
https://bugs.documentfoundation.org/show_bug.cgi?id=103030 Aron Budea changed: What|Removed |Added Depends on||128938 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=128938 [Bug 128938] [NAVIGATOR] Some drawing objects don't show in Navigator -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window
https://bugs.documentfoundation.org/show_bug.cgi?id=103030 Bug 103030 depends on bug 128938, which changed state. Bug 128938 Summary: [NAVIGATOR] Some drawing objects don't show in Navigator https://bugs.documentfoundation.org/show_bug.cgi?id=128938 What|Removed |Added Status|RESOLVED|NEW Resolution|DUPLICATE |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101630] Google Drive two-factor authentication (2FA) not working again
https://bugs.documentfoundation.org/show_bug.cgi?id=101630 Aron Budea changed: What|Removed |Added OS|Mac OS X (All) |All Keywords|accessibility | Version|6.3.3.2 release |5.2.0.4 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: connectivity/source sd/source
connectivity/source/drivers/mysqlc/mysqlc_prepared_resultset.cxx | 12
+-
sd/source/filter/ppt/pptin.cxx |8 +++---
2 files changed, 10 insertions(+), 10 deletions(-)
New commits:
commit a81489978cb96d819044be054f7ceabc4f8eccb2
Author: Julien Nabet
AuthorDate: Sun Nov 24 00:10:42 2019 +0100
Commit: Julien Nabet
CommitDate: Sun Nov 24 00:55:44 2019 +0100
cppcheck: fix 2 funcArgOrderDifferent
1) sd/source/filter/ppt/pptin.cxx
Function 'ProcessObj' argument order different:
declaration 'rSt, rData, rClientData, rTextRect, pObj'
definition 'rSt, rObjData, rData, rTextRect, pRet'
2) connectivity/source/drivers/mysqlc/mysqlc_prepared_resultset.cxx
Function 'OPreparedResultSet' argument order different:
declaration 'rConn, pStmt, pMyStmt'
definition 'rConn, pPrepared, pStmt'
Change-Id: I83f8427ee15c3025676c39f262c2e9881cdd33ae
Reviewed-on: https://gerrit.libreoffice.org/83593
Reviewed-by: Julien Nabet
Tested-by: Julien Nabet
diff --git a/connectivity/source/drivers/mysqlc/mysqlc_prepared_resultset.cxx
b/connectivity/source/drivers/mysqlc/mysqlc_prepared_resultset.cxx
index 57be21dd6cc5..bfba7745856e 100644
--- a/connectivity/source/drivers/mysqlc/mysqlc_prepared_resultset.cxx
+++ b/connectivity/source/drivers/mysqlc/mysqlc_prepared_resultset.cxx
@@ -170,21 +170,21 @@ sal_Bool SAL_CALL
OPreparedResultSet::supportsService(const OUString& _rServiceN
{
return cppu::supportsService(this, _rServiceName);
}
-OPreparedResultSet::OPreparedResultSet(OConnection& rConn, OPreparedStatement*
pPrepared,
- MYSQL_STMT* pStmt)
+OPreparedResultSet::OPreparedResultSet(OConnection& rConn, OPreparedStatement*
pStmt,
+ MYSQL_STMT* pMyStmt)
: OPreparedResultSet_BASE(m_aMutex)
, OPropertySetHelper(OPreparedResultSet_BASE::rBHelper)
, m_rConnection(rConn)
-, m_aStatement(static_cast(pPrepared))
-, m_pStmt(pStmt)
+, m_aStatement(static_cast(pStmt))
+, m_pStmt(pMyStmt)
, m_encoding(rConn.getConnectionEncoding())
-, m_nColumnCount(mysql_stmt_field_count(pStmt))
+, m_nColumnCount(mysql_stmt_field_count(pMyStmt))
{
m_pResult = mysql_stmt_result_metadata(m_pStmt);
if (m_pResult != nullptr)
mysql_stmt_store_result(m_pStmt);
m_aFields = mysql_fetch_fields(m_pResult);
-m_nRowCount = mysql_stmt_num_rows(pStmt);
+m_nRowCount = mysql_stmt_num_rows(pMyStmt);
}
void OPreparedResultSet::disposing()
diff --git a/sd/source/filter/ppt/pptin.cxx b/sd/source/filter/ppt/pptin.cxx
index c2f30fa880e4..b641545a8aca 100644
--- a/sd/source/filter/ppt/pptin.cxx
+++ b/sd/source/filter/ppt/pptin.cxx
@@ -2566,9 +2566,9 @@ SdrObject* ImplSdPPTImport::ApplyTextObj( PPTTextObj*
pTextObj, SdrTextObj* pObj
return pRet;
}
-SdrObject* ImplSdPPTImport::ProcessObj( SvStream& rSt, DffObjData& rObjData,
SvxMSDffClientData& rData, ::tools::Rectangle& rTextRect, SdrObject* pRet )
+SdrObject* ImplSdPPTImport::ProcessObj( SvStream& rSt, DffObjData& rData,
SvxMSDffClientData& rClientData, ::tools::Rectangle& rTextRect, SdrObject* pRet
)
{
-SdrObject* pObj = SdrPowerPointImport::ProcessObj( rSt, rObjData, rData,
rTextRect, pRet );
+SdrObject* pObj = SdrPowerPointImport::ProcessObj( rSt, rData,
rClientData, rTextRect, pRet );
// read animation effect of object
if ( pObj )
@@ -2576,7 +2576,7 @@ SdrObject* ImplSdPPTImport::ProcessObj( SvStream& rSt,
DffObjData& rObjData, Svx
// further setup placeholder objects
if (dynamic_cast(pObj))
{
-const ProcessData& rProcessData=static_cast(rData);
+const ProcessData& rProcessData=static_cast(rClientData);
if(rProcessData.pPage.page)
static_cast(rProcessData.pPage.page)->InsertPresObj(
pObj, PRESOBJ_PAGE );
@@ -2713,7 +2713,7 @@ SdrObject* ImplSdPPTImport::ProcessObj( SvStream& rSt,
DffObjData& rObjData, Svx
if ( bInhabitanceChecked || bAnimationInfoFound )
break;
bInhabitanceChecked = true;
-if ( ! ( IsProperty( DFF_Prop_hspMaster ) && SeekToShape( rSt,
, GetPropertyValue( DFF_Prop_hspMaster, 0 ) ) ) )
+if ( ! ( IsProperty( DFF_Prop_hspMaster ) && SeekToShape( rSt,
, GetPropertyValue( DFF_Prop_hspMaster, 0 ) ) ) )
break;
ReadDffRecordHeader( rSt, aMasterShapeHd );
if ( !SeekToRec( rSt, DFF_msofbtClientData,
aMasterShapeHd.GetRecEndFilePos(), ) )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128522] path is not an absolute uRL...: misleading diagnostic
https://bugs.documentfoundation.org/show_bug.cgi?id=128522 --- Comment #3 from tor...@yahoo.com --- Created attachment 156069 --> https://bugs.documentfoundation.org/attachment.cgi?id=156069=edit file with frame -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sot/source svl/qa svl/source svtools/source svx/source
sot/source/sdstor/stgio.cxx |3 -
svl/qa/unit/svl.cxx |4 --
svl/source/numbers/zforlist.cxx |2 -
svl/source/svdde/ddestrg.cxx|5 +-
svtools/source/config/slidesorterbaropt.cxx |4 --
svtools/source/control/calendar.cxx |7 +---
svtools/source/control/ctrltool.cxx |3 -
svx/source/sidebar/paragraph/ParaLineSpacingControl.cxx | 27 ++--
svx/source/sidebar/paragraph/ParaLineSpacingControl.hxx |3 -
svx/source/svdraw/svdocapt.cxx | 13 ++-
svx/source/unodraw/unoctabl.cxx |6 +--
11 files changed, 28 insertions(+), 49 deletions(-)
New commits:
commit d002d3e8c241f32ac931c1998d7820d5b7b97e64
Author: Julien Nabet
AuthorDate: Sat Nov 23 19:17:30 2019 +0100
Commit: Julien Nabet
CommitDate: Sun Nov 24 00:26:41 2019 +0100
cppcheck: performing init in init list (sot/svl/svtools/svx)
order had been changed in
svx/source/sidebar/paragraph/ParaLineSpacingControl.hxx
so initialization list was fine
Indeed mpActLineDistFld depends on mpLineDistAtMetricBox
Change-Id: I974e68892fe7ab900774bbe912c51ec56ba4ee43
Reviewed-on: https://gerrit.libreoffice.org/83577
Reviewed-by: Julien Nabet
Tested-by: Julien Nabet
diff --git a/sot/source/sdstor/stgio.cxx b/sot/source/sdstor/stgio.cxx
index 08f023c5f52a..7d90c490c634 100644
--- a/sot/source/sdstor/stgio.cxx
+++ b/sot/source/sdstor/stgio.cxx
@@ -175,9 +175,8 @@ public:
}
EasyFat::EasyFat( StgIo& rIo, StgStrm* pFatStream, sal_Int32 nPSize )
+ : nPages(pFatStream->GetSize() >> 2), nPageSize(nPSize)
{
-nPages = pFatStream->GetSize() >> 2;
-nPageSize = nPSize;
pFat.reset( new sal_Int32[ nPages ] );
pFree.reset( new bool[ nPages ] );
diff --git a/svl/qa/unit/svl.cxx b/svl/qa/unit/svl.cxx
index d30a7b6279ec..8eb3cf4b6dfa 100644
--- a/svl/qa/unit/svl.cxx
+++ b/svl/qa/unit/svl.cxx
@@ -101,10 +101,8 @@ private:
std::unique_ptr m_pDefaultTimeZone;
};
-Test::Test()
+Test::Test() : m_xContext(cppu::defaultBootstrap_InitialComponentContext())
{
-m_xContext = cppu::defaultBootstrap_InitialComponentContext();
-
uno::Reference
xFactory(m_xContext->getServiceManager());
uno::Reference xSM(xFactory,
uno::UNO_QUERY_THROW);
diff --git a/svl/source/numbers/zforlist.cxx b/svl/source/numbers/zforlist.cxx
index 04e32464d8b2..7243d0f7105c 100644
--- a/svl/source/numbers/zforlist.cxx
+++ b/svl/source/numbers/zforlist.cxx
@@ -196,8 +196,8 @@ public:
};
SvNumberFormatterRegistry_Impl::SvNumberFormatterRegistry_Impl()
+: eSysLanguage(MsLangId::getRealLanguage( LANGUAGE_SYSTEM ))
{
-eSysLanguage = MsLangId::getRealLanguage( LANGUAGE_SYSTEM );
aSysLocaleOptions.AddListener( this );
}
diff --git a/svl/source/svdde/ddestrg.cxx b/svl/source/svdde/ddestrg.cxx
index 43fbe5b6d9e4..6789dc1e172f 100644
--- a/svl/source/svdde/ddestrg.cxx
+++ b/svl/source/svdde/ddestrg.cxx
@@ -23,10 +23,9 @@
#include
DdeString::DdeString( DWORD hDdeInst, const OUString& r)
-: m_aString(r)
+: m_aString(r), hString(DdeCreateStringHandleW( hDdeInst,
o3tl::toW(r.getStr()), CP_WINUNICODE )),
+ hInst(hDdeInst)
{
-hString = DdeCreateStringHandleW( hDdeInst, o3tl::toW(r.getStr()),
CP_WINUNICODE );
-hInst = hDdeInst;
}
DdeString::~DdeString()
diff --git a/svtools/source/config/slidesorterbaropt.cxx
b/svtools/source/config/slidesorterbaropt.cxx
index ecf29453c765..83b10595869c 100644
--- a/svtools/source/config/slidesorterbaropt.cxx
+++ b/svtools/source/config/slidesorterbaropt.cxx
@@ -120,7 +120,7 @@ class SvtSlideSorterBarOptions_Impl : public ConfigItem
SvtSlideSorterBarOptions_Impl::SvtSlideSorterBarOptions_Impl()
// Init baseclasses first
: ConfigItem( ROOTNODE_SLIDESORTERBAR )
-
+, m_seqPropertyNames(GetPropertyNames())
, m_bVisibleImpressView( false )
, m_bVisibleOutlineView( false )
, m_bVisibleNotesView( false )
@@ -129,8 +129,6 @@
SvtSlideSorterBarOptions_Impl::SvtSlideSorterBarOptions_Impl()
, m_bVisibleDrawView( false )
{
-m_seqPropertyNames = GetPropertyNames( );
-
// Use our static list of configuration keys to get his values.
Sequence< Any > seqValues = GetProperties( m_seqPropertyNames );
diff --git a/svtools/source/control/calendar.cxx
b/svtools/source/control/calendar.cxx
index 023af05b18bc..d1b7f5d119c9 100644
--- a/svtools/source/control/calendar.cxx
+++ b/svtools/source/control/calendar.cxx
@@ -57,12 +57,9 @@ public:
};
ImplCFieldFloatWin::ImplCFieldFloatWin( vcl::Window* pParent ) :
-FloatingWindow( pParent, WB_BORDER | WB_SYSTEMWINDOW | WB_NOSHADOW )
+FloatingWindow( pParent, WB_BORDER | WB_SYSTEMWINDOW | WB_NOSHADOW ),
+mpCalendar(nullptr), mpTodayBtn(nullptr), mpNoneBtn(nullptr),
mpFixedLine(nullptr)
{
-
[Libreoffice-commits] core.git: emfio/inc emfio/source
emfio/inc/emfreader.hxx |1
emfio/source/reader/emfreader.cxx | 268 +-
emfio/source/reader/mtftools.cxx |6
3 files changed, 211 insertions(+), 64 deletions(-)
New commits:
commit debb38c7be8015b4de4aace6f8ac78e4ee2fbfa6
Author: Chris Sherlock
AuthorDate: Wed Nov 20 15:16:07 2019 +1100
Commit: Bartosz Kosiorek
CommitDate: Sat Nov 23 23:55:40 2019 +0100
emfio: extra logging
For emfio I believe we need more logging, so I am gradually adding this.
I decided to log the EMR_COMMENT_PUBLIC record subtypes
EMR_COMMENT_BEGINGROUP and EMR_COMMENT_ENDGROUP.
I honestly don't know what these actually do, but they are specified in
[MS-EMF] 2.3.3.4.1 and 2.3.3.4.2. Later on, we will need to look into
handling EMR_COMMENT_MULTIFORMATS so we can display things with EPS
data. We should also probably look into handling
EMR_COMMENT_WINDOWS_METAFILE later on also.
Change-Id: I7c3ba3cfd7f51a6cff2c7a47a48dde12240d0382
Reviewed-on: https://gerrit.libreoffice.org/83407
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek
diff --git a/emfio/inc/emfreader.hxx b/emfio/inc/emfreader.hxx
index a54eee1a9c70..90d8969ae70c 100644
--- a/emfio/inc/emfreader.hxx
+++ b/emfio/inc/emfreader.hxx
@@ -42,6 +42,7 @@ namespace emfio
~EmfReader();
bool ReadEnhWMF();
+void ReadGDIComment(sal_uInt32 nCommentId);
private:
template void ReadAndDrawPolyPolygon(sal_uInt32 nNextPos);
diff --git a/emfio/source/reader/emfreader.cxx
b/emfio/source/reader/emfreader.cxx
index b5fdf0238031..ed42f904c011 100644
--- a/emfio/source/reader/emfreader.cxx
+++ b/emfio/source/reader/emfreader.cxx
@@ -375,7 +375,7 @@ namespace emfio
, mnRecordCount(0)
, mbRecordPath(false)
, mbEMFPlus(false)
-,mbEMFPlusDualMode(false)
+, mbEMFPlusDualMode(false)
{
}
@@ -383,6 +383,74 @@ namespace emfio
{
}
+#if OSL_DEBUG_LEVEL > 0
+const sal_uInt32 EMR_COMMENT_BEGINGROUP = 0x0002;
+const sal_uInt32 EMR_COMMENT_ENDGROUP = 0x0003;
+const sal_uInt32 EMR_COMMENT_MULTIFORMATS = 0x0004;
+const sal_uInt32 EMR_COMMENT_WINDOWS_METAFILE = 0x0005;
+
+void EmfReader::ReadGDIComment(sal_uInt32 nCommentId)
+{
+sal_uInt32 nPublicCommentIdentifier;
+mpInputStream->ReadUInt32(nPublicCommentIdentifier);
+
+SAL_INFO("emfio", "\t\tEMR_COMMENT_PUBLIC, id: 0x" << std::hex <<
nCommentId << std::dec);
+switch (nPublicCommentIdentifier)
+{
+case EMR_COMMENT_BEGINGROUP:
+{
+SAL_INFO("emfio", "\t\t\tEMR_COMMENT_BEGINGROUP");
+sal_uInt32 left, top, right, bottom;
+
mpInputStream->ReadUInt32(left).ReadUInt32(top).ReadUInt32(right).ReadUInt32(bottom);
+
+SAL_INFO("emfio", "\t\t\t\tBounding rect");
+SAL_INFO("emfio", "\t\t\t\t\tLeft: " << left);
+SAL_INFO("emfio", "\t\t\t\t\tTop: " << top);
+SAL_INFO("emfio", "\t\t\t\t\tRight: " << right);
+SAL_INFO("emfio", "\t\t\t\t\tBottom: " << bottom);
+
+sal_uInt32 nDescChars;
+mpInputStream->ReadUInt32(nDescChars);
+
+OUString aDesc;
+for (sal_uInt32 i=0; i < nDescChars; i++)
+{
+sal_uInt16 cChar(0);
+mpInputStream->ReadUInt16(cChar);
+if (cChar == '\0')
+break;
+
+sal_Unicode cUniChar = static_cast(cChar);
+aDesc = aDesc.concat(OUString(cUniChar));
+}
+
+SAL_INFO("emfio", "\t\tDescription: " << aDesc);
+}
+break;
+
+case EMR_COMMENT_ENDGROUP:
+SAL_INFO("emfio", "\t\t\tEMR_COMMENT_ENDGROUP");
+break;
+
+case EMR_COMMENT_MULTIFORMATS:
+SAL_WARN("emfio", "\t\tEMR_COMMENT_MULTIFORMATS not
implemented");
+break;
+
+case EMR_COMMENT_WINDOWS_METAFILE:
+SAL_WARN("emfio", "\t\tEMR_COMMENT_WINDOWS_METAFILE not
implemented");
+break;
+
+default:
+SAL_WARN("emfio", "\t\tEMR_COMMENT_PUBLIC not implemented, id:
0x" << std::hex << nCommentId << std::dec);
+break;
+}
+}
+#else
+void EmfReader::ReadGDIComment(sal_uInt32)
+{
+}
+#endif
+
void EmfReader::ReadEMFPlusComment(sal_uInt32 length, bool& bHaveDC)
{
if (!mbEMFPlus)
@@ -425,14 +493,14 @@ namespace emfio
mpInputStream->ReadUInt16( type ).ReadUInt16( flags ).ReadUInt32(
size ).ReadUInt32( dataSize );
nRemainder -= nRequiredHeaderSize;
-SAL_INFO ("emfio", "\t\tEMF+ record type: " << std::hex << type <<
std::dec);
+SAL_INFO("emfio",
[Libreoffice-commits] core.git: comphelper/source connectivity/source cppu/source cui/source
comphelper/source/compare/AnyCompareFactory.cxx |2
connectivity/source/drivers/hsqldb/accesslog.cxx |4 -
connectivity/source/drivers/macab/MacabAddressBook.cxx |6 -
connectivity/source/drivers/macab/MacabRecord.cxx|5 -
connectivity/source/drivers/macab/MacabRecords.cxx | 38
+-
connectivity/source/drivers/macab/MacabResultSet.cxx |4 -
connectivity/source/drivers/mork/MStatement.cxx |4 -
connectivity/source/drivers/mysqlc/mysqlc_prepared_resultset.cxx |2
cppu/source/typelib/typelib.cxx |5 -
cui/source/options/certpath.cxx |4 -
cui/source/options/optjsearch.cxx|4 -
11 files changed, 28 insertions(+), 50 deletions(-)
New commits:
commit 4e1ae2a9a0d2d9185b49677fa4ea2a2b1fe8bab2
Author: Julien Nabet
AuthorDate: Sat Nov 23 20:25:07 2019 +0100
Commit: Julien Nabet
CommitDate: Sat Nov 23 23:51:35 2019 +0100
cppcheck: performing init in init list (comphelper/connectivity/cppu/cui)
Change-Id: I786c2c10e8b37b48adf6d619c0fa6a905de1bf7f
Reviewed-on: https://gerrit.libreoffice.org/83584
Reviewed-by: Julien Nabet
Tested-by: Julien Nabet
diff --git a/comphelper/source/compare/AnyCompareFactory.cxx
b/comphelper/source/compare/AnyCompareFactory.cxx
index 7a31f10f1f71..40e5f0806a95 100644
--- a/comphelper/source/compare/AnyCompareFactory.cxx
+++ b/comphelper/source/compare/AnyCompareFactory.cxx
@@ -39,8 +39,8 @@ class AnyCompare : public ::cppu::WeakImplHelper< XAnyCompare
>
public:
AnyCompare( Reference< XComponentContext > const & xContext, const Locale&
rLocale )
+ : m_xCollator(Collator::create( xContext ))
{
-m_xCollator = Collator::create( xContext );
m_xCollator->loadDefaultCollator( rLocale,
0 ); //???
}
diff --git a/connectivity/source/drivers/hsqldb/accesslog.cxx
b/connectivity/source/drivers/hsqldb/accesslog.cxx
index 880600a71d5a..bc5a2c3de81e 100644
--- a/connectivity/source/drivers/hsqldb/accesslog.cxx
+++ b/connectivity/source/drivers/hsqldb/accesslog.cxx
@@ -39,9 +39,9 @@ namespace connectivity { namespace hsqldb
LogFile::LogFile( JNIEnv* env, jstring streamName, const sal_Char*
_pAsciiSuffix )
+: m_sFileName(StorageContainer::jstring2ustring(env,streamName) +
+ "." + OUString::createFromAscii( _pAsciiSuffix ) )
{
-m_sFileName = StorageContainer::jstring2ustring(env,streamName) +
-"." + OUString::createFromAscii( _pAsciiSuffix );
}
diff --git a/connectivity/source/drivers/macab/MacabAddressBook.cxx
b/connectivity/source/drivers/macab/MacabAddressBook.cxx
index 46570ef5ff57..09e4892033e8 100644
--- a/connectivity/source/drivers/macab/MacabAddressBook.cxx
+++ b/connectivity/source/drivers/macab/MacabAddressBook.cxx
@@ -78,10 +78,10 @@ void manageDuplicateGroups(std::vector
_xGroups)
}
MacabAddressBook::MacabAddressBook( )
+ : m_aAddressBook(ABGetSharedAddressBook()),
+ m_xMacabRecords(nullptr),
+ m_bRetrievedGroups(false)
{
-m_aAddressBook = ABGetSharedAddressBook();
-m_xMacabRecords = nullptr;
-m_bRetrievedGroups = false;
}
diff --git a/connectivity/source/drivers/macab/MacabRecord.cxx
b/connectivity/source/drivers/macab/MacabRecord.cxx
index 5d95e320ef20..b7e270f378f2 100644
--- a/connectivity/source/drivers/macab/MacabRecord.cxx
+++ b/connectivity/source/drivers/macab/MacabRecord.cxx
@@ -33,13 +33,14 @@ using namespace com::sun::star::util;
using namespace ::dbtools;
-MacabRecord::MacabRecord()
+MacabRecord::MacabRecord() : size(0)
{
-size = 0;
}
MacabRecord::MacabRecord(const sal_Int32 _size)
+ : size(_size),
+ fields(std::make_unique(size))
{
size = _size;
fields = std::make_unique(size);
diff --git a/connectivity/source/drivers/macab/MacabRecords.cxx
b/connectivity/source/drivers/macab/MacabRecords.cxx
index 4b7220e56723..0bc27ea0ee6f 100644
--- a/connectivity/source/drivers/macab/MacabRecords.cxx
+++ b/connectivity/source/drivers/macab/MacabRecords.cxx
@@ -73,17 +73,9 @@ void manageDuplicateHeaders(macabfield **_headerNames, const
sal_Int32 _length)
}
MacabRecords::MacabRecords(const ABAddressBookRef _addressBook, MacabHeader
*_header, MacabRecord **_records, sal_Int32 _numRecords)
+ : recordsSize(_numRecords), currentRecord(_numRecords),
recordType(kABPersonRecordType),
+ header(_header), records(_records), addressBook(_addressBook)
{
-/* Variables passed in... */
-header = _header;
-recordsSize = _numRecords;
-currentRecord = _numRecords;
-records = _records;
-addressBook = _addressBook;
-
-/* Default variables... */
-recordType = kABPersonRecordType;
-
/* Variables constructed... */
bootstrap_CF_types();
Jenkins clang failure
Hello, I noticed this failure on several patches (not only mine): fatal error: file '/usr/include/asm-generic/errno.h' has been modified since the precompiled header '/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/compilerplugins/clang/sharedvisitor/clang.pch' was built Could someone take a look? Julien -- Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sfx2/source slideshow/source stoc/source store/source
sfx2/source/bastyp/fltlst.cxx |4 ++--
sfx2/source/doc/exoticfileloadexception.cxx|4 ++--
sfx2/source/view/viewsh.cxx|3 +--
slideshow/source/engine/transitions/slidetransitionfactory.cxx |3 +--
stoc/source/defaultregistry/defaultregistry.cxx|7 +--
stoc/source/inspect/introspection.cxx |6 ++
stoc/source/invocation_adapterfactory/iafactory.cxx|8 +++-
store/source/stordata.hxx |6 +++---
8 files changed, 15 insertions(+), 26 deletions(-)
New commits:
commit e6ab01ce532d1db01579b70bd476b2f643522bf9
Author: Julien Nabet
AuthorDate: Sat Nov 23 18:54:42 2019 +0100
Commit: Julien Nabet
CommitDate: Sat Nov 23 23:38:07 2019 +0100
cppcheck: performing init in init list (sfx2/slideshow/stoc/store)
Change-Id: Iddbd3256aabe9552472b55d3d9b88a3769698de9
Reviewed-on: https://gerrit.libreoffice.org/83576
Reviewed-by: Julien Nabet
Tested-by: Julien Nabet
diff --git a/sfx2/source/bastyp/fltlst.cxx b/sfx2/source/bastyp/fltlst.cxx
index ef9e333129b8..25b401e9feb7 100644
--- a/sfx2/source/bastyp/fltlst.cxx
+++ b/sfx2/source/bastyp/fltlst.cxx
@@ -82,9 +82,9 @@ class SfxRefreshListener : public
::cppu::WeakImplHelperaddRefreshListener( m_xFilterCacheListener );
}
diff --git a/sfx2/source/doc/exoticfileloadexception.cxx
b/sfx2/source/doc/exoticfileloadexception.cxx
index 56a697f43bf6..4993c0640a47 100644
--- a/sfx2/source/doc/exoticfileloadexception.cxx
+++ b/sfx2/source/doc/exoticfileloadexception.cxx
@@ -16,6 +16,8 @@ using namespace com::sun::star;
ExoticFileLoadException::ExoticFileLoadException(const OUString& rURL,
const OUString& rFilterUIName)
+: m_xAbort(new comphelper::OInteractionAbort)
+, m_xApprove(new comphelper::OInteractionApprove)
{
document::ExoticFileLoadException aReq;
aReq.URL = rURL;
@@ -23,8 +25,6 @@ ExoticFileLoadException::ExoticFileLoadException(const
OUString& rURL,
m_aRequest <<= aReq;
-m_xAbort = new comphelper::OInteractionAbort;
-m_xApprove = new comphelper::OInteractionApprove;
m_lContinuations.realloc(2);
m_lContinuations[0] = m_xApprove;
m_lContinuations[1] = m_xAbort;
diff --git a/sfx2/source/view/viewsh.cxx b/sfx2/source/view/viewsh.cxx
index 1c7638349b79..d648b1159b04 100644
--- a/sfx2/source/view/viewsh.cxx
+++ b/sfx2/source/view/viewsh.cxx
@@ -152,9 +152,8 @@ private:
};
SfxClipboardChangeListener::SfxClipboardChangeListener( SfxViewShell* pView,
const uno::Reference< datatransfer::clipboard::XClipboardNotifier >&
xClpbrdNtfr )
- : m_pViewShell( nullptr ), m_xClpbrdNtfr( xClpbrdNtfr )
+ : m_pViewShell( nullptr ), m_xClpbrdNtfr( xClpbrdNtfr ),
m_xCtrl(pView->GetController())
{
-m_xCtrl = pView->GetController();
if ( m_xCtrl.is() )
{
m_xCtrl->addEventListener( uno::Reference < lang::XEventListener > (
static_cast < lang::XEventListener* >( this ) ) );
diff --git a/slideshow/source/engine/transitions/slidetransitionfactory.cxx
b/slideshow/source/engine/transitions/slidetransitionfactory.cxx
index 7cc5045bcc59..49d440aa2ed7 100644
--- a/slideshow/source/engine/transitions/slidetransitionfactory.cxx
+++ b/slideshow/source/engine/transitions/slidetransitionfactory.cxx
@@ -95,9 +95,8 @@ class PluginSlideChange: public SlideChangeBase
UnoViewSharedPtr mpView;
TransitionViewPair( uno::Reference const &
xTransition, const UnoViewSharedPtr& rView )
+ : mxTransition(xTransition), mpView(rView)
{
-mxTransition = xTransition;
-mpView = rView;
}
~TransitionViewPair()
diff --git a/stoc/source/defaultregistry/defaultregistry.cxx
b/stoc/source/defaultregistry/defaultregistry.cxx
index f0a4d0ff18a3..aff6a5f1113c 100644
--- a/stoc/source/defaultregistry/defaultregistry.cxx
+++ b/stoc/source/defaultregistry/defaultregistry.cxx
@@ -137,11 +137,8 @@ protected:
NestedKeyImpl::NestedKeyImpl( NestedRegistryImpl* pDefaultRegistry,
Reference& localKey,
Reference& defaultKey )
-: m_xRegistry(pDefaultRegistry)
+: m_state(m_xRegistry->m_state), m_xRegistry(pDefaultRegistry),
m_localKey(localKey), m_defaultKey(defaultKey)
{
-m_localKey = localKey;
-m_defaultKey = defaultKey;
-
if (m_localKey.is())
{
m_name = m_localKey->getKeyName();
@@ -150,8 +147,6 @@ NestedKeyImpl::NestedKeyImpl( NestedRegistryImpl*
pDefaultRegistry,
{
m_name = m_defaultKey->getKeyName();
}
-
-m_state = m_xRegistry->m_state;
}
diff --git a/stoc/source/inspect/introspection.cxx
b/stoc/source/inspect/introspection.cxx
index 58434b2f51ea..14ecf79af050 100644
--- a/stoc/source/inspect/introspection.cxx
+++ b/stoc/source/inspect/introspection.cxx
@@ -773,13 +773,11 @@
[Libreoffice-bugs] [Bug 128944] LibreOffice Crash using LXQT 0.14.1
https://bugs.documentfoundation.org/show_bug.cgi?id=128944 --- Comment #12 from Hector Colina --- I've downloaded: LibreOffice Version: 6.4.0.0.beta1, Build ID: 4d7e5b0c40ed843384704eca3ce21981d4e98920, CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: es-VE (es_VE.UTF-8); UI-Language: en-US Calc: threaded It works perfect on LXQT, but previous version crashed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/lingu/olmenu.cxx | 41 +
sw/source/uibase/shells/textsh1.cxx | 85 +++-
2 files changed, 106 insertions(+), 20 deletions(-)
New commits:
commit 5efa7d4605c8c683bb54a1723d0916e6f0166b52
Author: Tamás Zolnai
AuthorDate: Sun Nov 17 14:17:59 2019 +0100
Commit: Tamás Zolnai
CommitDate: Sat Nov 23 23:22:08 2019 +0100
SpellingPopup: Convert suggestion menu items to use slot ID.
Change-Id: Icf1f50d04ab5e7ba467d68613f4101a3fe48589b
(cherry picked from commit c2f58bc25cedf8a13a978b52a5bf012809fc38ed)
Reviewed-on: https://gerrit.libreoffice.org/83590
Reviewed-by: Tamás Zolnai
Tested-by: Tamás Zolnai
diff --git a/sw/source/uibase/lingu/olmenu.cxx
b/sw/source/uibase/lingu/olmenu.cxx
index f04fb6b71880..e08c5f4a2804 100644
--- a/sw/source/uibase/lingu/olmenu.cxx
+++ b/sw/source/uibase/lingu/olmenu.cxx
@@ -636,26 +636,29 @@ void SwSpellPopup::Execute( sal_uInt16 nId )
if (/*m_bGrammarResults && */nId == MN_SHORT_COMMENT)
return; // nothing to do since it is the error message (short
comment)
-if ((MN_SUGGESTION_START <= nId && nId <= MN_SUGGESTION_END) ||
-(MN_AUTOCORR_START <= nId && nId <= MN_AUTOCORR_END))
+if (MN_SUGGESTION_START <= nId && nId <= MN_SUGGESTION_END)
{
-OUString sNewWord;
-if (MN_AUTOCORR_START <= nId && nId <= MN_AUTOCORR_END)
-{
-PopupMenu* pMenu = m_xPopupMenu->GetPopupMenu(m_nCorrectMenuId);
-assert(pMenu);
-sNewWord = pMenu->GetItemText(nId);
-}
-else
-sNewWord = m_xPopupMenu->GetItemText(nId);
-
-if (m_bGrammarResults || m_xSpellAlt.is())
+OUString sApplyRule("Replace_");
+if(m_bGrammarResults)
+sApplyRule += "Grammar_";
+else if (m_xSpellAlt.is())
+sApplyRule += "Spelling_";
+sApplyRule += m_xPopupMenu->GetItemText(nId);
+
+SfxStringItem aApplyItem(FN_PARAM_1, sApplyRule);
+
m_pSh->GetView().GetViewFrame()->GetDispatcher()->ExecuteList(SID_APPLY_SPELLCHECKING,
SfxCallMode::SYNCHRON, { });
+}
+else if(MN_AUTOCORR_START <= nId && nId <= MN_AUTOCORR_END)
+{
+if (m_xSpellAlt.is())
{
bool bOldIns = m_pSh->IsInsMode();
m_pSh->SetInsMode();
-OUString aTmp( sNewWord );
-OUString aOrig( m_bGrammarResults ? OUString() :
m_xSpellAlt->getWord() );
+PopupMenu* pMenu = m_xPopupMenu->GetPopupMenu(m_nCorrectMenuId);
+assert(pMenu);
+OUString aTmp( pMenu->GetItemText(nId) );
+OUString aOrig( m_xSpellAlt->getWord() );
// if original word has a trailing . (likely the end of a sentence)
// and the replacement text hasn't, then add it to the replacement
@@ -688,11 +691,11 @@ void SwSpellPopup::Execute( sal_uInt16 nId )
// record only if it's NOT already present in autocorrection
SvxAutoCorrect* pACorr = SvxAutoCorrCfg::Get().GetAutoCorrect();
-OUString aOrigWord( m_bGrammarResults ? OUString() :
m_xSpellAlt->getWord() ) ;
-SvxPrepareAutoCorrect( aOrigWord, sNewWord );
+OUString aOrigWord( m_xSpellAlt->getWord() ) ;
+OUString aNewWord( pMenu->GetItemText(nId) );
+SvxPrepareAutoCorrect( aOrigWord, aNewWord );
-if (MN_AUTOCORR_START <= nId && nId <= MN_AUTOCORR_END)
-pACorr->PutText( aOrigWord, sNewWord, m_nCheckedLanguage );
+pACorr->PutText( aOrigWord, aNewWord, m_nCheckedLanguage );
/* #102505# EndAction/EndUndo moved down since insertion
of temporary auto correction is now undoable two and
diff --git a/sw/source/uibase/shells/textsh1.cxx
b/sw/source/uibase/shells/textsh1.cxx
index bff08a595f18..4db7fd030846 100644
--- a/sw/source/uibase/shells/textsh1.cxx
+++ b/sw/source/uibase/shells/textsh1.cxx
@@ -128,6 +128,7 @@
#include
#include
#include
+#include
using namespace ::com::sun::star;
using namespace com::sun::star::beans;
@@ -1444,7 +1445,7 @@ void SwTextShell::Execute(SfxRequest )
const OUString sIgnoreAllPrefix("IgnoreAll_");
const OUString sSpellingRule("Spelling");
const OUString sGrammarRule("Grammar");
-//const OUString aReplacePrefix("Replace_");
+const OUString aReplacePrefix("Replace_");
// Ignore the word at the cursor pos
sal_Int32 nPos = 0;
@@ -1500,6 +1501,88 @@ void SwTextShell::Execute(SfxRequest )
}
}
}
+// Replace text with the suggestion
+else if (-1 != (nPos = sApplyText.indexOf( aReplacePrefix )))
+{
+sApplyText = sApplyText.replaceAt(nPos,
aReplacePrefix.getLength(), "");
+
+const OUString sSpellingRule2(sSpellingRule + "_");
+const OUString sGrammarRule2(sGrammarRule + "_");
+
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/inc/olmenu.hxx |1 -
sw/source/uibase/lingu/olmenu.cxx | 34 --
2 files changed, 20 insertions(+), 15 deletions(-)
New commits:
commit 4549de73090284f149ed6ba62818e27739bdaf19
Author: Tamás Zolnai
AuthorDate: Sun Nov 17 13:33:51 2019 +0100
Commit: Tamás Zolnai
CommitDate: Sat Nov 23 23:21:48 2019 +0100
SpellingPopup: Remove m_aSuggestions member variable
We don't need it after the construction. The text is stored by the
menu item.
Change-Id: I54b0392b4564e76d405824bb297e6f993a24a5fb
(cherry picked from commit dc842a4af87ae5f1edd6112ca4f2ff2ac25f5a50)
Reviewed-on: https://gerrit.libreoffice.org/83589
Reviewed-by: Tamás Zolnai
Tested-by: Tamás Zolnai
diff --git a/sw/source/uibase/inc/olmenu.hxx b/sw/source/uibase/inc/olmenu.hxx
index db80e20e931a..984dfb759872 100644
--- a/sw/source/uibase/inc/olmenu.hxx
+++ b/sw/source/uibase/inc/olmenu.hxx
@@ -96,7 +96,6 @@ class SW_DLLPUBLIC SwSpellPopup
css::linguistic2::ProofreadingResult m_xGrammarResult;
sal_Int32 m_nGrammarError;
-css::uno::Sequence< OUString > m_aSuggestions;
OUString m_sExplanationLink;
LanguageTypem_nCheckedLanguage;
diff --git a/sw/source/uibase/lingu/olmenu.cxx
b/sw/source/uibase/lingu/olmenu.cxx
index 57260b5b4dd7..f04fb6b71880 100644
--- a/sw/source/uibase/lingu/olmenu.cxx
+++ b/sw/source/uibase/lingu/olmenu.cxx
@@ -242,12 +242,13 @@ SwSpellPopup::SwSpellPopup(
bool bUseImagesInMenus =
Application::GetSettings().GetStyleSettings().GetUseImagesInMenus();
m_nCheckedLanguage = LANGUAGE_NONE;
+css::uno::Sequence< OUString > aSuggestions;
if (m_xSpellAlt.is())
{
m_nCheckedLanguage = LanguageTag( m_xSpellAlt->getLocale()
).getLanguageType();
-m_aSuggestions = m_xSpellAlt->getAlternatives();
+aSuggestions = m_xSpellAlt->getAlternatives();
}
-sal_Int16 nStringCount = static_cast< sal_Int16 >(
m_aSuggestions.getLength() );
+sal_Int16 nStringCount = static_cast< sal_Int16 >(
aSuggestions.getLength() );
SvtLinguConfig aCfg;
@@ -275,7 +276,7 @@ SwSpellPopup::SwSpellPopup(
sal_uInt16 nItemId = MN_SUGGESTION_START;
for (sal_uInt16 i = 0; i < nStringCount; ++i)
{
-const OUString aEntry = m_aSuggestions[ i ];
+const OUString aEntry = aSuggestions[ i ];
m_xPopupMenu->InsertItem(nItemId, aEntry, MenuItemBits::NONE,
OString(), i);
m_xPopupMenu->SetHelpId(nItemId, HID_LINGU_REPLACE);
if (!aSuggestionImageUrl.isEmpty())
@@ -443,7 +444,6 @@ SwSpellPopup::SwSpellPopup(
, m_nRedlinePrevId(m_xPopupMenu->GetItemId("prev"))
, m_pSh(pWrtSh)
, m_xGrammarResult(rResult)
-, m_aSuggestions(rSuggestions)
, m_sExplanationLink()
, m_bGrammarResults(true)
{
@@ -480,7 +480,7 @@ SwSpellPopup::SwSpellPopup(
m_xPopupMenu->SetMenuFlags(MenuFlags::NoAutoMnemonics);
m_xPopupMenu->InsertSeparator(OString(), nPos++);
-if ( m_aSuggestions.hasElements() ) // suggestions available...
+if ( rSuggestions.hasElements() ) // suggestions available...
{
Image aImage;
OUString aSuggestionImageUrl;
@@ -496,7 +496,7 @@ SwSpellPopup::SwSpellPopup(
}
sal_uInt16 nItemId = MN_SUGGESTION_START;
-for (const OUString& aEntry : std::as_const(m_aSuggestions))
+for (const OUString& aEntry : std::as_const(rSuggestions))
{
m_xPopupMenu->InsertItem(nItemId, aEntry, MenuItemBits::NONE,
OString(), nPos++);
m_xPopupMenu->SetHelpId(nItemId, HID_LINGU_REPLACE);
@@ -639,15 +639,22 @@ void SwSpellPopup::Execute( sal_uInt16 nId )
if ((MN_SUGGESTION_START <= nId && nId <= MN_SUGGESTION_END) ||
(MN_AUTOCORR_START <= nId && nId <= MN_AUTOCORR_END))
{
-sal_Int32 nAltIdx = (MN_SUGGESTION_START <= nId && nId <=
MN_SUGGESTION_END) ?
-nId - MN_SUGGESTION_START : nId - MN_AUTOCORR_START;
-OSL_ENSURE(nAltIdx < m_aSuggestions.getLength(), "index out of range");
-if (nAltIdx < m_aSuggestions.getLength() && (m_bGrammarResults ||
m_xSpellAlt.is()))
+OUString sNewWord;
+if (MN_AUTOCORR_START <= nId && nId <= MN_AUTOCORR_END)
+{
+PopupMenu* pMenu = m_xPopupMenu->GetPopupMenu(m_nCorrectMenuId);
+assert(pMenu);
+sNewWord = pMenu->GetItemText(nId);
+}
+else
+sNewWord = m_xPopupMenu->GetItemText(nId);
+
+if (m_bGrammarResults || m_xSpellAlt.is())
{
bool bOldIns = m_pSh->IsInsMode();
m_pSh->SetInsMode();
-OUString aTmp( m_aSuggestions[ nAltIdx ] );
+OUString aTmp( sNewWord );
OUString aOrig( m_bGrammarResults ? OUString() :
m_xSpellAlt->getWord() );
// if original word has a trailing . (likely the end of a sentence)
[Libreoffice-bugs] [Bug 128405] Style formatting and management - bullet and number lists continue to stay applied even changing style by applying a simple paragraph style
https://bugs.documentfoundation.org/show_bug.cgi?id=128405 zionoto changed: What|Removed |Added Summary|Style formatting and|Style formatting and |management - bullet and |management - bullet and |number lists continue to|number lists continue to |stay applied even changing |stay applied even changing |style and applying a simple |style by applying a simple |paragraph style |paragraph style -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128989] New: libreoffice fails to print, may be related to page size confusion between cm and inches
https://bugs.documentfoundation.org/show_bug.cgi?id=128989 Bug ID: 128989 Summary: libreoffice fails to print, may be related to page size confusion between cm and inches Product: LibreOffice Version: 6.3.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: digi...@joescat.com Description: Crash report URL included. I think this might be due to some sort of confusion with cm, inches when sending page to printer. Earlier versions of libreoffice noticeably did not have measurements as 0.5" or 1" but had a rounded value such as 0.49 or 0.79 and therefore probably was acceptable by the printer. I did notice with this version that although the write document was letter-size like 8.5" x 11", the printer preview was showing mm values. I don't know if this was oversized, or maybe confused as some huge paper size in inches. In any case, it worked okay with libreoffice 4.x, spooled but not printed with 6.2, and currently crashes with libreoffice 6.3 Steps to Reproduce: 1. Fresh install of LibreOffice 2. Settings set to Canadian (we are on metric system now), however, set rulers to display in inches. 3. Page set to "Letter" size which is 8.5" x 11" 4. Printer loaded with Letter size paper. 5. create/save letter sized document. 6. Select Print 7. Notice that although you chose letter size you see in print preview shows mm 8. print document - crash occurs. (in 6.2 it went to print spool but did not print I believe due to wrong size paper settings). Actual Results: Version 6.2 would spool results but printer did not actually print document. Current version 6.3 of libreoffice crashed. Here is the crash report: crashreport.libreoffice.org/stats/crash_details/4a0761ee-ff32-498a-b736-27dc7e2bcb41 Expected Results: Libreoffice writer set to Canadian, and also set for "inches" not "cm" due to older users who are accustomed to English measurements plus "letter" sized paper, not metric A4 paper - expected print to send to spool, and then proceed to print. Reproducible: Always User Profile Reset: No Additional Info: Version: 6.3.3.2 (x64) Build ID: a64200df03143b798afd1ec74a12ab50359878ed CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; Locale: en-CA (en_CA); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128405] Style formatting and management - bullet and number lists continue to stay applied even changing style and applying a simple paragraph style
https://bugs.documentfoundation.org/show_bug.cgi?id=128405 zionoto changed: What|Removed |Added Summary|Style formatting and|Style formatting and |management - bullet and |management - bullet and |number lists continue to|number lists continue to |stay applied even changing |stay applied even changing |style to a paragraph|style and applying a simple ||paragraph style -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128361] jagged, indented rendered rows
https://bugs.documentfoundation.org/show_bug.cgi?id=128361 zionoto changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #5 from zionoto --- (In reply to Xisco Faulí from comment #4) > Thank you for reporting the bug. Please attach a sample document, as this > makes it easier for us to verify the bug. > (Please note that the attachment will be public, remove any sensitive > information before attaching it. > See > https://wiki.documentfoundation.org/QA/ > FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F for help > on how to do so.) > > I have set the bug's status to 'NEEDINFO'. Please change it back to > 'UNCONFIRMED' once the requested document is provided. I'm not able to attach a document that does it every time because the problem happens randomly. I think it is an issue due to rendering as I said before, so IMHO it doesn't matter the text content of the doc. Just I have to add enough text in it an after a while it happens scrolling the document up or down. This is why I added a screenshot instead of a Write file. Sorry. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128944] LibreOffice Crash using LXQT 0.14.1
https://bugs.documentfoundation.org/show_bug.cgi?id=128944 --- Comment #11 from Hector Colina --- Created attachment 156067 --> https://bugs.documentfoundation.org/attachment.cgi?id=156067=edit Libreoffice on mate As you can see, same version works perfectly on MATE, but it crash on LXQT Be advice, using libreofice debian 10 packages on LXQT works without problems. I think that is a bug over LXQT. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128944] LibreOffice Crash using LXQT 0.14.1
https://bugs.documentfoundation.org/show_bug.cgi?id=128944 --- Comment #10 from Hector Colina --- (In reply to Julien Nabet from comment #7) > (In reply to Hector Colina from comment #6) > > In my previous comment, I attached linux version: > > > > hector@snoopy:/tmp/debug$ lsb_release -a > > No LSB modules are available. > > Distributor ID: Debian > > Description:Debian GNU/Linux 10 (buster) > > Release:10 > > Codename: buster > > hector@snoopy:/tmp/debug$ > > > > So, I'm using Debian version 10 > > > > ... > > Sorry, just missed it. > I use Debian testing which contains 6.3.3 > > IMHO stable version of Debian is more for servers than for desktop. > > Now, you can also use LO from testing even if you use stable however, it'll > need dependencies (see > https://serverfault.com/questions/22414/how-can-i-run-debian-stable-but- > install-some-packages-from-testing) Sorry Julien... I think that is not dependency issue, why? Libreoffice works perfectly using MATE in same computer.. I mean, if I open a session using MATE desktop manager, I ca open without problem Libreoffice, but If I start LXQT in same computer... Libreoffice crash according my report. I will be able to reproduce again the bug, Mate works perfectly but now libreoffice download from page version 6.2.82 crashed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128944] LibreOffice Crash using LXQT 0.14.1
https://bugs.documentfoundation.org/show_bug.cgi?id=128944 --- Comment #9 from Hector Colina --- Ok. Version used for to reproduce bug is 6.2.82 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - sw/source
sw/source/core/edit/edlingu.cxx | 10 +++---
sw/source/uibase/lingu/olmenu.cxx | 29 +-
sw/source/uibase/shells/textsh1.cxx | 58 +---
3 files changed, 62 insertions(+), 35 deletions(-)
New commits:
commit 352966952641eed80ae94de57065b0e0896116a6
Author: Tamás Zolnai
AuthorDate: Sun Nov 17 13:18:34 2019 +0100
Commit: Tamás Zolnai
CommitDate: Sat Nov 23 22:37:28 2019 +0100
SpellingPopup: Convert "IgnoreAll" menu item to use a slot ID (spelling).
When the popup is in spelling mode. "IgnoreAll_Spelling" rule
triggers this method.
Change-Id: Ia1e1877f8501beff29f09bc33621c8f03008b7e8
Reviewed-on: https://gerrit.libreoffice.org/83588
Reviewed-by: Tamás Zolnai
Tested-by: Tamás Zolnai
diff --git a/sw/source/core/edit/edlingu.cxx b/sw/source/core/edit/edlingu.cxx
index 1c03f321de69..f0220a8e7ef2 100644
--- a/sw/source/core/edit/edlingu.cxx
+++ b/sw/source/core/edit/edlingu.cxx
@@ -897,12 +897,13 @@ uno::Reference< XSpellAlternatives >
return nullptr;
SwPaM* pCursor = GetCursor();
SwPosition aPos( *pCursor->GetPoint() );
-Point aPt( *pPt );
SwCursorMoveState eTmpState( MV_SETONLYTEXT );
SwTextNode *pNode = nullptr;
SwWrongList *pWrong = nullptr;
-if (GetLayout()->GetCursorOfst( , aPt, ))
+if (pPt && GetLayout()->GetCursorOfst( , *(const_cast(pPt)),
))
pNode = aPos.nNode.GetNode().GetTextNode();
+if (nullptr == pNode)
+pNode = pCursor->GetNode().GetTextNode();
if (nullptr != pNode)
pWrong = pNode->GetWrong();
if (nullptr != pWrong && !pNode->IsInProtectSect())
diff --git a/sw/source/uibase/lingu/olmenu.cxx
b/sw/source/uibase/lingu/olmenu.cxx
index 4d2e83131636..57260b5b4dd7 100644
--- a/sw/source/uibase/lingu/olmenu.cxx
+++ b/sw/source/uibase/lingu/olmenu.cxx
@@ -716,19 +716,8 @@ void SwSpellPopup::Execute( sal_uInt16 nId )
}
else if (nId == m_nIgnoreWordId)
{
-uno::Reference< linguistic2::XDictionary > xDictionary =
LinguMgr::GetIgnoreAllList();
-if (m_bGrammarResults) {
-SfxStringItem aIgnoreString(FN_PARAM_1, "IgnoreAll_Grammar");
-
m_pSh->GetView().GetViewFrame()->GetDispatcher()->ExecuteList(SID_APPLY_SPELLCHECKING,
SfxCallMode::SYNCHRON, { });
-} else {
-OUString sWord(m_xSpellAlt->getWord());
-linguistic::DictionaryError nAddRes = linguistic::AddEntryToDic(
xDictionary,
-sWord, false, OUString() );
-if (linguistic::DictionaryError::NONE != nAddRes &&
!xDictionary->getEntry(sWord).is())
-{
-SvxDicError(m_pSh->GetView().GetFrameWeld(), nAddRes);
-}
-}
+SfxStringItem aIgnoreString(FN_PARAM_1, m_bGrammarResults ?
OUString("IgnoreAll_Grammar") : OUString("IgnoreAll_Spelling"));
+
m_pSh->GetView().GetViewFrame()->GetDispatcher()->ExecuteList(SID_APPLY_SPELLCHECKING,
SfxCallMode::SYNCHRON, { });
}
else if ((MN_DICTIONARIES_START <= nId && nId <= MN_DICTIONARIES_END) ||
nId == m_nAddId)
{
diff --git a/sw/source/uibase/shells/textsh1.cxx
b/sw/source/uibase/shells/textsh1.cxx
index 510c25432e32..bff08a595f18 100644
--- a/sw/source/uibase/shells/textsh1.cxx
+++ b/sw/source/uibase/shells/textsh1.cxx
@@ -105,6 +105,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -126,6 +127,7 @@
#include
#include
#include
+#include
using namespace ::com::sun::star;
using namespace com::sun::star::beans;
@@ -1440,7 +1442,7 @@ void SwTextShell::Execute(SfxRequest )
const OUString sIgnoreString("Ignore");
const OUString sIgnoreAllPrefix("IgnoreAll_");
-//const OUString sSpellingRule("Spelling");
+const OUString sSpellingRule("Spelling");
const OUString sGrammarRule("Grammar");
//const OUString aReplacePrefix("Replace_");
@@ -1466,7 +1468,7 @@ void SwTextShell::Execute(SfxRequest )
bool bCorrectionRes = rWrtSh.GetGrammarCorrection(
aGrammarCheckRes, nErrorPosInText, nErrorInResult, aSuggestions, nullptr,
aToFill );
if(bCorrectionRes)
{
-try{
+try {
uno::Reference< linguistic2::XDictionary > xDictionary
= LinguMgr::GetIgnoreAllList();
aGrammarCheckRes.xProofreader->ignoreRule(
aGrammarCheckRes.aErrors[ nErrorInResult
].aRuleIdentifier,
@@ -1484,6 +1486,19 @@ void SwTextShell::Execute(SfxRequest )
}
}
}
+else if (sApplyText == sSpellingRule)
+{
+SwRect aToFill;
+uno::Reference< linguistic2::XSpellAlternatives > xSpellAlt(
rWrtSh.GetCorrection(nullptr, aToFill) );
+uno::Reference< linguistic2::XDictionary > xDictionary =
[Libreoffice-bugs] [Bug 128133] muddy fonts in LibreOffice GUI with 125% scale in Windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=128133 --- Comment #7 from Roman Kuznetsov <79045_79...@mail.ru> --- (In reply to Aron Budea from comment #6) > (In reply to Buovjaga from comment #3) > > Unfortunately, both Roman and myself get nonsensical results when > > bibisecting this! > Sharing those nonsensical results might still be helpful, as an indication. > Like this one: > https://cgit.freedesktop.org/libreoffice/core/log/ > ?id=d4ad516bc0607a1d84451dd3dc8811a4f801fa4c yep, I got this sha d4ad516bc0607a1d84451dd3dc8811a4f801fa4c five time=( -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128405] Style formatting and management - bullet and number lists continue to stay applied even changing style to a paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=128405 zionoto changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #8 from zionoto --- (In reply to Dieter Praas from comment #5) > (In reply to zionoto from comment #4) > > > Better doing with an example. > > Please attach example document, as this makes it easier for us to verify the > bug. > I have set the bug's status to 'NEEDINFO'. Please change it back to > 'UNCONFIRMED' once the requested document is provided. > (Please note that the attachment will be public, remove any sensitive > information before attaching it) I've found another problem but I think that it is the same nature, in the sense that it is due to the same cause. Try the following procedure: 1) create a new file 2) insert some generic text in it 3) then apply on it a formatting as size 8pt 4) then try to apply on it the default style: it works every where but the text you have applied the 8pt size 5) also try to modify the style it self (right click on the style name on the sidebar and then click the “Modify” item on the right click menu). Into the dialog that appears modify the text size and set it to let say 35pt (or any other size you want) then confirm and close the dialog. You will notice that all the text has updated to match the new size but the text formatted before. This persist even if I change the style of the paragraph style or the Char style from the corresponding section in the sidebar. Even this behavior in a word processing software is wired and awkward. Nevertheless IMHO I think the nature of this problem is the same of the original post of this thread. In the sense that LO Write stacks styles in an incoherent way creating this kind of result. And this cannot be the desired behavior because the logic wants that if I select a piece of text and I apply a style on it I want to overwrite the previous formatting for the same type of style. So if I apply a paragraph. Of course this strange behavior can easily make the text formatting incoherent from a paragraph to another and even inside the same paragraph even if you don't want to. I have added a new attachment. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128405] Style formatting and management - bullet and number lists continue to stay applied even changing style to a paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=128405 --- Comment #7 from zionoto --- Created attachment 156066 --> https://bugs.documentfoundation.org/attachment.cgi?id=156066=edit Write formatting problems.odt Write formatting problems.odt -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128988] New: Form control events triggered twice
https://bugs.documentfoundation.org/show_bug.cgi?id=128988 Bug ID: 128988 Summary: Form control events triggered twice Product: LibreOffice Version: 6.3.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ville...@t-online.de Created attachment 156065 --> https://bugs.documentfoundation.org/attachment.cgi?id=156065=edit Text document with form controls and a bit of macro code I'm unsure if UI is the right component to report form control issues. I noticed this when one of my database forms became unusable after upgrading from 6.2 to 6.3. My form catches double-clicks by means of the mouse release script event. Under certain conditions the event is triggered twice. This affects table controls, list boxes, combo boxes, text boxes if they are multi-line and some more controls if they have a spin button but not the spin button control. The attached text includes a simple macro and lots of form controls. The macro fires 2 message boxes when double-clicking a yellow control with LO 6.3. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source
sd/source/ui/view/drviews2.cxx |6 ++
1 file changed, 6 insertions(+)
New commits:
commit 30e0deb5d0282491af51ef1f533e738194a2d97d
Author: Samuel Mehrbrodt
AuthorDate: Thu Nov 21 15:45:26 2019 +0100
Commit: Thorsten Behrens
CommitDate: Sat Nov 23 21:26:50 2019 +0100
tdf#128932 Disable spellcheck while converting shape to bitmap
To not have red underline in the resulting bitmap
Change-Id: I5d6ae5767df8e8caf295955bdc0e5a5b6b79d45d
Reviewed-on: https://gerrit.libreoffice.org/83404
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
diff --git a/sd/source/ui/view/drviews2.cxx b/sd/source/ui/view/drviews2.cxx
index d1f037bf2b69..a31599291056 100644
--- a/sd/source/ui/view/drviews2.cxx
+++ b/sd/source/ui/view/drviews2.cxx
@@ -1104,6 +1104,10 @@ void DrawViewShell::FuTemporary(SfxRequest& rReq)
break;
case SID_CONVERT_TO_BITMAP:
{
+// Disable spelling during conversion
+bool bOnlineSpell = GetDoc()->GetOnlineSpell();
+GetDoc()->SetOnlineSpell(false);
+
// switch on undo for the next operations
mpDrawView->BegUndo(SdResId(STR_UNDO_CONVERT_TO_BITMAP));
bool bDone(false);
@@ -1130,6 +1134,8 @@ void DrawViewShell::FuTemporary(SfxRequest& rReq)
{
aGraphic =
Graphic(mpDrawView->GetMarkedObjBitmapEx());
}
+// Restore online spelling
+GetDoc()->SetOnlineSpell(bOnlineSpell);
}
break;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128983] Calc will not start FILEOPEN
https://bugs.documentfoundation.org/show_bug.cgi?id=128983 Richard OBrien changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEEDINFO|RESOLVED --- Comment #2 from Richard OBrien --- I was finally able to disable OpenGL, and I was able to open spreadsheets normally. My recent spreadsheets were locked for editing, so I had to open them as "read-only," then save with a different name. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128868] In LibreOffice Impress Console view, clicking on the scroll bar or control buttons advances the slide
https://bugs.documentfoundation.org/show_bug.cgi?id=128868 --- Comment #5 from Timur --- Please make a screenshot and mark where you click so slide advances. Since per Comment 3 this may be regression, please test with daily master LO -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - include/svx officecfg/registry svx/sdi sw/sdi sw/source
include/svx/svxids.hrc |1
officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |5 ++
svx/sdi/svx.sdi | 17
+++
sw/sdi/_textsh.sdi |6 ++
sw/source/uibase/lingu/olmenu.cxx| 11
+---
sw/source/uibase/shells/textsh1.cxx | 23
++
6 files changed, 56 insertions(+), 7 deletions(-)
New commits:
commit 51061b780ba42d2b7673de76a729a4084da5ed2b
Author: Tamás Zolnai
AuthorDate: Sat Nov 16 15:14:20 2019 +0100
Commit: Tamás Zolnai
CommitDate: Sat Nov 23 21:15:52 2019 +0100
SpellingPopup: Convert "Ignore" menu item to use a slot ID.
Introduced a new slot id SID_APPLY_SPELLING, which can be used
to apply any spelling / grammar related changes (e.g. ignore,
ignore all, replace with suggestion, add to dictionary).
In this commit, only the simple ignore is implemented.
Change-Id: I06ab84efeb955cc02ce3ff531bd8b5c20ddced9e
Reviewed-on: https://gerrit.libreoffice.org/83583
Reviewed-by: Tamás Zolnai
Tested-by: Tamás Zolnai
diff --git a/include/svx/svxids.hrc b/include/svx/svxids.hrc
index 100d2f4fbaf8..6e9cd310f9ad 100644
--- a/include/svx/svxids.hrc
+++ b/include/svx/svxids.hrc
@@ -355,6 +355,7 @@ class SvxSetItem;
#define SID_SPELL_DIALOG( SID_SVX_START + 243 )
#define SID_INSERT_DRAW ( SID_SVX_START + 244 )
#define SID_THESAURUS ( SID_SVX_START + 245 )
+#define SID_APPLY_SPELLCHECKING ( SID_SVX_START + 246 )
// CAUTION! Range <250 .. 250> used by EditEngine (!)
diff --git
a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
index 58114eef36c7..aa5173877eae 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
@@ -2678,6 +2678,11 @@
Language Status
+
+
+ Apply Spell Checking
+
+
Insert Controls
diff --git a/svx/sdi/svx.sdi b/svx/sdi/svx.sdi
index b501e546e7bb..d417b2ef9967 100644
--- a/svx/sdi/svx.sdi
+++ b/svx/sdi/svx.sdi
@@ -12169,3 +12169,20 @@ SfxVoidItem EditQrCode SID_EDIT_QRCODE
ToolBoxConfig = TRUE,
GroupId = SfxGroupId::Edit;
]
+
+SfxVoidItem ApplySpellChecking SID_APPLY_SPELLCHECKING
+(SfxStringItem ApplyRule FN_PARAM_1)
+[
+AutoUpdate = FALSE,
+FastCall = TRUE,
+ReadOnlyDoc = FALSE,
+Toggle = FALSE,
+Container = FALSE,
+RecordAbsolute = FALSE,
+RecordPerSet;
+
+AccelConfig = FALSE,
+MenuConfig = FALSE,
+ToolBoxConfig = FALSE,
+GroupId = SfxGroupId::Format;
+]
diff --git a/sw/sdi/_textsh.sdi b/sw/sdi/_textsh.sdi
index bfd47719ca35..94bcc81cd5ac 100644
--- a/sw/sdi/_textsh.sdi
+++ b/sw/sdi/_textsh.sdi
@@ -1740,5 +1740,11 @@ interface BaseText
StateMethod = GetState ;
]
+SID_APPLY_SPELLCHECKING
+[
+ExecMethod = Execute ;
+StateMethod = GetState ;
+]
+
} // end of interface text
diff --git a/sw/source/uibase/lingu/olmenu.cxx
b/sw/source/uibase/lingu/olmenu.cxx
index 23435104bfc5..e627534fdf6e 100644
--- a/sw/source/uibase/lingu/olmenu.cxx
+++ b/sw/source/uibase/lingu/olmenu.cxx
@@ -711,9 +711,8 @@ void SwSpellPopup::Execute( sal_uInt16 nId )
}
else if (nId == MN_IGNORE_SELECTION)
{
-SwPaM *pPaM = m_pSh->GetCursor();
-if (pPaM)
-SwEditShell::IgnoreGrammarErrorAt( *pPaM );
+SfxStringItem aIgnoreString(FN_PARAM_1, "Ignore");
+
m_pSh->GetView().GetViewFrame()->GetDispatcher()->ExecuteList(SID_APPLY_SPELLCHECKING,
SfxCallMode::SYNCHRON, { });
}
else if (nId == m_nIgnoreWordId)
{
diff --git a/sw/source/uibase/shells/textsh1.cxx
b/sw/source/uibase/shells/textsh1.cxx
index 41d2fbded1da..fc940da44737 100644
--- a/sw/source/uibase/shells/textsh1.cxx
+++ b/sw/source/uibase/shells/textsh1.cxx
@@ -1429,6 +1429,29 @@ void SwTextShell::Execute(SfxRequest )
}
}
break;
+case SID_APPLY_SPELLCHECKING:
+{
+OUString sApplyText;
+const SfxStringItem* pItem2 = rReq.GetArg(FN_PARAM_1);
+if (pItem2)
+sApplyText = pItem2->GetValue();
+
+const OUString sIgnoreString("Ignore");
+//const OUString sIgnoreAllPrefix("IgnoreAll_");
+//const OUString sSpellingRule("Spelling");
+//const OUString sGrammarRule("Grammar");
+//const OUString aReplacePrefix("Replace_");
+
+// Ignore the word at the cursor pos
+//sal_Int32 nPos = 0;
+if (sApplyText == sIgnoreString)
+{
+SwPaM *pPaM =
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/lingu/olmenu.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 9100f5815aedf8bf202322d2ca6d16d7d1f68228
Author: Tamás Zolnai
AuthorDate: Sat Nov 16 11:13:01 2019 +0100
Commit: Tamás Zolnai
CommitDate: Sat Nov 23 21:14:38 2019 +0100
SpellingPopup: lok: Also hide the add menu
Change-Id: Ic6b10d579fe1fb0afe5e80244e84ed456dc6cc87
Reviewed-on: https://gerrit.libreoffice.org/83579
Reviewed-by: Tamás Zolnai
Tested-by: Tamás Zolnai
diff --git a/sw/source/uibase/lingu/olmenu.cxx
b/sw/source/uibase/lingu/olmenu.cxx
index e1ef7a80621d..ccb4beeb9895 100644
--- a/sw/source/uibase/lingu/olmenu.cxx
+++ b/sw/source/uibase/lingu/olmenu.cxx
@@ -301,6 +301,7 @@ SwSpellPopup::SwSpellPopup(
{
m_xPopupMenu->HideItem(m_nCorrectDialogId);
m_xPopupMenu->HideItem(m_nAddId);
+m_xPopupMenu->HideItem(m_nAddMenuId);
}
sal_uInt16 nItemPos = m_xPopupMenu->GetItemPos(m_nIgnoreWordId);
m_xPopupMenu->InsertItem(MN_IGNORE_SELECTION, aIgnoreSelection,
MenuItemBits::NONE, OString(), nItemPos);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/lingu/olmenu.cxx |2 --
1 file changed, 2 deletions(-)
New commits:
commit 0b7a529b364b36dfc53fcf1bce139e0ced7d2bef
Author: Tamás Zolnai
AuthorDate: Sat Nov 16 10:46:28 2019 +0100
Commit: Tamás Zolnai
CommitDate: Sat Nov 23 21:14:12 2019 +0100
SpellingPopup: Remove unused variables
Change-Id: I3cb3b128ec54f82381bf6f0c17401a5d5fb58a96
Reviewed-on: https://gerrit.libreoffice.org/83578
Reviewed-by: Tamás Zolnai
Tested-by: Tamás Zolnai
diff --git a/sw/source/uibase/lingu/olmenu.cxx
b/sw/source/uibase/lingu/olmenu.cxx
index 5be1f29b859c..e1ef7a80621d 100644
--- a/sw/source/uibase/lingu/olmenu.cxx
+++ b/sw/source/uibase/lingu/olmenu.cxx
@@ -702,8 +702,6 @@ void SwSpellPopup::Execute( sal_uInt16 nId )
}
m_pSh->Left(CRSR_SKIP_CHARS, false, 1, false );
{
-uno::Reference
xDictionaryList( LinguMgr::GetDictionaryList() );
-SvxDicListChgClamp aClamp( xDictionaryList );
m_pSh->GetView().GetViewFrame()->GetDispatcher()->
Execute( FN_SPELL_GRAMMAR_DIALOG, SfxCallMode::ASYNCHRON );
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - sw/source
sw/source/core/doc/DocumentContentOperationsManager.cxx | 18 +++---
sw/source/core/inc/DocumentContentOperationsManager.hxx |3 +
sw/source/core/txtnode/thints.cxx | 48 ++--
3 files changed, 56 insertions(+), 13 deletions(-)
New commits:
commit 9ac3d5fd5580837c4d1f05d3001e6b7c7422784b
Author: Michael Stahl
AuthorDate: Thu Nov 21 13:38:38 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Nov 23 21:02:40 2019 +0100
sw: check fieldmark overlap in SwpHints::TryInsertNesting()
This is a follow-up to bd2ada701aad2c4e85d03cd8db68eaeae081d91c,
which added the check for nesting hints in MarkManager::makeMark().
Change-Id: Ife847a677514fb1aeb28dc8d6254caea365b754d
Reviewed-on: https://gerrit.libreoffice.org/83388
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit ab90d83d73b701747a56e09f71e3609a92378504)
Reviewed-on: https://gerrit.libreoffice.org/83424
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index 3b9433619ae6..731bac5b7b49 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -484,10 +484,10 @@ namespace
}
//local functions originally from sw/source/core/doc/docedt.cxx
-namespace
+namespace sw
{
-void
-lcl_CalcBreaks(std::vector> & rBreaks,
SwPaM const & rPam, bool const isOnlyFieldmarks = false)
+void CalcBreaks(std::vector> & rBreaks,
+SwPaM const & rPam, bool const isOnlyFieldmarks)
{
sal_uLong const nStartNode(rPam.Start()->nNode.GetIndex());
sal_uLong const nEndNode(rPam.End()->nNode.GetIndex());
@@ -589,13 +589,17 @@ namespace
rBreaks.insert(it, pos);
}
}
+}
+
+namespace
+{
bool lcl_DoWithBreaks(::sw::DocumentContentOperationsManager &
rDocumentContentOperations, SwPaM & rPam,
bool (::sw::DocumentContentOperationsManager::*pFunc)(SwPaM&,
bool), const bool bForceJoinNext = false)
{
std::vector> Breaks;
-lcl_CalcBreaks(Breaks, rPam);
+sw::CalcBreaks(Breaks, rPam);
if (Breaks.empty())
{
@@ -1802,7 +1806,7 @@ namespace mark
bool IsFieldmarkOverlap(SwPaM const& rPaM)
{
std::vector> Breaks;
-lcl_CalcBreaks(Breaks, rPaM);
+sw::CalcBreaks(Breaks, rPaM);
return !Breaks.empty();
}
}
@@ -3181,7 +3185,7 @@ bool DocumentContentOperationsManager::ReplaceRange(
SwPaM& rPam, const OUString
}
OSL_ENSURE((aPam.GetPoint()->nNode == aPam.GetMark()->nNode), "invalid
pam?");
-lcl_CalcBreaks(Breaks, aPam);
+sw::CalcBreaks(Breaks, aPam);
while (!Breaks.empty() // skip over prefix of dummy chars
&& (aPam.GetMark()->nNode.GetIndex() == Breaks.begin()->first)
@@ -,7 +4448,7 @@ bool DocumentContentOperationsManager::CopyImpl(SwPaM&
rPam, SwPosition& rPos,
{
std::vector> Breaks;
-lcl_CalcBreaks(Breaks, rPam, true);
+sw::CalcBreaks(Breaks, rPam, true);
if (Breaks.empty())
{
diff --git a/sw/source/core/inc/DocumentContentOperationsManager.hxx
b/sw/source/core/inc/DocumentContentOperationsManager.hxx
index bf765d291d46..21829eaf22a5 100644
--- a/sw/source/core/inc/DocumentContentOperationsManager.hxx
+++ b/sw/source/core/inc/DocumentContentOperationsManager.hxx
@@ -180,6 +180,9 @@ private:
void CopyBookmarks(const SwPaM& rPam, SwPosition& rTarget);
+void CalcBreaks(std::vector> & rBreaks,
+SwPaM const & rPam, bool const isOnlyFieldmarks = false);
+
}
#endif // INCLUDED_SW_SOURCE_CORE_INC_DOCUMENTCONTENTOPERATIONSMANAGER_HXX
diff --git a/sw/source/core/txtnode/thints.cxx
b/sw/source/core/txtnode/thints.cxx
index 1e4009a50f64..34bbe03518dc 100644
--- a/sw/source/core/txtnode/thints.cxx
+++ b/sw/source/core/txtnode/thints.cxx
@@ -21,6 +21,7 @@
#include
#include
+#include
#include
#include
#include
@@ -254,6 +255,19 @@ MakeTextAttrNesting(SwTextNode & rNode, SwTextAttrNesting
& rNesting,
typedef std::vector NestList_t;
+static NestList_t::iterator
+lcl_DoSplitImpl(NestList_t & rSplits, SwTextNode & rNode,
+NestList_t::iterator const iter, sal_Int32 const nSplitPos,
+bool const bSplitAtStart, bool const bOtherDummy)
+{
+const sal_Int32 nStartPos( // skip other's dummy character!
+(bSplitAtStart && bOtherDummy) ? nSplitPos + 1 : nSplitPos );
+SwTextAttrNesting * const pNew( MakeTextAttrNesting(
+rNode, **iter, nStartPos, *(*iter)->GetEnd() ) );
+(*iter)->SetEnd(nSplitPos);
+return rSplits.insert(iter + 1, pNew);
+}
+
static void
lcl_DoSplitNew(NestList_t & rSplits, SwTextNode & rNode,
const sal_Int32 nNewStart,
@@ -269,12 +283,7 @@ lcl_DoSplitNew(NestList_t & rSplits, SwTextNode & rNode,
} ) );
if (iter !=
[Libreoffice-bugs] [Bug 128405] Style formatting and management - bullet and number lists continue to stay applied even changing style to a paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=128405 --- Comment #6 from zionoto --- (In reply to Dieter Praas from comment #5) > (In reply to zionoto from comment #4) > > > Better doing with an example. > > Please attach example document, as this makes it easier for us to verify the > bug. > I have set the bug's status to 'NEEDINFO'. Please change it back to > 'UNCONFIRMED' once the requested document is provided. > (Please note that the attachment will be public, remove any sensitive > information before attaching it) I've added a screencast file. Is that ok? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128987] New: Bad font rendering in Writer, mainly with serif fonts: it seems like font kerning has gone awry
https://bugs.documentfoundation.org/show_bug.cgi?id=128987 Bug ID: 128987 Summary: Bad font rendering in Writer, mainly with serif fonts: it seems like font kerning has gone awry Product: LibreOffice Version: 6.3.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: shack...@gmail.com Description: This graphic glitch happens mostly with zoom factors multiple of 100%. Using serif font like Times New Roman, Liberation Serif et al., I see a little space after many characters, in particular after the lowercase m. Setting another zoom factor, like 103%, seems to reduce the effect of this bug. I don't see this behaviour in other office apps, like Microsoft Word, that render font correctly. Also, I've seen this glitch under Windows, Linux and Mac OS. Enabling or disabling OpenGL doesn't make any difference. Steps to Reproduce: 1. Set zoom at a multiple of 100% 2. Write some text in Times New Roman (or other serif font) and see how it appears 3. Set zoom at another value and note the difference Actual Results: Wrong font rendering, as described Expected Results: Better font rendering Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33495] Minimizing the presenter screen while presentation is active (UI)
https://bugs.documentfoundation.org/show_bug.cgi?id=33495 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||124438 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124438 [Bug 124438] [META] Presenter console bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124438] [META] Presenter console bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=124438 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||33495 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=33495 [Bug 33495] Minimizing the presenter screen while presentation is active (UI) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128983] Calc will not start FILEOPEN
https://bugs.documentfoundation.org/show_bug.cgi?id=128983 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Julien Nabet --- Please give a look at https://wiki.documentfoundation.org/QA/FirstSteps -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124438] [META] Presenter console bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=124438 --- Comment #1 from Roland Taylor --- There are a couple more bugs that should probably be included here: Live presentation editing: https://bugs.documentfoundation.org/show_bug.cgi?id=34965 And adding the ability to minimize the presenter console window: https://bugs.documentfoundation.org/show_bug.cgi?id=33495 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128969] File is not an absolute URL that can be passed to an external application to open it
https://bugs.documentfoundation.org/show_bug.cgi?id=128969 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from V Stuart Foote --- What is status of Tools -> Options -> Load/Save -> General: 'Save URL relative to File system'? Default is checked enabled. Looks like checking disabled would use an absolute path. =-ref-= https://help.libreoffice.org/6.5/en-US/text/shared/optionen/01010200.html?System=WIN=IMPRESS=cui/ui/optsavepage/relative_fsys#bm_id3151187 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128862] CRASH: Unable to open tables in HSQLDB odb-files with apostrophe " ' " character in table name
https://bugs.documentfoundation.org/show_bug.cgi?id=128862 --- Comment #26 from Commit Notification --- Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-6-3-4": https://git.libreoffice.org/core/commit/59c51419381a2b2532fbd0d094f62e0527e60369 tdf#128862: fix HSQLDB odb-files with apostrophe crash It will be available in 6.3.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128862] CRASH: Unable to open tables in HSQLDB odb-files with apostrophe " ' " character in table name
https://bugs.documentfoundation.org/show_bug.cgi?id=128862 Commit Notification changed: What|Removed |Added Whiteboard|target:6.5.0 target:6.4.0.1 |target:6.5.0 target:6.4.0.1 |target:6.3.5|target:6.3.5 target:6.3.4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3-4' - tools/source
tools/source/debug/debug.cxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit 59c51419381a2b2532fbd0d094f62e0527e60369
Author: Julien Nabet
AuthorDate: Tue Nov 19 23:02:20 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Nov 23 20:16:55 2019 +0100
tdf#128862: fix HSQLDB odb-files with apostrophe crash
see bt:
0 0x7209866a in std::type_info::name() const (this=0x0) at
/usr/include/c++/9/typeinfo:100
1 0x720966e1 in exceptionToStringImpl(rtl::OStringBuffer&,
com::sun::star::uno::Any const&)
(sMessage="DBG_UNHANDLED_EXCEPTION in bool
connectivity::hsqldb::OHsqlConnection::impl_isTextTable_nothrow(const
rtl::OUString&) exception: com.sun.star.sdbc.SQLException message: Unexpected
token: S in statemen"..., caught=
uno::Any("com.sun.star.sdbc.SQLException":
{ = {Message = "Unexpected token: S in
statement [s]", Context = uno::Reference to (com::sun::star::uno::XInterface *)
0x59269238}, SQLState = "37000", ErrorCode = -11, NextException =
uno::Any(void)})) at
/home/julien/lo/libreoffice/tools/source/debug/debug.cxx:113
2 0x7209855d in DbgUnhandledException(com::sun::star::uno::Any
const&, char const*, char const*, char const*, char const*) (caught=
uno::Any("com.sun.star.sdbc.SQLException":
{ = {Message = "Unexpected token: S in
statement [s]", Context = uno::Reference to (com::sun::star::uno::XInterface *)
0x59269238}, SQLState = "37000", ErrorCode = -11, NextException =
uno::Any(void)}), currentFunction=0x7fffdb5ca340 "bool
connectivity::hsqldb::OHsqlConnection::impl_isTextTable_nothrow(const
rtl::OUString&)", fileAndLineNo=0x7fffdb5ca2e8
"/home/julien/lo/libreoffice/connectivity/source/drivers/hsqldb/HConnection.cxx:301:
", area=0x7fffdb5c9f49 "connectivity.hsqldb", explanatory=0x0)
at /home/julien/lo/libreoffice/tools/source/debug/debug.cxx:418
3 0x7fffdb58a16a in
connectivity::hsqldb::OHsqlConnection::impl_isTextTable_nothrow(rtl::OUString
const&) (this=0x58a43de0, _rTableName="William Kidwell's Address Book")
at
/home/julien/lo/libreoffice/connectivity/source/drivers/hsqldb/HConnection.cxx:301
https://bugs.documentfoundation.org/attachment.cgi?id=155952
Change-Id: I2bc744164b1470d8f09bcb126b02e48af180e886
Reviewed-on: https://gerrit.libreoffice.org/83245
Tested-by: Jenkins
Reviewed-by: Julien Nabet
(cherry picked from commit c5f0e89ee5b1d13416987ddceaccc4d8a0816986)
Reviewed-on: https://gerrit.libreoffice.org/83436
Reviewed-by: Xisco Faulí
(cherry picked from commit 5fd96e4b96da471afef510c8e3c26ab3c4890881)
Reviewed-on: https://gerrit.libreoffice.org/83517
Reviewed-by: Noel Grandin
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/tools/source/debug/debug.cxx b/tools/source/debug/debug.cxx
index fdfd7259d3cf..65395a18f2aa 100644
--- a/tools/source/debug/debug.cxx
+++ b/tools/source/debug/debug.cxx
@@ -106,6 +106,7 @@ OString exceptionToString(const css::uno::Any & caught)
sMessage += " message: ";
sMessage += toOString(exception.Message);
}
+/* TODO FIXME (see https://gerrit.libreoffice.org/#/c/83245/)
if ( exception.Context.is() )
{
const char* pContext = typeid( *exception.Context.get() ).name();
@@ -120,6 +121,7 @@ OString exceptionToString(const css::uno::Any & caught)
std::free(const_cast(pContext));
#endif
}
+*/
{
css::configuration::CorruptedConfigurationException specialized;
if ( caught >>= specialized )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128926] PPS files will not play with Libre Office Impress 6.2.8
https://bugs.documentfoundation.org/show_bug.cgi?id=128926 --- Comment #8 from edwardsta...@gmail.com --- Further information. This was a brand new PC and I downloaded Libreoffice 6.2.8 and ran it with the default options it installs... this resulted in the crash I described. I recall I fiddled with safe mode and it ran ONLY ONCE (I tested moving down about 4 slides then exited as I was giddy with excitement) and crashed on all further attempts to make it run in safe mode. This would be after exiting safe mode and restarting safe mode. I then downloaded Libreoffice 6.3.3 and updated the PC. Testing with 6.3.3 I found that this does not play with OpenGL turned on. However this file does play with openGL turned off. As this particular PC has been delivered to the client I can no longer test on it with 6.2.8 for you. However I do have an interim summary of my findings and that is it may be this particular file is unique in some way I dont understand. It has problems playing with OpenGL turned on. Other PPS files I have sourced since then for comparision all played on this computer with OpenGL turned ON on 6.3.3. Thus I find it difficult to conclude if this is an issue unique to the file I was asked to trouble shoot and provided to you or if this is an issue related to the application and the OS. Perhaps you know how to parse this better. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/lingu/olmenu.cxx | 21 ++---
1 file changed, 6 insertions(+), 15 deletions(-)
New commits:
commit 8400f8ef3b5dcaec4867c27bee7ad8f7820564ad
Author: Tamás Zolnai
AuthorDate: Fri Nov 15 20:47:57 2019 +0100
Commit: Tamás Zolnai
CommitDate: Sat Nov 23 20:03:22 2019 +0100
SpellingPopup: Convert selection language items to use slot id
Change-Id: I10a89d7efa957e6b94e793158983c5acf623e511
Reviewed-on: https://gerrit.libreoffice.org/83575
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai
diff --git a/sw/source/uibase/lingu/olmenu.cxx
b/sw/source/uibase/lingu/olmenu.cxx
index 81f336ea0339..5be1f29b859c 100644
--- a/sw/source/uibase/lingu/olmenu.cxx
+++ b/sw/source/uibase/lingu/olmenu.cxx
@@ -817,29 +817,20 @@ void SwSpellPopup::Execute( sal_uInt16 nId )
}
else
{
-// Set language for selection or for paragraph...
-
-SfxItemSet aCoreSet( m_pSh->GetView().GetPool(),
-svl::Items{} );
-OUString aNewLangText;
-
if (MN_SET_LANGUAGE_SELECTION_START <= nId && nId <=
MN_SET_LANGUAGE_SELECTION_END)
{
-//Set language for current selection
-aNewLangText = m_aLangTable_Text[nId];
-SwLangHelper::SetLanguage( *m_pSh, aNewLangText, true, aCoreSet );
+SfxStringItem aLangString(SID_LANGUAGE_STATUS, "Current_" +
m_aLangTable_Text[nId]);
+
m_pSh->GetView().GetViewFrame()->GetDispatcher()->ExecuteList(SID_LANGUAGE_STATUS,
SfxCallMode::SYNCHRON, { });
}
else if (nId == MN_SET_SELECTION_NONE)
{
-//Set Language_None for current selection
-SwLangHelper::SetLanguage_None( *m_pSh, true, aCoreSet );
+SfxStringItem aLangString(SID_LANGUAGE_STATUS,
"Current_LANGUAGE_NONE");
+
m_pSh->GetView().GetViewFrame()->GetDispatcher()->ExecuteList(SID_LANGUAGE_STATUS,
SfxCallMode::SYNCHRON, { });
}
else if (nId == MN_SET_SELECTION_RESET)
{
-//reset languages for current selection
-SwLangHelper::ResetLanguages( *m_pSh );
+SfxStringItem aLangString(SID_LANGUAGE_STATUS,
"Current_RESET_LANGUAGES");
+
m_pSh->GetView().GetViewFrame()->GetDispatcher()->ExecuteList(SID_LANGUAGE_STATUS,
SfxCallMode::SYNCHRON, { });
}
else if (nId == MN_SET_SELECTION_MORE)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128438] Writer: Cannot remove tab marks in paragraph using the Paragraph dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=128438 --- Comment #9 from Markus Elfring --- (In reply to Dieter Praas from comment #4) I became also curious under which circumstances the deletion of unwanted tabulator positions will work again by the paragraph dialogue. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128879] PDF Export Problems in LO 6.3.3 but working in 6.2.6
https://bugs.documentfoundation.org/show_bug.cgi?id=128879 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||103378 Keywords||filter:pdf, filter:svg Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103378 [Bug 103378] [META] PDF export bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||128879 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=128879 [Bug 128879] PDF Export Problems in LO 6.3.3 but working in 6.2.6 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128944] LibreOffice Crash using LXQT 0.14.1
https://bugs.documentfoundation.org/show_bug.cgi?id=128944 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #8 from Roman Kuznetsov <79045_79...@mail.ru> --- Hector, please show us info from Help->About LibreOffice dialog -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128985] FILESAVE, FILEOPEN: Style text directionss revert to RTL on save and re-open
https://bugs.documentfoundation.org/show_bug.cgi?id=128985 --- Comment #1 from Eyal Rozenberg --- Created attachment 156064 --> https://bugs.documentfoundation.org/attachment.cgi?id=156064=edit Presentation with the bug manifesting -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||128978 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=128978 [Bug 128978] Exported PDF files are too big -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128978] Exported PDF files are too big
https://bugs.documentfoundation.org/show_bug.cgi?id=128978 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128978] Exported PDF files are too big
https://bugs.documentfoundation.org/show_bug.cgi?id=128978 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||103378 Component|LibreOffice |Printing and PDF export Keywords||filter:pdf, ||possibleRegression CC||79045_79...@mail.ru --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Paolo, please attach example ODT file here Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103378 [Bug 103378] [META] PDF export bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128984] Total crash on selecting printer
https://bugs.documentfoundation.org/show_bug.cgi?id=128984 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Paul, please add info from Help->About LibreOffice dialog. Is your printer network or locale? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
