[Libreoffice-commits] online.git: test/data test/integration-http-server.cpp

[Michael Meeks (via logerrit)]

 test/data/convert-to.xlsx|binary
 test/integration-http-server.cpp |   40 +++
 2 files changed, 40 insertions(+)

New commits:
commit f95cc10438f0cc3d584a6badc33256eb548db4e3
Author: Michael Meeks 
AuthorDate: Thu Dec 12 05:33:09 2019 +
Commit: Michael Meeks 
CommitDate: Thu Dec 12 08:57:28 2019 +0100

A new convert-to unit test, hopefully taking longer to load.

Change-Id: I8d8291e272a175ab3c846b692bb34b185b2b8278
Reviewed-on: https://gerrit.libreoffice.org/85008
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Michael Meeks 

diff --git a/test/data/convert-to.xlsx b/test/data/convert-to.xlsx
new file mode 100644
index 0..7af9e7063
Binary files /dev/null and b/test/data/convert-to.xlsx differ
diff --git a/test/integration-http-server.cpp b/test/integration-http-server.cpp
index c19c57904..a2ceaca92 100644
--- a/test/integration-http-server.cpp
+++ b/test/integration-http-server.cpp
@@ -51,6 +51,7 @@ class HTTPServerTest : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST(testScriptsAndLinksGet);
 CPPUNIT_TEST(testScriptsAndLinksPost);
 CPPUNIT_TEST(testConvertTo);
+CPPUNIT_TEST(testConvertTo2);
 CPPUNIT_TEST(testConvertToWithForwardedClientIP);
 
 CPPUNIT_TEST_SUITE_END();
@@ -62,6 +63,7 @@ class HTTPServerTest : public CPPUNIT_NS::TestFixture
 void testScriptsAndLinksGet();
 void testScriptsAndLinksPost();
 void testConvertTo();
+void testConvertTo2();
 void testConvertToWithForwardedClientIP();
 
 public:
@@ -375,6 +377,44 @@ void HTTPServerTest::testConvertTo()
 CPPUNIT_ASSERT_EQUAL(expectedStream.str(), actualString);
 }
 
+void HTTPServerTest::testConvertTo2()
+{
+const std::string srcPath = FileUtil::getTempFilePath(TDOC, 
"convert-to.xlsx", "convertTo_");
+std::unique_ptr 
session(helpers::createSession(_uri));
+session->setTimeout(Poco::Timespan(5, 0)); // 5 seconds.
+
+Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_POST, 
"/lool/convert-to");
+Poco::Net::HTMLForm form;
+form.setEncoding(Poco::Net::HTMLForm::ENCODING_MULTIPART);
+form.set("format", "png");
+form.addPart("data", new Poco::Net::FilePartSource(srcPath));
+form.prepareSubmit(request);
+try
+{
+form.write(session->sendRequest(request));
+}
+catch (const std::exception& ex)
+{
+// In case the server is still starting up.
+sleep(2);
+form.write(session->sendRequest(request));
+}
+
+Poco::Net::HTTPResponse response;
+std::stringstream actualStream;
+std::istream& responseStream = session->receiveResponse(response);
+Poco::StreamCopier::copyStream(responseStream, actualStream);
+
+// Remove the temp files.
+FileUtil::removeFile(srcPath);
+
+std::string actualString = actualStream.str();
+CPPUNIT_ASSERT(actualString.size() >= 100);
+//  CPPUNIT_ASSERT_EQUAL(actualString[0], 0x89);
+CPPUNIT_ASSERT_EQUAL(actualString[1], 'P');
+CPPUNIT_ASSERT_EQUAL(actualString[2], 'N');
+CPPUNIT_ASSERT_EQUAL(actualString[3], 'G');
+}
 
 void HTTPServerTest::testConvertToWithForwardedClientIP()
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 127493] With or without "Create PDF form", Export to PDF always exports modifiable fields to PDF (workaround: print)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127493

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127493] With or without "Create PDF form", Export to PDF always exports modifiable fields to PDF (workaround: print)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127493

--- Comment #13 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b06cba8f13e0b71346cb884cf827751f2086fd8e

tdf#127493 store ExportFormFields checkbox value

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: filter/source

[Jan-Marek Glogowski (via logerrit)]

 filter/source/pdf/impdialog.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit b06cba8f13e0b71346cb884cf827751f2086fd8e
Author: Jan-Marek Glogowski 
AuthorDate: Wed Dec 11 19:14:31 2019 +0100
Commit: Thorsten Behrens 
CommitDate: Thu Dec 12 08:41:44 2019 +0100

tdf#127493 store ExportFormFields checkbox value

... and also correctly set the initial frames sensitivity.

The commit removed the no longer needed UserSelection variant of
mbExportFormFields but forgit to actually set it now.

Regression from my commit 76fcd878da1624e73f1eb9d9405485d4faf66edf.

Change-Id: Ia5fcc1c37e2e4b4a330b59a492f817d2db8d7347
Reviewed-on: https://gerrit.libreoffice.org/84975
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx
index 1d49f17f3087..8d852d0e847e 100644
--- a/filter/source/pdf/impdialog.cxx
+++ b/filter/source/pdf/impdialog.cxx
@@ -574,6 +574,7 @@ void 
ImpPDFTabGeneralPage::SetFilterConfigItem(ImpPDFTabDialog* pParent)
 
 mxLbFormsFormat->set_active(static_cast(pParent->mnFormsType));
 mxCbAllowDuplicateFieldNames->set_active( 
pParent->mbAllowDuplicateFieldNames );
+mxFormsFrame->set_sensitive(pParent->mbExportFormFields);
 
 mxCbExportBookmarks->set_active( pParent->mbExportBookmarks );
 
@@ -688,6 +689,7 @@ void ImpPDFTabGeneralPage::GetFilterConfigItem( 
ImpPDFTabDialog* pParent )
 else
 mbUseTaggedPDFUserSelection = pParent->mbUseTaggedPDF;
 pParent->mbUseTaggedPDFUserSelection = mbUseTaggedPDFUserSelection;
+pParent->mbExportFormFields = mxCbExportFormFields->get_active();
 
 if( mxCbWatermark->get_active() )
 pParent->maWatermarkText = mxEdWatermark->get_text();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp wsd/DocumentBroker.hpp wsd/LOOLWSD.cpp

[Michael Meeks (via logerrit)]

 wsd/DocumentBroker.cpp |   74 +++--
 wsd/DocumentBroker.hpp |   17 +--
 wsd/LOOLWSD.cpp|   63 +
 3 files changed, 89 insertions(+), 65 deletions(-)

New commits:
commit 948b424abbb3ee493d148896492d18186e3507f2
Author: Michael Meeks 
AuthorDate: Thu Dec 12 05:09:35 2019 +
Commit: Michael Meeks 
CommitDate: Thu Dec 12 07:42:42 2019 +0100

convert-to: wait for load to complete before attempting the save.

Change-Id: Iee3a8a6720bbc29fc4e113bf705f405b840e1e45
Reviewed-on: https://gerrit.libreoffice.org/85009
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index af756c676..700a56fbf 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -2195,14 +2195,64 @@ size_t ConvertToBroker::getInstanceCount()
 
 ConvertToBroker::ConvertToBroker(const std::string& uri,
  const Poco::URI& uriPublic,
- const std::string& docKey)
-: DocumentBroker(uri, uriPublic, docKey)
+ const std::string& docKey,
+ const std::string& format,
+ const std::string& sOptions) :
+DocumentBroker(uri, uriPublic, docKey),
+_format(format),
+_sOptions(sOptions)
 {
 static const int limit_convert_secs = 
LOOLWSD::getConfigValue("per_document.limit_convert_secs", 100);
 NumConverters++;
 _limitLifeSeconds = limit_convert_secs;
 }
 
+bool ConvertToBroker::startConversion(SocketDisposition , const 
std::string )
+{
+std::shared_ptr docBroker = 
std::static_pointer_cast(shared_from_this());
+
+// Create a session to load the document.
+const bool isReadOnly = true;
+_clientSession = std::make_shared(id, docBroker, 
getPublicUri(), isReadOnly, "nocliphost");
+_clientSession->construct();
+
+if (!_clientSession)
+return false;
+
+disposition.setMove([docBroker] (const std::shared_ptr )
+{
+// Perform all of this after removing the socket
+
+// Make sure the thread is running before adding callback.
+docBroker->startThread();
+
+// We no longer own this socket.
+moveSocket->setThreadOwner(std::thread::id(0));
+
+docBroker->addCallback([docBroker, moveSocket]()
+ {
+ auto streamSocket = 
std::static_pointer_cast(moveSocket);
+ docBroker->_clientSession->setSaveAsSocket(streamSocket);
+
+ // Move the socket into DocBroker.
+ docBroker->addSocketToPoll(moveSocket);
+
+ // First add and load the session.
+ docBroker->addSession(docBroker->_clientSession);
+
+ // Load the document manually and request saving in the 
target format.
+ std::string encodedFrom;
+ Poco::URI::encode(docBroker->getPublicUri().getPath(), 
"", encodedFrom);
+ const std::string load = "load url=" + encodedFrom;
+ std::vector loadRequest(load.begin(), load.end());
+ docBroker->_clientSession->handleMessage(true, 
WSOpCode::Text, loadRequest);
+
+ // Save is done in the setLoaded
+ });
+});
+return true;
+}
+
 void ConvertToBroker::dispose()
 {
 if (!_uriOrig.empty())
@@ -2233,6 +2283,26 @@ void ConvertToBroker::removeFile(const std::string 
)
 }
 }
 
+void ConvertToBroker::setLoaded()
+{
+DocumentBroker::setLoaded();
+
+// FIXME: Check for security violations.
+Poco::Path toPath(getPublicUri().getPath());
+toPath.setExtension(_format);
+const std::string toJailURL = "file://" + 
std::string(JAILED_DOCUMENT_ROOT) + toPath.getFileName();
+std::string encodedTo;
+Poco::URI::encode(toJailURL, "", encodedTo);
+
+// Convert it to the requested format.
+const std::string saveAsCmd = "saveas url=" + encodedTo + " format=" + 
_format + " options=" + _sOptions;
+
+// Send the save request ...
+std::vector saveasRequest(saveAsCmd.begin(), saveAsCmd.end());
+
+_clientSession->handleMessage(true, WSOpCode::Text, saveasRequest);
+}
+
 std::vector> 
DocumentBroker::getSessionsTestOnlyUnsafe()
 {
 std::vector> result;
diff --git a/wsd/DocumentBroker.hpp b/wsd/DocumentBroker.hpp
index 3b8f6e844..5632c56b6 100644
--- a/wsd/DocumentBroker.hpp
+++ b/wsd/DocumentBroker.hpp
@@ -245,7 +245,8 @@ public:
 /// Thread safe termination of this broker if it has a lingering thread
 void joinThread();
 
-void setLoaded();
+/// Notify that the load has completed
+virtual void setLoaded();
 
 bool isDocumentChangedInStorage() { return _documentChangedInStorage; }
 
@@ -518,16 +519,28 @@ private:
 
 class ConvertToBroker : 

[Libreoffice-commits] core.git: sc/inc

[Stephan Bergmann (via logerrit)]

 sc/inc/scitems.hxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 658ace95837d49a21e2788e5dcc534a08198dc12
Author: Stephan Bergmann 
AuthorDate: Wed Dec 11 23:47:31 2019 +0100
Commit: Stephan Bergmann 
CommitDate: Thu Dec 12 07:41:11 2019 +0100

Fix UBSan dynamic-type-mismatch

...as seen after 331cafb1484597544bd94fa3f0e0a45b3328a4d8 "Related: 
tdf#129300
add ScLineBreakCell to provide a description" during CppunitTest_sc_ucalc:

> sc/inc/patattr.hxx:76:14: runtime error: downcast of address 
0x60200056aaf0 which does not point to an object of type 'const 
ScShrinkToFitCell'
> 0x60200056aaf0: note: object is of type 'ScVerticalStackCell'
>  6f 00 00 60  70 7b f7 16 b0 7f 00 00  ff ff ff ff 86 00 02 00  02 00 00 
00 ff ff ff 04  10 00 00 00
>   ^~~
>   vptr for 'ScVerticalStackCell'
>  #0 in ScShrinkToFitCell const& 
ScPatternAttr::GetItem(TypedWhichId, 
SfxItemSet const&, SfxItemSet const*) at sc/inc/patattr.hxx:76:14
>  #1 in ScPatternAttr::GetCellOrientation(SfxItemSet const&, SfxItemSet 
const*) at sc/source/core/data/patattr.cxx:152:9
>  #2 in ScPatternAttr::GetCellOrientation(SfxItemSet const*) const at 
sc/source/core/data/patattr.cxx:170:12
>  #3 in ScColumn::GetOptimalHeight(sc::RowHeightContext&, int, int, 
unsigned short, int) at sc/source/core/data/column2.cxx:809:43
>  #4 in (anonymous 
namespace)::GetOptimalHeightsInColumn(sc::RowHeightContext&, ScColContainer&, 
int, int, ScProgress*, unsigned long) at sc/source/core/data/table1.cxx:92:17
>  #5 in ScTable::SetOptimalHeight(sc::RowHeightContext&, int, int, 
ScProgress*, unsigned long) at sc/source/core/data/table1.cxx:466:5
>  #6 in ScDocument::SetOptimalHeight(sc::RowHeightContext&, int, int, 
short) at sc/source/core/data/document.cxx:4274:18
>  #7 in ScDocFunc::AdjustRowHeight(ScRange const&, bool) at 
sc/source/ui/docshell/docfunc.cxx:156:26
>  #8 in ScDocFunc::InsertCells(ScRange const&, ScMarkData const*, 
InsCellCmd, bool, bool, bool) at sc/source/ui/docshell/docfunc.cxx:2146:25
>  #9 in Test::testFormulaRefUpdateInsertRows() at 
sc/qa/unit/ucalc_formula.cxx:2247:11

Change-Id: I12b95a8229bac8d67d85f2a5a90a5e2e286a6981
Reviewed-on: https://gerrit.libreoffice.org/84996
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sc/inc/scitems.hxx b/sc/inc/scitems.hxx
index 6e5054d7757d..9e22a0415aeb 100644
--- a/sc/inc/scitems.hxx
+++ b/sc/inc/scitems.hxx
@@ -52,7 +52,7 @@ class SvxBoxItem;
 class ScCondFormatItem;
 class ScLineBreakCell;
 class ScRotateValueItem;
-class ScShrinkToFitCell;
+class ScVerticalStackCell;
 class SvxLineItem;
 class SvxRotateModeItem;
 class SfxStringItem;
@@ -120,7 +120,7 @@ class SvxSizeItem;
 #define ATTR_INDENT TypedWhichId(131)
 #define ATTR_VER_JUSTIFYTypedWhichId(132)
 #define ATTR_VER_JUSTIFY_METHOD TypedWhichId(133)
-#define ATTR_STACKEDTypedWhichId(134)
+#define ATTR_STACKEDTypedWhichId(134)
 #define ATTR_ROTATE_VALUE   TypedWhichId(135)
 #define ATTR_ROTATE_MODETypedWhichId(136)
 #define ATTR_VERTICAL_ASIAN TypedWhichId(137)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 126988] ANY FIELD of ARGUMENT of ANY function it is impossible to add a link to the data in another file with the mouse

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126988

astrel  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #4 from astrel  ---

Here is a special case of this error:
http://bugs.documentfoundation.org/attachment.cgi?id=156501


"peter 2019-12-12 04:20:21 UTC
Dear :
step 1 :

please create  2  excel files ;


step 2:

use the  function: vlooup ;


  pls try  it , the test  is very  easy , u can found the error ;


 thank  you very much!
[tag] [reply] [−]Comment 24astrel 2019-12-12 05:50:16 UTC
To play, be sure to use the function wizard and mouse 
[tag] [reply] [−]Comment 25Mike Kaganski 2019-12-12 06:00:38 UTC
Created attachment 156501 [details]
Screencast of using wizard with VLOOKUP"

https://bugs.documentfoundation.org/show_bug.cgi?id=124513#add_comment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 127294] Add more tips of the day (and make it module-specific eventually)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127294

--- Comment #59 from Commit Notification 
 ---
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/2c1e9249247ffd67f931a063047cd1690aac0aa6

tdf#127294 one new tip of the day; clarification of three existing tips

It will be available in 6.4.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 127294] Add more tips of the day (and make it module-specific eventually)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127294

--- Comment #59 from Commit Notification 
 ---
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/2c1e9249247ffd67f931a063047cd1690aac0aa6

tdf#127294 one new tip of the day; clarification of three existing tips

It will be available in 6.4.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - 2 commits - cui/inc instsetoo_native/inc_ooohelppack instsetoo_native/inc_openoffice

[Seth Chaiklin (via logerrit)]

 cui/inc/tipoftheday.hrc|7 
---
 instsetoo_native/inc_ooohelppack/windows/msi_templates/Control.idt |8 
+---
 instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf  |5 +
 3 files changed, 14 insertions(+), 6 deletions(-)

New commits:
commit 2c1e9249247ffd67f931a063047cd1690aac0aa6
Author: Seth Chaiklin 
AuthorDate: Tue Dec 10 13:42:40 2019 +0100
Commit: Heiko Tietze 
CommitDate: Thu Dec 12 07:10:40 2019 +0100

tdf#127294 one new tip of the day; clarification of three existing tips

1.  It seems that inserting images in shapes only works in Writer, so
added correction to make this tip Writer-specific.

2.  Added a tip about how to insert images and photos to shapes in
Draw and Impress.

3.  Small wording adjustment in two other tips

Change-Id: Ife6d7164af294803ca0ec50487b1e2d7b6a9d75a
Reviewed-on: https://gerrit.libreoffice.org/84830
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 
(cherry picked from commit d115fabdc6927bfcc48e7e7be5bad546c66b11ad)
Reviewed-on: https://gerrit.libreoffice.org/84958
Reviewed-by: Seth Chaiklin 

diff --git a/cui/inc/tipoftheday.hrc b/cui/inc/tipoftheday.hrc
index 8c62a80822be..060fdd97c24a 100644
--- a/cui/inc/tipoftheday.hrc
+++ b/cui/inc/tipoftheday.hrc
@@ -65,7 +65,7 @@ const std::tuple 
TIPOFTHEDAY_STRINGARRAY[] =
  { NC_("RID_CUI_TIPOFTHEDAY", "Use View > Value Highlighting to display 
cell contents in colors: Text/black, Formulas/green, Numbers/blue, Protected 
cells/grey background."), 
"https://help.libreoffice.org/%PRODUCTVERSION/%LANGUAGENAME/text/scalc/01/0308.html;,
 "tipoftheday_c.png"}, //local help missing
  { NC_("RID_CUI_TIPOFTHEDAY", "Create different master pages in a 
presentation template: View > Master Slide and Slide > New Master (or per 
toolbar or right click in slide pane)."), "", "tipoftheday_i.png"},
  { NC_("RID_CUI_TIPOFTHEDAY", "Want to sort a pivot table? Click on 
drop-list's arrow in the row/col header and select sort method: ascending, 
descending, or custom."), "", "tipoftheday_c.png"},
- { NC_("RID_CUI_TIPOFTHEDAY", "Display photos or images with different 
shapes. Insert and select shape, then Insert > Image. To adjust image, 
right-click on selected shape and choose Area."), "", ""},
+ { NC_("RID_CUI_TIPOFTHEDAY", "Display photos or images with different 
shapes in Writer. Insert and select shape, then Insert > Image. To adjust 
image, right-click on selected shape and choose Area."), "", 
"tipoftheday_w.png"},
  { NC_("RID_CUI_TIPOFTHEDAY", "Use Page/Slide > Properties > 'Fit object 
to paper format' in Draw/Impress to resize the objects so that they fit on your 
chosen paper format."), "", "tipoftheday_d.png"},
  { NC_("RID_CUI_TIPOFTHEDAY", "Fit the entire page in a Draw window, use * 
on the number pad."), "", "tipoftheday_d.png"},
  { NC_("RID_CUI_TIPOFTHEDAY", "In a Draw page, use '-' to zoom out; '+' to 
zoom in."), "", "tipoftheday_d.png"},
@@ -77,9 +77,10 @@ const std::tuple 
TIPOFTHEDAY_STRINGARRAY[] =
  { NC_("RID_CUI_TIPOFTHEDAY", "Ctrl+Shift+F9 recalculates all formulas in 
all spreadsheets."), "", "tipoftheday_c.png"},
  { NC_("RID_CUI_TIPOFTHEDAY", "Use the Backspace key instead of Delete in 
Calc. You can choose what to delete."), "", "tipoftheday_c.png"},
  { NC_("RID_CUI_TIPOFTHEDAY", "Best way to fix bad-looking MS Word table 
cells via Table > Size > Optimal Row Height / Column Width."), "", 
"tipoftheday_w.png"},
- { NC_("RID_CUI_TIPOFTHEDAY", "Repeat the heading on a subsequent page 
when a table spans over more than one page with Table > Table Properties > Text 
Flow > Repeat heading."), "", "tipoftheday_w.png"},
+ { NC_("RID_CUI_TIPOFTHEDAY", "To repeat a table heading when a table 
spans over a page, use Table > Table Properties > Text Flow > Repeat 
heading."), "", "tipoftheday_w.png"},
  { NC_("RID_CUI_TIPOFTHEDAY", "To quickly insert or delete rows, select 
the desired number of rows (or columns) and press Ctrl+ to add or Ctrl- to 
delete."), "", "tipoftheday_c.png"},
  { NC_("RID_CUI_TIPOFTHEDAY", "To repeat rows/columns on every pages use 
Format > Print Ranges > Edit."), "", "tipoftheday_c.png"},
+ { NC_("RID_CUI_TIPOFTHEDAY", "Insert images and photos into shapes in 
Draw and Impress. Right-click on a shape, choose Area > Bitmap > Add/Import, 
and use Options to adjust appearance."), "", ""},
  { NC_("RID_CUI_TIPOFTHEDAY", "Need to insert the date in a spreadsheet 
cell? Type Ctrl+; or Shift+Ctrl+; to insert the time."), "", 
"tipoftheday_c.png"},
  { NC_("RID_CUI_TIPOFTHEDAY", "Insert your metadata in your document with 
Insert > Fields > More Fields… > Document or DocInformation."), "", 
"tipoftheday_w.png"},
  { NC_("RID_CUI_TIPOFTHEDAY", "Get help from the community via the Ask 
portal."), "https://ask.libreoffice.org;, ""},
@@ -107,7 +108,7 @@ const std::tuple 

[Libreoffice-bugs] [Bug 70975] Support for (Markdown and) reStructuredText RST

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70975

--- Comment #15 from roshni  ---

Nice blog, the article you have shared is good.This article 
is very useful. My friend suggest me to use this blog.

https://makegooglemyhomepage.co/

https://myhrcvslogin.co/

https://kahoot-login.com/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124918] iOS App Crashes with Invalid Template URL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124918

--- Comment #10 from Mosin Motte  ---
Source - https://manchesterwebdesigncompany.co.uk/ios-iphone-app-development/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74721] Some server connection types don't work (WebDAV, SSH, Windows share)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=74721

--- Comment #5 from Mosin Motte  ---
Resource -
http://xplormedia.com/web-hosting/top-10-best-web-hosting-companies-in-india/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118052] Libreoffice cannot copy paste from VirtualBox hosted Windows XP VM with 5.4.7

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=118052

--- Comment #19 from Mosin Motte  ---
There are several renowned and reliable web hosting service providers in the
market today. The leading web hosting service providers are known for their
excellent security of stored website data, the ease and swiftness of connection
between user computer and server as well as the ability to grow with increasing
user traffic and demands. In addition to excellent server features, the best
web hosting service providers will also offer extensive add-ons and additional
features to include in your server subscription package. All-round customer
support for website owners is also an important way to identify the best web
hosting services.

Source - http://www.webhostingreviewsx.co.uk/uk2-net/
https://hosting-reviews.co.uk/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128397] Crashes after chart manipulation in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128397

--- Comment #2 from aquafo...@sikharchives.com ---
Crashes after chart manipulation is doing work first time. It took sometime to
understand it. And that is only good when we have complete
https://www.bestessays-uk.org/write-my-paper site. When we start to do
manipulation then working is really good.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109329] [META] VLookup function bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109329
Bug 109329 depends on bug 124513, which changed state.

Bug 124513 Summary: Calc: Unable to reference cells in another workbook using 
mouse from Function Wizard
https://bugs.documentfoundation.org/show_bug.cgi?id=124513

   What|Removed |Added

 Status|VERIFIED|UNCONFIRMED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129333] calc autocalculate quite simple case still buggy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129333

QA Administrators  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128763] Libre Office very slow if Offline Help installed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128763

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127742] Cell with Arabic (only?) text that starts with LTR character is rendered incorrectly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127742

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128954] Multiple instances of global menu entries

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128954

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128990] UI enhancement wish: editable NOTE pane while in NORMAL view + slide editable from the NOTE view

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128990

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128886] LibreOffice Calc stops updating link to external after about 40 minutes.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128886

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128888] Transparent objects causing excessive CPU usage when exporting PNG from LO Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=12

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 128990] UI enhancement wish: editable NOTE pane while in NORMAL view + slide editable from the NOTE view

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128990

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 128705] Cyrillic and other non-latin filenames saved as ?????'s on KDE

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128705

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128852] Vertical artifacts on the left of the external presentation-screen in Linux with Cinnamon

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128852

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128426] Swapping two commands' keyboard shortcuts is not easy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128426

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128832] make cell RTL is not effective on render text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128832

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128999] EDITING:find replaces "\n" in document with newline formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128999

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128915] Installation error - GetTempFileNameW failed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128915

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125970] Export to JPG/GIF generates low quality image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125970

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128843] enhancement: if text is already in a section, ask for confirmation before linking a file in the section

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128843

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126456] Writer Export To PDF button's hint under MacOS, Chinese characters are not displayed properly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126456

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127919] Assign Component dialog F1/Help button behave inconsistently

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127919

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129048] Open remote for Onedrive does not finish after getting code and completing sentence to send. Gives message Invalid device. Using 6.3.3.2 Linux

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129048

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129046] EDITING:find search for font "times new roman" gives unstable results

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129046

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129230] Alignment problem? - Significant Offsets and vertically streched when Cropping Image in LibreOffice Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129230

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128999] EDITING:find replaces "\n" in document with newline formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128999

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128852] Vertical artifacts on the left of the external presentation-screen in Linux with Cinnamon

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128852

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121479] text is pasted with strikethrough format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121479

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129319] Copy/Paste Problem

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129319

--- Comment #8 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129230] Alignment problem? - Significant Offsets and vertically streched when Cropping Image in LibreOffice Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129230

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125029] Menus prefer going up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125029

--- Comment #6 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129293] Kde5 VCL: Buttons are different from Breeze style ones

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129293

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128852] Vertical artifacts on the left of the external presentation-screen in Linux with Cinnamon

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128852

--- Comment #4 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129319] Copy/Paste Problem

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129319

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129293] Kde5 VCL: Buttons are different from Breeze style ones

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129293

--- Comment #4 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125029] Menus prefer going up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125029

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128999] EDITING:find replaces "\n" in document with newline formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128999

--- Comment #4 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121479] text is pasted with strikethrough format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121479

--- Comment #6 from QA Administrators  ---
Dear raal,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82164] FILEOPEN: MS ODT - Table of Contents has wrong style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82164

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94587] [META] ODF features missing or incorrectly imported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94587
Bug 94587 depends on bug 82164, which changed state.

Bug 82164 Summary: FILEOPEN: MS ODT - Table of Contents has wrong style
https://bugs.documentfoundation.org/show_bug.cgi?id=82164

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102593
Bug 102593 depends on bug 121479, which changed state.

Bug 121479 Summary: text is pasted with strikethrough format
https://bugs.documentfoundation.org/show_bug.cgi?id=121479

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82164] FILEOPEN: MS ODT - Table of Contents has wrong style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82164

--- Comment #16 from QA Administrators  ---
Dear Yousuf Philips (jay) (retired),

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89606] [META] Table of Contents and Indexes bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89606
Bug 89606 depends on bug 82164, which changed state.

Bug 82164 Summary: FILEOPEN: MS ODT - Table of Contents has wrong style
https://bugs.documentfoundation.org/show_bug.cgi?id=82164

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125910] Not calculating formula in existing sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125910

--- Comment #2 from QA Administrators  ---
Dear fabianosidler,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104438] The subscript in a Formula is clipped vertically, if the Formula is in the last line of a paragraph

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104438

--- Comment #4 from QA Administrators  ---
Dear thomas.koehler.rovema,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd.xml.in wsd/DocumentBroker.cpp wsd/DocumentBroker.hpp wsd/LOOLWSD.cpp

[Michael Meeks (via logerrit)]

 loolwsd.xml.in |1 +
 wsd/DocumentBroker.cpp |   22 ++
 wsd/DocumentBroker.hpp |2 ++
 wsd/LOOLWSD.cpp|1 +
 4 files changed, 26 insertions(+)

New commits:
commit 83e02ab38b4ffee6c350d1ba01bc8c7e89c02b77
Author: Michael Meeks 
AuthorDate: Thu Dec 12 03:38:50 2019 +
Commit: Michael Meeks 
CommitDate: Thu Dec 12 03:38:50 2019 +

Add a time limit for badly behaved / huge document conversions.

Handles problems with load, save, and lingering DocumentBrokers.

Change-Id: I6079cba3a4fa2a84c303b3a8669d94863a04f474

diff --git a/loolwsd.xml.in b/loolwsd.xml.in
index 6b81a4385..71f6b8f6f 100644
--- a/loolwsd.xml.in
+++ b/loolwsd.xml.in
@@ -29,6 +29,7 @@
 0
 0
 100
+100
 
 
 
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 1fb51b513..af756c676 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -175,6 +175,7 @@ std::atomic DocumentBroker::DocBrokerId(1);
 DocumentBroker::DocumentBroker(const std::string& uri,
const Poco::URI& uriPublic,
const std::string& docKey) :
+_limitLifeSeconds(0),
 _uriOrig(uri),
 _uriPublic(uriPublic),
 _docKey(docKey),
@@ -314,6 +315,22 @@ void DocumentBroker::pollThread()
 continue;
 }
 
+if (_limitLifeSeconds > 0 &&
+std::chrono::duration_cast(now - 
_threadStart).count() > _limitLifeSeconds)
+{
+LOG_WRN("Doc [" << _docKey << "] is taking too long to convert. 
Will kill process ["
+<< _childProcess->getPid() << "]. 
per_document.limit_convert_secs set to "
+<< _limitLifeSeconds << " secs.");
+broadcastMessage("error: cmd=load kind=docexpired");
+
+// Brutal but effective.
+if (_childProcess)
+_childProcess->terminate();
+
+stop("Load timed out");
+continue;
+}
+
 if (std::chrono::duration_cast
 (now - lastBWUpdateTime).count() >= COMMAND_TIMEOUT_MS)
 {
@@ -2181,7 +2198,9 @@ ConvertToBroker::ConvertToBroker(const std::string& uri,
  const std::string& docKey)
 : DocumentBroker(uri, uriPublic, docKey)
 {
+static const int limit_convert_secs = 
LOOLWSD::getConfigValue("per_document.limit_convert_secs", 100);
 NumConverters++;
+_limitLifeSeconds = limit_convert_secs;
 }
 
 void ConvertToBroker::dispose()
@@ -2252,11 +2271,14 @@ void DocumentBroker::dumpState(std::ostream& os)
 os << "\n  doc key: " << _docKey;
 os << "\n  doc id: " << _docId;
 os << "\n  num sessions: " << _sessions.size();
+os << "\n  thread start: " << Util::getSteadyClockAsString(_threadStart);
 os << "\n  last saved: " << Util::getSteadyClockAsString(_lastSaveTime);
 os << "\n  last save request: " << 
Util::getSteadyClockAsString(_lastSaveRequestTime);
 os << "\n  last save response: " << 
Util::getSteadyClockAsString(_lastSaveResponseTime);
 os << "\n  last modifed: " << Util::getHttpTime(_documentLastModifiedTime);
 os << "\n  file last modifed: " << 
Util::getHttpTime(_lastFileModifiedTime);
+if (_limitLifeSeconds)
+os << "\n  life limit in seconds: " << _limitLifeSeconds;
 os << "\n  idle time: " << getIdleTimeSecs();
 os << "\n  cursor " << _cursorPosX << ", " << _cursorPosY
   << "( " << _cursorWidth << "," << _cursorHeight << ")\n";
diff --git a/wsd/DocumentBroker.hpp b/wsd/DocumentBroker.hpp
index 19c88e4c4..3b8f6e844 100644
--- a/wsd/DocumentBroker.hpp
+++ b/wsd/DocumentBroker.hpp
@@ -443,6 +443,8 @@ private:
 void getIOStats(uint64_t , uint64_t );
 
 protected:
+/// Seconds to live for, or 0 forever
+int64_t _limitLifeSeconds;
 std::string _uriOrig;
 private:
 const Poco::URI _uriPublic;
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index faa399756..524415b6f 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -835,6 +835,7 @@ void LOOLWSD::initialize(Application& self)
 { "per_document.limit_file_size_mb", "0" },
 { "per_document.limit_num_open_files", "0" },
 { "per_document.limit_load_secs", "100" },
+{ "per_document.limit_convert_secs", "100" },
 { "per_document.limit_stack_mem_kb", "8000" },
 { "per_document.limit_virt_mem_mb", "0" },
 { "per_document.max_concurrency", "4" },
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 98284] FILEOPEN: doc import: What's "MACRO CARRIER"?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98284

--- Comment #3 from QA Administrators  ---
Dear Aldo,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72910] FORMATTING: Column Break in a new DOC file in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72910

--- Comment #7 from QA Administrators  ---
Dear Abram,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96629] FILESAVE: equations change positioning after reopening particular DOCX ('To Character' saved 'As Character')

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96629

--- Comment #7 from QA Administrators  ---
Dear ale.carrazzoni,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96560] arrows change when exporting to doc in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96560

--- Comment #5 from QA Administrators  ---
Dear yuval aviel,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125907] Libre Office (Writer) Text Selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125907

--- Comment #2 from QA Administrators  ---
Dear Laurie,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: io/test

[Andrea Gelmini (via logerrit)]

 io/test/stm/pumptest.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 911d848e60ab57d5d865290dcf2a5aa28a7df854
Author: Andrea Gelmini 
AuthorDate: Wed Dec 11 22:17:45 2019 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu Dec 12 04:14:02 2019 +0100

Fix typo

Change-Id: Ie1a06014d989f51141a15c724ab026f5423335de
Reviewed-on: https://gerrit.libreoffice.org/84995
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/io/test/stm/pumptest.cxx b/io/test/stm/pumptest.cxx
index e00d840f3a75..f0563153e91b 100644
--- a/io/test/stm/pumptest.cxx
+++ b/io/test/stm/pumptest.cxx
@@ -317,7 +317,7 @@ void OPumpTest::testClose( const Reference< XInterface >  
)
 ERROR_ASSERT( ! t.m_pTestListener->m_bStarted , "started too early" );
 ERROR_ASSERT( ! t.m_pTestListener->m_bTerminated , "termination 
unexpected" );
 ERROR_ASSERT( ! t.m_pTestListener->m_bError, "unexpected error" );
-ERROR_ASSERT( ! t.m_pTestListener->m_bClosed, "unexpected clase" );
+ERROR_ASSERT( ! t.m_pTestListener->m_bClosed, "unexpected close" );
 
 t.m_rControl->start();
 mywait();
@@ -325,7 +325,7 @@ void OPumpTest::testClose( const Reference< XInterface >  
)
 ERROR_ASSERT( t.m_pTestListener->m_bStarted , "should have been started 
already" );
 ERROR_ASSERT( ! t.m_pTestListener->m_bTerminated , "termination 
unexpected" );
 ERROR_ASSERT( ! t.m_pTestListener->m_bError, "unexpected error" );
-ERROR_ASSERT( ! t.m_pTestListener->m_bClosed, "unexpected clase" );
+ERROR_ASSERT( ! t.m_pTestListener->m_bClosed, "unexpected close" );
 
 Reference< XStreamListener > rListener( new TestListener() );
 t.m_rControl->addListener( rListener );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/gtk3/gtk3gtkinst.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit 6f1f1af8b7abb1597c7a83249658fe977729ddcf
Author: Caolán McNamara 
AuthorDate: Wed Dec 11 14:22:30 2019 +
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu Dec 12 04:13:13 2019 +0100

Resolves: tdf#128867 support LocalizedDecimalSep for native gtk dialogs

Change-Id: Idb883707fb89d1f76b24ea592c51e28fffd2322f
Reviewed-on: https://gerrit.libreoffice.org/84954
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 090275da6e97..186b3f2bb2a0 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -1627,6 +1627,10 @@ public:
 , m_nDragDropReceivedSignalId(0)
 , m_nDragLeaveSignalId(0)
 {
+// tdf#128867 if localize decimal separator is active we will always
+// need to be able to change the output of the decimal key press
+if 
(Application::GetSettings().GetMiscSettings().GetEnableLocalizedDecimalSep())
+m_nKeyPressSignalId = g_signal_connect(m_pWidget, 
"key-press-event", G_CALLBACK(signalKey), this);
 }
 
 virtual void connect_key_press(const Link& rLink) 
override
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - cui/source

[Caolán McNamara (via logerrit)]

 cui/source/tabpages/align.cxx |5 +
 1 file changed, 5 insertions(+)

New commits:
commit 0476613b0150b706cbff80d08c6983793c7fd612
Author: Caolán McNamara 
AuthorDate: Tue Dec 10 20:15:27 2019 +
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu Dec 12 04:07:06 2019 +0100

tdf#129300 If it would create no change, don't force it

otherwise a bogus "change" from the parent style is shown in the organizer

this dates to...

commit 755ad6834625488c5d31d4bacc9370eae7ffd8f3
Date:   Tue Oct 5 11:15:56 2010 -0400

Ported calc-distributed-cell-text-*.diff from ooo-build.

Change-Id: I49fc654a232d3c0f43f8add9a9f9fee34a6c5add
Reviewed-on: https://gerrit.libreoffice.org/84895
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
Reviewed-on: https://gerrit.libreoffice.org/84985
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/cui/source/tabpages/align.cxx b/cui/source/tabpages/align.cxx
index b4f1a2b9ad73..559cb88755a3 100644
--- a/cui/source/tabpages/align.cxx
+++ b/cui/source/tabpages/align.cxx
@@ -98,6 +98,11 @@ void lcl_SetJustifyMethodToItemSet(SfxItemSet& rSet, 
sal_uInt16 nWhichJM, const
 if (rLB.get_active() == nListPos)
 eJM = SvxCellJustifyMethod::Distribute;
 
+// tdf#129300 If it would create no change, don't force it
+const SvxJustifyMethodItem& rOldItem = static_cast(rSet.Get(nWhichJM));
+if (rOldItem.GetValue() == eJM)
+return;
+
 SvxJustifyMethodItem aItem(eJM, nWhichJM);
 rSet.Put(aItem);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - editeng/source include/editeng

[Caolán McNamara (via logerrit)]

 editeng/source/items/justifyitem.cxx |   64 +++
 include/editeng/justifyitem.hxx  |2 -
 2 files changed, 59 insertions(+), 7 deletions(-)

New commits:
commit 844c56230fde10bd62269ed14aa7f7e10edb2ea2
Author: Caolán McNamara 
AuthorDate: Tue Dec 10 11:37:25 2019 +
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu Dec 12 04:05:25 2019 +0100

tdf#129300 alignment enums not translated in organizer

because they used the trick that the original ids
were contiguous integers

Change-Id: I4405100f26241dd84c26155529d3961d5082ee9e
Reviewed-on: https://gerrit.libreoffice.org/84814
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/editeng/source/items/justifyitem.cxx 
b/editeng/source/items/justifyitem.cxx
index 1b9701356bdc..976226e97671 100644
--- a/editeng/source/items/justifyitem.cxx
+++ b/editeng/source/items/justifyitem.cxx
@@ -57,7 +57,7 @@ bool SvxHorJustifyItem::GetPresentation
 MapUnit /*ePresUnit*/,
 OUString&   rText, const IntlWrapper&)const
 {
-rText = GetValueText( static_cast(GetValue()) );
+rText = GetValueText( GetValue() );
 return true;
 }
 
@@ -159,10 +159,33 @@ bool SvxHorJustifyItem::PutValue( const uno::Any& rVal, 
sal_uInt8 nMemberId )
 }
 
 
-OUString SvxHorJustifyItem::GetValueText( sal_uInt16 nVal )
+OUString SvxHorJustifyItem::GetValueText( SvxCellHorJustify nVal )
 {
-DBG_ASSERT( nVal <= sal_uInt16(SvxCellHorJustify::Repeat), "enum 
overflow!" );
-return EditResId(RID_SVXITEMS_HORJUST_STANDARD + nVal);
+DBG_ASSERT( nVal <= SvxCellHorJustify::Repeat, "enum overflow!" );
+
+OUString sRet;
+switch (nVal)
+{
+case SvxCellHorJustify::Standard:
+sRet = EditResId(RID_SVXITEMS_HORJUST_STANDARD);
+break;
+case SvxCellHorJustify::Left:
+sRet = EditResId(RID_SVXITEMS_HORJUST_LEFT);
+break;
+case SvxCellHorJustify::Center:
+sRet = EditResId(RID_SVXITEMS_HORJUST_CENTER);
+break;
+case SvxCellHorJustify::Right:
+sRet = EditResId(RID_SVXITEMS_HORJUST_RIGHT);
+break;
+case SvxCellHorJustify::Block:
+sRet = EditResId(RID_SVXITEMS_HORJUST_BLOCK);
+break;
+case SvxCellHorJustify::Repeat:
+sRet = EditResId(RID_SVXITEMS_HORJUST_REPEAT);
+break;
+}
+return sRet;
 }
 
 
@@ -289,7 +312,26 @@ bool SvxVerJustifyItem::PutValue( const uno::Any& rVal, 
sal_uInt8 nMemberId )
 OUString SvxVerJustifyItem::GetValueText( SvxCellVerJustify nVal )
 {
 DBG_ASSERT( nVal <= SvxCellVerJustify::Bottom, "enum overflow!" );
-return EditResId(RID_SVXITEMS_VERJUST_STANDARD + static_cast(nVal));
+
+OUString sRet;
+switch (nVal)
+{
+case SvxCellVerJustify::Standard:
+sRet = EditResId(RID_SVXITEMS_VERJUST_STANDARD);
+break;
+case SvxCellVerJustify::Top:
+sRet = EditResId(RID_SVXITEMS_VERJUST_TOP);
+break;
+case SvxCellVerJustify::Center:
+sRet = EditResId(RID_SVXITEMS_VERJUST_CENTER);
+break;
+case SvxCellVerJustify::Bottom:
+sRet = EditResId(RID_SVXITEMS_VERJUST_BOTTOM);
+break;
+default:
+break;
+}
+return sRet;
 }
 
 
@@ -362,7 +404,17 @@ bool SvxJustifyMethodItem::PutValue( const uno::Any& rVal, 
sal_uInt8 /*nMemberId
 
 OUString SvxJustifyMethodItem::GetValueText( SvxCellJustifyMethod nVal )
 {
-return EditResId(RID_SVXITEMS_JUSTMETHOD_AUTO + static_cast(nVal));
+OUString sRet;
+switch (nVal)
+{
+case SvxCellJustifyMethod::Auto:
+sRet = EditResId(RID_SVXITEMS_JUSTMETHOD_AUTO);
+break;
+case SvxCellJustifyMethod::Distribute:
+sRet = EditResId(RID_SVXITEMS_JUSTMETHOD_DISTRIBUTE);
+break;
+}
+return sRet;
 }
 
 
diff --git a/include/editeng/justifyitem.hxx b/include/editeng/justifyitem.hxx
index c53a7b83b744..7f619e4120b5 100644
--- a/include/editeng/justifyitem.hxx
+++ b/include/editeng/justifyitem.hxx
@@ -45,7 +45,7 @@ public:
 virtual bool PutValue( const css::uno::Any& rVal, sal_uInt8 
nMemberId ) override;
 
 virtual sal_uInt16   GetValueCount() const override;
-static OUString  GetValueText( sal_uInt16 nVal );
+static OUString  GetValueText( SvxCellHorJustify nVal );
 virtual SfxPoolItem* Clone( SfxItemPool *pPool = nullptr ) const 
override;
 
 SvxHorJustifyItem(SvxHorJustifyItem const &) = default; // SfxPoolItem 
copy function dichotomy
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 108626] LibreOffice Writer comment boxes are too small and should be resizable ( THIS BUG IS BLOCKED - DO NOT WRITE NEW COMMENTS )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108626

Desert safari  changed:

   What|Removed |Added

   Keywords||difficultyBeginner
URL||https://www.busrentdubai.ae
   ||/cheap-desert-safari-dubai/

--- Comment #8 from Desert safari  ---
I didn't get the details here. What are these all about.
I have some issues and bugs. How can I report it here. 
I am from Dubai Desert safari

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 55946] FILEOPEN: Word document with multiple objects/frames on cover page formatted wrong

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=55946

ni shengyue  changed:

   What|Removed |Added

Version|3.4.3 release   |6.3.2.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 55946] FILEOPEN: Word document with multiple objects/frames on cover page formatted wrong

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=55946

--- Comment #21 from ni shengyue  ---
(In reply to QA Administrators from comment #19)
> ** Please read this message in its entirety before responding **
> 
> To make sure we're focusing on the bugs that affect our users today,
> LibreOffice QA is asking bug reporters and confirmers to retest open,
> confirmed bugs which have not been touched for over a year.
> 
> There have been thousands of bug fixes and commits since anyone checked on
> this bug report. During that time, it's possible that the bug has been
> fixed, or the details of the problem have changed. We'd really appreciate
> your help in getting confirmation that the bug is still present.
> 
> If you have time, please do the following:
> 
> Test to see if the bug is still present with the latest version of
> LibreOffice from https://www.libreoffice.org/download/
> 
> If the bug is present, please leave a comment that includes the information
> from Help - About LibreOffice.
>  
> If the bug is NOT present, please set the bug's Status field to
> RESOLVED-WORKSFORME and leave a comment that includes the information from
> Help - About LibreOffice.
> 
> Please DO NOT
> 
> Update the version field
> Reply via email (please reply directly on the bug tracker)
> Set the bug's Status field to RESOLVED - FIXED (this status has a particular
> meaning that is not 
> appropriate in this case)
> 
> 
> If you want to do more to help you can test to see if your issue is a
> REGRESSION. To do so:
> 1. Download and install oldest version of LibreOffice (usually 3.3 unless
> your bug pertains to a feature added after 3.3) from
> http://downloadarchive.documentfoundation.org/libreoffice/old/
> 
> 2. Test your bug
> 3. Leave a comment with your results.
> 4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
> 4b. If the bug was not present in 3.3 - add 'regression' to keyword
> 
> 
> Feel free to come ask questions or to say hello in our QA chat:
> https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa
> 
> Thank you for helping us make LibreOffice even better for everyone!
> 
> Warm Regards,
> QA Team
> 
> MassPing-UntouchedBug

I tested with Libreoffice Writer , and find the bug is still exist:
DISTRIB_ID=ManjaroLinux
DISTRIB_RELEASE=18.1.4

and my OS is:
Libreoffice Writer Version: 6.3.3.2.0+
Build ID: 6.3.3-1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129262] Exporting a large document as EPUB hangs the system

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129262

Adolfo Jayme  changed:

   What|Removed |Added

   Keywords||perf

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129264] "Warning: failed to read path from javaldx" even with Java disabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129264

Adolfo Jayme  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Priority|medium  |low
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129336] The libre writer can't display the document correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129336

ni shengyue  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEEDINFO|RESOLVED

--- Comment #3 from ni shengyue  ---


*** This bug has been marked as a duplicate of bug 55946 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 55946] FILEOPEN: Word document with multiple objects/frames on cover page formatted wrong

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=55946

ni shengyue  changed:

   What|Removed |Added

 CC||nsy...@qq.com

--- Comment #20 from ni shengyue  ---
*** Bug 129336 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83009] [META] Bugs requiring the use of the Infobar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83009

Adolfo Jayme  changed:

   What|Removed |Added

 Depends on||129005


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129005
[Bug 129005] Infobar does not indicate that it has focus
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83009] [META] Bugs requiring the use of the Infobar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83009
Bug 83009 depends on bug 129005, which changed state.

Bug 129005 Summary: Infobar does not indicate that it has focus
https://bugs.documentfoundation.org/show_bug.cgi?id=129005

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83009] [META] Bugs requiring the use of the Infobar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83009

Adolfo Jayme  changed:

   What|Removed |Added

 Depends on|129005  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129005
[Bug 129005] Infobar does not indicate that it has focus
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129005] Infobar does not indicate that it has focus

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129005

Adolfo Jayme  changed:

   What|Removed |Added

 Blocks||83009
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |rayk...@gmail.com
   |desktop.org |
   Priority|lowest  |medium
 Status|NEW |RESOLVED


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83009
[Bug 83009] [META] Bugs requiring the use of the Infobar
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105830] [META] Infobar behaviour and appearance issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105830

Adolfo Jayme  changed:

   What|Removed |Added

 Depends on||129005


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129005
[Bug 129005] Infobar does not indicate that it has focus
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - vcl/source

[Michael Meeks (via logerrit)]

 vcl/source/window/floatwin.cxx |9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

New commits:
commit 19722a41a2f3f9231702f9508840b6124d290a0a
Author: Michael Meeks 
AuthorDate: Thu Dec 12 01:44:23 2019 +
Commit: Ashod Nakashian 
CommitDate: Thu Dec 12 03:36:31 2019 +0100

lok: vcl: fix multiple floatwin removal case.

We need to progress in our while loop to remove children, even if
they are currently not in popup-mode; fixes infinite loop with two
popups present concurrently.

Change-Id: I4926ef8c88152dbf532ccd3fdb8e28ca2d0c62d3
Reviewed-on: https://gerrit.libreoffice.org/85000
Reviewed-by: Ashod Nakashian 
Tested-by: Jenkins CollaboraOffice 

diff --git a/vcl/source/window/floatwin.cxx b/vcl/source/window/floatwin.cxx
index bef5dfc13069..55784bdb2aa2 100644
--- a/vcl/source/window/floatwin.cxx
+++ b/vcl/source/window/floatwin.cxx
@@ -818,9 +818,6 @@ void FloatingWindow::StartPopupMode( ToolBox* pBox, 
FloatWinPopupFlags nFlags )
 
 void FloatingWindow::ImplEndPopupMode( FloatWinPopupEndFlags nFlags, const 
VclPtr& xFocusId )
 {
-if ( !mbInPopupMode )
-return;
-
 ImplSVData* pSVData = ImplGetSVData();
 
 mbInCleanUp = true; // prevent killing this window due to focus change 
while working with it
@@ -833,6 +830,12 @@ void FloatingWindow::ImplEndPopupMode( 
FloatWinPopupEndFlags nFlags, const VclPt
 pSVData->mpWinData->mpFirstFloat = mpNextFloat;
 mpNextFloat = nullptr;
 
+if ( !mbInPopupMode )
+{
+mbInCleanUp = false;
+return;
+}
+
 FloatWinPopupFlags nPopupModeFlags = mnPopupModeFlags;
 mbPopupModeTearOff = nFlags & FloatWinPopupEndFlags::TearOff &&
  nPopupModeFlags & FloatWinPopupFlags::AllowTearOff;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 129332] Writer: Autotext adds a line feed, and inserts text with a fixed font size

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129332

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||vstuart.fo...@utsa.edu

--- Comment #1 from V Stuart Foote  ---
Thanks for filing, but can not confirm on Windows 10 with current 6.3.3.2
release. The Autotext entry made into a paragraph where the nemonic is entered
will pick up the direct formatting or the style applied to the paragraph.

As the 6.1 build is well past EOL, are you able to update and test with a
current release?  At the least, please either reset your profile, or use the
'Restart in Safe Mode..." from the Help menu to get a clean user profile and
retest.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - vcl/source

[Michael Meeks (via logerrit)]

 vcl/source/app/help.cxx |   19 +--
 1 file changed, 13 insertions(+), 6 deletions(-)

New commits:
commit 435659fd7e401353fc114246813b811190362293
Author: Michael Meeks 
AuthorDate: Wed Dec 11 23:58:08 2019 +
Commit: Michael Meeks 
CommitDate: Thu Dec 12 01:14:04 2019 +0100

lok: avoid crash cleaning up help-windows with multiple views.

Change-Id: Ic57018396de7730d9fa4fb3b4803a221cb9678da
Reviewed-on: https://gerrit.libreoffice.org/84999
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

diff --git a/vcl/source/app/help.cxx b/vcl/source/app/help.cxx
index b7cf9f4d4b6b..784dc3ea86fb 100644
--- a/vcl/source/app/help.cxx
+++ b/vcl/source/app/help.cxx
@@ -573,13 +573,20 @@ void ImplDestroyHelpWindow( bool bUpdateHideTime )
 void ImplDestroyHelpWindow(ImplSVHelpData& rHelpData, bool bUpdateHideTime)
 {
 VclPtr pHelpWin = rHelpData.mpHelpWin;
-if ( pHelpWin )
+if( pHelpWin )
 {
-vcl::Window * pWindow = pHelpWin->GetParent()->ImplGetFrameWindow();
-// find out screen area covered by system help window
-tools::Rectangle aInvRect( pHelpWin->GetWindowExtentsRelative( pWindow 
) );
-if( pHelpWin->IsVisible() )
-pWindow->Invalidate( aInvRect );
+vcl::Window * pParent = pHelpWin->GetParent();
+if( pParent )
+{
+VclPtr pWindow( pParent->ImplGetFrameWindow() );
+if( pWindow )
+{
+// find out screen area covered by system help window
+tools::Rectangle aInvRect( pHelpWin->GetWindowExtentsRelative( 
pWindow ) );
+if( pHelpWin->IsVisible() )
+pWindow->Invalidate( aInvRect );
+}
+}
 rHelpData.mpHelpWin = nullptr;
 rHelpData.mbKeyboardHelp = false;
 pHelpWin->Hide();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - chart2/source

[Ashod Nakashian (via logerrit)]

 chart2/source/controller/main/ChartWindow.cxx  |1 +
 chart2/source/controller/sidebar/ChartSidebarModifyListener.cxx|7 
++-
 chart2/source/controller/sidebar/ChartSidebarSelectionListener.cxx |7 
+++
 3 files changed, 14 insertions(+), 1 deletion(-)

New commits:
commit d4c52ebce80e6ea9dbfa0ca47b50272fab71c546
Author: Ashod Nakashian 
AuthorDate: Wed Dec 11 18:19:43 2019 -0500
Commit: Ashod Nakashian 
CommitDate: Thu Dec 12 01:12:45 2019 +0100

chart2: clear listener parents in dispose

Change-Id: Icdab125589ab0f55255f683a1ea39e036de661b1
Reviewed-on: https://gerrit.libreoffice.org/84997
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Ashod Nakashian 

diff --git a/chart2/source/controller/main/ChartWindow.cxx 
b/chart2/source/controller/main/ChartWindow.cxx
index 57f245fe8db4..41e2664d1e9d 100644
--- a/chart2/source/controller/main/ChartWindow.cxx
+++ b/chart2/source/controller/main/ChartWindow.cxx
@@ -75,6 +75,7 @@ ChartWindow::~ChartWindow()
 
 void ChartWindow::dispose()
 {
+m_pWindowController = nullptr;
 m_pViewShellWindow.clear();
 vcl::Window::dispose();
 }
diff --git a/chart2/source/controller/sidebar/ChartSidebarModifyListener.cxx 
b/chart2/source/controller/sidebar/ChartSidebarModifyListener.cxx
index b000e55c5aa6..0fa0b793b5b6 100644
--- a/chart2/source/controller/sidebar/ChartSidebarModifyListener.cxx
+++ b/chart2/source/controller/sidebar/ChartSidebarModifyListener.cxx
@@ -27,12 +27,17 @@ ChartSidebarModifyListener::~ChartSidebarModifyListener()
 
 void ChartSidebarModifyListener::modified(const css::lang::EventObject& 
/*rEvent*/)
 {
-mpParent->updateData();
+if (mpParent)
+mpParent->updateData();
 }
 
 void ChartSidebarModifyListener::disposing(const css::lang::EventObject& 
/*rEvent*/)
 {
+if (!mpParent)
+return;
+
 mpParent->modelInvalid();
+mpParent = nullptr;
 }
 
 } }
diff --git a/chart2/source/controller/sidebar/ChartSidebarSelectionListener.cxx 
b/chart2/source/controller/sidebar/ChartSidebarSelectionListener.cxx
index 19f4335e0b49..65d7bc9ce350 100644
--- a/chart2/source/controller/sidebar/ChartSidebarSelectionListener.cxx
+++ b/chart2/source/controller/sidebar/ChartSidebarSelectionListener.cxx
@@ -41,6 +41,9 @@ 
ChartSidebarSelectionListener::~ChartSidebarSelectionListener()
 
 void ChartSidebarSelectionListener::selectionChanged(const 
css::lang::EventObject& rEvent)
 {
+if (!mpParent)
+return;
+
 bool bCorrectObjectSelected = false;
 
 css::uno::Reference xController(rEvent.Source, 
css::uno::UNO_QUERY);
@@ -66,7 +69,11 @@ void ChartSidebarSelectionListener::selectionChanged(const 
css::lang::EventObjec
 
 void ChartSidebarSelectionListener::disposing(const css::lang::EventObject& 
/*rEvent*/)
 {
+if (!mpParent)
+return;
+
 mpParent->SelectionInvalid();
+mpParent = nullptr;
 }
 
 void ChartSidebarSelectionListener::setAcceptedTypes(const 
std::vector& aTypes)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 128674] Do not use "System" bitmap font on the MSI package

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128674

Ming Hua  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=99
   ||891

--- Comment #5 from Ming Hua  ---
The font change was made as a fix for bug 99891.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128741] Always Wrong Icon Theme Selection In GTK3 Backend

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128741

--- Comment #10 from Rizal Muttaqin  ---
OK it's resolved in

Version: 6.5.0.0.alpha0+
Build ID: d5d8fa63282a433da9c49d811f04390b8d6ab9cc
CPU threads: 4; OS: Linux 5.0; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2019-12-11_04:03:13
Locale: id-ID (id_ID.UTF-8); UI-Language: en-US
Calc: threaded

Thank you Bogdan and Caolan!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126565] Import XML data in a new sheet does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126565

Rizal Muttaqin  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #5 from Rizal Muttaqin  ---
OK here my testing come

When importing to the Sheet2 (A new sheet) with "Mapped cell: $A$1" the XML
content go to Sheet1

But with addition in "Mapped cell: $Sheet2.$A$1" then the XML content go to
Sheet2.

Is this happen by design? By default without defining Sheet variable the
content go to Sheet1. I just think this is a little bit misleading, without
defining $Sheet variable the content SHOULD BE go to THE active sheet.

Tested with
Version: 6.5.0.0.alpha0+
Build ID: d5d8fa63282a433da9c49d811f04390b8d6ab9cc
CPU threads: 4; OS: Linux 5.0; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2019-12-11_04:03:13
Locale: id-ID (id_ID.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125029] Menus prefer going up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125029

--- Comment #5 from JL  ---
Hurrah! The problem seems to be solved. Menus now go down by preference if
there is space for them to do so. 

Many thanks to those involved in implementing the cure.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: android/README

[Michael Meeks (via logerrit)]

 android/README |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit a72392cc57399523fb133250983279b65e571172
Author: Michael Meeks 
AuthorDate: Wed Dec 11 22:52:55 2019 +
Commit: Michael Meeks 
CommitDate: Wed Dec 11 22:53:14 2019 +

android: improve debugging readme.

Change-Id: I4d1933e38c7cb0fd4d28b4384e11f35f2c9e8626

diff --git a/android/README b/android/README
index eb34c511b..4606ef3a3 100644
--- a/android/README
+++ b/android/README
@@ -113,7 +113,8 @@ to setup lldb to actually read & use them.
 
   This path contains the non-stripped version of the liblo-native-code.so, and
   the debugger will read the symbols from that one (even if the APK contains
-  the stripped version).
+  the stripped version). *NB* ensure that this is before any internal source
+  directories - since the internal source contains stripped native code.
 
   [Alternatively you can add the following to your ~/.lldbinit instead:
 
@@ -129,6 +130,8 @@ to setup lldb to actually read & use them.
 From now on, you will be able to debug directly in the Android Studio
 debugger.  Happy debugging!
 
+Note: to re-buld your app with a newly compiled libnative-lo code - it is 
+
 == Tip: How to speed up your core.git build ==
 
 If you use icecream for parallel building, you can use it for
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125516] crash on preview of slide transitions, or in slideshow, when OpenGL rendering enabled Windows 10, with Intel DCH packaged driver 26.20.100.6861 (2019-05-14) and newer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125516

--- Comment #28 from V Stuart Foote  ---
So at the day job, I dug out a Dell Lattitude E5470 laptop with i5-6440HQ
Skylake cpu w/HD Graphcis 530, updated Windows 10 to 1903 build and updated.

had "legacy" 22.20.16.4799 (9/13/2017) Graphics packaging.

Tested OpenGL slide transitions on it with LibreOffice TB77 daily for
2019-12-10 64-bit build--no issues with the .4799 build rendering gl
transitions (Fade, Ripple).

Enabled the 'Ignore OpenGL black list', and sequentially installed and tested
Intel DCH drivers. 

Test results for the DCH packaged builds (only checked the Fade & Ripple gl
transition):

25.20.100.6519 (1/16/2019) -- no issues

26.20.100.6708 (4/18/2019) -- no issues

26.20.100.6861 (5/15/2019) -- crashes

26.20.100.7463 (11/6.2019) -- crashes

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/svx sc/CppunitTest_sc_shapetest.mk sc/Module_sc.mk sc/qa sc/source svx/source

[Regina Henschel (via logerrit)]

 include/svx/svdoashp.hxx   |1 
 sc/CppunitTest_sc_shapetest.mk |   53 +
 sc/Module_sc.mk|1 
 sc/qa/unit/data/ods/tdf119191_FitToCellSize.ods|binary
 sc/qa/unit/data/ods/tdf119191_transformedShape.ods |binary
 sc/qa/unit/scshapetest.cxx |  189 +
 sc/source/core/data/drwlayer.cxx   |5 
 sc/source/ui/view/drawvie4.cxx |6 
 svx/source/svdraw/svdoashp.cxx |   66 +++
 9 files changed, 318 insertions(+), 3 deletions(-)

New commits:
commit f44140bebb9c493d97ba5aef26c9692c53a6b93f
Author: Regina Henschel 
AuthorDate: Thu Nov 28 19:28:29 2019 +0100
Commit: Regina Henschel 
CommitDate: Wed Dec 11 23:42:39 2019 +0100

tdf#119191 Implement SdrObjCustomShape::AdjustToMaxRect

and use in ScDrawLayer::RecalcPos and in ScDrawView::FitToCellSize().
Error was, that it was assumed, that SdObjCustomShape::SetSnapRect()
changes the shape so, that it fits into the passed rectangle. That is
true for other type of shapes, but not for custom shapes.

Change-Id: Ib00d52087509f459165000abf43c7f244980a01b
Reviewed-on: https://gerrit.libreoffice.org/84216
Tested-by: Jenkins
Reviewed-by: Regina Henschel 

diff --git a/include/svx/svdoashp.hxx b/include/svx/svdoashp.hxx
index 02b957de95a0..ff51e20ec974 100644
--- a/include/svx/svdoashp.hxx
+++ b/include/svx/svdoashp.hxx
@@ -172,6 +172,7 @@ public:
 virtual void Shear(const Point& rRef, long nAngle, double tn, bool 
bVShear) override;
 virtual void SetSnapRect(const tools::Rectangle& rRect) override;
 virtual void SetLogicRect(const tools::Rectangle& rRect) override;
+virtual void AdjustToMaxRect( const tools::Rectangle& rMaxRect, bool 
bShrinkOnly = false ) override;
 
 virtual void NbcMove(const Size& rSiz) override;
 virtual void NbcResize(const Point& rRef, const Fraction& xFact, const 
Fraction& yFact) override;
diff --git a/sc/CppunitTest_sc_shapetest.mk b/sc/CppunitTest_sc_shapetest.mk
new file mode 100644
index ..cf97cf99da13
--- /dev/null
+++ b/sc/CppunitTest_sc_shapetest.mk
@@ -0,0 +1,53 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#*
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+#*
+
+$(eval $(call gb_CppunitTest_CppunitTest,sc_shapetest))
+
+$(eval $(call gb_CppunitTest_use_external,sc_shapetest,boost_headers))
+
+$(eval $(call gb_CppunitTest_use_common_precompiled_header,sc_shapetest))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,sc_shapetest, \
+sc/qa/unit/scshapetest \
+))
+
+$(eval $(call gb_CppunitTest_use_libraries,sc_shapetest, \
+cppu \
+sal \
+sc \
+sfx \
+subsequenttest \
+svx \
+svxcore \
+test \
+tl \
+unotest \
+utl \
+))
+
+$(eval $(call gb_CppunitTest_set_include,sc_shapetest,\
+-I$(SRCDIR)/sc/source/ui/inc \
+-I$(SRCDIR)/sc/inc \
+$$(INCLUDE) \
+))
+
+$(eval $(call gb_CppunitTest_use_sdk_api,sc_shapetest))
+
+$(eval $(call gb_CppunitTest_use_ure,sc_shapetest))
+$(eval $(call gb_CppunitTest_use_vcl,sc_shapetest))
+
+$(eval $(call gb_CppunitTest_use_components,sc_shapetest,\
+$(sc_unoapi_common_components) \
+))
+
+$(eval $(call gb_CppunitTest_use_configuration,sc_shapetest))
+
+# vim: set noet sw=4 ts=4:
diff --git a/sc/Module_sc.mk b/sc/Module_sc.mk
index cbe32e32ebc2..d52537f1c908 100644
--- a/sc/Module_sc.mk
+++ b/sc/Module_sc.mk
@@ -48,6 +48,7 @@ $(eval $(call gb_Module_add_check_targets,sc,\
CppunitTest_sc_dataprovider \
CppunitTest_sc_datatransformation \
CppunitTest_sc_cache_test \
+CppunitTest_sc_shapetest \
 ))
 
 ifneq ($(DISABLE_GUI),TRUE)
diff --git a/sc/qa/unit/data/ods/tdf119191_FitToCellSize.ods 
b/sc/qa/unit/data/ods/tdf119191_FitToCellSize.ods
new file mode 100644
index ..ff43af5f7589
Binary files /dev/null and b/sc/qa/unit/data/ods/tdf119191_FitToCellSize.ods 
differ
diff --git a/sc/qa/unit/data/ods/tdf119191_transformedShape.ods 
b/sc/qa/unit/data/ods/tdf119191_transformedShape.ods
new file mode 100644
index ..c3936a269627
Binary files /dev/null and b/sc/qa/unit/data/ods/tdf119191_transformedShape.ods 
differ
diff --git a/sc/qa/unit/scshapetest.cxx b/sc/qa/unit/scshapetest.cxx
new file mode 100644
index ..8e3cbe2c7802
--- /dev/null
+++ b/sc/qa/unit/scshapetest.cxx
@@ -0,0 +1,189 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code 

[Libreoffice-commits] core.git: compilerplugins/clang

[Andrea Gelmini (via logerrit)]

 compilerplugins/clang/unusedmember.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2ae964f88a4f1002a4fd8a804a079559c3d64196
Author: Andrea Gelmini 
AuthorDate: Wed Dec 11 22:17:27 2019 +0100
Commit: Julien Nabet 
CommitDate: Wed Dec 11 22:54:29 2019 +0100

Fix typo

Change-Id: Iffb9bcf5bfb18591dedfea62875bae76c772b7e2
Reviewed-on: https://gerrit.libreoffice.org/84994
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/compilerplugins/clang/unusedmember.cxx 
b/compilerplugins/clang/unusedmember.cxx
index 214d66556e40..bf1166c14db5 100644
--- a/compilerplugins/clang/unusedmember.cxx
+++ b/compilerplugins/clang/unusedmember.cxx
@@ -360,7 +360,7 @@ public:
 layout = true;
 break;
 }
-// Heuristic to recursivley check parent RecordDecl if 
given RecordDecl is
+// Heuristic to recursively check parent RecordDecl if 
given RecordDecl is
 // unnamed and either an anonymous struct (or union, but 
which are already
 // filtered out anyway), or defined in a non-static data 
member declaration
 // (TODO: which is erroneously approximated here with 
getTypedefNameForAnonDecl
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - include/sfx2 include/vcl sc/source sd/source sfx2/source svx/source sw/source

[Szymon Kłos (via logerrit)]

 include/sfx2/lokhelper.hxx  |2 -
 include/sfx2/viewsh.hxx |1 
 include/vcl/IDialogRenderable.hxx   |1 
 sc/source/ui/drawfunc/drawsh2.cxx   |4 ---
 sd/source/ui/view/drviewsf.cxx  |4 ---
 sfx2/source/control/unoctitm.cxx|4 +++
 sfx2/source/view/lokhelper.cxx  |   41 ++--
 sfx2/source/view/viewsh.cxx |5 
 svx/source/svdraw/svdedtv1.cxx  |4 ---
 svx/source/tbxctrls/grafctrl.cxx|4 ---
 sw/source/uibase/shells/drawdlg.cxx |4 ---
 sw/source/uibase/shells/grfsh.cxx   |4 ---
 sw/source/uibase/shells/txtattr.cxx |4 ---
 sw/source/uibase/uiview/viewtab.cxx |4 ---
 14 files changed, 22 insertions(+), 64 deletions(-)

New commits:
commit 3df4ee7e2a64824d467a5e0e6a06551b15c217ea
Author: Szymon Kłos 
AuthorDate: Wed Dec 11 14:54:56 2019 +0100
Commit: Szymon Kłos 
CommitDate: Wed Dec 11 22:51:10 2019 +0100

Avoid crash when no uno name available

Change-Id: I81895e68d6fda46bec0cc3bca2da63901d3fed4c
Reviewed-on: https://gerrit.libreoffice.org/84950
Tested-by: Jenkins
Reviewed-by: Szymon Kłos 

diff --git a/sfx2/source/view/lokhelper.cxx b/sfx2/source/view/lokhelper.cxx
index fb38b4a91e91..181d0b385cae 100644
--- a/sfx2/source/view/lokhelper.cxx
+++ b/sfx2/source/view/lokhelper.cxx
@@ -191,14 +191,18 @@ void SfxLokHelper::notifyOtherViews(SfxViewShell* 
pThisView, int nType, const OS
 namespace {
 OUString lcl_getNameForSlot(const SfxViewShell* pShell, sal_uInt16 nWhich)
 {
-if (pShell->GetFrame())
+if (pShell && pShell->GetFrame())
 {
 const SfxSlot* pSlot = 
SfxSlotPool::GetSlotPool(pShell->GetFrame()).GetSlot(nWhich);
 if (pSlot)
 {
 OUStringBuffer sUnoCommand(".uno:");
-sUnoCommand.append(OStringToOUString(pSlot->GetUnoName(), 
RTL_TEXTENCODING_ASCII_US));
-return sUnoCommand.makeStringAndClear();
+const char* pName = pSlot->GetUnoName();
+if (pName)
+{
+sUnoCommand.append(OStringToOUString(pName, 
RTL_TEXTENCODING_ASCII_US));
+return sUnoCommand.makeStringAndClear();
+}
 }
 }
 
@@ -208,7 +212,7 @@ namespace {
 
 void SfxLokHelper::sendUnoStatus(const SfxViewShell* pShell, const 
SfxPoolItem* pItem)
 {
-if (!pShell || !pItem)
+if (!pShell || !pItem || pItem == reinterpret_cast(-1))
 return;
 
 boost::property_tree::ptree aItem = pItem->dumpAsJSON();
commit dd27fedb88cc18bbfc669503cfe510d99f40f05d
Author: Szymon Kłos 
AuthorDate: Tue Dec 10 15:16:32 2019 +0100
Commit: Szymon Kłos 
CommitDate: Wed Dec 11 22:51:03 2019 +0100

jsdialog: send items on status change

Use existing mechanism, delete sending in getter code
which caused unnecessary work.

Change-Id: Ibc191c16b95fd58e7065e019f48f3837cfed5bbd
Reviewed-on: https://gerrit.libreoffice.org/84914
Reviewed-by: Szymon Kłos 
Tested-by: Szymon Kłos 

diff --git a/include/sfx2/lokhelper.hxx b/include/sfx2/lokhelper.hxx
index 889788454d41..0a5af99a9e45 100644
--- a/include/sfx2/lokhelper.hxx
+++ b/include/sfx2/lokhelper.hxx
@@ -43,7 +43,7 @@ public:
 /// Same as notifyOtherViews(), but works on a selected "other" view, not 
on all of them.
 static void notifyOtherView(SfxViewShell* pThisView, SfxViewShell const* 
pOtherView, int nType, const OString& rKey, const OString& rPayload);
 /// Emits a LOK_CALLBACK_STATE_CHANGED
-static void sendUnoStatus(const SfxViewShell* pThisView, const SfxItemSet* 
pSet);
+static void sendUnoStatus(const SfxViewShell* pShell, const SfxPoolItem* 
pItem);
 /// Emits a LOK_CALLBACK_WINDOW
 static void notifyWindow(const SfxViewShell* pThisView,
  vcl::LOKWindowId nWindowId,
diff --git a/include/sfx2/viewsh.hxx b/include/sfx2/viewsh.hxx
index 691ee99839e4..d65fae656b16 100644
--- a/include/sfx2/viewsh.hxx
+++ b/include/sfx2/viewsh.hxx
@@ -219,7 +219,6 @@ public:
 virtual const SfxShell* GetFormShell() const { return nullptr; };
 
 // ILibreOfficeKitNotifier
-virtual voidsendUnoStatus(const SfxItemSet* pSet) const 
override;
 virtual voidnotifyWindow(vcl::LOKWindowId nLOKWindowId, 
const OUString& rAction, const std::vector& rPayload = 
std::vector()) const override;
 
 // Focus, KeyInput, Cursor
diff --git a/include/vcl/IDialogRenderable.hxx 
b/include/vcl/IDialogRenderable.hxx
index 969c15421995..7e2d39c7a486 100644
--- a/include/vcl/IDialogRenderable.hxx
+++ b/include/vcl/IDialogRenderable.hxx
@@ -32,7 +32,6 @@ public:
 virtual ~ILibreOfficeKitNotifier();
 
 /// Callbacks
-virtual void sendUnoStatus(const SfxItemSet* pSet) const = 0;
 virtual void notifyWindow(vcl::LOKWindowId nLOKWindowId,
   const OUString& rAction,
 

[Libreoffice-bugs] [Bug 129337] Tables background color not implemented correctly when using background color button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129337

--- Comment #1 from george  ---
Created attachment 156500
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156500=edit
screenshot showcasing the problem

Table cells not filled with background color which is selected by user.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129259] Check for Updates dialog does not show up with Windows 7

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129259

Thomas Bertels  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #2 from Thomas Bertels  ---
I can't reproduce it with

Version: 6.5.0.0.alpha0+ (x64)
Build ID: 67ee8818e68a2793d89331dd715989c468fe5680

So I guess it's fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129337] New: Tables background color not implemented correctly when using background color button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129337

Bug ID: 129337
   Summary: Tables background color not implemented correctly when
using background color button
   Product: LibreOffice
   Version: 6.3.3.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gd...@yahoo.com

Description:
When you try to set background color inside the cells of a table, by using the
button "Background color", the selected cells do not fill completely with the
color that user selected. Instead a white border remains between border line
and background color.

The only way to completely fill the cell with a color is by right click--->
table properties ---> background ---> color...

Steps to Reproduce:
1.select some cells inside a table
2.click "background button" on the toolbar
3.select color

Actual Results:
The selected cells do not fill completely with the color that user selected.
Instead a white border remains between border line and background color.

Expected Results:
The selected cells should fill completely by the color that user selected


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Version: 6.3.3.2
Build ID: 1:6.3.3-0ubuntu0.18.04.1~lo1
CPU threads: 12; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: el-GR (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129333] calc autocalculate quite simple case still buggy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129333

--- Comment #2 from b.  ---
Created attachment 156499
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156499=edit
wrong_calculate_5, also with 6.4.0.0.b1 (x64)


thanks for retest, 

imho not! a fresh regression, 

6.4.0.0.beta1 fails too here, see screenshot, 

i have not found any 'notfailing' ver. since 4.1.6.2, 

we have differences in hardware - 8 vs. 4 core, and OS - 7SP1 vs. 10, and
perhaps some minor options? 

it may / might / could be that a complex coincidence of special states is
necessary for the bug to occur ... i think it is necessary to find out ... 

Version: 6.4.0.0.beta1 (x64)
Build ID: 4d7e5b0c40ed843384704eca3ce21981d4e98920
CPU threads: 8; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default;
VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-US
Calc:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sfx2/source

[Ashod Nakashian (via logerrit)]

 sfx2/source/sidebar/SidebarController.cxx |   16 +++-
 1 file changed, 15 insertions(+), 1 deletion(-)

New commits:
commit 52bfa7294ce18456c6285ed4897e0ed318dbb98e
Author: Ashod Nakashian 
AuthorDate: Wed Dec 11 12:23:08 2019 -0500
Commit: Ashod Nakashian 
CommitDate: Wed Dec 11 22:06:46 2019 +0100

sfx2: sidebar: notify mobile when the sidebar closes

Change-Id: Idb05346a9ccc8690cad566b74ec86d5fdd3bfb35
Reviewed-on: https://gerrit.libreoffice.org/84973
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Ashod Nakashian 

diff --git a/sfx2/source/sidebar/SidebarController.cxx 
b/sfx2/source/sidebar/SidebarController.cxx
index 4a7942b16453..561bc1e18ce5 100644
--- a/sfx2/source/sidebar/SidebarController.cxx
+++ b/sfx2/source/sidebar/SidebarController.cxx
@@ -1211,7 +1211,21 @@ void SidebarController::RequestCloseDeck()
 if (comphelper::LibreOfficeKit::isActive() && mpCurrentDeck.get())
 {
 const vcl::ILibreOfficeKitNotifier* pNotifier = 
mpCurrentDeck->GetLOKNotifier();
-if (pNotifier)
+auto pMobileNotifier = SfxViewShell::Current();
+if (pMobileNotifier && 
comphelper::LibreOfficeKit::isMobile(SfxLokHelper::getView()))
+{
+// Mobile.
+std::stringstream aStream;
+boost::property_tree::ptree aTree;
+aTree.put("id", mpParentWindow->get_id()); // TODO could be 
missing - sort out
+aTree.put("type", "dockingwindow");
+aTree.put("text", mpParentWindow->GetText());
+aTree.put("enabled", false);
+boost::property_tree::write_json(aStream, aTree);
+const std::string message = aStream.str();
+pMobileNotifier->libreOfficeKitViewCallback(LOK_CALLBACK_JSDIALOG, 
message.c_str());
+}
+else if (pNotifier)
 pNotifier->notifyWindow(mpCurrentDeck->GetLOKWindowId(), "close");
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 129322] MacOS Calc Error on Hyperlink- File is not an absolute URL that can be passed to an external application to open it

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129322

Stephan Bergmann  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |WORKSFORME

--- Comment #3 from Stephan Bergmann  ---
This bug is not a duplicate of bug 128538.  That bug is about opening links
that denote folders, while this bug is about opening links that denote files.

I cannot reproduce this bug with LO 6.2.8.2 on macOS.  In my Desktop folder I
create the Error-Hyperlink.xls and the folder X containing a jpeg file PIC.JPG.
 Clicking the hyperlink in Calc opens the jpeg file in Preview.  This works
even if I make the case-spelling of the actual file name (e.g., Pic.JPG) differ
from the PIC.JPG spelling in the =HYPERLINK(...) formula (as would be expected
for a case-insensitive file system on macOS).  However, if I remove the
Desktop/X/PIC.JPG file, I get the (unfortunately somewhat misleading, for that
scenario) "... is not an absolute URL that can be passed..." error message.

Your comment 0 mentions a Desktop/Tst-Hyperlink sub-folder.  Both your
Error-Hyperlink.xls and your X sub-folder are contained in that
Desktop/Tst-Hyperlink folder?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127148] Selectable text and links in dialogs don't have indication of focused state

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127148

--- Comment #4 from Caolán McNamara  ---
by which I mean its just this dialog has an issue with links, not the rest of
them

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127148] Selectable text and links in dialogs don't have indication of focused state

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127148

--- Comment #3 from Caolán McNamara  ---
The link issue half of this is a regression from...

commit 7eb37a422f2e66bc177d72404c53659a248661ca
Date:   Mon Aug 12 11:35:51 2019 +0200

tdf#118856 vcl: avoid flicker in the about dialog

the RequestDoubleBuffering line in vcl/source/window/aboutdialog.cxx does
"flickering" under windows return if that's removed ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs