[Libreoffice-commits] core.git: drawinglayer/source

[Mike Kaganski (via logerrit)]

 drawinglayer/source/tools/emfphelperdata.cxx |2 +-
 drawinglayer/source/tools/emfphelperdata.hxx |2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 4644edc92a93cb80ebe0e409975ff1303927461f
Author: Mike Kaganski 
AuthorDate: Wed Dec 18 09:50:55 2019 +0300
Commit: Mike Kaganski 
CommitDate: Wed Dec 18 08:49:10 2019 +0100

Fix debug build after 7732444c5d4e79ae0218932afe85bcc4b56a00a4

UnitTypeToString was defined static in emfphelperdata.cxx, and was
absent in any header included in emfpfont.cxx, so it's unclear how
could it pass all the build tests.

Change-Id: I87f966d3cde5d04ab3d364ee0d583adbdc2cc2c0
Reviewed-on: https://gerrit.libreoffice.org/85355
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/drawinglayer/source/tools/emfphelperdata.cxx 
b/drawinglayer/source/tools/emfphelperdata.cxx
index f3deca577e94..99d88a27bdb4 100644
--- a/drawinglayer/source/tools/emfphelperdata.cxx
+++ b/drawinglayer/source/tools/emfphelperdata.cxx
@@ -160,7 +160,7 @@ namespace emfplushelper
 return "";
 }
 
-static OUString UnitTypeToString(sal_uInt16 nType)
+OUString UnitTypeToString(sal_uInt16 nType)
 {
 switch (nType)
 {
diff --git a/drawinglayer/source/tools/emfphelperdata.hxx 
b/drawinglayer/source/tools/emfphelperdata.hxx
index 19677d9438e8..a6560359fe52 100644
--- a/drawinglayer/source/tools/emfphelperdata.hxx
+++ b/drawinglayer/source/tools/emfphelperdata.hxx
@@ -166,6 +166,8 @@ namespace emfplushelper
 };
 
 const char* emfTypeToName(sal_uInt16 type);
+OUString UnitTypeToString(sal_uInt16 nType);
+
 struct EMFPObject
 {
 virtual ~EMFPObject();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: xmlsecurity/source

[Noel Grandin (via logerrit)]

 xmlsecurity/source/xmlsec/nss/nssinitializer.cxx |   41 +--
 1 file changed, 9 insertions(+), 32 deletions(-)

New commits:
commit 998ad9b8b1d0eb08b2515ea2086b9f3de58492e7
Author: Noel Grandin 
AuthorDate: Tue Dec 17 13:40:44 2019 +0200
Commit: Noel Grandin 
CommitDate: Wed Dec 18 08:47:42 2019 +0100

Elide use of rtl_Instance (which is obsoleted by C++11 thread-safe statics)

Change-Id: I522c42d1fe97de2b1a8a629c97cf68e11006a328
Reviewed-on: https://gerrit.libreoffice.org/85327
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/xmlsecurity/source/xmlsec/nss/nssinitializer.cxx 
b/xmlsecurity/source/xmlsec/nss/nssinitializer.cxx
index e268e6e25d63..421adfdf16e3 100644
--- a/xmlsecurity/source/xmlsec/nss/nssinitializer.cxx
+++ b/xmlsecurity/source/xmlsec/nss/nssinitializer.cxx
@@ -25,7 +25,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -158,35 +157,6 @@ salhelper::SingletonRef* 
getInitNSSPrivate()
 
 bool nsscrypto_initialize( const css::uno::Reference< 
css::uno::XComponentContext > , bool & out_nss_init );
 
-struct InitNSSInitialize
-{
-css::uno::Reference< css::uno::XComponentContext > m_xContext;
-
-explicit InitNSSInitialize(const 
css::uno::Reference )
-: m_xContext(rxContext)
-{
-}
-
-bool * operator()()
-{
-static bool bInitialized = false;
-bool bNSSInit = false;
-bInitialized = nsscrypto_initialize( m_xContext, bNSSInit );
-if (bNSSInit)
-atexit(nsscrypto_finalize );
-return & bInitialized;
-}
-};
-
-struct GetNSSInitStaticMutex
-{
-::osl::Mutex* operator()()
-{
-static ::osl::Mutex aNSSInitMutex;
-return 
-}
-};
-
 #ifdef XMLSEC_CRYPTO_NSS
 
 void deleteRootsModule()
@@ -504,8 +474,15 @@ ONSSInitializer::~ONSSInitializer()
 
 bool ONSSInitializer::initNSS( const css::uno::Reference< 
css::uno::XComponentContext >  )
 {
-return *rtl_Instance< bool, InitNSSInitialize, ::osl::MutexGuard, 
GetNSSInitStaticMutex >
-::create( InitNSSInitialize( rxContext ), 
GetNSSInitStaticMutex() );
+static bool gbInitialized = []()
+{
+bool bNSSInit = false;
+bool bInitialized = nsscrypto_initialize( rxContext, bNSSInit );
+if (bNSSInit)
+atexit(nsscrypto_finalize);
+return bInitialized;
+}();
+return gbInitialized;
 }
 
 css::uno::Reference< css::xml::crypto::XDigestContext > SAL_CALL 
ONSSInitializer::getDigestContext( ::sal_Int32 nDigestID, const 
css::uno::Sequence< css::beans::NamedValue >& aParams )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 129324] EDITING Draw converts text to curves in a SVG file with viewBox in SVG code

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129324

--- Comment #4 from joachim_lied...@as-gmbh.de ---
Created attachment 156642
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156642=edit
SVG made from LODraw for comparison of code and size

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: icon-themes/colibre_svg

[andreas kainz (via logerrit)]

 icon-themes/colibre_svg/chart2/res/net_52x60.svg  |2 +-
 icon-themes/colibre_svg/chart2/res/netstack_52x60.svg |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit bcd45c2ab6cbdef1d8b82b327be92b30d49c09fb
Author: andreas kainz 
AuthorDate: Tue Dec 17 23:48:05 2019 +0100
Commit: andreas_kainz 
CommitDate: Wed Dec 18 08:36:58 2019 +0100

Colibre icon remove symbolic link from colibre-svg icons

Change-Id: I993ab3fb57bedaf6c6c1c1946c52eeab7c622acb
Reviewed-on: https://gerrit.libreoffice.org/85345
Tested-by: Jenkins
Reviewed-by: andreas_kainz 

diff --git a/icon-themes/colibre_svg/chart2/res/net_52x60.svg 
b/icon-themes/colibre_svg/chart2/res/net_52x60.svg
deleted file mode 12
index d6ac8897dfe6..
--- a/icon-themes/colibre_svg/chart2/res/net_52x60.svg
+++ /dev/null
@@ -1 +0,0 @@
-netlinepoint_52x60.svg
\ No newline at end of file
diff --git a/icon-themes/colibre_svg/chart2/res/net_52x60.svg 
b/icon-themes/colibre_svg/chart2/res/net_52x60.svg
new file mode 100644
index ..7fcf9be71665
--- /dev/null
+++ b/icon-themes/colibre_svg/chart2/res/net_52x60.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/icon-themes/colibre_svg/chart2/res/netstack_52x60.svg 
b/icon-themes/colibre_svg/chart2/res/netstack_52x60.svg
deleted file mode 12
index 1bc9f0ccd295..
--- a/icon-themes/colibre_svg/chart2/res/netstack_52x60.svg
+++ /dev/null
@@ -1 +0,0 @@
-netlinepointstack_52x60.svg
\ No newline at end of file
diff --git a/icon-themes/colibre_svg/chart2/res/netstack_52x60.svg 
b/icon-themes/colibre_svg/chart2/res/netstack_52x60.svg
new file mode 100644
index ..7eccd530fed8
--- /dev/null
+++ b/icon-themes/colibre_svg/chart2/res/netstack_52x60.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
\ No newline at end of file
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 129324] EDITING Draw converts text to curves in a SVG file with viewBox in SVG code

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129324

--- Comment #3 from joachim_lied...@as-gmbh.de ---
Basically the SVG was coming from Affinity Designer / Adobe Illustrator CS6.
Tried both versions. Step by step I removed several lines of code from the SVG
until the versions I uploaded.

So the only version worked was the one where I removed viewBox. Apart from
this: Have you ever checked the code of SVG generated from LODraw? Its massive
for just two lines of text. Good news, this SVG works after reimport to LODraw.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129356] VIEWING: Svg image are incorrectly rendered

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129356

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   Keywords||filter:svg
 Blocks||88278


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=88278
[Bug 88278] [META] SVG import image filter (all modules)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88278] [META] SVG import image filter (all modules)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88278

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||129356


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129356
[Bug 129356] VIEWING: Svg image are incorrectly rendered
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129460] concat function ignores decimal point display

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129460

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG
 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m.a.riosv  ---
Cell format doesn't change ceel value, so references to the cell retrieve the
true value not the formatted value.

Use a formula like =CONCAT(TEXT(I10;"0")).
BTW you can use the operator '&' to concatenate texts ="a"&"b"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: ucb/source

[Noel Grandin (via logerrit)]

 ucb/source/ucp/hierarchy/hierarchyuri.cxx |3 ++-
 ucb/source/ucp/hierarchy/hierarchyuri.hxx |4 
 2 files changed, 2 insertions(+), 5 deletions(-)

New commits:
commit ab35d0ab54501cb552cea56ec920d475e4bfe26f
Author: Noel Grandin 
AuthorDate: Tue Dec 17 15:14:49 2019 +0200
Commit: Noel Grandin 
CommitDate: Wed Dec 18 08:27:22 2019 +0100

loplugin:duplicate-defines

not used outside the .cxxx file, so move them there

Change-Id: I1043d58bfa849c67a572d53c4cc60fc7e227d508
Reviewed-on: https://gerrit.libreoffice.org/85337
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/ucb/source/ucp/hierarchy/hierarchyuri.cxx 
b/ucb/source/ucp/hierarchy/hierarchyuri.cxx
index 0c1a187504be..8cb26e0f70b1 100644
--- a/ucb/source/ucp/hierarchy/hierarchyuri.cxx
+++ b/ucb/source/ucp/hierarchy/hierarchyuri.cxx
@@ -28,7 +28,8 @@
 
 using namespace hierarchy_ucp;
 
-
+#define HIERARCHY_URL_SCHEME  "vnd.sun.star.hier"
+#define HIERARCHY_URL_SCHEME_LENGTH   17
 #define DEFAULT_DATA_SOURCE_SERVICE \
 "com.sun.star.ucb.DefaultHierarchyDataSource"
 
diff --git a/ucb/source/ucp/hierarchy/hierarchyuri.hxx 
b/ucb/source/ucp/hierarchy/hierarchyuri.hxx
index 12973a9c3326..bf282d508f4f 100644
--- a/ucb/source/ucp/hierarchy/hierarchyuri.hxx
+++ b/ucb/source/ucp/hierarchy/hierarchyuri.hxx
@@ -25,10 +25,6 @@
 namespace hierarchy_ucp {
 
 
-#define HIERARCHY_URL_SCHEME  "vnd.sun.star.hier"
-#define HIERARCHY_URL_SCHEME_LENGTH   17
-
-
 class HierarchyUri
 {
 mutable OUString m_aUri;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 129324] EDITING Draw converts text to curves in a SVG file with viewBox in SVG code

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129324

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru,
   ||xiscofa...@libreoffice.org

--- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> ---
Joachim, in which software did you make your SVG?


Xisco, possibly it's not our bug?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111450] [META] SVG fileSave filter (Draw)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111450

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||128267


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=128267
[Bug 128267] FILESAVE: Spurious definitions in SVG file (EmbeddedBulletChars)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128267] FILESAVE: Spurious definitions in SVG file (EmbeddedBulletChars)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128267

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   Keywords||filter:svg
 Blocks||111450


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=111450
[Bug 111450] [META] SVG fileSave filter (Draw)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127005] SVG export from Draw doesn't include correctly the font family

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127005

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   Keywords||filter:svg
 Blocks||111450


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=111450
[Bug 111450] [META] SVG fileSave filter (Draw)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111450] [META] SVG fileSave filter (Draw)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111450

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||127005


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=127005
[Bug 127005] SVG export from Draw doesn't include correctly the font family
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126323] [UI] Mouse cursor over an SVG image containing text mislead into believing you can directly edit the text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126323

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||108430


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108430
[Bug 108430] [META] Mouse cursor bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108430] [META] Mouse cursor bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108430

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||126323


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=126323
[Bug 126323] [UI] Mouse cursor over an SVG image containing text mislead into
believing you can directly edit the text
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129421] STYLES: Heading has a mixture of typefaces and doesn't update as expected

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129421

Dieter Praas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 Blocks||107326
Summary|Heading has a mixture of|STYLES: Heading has a
   |typefaces and doesn't   |mixture of typefaces and
   |update as expected  |doesn't update as expected
 CC||dgp-m...@gmx.de
 OS|Mac OS X (All)  |All

--- Comment #2 from Dieter Praas  ---
I confirm it with

Version: 6.3.4.2 (x64)
Build-ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: threaded

Character style of the whole paragraph is default style, so I would expect,
that character style changes, if you change heading style.

Workaround:
1. Mar paragraph
2. Clear formatting
3. Choose a paragraph style


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107326
[Bug 107326] [META] Writer style bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107326] [META] Writer style bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107326

Dieter Praas  changed:

   What|Removed |Added

 Depends on||129421


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129421
[Bug 129421] STYLES: Heading has a mixture of typefaces and doesn't update as
expected
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120808] Problems with page size defined as "Oficio" in the new experimental user interface with tabs in LibreOffice Writer in Spanish.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120808

Dieter Praas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #10 from Dieter Praas  ---
(In reply to Albert Acer from comment #8)
> This is already resolved in LO 6.3 and all its maintenance updates.
> The paper size defined by you as "Folio" is the right solution and now I can
> say that it is already solved. Thank you very much.

=> RESOLVED WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129457] writer pdf text import crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129457

--- Comment #3 from Dieter Praas  ---
(In reply to m.a.riosv from comment #2)
> Sorry but writer can't insert text from a pdf file, you can insert a pdf as
> OLE object through Menu/Insert/Object/OLE Object.

Yes, that's right, but question remains, why it crashes and if it happens with
every pdf-document.


> In fact you can't see the pdf on the file types in the Menu/Insert/Text from
> file.

All files are shown by default. Would be better, if you can see only text files
by default.

> In any case for me doesn't crash, only show an error message.

Yes

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: extensions/source

[Alex Henrie (via logerrit)]

 extensions/source/update/feed/updatefeed.cxx |4 
 1 file changed, 4 deletions(-)

New commits:
commit 642e33e53f965d8f85d55f092809c4c5c23bba5d
Author: Alex Henrie 
AuthorDate: Tue Dec 3 22:05:02 2019 -0700
Commit: Noel Grandin 
CommitDate: Wed Dec 18 08:04:19 2019 +0100

Remove unused exception imports from updatefeed.cxx

This reverts commit 1e73a1bfab8abe658e2864ae1512737e489dfb0f.

Change-Id: I5f3c62ffafd3e15b62227766e15a944c76d11978
Reviewed-on: https://gerrit.libreoffice.org/84294
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/extensions/source/update/feed/updatefeed.cxx 
b/extensions/source/update/feed/updatefeed.cxx
index 15152721c35d..6642d977b1eb 100644
--- a/extensions/source/update/feed/updatefeed.cxx
+++ b/extensions/source/update/feed/updatefeed.cxx
@@ -59,10 +59,6 @@
 #include 
 #include 
 
-#ifdef DEBUG
-#include 
-#include 
-#endif
 namespace beans = com::sun::star::beans ;
 namespace container = com::sun::star::container ;
 namespace deployment = com::sun::star::deployment ;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 129462] Missing translation in LO Impress 6.3.4 Spanish version> View> User Interface> Tabs> "Disposición" tab> Layout Menu.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129462

--- Comment #1 from Albert Acer  ---
Created attachment 156641
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156641=edit
Image showing how and where the translation error appears.

I attached an image to show you how and where the translation error appears.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: writerperfect/source

[alonso (via logerrit)]

 writerperfect/source/calc/MSWorksCalcImportFilter.cxx |  127 ++
 writerperfect/source/writer/MSWorksImportFilter.cxx   |   42 +++--
 2 files changed, 99 insertions(+), 70 deletions(-)

New commits:
commit f14cd1ad62e6f17f2a1e56a7d4dfb8fad8d5375e
Author: alonso 
AuthorDate: Wed Nov 13 14:03:53 2019 +0100
Commit: Noel Grandin 
CommitDate: Wed Dec 18 08:03:42 2019 +0100

writerperfect[libwps,tdf#128673]: use the inFilter option in headless 
mode...

Change-Id: I494360ddb55e39e09edf03aaf0bf6a01dc432f83
Reviewed-on: https://gerrit.libreoffice.org/82595
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/writerperfect/source/calc/MSWorksCalcImportFilter.cxx 
b/writerperfect/source/calc/MSWorksCalcImportFilter.cxx
index b2f00e437e3a..875f7ebe32cd 100644
--- a/writerperfect/source/calc/MSWorksCalcImportFilter.cxx
+++ b/writerperfect/source/calc/MSWorksCalcImportFilter.cxx
@@ -177,7 +177,8 @@ private:
 
 bool MSWorksCalcImportFilter::doImportDocument(weld::Window* pParent,
librevenge::RVNGInputStream& 
rInput,
-   OdsGenerator& rGenerator, 
utl::MediaDescriptor&)
+   OdsGenerator& rGenerator,
+   utl::MediaDescriptor& 
mediaDescriptor)
 {
 libwps::WPSKind kind = libwps::WPS_TEXT;
 libwps::WPSCreator creator;
@@ -191,70 +192,88 @@ bool 
MSWorksCalcImportFilter::doImportDocument(weld::Window* pParent,
 std::string fileEncoding;
 if (needEncoding)
 {
-OUString title, encoding;
-switch (creator)
+OUString encoding;
+// first check if we can find the encoding in the filter options 
(headless mode)
+mediaDescriptor[utl::MediaDescriptor::PROP_FILTEROPTIONS()] >>= 
encoding;
+if (!encoding.isEmpty()) // TODO: check if the encoding string is valid
+fileEncoding = encoding.toUtf8().getStr();
+else
 {
-case libwps::WPS_MSWORKS:
-title = WpResId(STR_ENCODING_DIALOG_TITLE_MSWORKS);
-encoding = "CP850";
-break;
-case libwps::WPS_LOTUS:
-title = WpResId(STR_ENCODING_DIALOG_TITLE_LOTUS);
-encoding = "CP437";
-break;
-case libwps::WPS_SYMPHONY:
-title = WpResId(STR_ENCODING_DIALOG_TITLE_SYMPHONY);
-encoding = "CP437";
-break;
-case libwps::WPS_QUATTRO_PRO:
-title = WpResId(STR_ENCODING_DIALOG_TITLE_QUATTROPRO);
-encoding = "CP437";
-break;
-case libwps::WPS_RESERVED_2:
-title = WpResId(STR_ENCODING_DIALOG_TITLE_MSMULTIPLAN);
-encoding = "CP437";
-break;
-default:
-SAL_INFO("writerperfect", "unexpected creator: " << creator);
-title = WpResId(STR_ENCODING_DIALOG_TITLE);
-encoding = "CP437";
-break;
-}
+OUString title;
+switch (creator)
+{
+case libwps::WPS_MSWORKS:
+title = WpResId(STR_ENCODING_DIALOG_TITLE_MSWORKS);
+encoding = "CP850";
+break;
+case libwps::WPS_LOTUS:
+title = WpResId(STR_ENCODING_DIALOG_TITLE_LOTUS);
+encoding = "CP437";
+break;
+case libwps::WPS_SYMPHONY:
+title = WpResId(STR_ENCODING_DIALOG_TITLE_SYMPHONY);
+encoding = "CP437";
+break;
+case libwps::WPS_QUATTRO_PRO:
+title = WpResId(STR_ENCODING_DIALOG_TITLE_QUATTROPRO);
+encoding = "CP437";
+break;
+case libwps::WPS_RESERVED_2:
+title = WpResId(STR_ENCODING_DIALOG_TITLE_MSMULTIPLAN);
+encoding = "CP437";
+break;
+default:
+SAL_INFO("writerperfect", "unexpected creator: " << 
creator);
+title = WpResId(STR_ENCODING_DIALOG_TITLE);
+encoding = "CP437";
+break;
+}
 
-try
-{
-writerperfect::WPFTEncodingDialog aDlg(pParent, title, encoding);
-if (aDlg.run() == RET_OK)
+fileEncoding = encoding.toUtf8().getStr(); // set default to the 
proposed encoding
+try
 {
-if (!aDlg.GetEncoding().isEmpty())
-fileEncoding = aDlg.GetEncoding().toUtf8().getStr();
+writerperfect::WPFTEncodingDialog aDlg(pParent, title, 
encoding);
+if (aDlg.run() == RET_OK)
+   

[Libreoffice-bugs] [Bug 125257] [META] Tip of the day

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125257
Bug 125257 depends on bug 129453, which changed state.

Bug 129453 Summary: Calc Tips of the day not wrapping
https://bugs.documentfoundation.org/show_bug.cgi?id=129453

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129453] Calc Tips of the day not wrapping

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129453

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||heiko.tietze@documentfounda
   ||tion.org
 Status|NEEDINFO|RESOLVED

--- Comment #3 from Heiko Tietze  ---


*** This bug has been marked as a duplicate of bug 128524 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - linguistic/source vcl/inc

[Noel Grandin (via logerrit)]

 linguistic/source/convdic.cxx   |2 --
 vcl/inc/unx/x11_cursors/pivotrow_mask.h |2 --
 2 files changed, 4 deletions(-)

New commits:
commit d681cca399947a0f1438d68850a8e61131e6e414
Author: Noel Grandin 
AuthorDate: Tue Dec 17 15:42:33 2019 +0200
Commit: Noel Grandin 
CommitDate: Wed Dec 18 08:02:38 2019 +0100

loplugin:duplicate-defines

already defined in pivotrow_curs.h, so just delete this one

Change-Id: I1c60bef657a8312cad29ede09c4f6925f0f0e15c
Reviewed-on: https://gerrit.libreoffice.org/85340
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/vcl/inc/unx/x11_cursors/pivotrow_mask.h 
b/vcl/inc/unx/x11_cursors/pivotrow_mask.h
index ccc4756b661d..ec9f7f2ba274 100644
--- a/vcl/inc/unx/x11_cursors/pivotrow_mask.h
+++ b/vcl/inc/unx/x11_cursors/pivotrow_mask.h
@@ -18,8 +18,6 @@
  */
 #define pivotrow_mask_width 32
 #define pivotrow_mask_height 32
-#define pivotrow_curs_x_hot 8
-#define pivotrow_curs_y_hot 7
 static unsigned char pivotrow_mask_bits[] = {
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0xff, 0x07, 0x00,
0xff, 0xff, 0x07, 0x00, 0xff, 0xff, 0x07, 0x00, 0xff, 0xff, 0x07, 0x00,
commit 000db9b072a93884865937942ca82588be7f9919
Author: Noel Grandin 
AuthorDate: Tue Dec 17 15:28:31 2019 +0200
Commit: Noel Grandin 
CommitDate: Wed Dec 18 08:02:21 2019 +0100

loplugin:duplicate-defines

this one is shared between multiple cxx files, so remove the local one

Change-Id: I9f6d06db04febd1bae616b4f87543066b1212f0f
Reviewed-on: https://gerrit.libreoffice.org/85339
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/linguistic/source/convdic.cxx b/linguistic/source/convdic.cxx
index 20ac65582078..4a9bb04909d9 100644
--- a/linguistic/source/convdic.cxx
+++ b/linguistic/source/convdic.cxx
@@ -62,8 +62,6 @@ using namespace com::sun::star::linguistic2;
 using namespace linguistic;
 
 
-#define SN_CONV_DICTIONARY  "com.sun.star.linguistic2.ConversionDictionary"
-
 static void ReadThroughDic( const OUString , ConvDicXMLImport 
 )
 {
 if (rMainURL.isEmpty())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 126267] [VIEWING] Incorrect rendering of SVG image while in normal mode but not in slideshow mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126267

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   Keywords||filter:svg
 CC||79045_79...@mail.ru
 Status|NEW |NEEDINFO

--- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> ---
no problem in

Version: 6.5.0.0.alpha0+ (x64)
Build ID: ff566c67d67e96c97bcf4064b39df6998733c84e
CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded

Can you update your LibreOffice to 6.3.4 version and retest your problem?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - connectivity/source include/vcl

[Noel Grandin (via logerrit)]

 connectivity/source/drivers/jdbc/JConnection.cxx |   26 +++
 include/vcl/headbar.hxx  |3 --
 2 files changed, 8 insertions(+), 21 deletions(-)

New commits:
commit 14824e73d8be8dfe3f26880d805dde58418a4835
Author: Noel Grandin 
AuthorDate: Tue Dec 17 15:21:06 2019 +0200
Commit: Noel Grandin 
CommitDate: Wed Dec 18 08:01:16 2019 +0100

loplugin:duplicate-defines

already defined inside the .cxx file, so just delete the one in the .hxx
file

Change-Id: I2b8eb1dde1365276ef0cddb89d6016348708f5e6
Reviewed-on: https://gerrit.libreoffice.org/85338
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/vcl/headbar.hxx b/include/vcl/headbar.hxx
index 2afc2049cf7d..162ebd2acfec 100644
--- a/include/vcl/headbar.hxx
+++ b/include/vcl/headbar.hxx
@@ -201,9 +201,6 @@ namespace o3tl
 #define HEADERBAR_ITEM_NOTFOUND (sal_uInt16(0x))
 #define HEADERBAR_FULLSIZE  (long(10))
 
-#define HEADERBAR_TEXTOFF   2
-
-
 class VCL_DLLPUBLIC HeaderBar : public vcl::Window
 {
 private:
commit 6526b72434e5f4097229629e12d9ab958edfafc4
Author: Noel Grandin 
AuthorDate: Tue Dec 17 14:05:58 2019 +0200
Commit: Noel Grandin 
CommitDate: Wed Dec 18 08:00:44 2019 +0100

Elide use of rtl_Instance (which is obsoleted by C++11 thread-safe statics)

Change-Id: I34f801d1d56868b89027f10e0567004f1b8a4cc7
Reviewed-on: https://gerrit.libreoffice.org/85331
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/connectivity/source/drivers/jdbc/JConnection.cxx 
b/connectivity/source/drivers/jdbc/JConnection.cxx
index e9109a7d7e0f..bc2e2ad18d66 100644
--- a/connectivity/source/drivers/jdbc/JConnection.cxx
+++ b/connectivity/source/drivers/jdbc/JConnection.cxx
@@ -79,13 +79,6 @@ struct ClassMapData {
 ClassMap map;
 };
 
-struct ClassMapDataInit {
-ClassMapData * operator()() {
-static ClassMapData instance;
-return 
-}
-};
-
 template < typename T >
 bool getLocalFromWeakRef( jweak& _weak, LocalRef< T >& _inout_local )
 {
@@ -133,17 +126,14 @@ bool loadClass(
 OSL_ASSERT(classLoaderPtr != nullptr);
 // For any jweak entries still present in the map upon destruction,
 // DeleteWeakGlobalRef is not called (which is a leak):
-ClassMapData * d =
-rtl_Instance< ClassMapData, ClassMapDataInit, osl::MutexGuard,
-osl::GetGlobalMutex >::create(
-ClassMapDataInit(), osl::GetGlobalMutex());
-osl::MutexGuard g(d->mutex);
-ClassMap::iterator i(d->map.begin());
+static ClassMapData classMapData;
+osl::MutexGuard g(classMapData.mutex);
+ClassMap::iterator i(classMapData.map.begin());
 LocalRef< jobject > cloader(environment);
 LocalRef< jclass > cl(environment);
 // Prune dangling weak references from the list while searching for a 
match,
 // so that the list cannot grow unbounded:
-for (; i != d->map.end();)
+for (; i != classMapData.map.end();)
 {
 LocalRef< jobject > classLoader( environment );
 if ( !getLocalFromWeakRef( i->classLoader, classLoader ) )
@@ -155,7 +145,7 @@ bool loadClass(
 
 if ( !classLoader.is() && !classObject.is() )
 {
-i = d->map.erase(i);
+i = classMapData.map.erase(i);
 }
 else if ( i->classPath == classPath && i->className == name )
 {
@@ -170,7 +160,7 @@ bool loadClass(
 }
 if ( !cloader.is() || !cl.is() )
 {
-if ( i == d->map.end() )
+if ( i == classMapData.map.end() )
 {
 // Push a new ClassMapEntry (which can potentially fail) before
 // loading the class, so that it never happens that a class is
@@ -178,8 +168,8 @@ bool loadClass(
 // JVM that are not easily undone).  If the pushed ClassMapEntry is
 // not used after all (return false, etc.) it will be pruned on 
next
 // call because its classLoader/classObject are null:
-d->map.push_back( ClassMapEntry( classPath, name ) );
-i = std::prev(d->map.end());
+classMapData.map.push_back( ClassMapEntry( classPath, name ) );
+i = std::prev(classMapData.map.end());
 }
 
 LocalRef< jclass > clClass( environment );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125257] [META] Tip of the day

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125257
Bug 125257 depends on bug 125615, which changed state.

Bug 125615 Summary: Tip-of-the-day should be variable on Alt vs. Option
https://bugs.documentfoundation.org/show_bug.cgi?id=125615

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 3 commits - basic/source bridges/source extensions/source

[Noel Grandin (via logerrit)]

 basic/source/basmgr/basicmanagerrepository.cxx  |   19 +
 bridges/source/cpp_uno/shared/cppinterfaceproxy.cxx |   22 ---
 extensions/source/propctrlr/modulepcr.cxx   |   29 ++--
 3 files changed, 12 insertions(+), 58 deletions(-)

New commits:
commit 10f4db67b6690cecfe449b4283b52f56400f07e2
Author: Noel Grandin 
AuthorDate: Tue Dec 17 14:00:18 2019 +0200
Commit: Noel Grandin 
CommitDate: Wed Dec 18 08:00:23 2019 +0100

Elide use of rtl_Instance (which is obsoleted by C++11 thread-safe statics)

Change-Id: Ib0965f57cb929a220fc9df381abdca654985c9de
Reviewed-on: https://gerrit.libreoffice.org/85330
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/extensions/source/propctrlr/modulepcr.cxx 
b/extensions/source/propctrlr/modulepcr.cxx
index a7da05f3e947..88b6d4d97152 100644
--- a/extensions/source/propctrlr/modulepcr.cxx
+++ b/extensions/source/propctrlr/modulepcr.cxx
@@ -19,38 +19,27 @@
 
 #include "modulepcr.hxx"
 
-#include 
-#include 
 #include 
 #include 
 #include 
 
 namespace pcr
 {
-struct CreateModuleClass
-{
-PcrModule* operator()()
-{
-static PcrModule* pModule = new PcrModule;
-return pModule;
-/*  yes, in theory, this is a resource leak, since the PcrModule
-will never be cleaned up. However, using a non-heap instance 
of PcrModule
-would not work: It would be cleaned up when the module is 
unloaded.
-This might happen (and is likely to happen) *after* the 
tools-library
-has been unloaded. However, the module's dtor is where we 
would delete
-our resource manager (in case not all our clients 
de-registered) - which
-would call into the already-unloaded tools-library. */
-}
-};
-
 PcrModule::PcrModule()
 {
 }
 
 PcrModule& PcrModule::getInstance()
 {
-return *rtl_Instance< PcrModule, CreateModuleClass, ::osl::MutexGuard, 
::osl::GetGlobalMutex >::
-create( CreateModuleClass(), ::osl::GetGlobalMutex() );
+static PcrModule* pModule = new PcrModule;
+return *pModule;
+/*  yes, in theory, this is a resource leak, since the PcrModule
+will never be cleaned up. However, using a non-heap instance of 
PcrModule
+would not work: It would be cleaned up when the module is unloaded.
+This might happen (and is likely to happen) *after* the 
tools-library
+has been unloaded. However, the module's dtor is where we would 
delete
+our resource manager (in case not all our clients de-registered) - 
which
+would call into the already-unloaded tools-library. */
 }
 
 OUString PcrRes(const char* pId)
commit 51e7a590976f664deb0a386d23b66bee38ea5687
Author: Noel Grandin 
AuthorDate: Tue Dec 17 13:58:20 2019 +0200
Commit: Noel Grandin 
CommitDate: Wed Dec 18 07:59:59 2019 +0100

Elide use of rtl_Instance (which is obsoleted by C++11 thread-safe statics)

Change-Id: Ie3e099a6561c22646f07dab418f1a2f8123f1449
Reviewed-on: https://gerrit.libreoffice.org/85329
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/basic/source/basmgr/basicmanagerrepository.cxx 
b/basic/source/basmgr/basicmanagerrepository.cxx
index c493da8bd29d..1e9378ff864b 100644
--- a/basic/source/basmgr/basicmanagerrepository.cxx
+++ b/basic/source/basmgr/basicmanagerrepository.cxx
@@ -38,8 +38,6 @@
 #include 
 #include 
 
-#include 
-#include 
 #include 
 
 #include 
@@ -198,19 +196,6 @@ namespace basic
 StarBASIC* impl_getDefaultAppBasicLibrary();
 };
 
-namespace {
-
-struct CreateImplRepository
-{
-ImplRepository* operator()()
-{
-static ImplRepository repository;
-return 
-}
-};
-
-}
-
 ImplRepository::ImplRepository()
 {
 }
@@ -218,8 +203,8 @@ namespace basic
 
 ImplRepository& ImplRepository::Instance()
 {
-return *rtl_Instance< ImplRepository, CreateImplRepository, 
::osl::MutexGuard, ::osl::GetGlobalMutex >::
-create( CreateImplRepository(), ::osl::GetGlobalMutex() );
+static ImplRepository repository;
+return repository;
 }
 
 BasicManager* ImplRepository::getDocumentBasicManager( const Reference< 
XModel >& _rxDocumentModel )
commit 8473ac2e27efff3ec902a358896a669ce05f047a
Author: Noel Grandin 
AuthorDate: Tue Dec 17 13:56:07 2019 +0200
Commit: Noel Grandin 
CommitDate: Wed Dec 18 07:59:40 2019 +0100

Elide use of rtl_Instance (which is obsoleted by C++11 thread-safe statics)

which does not seem to have been doing anything useful here anyway, not
since

commit 730399de90add4e35da9754a8f7525b443237026
Date:   Wed Jul 18 11:16:06 2007 +
INTEGRATION: CWS unomacli64 (1.6.50); FILE MERGED
2007/06/20 10:29:46 

[Libreoffice-bugs] [Bug 127294] Add more tips of the day (and make it module-specific eventually)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127294

--- Comment #67 from Commit Notification 
 ---
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1bc50aca32a2c76017a552a06dca2c941ab38f7a

tdf#127294 Remove spaces; follow design guidelines for tips-of-the-day

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/inc cui/source

[Seth Chaiklin (via logerrit)]

 cui/inc/tipoftheday.hrc   |  315 +-
 cui/source/dialogs/tipofthedaydlg.cxx |   17 +
 2 files changed, 177 insertions(+), 155 deletions(-)

New commits:
commit 1bc50aca32a2c76017a552a06dca2c941ab38f7a
Author: Seth Chaiklin 
AuthorDate: Mon Dec 16 16:53:19 2019 +0100
Commit: Heiko Tietze 
CommitDate: Wed Dec 18 07:59:24 2019 +0100

tdf#127294 Remove spaces; follow design guidelines for tips-of-the-day

- converted to design guidelines
all quotes
all menus items
apostrophe (U+2019)
em-dash (U+2014)
minus (U+2212)
expanded contractions

- Corrected spelling and grammar mistakes.

- Simplified wording in some tips

- tried to clarify uri explanation in relation to help

Change-Id: Ic9984fdc09813d2b43324a104d5c30420671c6b9
Reviewed-on: https://gerrit.libreoffice.org/85228
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 

diff --git a/cui/inc/tipoftheday.hrc b/cui/inc/tipoftheday.hrc
index 5847985b714e..3c77cd73307d 100644
--- a/cui/inc/tipoftheday.hrc
+++ b/cui/inc/tipoftheday.hrc
@@ -29,247 +29,254 @@
  * std:tuple consists of 
  * text:
* escape backslash, ie. use \\ to show \
+   * Use %MOD1 for Ctrl/Cmd and %MOD2 for Alt/Option depending on OS 
(uppercase required)
  * uri:
-   * leave uri empty to not show any link
-   * if uri starts with "http" it opens directly in the browser
-   * all other strings are converted for the offline help
-   * find the right uri for e.g. 
https://help.libreoffice.org/6.2/en-US/text/shared/optionen/01030300.html by
-   * grepping help2file.js after building --with-help=html 
(cui/ui/optsecuritypage/OptSecurityPage for the example)
+   * if uri is empty, do not show any link
+   * if uri starts with "http", show the link directly in the browser
+   * all other strings are converted to a link for the offline help
+   * to find the right uri, look in instdir/help/hid2file.js after building 
--with-help=html
+   * structure of hid2file.js  'uri' : 'rest of URL' (that starts: 
https://help.libreoffice.org/latest/en-US/)
+   * For example 'cui/ui/optsecuritypage/OptSecurityPage' is the uri for 
https://help.libreoffice.org/latest/en-US/text/shared/optionen/01030300.html#bm_id9049654
  * image:
* leave the image string empty for the default tipoftheday.png
-   * place new images at extra/source/tipoftheday and don't forget to add the 
files to vcl/Package_tipoftheday.mk
-   * don't exceed 100x120px too much - images don't get scaled
+   * place new images at extra/source/tipoftheday and do not forget to add the 
files to vcl/Package_tipoftheday.mk
+   * do not exceed 100x120px too much - images do not get scaled
 */
 
 const std::tuple TIPOFTHEDAY_STRINGARRAY[] =
 {
  { NC_("RID_CUI_TIPOFTHEDAY", "Need to allow changes to parts of a 
read-only document in Writer? Insert frames or sections that can authorize 
changes."), 
"https://help.libreoffice.org/%PRODUCTVERSION/%LANGUAGENAME/text/swriter/guide/section_edit.html;,
 "tipoftheday_w.png"}, //local help missing
- { NC_("RID_CUI_TIPOFTHEDAY", "To print the notes of your slides go to 
File > Print > Impress tab and select Notes under Document > Type."), "", 
"tipoftheday_i.png"},
- { NC_("RID_CUI_TIPOFTHEDAY", "To start temporarily with a fresh user 
profile, or to restore a non-working %PRODUCTNAME, use  Help > Restart in Safe 
Mode."), "svx/ui/safemodedialog/SafeModeDialog", ""}, 
//https://help.libreoffice.org/%PRODUCTVERSION/%LANGUAGENAME/text/shared/01/profile_safe_mode.html
+ { NC_("RID_CUI_TIPOFTHEDAY", "To print the notes of your slides go to 
File ▸ Print ▸ Impress tab and select Notes under Document ▸ Type."), "", 
"tipoftheday_i.png"},
+ { NC_("RID_CUI_TIPOFTHEDAY", "To start temporarily with a fresh user 
profile, or to restore a non-working %PRODUCTNAME, use Help ▸ Restart in Safe 
Mode."), "svx/ui/safemodedialog/SafeModeDialog", ""}, 
//https://help.libreoffice.org/%PRODUCTVERSION/%LANGUAGENAME/text/shared/01/profile_safe_mode.html
  { NC_("RID_CUI_TIPOFTHEDAY", "Writing a book? %PRODUCTNAME master 
document lets you manage large documents as a container for individual 
%PRODUCTNAME Writer files."), 
"https://help.libreoffice.org/%PRODUCTVERSION/%LANGUAGENAME/text/swriter/guide/globaldoc.html;,
 "tipoftheday_w.png"}, //local help missing
  { NC_("RID_CUI_TIPOFTHEDAY", "Create editable Hybrid PDFs with 
%PRODUCTNAME."), 
"https://wiki.documentfoundation.org/Documentation/HowTo/CreateAHybridPDF;, ""},
- { NC_("RID_CUI_TIPOFTHEDAY", "Explore the ten different functions in the 
status bar (at the bottom of the document window). Place the cursor over each 
field for an explanation. If not visible, use View > Status Bar."), "", 
"tipoftheday_w.png"},
+ { NC_("RID_CUI_TIPOFTHEDAY", "Explore the ten different functions in the 
status bar (at the bottom of the document window). Place the cursor over each 
field for an explanation. If 

[Libreoffice-ux-advise] [Bug 127294] Add more tips of the day (and make it module-specific eventually)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127294

--- Comment #67 from Commit Notification 
 ---
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1bc50aca32a2c76017a552a06dca2c941ab38f7a

tdf#127294 Remove spaces; follow design guidelines for tips-of-the-day

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 126023] Breaking an SVG image destroys objects

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126023

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   Keywords||filter:svg

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129462] New: Missing translation in LO Impress 6.3.4 Spanish version> View> User Interface> Tabs> "Disposición" tab> Layout Menu.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129462

Bug ID: 129462
   Summary: Missing translation in LO Impress 6.3.4 Spanish
version> View> User Interface> Tabs> "Disposición"
tab> Layout Menu.
   Product: LibreOffice
   Version: 6.3.4.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: albac...@gmail.com

Description:
When I activate the User Interface with Tabs, in LO Impress 6.3.4, Spanish
Version, I find a translation error in the last drop-down menu (on the far
right side) of the Toolbar, under the "Disposición" tab. It appears in English
when it should be in Spanish because it corresponds to the Spanish versión.

Steps to Reproduce:
1. Open Libreoffice Impress 6.3.4 Spanish Version.
2. Activate the User Interface with Tabs (View Menu> User Interface> In Tabs)
3. Select the “Disposición” tab and then look for the last drop-down menu on
the toolbar corresponding to that tab, to the far right side.


Actual Results:
The name of the last drop-down menu is in English (“Layout”) when it should be
in Spanish (“Disposición”) because it corresponds to the Spanish versión.

Expected Results:
For the last drop-down menu, in the toolbar corresponding to the "Layout" tab,
you should put "Disposición" instead of "Layout", as it is in LO Writer and LO
Calc 6.3.4, Spanish version.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
[Information automatically included from LibreOffice]
Locale: es
Module: SpreadsheetDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84494] FILEOPEN: Possible failure to follow SVG spec, 800 pixels interpreted as 0.8cm

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84494

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||88278


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=88278
[Bug 88278] [META] SVG import image filter (all modules)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88278] [META] SVG import image filter (all modules)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88278

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||84494


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=84494
[Bug 84494] FILEOPEN: Possible failure to follow SVG spec, 800 pixels
interpreted as 0.8cm
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109139] [META] Cell selection bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109139

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||129420


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129420
[Bug 129420] Decrease performance when select many aleatory cells with Ctrl
pressed.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129420] Decrease performance when select many aleatory cells with Ctrl pressed.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129420

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||109139


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109139
[Bug 109139] [META] Cell selection bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129425] Label formats do not align

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129425

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||120679


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=120679
[Bug 120679] [META] Labels and Business Cards issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120679] [META] Labels and Business Cards issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120679

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||129425


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129425
[Bug 129425] Label formats do not align
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107905] [META] Cross-references bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107905

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||129447


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129447
[Bug 129447] Insert of cross reference
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129447] Insert of cross reference

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129447

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||107905


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107905
[Bug 107905] [META] Cross-references bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86349] [META] Context menu bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86349

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||129446


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129446
[Bug 129446] Silde Pane: Context menu is not displayed under certain conditions
(gen)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129446] Silde Pane: Context menu is not displayed under certain conditions (gen)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129446

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||86349


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=86349
[Bug 86349] [META] Context menu bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104444] [META] DOCX (OOXML) table-related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=10

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||129458


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129458
[Bug 129458] .docx import: incorrect alignment of tables
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129458] .docx import: incorrect alignment of tables

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129458

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||10


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=10
[Bug 10] [META] DOCX (OOXML) table-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129453] Calc Tips of the day not wrapping

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129453

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||125257


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125257
[Bug 125257] [META] Tip of the day
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125257] [META] Tip of the day

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125257

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||129453


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129453
[Bug 129453] Calc Tips of the day not wrapping
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34804] EDITING: Keyboard shortcut for Format-Highlighting does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=34804

Arloprosetup  changed:

   What|Removed |Added

URL||https://arlo-setup.net/#arl
   ||o-app

--- Comment #33 from Arloprosetup  ---
It's the most common error that every user tackles once in a life time while
perform Arlo pro login. But fortunately, arlo-setup.net, will provide you the
instant solutions for all Arlo setup problems. Arlo login my account Error is
one of the most common and critical error in the Arlo Pro cameras. Change in
the password or forget the password are the major reasons behind the login
failure. Dial 1-855-881-8818, and get the instant solution to fix Arlo Pro
login failure error.
https://arlo-setup.net/how-to-use-motion-detection-test-for-your-arlo-device/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 39422] Changes are displayed incorrectly in MS Word 2007

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39422

Tamas Szabo  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTOURBUG   |---

--- Comment #15 from Tamas Szabo  ---
MS Office not implemented yet.(In reply to sasha.libreoffice from comment #14)
> > Have I got it right finally? ;-)
> Yes.
> 
> Ps: Interesting, what will happens if we change version of document inside
> of odt manually. May be then msOffice 2010 will open it?
Old Hungarian users don't use MS Office. For example, AbiWord is better for
them. The keyboard problem is reality.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129461] New: Password window hidden

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129461

Bug ID: 129461
   Summary: Password window hidden
   Product: LibreOffice
   Version: 6.2.8.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: pitho...@free.fr

Description:
When opening a file protected by a password, I have to look for the window
where I enter the password: this window is hidden in the stack of all other
windows opened.
Like, for example, the reminder window of my agenda (KOrganizer), this window
must be displayed in front of all other windows.

I use Libre Office 6.2.8.2 with Mageia Linux.

Steps to Reproduce:
1.Define a password for saving / opening a file.
2.
3.

Actual Results:
Password window hidden.

Expected Results:
Password window must be displayed in front of all other windows.


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: fr
Module: StartModule
[Information guessed from browser]
OS: Mageia Linux 7
OS is 64bit: yes

Version: 6.2.8.2
Build ID: 6.2.8.2-1.mga7
Threads CPU : 2; OS : Linux 5.4; UI Render : par défaut; VCL: gtk3_kde5; 
Locale : fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: helpcontent2

[Andrea Gelmini (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 09ff0a177753fdb6337239d908b72385913fbf51
Author: Andrea Gelmini 
AuthorDate: Wed Dec 18 00:23:03 2019 +0100
Commit: Gerrit Code Review 
CommitDate: Wed Dec 18 07:08:40 2019 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  - Fix repetition

Change-Id: I133f5d6d70a39d2ccd90f4a16d579c0e3225108e
Reviewed-on: https://gerrit.libreoffice.org/85349
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/helpcontent2 b/helpcontent2
index 16e2b03f2702..9f10d6a9ed06 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 16e2b03f2702257fc4c5cee1a606e25699bc3c0d
+Subproject commit 9f10d6a9ed0623419d8c1fdf3a0be22e1e0490eb
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[Andrea Gelmini (via logerrit)]

 source/text/shared/01/0528.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9f10d6a9ed0623419d8c1fdf3a0be22e1e0490eb
Author: Andrea Gelmini 
AuthorDate: Wed Dec 18 00:23:03 2019 +0100
Commit: Julien Nabet 
CommitDate: Wed Dec 18 07:08:40 2019 +0100

Fix repetition

Change-Id: I133f5d6d70a39d2ccd90f4a16d579c0e3225108e
Reviewed-on: https://gerrit.libreoffice.org/85349
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/source/text/shared/01/0528.xhp 
b/source/text/shared/01/0528.xhp
index fa3a5d3a9..2bbae57ad 100644
--- a/source/text/shared/01/0528.xhp
+++ b/source/text/shared/01/0528.xhp
@@ -33,7 +33,7 @@
 
 Fontwork Dialog (for putting 
text along a curve)
 Simple tool for putting text along a curve without any 
fancy effects.UFI: see "Fontwork_ui" spec 
doc.
-This Fontwork dialog is meant for making 
text follow a curve. Draw a curve, double-click it and type text into it. With 
the curve selected, you can now activate the Fontwork command. Access the dialog by by choosing 
Format - Text Box and Shape - 
FontworkFirst call Tools - 
Customize to add a menu command or a toolbar button to open the 
dialog. The Fontwork command is found in the Format category of 
the Customize dialog.
+This Fontwork dialog is meant for making 
text follow a curve. Draw a curve, double-click it and type text into it. With 
the curve selected, you can now activate the Fontwork command. Access the dialog by choosing 
Format - Text Box and Shape - 
FontworkFirst call Tools - 
Customize to add a menu command or a toolbar button to open the 
dialog. The Fontwork command is found in the Format category of 
the Customize dialog.
 
 Alignment icons
 You can make 
text follow any shape. Most of the custom shapes available in the Drawing 
toolbar need to be converted to a different type before you can use them with 
Fontwork. In Impress or Draw, right-click the shape and select Convert - 
To Curve/Polygon/Contour. If you wish, you can now copy and paste the 
converted shape into Writer for use with Fontwork. Shapes in the Legacy 
Circles and Ovals and Legacy Rectangles toolbars do not 
need to be converted. The Arc included in the basic shapes is also 
a legacy shape.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 70710] filled areas are not filled for WMF images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70710

Chris Sherlock  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |chris.sherloc...@gmail.com
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70710] filled areas are not filled for WMF images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70710

--- Comment #12 from Chris Sherlock  ---
I have a feeling I may have fixed this recently:

https://git.libreoffice.org/core/commit/e356b371373ed6d047efac9913bc69cb2bfa0105

Needs to be tested.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125364] Unable to download latest update

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125364

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129031] distorted lines

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129031

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129318] Java JRE not found on Base

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129318

--- Comment #12 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129318] Java JRE not found on Base

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129318

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120808] Problems with page size defined as "Oficio" in the new experimental user interface with tabs in LibreOffice Writer in Spanish.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120808

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125364] Unable to download latest update

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125364

--- Comment #3 from QA Administrators  ---
Dear David,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93083] Uninstall leaves folder "LibreOffice 5" with empty subfolders

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93083

--- Comment #3 from QA Administrators  ---
Dear Regina Henschel,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129031] distorted lines

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129031

--- Comment #13 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120808] Problems with page size defined as "Oficio" in the new experimental user interface with tabs in LibreOffice Writer in Spanish.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120808

--- Comment #9 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126505] Wrong Subtotal of auto-filtered rows on opening XLSX (comment 6)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126505

--- Comment #9 from Satit  ---
Ref. Comment 8 (subtotal needs the '9' to shrink to visible rows, was different
in your ascii-graph)

I wrong typed subtotal function, actually it had 9 as arguments in all samples
above. The behavior also occurs in v.6.3.3.2(x64) and v.6.3.4.2(x64)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: drawinglayer/source

[Chris Sherlock (via logerrit)]

 drawinglayer/source/tools/emfphelperdata.cxx |   58 +++
 drawinglayer/source/tools/emfphelperdata.hxx |1 
 2 files changed, 35 insertions(+), 24 deletions(-)

New commits:
commit e356b371373ed6d047efac9913bc69cb2bfa0105
Author: Chris Sherlock 
AuthorDate: Wed Dec 18 09:09:46 2019 +1100
Commit: Bartosz Kosiorek 
CommitDate: Wed Dec 18 03:16:53 2019 +0100

tdf#129459 drawinglayer: fill shapes with solid color brush

EMF+ shapes were not filling when the brush style is a solid color. This
patch fixes this issue.

Change-Id: I6a2b12e514af9a85f50198dceee642fac8df2f1b
Reviewed-on: https://gerrit.libreoffice.org/85343
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek 

diff --git a/drawinglayer/source/tools/emfphelperdata.cxx 
b/drawinglayer/source/tools/emfphelperdata.cxx
index f29f470cec3b..f3deca577e94 100644
--- a/drawinglayer/source/tools/emfphelperdata.cxx
+++ b/drawinglayer/source/tools/emfphelperdata.cxx
@@ -646,6 +646,33 @@ namespace emfplushelper
 }
 }
 
+void EmfPlusHelperData::EMFPPlusFillPolygonSolidColor(const 
::basegfx::B2DPolyPolygon& polygon, Color const& color)
+{
+if (color.GetTransparency() < 255)
+{
+if (color.GetTransparency() == 0)
+{
+// not transparent
+mrTargetHolders.Current().append(
+
std::make_unique(
+polygon,
+color.getBColor()));
+}
+else
+{
+const drawinglayer::primitive2d::Primitive2DReference 
aPrimitive(
+new 
drawinglayer::primitive2d::PolyPolygonColorPrimitive2D(
+polygon,
+color.getBColor()));
+
+mrTargetHolders.Current().append(
+
std::make_unique(
+
drawinglayer::primitive2d::Primitive2DContainer { aPrimitive },
+color.GetTransparency() / 255.0));
+}
+}
+}
+
 void EmfPlusHelperData::EMFPPlusFillPolygon(const 
::basegfx::B2DPolyPolygon& polygon, const bool isColor, const sal_uInt32 
brushIndexOrColor)
 {
 if (!polygon.count())
@@ -658,29 +685,7 @@ namespace emfplushelper
 // EMF Alpha (1 byte): An 8-bit unsigned integer that specifies 
the transparency of the background,
 // ranging from 0 for completely transparent to 0xFF for 
completely opaque.
 const Color color(0xff - (brushIndexOrColor >> 24), 
(brushIndexOrColor >> 16) & 0xff, (brushIndexOrColor >> 8) & 0xff, 
brushIndexOrColor & 0xff);
-if (color.GetTransparency() < 255)
-{
-if (color.GetTransparency() == 0)
-{
-// not transparent
-mrTargetHolders.Current().append(
-
std::make_unique(
-polygon,
-color.getBColor()));
-}
-else
-{
-const drawinglayer::primitive2d::Primitive2DReference 
aPrimitive(
-new 
drawinglayer::primitive2d::PolyPolygonColorPrimitive2D(
-polygon,
-color.getBColor()));
-
-mrTargetHolders.Current().append(
-
std::make_unique(
-
drawinglayer::primitive2d::Primitive2DContainer { aPrimitive },
-color.GetTransparency() / 255.0));
-}
-}
+EMFPPlusFillPolygonSolidColor(polygon, color);
 
 mrPropertyHolders.Current().setFillColor(color.getBColor());
 mrPropertyHolders.Current().setFillColorActive(true);
@@ -698,7 +703,12 @@ namespace emfplushelper
 mrPropertyHolders.Current().setFillColorActive(false);
 mrPropertyHolders.Current().setLineColorActive(false);
 
-if (brush->type == BrushTypeHatchFill)
+if (brush->type == BrushTypeSolidColor)
+{
+Color fillColor = brush->solidColor;
+EMFPPlusFillPolygonSolidColor(polygon, fillColor);
+}
+else if (brush->type == BrushTypeHatchFill)
 {
 // EMF+ like hatching is currently not supported. These are 
just color blends which serve as an approximation for some of them
 // for the others the hatch "background" color (secondColor in 
brush) is used.
diff --git a/drawinglayer/source/tools/emfphelperdata.hxx 
b/drawinglayer/source/tools/emfphelperdata.hxx
index c29a858e85a7..19677d9438e8 100644
--- a/drawinglayer/source/tools/emfphelperdata.hxx
+++ 

[Libreoffice-commits] core.git: drawinglayer/source

[Chris Sherlock (via logerrit)]

 drawinglayer/source/tools/emfpfont.cxx |   30 +++---
 drawinglayer/source/tools/emfpfont.hxx |   14 ++
 2 files changed, 37 insertions(+), 7 deletions(-)

New commits:
commit 7732444c5d4e79ae0218932afe85bcc4b56a00a4
Author: Chris Sherlock 
AuthorDate: Tue Dec 10 13:43:16 2019 +1100
Commit: Bartosz Kosiorek 
CommitDate: Wed Dec 18 03:11:57 2019 +0100

drawinglayer: improve logging for fonts

Change-Id: I5b430360894dc1738445820679ceaf09edfeef55
Reviewed-on: https://gerrit.libreoffice.org/84840
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek 

diff --git a/drawinglayer/source/tools/emfpfont.cxx 
b/drawinglayer/source/tools/emfpfont.cxx
index d7b9daa0c46d..185b813540b2 100644
--- a/drawinglayer/source/tools/emfpfont.cxx
+++ b/drawinglayer/source/tools/emfpfont.cxx
@@ -22,6 +22,25 @@
 
 namespace emfplushelper
 {
+static OUString FontStyleToString(sal_uInt32 style)
+{
+OUString sStyle;
+
+if (style & FontStyleBold)
+sStyle = "\n\t\t\tFontStyleBold";
+
+if (style & FontStyleItalic)
+sStyle = sStyle.concat("\n\t\t\tFontStyleItalic");
+
+if (style & FontStyleUnderline)
+sStyle = sStyle.concat("\n\t\t\tFontStyleUnderline");
+
+if (style & FontStyleStrikeout)
+sStyle = sStyle.concat("\n\t\t\tFontStyleStrikeout");
+
+return sStyle;
+}
+
 void EMFPFont::Read(SvMemoryStream )
 {
 sal_uInt32 header;
@@ -29,8 +48,13 @@ namespace emfplushelper
 sal_uInt32 length;
 
s.ReadUInt32(header).ReadFloat(emSize).ReadUInt32(sizeUnit).ReadInt32(fontFlags).ReadUInt32(reserved).ReadUInt32(length);
 SAL_WARN_IF((header >> 12) != 0xdbc01, "drawinglayer", "Invalid header 
- not 0xdbc01");
-SAL_INFO("drawinglayer", "EMF+\tfont\nEMF+\theader: 0x" << std::hex << 
(header >> 12) << " version: 0x" << (header & 0x1fff) << " size: " << std::dec 
<< emSize << " unit: 0x" << std::hex << sizeUnit << std::dec);
-SAL_INFO("drawinglayer", "EMF+\tflags: 0x" << std::hex << fontFlags << 
" reserved: 0x" << reserved << " length: 0x" << std::hex << length << std::dec);
+SAL_INFO("drawinglayer", "EMF+\tHeader: 0x" << std::hex << (header >> 
12));
+SAL_INFO("drawinglayer", "EMF+\tVersion: 0x" << (header & 0x1fff));
+SAL_INFO("drawinglayer", "EMF+\tSize: " << std::dec << emSize);
+SAL_INFO("drawinglayer", "EMF+\tUnit: " << UnitTypeToString(sizeUnit) 
<< " (0x" << std::hex << sizeUnit << ")" << std::dec);
+SAL_INFO("drawinglayer", "EMF+\tFlags: " << 
FontStyleToString(fontFlags) << " (0x" << std::hex << fontFlags << ")");
+SAL_INFO("drawinglayer", "EMF+\tReserved: 0x" << reserved << std::dec);
+SAL_INFO("drawinglayer", "EMF+\tLength: " << length);
 
 //tdf#113624 Convert unit to Pixels
 emSize = emSize * 
EmfPlusHelperData::getUnitToPixelMultiplier(static_cast(sizeUnit));
@@ -46,7 +70,7 @@ namespace emfplushelper
 }
 
 family = OUString(pStr, SAL_NO_ACQUIRE);
-SAL_INFO("drawinglayer", "EMF+\tfamily: " << family);
+SAL_INFO("drawinglayer", "EMF+\tFamily: " << family);
 }
 }
 }
diff --git a/drawinglayer/source/tools/emfpfont.hxx 
b/drawinglayer/source/tools/emfpfont.hxx
index ce5760546e87..0559cb949487 100644
--- a/drawinglayer/source/tools/emfpfont.hxx
+++ b/drawinglayer/source/tools/emfpfont.hxx
@@ -24,6 +24,12 @@
 
 namespace emfplushelper
 {
+const sal_uInt32 FontStyleBold = 0x0001;
+const sal_uInt32 FontStyleItalic = 0x0002;
+const sal_uInt32 FontStyleUnderline = 0x0004;
+const sal_uInt32 FontStyleStrikeout = 0x0008;
+
+
 struct EMFPFont : public EMFPObject
 {
 float emSize;
@@ -33,10 +39,10 @@ namespace emfplushelper
 
 void Read(SvMemoryStream );
 
-bool Bold()  const { return fontFlags & 0x1; }
-bool Italic()const { return fontFlags & 0x2; }
-bool Underline() const { return fontFlags & 0x4; }
-bool Strikeout() const { return fontFlags & 0x8; }
+bool Bold()  const { return fontFlags & FontStyleBold; }
+bool Italic()const { return fontFlags & FontStyleItalic; }
+bool Underline() const { return fontFlags & FontStyleUnderline; }
+bool Strikeout() const { return fontFlags & FontStyleStrikeout; }
 };
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 129318] Java JRE not found on Base

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129318

--- Comment #11 from Normand Renaud  ---
Hi,
Finally get solved.
I have w10/64, but IE or Edge on my system is 32. 
I loaded both versions of Java. first 32, with restart and load 64 .
Now LO Base / Table works

Big thank you guys, very helpfull

Have a Mery Christmass, HoHo !

Normand

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122218] After Update to 6.1.4 on macOS fonts are blurred on retina display (xcode 10)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122218

--- Comment #117 from bunkem  ---
Not sure what you guys are seeing but the 6.5alpha that I downloaded still has
fuzzy text in the calc sheet.

I've tried various fonts but it still looks like crap.

Same with the text in Writer.

OK a bit better because all the icons and text in formula bar are OK but still
no prize.

15" MBP Retina

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129460] concat function ignores decimal point display

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129460

--- Comment #1 from gyrlgith  ---
Created attachment 156640
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156640=edit
decimate point no change

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129460] New: concat function ignores decimal point display

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129460

Bug ID: 129460
   Summary: concat function ignores decimal point display
   Product: LibreOffice
   Version: 6.4.0.0.beta1+
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gyrlg...@protonmail.com

Description:
10/3=3.333...
This is not a mistake.
The problem is cell style> default> number> number of decimals = 0
Even with this setting, the concat function displays all the decimal points of
the referenced cell. I can't fix it by ignoring the cell style.
This is a very disturbing bug.


Steps to Reproduce:
1.A2 input > 10/3 >A2 view 3...
2.cell style > default > number > decimal points 0
3.concat input B1 to =A2
3.decimal points not 0. you cant setting 0 or other.

Actual Results:
write > steps to Reproduce

Expected Results:
3.decimal points not 0. you cant setting 0 or other.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
concat function cell. view decimal points settings 0.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127024] Err:522 on updating data from linked sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127024

b.  changed:

   What|Removed |Added

 CC||newbie...@gmx.de

--- Comment #10 from b.  ---
that option shouldn't be there while not working reliable ... !!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109324] [META] Calculate bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109324
Bug 109324 depends on bug 129396, which changed state.

Bug 129396 Summary: Shared formula group created by pasting row(s) stops 
listening to (part of) a range after insertion of a column before the formula 
group.
https://bugs.documentfoundation.org/show_bug.cgi?id=129396

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

[Eike Rathke (via logerrit)]

 sc/source/core/data/column.cxx |   12 +++-
 1 file changed, 11 insertions(+), 1 deletion(-)

New commits:
commit 491e8f60bf7f216a3bb3092b22334924b6c9aee1
Author: Eike Rathke 
AuthorDate: Tue Dec 17 23:51:54 2019 +0100
Commit: Eike Rathke 
CommitDate: Wed Dec 18 01:55:02 2019 +0100

Resolves: tdf#129396 Refresh shared formula group area listeners upon 
shifting

Regression from

commit 47230a036fe35b9a7a7c0609232849fcbb51efcc
CommitDate: Thu Feb 5 11:52:51 2015 +0100

Resolves: tdf#88792 do not hold a ScFormulaCell** in group area 
listener

where previously the listener position's column was taken from the
group's remembered top formula cell (then updated) position, which
holding the cell was wrong in other cases.

Change-Id: Ida1503daa7cbda2b41459ff5d63652a6febd91e0
Reviewed-on: https://gerrit.libreoffice.org/85347
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx
index 3cfe18891f63..268475df4d1c 100644
--- a/sc/source/core/data/column.cxx
+++ b/sc/source/core/data/column.cxx
@@ -2157,6 +2157,7 @@ class UpdateRefOnNonCopy
 // Run this before the position gets updated.
 sc::RefUpdateResult aRes = pCode->AdjustReferenceOnShift(*mpCxt, 
aOldPos);
 
+bool bGroupShifted = false;
 if (pTop->UpdatePosOnShift(*mpCxt))
 {
 ScAddress aErrorPos( ScAddress::UNINITIALIZED );
@@ -2172,6 +2173,15 @@ class UpdateRefOnNonCopy
 
 if (pCode->IsRecalcModeOnRefMove())
 aRes.mbValueChanged = true;
+
+// FormulaGroupAreaListener (contrary to ScBroadcastArea) is not
+// updated but needs to be re-setup, else at least its mpColumn
+// would indicate the old column to collect cells from. tdf#129396
+/* TODO: investigate if that could be short-cut to avoid all the
+ * EndListeningTo() / StartListeningTo() overhead and is really
+ * only necessary when shifting the column, not also when shifting
+ * rows. */
+bGroupShifted = true;
 }
 else if (aRes.mbReferenceModified && pCode->IsRecalcModeOnRefMove())
 {
@@ -2183,7 +2193,7 @@ class UpdateRefOnNonCopy
 if (aRes.mbNameModified)
 recompileTokenArray(*pTop);
 
-if (aRes.mbReferenceModified || aRes.mbNameModified)
+if (aRes.mbReferenceModified || aRes.mbNameModified || bGroupShifted)
 {
 sc::EndListeningContext aEndCxt(mpCxt->mrDoc, pOldCode.get());
 aEndCxt.setPositionDelta(
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/sfx2 include/vcl sfx2/source vcl/inc vcl/source vcl/unx

[Ashod Nakashian (via logerrit)]

 include/sfx2/viewfrm.hxx |1 
 include/vcl/svapp.hxx|6 +
 sfx2/source/view/viewfrm.cxx |7 +
 vcl/inc/svdata.hxx   |   26 ++--
 vcl/source/app/help.cxx  |8 -
 vcl/source/app/salvtables.cxx|2 
 vcl/source/app/stdtext.cxx   |   10 -
 vcl/source/app/svapp.cxx |   44 +++
 vcl/source/app/svdata.cxx|   62 +--
 vcl/source/app/svmain.cxx|   26 ++--
 vcl/source/outdev/font.cxx   |4 
 vcl/source/outdev/map.cxx|4 
 vcl/source/uitest/logger.cxx |6 -
 vcl/source/uitest/uitest.cxx |6 -
 vcl/source/window/brdwin.cxx |2 
 vcl/source/window/cursor.cxx |   10 +
 vcl/source/window/dialog.cxx |   38 +++---
 vcl/source/window/event.cxx  |   16 +-
 vcl/source/window/floatwin.cxx   |   24 ++--
 vcl/source/window/menu.cxx   |7 -
 vcl/source/window/menubarwindow.cxx  |   12 +-
 vcl/source/window/menufloatingwindow.cxx |2 
 vcl/source/window/mouse.cxx  |   36 +++---
 vcl/source/window/msgbox.cxx |   82 ++
 vcl/source/window/scrwnd.cxx |6 -
 vcl/source/window/stacking.cxx   |2 
 vcl/source/window/syswin.cxx |4 
 vcl/source/window/taskpanelist.cxx   |4 
 vcl/source/window/toolbox.cxx|4 
 vcl/source/window/window.cxx |   85 +++
 vcl/source/window/window2.cxx|   60 +-
 vcl/source/window/winproc.cxx|  173 ---
 vcl/source/window/wrkwin.cxx |   11 +
 vcl/unx/generic/window/salframe.cxx  |   16 +-
 vcl/unx/gtk3/gtk3gtkframe.cxx|6 -
 35 files changed, 488 insertions(+), 324 deletions(-)

New commits:
commit c2f8929ed76085bc81f390f90e06bd6781206537
Author: Ashod Nakashian 
AuthorDate: Wed May 29 23:33:25 2019 -0400
Commit: Michael Meeks 
CommitDate: Wed Dec 18 01:50:41 2019 +0100

vcl: sfx2: LOK: Support per-view popup windows

While we do support multiple views, there is only
one state for popup/floating windows, that also
includes the dialogs open and related windows/data.

This adds support to allow each view to have its own
popups and state, thus allowing multiple users to
interact with the dialogs independently of one
another.

(cherry picked from commit b50c341a53911f1d725947a4d8d3d2f782c94079)

Change-Id: I3786a561ca6ca113ad12425bdb491e5a30bd1a28
Reviewed-on: https://gerrit.libreoffice.org/82440
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Ashod Nakashian 
Reviewed-on: https://gerrit.libreoffice.org/85221
Tested-by: Jenkins
Reviewed-by: Michael Meeks 

diff --git a/include/sfx2/viewfrm.hxx b/include/sfx2/viewfrm.hxx
index cfd7fe068ae4..7f8be83f0aa7 100644
--- a/include/sfx2/viewfrm.hxx
+++ b/include/sfx2/viewfrm.hxx
@@ -50,6 +50,7 @@ class SFX2_DLLPUBLIC SfxViewFrame: public SfxShell, public 
SfxListener
 std::unique_ptr m_pDispatcher;
 SfxBindings*m_pBindings;
 ImplSVHelpData* m_pHelpData;
+ImplSVWinData*  m_pWinData;
 sal_uInt16  m_nAdjustPosPixelLock;
 
 private:
diff --git a/include/vcl/svapp.hxx b/include/vcl/svapp.hxx
index 95e46500a899..b36c22ed9de9 100644
--- a/include/vcl/svapp.hxx
+++ b/include/vcl/svapp.hxx
@@ -1458,6 +1458,12 @@ VCL_DLLPUBLIC ImplSVHelpData* CreateSVHelpData();
 VCL_DLLPUBLIC void DestroySVHelpData(ImplSVHelpData*);
 VCL_DLLPUBLIC void SetSVHelpData(ImplSVHelpData*);
 
+/// The following are to manage per-view (frame) window data.
+struct ImplSVWinData;
+VCL_DLLPUBLIC ImplSVWinData* CreateSVWinData();
+VCL_DLLPUBLIC void DestroySVWinData(ImplSVWinData*);
+VCL_DLLPUBLIC void SetSVWinData(ImplSVWinData*);
+
 inline void Application::EndYield()
 {
 PostUserEvent( Link() );
diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx
index a19a89a91b91..3e36ab14081b 100644
--- a/sfx2/source/view/viewfrm.cxx
+++ b/sfx2/source/view/viewfrm.cxx
@@ -1620,6 +1620,7 @@ SfxViewFrame::SfxViewFrame
 : m_pImpl( new SfxViewFrame_Impl( rFrame ) )
 , m_pBindings( new SfxBindings )
 , m_pHelpData(CreateSVHelpData())
+, m_pWinData(CreateSVWinData())
 , m_nAdjustPosPixelLock( 0 )
 {
 
@@ -1665,6 +1666,9 @@ SfxViewFrame::~SfxViewFrame()
 
 DestroySVHelpData(m_pHelpData);
 m_pHelpData = nullptr;
+
+DestroySVWinData(m_pWinData);
+m_pWinData = nullptr;
 }
 
 // Remove and delete the Dispatcher.
@@ -3309,6 +3313,9 @@ void SfxViewFrame::SetViewFrame( SfxViewFrame* pFrame )
 {
 if(pFrame)
 SetSVHelpData(pFrame->m_pHelpData);
+
+SetSVWinData(pFrame ? pFrame->m_pWinData : nullptr);
+
 SfxGetpApp()->SetViewFrame_Impl( pFrame );
 }
 
diff --git 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - translations

[Christian Lohmaier (via logerrit)]

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ec3915d99524c873243d5d66da77e8ce3a953ee2
Author: Christian Lohmaier 
AuthorDate: Wed Dec 18 01:09:41 2019 +0100
Commit: Gerrit Code Review 
CommitDate: Wed Dec 18 01:36:01 2019 +0100

Update git submodules

* Update translations from branch 'libreoffice-6-4'
  - update translations for 6.4.0 rc1

and force-fix errors using pocheck

Change-Id: Ifade3024bff4b2dcb177994fe2e5a3e1134ff17c

diff --git a/translations b/translations
index 8899f2f00aaf..f217c955342d 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit 8899f2f00aaf2bd76acd636f56be6dd6d090fa0a
+Subproject commit f217c955342dcb27ea404ebb639e9521b72a270b
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 129420] Decrease performance when select many aleatory cells with Ctrl pressed.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129420

--- Comment #10 from Yerinier Ferrás  ---
Comment on attachment 156639
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156639
Processor Doing Some Hard Work, when 30 cells are selected randomly.

By the time this screenshot was taken, the application had not yet finished
rendering the rest of the selected cells.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129420] Decrease performance when select many aleatory cells with Ctrl pressed.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129420

--- Comment #9 from Yerinier Ferrás  ---
Comment on attachment 156639
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156639
Processor Doing Some Hard Work, when 30 cells are selected randomly.

Para cuando esta captura de pantalla se tomó la aplicación todavía no había
terminado de renderear el resto de las celdas seleccionadas.

The application was launched from terminal using the following line:
export sal_use_vclplugin=gen && /opt/libreoffice6.3/program/soffice.bin --calc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sc/qa sc/source

[Deena Francis (via logerrit)]

 sc/qa/unit/ucalc.hxx  |2 ++
 sc/qa/unit/ucalc_formula.cxx  |   20 
 sc/source/core/tool/token.cxx |8 
 3 files changed, 26 insertions(+), 4 deletions(-)

New commits:
commit ab6720ec8a9359212fe3ea4f71037acd0b5709fa
Author: Deena Francis 
AuthorDate: Fri Dec 13 19:49:36 2019 +0530
Commit: Eike Rathke 
CommitDate: Wed Dec 18 01:16:32 2019 +0100

tdf#120948: row deltas should be stored as SCROW...

instead of SCCOL, else it may cause overflows.
Also included a unit test for protecting the fix.

Reviewed-on: https://gerrit.libreoffice.org/85118
Tested-by: Jenkins
Reviewed-by: Noel Grandin 
(cherry picked from commit 3b8e554b69de349a20d10ec90b27ab71a013b464)
Reviewed-on: https://gerrit.libreoffice.org/85180
Signed-off-by: Xisco Fauli 

Change-Id: I8f735b23b7f95ecf34ccae86f00c76b82b0d668f
Reviewed-on: https://gerrit.libreoffice.org/85205
Tested-by: Jenkins
Reviewed-by: Eike Rathke 

diff --git a/sc/qa/unit/ucalc.hxx b/sc/qa/unit/ucalc.hxx
index ba85b9b78042..157a3227eb68 100644
--- a/sc/qa/unit/ucalc.hxx
+++ b/sc/qa/unit/ucalc.hxx
@@ -562,6 +562,7 @@ public:
 void testProtectedSheetEditByColumn();
 void testFuncRowsHidden();
 void testInsertColCellStoreEventSwap();
+void testFormulaAfterDeleteRows();
 
 CPPUNIT_TEST_SUITE(Test);
 CPPUNIT_TEST(testCollator);
@@ -862,6 +863,7 @@ public:
 CPPUNIT_TEST(testProtectedSheetEditByColumn);
 CPPUNIT_TEST(testFuncRowsHidden);
 CPPUNIT_TEST(testInsertColCellStoreEventSwap);
+CPPUNIT_TEST(testFormulaAfterDeleteRows);
 CPPUNIT_TEST_SUITE_END();
 
 private:
diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx
index 8754239bbb2a..06cdf1e7ba4a 100644
--- a/sc/qa/unit/ucalc_formula.cxx
+++ b/sc/qa/unit/ucalc_formula.cxx
@@ -8993,4 +8993,24 @@ void Test::testInsertColCellStoreEventSwap()
 m_pDoc->DeleteTab(0);
 }
 
+void Test::testFormulaAfterDeleteRows()
+{
+sc::AutoCalcSwitch aACSwitch(*m_pDoc, true); // turn auto calc on.
+m_pDoc->InsertTab(0, "Test");
+
+// Fill A1:A7 with 1.0
+std::vector aVals(7, 1.0);
+m_pDoc->SetValues(ScAddress(0, 0, 0), aVals);
+// Set A70001 with formula "=SUM(A1:A7)"
+m_pDoc->SetString(0, 7, 0, "=SUM(A1:A7)");
+
+// Delete rows 2:69998
+m_pDoc->DeleteRow(ScRange(0, 1, 0, MAXCOL, 69997, 0));
+
+const ScAddress aPos(0, 3, 0);  // A4
+ASSERT_FORMULA_EQUAL(*m_pDoc, aPos, "SUM(A1:A3)", "Wrong formula in A4.");
+
+ASSERT_DOUBLES_EQUAL_MESSAGE("Wrong value at A4", 3.0, 
m_pDoc->GetValue(aPos));
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/core/tool/token.cxx b/sc/source/core/tool/token.cxx
index 0b8b52880dc4..906f170e810c 100644
--- a/sc/source/core/tool/token.cxx
+++ b/sc/source/core/tool/token.cxx
@@ -2833,8 +2833,8 @@ ShrinkResult shrinkRange( const sc::RefUpdateContext& 
rCxt, ScRange& rRefRange,
 else
 {
 // The reference range is truncated on the top.
-SCCOL nOffset = rDeletedRange.aStart.Row() - 
rRefRange.aStart.Row();
-SCCOL nDelta = rRefRange.aStart.Row() - 
rDeletedRange.aEnd.Row() - 1;
+SCROW nOffset = rDeletedRange.aStart.Row() - 
rRefRange.aStart.Row();
+SCROW nDelta = rRefRange.aStart.Row() - 
rDeletedRange.aEnd.Row() - 1;
 rRefRange.IncEndRowSticky(nDelta+nOffset);
 rRefRange.aStart.IncRow(nOffset);
 }
@@ -2847,7 +2847,7 @@ ShrinkResult shrinkRange( const sc::RefUpdateContext& 
rCxt, ScRange& rRefRange,
 
 // Reference is deleted in the middle. Move the last row
 // position upward.
-SCCOL nDelta = rDeletedRange.aStart.Row() - 
rDeletedRange.aEnd.Row() - 1;
+SCROW nDelta = rDeletedRange.aStart.Row() - 
rDeletedRange.aEnd.Row() - 1;
 rRefRange.IncEndRowSticky(nDelta);
 }
 else
@@ -2857,7 +2857,7 @@ ShrinkResult shrinkRange( const sc::RefUpdateContext& 
rCxt, ScRange& rRefRange,
 return STICKY;
 
 // The reference range is truncated on the bottom.
-SCCOL nDelta = rDeletedRange.aStart.Row() - rRefRange.aEnd.Row() - 
1;
+SCROW nDelta = rDeletedRange.aStart.Row() - rRefRange.aEnd.Row() - 
1;
 rRefRange.IncEndRowSticky(nDelta);
 }
 return SHRUNK;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 129420] Decrease performance when select many aleatory cells with Ctrl pressed.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129420

--- Comment #8 from Yerinier Ferrás  ---
Created attachment 156639
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156639=edit
Processor Doing Some Hard Work, when 30 cells are selected randomly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - sc/qa sc/source

[Dennis Francis (via logerrit)]

 sc/qa/unit/data/xls/tdf129127.xls |binary
 sc/qa/unit/filters-test.cxx   |   33 +
 sc/source/core/data/column4.cxx   |2 ++
 3 files changed, 35 insertions(+)

New commits:
commit c8079949bcccb20caf7fc91ee4567d811606c8e4
Author: Dennis Francis 
AuthorDate: Thu Dec 12 22:22:48 2019 +0530
Commit: Eike Rathke 
CommitDate: Wed Dec 18 01:14:01 2019 +0100

Resolves tdf#129127: do a safe swap of patterns

Following swap of patterns is not safe :
"""
const ScPatternAttr* pPat1 = GetPattern(nRow);
const ScPatternAttr* pPat2 = rOther.GetPattern(nRow);
SetPattern(nRow, *pPat2);
rOther.SetPattern(nRow, *pPat1);
"""

as the first SetPattern can cause deallocation of the pattern object
pointed to by pPat1 if it had a reference count of 1 to begin with.
In such cases, increase the reference count of first pattern by
putting it into document pool, thereby evading deallocation.

The stacktrace of the crash without the fix looks like :

Thread 1 "soffice.bin" received signal SIGSEGV, Segmentation fault.
602 SfxPoolItem *pPoolItem = rItem.Clone(pImpl->mpMaster);

0  0x74ad2905 in SfxItemPool::PutImpl(SfxPoolItem const&, unsigned 
short, bool) (this=0x16c6830, rItem=..., nWhich=39321, bPassingOwnership=false) 
at /ssd1/work/dennis/core/svl/source/items/itempool.cxx:602
1  0x7fffd179e5a5 in ScDocumentPool::PutImpl(SfxPoolItem const&, 
unsigned short, bool) (this=0x16c6830, rItem=..., nWhich=0, 
bPassingOwnership=false) at 
/ssd1/work/dennis/core/sc/source/core/data/docpool.cxx:333
2  0x7fffd14e88fb in SfxItemPool::Put(ScPatternAttr 
const&, unsigned short) (this=0x16c6830, rItem=..., nWhich=0) at 
/ssd1/work/dennis/core/include/svl/itempool.hxx:154
3  0x7fffd14dd228 in ScAttrArray::SetPatternAreaImpl(int, int, 
ScPatternAttr const*, bool, ScEditDataArray*, bool)
   (this=0x2cbc020, nStartRow=9, nEndRow=9, pPattern=0x2da5d80, 
bPutToPool=true, pDataArray=0x0, bPassingOwnership=false) at 
/ssd1/work/dennis/core/sc/source/core/data/attarray.cxx:464
4  0x7fffd1653fcd in ScAttrArray::SetPattern(int, ScPatternAttr const*, 
bool) (this=0x2cbc020, nRow=9, pPattern=0x2da5d80, bPutToPool=true) at 
/ssd1/work/dennis/core/sc/inc/attarray.hxx:142
5  0x7fffd163cd41 in ScColumn::SetPattern(int, ScPatternAttr const&) 
(this=0x2cb4610, nRow=9, rPatAttr=...) at 
/ssd1/work/dennis/core/sc/source/core/data/column.cxx:694
6  0x7fffd170e65b in ScColumn::Swap(ScColumn&, int, int, bool) 
(this=0x2339270, rOther=..., nRow1=0, nRow2=9, bPattern=true) at 
/ssd1/work/dennis/core/sc/source/core/data/column4.cxx:1112
7  0x7fffd1ada654 in ScTable::SortReorderByColumn(ScSortInfoArray 
const*, int, int, bool, ScProgress*) (this=0x2cb9ea0, pArray=0x5ef71a0, 
nRow1=0, nRow2=9, bPattern=true, pProgress=0x7fff09a0)
   at /ssd1/work/dennis/core/sc/source/core/data/table3.cxx:922
8  0x7fffd1adf991 in ScTable::Sort(ScSortParam const&, bool, bool, 
ScProgress*, sc::ReorderParam*) (this=0x2cb9ea0, rSortParam=..., 
bKeepQuery=false, bUpdateRefs=false, pProgress=0x7fff09a0, 
pUndo=0x7fff0950)
   at /ssd1/work/dennis/core/sc/source/core/data/table3.cxx:1750
9  0x7fffd17cc70a in ScDocument::Sort(short, ScSortParam const&, bool, 
bool, ScProgress*, sc::ReorderParam*) (
   this=0x2cc4db0, nTab=0, rSortParam=..., bKeepQuery=false, 
bUpdateRefs=false, pProgress=0x7fff09a0, pUndo=0x7fff0950) at 
/ssd1/work/dennis/core/sc/source/core/data/documen3.cxx:1411
10 0x7fffd22a2f76 in ScDBDocFunc::Sort(short, ScSortParam const&, bool, 
bool, bool) (this=0x7fff0b50, nTab=0, rSortParam=..., bRecord=true, 
bPaint=true, bApi=false)
   at /ssd1/work/dennis/core/sc/source/ui/docshell/dbdocfun.cxx:578
11 0x7fffd2744e29 in ScDBFunc::Sort(ScSortParam const&, bool, bool) 
(this=0x2e3b560, rSortParam=..., bRecord=true, bPaint=true) at 
/ssd1/work/dennis/core/sc/source/ui/view/dbfunc.cxx:217
12 0x7fffd2744d7b in ScDBFunc::UISort(ScSortParam const&) 
(this=0x2e3b560, rSortParam=...) at 
/ssd1/work/dennis/core/sc/source/ui/view/dbfunc.cxx:208
13 0x7fffd2735e3d in ScCellShell::ExecuteDB(SfxRequest&) 
(this=0x1e42330, rReq=...) at 
/ssd1/work/dennis/core/sc/source/ui/view/cellsh2.cxx:528

Change-Id: I70f8b95a6ff59f372b909fd173117a114906deff
Reviewed-on: https://gerrit.libreoffice.org/85072
Tested-by: Jenkins
Reviewed-by: Dennis Francis 
(cherry picked from commit f86824cca0c442d371379d2ea0bff2241f18ab3d)
Reviewed-on: https://gerrit.libreoffice.org/85279
Reviewed-by: Eike Rathke 

diff --git a/sc/qa/unit/data/xls/tdf129127.xls 
b/sc/qa/unit/data/xls/tdf129127.xls
new file mode 100644
index ..4862d2319691
Binary files /dev/null and b/sc/qa/unit/data/xls/tdf129127.xls differ
diff --git a/sc/qa/unit/filters-test.cxx b/sc/qa/unit/filters-test.cxx
index 

[Libreoffice-bugs] [Bug 129420] Decrease performance when select many aleatory cells with Ctrl pressed.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129420

--- Comment #7 from Yerinier Ferrás  ---
(In reply to Roman Kuznetsov from comment #5)
> (In reply to Julien Nabet from comment #4)
> 
> > 
> > The goal is to know if it concerns only gtk3 rendering or not.
> 
> It may be Ubuntu build problem
> 
> Yerinier, please try install LibreOffice from libreoffice.org, not from PPA
> or repo of your OS.

Hi Roman,
Before I installed the latest version (6.3.4), I purged all packages from
version: 6.0.7.3. Then I installed version 6.3.4, from:
https://mirror.ueb.edu.ec/tdf/libreoffice/stable/6.3.4/deb/x86_64/LibreOffice_6.3.4_Linux_x86-64_deb.tar.gz

Now I executed 'export sal_use_vclplugin=gen && soffice --calc' (as Julien
Nabet suggested) bu in this way: 
export sal_use_vclplugin=gen && /opt/libreoffice6.3/program/soffice.bin --calc

I tested the scenario many times, and the same result. During my tests I
noticed that the fan cooler of my processor was increasing the sound. Then I
opened the System Monitor App and put it side by side in the descktop with LO
Calc. I performed the test a couple times and I taked a screen picture
(attached to this issue), as You can see for one minute and more  the porcessor
is doing something many times. This happened when I selected a least 30 cells
in alleatory way.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/cib_contract4236' - vcl/source

[Noel Grandin (via logerrit)]

 vcl/source/outdev/text.cxx |   12 +---
 1 file changed, 9 insertions(+), 3 deletions(-)

New commits:
commit e73abe51aef8c0f1ff4fdbc370c714c20cf15db6
Author: Noel Grandin 
AuthorDate: Tue Dec 17 12:54:56 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Wed Dec 18 01:03:24 2019 +0100

tdf#112989 reduce export to PDF time

reduces the time from 33s to 24s for me

Change-Id: Ia70e1c4220ebedf0b686ed76c5704efa551591fe
Reviewed-on: https://gerrit.libreoffice.org/85281
Tested-by: Jenkins
Reviewed-by: Noel Grandin 
(cherry picked from commit 11c0effe3def917ec2002a30dbbcca1c5758ffa9)
Reviewed-on: https://gerrit.libreoffice.org/85302
Reviewed-by: Adolfo Jayme Barrientos 
(cherry picked from commit 580f2b93a9c754743341e5e2f40084bceb8a1680)

diff --git a/vcl/source/outdev/text.cxx b/vcl/source/outdev/text.cxx
index fb3092739ffc..69919d2cac5f 100644
--- a/vcl/source/outdev/text.cxx
+++ b/vcl/source/outdev/text.cxx
@@ -48,6 +48,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #define TEXT_DRAW_ELLIPSIS  (DrawTextFlags::EndEllipsis | 
DrawTextFlags::PathEllipsis | DrawTextFlags::NewsEllipsis)
 
@@ -1189,7 +1190,7 @@ ImplLayoutArgs OutputDevice::ImplPrepareLayoutArgs( 
OUString& rStr,
 const sal_Unicode* pBase = rStr.getStr();
 const sal_Unicode* pStr = pBase + nMinIndex;
 const sal_Unicode* pEnd = pBase + nEndIndex;
-OUStringBuffer sTmpStr(rStr);
+boost::optional xTmpStr;
 for( ; pStr < pEnd; ++pStr )
 {
 // TODO: are there non-digit localizations?
@@ -1198,11 +1199,16 @@ ImplLayoutArgs OutputDevice::ImplPrepareLayoutArgs( 
OUString& rStr,
 // translate characters to local preference
 sal_UCS4 cChar = GetLocalizedChar( *pStr, meTextLanguage );
 if( cChar != *pStr )
+{
+if (!xTmpStr)
+xTmpStr = OUStringBuffer(rStr);
 // TODO: are the localized digit surrogates?
-sTmpStr[pStr - pBase] = cChar;
+(*xTmpStr)[pStr - pBase] = cChar;
+}
 }
 }
-rStr = sTmpStr.makeStringAndClear();
+if (xTmpStr)
+rStr = (*xTmpStr).makeStringAndClear();
 }
 
 // right align for RTL text, DRAWPOS_REVERSED, RTL window style
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - 3 commits - ucb/source

[Mike Kaganski (via logerrit)]

 ucb/source/ucp/webdav-neon/NeonLockStore.cxx |   13 ++-
 ucb/source/ucp/webdav-neon/NeonLockStore.hxx |2 +
 ucb/source/ucp/webdav-neon/NeonSession.cxx   |   31 +++
 ucb/source/ucp/webdav-neon/NeonSession.hxx   |1 
 ucb/source/ucp/webdav-neon/webdavcontent.cxx |   10 +++-
 5 files changed, 46 insertions(+), 11 deletions(-)

New commits:
commit d49602781e920c008ee3a38df5bd6c14552e0a24
Author: Mike Kaganski 
AuthorDate: Mon Jul 8 23:47:12 2019 +1000
Commit: Thorsten Behrens 
CommitDate: Wed Dec 18 00:45:26 2019 +0100

tdf#126279 related: remove locks from NeonLockStore after NE_AUTH error

Change-Id: Idbbb9bb215e3a56e72a29f798c5a5f84afaf2213
Reviewed-on: https://gerrit.libreoffice.org/75224
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 
(cherry picked from commit 94e4695bcfcb9356d37942c47359b94531ef7b95)

diff --git a/ucb/source/ucp/webdav-neon/NeonLockStore.cxx 
b/ucb/source/ucp/webdav-neon/NeonLockStore.cxx
index 390d58c4e8cb..85b821b2bd87 100644
--- a/ucb/source/ucp/webdav-neon/NeonLockStore.cxx
+++ b/ucb/source/ucp/webdav-neon/NeonLockStore.cxx
@@ -153,7 +153,7 @@ void NeonLockStore::stopTicker(osl::ClearableMutexGuard & 
rGuard)
 
 rGuard.clear();
 
-if (pTickerThread.is())
+if (pTickerThread.is() && pTickerThread->getIdentifier() != 
osl::Thread::getCurrentIdentifier())
 pTickerThread->join(); // without m_aMutex locked (to prevent deadlock)
 }
 
@@ -198,6 +198,13 @@ void NeonLockStore::removeLock( NeonLock * pLock )
 stopTicker(aGuard);
 }
 
+void NeonLockStore::removeLockDeferred(NeonLock* pLock)
+{
+osl::MutexGuard aGuard(m_aMutex);
+
+m_aRemoveDeferred.push_back(pLock);
+}
+
 void NeonLockStore::refreshLocks()
 {
 osl::MutexGuard aGuard( m_aMutex );
@@ -233,6 +240,10 @@ void NeonLockStore::refreshLocks()
 }
 ++it;
 }
+// removeLock will not need to actually release the lock, because this is 
run from TickerThread
+for (auto pLock : m_aRemoveDeferred)
+removeLock(pLock);
+m_aRemoveDeferred.clear();
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/ucb/source/ucp/webdav-neon/NeonLockStore.hxx 
b/ucb/source/ucp/webdav-neon/NeonLockStore.hxx
index 7a76a321ced6..fa64cb320374 100644
--- a/ucb/source/ucp/webdav-neon/NeonLockStore.hxx
+++ b/ucb/source/ucp/webdav-neon/NeonLockStore.hxx
@@ -66,6 +66,7 @@ class NeonLockStore
 ne_lock_store* m_pNeonLockStore;
 rtl::Reference< TickerThread > m_pTickerThread;
 LockInfoMapm_aLockInfoMap;
+std::vector m_aRemoveDeferred;
 
 public:
 NeonLockStore();
@@ -82,6 +83,7 @@ public:
   sal_Int32 nLastChanceToSendRefreshRequest );
 
 void removeLock( NeonLock * pLock );
+void removeLockDeferred(NeonLock* pLock);
 
 void refreshLocks();
 
diff --git a/ucb/source/ucp/webdav-neon/NeonSession.cxx 
b/ucb/source/ucp/webdav-neon/NeonSession.cxx
index dfeba0acbabd..c1336c07a9c0 100644
--- a/ucb/source/ucp/webdav-neon/NeonSession.cxx
+++ b/ucb/source/ucp/webdav-neon/NeonSession.cxx
@@ -1631,6 +1631,7 @@ bool NeonSession::LOCK( NeonLock * pLock,
 {
 // tdf#126279: see handling of NE_AUTH in HandleError
 m_bNeedNewSession = true;
+m_aNeonLockStore.removeLockDeferred(pLock);
 }
 return false;
 }
commit 6dcfaa015d1dfd345c396d756a476dba80f182a2
Author: Mike Kaganski 
AuthorDate: Mon Jul 8 16:25:16 2019 +1000
Commit: Thorsten Behrens 
CommitDate: Wed Dec 18 00:43:49 2019 +0100

tdf#126279: reinitialize session after NE_AUTH errors in (UN)LOCK

This just fixes the crash; but there's still a problem left/TODO, because
the lock is kept registered with NeonLockStore; following attempts to lock
and unlock fail.

The NE_AUTH error is returned from this call stack:

neon.dll!clean_session(auth_session * sess) Line 275
at 
C:\cygwin\home\user\lode\dev\core\workdir\UnpackedTarball\neon\src\ne_auth.c(275)
neon.dll!ah_post_send(ne_request_s * req, void * cookie, const ne_status * 
status) Line 1554
at 
C:\cygwin\home\user\lode\dev\core\workdir\UnpackedTarball\neon\src\ne_auth.c(1554)
neon.dll!ne_end_request(ne_request_s * req) Line 1399
at 
C:\cygwin\home\user\lode\dev\core\workdir\UnpackedTarball\neon\src\ne_request.c(1399)
neon.dll!ne_xml_dispatch_request(ne_request_s * req, ne_xml_parser_s * 
parser) Line 105
at 
C:\cygwin\home\user\lode\dev\core\workdir\UnpackedTarball\neon\src\ne_xmlreq.c(105)
neon.dll!ne_lock_refresh(ne_session_s * sess, ne_lock * lock) Line 849
at 
C:\cygwin\home\user\lode\dev\core\workdir\UnpackedTarball\neon\src\ne_locks.c(849)
ucpdav1.dll!webdav_ucp::NeonSession::LOCK(ne_lock * pLock, long & 
rlastChanceToSendRefreshRequest) Line 1663
at 
C:\cygwin\home\user\lode\dev\core\ucb\source\ucp\webdav-neon\NeonSession.cxx(1663)

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #43 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/580f2b93a9c754743341e5e2f40084bceb8a1680

tdf#112989 reduce export to PDF time

It will be available in 6.4.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled for Latin (text layout issue)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.5.0|target:6.5.0 target:6.4.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - vcl/source

[Noel Grandin (via logerrit)]

 vcl/source/outdev/text.cxx |   12 +---
 1 file changed, 9 insertions(+), 3 deletions(-)

New commits:
commit 580f2b93a9c754743341e5e2f40084bceb8a1680
Author: Noel Grandin 
AuthorDate: Tue Dec 17 12:54:56 2019 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Tue Dec 17 23:52:02 2019 +0100

tdf#112989 reduce export to PDF time

reduces the time from 33s to 24s for me

Change-Id: Ia70e1c4220ebedf0b686ed76c5704efa551591fe
Reviewed-on: https://gerrit.libreoffice.org/85281
Tested-by: Jenkins
Reviewed-by: Noel Grandin 
(cherry picked from commit 11c0effe3def917ec2002a30dbbcca1c5758ffa9)
Reviewed-on: https://gerrit.libreoffice.org/85302
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/vcl/source/outdev/text.cxx b/vcl/source/outdev/text.cxx
index 3c69069929a8..0bb1d36fd35e 100644
--- a/vcl/source/outdev/text.cxx
+++ b/vcl/source/outdev/text.cxx
@@ -48,6 +48,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #define TEXT_DRAW_ELLIPSIS  (DrawTextFlags::EndEllipsis | 
DrawTextFlags::PathEllipsis | DrawTextFlags::NewsEllipsis)
 
@@ -1189,7 +1190,7 @@ ImplLayoutArgs OutputDevice::ImplPrepareLayoutArgs( 
OUString& rStr,
 const sal_Unicode* pBase = rStr.getStr();
 const sal_Unicode* pStr = pBase + nMinIndex;
 const sal_Unicode* pEnd = pBase + nEndIndex;
-OUStringBuffer sTmpStr(rStr);
+boost::optional xTmpStr;
 for( ; pStr < pEnd; ++pStr )
 {
 // TODO: are there non-digit localizations?
@@ -1198,11 +1199,16 @@ ImplLayoutArgs OutputDevice::ImplPrepareLayoutArgs( 
OUString& rStr,
 // translate characters to local preference
 sal_UCS4 cChar = GetLocalizedChar( *pStr, meTextLanguage );
 if( cChar != *pStr )
+{
+if (!xTmpStr)
+xTmpStr = OUStringBuffer(rStr);
 // TODO: are the localized digit surrogates?
-sTmpStr[pStr - pBase] = cChar;
+(*xTmpStr)[pStr - pBase] = cChar;
+}
 }
 }
-rStr = sTmpStr.makeStringAndClear();
+if (xTmpStr)
+rStr = (*xTmpStr).makeStringAndClear();
 }
 
 // right align for RTL text, DRAWPOS_REVERSED, RTL window style
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 128671] master branch cannot be built without manual hacks with Aarch64 distro config

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128671

--- Comment #23 from Stephan Bergmann  ---
(In reply to Stephan Bergmann from comment #22)
> That's what  "android: Fix the
> 'bridges' build on aarch64" should address.

Please check whether  "tdf#128671:
Rely on unwind.h, declare what's missing from cxxabi.h" fixes those problems
(and ideally report your results directly in that Gerrit change).  (I only
checked that change with a Linux aaarch64 build, not with an Adnroid aarch64
one.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122218] After Update to 6.1.4 on macOS fonts are blurred on retina display (xcode 10)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122218

--- Comment #116 from solarcolom...@icloud.com ---
(In reply to eisa01 from comment #114)
> (In reply to eisa01 from comment #113)
> > Yup, it's now crisp again, apart from the lower bar where e.g., "Sum" and so
> > on is displayed in Calc (only opened Calc)
> Sorry spoke to fast, the cell-contents are not crisp, but the rest of the UI
> in Calc is

Not a single problem here (MacBook Pro Retina) with the display quality.
Actually, font rendering looks far better (Thunderbolt display too) than in any
previous versions).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122218] After Update to 6.1.4 on macOS fonts are blurred on retina display (xcode 10)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122218

--- Comment #115 from solarcolom...@icloud.com ---
Yes, LO. You made me look a bit stupid. And I am quite glad. 6.5 is better than
any previous version (for Osx). I run a couple of old simulations (which are
not possible to carry out with excel...) without any issues. Muchas Gracias
from Colombia. May god and such do something good for you ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129459] EMF+ not filling shapes when using solid color brush

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129459

--- Comment #3 from Chris Sherlock  ---
Created attachment 156638
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156638=edit
How test_libuemf_p_ref.emf displays

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129459] EMF+ not filling shapes when using solid color brush

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129459

Chris Sherlock  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |chris.sherloc...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129459] EMF+ not filling shapes when using solid color brush

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129459

Chris Sherlock  changed:

   What|Removed |Added

 CC||chris.sherloc...@gmail.com

--- Comment #1 from Chris Sherlock  ---
Created attachment 156636
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156636=edit
test_libuemf_p_ref.emf test image from the libUEMF project

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129459] EMF+ not filling shapes when using solid color brush

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129459

--- Comment #2 from Chris Sherlock  ---
Created attachment 156637
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156637=edit
How test_libuemf_p_ref.emf should display

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129459] EMF+ not filling shapes when using solid color brush

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129459

Chris Sherlock  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129459] New: EMF+ not filling shapes when using solid color brush

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129459

Bug ID: 129459
   Summary: EMF+ not filling shapes when using solid color brush
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: graphics stack
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: chris.sherloc...@gmail.com

Description:
EMF+ shapes are not filling when the brush style is a solid color. 

Steps to Reproduce:
Open test image EMF+ file



Actual Results:
Notice that the top shapes do not have a fill color.

Expected Results:
Images should have purple fill color. 


Reproducible: Always


User Profile Reset: No



Additional Info:
This is caused because we aren't handling brushes with a solid fill color.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa sw/source

[Michael Stahl (via logerrit)]

 sw/qa/core/data/ww8/pass/ofz18534-1.doc |binary
 sw/source/filter/basflt/fltshell.cxx|   32 
 sw/source/filter/inc/fltshell.hxx   |7 +--
 sw/source/filter/ww8/writerhelper.cxx   |4 ++--
 sw/source/filter/ww8/ww8par.cxx |4 ++--
 sw/source/filter/ww8/ww8par6.cxx|6 ++
 6 files changed, 31 insertions(+), 22 deletions(-)

New commits:
commit 9e63d328691014bc97f6b66b708ed9dec53618e6
Author: Michael Stahl 
AuthorDate: Tue Dec 17 18:02:34 2019 +0100
Commit: Caolán McNamara 
CommitDate: Tue Dec 17 22:31:44 2019 +0100

ofz#18534 sw: WW8 import: avoid creating redlines that overlap...

...with fieldmarks, as the editing operations already do.

This was triggering ~SwIndexReg assert when creating this redline:

$4 = " \b\nfür \a\003 \b\nKlasse \a\003 \b\t\tSchuljahr \a\003  
   \b\t\a\003  \b. Halbjahr\nLeistungsbeurteilung lt. Konferenzbeschluss vom "

Change-Id: I904be93e044c4b98bb8c806357ed061692303c7a
Reviewed-on: https://gerrit.libreoffice.org/85149
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/qa/core/data/ww8/pass/ofz18534-1.doc 
b/sw/qa/core/data/ww8/pass/ofz18534-1.doc
new file mode 100644
index ..6b50fdd6d419
Binary files /dev/null and b/sw/qa/core/data/ww8/pass/ofz18534-1.doc differ
diff --git a/sw/source/filter/basflt/fltshell.cxx 
b/sw/source/filter/basflt/fltshell.cxx
index 359ab5628e77..a9727bda9a4f 100644
--- a/sw/source/filter/basflt/fltshell.cxx
+++ b/sw/source/filter/basflt/fltshell.cxx
@@ -66,6 +66,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -131,7 +132,7 @@ void SwFltStackEntry::SetEndPos(const SwPosition& rEndPos)
 m_aPtPos.SetPos(rEndPos);
 }
 
-bool SwFltStackEntry::MakeRegion(SwDoc* pDoc, SwPaM& rRegion, bool bCheck,
+bool SwFltStackEntry::MakeRegion(SwDoc* pDoc, SwPaM& rRegion, RegionMode const 
eCheck,
 const SwFltPosition , const SwFltPosition , bool bIsParaEnd,
 sal_uInt16 nWhich)
 {
@@ -180,16 +181,22 @@ bool SwFltStackEntry::MakeRegion(SwDoc* pDoc, SwPaM& 
rRegion, bool bCheck,
 OSL_ENSURE( CheckNodesRange( rRegion.Start()->nNode,
  rRegion.End()->nNode, true ),
  "attribute or similar crosses section-boundaries" );
-if( bCheck )
-return CheckNodesRange( rRegion.Start()->nNode,
-rRegion.End()->nNode, true );
-else
-return true;
+bool bRet = true;
+if (eCheck & RegionMode::CheckNodes)
+{
+bRet &= CheckNodesRange(rRegion.Start()->nNode,
+rRegion.End()->nNode, true);
+}
+if (eCheck & RegionMode::CheckFieldmark)
+{
+bRet &= !sw::mark::IsFieldmarkOverlap(rRegion);
+}
+return bRet;
 }
 
-bool SwFltStackEntry::MakeRegion(SwDoc* pDoc, SwPaM& rRegion, bool bCheck) 
const
+bool SwFltStackEntry::MakeRegion(SwDoc* pDoc, SwPaM& rRegion, RegionMode 
eCheck) const
 {
-return MakeRegion(pDoc, rRegion, bCheck, m_aMkPos, m_aPtPos, bIsParaEnd,
+return MakeRegion(pDoc, rRegion, eCheck, m_aMkPos, m_aPtPos, bIsParaEnd,
 pAttr->Which());
 }
 
@@ -489,7 +496,7 @@ static bool MakePoint(const SwFltStackEntry& rEntry, SwDoc* 
pDoc,
 static bool MakeBookRegionOrPoint(const SwFltStackEntry& rEntry, SwDoc* pDoc,
 SwPaM& rRegion )
 {
-if (rEntry.MakeRegion(pDoc, rRegion, true/*bCheck*/ ))
+if (rEntry.MakeRegion(pDoc, rRegion, 
SwFltStackEntry::RegionMode::CheckNodes))
 {
 if (rRegion.GetPoint()->nNode.GetNode().FindTableBoxStartNode()
   != rRegion.GetMark()->nNode.GetNode().FindTableBoxStartNode())
@@ -591,7 +598,7 @@ void SwFltControlStack::SetAttrInDoc(const SwPosition& 
rTmpPos,
 SwNumRule* pNumRule = pDoc->FindNumRulePtr( rNumNm );
 if( pNumRule )
 {
-if( rEntry.MakeRegion(pDoc, aRegion, true))
+if (rEntry.MakeRegion(pDoc, aRegion, 
SwFltStackEntry::RegionMode::CheckNodes))
 {
 SwNodeIndex aTmpStart( aRegion.Start()->nNode );
 SwNodeIndex aTmpEnd( aTmpStart );
@@ -757,7 +764,8 @@ void SwFltControlStack::SetAttrInDoc(const SwPosition& 
rTmpPos,
 break;
 case RES_FLTR_REDLINE:
 {
-if (rEntry.MakeRegion(pDoc, aRegion, true))
+if (rEntry.MakeRegion(pDoc, aRegion,
+
SwFltStackEntry::RegionMode::CheckNodes|SwFltStackEntry::RegionMode::CheckFieldmark))
 {
 pDoc->getIDocumentRedlineAccess().SetRedlineFlags( 
RedlineFlags::On
   | RedlineFlags::ShowInsert
@@ -791,7 +799,7 @@ void SwFltControlStack::SetAttrInDoc(const SwPosition& 
rTmpPos,
 {
 rEntry.SetIsParaEnd( IsParaEndInCPs(nStart,nEnd,bHasSdOD) );
 }
-if 

[Libreoffice-commits] core.git: vcl/inc vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/inc/unx/gtk/gtkdata.hxx |   15 
 vcl/unx/gtk3/gtk3gtkframe.cxx   |   48 
 vcl/unx/gtk3/gtk3gtkobject.cxx  |4 +--
 vcl/unx/gtk3/gtk3gtksalmenu.cxx |2 -
 4 files changed, 27 insertions(+), 42 deletions(-)

New commits:
commit 41c34570b98f31cc920efa2ba0eda9634188122a
Author: Caolán McNamara 
AuthorDate: Tue Dec 17 15:37:14 2019 +
Commit: Caolán McNamara 
CommitDate: Tue Dec 17 22:31:27 2019 +0100

unfold the gtk-related inline we don't need anymore

Change-Id: I9b5ef4cc4e00649c4609bb576c01ce2ea15e4fdd
Reviewed-on: https://gerrit.libreoffice.org/85309
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/inc/unx/gtk/gtkdata.hxx b/vcl/inc/unx/gtk/gtkdata.hxx
index 9830843e30ab..3ee22e90f1b7 100644
--- a/vcl/inc/unx/gtk/gtkdata.hxx
+++ b/vcl/inc/unx/gtk/gtkdata.hxx
@@ -40,26 +40,11 @@ namespace com { namespace sun { namespace star { namespace 
accessibility { class
 class GtkSalDisplay;
 class DocumentFocusListener;
 
-inline GdkWindow * widget_get_window(GtkWidget *widget)
-{
-return gtk_widget_get_window(widget);
-}
-
 inline ::Window widget_get_xid(GtkWidget *widget)
 {
 return GDK_WINDOW_XID(gtk_widget_get_window(widget));
 }
 
-inline void widget_set_can_focus(GtkWidget *widget, gboolean can_focus)
-{
-return gtk_widget_set_can_focus(widget, can_focus);
-}
-
-inline void widget_set_can_default(GtkWidget *widget, gboolean can_default)
-{
-return gtk_widget_set_can_default(widget, can_default);
-}
-
 class GtkSalTimer final : public SalTimer
 {
 struct SalGtkTimeoutSource *m_pTimeout;
diff --git a/vcl/unx/gtk3/gtk3gtkframe.cxx b/vcl/unx/gtk3/gtk3gtkframe.cxx
index 54ba13e1ee19..ec183b821421 100644
--- a/vcl/unx/gtk3/gtk3gtkframe.cxx
+++ b/vcl/unx/gtk3/gtk3gtkframe.cxx
@@ -497,7 +497,7 @@ static void hud_activated( gboolean hud_active, gpointer 
user_data )
 static bool ensure_dbus_setup( gpointer data )
 {
 GtkSalFrame* pSalFrame = static_cast< GtkSalFrame* >( data );
-GdkWindow* gdkWindow = widget_get_window( pSalFrame->getWindow() );
+GdkWindow* gdkWindow = gtk_widget_get_window( pSalFrame->getWindow() );
 
 if ( gdkWindow != nullptr && g_object_get_data( G_OBJECT( gdkWindow ), 
"g-lo-menubar" ) == nullptr )
 {
@@ -1152,9 +1152,9 @@ void GtkSalFrame::Init( SystemParentData* pSysData )
 if( pSysData->nSize > sizeof(pSysData->nSize)+sizeof(pSysData->aWindow) && 
pSysData->bXEmbedSupport )
 {
 m_pWindow = gtk_plug_new_for_display( getGdkDisplay(), 
pSysData->aWindow );
-widget_set_can_default( m_pWindow, true );
-widget_set_can_focus( m_pWindow, true );
-gtk_widget_set_sensitive( m_pWindow, true );
+gtk_widget_set_can_default(m_pWindow, true);
+gtk_widget_set_can_focus(m_pWindow, true);
+gtk_widget_set_sensitive(m_pWindow, true);
 }
 else
 {
@@ -1453,7 +1453,7 @@ void GtkSalFrame::AllocateFrame()
 if (m_pSurface)
 cairo_surface_destroy(m_pSurface);
 
-m_pSurface = 
gdk_window_create_similar_surface(widget_get_window(m_pWindow),
+m_pSurface = 
gdk_window_create_similar_surface(gtk_widget_get_window(m_pWindow),

CAIRO_CONTENT_COLOR_ALPHA,
aFrameSize.getX(),
aFrameSize.getY());
@@ -1721,7 +1721,7 @@ void GtkSalFrame::SetScreen( unsigned int nNewScreen, 
SetType eType, tools::Rect
 gtk_window_set_screen( GTK_WINDOW( m_pWindow ), pScreen );
 
 gint nOldMonitor = gdk_screen_get_monitor_at_window(
-pScreen, widget_get_window( m_pWindow ) );
+pScreen, gtk_widget_get_window( m_pWindow ) );
 if (bSameMonitor)
 nMonitor = nOldMonitor;
 
@@ -1778,7 +1778,7 @@ void GtkSalFrame::SetScreen( unsigned int nNewScreen, 
SetType eType, tools::Rect
 
 gtk_window_move(GTK_WINDOW(m_pWindow), nX, nY);
 
-gdk_window_set_fullscreen_mode( widget_get_window(m_pWindow), 
m_bSpanMonitorsWhenFullscreen
+gdk_window_set_fullscreen_mode( gtk_widget_get_window(m_pWindow), 
m_bSpanMonitorsWhenFullscreen
 ? GDK_FULLSCREEN_ON_ALL_MONITORS : GDK_FULLSCREEN_ON_CURRENT_MONITOR );
 
 GtkWidget* pMenuBarContainerWidget = m_pSalMenu ? 
m_pSalMenu->GetMenuBarContainerWidget() : nullptr;
@@ -1932,7 +1932,7 @@ void GtkSalFrame::ToTop( SalFrameToTop nFlags )
 if (!(nFlags & SalFrameToTop::GrabFocusOnly))
 gtk_window_present_with_time(GTK_WINDOW(m_pWindow), 
GetLastInputEventTime());
 else
-gdk_window_focus(widget_get_window(m_pWindow), 
GetLastInputEventTime());
+gdk_window_focus(gtk_widget_get_window(m_pWindow), 
GetLastInputEventTime());
 }
 else
 {
@@ -1948,7 +1948,7 @@ 

[Libreoffice-bugs] [Bug 129377] Crash when using insert > table of contents... > table of contents, index... (ios 4.2)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129377

--- Comment #5 from Tor Lillqvist  ---
And if one builds without assertions active, no dialog shows up and nothing
happens in web-based Online with "make run".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs