[Libreoffice-ux-advise] [Bug 128658] image compress and impress optimization Defaults
https://bugs.documentfoundation.org/show_bug.cgi?id=128658 --- Comment #4 from andreas_k --- The patch for impress presentation optimizer https://gerrit.libreoffice.org/c/core/+/86436 I use similar settings than Powerpoint - E-Mail 96 DPI JPG 70 - Web 150 DPI JPG 75 - Print 300 DPI JPG 80 - High Fidelity (Reduce image resolution not set) -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 120594] Crash attempting to open More Fields dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=120594 --- Comment #34 from wdeh...@exalondelft.nl --- Kept crashing for me as well. Started to work after deleting AppData/Roaming/Libreoffice/4. Version: 6.3.3.2 (x64) Build ID: a64200df03143b798afd1ec74a12ab50359878ed CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win; Locale: en-US (en_NL); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - filter/source
filter/source/graphicfilter/icgm/class7.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6bc3f02ed2378dd70f03df64f53e852e3c9dbfdd Author: Caolán McNamara AuthorDate: Sun Jan 5 20:37:20 2020 + Commit: Michael Stahl CommitDate: Wed Jan 8 15:42:38 2020 +0100 ofz#19803 check for negative values Change-Id: I30036a16cf1651a7e27c7aefa086b3725d58933a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86250 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara (cherry picked from commit 0ab8ae4d98122f7de50365a062675d001ef0ca6a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86341 Reviewed-by: Michael Stahl diff --git a/filter/source/graphicfilter/icgm/class7.cxx b/filter/source/graphicfilter/icgm/class7.cxx index 8c2478a308ae..b1652cc84ae0 100644 --- a/filter/source/graphicfilter/icgm/class7.cxx +++ b/filter/source/graphicfilter/icgm/class7.cxx @@ -80,7 +80,7 @@ void CGM::ImplDoClass7() mpChart->mDataNode[ 0 ] = *reinterpret_cast( pAppData ); sal_Int8 nZoneEnum = mpChart->mDataNode[ 0 ].nZoneEnum; -if ( nZoneEnum && ( nZoneEnum <= 6 ) ) +if (nZoneEnum > 0 && nZoneEnum <= 6) mpChart->mDataNode[ nZoneEnum ] = *reinterpret_cast( pAppData ); } break; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 11ab8389d4a2a05c18d23160e0ec51d559a75918 Author: Christian Lohmaier AuthorDate: Wed Jan 8 15:42:43 2020 +0100 Commit: Gerrit Code Review CommitDate: Wed Jan 8 15:42:43 2020 +0100 Update git submodules * Update helpcontent2 from branch 'libreoffice-6-4' to daea7016dd2410de8a610cc63a6ab3d84b256c52 - avoid unnecessary change in po files due to use of spaces to indent po file extraction would strip tabs, but keeps spaces when extracting strings. Change-Id: I2947b12787f52f65ef9981ba6a9c9ffdee503a6b (cherry picked from commit 9fc4da0db94a4d06ab31ada262551a0a28f2859e) diff --git a/helpcontent2 b/helpcontent2 index b69d4fce04ce..daea7016dd24 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit b69d4fce04ce452840f9c4fbe0de83e7316b5900 +Subproject commit daea7016dd2410de8a610cc63a6ab3d84b256c52 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129879] Qt UI swapped button order in save dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=129879 Commit Notification changed: What|Removed |Added Whiteboard|target:6.5.0|target:6.5.0 target:6.4.0.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129879] Qt UI swapped button order in save dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=129879 --- Comment #6 from Commit Notification --- Tomáš Chvátal committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/95d7d13205c05c2114a6d3bc2c4538246b22f3e0 tdf#129879 Fix wrong order of buttons It will be available in 6.4.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: solenv/flatpak-manifest.in
solenv/flatpak-manifest.in |6 ++ 1 file changed, 6 insertions(+) New commits: commit 97cae48ae9711e27eaf80058fca7f9a5d4cf547b Author: Stephan Bergmann AuthorDate: Wed Jan 8 11:33:25 2020 +0100 Commit: Stephan Bergmann CommitDate: Wed Jan 8 15:41:42 2020 +0100 Adapt solenv/flatpak-manifest.in to implicit --enable-skia (or should it better explicitly --disable-skia?) Change-Id: Id9483bee4148ec1101272b7b05f2ca1cd12e12e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86414 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/solenv/flatpak-manifest.in b/solenv/flatpak-manifest.in index 6536b0c5d552..b4bf47bc3971 100644 --- a/solenv/flatpak-manifest.in +++ b/solenv/flatpak-manifest.in @@ -572,6 +572,12 @@ "type": "file", "dest-filename": "external/tarballs/libatomic_ops-7.6.8.tar.gz" }, +{ +"url": "https://dev-www.libreoffice.org/src/skia-m80-0af13b3caf0384981f50e073ebc7bd0f3f751711.tar.xz;, +"sha256": "f1b3be9d9468c20a84fa21aea44b19daa48bca8fd2c7f9ea6fe76d6e31f54530", +"type": "file", +"dest-filename": "external/tarballs/skia-m80-0af13b3caf0384981f50e073ebc7bd0f3f751711.tar.xz" +}, { "url": "https://dev-www.libreoffice.org/extern/884ed41809687c3e168fc7c19b16585149ff058eca79acbf3ee784f6630704cc-opens___.ttf;, "sha256": "884ed41809687c3e168fc7c19b16585149ff058eca79acbf3ee784f6630704cc", ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3c9288edd5bbdbac239a236f96f6c5f83c28de10 Author: Christian Lohmaier AuthorDate: Wed Jan 8 15:42:21 2020 +0100 Commit: Gerrit Code Review CommitDate: Wed Jan 8 15:42:21 2020 +0100 Update git submodules * Update helpcontent2 from branch 'master' to 9fc4da0db94a4d06ab31ada262551a0a28f2859e - avoid unnecessary change in po files due to use of spaces to indent po file extraction would strip tabs, but keeps spaces when extracting strings. Change-Id: I2947b12787f52f65ef9981ba6a9c9ffdee503a6b diff --git a/helpcontent2 b/helpcontent2 index 84e12edbc498..9fc4da0db94a 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 84e12edbc498a2fca5a7e39eb8754196b5df +Subproject commit 9fc4da0db94a4d06ab31ada262551a0a28f2859e ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Branch 'libreoffice-6-4' - source/text
source/text/simpress/01/0605.xhp | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) New commits: commit daea7016dd2410de8a610cc63a6ab3d84b256c52 Author: Christian Lohmaier AuthorDate: Wed Jan 8 15:24:26 2020 +0100 Commit: Christian Lohmaier CommitDate: Wed Jan 8 15:25:53 2020 +0100 avoid unnecessary change in po files due to use of spaces to indent po file extraction would strip tabs, but keeps spaces when extracting strings. Change-Id: I2947b12787f52f65ef9981ba6a9c9ffdee503a6b (cherry picked from commit 9fc4da0db94a4d06ab31ada262551a0a28f2859e) diff --git a/source/text/simpress/01/0605.xhp b/source/text/simpress/01/0605.xhp index 6d58c3d4b..daa401adc 100644 --- a/source/text/simpress/01/0605.xhp +++ b/source/text/simpress/01/0605.xhp @@ -46,8 +46,7 @@ -Icon - +Icon First image @@ -61,8 +60,7 @@ -Icon - +Icon Backwards @@ -76,8 +74,7 @@ -Icon - +Icon Stop @@ -91,8 +88,7 @@ -Icon - +Icon Play @@ -106,8 +102,7 @@ -Icon - +Icon Last image @@ -133,8 +128,7 @@ -Icon - +Icon Apply Object @@ -150,8 +144,7 @@ -Icon - +Icon Apply Objects Individually @@ -166,8 +159,7 @@ -Icon - +Icon Delete Current Image @@ -182,8 +174,7 @@ -Icon - +Icon Delete All Images ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/simpress/01/0605.xhp | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) New commits: commit 9fc4da0db94a4d06ab31ada262551a0a28f2859e Author: Christian Lohmaier AuthorDate: Wed Jan 8 15:24:26 2020 +0100 Commit: Christian Lohmaier CommitDate: Wed Jan 8 15:24:26 2020 +0100 avoid unnecessary change in po files due to use of spaces to indent po file extraction would strip tabs, but keeps spaces when extracting strings. Change-Id: I2947b12787f52f65ef9981ba6a9c9ffdee503a6b diff --git a/source/text/simpress/01/0605.xhp b/source/text/simpress/01/0605.xhp index 6d58c3d4b..daa401adc 100644 --- a/source/text/simpress/01/0605.xhp +++ b/source/text/simpress/01/0605.xhp @@ -46,8 +46,7 @@ -Icon - +Icon First image @@ -61,8 +60,7 @@ -Icon - +Icon Backwards @@ -76,8 +74,7 @@ -Icon - +Icon Stop @@ -91,8 +88,7 @@ -Icon - +Icon Play @@ -106,8 +102,7 @@ -Icon - +Icon Last image @@ -133,8 +128,7 @@ -Icon - +Icon Apply Object @@ -150,8 +144,7 @@ -Icon - +Icon Apply Objects Individually @@ -166,8 +159,7 @@ -Icon - +Icon Delete Current Image @@ -182,8 +174,7 @@ -Icon - +Icon Delete All Images ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - vcl/source
vcl/source/window/layout.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 95d7d13205c05c2114a6d3bc2c4538246b22f3e0 Author: Tomáš Chvátal AuthorDate: Wed Jan 8 13:25:05 2020 +0100 Commit: Adolfo Jayme Barrientos CommitDate: Wed Jan 8 15:40:41 2020 +0100 tdf#129879 Fix wrong order of buttons Change-Id: I0cb135c5b8298fd7c5579673d0eaff7068a03842 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86426 Tested-by: Jenkins Reviewed-by: Tomáš Chvátal Reviewed-by: Adolfo Jayme Barrientos diff --git a/vcl/source/window/layout.cxx b/vcl/source/window/layout.cxx index 981ac621aa60..9c5a36304a21 100644 --- a/vcl/source/window/layout.cxx +++ b/vcl/source/window/layout.cxx @@ -718,8 +718,8 @@ static int getButtonPriority(const OString ) const OUString = Application::GetDesktopEnvironment(); if (rEnv.equalsIgnoreAsciiCase("windows") || -rEnv.equalsIgnoreAsciiCase("tde") || -rEnv.startsWithIgnoreAsciiCase("kde")) +rEnv.equalsIgnoreAsciiCase("lxqt") || +rEnv.startsWithIgnoreAsciiCase("plasma")) { pOrder = [0]; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: comphelper/source
comphelper/source/misc/meminfo.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4ddc57c4af77ae5990b1cab2201ec844d945069a Author: Stephan Bergmann AuthorDate: Wed Jan 8 11:36:50 2020 +0100 Commit: Stephan Bergmann CommitDate: Wed Jan 8 15:40:02 2020 +0100 loplugin:includeform (clang-cl) Change-Id: I30d1f3e67eafddb6334d0cb6cdc9bbe132057ea7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86415 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/comphelper/source/misc/meminfo.cxx b/comphelper/source/misc/meminfo.cxx index 762d4ef1a9b2..72a55addd4d5 100644 --- a/comphelper/source/misc/meminfo.cxx +++ b/comphelper/source/misc/meminfo.cxx @@ -24,7 +24,7 @@ #define WIN32_LEAN_AND_MEAN #include -#include "psapi.h" +#include #elif defined(UNX) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/window/layout.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 4f0d4c9387eb1d73f96b9072128cff2038f6c61a Author: Tomáš Chvátal AuthorDate: Wed Jan 8 13:25:05 2020 +0100 Commit: Tomáš Chvátal CommitDate: Wed Jan 8 15:35:20 2020 +0100 tdf#129879 Fix wrong order of buttons Change-Id: I0cb135c5b8298fd7c5579673d0eaff7068a03842 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86425 Reviewed-by: Adolfo Jayme Barrientos Tested-by: Jenkins diff --git a/vcl/source/window/layout.cxx b/vcl/source/window/layout.cxx index fbada38f6e48..be8313c12f00 100644 --- a/vcl/source/window/layout.cxx +++ b/vcl/source/window/layout.cxx @@ -722,8 +722,8 @@ static int getButtonPriority(const OString ) const OUString = Application::GetDesktopEnvironment(); if (rEnv.equalsIgnoreAsciiCase("windows") || -rEnv.equalsIgnoreAsciiCase("tde") || -rEnv.startsWithIgnoreAsciiCase("kde")) +rEnv.equalsIgnoreAsciiCase("lxqt") || +rEnv.startsWithIgnoreAsciiCase("plasma")) { pOrder = [0]; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129879] Qt UI swapped button order in save dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=129879 Commit Notification changed: What|Removed |Added Whiteboard||target:6.5.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129879] Qt UI swapped button order in save dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=129879 --- Comment #5 from Commit Notification --- Tomáš Chvátal committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4f0d4c9387eb1d73f96b9072128cff2038f6c61a tdf#129879 Fix wrong order of buttons It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129374] Dialog containing shapes is too big and doesn't scroll on iOS 4.2
https://bugs.documentfoundation.org/show_bug.cgi?id=129374 --- Comment #7 from Commit Notification --- Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/online/commit/152a20df3a58fc79e79d6baa6a50e755ad3faae2 Revert "tdf#129374: Make the overlay wider on iOS if it seems necessary" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/js
loleaflet/js/w2ui-1.5.rc1.js |7 --- 1 file changed, 7 deletions(-) New commits: commit 152a20df3a58fc79e79d6baa6a50e755ad3faae2 Author: Tor Lillqvist AuthorDate: Wed Jan 8 16:26:32 2020 +0200 Commit: Tor Lillqvist CommitDate: Wed Jan 8 16:29:45 2020 +0200 Revert "tdf#129374: Make the overlay wider on iOS if it seems necessary" There is a better fix coming. This reverts commit ce7ad16087701adf9803f2dfd3b2da0eb2718668. diff --git a/loleaflet/js/w2ui-1.5.rc1.js b/loleaflet/js/w2ui-1.5.rc1.js index a9e48c1b2..687a00202 100644 --- a/loleaflet/js/w2ui-1.5.rc1.js +++ b/loleaflet/js/w2ui-1.5.rc1.js @@ -2388,13 +2388,6 @@ w2utils.event = { Y = (offset.top + w2utils.getSize(obj, 'height') + options.top + 7); offsetTop = offset.top; } - -// tdf#129374 make the overlay wider so that it is more likely all we want to put in it will fit. Yes, this -// is just horrible heuristics. The sane thing would be if this w2ui code could itself make sure that the -// overlay thing grows in width if necessary as stuff is added to it so that they all show up. -if (window.ThisIsTheiOSApp && X > window.innerWidth - 300) - X = window.innerWidth - 300; - div1.css({ left: X + 'px', top : Y + 'px', ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129722] Writer - Hide white-space mode is buggy with impact on document content
https://bugs.documentfoundation.org/show_bug.cgi?id=129722 Dieter Praas changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #4 from Dieter Praas --- Jul, I (In reply to jul from comment #3) > So I guess this bug can be cancelled. Julien, thanks for testing. I close it as RESOLVED WORKSFORME. Feel free to reopen it, if it happens again and you're able to reproduce it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123224] Do not extend ReferenceMarks when editing on its border (start or end)
https://bugs.documentfoundation.org/show_bug.cgi?id=123224 V Stuart Foote changed: What|Removed |Added Blocks||107905 CC||vstuart.fo...@utsa.edu Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107905 [Bug 107905] [META] Cross-references bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107905] [META] Cross-references bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107905 V Stuart Foote changed: What|Removed |Added Depends on||123224 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=123224 [Bug 123224] Do not extend ReferenceMarks when editing on its border (start or end) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62179] SLIDESHOW: enhancement: Presenter Console also with only one monitor (as Rehearse Timings)
https://bugs.documentfoundation.org/show_bug.cgi?id=62179 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #9 from Regina Henschel --- You can use the macro in https://bz.apache.org/ooo/show_bug.cgi?id=121873 to use the presenter console with a single monitor. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128658] image compress and impress optimization Defaults
https://bugs.documentfoundation.org/show_bug.cgi?id=128658 --- Comment #3 from andreas_k --- Created attachment 157006 --> https://bugs.documentfoundation.org/attachment.cgi?id=157006=edit Powerpoint Image optimization Dialog Powerpoint has the following Resolution settings: - High Fidelity = Default (Reduce image resolution not set) - HD 330 ppi - Print 220 ppi - Web 150 ppi - E-Mail 96 ppi -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129872] Crash with table inserting in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=129872 Julien Nabet changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #4 from Julien Nabet --- *** This bug has been marked as a duplicate of bug 129850 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129872] Crash with table inserting in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=129872 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #3 from Julien Nabet --- On Win10 with master sources updated today, I don't reproduce this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129886] New: Save Untitled document uses Path set in Options rather than "last-used" directory
https://bugs.documentfoundation.org/show_bug.cgi?id=129886 Bug ID: 129886 Summary: Save Untitled document uses Path set in Options rather than "last-used" directory Product: LibreOffice Version: 6.5.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sdc.bla...@youmail.dk 1. New Document. 2. Save (but not in the Directory named in Options>LibreOffice>Paths>MyDocuments) 3. Second New Document. 4. Save. Actual Result: opens directory specified in Paths-My Documents Expected Result: opens directory where first document was saved. Actual result obtained in: Version: 6.5.0.0.alpha0+ (x64) Build ID: 035c7717c135c66c0ec025500b73ae9c13b7c586 CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: GL; VCL: win; Locale: da-DK (en_DK); UI-Language: en-US Calc: threaded (7 jan 2020 build) Expected result obtained in: Version: 6.3.4.2 (x64) Build ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win; Locale: de-DE (en_DK); UI-Language: en-US Calc: threaded Uncertain if this change was intentional. Cf bug #96503 and bug #129292 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128658] image compress and impress optimization Defaults
https://bugs.documentfoundation.org/show_bug.cgi?id=128658 --- Comment #2 from andreas_k --- Created attachment 157005 --> https://bugs.documentfoundation.org/attachment.cgi?id=157005=edit Image Compression default's Study how different settings will look like. Solution for Compress Image will be: - jpeg quality default = 80 - png compression default = 6 - resolution default = 300 DPI the patch for the default change. https://gerrit.libreoffice.org/c/core/+/86431 an additional patch could be to deactivate Reduce image resolution by default. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 128658] image compress and impress optimization Defaults
https://bugs.documentfoundation.org/show_bug.cgi?id=128658 --- Comment #2 from andreas_k --- Created attachment 157005 --> https://bugs.documentfoundation.org/attachment.cgi?id=157005=edit Image Compression default's Study how different settings will look like. Solution for Compress Image will be: - jpeg quality default = 80 - png compression default = 6 - resolution default = 300 DPI the patch for the default change. https://gerrit.libreoffice.org/c/core/+/86431 an additional patch could be to deactivate Reduce image resolution by default. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
LO 6.4 : missing file in python 3.7.6 tarball
Hi Michael, all, My current build of LibreOffice 6.4 under Ubuntu 18.04 x86-64 fails with the following error message: [...]/60/external/python3/ExternalPackage_python3.mk:43: *** file [...]/60/workdir/UnpackedTarball/python3/LO_lib/_uuid.cpython-3.7m.so does not exist in the tarball. Arrêt. Makefile:167: recipe for target 'ExternalPackage_python3' failed I guess there is a problem in the commit " python3: upgrade to release 3.7.6" https://gerrit.libreoffice.org/plugins/gitiles/core/+/853cc90f49d59a94242494c4aee2479de0865486 Best regards JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - pyuno/source
pyuno/source/module/pyuno_runtime.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 46b469d58a0e6b8fbe5888045c272159154a0705 Author: Miklos Vajna AuthorDate: Wed Jan 8 11:12:08 2020 +0100 Commit: Michael Stahl CommitDate: Wed Jan 8 14:48:57 2020 +0100 pyuno: fix build against system-python-3.6 pyuno/source/module/pyuno_runtime.cxx:984:57: error: use of undeclared identifier 'PyThread_get_thread_ident' It's only an assert, so simply do it only for >=3.7. Change-Id: Ia3fffc7a9af30780adff9bc7dbabe1727c1f8f54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86410 Reviewed-by: Michael Stahl Tested-by: Jenkins (cherry picked from commit fb4e15a89d8d8f081c0c152e5047bc0e76870b39) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86421 Tested-by: Michael Stahl diff --git a/pyuno/source/module/pyuno_runtime.cxx b/pyuno/source/module/pyuno_runtime.cxx index 5fa923c236dc..e0987cd63cd7 100644 --- a/pyuno/source/module/pyuno_runtime.cxx +++ b/pyuno/source/module/pyuno_runtime.cxx @@ -979,9 +979,11 @@ PyThreadAttach::PyThreadAttach( PyInterpreterState *interp) // note: *may* be called recursively, with PyThreadDetach between - in // that case, don't create *new* PyThreadState but reuse! #ifndef NDEBUG +#if PY_MAJOR_VERSION == 3 && PY_MINOR_VERSION >= 7 PyThreadState const*const current = _PyThreadState_UncheckedGet(); // dereference isn't safe but let's hope it's tolerable for debugging purpose assert((current == nullptr || current->thread_id != PyThread_get_thread_ident()) && "recursive PyThreadAttach"); +#endif #endif tstate = PyGILState_GetThisThreadState(); // from TLS, possibly detached if (!tstate) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf129450_BottomBorder.docx |binary sw/qa/extras/ooxmlexport/ooxmlexport3.cxx | 12 writerfilter/source/dmapper/DomainMapperTableHandler.cxx |5 + 3 files changed, 17 insertions(+) New commits: commit e4b8fc7563087e82a659f6b697a986b53e51876c Author: Szabolcs Toth AuthorDate: Tue Dec 17 16:06:30 2019 +0100 Commit: Xisco Faulí CommitDate: Wed Jan 8 14:43:54 2020 +0100 tdf#129450 DOCX import: fix bottom border of 1-row tables Bottom border was missing in a 1-row table with disabled inside borders. This happened because LO applied the empty horizontal borders to the bottom border of the table. Change-Id: I40140bf63297189edad13088f98fc5f869969c2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85303 Reviewed-by: László Németh Tested-by: László Németh (cherry picked from commit 6b1bd2699b0bdad6dc42db741dea0717cf7c1d36) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86397 Tested-by: Jenkins Reviewed-by: Xisco Faulí diff --git a/sw/qa/extras/ooxmlexport/data/tdf129450_BottomBorder.docx b/sw/qa/extras/ooxmlexport/data/tdf129450_BottomBorder.docx new file mode 100644 index ..df00bfe04421 Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf129450_BottomBorder.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx index 8e7a7149292e..4511509e69cd 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx @@ -1036,6 +1036,18 @@ DECLARE_OOXMLEXPORT_TEST(testRightBorder, "tdf129442_RightBorder.docx") assertXPath(pXmlDocument, "/w:document/w:body/w:tbl/w:tr[1]/w:tc/w:tcPr/w:tcBorders/w:end [@w:val = 'nil']", 0); } +DECLARE_OOXMLEXPORT_TEST(testBottomBorder, "tdf129450_BottomBorder.docx") +{ +// tdf#129450: Missing bottom border in one row table. + +xmlDocPtr pXmlDocument = parseExport("word/document.xml"); +if (!pXmlDocument) +return; + +// If there is no bottom border, it is shown in tcBorders. +assertXPath(pXmlDocument, "/w:document/w:body/w:tbl/w:tr/w:tc[1]/w:tcPr/w:tcBorders/w:bottom [@w:val = 'nil']", 0); +} + CPPUNIT_PLUGIN_IMPLEMENT(); /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/writerfilter/source/dmapper/DomainMapperTableHandler.cxx b/writerfilter/source/dmapper/DomainMapperTableHandler.cxx index 21472dc0eddf..b3bd18de4931 100644 --- a/writerfilter/source/dmapper/DomainMapperTableHandler.cxx +++ b/writerfilter/source/dmapper/DomainMapperTableHandler.cxx @@ -835,6 +835,11 @@ CellPropertyValuesSeq_t DomainMapperTableHandler::endTableGetCellProperties(Tabl { rInfo.pTableBorders->Erase(META_PROP_VERTICAL_BORDER); } +// Do not apply horizontal borders to a one row table. +else if (m_aCellProperties.size() == 1 && aRowOfCellsIterator->size() > 1) +{ +rInfo.pTableBorders->Erase(META_PROP_HORIZONTAL_BORDER); +} lcl_computeCellBorders( rInfo.pTableBorders, *aCellIterator, nCell, nRow, bIsEndCol, bIsEndRow ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129883] Remove write protect to section link, save and reload, loses link to file
https://bugs.documentfoundation.org/show_bug.cgi?id=129883 --- Comment #1 from sdc.bla...@youmail.dk --- Not sure if this is a separate issue but: 1. Insert>Section, Link, filename 2. Write Protection, uncheck "Protect" 3. Modify text in the section. 4. Right-click, "Edit Section" Check "protect" 5. Save and reload. Actual Result:Link to file is lost, but modified text is preserved. Expected Result: Link to file preserved. As before, works in 6.3.4.2 (and keeps modified text, if you do not update the external links!), but not in 6.5.0.0.alpha (which does not ask about updating links). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60976] RFE: Ability to add audio/video review comments, or insert audio/video/image in comments.
https://bugs.documentfoundation.org/show_bug.cgi?id=60976 --- Comment #4 from Regina Henschel --- (In reply to Dieter Praas from comment #3) > Regina, while working on bug 129855, I just detected this enhancement > request. So I would like to ask you, if it is possible to add images or > videos to a comment in odf-format. A comment is an element. That has and child elements. Video, audio or image would require a element. That is allowed inside a element. So from ODF point of view, there is no problem for video, audio or image in an comment. But the edit engine of LibreOffice is not able to handle that. Besides that I cannot imagine to have video directly inside a comment. You can already include links into comments. While you are editing the comment text, press Ctrl+K to open the hyperlink dialog. Do not forget to set a short text in the "Text" field, otherwise the URL is used and that would be far to long for the width of comments. Such link need not be a web link, you can link to a document or other file too. It will be opened in the default application. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129885] Interference between comment and track change in writer leads to disappearing text
https://bugs.documentfoundation.org/show_bug.cgi?id=129885 --- Comment #1 from mace --- Created attachment 157004 --> https://bugs.documentfoundation.org/attachment.cgi?id=157004=edit odt document demonstrating the bug Try to write in the middle of the marked text. The text should disappear immediately. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129849] On LibreOffice, Mathemathic expression are smaller than on Word and color in formula is loss
https://bugs.documentfoundation.org/show_bug.cgi?id=129849 --- Comment #3 from Robert Cabane --- LO saves each formula as MathML, while Word saves them as OMML (Open Math Metalanguage), similar but quite different XML schemes. Upon loading a docx document in LO, the conversion to MathML only arises when the user opens a particular mathematical formula. The rendering of each formula is made according to the defaults as defined in the default model for LO. You can edit this model (for your profile), create a formula and change the default font size there, and save the default model (.ott) (and activate it). Once the default math font size is changed, the ulterior Word documents will user this new size. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124741] Empty row height changes when exported to XLSX (width fixed)
https://bugs.documentfoundation.org/show_bug.cgi?id=124741 --- Comment #17 from Xisco Faulí --- (In reply to Timur from comment #16) > Empty row height still changes when exported to XLSX (width fixed). LO 6.5+. Hi Timur, Could you please explain the steps to reproduce it ? Which file are you using ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129885] New: Interference between comment and track change in writer leads to disappearing text
https://bugs.documentfoundation.org/show_bug.cgi?id=129885 Bug ID: 129885 Summary: Interference between comment and track change in writer leads to disappearing text Product: LibreOffice Version: 6.3.4.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: msiew...@gmx.de Description: I noticed interference between comments and track changes in files. Once text is marked with a comment, adding text during track change will lead to the text disappearing. Steps to Reproduce: 1. Open new writer document 2. Write some text 3. Mark the text aand press 'Insert comment' 4. activate track changes (show changes) 5. Try to write in marked text (or outside) 6. Any written text will disappear immediately Actual Results: new text disappears Expected Results: new text should be shown. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Sometimes it works as expected, but mostly it doesn't. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124505] Add predefined double screen sizes for slide show using "All displays" (workaround: manually double slide width)
https://bugs.documentfoundation.org/show_bug.cgi?id=124505 --- Comment #9 from Timur --- "manually double slide width" is what I explained in Comment 7: change predefined slide size 28,00 x 15,75 cm to a custom width of 56 cm. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 124505] Add predefined double screen sizes for slide show using "All displays" (workaround: manually double slide width)
https://bugs.documentfoundation.org/show_bug.cgi?id=124505 --- Comment #9 from Timur --- "manually double slide width" is what I explained in Comment 7: change predefined slide size 28,00 x 15,75 cm to a custom width of 56 cm. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 129884] New: UI: Page breaks on column resize
https://bugs.documentfoundation.org/show_bug.cgi?id=129884 Bug ID: 129884 Summary: UI: Page breaks on column resize Product: LibreOffice Version: 6.2.7.1 release Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: johnsmithbeat...@gmail.com Description: 1. Open calc 2. Resize any column 3. Calc will show you page breaks. Yes, you can disable them by Tools > Options > LibreOffice Calc > View > Page breaks = False, but as I understand, page breaks are still useful under some circumstances (print? print preview?). Showing them when I simple resize a column looks like a bug. Steps to Reproduce: - Actual Results: - Expected Results: - Reproducible: Always User Profile Reset: Yes Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123206] FILEOPEN DOCX Custom chart labels disappear
https://bugs.documentfoundation.org/show_bug.cgi?id=123206 --- Comment #17 from Commit Notification --- Tamas Bunth committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/a57f273da44ec4f3a1364e77679146bf535941ff tdf#123206 Add test: import custom-label-field It will be available in 6.4.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129595] Insert current date only inserts month and day
https://bugs.documentfoundation.org/show_bug.cgi?id=129595 --- Comment #9 from Julien Nabet --- (In reply to gyrlgith from comment #8) > japanese locale is only "1月7日" > dosen't change view. why? Isn't just width of the column? I mean if you increase width of the column it should be ok. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - chart2/qa xmloff/source
chart2/qa/extras/chart2import.cxx | 21 - chart2/qa/extras/data/odp/tdf123206.odp |binary xmloff/source/chart/SchXMLPlotAreaContext.cxx |2 ++ 3 files changed, 22 insertions(+), 1 deletion(-) New commits: commit a57f273da44ec4f3a1364e77679146bf535941ff Author: Tamas Bunth AuthorDate: Thu Jan 2 12:55:16 2020 +0100 Commit: Andras Timar CommitDate: Wed Jan 8 14:31:30 2020 +0100 tdf#123206 Add test: import custom-label-field Add test for deprecated custom-label-field attribute of the data-point element. Change-Id: I9a7619898fa72900323e5b41728d2146c14203e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86103 Tested-by: Jenkins Reviewed-by: Tamás Bunth Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86123 Reviewed-by: Andras Timar diff --git a/chart2/qa/extras/chart2import.cxx b/chart2/qa/extras/chart2import.cxx index 6ff60e1e6c00..9fa051df2bc1 100644 --- a/chart2/qa/extras/chart2import.cxx +++ b/chart2/qa/extras/chart2import.cxx @@ -150,6 +150,7 @@ public: void testTdf122765(); void testTdf121991(); void testTdf125444PercentageCustomLabel(); +void testTdf123206CustomLabelField(); CPPUNIT_TEST_SUITE(Chart2ImportTest); CPPUNIT_TEST(Fdo60083); @@ -249,7 +250,7 @@ public: CPPUNIT_TEST(testTdf122765); CPPUNIT_TEST(testTdf121991); CPPUNIT_TEST(testTdf125444PercentageCustomLabel); - +CPPUNIT_TEST(testTdf123206CustomLabelField); CPPUNIT_TEST_SUITE_END(); private: @@ -2318,6 +2319,24 @@ void Chart2ImportTest::testTdf125444PercentageCustomLabel() } +void Chart2ImportTest::testTdf123206CustomLabelField() +{ +// File contains the deprecated "custom-label-field" attribute of the +// "data-point" element. It should be interpreted and stored as a data point +// property. +uno::Reference< chart2::XChartDocument > xChartDoc(getChartDocFromImpress("/chart2/qa/extras/data/odp/", "tdf123206.odp"), uno::UNO_QUERY_THROW); +CPPUNIT_ASSERT_MESSAGE("failed to load chart", xChartDoc.is()); +CPPUNIT_ASSERT(xChartDoc.is()); +Reference xDataSeries = getDataSeriesFromDoc(xChartDoc, 0); +CPPUNIT_ASSERT(xDataSeries.is()); +Reference xDp = xDataSeries->getDataPointByIndex(1); +Sequence> aLabelFields; +CPPUNIT_ASSERT(xDp->getPropertyValue("CustomLabelFields") >>= aLabelFields); +CPPUNIT_ASSERT_EQUAL(static_cast(1), aLabelFields.getLength()); +CPPUNIT_ASSERT_EQUAL(OUString("Kiskacsa"), aLabelFields[0]->getString()); + +} + CPPUNIT_TEST_SUITE_REGISTRATION(Chart2ImportTest); CPPUNIT_PLUGIN_IMPLEMENT(); diff --git a/chart2/qa/extras/data/odp/tdf123206.odp b/chart2/qa/extras/data/odp/tdf123206.odp new file mode 100644 index ..1975756bce18 Binary files /dev/null and b/chart2/qa/extras/data/odp/tdf123206.odp differ diff --git a/xmloff/source/chart/SchXMLPlotAreaContext.cxx b/xmloff/source/chart/SchXMLPlotAreaContext.cxx index 9767efd933dc..f488244e142f 100644 --- a/xmloff/source/chart/SchXMLPlotAreaContext.cxx +++ b/xmloff/source/chart/SchXMLPlotAreaContext.cxx @@ -702,6 +702,8 @@ void SchXMLDataPointContext::StartElement( const uno::Reference< xml::sax::XAttr } else if( nPrefix == XML_NAMESPACE_LO_EXT) { +// Deprecated. New documents use the chart:data-label element +// instead in order to store custom label text. if( IsXMLToken( aLocalName, XML_CUSTOM_LABEL_FIELD) && !mbHasLabelParagraph) { sCustomLabelField = xAttrList->getValueByIndex( i ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129391] The active/selected cell misses the handles to grow/shrink the cell selection in calc on iOS (app version 4.2)
https://bugs.documentfoundation.org/show_bug.cgi?id=129391 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu --- Comment #3 from Aron Budea --- Is this still reproducible for you, Nicolas? I can see the handles in version 4.2 (28). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129883] Remove write protect to section link, save and reload, loses link to file
https://bugs.documentfoundation.org/show_bug.cgi?id=129883 sdc.bla...@youmail.dk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||9881 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129881] section dropdown box in Link section of "Edit Sections" dialog does not show sections in an external document that has sections
https://bugs.documentfoundation.org/show_bug.cgi?id=129881 sdc.bla...@youmail.dk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||9883 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129883] New: Remove write protect to section link, save and reload, loses link to file
https://bugs.documentfoundation.org/show_bug.cgi?id=129883 Bug ID: 129883 Summary: Remove write protect to section link, save and reload, loses link to file Product: LibreOffice Version: 6.5.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sdc.bla...@youmail.dk 1. Insert>Section, Link, filename 2. Write Protection, uncheck "Protect" 3. Save and reload. Actual Result: Link to file is lost. Expected Result: Link is preserved. Tested in: Version: 6.5.0.0.alpha0+ (x64) Build ID: 035c7717c135c66c0ec025500b73ae9c13b7c586 CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: GL; VCL: win; Locale: da-DK (en_DK); UI-Language: en-US Calc: threaded Works as expected in: Version: 6.3.4.2 (x64) Build ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win; Locale: de-DE (en_DK); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/WW8Sttbf.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 16f8807a9255359da53e980185591e356166e414 Author: Stephan Bergmann AuthorDate: Wed Jan 8 11:42:59 2020 +0100 Commit: Stephan Bergmann CommitDate: Wed Jan 8 14:24:16 2020 +0100 Missing include (Windows --disable-pch; for std::min) Change-Id: Ie6951257a94ae004e1a51f46e908917a07d137f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86417 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/sw/source/filter/ww8/WW8Sttbf.cxx b/sw/source/filter/ww8/WW8Sttbf.cxx index cd253087d68a..54e05c42ac02 100644 --- a/sw/source/filter/ww8/WW8Sttbf.cxx +++ b/sw/source/filter/ww8/WW8Sttbf.cxx @@ -17,6 +17,9 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ +#include + +#include #include #include "WW8Sttbf.hxx" #include ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129620] Crash when I press down arrow in edit header dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=129620 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Summary|Crash when I press down |Crash when I press down |arrow in edit header dialog |arrow in edit header dialog |(macOS only?) | --- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> --- don't repro in Версия: 6.3.3.2 ID сборки: a64200df03143b798afd1ec74a12ab50359878ed Потоков ЦП: 4; ОС:Mac OS X 10.15.2; Отрисовка ИП: по умолчанию; VCL: osx; Локаль: ru-RU (ru_RU.UTF-8); Язык интерфейса: ru-RU Calc: threaded nor in Версия: 6.4.0.0.beta1 ID сборки: 4d7e5b0c40ed843384704eca3ce21981d4e98920 Потоков ЦП: 4; ОС:Mac OS X 10.15.2; Отрисовка ИП: GL; VCL: osx; Локаль: ru-RU (ru_RU.UTF-8); Язык интерфейса: ru-RU Calc: threaded nor in Version: 6.5.0.0.alpha0+ Build ID: e22a3f596ce50b5166063e217d96ef674a54d380 CPU threads: 4; OS: Mac OS X 10.15.2; UI render: GL; VCL: osx; Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120502] Assigns style to columns it cannot handle in .xlsx files
https://bugs.documentfoundation.org/show_bug.cgi?id=120502 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #9 from Xisco Faulí --- (In reply to Kevin Suo from comment #8) > Mike Kaganski: Thanks for the fix. Any plan to backport this to > libreoffice-6-3 and libreoffice-6-4 branch? Backported to 6-4: https://gerrit.libreoffice.org/c/core/+/86428 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129722] Writer - Hide white-space mode is buggy with impact on document content
https://bugs.documentfoundation.org/show_bug.cgi?id=129722 jul changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #3 from jul --- Hi Dieter Thanks for your answer. I tried to reproduce the bugs I faced. - as you suggested, the part regarding the deletion at beginning of document is quite the same as bug 118456. - for other issues, I'm not able to reproduce them (I'm a bit frustrated, but that's the way it is...). The document I was working on as evolved and I think I also updated LO since then... So I guess this bug can be cancelled. Thanks again for your time & answer. Julien -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129882] New: Add "save and reload" option in the cancel Confirmation box that appears when attempting to reload a modified document
https://bugs.documentfoundation.org/show_bug.cgi?id=129882 Bug ID: 129882 Summary: Add "save and reload" option in the cancel Confirmation box that appears when attempting to reload a modified document Product: LibreOffice Version: 6.3.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sdc.bla...@youmail.dk The summary says it all. Gives better workflow. To see issue: 1. Open saved document. 2. Modify 3. File>Reload Actual: Confirmation: Cancel all changes? "Yes""No" Proposed: Confirmation: "Save and Reload" "Drop (all) Changes and Reload" "Cancel" (labels are for illustration. salt and pepper to taste.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 129639] Could Not Set Column Width in One Column Table
https://bugs.documentfoundation.org/show_bug.cgi?id=129639 --- Comment #3 from Timur --- There are multiple possible solutions to this bug report: 1. shrink table if single column (as bug report that I support) 2. give a warning (alternative to 1.) 3. explain in Documentation (in any case), where this is not explained at https://help.libreoffice.org/6.5/en-US/text/swriter/01/05120100.html -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 129639] Could Not Set Column Width in One Column Table
https://bugs.documentfoundation.org/show_bug.cgi?id=129639 --- Comment #3 from Timur --- There are multiple possible solutions to this bug report: 1. shrink table if single column (as bug report that I support) 2. give a warning (alternative to 1.) 3. explain in Documentation (in any case), where this is not explained at https://help.libreoffice.org/6.5/en-US/text/swriter/01/05120100.html -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/objectpositioning/anchoredobjectposition.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d486d675ead6a4b4c08ac0e6b9977d280f1606e0 Author: Andrea Gelmini AuthorDate: Tue Jan 7 19:24:41 2020 +0100 Commit: Julien Nabet CommitDate: Wed Jan 8 14:09:28 2020 +0100 Fix typo Change-Id: I76be5d73d9acfe0c3f5525b251bb3feffb1e4c1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86380 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/sw/source/core/objectpositioning/anchoredobjectposition.cxx b/sw/source/core/objectpositioning/anchoredobjectposition.cxx index 42ec72d3221a..6a9e02a499bf 100644 --- a/sw/source/core/objectpositioning/anchoredobjectposition.cxx +++ b/sw/source/core/objectpositioning/anchoredobjectposition.cxx @@ -53,7 +53,7 @@ SwAnchoredObjectPosition::SwAnchoredObjectPosition( SdrObject& _rDrawObj ) mbDoNotCaptureAnchoredObj( false ) { #if OSL_DEBUG_LEVEL > 0 -// assert, if object isn't of excepted type +// assert, if object isn't of expected type const bool bObjOfExceptedType = dynamic_cast( ) != nullptr || // object representing fly frame dynamic_cast( ) != nullptr|| // 'virtual' drawing object ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svl/source
svl/source/items/stylepool.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 05173782d8fd35f302db471b509c2f8389beeab1 Author: Andrea Gelmini AuthorDate: Tue Jan 7 19:24:36 2020 +0100 Commit: Julien Nabet CommitDate: Wed Jan 8 14:08:57 2020 +0100 Fix typo Change-Id: I01c4bfadfabce128f1e28b0c871da1722b865b6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86377 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/svl/source/items/stylepool.cxx b/svl/source/items/stylepool.cxx index 6471212c7ff4..a7089165309f 100644 --- a/svl/source/items/stylepool.cxx +++ b/svl/source/items/stylepool.cxx @@ -363,7 +363,7 @@ public: DBG_ASSERT( !pIgnorableItems || !pIgnorableItems->Count(), " - misusage: item set for ignorable item should be empty. Please correct usage." ); DBG_ASSERT( !mpIgnorableItems || !mpIgnorableItems->Count(), -" - does not work as excepted - is not empty." ); +" - does not work as expected - is not empty." ); } std::shared_ptr insertItemSet( const SfxItemSet& rSet, const OUString* pParentName = nullptr ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/objectpositioning/tocntntanchoredobjectposition.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e30c8812f623f8dcfa83ed7e44b40c78ad94933b Author: Andrea Gelmini AuthorDate: Tue Jan 7 19:24:42 2020 +0100 Commit: Julien Nabet CommitDate: Wed Jan 8 14:08:25 2020 +0100 Fix typo Change-Id: I211fb36e9ad16b8ed468ce8dec5c95e7f5ab9391 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86381 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/sw/source/core/objectpositioning/tocntntanchoredobjectposition.cxx b/sw/source/core/objectpositioning/tocntntanchoredobjectposition.cxx index 402249cf8080..0a19ebc7c4ae 100644 --- a/sw/source/core/objectpositioning/tocntntanchoredobjectposition.cxx +++ b/sw/source/core/objectpositioning/tocntntanchoredobjectposition.cxx @@ -122,7 +122,7 @@ static bool lcl_DoesVertPosFits( const SwTwips _nRelPosY, else if ( _pUpperOfOrientFrame->IsInTab() && _bGrowInTable ) { // #i45085# - check, if upper frame would grow the -// excepted amount of twips. +// expected amount of twips. const SwTwips nTwipsGrown = const_cast(_pUpperOfOrientFrame)-> Grow( _nRelPosY - _nAvail, true ); bVertPosFits = ( nTwipsGrown == ( _nRelPosY - _nAvail ) ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/layout/objectformattertxtfrm.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 026b6dc1f195e6af797ba1bbb096130b1ebdebf4 Author: Andrea Gelmini AuthorDate: Tue Jan 7 19:24:39 2020 +0100 Commit: Julien Nabet CommitDate: Wed Jan 8 14:04:26 2020 +0100 Fix typo Change-Id: I4e4a1b24d6b19ab62d9f0d73bcd74492bc955beb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86379 Reviewed-by: Julien Nabet Tested-by: Julien Nabet diff --git a/sw/source/core/layout/objectformattertxtfrm.cxx b/sw/source/core/layout/objectformattertxtfrm.cxx index cc59fdd4e15c..d02cdc2edf07 100644 --- a/sw/source/core/layout/objectformattertxtfrm.cxx +++ b/sw/source/core/layout/objectformattertxtfrm.cxx @@ -324,7 +324,7 @@ bool SwObjectFormatterTextFrame::DoFormatObjs() if ( bSuccess ) { // format of as-character anchored floating screen objects - no failure -// excepted on the format of these objects. +// expected on the format of these objects. bSuccess = FormatObjsAtFrame_(); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/txtnode/ndtxt.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9a66bd88834494457574b7575656ae935103759e Author: Andrea Gelmini AuthorDate: Tue Jan 7 19:24:44 2020 +0100 Commit: Julien Nabet CommitDate: Wed Jan 8 14:03:28 2020 +0100 Fix typo Change-Id: I29fcf584404acf9302e261721bb6c255e4701918 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86382 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/sw/source/core/txtnode/ndtxt.cxx b/sw/source/core/txtnode/ndtxt.cxx index cc8c30a08a25..9f3331c1ecb4 100644 --- a/sw/source/core/txtnode/ndtxt.cxx +++ b/sw/source/core/txtnode/ndtxt.cxx @@ -4638,7 +4638,7 @@ namespace { const SfxStringItem& rListIdItem = dynamic_cast(pItem); OSL_ENSURE( rListIdItem.GetValue().getLength() > 0, -" - empty list id attribute not excepted. Serious defect." ); +" - empty list id attribute not expected. Serious defect." ); const OUString sListIdOfTextNode = rTextNode.GetListId(); if ( rListIdItem.GetValue() != sListIdOfTextNode ) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: contributing to LibreOffice
Animesh Ramasami IIT bhu kirjoitti 8.1.2020 klo 12.25: I am interested in contributing for your organization so may I know what are the prerequisites and how to get started with it... If you are interested in contributing C++ code, follow this article: https://wiki.documentfoundation.org/Development/GetInvolved If not, please specify in what way you would like to contribute. Ilmari ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/inc/conttree.hxx |1 - sw/source/uibase/utlui/content.cxx |1 + 2 files changed, 1 insertion(+), 1 deletion(-) New commits: commit 5c3b41e31e22157edab67b00efc66ec3ddafc1f7 Author: Andrea Gelmini AuthorDate: Tue Jan 7 15:11:39 2020 +0100 Commit: Julien Nabet CommitDate: Wed Jan 8 14:02:23 2020 +0100 Fix typos Change-Id: I2f498d16882e2aa6e75d6fc0a1073f094869a2b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/77765 Reviewed-by: Samuel Mehrbrodt Tested-by: Julien Nabet diff --git a/sw/source/uibase/inc/conttree.hxx b/sw/source/uibase/inc/conttree.hxx index 9ea8f9f9ffc9..0c65e0acc407 100644 --- a/sw/source/uibase/inc/conttree.hxx +++ b/sw/source/uibase/inc/conttree.hxx @@ -216,7 +216,6 @@ public: voidExecCommand(const OUString& rCmd, bool bModifier); voidShowTree(); -/** folded together will not be glidled */ voidHideTree(); boolIsConstantView() const { return State::CONSTANT == m_eState; } diff --git a/sw/source/uibase/utlui/content.cxx b/sw/source/uibase/utlui/content.cxx index eaaf40f8963a..5b69e66a50fa 100644 --- a/sw/source/uibase/utlui/content.cxx +++ b/sw/source/uibase/utlui/content.cxx @@ -2734,6 +2734,7 @@ void SwContentTree::Paint( vcl::RenderContext& rRenderContext, void SwContentTree::HideTree() { +// folded together will not be idled m_aUpdTimer.Stop(); SvTreeListBox::Hide(); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129881] New: section dropdown box in Link section of "Edit Sections" dialog does not show sections in an external document that has sections
https://bugs.documentfoundation.org/show_bug.cgi?id=129881 Bug ID: 129881 Summary: section dropdown box in Link section of "Edit Sections" dialog does not show sections in an external document that has sections Product: LibreOffice Version: 6.5.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sdc.bla...@youmail.dk 1. Insert>Section 2. Select Link 3. Choose Filename (where file has 1 or more sections already). 4. Dropdown box on Section Actual: Empty Expected: Shows the sections. Additional information: 1. Can write the sectionname (if you know it) and the link will work. 2. LO 6.3.4.2 works as expected. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96505] Get rid of cargo cult "long" integer literals
https://bugs.documentfoundation.org/show_bug.cgi?id=96505 --- Comment #64 from Commit Notification --- Yusuf Keten committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f69fa576c579a88853a563aed1b947319b6ffcf1 tdf#96505 Get rid of cargo cult long integer literals It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svx/source tools/source
svx/source/engine3d/obj3d.cxx |2 +- svx/source/svdraw/svdobj.cxx |2 +- svx/source/svdraw/svdocirc.cxx |4 ++-- svx/source/svdraw/svdograf.cxx |2 +- svx/source/svdraw/svdomeas.cxx |6 +++--- svx/source/svdraw/svdotext.cxx |2 +- svx/source/svdraw/svdotxdr.cxx |2 +- tools/source/stream/stream.cxx |2 +- 8 files changed, 11 insertions(+), 11 deletions(-) New commits: commit f69fa576c579a88853a563aed1b947319b6ffcf1 Author: Yusuf Keten AuthorDate: Tue Jan 7 00:12:30 2020 +0300 Commit: Michael Stahl CommitDate: Wed Jan 8 14:00:31 2020 +0100 tdf#96505 Get rid of cargo cult long integer literals Change-Id: Ic0cde7c087d54a80a57d2a2574fa1f3932192367 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86311 Tested-by: Jenkins Reviewed-by: Michael Stahl diff --git a/svx/source/engine3d/obj3d.cxx b/svx/source/engine3d/obj3d.cxx index f743c58fd67b..911a9b7ff70a 100644 --- a/svx/source/engine3d/obj3d.cxx +++ b/svx/source/engine3d/obj3d.cxx @@ -520,7 +520,7 @@ basegfx::B2DPolyPolygon E3dCompoundObject::TakeXorPoly() const sal_uInt32 E3dCompoundObject::GetHdlCount() const { // 8 corners + 1 E3dVolumeMarker (= Wireframe representation) -return 9L; +return 9; } void E3dCompoundObject::AddToHdlList(SdrHdlList& rHdlList) const diff --git a/svx/source/svdraw/svdobj.cxx b/svx/source/svdraw/svdobj.cxx index db6238c704ba..d1d898379fdf 100644 --- a/svx/source/svdraw/svdobj.cxx +++ b/svx/source/svdraw/svdobj.cxx @@ -1190,7 +1190,7 @@ basegfx::B2DPolyPolygon SdrObject::TakeContour() const sal_uInt32 SdrObject::GetHdlCount() const { -return 8L; +return 8; } void SdrObject::AddToHdlList(SdrHdlList& rHdlList) const diff --git a/svx/source/svdraw/svdocirc.cxx b/svx/source/svdraw/svdocirc.cxx index 7c5aa3bf9196..efbc2803cb2f 100644 --- a/svx/source/svdraw/svdocirc.cxx +++ b/svx/source/svdraw/svdocirc.cxx @@ -424,11 +424,11 @@ sal_uInt32 SdrCircObj::GetHdlCount() const { if(SdrCircKind::Full != meCircleKind) { -return 10L; +return 10; } else { -return 8L; +return 8; } } diff --git a/svx/source/svdraw/svdograf.cxx b/svx/source/svdraw/svdograf.cxx index 135b934be8b4..67b598ce14b3 100644 --- a/svx/source/svdraw/svdograf.cxx +++ b/svx/source/svdraw/svdograf.cxx @@ -767,7 +767,7 @@ SdrGrafObj& SdrGrafObj::operator=( const SdrGrafObj& rObj ) sal_uInt32 SdrGrafObj::GetHdlCount() const { -return 8L; +return 8; } void SdrGrafObj::AddToHdlList(SdrHdlList& rHdlList) const diff --git a/svx/source/svdraw/svdomeas.cxx b/svx/source/svdraw/svdomeas.cxx index e950dc8f14e3..8ac271db2904 100644 --- a/svx/source/svdraw/svdomeas.cxx +++ b/svx/source/svdraw/svdomeas.cxx @@ -749,7 +749,7 @@ basegfx::B2DPolyPolygon SdrMeasureObj::TakeXorPoly() const sal_uInt32 SdrMeasureObj::GetHdlCount() const { -return 6L; +return 6; } void SdrMeasureObj::AddToHdlList(SdrHdlList& rHdlList) const @@ -1079,7 +1079,7 @@ void SdrMeasureObj::RecalcSnapRect() sal_uInt32 SdrMeasureObj::GetSnapPointCount() const { -return 2L; +return 2; } Point SdrMeasureObj::GetSnapPoint(sal_uInt32 i) const @@ -1095,7 +1095,7 @@ bool SdrMeasureObj::IsPolyObj() const sal_uInt32 SdrMeasureObj::GetPointCount() const { -return 2L; +return 2; } Point SdrMeasureObj::GetPoint(sal_uInt32 i) const diff --git a/svx/source/svdraw/svdotext.cxx b/svx/source/svdraw/svdotext.cxx index 4ce65ca33f61..ef76a53b1dca 100644 --- a/svx/source/svdraw/svdotext.cxx +++ b/svx/source/svdraw/svdotext.cxx @@ -1120,7 +1120,7 @@ void SdrTextObj::RecalcSnapRect() sal_uInt32 SdrTextObj::GetSnapPointCount() const { -return 4L; +return 4; } Point SdrTextObj::GetSnapPoint(sal_uInt32 i) const diff --git a/svx/source/svdraw/svdotxdr.cxx b/svx/source/svdraw/svdotxdr.cxx index b340340a1a3c..182f4d99f9fc 100644 --- a/svx/source/svdraw/svdotxdr.cxx +++ b/svx/source/svdraw/svdotxdr.cxx @@ -35,7 +35,7 @@ sal_uInt32 SdrTextObj::GetHdlCount() const { -return 8L; +return 8; } void SdrTextObj::AddToHdlList(SdrHdlList& rHdlList) const diff --git a/tools/source/stream/stream.cxx b/tools/source/stream/stream.cxx index a85f4d1be5a2..c39d6787e134 100644 --- a/tools/source/stream/stream.cxx +++ b/tools/source/stream/stream.cxx @@ -1702,7 +1702,7 @@ std::size_t SvMemoryStream::GetData( void* pData, std::size_t nCount ) std::size_t SvMemoryStream::PutData( const void* pData, std::size_t nCount ) { if( GetError() ) -return 0L; +return 0; std::size_t nMaxCount = nSize-nPos; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129872] Crash with table inserting in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=129872 --- Comment #2 from Timur --- no repro Win from 08.01. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81720] EDITING: setting cross-reference still active after closing
https://bugs.documentfoundation.org/show_bug.cgi?id=81720 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #21 from Julien Nabet --- Created attachment 157003 --> https://bugs.documentfoundation.org/attachment.cgi?id=157003=edit test with Win10 + LO 6.3.4 I gave a try to initial comment on Win10 with LO 6.3.4 (last stable LO version) Is there something wrong in the attached file? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/uiconfig
sw/uiconfig/swriter/ui/optcompatpage.ui | 126 1 file changed, 63 insertions(+), 63 deletions(-) New commits: commit d68f5c3c684ef440d537372ccf3edc30d2fa3668 Author: andreas kainz AuthorDate: Wed Jan 8 11:06:54 2020 +0100 Commit: andreas_kainz CommitDate: Wed Jan 8 13:52:51 2020 +0100 Options Dialog Compatibility options update first global than file Change-Id: Ibd906476eb9a798b1ef290a35545e0b22c10b892 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86407 Tested-by: Jenkins Reviewed-by: andreas_kainz diff --git a/sw/uiconfig/swriter/ui/optcompatpage.ui b/sw/uiconfig/swriter/ui/optcompatpage.ui index 29a5c6eaee75..4f7897212b39 100644 --- a/sw/uiconfig/swriter/ui/optcompatpage.ui +++ b/sw/uiconfig/swriter/ui/optcompatpage.ui @@ -39,54 +39,54 @@ vertical 12 - + True False True -True +False 0 none - + True False True -True +False 6 12 - + True False 5 - + True True True True in - + True True True True True -liststore1 +liststore2 False 0 False - + - + True 6 0.5 - + 3 0 @@ -95,11 +95,11 @@ - + True 6 - + 1 @@ -115,26 +115,11 @@ - + False True - Use printer metrics for document formatting - Add spacing between paragraphs and tables - Add paragraph and table spacing at tops of pages - Use OpenOffice.org 1.1 tabstop formatting - Do not add leading (extra space) between lines of text - Use OpenOffice.org 1.1 line spacing - Add paragraph and table spacing at bottom of table cells - Use OpenOffice.org 1.1 object positioning - Use OpenOffice.org 1.1 text wrapping around objects - Consider wrapping style when positioning objects - Expand word space on lines with manual line breaks in justified paragraphs - Protect form (no longer protects whole document. Insert write protected section instead) - Word-compatible trailing blanks - Tolerate white lines of PDF page backgrounds for compatibility with old documents - Hide paragraphs of database fields (e.g., mail merge) with an empty value - User settings + Reorganize Form menu to have it MS compatible @@ -142,29 +127,15 @@ 1 - - -Use as _Default -True -True -True -end -True - - -0 -2 - - - + True False -Compatibility options for “%DOCNAME” +Global compatibility options @@ -178,54 +149,54 @@ - + True
[Libreoffice-bugs] [Bug 125965] [META] Sifr icons
https://bugs.documentfoundation.org/show_bug.cgi?id=125965 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||129846 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=129846 [Bug 129846] Missing Extra Large (32px*32px) Sifr Icons -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/uiconfig
sw/uiconfig/swriter/ui/optcaptionpage.ui | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) New commits: commit 741594a54f5abc3bad42754363bdf59d8f0e16aa Author: andreas kainz AuthorDate: Wed Jan 8 11:12:41 2020 +0100 Commit: andreas_kainz CommitDate: Wed Jan 8 13:52:37 2020 +0100 Options Dialog AutoCaption fix label alignment to follow HIG Change-Id: Ia1e6370ba2c15d9ef6c940b60ebe8ada846622c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86411 Tested-by: Jenkins Reviewed-by: andreas_kainz diff --git a/sw/uiconfig/swriter/ui/optcaptionpage.ui b/sw/uiconfig/swriter/ui/optcaptionpage.ui index 0787f53a96da..4eb7f90283e2 100644 --- a/sw/uiconfig/swriter/ui/optcaptionpage.ui +++ b/sw/uiconfig/swriter/ui/optcaptionpage.ui @@ -62,7 +62,7 @@ Category: True category -1 +0 0 @@ -76,7 +76,7 @@ _Numbering: True numbering -1 +0 0 @@ -90,7 +90,7 @@ Numbering separator: True numseparator -1 +0 0 @@ -104,7 +104,7 @@ Separator: True separator -1 +0 0 @@ -118,7 +118,7 @@ Position: True position -1 +0 0 @@ -243,7 +243,7 @@ Level: True level -1 +0 0 @@ -257,7 +257,7 @@ Separator: True chapseparator -1 +0 0 @@ -340,7 +340,7 @@ Character style: True charstyle -1 +0 0 @@ -501,6 +501,7 @@ when inserting: True center start +12 never never in ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129846] Missing Extra Large (32px*32px) Sifr Icons
https://bugs.documentfoundation.org/show_bug.cgi?id=129846 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||125965 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=125965 [Bug 125965] [META] Sifr icons -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129861] Drop down menu not working correctly in LibreOffice.
https://bugs.documentfoundation.org/show_bug.cgi?id=129861 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added OS|Mac OS X (All) |All CC||79045_79...@mail.ru Keywords||filter:xlsx Blocks||119060 Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> --- repro in Версия: 6.3.3.2 (x64) ID сборки: a64200df03143b798afd1ec74a12ab50359878ed Потоков ЦП: 4; ОС:Windows 10.0; Отрисовка ИП: GL; VCL: win; Локаль: ru-RU (ru_RU); Язык интерфейса: ru-RU Calc: threaded form controls just don't work but in Версия: 6.5.0.0.alpha0+ (x64) ID сборки: 035c7717c135c66c0ec025500b73ae9c13b7c586 Потоков ЦП: 4; ОС:Windows 10.0 Build 17763; Отрисовка ИП: по умолчанию; VCL: win; Локаль: ru-RU (ru_RU); Язык интерфейса: ru-RU Calc: threaded form control allows select country but linked second drop-down list shows wrong info. Possibly another problem Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=119060 [Bug 119060] [META] XLSX (OOXML) ActiveX and Legacy form control related issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119060] [META] XLSX (OOXML) ActiveX and Legacy form control related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=119060 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||129861 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=129861 [Bug 129861] Drop down menu not working correctly in LibreOffice. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129880] RFE: Render fontnames in dropdown in the corresponding font
https://bugs.documentfoundation.org/show_bug.cgi?id=129880 --- Comment #1 from Beat Rubischon --- Created attachment 157002 --> https://bugs.documentfoundation.org/attachment.cgi?id=157002=edit LibreOffice desktop font selector To compare with the desktop application where the names are rendered in the corresponding font. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129880] New: RFE: Render fontnames in dropdown in the corresponding font
https://bugs.documentfoundation.org/show_bug.cgi?id=129880 Bug ID: 129880 Summary: RFE: Render fontnames in dropdown in the corresponding font Product: LibreOffice Online Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: b...@0x1b.ch Created attachment 157001 --> https://bugs.documentfoundation.org/attachment.cgi?id=157001=edit LibreOffice online font selector The font chooser in the various Libre Office components shows the names of the fonts in a default typeset. Rendering the names in the corresponding font would simplify the selection by a user. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129879] Qt UI swapped button order in save dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=129879 Tomáš Chvátal changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #4 from Tomáš Chvátal --- Submitted to 6.4 branch and master. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90069] DOCX: Font style table inconsistencies, new cells resetting font styles
https://bugs.documentfoundation.org/show_bug.cgi?id=90069 László Németh changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |nem...@numbertext.org |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: dbaccess/source editeng/source forms/source include/svtools include/tools sal/osl sfx2/qa sfx2/source svx/source sw/qa sw/source toolkit/source
dbaccess/source/core/api/RowSetCache.cxx |2 +- editeng/source/editeng/impedit5.cxx |2 +- forms/source/component/FormattedField.cxx|6 +++--- forms/source/component/FormattedFieldWrapper.cxx |2 +- include/svtools/table/tablerenderer.hxx |2 +- include/tools/date.hxx |2 +- sal/osl/all/utility.cxx |2 +- sfx2/qa/complex/sfx2/UndoManager.java|4 ++-- sfx2/source/appl/newhelp.cxx |2 +- svx/source/fmcomp/fmgridcl.cxx |2 +- svx/source/form/fmshell.cxx |2 +- sw/qa/extras/ooxmlexport/ooxmlexport4.cxx|2 +- sw/source/core/inc/txtfly.hxx|2 +- toolkit/source/controls/grid/gridcontrol.cxx |2 +- 14 files changed, 17 insertions(+), 17 deletions(-) New commits: commit 2e5c4b4081411b77b5e0593225b805d3756f7533 Author: Andrea Gelmini AuthorDate: Wed Jan 8 06:57:25 2020 +0100 Commit: Adolfo Jayme Barrientos CommitDate: Wed Jan 8 13:25:05 2020 +0100 Grammar fixes Change-Id: I6ac6f6abb601aa254e94612e6826488393de8e3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86383 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/dbaccess/source/core/api/RowSetCache.cxx b/dbaccess/source/core/api/RowSetCache.cxx index 2f71f9e4bc5d..1ca8ba61b7da 100644 --- a/dbaccess/source/core/api/RowSetCache.cxx +++ b/dbaccess/source/core/api/RowSetCache.cxx @@ -875,7 +875,7 @@ void ORowSetCache::moveWindow() bool bCheck; bCheck = m_xCacheSet->absolute(nNewStartPos + 1); -// m_nEndPos < nNewEndPos when window not filled (e.g. there are less rows in total than window size) +// m_nEndPos < nNewEndPos when window not filled (e.g. there are fewer rows in total than window size) m_nEndPos = std::min(nNewEndPos, m_nEndPos); const sal_Int32 nOverlapSize = m_nEndPos - m_nStartPos; const sal_Int32 nStartPosOffset = m_nStartPos - nNewStartPos; // by how much m_nStartPos moves diff --git a/editeng/source/editeng/impedit5.cxx b/editeng/source/editeng/impedit5.cxx index 975eddebf6ae..0e6b6af722fa 100644 --- a/editeng/source/editeng/impedit5.cxx +++ b/editeng/source/editeng/impedit5.cxx @@ -395,7 +395,7 @@ SfxItemSet ImpEditEngine::GetAttribs( EditSelection aSel, EditEngineAttribs nOnl SfxItemSet ImpEditEngine::GetAttribs( sal_Int32 nPara, sal_Int32 nStart, sal_Int32 nEnd, GetAttribsFlags nFlags ) const { -// Optimized function with less Puts(), which cause unnecessary cloning from default items. +// Optimized function with fewer Puts(), which cause unnecessary cloning from default items. // If this works, change GetAttribs( EditSelection ) to use this for each paragraph and merge the results! diff --git a/forms/source/component/FormattedField.cxx b/forms/source/component/FormattedField.cxx index 805076b545d1..fb84dcb2e531 100644 --- a/forms/source/component/FormattedField.cxx +++ b/forms/source/component/FormattedField.cxx @@ -748,7 +748,7 @@ void OFormattedModel::read(const Reference& _rxInStream) { // since version 3 there is a "skippable" block at this position OStreamSection aDownCompat(_rxInStream); _rxInStream->readShort(); // sub-version -// version 0 and higher : the "effective value" property +// version 0 and higher: the "effective value" property Any aEffectiveValue; { OStreamSection aDownCompat2(_rxInStream); @@ -763,10 +763,10 @@ void OFormattedModel::read(const Reference& _rxInStream) case 2: break; case 3: -OSL_FAIL("FmXFormattedModel::read : unknown effective value type !"); +OSL_FAIL("FmXFormattedModel::read : unknown effective value type!"); } } -// this property is only to be set if we have no control source : in all other cases the base class did a +// this property is only to be set if we have no control source: in all other cases the base class made a // reset after it's read and this set the effective value to a default value if ( m_xAggregateSet.is() && getControlSource().isEmpty() ) { diff --git a/forms/source/component/FormattedFieldWrapper.cxx b/forms/source/component/FormattedFieldWrapper.cxx index 1a7cf9446190..b434e1bd2e84 100644 --- a/forms/source/component/FormattedFieldWrapper.cxx +++ b/forms/source/component/FormattedFieldWrapper.cxx @@ -237,7 +237,7 @@ void SAL_CALL OFormattedFieldWrapper::read(const Reference& { SolarMutexGuard g; if (m_xAggregate.is()) -{ // we already did a
[Libreoffice-commits] core.git: solenv/flatpak-manifest.in
solenv/flatpak-manifest.in |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit cc8eeb3148b88807b4acf4ac3c829fb4f37f9a80 Author: Stephan Bergmann AuthorDate: Wed Jan 8 11:32:28 2020 +0100 Commit: Stephan Bergmann CommitDate: Wed Jan 8 13:23:26 2020 +0100 Adapt solenv/flatpak-manifest.in to ffe9ff2cf63112ac04a695740a5637f25c16abe8 ..."update cppunit to 1.15.1" Change-Id: Id27a3c1b54845e965381514584ebaac13f70d8da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86413 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/solenv/flatpak-manifest.in b/solenv/flatpak-manifest.in index 294bcd1a3e76..6536b0c5d552 100644 --- a/solenv/flatpak-manifest.in +++ b/solenv/flatpak-manifest.in @@ -171,10 +171,10 @@ "dest-filename": "external/tarballs/CoinMP-1.7.6.tgz" }, { -"url": "https://dev-www.libreoffice.org/src/cppunit-1.14.0.tar.gz;, -"sha256": "3d569869d27b48860210c758c4f313082103a5e58219a7669b52bfd29d674780", +"url": "https://dev-www.libreoffice.org/src/cppunit-1.15.1.tar.gz;, +"sha256": "89c5c6665337f56fd2db36bc3805a5619709d51fb136e51937072f63fcc717a7", "type": "file", -"dest-filename": "external/tarballs/cppunit-1.14.0.tar.gz" +"dest-filename": "external/tarballs/cppunit-1.15.1.tar.gz" }, { "url": "https://dev-www.libreoffice.org/src/Firebird-3.0.0.32483-0.tar.bz2;, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: framework/source writerperfect/source
framework/source/dispatch/dispatchprovider.cxx |2 +- writerperfect/source/common/WPXSvInputStream.cxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 22d656a45ce3d44d775196c70e7dae8aced90b3d Author: Andrea Gelmini AuthorDate: Wed Jan 8 06:53:31 2020 +0100 Commit: Adolfo Jayme Barrientos CommitDate: Wed Jan 8 13:18:43 2020 +0100 Fix typo/grammar Change-Id: I8e7320224a9cb4ff9317b842a2c1c0b1a3ddcd17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86390 Tested-by: Jenkins Reviewed-by: Julien Nabet Reviewed-by: Adolfo Jayme Barrientos diff --git a/framework/source/dispatch/dispatchprovider.cxx b/framework/source/dispatch/dispatchprovider.cxx index c573cd487e48..9d86254061a7 100644 --- a/framework/source/dispatch/dispatchprovider.cxx +++ b/framework/source/dispatch/dispatchprovider.cxx @@ -325,7 +325,7 @@ css::uno::Reference< css::frame::XDispatch > DispatchProvider::implts_queryFrame { css::uno::Reference< css::frame::XDispatchProvider > xParent( xFrame->getCreator(), css::uno::UNO_QUERY ); // In case the frame is not a top one, is not based on system window and has a parent, -// the parent frame should to be queried for the correct dispatcher. +// the parent frame should be queried for the correct dispatcher. // See i93473 if ( !WindowHelper::isTopWindow(xFrame->getContainerWindow()) && diff --git a/writerperfect/source/common/WPXSvInputStream.cxx b/writerperfect/source/common/WPXSvInputStream.cxx index f1799f56bd19..3f37c89c11c3 100644 --- a/writerperfect/source/common/WPXSvInputStream.cxx +++ b/writerperfect/source/common/WPXSvInputStream.cxx @@ -77,7 +77,7 @@ namespace OUString lcl_normalizeSubStreamPath(const OUString& rPath) { // accept paths which begin by '/' -// TODO: maybe this should to a full normalization +// TODO: maybe this should do a full normalization if (rPath.startsWith("/") && rPath.getLength() >= 2) return rPath.copy(1); return rPath; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: pyuno/source
pyuno/source/module/pyuno_runtime.cxx |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) New commits: commit 648fa0ab6bd5399422951f848ca86cb710b1bd52 Author: Michael Stahl AuthorDate: Wed Jan 8 10:31:37 2020 +0100 Commit: Michael Stahl CommitDate: Wed Jan 8 13:07:09 2020 +0100 pyuno: remove redundant if Change-Id: Ie0359efa8777439818e357a14db3e2474e936ef6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86403 Reviewed-by: Michael Stahl Tested-by: Jenkins diff --git a/pyuno/source/module/pyuno_runtime.cxx b/pyuno/source/module/pyuno_runtime.cxx index e0987cd63cd7..3e2bb0c6b0a6 100644 --- a/pyuno/source/module/pyuno_runtime.cxx +++ b/pyuno/source/module/pyuno_runtime.cxx @@ -1001,9 +1001,7 @@ PyThreadAttach::~PyThreadAttach() if (m_isNewState) { // Clear needs GIL! PyThreadState_Clear( tstate ); -} -if (m_isNewState) -{ // note: PyThreadState_Delete(tstate) cannot be called, it will assert +// note: PyThreadState_Delete(tstate) cannot be called, it will assert // because it requires a PyThreadState to be set, but not the tstate! PyThreadState_DeleteCurrent(); } @@ -1017,6 +1015,7 @@ PyThreadDetach::PyThreadDetach() { tstate = PyThreadState_Get(); PyEval_ReleaseThread( tstate ); +// tstate must not be deleted here! lots of pointers to it on the stack } /** Acquires the global interpreter lock again ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 116883] FILEOPEN DOCX Numbering format shown as "1.1.1-" even though it should be "1-1-1-"
https://bugs.documentfoundation.org/show_bug.cgi?id=116883 Szabolcs Toth changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |szabolcs...@gmail.com |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97899] FILEOPEN: Numbering format in (part of) docx files not imported correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=97899 Szabolcs Toth changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |szabolcs...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sw/uiconfig
sw/uiconfig/swriter/ui/sidebartableedit.ui |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit ff8cea1ca6f193f434b52361b435403a0f27d023 Author: Tor Lillqvist AuthorDate: Tue Jan 7 17:42:50 2020 +0200 Commit: Tor Lillqvist CommitDate: Wed Jan 8 12:59:19 2020 +0100 tdf#129373: Make table column width and row height controls look better on iOS For some reason the space allocated for the measurement in a svxlo-SvxRelativeField is quite large, and it looks weird when the plus button of the row height control bumps into the icon of the column width control. (Changing the hexpand element to False does not fully help.) It looks much better to have these controls on separate rows. Hopefully the change in how it looks in web-based Online or in desktop LibreOffice will not cause endless bikeshedding. Change-Id: Ia8fbbbfe035a92fc5c89b27dc8c8985707a5cb0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86358 Reviewed-by: Tor Lillqvist Tested-by: Tor Lillqvist diff --git a/sw/uiconfig/swriter/ui/sidebartableedit.ui b/sw/uiconfig/swriter/ui/sidebartableedit.ui index aa01759ea491..4ca5c3a6b483 100644 --- a/sw/uiconfig/swriter/ui/sidebartableedit.ui +++ b/sw/uiconfig/swriter/ui/sidebartableedit.ui @@ -173,6 +173,7 @@ True False +vertical True @@ -198,7 +199,7 @@ True True Row Height -True +False 0 @@ -244,7 +245,7 @@ True True Column Width -True +False 0 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loleaflet/admin
loleaflet/admin/src/AdminSocketOverview.js |3 +++ 1 file changed, 3 insertions(+) New commits: commit 971ed41c0ddfcf5ed193435d73b819e09dd3c338 Author: Michael Meeks AuthorDate: Wed Jan 8 11:50:19 2020 + Commit: Michael Meeks CommitDate: Wed Jan 8 11:51:10 2020 + admin: Kill menu uses href="#" so disable vex auto-close on popstate Change-Id: Icc94fc0dae70718700b709b81785162254af2ed4 diff --git a/loleaflet/admin/src/AdminSocketOverview.js b/loleaflet/admin/src/AdminSocketOverview.js index 9c61089cc..029b36997 100644 --- a/loleaflet/admin/src/AdminSocketOverview.js +++ b/loleaflet/admin/src/AdminSocketOverview.js @@ -82,6 +82,9 @@ var AdminSocketOverview = AdminSocketBase.extend({ }); }, 1000); + // Dialog uses https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129866] PASTE doesn't work correctly on calc
https://bugs.documentfoundation.org/show_bug.cgi?id=129866 --- Comment #2 from Timur --- May be a duplicate of bug 65606. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: pyuno/source
pyuno/source/module/pyuno_runtime.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit fb4e15a89d8d8f081c0c152e5047bc0e76870b39 Author: Miklos Vajna AuthorDate: Wed Jan 8 11:12:08 2020 +0100 Commit: Miklos Vajna CommitDate: Wed Jan 8 12:47:46 2020 +0100 pyuno: fix build against system-python-3.6 pyuno/source/module/pyuno_runtime.cxx:984:57: error: use of undeclared identifier 'PyThread_get_thread_ident' It's only an assert, so simply do it only for >=3.7. Change-Id: Ia3fffc7a9af30780adff9bc7dbabe1727c1f8f54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86410 Reviewed-by: Michael Stahl Tested-by: Jenkins diff --git a/pyuno/source/module/pyuno_runtime.cxx b/pyuno/source/module/pyuno_runtime.cxx index 5fa923c236dc..e0987cd63cd7 100644 --- a/pyuno/source/module/pyuno_runtime.cxx +++ b/pyuno/source/module/pyuno_runtime.cxx @@ -979,9 +979,11 @@ PyThreadAttach::PyThreadAttach( PyInterpreterState *interp) // note: *may* be called recursively, with PyThreadDetach between - in // that case, don't create *new* PyThreadState but reuse! #ifndef NDEBUG +#if PY_MAJOR_VERSION == 3 && PY_MINOR_VERSION >= 7 PyThreadState const*const current = _PyThreadState_UncheckedGet(); // dereference isn't safe but let's hope it's tolerable for debugging purpose assert((current == nullptr || current->thread_id != PyThread_get_thread_ident()) && "recursive PyThreadAttach"); +#endif #endif tstate = PyGILState_GetThisThreadState(); // from TLS, possibly detached if (!tstate) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129556] Appending data to Firebird Base table with copied Calc range can be over the field length
https://bugs.documentfoundation.org/show_bug.cgi?id=129556 Alex Thurgood changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |DUPLICATE --- Comment #8 from Alex Thurgood --- Seems to me that this is a DUP of bug 108082 *** This bug has been marked as a duplicate of bug 108082 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108082] Firebird:The user can enter up to 20 characters in a field with a length of 5
https://bugs.documentfoundation.org/show_bug.cgi?id=108082 Alex Thurgood changed: What|Removed |Added CC||nuk...@gmail.com --- Comment #7 from Alex Thurgood --- *** Bug 129556 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128614] Paste bug
https://bugs.documentfoundation.org/show_bug.cgi?id=128614 Timur changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA --- Comment #4 from Timur --- Since no response from reporter, I close as insufficient. If you do test as required and reproduce and explain details, feel free to set Unconfirmed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - include/xmloff xmloff/inc xmloff/source
include/xmloff/xmltoken.hxx |1 xmloff/inc/SchXMLImport.hxx |1 xmloff/source/chart/SchXMLExport.cxx | 55 -- xmloff/source/chart/SchXMLImport.cxx |1 xmloff/source/chart/SchXMLPlotAreaContext.cxx | 100 ++ xmloff/source/chart/SchXMLPlotAreaContext.hxx | 47 +++- xmloff/source/chart/SchXMLSeries2Context.cxx | 18 ++-- xmloff/source/chart/transporttypes.hxx|7 + xmloff/source/core/xmltoken.cxx |1 xmloff/source/token/tokens.txt|1 10 files changed, 186 insertions(+), 46 deletions(-) New commits: commit cdacee1de7cd8d98d79ef13bc165ce016c8b2e1a Author: Tamas Bunth AuthorDate: Wed Dec 18 13:08:11 2019 +0100 Commit: Andras Timar CommitDate: Wed Jan 8 12:44:08 2020 +0100 tdf#123206 Store custom label as chart:data-label Use the chart:data-label element instead of using the loext:custom-label-field attribute. chart:data-label stores can be a child of chart:data-point and it may contain a text:o element for holding one or more paragraphs of custom label text. This commit aims to export and import chart:data-label with paragraphs put into different text:span elements. These span elements may hold a text:style-name attribute in order to achieve formatted text. This structure is already in the ODF format. Change-Id: I0bea7ce1a16af9c47b33555e18545bdaae7e95ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85659 Tested-by: Jenkins Reviewed-by: Tamás Bunth Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86122 Reviewed-by: Andras Timar diff --git a/include/xmloff/xmltoken.hxx b/include/xmloff/xmltoken.hxx index 02bd9702d980..1175958548ff 100644 --- a/include/xmloff/xmltoken.hxx +++ b/include/xmloff/xmltoken.hxx @@ -551,6 +551,7 @@ namespace xmloff { namespace token { XML_DATA_BAR, XML_DATA_BAR_ENTRY, XML_DATA_CELL_RANGE_ADDRESS, +XML_DATA_LABEL, XML_DATA_LABEL_NUMBER, XML_DATA_LABEL_SYMBOL, XML_DATA_LABEL_TEXT, diff --git a/xmloff/inc/SchXMLImport.hxx b/xmloff/inc/SchXMLImport.hxx index 5b587a4abdb1..2978ac66b5ab 100644 --- a/xmloff/inc/SchXMLImport.hxx +++ b/xmloff/inc/SchXMLImport.hxx @@ -73,6 +73,7 @@ enum SchXMLPlotAreaElemTokenMap enum SchXMLSeriesElemTokenMap { XML_TOK_SERIES_DATA_POINT, +XML_TOK_SERIES_DATA_LABEL, XML_TOK_SERIES_DOMAIN, XML_TOK_SERIES_MEAN_VALUE_LINE, XML_TOK_SERIES_REGRESSION_CURVE, diff --git a/xmloff/source/chart/SchXMLExport.cxx b/xmloff/source/chart/SchXMLExport.cxx index 4dd2bc43b6c8..e277b73758b7 100644 --- a/xmloff/source/chart/SchXMLExport.cxx +++ b/xmloff/source/chart/SchXMLExport.cxx @@ -113,11 +113,13 @@ using ::std::vector; namespace { +using CustomLabelSeq = Sequence>; + struct SchXMLDataPointStruct { OUString maStyleName; sal_Int32 mnRepeat; -OUString msCustomLabelText; +CustomLabelSeq mCustomLabelText; SchXMLDataPointStruct() : mnRepeat( 1 ) {} }; @@ -229,6 +231,8 @@ public: const css::uno::Reference< css::chart2::XDiagram > & xDiagram, bool bExportContent ); +void exportCustomLabel(const CustomLabelSeq & xCustomLabel); + void exportRegressionCurve( const css::uno::Reference& xSeries, const css::awt::Size& rPageSize, @@ -277,31 +281,26 @@ public: namespace { -OUString lcl_getCustomLabelField(sal_Int32 nDataPointIndex, +CustomLabelSeq lcl_getCustomLabelField(sal_Int32 nDataPointIndex, const uno::Reference< chart2::XDataSeries >& rSeries) { if( !rSeries.is() ) -return OUString{}; +return CustomLabelSeq(); const SvtSaveOptions::ODFDefaultVersion nCurrentODFVersion( SvtSaveOptions().GetODFDefaultVersion() ); if( nCurrentODFVersion <= SvtSaveOptions::ODFVER_012 )//do not export to ODF 1.2 or older -return OUString{}; +return CustomLabelSeq(); -// export custom label text if(Reference xLabels = rSeries->getDataPointByIndex(nDataPointIndex); xLabels.is()) { if(Any aAny = xLabels->getPropertyValue("CustomLabelFields"); aAny.hasValue()) { Sequence> aCustomLabels; aAny >>= aCustomLabels; -OUString sLabel; -// TODO export formatted string instead of simple characters -for(auto& aLabel : aCustomLabels) -sLabel += aLabel->getString(); -return sLabel; +return aCustomLabels; } } -return OUString{}; +return CustomLabelSeq(); } class lcl_MatchesRole @@ -3266,7 +3265,7 @@ void SchXMLExportHelper_Impl::exportDataPoints( SchXMLDataPointStruct aPoint; aPoint.maStyleName = maAutoStyleNameQueue.front();
[Libreoffice-bugs] [Bug 123206] FILEOPEN DOCX Custom chart labels disappear
https://bugs.documentfoundation.org/show_bug.cgi?id=123206 Commit Notification changed: What|Removed |Added Whiteboard|target:6.5.0 target:6.4.0.1 |target:6.5.0 target:6.4.0.1 |target:6.3.5|target:6.3.5 target:6.4.0.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123206] FILEOPEN DOCX Custom chart labels disappear
https://bugs.documentfoundation.org/show_bug.cgi?id=123206 --- Comment #16 from Commit Notification --- Tamas Bunth committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/cdacee1de7cd8d98d79ef13bc165ce016c8b2e1a tdf#123206 Store custom label as chart:data-label It will be available in 6.4.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - .gitreview
.gitreview |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 8b6a27abe930685e99135a2ec430f8167d8cd88f Author: Samuel Mehrbrodt AuthorDate: Mon Dec 23 08:33:57 2019 +0100 Commit: Michael Stahl CommitDate: Wed Jan 8 12:43:40 2020 +0100 .gitreview: Update default branch Change-Id: Ieb52dd99910bef4efd75639a1ba90e3f1e6a91bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85729 Reviewed-by: Michael Stahl Tested-by: Michael Stahl diff --git a/.gitreview b/.gitreview index 4cd7d22d9a83..061a30936c85 100644 --- a/.gitreview +++ b/.gitreview @@ -3,5 +3,4 @@ host=gerrit.libreoffice.org port=29418 project=core defaultremote=logerrit -defaultbranch=libreoffice-6-4 - +defaultbranch=distro/lhm/libreoffice-6-4+backports ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129772] LibreOffice Base lacks documentation on ODBC in general and MDB in particular
https://bugs.documentfoundation.org/show_bug.cgi?id=129772 --- Comment #3 from Alex Thurgood --- See also : https://github.com/brianb/mdbtools The documentation in LO is limited to general points about the possibility of connecting to an ODBC compliant pre-defined datasource. The specifics are, well, specific to each type of database to which you want to connect via ODBC and as such depend very much on the ODBC driver. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: filter/source
filter/source/msfilter/msdffimp.cxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit fcf25f3b300463422a5c5c8895710d71e372878a Author: Caolán McNamara AuthorDate: Wed Jan 8 08:54:38 2020 + Commit: Caolán McNamara CommitDate: Wed Jan 8 12:39:14 2020 +0100 ofz#19901 Invalid-enum-value Change-Id: I14273dfc695c504bd00f23f614b041207a8f2b29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86396 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/filter/source/msfilter/msdffimp.cxx b/filter/source/msfilter/msdffimp.cxx index 9fc3a35764c3..97577199628c 100644 --- a/filter/source/msfilter/msdffimp.cxx +++ b/filter/source/msfilter/msdffimp.cxx @@ -4419,7 +4419,6 @@ SdrObject* SvxMSDffManager::ImportShape( const DffRecordHeader& rHd, SvStream& r { OUStringaObjectText; OUStringaFontName; -MSO_GeoTextAligneGeoTextAlign; if ( SeekToContent( DFF_Prop_gtextFont, rSt ) ) { @@ -4454,7 +4453,7 @@ SdrObject* SvxMSDffManager::ImportShape( const DffRecordHeader& rHd, SvStream& r ReadObjText( aObjectText, pRet ); } -eGeoTextAlign = static_cast(GetPropertyValue( DFF_Prop_gtextAlign, mso_alignTextCenter )); +auto eGeoTextAlign = GetPropertyValue(DFF_Prop_gtextAlign, mso_alignTextCenter); { SdrTextHorzAdjust eHorzAdjust; switch( eGeoTextAlign ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 89846] problem with table column dislocated
https://bugs.documentfoundation.org/show_bug.cgi?id=89846 Timur changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #8 from Timur --- I don't repro steps from Comment 3 in LO 6.5+ but I also don't reproduce with LO 5.2. I may be missing something or resolved. I set Needinfo for you to test in recent LO. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: i18nutil/source
i18nutil/source/utility/casefolding_data.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 41bbc4b9482df12166ba9ae88026717e6327573d Author: Alex Henrie AuthorDate: Fri Dec 20 21:17:43 2019 -0700 Commit: Eike Rathke CommitDate: Wed Jan 8 12:35:29 2020 +0100 Fix case mapping for undefined characters in the Osage block Regression from commit 209fc9fd7fa433947af0bf86e210d73fa7f5a045 Change-Id: Icd181d0611b5fe194ba00352a93bf40bef35a8f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85641 Tested-by: Jenkins Reviewed-by: Eike Rathke diff --git a/i18nutil/source/utility/casefolding_data.h b/i18nutil/source/utility/casefolding_data.h index 20c5cc714103..938fb4df9076 100644 --- a/i18nutil/source/utility/casefolding_data.h +++ b/i18nutil/source/utility/casefolding_data.h @@ -516,12 +516,12 @@ static const Value CaseMappingValue[] = { {0x6a, 0xDCE0}, {0x6a, 0xDCE1}, {0x6a, 0xDCE2}, {0x6a, 0xDCE3}, {0x6a, 0xDCE4}, {0x6a, 0xDCE5}, {0x6a, 0xDCE6}, {0x6a, 0xDCE7}, // 104b8 - 104bf {0x6a, 0xDCE8}, {0x6a, 0xDCE9}, {0x6a, 0xDCEA}, {0x6a, 0xDCEB}, {0x6a, 0xDCEC}, {0x6a, 0xDCED}, {0x6a, 0xDCEE}, {0x6a, 0xDCEF}, // 104c0 - 104c7 {0x6a, 0xDCF0}, {0x6a, 0xDCF1}, {0x6a, 0xDCF2}, {0x6a, 0xDCF3}, {0x6a, 0xDCF4}, {0x6a, 0xDCF5}, {0x6a, 0xDCF6}, {0x6a, 0xDCF7}, // 104c8 - 104cf -{0x6a, 0xDCF8}, {0x6a, 0xDCF9}, {0x6a, 0xDCFA}, {0x6a, 0xDCFB}, {0x6a, 0x}, {0x6a, 0x}, {0x6a, 0x}, {0x6a, 0x}, // 104d0 - 104d7 +{0x6a, 0xDCF8}, {0x6a, 0xDCF9}, {0x6a, 0xDCFA}, {0x6a, 0xDCFB}, {0x00, 0x}, {0x00, 0x}, {0x00, 0x}, {0x00, 0x}, // 104d0 - 104d7 {0x15, 0xDCB0}, {0x15, 0xDCB1}, {0x15, 0xDCB2}, {0x15, 0xDCB3}, {0x15, 0xDCB4}, {0x15, 0xDCB5}, {0x15, 0xDCB6}, {0x15, 0xDCB7}, // 104d8 - 104df {0x15, 0xDCB8}, {0x15, 0xDCB9}, {0x15, 0xDCBA}, {0x15, 0xDCBB}, {0x15, 0xDCBC}, {0x15, 0xDCBD}, {0x15, 0xDCBE}, {0x15, 0xDCBF}, // 104e0 - 104e7 {0x15, 0xDCC0}, {0x15, 0xDCC1}, {0x15, 0xDCC2}, {0x15, 0xDCC3}, {0x15, 0xDCC4}, {0x15, 0xDCC5}, {0x15, 0xDCC6}, {0x15, 0xDCC7}, // 104e8 - 104ef {0x15, 0xDCD0}, {0x15, 0xDCD1}, {0x15, 0xDCD2}, {0x15, 0xDCD3}, {0x15, 0xDCD4}, {0x15, 0xDCD5}, {0x15, 0xDCD6}, {0x15, 0xDCD7}, // 104f0 - 104f7 -{0x15, 0xDCD8}, {0x15, 0xDCD9}, {0x15, 0xDCDA}, {0x15, 0xDCDB}, {0x15, 0x}, {0x15, 0x}, {0x15, 0x}, {0x15, 0x}, // 104f8 - 104ff +{0x15, 0xDCD8}, {0x15, 0xDCD9}, {0x15, 0xDCDA}, {0x15, 0xDCDB}, {0x00, 0x}, {0x00, 0x}, {0x00, 0x}, {0x00, 0x}, // 104f8 - 104ff }; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cui/uiconfig
cui/uiconfig/ui/numberingoptionspage.ui | 97 +++-- cui/uiconfig/ui/numberingpositionpage.ui | 224 --- 2 files changed, 174 insertions(+), 147 deletions(-) New commits: commit d54315e5cb371afd01c5f03958dda9bcf93514e5 Author: Seth Chaiklin AuthorDate: Tue Jan 7 01:39:49 2020 +0100 Commit: Caolán McNamara CommitDate: Wed Jan 8 12:33:54 2020 +0100 tdf#129517 add "Preview" labels in BulletandNumberingStyle dialog box" added GtkFrame to include label with Preview Window in Customize tab added label in Position tab Change-Id: Id37a2c696832ebe9dcd3cb4910a7bc3292cb0143 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86320 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/cui/uiconfig/ui/numberingoptionspage.ui b/cui/uiconfig/ui/numberingoptionspage.ui index c13f9dad950d..321602dcf693 100644 --- a/cui/uiconfig/ui/numberingoptionspage.ui +++ b/cui/uiconfig/ui/numberingoptionspage.ui @@ -581,49 +581,6 @@ 0 - - -True -False -never -never -in - - -True -False - - -150 -300 -True -False - - - - - - -True -True -1 - - - - -True -False -Preview - - - - - - -True -True -1 - @@ -695,5 +652,59 @@ 1 + + +True +False +0 +none + + +True +False +6 +12 + + +True +False +never +never +in + + +True +False + + +150 +300 +True +False + + + + + + + + + + +True +False +Preview + + + + + + + +True +True +2 + + diff --git a/cui/uiconfig/ui/numberingpositionpage.ui b/cui/uiconfig/ui/numberingpositionpage.ui index 75be42c1456b..4ab3f2226c5d 100644 --- a/cui/uiconfig/ui/numberingpositionpage.ui +++ b/cui/uiconfig/ui/numberingpositionpage.ui @@ -48,68 +48,6 @@ True 6 12 - - -True -False -0 -none - - -True -False -6 -12 - - -True -True -in - - -True -True -liststore1 -False -False -0 -False - - - - - - - - -0 - - - - - - - - - - - - -True -False -Level - - - - - - - -False -True -0 - - True @@ -428,78 +366,156 @@ numbering and text: - + True False -True -True -
[Libreoffice-bugs] [Bug 129772] LibreOffice Base lacks documentation on ODBC in general and MDB in particular
https://bugs.documentfoundation.org/show_bug.cgi?id=129772 --- Comment #2 from Alex Thurgood --- For general usage on setting up a connection to an ODBC defined datasource, there is actually quite a lot of documentation out there, for example: https://www.easysoft.com/applications/openoffice_org/odbc.html much of the older documentation written for OpenOffice.org is still valid. Note that ODB and ODBC are not the same thing - the first is the filename extension, the second a protocol for accessing data sources which is made accessible via a separate driver. I am not aware of an ODBC-compliant driver which runs on Linux that will allow you to gain access to a MDB file. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sw/inc sw/qa sw/source
sw/inc/doc.hxx|4 + sw/qa/extras/tiledrendering/data/redline-notification-during-save.odt |binary sw/qa/extras/tiledrendering/tiledrendering.cxx| 21 ++ sw/source/core/doc/docnew.cxx |1 sw/source/core/txtnode/ndtxt.cxx |4 + sw/source/filter/basflt/shellio.cxx |2 6 files changed, 31 insertions(+), 1 deletion(-) New commits: commit a32e277b0f9c7d58391d93e4cc1ce6d11fe48878 Author: Miklos Vajna AuthorDate: Tue Jan 7 17:26:53 2020 +0100 Commit: Miklos Vajna CommitDate: Wed Jan 8 12:23:52 2020 +0100 sw: don't send LOK notifications about redlines during save SwXMLWriter::Write_() sets redline flags to show insertion and hide deletion, but it resets those flags before the function returns. So LOK notifications for redline changes during save is not useful. Conflicts: sw/qa/extras/tiledrendering/tiledrendering.cxx Change-Id: I4bf963bbe9c7003cbe85ea6c5538be733a3e3cdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86369 Reviewed-by: Miklos Vajna Tested-by: Miklos Vajna diff --git a/sw/inc/doc.hxx b/sw/inc/doc.hxx index 5afcea308e31..83f89c88db79 100644 --- a/sw/inc/doc.hxx +++ b/sw/inc/doc.hxx @@ -299,6 +299,7 @@ private: frames need deletion. */ bool mbCopyIsMove: 1;//< TRUE: Copy is a hidden Move. bool mbInReading : 1;//< TRUE: Document is in the process of being read. +bool mbInWriting : 1; //< TRUE: Document is in the process of being written. bool mbInMailMerge : 1;//< TRUE: Document is in the process of being written by mail merge. bool mbInXMLImport : 1;//< TRUE: During xml import, attribute portion building is not necessary. bool mbUpdateTOX : 1;//< TRUE: After loading document, update TOX. @@ -948,6 +949,9 @@ public: bool IsInReading() const{ return mbInReading; } void SetInReading( bool bNew ) { mbInReading = bNew; } +bool IsInWriting() const { return mbInWriting; } +void SetInWriting(bool bNew) { mbInWriting = bNew; } + bool IsInMailMerge() const { return mbInMailMerge; } void SetInMailMerge( bool bNew ){ mbInMailMerge = bNew; } diff --git a/sw/qa/extras/tiledrendering/data/redline-notification-during-save.odt b/sw/qa/extras/tiledrendering/data/redline-notification-during-save.odt new file mode 100644 index ..2bd9c814750c Binary files /dev/null and b/sw/qa/extras/tiledrendering/data/redline-notification-during-save.odt differ diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx b/sw/qa/extras/tiledrendering/tiledrendering.cxx index e07605770c56..e1fdbcc4b97b 100644 --- a/sw/qa/extras/tiledrendering/tiledrendering.cxx +++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx @@ -12,6 +12,7 @@ #include #include +#include #include #include #include @@ -120,6 +121,7 @@ public: void testLanguageStatus(); void testDeselectCustomShape(); void testHyperlink(); +void testRedlineNotificationDuringSave(); CPPUNIT_TEST_SUITE(SwTiledRenderingTest); CPPUNIT_TEST(testRegisterCallback); @@ -182,6 +184,7 @@ public: CPPUNIT_TEST(testLanguageStatus); CPPUNIT_TEST(testDeselectCustomShape); CPPUNIT_TEST(testHyperlink); +CPPUNIT_TEST(testRedlineNotificationDuringSave); CPPUNIT_TEST_SUITE_END(); private: @@ -2487,6 +2490,24 @@ void SwTiledRenderingTest::testHyperlink() } +void SwTiledRenderingTest::testRedlineNotificationDuringSave() +{ +// Load a document with redlines which are hidden at a layout level. +// It's an empty document, just settings.xml and content.xml are custom. +comphelper::LibreOfficeKit::setActive(); +SwXTextDocument* pXTextDocument = createDoc("redline-notification-during-save.odt"); +SwWrtShell* pWrtShell = pXTextDocument->GetDocShell()->GetWrtShell(); + pWrtShell->GetSfxViewShell()->registerLibreOfficeKitViewCallback(::callback, this); + +// Save the document. +utl::MediaDescriptor aMediaDescriptor; +aMediaDescriptor["FilterName"] <<= OUString("writer8"); +uno::Reference xStorable(mxComponent, uno::UNO_QUERY); +// Without the accompanying fix in place, this test would have never returned due to an infinite +// loop while sending not needed LOK notifications for redline changes during save. +xStorable->storeToURL(maTempFile.GetURL(), aMediaDescriptor.getAsConstPropertyValueList()); +} + CPPUNIT_TEST_SUITE_REGISTRATION(SwTiledRenderingTest); CPPUNIT_PLUGIN_IMPLEMENT(); diff --git a/sw/source/core/doc/docnew.cxx b/sw/source/core/doc/docnew.cxx index 421d49bac9a3..b176293ef3ff 100644 ---
[Libreoffice-bugs] [Bug 129772] LibreOffice Base lacks documentation on ODBC in general and MDB in particular
https://bugs.documentfoundation.org/show_bug.cgi?id=129772 --- Comment #1 from Alex Thurgood --- @Noloader : why is the subject header about ODBC to MDB when you are on Linux ? What makes you think that an ODBC driver (in this case unixODBC provided by the Linux distro) would allow you to connect to an Access MDB file ? Shouldn't you be trying with another tool, e.g. : https://www.binarytides.com/open-view-ms-access-mdb-files-in-ubuntu-linux/ or https://ask.libreoffice.org/en/question/145877/mdb-files-not-loading-to-base/ "UCanAccess" which uses a JDBC driver -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs