date:20200126

When I ran make 2>&1 | tee build.log , the process halted in between.
When I again ran it again, it gave the following output :
C:/cygwin/home/hp/lode/opt/bin/make -j 4  -rs -f
C:/cygwin/home/hp/lode/dev/core/Makefile.gbuildall
[build DEP] LNK:StaticLibrary/graphite.lib
[build DEP] LNK:StaticLibrary/expat.lib
[build DEP] LNK:Library/salhelper3MSC.dll
[build LNK] Library/salhelper3MSC.dll
[build PRJ] icu
[build DEP] LNK:StaticLibrary/expat.lib
[build LNK] StaticLibrary/expat.lib
[build DEP] LNK:Executable/bestreversemap.exe
[build LNK] Executable/bestreversemap.exe
[build UPK] libjpeg-turbo-1.5.3.tar.gz
[build CXX] workdir/UnpackedTarball/graphite/src/json.cpp
[build CXX] workdir/UnpackedTarball/graphite/src/CmapCache.cpp
[build CXX] workdir/UnpackedTarball/graphite/src/Code.cpp
[build CXX] workdir/UnpackedTarball/graphite/src/Collider.cpp
[build CXX] workdir/UnpackedTarball/graphite/src/Decompressor.cpp
[build CXX] workdir/UnpackedTarball/graphite/src/Face.cpp
[build CXX] workdir/UnpackedTarball/graphite/src/FeatureMap.cpp
[build CXX] workdir/UnpackedTarball/graphite/src/FileFace.cpp
[build CXX] workdir/UnpackedTarball/graphite/src/Font.cpp
[build CXX] workdir/UnpackedTarball/graphite/src/GlyphCache.cpp
[build CXX] workdir/UnpackedTarball/graphite/src/GlyphFace.cpp
[build CXX] workdir/UnpackedTarball/graphite/src/Intervals.cpp
Configuring for VC-WIN32
no-ec_nistp_64_gcc_128 [default]  OPENSSL_NO_EC_NISTP_64_GCC_128 (skip
dir)
no-gmp  [default]  OPENSSL_NO_GMP (skip dir)
no-idea [option]   OPENSSL_NO_IDEA (skip dir)
no-jpake[experimental] OPENSSL_NO_JPAKE (skip dir)
no-krb5 [krb5-flavor not specified] OPENSSL_NO_KRB5
no-libunbound   [experimental] OPENSSL_NO_LIBUNBOUND (skip dir)
no-md2  [default]  OPENSSL_NO_MD2 (skip dir)
no-rc5  [default]  OPENSSL_NO_RC5 (skip dir)
no-rfc3779  [default]  OPENSSL_NO_RFC3779 (skip dir)
no-sctp [default]  OPENSSL_NO_SCTP (skip dir)
no-shared   [default]
no-ssl-trace[default]  OPENSSL_NO_SSL_TRACE (skip dir)
no-ssl2 [default]  OPENSSL_NO_SSL2 (skip dir)
no-store[experimental] OPENSSL_NO_STORE (skip dir)
no-unit-test[default]  OPENSSL_NO_UNIT_TEST (skip dir)
no-weak-ssl-ciphers [default]  OPENSSL_NO_WEAK_SSL_CIPHERS (skip dir)
no-zlib [default]
no-zlib-dynamic [default]
IsMK1MF=1
CC
 
=C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\1424~1.283\bin\HostX64\x86\cl.exe
-arch:SSE
CFLAG =-DOPENSSL_THREADS  -DDSO_WIN32 -W3 -WX -Gs0 -GF -Gy -nologo
-DOPENSSL_SYSNAME_WIN32 -DWIN32_LEAN_AND_MEAN -DL_ENDIAN
-D_CRT_SECURE_NO_DEPRECATE -D_WINSOCK_DEPRECATED_NO_WARNINGS
-DOPENSSL_BN_ASM_PART_WORDS -DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT
-DOPENSSL_BN_ASM_GF2m -DRC4_ASM -DSHA1_ASM -DSHA256_ASM -DSHA512_ASM
-DMD5_ASM -DRMD160_ASM -DAES_ASM -DVPAES_ASM -DWHIRLPOOL_ASM -DGHASH_ASM
EX_LIBS   =
CPUID_OBJ =x86cpuid.o
BN_ASM=bn-586.o co-586.o x86-mont.o x86-gf2m.o
EC_ASM=
DES_ENC   =des-586.o crypt586.o
AES_ENC   =aes-586.o vpaes-x86.o aesni-x86.o
BF_ENC=bf-586.o
CAST_ENC  =cast-586.o
RC4_ENC   =rc4-586.o
RC5_ENC   =rc5-586.o
MD5_OBJ_ASM   =md5-586.o
SHA1_OBJ_ASM  =sha1-586.o sha256-586.o sha512-586.o
RMD160_OBJ_ASM=rmd-586.o
CMLL_ENC  =cmll-x86.o
MODES_OBJ =ghash-x86.o
ENGINES_OBJ   =
PROCESSOR =
RANLIB=/cygdrive/c/MinGW/bin/ranlib
ARFLAGS   =
PERL  =C:\cygwin\bin\perl.exe
THIRTY_TWO_BIT mode
BN_LLONG mode
RC4_INDEX mode
RC4_CHUNK is undefined

Configured for VC-WIN32.

C:\cygwin\home\hp\lode\dev\core\workdir\UnpackedTarball\openssl>C:/cygwin/bin/perl.exe
util\mkfiles.pl  1>MINFO

C:\cygwin\home\hp\lode\dev\core\workdir\UnpackedTarball\openssl>if VC-WIN32
== VC-WIN32 goto not64a

C:\cygwin\home\hp\lode\dev\core\workdir\UnpackedTarball\openssl>C:/cygwin/bin/perl.exe
util\mk1mf.pl no-asm VC-WIN32  1>ms\nt.mak

C:\cygwin\home\hp\lode\dev\core\workdir\UnpackedTarball\openssl>C:/cygwin/bin/perl.exe
util\mk1mf.pl dll no-asm VC-WIN32  1>ms\ntdll.mak

C:\cygwin\home\hp\lode\dev\core\workdir\UnpackedTarball\openssl>C:/cygwin/bin/perl.exe
util\mkdef.pl 32 libeay  1>ms\libeay32.def

C:\cygwin\home\hp\lode\dev\core\workdir\UnpackedTarball\openssl>C:/cygwin/bin/perl.exe
util\mkdef.pl 32 ssleay  1>ms\ssleay32.def

Microsoft (R) Program Maintenance Utility Version 14.24.28314.0
Copyright (C) Microsoft Corporation.  All rights reserved.

Building OpenSSL
C:\cygwin\bin\perl.exe ./util/copy-if-different.pl
"./crypto/buildinf.h" "tmp32dll/buildinf.h"
Copying: ./crypto/buildinf.h to tmp32dll/buildinf.h

C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\1424~1.283\bin\HostX64\x86\cl.exe
-arch:SSE -Fo.\tmp32dll/rsa_none.obj  -Iinc32 -Itmp32dll -MD -Ox -O2 -Ob2
-DOPENSSL_THREADS  -DDSO_WIN32 -W3 -WX -Gs0 -GF -Gy -nologo
-DOPENSSL_SYSNAME_WIN32 -DWIN32_LEAN_AND_MEAN -DL_ENDIAN
-D_CRT_SECURE_NO_DEPRECATE -D_WINSOCK_DEPRECATED_NO_WARNINGS
-DOPENSSL_BN_A

[Libreoffice-commits] core.git: editeng/inc package/inc sal/textenc sc/inc sw/inc

2020-01-26 Thread Burak Bala (via logerrit)

 editeng/inc/editeng.hxx |6 ++
 package/inc/ZipEnumeration.hxx  |5 ++---
 sal/textenc/gettextencodingdata.hxx |5 +
 sc/inc/scresid.hxx  |5 +
 sw/inc/SwNumberTree.hxx |5 +
 5 files changed, 7 insertions(+), 19 deletions(-)

New commits:
commit 47c598260a8f07cf3a1e4cab061df3f2d261932c
Author: Burak Bala 
AuthorDate: Sat Jan 25 16:35:42 2020 +0300
Commit: Muhammet Kara 
CommitDate: Sun Jan 26 20:47:13 2020 +0100

tdf#124176: Use pragma once instead of include guards

Change-Id: Ib2465f040f12413560b2cec1c742cf3558461309
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87404
Tested-by: Jenkins
Reviewed-by: Muhammet Kara 

diff --git a/editeng/inc/editeng.hxx b/editeng/inc/editeng.hxx
index 6c59982d679e..cce3d79d4e10 100644
--- a/editeng/inc/editeng.hxx
+++ b/editeng/inc/editeng.hxx
@@ -16,8 +16,8 @@
  *   except in compliance with the License. You may obtain a copy of
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
-#ifndef INCLUDED_EDITENG_INC_EDITENG_HXX
-#define INCLUDED_EDITENG_INC_EDITENG_HXX
+
+#pragma once
 
 #define MN_WORDLANGUAGE  998
 #define MN_PARALANGUAGE  999
@@ -25,6 +25,4 @@
 #define MN_AUTOSTART2000
 #define MN_DICTSTART3000
 
-#endif
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/package/inc/ZipEnumeration.hxx b/package/inc/ZipEnumeration.hxx
index 07e8a5848617..cc4156a0ee52 100644
--- a/package/inc/ZipEnumeration.hxx
+++ b/package/inc/ZipEnumeration.hxx
@@ -16,8 +16,8 @@
  *   except in compliance with the License. You may obtain a copy of
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
-#ifndef INCLUDED_PACKAGE_INC_ZIPENUMERATION_HXX
-#define INCLUDED_PACKAGE_INC_ZIPENUMERATION_HXX
+
+#pragma once
 
 #include "HashMaps.hxx"
 
@@ -31,6 +31,5 @@ public:
 ZipEnumeration( EntryHash &rNewEntryHash );
 ~ZipEnumeration();
 };
-#endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sal/textenc/gettextencodingdata.hxx 
b/sal/textenc/gettextencodingdata.hxx
index 22bd9c2fed75..88f22be36424 100644
--- a/sal/textenc/gettextencodingdata.hxx
+++ b/sal/textenc/gettextencodingdata.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_SAL_TEXTENC_GETTEXTENCODINGDATA_HXX
-#define INCLUDED_SAL_TEXTENC_GETTEXTENCODINGDATA_HXX
+#pragma once
 
 #include 
 
@@ -29,6 +28,4 @@
 ImplTextEncodingData const *
 Impl_getTextEncodingData(rtl_TextEncoding nEncoding);
 
-#endif
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/inc/scresid.hxx b/sc/inc/scresid.hxx
index a9b7f2798a6d..0be9da0ff5b6 100644
--- a/sc/inc/scresid.hxx
+++ b/sc/inc/scresid.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_SC_INC_SCRESID_HXX
-#define INCLUDED_SC_INC_SCRESID_HXX
+#pragma once
 
 #include 
 #include "scdllapi.h"
@@ -26,6 +25,4 @@
 OUString SC_DLLPUBLIC ScResId(const char* pId);
 OUString ScResId(const char* pId, int nCardinality);
 
-#endif // SC_SCRESMGR_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/inc/SwNumberTree.hxx b/sw/inc/SwNumberTree.hxx
index ad3ffe845110..9323d3df5644 100644
--- a/sw/inc/SwNumberTree.hxx
+++ b/sw/inc/SwNumberTree.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_SW_INC_SWNUMBERTREE_HXX
-#define INCLUDED_SW_INC_SWNUMBERTREE_HXX
+#pragma once
 
 #include 
 #include 
@@ -602,6 +601,4 @@ protected:
 
 };
 
-#endif // INCLUDED_SW_INC_SWNUMBERTREE_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Gsoc 2020

2020-01-26 Thread Kaganski Mike

Hi!

On 2020-01-26 20:18, Ilmari Lauhakangas wrote:
> You could try
> --with-jdk-home=/cygdrive/c/Program Files/Java/jdk-13.0.1

In cygwin, I usually use forward-slash paths, which are perfectly-valid 
cygwin paths, like

--with-jdk-home=C:/Program Files/Java/jdk-13.0.1

-- 
Best regards,
Mike Kaganski
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: connectivity/source

2020-01-26 Thread Canberk TURAN (via logerrit)

 connectivity/source/inc/calc/CTables.hxx |5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

New commits:
commit e337f5b20430e52ef99923a475d05a1191506d21
Author: Canberk TURAN 
AuthorDate: Sat Jan 25 14:59:25 2020 +0300
Commit: Muhammet Kara 
CommitDate: Sun Jan 26 20:32:26 2020 +0100

tdf#124176: Use pragma once instead of include guards

Change-Id: I138b35bab9f4844e6fe1cac9a5c74c2e55d6680b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87382
Tested-by: Jenkins
Reviewed-by: Muhammet Kara 

diff --git a/connectivity/source/inc/calc/CTables.hxx 
b/connectivity/source/inc/calc/CTables.hxx
index 94d28bdd5478..65c7135f0981 100644
--- a/connectivity/source/inc/calc/CTables.hxx
+++ b/connectivity/source/inc/calc/CTables.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_CONNECTIVITY_SOURCE_INC_CALC_CTABLES_HXX
-#define INCLUDED_CONNECTIVITY_SOURCE_INC_CALC_CTABLES_HXX
+#pragma once
 
 #include 
 
@@ -40,6 +39,4 @@ namespace connectivity
 }
 }
 
-#endif // INCLUDED_CONNECTIVITY_SOURCE_INC_CALC_CTABLES_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sd/inc

2020-01-26 Thread Mehmet Emin Başoğlu (via logerrit)

 sd/inc/sdresid.hxx |5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

New commits:
commit 20b5c03ae6406a64ffec328e550fd3c9b3f0306c
Author: Mehmet Emin Başoğlu 
AuthorDate: Sat Jan 25 14:58:36 2020 +0300
Commit: Muhammet Kara 
CommitDate: Sun Jan 26 20:29:14 2020 +0100

tdf#124176: Use pragma once instead of include guards

Change-Id: Iaf87f70db32bcdb9ae079732e931b4c80879e247
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87383
Tested-by: Jenkins
Reviewed-by: Muhammet Kara 

diff --git a/sd/inc/sdresid.hxx b/sd/inc/sdresid.hxx
index 8ac4ea45405e..20254c0979fb 100644
--- a/sd/inc/sdresid.hxx
+++ b/sd/inc/sdresid.hxx
@@ -17,14 +17,11 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_SD_INC_SDRESID_HXX
-#define INCLUDED_SD_INC_SDRESID_HXX
+#pragma once
 
 #include 
 #include "sddllapi.h"
 
 SD_DLLPUBLIC OUString SdResId(const char* pId);
 
-#endif /* _SD_SDRESID_HXX */
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/LibreOfficeKit include/registry include/rtl include/sfx2 include/svx

2020-01-26 Thread iakarsu (via logerrit)

 include/LibreOfficeKit/LibreOfficeKit.hxx |5 +
 include/registry/registry.hxx |6 +-
 include/rtl/strbuf.hxx|6 +-
 include/sfx2/sfxbasemodel.hxx |5 +
 include/svx/msdffdef.hxx  |5 +
 5 files changed, 5 insertions(+), 22 deletions(-)

New commits:
commit 9accb3c4b5e1861d9a03c655242da5b629f5a6d6
Author: iakarsu 
AuthorDate: Sat Jan 25 16:21:43 2020 +0300
Commit: Muhammet Kara 
CommitDate: Sun Jan 26 20:27:42 2020 +0100

tdf#124176: Use pragma once instead of include guards

Change-Id: I6a7f7711fa931657dd97c9c0bc1bdce671b69b7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87405
Tested-by: Jenkins
Reviewed-by: Muhammet Kara 

diff --git a/include/LibreOfficeKit/LibreOfficeKit.hxx 
b/include/LibreOfficeKit/LibreOfficeKit.hxx
index 19f0b2663552..28a603e02203 100644
--- a/include/LibreOfficeKit/LibreOfficeKit.hxx
+++ b/include/LibreOfficeKit/LibreOfficeKit.hxx
@@ -7,8 +7,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#ifndef INCLUDED_LIBREOFFICEKIT_LIBREOFFICEKIT_HXX
-#define INCLUDED_LIBREOFFICEKIT_LIBREOFFICEKIT_HXX
+#pragma once
 
 #include 
 
@@ -972,6 +971,4 @@ inline Office* lok_cpp_init(const char* pInstallPath, const 
char* pUserProfileUr
 
 }
 
-#endif // INCLUDED_LIBREOFFICEKIT_LIBREOFFICEKIT_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/registry/registry.hxx b/include/registry/registry.hxx
index 9e264f4a30bd..c71e7dc804c4 100644
--- a/include/registry/registry.hxx
+++ b/include/registry/registry.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_REGISTRY_REGISTRY_HXX
-#define INCLUDED_REGISTRY_REGISTRY_HXX
+#pragma once
 
 #include 
 #include 
@@ -1055,7 +1054,4 @@ inline RegError Registry::mergeKey(RegistryKey& rKey,
  bool bReport)
 {  return m_pApi->mergeKey(m_hImpl, rKey.m_hImpl, keyName.pData, 
regFileName.pData, false/*bWarnings*/, bReport); }
 
-
-#endif
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/rtl/strbuf.hxx b/include/rtl/strbuf.hxx
index 3be06a31e120..780f00dddbb5 100644
--- a/include/rtl/strbuf.hxx
+++ b/include/rtl/strbuf.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_RTL_STRBUF_HXX
-#define INCLUDED_RTL_STRBUF_HXX
+#pragma once
 
 #include "sal/config.h"
 
@@ -1068,7 +1067,4 @@ typedef rtlunittest::OStringBuffer OStringBuffer;
 using ::rtl::OStringBuffer;
 #endif
 
-#endif // INCLUDED_RTL_STRBUF_HXX
-
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/sfx2/sfxbasemodel.hxx b/include/sfx2/sfxbasemodel.hxx
index 7d3be53fd515..3dbdb80c3aff 100644
--- a/include/sfx2/sfxbasemodel.hxx
+++ b/include/sfx2/sfxbasemodel.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_SFX2_SFXBASEMODEL_HXX
-#define INCLUDED_SFX2_SFXBASEMODEL_HXX
+#pragma once
 
 #include 
 #include 
@@ -745,6 +744,4 @@ private:
 
 } ; // class SfxBaseModel
 
-#endif // INCLUDED_SFX2_SFXBASEMODEL_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/svx/msdffdef.hxx b/include/svx/msdffdef.hxx
index b722e95be8b3..373974e67b31 100644
--- a/include/svx/msdffdef.hxx
+++ b/include/svx/msdffdef.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_SVX_MSDFFDEF_HXX
-#define INCLUDED_SVX_MSDFFDEF_HXX
+#pragma once
 
 #include 
 #include 
@@ -856,6 +855,4 @@ enum MSO_TextGeometryProperties {
 //ALT_TXT_MSINTEROP
 #define MSPROP_DESCRIPTION_MAX_LEN  4096
 
-#endif
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/svx include/ucbhelper include/unotools include/vcl

2020-01-26 Thread Mehmet Emin Başoğlu (via logerrit)

 include/svx/zoom_def.hxx |5 +
 include/ucbhelper/authenticationfallback.hxx |5 +
 include/unotools/docinfohelper.hxx   |5 +
 include/vcl/IContext.hxx |5 +
 include/vcl/sound.hxx|5 +
 5 files changed, 5 insertions(+), 20 deletions(-)

New commits:
commit 34330368088109fd140cad345f3de1077d195ddd
Author: Mehmet Emin Başoğlu 
AuthorDate: Sat Jan 25 16:23:02 2020 +0300
Commit: Muhammet Kara 
CommitDate: Sun Jan 26 20:10:59 2020 +0100

tdf#124176: Use pragma once instead of include guards

Change-Id: I045ce53c74bfb24be77537986fb5a8fcad3ed173
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87401
Tested-by: Jenkins
Reviewed-by: Muhammet Kara 

diff --git a/include/svx/zoom_def.hxx b/include/svx/zoom_def.hxx
index 0289805e0e50..e75dd9a27ac3 100644
--- a/include/svx/zoom_def.hxx
+++ b/include/svx/zoom_def.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_SVX_ZOOM_DEF_HXX
-#define INCLUDED_SVX_ZOOM_DEF_HXX
+#pragma once
 
 enum class ZoomButtonId
 {
@@ -28,6 +27,4 @@ enum class ZoomButtonId
 WHOLEPAGE   = 0x0004,
 };
 
-#endif
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/ucbhelper/authenticationfallback.hxx 
b/include/ucbhelper/authenticationfallback.hxx
index 171ebb7fe15f..a2634b06069b 100644
--- a/include/ucbhelper/authenticationfallback.hxx
+++ b/include/ucbhelper/authenticationfallback.hxx
@@ -7,8 +7,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#ifndef INCLUDED_UCBHELPER_AUTHENTICATIONFALLBACK_HXX
-#define INCLUDED_UCBHELPER_AUTHENTICATIONFALLBACK_HXX
+#pragma once
 
 #include 
 #include 
@@ -46,6 +45,4 @@ public:
 
 } // namespace ucbhelper
 
-#endif /* ! INCLUDED_UCBHELPER_AUTHENTICATIONFALLBACK_HXX*/
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/unotools/docinfohelper.hxx 
b/include/unotools/docinfohelper.hxx
index ddc28b05279b..081bc3660c97 100644
--- a/include/unotools/docinfohelper.hxx
+++ b/include/unotools/docinfohelper.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_UNOTOOLS_DOCINFOHELPER_HXX
-#define INCLUDED_UNOTOOLS_DOCINFOHELPER_HXX
+#pragma once
 
 #include 
 #include 
@@ -34,6 +33,4 @@ public:
 
 }   // namespace utl
 
-#endif // INCLUDED_UNOTOOLS_DOCINFOHELPER_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/vcl/IContext.hxx b/include/vcl/IContext.hxx
index 532242f213e5..6af9b20c4453 100644
--- a/include/vcl/IContext.hxx
+++ b/include/vcl/IContext.hxx
@@ -7,8 +7,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#ifndef INCLUDED_VCL_ICONTEXT_HXX
-#define INCLUDED_VCL_ICONTEXT_HXX
+#pragma once
 
 #include 
 #include 
@@ -46,6 +45,4 @@ private:
 
 } // namespace vcl
 
-#endif // INCLUDED_VCL_ICONTEXT_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/include/vcl/sound.hxx b/include/vcl/sound.hxx
index 84d3d25c4e35..2df3c800442e 100644
--- a/include/vcl/sound.hxx
+++ b/include/vcl/sound.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_VCL_SOUND_HXX
-#define INCLUDED_VCL_SOUND_HXX
+#pragma once
 
 #include 
 
@@ -29,6 +28,4 @@ public:
 static void Beep();
 };
 
-#endif // INCLUDED_VCL_SOUND_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/basegfx

2020-01-26 Thread Pelin Kuran (via logerrit)

 include/basegfx/numeric/ftools.hxx |5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

New commits:
commit c37d56c6cd161fd67e5aae917dc248f373df7767
Author: Pelin Kuran 
AuthorDate: Sat Jan 25 15:22:34 2020 +0300
Commit: Muhammet Kara 
CommitDate: Sun Jan 26 19:59:24 2020 +0100

tdf#124176: Use pragma once instead of header guard

Change-Id: I55ca953de1d0c4eea1df802e66b0c8d9468d5126
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87381
Reviewed-by: Muhammet Kara 
Tested-by: Muhammet Kara 

diff --git a/include/basegfx/numeric/ftools.hxx 
b/include/basegfx/numeric/ftools.hxx
index 91fc7bfb5722..a272cb76b22c 100644
--- a/include/basegfx/numeric/ftools.hxx
+++ b/include/basegfx/numeric/ftools.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_BASEGFX_NUMERIC_FTOOLS_HXX
-#define INCLUDED_BASEGFX_NUMERIC_FTOOLS_HXX
+#pragma once
 
 #include 
 #include 
@@ -231,6 +230,4 @@ namespace basegfx
 };
 } // end of namespace basegfx
 
-#endif // INCLUDED_BASEGFX_NUMERIC_FTOOLS_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

 sw/source/core/text/frminf.cxx |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit ed3f2312b08e93daec613bf5fa8bbb07a56cefc7
Author: Stephan Bergmann 
AuthorDate: Sun Jan 26 15:06:16 2020 +0100
Commit: Stephan Bergmann 
CommitDate: Sun Jan 26 19:39:48 2020 +0100

Avoid explicit cast to smaller sal_uInt16 from larger long

...in what might be an attempt to avoid warnings about signed vs. unsigned
comparisons.

Change-Id: I43f3efdbd93d1bc9a51ea89ac4a728fc68205379
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87449
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sw/source/core/text/frminf.cxx b/sw/source/core/text/frminf.cxx
index 3d6234e6e1de..ac25d9d1c1b4 100644
--- a/sw/source/core/text/frminf.cxx
+++ b/sw/source/core/text/frminf.cxx
@@ -17,6 +17,10 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
+#include 
+
+#include 
+
 #include 
 #include "itrtxt.hxx"
 
@@ -78,7 +82,7 @@ bool SwTextFrameInfo::IsFilled( const sal_uInt8 nPercent ) 
const
 long nWidth = pFrame->getFramePrintArea().Width();
 nWidth *= nPercent;
 nWidth /= 100;
-return sal_uInt16(nWidth) <= pLay->Width();
+return o3tl::make_unsigned(nWidth) <= pLay->Width();
 }
 
 // Where does the text start (without whitespace)? (document global)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: reportdesign/source

 reportdesign/source/ui/report/ReportSection.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 32922b3f1fc47415b40a701345a76a33e2d69a64
Author: Stephan Bergmann 
AuthorDate: Sun Jan 26 15:15:23 2020 +0100
Commit: Stephan Bergmann 
CommitDate: Sun Jan 26 19:39:22 2020 +0100

iAvoid explicit casts to smaller sal_uInt32 from larger long

...in what might be attempts to avoid warnings about signed vs. unsigned
comparisons.

Change-Id: I0e689d8b730170f35107cbdf46c3d8cd9a593367
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87456
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/reportdesign/source/ui/report/ReportSection.cxx 
b/reportdesign/source/ui/report/ReportSection.cxx
index 84236084c00d..7991fea3f1b5 100644
--- a/reportdesign/source/ui/report/ReportSection.cxx
+++ b/reportdesign/source/ui/report/ReportSection.cxx
@@ -276,7 +276,7 @@ void OReportSection::Paste(const uno::Sequence< 
beans::NamedValue >& _aAllreadyC
 }
 m_pView->AddUndo( 
m_pView->GetModel()->GetSdrUndoFactory().CreateUndoNewObject( *pNewObj ) );
 m_pView->MarkObj( pNewObj, 
m_pView->GetSdrPageView() );
-if ( m_xSection.is() && 
(static_cast(aRet.getHeight() + aRet.Top()) > 
m_xSection->getHeight()) )
+if ( m_xSection.is() && 
(o3tl::make_unsigned(aRet.getHeight() + aRet.Top()) > m_xSection->getHeight()) )
 m_xSection->setHeight(aRet.getHeight() + 
aRet.Top());
 }
 }
@@ -540,7 +540,7 @@ void 
OReportSection::impl_adjustObjectSizePosition(sal_Int32 i_nPaperWidth,sal_I
 tools::Rectangle 
aRet(VCLPoint(xReportComponent->getPosition()),VCLSize(xReportComponent->getSize()));
 aRet.setHeight(aRet.getHeight() + 1);
 aRet.setWidth(aRet.getWidth() + 1);
-if ( m_xSection.is() && 
(static_cast(aRet.getHeight() + aRet.Top()) > 
m_xSection->getHeight()) )
+if ( m_xSection.is() && 
(o3tl::make_unsigned(aRet.getHeight() + aRet.Top()) > m_xSection->getHeight()) )
 m_xSection->setHeight(aRet.getHeight() + aRet.Top());
 
 pObject->RecalcBoundRect();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

 sw/source/uibase/ribbar/inputwin.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 04404a2edd1121f518ff28bebdd74b45df228280
Author: Stephan Bergmann 
AuthorDate: Sun Jan 26 15:07:40 2020 +0100
Commit: Stephan Bergmann 
CommitDate: Sun Jan 26 19:38:47 2020 +0100

Avoid explicit cast to smaller sal_uInt16 from larger long

...in what might be an attempt to avoid warnings about signed vs. unsigned
comparisons.

Change-Id: I19be3cc0510b8628e961d840f51b0c9480aee746
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87450
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sw/source/uibase/ribbar/inputwin.cxx 
b/sw/source/uibase/ribbar/inputwin.cxx
index cc1bc1705050..47e551f69c8e 100644
--- a/sw/source/uibase/ribbar/inputwin.cxx
+++ b/sw/source/uibase/ribbar/inputwin.cxx
@@ -21,6 +21,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -527,7 +528,7 @@ void InputEdit::UpdateRange(const OUString& rBoxes,
 ++nEndPos;
 }
 // Only if the current position lies in the range or right behind.
-if( bFound && !( nStartPos < 
static_cast(aSelection.Max()) &&
+if( bFound && !( nStartPos < o3tl::make_unsigned(aSelection.Max()) 
&&
  static_cast(aSelection.Max()) <= 
nEndPos + 1 ))
 bFound = false;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: help in writing tests

2020-01-26 Thread Regina Henschel


Hi Shivam,

Shivam Kumar Singh schrieb am 26-Jan-20 um 18:24:



Also ,  tdf123684 is very similar to tdf123841 , Check for an object and 
inspect

its style to be FillStyle_NONE, I used the code and have submitted a patch
https://gerrit.libreoffice.org/c/core/+/87440
and here is the build
https://ci.libreoffice.org/job/gerrit_master/48393/
I may be wrong in both the approaches.
Please have a look , and suggest me furthur steps.


Do you have tested, that the test fails, if your original patch is not 
applied?


The problem in the bug report was, that someone changed the values of 
the properties of the default styles in core. The default styles in core 
are used, if a new document is generated. If the document is then saved, 
all values are inside the stored file. And from now on these values are 
used.


Therefore it makes no sense to load an existing document. It will have 
whatever was current, when the document was saved. You need to generate 
a new document and inspect the style "Object without fill".


If you use the document directly, a  
gives you access to the styles.


Miklos suggestion was, not to use the document directly, but insert a 
shape and inspect the shape then. But his proposal starts with "create a 
new document" too.


So the way to go is, first try to create a new document.

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: solenv/sanitizers

2020-01-26 Thread Caolán McNamara (via logerrit)

 solenv/sanitizers/ui/modules/swriter.suppr |5 -
 1 file changed, 5 deletions(-)

New commits:
commit eb5e995bdbcd388371bc0653bcdeae73747f51bf
Author: Caolán McNamara 
AuthorDate: Sun Jan 26 16:39:01 2020 +
Commit: Caolán McNamara 
CommitDate: Sun Jan 26 18:52:29 2020 +0100

drop unused suppression

Change-Id: I98cd7f7075476c69ae6ed1646d17a43dc7a05c89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87458
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/solenv/sanitizers/ui/modules/swriter.suppr 
b/solenv/sanitizers/ui/modules/swriter.suppr
index 47348e2d58af..bbe52698d3b0 100644
--- a/solenv/sanitizers/ui/modules/swriter.suppr
+++ b/solenv/sanitizers/ui/modules/swriter.suppr
@@ -121,11 +121,6 @@ 
sw/uiconfig/swriter/ui/numparapage.ui://GtkCheckButton[@id='checkCB_NUMBER_NEW_S
 sw/uiconfig/swriter/ui/numberingnamedialog.ui://GtkEntry[@id='entry'] 
no-labelled-by
 sw/uiconfig/swriter/ui/optcomparison.ui://GtkSpinButton[@id='ignorelen'] 
no-labelled-by
 sw/uiconfig/swriter/ui/optfonttabpage.ui://GtkLabel[@id='font_label'] 
orphan-label
-sw/uiconfig/swriter/ui/optformataidspage.ui:GtkBox[@id='OptFormatAidsPage']/GtkGrid[@id='grid1']/GtkBox[@id='box2']/GtkFrame[@id='frame1']/GtkAlignment[@id='alignment1']/GtkGrid[@id='grid2']/GtkLabel
 orphan-label
-sw/uiconfig/swriter/ui/optformataidspage.ui:GtkBox[@id='OptFormatAidsPage']/GtkGrid[@id='grid1']/GtkBox[@id='box2']/GtkFrame[@id='frame1']/GtkAlignment[@id='alignment1']/GtkGrid[@id='grid2']/GtkLabel
 orphan-label
-sw/uiconfig/swriter/ui/optformataidspage.ui:GtkBox[@id='OptFormatAidsPage']/GtkGrid[@id='grid1']/GtkBox[@id='box2']/GtkFrame[@id='frame1']/GtkAlignment[@id='alignment1']/GtkGrid[@id='grid2']/GtkLabel
 orphan-label
-sw/uiconfig/swriter/ui/optformataidspage.ui:GtkBox[@id='OptFormatAidsPage']/GtkGrid[@id='grid1']/GtkBox[@id='box2']/GtkFrame[@id='frame1']/GtkAlignment[@id='alignment1']/GtkGrid[@id='grid2']/GtkLabel
 orphan-label
-sw/uiconfig/swriter/ui/optformataidspage.ui:GtkBox[@id='OptFormatAidsPage']/GtkGrid[@id='grid1']/GtkBox[@id='box2']/GtkFrame[@id='frame1']/GtkAlignment[@id='alignment1']/GtkGrid[@id='grid2']/GtkLabel
 orphan-label
 sw/uiconfig/swriter/ui/opttablepage.ui://GtkLabel[@id='label10'] orphan-label
 sw/uiconfig/swriter/ui/opttablepage.ui://GtkLabel[@id='label11'] orphan-label
 sw/uiconfig/swriter/ui/opttablepage.ui://GtkLabel[@id='label12'] orphan-label
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: help in writing tests

2020-01-26 Thread Shivam Kumar Singh

Hi Regina ,Miklos, all,

Thanks for the great help and the code pointers .
I tried to modify the code from SdImportTest::testTdf97808() in
sd/qa/unit/import-tests.cxx.
In the code for tdf97808 a line is inspected and using the property
getPropertyValue("Style") it was checked if it is equal to the
property "objectwithoutfill" .
Observing a few more tests I replaced XLine with Xshape  and compared for
"Style"

uno::Reference xLine(
  xPage->getByIndex(0), uno::UNO_QUERY_THROW);
uno::Reference xParent;
CPPUNIT_ASSERT(xLine->getPropertyValue("Style") >>= xParent);
CPPUNIT_ASSERT_EQUAL(xStyle, xParent);

to

uno::Reference< drawing::XShape > xShape(
xPage->getByIndex(0), uno::UNO_QUERY_THROW );
uno::Reference xParent;
CPPUNIT_ASSERT(xShape->getPropertyValue("Style") >>= xParent);
CPPUNIT_ASSERT_EQUAL(xStyle, xParent);

but xShape does not have getPropertyValue("") method hence the build failed
.
Can we do some modification to xShape ?
Maybe changing the method or something

Also ,  tdf123684 is very similar to tdf123841 , Check for an object and
inspect
its style to be FillStyle_NONE, I used the code and have submitted a patch
https://gerrit.libreoffice.org/c/core/+/87440
and here is the build
 https://ci.libreoffice.org/job/gerrit_master/48393/
I may be wrong in both the approaches.
Please have a look , and suggest me furthur steps.

SIncerely ,
Shivam

On Thu, 23 Jan 2020 at 16:23, Regina Henschel 
wrote:

>
> > I had some private mails with Shivam. I have suggested to create a new
> > document and verify, that the default style has filling NONE.
>
> default style --> style, which is "Object without fill" in the UI
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: help in writing tests

2020-01-26 Thread Shivam Kumar Singh

Hi Regina ,Miklos, all,

Thanks for the great help and the code pointers .
I tried to modify the code from SdImportTest::testTdf97808() in
sd/qa/unit/import-tests.cxx.
In the code for tdf97808 a line is inspected and using the property
getPropertyValue("Style") it was checked if it is equal to the
property "objectwithoutfill" .
Observing a few more tests I replaced XLine with Xshape  and compared for
"Style"

uno::Reference xLine(
  xPage->getByIndex(0), uno::UNO_QUERY_THROW);
uno::Reference xParent;
CPPUNIT_ASSERT(xLine->getPropertyValue("Style") >>= xParent);
CPPUNIT_ASSERT_EQUAL(xStyle, xParent);

to

uno::Reference< drawing::XShape > xShape(
xPage->getByIndex(0), uno::UNO_QUERY_THROW );
uno::Reference xParent;
CPPUNIT_ASSERT(xShape->getPropertyValue("Style") >>= xParent);
CPPUNIT_ASSERT_EQUAL(xStyle, xParent);

but xShape does not have getPropertyValue("") method hence the build failed
.
Can we do some modification to xShape ?
Maybe changing the method or something

Also ,  tdf123684 is very similar to tdf123841 , Check for an object and
inspect
its style to be FillStyle_NONE, I used the code and have submitted a patch
https://gerrit.libreoffice.org/c/core/+/87440
and here is the build
 https://ci.libreoffice.org/job/gerrit_master/48393/
I may be wrong in both the approaches.
Please have a look , and suggest me furthur steps.

SIncerely ,
Shivam

On Thu, 23 Jan 2020 at 16:23, Regina Henschel 
wrote:

>
> > I had some private mails with Shivam. I have suggested to create a new
> > document and verify, that the default style has filling NONE.
>
> default style --> style, which is "Object without fill" in the UI
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Gsoc 2020

2020-01-26 Thread Ilmari Lauhakangas


You could try
--with-jdk-home=/cygdrive/c/Program Files/Java/jdk-13.0.1

or if you have no use for Java, you could also simply use

--without-java

Ilmari

anshu khare kirjoitti 26.1.2020 klo 19.05:

My path for JDK is C:/Program Files/Java/jdk-13.0.1/bin/javac.exe

I am sure on how should I write this path on cygwin shell.
Could you please help me with it?


On Sun, 26 Jan, 2020, 9:50 PM Ilmari Lauhakangas, 
> wrote:


You forgot to give a path with --with-jdk-home, so it is tripping on
the
emptiness.

Ilmari

anshu khare kirjoitti 26.1.2020 klo 17.19:
 > When I run  ./autogen.sh --with-visual-studio=2019
--with-jdk-home , it
 > gives following output
 >
 > 
 > *
 > *   Using commandline arguments and ignoring autogen.input!
 > *
 > 
 > Running ./configure with '--with-visual-studio=2019 --with-jdk-home
 > --srcdir=/home/hp/lode/dev/core --enable-option-checking=fatal'
 > 
 > *
 > *   Running LibreOffice build configuration.
 > *
 > 
 >
 > checking build system type... x86_64-pc-cygwin
 > checking host system type... x86_64-pc-cygwin
 > checking for product name... LibreOfficeDev
 > checking for package version... 7.0.0.0.alpha0+
 > checking for product version... 7.0
 > checking for grep that handles long lines and -e... /usr/bin/grep
 > checking for egrep... /usr/bin/grep -E
 > checking for grep... (cached) /usr/bin/grep
 > checking for GNU Make... /usr/bin/make
 > checking for explicit COMSPEC... found: C:\Windows\system32\cmd.exe
 > checking for sed... /usr/bin/sed
 > checking whether to use link-time optimization... no
 > checking for explicit AFLAGS... no
 > checking for explicit CFLAGS... no
 > checking for explicit CXXFLAGS... no
 > checking for explicit OBJCFLAGS... no
 > checking for explicit OBJCXXFLAGS... no
 > checking for explicit LDFLAGS... no
 > checking whether build target is Release Build... no
 > checking whether to sign windows build... no
 > checking for gawk... gawk
 > checking for gawk... /usr/bin/gawk
 > checking for bash... /bin/sh
 > checking for GNU or BSD tar... tar
 > checking for tar's option to strip components... --strip-components
 > checking how to build and package galleries... internal src
images for
 > desktop
 > checking whether to build with Java support... yes
 > checking whether to treat the installation as read-only... no
 > checking whether to build a 64-bit LibreOffice... no
 > checking Visual C++... C:/PROGRA~2/MICROS~2/2019/COMMUN~1/VC
 > checking for short pathname of VC product directory...
 > /cygdrive/c/PROGRA~2/MICROS~2/2019/COMMUN~1/VC
 > checking for UCRT location... found
 > checking for MSBuild.exe location for: 16.0...
 > /cygdrive/c/PROGRA~2/MICROS~2/2019/COMMUN~1/VC/../MSBuild/Current/Bin
 > checking cl.exe... found Visual C++ 2019
 >

(/cygdrive/c/PROGRA~2/MICROS~2/2019/COMMUN~1/VC/Tools/MSVC/1424~1.283/bin/HostX64/x86/cl.exe)
 > checking cl.exe is at least Visual Studio 2017 version 15.7... yes
 > checking for a x64 compiler and libraries for 64-bit Explorer
 > extensions... found
 > checking whether the compiler is actually Clang... no
 > checking the dependency generation prefix (cl.exe -showIncludes)...
 > "Note: including file:"
 > checking whether to build with additional debug utilities... no
 > checking whether to do a debug build... no
 > checking whether to generate debug information... no
 > checking whether to compile with optimization flags... yes
 > checking which package format to use... none
 > checking syslog.h usability... no
 > checking syslog.h presence... no
 > checking for syslog.h... no
 > checking whether to turn warnings to errors... no
 > checking whether to have assert() failures abort even without
 > --enable-debug... no
 > checking whether to enable CUPS support... no
 > checking whether we want to fetch tarballs... yes, if we use them
 > checking whether to build help... no
 > checking whether to enable xapian-omega support for help... no
 > checking whether to include MySpell dictionaries... no
 > checking whether to use dicts from external paths... no
 > checking whether to enable pch feature... yes (full)
 > checking whether
 >

/cygdrive/c/PROGRA~2/MICROS~2/2019/COMMUN~1/VC/Tools/MSVC/1424~1.283/bin/HostX64/x86/cl.exe

 > -arch:SSE supports -Xclang -building-pch-with-obj... no
 > checking the GNU Make version... /usr/bin/make 4.2.1
 > checkin

Re: Gsoc 2020

My path for JDK is C:/Program Files/Java/jdk-13.0.1/bin/javac.exe

I am sure on how should I write this path on cygwin shell.
Could you please help me with it?


On Sun, 26 Jan, 2020, 9:50 PM Ilmari Lauhakangas, <
ilmari.lauhakan...@libreoffice.org> wrote:

> You forgot to give a path with --with-jdk-home, so it is tripping on the
> emptiness.
>
> Ilmari
>
> anshu khare kirjoitti 26.1.2020 klo 17.19:
> > When I run  ./autogen.sh --with-visual-studio=2019 --with-jdk-home , it
> > gives following output
> >
> > 
> > *
> > *   Using commandline arguments and ignoring autogen.input!
> > *
> > 
> > Running ./configure with '--with-visual-studio=2019 --with-jdk-home
> > --srcdir=/home/hp/lode/dev/core --enable-option-checking=fatal'
> > 
> > *
> > *   Running LibreOffice build configuration.
> > *
> > 
> >
> > checking build system type... x86_64-pc-cygwin
> > checking host system type... x86_64-pc-cygwin
> > checking for product name... LibreOfficeDev
> > checking for package version... 7.0.0.0.alpha0+
> > checking for product version... 7.0
> > checking for grep that handles long lines and -e... /usr/bin/grep
> > checking for egrep... /usr/bin/grep -E
> > checking for grep... (cached) /usr/bin/grep
> > checking for GNU Make... /usr/bin/make
> > checking for explicit COMSPEC... found: C:\Windows\system32\cmd.exe
> > checking for sed... /usr/bin/sed
> > checking whether to use link-time optimization... no
> > checking for explicit AFLAGS... no
> > checking for explicit CFLAGS... no
> > checking for explicit CXXFLAGS... no
> > checking for explicit OBJCFLAGS... no
> > checking for explicit OBJCXXFLAGS... no
> > checking for explicit LDFLAGS... no
> > checking whether build target is Release Build... no
> > checking whether to sign windows build... no
> > checking for gawk... gawk
> > checking for gawk... /usr/bin/gawk
> > checking for bash... /bin/sh
> > checking for GNU or BSD tar... tar
> > checking for tar's option to strip components... --strip-components
> > checking how to build and package galleries... internal src images for
> > desktop
> > checking whether to build with Java support... yes
> > checking whether to treat the installation as read-only... no
> > checking whether to build a 64-bit LibreOffice... no
> > checking Visual C++... C:/PROGRA~2/MICROS~2/2019/COMMUN~1/VC
> > checking for short pathname of VC product directory...
> > /cygdrive/c/PROGRA~2/MICROS~2/2019/COMMUN~1/VC
> > checking for UCRT location... found
> > checking for MSBuild.exe location for: 16.0...
> > /cygdrive/c/PROGRA~2/MICROS~2/2019/COMMUN~1/VC/../MSBuild/Current/Bin
> > checking cl.exe... found Visual C++ 2019
> >
> (/cygdrive/c/PROGRA~2/MICROS~2/2019/COMMUN~1/VC/Tools/MSVC/1424~1.283/bin/HostX64/x86/cl.exe)
> > checking cl.exe is at least Visual Studio 2017 version 15.7... yes
> > checking for a x64 compiler and libraries for 64-bit Explorer
> > extensions... found
> > checking whether the compiler is actually Clang... no
> > checking the dependency generation prefix (cl.exe -showIncludes)...
> > "Note: including file:"
> > checking whether to build with additional debug utilities... no
> > checking whether to do a debug build... no
> > checking whether to generate debug information... no
> > checking whether to compile with optimization flags... yes
> > checking which package format to use... none
> > checking syslog.h usability... no
> > checking syslog.h presence... no
> > checking for syslog.h... no
> > checking whether to turn warnings to errors... no
> > checking whether to have assert() failures abort even without
> > --enable-debug... no
> > checking whether to enable CUPS support... no
> > checking whether we want to fetch tarballs... yes, if we use them
> > checking whether to build help... no
> > checking whether to enable xapian-omega support for help... no
> > checking whether to include MySpell dictionaries... no
> > checking whether to use dicts from external paths... no
> > checking whether to enable pch feature... yes (full)
> > checking whether
> >
> /cygdrive/c/PROGRA~2/MICROS~2/2019/COMMUN~1/VC/Tools/MSVC/1424~1.283/bin/HostX64/x86/cl.exe
>
> > -arch:SSE supports -Xclang -building-pch-with-obj... no
> > checking the GNU Make version... /usr/bin/make 4.2.1
> > checking whether GNU Make supports the 'file' function... yes
> > checking for --hash-style gcc linker support... no
> > checking for perl... /usr/bin/perl
> > checking the Perl version... Perl 5
> > checking for required Perl modules... all modules found
> > checking for Windows SDK... found Windows SDK 10.0
> > (/cygdrive/c/PROGRA~2/WI3CF2~1/10)
> > checking for midl.exe... C:\Program Files (x86)\Windows
> > Kits\10\/Bin/10.0.18362.0/x86/midl.exe
> > checking for csc.exe...
> > C:\W

[Libreoffice-commits] core.git: sw/source

 sw/source/core/docnode/ndtbl1.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit a2f90ebd9a96d869d7417507f41284d739197d3e
Author: Stephan Bergmann 
AuthorDate: Sun Jan 26 15:04:40 2020 +0100
Commit: Stephan Bergmann 
CommitDate: Sun Jan 26 17:49:24 2020 +0100

Avoid explicit cast to smaller sal_uInt16 from larger long

...in what might be an attempt to avoid warnings about signed vs. unsigned
comparisons.

Change-Id: Ie3aa77f099df19fc150271b17d06194005bfeec5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87448
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sw/source/core/docnode/ndtbl1.cxx 
b/sw/source/core/docnode/ndtbl1.cxx
index 05ca3c0b8133..4bf684197a90 100644
--- a/sw/source/core/docnode/ndtbl1.cxx
+++ b/sw/source/core/docnode/ndtbl1.cxx
@@ -48,6 +48,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using ::editeng::SvxBorderLine;
 using namespace ::com::sun::star;
@@ -1363,7 +1364,7 @@ static void lcl_CalcSubColValues( std::vector 
&rToFill, const SwTabC
 if ( nWidth && pCell->getFrameArea().Width() )
 {
 long nTmp = nWidth * nWish / pCell->getFrameArea().Width();
-if ( sal_uInt16(nTmp) > rToFill[i] )
+if ( o3tl::make_unsigned(nTmp) > rToFill[i] )
 rToFill[i] = sal_uInt16(nTmp);
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: dbaccess/source

 dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx |   11 ++-
 1 file changed, 6 insertions(+), 5 deletions(-)

New commits:
commit 3a5b8e039dcb6cfe68505de3440c4bcdaeb7a94a
Author: Stephan Bergmann 
AuthorDate: Sun Jan 26 14:59:23 2020 +0100
Commit: Stephan Bergmann 
CommitDate: Sun Jan 26 17:36:10 2020 +0100

Avoid explicit casts to smaller sal_uInt16 from larger int

...in what might be attempts to avoid warnings about signed vs. unsigned
comparisons.

Change-Id: I8eceaa989c35558e37cb815d997dda88d17c22b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87444
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx 
b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
index f0f383b126e2..7fd11331b640 100644
--- a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
+++ b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
@@ -40,6 +40,7 @@
 #include "QueryDesignFieldUndoAct.hxx"
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -289,7 +290,7 @@ void OSelectionBrowseBox::ColumnMoved( sal_uInt16 nColId, 
bool _bCreateUndo )
 // swap the two columns
 sal_uInt16 nNewPos = GetColumnPos( nColId );
 OTableFields& rFields = getFields();
-if ( rFields.size() > sal_uInt16(nNewPos-1) )
+if ( rFields.size() > o3tl::make_unsigned(nNewPos-1) )
 {
 sal_uInt16 nOldPos = 0;
 bool bFoundElem = false;
@@ -888,7 +889,7 @@ bool OSelectionBrowseBox::SaveModified()
 OQueryController& rController = 
static_cast(getDesignView()->getController());
 OTableFieldDescRef pEntry;
 sal_uInt16 nCurrentColumnPos = GetColumnPos(GetCurColumnId());
-if(getFields().size() > static_cast(nCurrentColumnPos - 1))
+if(getFields().size() > o3tl::make_unsigned(nCurrentColumnPos - 1))
 pEntry = getEntry(nCurrentColumnPos - 1);
 
 bool bWasEmpty  = pEntry.is() && pEntry->IsEmpty();
@@ -1213,7 +1214,7 @@ void OSelectionBrowseBox::PaintCell(OutputDevice& rDev, 
const tools::Rectangle&
 
 OTableFieldDescRef pEntry;
 sal_uInt16 nPos = GetColumnPos(nColumnId);
-if(getFields().size() > sal_uInt16(nPos - 1))
+if(getFields().size() > o3tl::make_unsigned(nPos - 1))
 pEntry = getFields()[nPos - 1];
 
 if (!pEntry.is())
@@ -1278,7 +1279,7 @@ void OSelectionBrowseBox::RemoveField(sal_uInt16 
nColumnId )
 OQueryController& rController = 
static_cast(getDesignView()->getController());
 
 sal_uInt16 nPos = GetColumnPos(nColumnId);
-OSL_ENSURE(getFields().size() > sal_uInt16(nPos-1),"ID is to great!");
+OSL_ENSURE(getFields().size() > o3tl::make_unsigned(nPos-1),"ID is to 
great!");
 
 OTableFieldDescRef pDesc = getEntry(static_cast(nPos - 1)) ;
 pDesc->SetColWidth( static_cast(GetColumnWidth(nColumnId)) );  
  // was not stored this before
@@ -2642,7 +2643,7 @@ void 
OSelectionBrowseBox::setFunctionCell(OTableFieldDescRef const & _pEntry)
 Reference< XAccessible > OSelectionBrowseBox::CreateAccessibleCell( sal_Int32 
_nRow, sal_uInt16 _nColumnPos )
 {
 OTableFieldDescRef pEntry;
-if(getFields().size() > sal_uInt16(_nColumnPos - 1))
+if(getFields().size() > o3tl::make_unsigned(_nColumnPos - 1))
 pEntry = getFields()[_nColumnPos - 1];
 
 if ( _nRow == BROW_VIS_ROW && pEntry.is() )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

 sc/source/filter/excel/xlescher.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit a7f50a30abd0ed51ca1fd053e1cc726558e00cb0
Author: Stephan Bergmann 
AuthorDate: Sun Jan 26 15:09:25 2020 +0100
Commit: Stephan Bergmann 
CommitDate: Sun Jan 26 17:34:35 2020 +0100

Use properly typed variable for iteration

Change-Id: Ifb81145c7238ef6b4916e0ef0984c9b868319aec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87451
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sc/source/filter/excel/xlescher.cxx 
b/sc/source/filter/excel/xlescher.cxx
index 45bcbbc753a8..8bbc1e397491 100644
--- a/sc/source/filter/excel/xlescher.cxx
+++ b/sc/source/filter/excel/xlescher.cxx
@@ -100,12 +100,12 @@ void lclGetRowFromY(
 long nTwipsY = static_cast< long >( nY / fScale + 0.5 );
 long nRowH = 0;
 bool bFound = false;
-for( SCROW nRow = static_cast< SCROW >( nXclStartRow ); 
static_cast(nRow) <= nXclMaxRow; ++nRow )
+for( sal_uInt32 nRow = nXclStartRow; nRow <= nXclMaxRow; ++nRow )
 {
 nRowH = rDoc.GetRowHeight( nRow, nScTab );
 if( rnStartH + nRowH > nTwipsY )
 {
-rnXclRow = static_cast< sal_uInt32 >( nRow );
+rnXclRow = nRow;
 bFound = true;
 break;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vbahelper/source

 vbahelper/source/msforms/vbacontrol.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 0288c8ffecff4956a52b9147d441979941e8b87f
Author: Stephan Bergmann 
AuthorDate: Sun Jan 26 15:10:03 2020 +0100
Commit: Stephan Bergmann 
CommitDate: Sun Jan 26 17:34:15 2020 +0100

Rephrase cast from sal_Int32 to sal_uInt32

...to avoid false positives with upcoming loplugin:unsignedcompare:

> vbahelper/source/msforms/vbacontrol.cxx:730:12: error: explicit cast from 
'sal_Int32' (aka 'int') to 'sal_uInt32' (aka 'unsigned int') (of equal rank) in 
comparison against 'sal_uInt32': if the cast value is known to be non-negative, 
use o3tl::make_unsigned instead of the cast [loplugin:unsignedcompare]
> if ( ( static_cast(nBackColor) >= sal_uInt32(0x8000) 
) &&
>^
> vbahelper/source/msforms/vbacontrol.cxx:731:12: error: explicit cast from 
'sal_Int32' (aka 'int') to 'sal_uInt32' (aka 'unsigned int') (of equal rank) in 
comparison against 'unsigned long': if the cast value is known to be 
non-negative, use o3tl::make_unsigned instead of the cast 
[loplugin:unsignedcompare]
>  ( static_cast(nBackColor) <= sal_uInt32(0x8000) 
+ SAL_N_ELEMENTS(nSysCols) ) )
>
^~~~

(This is the only case I found where the plugin's heuristics failed.)

Change-Id: I36d12caa0f837b8ba860eaf33b3e166a4f1001fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87454
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/vbahelper/source/msforms/vbacontrol.cxx 
b/vbahelper/source/msforms/vbacontrol.cxx
index 1e877c66d063..bcbbbdcd446e 100644
--- a/vbahelper/source/msforms/vbacontrol.cxx
+++ b/vbahelper/source/msforms/vbacontrol.cxx
@@ -727,10 +727,11 @@ sal_Int32 ScVbaControl::getBackColor()
 
 void ScVbaControl::setBackColor( sal_Int32 nBackColor )
 {
-if ( ( static_cast(nBackColor) >= sal_uInt32(0x8000) ) &&
- ( static_cast(nBackColor) <= sal_uInt32(0x8000) + 
SAL_N_ELEMENTS(nSysCols) ) )
+auto const col = static_cast(nBackColor);
+if ( ( col >= sal_uInt32(0x8000) ) &&
+ ( col <= sal_uInt32(0x8000) + SAL_N_ELEMENTS(nSysCols) ) )
 {
-nBackColor = nSysCols[ nBackColor & 0x0FF];
+nBackColor = nSysCols[ col & 0x0FF];
 }
 m_xProps->setPropertyValue( "BackgroundColor" , uno::makeAny( 
XLRGBToOORGB( nBackColor ) ) );
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Gsoc 2020

2020-01-26 Thread Ilmari Lauhakangas

You forgot to give a path with --with-jdk-home, so it is tripping on the
emptiness.

Ilmari

anshu khare kirjoitti 26.1.2020 klo 17.19:
When I run ./autogen.sh --with-visual-studio=2019 --with-jdk-home , it
gives following output

*
* Using commandline arguments and ignoring autogen.input!
*

Running ./configure with '--with-visual-studio=2019 --with-jdk-home
--srcdir=/home/hp/lode/dev/core --enable-option-checking=fatal'

*
* Running LibreOffice build configuration.
*

checking whether to build with Java support... yes
checking whether to treat the installation as read-only... no
checking whether to build a 64-bit LibreOffice... no
checking Visual C++... C:/PROGRA~2/MICROS~2/2019/COMMUN~1/VC
checking for short pathname of VC product directory...
/cygdrive/c/PROGRA~2/MICROS~2/2019/COMMUN~1/VC

checking for UCRT location... found
checking for MSBuild.exe location for: 16.0...
/cygdrive/c/PROGRA~2/MICROS~2/2019/COMMUN~1/VC/../MSBuild/Current/Bin
checking cl.exe... found Visual C++ 2019
(/cygdrive/c/PROGRA~2/MICROS~2/2019/COMMUN~1/VC/Tools/MSVC/1424~1.283/bin/HostX64/x86/cl.exe)

checking cl.exe is at least Visual Studio 2017 version 15.7... yes
checking for a x64 compiler and libraries for 64-bit Explorer
extensions... found

checking whether the compiler is actually Clang... no
checking the dependency generation prefix (cl.exe -showIncludes)...
"Note: including file:"

checking whether to build with additional debug utilities... no
checking whether to do a debug build... no
checking whether to generate debug information... no
checking whether to compile with optimization flags... yes
checking which package format to use... none
checking syslog.h usability... no
checking syslog.h presence... no
checking for syslog.h... no
checking whether to turn warnings to errors... no
checking whether to have assert() failures abort even without
--enable-debug... no

checking whether to enable CUPS support... no
checking whether we want to fetch tarballs... yes, if we use them
checking whether to build help... no
checking whether to enable xapian-omega support for help... no
checking whether to include MySpell dictionaries... no
checking whether to use dicts from external paths... no
checking whether to enable pch feature... yes (full)
checking whether
/cygdrive/c/PROGRA~2/MICROS~2/2019/COMMUN~1/VC/Tools/MSVC/1424~1.283/bin/HostX64/x86/cl.exe
-arch:SSE supports -Xclang -building-pch-with-obj... no

checking the GNU Make version... /usr/bin/make 4.2.1
checking whether GNU Make supports the 'file' function... yes
checking for --hash-style gcc linker support... no
checking for perl... /usr/bin/perl
checking the Perl version... Perl 5
checking for required Perl modules... all modules found
checking for Windows SDK... found Windows SDK 10.0
(/cygdrive/c/PROGRA~2/WI3CF2~1/10)
checking for midl.exe... C:\Program Files (x86)\Windows
Kits\10\/Bin/10.0.18362.0/x86/midl.exe
checking for csc.exe...
C:\Windows\Microsoft.NET\Framework\v4.0.30319\/csc.exe
checking for al.exe... C:\Program Files (x86)\Microsoft
SDKs\Windows\v10.0A\bin\NETFX 4.8 Tools\/al.exe

checking .NET Framework... found: C:/PROGRA~2/WI3CF2~1/NETFXSDK/4.8/
checking whether to enable runtime optimizations... yes
checking valgrind/valgrind.h usability... no
checking valgrind/valgrind.h presence... no
checking for valgrind/valgrind.h... no
checking sys/sdt.h usability... no
checking sys/sdt.h presence... no
checking for sys/sdt.h... no
checking what the C++ library is... Microsoft
checking for gperf... /usr/bin/gperf
checking whether gperf is ne

[Libreoffice-commits] core.git: include/svx svx/source

2020-01-26 Thread Caolán McNamara (via logerrit)

 include/svx/verttexttbxctrl.hxx |3 +++
 svx/source/tbxctrls/verttexttbxctrl.cxx |7 +++
 2 files changed, 10 insertions(+)

New commits:
commit 2f019777fbbd2a1f9821f5d19608cc2a36413d9d
Author: Caolán McNamara 
AuthorDate: Sat Jan 25 21:54:52 2020 +
Commit: Caolán McNamara 
CommitDate: Sun Jan 26 17:08:58 2020 +0100

restore fix of tdf#83320 Hide vertical text commands early

Change-Id: I738776028af90e2711418f922ff6e77a5cce14c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87423
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/include/svx/verttexttbxctrl.hxx b/include/svx/verttexttbxctrl.hxx
index 12498068c467..77471310707a 100644
--- a/include/svx/verttexttbxctrl.hxx
+++ b/include/svx/verttexttbxctrl.hxx
@@ -43,6 +43,9 @@ public:
 
 virtual ~SvxVertCTLTextTbxCtrl() override;
 
+// XInitialization
+virtual void SAL_CALL initialize(const css::uno::Sequence& 
rArguments) override;
+
 // XServiceInfo
 virtual OUString SAL_CALL getImplementationName() override = 0;
 virtual sal_Bool SAL_CALL supportsService( const OUString& ServiceName ) 
override;
diff --git a/svx/source/tbxctrls/verttexttbxctrl.cxx 
b/svx/source/tbxctrls/verttexttbxctrl.cxx
index 7fbb87c245d7..2176ae8b6362 100644
--- a/svx/source/tbxctrls/verttexttbxctrl.cxx
+++ b/svx/source/tbxctrls/verttexttbxctrl.cxx
@@ -74,6 +74,13 @@ SvxVertCTLTextTbxCtrl::~SvxVertCTLTextTbxCtrl( )
 {
 }
 
+void SAL_CALL SvxVertCTLTextTbxCtrl::initialize(const 
css::uno::Sequence& rArguments)
+{
+SvxVertCTLTextTbxCtrl_Base::initialize(rArguments);
+// fdo#83320 Hide vertical text commands early
+setFastPropertyValue_NoBroadcast(1, css::uno::makeAny(true));
+}
+
 void SAL_CALL SvxVertCTLTextTbxCtrl::statusChanged(const 
css::frame::FeatureStateEvent& rEvent)
 {
 ToolBox* pToolBox = nullptr;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Gsoc 2020

When I run ./autogen.sh --with-visual-studio=2019 --with-jdk-home , it
gives following output

*
* Using commandline arguments and ignoring autogen.input!
*

Running ./configure with '--with-visual-studio=2019 --with-jdk-home
--srcdir=/home/hp/lode/dev/core --enable-option-checking=fatal'

*
* Running LibreOffice build configuration.
*

checking build system type... x86_64-pc-cygwin
checking host system type... x86_64-pc-cygwin
checking for product name... LibreOfficeDev
checking for package version... 7.0.0.0.alpha0+
checking for product version... 7.0
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for grep... (cached) /usr/bin/grep
checking for GNU Make... /usr/bin/make
checking for explicit COMSPEC... found: C:\Windows\system32\cmd.exe
checking for sed... /usr/bin/sed
checking whether to use link-time optimization... no
checking for explicit AFLAGS... no
checking for explicit CFLAGS... no
checking for explicit CXXFLAGS... no
checking for explicit OBJCFLAGS... no
checking for explicit OBJCXXFLAGS... no
checking for explicit LDFLAGS... no
checking whether build target is Release Build... no
checking whether to sign windows build... no
checking for gawk... gawk
checking for gawk... /usr/bin/gawk
checking for bash... /bin/sh
checking for GNU or BSD tar... tar
checking for tar's option to strip components... --strip-components
checking how to build and package galleries... internal src images for
desktop
checking whether to build with Java support... yes
checking whether to treat the installation as read-only... no
checking whether to build a 64-bit LibreOffice... no
checking Visual C++... C:/PROGRA~2/MICROS~2/2019/COMMUN~1/VC
checking for short pathname of VC product directory...
/cygdrive/c/PROGRA~2/MICROS~2/2019/COMMUN~1/VC
checking for UCRT location... found
checking for MSBuild.exe location for: 16.0...
/cygdrive/c/PROGRA~2/MICROS~2/2019/COMMUN~1/VC/../MSBuild/Current/Bin
checking cl.exe... found Visual C++ 2019
(/cygdrive/c/PROGRA~2/MICROS~2/2019/COMMUN~1/VC/Tools/MSVC/1424~1.283/bin/HostX64/x86/cl.exe)
checking cl.exe is at least Visual Studio 2017 version 15.7... yes
checking for a x64 compiler and libraries for 64-bit Explorer extensions...
found
checking whether the compiler is actually Clang... no
checking the dependency generation prefix (cl.exe -showIncludes)... "Note:
including file:"
checking whether to build with additional debug utilities... no
checking whether to do a debug build... no
checking whether to generate debug information... no
checking whether to compile with optimization flags... yes
checking which package format to use... none
checking syslog.h usability... no
checking syslog.h presence... no
checking for syslog.h... no
checking whether to turn warnings to errors... no
checking whether to have assert() failures abort even without
--enable-debug... no
checking whether to enable CUPS support... no
checking whether we want to fetch tarballs... yes, if we use them
checking whether to build help... no
checking whether to enable xapian-omega support for help... no
checking whether to include MySpell dictionaries... no
checking whether to use dicts from external paths... no
checking whether to enable pch feature... yes (full)
checking whether
/cygdrive/c/PROGRA~2/MICROS~2/2019/COMMUN~1/VC/Tools/MSVC/1424~1.283/bin/HostX64/x86/cl.exe
-arch:SSE supports -Xclang -building-pch-with-obj... no
checking the GNU Make version... /usr/bin/make 4.2.1
checking whether GNU Make supports the 'file' function... yes
checking for --hash-style gcc linker support... no
checking for perl... /usr/bin/perl
checking the Perl version... Perl 5
checking for required Perl modules... all modules found
checking for Windows SDK... found Windows SDK 10.0
(/cygdrive/c/PROGRA~2/WI3CF2~1/10)
checking for midl.exe... C:\Program Files (x86)\Windows
Kits\10\/Bin/10.0.18362.0/x86/midl.exe
checking for csc.exe...
C:\Windows\Microsoft.NET\Framework\v4.0.30319\/csc.exe
checking for al.exe... C:\Program Files (x86)\Microsoft
SDKs\Windows\v10.0A\bin\NETFX 4.8 Tools\/al.exe
checking .NET Framework... found: C:/PROGRA~2/WI3CF2~1/NETFXSDK/4.8/
checking whether to enable runtime optimizations... yes
checking valgrind/valgrind.h usability... no
checking valgrind/valgrind.h presence... no
checking for valgrind/valgrind.h... no
checking sys/sdt.h usability... no
checking sys/sdt.h presence... no
checking for sys/sdt.h... no
checking what the C++ library is... Microsoft
checking for gperf... /usr/bin/gperf
checking whether gperf is new enough... yes (3.1)
checking which libcmis to use... internal
checking whether cl.exe supports C++17... yes (-std:c++17 -Zc:__cplusplus)
checking whether cl.exe

[Libreoffice-commits] core.git: sw/source

 sw/source/core/doc/doctxm.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit d990c0e4bea625f3f8874d964fe183125f38b757
Author: Stephan Bergmann 
AuthorDate: Sun Jan 26 15:03:12 2020 +0100
Commit: Stephan Bergmann 
CommitDate: Sun Jan 26 16:09:18 2020 +0100

Avoid explicit cast to smaller sal_uInt16 from larger int

...in what might be an attempt to avoid warnings about signed vs. unsigned
comparisons.

Change-Id: I21381a7df7e0902d3b6ab4de064d6470a9c4a2db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87447
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sw/source/core/doc/doctxm.cxx b/sw/source/core/doc/doctxm.cxx
index 01fa812c4a1d..2782ff681a98 100644
--- a/sw/source/core/doc/doctxm.cxx
+++ b/sw/source/core/doc/doctxm.cxx
@@ -66,6 +66,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
@@ -1248,7 +1249,7 @@ void SwTOXBaseSection::UpdateOutline( const SwTextNode* 
pOwnChapterNode,
 ::SetProgressState( 0, pDoc->GetDocShell() );
 SwTextNode* pTextNd = pOutlineNode->GetTextNode();
 if( pTextNd && pTextNd->Len() && pTextNd->HasWriterListeners() &&
-sal_uInt16( pTextNd->GetAttrOutlineLevel()) <= GetLevel() &&
+o3tl::make_unsigned( pTextNd->GetAttrOutlineLevel()) <= GetLevel() 
&&
 pTextNd->getLayoutFrame(pLayout) &&
!pTextNd->IsHiddenByParaField() &&
!pTextNd->HasHiddenCharAttribute( true ) &&
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

 sc/source/core/data/dpcache.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 22c33b17cd64889d2324cbc11b729ea60d0a2e87
Author: Stephan Bergmann 
AuthorDate: Sun Jan 26 15:02:16 2020 +0100
Commit: Stephan Bergmann 
CommitDate: Sun Jan 26 16:06:38 2020 +0100

Use properly typed variables for iteration

Change-Id: Id4857933ae7f038ae14c356ce22257d3ab352c96
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87445
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sc/source/core/data/dpcache.cxx b/sc/source/core/data/dpcache.cxx
index 95f932339443..d86ab2a300be 100644
--- a/sc/source/core/data/dpcache.cxx
+++ b/sc/source/core/data/dpcache.cxx
@@ -554,7 +554,7 @@ void ScDPCache::InitFromDoc(ScDocument* pDoc, const 
ScRange& rRange)
 maStringPools.resize(mnColumnCount);
 std::vector aColData(mnColumnCount);
 maFields.reserve(mnColumnCount);
-for (size_t i = 0; i < static_cast(mnColumnCount); ++i)
+for (SCCOL i = 0; i < mnColumnCount; ++i)
 maFields.push_back(std::make_unique());
 
 maLabelNames.reserve(mnColumnCount+1);
@@ -633,7 +633,7 @@ bool ScDPCache::InitFromDataBase(DBConnector& rDB)
 maStringPools.resize(mnColumnCount);
 maFields.clear();
 maFields.reserve(mnColumnCount);
-for (size_t i = 0; i < static_cast(mnColumnCount); ++i)
+for (SCCOL i = 0; i < mnColumnCount; ++i)
 maFields.push_back(std::make_unique());
 
 // Get column titles and types.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sfx2/source

 sfx2/source/control/thumbnailview.cxx |9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

New commits:
commit b2945902e7a0ad9f033fe67f5ab217d6e31d8d84
Author: Stephan Bergmann 
AuthorDate: Sun Jan 26 14:56:56 2020 +0100
Commit: Stephan Bergmann 
CommitDate: Sun Jan 26 15:51:51 2020 +0100

Avoid explicit casts to smaller sal_uInt16 from larger long

...in what might be attempts to avoid warnings about signed vs. unsigned
comparisons.

Change-Id: I699718a90dffb4b5bcd3706eddbaf6fba71114fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87442
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sfx2/source/control/thumbnailview.cxx 
b/sfx2/source/control/thumbnailview.cxx
index 56cf4213b51d..ba829574d6a3 100644
--- a/sfx2/source/control/thumbnailview.cxx
+++ b/sfx2/source/control/thumbnailview.cxx
@@ -21,6 +21,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -290,7 +291,7 @@ void ThumbnailView::CalculateItemPositions (bool 
bScrollBarUsed)
 
 if ( mnLines <= mnVisLines )
 mnFirstLine = 0;
-else if ( mnFirstLine > static_cast(mnLines-mnVisLines) )
+else if ( mnFirstLine > o3tl::make_unsigned(mnLines-mnVisLines) )
 mnFirstLine = static_cast(mnLines-mnVisLines);
 
 mbHasVisibleItems = true;
@@ -1007,7 +1008,7 @@ void ThumbnailView::SelectItem( sal_uInt16 nItemId )
 {
 mnFirstLine = nNewLine;
 }
-else if ( nNewLine > static_cast(mnFirstLine+mnVisLines-1) 
)
+else if ( nNewLine > o3tl::make_unsigned(mnFirstLine+mnVisLines-1) )
 {
 mnFirstLine = static_cast(nNewLine-mnVisLines+1);
 }
@@ -1444,7 +1445,7 @@ void SfxThumbnailView::CalculateItemPositions(bool 
bScrollBarUsed)
 
 if ( mnLines <= mnVisLines )
 mnFirstLine = 0;
-else if ( mnFirstLine > static_cast(mnLines-mnVisLines) )
+else if ( mnFirstLine > o3tl::make_unsigned(mnLines-mnVisLines) )
 mnFirstLine = static_cast(mnLines-mnVisLines);
 
 mbHasVisibleItems = true;
@@ -2175,7 +2176,7 @@ void SfxThumbnailView::SelectItem( sal_uInt16 nItemId )
 {
 mnFirstLine = nNewLine;
 }
-else if ( nNewLine > static_cast(mnFirstLine+mnVisLines-1) 
)
+else if ( nNewLine > o3tl::make_unsigned(mnFirstLine+mnVisLines-1) )
 {
 mnFirstLine = static_cast(nNewLine-mnVisLines+1);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: accessibility/source

 accessibility/source/standard/vclxaccessiblelist.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 0f6bbde666382f1517e8ba7d94e692a86ebca28b
Author: Stephan Bergmann 
AuthorDate: Sun Jan 26 14:53:23 2020 +0100
Commit: Stephan Bergmann 
CommitDate: Sun Jan 26 15:51:15 2020 +0100

Use properly typed variable for iteration

...avoiding explicit casts to smaller sal_uInt16 from larger sal_Int32.  
(Adding
a o3tl::make_unsigned to silence a resulting -Werror,-Wsign-compare.)

Change-Id: Iff1636e961db6edfac274cf8f7440369e841f9c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87441
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/accessibility/source/standard/vclxaccessiblelist.cxx 
b/accessibility/source/standard/vclxaccessiblelist.cxx
index 2077fcdf874b..b549c6d0c008 100644
--- a/accessibility/source/standard/vclxaccessiblelist.cxx
+++ b/accessibility/source/standard/vclxaccessiblelist.cxx
@@ -28,6 +28,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -620,11 +621,11 @@ void VCLXAccessibleList::UpdateEntryRange_Impl()
 UpdateVisibleLineCount();
 sal_Int32 nBegin = std::min( m_nLastTopEntry, nTop );
 sal_Int32 nEnd = std::max( m_nLastTopEntry + m_nVisibleLineCount, nTop 
+ m_nVisibleLineCount );
-for (sal_uInt16 i = static_cast(nBegin); (i <= 
static_cast(nEnd)); ++i)
+for (sal_Int32 i = nBegin; (i <= nEnd); ++i)
 {
 bool bVisible = ( i >= nTop && i < ( nTop + m_nVisibleLineCount ) 
);
 Reference< XAccessible > xHold;
-if ( i < m_aAccessibleChildren.size() )
+if ( o3tl::make_unsigned(i) < m_aAccessibleChildren.size() )
 xHold = m_aAccessibleChildren[i];
 else if ( bVisible )
 xHold = CreateChild(i);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

GSOC 2020 Application

2020-01-26 Thread Smarth Gupta

Hi,

I am Smarth Gupta and I am planning to apply for GSOC 2020 with
LibreOffice. I am an undergraduate from IIT Kanpur. I have successfully
built LibreOffice and I am currently going over the EasyHacks list to work
on my first contribution to the organization. It would be a great help if
someone could suggest an interesting problem to work on.

Thank You
Regards

Smarth Gupta



ᐧ
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - slideshow/source

2020-01-26 Thread Katarina Behrens (via logerrit)

 slideshow/source/engine/shapes/viewmediashape.cxx |9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

New commits:
commit 59edd056643125978483e7292bfb4b7be707cf3d
Author: Katarina Behrens 
AuthorDate: Tue Jan 21 13:16:09 2020 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Sun Jan 26 14:35:01 2020 +0100

tdf#126459: Consider translated origin of the view also on resize

use-case is the presenter console on 2nd screen, media shape must
be placed relative to the window w/ slide preview, not relative to
the main window

Change-Id: I120f86e399563d2aafc31d88d0a7f9d357f4840c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87135
Tested-by: Jenkins
Reviewed-by: Katarina Behrens 
(cherry picked from commit d4561921dde7d350b3b4d5f793871bea8ba4546d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87258
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/slideshow/source/engine/shapes/viewmediashape.cxx 
b/slideshow/source/engine/shapes/viewmediashape.cxx
index 057b508437ae..c17b550372b1 100644
--- a/slideshow/source/engine/shapes/viewmediashape.cxx
+++ b/slideshow/source/engine/shapes/viewmediashape.cxx
@@ -244,8 +244,13 @@ namespace slideshow
 if( rRangePix.isEmpty() )
 return true;
 
-const Point aPosPixel( rRangePix.getMinX() + maWindowOffset.X,
-   rRangePix.getMinY() + maWindowOffset.Y );
+awt::Rectangle aCanvasArea;
+UnoViewSharedPtr 
xUnoView(std::dynamic_pointer_cast(mpViewLayer));
+if (xUnoView)
+aCanvasArea = xUnoView->getUnoView()->getCanvasArea();
+
+const Point aPosPixel( rRangePix.getMinX() + maWindowOffset.X + 
aCanvasArea.X,
+   rRangePix.getMinY() + maWindowOffset.Y + 
aCanvasArea.Y );
 const Size  aSizePixel( rRangePix.getMaxX() - rRangePix.getMinX(),
 rRangePix.getMaxY() - rRangePix.getMinY() 
);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Gsoc 2020

2020-01-26 Thread Ilmari Lauhakangas

You forgot --with-visual-studio=2019

Ilmari

anshu khare kirjoitti 26.1.2020 klo 15.05:

Hi sir,
I was finally able to run ./setup --dev --force  and it worked.
But now when I go to dev/core repository and run ./autogen.sh it  is 
giving the following output.

Running ./configure with '--enable-debug --srcdir=/home/hp/lode/dev/core 
--enable-option-checking=fatal'

*
*   Running LibreOffice build configuration.
*

checking build system type... x86_64-pc-cygwin
checking host system type... x86_64-pc-cygwin
checking for product name... LibreOfficeDev
checking for package version... 7.0.0.0.alpha0+
checking for product version... 7.0
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for grep... (cached) /usr/bin/grep
checking for GNU Make... /usr/bin/make
checking for explicit COMSPEC... found: C:\Windows\system32\cmd.exe
checking for sed... /usr/bin/sed
checking whether to use link-time optimization... no
checking for explicit AFLAGS... no
checking for explicit CFLAGS... no
checking for explicit CXXFLAGS... no
checking for explicit OBJCFLAGS... no
checking for explicit OBJCXXFLAGS... no
checking for explicit LDFLAGS... no
checking whether build target is Release Build... no
checking whether to sign windows build... no
checking for gawk... gawk
checking for gawk... /usr/bin/gawk
checking for bash... /bin/sh
checking for GNU or BSD tar... tar
checking for tar's option to strip components... --strip-components
checking how to build and package galleries... internal src images for 
desktop

checking whether to build with Java support... yes
checking whether to treat the installation as read-only... no
checking whether to build a 64-bit LibreOffice... no
checking Visual C++... checking VC++ Build Tools and similar... 
configure: error: no Visual Studio 2017 installation found

Error running configure at ./autogen.sh line 292.

I have Visual Studio 19 installed on my system and its path 
is C:\ProgramData\Microsoft\Windows\Start Menu\Programs.

Regards
Anshu Khare

On Sun, 26 Jan, 2020, 1:26 AM Ilmari Lauhakangas, 
> wrote:

For what it's worth, I am able to access
http://archive.apache.org/dist/ant/binaries/apache-ant-1.9.4-bin.zip
just fine.

Ilmari

anshu khare kirjoitti 25.1.2020 klo 16.55:
 > Hi sir,
 >
 > I executed the whole process again.
 > But it's again giving the same error.
 >
 > Regards
 > Anshu
 >
 > On Sat, 25 Jan, 2020, 7:08 PM Mark Hung, mailto:mark...@gmail.com>
 > >> wrote:
 >
 >     Hi anshu khare,
 >
 >     You should proceed only after you successfully completes
setup. Http
 >     500 means server side error. Try to run setup again.
 >
 >
 >     anshu khare mailto:anshukhar...@gmail.com> >>
 >     於 2020年1月25日 週六 21:01 寫道：
 >
 >         Hi mentors
 >
 >         I am Anshu and I want to contribute to this organization.
I was
 >         trying to build libre-office on windows. When I ran ./setup I
 >         got the output as follows :
 >
 >         Check directory 'packages' ... : Created
 >         Check directory 'opt' ... : Created
 >         Check directory 'ext_tar' ... : Created
 >         Check directory 'adm' ... : Created
 >         Check directory 'tb' ... : Created
 >         Cloning into 'buildbot'...
 >         Cloned /home/hp/lode/adm/buildbot
 >         Check directory '/home/hp/lode/opt/bin' ... : Created
 >         --2020-01-25 14:32:45--
 > http://dev-www.libreoffice.org/bin/cygwin/make-4.2.1-msvc.exe
 >         Resolving dev-www.libreoffice.org

 >          (dev-www.libreoffice.org

 >         )... 89.238.68.201,
 >         2a00:1828:a012:201::1
 >         Connecting to dev-www.libreoffice.org

 >          (dev-www.libreoffice.org

 >         )|89.238.68.201|:80...
connected.
 >         HTTP request sent, awaiting response... 301 Moved Permanently
 >         Location:
 > https://dev-www.libreoffice.org/bin/cygwin/make-4.2.1-msvc.exe
 >         [following]
 >         --2020-01-25 14:32:46--
 > https://dev-www.libreoffice.org/bin/cygwin/make-4.2.1-msvc.exe
 >         Connecting to dev-www.libreoffice.org

 >          (dev-www.libreoffice.org

[Libreoffice-commits] help.git: source/text

2020-01-26 Thread Olivier Hallot (via logerrit)

 source/text/smath/01/0309.xhp |   15 +--
 1 file changed, 9 insertions(+), 6 deletions(-)

New commits:
commit 7d262f50126db92b074855ece4af73d1b597ca47
Author: Olivier Hallot 
AuthorDate: Fri Jan 24 12:51:01 2020 -0300
Commit: Olivier Hallot 
CommitDate: Sun Jan 26 14:14:28 2020 +0100

tdf#129918 Add right bookmark for Elements panel

The Elements panel has no target page for F1 key.
This patch adds the bookmark for Elements widgets.

Change-Id: Ic8d5a0042812f76ca218fada34a40002e2175b90
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/87350
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/smath/01/0309.xhp 
b/source/text/smath/01/0309.xhp
index 294123146..2e362a81e 100644
--- a/source/text/smath/01/0309.xhp
+++ b/source/text/smath/01/0309.xhp
@@ -28,13 +28,16 @@


   
-selection options in formulas
- formulas; selections
- elements;in Math
+
+selection options in formulas
+formulas; selections
+elements;in Math
 
 
-Elements
-
+
+
+Elements
+
  This is a list of operators, 
functions, symbols and format options that can be inserted into the 
formula.
   
   Some 
examples show 
you the range of operations.
@@ -59,4 +62,4 @@
  
   

-
\ No newline at end of file
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

2020-01-26 Thread Olivier Hallot (via logerrit)

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4cb5dae9f2c703bc2b2af0817dea2d808dc646b9
Author: Olivier Hallot 
AuthorDate: Sun Jan 26 10:14:28 2020 -0300
Commit: Gerrit Code Review 
CommitDate: Sun Jan 26 14:14:28 2020 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 7d262f50126db92b074855ece4af73d1b597ca47
  - tdf#129918 Add right bookmark for Elements panel

The Elements panel has no target page for F1 key.
This patch adds the bookmark for Elements widgets.

Change-Id: Ic8d5a0042812f76ca218fada34a40002e2175b90
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/87350
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 439b432e1800..7d262f50126d 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 439b432e1800a19dd880811e7014ba82c80ed367
+Subproject commit 7d262f50126db92b074855ece4af73d1b597ca47
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

2020-01-26 Thread Stanislav Horacek (via logerrit)

 source/text/shared/guide/qrcode.xhp |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 439b432e1800a19dd880811e7014ba82c80ed367
Author: Stanislav Horacek 
AuthorDate: Sun Jan 26 11:57:37 2020 +0100
Commit: Olivier Hallot 
CommitDate: Sun Jan 26 14:09:01 2020 +0100

QR code: correct option name and use better word for code damage

Change-Id: Id547a8690ac8c0d34e61b93f89bf4d7265ccf9fb
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/87438
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/shared/guide/qrcode.xhp 
b/source/text/shared/guide/qrcode.xhp
index 1711b55c7..bfb7f7773 100644
--- a/source/text/shared/guide/qrcode.xhp
+++ b/source/text/shared/guide/qrcode.xhp
@@ -30,8 +30,8 @@
 
 URL or Text
 The text for which 
the QR Code is generated.
-Option
-The error 
correction value for the QR Code that is to be created. The error correction of 
a QR code is a measure that helps a QR code to recover if it is 
destroyed.
+Error correction
+The error 
correction value for the QR Code that is to be created. The error correction of 
a QR code is a measure that helps a QR code to recover if it is 
damaged.
 There are four 
standard error correction values.
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

2020-01-26 Thread Stanislav Horacek (via logerrit)

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit fc1813b0d23300108a69ad7475daece5599c9408
Author: Stanislav Horacek 
AuthorDate: Sun Jan 26 14:09:01 2020 +0100
Commit: Gerrit Code Review 
CommitDate: Sun Jan 26 14:09:01 2020 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 439b432e1800a19dd880811e7014ba82c80ed367
  - QR code: correct option name and use better word for code damage

Change-Id: Id547a8690ac8c0d34e61b93f89bf4d7265ccf9fb
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/87438
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 2103dc93c169..439b432e1800 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 2103dc93c16973e31b086f80bde7f2d6960b0ca9
+Subproject commit 439b432e1800a19dd880811e7014ba82c80ed367
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Gsoc 2020

Hi sir,
I was finally able to run ./setup --dev --force  and it worked.
But now when I go to dev/core repository and run ./autogen.sh it  is giving
the following output.

Running ./configure with '--enable-debug --srcdir=/home/hp/lode/dev/core
--enable-option-checking=fatal'

*
*   Running LibreOffice build configuration.
*

checking build system type... x86_64-pc-cygwin
checking host system type... x86_64-pc-cygwin
checking for product name... LibreOfficeDev
checking for package version... 7.0.0.0.alpha0+
checking for product version... 7.0
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for grep... (cached) /usr/bin/grep
checking for GNU Make... /usr/bin/make
checking for explicit COMSPEC... found: C:\Windows\system32\cmd.exe
checking for sed... /usr/bin/sed
checking whether to use link-time optimization... no
checking for explicit AFLAGS... no
checking for explicit CFLAGS... no
checking for explicit CXXFLAGS... no
checking for explicit OBJCFLAGS... no
checking for explicit OBJCXXFLAGS... no
checking for explicit LDFLAGS... no
checking whether build target is Release Build... no
checking whether to sign windows build... no
checking for gawk... gawk
checking for gawk... /usr/bin/gawk
checking for bash... /bin/sh
checking for GNU or BSD tar... tar
checking for tar's option to strip components... --strip-components
checking how to build and package galleries... internal src images for
desktop
checking whether to build with Java support... yes
checking whether to treat the installation as read-only... no
checking whether to build a 64-bit LibreOffice... no
checking Visual C++... checking VC++ Build Tools and similar... configure:
error: no Visual Studio 2017 installation found
Error running configure at ./autogen.sh line 292.

I have Visual Studio 19 installed on my system and its path
is C:\ProgramData\Microsoft\Windows\Start Menu\Programs.

Regards
Anshu Khare

On Sun, 26 Jan, 2020, 1:26 AM Ilmari Lauhakangas, <
ilmari.lauhakan...@libreoffice.org> wrote:

> For what it's worth, I am able to access
> http://archive.apache.org/dist/ant/binaries/apache-ant-1.9.4-bin.zip
> just fine.
>
> Ilmari
>
> anshu khare kirjoitti 25.1.2020 klo 16.55:
> > Hi sir,
> >
> > I executed the whole process again.
> > But it's again giving the same error.
> >
> > Regards
> > Anshu
> >
> > On Sat, 25 Jan, 2020, 7:08 PM Mark Hung,  > > wrote:
> >
> > Hi anshu khare,
> >
> > You should proceed only after you successfully completes setup. Http
> > 500 means server side error. Try to run setup again.
> >
> >
> > anshu khare mailto:anshukhar...@gmail.com>>
> > 於 2020年1月25日 週六 21:01 寫道：
> >
> > Hi mentors
> >
> > I am Anshu and I want to contribute to this organization. I was
> > trying to build libre-office on windows. When I ran ./setup I
> > got the output as follows :
> >
> > Check directory 'packages' ... : Created
> > Check directory 'opt' ... : Created
> > Check directory 'ext_tar' ... : Created
> > Check directory 'adm' ... : Created
> > Check directory 'tb' ... : Created
> > Cloning into 'buildbot'...
> > Cloned /home/hp/lode/adm/buildbot
> > Check directory '/home/hp/lode/opt/bin' ... : Created
> > --2020-01-25 14:32:45--
> > http://dev-www.libreoffice.org/bin/cygwin/make-4.2.1-msvc.exe
> > Resolving dev-www.libreoffice.org
> >  (dev-www.libreoffice.org
> > )... 89.238.68.201,
> > 2a00:1828:a012:201::1
> > Connecting to dev-www.libreoffice.org
> >  (dev-www.libreoffice.org
> > )|89.238.68.201|:80...
> connected.
> > HTTP request sent, awaiting response... 301 Moved Permanently
> > Location:
> > https://dev-www.libreoffice.org/bin/cygwin/make-4.2.1-msvc.exe
> > [following]
> > --2020-01-25 14:32:46--
> > https://dev-www.libreoffice.org/bin/cygwin/make-4.2.1-msvc.exe
> > Connecting to dev-www.libreoffice.org
> >  (dev-www.libreoffice.org
> > )|89.238.68.201|:443...
> connected.
> > HTTP request sent, awaiting response... 200 OK
> > Length: 291328 (284K) [application/octet-stream]
> > Saving to: ‘make-4.2.1-msvc.exe’
> >
> >   0K .. .. .. .. ..
> > 17%  308K 1s
> >  50K .. .. .. .. ..
> > 35%  294K 1s
> > 100K .. .. .. .. ..
> > 52% 2.12M 0s
> > 15

[Libreoffice-commits] core.git: sw/source

2020-01-26 Thread Tomaž Vajngerl (via logerrit)

 sw/source/core/access/AccessibilityCheck.cxx |   24 
 sw/source/core/access/AccessibilityIssue.cxx |   15 +++
 sw/source/core/inc/AccessibilityIssue.hxx|   18 ++
 3 files changed, 53 insertions(+), 4 deletions(-)

New commits:
commit e06760dbf2fd6a389aee2c8cf5eeb16f8a8044c2
Author: Tomaž Vajngerl 
AuthorDate: Sat Jan 25 22:10:32 2020 +0100
Commit: Tomaž Vajngerl 
CommitDate: Sun Jan 26 13:53:01 2020 +0100

acc. check: implement goto for a range of text range in a para.

Change-Id: I847bc67f886b5dcfe8ec30d7c0bdd3aa61ba2d36
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87421
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/sw/source/core/access/AccessibilityCheck.cxx 
b/sw/source/core/access/AccessibilityCheck.cxx
index 2475fb3172fc..0d8c1eee4aab 100644
--- a/sw/source/core/access/AccessibilityCheck.cxx
+++ b/sw/source/core/access/AccessibilityCheck.cxx
@@ -45,6 +45,14 @@ lclAddIssue(sfx::AccessibilityIssueCollection& 
rIssueCollection, OUString const&
 return pIssue;
 }
 
+template  void removeDuplicates(std::vector& aVector)
+{
+std::unordered_set aSet;
+auto end = std::copy_if(aVector.begin(), aVector.end(), aVector.begin(),
+[&aSet](T const& rElement) { return 
aSet.insert(rElement).second; });
+aVector.erase(end, aVector.end());
+}
+
 class BaseCheck
 {
 protected:
@@ -436,7 +444,7 @@ public:
 {
 }
 
-void checkAutoFormat(const SwTextAttr* pTextAttr)
+void checkAutoFormat(SwTextNode* pTextNode, const SwTextAttr* pTextAttr)
 {
 const SwFormatAutoFormat& rAutoFormat = pTextAttr->GetAutoFormat();
 SfxItemIter aItemIter(*rAutoFormat.GetStyleHandle());
@@ -510,8 +518,16 @@ public:
 }
 if (!aFormattings.empty())
 {
-lclAddIssue(m_rIssueCollection, 
SwResId(STR_TEXT_FORMATTING_CONVEYS_MEANING),
-sfx::AccessibilityIssueID::TEXT_FORMATTING);
+removeDuplicates(aFormattings);
+auto pIssue
+= lclAddIssue(m_rIssueCollection, 
SwResId(STR_TEXT_FORMATTING_CONVEYS_MEANING),
+  sfx::AccessibilityIssueID::TEXT_FORMATTING);
+pIssue->setIssueObject(IssueObject::TEXT);
+pIssue->setNode(pTextNode);
+SwDoc* pDocument = pTextNode->GetDoc();
+pIssue->setDoc(pDocument);
+pIssue->setStart(pTextAttr->GetStart());
+pIssue->setEnd(pTextAttr->GetAnyEnd());
 }
 }
 void check(SwNode* pCurrent) override
@@ -527,7 +543,7 @@ public:
 const SwTextAttr* pTextAttr = rHints.Get(i);
 if (pTextAttr->Which() == RES_TXTATR_AUTOFMT)
 {
-checkAutoFormat(pTextAttr);
+checkAutoFormat(pTextNode, pTextAttr);
 }
 }
 }
diff --git a/sw/source/core/access/AccessibilityIssue.cxx 
b/sw/source/core/access/AccessibilityIssue.cxx
index a9eccf478a31..13b0a32a6b16 100644
--- a/sw/source/core/access/AccessibilityIssue.cxx
+++ b/sw/source/core/access/AccessibilityIssue.cxx
@@ -54,6 +54,21 @@ void AccessibilityIssue::gotoIssue() const
 pWrtShell->GotoTable(m_sObjectID);
 }
 break;
+case IssueObject::TEXT:
+{
+SwWrtShell* pWrtShell = m_pDoc->GetDocShell()->GetWrtShell();
+SwContentNode* pContentNode = m_pNode->GetContentNode();
+SwPosition aPoint(*pContentNode, m_nStart);
+SwPosition aMark(*pContentNode, m_nEnd);
+pWrtShell->EnterStdMode();
+pWrtShell->StartAllAction();
+SwPaM* pPaM = pWrtShell->GetCursor();
+*pPaM->GetPoint() = aPoint;
+pPaM->SetMark();
+*pPaM->GetMark() = aMark;
+pWrtShell->EndAllAction();
+}
+break;
 default:
 break;
 }
diff --git a/sw/source/core/inc/AccessibilityIssue.hxx 
b/sw/source/core/inc/AccessibilityIssue.hxx
index 3d59c420708f..9d64a7e4e8e8 100644
--- a/sw/source/core/inc/AccessibilityIssue.hxx
+++ b/sw/source/core/inc/AccessibilityIssue.hxx
@@ -22,6 +22,7 @@ enum class IssueObject
 GRAPHIC,
 OLE,
 TABLE,
+TEXT,
 };
 
 class SW_DLLPUBLIC AccessibilityIssue final : public sfx::AccessibilityIssue
@@ -30,6 +31,11 @@ private:
 IssueObject m_eIssueObject;
 SwDoc* m_pDoc;
 OUString m_sObjectID;
+std::vector m_aIssueAdditionalInfo;
+SwNode* m_pNode;
+
+sal_Int32 m_nStart;
+sal_Int32 m_nEnd;
 
 public:
 AccessibilityIssue(sfx::AccessibilityIssueID eIssueID = 
sfx::AccessibilityIssueID::UNSPECIFIED);
@@ -37,6 +43,18 @@ public:
 void setIssueObject(IssueObject eIssueObject);
 void setDoc(SwDoc* pDoc);
 void setObjectID(OUString const& rID);
+void setNode(SwNode* pNode) { m_pNode = pNode; }
+
+void setStart(sal_Int32 nS

[Libreoffice-commits] core.git: include/o3tl sw/source

2020-01-26 Thread Tomaž Vajngerl (via logerrit)

 include/o3tl/vector_utils.hxx|   27 +++
 sw/source/core/access/AccessibilityCheck.cxx |   11 ++-
 2 files changed, 29 insertions(+), 9 deletions(-)

New commits:
commit af29884072817481273c03373899624933fd567a
Author: Tomaž Vajngerl 
AuthorDate: Sun Jan 26 09:38:40 2020 +0100
Commit: Tomaž Vajngerl 
CommitDate: Sun Jan 26 13:53:21 2020 +0100

move "remove duplicates" for a vector to o3tl/vector_utils.hxx

Change-Id: I9ecf95a2bf975912b7029cdfb459a9ebc159c75d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87429
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/o3tl/vector_utils.hxx b/include/o3tl/vector_utils.hxx
new file mode 100644
index ..dc6d80a9ffbc
--- /dev/null
+++ b/include/o3tl/vector_utils.hxx
@@ -0,0 +1,27 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#pragma once
+
+#include 
+
+namespace o3tl
+{
+// removes duplicated elements in a vector
+template  void remove_duplicates(std::vector& rVector)
+{
+std::unordered_set aSet;
+auto aEnd = std::copy_if(rVector.begin(), rVector.end(), rVector.begin(),
+ [&aSet](T const& rElement) { return 
aSet.insert(rElement).second; });
+rVector.erase(aEnd, rVector.end());
+}
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/access/AccessibilityCheck.cxx 
b/sw/source/core/access/AccessibilityCheck.cxx
index 0d8c1eee4aab..bf1660d073c1 100644
--- a/sw/source/core/access/AccessibilityCheck.cxx
+++ b/sw/source/core/access/AccessibilityCheck.cxx
@@ -30,6 +30,7 @@
 #include 
 #include 
 #include 
+#include 
 
 namespace sw
 {
@@ -45,14 +46,6 @@ lclAddIssue(sfx::AccessibilityIssueCollection& 
rIssueCollection, OUString const&
 return pIssue;
 }
 
-template  void removeDuplicates(std::vector& aVector)
-{
-std::unordered_set aSet;
-auto end = std::copy_if(aVector.begin(), aVector.end(), aVector.begin(),
-[&aSet](T const& rElement) { return 
aSet.insert(rElement).second; });
-aVector.erase(end, aVector.end());
-}
-
 class BaseCheck
 {
 protected:
@@ -518,7 +511,7 @@ public:
 }
 if (!aFormattings.empty())
 {
-removeDuplicates(aFormattings);
+o3tl::remove_duplicates(aFormattings);
 auto pIssue
 = lclAddIssue(m_rIssueCollection, 
SwResId(STR_TEXT_FORMATTING_CONVEYS_MEANING),
   sfx::AccessibilityIssueID::TEXT_FORMATTING);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sal/osl

 sal/osl/unx/file_url.cxx |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit a2f768f417f133fb2564ed5fe351662742dde274
Author: Julien Nabet 
AuthorDate: Sun Jan 26 10:08:31 2020 +0100
Commit: Julien Nabet 
CommitDate: Sun Jan 26 12:54:55 2020 +0100

cppcheck: shadowFunction in sal/file_url

Change-Id: I7454640278f4af0f71f429b45c9f1e40f7be0545
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87433
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/sal/osl/unx/file_url.cxx b/sal/osl/unx/file_url.cxx
index 207bb907feaf..513b8661d406 100644
--- a/sal/osl/unx/file_url.cxx
+++ b/sal/osl/unx/file_url.cxx
@@ -138,10 +138,10 @@ namespace {
 
 bool convert(OUStringBuffer const & in, OStringBuffer * append) {
 assert(append != nullptr);
-for (sal_Size convert = in.getLength();;) {
+for (sal_Size nConvert = in.getLength();;) {
 auto const oldLen = append->getLength();
 auto n = std::min(
-std::max(convert, sal_Size(PATH_MAX)),
+std::max(nConvert, sal_Size(PATH_MAX)),
 sal_Size(std::numeric_limits::max() - oldLen));
 // approximation of required converted size
 auto s = append->appendUninitialized(n);
@@ -149,7 +149,7 @@ bool convert(OUStringBuffer const & in, OStringBuffer * 
append) {
 sal_Size converted;
 //TODO: context, for reliable treatment of DESTBUFFERTOSMALL:
 n = UnicodeToTextConverter_Impl::getInstance().convert(
-in.getStr() + in.getLength() - convert, convert, s, n,
+in.getStr() + in.getLength() - nConvert, nConvert, s, n,
 (RTL_UNICODETOTEXT_FLAGS_UNDEFINED_ERROR | 
RTL_UNICODETOTEXT_FLAGS_INVALID_ERROR
  | RTL_UNICODETOTEXT_FLAGS_FLUSH),
 &info, &converted);
@@ -157,9 +157,9 @@ bool convert(OUStringBuffer const & in, OStringBuffer * 
append) {
 return false;
 }
 append->setLength(oldLen + n);
-assert(converted <= convert);
-convert -= converted;
-assert((convert == 0) == ((info & 
RTL_UNICODETOTEXT_INFO_DESTBUFFERTOSMALL) == 0));
+assert(converted <= nConvert);
+nConvert -= converted;
+assert((nConvert == 0) == ((info & 
RTL_UNICODETOTEXT_INFO_DESTBUFFERTOSMALL) == 0));
 if ((info & RTL_UNICODETOTEXT_INFO_DESTBUFFERTOSMALL) == 0) {
 break;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: store/source

 store/source/storbase.hxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit d87ba243e5dd2f6afcd9da7d99781a78fced1cba
Author: Julien Nabet 
AuthorDate: Sun Jan 26 10:05:45 2020 +0100
Commit: Julien Nabet 
CommitDate: Sun Jan 26 11:44:05 2020 +0100

cppcheck: shadowFunction in store/storbase

Change-Id: I836a5476a139c8c863c2e7c33e57c31dc3f6ab78
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87432
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/store/source/storbase.hxx b/store/source/storbase.hxx
index b9dc53247a8d..09b0e88b2ae5 100644
--- a/store/source/storbase.hxx
+++ b/store/source/storbase.hxx
@@ -284,10 +284,11 @@ struct PageData
 public:
 template< class T > T * construct()
 {
-void * page = nullptr; sal_uInt16 size = 0;
-if (allocate (&page, &size))
+void * page = nullptr;
+sal_uInt16 nSize = 0;
+if (allocate (&page, &nSize))
 {
-return new(page) T(size);
+return new(page) T(nSize);
 }
 return 0;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sal/qa

 sal/qa/osl/file/osl_File.cxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit f7c3e35a9d28a1294d635f714f20933572f12e4d
Author: Julien Nabet 
AuthorDate: Sun Jan 26 10:10:07 2020 +0100
Commit: Noel Grandin 
CommitDate: Sun Jan 26 11:38:23 2020 +0100

cppcheck: shadowFunction in sal/osl_File

Change-Id: I7d264faad080428459e499c786f25b3e06a6700b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87434
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sal/qa/osl/file/osl_File.cxx b/sal/qa/osl/file/osl_File.cxx
index dabe4e09e15f..32a9509dd00d 100644
--- a/sal/qa/osl/file/osl_File.cxx
+++ b/sal/qa/osl/file/osl_File.cxx
@@ -1088,14 +1088,14 @@ namespace osl_FileBase
  void searchFileURL_002()
 {
 /* search file is passed by system filename */
-OUString aRootSys = INetURLObject(aTempDirectoryURL).GetLastName();
-nError1 = osl::FileBase::searchFileURL(aTempDirectorySys, 
aRootSys, aUStr);
+OUString strRootSys = 
INetURLObject(aTempDirectoryURL).GetLastName();
+nError1 = osl::FileBase::searchFileURL(aTempDirectorySys, 
strRootSys, aUStr);
 bool bOk1 = compareFileName(aUStr, aTempDirectoryURL);
 /* search file is passed by full qualified file URL */
-nError2 = osl::FileBase::searchFileURL(aTempDirectoryURL, 
aRootSys, aUStr);
+nError2 = osl::FileBase::searchFileURL(aTempDirectoryURL, 
strRootSys, aUStr);
 bool bOk2 = compareFileName(aUStr, aTempDirectoryURL);
 /* search file is passed by relative file path */
-nError3 = osl::FileBase::searchFileURL(aRelURL5, aRootSys, aUStr);
+nError3 = osl::FileBase::searchFileURL(aRelURL5, strRootSys, 
aUStr);
 bool bOk3 = compareFileName(aUStr, aTempDirectoryURL);
 /* search file is passed by an exist file */
 createTestFile(aCanURL1);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/inc vcl/source

2020-01-26 Thread Adrien Ollier (via logerrit)

 vcl/inc/impanmvw.hxx|2 +-
 vcl/source/gdi/impanmvw.cxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 22d2ad9135eca2a3d793cc1709148d4a5b6ec1c4
Author: Adrien Ollier 
AuthorDate: Sat Jan 25 18:10:13 2020 +0100
Commit: Noel Grandin 
CommitDate: Sun Jan 26 11:37:35 2020 +0100

const parameter for ImplAnimView::matches

pOut is a const OutputDevice* instead of OutputDevice*

Change-Id: I369fea42a19afaeca3c5a9714e5a6043921be3b4
Signed-off-by: Adrien Ollier 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87416
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/vcl/inc/impanmvw.hxx b/vcl/inc/impanmvw.hxx
index 69949e9252ce..a9f5e959ee58 100644
--- a/vcl/inc/impanmvw.hxx
+++ b/vcl/inc/impanmvw.hxx
@@ -74,7 +74,7 @@ private:
   const Point& rPt, const Size& rSz, sal_uLong 
nExtraData,
   OutputDevice* pFirstFrameOutDev = nullptr );
 
-boolmatches( OutputDevice* pOut, long nExtraData ) const;
+boolmatches(const OutputDevice* pOut, long nExtraData) const;
 voiddrawToPos( sal_uLong nPos );
 voiddraw( sal_uLong nPos, VirtualDevice* pVDev=nullptr );
 voidrepaint();
diff --git a/vcl/source/gdi/impanmvw.cxx b/vcl/source/gdi/impanmvw.cxx
index b27a7cc70581..abdc376b2567 100644
--- a/vcl/source/gdi/impanmvw.cxx
+++ b/vcl/source/gdi/impanmvw.cxx
@@ -96,7 +96,7 @@ ImplAnimView::~ImplAnimView()
 Animation::ImplDecAnimCount();
 }
 
-bool ImplAnimView::matches(OutputDevice* pOut, long nExtraData) const
+bool ImplAnimView::matches(const OutputDevice* pOut, long nExtraData) const
 {
 return (!pOut || pOut == mpRenderContext) && (nExtraData == 0 || 
nExtraData == mnExtraData);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: compilerplugins/clang