[Libreoffice-ux-advise] [Bug 34436] TABLES text in cells behaves wrong when rotated (Shift Enter needed for line - see comment#3)
https://bugs.documentfoundation.org/show_bug.cgi?id=34436 --- Comment #41 from Timur --- (In reply to Frank from comment #39) > Fascinating... Yet another "Special Case" in Writer. Whole comment is rather sarcastic than purposeful. LO is volunteer based project. One can help by opening a bug that will (after searching, reading and pointing to similar bugs) explain what's exactly expected (starting from existing rotations) or help more by coding himself/herself. No point to further give general observations and complaints in a bug that's resolved at least by explaining the reason. (In reply to Gerhard Schaber from comment #40) > Or even put simpler--look at what MS Word does. That's possible solution "some rework of rotation, which could be another bug, but only if explained what's expected" taking into account all possibilities. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 130952] New: CRASH: launching Bullets & Numbering dialog from sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=130952 Bug ID: 130952 Summary: CRASH: launching Bullets & Numbering dialog from sidebar Product: LibreOffice Version: 7.0.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: xiscofa...@libreoffice.org Steps to reproduce: 1. Open writer 2. Sidebar - Properties - Paragraph 3. Expand the bullet's or numbering's dropdown list - More bullets -> Crash Reproduced in Version: 7.0.0.0.alpha0+ Build ID: e6b9bc3f2ecf0fb7fde5b02f9d750ccbe022f4c1 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/admin wsd/Admin.cpp wsd/AdminModel.hpp
loleaflet/admin/adminAnalytics.html |2
loleaflet/admin/src/AdminSocketAnalytics.js | 63 ++--
loleaflet/admin/src/Util.js |2
wsd/Admin.cpp |2
wsd/AdminModel.hpp |4 -
5 files changed, 11 insertions(+), 62 deletions(-)
New commits:
commit 51c840249e8a7a094ae9594ab2aea13668c5d66b
Author: nienzu
AuthorDate: Wed Feb 26 13:47:21 2020 +0800
Commit: Michael Meeks
CommitDate: Wed Feb 26 10:53:25 2020 +0100
tdf#130798 admin: Use original data to create network traffic graph
Instead of using the data of rolling average, using original data would
reflect the real network traffic.
Change-Id: I3f5a277b6ee8e7d760f5623eb4aae9f6c999e10f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89494
Tested-by: Michael Meeks
Reviewed-by: Michael Meeks
diff --git a/loleaflet/admin/adminAnalytics.html
b/loleaflet/admin/adminAnalytics.html
index 7f52c080f..7667c67df 100644
--- a/loleaflet/admin/adminAnalytics.html
+++ b/loleaflet/admin/adminAnalytics.html
@@ -30,7 +30,7 @@
host = 'ws://' + window.location.host +
'%SERVICE_ROOT%/lool/adminws/'
}
-Admin.Analytics(host)
+var socketAnalytics = Admin.Analytics(host);
diff --git a/loleaflet/admin/src/AdminSocketAnalytics.js
b/loleaflet/admin/src/AdminSocketAnalytics.js
index fcc86d5d5..e965fc62e 100644
--- a/loleaflet/admin/src/AdminSocketAnalytics.js
+++ b/loleaflet/admin/src/AdminSocketAnalytics.js
@@ -13,9 +13,7 @@ var AdminSocketAnalytics = AdminSocketBase.extend({
_memStatsData: [],
_cpuStatsData: [],
_sentStatsData: [],
- _sentAvgStats: [],
_recvStatsData: [],
- _recvAvgStats: [],
_memStatsSize: 0,
_memStatsInterval: 0,
@@ -23,7 +21,6 @@ var AdminSocketAnalytics = AdminSocketBase.extend({
_cpuStatsSize: 0,
_cpuStatsInterval: 0,
- _netAvgSize: 10,
_netStatsSize: 0,
_netStatsInterval: 0,
@@ -48,10 +45,6 @@ var AdminSocketAnalytics = AdminSocketBase.extend({
this._sentStatsData = actualData;
else if (option === 'recv')
this._recvStatsData = actualData;
- else if (option === 'sent_avg')
- this._sentAvgStats = actualData;
- else if (option === 'recv_avg')
- this._recvAvgStats = actualData;
},
onSocketOpen: function() {
@@ -102,7 +95,7 @@ var AdminSocketAnalytics = AdminSocketBase.extend({
else if (option === 'cpu')
data = this._cpuStatsData;
else if (option === 'net')
- data = this._sentAvgStats.concat(this._recvAvgStats);
+ data = this._sentStatsData.concat(this._recvStatsData);
xScale = d3.scale.linear().range([this._graphMargins.left,
this._graphWidth - this._graphMargins.right]).domain([d3.min(data, function(d) {
return d.time;
@@ -142,7 +135,7 @@ var AdminSocketAnalytics = AdminSocketBase.extend({
.y(function(d) {
return yScale(d.value);
})
- .interpolate('basis');
+ .interpolate('monotone');
if (option === 'mem') {
this._xMemScale = xScale;
@@ -264,14 +257,14 @@ var AdminSocketAnalytics = AdminSocketBase.extend({
else if (option === 'net') {
vis.append('svg:path')
- .attr('d',
this._d3NetSentLine(this._sentAvgStats))
+ .attr('d',
this._d3NetSentLine(this._sentStatsData))
.attr('class', 'lineSent')
.attr('stroke', 'red')
.attr('stroke-width', 1)
.attr('fill', 'none');
vis.append('svg:path')
- .attr('d',
this._d3NetRecvLine(this._recvAvgStats))
+ .attr('d',
this._d3NetRecvLine(this._recvStatsData))
.attr('class', 'lineRecv')
.attr('stroke', 'green')
.attr('stroke-width', 1)
@@ -294,16 +287,6 @@ var AdminSocketAnalytics = AdminSocketBase.extend({
graphName = '#CpuVisualisation';
line = 'line';
}
- else if (option === 'sent_avg') {
- size = this._netStatsSize - this._netAvgSize + 1;
- graphName = '#NetVisualisation';
- line = 'lineSent';
- }
- else if (option === 'recv_avg') {
- size =
[Libreoffice-bugs] [Bug 130930] Ability to remove one specific direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=130930 --- Comment #9 from Frederic Parrenin --- > The recommended workflow is still to clean up per Remove Direct Formatting > and to use character styles Yes, thank you for bringing this workaround solution. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 130930] Ability to remove one specific direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=130930 --- Comment #9 from Frederic Parrenin --- > The recommended workflow is still to clean up per Remove Direct Formatting > and to use character styles Yes, thank you for bringing this workaround solution. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: sw/CustomTarget_generated.mk
sw/CustomTarget_generated.mk |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit c8d764b3f27c2bb0712745891b70630e94436317 Author: Jussi Pakkanen AuthorDate: Tue Feb 25 19:32:55 2020 +0200 Commit: Michael Stahl CommitDate: Wed Feb 26 10:46:48 2020 +0100 Add missing Python dependency to Makefile. Change-Id: I9d1b37f0a9b47da53ee15ebf7d4b24f867dc274d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89474 Reviewed-by: Michael Stahl Tested-by: Jenkins diff --git a/sw/CustomTarget_generated.mk b/sw/CustomTarget_generated.mk index eafb8705564d..fb3f842d382a 100644 --- a/sw/CustomTarget_generated.mk +++ b/sw/CustomTarget_generated.mk @@ -13,11 +13,13 @@ sw_SRC := $(SRCDIR)/sw/source/core/swg sw_PY := $(SRCDIR)/solenv/bin/gentoken.py sw_INC := $(call gb_CustomTarget_get_workdir,sw/generated) -$(sw_INC)/TextBlockTokens.gperf : $(sw_SRC)/TextBlockTokens.txt $(sw_PY) +$(sw_INC)/TextBlockTokens.gperf : $(sw_SRC)/TextBlockTokens.txt $(sw_PY) \ + $(call gb_ExternalExecutable_get_dependencies,python) mkdir -p $(sw_INC) $(PYTHON) $(sw_PY) $(sw_SRC)/TextBlockTokens.txt $(sw_INC)/TextBlockTokens.gperf -$(sw_INC)/BlockListTokens.gperf : $(sw_SRC)/BlockListTokens.txt $(sw_PY) +$(sw_INC)/BlockListTokens.gperf : $(sw_SRC)/BlockListTokens.txt $(sw_PY) \ + $(call gb_ExternalExecutable_get_dependencies,python) mkdir -p $(sw_INC) $(PYTHON) $(sw_PY) $(sw_SRC)/BlockListTokens.txt $(sw_INC)/BlockListTokens.gperf ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 130909] Tabbed interface: Add subscript in Calc Home Tab
https://bugs.documentfoundation.org/show_bug.cgi?id=130909 Heiko Tietze changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Severity|normal |enhancement CC||kain...@gmail.com --- Comment #1 from Heiko Tietze --- For what exactly do you need subscript in Calc? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 130950] CRASH: scrolling document
https://bugs.documentfoundation.org/show_bug.cgi?id=130950 Michael Stahl (CIB) changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |michael.st...@cib.de |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130909] Tabbed interface: Add subscript in Calc Home Tab
https://bugs.documentfoundation.org/show_bug.cgi?id=130909 Heiko Tietze changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Severity|normal |enhancement CC||kain...@gmail.com --- Comment #1 from Heiko Tietze --- For what exactly do you need subscript in Calc? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130935] Crash when selecting txt file after insert sheet from file
https://bugs.documentfoundation.org/show_bug.cgi?id=130935 Xisco Faulí changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #5 from Xisco Faulí --- @Nemo, Does it crash if you launch LibreOffice from command line with 'SAL_USE_VCLPLUGIN=gen soffice' ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 130930] Ability to remove one specific direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=130930 Heiko Tietze changed: What|Removed |Added CC||mikekagan...@hotmail.com See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||7708 Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #8 from Heiko Tietze --- (In reply to V Stuart Foote from comment #6) > So, guess there is potential to implement. Question is rather if we want to support single DF removal. The recommended workflow is still to clean up per Remove Direct Formatting and to use character styles (where we have the same problem, see bug 89826). Guess the issue is mostly related to font names. Why not remove the DF when it fits the PS/CS? Without any UI. Don't we have a request on this? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 127708] Make it easier to revert to "No setting" for various settings of a style
https://bugs.documentfoundation.org/show_bug.cgi?id=127708 Heiko Tietze changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||0930 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130930] Ability to remove one specific direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=130930 Heiko Tietze changed: What|Removed |Added CC||mikekagan...@hotmail.com See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||7708 Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #8 from Heiko Tietze --- (In reply to V Stuart Foote from comment #6) > So, guess there is potential to implement. Question is rather if we want to support single DF removal. The recommended workflow is still to clean up per Remove Direct Formatting and to use character styles (where we have the same problem, see bug 89826). Guess the issue is mostly related to font names. Why not remove the DF when it fits the PS/CS? Without any UI. Don't we have a request on this? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130935] Crash when selecting txt file after insert sheet from file
https://bugs.documentfoundation.org/show_bug.cgi?id=130935 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #4 from Xisco Faulí --- I can't reproduce it in Version: 7.0.0.0.alpha0+ Build ID: 828504974d70111e4a35b31d579cf42fe660a660 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130951] FILEOPEN: DOCX: picture does not display doc saved by MSWord
https://bugs.documentfoundation.org/show_bug.cgi?id=130951 Xisco Faulí changed: What|Removed |Added Ever confirmed|0 |1 CC||armin.le.gr...@me.com Keywords||bibisected, bisected, ||regression See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||0768 Status|UNCONFIRMED |NEW --- Comment #3 from Xisco Faulí --- Regression introduced by: author Armin Le Grand (Collabora) 2020-02-21 16:58:17 +0100 committer Armin Le Grand 2020-02-21 20:16:59 +0100 commit 828504974d70111e4a35b31d579cf42fe660a660 (patch) tree4c2f7720b3efaecf55b8fa7b9b3eeccb278160e6 parent 813cde918338bccc4f711230616340cad2c1d4a0 (diff) tdf#130768 speedup huge pixel graphics Cairo Bisected with: bibisect-linux64-6.5 Adding Cc: to Armin Le Grand -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130951] FILEOPEN: DOCX: picture does not display doc saved by MSWord
https://bugs.documentfoundation.org/show_bug.cgi?id=130951 Xisco Faulí changed: What|Removed |Added Summary|picture does not display|FILEOPEN: DOCX: picture |doc saved by MSWord |does not display doc saved ||by MSWord Keywords||filter:docx -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130951] picture does not display doc saved by MSWord
https://bugs.documentfoundation.org/show_bug.cgi?id=130951 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #2 from Xisco Faulí --- Created attachment 158196 --> https://bugs.documentfoundation.org/attachment.cgi?id=158196=edit Comparison MSO 2010 and LibreOffice 7.0 master -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130941] Graphical issue with vectors in LibreOffice Math
https://bugs.documentfoundation.org/show_bug.cgi?id=130941 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Julien Nabet --- On Win10 with LO 6.3.4.2 (x64), I don't reproduce this. Could you give a try at https://wiki.documentfoundation.org/QA/FirstSteps ? Just to be sure, do you use LO 64 or 32 bits? Indeed, you put "6.3.4.2 (x64)" in description but x86 (IA32) in Hardware Field. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61914] [META] Start Center bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=61914 Bug 61914 depends on bug 130742, which changed state. Bug 130742 Summary: LibreOffice Start Center overlay icons aren't correct for Flat ODF documents https://bugs.documentfoundation.org/show_bug.cgi?id=130742 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/control/recentdocsview.cxx |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit f4b5b12fbe7eb0260119445ac39a28427fef3ee6
Author: Heiko Tietze
AuthorDate: Tue Feb 25 14:16:22 2020 +0100
Commit: Heiko Tietze
CommitDate: Wed Feb 26 10:18:24 2020 +0100
Resolves tdf#130742 - Flat ODF in start center
Added fodt,fods,fopd,fodg to typeMatchesExtension
Change-Id: Ife8139af87ecc5af8a5e98c9d9dd7830c3a3231a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89455
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/sfx2/source/control/recentdocsview.cxx
b/sfx2/source/control/recentdocsview.cxx
index d875c73dda17..e9120d355a01 100644
--- a/sfx2/source/control/recentdocsview.cxx
+++ b/sfx2/source/control/recentdocsview.cxx
@@ -148,21 +148,21 @@ bool RecentDocsView::typeMatchesExtension(ApplicationType
type, const OUString &
{
bool bRet = false;
-if (rExt == "odt" || rExt == "doc" || rExt == "docx" ||
+if (rExt == "odt" || rExt == "fodt" || rExt == "doc" || rExt == "docx" ||
rExt == "rtf" || rExt == "txt" || rExt == "odm" || rExt == "otm")
{
bRet = static_cast(type & ApplicationType::TYPE_WRITER);
}
-else if (rExt == "ods" || rExt == "xls" || rExt == "xlsx")
+else if (rExt == "ods" || rExt == "fods" || rExt == "xls" || rExt ==
"xlsx")
{
bRet = static_cast(type & ApplicationType::TYPE_CALC);
}
-else if (rExt == "odp" || rExt == "pps" || rExt == "ppt" ||
+else if (rExt == "odp" || rExt == "fodp" || rExt == "pps" || rExt == "ppt"
||
rExt == "pptx")
{
bRet = static_cast(type & ApplicationType::TYPE_IMPRESS);
}
-else if (rExt == "odg")
+else if (rExt == "odg" || rExt == "fodg")
{
bRet = static_cast(type & ApplicationType::TYPE_DRAW);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 127508] I cannot disable effect from highlighted/normal column/row header
https://bugs.documentfoundation.org/show_bug.cgi?id=127508 Heiko Tietze changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #27 from Heiko Tietze --- And fixed again. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 130951] picture does not display doc saved by MSWord
https://bugs.documentfoundation.org/show_bug.cgi?id=130951 --- Comment #1 from Elmar --- Created attachment 158195 --> https://bugs.documentfoundation.org/attachment.cgi?id=158195=edit no picture on first page -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130951] New: picture does not display doc saved by MSWord
https://bugs.documentfoundation.org/show_bug.cgi?id=130951 Bug ID: 130951 Summary: picture does not display doc saved by MSWord Product: LibreOffice Version: 7.0.0.0.alpha0+ Master Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rob...@iafrica.com Description: Open a document with picture in first page. the picture does not display (in the original doc, a picture in a later page did show. Steps to Reproduce: 1. save a document after editing in MS Word 2. open in Writer 3. Actual Results: no picture in first page Expected Results: should see it. When open the doc in v6.0 it does display. Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-GB Module: TextDocument [Information guessed from browser] OS: Linux (All) OS is 64bit: yes tried with .doc and .docx results the same -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 45589] Show bookmarks: make them visible in a document
https://bugs.documentfoundation.org/show_bug.cgi?id=45589 Xisco Faulí changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||0950 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 130950] CRASH: scrolling document
https://bugs.documentfoundation.org/show_bug.cgi?id=130950 Xisco Faulí changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=45 ||589 Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Keywords||bibisected, bisected, ||regression CC||michael.st...@cib.de, ||xiscofa...@libreoffice.org --- Comment #1 from Xisco Faulí --- Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=ef8427d12a63127a2eb867637699343d630545dd author Michael Stahl 2020-01-21 13:15:50 +0100 committer Michael Stahl 2020-01-30 14:18:46 +0100 commit ef8427d12a63127a2eb867637699343d630545dd (patch) treeb3312295b36246c8bad99e417639445cfe23670e parent 3a248dfe57318af57fc5df89652cb64dfa923e46 (diff) tdf#45589 sw: invalidate on bookmark insertion/deletion Bisected with: bibisect-linux64-6.5 Adding Cc: to Michael Stahl -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sw/qa sw/source
sw/qa/extras/odfimport/odfimport.cxx |9 ++
sw/qa/extras/ooxmlexport/ooxmlexport10.cxx |8 +++---
sw/qa/extras/ooxmlexport/ooxmlexport4.cxx |3 +-
sw/qa/extras/ww8export/ww8export.cxx |7 +
sw/source/core/inc/frmtool.hxx |8 +-
sw/source/core/layout/flowfrm.cxx | 18 ++---
sw/source/core/layout/frmtool.cxx | 25 ---
sw/source/core/layout/laycache.cxx | 10 ---
sw/source/core/layout/newfrm.cxx | 10 +--
sw/source/core/layout/pagechg.cxx | 28 ++---
sw/source/core/layout/trvlfrm.cxx | 38 -
11 files changed, 86 insertions(+), 78 deletions(-)
New commits:
commit da4f9ff1cfeeeb4f04bb943e94db86887b5c9f58
Author: Michael Stahl
AuthorDate: Tue Feb 18 19:18:47 2020 +0100
Commit: Miklos Vajna
CommitDate: Wed Feb 26 10:10:57 2020 +0100
tdf#125682 sw: don't insert empty page before first page with even number
This mostly reverts commit 14bb680949b47332d2921cc68f75340b31ad5c32 and
replaces it by a hopefully better approach: if the first page in the
document has an even number, it will become a right page, and "toggle"
the document so that even pages are right pages and odd pages are left
pages.
This is closer to what Word does; the tests adapted in the above commit
were actually regressions.
Add a new function IsRightPageByNumber() to determine how the page
number offsets should be interpreted.
Also make it explicit that even/odd and right/left page are no longer
synonymous by renaming various "Odd" variables.
Historically documents that start with even page number didn't work well
anyway; before the above commit you'd get a left page followed by a left
page followed by a right page, which is clearly nonsense if the page
style differs between left and right pages - so hopefully we can do
without a compat setting for those.
There is still one situation where an empty page is inserted before the
first page: if the page style is "Left Page"; this appears to be
impossible in Word so we'll have issues exporting that to Word formats
anyway.
Testing:
Writer pre-commit; LO 5.4/OOo 3.3:
1.odd -> right, 2.even -> left
1.even -> left, 2.odd -> right + inserts a blank page on the right
after reload:
1.even -> left, 2.odd -> left, no empty page
Writer w/ commit; LO 6.0+:
1.odd -> right, 2.even -> left
1.even -> left, 2.odd -> right + blank page as first page (right)
after reload:
1.even -> left, 2.odd -> right + blank page as first page (right)
Word:
1.odd -> right, 2.even -> left
1.even -> right but left style, 2.odd -> left but right style
[technically uses terminology even/odd instead of left/right, but if
mirrored, the "inner margin" is always the same and leads to
interpretation of left/right]
Writer and Word appear to agree on inserting empty pages on
SwFormatPageDesc items/Word section breaks: both even-ness of an
explicit page number and "Left Page" only page style or explicit
even/odd section break may insert empty page.
A useful improvement would be to detect in Word import filters that the
first page is even numbered and then invert the mapping of all of the
page styles, i.e. odd header/footer->left instead of right, and if
mirrorMargins, pgMar left -> inner instead of outer.
Change-Id: Ibed0dbf888c120a3a7d11892f40d07ffb5bc0b68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88978
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 509a02aa96f6d7620cb0bf06c20b3bfa0641be92)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89047
Tested-by: Xisco Faulí
Reviewed-by: Miklos Vajna
(cherry picked from commit 2e909f572229c16ae86a17d5a6fc83b67e818f9b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89461
diff --git a/sw/qa/extras/odfimport/odfimport.cxx
b/sw/qa/extras/odfimport/odfimport.cxx
index 2264d25615c6..703de09ef7f7 100644
--- a/sw/qa/extras/odfimport/odfimport.cxx
+++ b/sw/qa/extras/odfimport/odfimport.cxx
@@ -876,14 +876,11 @@ DECLARE_ODFIMPORT_TEST(testTdf94882, "tdf94882.odt")
DECLARE_ODFIMPORT_TEST(testBlankBeforeFirstPage, "tdf94882.odt")
{
-// This document starts on page 50, which is even, so it should have a
+// This document starts on page 50, which is even, but it should not have a
// blank page inserted before it to make it a left page
-CPPUNIT_ASSERT_EQUAL_MESSAGE("There should be 2 pages output",
-OUString("2"), parseDump("count(/root/page)")
-);
-CPPUNIT_ASSERT_EQUAL_MESSAGE("The first page should be blank",
-OUString("0"), parseDump("count(/root/page[1]/body)")
+CPPUNIT_ASSERT_EQUAL_MESSAGE("There should be 1 pages
[Libreoffice-bugs] [Bug 130950] New: CRASH: scrolling document
https://bugs.documentfoundation.org/show_bug.cgi?id=130950 Bug ID: 130950 Summary: CRASH: scrolling document Product: LibreOffice Version: 7.0.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: xiscofa...@libreoffice.org Steps to reproduce: 1. Open attachment 79203 from bug 64500 2. Scroll down -> Crash Reproduced in Version: 7.0.0.0.alpha0+ Build ID: e6b9bc3f2ecf0fb7fde5b02f9d750ccbe022f4c1 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123102] WRITER: Numbering should be separate for table columns so inserting a new row outside shouldn't increase number in vertically merged cell where rows don't change
https://bugs.documentfoundation.org/show_bug.cgi?id=123102 László Németh changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |nem...@numbertext.org |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - vcl/inc vcl/source
vcl/inc/svdata.hxx | 31 ++-
vcl/source/app/salvtables.cxx|4 +--
vcl/source/app/svmain.cxx|2 -
vcl/source/bitmap/BitmapScaleSuperFilter.cxx | 11 ++---
4 files changed, 40 insertions(+), 8 deletions(-)
New commits:
commit 4d50456f1c8a54095c136ca14114e38a78f90c09
Author: Michael Meeks
AuthorDate: Wed Feb 26 06:59:09 2020 +
Commit: Michael Meeks
CommitDate: Wed Feb 26 10:01:31 2020 +0100
lru_scale_cache - cache the same bitmap at multiple scales.
Helps accelerate different views at different scales, as well as
document / image thumbnailing on save, as well as stray views that
can get rendered behind the scenes at odd scales on mobile.
Each scale + bitmap combination is another key in the LRU table.
Change-Id: Id82ce2e4180608082c9ca16fad35bba9e8c2e81a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89497
Reviewed-by: Tomaž Vajngerl
Reviewed-by: Miklos Vajna
Tested-by: Michael Meeks
diff --git a/vcl/inc/svdata.hxx b/vcl/inc/svdata.hxx
index 1fae7681f8e7..45d9bee12955 100644
--- a/vcl/inc/svdata.hxx
+++ b/vcl/inc/svdata.hxx
@@ -177,7 +177,36 @@ struct ImplSVAppData
DECL_LINK(VclEventTestingHdl, Timer*, void);
};
-typedef o3tl::lru_map lru_scale_cache;
+/// Cache multiple scalings for the same bitmap
+struct ScaleCacheKey {
+SalBitmap *mpBitmap;
+Size maDestSize;
+ScaleCacheKey(SalBitmap *pBitmap, const Size )
+{
+mpBitmap = pBitmap;
+maDestSize = aDestSize;
+}
+ScaleCacheKey(const ScaleCacheKey )
+{
+mpBitmap = key.mpBitmap;
+maDestSize = key.maDestSize;
+}
+struct KeyHash {
+std::size_t operator()(const ScaleCacheKey& k) const
+{
+return ((std::size_t) k.mpBitmap) ^ k.maDestSize.getWidth() ^
+(k.maDestSize.getHeight() << 16);
+}
+};
+struct KeyEqual {
+bool operator()(const ScaleCacheKey& l, const ScaleCacheKey& r) const
+{
+return l.mpBitmap == r.mpBitmap && l.maDestSize == r.maDestSize;
+}
+};
+};
+
+typedef o3tl::lru_map lru_scale_cache;
struct ImplSVGDIData
{
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 856f6745b300..55ceb47ee7f0 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -144,8 +144,8 @@ void SalBitmap::DropScaledCache()
if (ImplSVData* pSVData = ImplGetSVData())
{
auto& rCache = pSVData->maGDIData.maScaleCache;
-rCache.remove_if([this] (const o3tl::lru_map::key_value_pair_t& rKeyValuePair)
- { return rKeyValuePair.first == this; });
+rCache.remove_if([this] (const lru_scale_cache::key_value_pair_t&
rKeyValuePair)
+ { return rKeyValuePair.first.mpBitmap == this; });
}
}
diff --git a/vcl/source/app/svmain.cxx b/vcl/source/app/svmain.cxx
index 74b7fa6a0789..14feb2b103fc 100644
--- a/vcl/source/app/svmain.cxx
+++ b/vcl/source/app/svmain.cxx
@@ -583,7 +583,7 @@ void DeInitVCL()
pSVData->maGDIData.mxScreenFontList.reset();
pSVData->maGDIData.mxScreenFontCache.reset();
-pSVData->maGDIData.maScaleCache.remove_if([](const
o3tl::lru_map::key_value_pair_t&)
+pSVData->maGDIData.maScaleCache.remove_if([](const
lru_scale_cache::key_value_pair_t&)
{ return true; });
pSVData->maGDIData.maThemeDrawCommandsCache.clear();
diff --git a/vcl/source/bitmap/BitmapScaleSuperFilter.cxx
b/vcl/source/bitmap/BitmapScaleSuperFilter.cxx
index 14b18e9f7a02..ce5a968379fa 100644
--- a/vcl/source/bitmap/BitmapScaleSuperFilter.cxx
+++ b/vcl/source/bitmap/BitmapScaleSuperFilter.cxx
@@ -936,8 +936,6 @@ BitmapScaleSuperFilter::~BitmapScaleSuperFilter()
BitmapEx BitmapScaleSuperFilter::execute(BitmapEx const& rBitmap) const
{
Bitmap aBitmap(rBitmap.GetBitmap());
-SalBitmap* pKey = aBitmap.ImplGetSalBitmap().get();
-
bool bRet = false;
const Size aSizePix(rBitmap.GetSizePixel());
@@ -957,13 +955,18 @@ BitmapEx BitmapScaleSuperFilter::execute(BitmapEx const&
rBitmap) const
return BitmapEx();
// check cache for a previously scaled version of this
+ScaleCacheKey aKey(aBitmap.ImplGetSalBitmap().get(),
+ Size(nDstW, nDstH));
+
ImplSVData* pSVData = ImplGetSVData();
auto& rCache = pSVData->maGDIData.maScaleCache;
-auto aFind = rCache.find(pKey);
+auto aFind = rCache.find(aKey);
if (aFind != rCache.end())
{
if (aFind->second.GetSizePixel().Width() == nDstW &&
aFind->second.GetSizePixel().Height() == nDstH)
return aFind->second;
+else
+SAL_WARN("vcl.gdi", "Error: size mismatch in scale cache");
}
{
@@ -1090,7 +1093,7 @@ BitmapEx BitmapScaleSuperFilter::execute(BitmapEx const&
rBitmap) const
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - filter/source include/svx svx/source
filter/source/svg/svgwriter.cxx | 45 ++--
include/svx/svdograf.hxx|9
svx/source/svdraw/svdograf.cxx | 22 ---
3 files changed, 34 insertions(+), 42 deletions(-)
New commits:
commit 5aae00b8a9400dad43004081db69996c24157641
Author: Miklos Vajna
AuthorDate: Tue Feb 25 11:28:44 2020 +0100
Commit: Mike Kaganski
CommitDate: Wed Feb 26 09:59:13 2020 +0100
SVG export: try to reuse original bitmap data for JPG and PNG bitmaps
This has a number of benefits:
1) For a sample JPG photo, the SVG output is now 4,9MB, not 20MB.
2) Even the first export to SVG is fast, see commit
570be56b37e4ff105649e604ff4c8a6c368e2e79 (svx: cache PNG export of
graphic shapes, 2020-02-25) for exact numbers.
3) Allow using less memory as the SdrGrafObj doesn't have to store a PNG
result till the document is closed.
We still require matching checksums, so in case anything problematic
happens with the bitmap (grayscale filter applied, etc), then the
optimization is meant to not help, but still produces correct output.
(cherry picked from commit c7af36a6504a192f72fcd3a30712ca8c14e12fa5)
Conflicts:
include/svx/svdograf.hxx
Change-Id: Id3bc359a8dcc4c4d12d3b66ffb512cfa71939a26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89465
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Mike Kaganski
diff --git a/filter/source/svg/svgwriter.cxx b/filter/source/svg/svgwriter.cxx
index 956651e41d01..d9f7dc48bf08 100644
--- a/filter/source/svg/svgwriter.cxx
+++ b/filter/source/svg/svgwriter.cxx
@@ -2716,29 +2716,52 @@ void SVGActionWriter::ImplWriteBmp( const BitmapEx&
rBmpEx,
bool bCached = false;
SdrGrafObj* pGrafObj = nullptr;
+bool bPNG = false;
+bool bJPG = false;
if (pShape)
{
pGrafObj = GetSdrGrafObjFromXShape(pShape);
-if (pGrafObj && pGrafObj->GetPNGPreviewChecksum() ==
rBmpEx.GetChecksum())
+if (pGrafObj)
{
-const std::vector& rPreviewData =
pGrafObj->GetPNGPreviewData();
-aOStm.WriteBytes(rPreviewData.data(), rPreviewData.size());
-bCached = true;
+const Graphic& rGraphic = pGrafObj->GetGraphic();
+if (rGraphic.GetType() == GraphicType::Bitmap)
+{
+const BitmapEx& rGraphicBitmap =
rGraphic.GetBitmapExRef();
+if (rGraphicBitmap.GetChecksum() ==
rBmpEx.GetChecksum())
+{
+GfxLink aGfxLink = rGraphic.GetGfxLink();
+if (aGfxLink.GetType() == GfxLinkType::NativePng)
+{
+bPNG = true;
+}
+else if (aGfxLink.GetType() ==
GfxLinkType::NativeJpg)
+{
+bJPG = true;
+}
+if (bPNG || bJPG)
+{
+aOStm.WriteBytes(aGfxLink.GetData(),
aGfxLink.GetDataSize());
+bCached = true;
+}
+}
+}
}
}
if( bCached || GraphicConverter::Export( aOStm, rBmpEx,
ConvertDataFormat::PNG ) == ERRCODE_NONE )
{
-if (!bCached && pGrafObj)
-{
-pGrafObj->SetPNGPreviewChecksum(rBmpEx.GetChecksum());
-pGrafObj->SetPNGPreviewData(aOStm);
-}
-
PointaPt;
Size aSz;
Sequence< sal_Int8 > aSeq( static_cast(aOStm.GetData()), aOStm.Tell() );
-OUStringBuffer aBuffer( "data:image/png;base64," );
+OUStringBuffer aBuffer;
+if (bJPG)
+{
+aBuffer.append("data:image/jpeg;base64,");
+}
+else
+{
+aBuffer.append("data:image/png;base64,");
+}
::comphelper::Base64::encode( aBuffer, aSeq );
ImplMap( rPt, aPt );
diff --git a/include/svx/svdograf.hxx b/include/svx/svdograf.hxx
index 966cb3893b9b..c3e2ae0c1874 100644
--- a/include/svx/svdograf.hxx
+++ b/include/svx/svdograf.hxx
@@ -28,7 +28,6 @@
#include
#include
#include
-#include
namespace sdr
{
@@ -122,9 +121,6 @@ private:
void onGraphicChanged();
GDIMetaFile GetMetaFile(GraphicType ) const;
-BitmapChecksum mnPNGPreviewChecksum = 0;
-std::vector maPNGPreviewData;
-
protected:
//
[Libreoffice-bugs] [Bug 129619] Layout: Table breaks in unexpected places when all paragraphs marked keep-with-next (see comment 12 and comment 14)
https://bugs.documentfoundation.org/show_bug.cgi?id=129619 Timur changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|NEW See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=89 ||007 Summary|Layout: Table breaks in |Layout: Table breaks in |unexpected places when all |unexpected places when all |paragraphs marked |paragraphs marked |keep-with-next (see comment |keep-with-next (see comment |14) |12 and comment 14) --- Comment #17 from Timur --- Reporter set status Fixed, but that's reserved in Bugzilla when there was a fix, as explained in Status link. So, from Justin's explanation this is WontFix (to change code) or WorksForMe (to use with workaround). Or we may convert to Documentation type, which I prefer. But before we do it, let's clarify what's the workaround: I turned off paragraph property "keep with next" in this 10 pages .odt *but* got the same issue with table split and 11 pages when saving to .docx and reopening in LO. Note: Same commit caused bug 89007 that was resolved. It's not clear which use cases it fixed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104444] [META] DOCX (OOXML) table-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=10 Bug 10 depends on bug 129619, which changed state. Bug 129619 Summary: Layout: Table breaks in unexpected places when all paragraphs marked keep-with-next (see comment 12 and comment 14) https://bugs.documentfoundation.org/show_bug.cgi?id=129619 What|Removed |Added Status|RESOLVED|NEW Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113088] [META] Writer table properties dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113088 Bug 113088 depends on bug 129619, which changed state. Bug 129619 Summary: Layout: Table breaks in unexpected places when all paragraphs marked keep-with-next (see comment 12 and comment 14) https://bugs.documentfoundation.org/show_bug.cgi?id=129619 What|Removed |Added Status|RESOLVED|NEW Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sw/source vcl/headless vcl/inc vcl/source
sw/source/core/doc/notxtfrm.cxx | 198 +---
sw/source/core/inc/frmtool.hxx |6
sw/source/core/inc/notxtfrm.hxx |6
vcl/headless/svpbmp.cxx |7 -
vcl/headless/svpgdi.cxx | 219 +++
vcl/inc/headless/svpbmp.hxx | 26
vcl/source/outdev/bitmap.cxx| 247 +++-
7 files changed, 107 insertions(+), 602 deletions(-)
New commits:
commit 4e19d09360220a181d7bdad92e6112390ff49f39
Author: Michael Meeks
AuthorDate: Wed Feb 26 03:59:48 2020 +
Commit: Michael Meeks
CommitDate: Wed Feb 26 09:53:26 2020 +0100
Revert "tdf#130768 speedup huge pixel graphics Cairo"
This reverts commit ef6f94e93bbe55a26b67b55b2aecda67d406ab85.
Change-Id: I34d4d4782d9d9711a78c0d5a8eaf019bfcdd701c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89496
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Michael Meeks
diff --git a/sw/source/core/doc/notxtfrm.cxx b/sw/source/core/doc/notxtfrm.cxx
index f2b148361994..04e556277738 100644
--- a/sw/source/core/doc/notxtfrm.cxx
+++ b/sw/source/core/doc/notxtfrm.cxx
@@ -82,14 +82,6 @@
#include
#include
-// MM02 needed for VOC mechanism and getting the OC - may be moved to an own
file
-#include
-#include
-#include
-#include
-#include
-#include
-
using namespace com::sun::star;
static bool GetRealURL( const SwGrfNode& rNd, OUString& rText )
@@ -156,9 +148,7 @@ static void lcl_PaintReplacement( const SwRect ,
const OUString ,
SwNoTextFrame::SwNoTextFrame(SwNoTextNode * const pNode, SwFrame* pSib )
: SwContentFrame( pNode, pSib ),
// RotateFlyFrame3
-mpTransformableSwFrame(),
-// MM02
-mpViewContact()
+mpTransformableSwFrame()
{
mnFrameType = SwFrameType::NoTxt;
}
@@ -935,7 +925,6 @@ static bool paintUsingPrimitivesHelper(
return false;
}
-// MM02 original using falölback to VOC and primitive-based version
void paintGraphicUsingPrimitivesHelper(
vcl::RenderContext & rOutputDevice,
GraphicObject const& rGrfObj,
@@ -947,24 +936,12 @@ void paintGraphicUsingPrimitivesHelper(
// -> the primitive renderer will create the needed pdf export data
// -> if bitmap content, it will be cached system-dependent
drawinglayer::primitive2d::Primitive2DContainer aContent(1);
+
aContent[0] = new drawinglayer::primitive2d::GraphicPrimitive2D(
rGraphicTransform,
rGrfObj,
rGraphicAttr);
-// MM02 use primitive-based version for visualization
-paintGraphicUsingPrimitivesHelper(
-rOutputDevice,
-aContent,
-rGraphicTransform);
-}
-
-// MM02 new VOC and primitive-based version
-void paintGraphicUsingPrimitivesHelper(
-vcl::RenderContext & rOutputDevice,
-drawinglayer::primitive2d::Primitive2DContainer& rContent,
-const basegfx::B2DHomMatrix& rGraphicTransform)
-{
// RotateFlyFrame3: If ClipRegion is set at OutputDevice, we
// need to use that. Usually the renderer would be a VCL-based
// PrimitiveRenderer, but there are system-specific shortcuts that
@@ -1031,12 +1008,9 @@ void paintGraphicUsingPrimitivesHelper(
aTarget.append(aClip);
}
-drawinglayer::primitive2d::MaskPrimitive2D* pNew(
-new drawinglayer::primitive2d::MaskPrimitive2D(
-aTarget,
-rContent));
-rContent.resize(1);
-rContent[0] = pNew;
+aContent[0] = new drawinglayer::primitive2d::MaskPrimitive2D(
+aTarget,
+aContent);
}
}
@@ -1045,111 +1019,11 @@ void paintGraphicUsingPrimitivesHelper(
paintUsingPrimitivesHelper(
rOutputDevice,
-rContent,
+aContent,
aTargetRange,
aTargetRange);
}
-// DrawContact section
-namespace { // anonymous namespace
-class ViewObjectContactOfSwNoTextFrame : public sdr::contact::ViewObjectContact
-{
-protected:
-virtual drawinglayer::primitive2d::Primitive2DContainer
createPrimitive2DSequence(
-const sdr::contact::DisplayInfo& rDisplayInfo) const override;
-
-public:
-ViewObjectContactOfSwNoTextFrame(
-sdr::contact::ObjectContact& rObjectContact,
-sdr::contact::ViewContact& rViewContact);
-};
-
-class ViewContactOfSwNoTextFrame : public sdr::contact::ViewContact
-{
-private:
-// owner
-const SwNoTextFrame&mrSwNoTextFrame;
-
-protected:
-// Create an Object-Specific ViewObjectContact, set ViewContact and
-// ObjectContact. Always needs to return something.
-virtual sdr::contact::ViewObjectContact&
CreateObjectSpecificViewObjectContact(
-sdr::contact::ObjectContact& rObjectContact) override;
-
-public:
-// read-access to owner
-const SwNoTextFrame& getSwNoTextFrame() const { return mrSwNoTextFrame; }
-
-// basic constructor, used from SwNoTextFrame.
-explicit
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - vcl/source
vcl/source/outdev/bitmap.cxx | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
New commits:
commit 0b99af16f0286fce9fb410c904bea32d0e510280
Author: Michael Meeks
AuthorDate: Wed Feb 26 03:59:35 2020 +
Commit: Michael Meeks
CommitDate: Wed Feb 26 09:53:10 2020 +0100
Revert "tdf#130768 need to use mnOutOffX/mnOutOffY"
This reverts commit 1c62465ff27a5721fac7f60798e8d674fefdd2aa.
Change-Id: I48cc7069e69b98e02b67d460f55e6cba0a3297dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89495
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Michael Meeks
diff --git a/vcl/source/outdev/bitmap.cxx b/vcl/source/outdev/bitmap.cxx
index 4aba910cf599..7fe75ec21a14 100644
--- a/vcl/source/outdev/bitmap.cxx
+++ b/vcl/source/outdev/bitmap.cxx
@@ -1230,10 +1230,7 @@ void OutputDevice::DrawTransformedBitmapEx(
if(bAllowPreferDirectPaint && bTryDirectPaint)
{
-// tdf#130768 CAUTION(!) using GetViewTransformation() is *not* enough
here, it may
-// be that mnOutOffX/mnOutOffY is used - see AOO bug 75163, mentioned
at
-// ImplGetDeviceTransformation declaration
-const basegfx::B2DHomMatrix
aFullTransform(ImplGetDeviceTransformation() * rTransformation);
+const basegfx::B2DHomMatrix aFullTransform(GetViewTransformation() *
rTransformation);
if(DrawTransformBitmapExDirect(aFullTransform, rBitmapEx))
{
@@ -1280,10 +1277,7 @@ void OutputDevice::DrawTransformedBitmapEx(
// to specify order of executions, so give bTryDirectPaint a call
if(bTryDirectPaint)
{
-// tdf#130768 CAUTION(!) using GetViewTransformation() is *not* enough
here, it may
-// be that mnOutOffX/mnOutOffY is used - see AOO bug 75163, mentioned
at
-// ImplGetDeviceTransformation declaration
-const basegfx::B2DHomMatrix
aFullTransform(ImplGetDeviceTransformation() * rTransformation);
+const basegfx::B2DHomMatrix aFullTransform(GetViewTransformation() *
rTransformation);
if(DrawTransformBitmapExDirect(aFullTransform, rBitmapEx))
{
@@ -1322,10 +1316,7 @@ void OutputDevice::DrawTransformedBitmapEx(
const double fOrigArea(rOriginalSizePixel.Width() *
rOriginalSizePixel.Height() * 0.5);
const double fOrigAreaScaled(fOrigArea * 1.44);
double fMaximumArea(std::min(450.0, std::max(100.0,
fOrigAreaScaled)));
-// tdf#130768 CAUTION(!) using GetViewTransformation() is *not* enough
here, it may
-// be that mnOutOffX/mnOutOffY is used - see AOO bug 75163, mentioned at
-// ImplGetDeviceTransformation declaration
-basegfx::B2DHomMatrix aFullTransform(ImplGetDeviceTransformation() *
rTransformation);
+basegfx::B2DHomMatrix aFullTransform(GetViewTransformation() *
rTransformation);
if(!bMetafile)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtk3gtkinst.cxx | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
New commits:
commit 813217dee1d809a2c33785c9024dc42671696067
Author: Caolán McNamara
AuthorDate: Tue Feb 25 15:23:38 2020 +
Commit: Caolán McNamara
CommitDate: Wed Feb 26 09:52:50 2020 +0100
only call enter/leave page when not changing programatically
which is how the vcl version traditionally works, this results
in the "General" tab in the basic dialog editor 'sticking' as the
the default page
Change-Id: I2bc88093df48724c32c99add5234968fa672e4a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89463
Tested-by: Jenkins
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index e6c80ab1a456..1e93792e7778 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -5694,6 +5694,7 @@ private:
guint m_nLaunchSplitTimeoutId;
bool m_bOverFlowBoxActive;
bool m_bOverFlowBoxIsStart;
+bool m_bInternalPageChange;
int m_nStartTabCount;
int m_nEndTabCount;
mutable std::vector> m_aPages;
@@ -5726,7 +5727,7 @@ private:
nNewPage += nOverFlowLen;
}
-bool bAllow = !m_aLeavePageHdl.IsSet() ||
m_aLeavePageHdl.Call(get_current_page_ident());
+bool bAllow = m_bInternalPageChange || !m_aLeavePageHdl.IsSet() ||
m_aLeavePageHdl.Call(get_current_page_ident());
if (!bAllow)
{
g_signal_stop_emission_by_name(m_pNotebook, "switch-page");
@@ -5735,7 +5736,8 @@ private:
if (m_bOverFlowBoxActive)
gtk_notebook_set_current_page(m_pOverFlowNotebook,
gtk_notebook_get_n_pages(m_pOverFlowNotebook) - 1);
OString sNewIdent(get_page_ident(nNewPage));
-m_aEnterPageHdl.Call(sNewIdent);
+if (!m_bInternalPageChange)
+m_aEnterPageHdl.Call(sNewIdent);
}
void unsplit_notebooks()
@@ -6133,6 +6135,7 @@ public:
, m_nLaunchSplitTimeoutId(0)
, m_bOverFlowBoxActive(false)
, m_bOverFlowBoxIsStart(false)
+, m_bInternalPageChange(false)
, m_nStartTabCount(0)
, m_nEndTabCount(0)
{
@@ -6234,6 +6237,13 @@ public:
virtual void set_current_page(int nPage) override
{
+// normally we'd call disable_notify_events/enable_notify_events here,
+// but the notebook is complicated by the need to support the
+// double-decker hackery so for simplicity just flag that the page
+// change is not a directly user-triggered one
+bool bInternalPageChange = m_bInternalPageChange;
+m_bInternalPageChange = true;
+
if (m_bOverFlowBoxIsStart)
{
auto nOverFlowLen = m_bOverFlowBoxActive ?
gtk_notebook_get_n_pages(m_pOverFlowNotebook) - 1 : 0;
@@ -6256,6 +6266,8 @@ public:
gtk_notebook_set_current_page(m_pOverFlowNotebook, nPage);
}
}
+
+m_bInternalPageChange = bInternalPageChange;
}
virtual void set_current_page(const OString& rIdent) override
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 130500] Add Sukapura icon Theme to Core and Set It to Default for macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=130500 --- Comment #8 from Rizal Muttaqin --- (In reply to Rizal Muttaqin from comment #0) > - As I write this bug report, Sukapura could be considered 99% finished. So > it will not fallback to other theme. The last things that should be taken > care is adding localization support for some of formatting toolbar (B,I,U, > etc). As I reply this and the icon was submitted, now localization support has been finished also. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: basctl/source
basctl/source/basicide/linenumberwindow.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit ca79c018f1e8bd0e1f42e3cef4b4f5893ef2e47f
Author: Caolán McNamara
AuthorDate: Tue Feb 25 15:55:24 2020 +
Commit: Caolán McNamara
CommitDate: Wed Feb 26 09:51:11 2020 +0100
tdf#130925 use the maximum document line number for the width calculation
not the max line number in the range currently getting rendered
Change-Id: I447e4152ef6a1ec327a95a8260d1616940e5d6c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89467
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/basctl/source/basicide/linenumberwindow.cxx
b/basctl/source/basicide/linenumberwindow.cxx
index 79c124117c97..4fa6ebf8f5aa 100644
--- a/basctl/source/basicide/linenumberwindow.cxx
+++ b/basctl/source/basicide/linenumberwindow.cxx
@@ -73,7 +73,8 @@ void LineNumberWindow::Paint( vcl::RenderContext&
rRenderContext, const tools::R
// reserve enough for 3 digit minimum, with a bit to spare for comfort
m_nWidth = m_nBaseWidth * 3 + m_nBaseWidth / 2;
-sal_uInt32 i = (nEndLine + 1) / 1000;
+auto nMaxLineNumber = std::max(nEndLine, txtEngine->GetParagraphCount() +
1);
+sal_uInt32 i = (nMaxLineNumber + 1) / 1000;
while (i)
{
i /= 10;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: basctl/source
basctl/source/basicide/moduldlg.cxx |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
New commits:
commit 9f6be5d9ce3f2ffb7180aa4bda4bd575fd9928e5
Author: Caolán McNamara
AuthorDate: Tue Feb 25 15:23:24 2020 +
Commit: Caolán McNamara
CommitDate: Wed Feb 26 09:51:34 2020 +0100
explicitly call ActivatePageHdl when programatically calling
set_current_page
Change-Id: I6113e51565cf4f89e77829f56e08f6b98f2fe244
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89462
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/basctl/source/basicide/moduldlg.cxx
b/basctl/source/basicide/moduldlg.cxx
index 2e7191ee8abe..2cd8bd8009b3 100644
--- a/basctl/source/basicide/moduldlg.cxx
+++ b/basctl/source/basicide/moduldlg.cxx
@@ -192,12 +192,15 @@ OrganizeDialog::OrganizeDialog(weld::Window* pParent,
sal_Int16 tabId )
{
m_xTabCtrl->connect_enter_page(LINK(this, OrganizeDialog,
ActivatePageHdl));
+OString sPage;
if (tabId == 0)
-m_xTabCtrl->set_current_page("modules");
+sPage = "modules";
else if (tabId == 1)
-m_xTabCtrl->set_current_page("dialogs");
+sPage = "dialogs";
else
-m_xTabCtrl->set_current_page("libraries");
+sPage = "libraries";
+m_xTabCtrl->set_current_page(sPage);
+ActivatePageHdl(sPage);
if (SfxDispatcher* pDispatcher = GetDispatcher())
pDispatcher->Execute( SID_BASICIDE_STOREALLMODULESOURCES );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtk3gtkinst.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 4c15615d348f184ccc9d6f126f0840cec40e8e2c
Author: Caolán McNamara
AuthorDate: Tue Feb 25 17:06:39 2020 +
Commit: Caolán McNamara
CommitDate: Wed Feb 26 09:51:59 2020 +0100
leave "skipped" events available to gtk parent handler
Change-Id: I6cf4b8b308ec41a46aeb6b48554d87a2fa316d85
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89475
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 155472a91532..e6c80ab1a456 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -2058,7 +2058,7 @@ private:
gdk_event_free(pPeekEvent);
if (bSkip)
{
-return true;
+return false;
}
}
nEventType = SalEvent::MouseButtonDown;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 130949] New: Calc become very slow when using named ranges
https://bugs.documentfoundation.org/show_bug.cgi?id=130949 Bug ID: 130949 Summary: Calc become very slow when using named ranges Product: LibreOffice Version: 6.3.5.2 release Hardware: x86-64 (AMD64) OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: koleden...@gmail.com Description: When i set named range and use it into calculation, every interaction with that sheet become very slow (scrolling, opening sheet) Steps to Reproduce: 1.Make new spreadsheet 2.Put some number like 9,5 into cell a1 3.Set name for this cell like "some_named_cell" 4.Add sheet to that spreadsheet 5. Set some number like 100 into a1 6. Set formula =a1*some_named_cell into B1 7. Try to scroll page and open system monitor to view than libreoffice takes 100% cpu while interacting with Actual Results: Lags and slowdowns each time i open sheet with formula that includes named range Expected Results: Smooth and fast working (scrolling, sheet switching) Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Версия: 6.4.0.3 ID сборки: b0a288ab3d2d4774cb44b62f04d5d28733ac6df8 Потоков ЦП: 4; ОС: Mac OS X 10.13.6; Отрисовка ИП: по умолчанию; VCL: osx; Локаль: ru-RU (ru_RU.UTF-8); Язык интерфейса: ru-RU Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 127508] I cannot disable effect from highlighted/normal column/row header
https://bugs.documentfoundation.org/show_bug.cgi?id=127508 --- Comment #26 from Commit Notification --- Heiko Tietze committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d8c7864407249fd1ed69713dfdf4fa533a9efb0b Resolves tdf#127508 - Flat table header in Calc It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 127508] I cannot disable effect from highlighted/normal column/row header
https://bugs.documentfoundation.org/show_bug.cgi?id=127508 Commit Notification changed: What|Removed |Added Whiteboard|target:6.4.0|target:6.4.0 target:7.0.0 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 42082] [META] Make LibreOffice shine and glow on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=42082 Bug 42082 depends on bug 130500, which changed state. Bug 130500 Summary: Add Sukapura icon Theme to Core and Set It to Default for macOS https://bugs.documentfoundation.org/show_bug.cgi?id=130500 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 130500] Add Sukapura icon Theme to Core and Set It to Default for macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=130500 Heiko Tietze changed: What|Removed |Added Resolution|--- |FIXED Assignee|heiko.tietze@documentfounda |riz_17_...@yahoo.co.id |tion.org| Status|ASSIGNED|RESOLVED -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: sc/source
sc/source/ui/inc/tabview.hxx |3 +--
sc/source/ui/view/tabview.cxx | 35 ---
2 files changed, 5 insertions(+), 33 deletions(-)
New commits:
commit d8c7864407249fd1ed69713dfdf4fa533a9efb0b
Author: Heiko Tietze
AuthorDate: Mon Feb 24 17:15:11 2020 +0100
Commit: Mike Kaganski
CommitDate: Wed Feb 26 09:33:53 2020 +0100
Resolves tdf#127508 - Flat table header in Calc
Amends 67fd62b3edc86c2891f279b25cf9919c4ca1 with
flat corner button
Change-Id: Ia26aff0844069dd435cf4edd7524c19f5f0f22ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89365
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sc/source/ui/inc/tabview.hxx b/sc/source/ui/inc/tabview.hxx
index dc65f970d78e..8a8d3e9125cc 100644
--- a/sc/source/ui/inc/tabview.hxx
+++ b/sc/source/ui/inc/tabview.hxx
@@ -71,14 +71,13 @@ class ScCornerButton : public vcl::Window
{
private:
ScViewData* const pViewData;
-bool constbAdd;
protected:
virtual voidPaint( vcl::RenderContext& rRenderContext, const
tools::Rectangle& rRect ) override;
virtual voidResize() override;
virtual voidMouseButtonDown( const MouseEvent& rMEvt ) override;
public:
-ScCornerButton( vcl::Window* pParent, ScViewData* pData,
bool bAdditional );
+ScCornerButton( vcl::Window* pParent, ScViewData* pData );
virtual ~ScCornerButton() override;
virtual voidStateChanged( StateChangedType nType ) override;
diff --git a/sc/source/ui/view/tabview.cxx b/sc/source/ui/view/tabview.cxx
index 53e03e61de07..f45a575ec461 100644
--- a/sc/source/ui/view/tabview.cxx
+++ b/sc/source/ui/view/tabview.cxx
@@ -68,10 +68,9 @@ using namespace ::com::sun::star;
// Corner-Button
-ScCornerButton::ScCornerButton( vcl::Window* pParent, ScViewData* pData, bool
bAdditional ) :
+ScCornerButton::ScCornerButton( vcl::Window* pParent, ScViewData* pData ) :
Window( pParent, WinBits( 0 ) ),
-pViewData( pData ),
-bAdd( bAdditional )
+pViewData( pData )
{
EnableRTL( false );
}
@@ -94,32 +93,6 @@ void ScCornerButton::Paint(vcl::RenderContext&
rRenderContext, const tools::Rect
bool bLayoutRTL = pViewData->GetDocument()->IsLayoutRTL(
pViewData->GetTabNo() );
long nDarkX = bLayoutRTL ? 0 : nPosX;
-if (!bAdd)
-{
-// match the shaded look of column/row headers
-
-Color aFace(rStyleSettings.GetFaceColor());
-Color aWhite(COL_WHITE);
-Color aCenter(aFace);
-aCenter.Merge(aWhite, 0xd0); // lighten up a bit
-Color aOuter(aFace );
-aOuter.Merge(aWhite, 0xa0); // lighten up more
-
-long nCenterX = (aSize.Width() / 2) - 1;
-long nCenterY = (aSize.Height() / 2) - 1;
-
-rRenderContext.SetLineColor();
-rRenderContext.SetFillColor(aCenter);
-rRenderContext.DrawRect(tools::Rectangle(nCenterX, nCenterY, nCenterX,
nPosY));
-rRenderContext.DrawRect(tools::Rectangle(nCenterX, nCenterY, nDarkX,
nCenterY));
-rRenderContext.SetFillColor(aOuter);
-rRenderContext.DrawRect(tools::Rectangle(0, 0, nPosX, nCenterY - 1));
-if (bLayoutRTL)
-rRenderContext.DrawRect(tools::Rectangle(nCenterX + 1, nCenterY,
nPosX, nPosY));
-else
-rRenderContext.DrawRect(tools::Rectangle(0, nCenterY, nCenterX -
1, nPosY));
-}
-
// both buttons have the same look now - only dark right/bottom lines
rRenderContext.SetLineColor(rStyleSettings.GetDarkShadowColor());
rRenderContext.DrawLine(Point(0, nPosY), Point(nPosX, nPosY));
@@ -201,8 +174,8 @@ ScTabView::ScTabView( vcl::Window* pParent, ScDocShell&
rDocSh, ScTabViewShell*
aVScrollBottom( VclPtr::Create( pFrameWin, WinBits( WB_VSCROLL
| WB_DRAG ) ) ),
aHScrollLeft( VclPtr::Create( pFrameWin, WinBits( WB_HSCROLL |
WB_DRAG ) ) ),
aHScrollRight( VclPtr::Create( pFrameWin, WinBits( WB_HSCROLL |
WB_DRAG ) ) ),
-aCornerButton( VclPtr::Create( pFrameWin, ,
false ) ),
-aTopButton( VclPtr::Create( pFrameWin, , true )
),
+aCornerButton( VclPtr::Create( pFrameWin, ) ),
+aTopButton( VclPtr::Create( pFrameWin, ) ),
aScrollBarBox( VclPtr::Create( pFrameWin, WB_SIZEABLE ) ),
mxInputHintOO(),
pTimerWindow( nullptr ),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 107733] [META] Hyperlink bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107733 Samuel Mehrbrodt (CIB) changed: What|Removed |Added Depends on||130760 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=130760 [Bug 130760] Impress crashes on broken hyperlink click -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130948] different bug
https://bugs.documentfoundation.org/show_bug.cgi?id=130948 Jayaseela Murugan changed: What|Removed |Added Resolution|--- |INVALID Status|UNCONFIRMED |RESOLVED --- Comment #1 from Jayaseela Murugan --- Nevas Technologies specializes in Microsoft Dynamics GP (Great Plains). Our Microsoft Dynamics GP support team can provide support, no matter your version of Dynamics GP, we offer support plans for all Dynamics GP modules and ISV applications. Our team of experts provides flexible support plans, from Dynamics GP support to full IT infrastructure support. https://www.nevastech.com/solutions/microsoft-dynamics-erp/microsoft-dynamics-gp/dynamics-gp-support -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 130500] Add Sukapura icon Theme to Core and Set It to Default for macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=130500 --- Comment #7 from Commit Notification --- Heiko Tietze committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a8c3addfce4df0fa8278d83764148d4aec40b36e Resolves tdf#130500 - Sukapura icon theme It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 130500] Add Sukapura icon Theme to Core and Set It to Default for macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=130500 Commit Notification changed: What|Removed |Added Whiteboard||target:7.0.0 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 130948] New: different bug
https://bugs.documentfoundation.org/show_bug.cgi?id=130948 Bug ID: 130948 Summary: different bug Product: cppunit Version: 1.13 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: General Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jayaseelamuru...@hotmail.com CC: markus.mohrh...@googlemail.com -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: .clang-format
.clang-format |1 + 1 file changed, 1 insertion(+) New commits: commit 6397a0d49c1672eadf2408e2deac8399322e3013 Author: Miklos Vajna AuthorDate: Tue Feb 25 21:11:51 2020 +0100 Commit: Miklos Vajna CommitDate: Wed Feb 26 09:12:49 2020 +0100 clang-format: don't sort using declarations Our clang-format-5.0.0 does sorting in a way different to clang-format from git, so prepare for that unwanted change now. There are two differences: - newer clang-format does uniq sort - the ordering also differs, e.g. 'librevenge::RVNGInputStream' used to be ordered before 'librevenge::RVNG_SEEK_CUR', now it's ordered after that Turning the sorting off is always possible, i.e. running solenv/clang-format/reformat-formatted-files after this change results in no changes. Change-Id: I146874d4d5a9ad1c45826285fdc798fec77d6ade Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89480 Tested-by: Jenkins Reviewed-by: Miklos Vajna diff --git a/.clang-format b/.clang-format index d16c2f72d040..16fd8b1263e7 100644 --- a/.clang-format +++ b/.clang-format @@ -45,3 +45,4 @@ SpaceAfterControlStatementKeyword: true SpaceBeforeAssignmentOperators: true ContinuationIndentWidth: 4 SortIncludes: false +SortUsingDeclarations: false ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 130947] New: elementary: Missing Merge Cells dialog icons
https://bugs.documentfoundation.org/show_bug.cgi?id=130947 Bug ID: 130947 Summary: elementary: Missing Merge Cells dialog icons Product: LibreOffice Version: 6.4.0.0.alpha0+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: riz_17_...@yahoo.co.id Created attachment 158194 --> https://bugs.documentfoundation.org/attachment.cgi?id=158194=edit Mergce Cells dialog fallback to Colibre Description: elementary icon theme have no images for Merge Cells dialog in Calc, they are fallbacked to Colibre (another finding related to tdf#130939) I suggest to provide the icons Steps to Reproduce: 1. Set elementary icon theme 2. Open Calc 3. Merge two cells 4. Look at these icons in Merge Cells dialog Actual Results: Icons are fallbacked Colibre Expected Results: elementary have its owns icons Reproducible: Always User Profile Reset: No Version: 7.0.0.0.alpha0+ Build ID: a545e25314d464c190d9d504d78ec6cb67ead4fd CPU threads: 4; OS: Linux 4.20; UI render: default; VCL: kf5; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-02-20_15:31:00 Locale: id-ID (id_ID.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106228] [META] Icon theme issues
https://bugs.documentfoundation.org/show_bug.cgi?id=106228 Bug 106228 depends on bug 125794, which changed state. Bug 125794 Summary: Bad-looking Show Draw Functions icon in Elementary icon set https://bugs.documentfoundation.org/show_bug.cgi?id=125794 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125794] Bad-looking Show Draw Functions icon in Elementary icon set
https://bugs.documentfoundation.org/show_bug.cgi?id=125794 Rizal Muttaqin changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
