[Libreoffice-bugs] [Bug 132551] Calc Fill Handle cell function fails with negative numbers in strings

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132551

--- Comment #2 from chebser  ---
Created attachment 160120
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160120=edit
Incorrect value

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132551] Calc Fill Handle cell function fails with negative numbers in strings

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132551

--- Comment #1 from chebser  ---
Created attachment 160119
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160119=edit
Prompt bubble

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132551] New: Calc Fill Handle cell function fails with negative numbers in strings

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132551

Bug ID: 132551
   Summary: Calc Fill Handle cell function fails with negative
numbers in strings
   Product: LibreOffice
   Version: 6.3.5.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: s.chebo...@gmail.com

Description:
Filling cells with strings containing negative numbers using fill handle causes
decrementing of number value instead of incrementing. 
However value in prompt bubble shows correct value.


Steps to Reproduce:
1. Fill the cell with negative number and some text. For examle "-1 level"
2. Drag the fill handle marker to the next cell

Actual Results:
-2 level

Expected Results:
0 level


Reproducible: Always


User Profile Reset: No



Additional Info:
Версия: 6.3.5.2 (x64)
ID сборки: dd0751754f11728f69b42ee2af66670068624673
Потоков ЦП: 4; ОС: Windows 10.0; Отрисовка ИП: по умолчанию; VCL: win; 
Локаль: ru-RU (ru_RU); Язык интерфейса: ru-RU
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132550] New: PDF: Viewer opens too soon before PDF is exported.

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132550

Bug ID: 132550
   Summary: PDF: Viewer opens too soon before PDF is exported.
   Product: LibreOffice
   Version: 6.1.5.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: hans...@ib-lederer.de

Description:
I have set the LO option Load/Save, General, Edit doc properties before saving 
and for PDF export “View PDF after export“.  
When exporting a PDF, the doc properties dialog also opens and the PDF viewer
is opened at the same time, *before* I have OKed the properties and thus
exported the PDF.  

Steps to Reproduce:
1. Open a document, set options to edit document properties before saving and
to view PDF after export. 
2. Export it to PDF (does not exist yet).  
3. Doc properties dialog opens.  
4. Click OK — the PDF is generated but not opened.  
5. Export it again, Yes to overwrite. 
6. The *old* PDF is opened and the doc properties dialog opens.
7. Click OK —  now it depends on the viewer and the file system whether the PDF
is overwritten and its view refreshed, or the PDF cannot be overwritten.  

Actual Results:
The PDF viewer is started before actually exporting, while the doc properties
dialog is still open.

Expected Results:
The PDF viewer should be started only after the doc properties dialog is closed
and the PDF is actually exported.


Reproducible: Always


User Profile Reset: No



Additional Info:
This bug was not present in older LO versions.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132398] Adopt new application icons for LibreOffice 7.0

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132398

--- Comment #15 from Heiko Tietze  ---
Created attachment 160118
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160118=edit
Application main icon

My attempt for a nice app icon.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 132398] Adopt new application icons for LibreOffice 7.0

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132398

--- Comment #15 from Heiko Tietze  ---
Created attachment 160118
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160118=edit
Application main icon

My attempt for a nice app icon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-commits] core.git: sd/source slideshow/source vcl/unx

2020-04-30 Thread Andrea Gelmini (via logerrit)
 sd/source/core/sdpage2.cxx|2 +-
 sd/source/ui/func/fumorph.cxx |2 +-
 slideshow/source/engine/slideshowimpl.cxx |2 +-
 vcl/unx/generic/window/salframe.cxx   |2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 97e85db82e56c3d1cba6fb10842ffb85cd804a8d
Author: Andrea Gelmini 
AuthorDate: Thu Apr 30 10:36:27 2020 +0200
Commit: Julien Nabet 
CommitDate: Thu Apr 30 11:54:15 2020 +0200

Fix typos

Change-Id: I380b85646a62c4eafa40fdb5257060fac040feb6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93195
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/sd/source/core/sdpage2.cxx b/sd/source/core/sdpage2.cxx
index d5e23641ae1a..b477b03e1930 100644
--- a/sd/source/core/sdpage2.cxx
+++ b/sd/source/core/sdpage2.cxx
@@ -222,7 +222,7 @@ void SdPage::SetPresentationLayout(const OUString& 
rLayoutName,
 else if (pObj->GetObjInventor() == SdrInventor::Default &&
  pObj->GetObjIdentifier() == OBJ_TITLETEXT)
 {
-// We do net get PresObjKind via GetPresObjKind() since there are
+// We do not get PresObjKind via GetPresObjKind() since there are
 // only PresObjListe considered. But we want to consider all "Title
 // objects" here (paste from clipboard etc.)
 SfxStyleSheet* pSheet = 
GetStyleSheetForPresObj(PresObjKind::Title);
diff --git a/sd/source/ui/func/fumorph.cxx b/sd/source/ui/func/fumorph.cxx
index de8dd06787f2..812d2d68b484 100644
--- a/sd/source/ui/func/fumorph.cxx
+++ b/sd/source/ui/func/fumorph.cxx
@@ -85,7 +85,7 @@ void FuMorph::DoExecute( SfxRequest& )
 SdrObject*  
pCloneObj1(pObj1->CloneSdrObject(pObj1->getSdrModelFromSdrObject()));
 SdrObject*  
pCloneObj2(pObj2->CloneSdrObject(pObj2->getSdrModelFromSdrObject()));
 
-// delete text at clone, otherwise we do net get a correct PathObj
+// delete text at clone, otherwise we do not get a correct PathObj
 pCloneObj1->SetOutlinerParaObject(nullptr);
 pCloneObj2->SetOutlinerParaObject(nullptr);
 
diff --git a/slideshow/source/engine/slideshowimpl.cxx 
b/slideshow/source/engine/slideshowimpl.cxx
index a0c652450bcb..214084710fad 100644
--- a/slideshow/source/engine/slideshowimpl.cxx
+++ b/slideshow/source/engine/slideshowimpl.cxx
@@ -1398,7 +1398,7 @@ void SlideShowImpl::registerUserPaintPolygons( const 
uno::Reference< lang::XMult
 }
 
 // ODF defaults from ctor of SdrLayer are not automatically set on the here
-// created XLayer. Need to be done explicitely here.
+// created XLayer. Need to be done explicitly here.
 aPropLayer <<= true;
 xDrawnInSlideshow->setPropertyValue("IsVisible", aPropLayer);
 xDrawnInSlideshow->setPropertyValue("IsPrintable", aPropLayer);
diff --git a/vcl/unx/generic/window/salframe.cxx 
b/vcl/unx/generic/window/salframe.cxx
index 94efbcd72f53..a246a975a3d5 100644
--- a/vcl/unx/generic/window/salframe.cxx
+++ b/vcl/unx/generic/window/salframe.cxx
@@ -1934,7 +1934,7 @@ void X11SalFrame::SetPosSize( const tools::Rectangle 
 )
 if( values.width != static_cast(maGeometry.nWidth) || values.height 
!= static_cast(maGeometry.nHeight) )
 bSized = true;
 
-// do net set WMNormalHints for ..
+// do not set WMNormalHints for...
 if(
 // child windows
 ! IsChildWindow()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/source

2020-04-30 Thread Andrea Gelmini (via logerrit)
 sw/source/filter/ww8/ww8par.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8aedb081e731da66191fe13b65e94a1009c815dc
Author: Andrea Gelmini 
AuthorDate: Thu Apr 30 10:43:03 2020 +0200
Commit: Julien Nabet 
CommitDate: Thu Apr 30 11:53:03 2020 +0200

Update name pReffedStck to xReffedStck

In commit 2a72602824bf8aec44319e7fb9fe6dd3cebc72b3 it was updated

Change-Id: I2dbc799f379805b94055e229606d032dc802d6fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90875
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/sw/source/filter/ww8/ww8par.hxx b/sw/source/filter/ww8/ww8par.hxx
index 0149c3a13f76..87156c52800d 100644
--- a/sw/source/filter/ww8/ww8par.hxx
+++ b/sw/source/filter/ww8/ww8par.hxx
@@ -1117,7 +1117,7 @@ private:
 This stack is for fields whose true conversion cannot be determined until
 the end of the document, it is the same stack for headers/footers/main
 text/textboxes/tables etc... They are things that reference other things
-e.g. NoteRef and Ref, they are processed after pReffedStck
+e.g. NoteRef and Ref, they are processed after m_xReffedStck
 */
 std::unique_ptr m_xReffingStck;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 132548] PDF: export gets wrong modification date

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132548

--- Comment #2 from HansPL  ---
On further experimenting:  this seems to happen when the ODT resides on a Samba
share, where an older PDF already exists to be overwritten or I enter a
different name for the export.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132478] Semi-transparent areas have white lines when using newline

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132478

--- Comment #3 from Ole Tange  ---
Repro in:

Version: 6.4.3.2 (x64)
Build ID: 747b5d0ebf89f41c860ec2a39efd7cb15b54f2d8
CPU tråde: 8; Styresystem: Windows 10.0 Build 18363; Gengiver af
brugergrænseflade: Standard; VCL: win; 
Lokalisering: da-DK (da_DK); Sprog for brugergrænseflade: da-DK
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132548] PDF: export gets wrong modification date

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132548

--- Comment #1 from HansPL  ---
Created attachment 160117
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160117=edit
A document with such a field.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 39270] Borders as graphics / Decorative borders

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=39270

--- Comment #8 from concretepatiolasvega...@gmail.com ---
Great results in this base, we can relate on so many levels. 
https://www.homeremodelingsandiego.com/hardscape-remodeling

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132549] Tempo traveller on rent in delhi

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132549

hemkundtra...@gmail.com changed:

   What|Removed |Added

URL||https://www.hemkundtravels.
   ||com/tempo-traveller

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132549] New: Tempo traveller on rent in delhi

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132549

Bug ID: 132549
   Summary: Tempo traveller on rent in delhi
   Product: LibreOffice
   Version: 3.3.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android Viewer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: hemkundtra...@gmail.com

Description:
In the event that you are searching for 9 Seater Tempo Traveller Hire in Delhi
then you have come to the correct place. We at hemkundtravels.com offer the
comfortable 9 Seater Tempo Traveller on Rent from Delhi to different
destinations in India.

Actual Results:
travel

Expected Results:
travel


Reproducible: Always


User Profile Reset: No



Additional Info:
travel

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129370] LibreOffice does not get restored on boot via X Session Management Protocol

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129370

Buovjaga  changed:

   What|Removed |Added

   Severity|normal  |minor
   Priority|medium  |low
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||ilmari.lauhakangas@libreoff
   ||ice.org
 Whiteboard| QA:needsComment|

--- Comment #1 from Buovjaga  ---
Confirmed.

Arch Linux 64-bit
Version: 6.4.3.2
Build ID: 6.4.3-1
CPU threads: 8; OS: Linux 5.6; UI render: default; VCL: kf5; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132548] New: PDF: export gets wrong modification date

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132548

Bug ID: 132548
   Summary: PDF: export gets wrong modification date
   Product: LibreOffice
   Version: 6.1.5.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: hans...@ib-lederer.de

Description:
When exporting an ODT text document to PDF, data fields with the modification
date are exported showing the current date instead of the correct modification
date.  

Steps to Reproduce:
1. Create a text document with a data field Document Info: Modified; save it.
(Option “Printing sets Document modified” is disabled.)  
2. Wait a day (or fiddle with your system’s date). 
3. Open it again:  the data field shows the old date of saving. 
4. Export it to PDF:  the PDF shows the current date *WRONG* 
5. LO still shows the old date of saving. 
6. Print to an printer:  the printout shows the old date of saving. *CORRECT*
7. Close the document:  LO asks to save it although option “Printing sets
Document modified” is disabled.  

Actual Results:
The PDF shows the current date *WRONG* 

Expected Results:
The PDF should show the modification date (of last saving).  


Reproducible: Always


User Profile Reset: No



Additional Info:
A workaround seems to be to open the document read-only for exporting.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: Building skia with clang(-cl)

2020-04-30 Thread Miklos Vajna
Hi Thorsten,

On Thu, Apr 23, 2020 at 04:42:17PM +0200, Thorsten Behrens 
 wrote:
> No objections, but I'd much prefer to have release and normal builds
> use the same compiler then. If it's easy to add in VS2019, let's make
> it a prerequisite & fail hard otherwise.

Now  implements this
idea. Next step is to have build bot owners actually install clang-cl,
so the change can go in without causing problems, I guess.

Regards,

Miklos


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 132515] MYSQL/MariaDB native connector: Unknown Column Type when opening table

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132515

--- Comment #3 from hojp  ---
I am using debian testing.

libreoffice-base 1:6.4.3-1
libreoffice-mysql-connector 1:6.4.3-1

I have not tested this setting with mysql server nor will this be easily
possible.

In earlier years this worked with mysql server. However, there is also no bug
with mariadb and LO 6.0.7.3 (same base file and same database) on ubuntu 18.04.

The bug also does not show in the debian 6.4.3-1 setting, if I connect to the
database via mariadb ODBC driver.

Therefore, I guess that the bug is connected to the ibreoffice-mysql-connector
in its newer version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132478] Semi-transparent areas have white lines when using newline

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132478

--- Comment #2 from Ole Tange  ---
Repro in:

Version: 6.3.3.2 (x64)
Build ID: a64200df03143b798afd1ec74a12ab50359878ed
CPU tråde: 8; Styresystem: Windows 10.0; Gengiver af brugergrænseflade:
Standard; VCL: win; 
Lokalisering: da-DK (da_DK); Sprog for brugergrænseflade: da-DK
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132547] Date conversion from HSQLDB to Firebird

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132547

--- Comment #6 from Alex Thurgood  ---
And please read also this :

https://wiki.documentfoundation.org/Documentation/HowTo/MigrateFromHSQLDB

which explains that you have to prepare your hsqldb database before migration
to take account of the differences in date/time handling between HSQLDB and
Firebird.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132547] Date conversion from HSQLDB to Firebird

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132547

Alex Thurgood  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #5 from Alex Thurgood  ---
@Chartagnat : please provide us with a sample hsqldb file against which we can
test and try to reproduce the migration failure.

Please also indicate your timezone and any daylight savings change applicable.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132547] Date conversion from HSQLDB to Firebird

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132547

--- Comment #4 from Alex Thurgood  ---
Also, please read the information at this link for more general caveats of what
is, and isn't supported :

https://wiki.documentfoundation.org/Documentation/FirebirdMigration

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 127854] Add ability to keep vector image and compress replacement image in image compression dialog

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127854

Miklos Vajna  changed:

   What|Removed |Added

 CC||michael.st...@cib.de

--- Comment #11 from Miklos Vajna  ---
Michael Stahl may have an opinion on this; the answer may depend on the ODF
version. Perhaps support for SVG is a reasonable expectation for ODF 1.3, but
not for ODF 1.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132177] SHAPES: scrolling text not running

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132177

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 132177] SHAPES: scrolling text not running

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132177

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 110746] [META] Options dialog's View settings bugs and enhancements

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=110746

Dieter  changed:

   What|Removed |Added

 Depends on||132274


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=132274
[Bug 132274] Writer does not allow a user-set default view/zoom (overwriting
the zoom level stored in a document, that is used by default)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132274] Writer does not allow a user-set default view/zoom (overwriting the zoom level stored in a document, that is used by default)

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132274

Dieter  changed:

   What|Removed |Added

 Blocks||110746


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=110746
[Bug 110746] [META] Options dialog's View settings bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 127854] Add ability to keep vector image and compress replacement image in image compression dialog

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127854

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org,
   ||vmik...@collabora.com
   Keywords|needsUXEval |
 Ever confirmed|0   |1

--- Comment #10 from Heiko Tietze  ---
Both SVG and PNG are stored in the document. It looks like this



PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiIHN0YW5kYWxvbmU9Im5vIj8+
...


iVBORw0KGgoNSUhEUgAAAVoAAABCCAYWox40AAApCUlEQVR4nO2dBZAURxuGA9zh
...

I cannot imagine a sane workflow where the converted/compressed PNG can be
reassigned/recompressed from the SVG. What definitely works is when the PNG
would be solely saved for compatibility reason and the SVG is being used in the
document.

However, the issue remains that documents grow rapidly and I wonder if a
compatibility flag makes sense. Something like Tools > Options > Writer >
Compatibility "[ ] Save vector graphics as PNG" (off by default, IMHO). 

What do you think, Miklos?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 127854] Add ability to keep vector image and compress replacement image in image compression dialog

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127854

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org,
   ||vmik...@collabora.com
   Keywords|needsUXEval |
 Ever confirmed|0   |1

--- Comment #10 from Heiko Tietze  ---
Both SVG and PNG are stored in the document. It looks like this



PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiIHN0YW5kYWxvbmU9Im5vIj8+
...


iVBORw0KGgoNSUhEUgAAAVoAAABCCAYWox40AAApCUlEQVR4nO2dBZAURxuGA9zh
...

I cannot imagine a sane workflow where the converted/compressed PNG can be
reassigned/recompressed from the SVG. What definitely works is when the PNG
would be solely saved for compatibility reason and the SVG is being used in the
document.

However, the issue remains that documents grow rapidly and I wonder if a
compatibility flag makes sense. Something like Tools > Options > Writer >
Compatibility "[ ] Save vector graphics as PNG" (off by default, IMHO). 

What do you think, Miklos?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 102945] Base table: entering a default value for a date in the design view gives a wrong value in the table view

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102945

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||2547

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132547] Date conversion from HSQLDB to Firebird

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132547

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||2945

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132547] Date conversion from HSQLDB to Firebird

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132547

--- Comment #3 from Alex Thurgood  ---
I seem to recall that this is already known, due to the fact that HSQLDB takes
into account timezones when storing a date, whereas Firebird (did) does not, or
the mechanisms for doing so were different (and not implemented in the
migration assistant).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'feature/drawinglayercore' - 3 commits - include/vcl vcl/CppunitTest_vcl_type_serializer_test.mk vcl/inc vcl/qa vcl/source

2020-04-30 Thread Tomaž Vajngerl (via logerrit)
 include/vcl/filter/pdfdocument.hxx  |   29 -
 vcl/CppunitTest_vcl_type_serializer_test.mk |   11 -
 vcl/inc/TypeSerializer.hxx  |4 
 vcl/qa/cppunit/TypeSerializerTest.cxx   |  161 +++-
 vcl/source/gdi/TypeSerializer.cxx   |  117 
 5 files changed, 285 insertions(+), 37 deletions(-)

New commits:
commit d028229068c89f44c74a645fe8f0c3400c05706f
Author: Tomaž Vajngerl 
AuthorDate: Thu Apr 30 10:48:44 2020 +0200
Commit: Tomaž Vajngerl 
CommitDate: Thu Apr 30 10:48:44 2020 +0200

vcl: add Graphic serialization (writing) to TypeSerializer + tests

Change-Id: I3c4845550e776c4c2c891d94db71bacea27c9a37

diff --git a/vcl/inc/TypeSerializer.hxx b/vcl/inc/TypeSerializer.hxx
index befd4edd7660..136af57a399a 100644
--- a/vcl/inc/TypeSerializer.hxx
+++ b/vcl/inc/TypeSerializer.hxx
@@ -24,6 +24,7 @@
 #include 
 #include 
 #include 
+#include 
 
 class VCL_DLLPUBLIC TypeSerializer : public tools::GenericTypeSerializer
 {
@@ -35,6 +36,9 @@ public:
 
 void readGfxLink(GfxLink& rGfxLink);
 void writeGfxLink(const GfxLink& rGfxLink);
+
+void readGraphic(Graphic& rGraphic);
+void writeGraphic(const Graphic& rGraphic);
 };
 
 #endif
diff --git a/vcl/qa/cppunit/TypeSerializerTest.cxx 
b/vcl/qa/cppunit/TypeSerializerTest.cxx
index e5d3a259f803..0c737a4c4f03 100644
--- a/vcl/qa/cppunit/TypeSerializerTest.cxx
+++ b/vcl/qa/cppunit/TypeSerializerTest.cxx
@@ -130,6 +130,43 @@ void TypeSerializerTest::testGraphic()
 
CPPUNIT_ASSERT_EQUAL(std::string("c2bed2099ce617f1cc035701de5186f0d43e3064"),
  toHexString(aHash));
 }
+
+// Test TypeSerializer - Native Format 5
+{
+SvMemoryStream aMemoryStream;
+aMemoryStream.SetVersion(SOFFICE_FILEFORMAT_50);
+aMemoryStream.SetCompressMode(SvStreamCompressFlags::NATIVE);
+{
+TypeSerializer aSerializer(aMemoryStream);
+aSerializer.writeGraphic(aGraphic);
+}
+aMemoryStream.Seek(STREAM_SEEK_TO_BEGIN);
+
+CPPUNIT_ASSERT_EQUAL(sal_uInt64(290), aMemoryStream.remainingSize());
+std::vector aHash = calculateHash(aMemoryStream);
+
CPPUNIT_ASSERT_EQUAL(std::string("ee55ab6faa73b61b68bc3d5628d95f0d3c528e2a"),
+ toHexString(aHash));
+
+aMemoryStream.Seek(STREAM_SEEK_TO_BEGIN);
+sal_uInt32 nType;
+aMemoryStream.ReadUInt32(nType);
+CPPUNIT_ASSERT_EQUAL(COMPAT_FORMAT('N', 'A', 'T', '5'), nType);
+}
+
+// Test TypeSerializer - Normal
+{
+SvMemoryStream aMemoryStream;
+{
+TypeSerializer aSerializer(aMemoryStream);
+aSerializer.writeGraphic(aGraphic);
+}
+aMemoryStream.Seek(STREAM_SEEK_TO_BEGIN);
+
+CPPUNIT_ASSERT_EQUAL(sal_uInt64(233), aMemoryStream.remainingSize());
+std::vector aHash = calculateHash(aMemoryStream);
+
CPPUNIT_ASSERT_EQUAL(std::string("c2bed2099ce617f1cc035701de5186f0d43e3064"),
+ toHexString(aHash));
+}
 }
 
 void TypeSerializerTest::testGraphic_Bitmap_NoGfxLink()
@@ -155,6 +192,26 @@ void TypeSerializerTest::testGraphic_Bitmap_NoGfxLink()
 aMemoryStream.ReadUInt16(nType);
 CPPUNIT_ASSERT_EQUAL(sal_uInt16(0x4D42), nType); // Magic written with 
WriteDIBBitmapEx
 }
+
+// Test TypeSerializer
+{
+SvMemoryStream aMemoryStream;
+{
+TypeSerializer aSerializer(aMemoryStream);
+aSerializer.writeGraphic(aGraphic);
+}
+aMemoryStream.Seek(STREAM_SEEK_TO_BEGIN);
+
+CPPUNIT_ASSERT_EQUAL(sal_uInt64(383), aMemoryStream.remainingSize());
+std::vector aHash = calculateHash(aMemoryStream);
+
CPPUNIT_ASSERT_EQUAL(std::string("da831418499146d51bf245fadf60b9111faa76c2"),
+ toHexString(aHash));
+
+aMemoryStream.Seek(STREAM_SEEK_TO_BEGIN);
+sal_uInt16 nType;
+aMemoryStream.ReadUInt16(nType);
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(0x4D42), nType); // Magic written with 
WriteDIBBitmapEx
+}
 }
 
 } // namespace
diff --git a/vcl/source/gdi/TypeSerializer.cxx 
b/vcl/source/gdi/TypeSerializer.cxx
index ad2f1400da85..8266c6ac9813 100644
--- a/vcl/source/gdi/TypeSerializer.cxx
+++ b/vcl/source/gdi/TypeSerializer.cxx
@@ -20,6 +20,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 
 TypeSerializer::TypeSerializer(SvStream& rStream)
 : GenericTypeSerializer(rStream)
@@ -148,4 +150,119 @@ void TypeSerializer::writeGfxLink(const GfxLink& rGfxLink)
 }
 }
 
+namespace
+{
+constexpr sal_uInt32 constSvgMagic((sal_uInt32('s') << 24) | (sal_uInt32('v') 
<< 16)
+   | (sal_uInt32('g') << 8) | sal_uInt32('0'));
+constexpr sal_uInt32 constWmfMagic((sal_uInt32('w') << 24) | (sal_uInt32('m') 
<< 16)
+   | (sal_uInt32('f') << 8) | sal_uInt32('0'));
+constexpr 

[Libreoffice-ux-advise] [Bug 104346] Extend the marker line if tracked changes spans over the next paragraph

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104346

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
   Severity|normal  |enhancement
   Keywords|needsUXEval |

--- Comment #8 from Heiko Tietze  ---
We discussed the topic in the design meeting and don't see blockers from
UX/design POV.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 104346] Extend the marker line if tracked changes spans over the next paragraph

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104346

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
   Severity|normal  |enhancement
   Keywords|needsUXEval |

--- Comment #8 from Heiko Tietze  ---
We discussed the topic in the design meeting and don't see blockers from
UX/design POV.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 128176] Opentype features window is longer than screen size and it is difficult to reach ok/cancel buttons

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128176

Heiko Tietze  changed:

   What|Removed |Added

   Severity|normal  |enhancement
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org,
   ||mentoring@documentfoundatio
   ||n.org
   Keywords|needsUXEval |difficultyBeginner,
   ||easyHack, skillDesign,
   ||topicUI

--- Comment #11 from Heiko Tietze  ---
We discussed this topic in the design meeting and favor a scrollwindow behind
the two columns.

Code pointer: cui/uiconfig/ui/fontfeaturesdialog.ui

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 128176] Opentype features window is longer than screen size and it is difficult to reach ok/cancel buttons

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128176

Heiko Tietze  changed:

   What|Removed |Added

   Severity|normal  |enhancement
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org,
   ||mentoring@documentfoundatio
   ||n.org
   Keywords|needsUXEval |difficultyBeginner,
   ||easyHack, skillDesign,
   ||topicUI

--- Comment #11 from Heiko Tietze  ---
We discussed this topic in the design meeting and favor a scrollwindow behind
the two columns.

Code pointer: cui/uiconfig/ui/fontfeaturesdialog.ui

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 132289] Inserted file not displayed correctly (Numbering missing)

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132289

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #4 from Heiko Tietze  ---
We discussed the topic in the design meeting. A stringent method what
formatting is taken makes sense and, as outlined in comment 2, inserting
content from a file or copy/pasting on an empty paragraph should take the
formatting from the source.

If the operation is applied somewhere in the middle of the paragraph we keep
the target style, which also applies to lists. Otherwise you get

Source: 1. First item \n 2. Second item
Target: Lorem ipsum |dolor est (pasting at the pipe)

Result with list style applied:
1. Lorem ipsum First item
2. Second item
3. dolor est

Result w/o list style:
Lorem ipsum First item
1. Second item
dolor est
(this is the expected behavior)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 132289] Inserted file not displayed correctly (Numbering missing)

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132289

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #4 from Heiko Tietze  ---
We discussed the topic in the design meeting. A stringent method what
formatting is taken makes sense and, as outlined in comment 2, inserting
content from a file or copy/pasting on an empty paragraph should take the
formatting from the source.

If the operation is applied somewhere in the middle of the paragraph we keep
the target style, which also applies to lists. Otherwise you get

Source: 1. First item \n 2. Second item
Target: Lorem ipsum |dolor est (pasting at the pipe)

Result with list style applied:
1. Lorem ipsum First item
2. Second item
3. dolor est

Result w/o list style:
Lorem ipsum First item
1. Second item
dolor est
(this is the expected behavior)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 132547] Date conversion from HSQLDB to Firebird

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132547

--- Comment #2 from Chartagnat  ---
Created attachment 160116
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160116=edit
Firebird database after conversion

Problem is xith the date fiels in MVTS table.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132547] Date conversion from HSQLDB to Firebird

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132547

Chartagnat  changed:

   What|Removed |Added

 CC||chartag...@gmail.com

--- Comment #1 from Chartagnat  ---
Created attachment 160115
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160115=edit
HSQLBD database before conversion

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 124470] Table settings and borders are not saved if checked "Embed fonts" and "Only embed fonts that are used"

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124470

Mike Kaganski  changed:

   What|Removed |Added

 CC||30...@zaclys.net

--- Comment #9 from Mike Kaganski  ---
*** Bug 132273 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132273] Tables shaping is not kept when I reopen the document where the modifications were done.

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132273

Mike Kaganski  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Mike Kaganski  ---


*** This bug has been marked as a duplicate of bug 124470 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 132274] Writer does not allow a user-set default view/zoom (overwriting the zoom level stored in a document, that is used by default)

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132274

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
   Keywords|needsUXEval |

--- Comment #2 from Heiko Tietze  ---
No objection from the design team. Tools > Options > Writer > View would be a
good place for "[ ] Override document zoom level [100 % +/-]" (the checkbox is
off by default making the spin edit below and indented disabled).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 132274] Writer does not allow a user-set default view/zoom (overwriting the zoom level stored in a document, that is used by default)

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132274

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
   Keywords|needsUXEval |

--- Comment #2 from Heiko Tietze  ---
No objection from the design team. Tools > Options > Writer > View would be a
good place for "[ ] Override document zoom level [100 % +/-]" (the checkbox is
off by default making the spin edit below and indented disabled).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132274] Writer does not allow a user-set default view/zoom (overwriting the zoom level stored in a document, that is used by default)

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132274

Heiko Tietze  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 124470] Table settings and borders are not saved if checked "Embed fonts" and "Only embed fonts that are used"

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124470

--- Comment #8 from 30...@zaclys.net ---
I encoutered the same bug but I didn't find it in bugzilla, so I reported a new
one.
It is the "Bug 132273", how can I put it into the "duplicates" of this bug
report ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132547] New: Date conversion from HSQLDB to Firebird

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132547

Bug ID: 132547
   Summary: Date conversion from HSQLDB to Firebird
   Product: LibreOffice
   Version: 6.4.2.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: chartag...@gmail.com

Description:
When converting a HSQLBD base to Firebird, the field containig a date is
systematically decreased of one day: January 5th, 1994 becomes January 4th,
1994... This occurs in 6.4.2.2 and 6.4.3.2.

Steps to Reproduce:
1.Set option to use experimental features and restart LibreOffice
2.Open HSQLDB database
3.Accept the conversion to Firebird
4.Opent the table to check the date values

Actual Results:
Date value in the firebird table is decreased by 1 day.

Expected Results:
Same value in the date field in HSQLBD and Firebird tables.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
See upper

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105478] DOC LAYOUT specified height row splits and flows back to previous page, despite not meeting minimum height (comment 9).

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105478

--- Comment #16 from Mike Kaganski  ---
Thanks Justin!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-qa] Minutes from the UX/design meeting 2020-Apr-29

2020-04-30 Thread Heiko Tietze
Present: Olivier, Cor, Heiko
Comments: by many

Tickets/Topic

 * Writer does not allow a user-set default view/zoom
   + https://bugs.documentfoundation.org/show_bug.cgi?id=132274
   + option to override document zoom level
   => do it

 * Inserted file not displayed correctly (Numbering missing)
   + https://bugs.documentfoundation.org/show_bug.cgi?id=132289
   + list style must not be ignored when pasting/inserting styled text
   + paste "1. Lorem" into a paragraph like "That didnt bode well" makes
 the paragraph a list, ie. "1. That didnt bode Lorem\n 2. well." 
 -> makes no sense
   + so just follow the recent decision and keep the source style when pasting
 at an empty paragraph, otherwise keep target's style
   + usually operation is done on an empty paragraph (Cor)
   => comment and fix the bug

 * Opentype features window is longer than screen size and it is difficult to 
reach
   ok/cancel buttons
   + https://bugs.documentfoundation.org/show_bug.cgi?id=128176
   + three columns or scrollwindow
   + prefer scrollwindow (Cor, Olivier)
   => do it

 * Extend the marker line if tracked changes spans over the next paragraph
   + https://bugs.documentfoundation.org/show_bug.cgi?id=104346
   + no objection, enhancement not a bug, low priority
   + line is interrupted by paragraph spacing
   => do it

 * Add ability to keep vector image and compress replacement image in image
   compression dialog
   + https://bugs.documentfoundation.org/show_bug.cgi?id=127854
   + reason for https://vmiklos.hu/blog/lo-insert-pdf-image.html
 + "Similarly to the SVG feature, the original vector image is stored in 
the 
   document, but when saving to ODF, a replacement PNG file is also 
generated to be
   backwards compatible with older ODF readers."
   + reading Miklos blog from comment #9, it looks as if
 + inserted PDF is represented with PNG,
   but choosing Save from Context menu allows to save as PDF again...
 + so would it be possible to do the same with inserted SVGs ?
 + could ask Miklos I think (Cor)
   + introduce a compatibility flag to switch conversion to raster graphic off?
   + any workflow with back and forth conversion of PNG<->SVG sounds weird 
(Heiko)
   => involve Miklos

 * Definition List (or Definition Index or Glossary) at the end of the page - 
EDITING
   + https://bugs.documentfoundation.org/show_bug.cgi?id=118455
   + would be nice to have it more comfortable though but quite a lot of effort 
 and unclear if possible with the ODF
   + less comfortable options are using endnotes or 1st key of index entry
   + would be definitely a nice feature (Cor, Olivier)
   + would ODF specs have the room for this to be implemented?
 + ask Regina :) (Cor)
   + if we realize it it has to be done based on the current ODF specs (Heiko)
   => look at the competitor's way and take compatibility as prime
 + or ask for a good design from someone if we know ODF allows it to be 
implemented

 * Adopt new application icons for LibreOffice 7.0
   + https://bugs.documentfoundation.org/show_bug.cgi?id=132398
   + seeking for opinions, see c8 (Heiko)
   + wouldn't change the app icons (Olivier)
   + let's gather the ideas first (Cor)
   => comments and input is always welcome



signature.asc
Description: OpenPGP digital signature
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/


Minutes from the UX/design meeting 2020-Apr-29

2020-04-30 Thread Heiko Tietze
Present: Olivier, Cor, Heiko
Comments: by many

Tickets/Topic

 * Writer does not allow a user-set default view/zoom
   + https://bugs.documentfoundation.org/show_bug.cgi?id=132274
   + option to override document zoom level
   => do it

 * Inserted file not displayed correctly (Numbering missing)
   + https://bugs.documentfoundation.org/show_bug.cgi?id=132289
   + list style must not be ignored when pasting/inserting styled text
   + paste "1. Lorem" into a paragraph like "That didnt bode well" makes
 the paragraph a list, ie. "1. That didnt bode Lorem\n 2. well." 
 -> makes no sense
   + so just follow the recent decision and keep the source style when pasting
 at an empty paragraph, otherwise keep target's style
   + usually operation is done on an empty paragraph (Cor)
   => comment and fix the bug

 * Opentype features window is longer than screen size and it is difficult to 
reach
   ok/cancel buttons
   + https://bugs.documentfoundation.org/show_bug.cgi?id=128176
   + three columns or scrollwindow
   + prefer scrollwindow (Cor, Olivier)
   => do it

 * Extend the marker line if tracked changes spans over the next paragraph
   + https://bugs.documentfoundation.org/show_bug.cgi?id=104346
   + no objection, enhancement not a bug, low priority
   + line is interrupted by paragraph spacing
   => do it

 * Add ability to keep vector image and compress replacement image in image
   compression dialog
   + https://bugs.documentfoundation.org/show_bug.cgi?id=127854
   + reason for https://vmiklos.hu/blog/lo-insert-pdf-image.html
 + "Similarly to the SVG feature, the original vector image is stored in 
the 
   document, but when saving to ODF, a replacement PNG file is also 
generated to be
   backwards compatible with older ODF readers."
   + reading Miklos blog from comment #9, it looks as if
 + inserted PDF is represented with PNG,
   but choosing Save from Context menu allows to save as PDF again...
 + so would it be possible to do the same with inserted SVGs ?
 + could ask Miklos I think (Cor)
   + introduce a compatibility flag to switch conversion to raster graphic off?
   + any workflow with back and forth conversion of PNG<->SVG sounds weird 
(Heiko)
   => involve Miklos

 * Definition List (or Definition Index or Glossary) at the end of the page - 
EDITING
   + https://bugs.documentfoundation.org/show_bug.cgi?id=118455
   + would be nice to have it more comfortable though but quite a lot of effort 
 and unclear if possible with the ODF
   + less comfortable options are using endnotes or 1st key of index entry
   + would be definitely a nice feature (Cor, Olivier)
   + would ODF specs have the room for this to be implemented?
 + ask Regina :) (Cor)
   + if we realize it it has to be done based on the current ODF specs (Heiko)
   => look at the competitor's way and take compatibility as prime
 + or ask for a good design from someone if we know ODF allows it to be 
implemented

 * Adopt new application icons for LibreOffice 7.0
   + https://bugs.documentfoundation.org/show_bug.cgi?id=132398
   + seeking for opinions, see c8 (Heiko)
   + wouldn't change the app icons (Olivier)
   + let's gather the ideas first (Cor)
   => comments and input is always welcome



signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 105478] DOC LAYOUT specified height row splits and flows back to previous page, despite not meeting minimum height (comment 9).

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105478

--- Comment #15 from Justin L  ---
(In reply to Mike Kaganski from comment #14)
> So the problem is relation between "allow to split between pages" and
> "minimal row height"? In Word, even if a row is allowed to split, it isn't
> allowed to split until minimal height is reached (or a whole page is
> filled), right? and in LO, "allow row to split" has now higher priority.
I think you have it exactly right. Don't worry about it for now - I'm
researching a fix. We can just re-use an existing compat flag like
TABLE_ROW_KEEP.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: xmloff/source

2020-04-30 Thread Noel Grandin (via logerrit)
 xmloff/source/forms/elementimport.cxx |   80 +++---
 xmloff/source/forms/elementimport.hxx |  121 +-
 2 files changed, 89 insertions(+), 112 deletions(-)

New commits:
commit 7e4463db510fe7faa15e4f5ad3394aa0abf52b66
Author: Noel Grandin 
AuthorDate: Thu Apr 30 09:53:49 2020 +0200
Commit: Noel Grandin 
CommitDate: Thu Apr 30 10:32:42 2020 +0200

expand out OContainerImport template

to make the logic easier to follow, and to make it possible to convert
this to fast-parser APIs

Change-Id: I48921c3cd84b45f56ff943060f2d9c8e4882d051
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93193
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/xmloff/source/forms/elementimport.cxx 
b/xmloff/source/forms/elementimport.cxx
index 25824d8e08c6..8693cc355bf1 100644
--- a/xmloff/source/forms/elementimport.cxx
+++ b/xmloff/source/forms/elementimport.cxx
@@ -1836,20 +1836,62 @@ namespace xmloff
 OGridImport::OGridImport(OFormLayerXMLImport_Impl& _rImport, 
IEventAttacherManager& _rEventManager, sal_uInt16 _nPrefix, const OUString& 
_rName,
 const Reference< XNameContainer >& _rxParentContainer,
 OControlElement::ElementType _eType)
-:OGridImport_Base(_rImport, _rEventManager, _nPrefix, _rName, 
_rxParentContainer, "column")
+:OControlImport(_rImport, _rEventManager, _nPrefix, _rName, 
_rxParentContainer)
 {
 setElementType(_eType);
 }
 
-SvXMLImportContext* OGridImport::implCreateControlWrapper(sal_uInt16 
_nPrefix, const OUString& _rLocalName)
+SvXMLImportContextRef OGridImport::CreateChildContext(
+sal_uInt16 _nPrefix, const OUString& _rLocalName,
+const css::uno::Reference< css::xml::sax::XAttributeList >& 
_rxAttrList)
+{
+// maybe it's a sub control
+if (_rLocalName == "column")
+{
+if (m_xMeAsContainer.is())
+return new OColumnWrapperImport(m_rFormImport, *this, 
_nPrefix, _rLocalName, m_xMeAsContainer);
+else
+{
+OSL_FAIL("OGridImport::CreateChildContext: don't have an 
element!");
+return nullptr;
+}
+}
+
+return OControlImport::CreateChildContext(_nPrefix, _rLocalName, 
_rxAttrList);
+}
+
+void OGridImport::EndElement()
+{
+OControlImport::EndElement();
+
+// now that we have all children, attach the events
+css::uno::Reference< css::container::XIndexAccess > 
xIndexContainer(m_xMeAsContainer, css::uno::UNO_QUERY);
+if (xIndexContainer.is())
+ODefaultEventAttacherManager::setEvents(xIndexContainer);
+}
+
+css::uno::Reference< css::beans::XPropertySet > 
OGridImport::createElement()
 {
-return new OColumnWrapperImport(m_rFormImport, *this, _nPrefix, 
_rLocalName, m_xMeAsContainer);
+// let the base class create the object
+css::uno::Reference< css::beans::XPropertySet > xReturn = 
OControlImport::createElement();
+if (!xReturn.is())
+return xReturn;
+
+// ensure that the object is a XNameContainer (we strongly need this 
for inserting child elements)
+m_xMeAsContainer.set(xReturn, css::uno::UNO_QUERY);
+if (!m_xMeAsContainer.is())
+{
+OSL_FAIL("OContainerImport::createElement: invalid element (no 
XNameContainer) created!");
+xReturn.clear();
+}
+
+return xReturn;
 }
 
 //= OFormImport
 OFormImport::OFormImport(OFormLayerXMLImport_Impl& _rImport, 
IEventAttacherManager& _rEventManager, sal_uInt16 _nPrefix, const OUString& 
_rName,
 const Reference< XNameContainer >& _rxParentContainer)
-:OFormImport_Base(_rImport, _rEventManager, _nPrefix, _rName, 
_rxParentContainer, "control")
+:OElementImport(_rImport, _rEventManager, _nPrefix, _rName, 
_rxParentContainer)
 {
 enableTrackAttributes();
 }
@@ -1875,7 +1917,7 @@ namespace xmloff
 void OFormImport::StartElement(const Reference< XAttributeList >& 
_rxAttrList)
 {
 m_rFormImport.enterEventContext();
-OFormImport_Base::StartElement(_rxAttrList);
+OElementImport::StartElement(_rxAttrList);
 
 // handle the target-frame attribute
 
simulateDefaultedAttribute(OAttributeMetaData::getCommonControlAttributeName(CCAFlags::TargetFrame),
 PROPERTY_TARGETFRAME, "_blank");
@@ -1883,14 +1925,32 @@ namespace xmloff
 
 void OFormImport::EndElement()
 {
-OFormImport_Base::EndElement();
+OElementImport::EndElement();
+
+// now that we have all children, attach the events
+css::uno::Reference< css::container::XIndexAccess > 
xIndexContainer(m_xMeAsContainer, css::uno::UNO_QUERY);
+if (xIndexContainer.is())
+ODefaultEventAttacherManager::setEvents(xIndexContainer);
+
 m_rFormImport.leaveEventContext();
 }
 
-   

[Libreoffice-commits] core.git: compilerplugins/clang sw/qa sw/source

2020-04-30 Thread Andrea Gelmini (via logerrit)
 compilerplugins/clang/test/cppunitassertequals.cxx |2 +-
 sw/qa/extras/ooxmlexport/ooxmlexport.cxx   |2 +-
 sw/qa/extras/ooxmlimport/ooxmlimport.cxx   |2 +-
 sw/source/core/doc/number.cxx  |2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 7685dff381f538bf011a56da4a0493228b84614a
Author: Andrea Gelmini 
AuthorDate: Tue Apr 28 17:19:13 2020 +0200
Commit: Andrea Gelmini 
CommitDate: Thu Apr 30 10:31:29 2020 +0200

Fix typos

Change-Id: I8d0e10b08393b7752d55298e0e1ba64e5fd6c422
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93083
Reviewed-by: Julien Nabet 
Tested-by: Jenkins

diff --git a/compilerplugins/clang/test/cppunitassertequals.cxx 
b/compilerplugins/clang/test/cppunitassertequals.cxx
index d0825000be07..d42007c99d66 100644
--- a/compilerplugins/clang/test/cppunitassertequals.cxx
+++ b/compilerplugins/clang/test/cppunitassertequals.cxx
@@ -53,7 +53,7 @@ void test(
 CPPUNIT_ASSERT(t.operator ==(t));
 
 // `P == nullptr` for P of pointer type is awkward to write with 
CPPUNIT_ASSERT_EQUAL, and the
-// actual pointer values that would be printed if CPPUNIT_ASSERT_EQUAL 
failed would likey not be
+// actual pointer values that would be printed if CPPUNIT_ASSERT_EQUAL 
failed would likely not be
 // very meaningful, so let it use CPPUNIT_ASSERT (but stick to 
CPPUNIT_ASSERT_EQUAL for
 // consistency in the unlikely case that P is of type std::nullptr_t):
 CPPUNIT_ASSERT(p == nullptr);
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
index 0b142d51141a..65036bbbc3bc 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
@@ -765,7 +765,7 @@ DECLARE_OOXMLEXPORT_TEST(testNumOverrideLvltext, 
"num-override-lvltext.docx")
 {
 uno::Reference xRules = getProperty< 
uno::Reference 
>(getStyles("NumberingStyles")->getByName("WWNum1"), "NumberingRules");
 // This was 1, i.e. the numbering on the second level was "1", not "1.1".
-// Check the praragraph properties, not the list ones, since they can 
differ due to overrides
+// Check the paragraph properties, not the list ones, since they can 
differ due to overrides
 uno::Reference xPara(getParagraph(1), uno::UNO_QUERY);
 CPPUNIT_ASSERT_EQUAL(static_cast(1), 
getProperty(xPara, "NumberingLevel"));
 CPPUNIT_ASSERT_EQUAL(OUString("1.1"), getProperty(xPara, 
"ListLabelString"));
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx 
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index 396f2a6e1513..773b5c457a73 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -1553,7 +1553,7 @@ DECLARE_OOXMLIMPORT_TEST(testTdf108995, "xml_space.docx")
 
 DECLARE_OOXMLIMPORT_TEST(testGroupShapeTextHighlight, 
"tdf131841_HighlightColorGroupedShape.docx")
 {
-// tdf#131841 Highligh color of text in grouped shapes was not imported.
+// tdf#131841 Highlight color of text in grouped shapes was not imported.
 
 // These are the possible highlight colors in MSO Word. Check that we 
import them properly.
 const std::vector xColors {
diff --git a/sw/source/core/doc/number.cxx b/sw/source/core/doc/number.cxx
index d26c48fe579d..cfa140a58817 100644
--- a/sw/source/core/doc/number.cxx
+++ b/sw/source/core/doc/number.cxx
@@ -648,7 +648,7 @@ OUString SwNumRule::MakeNumString( const 
SwNumberTree::tNumberVector & rNumVecto
 if (!sLevelFormat.isEmpty())
 {
 // In this case we are ignoring GetIncludeUpperLevels: we put 
all
-// level nubers requested by level format
+// level numbers requested by level format
 for (SwNumberTree::tNumberVector::size_type i=0; i <= nLevel; 
++i)
 {
 OUString sReplacement;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 64690] EDITING: Process hang on find/replace in Basic code involving "\&"

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=64690

--- Comment #28 from Andreas Heinisch  ---
I can even reproduce it without any ampersand (&) in the replace clause. Just
search for the dot (.) and replace it with ABC. At the end of the search
string, the selection will not be expanded, and therefore an infinite loop
occurs at
https://opengrok.libreoffice.org/xref/core/vcl/source/edit/textview.cxx?r=be53f326#2205.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120949] [META] Elementary icons

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120949
Bug 120949 depends on bug 132080, which changed state.

Bug 132080 Summary: elementary: Wrong Glyphs with Korean UI
https://bugs.documentfoundation.org/show_bug.cgi?id=132080

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - external/firebird

2020-04-30 Thread Stephan Bergmann (via logerrit)
 external/firebird/0001-Make-comparison-operator-member-functions-const.patch.1 
|   49 ++
 external/firebird/UnpackedTarball_firebird.mk  
|4 
 2 files changed, 53 insertions(+)

New commits:
commit b45283638b2167d32c8b0a09edc227dc6e4c97ee
Author: Stephan Bergmann 
AuthorDate: Mon Oct 21 18:09:00 2019 +0200
Commit: Tor Lillqvist 
CommitDate: Thu Apr 30 10:28:14 2020 +0200

external/firebird: Make comparison operator member functions const

see commit message of

external/firebird/0001-Make-comparison-operator-member-functions-const.patch.1
for details

Change-Id: I559e4b6ef2dbf3800ff5013dcde078d69296d2fb
Reviewed-on: https://gerrit.libreoffice.org/81261
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93191
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tor Lillqvist 

diff --git 
a/external/firebird/0001-Make-comparison-operator-member-functions-const.patch.1
 
b/external/firebird/0001-Make-comparison-operator-member-functions-const.patch.1
new file mode 100644
index ..42c677f7e5ad
--- /dev/null
+++ 
b/external/firebird/0001-Make-comparison-operator-member-functions-const.patch.1
@@ -0,0 +1,49 @@
+From 15390d75ee6ca429dbbe15ea04214df8a30fbd48 Mon Sep 17 00:00:00 2001
+From: Stephan Bergmann 
+Date: Mon, 21 Oct 2019 17:54:18 +0200
+Subject: [PATCH] Make comparison operator member functions const
+
+...which avoids overload resolution ambiguities in C++20, when a synthesized
+candidate of operator == for a reversed-argument rewrite conflicts with the
+actual operator ==, due to the asymmetric const-ness of the implicit object
+parameter and the RHS parameter.  (As observed with recent Clang 10 trunk with
+-std=c++2a when building firebird as part of LibreOffice:
+
+> workdir/UnpackedTarball/firebird/src/jrd/inf.cpp:1139:62: error: use of 
overloaded operator '!=' is ambiguous (with operand types 
'RuntimeStatistics::Iterator' and 'Jrd::RuntimeStatistics::Iterator')
+> for (RuntimeStatistics::Iterator iter = stats.begin(); iter != 
stats.end(); ++iter)
+> ^  
~~~
+> 
workdir/UnpackedTarball/firebird/src/jrd/../dsql/../jrd/RuntimeStatistics.h:283:8:
 note: candidate function
+> bool operator!=(const Iterator& other)
+>  ^
+> 
workdir/UnpackedTarball/firebird/src/jrd/../dsql/../jrd/RuntimeStatistics.h:278:8:
 note: candidate function
+> bool operator==(const Iterator& other)
+>  ^
+> 
workdir/UnpackedTarball/firebird/src/jrd/../dsql/../jrd/RuntimeStatistics.h:278:8:
 note: candidate function (with reversed parameter order)
+
+)
+---
+ src/jrd/RuntimeStatistics.h | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/src/jrd/RuntimeStatistics.h b/src/jrd/RuntimeStatistics.h
+index 74a03de2ad..fab286ad1a 100644
+--- a/src/jrd/RuntimeStatistics.h
 b/src/jrd/RuntimeStatistics.h
+@@ -290,12 +290,12 @@ public:
+   {}
+ 
+   public:
+-  bool operator==(const Iterator& other)
++  bool operator==(const Iterator& other) const
+   {
+   return (m_counts == other.m_counts);
+   }
+ 
+-  bool operator!=(const Iterator& other)
++  bool operator!=(const Iterator& other) const
+   {
+   return (m_counts != other.m_counts);
+   }
+-- 
+2.21.0
+
diff --git a/external/firebird/UnpackedTarball_firebird.mk 
b/external/firebird/UnpackedTarball_firebird.mk
index 96f29a76ead5..a2e2dcebc187 100644
--- a/external/firebird/UnpackedTarball_firebird.mk
+++ b/external/firebird/UnpackedTarball_firebird.mk
@@ -18,6 +18,9 @@ $(eval $(call 
gb_UnpackedTarball_update_autoconf_configs,firebird,\
extern/editline \
 ))
 
+# * 
external/firebird/0001-Make-comparison-operator-member-functions-const.patch.1 
is upstream at
+#    "Make comparison 
operator member functions
+#   const":
 $(eval $(call gb_UnpackedTarball_add_patches,firebird,\
 external/firebird/firebird.disable-ib-util-not-found.patch.1 \
external/firebird/firebird-Engine12.patch \
@@ -31,6 +34,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,firebird,\
external/firebird/c++17.patch \
external/firebird/ubsan.patch \
external/firebird/asan.patch \
+   
external/firebird/0001-Make-comparison-operator-member-functions-const.patch.1 \
 ))
 
 ifeq ($(OS),WNT)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 105478] DOC LAYOUT specified height row splits and flows back to previous page, despite not meeting minimum height (comment 9).

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105478

--- Comment #14 from Mike Kaganski  ---
So the problem is relation between "allow to split between pages" and "minimal
row height"? In Word, even if a row is allowed to split, it isn't allowed to
split until minimal height is reached (or a whole page is filled), right? and
in LO, "allow row to split" has now higher priority.

> For OP's document, MS interpretation certainly fits much better

Well, any use of corner cases makes hard time for interop. If OP document had
"do not split this row" flag set, which is logical, no problem would result...

but of course, we can have a new compat setting, yes.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: Doxygen

2020-04-30 Thread Stephan Bergmann

On 30/04/2020 03:34, Olivier Hallot wrote:

The way information is presented to the non-developer is sub-optimal.
Pre-Doxygen sdk was much easier to navigate and get information as the
ues cases below


What exactly do you mean with "pre-Doxygen sdk"?  (IIRC, Doxygen has 
been introduced to replace OOo's autodoc first for generation of the C++ 
API documentation and then for generation of the UNOIDL API documentation.)



With installed sdk in his computer at
file:///opt/libreoffice6.4/sdk/index.html


What exactly is installed there? 
 
or 
 
as currently available at ?



Let's suppose I am a candidate to macro programming and want to

Use case 1 : Search for ThisComponent -> no matches


Search how?  I find no ability to search on 
.  (Did you mean the search 
field at the top right of 
, reached from 
 via "IDL Reference"?  But 
then, "ThisComponent" is not a term related to LO's UNOIDL API, so no 
matches is a plausible outcome there.)


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 105478] DOC LAYOUT specified height row splits and flows back to previous page, despite not meeting minimum height (comment 9).

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105478

--- Comment #13 from Justin L  ---
(In reply to Mike Kaganski from comment #12)
> possible ways to interpret UB, and is more logical than of Word

Well, at least for loading MS format documents, MS interpretation would win
out. I too would probably hesitate changing ODT's interpretation once again.

For OP's document, MS interpretation certainly fits much better.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105478] DOC LAYOUT specified height row splits and flows back to previous page, despite not meeting minimum height (comment 9).

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105478

--- Comment #12 from Mike Kaganski  ---
(In reply to Justin L from comment #11)
> A minimum height for a table cell should be honoured. Otherwise what is the
> point, since a table grows to fill the space it needs anyway, and then there
> is no need for a minimum height (unless your content doesn't fill all of the
> space). But obviously this is tricky based on the history and fallout of
> that bugfix.

Yes, but LibreOffice does honour the minimum height of *rows* (not cells). When
a row requires that its height should be no less than X, and the X is greater
than space available on page, then it must be split anyway, despite it being
less than X on that page. But then, if it's split half way, how should it meet
the minimal height requirement? by summing the total height of that row's parts
on several pages. Now, if the row is required to split, and it's the total
height that is taken into account, then how is the current behaviour wrong?

Is there some specification that requires that in this case, the split must
only be performed when the whole page is filled with this row? I'm inclined to
consider this a corner case where LibreOffice's interpretation is one of
possible ways to interpret UB, and is more logical than of Word; and possibly
should not be changed... ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132528] Crash when opening Base (no .odb file) on Linux Mint 18.3

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132528

--- Comment #5 from Alex Thurgood  ---
(In reply to Robert Großkopf from comment #3)

> But you are writing the wizard for creating a database will crash? Or do I
> understand it wrong with "Application LO Base". You couldn't open Base
> without having an *.odb-file.
> 

My understanding of the bug description is that the application crashes when
the Base module is launched, e.g. by double-clicking the Base icon, or else
starting from the command line with ./soffice --base.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132528] Crash when opening Base (no .odb file) on Linux Mint 18.3

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132528

--- Comment #4 from Alex Thurgood  ---
@cme_linux : sounds like a right mess with your different installations...

LinuxMint 18.3 is pretty old right now. Ubuntu Focal Fossa is already out, I
upgraded my previous Ubuntu 18.04 to 20.04 this week and it appears to be
mostly working fine. Actually the first time in years when an Ubuntu upgrade
didn't force me into recovery mode to get it restarted ;-)


With regard to the LO Base problem, my first thought would be to completely
"purge" everything related to LO, and start afresh.

PPA versions are well known for bringing additional bugs to the already known
Base bugs.

I can't speak for Flatpak versions as I've never installed one.

I currently use Snaps for testing newer versions over the current distrib
release version (bearing in mind that they have their own limitations), and in
the past have also installed LO packages from the TDF download site to have the
latest versions available in parallel.

Given the age of Mint18, I would also check on their bug/forum web page to see
if anyone else has encountered the same problem as you. 

I recall, for example, a period in time not so long ago where a particular
kernel version caused Base to crash immediately on start. Could be that we are
back there again with your current setup ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132546] LO Impress: Mouse pointer is visible while slide demonstration, can't hide it

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132546

--- Comment #1 from Vera Blagoveschenskaya  ---
Created attachment 160111
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160111=edit
mouse_point

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103610] [META] Slide show (presentation mode) bugs and enhancements

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103610

Vera Blagoveschenskaya  changed:

   What|Removed |Added

 Depends on||132546


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=132546
[Bug 132546] LO Impress: Mouse pointer is visible while slide demonstration,
can't hide it
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132546] LO Impress: Mouse pointer is visible while slide demonstration, can't hide it

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132546

Vera Blagoveschenskaya  changed:

   What|Removed |Added

 Blocks||103610


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103610
[Bug 103610] [META] Slide show (presentation mode) bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: include/xmloff sw/source xmloff/inc xmloff/source

2020-04-30 Thread Noel Grandin (via logerrit)
 include/xmloff/xformsimport.hxx   |5 +
 sw/source/filter/xml/xmlimp.cxx   |2 
 xmloff/inc/DomBuilderContext.hxx  |   23 +++--
 xmloff/source/core/DomBuilderContext.cxx  |   77 +++
 xmloff/source/core/xmlimp.cxx |1 
 xmloff/source/forms/layerimport.cxx   |2 
 xmloff/source/xforms/SchemaContext.cxx|   32 +---
 xmloff/source/xforms/SchemaContext.hxx|   12 ++-
 xmloff/source/xforms/SchemaRestrictionContext.cxx |   88 ++
 xmloff/source/xforms/SchemaRestrictionContext.hxx |   12 ++-
 xmloff/source/xforms/SchemaSimpleTypeContext.cxx  |   36 ++---
 xmloff/source/xforms/SchemaSimpleTypeContext.hxx  |   12 ++-
 xmloff/source/xforms/TokenContext.cxx |   71 +
 xmloff/source/xforms/TokenContext.hxx |   42 +++---
 xmloff/source/xforms/XFormsBindContext.cxx|   54 -
 xmloff/source/xforms/XFormsBindContext.hxx|   15 ++-
 xmloff/source/xforms/XFormsInstanceContext.cxx|   44 +++
 xmloff/source/xforms/XFormsInstanceContext.hxx|   21 +++--
 xmloff/source/xforms/XFormsModelContext.cxx   |   65 +++-
 xmloff/source/xforms/XFormsModelContext.hxx   |   14 ++-
 xmloff/source/xforms/XFormsSubmissionContext.cxx  |   67 +++-
 xmloff/source/xforms/XFormsSubmissionContext.hxx  |   10 +-
 xmloff/source/xforms/xformsimport.cxx |7 +
 23 files changed, 474 insertions(+), 238 deletions(-)

New commits:
commit e4da8ae4bef37f5450dcf34d9f06b68e3b901c01
Author: Noel Grandin 
AuthorDate: Thu Apr 30 08:37:51 2020 +0200
Commit: Noel Grandin 
CommitDate: Thu Apr 30 09:43:10 2020 +0200

Revert "Convert TokenContext to fastparser APIs"

This reverts commit b7bfe6ae08f5b214f2d03d70a40b66c894c0b659.

Reason for revert: I missed some call-sites which means this is not going 
to work properly, which also means we don't have any tests for this 
functionality :-(

Change-Id: Ie340a5e2331609258e79176c3dd12249ad46ba7b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93134
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/xmloff/xformsimport.hxx b/include/xmloff/xformsimport.hxx
index 3bf554d9a7b2..5975ea993416 100644
--- a/include/xmloff/xformsimport.hxx
+++ b/include/xmloff/xformsimport.hxx
@@ -35,7 +35,10 @@ namespace com { namespace sun { namespace star {
 } } }
 
 /** create import context for xforms:model element. */
-XMLOFF_DLLPUBLIC SvXMLImportContext* createXFormsModelContext( SvXMLImport& 
rImport );
+XMLOFF_DLLPUBLIC SvXMLImportContext* createXFormsModelContext(
+SvXMLImport& rImport,
+sal_uInt16 nPrefix,
+const OUString& rLocalName );
 
 /** perform the actual binding of an XForms-binding with the suitable control
  *  @param document which contains the XForms-model(s)
diff --git a/sw/source/filter/xml/xmlimp.cxx b/sw/source/filter/xml/xmlimp.cxx
index eaded191bdcc..0ea3690eddac 100644
--- a/sw/source/filter/xml/xmlimp.cxx
+++ b/sw/source/filter/xml/xmlimp.cxx
@@ -260,7 +260,7 @@ SvXMLImportContextRef 
SwXMLDocContext_Impl::CreateChildContext(
 switch( rTokenMap.Get( nPrefix, rLocalName ) )
 {
 case XML_TOK_DOC_XFORMS:
-pContext = createXFormsModelContext(GetImport());
+pContext = createXFormsModelContext(GetImport(), nPrefix, rLocalName);
 break;
 }
 
diff --git a/xmloff/inc/DomBuilderContext.hxx b/xmloff/inc/DomBuilderContext.hxx
index a3ce39574473..cf73d6e7d608 100644
--- a/xmloff/inc/DomBuilderContext.hxx
+++ b/xmloff/inc/DomBuilderContext.hxx
@@ -32,7 +32,7 @@ namespace com { namespace sun { namespace star {
 class XDocument;
 } }
 namespace xml { namespace sax {
-class XFastAttributeList;
+class XAttributeList;
 } }
 } } }
 class SvXMLImport;
@@ -48,11 +48,14 @@ class DomBuilderContext final : public SvXMLImportContext
 public:
 
 /** default constructor: create new DOM tree */
-DomBuilderContext( SvXMLImport& rImport, sal_Int32 nElement );
+DomBuilderContext( SvXMLImport& rImport,
+   sal_uInt16 nPrefix,
+   const OUString& rLocalName );
 
 /** constructor: create DOM subtree under the given node */
 DomBuilderContext( SvXMLImport& rImport,
-   sal_Int32 nElement,
+   sal_uInt16 nPrefix,
+   const OUString& rLocalName,
css::uno::Reference const & );
 
 virtual ~DomBuilderContext() override;
@@ -67,12 +70,16 @@ public:
 
 // implement SvXMLImportContext methods:
 
-virtual css::uno::Reference< css::xml::sax::XFastContextHandler > SAL_CALL 
createFastChildContext(
-sal_Int32 nElement,
-const css::uno::Reference< css::xml::sax::XFastAttributeList >& 
xAttrList ) override;
 
-virtual void SAL_CALL startFastElement( 

[Libreoffice-bugs] [Bug 132546] New: LO Impress: Mouse pointer is visible while slide demonstration, can't hide it

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132546

Bug ID: 132546
   Summary: LO Impress: Mouse pointer is visible while slide
demonstration, can't hide it
   Product: LibreOffice
   Version: 7.0.0.0.alpha0+ Master
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ver...@basealt.ru

Description:
LO Impress: Mouse pointer is visible while slide demonstration, can't hide it

Steps to Reproduce:
1. Create LO Impress presentation (2-3 slides).
2. Slide Show -> Slide Show Settings.
3. DO NOT check "Mouse pointer visible".
4. Start presentation.

Actual Results:
I can see mouse pointer at the presentation screen.

Expected Results:
Mouse pointer is not visible.


Reproducible: Always


User Profile Reset: No



Additional Info:
Reproduced for 

Version: 7.0.0.0.alpha0+
Build ID: f845f74afaf087a46c82ee4209e29caca0980b71
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: kf5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2020-04-28_22:05:53
Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US
Calc: threaded

and older

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118901] [META] Issues related to direct formatting in DOCX (OOXML) bullet and numbering list

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118901
Bug 118901 depends on bug 114799, which changed state.

Bug 114799 Summary: EDITOR DOCX numbering highlight does not get repainted
https://bugs.documentfoundation.org/show_bug.cgi?id=114799

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/qa sw/source

2020-04-30 Thread László Németh (via logerrit)
 sw/qa/extras/tiledrendering/data/tdf114799.docx |binary
 sw/qa/extras/tiledrendering/tiledrendering.cxx  |   27 
 sw/source/core/text/txtfld.cxx  |   14 ++--
 3 files changed, 34 insertions(+), 7 deletions(-)

New commits:
commit 315d56582f8a56d8f2d3ea6cda63ea4832249608
Author: László Németh 
AuthorDate: Tue Apr 28 16:48:09 2020 +0200
Commit: László Németh 
CommitDate: Thu Apr 30 09:41:45 2020 +0200

tdf#114799 DOCX import: fix missing numbering highlight

opening a DOCX with shadowing (w:shd) instead of highlight
(w:highlight), for example, a DOCX saved in LibreOffice.

This reverts also commit aa02ed306f7c633bbffede16e44e8e736977ace4
(tdf#106991: Highlighting remains after select no fill).

Change-Id: I0935694e3c309b5a450cd424fd398a88d13f8b22
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93082
Tested-by: Jenkins
Reviewed-by: László Németh 

diff --git a/sw/qa/extras/tiledrendering/data/tdf114799.docx 
b/sw/qa/extras/tiledrendering/data/tdf114799.docx
new file mode 100644
index ..730ef91dcef9
Binary files /dev/null and b/sw/qa/extras/tiledrendering/data/tdf114799.docx 
differ
diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx 
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index 441c06271d52..355ae56cc29f 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -121,6 +121,7 @@ public:
 void testVisCursorInvalidation();
 void testDeselectCustomShape();
 void testSemiTransparent();
+void testHighlightNumbering();
 void testClipText();
 void testAnchorTypes();
 void testLanguageStatus();
@@ -186,6 +187,7 @@ public:
 CPPUNIT_TEST(testVisCursorInvalidation);
 CPPUNIT_TEST(testDeselectCustomShape);
 CPPUNIT_TEST(testSemiTransparent);
+CPPUNIT_TEST(testHighlightNumbering);
 CPPUNIT_TEST(testClipText);
 CPPUNIT_TEST(testAnchorTypes);
 CPPUNIT_TEST(testLanguageStatus);
@@ -2386,6 +2388,31 @@ void SwTiledRenderingTest::testSemiTransparent()
 CPPUNIT_ASSERT_GREATEREQUAL(190, static_cast(aColor.B));
 }
 
+void SwTiledRenderingTest::testHighlightNumbering()
+{
+// Load a document where the top left tile contains a semi-transparent 
rectangle shape.
+SwXTextDocument* pXTextDocument = createDoc("tdf114799.docx");
+
+// Render a larger area, and then get the color of the bottom right corner 
of our tile.
+size_t nCanvasWidth = 1024;
+size_t nCanvasHeight = 512;
+size_t nTileSize = 256;
+std::vector aPixmap(nCanvasWidth * nCanvasHeight * 4, 0);
+ScopedVclPtrInstance pDevice(DeviceFormat::DEFAULT);
+pDevice->SetBackground(Wallpaper(COL_TRANSPARENT));
+pDevice->SetOutputSizePixelScaleOffsetAndBuffer(Size(nCanvasWidth, 
nCanvasHeight),
+Fraction(1.0), Point(), 
aPixmap.data());
+pXTextDocument->paintTile(*pDevice, nCanvasWidth, nCanvasHeight, 
/*nTilePosX=*/0,
+  /*nTilePosY=*/0, /*nTileWidth=*/15360, 
/*nTileHeight=*/7680);
+pDevice->EnableMapMode(false);
+Bitmap aBitmap = pDevice->GetBitmap(Point(0, 0), Size(nTileSize, 
nTileSize));
+Bitmap::ScopedReadAccess pAccess(aBitmap);
+
+// Yellow highlighting over numbering
+Color aColor(pAccess->GetPixel(103, 148));
+CPPUNIT_ASSERT_EQUAL(COL_YELLOW, aColor);
+}
+
 void SwTiledRenderingTest::testClipText()
 {
 // Load a document where the top left tile contains table text with
diff --git a/sw/source/core/text/txtfld.cxx b/sw/source/core/text/txtfld.cxx
index a1c27cbb3597..5442f3f87922 100644
--- a/sw/source/core/text/txtfld.cxx
+++ b/sw/source/core/text/txtfld.cxx
@@ -466,17 +466,17 @@ static void 
checkApplyParagraphMarkFormatToNumbering(SwFont* pNumFnt, SwTextForm
 const SfxPoolItem* pItem = aIter.GetCurItem();
 do
 {
-if (SwTextNode::IsIgnoredCharFormatForNumbering(pItem->Which()))
-pCleanedSet->ClearItem(pItem->Which());
-else if (pFormat && pFormat->HasItem(pItem->Which()))
-pCleanedSet->ClearItem(pItem->Which());
+if (pItem->Which() != RES_CHRATR_BACKGROUND)
+{
+if 
(SwTextNode::IsIgnoredCharFormatForNumbering(pItem->Which()))
+pCleanedSet->ClearItem(pItem->Which());
+else if (pFormat && pFormat->HasItem(pItem->Which()))
+pCleanedSet->ClearItem(pItem->Which());
+}
 
 pItem = aIter.NextItem();
 } while (pItem);
-// Highlightcolor also needed to be untouched, but we can't have that 
just by clearing the item
-Color nSaveHighlight = pNumFnt->GetHighlightColor();
 pNumFnt->SetDiffFnt(pCleanedSet.get(), pIDSA);
-pNumFnt->SetHighlightColor(nSaveHighlight);
 }
 }
 
___
Libreoffice-commits mailing 

[Libreoffice-bugs] [Bug 129255] calc: wrong results, proposal to clear shared formula ./. autocalculate problems

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129255

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

--- Comment #6 from Buovjaga  ---
(In reply to b. from comment #5)
> @Buovjaga: 
> 
> close? imho not, it's about how to get rid of 'shared formula -
> autocalculate' problems in general, 
> 
> at the moment they get fixed one by one as local phenomena are spotted, but
> that takes long time, and will most likely never get them all because we can
> never fully test the complexity of constructions users will produce in
> sheets, 
> 
> at the moment 118843, 124577, 128975 (and 129541) are unfixed ...

Ok, you are talking about a 'META' report, which already exists for
AutoCalculate: bug 109324
Even this very report is in it. I will close this and add the ones you
mentioned into it.
You can add yourself to the Cc of the Calculate META, if you want.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118843] calc incorrectly handles cells with a REF error

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118843

Buovjaga  changed:

   What|Removed |Added

 Blocks||109324


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109324
[Bug 109324] [META] Calculate bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 109324] [META] Calculate bugs and enhancements

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109324
Bug 109324 depends on bug 129255, which changed state.

Bug 129255 Summary: calc: wrong results, proposal to clear shared formula ./. 
autocalculate problems
https://bugs.documentfoundation.org/show_bug.cgi?id=129255

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 128975] WORK: EDIT: issues left in fixing shared-formula / autocalculate problems? - edge case ( steps in comment 4 )

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128975

Buovjaga  changed:

   What|Removed |Added

 Blocks||109324


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109324
[Bug 109324] [META] Calculate bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 109324] [META] Calculate bugs and enhancements

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109324

Buovjaga  changed:

   What|Removed |Added

 Depends on||118843, 128975


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=118843
[Bug 118843] calc incorrectly handles cells with a REF error
https://bugs.documentfoundation.org/show_bug.cgi?id=128975
[Bug 128975] WORK: EDIT: issues left in fixing shared-formula / autocalculate
problems? - edge case ( steps in comment 4 )
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132545] Rajasthan tour package

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132545

Ming Hua  changed:

   What|Removed |Added

URL|https://www.brahmandtour.co |
   |m/rajasthan-tour-package/   |
  Component|BASIC   |deletionRequest
 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 128652] Free Internet security solutions

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128652

Ming Hua  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED
URL|https://enrollsetup.com/|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/source

2020-04-30 Thread Miklos Vajna (via logerrit)
 sw/source/core/doc/DocumentSettingManager.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5ce5f26159361b2e40d89d82595068067bc8ef7b
Author: Miklos Vajna 
AuthorDate: Wed Apr 29 21:07:47 2020 +0200
Commit: Miklos Vajna 
CommitDate: Thu Apr 30 09:11:43 2020 +0200

sw: handle TabOverMargin when replacing compat options

This was added in commit bdfc6363d66aa079512cc8008996b633f693fed1
(n#793998 sw: add TabOverMargin compat mode, 2013-01-08), it's off by
default and on for MSO documents.

Change-Id: Ic97e711e4c8be507db71c49ffbdb63b40464c1bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93178
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/source/core/doc/DocumentSettingManager.cxx 
b/sw/source/core/doc/DocumentSettingManager.cxx
index 60cbae457508..bbc2f0781387 100644
--- a/sw/source/core/doc/DocumentSettingManager.cxx
+++ b/sw/source/core/doc/DocumentSettingManager.cxx
@@ -622,7 +622,7 @@ void 
sw::DocumentSettingManager::ReplaceCompatibilityOptions(const DocumentSetti
 // No mbUnbreakableNumberings
 // No mbClippedPictures
 // No mbBackgroundParaOverDrawings
-// No mbTabOverMargin
+mbTabOverMargin = rSource.mbTabOverMargin;
 // No mbTreatSingleColumnBreakAsPageBreak
 // No mbSurroundTextWrapSmall
 // No mbPropLineSpacingShrinksFirstLine
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 131286] macOS title bar not reflecting dark mode setting

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131286

--- Comment #8 from Stephan Bergmann  ---
> Date: Thu, 30 Apr 2020 04:00:33 +
[...]
> QA Administrators  changed:
> 
>What|Removed |Added
> 
>Keywords||bibisectRequest

Why?  What needs bibisecting here?  Comment 7 already identified the relevant
commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104522] [META] DOCX (OOXML) header & footer-related issues

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104522
Bug 104522 depends on bug 121525, which changed state.

Bug 121525 Summary: DOCX Import formula alignment (centered or right-aligned 
formulas are left-aligned in Writer)
https://bugs.documentfoundation.org/show_bug.cgi?id=121525

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132545] New: Rajasthan tour package

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132545

Bug ID: 132545
   Summary: Rajasthan tour package
   Product: LibreOffice
   Version: 3.3.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: brahmandtou...@gmail.com

Description:
Rajasthan an incredibly beautiful state with vibrant colors and popular tourist
destination in India. It is also known as the land of Jaw-dropping Forts and
Palaces, Kings and Queens, commendable folk music, Mouth watering cuisine,
traditional welcome and hospitality

Actual Results:
Travel

Expected Results:
Rajasthan tour package


Reproducible: Always


User Profile Reset: No



Additional Info:
Rajasthan tour package

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132545] Rajasthan tour package

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132545

brahmandtou...@gmail.com changed:

   What|Removed |Added

URL||https://www.brahmandtour.co
   ||m/rajasthan-tour-package/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105478] DOC LAYOUT specified height row splits and flows back to previous page, despite not meeting minimum height (comment 9).

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105478

Justin L  changed:

   What|Removed |Added

Summary|DOC LAYOUT specified height |DOC LAYOUT specified height
   |row splits and flows back   |row splits and flows back
   |to previous page, despite   |to previous page, despite
   |not meeting minimum height. |not meeting minimum height
   ||(comment 9).
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4425
Version|5.2.4.2 release |5.3.0.3 release
 CC||mikekagan...@hotmail.com

--- Comment #11 from Justin L  ---
The root problem here seems to have been caused by LO 5.3.0.1's fix for bug
104425.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=6f5024de2e1a5cc533527e45b33d9a415467c48d

A minimum height for a table cell should be honoured. Otherwise what is the
point, since a table grows to fill the space it needs anyway, and then there is
no need for a minimum height (unless your content doesn't fill all of the
space). But obviously this is tricky based on the history and fallout of that
bugfix.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 128689] Request to Localize More Formatting Icons into Korean UI

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128689

--- Comment #24 from DaeHyun Sung  ---
Created attachment 160109
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160109=edit
HWP 2018's Korean Vertical & horizontal Text setting UI (Top Icon Selection)

HWP 2018's Korean Vertical & horizontal Text setting UI (Top Icon Selection)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132528] Crash when opening Base (no .odb file) on Linux Mint 18.3

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132528

Robert Großkopf  changed:

   What|Removed |Added

 CC||rob...@familiegrosskopf.de

--- Comment #3 from Robert Großkopf  ---
If you want to get an internal Firebird database you have to set the
experimental functions to "On" since LO 6.4.3

But you are writing the wizard for creating a database will crash? Or do I
understand it wrong with "Application LO Base". You couldn't open Base without
having an *.odb-file.

Contrary to Juliet in comment 1 I would prefer packages from LO directly for
databases. There are many special Base-bugs in the packages of the
distributions. One special from OpenSUSE at this moment: Unable to open any
Firebird database.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'feature/drawinglayercore' - 118 commits - bin/distro-install-file-lists bridges/source chart2/qa chart2/source comphelper/source compilerplugins/clang configure

2020-04-30 Thread Tomaž Vajngerl (via logerrit)
Rebased ref, commits from common ancestor:
commit 82ec858f9d4997568142e5455d96b4493d7f1a14
Author: Tomaž Vajngerl 
AuthorDate: Thu Apr 30 07:54:46 2020 +0200
Commit: Tomaž Vajngerl 
CommitDate: Thu Apr 30 08:51:55 2020 +0200

test import and export of multi-page PDF with PDFium filter

The test checks that the exported PDFs contain embedded PDF for
different pages.

Change-Id: I4e5cd108d8597851d86aa774efbde0d4f2b9d2ac

diff --git a/vcl/qa/cppunit/pdfexport/data/SimpleMultiPagePDF.pdf 
b/vcl/qa/cppunit/pdfexport/data/SimpleMultiPagePDF.pdf
new file mode 100644
index ..af665fcba8a0
Binary files /dev/null and 
b/vcl/qa/cppunit/pdfexport/data/SimpleMultiPagePDF.pdf differ
diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx 
b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index 313dbdd278b4..c228cc7945a6 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -26,6 +26,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -146,6 +147,8 @@ public:
 void testLargePage();
 void testVersion15();
 void testDefaultVersion();
+void testMultiPagePDF();
+
 
 CPPUNIT_TEST_SUITE(PdfExportTest);
 CPPUNIT_TEST(testTdf106059);
@@ -189,6 +192,7 @@ public:
 CPPUNIT_TEST(testLargePage);
 CPPUNIT_TEST(testVersion15);
 CPPUNIT_TEST(testDefaultVersion);
+CPPUNIT_TEST(testMultiPagePDF);
 CPPUNIT_TEST_SUITE_END();
 };
 
@@ -2154,6 +2158,136 @@ void PdfExportTest::testVersion15()
 CPPUNIT_ASSERT_EQUAL(15, nFileVersion);
 }
 
+// Check round-trip of importing and exporting the PDF with PDFium filter,
+// which imports the PDF document as multiple PDFs as graphic object.
+// Each page in the document has one PDF graphic object which content is
+// the correcponding page in the PDF. When such a document is exported,
+// the PDF graphic gets embedded into the exported PDF document (as a
+// Form XObject).
+void PdfExportTest::testMultiPagePDF()
+{
+// We need to enable PDFium import (and make sure to disable after the 
test)
+bool bResetEnvVar = false;
+if (getenv("LO_IMPORT_USE_PDFIUM") == nullptr)
+{
+bResetEnvVar = true;
+setenv("LO_IMPORT_USE_PDFIUM", "1", false);
+}
+comphelper::ScopeGuard aPDFiumEnvVarGuard([&]() {
+if (bResetEnvVar)
+unsetenv("LO_IMPORT_USE_PDFIUM");
+});
+
+// Load the PDF and save as PDF
+OUString aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) + 
"SimpleMultiPagePDF.pdf";
+mxComponent = loadFromDesktop(aURL);
+CPPUNIT_ASSERT(mxComponent.is());
+
+uno::Reference xStorable(mxComponent, uno::UNO_QUERY);
+utl::MediaDescriptor aMediaDescriptor;
+aMediaDescriptor["FilterName"] <<= OUString("writer_pdf_Export");
+xStorable->storeToURL(maTempFile.GetURL(), 
aMediaDescriptor.getAsConstPropertyValueList());
+
+// Parse the export result.
+vcl::filter::PDFDocument aDocument;
+SvFileStream aStream(maTempFile.GetURL(), StreamMode::READ);
+CPPUNIT_ASSERT(aDocument.Read(aStream));
+
+std::vector aPages = aDocument.GetPages();
+CPPUNIT_ASSERT_EQUAL(static_cast(3), aPages.size());
+
+vcl::filter::PDFObjectElement* pResources = 
aPages[0]->LookupObject("Resources");
+CPPUNIT_ASSERT(pResources);
+
+auto pXObjects = 
dynamic_cast(pResources->Lookup("XObject"));
+CPPUNIT_ASSERT(pXObjects);
+
+CPPUNIT_ASSERT_EQUAL(static_cast(3), 
pXObjects->GetItems().size()); // 3 PDFs as Form XObjects
+
+std::vector rIDs;
+for (auto const & rPair : pXObjects->GetItems()) {
+rIDs.push_back(rPair.first);
+}
+
+// Let's check the embedded PDF pages - just make sure the size differs,
+// which should indicate we don't have 3 times the same page.
+
+{   // embedded PDF page 1
+vcl::filter::PDFObjectElement* pXObject1 = 
pXObjects->LookupObject(rIDs[0]);
+CPPUNIT_ASSERT(pXObject1);
+CPPUNIT_ASSERT_EQUAL(OString("Im19"), rIDs[0]);
+
+auto pSubtype1 = 
dynamic_cast(pXObject1->Lookup("Subtype"));
+CPPUNIT_ASSERT(pSubtype1);
+CPPUNIT_ASSERT_EQUAL(OString("Form"), pSubtype1->GetValue());
+
+auto pXObjectResources = 
dynamic_cast(pXObject1->Lookup("Resources"));
+CPPUNIT_ASSERT(pXObjectResources);
+auto pXObjectForms = 
dynamic_cast(pXObjectResources->LookupElement("XObject"));
+CPPUNIT_ASSERT(pXObjectForms);
+vcl::filter::PDFObjectElement* pForm = 
pXObjectForms->LookupObject(pXObjectForms->GetItems().begin()->first);
+CPPUNIT_ASSERT(pForm);
+
+vcl::filter::PDFStreamElement* pStream = pForm->GetStream();
+CPPUNIT_ASSERT(pStream);
+SvMemoryStream& rObjectStream = pStream->GetMemory();
+rObjectStream.Seek(STREAM_SEEK_TO_BEGIN);
+
+// Just check that the size of the page stream is what is expected.
+CPPUNIT_ASSERT_EQUAL(sal_uInt64(230), rObjectStream.remainingSize());
+}
+
+{   // embedded 

[Libreoffice-commits] core.git: Branch 'feature/drawinglayercore' - 2 commits - drawinglayer/source solenv/clang-format vcl/qa

2020-04-30 Thread Tomaž Vajngerl (via logerrit)
 drawinglayer/source/processor2d/vclpixelprocessor2d.cxx | 1557 
 solenv/clang-format/blacklist   |1 
 vcl/qa/cppunit/pdfexport/data/SimpleMultiPagePDF.pdf|binary
 vcl/qa/cppunit/pdfexport/pdfexport.cxx  |  134 +
 4 files changed, 945 insertions(+), 747 deletions(-)

New commits:
commit f6fb4a0b2127b12ebb904659259de216c6a9b2d2
Author: Tomaž Vajngerl 
AuthorDate: Thu Apr 30 07:54:46 2020 +0200
Commit: Tomaž Vajngerl 
CommitDate: Thu Apr 30 08:50:29 2020 +0200

test import and export of multi-page PDF with PDFium filter

The test checks that the exported PDFs contain embedded PDF for
different pages.

Change-Id: I4e5cd108d8597851d86aa774efbde0d4f2b9d2ac

diff --git a/vcl/qa/cppunit/pdfexport/data/SimpleMultiPagePDF.pdf 
b/vcl/qa/cppunit/pdfexport/data/SimpleMultiPagePDF.pdf
new file mode 100644
index ..af665fcba8a0
Binary files /dev/null and 
b/vcl/qa/cppunit/pdfexport/data/SimpleMultiPagePDF.pdf differ
diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx 
b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index 313dbdd278b4..c228cc7945a6 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -26,6 +26,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -146,6 +147,8 @@ public:
 void testLargePage();
 void testVersion15();
 void testDefaultVersion();
+void testMultiPagePDF();
+
 
 CPPUNIT_TEST_SUITE(PdfExportTest);
 CPPUNIT_TEST(testTdf106059);
@@ -189,6 +192,7 @@ public:
 CPPUNIT_TEST(testLargePage);
 CPPUNIT_TEST(testVersion15);
 CPPUNIT_TEST(testDefaultVersion);
+CPPUNIT_TEST(testMultiPagePDF);
 CPPUNIT_TEST_SUITE_END();
 };
 
@@ -2154,6 +2158,136 @@ void PdfExportTest::testVersion15()
 CPPUNIT_ASSERT_EQUAL(15, nFileVersion);
 }
 
+// Check round-trip of importing and exporting the PDF with PDFium filter,
+// which imports the PDF document as multiple PDFs as graphic object.
+// Each page in the document has one PDF graphic object which content is
+// the correcponding page in the PDF. When such a document is exported,
+// the PDF graphic gets embedded into the exported PDF document (as a
+// Form XObject).
+void PdfExportTest::testMultiPagePDF()
+{
+// We need to enable PDFium import (and make sure to disable after the 
test)
+bool bResetEnvVar = false;
+if (getenv("LO_IMPORT_USE_PDFIUM") == nullptr)
+{
+bResetEnvVar = true;
+setenv("LO_IMPORT_USE_PDFIUM", "1", false);
+}
+comphelper::ScopeGuard aPDFiumEnvVarGuard([&]() {
+if (bResetEnvVar)
+unsetenv("LO_IMPORT_USE_PDFIUM");
+});
+
+// Load the PDF and save as PDF
+OUString aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) + 
"SimpleMultiPagePDF.pdf";
+mxComponent = loadFromDesktop(aURL);
+CPPUNIT_ASSERT(mxComponent.is());
+
+uno::Reference xStorable(mxComponent, uno::UNO_QUERY);
+utl::MediaDescriptor aMediaDescriptor;
+aMediaDescriptor["FilterName"] <<= OUString("writer_pdf_Export");
+xStorable->storeToURL(maTempFile.GetURL(), 
aMediaDescriptor.getAsConstPropertyValueList());
+
+// Parse the export result.
+vcl::filter::PDFDocument aDocument;
+SvFileStream aStream(maTempFile.GetURL(), StreamMode::READ);
+CPPUNIT_ASSERT(aDocument.Read(aStream));
+
+std::vector aPages = aDocument.GetPages();
+CPPUNIT_ASSERT_EQUAL(static_cast(3), aPages.size());
+
+vcl::filter::PDFObjectElement* pResources = 
aPages[0]->LookupObject("Resources");
+CPPUNIT_ASSERT(pResources);
+
+auto pXObjects = 
dynamic_cast(pResources->Lookup("XObject"));
+CPPUNIT_ASSERT(pXObjects);
+
+CPPUNIT_ASSERT_EQUAL(static_cast(3), 
pXObjects->GetItems().size()); // 3 PDFs as Form XObjects
+
+std::vector rIDs;
+for (auto const & rPair : pXObjects->GetItems()) {
+rIDs.push_back(rPair.first);
+}
+
+// Let's check the embedded PDF pages - just make sure the size differs,
+// which should indicate we don't have 3 times the same page.
+
+{   // embedded PDF page 1
+vcl::filter::PDFObjectElement* pXObject1 = 
pXObjects->LookupObject(rIDs[0]);
+CPPUNIT_ASSERT(pXObject1);
+CPPUNIT_ASSERT_EQUAL(OString("Im19"), rIDs[0]);
+
+auto pSubtype1 = 
dynamic_cast(pXObject1->Lookup("Subtype"));
+CPPUNIT_ASSERT(pSubtype1);
+CPPUNIT_ASSERT_EQUAL(OString("Form"), pSubtype1->GetValue());
+
+auto pXObjectResources = 
dynamic_cast(pXObject1->Lookup("Resources"));
+CPPUNIT_ASSERT(pXObjectResources);
+auto pXObjectForms = 
dynamic_cast(pXObjectResources->LookupElement("XObject"));
+CPPUNIT_ASSERT(pXObjectForms);
+vcl::filter::PDFObjectElement* pForm = 
pXObjectForms->LookupObject(pXObjectForms->GetItems().begin()->first);
+CPPUNIT_ASSERT(pForm);
+
+vcl::filter::PDFStreamElement* pStream = pForm->GetStream();
+CPPUNIT_ASSERT(pStream);

[Libreoffice-bugs] [Bug 128689] Request to Localize More Formatting Icons into Korean UI

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128689

--- Comment #23 from DaeHyun Sung  ---
Created attachment 160108
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160108=edit
HWP 2018's Korean Vertical & horizontal  Text setting UI

HWP(Hangul Word Processing) 2018's Korean Vertical & horizontal  Text setting
UI

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 128689] Request to Localize More Formatting Icons into Korean UI

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128689

--- Comment #22 from DaeHyun Sung  ---
Created attachment 160107
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160107=edit
MS Word 2016's Korean Vertical & horizontal  Text setting UI

MS Word 2016's Korean Vertical & horizontal  Text setting UI

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 126580] EDITING: Firebird - Create as View gives error but creates the view in the background.

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126580

Robert Großkopf  changed:

   What|Removed |Added

 CC||herman.via...@edpnet.be

--- Comment #6 from Robert Großkopf  ---
*** Bug 132522 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113196] [META] Korean language-specific CJK issues

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113196

DaeHyun Sung  changed:

   What|Removed |Added

 Blocks||128689


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=128689
[Bug 128689] Request to Localize More Formatting Icons into Korean UI
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132522] Base: after editing (creating) a new view, this one is not listed with the tables

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132522

Robert Großkopf  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||rob...@familiegrosskopf.de
 Resolution|--- |DUPLICATE

--- Comment #2 from Robert Großkopf  ---
This happens only with Firebird, not with internal HSQLDB. It is bug 126580. I
will close this one as a duplicate of bug 126580.

*** This bug has been marked as a duplicate of bug 126580 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 128689] Request to Localize More Formatting Icons into Korean UI

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128689

DaeHyun Sung  changed:

   What|Removed |Added

 Depends on||113196


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113196
[Bug 113196] [META] Korean language-specific CJK issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 128689] Request to Localize More Formatting Icons into Korean UI

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128689

--- Comment #21 from DaeHyun Sung  ---
I found wrong UI for Korean.

Vertical Icon is wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122247] [META] Icon requests

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122247
Bug 122247 depends on bug 128689, which changed state.

Bug 128689 Summary: Request to Localize More Formatting Icons into Korean UI
https://bugs.documentfoundation.org/show_bug.cgi?id=128689

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120949] [META] Elementary icons

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120949
Bug 120949 depends on bug 128689, which changed state.

Bug 128689 Summary: Request to Localize More Formatting Icons into Korean UI
https://bugs.documentfoundation.org/show_bug.cgi?id=128689

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 125965] [META] Sifr icons

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125965
Bug 125965 depends on bug 128689, which changed state.

Bug 128689 Summary: Request to Localize More Formatting Icons into Korean UI
https://bugs.documentfoundation.org/show_bug.cgi?id=128689

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 128689] Request to Localize More Formatting Icons into Korean UI

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128689

DaeHyun Sung  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107139] [META] Breeze icons

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107139
Bug 107139 depends on bug 128689, which changed state.

Bug 128689 Summary: Request to Localize More Formatting Icons into Korean UI
https://bugs.documentfoundation.org/show_bug.cgi?id=128689

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120946] [META] Karasa Jaga icons

2020-04-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120946
Bug 120946 depends on bug 128689, which changed state.

Bug 128689 Summary: Request to Localize More Formatting Icons into Korean UI
https://bugs.documentfoundation.org/show_bug.cgi?id=128689

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


<    1   2   3   4   5   6   >