[Libreoffice-bugs] [Bug 133592] LibreOffice 7.0.0.0 beta1 crashes when inserting a .png image into a new LibreOffice document.
https://bugs.documentfoundation.org/show_bug.cgi?id=133592 --- Comment #1 from cl...@protonmail.com --- Of these seven crashes the first three were in LibreOffice Draw. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114371] mirroring the borders of pasted images - more cropping options, crop to shape
https://bugs.documentfoundation.org/show_bug.cgi?id=114371 --- Comment #6 from solar system --- thank you for sharing details also visit site https://www.futuresolarwa.com.au/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132967] copy and paste with mouse
https://bugs.documentfoundation.org/show_bug.cgi?id=132967 --- Comment #8 from satp...@gmail.com --- I was suffering from this problem too since upgrading to Ubuntu 20.04, but as indicated by m.a.riosv I went to Menu/Tools/Options/LibreOffice/View/Mouse and changed the "Middle button" option from "Automatic Scrolling" to "Paste clipboard". I restarted Calc, and middle button paste worked again. Yay! Thanks m.a. LibreOffice 6.4.3.2 40(Build:2) Linux xxx 5.4.0-33-generic #37-Ubuntu SMP Thu May 21 12:53:59 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux VERSION="20.04 LTS (Focal Fossa)" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133592] New: LibreOffice 7.0.0.0 beta1 crashes when inserting a .png image into a new LibreOffice document.
https://bugs.documentfoundation.org/show_bug.cgi?id=133592 Bug ID: 133592 Summary: LibreOffice 7.0.0.0 beta1 crashes when inserting a .png image into a new LibreOffice document. Product: LibreOffice Version: unspecified Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cl...@protonmail.com Description: LibreOffice 7.0.0.0 beta1 crashes every time when trying to insert a .png image into a new LibreOffice document, be it in Draw, in Impress or in Writer. Steps to Reproduce: 1.Create a new Draw, Impress or Writer document. 2.Try to insert a .png image. 3.That's it. Actual Results: LibreOffice 7.0.0.0 beta1 immediately crashes. Expected Results: No crashes expected. Reproducible: Always User Profile Reset: Yes Additional Info: Build: 94f789cbb5b4a511c319542c7bdc31ff3b3c OS: Xubuntu 20.04 Linux: 5.4.0-33-generic See: crashreport.libreoffice.org/stats/crash_details/7eeac802-c16a-429c-968b-e3b71e773ef5 also: crashreport.libreoffice.org/stats/crash_details/7ca6d2f6-ed66-4f82-a78a-5a0583ad4ad1 (This second crash in "safe mode".) also: crashreport.libreoffice.org/stats/crash_details/45a35de4-4938-4a29-80bd-652a10077eee also in Impress: crashreport.libreoffice.org/stats/crash_details/e886e501-bd29-413b-b02a-d3aa4276d42f also in Writer: crashreport.libreoffice.org/stats/crash_details/570ac7ac-b385-42c6-9b23-f5f90fa23c46 also in Writer: crashreport.libreoffice.org/stats/crash_details/1ad629e9-022a-45fd-b6f5-ab32d7585c7a and also in Writer: crashreport.libreoffice.org/stats/crash_details/b85284e8-3cef-4ec7-8f1b-a2de1cfc36ec These last five crashes under a new user profile. And the last crash using a newly created and already saved nearly empty .odt document. All the other crashes happened when the newly created document hadn't even been saved for once. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: common/Session.cpp common/StringVector.cpp common/StringVector.hpp kit/ChildSession.cpp test/WhiteBoxTests.cpp wsd/ClientSession.cpp wsd/DocumentBroker.cpp wsd/LOOLWS
common/Session.cpp |2 -
common/StringVector.cpp | 73 +---
common/StringVector.hpp | 71 --
kit/ChildSession.cpp| 12 +++
test/WhiteBoxTests.cpp |3 +
wsd/ClientSession.cpp |2 -
wsd/DocumentBroker.cpp |2 -
wsd/LOOLWSD.cpp |3 -
8 files changed, 69 insertions(+), 99 deletions(-)
New commits:
commit 784b7dc39d880448e5599c19e65798d7207a412a
Author: Ashod Nakashian
AuthorDate: Sun May 31 14:16:58 2020 -0400
Commit: Ashod Nakashian
CommitDate: Tue Jun 2 01:39:37 2020 +0200
wsd: optimize StringVector
StringVector is heavily used for tokenization
and benefits from inlining of small functions.
Also, cat doesn't need to be slower than necessary.
Change-Id: I4ab2ff1b1f1a81092049d2cde64b6df10b34b5f7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/95287
Reviewed-by: Michael Meeks
Tested-by: Jenkins
diff --git a/common/Session.cpp b/common/Session.cpp
index 0b3499a05..204573e0f 100644
--- a/common/Session.cpp
+++ b/common/Session.cpp
@@ -200,7 +200,7 @@ void Session::parseDocOptions(const StringVector& tokens,
int& part, std::string
if (getTokenString(tokens[offset], "options", _docOptions))
{
if (tokens.size() > offset + 1)
-_docOptions += tokens.cat(std::string(" "), offset + 1);
+_docOptions += tokens.cat(' ', offset + 1);
}
}
}
diff --git a/common/StringVector.cpp b/common/StringVector.cpp
index aab884881..2fef5aa0b 100644
--- a/common/StringVector.cpp
+++ b/common/StringVector.cpp
@@ -17,7 +17,7 @@ StringVector::StringVector(const std::string& string, const
std::vector= _tokens.size())
{
@@ -28,76 +28,7 @@ std::string StringVector::operator[](size_t index) const
return _string.substr(token._index, token._length);
}
-size_t StringVector::size() const { return _tokens.size(); }
-
-bool StringVector::empty() const { return _tokens.empty(); }
-
-std::vector::const_iterator StringVector::begin() const { return
_tokens.begin(); }
-
-std::vector::iterator StringVector::begin() { return
_tokens.begin(); }
-
-std::vector::const_iterator StringVector::end() const { return
_tokens.end(); }
-
-std::vector::iterator StringVector::end() { return _tokens.end();
}
-
-std::vector::iterator
StringVector::erase(std::vector::const_iterator it)
-{
-return _tokens.erase(it);
-}
-
-void StringVector::push_back(const std::string& string)
-{
-StringToken token;
-token._index = _string.length();
-token._length = string.length();
-_tokens.push_back(token);
-_string += string;
-}
-
-std::string StringVector::getParam(const StringToken& token) const
-{
-return _string.substr(token._index, token._length);
-}
-
-std::string StringVector::cat(const std::string& separator, size_t offset)
const
-{
-std::string ret;
-bool first = true;
-
-if (offset >= _tokens.size())
-{
-return ret;
-}
-
-for (auto it = _tokens.begin() + offset; it != _tokens.end(); ++it)
-{
-if (first)
-{
-first = false;
-}
-else
-{
-ret += separator;
-}
-
-ret += getParam(*it);
-}
-
-return ret;
-}
-
-bool StringVector::equals(size_t index, const char* string) const
-{
-if (index >= _tokens.size())
-{
-return false;
-}
-
-const StringToken& token = _tokens[index];
-return _string.compare(token._index, token._length, string) == 0;
-}
-
-bool StringVector::equals(size_t index, const StringVector& other, size_t
otherIndex)
+bool StringVector::equals(std::size_t index, const StringVector& other,
std::size_t otherIndex)
{
if (index >= _tokens.size())
{
diff --git a/common/StringVector.hpp b/common/StringVector.hpp
index 154060bf1..fa0e94491 100644
--- a/common/StringVector.hpp
+++ b/common/StringVector.hpp
@@ -17,12 +17,12 @@
*/
struct StringToken
{
-size_t _index;
-size_t _length;
+std::size_t _index;
+std::size_t _length;
StringToken() = default;
-StringToken(size_t index, size_t length)
+StringToken(std::size_t index, std::size_t length)
: _index(index),
_length(length)
{
@@ -45,35 +45,74 @@ public:
explicit StringVector(const std::string& string, const
std::vector& tokens);
/// Unlike std::vector, gives an empty string if index is unexpected.
-std::string operator[](size_t index) const;
+std::string operator[](std::size_t index) const;
-size_t size() const;
+std::size_t size() const { return _tokens.size(); }
-bool empty() const;
+bool empty() const { return _tokens.empty(); }
-std::vector::const_iterator begin() const;
+std::vector::const_iterator begin() const { return
_tokens.begin(); }
-std::vector::iterator begin();
+std::vector::iterator begin() { return
[Libreoffice-commits] online.git: common/Crypto.cpp common/FileUtil.cpp common/JsonUtil.hpp common/Log.cpp common/LOOLWebSocket.hpp common/MessageQueue.cpp common/Seccomp.cpp common/Session.cpp common
common/Crypto.cpp|8 ++--
common/FileUtil.cpp |4 +-
common/JsonUtil.hpp |4 +-
common/LOOLWebSocket.hpp |6 +--
common/Log.cpp |4 +-
common/MessageQueue.cpp | 17 +---
common/Seccomp.cpp | 12 +++---
common/Session.cpp |4 +-
common/SigUtil.cpp |2 -
common/Util.cpp |6 +--
common/Util.hpp |4 +-
kit/ChildSession.cpp |6 +--
kit/Delta.hpp|6 +--
kit/ForKit.cpp | 10 ++---
kit/Kit.cpp | 38 ++--
kit/KitHelper.hpp|4 +-
net/DelaySocket.cpp | 28 +++---
net/FakeSocket.cpp | 24 ++--
net/ServerSocket.hpp |2 -
net/Socket.cpp | 36 +--
net/Socket.hpp | 36 +--
net/Ssl.cpp |6 +--
net/WebSocketHandler.hpp | 48 -
net/clientnb.cpp | 10 ++---
test/DeltaTests.cpp | 12 +++---
test/TileCacheTests.cpp | 16
test/UnitAdmin.cpp |2 -
test/UnitClient.cpp |2 -
test/UnitConvert.cpp |2 -
test/UnitCopyPaste.cpp | 18 -
test/UnitHTTP.cpp|7 ++-
test/UnitSession.cpp |2 -
test/UnitTyping.cpp | 10 ++---
test/UnitUNOCommand.cpp |2 -
test/countloolkits.hpp |2 -
test/fakesockettest.cpp |2 -
test/helpers.hpp |8 ++--
test/lokassert.hpp |2 -
tools/Config.cpp | 10 ++---
tools/Connect.cpp|2 -
tools/KitClient.cpp |2 -
tools/Replay.hpp |4 +-
tools/Tool.cpp |6 +--
tools/WebSocketDump.cpp | 10 ++---
tools/map.cpp|2 -
wsd/Admin.cpp| 10 ++---
wsd/AdminModel.cpp | 22 +--
wsd/ClientSession.cpp| 12 +++---
wsd/DocumentBroker.cpp | 38 ++--
wsd/FileServer.cpp | 15 +++
wsd/LOOLWSD.cpp | 89 +++
wsd/LOOLWSD.hpp |4 +-
wsd/ProxyProtocol.cpp|6 +--
wsd/ProxyProtocol.hpp|8 ++--
wsd/RequestDetails.hpp |2 -
wsd/SenderQueue.hpp |6 +--
wsd/ServerURL.hpp|8 ++--
wsd/Storage.cpp | 26 ++---
wsd/TileCache.cpp| 10 ++---
wsd/TileDesc.hpp |4 +-
60 files changed, 356 insertions(+), 352 deletions(-)
New commits:
commit 224ef08c7f6c9cf2a88fbf156225f04cac2eabeb
Author: Ashod Nakashian
AuthorDate: Sun May 24 09:10:18 2020 -0400
Commit: Ashod Nakashian
CommitDate: Tue Jun 2 01:31:26 2020 +0200
wsd: single-char string literals -> char
More readable and typically more efficient.
Change-Id: I9bd5bfc91f4ac255bb8ae0987708fb8b56b398f8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/95285
Reviewed-by: Michael Meeks
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice
diff --git a/common/Crypto.cpp b/common/Crypto.cpp
index 7c1d00052..5faf1988a 100644
--- a/common/Crypto.cpp
+++ b/common/Crypto.cpp
@@ -43,24 +43,24 @@ struct SupportKeyImpl
if (firstColon != std::string::npos)
{
std::string expiry(key.substr(0, firstColon));
-LOG_INF("Support key with expiry '" << expiry << "'");
+LOG_INF("Support key with expiry '" << expiry << '\'');
try {
int timeZoneDifferential = 0;
Poco::DateTimeParser::parse(expiry, _expiry,
timeZoneDifferential);
-size_t lastColon = key.rfind(":");
+size_t lastColon = key.rfind(':');
if (lastColon != std::string::npos)
{
_signature = key.substr(lastColon + 1,
key.length() - lastColon);
_data = key.substr(0, lastColon);
-LOG_INF("Support key signature '" << _signature << "' data
'" << _data << "'");
+LOG_INF("Support key signature '" << _signature << "' data
'" << _data << '\'');
_invalid = false;
}
} catch (SyntaxException ) {
-LOG_ERR("Invalid support key expiry '" << expiry << "'");
+LOG_ERR("Invalid support key expiry '" << expiry << '\'');
}
}
}
diff --git a/common/FileUtil.cpp b/common/FileUtil.cpp
index 054a9461d..793fc1e25 100644
--- a/common/FileUtil.cpp
+++ b/common/FileUtil.cpp
@@ -223,7 +223,7 @@ namespace FileUtil
catch (const std::exception)
{
// Already removed or we don't care about failures.
-LOG_DBG("Exception removing " << path << " " << recursive << " : "
<< e.what());
+LOG_DBG("Exception removing " << path << ' ' << recursive << " : "
<< e.what());
}
#endif
}
@@ -273,7 +273,7 @@ namespace FileUtil
if (lastSlash !=
[Libreoffice-bugs] [Bug 130693] PRINTING: font or style selectively changed from Writer in PDF printout
https://bugs.documentfoundation.org/show_bug.cgi?id=130693 --- Comment #10 from Nick Levinson --- That's comparing apples to oranges. I still don't know why the previews in your system via Okular and in my laptop, including in Writer for ODT and Okular for PDF and, for PDF, on Canon and Xerox are all correct while the paper output from Canon and Xerox are wrong. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - editeng/source include/editeng sw/qa
editeng/source/misc/svxacorr.cxx | 74 +-
include/editeng/svxacorr.hxx |1
sw/qa/extras/uiwriter/data/tdf133524.fodt | 14 +
sw/qa/extras/uiwriter/uiwriter.cxx| 49 +++
4 files changed, 137 insertions(+), 1 deletion(-)
New commits:
commit 4f0751949b6c2a495891e67a893ef98d4e4b5a80
Author: László Németh
AuthorDate: Thu May 28 08:50:39 2020 +0200
Commit: Adolfo Jayme Barrientos
CommitDate: Tue Jun 2 01:15:11 2020 +0200
tdf#133524 AutoCorrect: support double angle quotes
Add two methods to support double angle quotes,
as part of "Double quotes" replacement:
1. Correct ">>" and "<<" to » and « in several languages,
where double angle quotes are default or alternative
primary or second level quotation marks, but actual
LibreOffice locale settings don't contain double angle
quotes.
2. Correct " to double angle quotes, if the cursor
is there in a primary level quotation (i.e. there
is a preceding primary level opening quote, but not
other quotes). For example, it's possible to type
Hungarian or Romanian quotation marks in
„... »quote« ...”
pressing only Shift + 2 (") for them. (These languages,
where "Single quotes" replacement is used for apostrophe
and third level quotes instead of the standard second
level quotation marks.)
Change-Id: Icd1584a5a2b81422de693217d2d1f7f3058a74b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95212
Tested-by: Jenkins
Tested-by: László Németh
Reviewed-by: László Németh
(cherry picked from commit 57f07b1d7378d218648667c5b1315cc8ad905875)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95310
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/editeng/source/misc/svxacorr.cxx b/editeng/source/misc/svxacorr.cxx
index ebc0ec810a60..24a5235e9c1a 100644
--- a/editeng/source/misc/svxacorr.cxx
+++ b/editeng/source/misc/svxacorr.cxx
@@ -259,6 +259,7 @@ bool SvxAutoCorrect::IsAutoCorrectChar( sal_Unicode cChar )
cChar == '*' || cChar == '_' || cChar == '%' ||
cChar == '.' || cChar == ',' || cChar == ';' ||
cChar == ':' || cChar == '?' || cChar == '!' ||
+cChar == '<' || cChar == '>' ||
cChar == '/' || cChar == '-';
}
@@ -309,6 +310,12 @@ ACFlags SvxAutoCorrect::GetDefaultFlags()
static constexpr sal_Unicode cEmDash = 0x2014;
static constexpr sal_Unicode cEnDash = 0x2013;
static constexpr sal_Unicode cApostrophe = 0x2019;
+static constexpr sal_Unicode cLeftDoubleAngleQuote = 0xAB;
+static constexpr sal_Unicode cRightDoubleAngleQuote = 0xBB;
+// stop characters for searching preceding quotes
+// (the first character is also the opening quote we are looking for)
+const sal_Unicode aStopDoubleAngleQuoteStart[] = { 0x201E, 0x201D, 0 }; //
preceding ,,
+const sal_Unicode aStopDoubleAngleQuoteEnd[] = { cRightDoubleAngleQuote,
cLeftDoubleAngleQuote, 0x201D, 0x201E, 0 }; // preceding >>
SvxAutoCorrect::SvxAutoCorrect( const OUString& rShareAutocorrFile,
const OUString& rUserAutocorrFile )
@@ -1194,7 +1201,16 @@ void SvxAutoCorrect::InsertQuote( SvxAutoCorrDoc& rDoc,
sal_Int32 nInsPos,
sal_Unicode cInsChar, bool bSttQuote,
bool bIns, LanguageType eLang, ACQuotes
eType ) const
{
-sal_Unicode cRet = GetQuote( cInsChar, bSttQuote, eLang );
+sal_Unicode cRet;
+
+if ( eType == ACQuotes::DoubleAngleQuote )
+{
+cRet = ( '<' == cInsChar || ('\"' == cInsChar && !bSttQuote) )
+? cLeftDoubleAngleQuote
+: cRightDoubleAngleQuote;
+}
+else
+cRet = GetQuote( cInsChar, bSttQuote, eLang );
OUString sChg( cInsChar );
if( bIns )
@@ -1213,6 +1229,11 @@ void SvxAutoCorrect::InsertQuote( SvxAutoCorrDoc& rDoc,
sal_Int32 nInsPos,
++nInsPos;
}
}
+else if( eType == ACQuotes::DoubleAngleQuote && cInsChar != '\"' )
+{
+rDoc.Delete( nInsPos-1, nInsPos);
+--nInsPos;
+}
rDoc.Replace( nInsPos, sChg );
@@ -1242,6 +1263,26 @@ OUString SvxAutoCorrect::GetQuote( SvxAutoCorrDoc const
& rDoc, sal_Int32 nInsPo
return sRet;
}
+// search preceding opening quote in the paragraph before the insert position
+static bool lcl_HasPrecedingChar( const OUString& rTxt, sal_Int32 nPos,
+const sal_Unicode sPrecedingChar, const sal_Unicode*
aStopChars )
+{
+sal_Unicode cTmpChar;
+
+do {
+cTmpChar = rTxt[ --nPos ];
+if ( cTmpChar == sPrecedingChar )
+return true;
+
+for ( const sal_Unicode* pCh = aStopChars; *pCh; ++pCh )
+if ( cTmpChar == *pCh )
+return false;
+
+} while ( nPos > 0 );
+
+return false;
+}
+
// WARNING: rText may become invalid, see comment below
void
[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - configure.ac
configure.ac | 73 +--
1 file changed, 37 insertions(+), 36 deletions(-)
New commits:
commit 05f8ddaab5ca36f1ac68cda3f6df32eaec6c8397
Author: Thorsten Behrens
AuthorDate: Sun May 31 04:03:05 2020 +0200
Commit: Thorsten Behrens
CommitDate: Tue Jun 2 00:40:27 2020 +0200
configure.ac: make --enable-gtk3-kde5 work standalone
Previously always required the gtk3 backend enabled, too.
Plus jmux's Split gtk3* VCL backend test and library detection
from https://gerrit.libreoffice.org/c/core/+/95250
Change-Id: I9fc216686574aa0085ad1aa8cf93b316e277
Co-authored-by: Jan-Marek Glogowski
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95216
Tested-by: Thorsten Behrens
Reviewed-by: Thorsten Behrens
(cherry picked from commit 5e1eaaeb04e6194a3587eefcfd8e63652cc3a46d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95233
Tested-by: Jenkins
diff --git a/configure.ac b/configure.ac
index e950255146bd..6ebe3856333d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -10666,21 +10666,47 @@ R=""
if test "$USING_X11" != TRUE; then
enable_gtk3=no
fi
-GTK3_CFLAGS=""
-GTK3_LIBS=""
+
ENABLE_GTK3=""
if test "x$enable_gtk3" = "xyes"; then
+ENABLE_GTK3="TRUE"
+AC_DEFINE(ENABLE_GTK3)
+R="$R gtk3"
+fi
+AC_SUBST(ENABLE_GTK3)
+
+ENABLE_GTK3_KDE5=""
+if test "x$enable_gtk3_kde5" = "xyes"; then
+ENABLE_GTK3_KDE5="TRUE"
+AC_DEFINE(ENABLE_GTK3_KDE5)
+R="$R gtk3_kde5"
+fi
+AC_SUBST(ENABLE_GTK3_KDE5)
+
+ENABLE_QT5=""
+if test "x$enable_qt5" = "xyes"; then
+ENABLE_QT5="TRUE"
+AC_DEFINE(ENABLE_QT5)
+R="$R qt5"
+fi
+AC_SUBST(ENABLE_QT5)
+
+ENABLE_KF5=""
+if test "x$enable_kf5" = "xyes"; then
+ENABLE_KF5="TRUE"
+AC_DEFINE(ENABLE_KF5)
+R="$R kf5"
+fi
+AC_SUBST(ENABLE_KF5)
+
+GTK3_CFLAGS=""
+GTK3_LIBS=""
+if test "x$enable_gtk3" = "xyes" -o "x$enable_gtk3_kde5" = "xyes"; then
if test "$with_system_cairo" = no; then
AC_MSG_ERROR([System cairo required for gtk3 support, do not combine
--enable-gtk3 with --without-system-cairo])
fi
: ${with_system_cairo:=yes}
-PKG_CHECK_MODULES(GTK3, gtk+-3.0 >= 3.18 gtk+-unix-print-3.0
gmodule-no-export-2.0 glib-2.0 >= 2.38 cairo, ENABLE_GTK3="TRUE",
ENABLE_GTK3="")
-if test "x$ENABLE_GTK3" = "xTRUE"; then
-AC_DEFINE(ENABLE_GTK3)
-R="gtk3"
-else
-AC_MSG_ERROR([gtk3 or dependent libraries of the correct versions, not
found])
-fi
+PKG_CHECK_MODULES(GTK3, gtk+-3.0 >= 3.18 gtk+-unix-print-3.0
gmodule-no-export-2.0 glib-2.0 >= 2.38 cairo)
GTK3_CFLAGS=$(printf '%s' "$GTK3_CFLAGS" | sed -e "s/-I/${ISYSTEM?}/g")
FilterLibs "${GTK3_LIBS}"
GTK3_LIBS="${filteredlibs}"
@@ -10694,40 +10720,15 @@ if test "x$enable_gtk3" = "xyes"; then
fi
AC_SUBST(GTK3_LIBS)
AC_SUBST(GTK3_CFLAGS)
-AC_SUBST(ENABLE_GTK3)
if test "$enable_introspection" = yes; then
-if test "$ENABLE_GTK3" = TRUE; then
+if test "$ENABLE_GTK3" = "TRUE" -o "$ENABLE_GTK3_KDE5" = "TRUE"; then
GOBJECT_INTROSPECTION_REQUIRE(INTROSPECTION_REQUIRED_VERSION)
else
AC_MSG_ERROR([--enable-introspection requires --enable-gtk3])
fi
fi
-ENABLE_QT5=""
-if test "x$enable_qt5" = "xyes"; then
-ENABLE_QT5="TRUE"
-AC_DEFINE(ENABLE_QT5)
-R="$R qt5"
-fi
-AC_SUBST(ENABLE_QT5)
-
-ENABLE_KF5=""
-if test "x$enable_kf5" = "xyes"; then
-ENABLE_KF5="TRUE"
-AC_DEFINE(ENABLE_KF5)
-R="$R kf5"
-fi
-AC_SUBST(ENABLE_KF5)
-
-ENABLE_GTK3_KDE5=""
-if test "x$enable_gtk3_kde5" = "xyes"; then
-ENABLE_GTK3_KDE5="TRUE"
-AC_DEFINE(ENABLE_GTK3_KDE5)
-R="$R gtk3_kde5"
-fi
-AC_SUBST(ENABLE_GTK3_KDE5)
-
if test "$_os" = "WINNT"; then
R="$R win"
elif test "$_os" = "Darwin"; then
@@ -10859,7 +10860,7 @@ AC_SUBST(SYSTEM_BLUEZ)
dnl ===
dnl Check whether to enable GIO support
dnl ===
-if test "$ENABLE_GTK3" = "TRUE"; then
+if test "$ENABLE_GTK3" = "TRUE" -o "$ENABLE_GTK3_KDE5" = "TRUE"; then
AC_MSG_CHECKING([whether to enable GIO support])
if test "$_os" != "WINNT" -a "$_os" != "Darwin" -a "$enable_gio" = "yes";
then
dnl Need at least 2.26 for the dbus support.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
GSOC Community Bonding Period Report (Yusuf Keten)
Hello, I started the first phase of implementation of my project " https://summerofcode.withgoogle.com/projects/#6523754777149440;. - I've created a draft for this project which includes some necessary functions to implement API - App connection(curl etc.), JSON Parser, etc.[1] - I talked to my mentor about the future of the project such as the design of the dialog, code convention, etc. This week TODO - The connection between additions dialog and extension manager functions to install and uninstall the extensions. - JSON Parse test Also, thanks to my mentors for sharing their knowledge and experience with me. Best regards, Yusuf Keten IRC: yusufketen [1]: https://gerrit.libreoffice.org/c/core/+/95297 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/drawinglayercore' - 71 commits - basegfx/test compilerplugins/clang configure.ac drawinglayer/CppunitTest_drawinglayer_border.mk drawinglayer/inc drawin
Rebased ref, commits from common ancestor:
commit 8cc2d1f6d7aa461479f514824595ff2419feb65d
Author: Tomaž Vajngerl
AuthorDate: Mon Jun 1 23:04:00 2020 +0200
Commit: Tomaž Vajngerl
CommitDate: Mon Jun 1 23:08:16 2020 +0200
Use "Radius" instead of "Rad" for new properties
Change-Id: Ifd232bccf1519e0ed68195cf4344893175a675e0
diff --git a/include/svx/strings.hrc b/include/svx/strings.hrc
index fb9ed922f551..14da2224acf4 100644
--- a/include/svx/strings.hrc
+++ b/include/svx/strings.hrc
@@ -511,10 +511,10 @@
#define SIP_SA_GRAFINVERT
NC_("SIP_SA_GRAFINVERT", "Invert")
#define SIP_SA_GRAFMODE
NC_("SIP_SA_GRAFMODE", "Image mode")
#define SIP_SA_GRAFCROP
NC_("SIP_SA_GRAFCROP", "Crop")
-#define SIP_SA_GLOW_RAD
NC_("SIP_SA_GLOW_RAD", "Radius of glow effect")
+#define SIP_SA_GLOW_RADIUS
NC_("SIP_SA_GLOW_RADIUS", "Radius of glow effect")
#define SIP_SA_GLOW_COLOR
NC_("SIP_SA_GLOW_COLOR", "Color of glow effect")
#define SIP_SA_GLOW_TRANSPARENCY
NC_("SIP_SA_GLOW_TRANSPARENCY", "Transparency of glow effect")
-#define SIP_SA_SOFTEDGE_RAD
NC_("SIP_SA_SOFTEDGE_RAD", "Radius of soft edge effect")
+#define SIP_SA_SOFTEDGE_RADIUS
NC_("SIP_SA_SOFTEDGE_RADIUS", "Radius of soft edge effect")
#define STR_ObjNameSingulMEDIA
NC_("STR_ObjNameSingulMEDIA", "Media object")
#define STR_ObjNamePluralMEDIA
NC_("STR_ObjNamePluralMEDIA", "Media objects")
// drawing layer table strings
diff --git a/include/svx/svddef.hxx b/include/svx/svddef.hxx
index 27d90b44165c..30031e20dde2 100644
--- a/include/svx/svddef.hxx
+++ b/include/svx/svddef.hxx
@@ -417,14 +417,14 @@ constexpr TypedWhichId
SDRATTR_TABLE_TEXT_ROTATION (SDRATTR_T
constexpr sal_uInt16 SDRATTR_TABLE_LAST
(SDRATTR_TABLE_TEXT_ROTATION);
constexpr sal_uInt16 SDRATTR_GLOW_FIRST
(SDRATTR_TABLE_LAST+1);
-constexpr TypedWhichId SDRATTR_GLOW_RAD
(SDRATTR_GLOW_FIRST+0);
+constexpr TypedWhichId SDRATTR_GLOW_RADIUS
(SDRATTR_GLOW_FIRST+0);
constexpr TypedWhichIdSDRATTR_GLOW_COLOR
(SDRATTR_GLOW_FIRST+1);
constexpr TypedWhichId
SDRATTR_GLOW_TRANSPARENCY(SDRATTR_GLOW_FIRST + 2);
constexpr sal_uInt16 SDRATTR_GLOW_LAST
(SDRATTR_GLOW_TRANSPARENCY);
constexpr sal_uInt16 SDRATTR_SOFTEDGE_FIRST(SDRATTR_GLOW_LAST
+ 1);
-constexpr TypedWhichId
SDRATTR_SOFTEDGE_RAD(SDRATTR_SOFTEDGE_FIRST + 0);
-constexpr sal_uInt16
SDRATTR_SOFTEDGE_LAST(SDRATTR_SOFTEDGE_RAD);
+constexpr TypedWhichId
SDRATTR_SOFTEDGE_RADIUS(SDRATTR_SOFTEDGE_FIRST + 0);
+constexpr sal_uInt16
SDRATTR_SOFTEDGE_LAST(SDRATTR_SOFTEDGE_RADIUS);
constexpr sal_uInt16 SDRATTR_END (SDRATTR_SOFTEDGE_LAST); /* 1357 */ /*
1333 V4+++*/ /* 1243 V4+++*/ /*1213*/ /*1085*/ /*1040*/ /*Pool V2: 1123,V1:
1065 */
diff --git a/include/svx/unoshprp.hxx b/include/svx/unoshprp.hxx
index 4b3a05c6b5f4..33d47c5bc421 100644
--- a/include/svx/unoshprp.hxx
+++ b/include/svx/unoshprp.hxx
@@ -210,12 +210,12 @@
{ OUString("FontWorkShadowTransparence"),XATTR_FORMTXTSHDWTRANSP,
::cppu::UnoType::get(),0, 0},
#define GLOW_PROPERTIES \
-{ OUString{"GlowEffectRad"}, SDRATTR_GLOW_RAD,
::cppu::UnoType::get(),0, 0,
PropertyMoreFlags::METRIC_ITEM}, \
+{ OUString{"GlowEffectRadius"}, SDRATTR_GLOW_RADIUS,
::cppu::UnoType::get(),0, 0,
PropertyMoreFlags::METRIC_ITEM}, \
{ OUString{"GlowEffectColor"},SDRATTR_GLOW_COLOR,
::cppu::UnoType::get(),0, 0}, \
{ OUString{"GlowEffectTransparency"},
SDRATTR_GLOW_TRANSPARENCY,::cppu::UnoType::get(),0, 0 },
#define SOFTEDGE_PROPERTIES \
-{ OUString{"SoftEdgeRad"}, SDRATTR_SOFTEDGE_RAD,
cppu::UnoType::get(), 0, 0,
PropertyMoreFlags::METRIC_ITEM},
+{ OUString{"SoftEdgeRadius"}, SDRATTR_SOFTEDGE_RADIUS,
cppu::UnoType::get(), 0, 0,
PropertyMoreFlags::METRIC_ITEM},
#define SHADOW_PROPERTIES \
{ OUString(UNO_NAME_SHADOW),SDRATTR_SHADOW,
cppu::UnoType::get(),0, 0}, \
diff --git a/oox/source/drawingml/shape.cxx b/oox/source/drawingml/shape.cxx
index d0f243ffabc1..3fedf4dbb761 100644
--- a/oox/source/drawingml/shape.cxx
+++ b/oox/source/drawingml/shape.cxx
@@ -1470,7 +1470,7 @@ Reference< XShape > const & Shape::createAndInsert(
if ( aEffectProperties.maGlow.moGlowRad.has() )
{
uno::Reference propertySet (mxShape,
uno::UNO_QUERY);
-propertySet->setPropertyValue("GlowEffectRad",
[Libreoffice-commits] core.git: Branch 'feature/drawinglayercore' - include/svx oox/source sd/qa svx/sdi svx/source xmloff/source
include/svx/strings.hrc |4 ++--
include/svx/svddef.hxx|6 +++---
include/svx/unoshprp.hxx |4 ++--
oox/source/drawingml/shape.cxx|4 ++--
oox/source/export/drawingml.cxx |8
oox/source/token/properties.txt |2 +-
sd/qa/unit/export-tests-ooxml2.cxx|4 ++--
sd/qa/unit/export-tests.cxx |4 ++--
sd/qa/unit/import-tests.cxx |2 +-
svx/sdi/svx.sdi |2 +-
svx/source/sdr/primitive2d/sdrattributecreator.cxx|4 ++--
svx/source/sidebar/glow/GlowPropertyPanel.cxx |2 +-
svx/source/sidebar/softedge/SoftEdgePropertyPanel.cxx |2 +-
svx/source/svdraw/svdattr.cxx | 12 ++--
xmloff/source/draw/sdpropls.cxx |4 ++--
15 files changed, 32 insertions(+), 32 deletions(-)
New commits:
commit 99007f2a03c69bbee6150ec6493fdc14b9981a77
Author: Tomaž Vajngerl
AuthorDate: Mon Jun 1 23:04:00 2020 +0200
Commit: Tomaž Vajngerl
CommitDate: Mon Jun 1 23:04:00 2020 +0200
Use "Radius" instead of "Rad" for new properties
Change-Id: Ifd232bccf1519e0ed68195cf4344893175a675e0
diff --git a/include/svx/strings.hrc b/include/svx/strings.hrc
index fb9ed922f551..14da2224acf4 100644
--- a/include/svx/strings.hrc
+++ b/include/svx/strings.hrc
@@ -511,10 +511,10 @@
#define SIP_SA_GRAFINVERT
NC_("SIP_SA_GRAFINVERT", "Invert")
#define SIP_SA_GRAFMODE
NC_("SIP_SA_GRAFMODE", "Image mode")
#define SIP_SA_GRAFCROP
NC_("SIP_SA_GRAFCROP", "Crop")
-#define SIP_SA_GLOW_RAD
NC_("SIP_SA_GLOW_RAD", "Radius of glow effect")
+#define SIP_SA_GLOW_RADIUS
NC_("SIP_SA_GLOW_RADIUS", "Radius of glow effect")
#define SIP_SA_GLOW_COLOR
NC_("SIP_SA_GLOW_COLOR", "Color of glow effect")
#define SIP_SA_GLOW_TRANSPARENCY
NC_("SIP_SA_GLOW_TRANSPARENCY", "Transparency of glow effect")
-#define SIP_SA_SOFTEDGE_RAD
NC_("SIP_SA_SOFTEDGE_RAD", "Radius of soft edge effect")
+#define SIP_SA_SOFTEDGE_RADIUS
NC_("SIP_SA_SOFTEDGE_RADIUS", "Radius of soft edge effect")
#define STR_ObjNameSingulMEDIA
NC_("STR_ObjNameSingulMEDIA", "Media object")
#define STR_ObjNamePluralMEDIA
NC_("STR_ObjNamePluralMEDIA", "Media objects")
// drawing layer table strings
diff --git a/include/svx/svddef.hxx b/include/svx/svddef.hxx
index 27d90b44165c..30031e20dde2 100644
--- a/include/svx/svddef.hxx
+++ b/include/svx/svddef.hxx
@@ -417,14 +417,14 @@ constexpr TypedWhichId
SDRATTR_TABLE_TEXT_ROTATION (SDRATTR_T
constexpr sal_uInt16 SDRATTR_TABLE_LAST
(SDRATTR_TABLE_TEXT_ROTATION);
constexpr sal_uInt16 SDRATTR_GLOW_FIRST
(SDRATTR_TABLE_LAST+1);
-constexpr TypedWhichId SDRATTR_GLOW_RAD
(SDRATTR_GLOW_FIRST+0);
+constexpr TypedWhichId SDRATTR_GLOW_RADIUS
(SDRATTR_GLOW_FIRST+0);
constexpr TypedWhichIdSDRATTR_GLOW_COLOR
(SDRATTR_GLOW_FIRST+1);
constexpr TypedWhichId
SDRATTR_GLOW_TRANSPARENCY(SDRATTR_GLOW_FIRST + 2);
constexpr sal_uInt16 SDRATTR_GLOW_LAST
(SDRATTR_GLOW_TRANSPARENCY);
constexpr sal_uInt16 SDRATTR_SOFTEDGE_FIRST(SDRATTR_GLOW_LAST
+ 1);
-constexpr TypedWhichId
SDRATTR_SOFTEDGE_RAD(SDRATTR_SOFTEDGE_FIRST + 0);
-constexpr sal_uInt16
SDRATTR_SOFTEDGE_LAST(SDRATTR_SOFTEDGE_RAD);
+constexpr TypedWhichId
SDRATTR_SOFTEDGE_RADIUS(SDRATTR_SOFTEDGE_FIRST + 0);
+constexpr sal_uInt16
SDRATTR_SOFTEDGE_LAST(SDRATTR_SOFTEDGE_RADIUS);
constexpr sal_uInt16 SDRATTR_END (SDRATTR_SOFTEDGE_LAST); /* 1357 */ /*
1333 V4+++*/ /* 1243 V4+++*/ /*1213*/ /*1085*/ /*1040*/ /*Pool V2: 1123,V1:
1065 */
diff --git a/include/svx/unoshprp.hxx b/include/svx/unoshprp.hxx
index 4b3a05c6b5f4..33d47c5bc421 100644
--- a/include/svx/unoshprp.hxx
+++ b/include/svx/unoshprp.hxx
@@ -210,12 +210,12 @@
{ OUString("FontWorkShadowTransparence"),XATTR_FORMTXTSHDWTRANSP,
::cppu::UnoType::get(),0, 0},
#define GLOW_PROPERTIES \
-{ OUString{"GlowEffectRad"}, SDRATTR_GLOW_RAD,
::cppu::UnoType::get(),0, 0,
PropertyMoreFlags::METRIC_ITEM}, \
+{ OUString{"GlowEffectRadius"}, SDRATTR_GLOW_RADIUS,
::cppu::UnoType::get(),0, 0,
PropertyMoreFlags::METRIC_ITEM}, \
{ OUString{"GlowEffectColor"},SDRATTR_GLOW_COLOR,
::cppu::UnoType::get(),0, 0}, \
{ OUString{"GlowEffectTransparency"},
[Libreoffice-commits] core.git: include/svx svx/CppunitTest_svx_gallery_test.mk svx/qa
include/svx/galtheme.hxx |2
svx/CppunitTest_svx_gallery_test.mk |2
svx/qa/unit/gallery/data/galtest1.png |binary
svx/qa/unit/gallery/data/galtest2.png |binary
svx/qa/unit/gallery/data/galtest3.jpg |binary
svx/qa/unit/gallery/test_gallery.cxx | 177 +-
6 files changed, 178 insertions(+), 3 deletions(-)
New commits:
commit 75eeb423196c1e94a0189b7eccff37aed5765853
Author: Aditya
AuthorDate: Thu May 21 21:51:23 2020 +0530
Commit: Tomaž Vajngerl
CommitDate: Mon Jun 1 22:30:47 2020 +0200
svx:unit tests for adding, acquiring, counting objects into gallery theme
Change-Id: I256c6658a4257bc5bf8793153021efccef47bad2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94646
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/svx/galtheme.hxx b/include/svx/galtheme.hxx
index 44f85f19c6eb..c7c248d22344 100644
--- a/include/svx/galtheme.hxx
+++ b/include/svx/galtheme.hxx
@@ -126,7 +126,7 @@ public:
boolInsertObject(const SgaObject& rObj, sal_uInt32
nPos = SAL_MAX_UINT32);
voidRemoveObject(sal_uInt32 nPos);
-SAL_DLLPRIVATE bool ChangeObjectPos(sal_uInt32 nOldPos, sal_uInt32
nNewPos);
+boolChangeObjectPos(sal_uInt32 nOldPos, sal_uInt32
nNewPos);
const OUString& GetName() const;
diff --git a/svx/CppunitTest_svx_gallery_test.mk
b/svx/CppunitTest_svx_gallery_test.mk
index d4e50c51c127..1415dce921a5 100644
--- a/svx/CppunitTest_svx_gallery_test.mk
+++ b/svx/CppunitTest_svx_gallery_test.mk
@@ -29,6 +29,8 @@ $(eval $(call gb_CppunitTest_use_libraries,svx_gallery_test, \
tl \
svl \
sfx \
+ unotest \
+ test \
))
$(eval $(call gb_CppunitTest_use_externals,svx_gallery_test,boost_headers))
diff --git a/svx/qa/unit/gallery/data/galtest1.png
b/svx/qa/unit/gallery/data/galtest1.png
new file mode 100755
index ..37be81f9d203
Binary files /dev/null and b/svx/qa/unit/gallery/data/galtest1.png differ
diff --git a/svx/qa/unit/gallery/data/galtest2.png
b/svx/qa/unit/gallery/data/galtest2.png
new file mode 100755
index ..bf1aac397a39
Binary files /dev/null and b/svx/qa/unit/gallery/data/galtest2.png differ
diff --git a/svx/qa/unit/gallery/data/galtest3.jpg
b/svx/qa/unit/gallery/data/galtest3.jpg
new file mode 100755
index ..59f67e9aaf98
Binary files /dev/null and b/svx/qa/unit/gallery/data/galtest3.jpg differ
diff --git a/svx/qa/unit/gallery/test_gallery.cxx
b/svx/qa/unit/gallery/test_gallery.cxx
index 4c95e461a52b..c423f900cd64 100644
--- a/svx/qa/unit/gallery/test_gallery.cxx
+++ b/svx/qa/unit/gallery/test_gallery.cxx
@@ -6,6 +6,7 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
+#include
#include
#include
@@ -21,7 +22,7 @@
#include
#include
-class GalleryObjTest : public CppUnit::TestFixture
+class GalleryObjTest : public test::BootstrapFixture
{
public:
void TestCreateTheme();
@@ -31,6 +32,9 @@ public:
void TestThemeCount();
void TestGalleryThemeEntry();
void TestInsertGalleryObject();
+void TestRemoveGalleryObject();
+void TestChangePositionGalleryObject();
+void TestGetThemeNameFromGalleryTheme();
CPPUNIT_TEST_SUITE(GalleryObjTest);
@@ -41,6 +45,9 @@ public:
CPPUNIT_TEST(TestThemeCount);
CPPUNIT_TEST(TestGalleryThemeEntry);
CPPUNIT_TEST(TestInsertGalleryObject);
+CPPUNIT_TEST(TestRemoveGalleryObject);
+CPPUNIT_TEST(TestChangePositionGalleryObject);
+CPPUNIT_TEST(TestGetThemeNameFromGalleryTheme);
CPPUNIT_TEST_SUITE_END();
};
@@ -292,11 +299,177 @@ void GalleryObjTest::TestInsertGalleryObject()
CPPUNIT_ASSERT_MESSAGE("Could not create theme",
pGallery->CreateTheme(myThemeName));
CPPUNIT_ASSERT_MESSAGE("Could not find theme",
pGallery->HasTheme(myThemeName));
+// Create Sfx Instance
+SfxListener aListener;
+SfxApplication::GetOrCreate();
+
// Insert Objects Into Theme
+GalleryTheme* pGalleryTheme = pGallery->AcquireTheme(myThemeName,
aListener);
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Object count inconsistent", sal_uInt32(0),
+ pGalleryTheme->GetObjectCount());
+
+std::vector imageList{ "galtest1.png", "galtest2.png",
"galtest3.jpg" };
+
+for (sal_uInt32 i = 0; i < static_cast(imageList.size()); i++)
+{
+OUString imageNameFromList(imageList[i]);
+OUString aURL(m_directories.getURLFromSrc("/svx/qa/unit/gallery/data/")
+ + imageNameFromList);
+CPPUNIT_ASSERT_MESSAGE("Could not insert object into theme",
+ pGalleryTheme->InsertURL(INetURLObject(aURL)));
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Inconsistent object Count",
pGalleryTheme->GetObjectCount(),
+ i +
[Libreoffice-bugs] [Bug 133591] Invisible caracter generate when export in .txt
https://bugs.documentfoundation.org/show_bug.cgi?id=133591 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #1 from V Stuart Foote --- Can not confirm on Windows builds Version: 7.0.0.0.beta1 (x64) Build ID: 94f789cbb5b4a511c319542c7bdc31ff3b3c CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL A Writer document 'save-as' to 'Text (*.txt)' contains no hidden characters at start of text. Verified with a gvim session 'Convert to HEX', only expected characters from the text body are present. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133590] UI: 'Windows Default apps' button on Options -> General panel is cut off
https://bugs.documentfoundation.org/show_bug.cgi?id=133590 V Stuart Foote changed: What|Removed |Added Summary|UI: Windows Default App |UI: 'Windows Default apps' |button cut off |button on Options -> ||General panel is cut off OS|All |Windows (All) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133590] UI: Windows Default App button cut off
https://bugs.documentfoundation.org/show_bug.cgi?id=133590 V Stuart Foote changed: What|Removed |Added Ever confirmed|0 |1 CC||mikekagan...@hotmail.com, ||vstuart.fo...@utsa.edu Status|UNCONFIRMED |NEW --- Comment #2 from V Stuart Foote --- On Windows 10 with Version: 7.0.0.0.beta1 (x64) Build ID: 94f789cbb5b4a511c319542c7bdc31ff3b3c CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL This is Mike's 'Windows Default apps' work done for bug 44462 The Options dialog is a bit under height to fully show the button. And, don't see how one could add a scrollbar to this panel as done on some of the other panels. So, increase the y-height for the Options dialog, or find a new panel of the button? Although the General tab seems correct spot for it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133500] Fatal error: Component context fails to supply singleton com.sun.star.frame.theautorecovery
https://bugs.documentfoundation.org/show_bug.cgi?id=133500 Telesto changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128513] no linefeeds when importing Calc tables that contain multiline text
https://bugs.documentfoundation.org/show_bug.cgi?id=128513 --- Comment #16 from rac...@megabit.net --- (In reply to Robert Großkopf from comment #14) > > This bug is unconfirmed from any other person. So nobody, who could resolve > bugs, has a chance to find the buggy behavior. So the bug will still be there in a few years because only a few users use LibreOffice Base? Please look at my video so you can confirm this behaviour. > Firebird is set back to "experimental", because there are too many things, > which will work better with internal HSQLDB. Please test the behavior with > internal HSQLDB and upload an example as attachment here. This will be the > best possibility to see the problem for other people. HSQLDB has the same problem. Example is attached... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128513] no linefeeds when importing Calc tables that contain multiline text
https://bugs.documentfoundation.org/show_bug.cgi?id=128513 --- Comment #15 from rac...@megabit.net --- Created attachment 161505 --> https://bugs.documentfoundation.org/attachment.cgi?id=161505=edit simple table and database file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/control/Toolbar.js | 20
1 file changed, 16 insertions(+), 4 deletions(-)
New commits:
commit 642c7598a7e5c937c08d03323c299b83e84e1b5e
Author: mert
AuthorDate: Fri May 29 17:00:25 2020 +0300
Commit: Andras Timar
CommitDate: Mon Jun 1 21:38:07 2020 +0200
Fix proxy related welcome msg and help dialog problems
Fixed cookie problem with proxy too for welcome message
Change-Id: I8e3e6ccb7673bddd5c26e3d2aadd2da4ed03a2e4
Signed-off-by: mert
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/95152
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Andras Timar
diff --git a/loleaflet/src/control/Toolbar.js b/loleaflet/src/control/Toolbar.js
index 0409c9d1c..11f07f8f6 100644
--- a/loleaflet/src/control/Toolbar.js
+++ b/loleaflet/src/control/Toolbar.js
@@ -215,7 +215,11 @@ L.Map.include({
w = iw / 5 + 590;
}
var map = this;
- $.get('loleaflet-help.html', function(data) {
+ var helpLocation = 'loleaflet-help.html';
+ if (window.socketProxy)
+ helpLocation = window.host + window.serviceRoot +
'/loleaflet/dist/' + helpLocation;
+
+ $.get(helpLocation, function(data) {
var productName;
if (window.ThisIsAMobileApp) {
productName = window.MobileAppName;
@@ -403,7 +407,10 @@ L.Map.include({
if (!calledFromMenu) {
var WSDVerCookie = 'WSDWelcomeVersion='
+ map._socket.WSDServer.Version;
// Cookie will not expire for a year,
and it will not be sent to other domains
- WSDVerCookie += '; max-age=31536000;
SameSite=Strict; path=/loleaflet';
+ var cookiePath = '/loleaflet';
+ if (window.socketProxy)
+ cookiePath = window.host +
window.serviceRoot + cookiePath;
+ WSDVerCookie += '; max-age=31536000;
SameSite=Strict; path=' + cookiePath;
document.cookie = WSDVerCookie;
}
map.focus();
@@ -414,7 +421,9 @@ L.Map.include({
showWelcomeDialog: function(calledFromMenu) {
console.log('showWelcomeDialog, calledFromMenu: ' +
calledFromMenu);
- var welcomeLocation = window.location.origin +
window.location.pathname.substr(0, window.location.pathname.lastIndexOf('/')) +
'/welcome/welcome-' + String.locale + '.html';
+ var welcomeLocation = 'welcome/welcome-' + String.locale +
'.html';
+ if (window.socketProxy)
+ welcomeLocation = window.host + window.serviceRoot +
'/loleaflet/dist/' + welcomeLocation;
var map = this;
@@ -432,7 +441,10 @@ L.Map.include({
.fail(function() {
// Welcome dialog disabled in loolwsd.xml or
nonexistant for some other reason
// Let's check back in a day (60 x 60 x 24 =
86400 seconds)
- var welcomeDisabledCookie =
'WSDWelcomeDisabled=true; max-age=86400; SameSite=Strict; path=/loleaflet';
+ var cookiePath = '/loleaflet';
+ if (window.socketProxy)
+ cookiePath = window.host +
window.serviceRoot + cookiePath;
+ var welcomeDisabledCookie =
'WSDWelcomeDisabled=true; max-age=86400; SameSite=Strict; path=' + cookiePath;
document.cookie = welcomeDisabledCookie;
if (calledFromMenu)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 133585] Sound to verify document has been saved
https://bugs.documentfoundation.org/show_bug.cgi?id=133585 --- Comment #1 from n...@pendrich.scot --- The word option was called: "Provide feedback with sound" I found it a useful verification that the file had actually saved. I find in LO that I have to do a visual check instead of continuing to type. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 133585] Sound to verify document has been saved
https://bugs.documentfoundation.org/show_bug.cgi?id=133585 --- Comment #1 from n...@pendrich.scot --- The word option was called: "Provide feedback with sound" I found it a useful verification that the file had actually saved. I find in LO that I have to do a visual check instead of continuing to type. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133530] Paste disabled in Calc with content on the clipboard
https://bugs.documentfoundation.org/show_bug.cgi?id=133530 --- Comment #15 from Telesto --- Created attachment 161504 --> https://bugs.documentfoundation.org/attachment.cgi?id=161504=edit Screencast Yes it does.. but this stupid 'disabled' paste is hard to pin down. I really do't see any pattern... Except it does happen.. I enabled the MS Office clipboard sometimes - it appears - to happen more often - with it (screencast is without). It also depends on the build.. I could reproduce it pretty well with 6.2 range.. But it all depends.. 20 misses.. hit.. 20 misses Awfully boring.. As said.. the clipboard is not empty.. so I expect something within the code regulating the context menu.. to set it disabled or enabled.. And based on early observations.. probably very old code -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/treelistbox.hxx |8 ++--
vcl/source/treelist/svimpbox.cxx|6 +-
vcl/source/treelist/treelistbox.cxx |6 +-
3 files changed, 16 insertions(+), 4 deletions(-)
New commits:
commit d56ed8a462fb672f61a07279f30eb8597033f40b
Author: Caolán McNamara
AuthorDate: Sun May 31 19:13:54 2020 +0100
Commit: Caolán McNamara
CommitDate: Mon Jun 1 21:08:30 2020 +0200
support hover-selection in SvTreeListBox
Change-Id: I5ad124d7c9e5219a557069bc7283208124c734af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95269
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/include/vcl/treelistbox.hxx b/include/vcl/treelistbox.hxx
index 288314af8232..586686e81de1 100644
--- a/include/vcl/treelistbox.hxx
+++ b/include/vcl/treelistbox.hxx
@@ -221,8 +221,9 @@ class VCL_DLLPUBLIC SvTreeListBox
bool mbContextBmpExpanded;
bool mbAlternatingRowColors;
bool mbUpdateAlternatingRows;
-bool mbQuickSearch; // Enables type-ahead search in the check list box.
-bool mbActivateOnSingleClick; // Make single click "activate" a row
like a double-click normally does
+bool mbQuickSearch; // Enables type-ahead search in the check list box.
+bool mbActivateOnSingleClick; // Make single click "activate" a row like a
double-click normally does
+bool mbHoverSelection; // Make mouse over a row "select" a row like a
single-click normally does
SvTreeListEntry*pHdlEntry;
@@ -723,6 +724,9 @@ public:
// Make single click "activate" a row like a double-click normally does
voidSetActivateOnSingleClick(bool bEnable) {
mbActivateOnSingleClick = bEnable; }
+// Make mouse over a row "select" a row like a single-click normally does
+voidSetHoverSelection(bool bEnable) { mbHoverSelection =
bEnable; }
+
voidSetForceMakeVisible(bool bEnable);
virtual FactoryFunction GetUITestFactory() const override;
diff --git a/vcl/source/treelist/svimpbox.cxx b/vcl/source/treelist/svimpbox.cxx
index 2fc2d0bf9d3c..dff21f931e5f 100644
--- a/vcl/source/treelist/svimpbox.cxx
+++ b/vcl/source/treelist/svimpbox.cxx
@@ -2074,7 +2074,11 @@ void SvImpLBox::MouseMove( const MouseEvent& rMEvt)
{
SvTreeListEntry* pEntry = GetClickedEntry( rMEvt.GetPosPixel() );
if ( !MouseMoveCheckCtrl( rMEvt, pEntry ) && (
m_aSelEng.GetSelectionMode() != SelectionMode::NONE ) )
-m_aSelEng.SelMouseMove( rMEvt );
+{
+m_aSelEng.SelMouseMove(rMEvt);
+if (m_pView->mbHoverSelection && !m_pView->IsSelected(pEntry))
+m_pView->Select(pEntry);
+}
}
void SvImpLBox::ExpandAll()
diff --git a/vcl/source/treelist/treelistbox.cxx
b/vcl/source/treelist/treelistbox.cxx
index 3c68f1331f0b..389ed170828f 100644
--- a/vcl/source/treelist/treelistbox.cxx
+++ b/vcl/source/treelist/treelistbox.cxx
@@ -403,6 +403,7 @@ SvTreeListBox::SvTreeListBox(vcl::Window* pParent, WinBits
nWinStyle) :
mbUpdateAlternatingRows(false),
mbQuickSearch(false),
mbActivateOnSingleClick(false),
+mbHoverSelection(false),
eSelMode(SelectionMode::NONE),
nMinWidthInChars(0),
mnDragAction(DND_ACTION_COPYMOVE | DND_ACTION_LINK),
@@ -2337,7 +2338,6 @@ void SvTreeListBox::MouseMove( const MouseEvent& rMEvt )
pImpl->MouseMove( rMEvt );
}
-
void SvTreeListBox::SetUpdateMode( bool bUpdate )
{
pImpl->SetUpdateMode( bUpdate );
@@ -3585,6 +3585,10 @@ bool SvTreeListBox::set_property(const OString ,
const OUString )
{
SetActivateOnSingleClick(toBool(rValue));
}
+else if (rKey == "hover-selection")
+{
+SetHoverSelection(toBool(rValue));
+}
else if (rKey == "reorderable")
{
if (toBool(rValue))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128513] no linefeeds when importing Calc tables that contain multiline text
https://bugs.documentfoundation.org/show_bug.cgi?id=128513 --- Comment #14 from Robert Großkopf --- (In reply to racoon from comment #13) > Will LibreOffice Base be further developed? > > Version 6.4.4.2 and 7.0.0.0-alpha1 still have the bug... This bug is unconfirmed from any other person. So nobody, who could resolve bugs, has a chance to find the buggy behavior. Firebird is set back to "experimental", because there are too many things, which will work better with internal HSQLDB. Please test the behavior with internal HSQLDB and upload an example as attachment here. This will be the best possibility to see the problem for other people. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133530] Paste disabled in Calc with content on the clipboard
https://bugs.documentfoundation.org/show_bug.cgi?id=133530 --- Comment #14 from Buovjaga --- (In reply to Telesto from comment #13) > Created attachment 161503 [details] > Screencast Ok, in this video we see you do not use the same version for the test (you use 6.2 and 7.1). Does the same occur, if you purely use 7.1? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133530] Paste disabled in Calc with content on the clipboard
https://bugs.documentfoundation.org/show_bug.cgi?id=133530 --- Comment #13 from Telesto --- Created attachment 161503 --> https://bugs.documentfoundation.org/attachment.cgi?id=161503=edit Screencast -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: cypress_test/integration_tests
cypress_test/integration_tests/desktop/calc/focus_spec.js
| 18 ++--
cypress_test/integration_tests/mobile/calc/alignment_options_spec.js
| 34 +++
cypress_test/integration_tests/mobile/calc/apply_font_spec.js
| 26 ++---
cypress_test/integration_tests/mobile/calc/bottom_toolbar_spec.js
| 42 -
cypress_test/integration_tests/mobile/calc/cell_appearance_spec.js
| 38
cypress_test/integration_tests/mobile/calc/focus_spec.js
| 24 ++---
cypress_test/integration_tests/mobile/calc/insertion_wizard_spec.js
| 12 +-
cypress_test/integration_tests/mobile/calc/number_format_spec.js
| 40 -
cypress_test/integration_tests/mobile/calc/spellchecking_spec.js
| 12 +-
cypress_test/integration_tests/mobile/impress/impress_focus_spec.js
| 26 ++---
cypress_test/integration_tests/mobile/writer/apply_font_spec.js
| 36
cypress_test/integration_tests/mobile/writer/apply_paragraph_properties_spec.js
| 44 +-
cypress_test/integration_tests/mobile/writer/bottom_toolbar_spec.js
| 32 +++
cypress_test/integration_tests/mobile/writer/insert_field_spec.js
| 16 +--
cypress_test/integration_tests/mobile/writer/insert_formatting_mark_spec.js
| 16 +--
cypress_test/integration_tests/mobile/writer/insert_object_spec.js
|8 -
cypress_test/integration_tests/mobile/writer/shape_properties_spec.js
|4
cypress_test/integration_tests/mobile/writer/spellchecking_spec.js
|6 -
cypress_test/integration_tests/mobile/writer/table_properties_spec.js
| 36
19 files changed, 235 insertions(+), 235 deletions(-)
New commits:
commit 76e45490a4a71d63d639c63f5bdddee271a6d9bd
Author: Tamás Zolnai
AuthorDate: Mon Jun 1 14:24:14 2020 +0200
Commit: Tamás Zolnai
CommitDate: Mon Jun 1 20:43:06 2020 +0200
cypress: consistent naming of helper files.
Change-Id: I245dc0ee49684751f9042ff25e190dd883bca536
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/95284
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Tamás Zolnai
diff --git a/cypress_test/integration_tests/common/calc.js
b/cypress_test/integration_tests/common/calc_helper.js
similarity index 100%
rename from cypress_test/integration_tests/common/calc.js
rename to cypress_test/integration_tests/common/calc_helper.js
diff --git a/cypress_test/integration_tests/common/impress.js
b/cypress_test/integration_tests/common/impress_helper.js
similarity index 100%
rename from cypress_test/integration_tests/common/impress.js
rename to cypress_test/integration_tests/common/impress_helper.js
diff --git a/cypress_test/integration_tests/desktop/calc/focus_spec.js
b/cypress_test/integration_tests/desktop/calc/focus_spec.js
index 649d2ceb9..0c1da24c5 100644
--- a/cypress_test/integration_tests/desktop/calc/focus_spec.js
+++ b/cypress_test/integration_tests/desktop/calc/focus_spec.js
@@ -1,7 +1,7 @@
/* global describe it cy beforeEach require afterEach */
var helper = require('../../common/helper');
-var calc = require('../../common/calc');
+var calcHelper = require('../../common/calc_helper');
describe('Calc focus tests', function() {
var testFileName = 'focus.ods';
@@ -21,10 +21,10 @@ describe('Calc focus tests', function() {
// Select the first cell to edit the same one.
// Use the tile's edge to find the first cell's position
- calc.clickOnFirstCell();
+ calcHelper.clickOnFirstCell();
// Click in the formula-bar.
- calc.clickFormulaBar();
+ calcHelper.clickFormulaBar();
helper.assertCursorAndFocus();
// Type some text.
@@ -33,8 +33,8 @@ describe('Calc focus tests', function() {
cy.get('textarea.clipboard').type('{enter}');
// Select the first cell to edit the same one.
- calc.clickOnFirstCell();
- calc.clickFormulaBar();
+ calcHelper.clickOnFirstCell();
+ calcHelper.clickFormulaBar();
helper.assertCursorAndFocus();
// Validate.
cy.get('textarea.clipboard').type('{ctrl}a');
@@ -44,8 +44,8 @@ describe('Calc focus tests', function() {
// Type some more text, at the end.
cy.log('Appending text at the end.');
- calc.clickOnFirstCell();
- calc.clickFormulaBar();
+ calcHelper.clickOnFirstCell();
+ calcHelper.clickFormulaBar();
helper.assertCursorAndFocus();
var text2 = ', this is a test.';
helper.typeText('textarea.clipboard', text2);
@@ -57,8 +57,8 @@ describe('Calc
[Libreoffice-bugs] [Bug 127170] Clarify clock time (HH:MM, MM:SS, ...) and duration time ([HH]:MM, [MM]:SS, ...) formatting in help; (ignore the MM month vs minute discussion)
https://bugs.documentfoundation.org/show_bug.cgi?id=127170 --- Comment #23 from Albrecht Müller --- (In reply to Mike Kaganski from comment #21) > the approach I suggested elsewhere to standardize > on millisecond precision for displaying times I think you refer to Bug 127334 comment 8 where you propose that some kind of rounding is necessary. In attachment 160356 I needed a few pages to describe how Excel might do this "some kind of rounding". Based on this I think: • The user can choose whatever precision he or she considers reasonable. It is not necessary do standardize to some precision at all, neither seconds, milliseconds or whatever. • There is no need to use different rounding strategies for points in time (wall clock time) or durations. • The specification describes precisely the rounding method that has to be applied. Thus your approach as well as my proposal are incompatible with it. > incorrect attempt to standardize on 1/10 of a second precision. There are users who expect correct handling integer arithmetic when using integer multiples of time units without having to worry about roundoff errors or distinctions between wall clock times or durations. When using the SECOND and MINUTE functions other users may expect that a carry goes from seconds to minutes when seconds are rounded up to the next minute. The workaround is intended to make those persons happy. The trick is to inject a carefully crafted error into the input of the current implementation which makes it return the expected results. Its a kind of proof of concept for the ideas in the attachment. I chose rounding to seconds due to this specific use case. It is not a standardization attempt as I think standardization is unnecessary. > the essense (e.g., what needs documenting here) If it is unclear if the date and time functions should follow the specification or should do some kind of rounding that deviates from this specification then it is pretty difficult to decide what needs documenting. Just one example how this works: If the date and time functions handle the carry from seconds to minutes it is not necessary to document this. People would expect this anyway. But there is a decision that Calc will will not do this: Bug 127476 had been closed using the WONTFIX tag. In this case a lot of things need documentation: • The fact as such: The implementation will lose a carry sometimes. • What are the situations when this happens? • From a user’s point of view: What are the benefits of Calc’s way of handling the carry? • How date and time calculations are affected? The user should know if the value is wrong or the formatting. • Issues with compatibility to Excel, legacy spreadsheets, StarBasic’s date and time functions, … I stop here to avoid TLDR effects. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133591] New: Invisible caracter generate when export in .txt
https://bugs.documentfoundation.org/show_bug.cgi?id=133591 Bug ID: 133591 Summary: Invisible caracter generate when export in .txt Product: LibreOffice Version: 6.3.6.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: fg.r...@free.fr Description: From Writer, you export in .txt You open the file with a simple text editor* : there is a invisible caracter at the begining of the text (at left from the first letter or number). So, it's not visible, but it is obvious when you import this text, for instance with "EasyTAG". * Yes with "gedit", but no problem with "Mousepad" ! Steps to Reproduce: 1. "Enregistrer sous..." a text in ".txt" 2. Open the .txt with gedit 3. With "<" or ">", move the cursor to the right or left from the begining of the test to "detect" the invisible caracter Actual Results: Invisible caracter create Expected Results: No invisible caracter ! Reproducible: Always User Profile Reset: No Additional Info: Only the text "raw" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133590] UI: Windows Default App button cut off
https://bugs.documentfoundation.org/show_bug.cgi?id=133590 --- Comment #1 from Telesto --- Created attachment 161502 --> https://bugs.documentfoundation.org/attachment.cgi?id=161502=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133590] New: UI: Windows Default App button cut off
https://bugs.documentfoundation.org/show_bug.cgi?id=133590 Bug ID: 133590 Summary: UI: Windows Default App button cut off Product: LibreOffice Version: 7.0.0.0.alpha1+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: UI: Windows Default App button cut off Steps to Reproduce: 1. Open Writer 2. Tools -> Options -> General Actual Results: See screenshot Expected Results: Button visible in total Reproducible: Always User Profile Reset: No Additional Info: Version: 7.1.0.0.alpha0+ (x64) Build ID: 83c4f86f22dc37269ac6a038fe7de053c42aad6e CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: en-US (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103405] L10n: Add additional user interface language Hungarian Rovas [hu-Hung-HU]
https://bugs.documentfoundation.org/show_bug.cgi?id=103405 V Stuart Foote changed: What|Removed |Added Depends on||133589 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=133589 [Bug 133589] add transliteration support for Old Hungarian -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133585] Sound to verify document has been saved
https://bugs.documentfoundation.org/show_bug.cgi?id=133585 Telesto changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 133585] Sound to verify document has been saved
https://bugs.documentfoundation.org/show_bug.cgi?id=133585 Telesto changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 133573] Footnotes Alignment not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=133573 Telesto changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #4 from Telesto --- Repro with 7.1 and with Versie: 4.1.0.4 Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28 Leaving it unconfirmed.. no expert on the capability's of RTF format -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133586] Text file appears incorrectly compared to Notepad
https://bugs.documentfoundation.org/show_bug.cgi?id=133586 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #2 from V Stuart Foote --- Can not confirm. Text contains no formatting, and opens the same in MS Notepad and in LibreOffice 7.0.0 Writer with no formatting or autocorrections evident, only Spellcheck markup occurs. =-testing-= Notepad -- Winodws 10 1903 (OS Build 18632.778) LibreOffice -- Version: 6.4.4.2 (x64) Build ID: 3d775be2011f3886db32dfd395a6a6d1ca2630ff CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: GL; VCL: win; Locale: nl-NL (en_US); UI-Language: en-US Calc: CL Version: 7.0.0.0.beta1 (x64) Build ID: 94f789cbb5b4a511c319542c7bdc31ff3b3c CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL Version: 7.1.0.0.alpha0+ (x64) Build ID: a0c90f1bccd9b5a349d3199746facab549f27dba CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: default; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133573] Footnotes Alignment not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=133573 --- Comment #3 from Telesto --- Created attachment 161501 --> https://bugs.documentfoundation.org/attachment.cgi?id=161501=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/package.json
loleaflet/package.json |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit ba64819ef8400c05948c3c45735b425d4ef19643
Author: gokaysatir
AuthorDate: Mon Jun 1 12:03:32 2020 +0300
Commit: Henry Castro
CommitDate: Mon Jun 1 20:02:11 2020 +0200
update uglifyify package.
Change-Id: Ib7badc17f087d4abbf04d8f683229a4b92faff76
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/95265
Tested-by: Jenkins CollaboraOffice
Tested-by: Jenkins
Reviewed-by: Henry Castro
diff --git a/loleaflet/package.json b/loleaflet/package.json
index 40bf92609..b73444cc0 100644
--- a/loleaflet/package.json
+++ b/loleaflet/package.json
@@ -22,7 +22,7 @@
"smartmenus": "1.0.0",
"uglify-js": "3.9.4",
"uglifycss": "0.0.29",
-"uglifyify": "3.0.2",
+"uglifyify": "5.0.2",
"vex-js": "4.1.0"
},
"repository": {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 99525] [META] Enhance Draw's DTP capabilities
https://bugs.documentfoundation.org/show_bug.cgi?id=99525 Bug 99525 depends on bug 49247, which changed state. Bug 49247 Summary: Implement "Soft Edges" effect https://bugs.documentfoundation.org/show_bug.cgi?id=49247 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: unotools/source
unotools/source/misc/mediadescriptor.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 31db2a1c9e1597e7ab7d9b3505b99e2b08a53d9d
Author: Caolán McNamara
AuthorDate: Mon Jun 1 10:34:46 2020 +0100
Commit: Caolán McNamara
CommitDate: Mon Jun 1 19:47:49 2020 +0200
ofz#22822 use TOOLS_WARN_EXCEPTION
Change-Id: Ib8947dbe464c7b5b1f6fc55e7b0754e1c75491fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95268
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/unotools/source/misc/mediadescriptor.cxx
b/unotools/source/misc/mediadescriptor.cxx
index 7f8f4e3c3785..e522b54ee83f 100644
--- a/unotools/source/misc/mediadescriptor.cxx
+++ b/unotools/source/misc/mediadescriptor.cxx
@@ -526,7 +526,7 @@ bool MediaDescriptor::impl_addInputStream( bool bLockFile )
}
catch(const css::uno::Exception&)
{
-DBG_UNHANDLED_EXCEPTION("unotools.misc", "invalid MediaDescriptor
detected");
+TOOLS_WARN_EXCEPTION("unotools.misc", "invalid MediaDescriptor
detected");
return false;
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 133582] Tools > Options has no check boxes
https://bugs.documentfoundation.org/show_bug.cgi?id=133582 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #4 from V Stuart Foote --- Confirmed. Disabling Skia rendering does not resolve check-boxes missing from the Tools -> Options 2020-06-01 TB77 x64 build. Version: 7.1.0.0.alpha0+ (x64) Build ID: a0c90f1bccd9b5a349d3199746facab549f27dba CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: default; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/button.hxx|2 +-
vcl/source/control/button.cxx |8 ++--
2 files changed, 3 insertions(+), 7 deletions(-)
New commits:
commit b9c79a4dd4ad58156b60c2e387c0838ba911ab14
Author: Justin Luth
AuthorDate: Sat May 30 10:47:12 2020 +0300
Commit: Caolán McNamara
CommitDate: Mon Jun 1 19:39:39 2020 +0200
Revert "tdf#125609 c10 vcl/button: enforce only one radio selected on init"
This has already been reverted in 6.4.5
with commit 64d7f805616fd781d87b49156860d96f081a5a45.
I want to get out of this completely, because everything keeps
on breaking based on my earlier patches.
This reverts commit d35171456bc230efdaa9426da1398b2db7fa0df8,
and the accompanying
LO 6.4 commit a9f4913f283d34c610c4b73c755fdc828857bfce
"tdf#125609 c14: vcl button: don't modify style directly"
These reverted supporting commits are obsolete.
(They fixed a situation caused by
a commit that has since been fully reverted.
I left these in for the benefit of anyone who
might attempt that initial fix in the future.
But now I want to get my finger prints out of
here completely.)
Change-Id: I0d765ce0cc4ab2b9d282d36a239518d43d6015ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95190
Tested-by: Jenkins
Reviewed-by: Justin Luth
Reviewed-by: Caolán McNamara
diff --git a/include/vcl/button.hxx b/include/vcl/button.hxx
index a702a79c12c6..02371c996e95 100644
--- a/include/vcl/button.hxx
+++ b/include/vcl/button.hxx
@@ -270,7 +270,7 @@ private:
const Size& rImageSize, tools::Rectangle&
rStateRect,
tools::Rectangle& rMouseRect );
SAL_DLLPRIVATE void ImplDrawRadioButton(vcl::RenderContext&
rRenderContext );
-SAL_DLLPRIVATE void ImplUncheckAllOther( const bool bSetStyle = true);
+SAL_DLLPRIVATE void ImplUncheckAllOther();
SAL_DLLPRIVATE Size ImplGetRadioImageSize() const;
SAL_DLLPRIVATE long ImplGetImageToTextDistance() const;
diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx
index e6d52df0630a..1f9e2573e144 100644
--- a/vcl/source/control/button.cxx
+++ b/vcl/source/control/button.cxx
@@ -1789,9 +1789,6 @@ WinBits RadioButton::ImplInitStyle( const vcl::Window*
pPrevWindow, WinBits nSty
nStyle &= ~WB_TABSTOP;
}
-if ( IsChecked() && IsRadioCheckEnabled() )
-ImplUncheckAllOther( /*bSetStyle=*/false );
-
return nStyle;
}
@@ -2180,10 +2177,9 @@ std::vector< VclPtr >
RadioButton::GetRadioButtonGroup(bool bInclud
return aGroup;
}
-void RadioButton::ImplUncheckAllOther( const bool bSetStyle )
+void RadioButton::ImplUncheckAllOther()
{
-if ( bSetStyle )
-mpWindowImpl->mnStyle |= WB_TABSTOP;
+mpWindowImpl->mnStyle |= WB_TABSTOP;
std::vector > aGroup(GetRadioButtonGroup(false));
// iterate over radio button group and checked buttons
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 133389] Date & time functions in StarBasic and Calc return different results
https://bugs.documentfoundation.org/show_bug.cgi?id=133389 --- Comment #3 from Albrecht Müller --- Created attachment 161500 --> https://bugs.documentfoundation.org/attachment.cgi?id=161500=edit Example file demonstrating different results of date & time functions update (In reply to Eike Rathke from comment #2) > The usual confusion of timestamp and duration. Did I get timestamp and duration right this time? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl vcl/source vcl/unx
include/vcl/layout.hxx|8 +-
include/vcl/weld.hxx |2
vcl/source/app/salvtables.cxx | 17 +++-
vcl/source/window/layout.cxx |8 +-
vcl/unx/gtk3/gtk3gtkinst.cxx | 149 +-
5 files changed, 102 insertions(+), 82 deletions(-)
New commits:
commit ea79a34ec7ffee6f86f16172c9e5fd75257539ca
Author: Caolán McNamara
AuthorDate: Sun May 31 16:16:37 2020 +0100
Commit: Caolán McNamara
CommitDate: Mon Jun 1 19:38:11 2020 +0200
allow sorting buttons via weld::Box
Change-Id: I315fe2dd2e40c976edd802c1e87b7ccdb0c298fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95221
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/include/vcl/layout.hxx b/include/vcl/layout.hxx
index 8a5b881644e4..67e856fabdca 100644
--- a/include/vcl/layout.hxx
+++ b/include/vcl/layout.hxx
@@ -94,6 +94,10 @@ public:
{
m_bHomogeneous = bHomogeneous;
}
+bool get_orientation() const
+{
+return m_bVerticalContainer;
+}
virtual bool set_property(const OString , const OUString )
override;
virtual boost::property_tree::ptree DumpAsPropertyTree() override;
protected:
@@ -211,7 +215,6 @@ public:
{
}
virtual bool set_property(const OString , const OUString )
override;
-void sort_native_button_order();
protected:
virtual Size calculateRequisition() const override;
virtual void setAllocation(const Size ) override;
@@ -853,6 +856,9 @@ Size getLegacyBestSizeForChildren(const vcl::Window
);
//Get first parent which is not a layout widget
vcl::Window* getNonLayoutParent(vcl::Window *pParent);
+//Sort ok/cancel etc buttons in platform order
+void sort_native_button_order(VclBox& rContainer);
+
#endif
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index 58309c9e49ef..9d01a0fc7022 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -290,6 +290,8 @@ class VCL_DLLPUBLIC Box : virtual public Container
public:
// Moves child to a new position in the list of children
virtual void reorder_child(weld::Widget* pWidget, int position) = 0;
+// Sort ok/cancel etc buttons in platform order
+virtual void sort_native_button_order() = 0;
};
class VCL_DLLPUBLIC Paned : virtual public Container
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 6057ffbe6dd6..846bbfa98e46 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -1134,9 +1134,12 @@ namespace
{
class SalInstanceBox : public SalInstanceContainer, public virtual weld::Box
{
+private:
+VclPtr m_xBox;
public:
-SalInstanceBox(vcl::Window* pContainer, SalInstanceBuilder* pBuilder, bool
bTakeOwnership)
+SalInstanceBox(VclBox* pContainer, SalInstanceBuilder* pBuilder, bool
bTakeOwnership)
: SalInstanceContainer(pContainer, pBuilder, bTakeOwnership)
+, m_xBox(pContainer)
{
}
virtual void reorder_child(weld::Widget* pWidget, int nNewPosition)
override
@@ -1145,6 +1148,10 @@ public:
assert(pVclWidget);
pVclWidget->getWidget()->reorderWithinParent(nNewPosition);
}
+virtual void sort_native_button_order() override
+{
+::sort_native_button_order(*m_xBox);
+}
};
void CollectChildren(const vcl::Window& rCurrent, const basegfx::B2IPoint&
rTopLeft,
@@ -1380,7 +1387,7 @@ bool
SalInstanceDialog::runAsync(std::shared_ptr aOwner,
aCtx.maEndDialogFn = rEndDialogFn;
VclButtonBox* pActionArea = m_xDialog->get_action_area();
if (pActionArea)
-pActionArea->sort_native_button_order();
+sort_native_button_order(*pActionArea);
return m_xDialog->StartExecuteAsync(aCtx);
}
@@ -1395,7 +1402,7 @@ bool SalInstanceDialog::runAsync(std::shared_ptr
const& rxSelf,
aCtx.maEndDialogFn = rEndDialogFn;
VclButtonBox* pActionArea = m_xDialog->get_action_area();
if (pActionArea)
-pActionArea->sort_native_button_order();
+sort_native_button_order(*pActionArea);
return m_xDialog->StartExecuteAsync(aCtx);
}
@@ -1473,7 +1480,7 @@ int SalInstanceDialog::run()
{
VclButtonBox* pActionArea = m_xDialog->get_action_area();
if (pActionArea)
-pActionArea->sort_native_button_order();
+sort_native_button_order(*pActionArea);
return m_xDialog->Execute();
}
@@ -6292,7 +6299,7 @@ std::unique_ptr
SalInstanceBuilder::weld_container(const OStrin
std::unique_ptr SalInstanceBuilder::weld_box(const OString& id,
bool bTakeOwnership)
{
-vcl::Window* pContainer = m_xBuilder->get(id);
+VclBox* pContainer = m_xBuilder->get(id);
return pContainer ? std::make_unique(pContainer, this,
bTakeOwnership)
: nullptr;
}
diff --git a/vcl/source/window/layout.cxx b/vcl/source/window/layout.cxx
index 9225c27b05a8..29c4cf0e7d41 100644
--- a/vcl/source/window/layout.cxx
+++
[Libreoffice-commits] online.git: Branch 'distro/collabora/co-4-2-4' - loleaflet/css
loleaflet/css/menubar.css |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 8b509496aa9c0f50687042c7e7b1f3635d74b169
Author: Pedro Pinto Silva
AuthorDate: Fri May 29 12:40:44 2020 +0200
Commit: Andras Timar
CommitDate: Mon Jun 1 19:32:24 2020 +0200
Make sure document title bar is not above dialogs
by reducing the value introduced in
db32e4fc3800ffad83ea82e4835b0653d26d1bae and instead using the same z-index as
its neighbour elment (main-menu) so 1000
Change-Id: I92d893d1a092e16a1455a6d1941a98e73ec63d1a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/95103
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Pedro Silva
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/95264
Reviewed-by: Andras Timar
diff --git a/loleaflet/css/menubar.css b/loleaflet/css/menubar.css
index a9031469a..cab048379 100644
--- a/loleaflet/css/menubar.css
+++ b/loleaflet/css/menubar.css
@@ -39,7 +39,7 @@
table-layout: fixed;
border-spacing: 5px 0px;
max-height: 39px;
-z-index: 10;
+z-index: 1000;
}
.main-nav {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/co-4-2-4' - loleaflet/src
loleaflet/src/control/Control.LokDialog.js |3 +++
1 file changed, 3 insertions(+)
New commits:
commit ec6f108a24bba23fd17c398079b08586bc987182
Author: Marco Cecchetti
AuthorDate: Thu May 7 13:14:05 2020 +0200
Commit: Andras Timar
CommitDate: Mon Jun 1 19:32:07 2020 +0200
leaflet: formula bar: missing text selection handles
mobile: double tap a word
double tap the next word
the new word is selected but there is no selection handles
Change-Id: I283dc1b177910605826102daaa28714c65190f4f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/95225
Tested-by: Jenkins
Reviewed-by: Marco Cecchetti
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/95263
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Andras Timar
diff --git a/loleaflet/src/control/Control.LokDialog.js
b/loleaflet/src/control/Control.LokDialog.js
index a96ae309f..dfddbdfc2 100644
--- a/loleaflet/src/control/Control.LokDialog.js
+++ b/loleaflet/src/control/Control.LokDialog.js
@@ -503,6 +503,9 @@ L.Control.LokDialog = L.Control.extend({
handles.end = null;
}
+ if (!handles.start && !handles.end)
+ handles.draggingStopped = true;
+
if (!rectangles || rectangles.length < 1) {
return;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: docker/Debian docker/Ubuntu
docker/Debian |2 +- docker/Ubuntu |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit ac71e9c63af4f80c19111d0570eb96bad940ab65 Author: Andras Timar AuthorDate: Thu May 28 13:23:56 2020 +0200 Commit: Andras Timar CommitDate: Mon Jun 1 19:32:42 2020 +0200 we don't have to depend on locales-all ... after 15ced64d323e10660e60abbbcfa7386780dcfb4e Change-Id: If08624d4c9614f3616af7f39c7bc636aebaf749b Reviewed-on: https://gerrit.libreoffice.org/c/online/+/95024 Tested-by: Jenkins Tested-by: Jenkins CollaboraOffice Reviewed-by: Andras Timar diff --git a/docker/Debian b/docker/Debian index 58cc72142..c0218694a 100644 --- a/docker/Debian +++ b/docker/Debian @@ -12,7 +12,7 @@ FROM debian:stable # install an editor # tdf#117557 - Add CJK Fonts to LibreOffice Online Docker Image RUN apt-get update && \ -apt-get -y install locales-all libpng16-16 fontconfig adduser cpio \ +apt-get -y install libpng16-16 fontconfig adduser cpio \ findutils nano libpoco-dev libcap2-bin openssl inotify-tools \ procps libubsan0 libubsan1 openssh-client fonts-wqy-zenhei \ fonts-wqy-microhei fonts-droid-fallback fonts-noto-cjk diff --git a/docker/Ubuntu b/docker/Ubuntu index d0685b246..4d00a16bb 100644 --- a/docker/Ubuntu +++ b/docker/Ubuntu @@ -12,7 +12,7 @@ FROM ubuntu:18.04 # install an editor # tdf#117557 - Add CJK Fonts to LibreOffice Online Docker Image RUN apt-get update && \ -apt-get -y install locales-all libpng16-16 fontconfig adduser cpio \ +apt-get -y install libpng16-16 fontconfig adduser cpio \ findutils nano libpocoxml50 libpocoutil50 libpoconetssl50 \ libpoconet50 libpocojson50 libpocofoundation50 libpococrypto50 \ libcap2-bin openssl openssh-client inotify-tools procps \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 133573] Footnotes Alignment not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=133573 --- Comment #2 from fra...@slacky.it --- Version 6.4.4 installed just now, same problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72147] EDITING: Calc/Impress - Double clicking and dragging to select multiple words does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=72147 --- Comment #19 from Johannes Feld --- This bug is still present in 6.4.4.2 (x64) Version ID: 3d775be2011f3886db32dfd395a6a6d1ca2630ff -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50879] form exported as pdf does not embed all required fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=50879 --- Comment #50 from le...@arcor.de --- Strange thing is: It works with OpenOffice, without any interaction... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 50879] form exported as pdf does not embed all required fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=50879 --- Comment #50 from le...@arcor.de --- Strange thing is: It works with OpenOffice, without any interaction... -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 106307] Wrong shape for numerals, based on locale and not the text language
https://bugs.documentfoundation.org/show_bug.cgi?id=106307 --- Comment #6 from Mike --- Created attachment 161499 --> https://bugs.documentfoundation.org/attachment.cgi?id=161499=edit Screenshots of different Hindi fonts numerals -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106307] Wrong shape for numerals, based on locale and not the text language
https://bugs.documentfoundation.org/show_bug.cgi?id=106307 Mike changed: What|Removed |Added CC||bugzilla@mkr.email --- Comment #5 from Mike --- repro Version: 6.4.2.2 Build ID: 1:6.4.2-0ubuntu3 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3; Locale: en-US (de_DE.UTF-8); UI-Language: en-US Calc: threaded Version: 6.4.4.2 (x64) Build-ID: 3d775be2011f3886db32dfd395a6a6d1ca2630ff CPU-Threads: 4; BS: Windows 10.0 Build 18363; UI-Render: Standard; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: CL There are other things to this issue A) Additionally to Persian do some other locales that switch to Hindi numerals: Arabic (all locales) Urdu (Pakistan) Punjabi I don't know what they have in common except being in the same area [middle east and north africa]. (I did not test all locales, just some.) B) Impress uses different fonts for Hindi numerals. If you open the settings and change the locale from "Persian" to "Hindi", the numeral's font changes. Impress chooses another font. This affects both Win and Ubuntu. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133589] New: add transliteration support for Old Hungarian
https://bugs.documentfoundation.org/show_bug.cgi?id=133589 Bug ID: 133589 Summary: add transliteration support for Old Hungarian Product: LibreOffice Version: 3.3.0 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nem...@numbertext.org Old Hungarian (ISO 15924: Hung) is a historical and renewed script which is still in use to transliterate Hungarian writing, see https://en.wikipedia.org/wiki/Old_Hungarian_script. As a localized AutoCorrect feature, I suggest the following minimal transliteration support: – word-by-word transliteration of Hungarian texts in right-to-left mode. – consonant disambiguation of digraphs and trigraphs based on hyphenation (now pattern-based Huhyphn dictionary of libhyphen, planned dictionary based Hunspell later) – transliteration by Numbertext library More information: https://www.researchgate.net/publication/326855248_Sandor_Klara_2017_A_szekely_iras_reneszansza_%27The_Renaissance_of_the_Szekely_Script%27_Budapest_Typotext_311_pp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133589] add transliteration support for Old Hungarian
https://bugs.documentfoundation.org/show_bug.cgi?id=133589 László Németh changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Assignee|libreoffice-b...@lists.free |nem...@numbertext.org |desktop.org | Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133268] Colibre’s color palette is faint and fails WCAG contrast guidelines
https://bugs.documentfoundation.org/show_bug.cgi?id=133268 --- Comment #10 from V Stuart Foote --- Created attachment 161498 --> https://bugs.documentfoundation.org/attachment.cgi?id=161498=edit comparison of Writer toolbar old Colibre color theme and revised Applied the OXT to get a look at the new color scheme and touched up SVG/PNG--much crisper. Nice improvement Rizal, thanks! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133268] Colibre’s color palette is faint and fails WCAG contrast guidelines
https://bugs.documentfoundation.org/show_bug.cgi?id=133268 --- Comment #9 from V Stuart Foote --- Created attachment 161497 --> https://bugs.documentfoundation.org/attachment.cgi?id=161497=edit side by side comparison old Colibre color theme and revised 'monoline' compliant -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/GraphicAttributes.hxx | 121 ++
include/vcl/GraphicObject.hxx | 96 --
vcl/source/graphic/grfattr.cxx|4 -
3 files changed, 124 insertions(+), 97 deletions(-)
New commits:
commit d2974701e7f9e138ad952eeccb279567b5b309b1
Author: Tomaž Vajngerl
AuthorDate: Mon May 25 21:58:01 2020 +0200
Commit: Tomaž Vajngerl
CommitDate: Mon Jun 1 18:46:54 2020 +0200
vcl: move GraphicAttr into its own header file
Change-Id: I8a730414e712a1484ffcca427ed4b1599d223f8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95276
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/vcl/GraphicAttributes.hxx
b/include/vcl/GraphicAttributes.hxx
new file mode 100644
index ..0908a8f56b9d
--- /dev/null
+++ b/include/vcl/GraphicAttributes.hxx
@@ -0,0 +1,121 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed
+ * with this work for additional information regarding copyright
+ * ownership. The ASF licenses this file to you under the Apache
+ * License, Version 2.0 (the "License"); you may not use this file
+ * except in compliance with the License. You may obtain a copy of
+ * the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+#pragma once
+
+#include
+#include
+#include
+#include
+
+enum class GraphicDrawMode
+{
+Standard = 0,
+Greys = 1,
+Mono = 2,
+Watermark = 3
+};
+
+class VCL_DLLPUBLIC GraphicAttr
+{
+private:
+double mfGamma;
+BmpMirrorFlags mnMirrFlags;
+long mnLeftCrop;
+long mnTopCrop;
+long mnRightCrop;
+long mnBottomCrop;
+sal_uInt16 mnRotate10;
+short mnContPercent;
+short mnLumPercent;
+short mnRPercent;
+short mnGPercent;
+short mnBPercent;
+bool mbInvert;
+sal_uInt8 mcTransparency;
+GraphicDrawMode meDrawMode;
+
+public:
+GraphicAttr();
+
+bool operator==(const GraphicAttr& rAttr) const;
+bool operator!=(const GraphicAttr& rAttr) const { return !(*this ==
rAttr); }
+
+void SetDrawMode(GraphicDrawMode eDrawMode) { meDrawMode = eDrawMode; }
+GraphicDrawMode GetDrawMode() const { return meDrawMode; }
+
+void SetMirrorFlags(BmpMirrorFlags nMirrFlags) { mnMirrFlags = nMirrFlags;
}
+BmpMirrorFlags GetMirrorFlags() const { return mnMirrFlags; }
+
+void SetCrop(long nLeft_100TH_MM, long nTop_100TH_MM, long nRight_100TH_MM,
+ long nBottom_100TH_MM)
+{
+mnLeftCrop = nLeft_100TH_MM;
+mnTopCrop = nTop_100TH_MM;
+mnRightCrop = nRight_100TH_MM;
+mnBottomCrop = nBottom_100TH_MM;
+}
+long GetLeftCrop() const { return mnLeftCrop; }
+long GetTopCrop() const { return mnTopCrop; }
+long GetRightCrop() const { return mnRightCrop; }
+long GetBottomCrop() const { return mnBottomCrop; }
+
+void SetRotation(sal_uInt16 nRotate10) { mnRotate10 = nRotate10; }
+sal_uInt16 GetRotation() const { return mnRotate10; }
+
+void SetLuminance(short nLuminancePercent) { mnLumPercent =
nLuminancePercent; }
+short GetLuminance() const { return mnLumPercent; }
+
+void SetContrast(short nContrastPercent) { mnContPercent =
nContrastPercent; }
+short GetContrast() const { return mnContPercent; }
+
+void SetChannelR(short nChannelRPercent) { mnRPercent = nChannelRPercent; }
+short GetChannelR() const { return mnRPercent; }
+
+void SetChannelG(short nChannelGPercent) { mnGPercent = nChannelGPercent; }
+short GetChannelG() const { return mnGPercent; }
+
+void SetChannelB(short nChannelBPercent) { mnBPercent = nChannelBPercent; }
+short GetChannelB() const { return mnBPercent; }
+
+void SetGamma(double fGamma) { mfGamma = fGamma; }
+double GetGamma() const { return mfGamma; }
+
+void SetInvert(bool bInvert) { mbInvert = bInvert; }
+bool IsInvert() const { return mbInvert; }
+
+void SetTransparency(sal_uInt8 cTransparency) { mcTransparency =
cTransparency; }
+sal_uInt8 GetTransparency() const { return mcTransparency; }
+
+bool IsSpecialDrawMode() const { return (meDrawMode !=
GraphicDrawMode::Standard); }
+bool IsMirrored() const { return mnMirrFlags != BmpMirrorFlags::NONE; }
+bool IsCropped() const
+{
+return (mnLeftCrop != 0 || mnTopCrop != 0 || mnRightCrop != 0 ||
mnBottomCrop != 0);
+}
+bool IsRotated() const { return ((mnRotate10 % 3600) != 0); }
+bool IsTransparent() const {
[Libreoffice-commits] core.git: include/tools
include/tools/UnitConversion.hxx |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
New commits:
commit 5f8f8889a47a7079fc1beaa179e29cc32aa10e0e
Author: Tomaž Vajngerl
AuthorDate: Sat May 23 11:54:01 2020 +0200
Commit: Tomaž Vajngerl
CommitDate: Mon Jun 1 18:46:13 2020 +0200
vcl: add conversion point to twip int64 & double values
Change-Id: Id54d28b57c055269259317521f59d37dcdf9a456
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95274
Tested-by: Tomaž Vajngerl
Reviewed-by: Tomaž Vajngerl
diff --git a/include/tools/UnitConversion.hxx b/include/tools/UnitConversion.hxx
index 2093db6181d9..2585fecbb590 100644
--- a/include/tools/UnitConversion.hxx
+++ b/include/tools/UnitConversion.hxx
@@ -20,11 +20,15 @@ constexpr sal_Int64 convertMm100ToTwip(sal_Int64 n)
return (n >= 0) ? (n * 72 + 63) / 127 : (n * 72 - 63) / 127;
}
+constexpr sal_Int64 convertPointToTwip(sal_Int64 nNumber) { return nNumber *
20; }
+
constexpr sal_Int64 convertPointToMm100(sal_Int64 nNumber)
{
-return convertTwipToMm100(nNumber * 20);
+return convertTwipToMm100(convertPointToTwip(nNumber));
}
+constexpr double convertPointToTwip(double fNumber) { return fNumber * 20.0; }
+
constexpr double convertPointToMm100(double fNumber) { return fNumber *
35.278; }
// Convert PPT's "master unit" (1/576 inch) to twips
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/vcl
include/vcl/GraphicObject.hxx |5 + 1 file changed, 1 insertion(+), 4 deletions(-) New commits: commit f2b436b0dad86aec5dc22e27c83df93395378247 Author: Tomaž Vajngerl AuthorDate: Mon May 25 20:46:38 2020 +0200 Commit: Tomaž Vajngerl CommitDate: Mon Jun 1 18:46:34 2020 +0200 vcl: convert to use "pragma once" in GraphicObject.hxx Change-Id: I6fd1897574d831ef153adc0d385c6484f6c17d7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95275 Tested-by: Tomaž Vajngerl Reviewed-by: Tomaž Vajngerl diff --git a/include/vcl/GraphicObject.hxx b/include/vcl/GraphicObject.hxx index 5a4053fa6569..92c01274a453 100644 --- a/include/vcl/GraphicObject.hxx +++ b/include/vcl/GraphicObject.hxx @@ -17,8 +17,7 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#ifndef INCLUDED_VCL_GRAPHICOBJECT_HXX -#define INCLUDED_VCL_GRAPHICOBJECT_HXX +#pragma once #include #include @@ -396,6 +395,4 @@ VCL_DLLPUBLIC void SearchForGraphics(css::uno::Reference c } } // end namespace vcl::graphic -#endif // INCLUDED_VCL_GRAPHICOBJECT_HXX - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: tools/qa
tools/qa/cppunit/test_100mm2twips.cxx | 38 +-
1 file changed, 24 insertions(+), 14 deletions(-)
New commits:
commit b1c007cd06c01078df481e020d9d81afd4de6a91
Author: Tomaž Vajngerl
AuthorDate: Thu May 21 11:47:34 2020 +0200
Commit: Tomaž Vajngerl
CommitDate: Mon Jun 1 18:45:13 2020 +0200
tools: extend test for UnitConversion
Change-Id: I8fbc2a83f40fb04656f690b4b63d3cac9f0410c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95273
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/tools/qa/cppunit/test_100mm2twips.cxx
b/tools/qa/cppunit/test_100mm2twips.cxx
index 80ceda2ffb3f..bfed8c2e2ba9 100644
--- a/tools/qa/cppunit/test_100mm2twips.cxx
+++ b/tools/qa/cppunit/test_100mm2twips.cxx
@@ -23,29 +23,39 @@
#include
#include
+#include
-namespace tools
-{
-class cm2TwipsTest : public CppUnit::TestFixture
+class UnitConversionTest : public CppUnit::TestFixture
{
public:
-void testConvert()
+void testSanitiseMm100ToTwip()
+{
+CPPUNIT_ASSERT_EQUAL(sal_Int64(145), sanitiseMm100ToTwip(255));
+CPPUNIT_ASSERT_EQUAL(sal_Int64(-145), sanitiseMm100ToTwip(-255));
+}
+
+void testConvertMm100ToTwip()
+{
+CPPUNIT_ASSERT_EQUAL(sal_Int64(145), convertMm100ToTwip(255));
+CPPUNIT_ASSERT_EQUAL(sal_Int64(-145), convertMm100ToTwip(-255));
+}
+
+void testConvertPointToMm100()
{
-sal_Int32 nActual = sanitiseMm100ToTwip(255);
-sal_Int32 nExpected = 145;
-CPPUNIT_ASSERT_EQUAL(nExpected, nActual);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(599.72, convertPointToMm100(17.0), 1E-2);
+CPPUNIT_ASSERT_EQUAL(sal_Int64(600),
convertPointToMm100(sal_Int64(17)));
-nActual = sanitiseMm100ToTwip(-255);
-nExpected = -145;
-CPPUNIT_ASSERT_EQUAL(nExpected, nActual);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(22930.55, convertPointToMm100(650.0),
1E-2);
+CPPUNIT_ASSERT_EQUAL(sal_Int64(22931),
convertPointToMm100(sal_Int64(650)));
}
-CPPUNIT_TEST_SUITE(cm2TwipsTest);
-CPPUNIT_TEST(testConvert);
+CPPUNIT_TEST_SUITE(UnitConversionTest);
+CPPUNIT_TEST(testSanitiseMm100ToTwip);
+CPPUNIT_TEST(testConvertMm100ToTwip);
+CPPUNIT_TEST(testConvertPointToMm100);
CPPUNIT_TEST_SUITE_END();
};
-CPPUNIT_TEST_SUITE_REGISTRATION(cm2TwipsTest);
-} // namespace tools
+CPPUNIT_TEST_SUITE_REGISTRATION(UnitConversionTest);
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: compilerplugins/clang toolkit/source
compilerplugins/clang/referencecasting.cxx |3 +++
toolkit/source/controls/stdtabcontroller.cxx | 16 +---
2 files changed, 12 insertions(+), 7 deletions(-)
New commits:
commit d5e222cd86b82a429c28cb19583521d581efaf2b
Author: Noel Grandin
AuthorDate: Mon Jun 1 13:51:51 2020 +0200
Commit: Noel Grandin
CommitDate: Mon Jun 1 18:42:11 2020 +0200
Revert "tdf#125609 toolkit: don't use XTabController::getControls"
This reverts LO6.4 commit 5cf057c3365a0feafc8f2e4f4a9e24d69a581999,
in order to fix tdf#133158.
This commit is obsolete, but was left in place since it
seemed to have fixed a problem (in =gtk3 anyway).
But now SAL_USE_VCLPLUGIN=gen behaves differently,
so obviously a fix in one place must have broken another.
Better the problems you have always known than
a new problem, especially since this patch
isn't used to fix anything specific in gtk3 anymore
(since those changes were also reverted).
An earlier gerrit version of this revert (which
didn't just have an ignore-this-clang-rule exception)
half-worked, but failed if multiple documents
were opened.
Change-Id: Ie8ddb7b9669fa46067d04c35e157ea08701df0da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95282
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/compilerplugins/clang/referencecasting.cxx
b/compilerplugins/clang/referencecasting.cxx
index 33997cdb458d..f23e2f6811cd 100644
--- a/compilerplugins/clang/referencecasting.cxx
+++ b/compilerplugins/clang/referencecasting.cxx
@@ -44,6 +44,9 @@ public:
// macros
if (fn == SRCDIR "/dbaccess/source/ui/browser/formadapter.cxx")
return false;
+// UNO aggregation
+if (fn == SRCDIR "/toolkit/source/controls/stdtabcontroller.cxx")
+return false;
return true;
}
diff --git a/toolkit/source/controls/stdtabcontroller.cxx
b/toolkit/source/controls/stdtabcontroller.cxx
index b0c6142476b0..0fa0f96f965c 100644
--- a/toolkit/source/controls/stdtabcontroller.cxx
+++ b/toolkit/source/controls/stdtabcontroller.cxx
@@ -306,17 +306,19 @@ void StdTabController::activateTabOrder( )
if ( !xC.is() || !xVclContainerPeer.is() )
return;
+// This may return a TabController, which returns desired list of controls
faster
+// (the dreaded UNO aggregration, retrieve the thing that we are part of)
+Reference xTabController(
static_cast(this), UNO_QUERY );
+
// Get a flattened list of controls sequences
Sequence< Reference< XControlModel > > aModels =
mxModel->getControlModels();
Sequence< Reference< XWindow > > aCompSeq;
Sequence< Any> aTabSeq;
-// Previously used aControls = xTabController->getControls() "for the sake
of optimization",
-// but that list isn't valid during the creation phase (missing last
created control) because
-// listenermultiplexer.cxx handles fmvwimp::elementinserted before
formcontroller::elementInserted
-// Perhaps other places using the same optimization need to be reviewed?
(tdf#125609)
-Sequence< Reference< XControl > > aCachedControls = getControls();
-Sequence< Reference< XControl > > aControls = aCachedControls;
+// DG: For the sake of optimization, retrieve Controls from getControls(),
+// this may sound counterproductive, but leads to performance improvements
+// in practical scenarios (Forms)
+Sequence< Reference< XControl > > aControls =
xTabController->getControls();
// #58317# Some Models may be missing from the Container. Plus there is a
// autoTabOrder call later on.
@@ -334,7 +336,7 @@ void StdTabController::activateTabOrder( )
{
mxModel->getGroup( nG, aThisGroupModels, aName );
-aControls = aCachedControls;
+aControls = xTabController->getControls();
// ImplCreateComponentSequence has a really strange semantics
regarding it's first parameter:
// upon method entry, it expects a super set of the controls which
it returns
// this means we need to completely fill this sequence with all
available controls before
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - chart2/qa oox/source
chart2/qa/extras/chart2export.cxx | 11 +++
chart2/qa/extras/data/xlsx/chart_pie2007.xlsx |binary
oox/source/drawingml/chart/typegroupmodel.cxx |2 +-
3 files changed, 12 insertions(+), 1 deletion(-)
New commits:
commit 59a896d80feee9f4c25b931c77aee281da189868
Author: Tünde Tóth
AuthorDate: Tue May 26 13:34:32 2020 +0200
Commit: Xisco Fauli
CommitDate: Mon Jun 1 18:25:05 2020 +0200
tdf#132594 Chart XLSX import: fix legend entries in pie charts
Legend entry text of pie chart wasn't imported correctly
in XLSX documents created with Excel 2007.
Regression from commit: e0b0502516a10181bbd1737b93b38b2bba4c98e8
(tdf#128016 Chart OOXML Import: fix duplicated category labels)
Change-Id: I4567437a41fe66e124dccbd148c0c49196d5c007
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94864
Tested-by: Jenkins
Tested-by: László Németh
Reviewed-by: László Németh
Signed-off-by: Xisco Fauli
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95294
diff --git a/chart2/qa/extras/chart2export.cxx
b/chart2/qa/extras/chart2export.cxx
index 6826c3f53569..cb9e4aa32df3 100644
--- a/chart2/qa/extras/chart2export.cxx
+++ b/chart2/qa/extras/chart2export.cxx
@@ -152,6 +152,7 @@ public:
void testTdf123206_customLabelText();
void testCustomLabelText();
void testTdf131979();
+void testTdf132594();
CPPUNIT_TEST_SUITE(Chart2ExportTest);
CPPUNIT_TEST(testErrorBarXLSX);
@@ -267,6 +268,7 @@ public:
CPPUNIT_TEST(testTdf123206_customLabelText);
CPPUNIT_TEST(testCustomLabelText);
CPPUNIT_TEST(testTdf131979);
+CPPUNIT_TEST(testTdf132594);
CPPUNIT_TEST_SUITE_END();
@@ -2467,6 +2469,15 @@ void Chart2ExportTest::testTdf131979()
}
}
+void Chart2ExportTest::testTdf132594()
+{
+load("/chart2/qa/extras/data/xlsx/", "chart_pie2007.xlsx");
+xmlDocPtr pXmlDoc = parseExport("xl/charts/chart","Calc Office Open XML");
+CPPUNIT_ASSERT(pXmlDoc);
+
+assertXPath(pXmlDoc,
"/c:chartSpace/c:chart/c:plotArea/c:pieChart/c:ser/c:cat", 1);
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(Chart2ExportTest);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/chart2/qa/extras/data/xlsx/chart_pie2007.xlsx
b/chart2/qa/extras/data/xlsx/chart_pie2007.xlsx
new file mode 100644
index ..b122680257c0
Binary files /dev/null and b/chart2/qa/extras/data/xlsx/chart_pie2007.xlsx
differ
diff --git a/oox/source/drawingml/chart/typegroupmodel.cxx
b/oox/source/drawingml/chart/typegroupmodel.cxx
index aae01ed0f58e..7353bafbecc7 100644
--- a/oox/source/drawingml/chart/typegroupmodel.cxx
+++ b/oox/source/drawingml/chart/typegroupmodel.cxx
@@ -57,7 +57,7 @@ TypeGroupModel::TypeGroupModel( sal_Int32 nTypeId, bool
bMSO2007Doc ) :
mbSmooth( !bMSO2007Doc ),
mbVaryColors( !bMSO2007Doc ),
mbWireframe( !bMSO2007Doc ),
-mbCatAxisVisible( !bMSO2007Doc )
+mbCatAxisVisible( true )
{
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/qa sw/source writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf120394.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport14.cxx | 25 +
sw/qa/extras/rtfimport/rtfimport.cxx |5 +-
sw/source/core/doc/number.cxx|7 +++
sw/source/filter/ww8/wrtw8num.cxx| 30 +++
writerfilter/source/dmapper/NumberingManager.cxx | 44 +++
6 files changed, 56 insertions(+), 55 deletions(-)
New commits:
commit 8401181bf0232959efb516802abcda42377ea06e
Author: Vasily Melenchuk
AuthorDate: Sun May 17 13:35:46 2020 +0300
Commit: Thorsten Behrens
CommitDate: Mon Jun 1 18:20:24 2020 +0200
tdf#120394: DOCX list import: simplify zero width space hack
Since introducion of list format string hack with creation
of zero-width-space can be much more simple. It was being
used to indicate existing, but empty list label suffix to
avoid stripping down numbering.
Change-Id: I9a0c6047f806b2c656ef5dbab0c6b38200818bd2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94383
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
diff --git a/sw/qa/extras/ooxmlexport/data/tdf120394.docx
b/sw/qa/extras/ooxmlexport/data/tdf120394.docx
new file mode 100644
index ..39bd5886c0fe
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf120394.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
index b372f2e86dcd..b95d0afe4e8f 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
@@ -887,6 +887,31 @@ DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf128290,
"tdf128290.odt")
assertXPath(pXml, "/w:document/w:body/w:tbl/w:tblPr/w:tblLayout", "type",
"fixed");
}
+DECLARE_OOXMLEXPORT_TEST(testTdf120394, "tdf120394.docx")
+{
+CPPUNIT_ASSERT_EQUAL(1, getPages());
+{
+uno::Reference xPara(getParagraph(1),
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(static_cast(0),
getProperty(xPara, "NumberingLevel"));
+CPPUNIT_ASSERT_EQUAL(OUString("1"), getProperty(xPara,
"ListLabelString"));
+}
+{
+uno::Reference xPara(getParagraph(2),
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(static_cast(1),
getProperty(xPara, "NumberingLevel"));
+CPPUNIT_ASSERT_EQUAL(OUString(CHAR_ZWSP), getProperty(xPara,
"ListLabelString"));
+}
+{
+uno::Reference xPara(getParagraph(3),
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(static_cast(1),
getProperty(xPara, "NumberingLevel"));
+CPPUNIT_ASSERT_EQUAL(OUString(CHAR_ZWSP), getProperty(xPara,
"ListLabelString"));
+}
+{
+uno::Reference xPara(getParagraph(5),
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(static_cast(2),
getProperty(xPara, "NumberingLevel"));
+CPPUNIT_ASSERT_EQUAL(OUString("1.2.1"), getProperty(xPara,
"ListLabelString"));
+}
+}
+
DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf123757, "tdf123757.docx")
{
xmlDocUniquePtr pXml = parseExport("word/document.xml");
diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx
b/sw/qa/extras/rtfimport/rtfimport.cxx
index 085a71aedc86..cf9d5dd31309 100644
--- a/sw/qa/extras/rtfimport/rtfimport.cxx
+++ b/sw/qa/extras/rtfimport/rtfimport.cxx
@@ -343,8 +343,7 @@ CPPUNIT_TEST_FIXTURE(Test, testFdo49692)
if (rProp.Name == "Suffix")
{
-OUString aExpected(u'\x200B');
-CPPUNIT_ASSERT_EQUAL(aExpected, rProp.Value.get());
+CPPUNIT_ASSERT(rProp.Value.get().isEmpty());
}
}
}
@@ -1358,7 +1357,7 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf78506)
if (rProp.Name == "Suffix")
// This was '0', invalid \levelnumbers wasn't ignored.
-CPPUNIT_ASSERT_EQUAL(CHAR_ZWSP,
rProp.Value.get().toChar());
+CPPUNIT_ASSERT(rProp.Value.get().isEmpty());
}
}
diff --git a/sw/source/core/doc/number.cxx b/sw/source/core/doc/number.cxx
index 02c2512e7872..1d2ae4f970d4 100644
--- a/sw/source/core/doc/number.cxx
+++ b/sw/source/core/doc/number.cxx
@@ -667,6 +667,13 @@ OUString SwNumRule::MakeNumString( const
SwNumberTree::tNumberVector & rNumVecto
if (nPosition >= 0)
sLevelFormat = sLevelFormat.replaceAt(nPosition,
sFind.getLength(), sReplacement);
}
+
+// As a fallback: caller code expects nonempty string as a
result.
+// But if we have empty string (and had no errors before) this
is valid result.
+// So use classical hack with zero-width-space as a string
filling.
+if (sLevelFormat.isEmpty())
+sLevelFormat = OUStringChar(CHAR_ZWSP);
+
aStr = sLevelFormat;
}
else
diff --git a/sw/source/filter/ww8/wrtw8num.cxx
b/sw/source/filter/ww8/wrtw8num.cxx
index e2aad33206d3..1774c37239e7 100644
--- a/sw/source/filter/ww8/wrtw8num.cxx
+++
[Libreoffice-commits] core.git: configure.ac
configure.ac | 49 -
1 file changed, 16 insertions(+), 33 deletions(-)
New commits:
commit b44c8898fc13941f63066a5817ba5fe8f71fbdbf
Author: Jan-Marek Glogowski
AuthorDate: Sun May 31 23:35:20 2020 +0200
Commit: Thorsten Behrens
CommitDate: Mon Jun 1 18:19:00 2020 +0200
Split gtk3* VCL backend test and library detection
After seeing all the duplicate code added by commit
e3beaed3420b5f6deda1c443da1435d4ccfee022, this simply splits
the library detection and VCL backend handling.
PKG_CHECK_MODULES fails per default, if it doesn't use any
result handling, so no special error handling is needed.
Change-Id: I1f815091e9763c407e9297a6104559bed55d5706
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95250
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
diff --git a/configure.ac b/configure.ac
index cafd9ce86779..38cef8b899f2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -10659,34 +10659,23 @@ R=""
if test "$USING_X11" != TRUE; then
enable_gtk3=no
fi
-GTK3_CFLAGS=""
-GTK3_LIBS=""
+
ENABLE_GTK3=""
if test "x$enable_gtk3" = "xyes"; then
-if test "$with_system_cairo" = no; then
-AC_MSG_ERROR([System cairo required for gtk3 support, do not combine
--enable-gtk3 with --without-system-cairo])
-fi
-: ${with_system_cairo:=yes}
-PKG_CHECK_MODULES(GTK3, gtk+-3.0 >= 3.18 gtk+-unix-print-3.0
gmodule-no-export-2.0 glib-2.0 >= 2.38 cairo, ENABLE_GTK3="TRUE",
ENABLE_GTK3="")
-if test "x$ENABLE_GTK3" = "xTRUE"; then
-AC_DEFINE(ENABLE_GTK3)
-R="gtk3"
-else
-AC_MSG_ERROR([gtk3 or dependent libraries of the correct versions, not
found])
-fi
-GTK3_CFLAGS=$(printf '%s' "$GTK3_CFLAGS" | sed -e "s/-I/${ISYSTEM?}/g")
-FilterLibs "${GTK3_LIBS}"
-GTK3_LIBS="${filteredlibs}"
-
-dnl We require egl only for the gtk3 plugin. Otherwise we use glx.
-if test "$with_system_epoxy" != "yes"; then
-AC_CHECK_LIB(EGL, eglMakeCurrent, [:], AC_MSG_ERROR([libEGL
required.]))
-AC_CHECK_HEADER(EGL/eglplatform.h, [],
-[AC_MSG_ERROR(EGL headers not found. install
mesa-libEGL-devel)], [])
-fi
+ENABLE_GTK3="TRUE"
+AC_DEFINE(ENABLE_GTK3)
+R="$R gtk3"
fi
AC_SUBST(ENABLE_GTK3)
+ENABLE_GTK3_KDE5=""
+if test "x$enable_gtk3_kde5" = "xyes"; then
+ENABLE_GTK3_KDE5="TRUE"
+AC_DEFINE(ENABLE_GTK3_KDE5)
+R="$R gtk3_kde5"
+fi
+AC_SUBST(ENABLE_GTK3_KDE5)
+
ENABLE_QT5=""
if test "x$enable_qt5" = "xyes"; then
ENABLE_QT5="TRUE"
@@ -10703,19 +10692,14 @@ if test "x$enable_kf5" = "xyes"; then
fi
AC_SUBST(ENABLE_KF5)
-ENABLE_GTK3_KDE5=""
-if test "x$enable_gtk3_kde5" = "xyes"; then
+GTK3_CFLAGS=""
+GTK3_LIBS=""
+if test "x$enable_gtk3" = "xyes" -o "x$enable_gtk3_kde5" = "xyes"; then
if test "$with_system_cairo" = no; then
AC_MSG_ERROR([System cairo required for gtk3 support, do not combine
--enable-gtk3 with --without-system-cairo])
fi
: ${with_system_cairo:=yes}
-PKG_CHECK_MODULES(GTK3, gtk+-3.0 >= 3.18 gtk+-unix-print-3.0
gmodule-no-export-2.0 glib-2.0 >= 2.38 cairo, ENABLE_GTK3_KDE5="TRUE",
ENABLE_GTK3_KDE5="")
-if test "x$ENABLE_GTK3_KDE5" = "xTRUE"; then
-AC_DEFINE(ENABLE_GTK3_KDE5)
-R="$R gtk3_kde5"
-else
-AC_MSG_ERROR([gtk3_kde5 or dependent libraries of the correct
versions, not found])
-fi
+PKG_CHECK_MODULES(GTK3, gtk+-3.0 >= 3.18 gtk+-unix-print-3.0
gmodule-no-export-2.0 glib-2.0 >= 2.38 cairo)
GTK3_CFLAGS=$(printf '%s' "$GTK3_CFLAGS" | sed -e "s/-I/${ISYSTEM?}/g")
FilterLibs "${GTK3_LIBS}"
GTK3_LIBS="${filteredlibs}"
@@ -10727,7 +10711,6 @@ if test "x$enable_gtk3_kde5" = "xyes"; then
[AC_MSG_ERROR(EGL headers not found. install
mesa-libEGL-devel)], [])
fi
fi
-AC_SUBST(ENABLE_GTK3_KDE5)
AC_SUBST(GTK3_LIBS)
AC_SUBST(GTK3_CFLAGS)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - editeng/source include/editeng
editeng/source/misc/svxacorr.cxx | 55 +--
include/editeng/svxacorr.hxx | 10 ++-
2 files changed, 33 insertions(+), 32 deletions(-)
New commits:
commit 8a8ed6a79453907056d202efc7eb988320ca49b5
Author: László Németh
AuthorDate: Wed May 27 18:15:26 2020 +0200
Commit: Xisco Fauli
CommitDate: Mon Jun 1 18:10:12 2020 +0200
AutoCorrect: clean-up InsertQuote
Change-Id: I577115805e5bcc29f6eb4d853aaa523495f30126
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95211
Tested-by: László Németh
Reviewed-by: László Németh
(cherry picked from commit c87c7ddca46ae093a703ca673a204e4593402c38)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95244
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/editeng/source/misc/svxacorr.cxx b/editeng/source/misc/svxacorr.cxx
index 71f6efc2e33f..ebc0ec810a60 100644
--- a/editeng/source/misc/svxacorr.cxx
+++ b/editeng/source/misc/svxacorr.cxx
@@ -1192,9 +1192,8 @@ sal_Unicode SvxAutoCorrect::GetQuote( sal_Unicode
cInsChar, bool bSttQuote,
void SvxAutoCorrect::InsertQuote( SvxAutoCorrDoc& rDoc, sal_Int32 nInsPos,
sal_Unicode cInsChar, bool bSttQuote,
-bool bIns, bool b_iApostrophe ) const
+bool bIns, LanguageType eLang, ACQuotes
eType ) const
{
-const LanguageType eLang = GetDocLanguage( rDoc, nInsPos );
sal_Unicode cRet = GetQuote( cInsChar, bSttQuote, eLang );
OUString sChg( cInsChar );
@@ -1205,36 +1204,21 @@ void SvxAutoCorrect::InsertQuote( SvxAutoCorrDoc& rDoc,
sal_Int32 nInsPos,
sChg = OUString(cRet);
-if( '\"' == cInsChar )
+if( eType == ACQuotes::NonBreakingSpace )
{
-if (primary(eLang) == primary(LANGUAGE_FRENCH) && eLang !=
LANGUAGE_FRENCH_SWISS)
+OUString s( cNonBreakingSpace ); // UNICODE code for no break space
+if( rDoc.Insert( bSttQuote ? nInsPos+1 : nInsPos, s ))
{
-OUString s( cNonBreakingSpace ); // UNICODE code for no break space
-if( rDoc.Insert( bSttQuote ? nInsPos+1 : nInsPos, s ))
-{
-if( !bSttQuote )
-++nInsPos;
-}
+if( !bSttQuote )
+++nInsPos;
}
}
rDoc.Replace( nInsPos, sChg );
-// i' -> I' in English (last step for the undo)
-if( b_iApostrophe && eLang.anyOf(
-LANGUAGE_ENGLISH,
-LANGUAGE_ENGLISH_US,
-LANGUAGE_ENGLISH_UK,
-LANGUAGE_ENGLISH_AUS,
-LANGUAGE_ENGLISH_CAN,
-LANGUAGE_ENGLISH_NZ,
-LANGUAGE_ENGLISH_EIRE,
-LANGUAGE_ENGLISH_SAFRICA,
-LANGUAGE_ENGLISH_JAMAICA,
-LANGUAGE_ENGLISH_CARIBBEAN))
-{
+// i' -> I' in English (last step for the Undo)
+if( eType == ACQuotes::CapitalizeIAm )
rDoc.Replace( nInsPos-1, "I" );
-}
}
OUString SvxAutoCorrect::GetQuote( SvxAutoCorrDoc const & rDoc, sal_Int32
nInsPos,
@@ -1285,7 +1269,8 @@ void SvxAutoCorrect::DoAutoCorrect( SvxAutoCorrDoc& rDoc,
const OUString& rTxt,
{
sal_Unicode cPrev;
bool bSttQuote = !nInsPos;
-bool b_iApostrophe = false;
+ACQuotes eType = ACQuotes::NONE;
+const LanguageType eLang = GetDocLanguage( rDoc, nInsPos );
if (!bSttQuote)
{
cPrev = rTxt[ nInsPos-1 ];
@@ -1295,17 +1280,25 @@ void SvxAutoCorrect::DoAutoCorrect( SvxAutoCorrDoc&
rDoc, const OUString& rTxt,
( cEnDash == cPrev );
// tdf#38394 use opening quotation mark << in French
l'<>
if ( !bSingle && !bSttQuote && cPrev == cApostrophe &&
+primary(eLang) == primary(LANGUAGE_FRENCH) &&
(nInsPos == 2 || (nInsPos > 2 && IsWordDelim( rTxt[
nInsPos-3 ] ))) )
{
-const LanguageType eLang = GetDocLanguage( rDoc,
nInsPos );
-if ( primary(eLang) == primary(LANGUAGE_FRENCH) )
-bSttQuote = true;
+bSttQuote = true;
}
// tdf#108423 for capitalization of English i'm
-b_iApostrophe = bSingle && ( cPrev == 'i' ) &&
-(( nInsPos == 1 ) || IsWordDelim( rTxt[ nInsPos-2 ] ));
+else if ( bSingle && ( cPrev == 'i' ) &&
+primary(eLang) == primary(LANGUAGE_ENGLISH) &&
+( nInsPos == 1 || IsWordDelim( rTxt[ nInsPos-2 ] ) ) )
+{
+eType = ACQuotes::CapitalizeIAm;
+}
}
-InsertQuote( rDoc, nInsPos, cChar, bSttQuote, bInsert,
b_iApostrophe );
+
+if ( eType == ACQuotes::NONE &&
[Libreoffice-bugs] [Bug 133588] calc:The function SUM() does not produce the same result as the '+' operator
https://bugs.documentfoundation.org/show_bug.cgi?id=133588 --- Comment #1 from sebastien.kr...@wanadoo.fr --- Cell with SUM contains value 0, cell with operator + contains value 3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133588] New: calc:The function SUM() does not produce the same result as the '+' operator
https://bugs.documentfoundation.org/show_bug.cgi?id=133588 Bug ID: 133588 Summary: calc:The function SUM() does not produce the same result as the '+' operator Product: LibreOffice Version: 6.0.6.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sebastien.kr...@wanadoo.fr Description: The function SUM() does not produce the same result as the '+' operator in certain situations. I have the feeling this should not be. Steps to Reproduce: 1. enter "'1" in cell A1 (without the ") 2. enter "'2" in cell B1 (without the ") 3. enter "=sum(a1:b1)" in cell C1 (without the ") 4. enter "=a1+b1" in cell D1 (without the ") 5. watch Actual Results: the two cells C1 and D1 do not contain the same value Expected Results: The two cells C1 and D1 should contain the same value (either 0 or 3, I have no definitive answer on that point). I assume that when using the '+' operator, an automatic conversion to numerical values is done. If so, then why isn't that conversion also done when using SUM() ? This is odd. Reproducible: Always User Profile Reset: No Additional Info: The numerical values in A1 and B1 are in fact imported from another tool that (who knows why) exports them as strings, thus they are prefixed with "'" If you feel this is not a bug but a "feature", could you give me a link on where that behavior is documented? Thank you. Version: 6.0.6.2 Build ID: 1:6.0.6-0ubuntu0.14.04.1 CPU threads: 8; OS: Linux 4.4; UI render: default; VCL: gtk2; Locale: fr-FR (en_US.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133467] EDITING Image is not pasted into ODT when copied from MS Word DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=133467 Dieter changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||dgp-m...@gmx.de --- Comment #2 from Dieter --- I can't confirm it with Version: 7.0.0.0.beta1 (x64) Build ID: 94f789cbb5b4a511c319542c7bdc31ff3b3c CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL To be certain the reported issue is not related to corruption in the user profile, could you please reset your Libreoffice profile (https://wiki.documentfoundation.org/UserProfile) and re-test? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the issue is still present. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133587] New: Following the update of W10 Libre Office crashes and stop working. Need to restart the computer
https://bugs.documentfoundation.org/show_bug.cgi?id=133587 Bug ID: 133587 Summary: Following the update of W10 Libre Office crashes and stop working. Need to restart the computer Product: LibreOffice Version: 6.4.4.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jb.m...@sfr.fr Description: I've had different problems the program freezes the mouse is no longer active impossible to close the application the menu windows are empty forced to reboot the computer. Before w10 update, no problem Actual Results: happens randomly I have to restart the computer. When I restart Libre Office I have to recover the calc file that I could not save Expected Results: I can work for a while but a crash occurs after few minutes. Reproducible: Always User Profile Reset: No Additional Info: I insist on the randomness of the program's lockdown. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - sw/uiconfig
sw/uiconfig/swriter/ui/mmcreatingdialog.ui |1 + 1 file changed, 1 insertion(+) New commits: commit 4c75fe312fd15dfe0556c6342586edae4ca5015d Author: Michael Weghorn AuthorDate: Wed May 27 10:15:23 2020 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Mon Jun 1 17:46:34 2020 +0200 tdf#133426 Make mail merge progress dialog modal This prevents doing things like trying to start another mail merge for the same doc in parallel, thus crashing LibreOffice. Change-Id: I5df2e804d97e82a4f0e297cb6d3396652882 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94933 Tested-by: Jenkins Reviewed-by: Michael Weghorn (cherry picked from commit 77140de3fe925f75620e94dbd848b1c925935fb5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95247 Reviewed-by: Adolfo Jayme Barrientos diff --git a/sw/uiconfig/swriter/ui/mmcreatingdialog.ui b/sw/uiconfig/swriter/ui/mmcreatingdialog.ui index c7c787c37c13..3af13d32de04 100644 --- a/sw/uiconfig/swriter/ui/mmcreatingdialog.ui +++ b/sw/uiconfig/swriter/ui/mmcreatingdialog.ui @@ -5,6 +5,7 @@ False 6 Mail Merge +True dialog ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 133268] Colibre’s color palette is faint and fails WCAG contrast guidelines
https://bugs.documentfoundation.org/show_bug.cgi?id=133268 --- Comment #8 from Commit Notification --- Rizal Muttaqin committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/d763b8e9ef52ca416f0cd4a3dd56bb277e2e5999 Resolves tdf#133268: Update Colibre color palette It will be available in 7.0.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133268] Colibre’s color palette is faint and fails WCAG contrast guidelines
https://bugs.documentfoundation.org/show_bug.cgi?id=133268 Commit Notification changed: What|Removed |Added Whiteboard|target:7.1.0|target:7.1.0 target:7.0.0.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133586] Text file appears incorrectly compared to Notepad
https://bugs.documentfoundation.org/show_bug.cgi?id=133586 syeda.a...@d2l.com changed: What|Removed |Added Summary|Text file appear|Text file appears |incorrectly compared to |incorrectly compared to |Notepad |Notepad -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133586] Text file appear incorrectly compared to Notepad
https://bugs.documentfoundation.org/show_bug.cgi?id=133586 --- Comment #1 from syeda.a...@d2l.com --- Created attachment 161496 --> https://bugs.documentfoundation.org/attachment.cgi?id=161496=edit Incorrect txt file view -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133586] New: Text file appear incorrectly compared to Notepad
https://bugs.documentfoundation.org/show_bug.cgi?id=133586 Bug ID: 133586 Summary: Text file appear incorrectly compared to Notepad Product: LibreOffice Version: 6.3.4.1 rc Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: syeda.a...@d2l.com Description: Text file appears incorrectly in LO compared to Notepad. Steps to Reproduce: 1.Open the attached file in LO and also in Notepad. 2.Notice strikethrough and underlines. Actual Results: Text file view should be same as in the Notepad. Expected Results: Lines have strikethrough and underlines. Reproducible: Always User Profile Reset: No Additional Info: none -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131990] Macros: thisComponent.getCurrentController.getViewCursor.goUp() never returns false
https://bugs.documentfoundation.org/show_bug.cgi?id=131990 --- Comment #4 from Eltomito --- I'd hate this bug to stay in the official 7.0. Could someone raise its importance to major or critical, please? I mean, it's probably going to break all macros that move the cursor between lines, which I think is pretty serious. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 510b2ec6b35678e543722f3778b783f9e6c8466e Author: Steve Fanning AuthorDate: Mon Jun 1 17:38:54 2020 +0200 Commit: Gerrit Code Review CommitDate: Mon Jun 1 17:38:54 2020 +0200 Update git submodules * Update helpcontent2 from branch 'master' to e10bfae45bc138b0c2351a7cb6bd3cc591bea388 - (ful_func.xhp) Update common defintions for lengthy argument lists, to contain more white space and give greater consistency across Calc functions. Change-Id: I053486715c5cb8f0687b6b02c218e470db163b8d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/95249 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index a85505fe14d6..e10bfae45bc1 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit a85505fe14d6f677e10e1b1d08ca28ccac0d126c +Subproject commit e10bfae45bc138b0c2351a7cb6bd3cc591bea388 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/scalc/01/ful_func.xhp | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) New commits: commit e10bfae45bc138b0c2351a7cb6bd3cc591bea388 Author: Steve Fanning AuthorDate: Mon Jun 1 17:17:05 2020 +0200 Commit: Olivier Hallot CommitDate: Mon Jun 1 17:38:54 2020 +0200 (ful_func.xhp) Update common defintions for lengthy argument lists, to contain more white space and give greater consistency across Calc functions. Change-Id: I053486715c5cb8f0687b6b02c218e470db163b8d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/95249 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/scalc/01/ful_func.xhp b/source/text/scalc/01/ful_func.xhp index 642a2bf00..d53e5fd81 100644 --- a/source/text/scalc/01/ful_func.xhp +++ b/source/text/scalc/01/ful_func.xhp @@ -46,33 +46,33 @@ The result is presented in the string format and has the character "i" or "j" as an imaginary unit. 255 arguments -String 1[; String 2][; … ;[String 255]] +String 1 [; String 2 [; … [; String 255]]] -String 1[; String 2][; … ;[String 255]] are strings, references to cells or to cell ranges of strings. +String 1, String 2, … , String 255 are strings, references to cells or to cell ranges of strings. -Integer 1[; Integer 2][; … ;[Integer 255]] +Integer 1 [; Integer 2 [; … [; Integer 255]]] -Integer 1[; Integer 2][; … ;[Integer 255]] are integers, references to cells or to cell ranges of integers. +Integer 1, Integer 2, … , Integer 255 are integers, references to cells or to cell ranges of integers. -Number 1[; Number 2][; … ;[Number 254]] +Number 1 [; Number 2 [; … [; Number 254]]] -Number 1[; Number 2][; … ;[Number 254]] are numbers, references to cells or to cell ranges of numbers. +Number 1, Number 2, … , Number 254 are numbers, references to cells or to cell ranges of numbers. -Number 1[; Number 2][; … ;[Number 255]] +Number 1 [; Number 2 [; … [; Number 255]]] -Number 1[; Number 2][; … ;[Number 255]] are numbers, references to cells or to cell ranges of numbers. +Number 1, Number 2, … , Number 255 are numbers, references to cells or to cell ranges of numbers. -Logical 1[; Logical 2][; … ;[Logical 255]] +Logical 1 [; Logical 2 [; … [; Logical 255]]] -Logical 1[; Logical 2][; … ;[Logical 255]] are boolean values, references to cells or to cell ranges of logical values. +Logical 1, Logical 2, … , Logical 255 are boolean values, references to cells or to cell ranges of logical values. -Complex 1[; Complex 2][; … ;[Complex 255]] +Complex 1 [; Complex 2 [; … [; Complex 255]]] -Complex 1[; Complex 2][; … ;[Complex 255]] are complex numbers, references to cells or to cell ranges of complex numbers. Complex numbers are entered in the form "x+yi" or "x+yj". +Complex 1, Complex 2, … ,Complex 255 are complex numbers, references to cells or to cell ranges of complex numbers. Complex numbers are entered in the form "x+yi" or "x+yj". -Reference 1[; Reference 2][; … ;[Reference 255]] +Reference 1 [; Reference 2 [; … [; Reference 255]]] -Reference 1[; Reference 2][; … ;[Reference 255]] are references to cells. +Reference 1, Reference 2, … ,Reference 255 are references to cells. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 7ad54672c38127cf4e84c210714ef0a206426480 Author: Olivier Hallot AuthorDate: Mon Jun 1 12:38:21 2020 -0300 Commit: Gerrit Code Review CommitDate: Mon Jun 1 17:38:21 2020 +0200 Update git submodules * Update helpcontent2 from branch 'master' to a85505fe14d6f677e10e1b1d08ca28ccac0d126c - Correct argument separation character in CEILING Change-Id: Iac4caaba8c04232726529a201576a20f29b1a14f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/95296 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 79dfc48af63b..a85505fe14d6 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 79dfc48af63b0834aee096c65f92f1bc96fc1b6c +Subproject commit a85505fe14d6f677e10e1b1d08ca28ccac0d126c ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/scalc/01/func_ceiling.xhp | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) New commits: commit a85505fe14d6f677e10e1b1d08ca28ccac0d126c Author: Olivier Hallot AuthorDate: Mon Jun 1 11:32:10 2020 -0300 Commit: Olivier Hallot CommitDate: Mon Jun 1 17:38:21 2020 +0200 Correct argument separation character in CEILING Change-Id: Iac4caaba8c04232726529a201576a20f29b1a14f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/95296 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/scalc/01/func_ceiling.xhp b/source/text/scalc/01/func_ceiling.xhp index 858fb4881..97f831e8e 100644 --- a/source/text/scalc/01/func_ceiling.xhp +++ b/source/text/scalc/01/func_ceiling.xhp @@ -28,7 +28,7 @@ For a positive number and a positive significance value, the function rounds up (away from zero). For a negative number and a negative significance value, the direction of rounding is determined by the value of a mode parameter. The function returns an error if the number and significance values have opposite signs. If the spreadsheet is exported to Microsoft Excel, the CEILING function is exported as the equivalent CEILING.MATH function that has existed since Excel 2013. If you plan to use the spreadsheet with earlier Excel versions, use either CEILING.PRECISE that has existed since Excel 2010, or CEILING.XCL that is exported as the CEILING function compatible with all Excel versions. -CEILING(Number[; Significance[; Mode]]) +CEILING(Number [; Significance [; Mode]]) Number is the number that is to be rounded, or a reference to a cell containing the number. @@ -36,10 +36,10 @@ Mode (optional) is a number, or a reference to a cell containing a number. The function only uses Mode if both Number and Significance are negative. Then if Mode is given and not equal to zero, numbers are rounded down (away from zero); if Mode is equal to zero or not given, negative numbers are rounded up (towards zero). =CEILING(3.45) returns 4. -=CEILING(3.45, 3) returns 6. +=CEILING(3.45; 3) returns 6. =CEILING(-1.234) returns -1. -=CEILING(-45.67, -2, 0) returns -44. -=CEILING(-45.67, -2, 1) returns -46. +=CEILING(-45.67; -2; 0) returns -44. +=CEILING(-45.67; -2; 1) returns -46. see also FLOOR, EVEN, ODD, MROUND, INT, TRUNC, ROUND, ROUNDDOWN, ROUNDUP @@ -56,12 +56,12 @@ This function calculates identical results to the ISO.CEILING function. -CEILING.PRECISE(Number[; Significance]) +CEILING.PRECISE(Number [; Significance]) Significance (optional) is the value, or a reference to a cell containing the value, to whose multiple Number is to be rounded. It defaults to 1. =CEILING.PRECISE(3.45) returns 4. -=CEILING.PRECISE(-45.67,2) returns -44. +=CEILING.PRECISE(-45.67; 2) returns -44. see also FLOOR, EVEN, ODD, MROUND, INT, TRUNC, ROUND, ROUNDDOWN, ROUNDUP @@ -74,18 +74,18 @@ Rounds a number to the nearest multiple of a significance value. For a positive number the function rounds up (away from zero). For a negative number, the direction of rounding is determined by the value of a mode parameter. The sign of the significance value is ignored. - This function exists for interoperability with Microsoft Excel 2013 or newer. + This function exists for interoperability with Microsoft Excel 2013 or newer. -CEILING.MATH(Number[; Significance[; Mode]]) +CEILING.MATH(Number [; Significance [; Mode]]) Significance (optional) is the value, or a reference to a cell containing the value, to whose multiple Number is to be rounded. It defaults to 1. Mode (optional) is a number, or a reference to a cell containing a number. If Mode is given and not equal to zero, a negative Number is rounded down (away from zero). If Mode is equal to zero or is not given, a negative Number is rounded up (towards zero). =CEILING.MATH(3.45) returns 4. -=CEILING.MATH(3.45,-3) returns 6. +=CEILING.MATH(3.45; -3) returns 6. =CEILING.MATH(-1.234) returns -1. -=CEILING.MATH(-45.67,-2,0) returns -44. -=CEILING.MATH(-45.67,+2, 1) returns -46. +=CEILING.MATH(-45.67; -2; 0) returns -44. +=CEILING.MATH(-45.67; +2; 1) returns -46. @@ -103,8 +103,8 @@ Significance is the value, or a reference to a cell containing the value, to whose multiple Number is to be rounded. =CEILING.XCL(3.45,2) returns 4. -=CEILING.XCL(-45.67,2) returns -44. -=CEILING.XCL(-45.67,-2) returns -46. +=CEILING.XCL(-45.67; 2) returns -44. +
[Libreoffice-commits] online.git: loleaflet/package.json
loleaflet/package.json |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d4fcf7c537e54a5ef299ce7bef16b129546f1d30 Author: gokaysatir AuthorDate: Mon Jun 1 11:47:12 2020 +0300 Commit: Henry Castro CommitDate: Mon Jun 1 17:28:48 2020 +0200 update uglify-css package. Change-Id: If6c173393cf49d283db646d72f8770d0b2600ed7 Reviewed-on: https://gerrit.libreoffice.org/c/online/+/95262 Tested-by: Jenkins CollaboraOffice Tested-by: Jenkins Reviewed-by: Henry Castro diff --git a/loleaflet/package.json b/loleaflet/package.json index 0d41c6091..40bf92609 100644 --- a/loleaflet/package.json +++ b/loleaflet/package.json @@ -21,7 +21,7 @@ "shrinkpack": "1.0.0-alpha", "smartmenus": "1.0.0", "uglify-js": "3.9.4", -"uglifycss": "0.0.27", +"uglifycss": "0.0.29", "uglifyify": "3.0.2", "vex-js": "4.1.0" }, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 108335] HELP: Add informations about the option "hide whitespace"
https://bugs.documentfoundation.org/show_bug.cgi?id=108335 Dieter changed: What|Removed |Added Status|RESOLVED|VERIFIED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/js loleaflet/package.json
loleaflet/js/l10n.js |2 +-
loleaflet/package.json |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit ee098941a82a8bca8d90af0e663f6c2ec880d54b
Author: gokaysatir
AuthorDate: Mon Jun 1 11:21:23 2020 +0300
Commit: Henry Castro
CommitDate: Mon Jun 1 17:16:13 2020 +0200
update uglify-js package.
Change-Id: Ic1298127d186a094e81ffc58a9ed35f82948cb1f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/95267
Tested-by: Jenkins CollaboraOffice
Tested-by: Jenkins
Reviewed-by: Henry Castro
diff --git a/loleaflet/js/l10n.js b/loleaflet/js/l10n.js
index 4beab6e7a..b8706298f 100644
--- a/loleaflet/js/l10n.js
+++ b/loleaflet/js/l10n.js
@@ -130,7 +130,7 @@ var
return Function.prototype[$to_locale_string].apply(String_ctr,
arguments);
}
, loadFromDisk = String_ctr[$to_locale_string] = function (uri) {
-const fs = require('fs');
+var fs = require('fs');
var read = fs.readFileSync(uri, 'utf8');
return JSON.parse(read);
}
diff --git a/loleaflet/package.json b/loleaflet/package.json
index c8fbbf9e0..0d41c6091 100644
--- a/loleaflet/package.json
+++ b/loleaflet/package.json
@@ -20,7 +20,7 @@
"select2": "4.0.13",
"shrinkpack": "1.0.0-alpha",
"smartmenus": "1.0.0",
-"uglify-js": "2.4.24",
+"uglify-js": "3.9.4",
"uglifycss": "0.0.27",
"uglifyify": "3.0.2",
"vex-js": "4.1.0"
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 133585] New: Sound to verify document has been saved
https://bugs.documentfoundation.org/show_bug.cgi?id=133585 Bug ID: 133585 Summary: Sound to verify document has been saved Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: n...@pendrich.scot Hello. I haven't used bugzilla before so sorry if I'm not doing this in the conventional way. I just posted a question on the libreoffice forum and was advised to post a request here. Here's what I said on the forum: I moved over completely to Linux about 2 months ago and switched all the office documents over to Libre Office ODT and ODS formats (a huge job - lots of mail merge documents to rebuild from scratch). Everything is working great but one thing I miss that I had with word was a sound that plays every time I hit ctrl + s. I've looked through the LO options but haven't found a setting to enable. If this is not possible in Libreoffice is it something you would consider implementing? Many thanks. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133499] line dash with svg:stroke-linecap="square" is rendered as solid line
https://bugs.documentfoundation.org/show_bug.cgi?id=133499 --- Comment #10 from V Stuart Foote --- Version: 7.1.0.0.alpha0+ (x64) Build ID: a0c90f1bccd9b5a349d3199746facab549f27dba CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded Using 'Expert Configuration' dialog to toggle the controls into the user registry, edits there show the true stanza to be the problem with default GDI, OpenGL and Skia rendering. Toggling it 'false' disrupts dashes on line 5 & 6 comment 6 Issues of dash line length with Skia on zoom-in is no longer present. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133278] Export as ODF doesn't work on iOS
https://bugs.documentfoundation.org/show_bug.cgi?id=133278 --- Comment #4 from Commit Notification --- Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/online/commit/2bd05d68f790b3ca278d39da8f6b062666df8cf9 tdf#133278: Don't overwrite the copy of the document that we are editing -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133278] Export as ODF doesn't work on iOS
https://bugs.documentfoundation.org/show_bug.cgi?id=133278 Commit Notification changed: What|Removed |Added Whiteboard||target:7.1.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: ios/Mobile
ios/Mobile/DocumentViewController.mm | 26 +-
1 file changed, 17 insertions(+), 9 deletions(-)
New commits:
commit 2bd05d68f790b3ca278d39da8f6b062666df8cf9
Author: Tor Lillqvist
AuthorDate: Mon Jun 1 16:54:36 2020 +0300
Commit: Tor Lillqvist
CommitDate: Mon Jun 1 17:08:38 2020 +0200
tdf#133278: Don't overwrite the copy of the document that we are editing
When exporting a copy, let core write the copy to a temp subdirectory
before invoking UIDocumentPickerViewController to select where to
store it permanently.
Change-Id: I3d2292414a3c824515ba6d98ad09b296e543cea9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/95295
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Tor Lillqvist
diff --git a/ios/Mobile/DocumentViewController.mm
b/ios/Mobile/DocumentViewController.mm
index 54932be3f..c94161c02 100644
--- a/ios/Mobile/DocumentViewController.mm
+++ b/ios/Mobile/DocumentViewController.mm
@@ -16,6 +16,7 @@
#import
#import
+#import
#import "ios.h"
#import "FakeSocket.hpp"
@@ -465,8 +466,13 @@ static IMP standardImpOfInputAccessoryView = nil;
// First save it in the requested format to a temporary
location. First remove any
// leftover identically named temporary file.
+NSURL *tmpFileDirectory = [[NSFileManager.defaultManager
temporaryDirectory] URLByAppendingPathComponent:@"export"];
+if (![NSFileManager.defaultManager
createDirectoryAtURL:tmpFileDirectory withIntermediateDirectories:YES
attributes:nil error:nil]) {
+LOG_ERR("Could not create directory " <<
[[tmpFileDirectory path] UTF8String]);
+return;
+}
NSString *tmpFileName = [[[self.document->copyFileURL
lastPathComponent] stringByDeletingPathExtension] stringByAppendingString:[@"."
stringByAppendingString:format]];
-downloadAsTmpURL = [[NSFileManager.defaultManager
temporaryDirectory] URLByAppendingPathComponent:tmpFileName];
+downloadAsTmpURL = [tmpFileDirectory
URLByAppendingPathComponent:tmpFileName];
std::remove([[downloadAsTmpURL path] UTF8String]);
@@ -479,15 +485,15 @@ static IMP standardImpOfInputAccessoryView = nil;
struct stat statBuf;
if (stat([[downloadAsTmpURL path] UTF8String], ) ==
-1) {
LOG_ERR("Could apparently not save to '" <<
[[downloadAsTmpURL path] UTF8String] << "'");
-} else {
-UIDocumentPickerViewController *picker =
-[[UIDocumentPickerViewController alloc]
initWithURL:downloadAsTmpURL
-
inMode:UIDocumentPickerModeExportToService];
-picker.delegate = self;
-[self presentViewController:picker
- animated:YES
- completion:nil];
+return;
}
+UIDocumentPickerViewController *picker =
+[[UIDocumentPickerViewController alloc]
initWithURL:downloadAsTmpURL
+
inMode:UIDocumentPickerModeExportToService];
+picker.delegate = self;
+[self presentViewController:picker
+ animated:YES
+ completion:nil];
return;
}
}
@@ -504,10 +510,12 @@ static IMP standardImpOfInputAccessoryView = nil;
- (void)documentPicker:(UIDocumentPickerViewController *)controller
didPickDocumentsAtURLs:(NSArray *)urls {
std::remove([[downloadAsTmpURL path] UTF8String]);
+std::remove([[[downloadAsTmpURL URLByDeletingLastPathComponent] path]
UTF8String]);
}
- (void)documentPickerWasCancelled:(UIDocumentPickerViewController
*)controller {
std::remove([[downloadAsTmpURL path] UTF8String]);
+std::remove([[[downloadAsTmpURL URLByDeletingLastPathComponent] path]
UTF8String]);
}
- (void)scrollViewWillBeginZooming:(UIScrollView *)scrollView withView:(UIView
*)view {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 133439] FIND & REPLACE DIALOG: Improve find and replace for character attributes
https://bugs.documentfoundation.org/show_bug.cgi?id=133439 Dieter changed: What|Removed |Added Summary|Character styles break Find |FIND & REPLACE DIALOG: |and replace using |Improve find and replace |attributes Font+size|for character attributes CC||dgp-m...@gmx.de OS|Linux (All) |All Blocks||113136 Keywords||needsUXEval Severity|normal |enhancement --- Comment #10 from Dieter --- (In reply to Luke Kendall from comment #9) > "But not allowing to search for styles is also bad. My preferred solution > thus would be to separate searching for character styles (by name, not by > "bold"), and marking attribute search as "direct formatting only" for > clarity." > > I think I understand this suggestion; and it seems a good solution to me. I must admit, I haven't read the whole discussion in deatil, but in sum it seems more like an enhancement request than a bug. So let's involve design team for further input and decision cc: Design-Team Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113136 [Bug 113136] [META] Find & Replace Dialog -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113136] [META] Find & Replace Dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=113136 Dieter changed: What|Removed |Added Depends on||133439 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=133439 [Bug 133439] FIND & REPLACE DIALOG: Improve find and replace for character attributes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133584] Cannot edit an entire file after exiting read-only mode with Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=133584 --- Comment #1 from remonte...@gmail.com --- Created attachment 161495 --> https://bugs.documentfoundation.org/attachment.cgi?id=161495=edit The file with which I encounter the problems described in the bug report. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133584] New: Cannot edit an entire file after exiting read-only mode with Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=133584 Bug ID: 133584 Summary: Cannot edit an entire file after exiting read-only mode with Draw Product: LibreOffice Version: 6.3.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: remonte...@gmail.com Description: FILEOPEN, UI, EDITING When I open the attached ODG file with LibreOffice Draw (which is by default open in read-only mode) and I click on the button to edit the file (and thus exit the read-only mode), "read only" is still marked in the title bar and I can't move some segments or even delete them. Steps to Reproduce: 1. Open the attached ODG file. 2. Click "Editing the file" 3. Try to move some segments. Actual Results: I can't move most of the segments and the title bar of the LibreOffice window keeps displaying that my file is in read-only mode whereas it's not the case. Expected Results: When I click "Editing the file", the titlebar should not display "Read-only". I should be able to move the segments and edit the whole file normally. Reproducible: Always User Profile Reset: No Additional Info: I have the problem with Windows 10 and Kubuntu 19.10. I can't test more… -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133278] Export as ODF doesn't work on iOS
https://bugs.documentfoundation.org/show_bug.cgi?id=133278 --- Comment #3 from Tor Lillqvist --- Or actually, the idea does seem to work after all, there must have been some wrongly created temp subdirectory existing on my device. https://gerrit.libreoffice.org/c/online/+/95295 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124790] Mailmerge: Background image in printed address labels not visible
https://bugs.documentfoundation.org/show_bug.cgi?id=124790 Xisco Faulí changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #26 from Xisco Faulí --- Hi Timur, I do confirm https://git.libreoffice.org/core/+/539a5501e6732b5083e112e76511024c8ce9678a%5E!/ fixes this issue. Le'ts backport it to libreoffice-6-4. Thanks for bisecting it!! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133582] Tools > Options has no check boxes
https://bugs.documentfoundation.org/show_bug.cgi?id=133582 --- Comment #3 from Regina Henschel --- I the error too if Skia is disabled. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133583] Inserting new rows in a filed Calc sheet causes memory bumps of starting with +/-20 MB and more or less doubling for every row
https://bugs.documentfoundation.org/show_bug.cgi?id=133583 --- Comment #1 from Telesto --- Created attachment 161494 --> https://bugs.documentfoundation.org/attachment.cgi?id=161494=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133583] New: Inserting new rows in a filed Calc sheet causes memory bumps of starting with +/-20 MB and more or less doubling for every row
https://bugs.documentfoundation.org/show_bug.cgi?id=133583 Bug ID: 133583 Summary: Inserting new rows in a filed Calc sheet causes memory bumps of starting with +/-20 MB and more or less doubling for every row Product: LibreOffice Version: 4.0.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Inserting new rows in a filed Calc sheet causes memory bumps of starting with +/-20 MB and more or less doubling for every row Steps to Reproduce: 1. Open the attached file 2. Select row 10 and add a row 3. select row 20 and add a row 4. Select row 30 and add a row 5. Select row 30 and add a row Note first 2 or 3 rows don't cause memory bumps, as far I can tell.. Actual Results: 50-90 MB bump for every row added Expected Results: More or less table memory increase.. Reproducible: Always User Profile Reset: No Additional Info: Version: 6.4.3.2 Build ID: libreoffice-6.4.3.2-snap1 CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded and in Version 4.0.0.3 (Build ID: 7545bee9c2a0782548772a21bc84a9dcc583b89) (Linux) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/package.json
loleaflet/package.json |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c71ba8714b43f751e05d1e91bd0a366ee07eb00f Author: gokaysatir AuthorDate: Mon Jun 1 14:47:30 2020 +0300 Commit: Henry Castro CommitDate: Mon Jun 1 16:11:51 2020 +0200 update jquery-mousewheel package. Change-Id: Ib570f53cc1ca41bb8f5344562417e4490b9a04f0 Reviewed-on: https://gerrit.libreoffice.org/c/online/+/95281 Tested-by: Jenkins CollaboraOffice Tested-by: Jenkins Reviewed-by: Henry Castro diff --git a/loleaflet/package.json b/loleaflet/package.json index 5eef36ead..c8fbbf9e0 100644 --- a/loleaflet/package.json +++ b/loleaflet/package.json @@ -13,7 +13,7 @@ "hammerjs": "2.0.8", "jquery": "2.2.4", "jquery-contextmenu": "2.9.2", -"jquery-mousewheel": "3.1.3", +"jquery-mousewheel": "3.1.13", "jquery-ui": "1.10.5", "json-js": "1.1.2", "l10n-for-node": "0.0.1", ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
