[Libreoffice-commits] core.git: cui/source include/sfx2 include/vcl sfx2/source
cui/source/factory/dlgfact.cxx |9 ++---
cui/source/factory/dlgfact.hxx | 16 +---
include/sfx2/sfxdlg.hxx|2 ++
include/vcl/abstdlg.hxx| 10 --
include/vcl/weld.hxx | 12
sfx2/source/appl/appserv.cxx |2 +-
6 files changed, 6 insertions(+), 45 deletions(-)
New commits:
commit 13d788b476adb3901689282733cc2700e7934212
Author: Heiko Tietze
AuthorDate: Mon Aug 3 09:03:23 2020 +0200
Commit: Heiko Tietze
CommitDate: Sat Aug 8 07:56:12 2020 +0200
Clean-up of abstdlg
Unnecessary functions regarding the about dialog removed
Change-Id: I739a6b1383a0096ec46e2316da3c5327dafe1675
Follow-up to 39e83e2e4257c56adef13ed1dfeee013a4f45376
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99985
Reviewed-by: Heiko Tietze
Tested-by: Heiko Tietze
diff --git a/cui/source/factory/dlgfact.cxx b/cui/source/factory/dlgfact.cxx
index 35209dba8035..01925f1fdb0a 100644
--- a/cui/source/factory/dlgfact.cxx
+++ b/cui/source/factory/dlgfact.cxx
@@ -1418,11 +1418,6 @@ short SvxMacroAssignDialog::Execute()
return m_xDialog->run();
}
-short AbstractAboutDialog_Impl::Execute()
-{
-return m_xDlg->run();
-}
-
short AbstractAdditionsDialog_Impl::Execute()
{
return m_xDlg->run();
@@ -1691,10 +1686,10 @@ VclPtr
AbstractDialogFactory_Impl::CreateAdditionsDialo
#endif
}
-VclPtr
+VclPtr
AbstractDialogFactory_Impl::CreateAboutDialog(weld::Window* pParent)
{
-return VclPtr::Create(
+return VclPtr::Create(
std::make_unique(pParent));
}
diff --git a/cui/source/factory/dlgfact.hxx b/cui/source/factory/dlgfact.hxx
index 5519dba2dd72..f3306065f959 100644
--- a/cui/source/factory/dlgfact.hxx
+++ b/cui/source/factory/dlgfact.hxx
@@ -740,20 +740,6 @@ public:
virtual short Execute() override;
};
-class AboutDialog;
-class AbstractAboutDialog_Impl : public AbstractAboutDialog
-{
-protected:
-std::unique_ptr m_xDlg;
-
-public:
-explicit AbstractAboutDialog_Impl(std::unique_ptr p)
-: m_xDlg(std::move(p))
-{
-}
-virtual short Execute() override;
-};
-
class AbstractAdditionsDialog_Impl : public AbstractAdditionsDialog
{
protected:
@@ -970,7 +956,7 @@ public:
virtual VclPtr
CreateAdditionsDialog(weld::Window* pParent, const OUString&
sAdditionsTag) override;
-virtual VclPtr CreateAboutDialog(weld::Window*
pParent) override;
+virtual VclPtr CreateAboutDialog(weld::Window* pParent)
override;
virtual VclPtr CreateTipOfTheDayDialog(weld::Window*
pParent) override;
diff --git a/include/sfx2/sfxdlg.hxx b/include/sfx2/sfxdlg.hxx
index 1f9109744cd0..9bd600828f0e 100644
--- a/include/sfx2/sfxdlg.hxx
+++ b/include/sfx2/sfxdlg.hxx
@@ -144,6 +144,8 @@ public:
virtual VclPtr CreateOptionsDialog(
weld::Window* pParent, const OUString& rExtensionId ) = 0;
+virtual VclPtr CreateAboutDialog(weld::Window*
_pParent) = 0;
+
virtual VclPtr CreateTipOfTheDayDialog(weld::Window*
_pParent) = 0;
};
diff --git a/include/vcl/abstdlg.hxx b/include/vcl/abstdlg.hxx
index e5c6ec59c3e0..2a58f6af7355 100644
--- a/include/vcl/abstdlg.hxx
+++ b/include/vcl/abstdlg.hxx
@@ -125,12 +125,6 @@ protected:
virtual ~AbstractQrCodeGenDialog() override = default;
};
-class VCL_DLLPUBLIC AbstractAboutDialog : public VclAbstractDialog
-{
-protected:
-virtual ~AbstractAboutDialog() override = default;
-};
-
class VCL_DLLPUBLIC AbstractAdditionsDialog : public VclAbstractDialog
{
protected:
@@ -179,10 +173,6 @@ public:
virtual VclPtr
CreateScreenshotAnnotationDlg(
weld::Dialog& rParentDialog) = 0;
-// create about dialog
-virtual VclPtr
-CreateAboutDialog(weld::Window* pParent) = 0;
-
// create additions dialog
virtual VclPtr
CreateAdditionsDialog(weld::Window* pParent, const OUString&
sAdditionsTag) = 0;
diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index 8a796040bc78..4707d3905176 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -520,18 +520,6 @@ public:
virtual Container* weld_message_area() = 0;
};
-class VCL_DLLPUBLIC AboutDialog : virtual public Dialog
-{
-public:
-virtual void set_version(const OUString& rVersion) = 0;
-virtual void set_copyright(const OUString& rCopyright) = 0;
-virtual void set_website(const OUString& rURL) = 0;
-virtual void set_website_label(const OUString& rLabel) = 0;
-virtual OUString get_website_label() const = 0;
-virtual void set_logo(const css::uno::Reference&
rImage) = 0;
-virtual void set_background(const
css::uno::Reference& rImage) = 0;
-};
-
class VCL_DLLPUBLIC Assistant : virtual public Dialog
{
protected:
diff --git a/sfx2/source/appl/appserv.cxx b/sfx2/source/appl/appserv.cxx
index 0c843bc6b83c..68f80d7e99e3 100644
--- a/sfx2/source/appl/appserv.cxx
+++ b/sfx2/source/appl/appserv.cxx
@@ -653,7 +653,7 @@ void SfxApplication::MiscExec_Impl( SfxRequest& rReq )
[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg sdext/source sd/inc sd/source
icon-themes/colibre/sd/res/presenterscreen-Separator.png |binary
icon-themes/colibre_svg/sd/res/presenterscreen-Separator.svg |1 +
sd/inc/bitmaps.hlst |1 +
sd/source/ui/presenter/PresenterHelper.cxx |4 +++-
sdext/source/presenter/PresenterToolBar.cxx | 10 +++---
5 files changed, 12 insertions(+), 4 deletions(-)
New commits:
commit d04260e5318fad36b3a29deaf9a823052bc6bea9
Author: Srijan Bhatia
AuthorDate: Tue Aug 4 13:43:21 2020 +0530
Commit: Heiko Tietze
CommitDate: Sat Aug 8 07:55:34 2020 +0200
Presenter console new vertical separator
Change-Id: I82e30a8dd73ba91605ae839847fb6378b1d54b3e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100044
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin
diff --git a/icon-themes/colibre/sd/res/presenterscreen-Separator.png
b/icon-themes/colibre/sd/res/presenterscreen-Separator.png
new file mode 100644
index ..a7a35fa7e632
Binary files /dev/null and
b/icon-themes/colibre/sd/res/presenterscreen-Separator.png differ
diff --git a/icon-themes/colibre_svg/sd/res/presenterscreen-Separator.svg
b/icon-themes/colibre_svg/sd/res/presenterscreen-Separator.svg
new file mode 100644
index ..aa8a387ad5d3
--- /dev/null
+++ b/icon-themes/colibre_svg/sd/res/presenterscreen-Separator.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/sd/inc/bitmaps.hlst b/sd/inc/bitmaps.hlst
index 748ea562efa1..6186abcab3c1 100644
--- a/sd/inc/bitmaps.hlst
+++ b/sd/inc/bitmaps.hlst
@@ -104,6 +104,7 @@
#define BMP_PRESENTERSCREEN_BORDER_ACTIVE_LEFT
"sd/res/presenterscreen-BorderActiveLeft.png"
#define BMP_PRESENTERSCREEN_BUTTON_HELP_NORMAL
"sd/res/presenterscreen-ButtonHelpNormal.png"
#define BMP_PRESENTERSCREEN_BUTTON_EXIT_PRESENTER_NORMAL
"sd/res/presenterscreen-ButtonExitPresenterNormal.png"
+#define BMP_PRESENTERSCREEN_SEPARATOR
"sd/res/presenterscreen-Separator.png"
#define BMP_PRESENTERSCREEN_BORDER_ACTIVE_BOTTOM_CALLOUT
"sd/res/presenterscreen-BorderActiveBottomCallout.png"
#define BMP_PRESENTERSCREEN_BORDER_TOOLBAR_LEFT
"sd/res/presenterscreen-BorderToolbarLeft.png"
#define BMP_PRESENTERSCREEN_BUTTON_SLIDE_SORTER_NORMAL
"sd/res/presenterscreen-ButtonSlideSorterNormal.png"
diff --git a/sd/source/ui/presenter/PresenterHelper.cxx
b/sd/source/ui/presenter/PresenterHelper.cxx
index ec1d63e7029c..7504e914e475 100644
--- a/sd/source/ui/presenter/PresenterHelper.cxx
+++ b/sd/source/ui/presenter/PresenterHelper.cxx
@@ -380,7 +380,9 @@ Reference SAL_CALL
PresenterHelper::loadBitmap (
BMP_PRESENTERSCREEN_SCROLLBAR_THUMB_TOP_MOUSE_OVER },
{ "bitmaps/ScrollbarThumbTopNormal.png",
BMP_PRESENTERSCREEN_SCROLLBAR_THUMB_TOP_NORMAL },
-{ "bitmaps/ViewBackground.png", BMP_PRESENTERSCREEN_VIEW_BACKGROUND }
+{ "bitmaps/ViewBackground.png", BMP_PRESENTERSCREEN_VIEW_BACKGROUND },
+{ "bitmaps/Separator.png",
+ BMP_PRESENTERSCREEN_SEPARATOR }
};
OUString bmpid;
for (std::size_t i = 0; i != SAL_N_ELEMENTS(map); ++i) {
diff --git a/sdext/source/presenter/PresenterToolBar.cxx
b/sdext/source/presenter/PresenterToolBar.cxx
index ad0f36707c11..d36f42277da4 100644
--- a/sdext/source/presenter/PresenterToolBar.cxx
+++ b/sdext/source/presenter/PresenterToolBar.cxx
@@ -1953,7 +1953,7 @@ void VerticalSeparator::Paint (
awt::Rectangle aBBox (GetBoundingBox());
rendering::RenderState aRenderState(
-geometry::AffineMatrix2D(1,0,0, 0,1,0),
+geometry::AffineMatrix2D(1,0,aBBox.X, 0,1,aBBox.Y),
nullptr,
Sequence(4),
rendering::CompositeOperation::OVER);
@@ -1964,8 +1964,12 @@ void VerticalSeparator::Paint (
PresenterCanvasHelper::SetDeviceColor(aRenderState,
pFont->mnColor);
}
-rxCanvas->fillPolyPolygon(
-PresenterGeometryHelper::CreatePolygon(aBBox, rxCanvas->getDevice()),
+Reference
xBitmap(mpToolBar->GetPresenterController()->GetPresenterHelper()->loadBitmap("bitmaps/Separator.png",
rxCanvas));
+if (!xBitmap.is())
+return;
+
+rxCanvas->drawBitmap(
+xBitmap,
rViewState,
aRenderState);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 134583] FILEOPEN: Glow effect paints the document yellow
https://bugs.documentfoundation.org/show_bug.cgi?id=134583 --- Comment #12 from rygle --- Sorry, 7.0.0.3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134583] FILEOPEN: Glow effect paints the document yellow
https://bugs.documentfoundation.org/show_bug.cgi?id=134583 --- Comment #11 from rygle --- Reproduced in 7.0.0.1 Windows x64 by manually following the steps above. --- Steps to Reproduce: 1. Open Impress 2. Sidebar -> Gallery 3. Shapes folder -> Vertical Scroll -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135548] New: EDITING: cosmetic glitch when edit a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=135548 Bug ID: 135548 Summary: EDITING: cosmetic glitch when edit a cell Product: LibreOffice Version: 7.0.0.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: news.dist...@quantentunnel.de Description: When edit a cell the old value is displayed and the new entered number at the same time during edit. When press Enter the cell is displayed correct. This happen also when I enter a formula. The colored frame around the cell is displayed when I change the cell and finally all cells on the way to the wanted cell are marked with a colored frame. This happen till I finish to enter the formula and press enter. Then all colored frames are gone. Before I used the version 6.4.5 release without that issue Steps to Reproduce: 1. Go to a cell and press F2 2. Enter a new value and you can see this 3. Press Enter 1. Go to a cell and press F2 2. Move with the cursor keys to another cell and press + (all cells on the way are framed colored and not just the current selected one) 3. Move with the cursor keys to another cell and press enter (all cells on the way are also framed colored and not just the current selected one) 4. press Enter and everything is okay again. 5. When now press F2 again, the correct cells are colored framed Actual Results: Everything is okay again. The bug happen only during edit. Expected Results: Display the values correct and highlight only the needed cells like before Reproducible: Always User Profile Reset: No Additional Info: Version: 7.0.0.3 (x64) Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e CPU-Threads: 4; BS: Windows 10.0 Build 18363; UI-Render: Skia/Vulkan; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135547] Add Open Color Tools .oco color palettes support
https://bugs.documentfoundation.org/show_bug.cgi?id=135547 Volga changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=84 ||002 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135547] New: Add Open Color Tools .oco color palettes support
https://bugs.documentfoundation.org/show_bug.cgi?id=135547 Bug ID: 135547 Summary: Add Open Color Tools .oco color palettes support Product: LibreOffice Version: 7.1.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: shanshandehongx...@outlook.com Description: Open Color Tools is a collection of tools that produces an open file format to describe color palettes with sematics and context, the color palettes uses .oco file name extension. Resources and informations available at: http://opencolor.tools/index.html https://github.com/opencolor-tools Steps to Reproduce: - Actual Results: - Expected Results: - Reproducible: Always User Profile Reset: No Additional Info: - -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134749] button background color changes to black in libreoffice calc
https://bugs.documentfoundation.org/show_bug.cgi?id=134749 --- Comment #4 from Andrej --- After switching off the hardware acceleration, the error began to appear much less frequently (the error appeared a week after switching off the acceleration) and in fewer buttons began to change color. As soon as I turned the hardware acceleration back on, many buttons changed color. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134724] UI - Find in Calc fails when a formula refers to a cell in another sheet's pivot table
https://bugs.documentfoundation.org/show_bug.cgi?id=134724 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135118] Invisible image on wrong page after deleting an image and hiding changes
https://bugs.documentfoundation.org/show_bug.cgi?id=135118 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135117] File opening with lots of images/tracking changed enabled slower
https://bugs.documentfoundation.org/show_bug.cgi?id=135117 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135112] Cell with default font, 8pt font size, 0.88cm width, containing a 6 is displayed as II with zoom level 120%
https://bugs.documentfoundation.org/show_bug.cgi?id=135112 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135105] In Linux (Mint) two LibreOffice entries are created
https://bugs.documentfoundation.org/show_bug.cgi?id=135105 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135113] Tip-Of-The-Day which appears upon opening LibreOfficeis not selectable
https://bugs.documentfoundation.org/show_bug.cgi?id=135113 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135100] PASTE RTF: Images disappearing when pasting from DOCX (fine with ODT)
https://bugs.documentfoundation.org/show_bug.cgi?id=135100 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135101] Unknown characters appear in the navigation panel on top of the actual heading characters written in Persian(farsi)
https://bugs.documentfoundation.org/show_bug.cgi?id=135101 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135109] end of line blinking cursor placement
https://bugs.documentfoundation.org/show_bug.cgi?id=135109 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135526] EDITING - Unable to change height or Y position of objects in Base reports
https://bugs.documentfoundation.org/show_bug.cgi?id=135526 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135108] Err:540 is unjustified and persistent
https://bugs.documentfoundation.org/show_bug.cgi?id=135108 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135116] Undo accept tracking changes takes +/- 2 minutes to respond
https://bugs.documentfoundation.org/show_bug.cgi?id=135116 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135111] Reject all needs to be pressed twice to reject everything
https://bugs.documentfoundation.org/show_bug.cgi?id=135111 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135114] crash when cursor moves off dialog box or collapsing dropdown strands cursor outside dialog box
https://bugs.documentfoundation.org/show_bug.cgi?id=135114 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135091] FILESAVE DOCX: Overlapping images on file open
https://bugs.documentfoundation.org/show_bug.cgi?id=135091 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135010] Memory usage opening and scrolling a DOCX increased from 600 to 1250 MB; still 360 MB in use after close
https://bugs.documentfoundation.org/show_bug.cgi?id=135010 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135087] Text to column - In "fixed width" mode - missing column width handler
https://bugs.documentfoundation.org/show_bug.cgi?id=135087 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135090] Locale not set properly?
https://bugs.documentfoundation.org/show_bug.cgi?id=135090 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107901] Format Cells dialog overwrites user selection
https://bugs.documentfoundation.org/show_bug.cgi?id=107901 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135097] DOCX: Delete the image caption frame doesn't delete the image
https://bugs.documentfoundation.org/show_bug.cgi?id=135097 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135099] FILESAVE RTF: Track changes for image frames lost
https://bugs.documentfoundation.org/show_bug.cgi?id=135099 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59284] [META] Cell border related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=59284 Bug 59284 depends on bug 107901, which changed state. Bug 107901 Summary: Format Cells dialog overwrites user selection https://bugs.documentfoundation.org/show_bug.cgi?id=107901 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108681] [META] Cell formatting/style dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108681 Bug 108681 depends on bug 107901, which changed state. Bug 107901 Summary: Format Cells dialog overwrites user selection https://bugs.documentfoundation.org/show_bug.cgi?id=107901 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135503] Vorschlag zur Änderung beim Steuerelement "Schaltfläche"
https://bugs.documentfoundation.org/show_bug.cgi?id=135503 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129901] Error when trying to run Macros
https://bugs.documentfoundation.org/show_bug.cgi?id=129901 --- Comment #3 from QA Administrators --- Dear depotke, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135086] Cell containing unwanted hyperlink cannot be edited
https://bugs.documentfoundation.org/show_bug.cgi?id=135086 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130534] Print error in LibreOffice Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=130534 --- Comment #2 from QA Administrators --- Dear Mark Rosenberger, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107901] Format Cells dialog overwrites user selection
https://bugs.documentfoundation.org/show_bug.cgi?id=107901 --- Comment #15 from QA Administrators --- Dear Kevin, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129901] Error when trying to run Macros
https://bugs.documentfoundation.org/show_bug.cgi?id=129901 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135503] Vorschlag zur Änderung beim Steuerelement "Schaltfläche"
https://bugs.documentfoundation.org/show_bug.cgi?id=135503 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135540] TABLEIMPORT CALC: Format of the header of a table is copied while importing data to the content of all rows
https://bugs.documentfoundation.org/show_bug.cgi?id=135540 Pulkit Krishna changed: What|Removed |Added OS|Linux (All) |All Version|unspecified |6.1.0.3 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135540] TABLEIMPORT CALC: Format of the header of a table is copied while importing data to the content of all rows
https://bugs.documentfoundation.org/show_bug.cgi?id=135540 --- Comment #2 from Pulkit Krishna --- Confirm bug in Windows 10 Version: 7.0.0.2 (x64) Build ID: c01aa64b6c3d89ebe5fe69c28c7adb24eb85249c CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
LO7 rejects Oracle Java 14.0.1 as defective
Have had a working and regularly upgraded LO6.x for quite a while now using Oracle Java 12 and now 14.0.1 (MacOS Catalina) Today I tried to move to LO7.0.0 and BOINNNGG I have received the dreaded message... This says that my installed java is DEFECTIVE and I should install a working version. Of course, my java installation is working JUST FINE and has been functional with OpenOffice and Zotero. So, there is obviously something that was tweaked in LO7 that does not like Oracle java 14.0.1. What might that be, and where might one find the issue documented? -- "There are more things in heaven and earth, Horatio, Than are dreamt of in your philosophy. " smime.p7s Description: S/MIME Cryptographic Signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 135467] EDITTING FUNCTIONS RANDBETWEEN.NV
https://bugs.documentfoundation.org/show_bug.cgi?id=135467 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #3 from m.a.riosv --- Reproducible. Version: 7.1.0.0.alpha0+ (x64) Build ID: CPU threads: 4; OS: Windows 10.0 Build 20180; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US, Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'private/quwex/gsoc-box2d-experimental' - 4 commits - animations/source include/xmloff offapi/com offapi/UnoApi_offapi.mk officecfg/registry sd/xml slideshow/Lib
Rebased ref, commits from common ancestor:
commit 215dd4b85dd6c5afa52af313481543a7a0ecad4d
Author: Sarper Akdemir
AuthorDate: Thu Aug 6 10:32:55 2020 +0300
Commit: Sarper Akdemir
CommitDate: Sat Aug 8 03:40:53 2020 +0300
make physics based animation effects always processed last
Change-Id: I92d436aced6ef3ee2c8b0bf0167c1f7e642ba3b5
diff --git a/slideshow/source/engine/activitiesqueue.cxx
b/slideshow/source/engine/activitiesqueue.cxx
index ba982385356e..38e79d1e5677 100644
--- a/slideshow/source/engine/activitiesqueue.cxx
+++ b/slideshow/source/engine/activitiesqueue.cxx
@@ -50,6 +50,8 @@ namespace slideshow::internal
{
for( const auto& pActivity : maCurrentActivitiesWaiting )
pActivity->dispose();
+for( const auto& pActivity :
maCurrentActivitiesToBeProcessedLast )
+pActivity->dispose();
for( const auto& pActivity : maCurrentActivitiesReinsert )
pActivity->dispose();
}
@@ -59,7 +61,7 @@ namespace slideshow::internal
}
}
-bool ActivitiesQueue::addActivity( const ActivitySharedPtr& pActivity )
+bool ActivitiesQueue::addActivity( const ActivitySharedPtr& pActivity,
const bool bProcessLast )
{
OSL_ENSURE( pActivity, "ActivitiesQueue::addActivity: activity ptr
NULL" );
@@ -67,7 +69,17 @@ namespace slideshow::internal
return false;
// add entry to waiting list
-maCurrentActivitiesWaiting.push_back( pActivity );
+if( !bProcessLast )
+{
+maCurrentActivitiesWaiting.push_back( pActivity );
+}
+else
+{
+// Activities that should be processed last is kept in a
different
+// ActivityQueue, and later added to the end of the
maCurrentActivitiesWaiting
+// at the start of ActivitiesQueue::process()
+maCurrentActivitiesToBeProcessedLast.push_back( pActivity );
+}
return true;
}
@@ -76,6 +88,12 @@ namespace slideshow::internal
{
SAL_INFO("slideshow.verbose", "ActivitiesQueue: outer loop
heartbeat" );
+// If there are activities to be processed last add them to the
end of the ActivitiesQueue
+maCurrentActivitiesWaiting.insert(
maCurrentActivitiesWaiting.end(),
+
maCurrentActivitiesToBeProcessedLast.begin(),
+
maCurrentActivitiesToBeProcessedLast.end() );
+maCurrentActivitiesToBeProcessedLast.clear();
+
// accumulate time lag for all activities, and lag time
// base if necessary:
double fLag = 0.0;
diff --git a/slideshow/source/engine/animationnodes/animationbasenode.cxx
b/slideshow/source/engine/animationnodes/animationbasenode.cxx
index 4dcb640795aa..7999b5a7654a 100644
--- a/slideshow/source/engine/animationnodes/animationbasenode.cxx
+++ b/slideshow/source/engine/animationnodes/animationbasenode.cxx
@@ -23,6 +23,7 @@
#include
#include
#include
+#include
#include "nodetools.hxx"
#include
@@ -294,7 +295,10 @@ void AnimationBaseNode::activate_st()
mpActivity->setTargets( getShape(), maAttributeLayerHolder.get() );
// add to activities queue
-getContext().mrActivitiesQueue.addActivity( mpActivity );
+if( mxAnimateNode->getType() ==
css::animations::AnimationNodeType::ANIMATEPHYSICS )
+getContext().mrActivitiesQueue.addActivity(mpActivity, true);
+else
+getContext().mrActivitiesQueue.addActivity( mpActivity );
}
else {
// Actually, DO generate the event for empty activity,
diff --git a/slideshow/source/inc/activitiesqueue.hxx
b/slideshow/source/inc/activitiesqueue.hxx
index b4f88b1b39d1..76dc981f8f65 100644
--- a/slideshow/source/inc/activitiesqueue.hxx
+++ b/slideshow/source/inc/activitiesqueue.hxx
@@ -57,7 +57,7 @@ namespace slideshow
/** Add the given activity to the queue.
*/
-bool addActivity( const ActivitySharedPtr& pActivity );
+bool addActivity( const ActivitySharedPtr& pActivity, const bool
bProcessLast = false );
/** Process the activities queue.
@@ -96,6 +96,11 @@ namespace slideshow
// await
processing for this
// round
+ActivityQueue maCurrentActivitiesToBeProcessedLast; //
activities that will be
+ //
added to the end of
+ //
maCurrentActivitiesWaiting at
+
[Libreoffice-bugs] [Bug 135482] EDITING: Data validity fails after copying sheet and deleting original sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=135482 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 --- Comment #3 from m.a.riosv --- Reproduced. Versión: 6.4.6.1 (x64) Id. de compilación: 985dd72ca280d5c6da2e9f90f7ff9286cafe7ff8 Subprocs. CPU: 4; SO: Windows 10.0 Build 20180; Repres. IU: predet.; VCL: win; Configuración regional: es-ES (es_ES); Idioma de IU: es-ES Calc: threaded But after see the @REF, going to Menu/Data/Validity [Ok] works fine again. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135514] identical formulae give different values
https://bugs.documentfoundation.org/show_bug.cgi?id=135514 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from m.a.riosv --- Seems the file was saved in a inconsistent state. Doing a hard-recalc Menu/Data/Calculate/Recalculate hard, solves the issue. What could matter is if there are steps to generate the inconsistent state. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135541] Dates are entered inconsistently, switching between day and month.
https://bugs.documentfoundation.org/show_bug.cgi?id=135541 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from m.a.riosv --- Please attach a sample file for test purposes. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135546] New: Pictures lost if cut and pasted (into Writer) from MacOS Notes
https://bugs.documentfoundation.org/show_bug.cgi?id=135546 Bug ID: 135546 Summary: Pictures lost if cut and pasted (into Writer) from MacOS Notes Product: LibreOffice Version: 7.0.0.3 release Hardware: x86-64 (AMD64) OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: steven.mcc...@gmail.com Description: After selecting and copying the contents of a 'note' from within MacOS Notes, I tried to paste the contents into a new LibreOffice Writer document. Only the text appeared and the images were lost. Steps to Reproduce: 1. Open MacOS Notes and create a new note 2. Add both text and images into the note 3. Choose "Edit | Select All" in the note 4. Choose "Edit | Copy" 5. Open LibreOffice and create a new Writer document 6. Click in the new Writer document and select "Edit | Paste" 7. The cut & pasted text appears, but the images do not Actual Results: Only the text appears after the paste operation. The text appears properly formatted and has vertical space where the images should be, however, the images are not present. Expected Results: I would expect that both the copied text and images should have appeared in the Writer document. Reproducible: Always User Profile Reset: No Additional Info: I performed the same test with MS Word for Mac version 16.34 and the text and images were both present and appeared as they did in the MacOS Notes note. Also, I mentioned above that once pasted into the Writer doc, that the text appeared and vertical space appeared where the images should have been. I also tried to select the images and while there was vertical space, it did not appear that there were any images to be selected. I'm guessing the images were lost at some point even though some vertical space was allocated for them. I am experiencing these results in MacOS Catalina. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 7657fecbceb656d7745a0ae7674a733c722343d8 Author: Johnny_M AuthorDate: Sat Aug 8 01:27:18 2020 +0200 Commit: Gerrit Code Review CommitDate: Sat Aug 8 01:27:18 2020 +0200 Update git submodules * Update helpcontent2 from branch 'master' to d94a25c58b03f7619430ec7bf66564de16600548 - tdf#132643 Translate German section IDs Change-Id: If138eff022dc58dda7c6f6f7d9bb749a0f717684 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/100341 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 7c883574c203..d94a25c58b03 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 7c883574c2036f463359dde30a976db6ff568d4e +Subproject commit d94a25c58b03f7619430ec7bf66564de16600548 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 132643] [LOCALHELP] Translate section id to English mnemonics
https://bugs.documentfoundation.org/show_bug.cgi?id=132643 --- Comment #126 from Commit Notification --- Johnny_M committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/d94a25c58b03f7619430ec7bf66564de16600548 tdf#132643 Translate German section IDs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] help.git: source/text
source/text/scalc/01/0212.xhp |2 +- source/text/scalc/01/0502.xhp |2 +- source/text/scalc/01/1203.xhp |2 +- source/text/scalc/01/1205.xhp |2 +- source/text/scalc/01/1212.xhp |2 +- source/text/scalc/01/cell_styles.xhp |2 +- source/text/schart/01/0501.xhp |2 +- source/text/schart/01/05010100.xhp |2 +- source/text/schart/01/05010200.xhp |2 +- source/text/schart/01/05020100.xhp |2 +- source/text/schart/01/05020200.xhp |2 +- source/text/schart/01/0503.xhp |2 +- source/text/schart/01/0505.xhp |2 +- source/text/schart/01/05050100.xhp |2 +- source/text/schart/01/0506.xhp |2 +- source/text/schart/01/0507.xhp |2 +- source/text/schart/01/0508.xhp |2 +- source/text/shared/00/0001.xhp |2 +- source/text/shared/autopi/0101.xhp |2 +- source/text/shared/autopi/0113.xhp |2 +- source/text/shared/autopi/0117.xhp |2 +- source/text/swriter/01/0407.xhp|2 +- source/text/swriter/01/0413.xhp|2 +- source/text/swriter/01/05030200.xhp|2 +- source/text/swriter/01/05030400.xhp|2 +- source/text/swriter/01/05030800.xhp|2 +- source/text/swriter/01/0504.xhp|2 +- source/text/swriter/01/0506.xhp|2 +- source/text/swriter/01/0508.xhp|2 +- source/text/swriter/01/0509.xhp|2 +- source/text/swriter/01/05130100.xhp|2 +- source/text/swriter/01/0606.xhp|2 +- source/text/swriter/01/legacynumbering.xhp |2 +- 33 files changed, 33 insertions(+), 33 deletions(-) New commits: commit d94a25c58b03f7619430ec7bf66564de16600548 Author: Johnny_M AuthorDate: Thu Aug 6 14:41:34 2020 +0200 Commit: Olivier Hallot CommitDate: Sat Aug 8 01:27:18 2020 +0200 tdf#132643 Translate German section IDs Change-Id: If138eff022dc58dda7c6f6f7d9bb749a0f717684 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/100341 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/scalc/01/0212.xhp b/source/text/scalc/01/0212.xhp index b0314c20d..99198b4de 100644 --- a/source/text/scalc/01/0212.xhp +++ b/source/text/scalc/01/0212.xhp @@ -35,6 +35,6 @@ - + \ No newline at end of file diff --git a/source/text/scalc/01/0502.xhp b/source/text/scalc/01/0502.xhp index da4e8bb76..5abb23bef 100644 --- a/source/text/scalc/01/0502.xhp +++ b/source/text/scalc/01/0502.xhp @@ -52,6 +52,6 @@ - + diff --git a/source/text/scalc/01/1203.xhp b/source/text/scalc/01/1203.xhp index 2ec45561c..e83179435 100644 --- a/source/text/scalc/01/1203.xhp +++ b/source/text/scalc/01/1203.xhp @@ -39,6 +39,6 @@ - + diff --git a/source/text/scalc/01/1205.xhp b/source/text/scalc/01/1205.xhp index 8b6ed8311..97fc06cc9 100644 --- a/source/text/scalc/01/1205.xhp +++ b/source/text/scalc/01/1205.xhp @@ -39,7 +39,7 @@ For example, you can generate a sales summary for a certain postal code based on data from a client database. - + Delete Deletes the subtotal rows in the selected area. diff --git a/source/text/scalc/01/1212.xhp b/source/text/scalc/01/1212.xhp index e101beb39..faccc6ad6 100644 --- a/source/text/scalc/01/1212.xhp +++ b/source/text/scalc/01/1212.xhp @@ -40,6 +40,6 @@ - + diff --git a/source/text/scalc/01/cell_styles.xhp b/source/text/scalc/01/cell_styles.xhp index 703de4062..8b5620e0f 100644 --- a/source/text/scalc/01/cell_styles.xhp +++ b/source/text/scalc/01/cell_styles.xhp @@ -32,7 +32,7 @@ - + diff --git a/source/text/schart/01/0501.xhp b/source/text/schart/01/0501.xhp index c0e3489d9..edd67f84c 100644 --- a/source/text/schart/01/0501.xhp +++ b/source/text/schart/01/0501.xhp @@ -56,6 +56,6 @@ - + diff --git a/source/text/schart/01/05010100.xhp b/source/text/schart/01/05010100.xhp index be7514d91..be2f8ed55 100644 --- a/source/text/schart/01/05010100.xhp +++ b/source/text/schart/01/05010100.xhp @@ -43,7 +43,7 @@ - + diff --git a/source/text/schart/01/05010200.xhp b/source/text/schart/01/05010200.xhp index 75645bd1e..5a6e688e5 100644 --- a/source/text/schart/01/05010200.xhp +++ b/source/text/schart/01/05010200.xhp @@ -40,6 +40,6 @@ Y Error Bars - + diff --git a/source/text/schart/01/05020100.xhp b/source/text/schart/01/05020100.xhp index 652ea322f..888cf0a31 100644 --- a/source/text/schart/01/05020100.xhp +++ b/source/text/schart/01/05020100.xhp @@ -46,6 +46,6 @@ - + diff --git a/source/text/schart/01/05020200.xhp b/source/text/schart/01/05020200.xhp index 3f76e1ed0..e74c4bd79 100644 ---
[Libreoffice-bugs] [Bug 135545] New: following the hyperlink to the sheet with numbers only in its name will jump to the row with the numbers, not to the sheet.
https://bugs.documentfoundation.org/show_bug.cgi?id=135545 Bug ID: 135545 Summary: following the hyperlink to the sheet with numbers only in its name will jump to the row with the numbers, not to the sheet. Product: LibreOffice Version: 7.1.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: himajin100...@gmail.com Description: see steps to reproduce. Steps to Reproduce: 1. Launch Calc 2. You have 'Sheet1' 3. Insert a sheet with a number only. In this STR, I made the new sheet with only four letters '2000' 4. Save that file as foo.ods somewhere. 5. Launch Writer 6. [Insert] - [Insert Hyperlink] from the main menu 7. from the left pane of [Hyperlink] Window, choose [Document] 8. For the [Path] under [Document], please specify the foo.ods you've created. 9. Click the button next to [Target:] 10. you will find "Sheets" treeview entry in [Target in Document] window 11. Choose the '2000' sheet, Click [Apply], and then close the window 12. Click [Apply] in [Hyperlink] window 13. follow the link inserted to the Writer document. Actual Results: What you will see is 2000th row of 'Sheet1' Expected Results: What you should see is '2000' sheet Reproducible: Always User Profile Reset: No Additional Info: Version: 7.1.0.0.alpha0+ (x64) Build ID: 703809e1c9451ecf488b8fba09ed0c72d9468bbd CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win Locale: ja-JP (ja_JP); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135535] LibreOffice crashes without installed online update
https://bugs.documentfoundation.org/show_bug.cgi?id=135535 Mike Kaganski changed: What|Removed |Added CC||yan...@gmail.com --- Comment #3 from Mike Kaganski --- *** Bug 135544 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135544] 'Online Update' option is crashing when it isn't existed
https://bugs.documentfoundation.org/show_bug.cgi?id=135544 Mike Kaganski changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Mike Kaganski --- *** This bug has been marked as a duplicate of bug 135535 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135544] New: 'Online Update' option is crashing when it isn't existed
https://bugs.documentfoundation.org/show_bug.cgi?id=135544 Bug ID: 135544 Summary: 'Online Update' option is crashing when it isn't existed Product: LibreOffice Version: 7.0.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: yan...@gmail.com Description: I always uncheck Online Update notification option during installing LibreOffice, but in this version there is even so Online Update option in Options. If you click it, it crashes. Steps to Reproduce: 1. Install LibreOffice with unchecking Online Update option 2. Open Options from Tools -> Options 3. Press Online Update Actual Results: Options dialog window crashes. Expected Results: There shouldn't be any Online Update option in Options since it wasn't installed with Online Update feature. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 7.0.0.3 (x64) Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win Locale: tr-TR (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 135501] Change the default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=135501 --- Comment #49 from John Mills --- Thank you Stuart for a reasoned response, It is relevant, because the Tabbed interface is functionally similar. If it is not why was it created? It is an approximation that uses a similar design metaphor. If you look at some of the sources that are linked to this bug request you will see that people are asking for this type of interface, or at least a choice in how they interact with LibreOffice from a UI perspective. You mention API compatibility and I am certainly not expert enough to disagree. However, there is a UI that ships in LibreOffice that many people do not know about and once informed choose to use because it is similar to the interface that greater than 90% of Office users interact with worldwide and has existed for 14 years now, once informed of the existence many believe that they are more productive than the current shipping interface and it suits their personal needs better. I think no one expects LibreOffice and Microsoft Office to be functionally and aesthetically identical. Having an interface that works similarly like Microsoft Office (tabbed) is not a sin, WPS, FreeOffice, OnlyOffice and Softmaker to only name four suites that have adopted similar user interfaces. With best regards -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 135501] Change the default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=135501 --- Comment #49 from John Mills --- Thank you Stuart for a reasoned response, It is relevant, because the Tabbed interface is functionally similar. If it is not why was it created? It is an approximation that uses a similar design metaphor. If you look at some of the sources that are linked to this bug request you will see that people are asking for this type of interface, or at least a choice in how they interact with LibreOffice from a UI perspective. You mention API compatibility and I am certainly not expert enough to disagree. However, there is a UI that ships in LibreOffice that many people do not know about and once informed choose to use because it is similar to the interface that greater than 90% of Office users interact with worldwide and has existed for 14 years now, once informed of the existence many believe that they are more productive than the current shipping interface and it suits their personal needs better. I think no one expects LibreOffice and Microsoft Office to be functionally and aesthetically identical. Having an interface that works similarly like Microsoft Office (tabbed) is not a sin, WPS, FreeOffice, OnlyOffice and Softmaker to only name four suites that have adopted similar user interfaces. With best regards -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 135501] Change the default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=135501 --- Comment #48 from V Stuart Foote --- (In reply to John Mills from comment #47) > > I assume Microsoft did spend some money on research on the acceptance of > > the ribbon or the start menu of "Windows 8'. They transition did have some > > bumps and there were some tweaks.. but the didn't go back to before. > > Microsoft spent a huge amount of time, money and effort when designing this > interface. I think you will see this if you watch a little of the design > philosophy that went in to this and the effort undertaken. It certainly > wasn't just thrown together. > And all of that is absolutely irrelevant as LibreOffice makes *no* use of the Ribbon framework API, which yes is a very rich library. In fact if anything from a UX perspective it is a very strong argument to *not* use the NB Tabbed UI as naive users expecting fully implemented API will be confused/disappointed with the functionality our Glade UI assemblages of UNO controls provide. I'd anticipate a flood of user requests for 'why doesn't it work like in MSO'... -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 135501] Change the default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=135501 --- Comment #48 from V Stuart Foote --- (In reply to John Mills from comment #47) > > I assume Microsoft did spend some money on research on the acceptance of > > the ribbon or the start menu of "Windows 8'. They transition did have some > > bumps and there were some tweaks.. but the didn't go back to before. > > Microsoft spent a huge amount of time, money and effort when designing this > interface. I think you will see this if you watch a little of the design > philosophy that went in to this and the effort undertaken. It certainly > wasn't just thrown together. > And all of that is absolutely irrelevant as LibreOffice makes *no* use of the Ribbon framework API, which yes is a very rich library. In fact if anything from a UX perspective it is a very strong argument to *not* use the NB Tabbed UI as naive users expecting fully implemented API will be confused/disappointed with the functionality our Glade UI assemblages of UNO controls provide. I'd anticipate a flood of user requests for 'why doesn't it work like in MSO'... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: chart2/source oox/source svx/source
chart2/source/view/inc/VLineProperties.hxx |2 +-
oox/source/drawingml/fillproperties.cxx|2 +-
svx/source/engine3d/view3d.cxx |2 +-
svx/source/svdraw/svdhdl.cxx |2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
New commits:
commit 255d7e562c729ed113336d635326cb84d98b8f4e
Author: Andrea Gelmini
AuthorDate: Fri Aug 7 16:21:37 2020 +0200
Commit: Julien Nabet
CommitDate: Fri Aug 7 23:08:59 2020 +0200
Fix typos
Change-Id: Ic28a1cdc779af9438555acd3bf85312e5e244fe6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100336
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/chart2/source/view/inc/VLineProperties.hxx
b/chart2/source/view/inc/VLineProperties.hxx
index 864e78316322..5fbf2e53d29f 100644
--- a/chart2/source/view/inc/VLineProperties.hxx
+++ b/chart2/source/view/inc/VLineProperties.hxx
@@ -35,7 +35,7 @@ struct VLineProperties
css::uno::Any Transparence;//type sal_Int16 for property
UNO_NAME_LINETRANSPARENCE
css::uno::Any Width;//type sal_Int32 for property UNO_NAME_LINEWIDTH
css::uno::Any DashName;//type OUString for property "LineDashName"
-css::uno::Any LineCap; //type drawing::LineCap for propertey
UNO_NAME_LINECAP
+css::uno::Any LineCap; //type drawing::LineCap for property
UNO_NAME_LINECAP
VLineProperties();
void initFromPropertySet( const css::uno::Reference<
css::beans::XPropertySet >& xProp );
diff --git a/oox/source/drawingml/fillproperties.cxx
b/oox/source/drawingml/fillproperties.cxx
index 7082cbee0186..d2485e02ddd3 100644
--- a/oox/source/drawingml/fillproperties.cxx
+++ b/oox/source/drawingml/fillproperties.cxx
@@ -528,7 +528,7 @@ void FillProperties::pushToPropMap( ShapePropertyMap&
rPropMap,
}
auto aWidestSegmentEnd = std::next(aWidestSegmentStart);
-// Try to grow the widest segment forward: if a neext
segment has the same
+// Try to grow the widest segment forward: if a next
segment has the same
// color, just different transparency, include it.
while (aWidestSegmentEnd !=
std::prev(aGradientStops.end()))
{
diff --git a/svx/source/engine3d/view3d.cxx b/svx/source/engine3d/view3d.cxx
index 78bc1dd15521..2a03587f1fe2 100644
--- a/svx/source/engine3d/view3d.cxx
+++ b/svx/source/engine3d/view3d.cxx
@@ -712,7 +712,7 @@ void E3dView::ImpCreateSingle3DObjectFlat(E3dScene* pScene,
SdrObject* pObj, boo
// line style turned off
aSet.Put(XLineStyleItem(drawing::LineStyle_NONE));
-//Determining if FILL_Attribut is set.
+//Determining if FILL_Attribute is set.
if(!pPath->IsClosed() || eFillStyle == drawing::FillStyle_NONE)
{
// This SdrPathObj is not filled, leave the front and rear face out.
diff --git a/svx/source/svdraw/svdhdl.cxx b/svx/source/svdraw/svdhdl.cxx
index bbd2926d36ab..f16f73346c1e 100644
--- a/svx/source/svdraw/svdhdl.cxx
+++ b/svx/source/svdraw/svdhdl.cxx
@@ -369,7 +369,7 @@ void SdrHdl::SetHdlList(SdrHdlList* pList)
// remember list
pHdlList = pList;
-// now its possible to create graphic representation
+// now it's possible to create graphic representation
Touch();
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: dbaccess/source forms/source include/dbaccess sc/source sdext/source
dbaccess/source/core/misc/DatabaseDataProvider.cxx |2 +-
forms/source/component/DatabaseForm.cxx|2 +-
forms/source/inc/FormComponent.hxx |4 ++--
forms/source/inc/property.hxx |6 +++---
include/dbaccess/genericcontroller.hxx |2 +-
sc/source/core/tool/rangenam.cxx |2 +-
sdext/source/pdfimport/tree/writertreevisiting.cxx |2 +-
7 files changed, 10 insertions(+), 10 deletions(-)
New commits:
commit 621580eda6361c5a9f949ad7a16691abf632e370
Author: Andrea Gelmini
AuthorDate: Fri Aug 7 16:01:34 2020 +0200
Commit: Julien Nabet
CommitDate: Fri Aug 7 23:08:45 2020 +0200
Fix typos to complete commit cfce486
See:
https: //gerrit.libreoffice.org/c/core/+/100172
Change-Id: Iefcf549f23fa27affe7b6254d82eb2fc8ecf283b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100334
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/dbaccess/source/core/misc/DatabaseDataProvider.cxx
b/dbaccess/source/core/misc/DatabaseDataProvider.cxx
index 185591d76203..b6366e4482fb 100644
--- a/dbaccess/source/core/misc/DatabaseDataProvider.cxx
+++ b/dbaccess/source/core/misc/DatabaseDataProvider.cxx
@@ -80,7 +80,7 @@ DatabaseDataProvider::DatabaseDataProvider(uno::Reference<
uno::XComponentContex
void SAL_CALL DatabaseDataProvider::disposing()
{
m_aParameterManager.dispose(); // (to free any references it may have to
me)
-m_aFilterManager.dispose(); // (dito)
+m_aFilterManager.dispose(); // (ditto)
m_xParent.clear();
m_xAggregateSet.clear();
diff --git a/forms/source/component/DatabaseForm.cxx
b/forms/source/component/DatabaseForm.cxx
index ca6681c40a23..182e3ba34760 100644
--- a/forms/source/component/DatabaseForm.cxx
+++ b/forms/source/component/DatabaseForm.cxx
@@ -1222,7 +1222,7 @@ void ODatabaseForm::disposing()
m_aErrorListeners.disposeAndClear(aEvt);
m_aParameterManager.dispose(); // To free any references it may have to
be me
-m_aFilterManager.dispose(); // (dito)
+m_aFilterManager.dispose(); // (ditto)
OFormComponents::disposing();
OPropertySetAggregationHelper::disposing();
diff --git a/forms/source/inc/FormComponent.hxx
b/forms/source/inc/FormComponent.hxx
index 09fdb0658c3b..1817c633ebe4 100644
--- a/forms/source/inc/FormComponent.hxx
+++ b/forms/source/inc/FormComponent.hxx
@@ -532,12 +532,12 @@ typedef ::cppu::ImplHelper4 < css::form::XLoadListener
typedef ::cppu::ImplHelper1 < css::form::XBoundComponent
> OBoundControlModel_COMMITTING;
-// dito
+// ditto
typedef ::cppu::ImplHelper2 < css::form::binding::XBindableValue
, css::util::XModifyListener
> OBoundControlModel_BINDING;
-// dito
+// ditto
typedef ::cppu::ImplHelper2 <
css::form::validation::XValidityConstraintListener
,
css::form::validation::XValidatableFormComponent
> OBoundControlModel_VALIDATION;
diff --git a/forms/source/inc/property.hxx b/forms/source/inc/property.hxx
index d4d3aecd2231..fa3f071d011d 100644
--- a/forms/source/inc/property.hxx
+++ b/forms/source/inc/property.hxx
@@ -193,9 +193,9 @@ namespace frm
#define PROPERTY_ID_FORMATSSUPPLIER (PROPERTY_ID_START +155)//
XNumberFormatsSupplier
#define PROPERTY_ID_TREATASNUMERIC (PROPERTY_ID_START +156)// BOOL
#define PROPERTY_ID_EFFECTIVE_VALUE (PROPERTY_ID_START +157)// ANY
(string or double)
-#define PROPERTY_ID_EFFECTIVE_DEFAULT (PROPERTY_ID_START +158)// dito
-#define PROPERTY_ID_EFFECTIVE_MIN (PROPERTY_ID_START +159)// dito
-#define PROPERTY_ID_EFFECTIVE_MAX (PROPERTY_ID_START +160)// dito
+#define PROPERTY_ID_EFFECTIVE_DEFAULT (PROPERTY_ID_START +158)// ditto
+#define PROPERTY_ID_EFFECTIVE_MIN (PROPERTY_ID_START +159)// ditto
+#define PROPERTY_ID_EFFECTIVE_MAX (PROPERTY_ID_START +160)// ditto
#define PROPERTY_ID_HIDDEN (PROPERTY_ID_START +161)// BOOL
#define PROPERTY_ID_FILTERPROPOSAL (PROPERTY_ID_START +162)// BOOL
#define PROPERTY_ID_FIELDSOURCE (PROPERTY_ID_START +163)// String
diff --git a/include/dbaccess/genericcontroller.hxx
b/include/dbaccess/genericcontroller.hxx
index c60cf9feb25c..c90ad028908e 100644
--- a/include/dbaccess/genericcontroller.hxx
+++ b/include/dbaccess/genericcontroller.hxx
@@ -242,7 +242,7 @@ namespace dbaui
css::uno::Reference< css::uno::XComponentContext >m_xContext;
ControllerFrame
m_aCurrentFrame;
css::uno::Reference< css::frame::XDispatchProvider >
m_xSlaveDispatcher; // for intercepting dispatches
-css::uno::Reference< css::frame::XDispatchProvider >
m_xMasterDispatcher;// dito
+
[Libreoffice-ux-advise] [Bug 117463] Create a Dialog that shows up on first boot of Writer/Calc/Impress for the user to pick its default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=117463 --- Comment #29 from John Mills --- Hi jan d, Just on your statement: >For me it hinges a bit on who is the target group for LO. If it is people who >are about open source software: Options and showing community efforts are >great. > But if we assume we compete more with software for office workers who > otherwise use MSO or SoftMaker or WPS… Then I would go with the UX principle > of choosing a decent default options – since most people leave it as it is. The LibreOffice Next Decade manifesto: https://www.documentfoundation.org/assets/Documents/tdf-manifesto.pdf The very first point: WE COMMIT OURSELVES: 'To eliminate the digital divide in society by giving everyone access to office productivity tools free of charge to enable them to participate as full citizens in the 21st century' I don't see any other way that other than LibreOffice is targeted at typical users of office software. No where in that manifesto can I see it saying that this is targeted at open source 'activists' first. The wonderful thing about LibreOffice and FLOSS software in particular is that is a great equalizer. From the poorest to richest the our rights are the same. The document foundation provide a fantastic Office suite that respects user freedoms and empowers them. That is critical, anything that enables this and encourages more users to break away from proprietary software should be encouraged. I think a providing a user interface similar to what > 90% of users interact with can only be a positive step, it's a great starting point. Note also the first value rejected. 'The ownership of office productivity tools by monopoly suppliers which imposes a de-facto tax on global electronic free speech and penalises the economically disadvantaged.' LibreOffice competes for the poorest users against 'pirated' versions of Microsoft Office. When a user has no inclination that something free (libre/gratis)exists that respects them they become a prisoner. It is insidious. Anyway I apologise if off topic, but I just wanted to make clear who could benefit by this decision. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 117463] Create a Dialog that shows up on first boot of Writer/Calc/Impress for the user to pick its default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=117463 --- Comment #29 from John Mills --- Hi jan d, Just on your statement: >For me it hinges a bit on who is the target group for LO. If it is people who >are about open source software: Options and showing community efforts are >great. > But if we assume we compete more with software for office workers who > otherwise use MSO or SoftMaker or WPS… Then I would go with the UX principle > of choosing a decent default options – since most people leave it as it is. The LibreOffice Next Decade manifesto: https://www.documentfoundation.org/assets/Documents/tdf-manifesto.pdf The very first point: WE COMMIT OURSELVES: 'To eliminate the digital divide in society by giving everyone access to office productivity tools free of charge to enable them to participate as full citizens in the 21st century' I don't see any other way that other than LibreOffice is targeted at typical users of office software. No where in that manifesto can I see it saying that this is targeted at open source 'activists' first. The wonderful thing about LibreOffice and FLOSS software in particular is that is a great equalizer. From the poorest to richest the our rights are the same. The document foundation provide a fantastic Office suite that respects user freedoms and empowers them. That is critical, anything that enables this and encourages more users to break away from proprietary software should be encouraged. I think a providing a user interface similar to what > 90% of users interact with can only be a positive step, it's a great starting point. Note also the first value rejected. 'The ownership of office productivity tools by monopoly suppliers which imposes a de-facto tax on global electronic free speech and penalises the economically disadvantaged.' LibreOffice competes for the poorest users against 'pirated' versions of Microsoft Office. When a user has no inclination that something free (libre/gratis)exists that respects them they become a prisoner. It is insidious. Anyway I apologise if off topic, but I just wanted to make clear who could benefit by this decision. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135501] Change the default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=135501 --- Comment #47 from John Mills --- Hi Telesto, You make some very interesting points, I just wanted to pick up on one of them regarding the 'Ribbon' interface. > I assume Microsoft did spend some money on research on the acceptance of the > ribbon or the start menu of "Windows 8'. They transition did have some bumps > and there were some tweaks.. but the didn't go back to before. Microsoft spent a huge amount of time, money and effort when designing this interface. I think you will see this if you watch a little of the design philosophy that went in to this and the effort undertaken. It certainly wasn't just thrown together. https://channel9.msdn.com/Events/MIX/MIX08/UX09 I know it is fashionable in some segments of the FLOSS community to hate on Microsoft, I understand, embrace, extend and extinguish but what people can't do is call their Office suite garbage. It isn't. There is a reason why it is used by over 90% of Office users worldwide. It is good, very good. I encourage you to spend a little time, and anyone else reading this, just to watch a little and understand some of the thought and design process that went in to Microsoft Office 2007. I understand the objections to telemetry but look in that video just how useful it can be when making decisions. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 135501] Change the default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=135501 --- Comment #47 from John Mills --- Hi Telesto, You make some very interesting points, I just wanted to pick up on one of them regarding the 'Ribbon' interface. > I assume Microsoft did spend some money on research on the acceptance of the > ribbon or the start menu of "Windows 8'. They transition did have some bumps > and there were some tweaks.. but the didn't go back to before. Microsoft spent a huge amount of time, money and effort when designing this interface. I think you will see this if you watch a little of the design philosophy that went in to this and the effort undertaken. It certainly wasn't just thrown together. https://channel9.msdn.com/Events/MIX/MIX08/UX09 I know it is fashionable in some segments of the FLOSS community to hate on Microsoft, I understand, embrace, extend and extinguish but what people can't do is call their Office suite garbage. It isn't. There is a reason why it is used by over 90% of Office users worldwide. It is good, very good. I encourage you to spend a little time, and anyone else reading this, just to watch a little and understand some of the thought and design process that went in to Microsoft Office 2007. I understand the objections to telemetry but look in that video just how useful it can be when making decisions. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: xmloff/source
xmloff/source/text/txtparai.cxx | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
New commits:
commit e17e3dd6d9c06f0dc25246a4e0fb82970d74ba39
Author: Caolán McNamara
AuthorDate: Fri Aug 7 09:43:14 2020 +0100
Commit: Caolán McNamara
CommitDate: Fri Aug 7 21:44:29 2020 +0200
cid#1465671 Unchecked return value
Change-Id: I796799f2964f70f107acc53d376379a79e044472
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100294
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/xmloff/source/text/txtparai.cxx b/xmloff/source/text/txtparai.cxx
index f957f216fc0e..54a86e01157b 100644
--- a/xmloff/source/text/txtparai.cxx
+++ b/xmloff/source/text/txtparai.cxx
@@ -1937,26 +1937,23 @@ XMLParaContext::XMLParaContext(
break;
case XML_TOK_TEXT_P_OUTLINE_CONTENT_VISIBLE:
{
-mbOutlineContentVisible = true;
-::sax::Converter::convertBool(mbOutlineContentVisible, rValue);
+bool bBool(false);
+if (::sax::Converter::convertBool(bBool, rValue))
+mbOutlineContentVisible = bBool;
}
break;
case XML_TOK_TEXT_P_IS_LIST_HEADER:
{
bool bBool(false);
-if( ::sax::Converter::convertBool( bBool, rValue ) )
-{
+if (::sax::Converter::convertBool(bBool, rValue))
bIsListHeader = bBool;
-}
}
break;
case XML_TOK_TEXT_P_RESTART_NUMBERING:
{
bool bBool(false);
if (::sax::Converter::convertBool(bBool, rValue))
-{
bIsRestart = bBool;
-}
}
break;
case XML_TOK_TEXT_P_START_VALUE:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135543] New: Writer auto spellcheck works intermittently
https://bugs.documentfoundation.org/show_bug.cgi?id=135543 Bug ID: 135543 Summary: Writer auto spellcheck works intermittently Product: LibreOffice Version: 6.3.6.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: garyf8...@gmail.com Description: I have Auto Spellcheck on, but the squiggly underlines sometimes show up, sometimes do not. Today when they did not show up, I opened another doc where they did show up. Then went back to the original file and they were now showing up. This intermittent showing of misspelled underlines has been going on since I started using Writer. Steps to Reproduce: 1.misspell a word 2. 3. Actual Results: sometimes red squiggly line will show up, sometimes it will not display. Expected Results: red squiggly lines under misspelled words when Auto Spellcheck turned on. Reproducible: Sometimes User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: TextDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: no -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135540] TABLEIMPORT CALC: Format of the header of a table is copied while importing data to the content of all rows
https://bugs.documentfoundation.org/show_bug.cgi?id=135540 --- Comment #1 from elmau --- Confirm bug in ArchLinux Version: 6.4.5.2 Build ID: 6.4.5-2 CPU threads: 8; OS: Linux 5.7; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/opengl
vcl/opengl/RenderList.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit c8284fea44bd2e0170da8cbfab0c041e287ea99b
Author: Caolán McNamara
AuthorDate: Fri Aug 7 09:34:28 2020 +0100
Commit: Caolán McNamara
CommitDate: Fri Aug 7 21:24:11 2020 +0200
cid#1465674 silence Copy-paste error
Change-Id: I5b90774ffae5ee0ce32de1d557bd50f2d6b775cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100293
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/opengl/RenderList.cxx b/vcl/opengl/RenderList.cxx
index e894bb67ce50..8ba437f924c3 100644
--- a/vcl/opengl/RenderList.cxx
+++ b/vcl/opengl/RenderList.cxx
@@ -240,6 +240,7 @@ void RenderList::addDrawRectangle(long nX, long nY, long
nWidth, long nHeight, d
if (nFillColor == SALCOLOR_NONE)
return;
+// coverity[copy_paste_error : FALSE] - this is correct nLineColor not
nFillColor
if (nLineColor == SALCOLOR_NONE)
{
appendRectangle(rRenderParameter.maVertices,
rRenderParameter.maIndices,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 107191] [META] Notebookbar theming issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107191 V Stuart Foote changed: What|Removed |Added Depends on||135522 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135522 [Bug 135522] UI ENHANCEMENT:Make the tabbed interface visual more appealing (color shemes) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107191] [META] Notebookbar theming issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107191 Bug 107191 depends on bug 135522, which changed state. Bug 135522 Summary: UI ENHANCEMENT:Make the tabbed interface visual more appealing (color shemes) https://bugs.documentfoundation.org/show_bug.cgi?id=135522 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121877] Tabbed UI in Windows does not get theme color - remains white.
https://bugs.documentfoundation.org/show_bug.cgi?id=121877 V Stuart Foote changed: What|Removed |Added CC||tele...@surfxs.nl --- Comment #11 from V Stuart Foote --- *** Bug 135522 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135522] UI ENHANCEMENT:Make the tabbed interface visual more appealing (color shemes)
https://bugs.documentfoundation.org/show_bug.cgi?id=135522 V Stuart Foote changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED CC||vstuart.fo...@utsa.edu Blocks||107191 --- Comment #5 from V Stuart Foote --- *** This bug has been marked as a duplicate of bug 121877 *** Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107191 [Bug 107191] [META] Notebookbar theming issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134377] Unoperating Help buttons in File/Open|Save|Save As|Save Remote libO dialogs
https://bugs.documentfoundation.org/show_bug.cgi?id=134377 --- Comment #7 from Olivier Hallot --- the file picker hid's are in the form Help ID: fps/ui/explorerfiledialog/file_name Help ID: fps/ui/explorerfiledialog/file_type etc. so the bookmark is like widgets are to be obtained from Glade loaded with fpicker/.../explorefiledialog.ui Is some situations you also have Helpid in the form Help ID: SVT_HID_FILESAVE_FILEURL Help ID: SVT_HID_FILESAVE_FILEVIEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/ooxmlimport/data/tdf134572.docx |binary
sw/qa/extras/ooxmlimport/ooxmlimport.cxx | 28 +++
2 files changed, 28 insertions(+)
New commits:
commit bdbf72d9a23cf63bebc01d5fe1567f76cb260c7d
Author: Xisco Fauli
AuthorDate: Fri Aug 7 12:12:27 2020 +0200
Commit: Xisco Fauli
CommitDate: Fri Aug 7 21:07:05 2020 +0200
tdf#134572: sw_ooxmlimport: Add unittest
Change-Id: I9162211edb583201ba4600362045379fbed2b05c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100302
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/extras/ooxmlimport/data/tdf134572.docx
b/sw/qa/extras/ooxmlimport/data/tdf134572.docx
new file mode 100644
index ..7ab509b5fd1e
Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/tdf134572.docx differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index 937721f2f07d..1f534cb2fbbf 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -262,6 +262,34 @@ DECLARE_OOXMLIMPORT_TEST(testTdf129237, "tdf129237.docx")
CPPUNIT_ASSERT_EQUAL(OUString("Title New"),
xEnumerationAccess4->getPresentation(false).trim());
}
+DECLARE_OOXMLIMPORT_TEST(testTdf134572, "tdf134572.docx")
+{
+uno::Reference xTextFieldsSupplier(mxComponent,
uno::UNO_QUERY);
+uno::Reference
xFieldsAccess(xTextFieldsSupplier->getTextFields());
+uno::Reference
xFields(xFieldsAccess->createEnumeration());
+
+if( !xFields->hasMoreElements() ) {
+CPPUNIT_ASSERT(false);
+return;
+}
+
+// Without the fix in place, this test would have failed with
+// - Expected: RK - Risk / EH
+// - Actual : [Responsible Office]
+uno::Reference
xEnumerationAccess1(xFields->nextElement(), uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(OUString("RK - Risk / EH"),
xEnumerationAccess1->getPresentation(false).trim());
+
+if( !xFields->hasMoreElements() ) {
+CPPUNIT_ASSERT(false);
+return;
+}
+
+// - Expected: Choose an item.
+// - Actual : A.M.
+uno::Reference
xEnumerationAccess2(xFields->nextElement(), uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(OUString("Choose an item."),
xEnumerationAccess2->getPresentation(false).trim());
+}
+
DECLARE_OOXMLIMPORT_TEST(testTdf128076, "tdf128076.docx")
{
uno::Reference xTextFieldsSupplier(mxComponent,
uno::UNO_QUERY);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135249] Allow duration inputs of 0:mm or 0:0:ss with values >59, or 0:mm:ss with mm>59
https://bugs.documentfoundation.org/show_bug.cgi?id=135249 --- Comment #10 from Commit Notification --- Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b02d05f460fb43424d4288969ea826afc06b66e5 tdf#135249: sc_ucalc: Add unittest It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134572] FILEOPEN: DOCX: Incorrect default value in dropdown text fields
https://bugs.documentfoundation.org/show_bug.cgi?id=134572 --- Comment #7 from Commit Notification --- Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bdbf72d9a23cf63bebc01d5fe1567f76cb260c7d tdf#134572: sw_ooxmlimport: Add unittest It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/ucalc.cxx | 27 +++
sc/qa/unit/ucalc.hxx |2 ++
2 files changed, 29 insertions(+)
New commits:
commit b02d05f460fb43424d4288969ea826afc06b66e5
Author: Xisco Fauli
AuthorDate: Fri Aug 7 11:41:00 2020 +0200
Commit: Xisco Fauli
CommitDate: Fri Aug 7 21:06:32 2020 +0200
tdf#135249: sc_ucalc: Add unittest
Change-Id: Iddaf35d0b0afa44f081db2a1ac4f29567876f967
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100300
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index eb9636caaea1..6cd9a5db7ba0 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -456,6 +456,33 @@ void Test::testColumnIterator() // tdf#118620
m_pDoc->DeleteTab(0);
}
+void Test::testTdf135249()
+{
+CPPUNIT_ASSERT(m_pDoc->InsertTab (0, "Test"));
+
+m_pDoc->SetString(ScAddress(0,0,0), "1:60");
+m_pDoc->SetString(ScAddress(0,1,0), "1:123");
+m_pDoc->SetString(ScAddress(0,2,0), "1:1:123");
+m_pDoc->SetString(ScAddress(0,3,0), "0:123");
+m_pDoc->SetString(ScAddress(0,4,0), "0:0:123");
+m_pDoc->SetString(ScAddress(0,5,0), "0:123:59");
+
+// These are not valid duration inputs
+CPPUNIT_ASSERT_EQUAL(OUString("1:60"),
m_pDoc->GetString(ScAddress(0,0,0)));
+CPPUNIT_ASSERT_EQUAL(OUString("1:123"),
m_pDoc->GetString(ScAddress(0,1,0)));
+CPPUNIT_ASSERT_EQUAL(OUString("1:1:123"),
m_pDoc->GetString(ScAddress(0,2,0)));
+
+// These are valid duration inputs
+// Without the fix in place, this test would have failed with
+// - Expected: 02:03:00 AM
+// - Actual : 0:123
+CPPUNIT_ASSERT_EQUAL(OUString("02:03:00 AM"),
m_pDoc->GetString(ScAddress(0,3,0)));
+CPPUNIT_ASSERT_EQUAL(OUString("12:02:03 AM"),
m_pDoc->GetString(ScAddress(0,4,0)));
+CPPUNIT_ASSERT_EQUAL(OUString("02:03:59 AM"),
m_pDoc->GetString(ScAddress(0,5,0)));
+
+m_pDoc->DeleteTab(0);
+}
+
void Test::testDocStatistics()
{
SCTAB nStartTabs = m_pDoc->GetTableCount();
diff --git a/sc/qa/unit/ucalc.hxx b/sc/qa/unit/ucalc.hxx
index 2f2b8bc5501c..cba0a60c8143 100644
--- a/sc/qa/unit/ucalc.hxx
+++ b/sc/qa/unit/ucalc.hxx
@@ -126,6 +126,7 @@ public:
void testMarkData();
void testInput();
void testColumnIterator();
+void testTdf135249();
void testDocStatistics();
void testRowForHeight();
@@ -581,6 +582,7 @@ public:
CPPUNIT_TEST(testMarkData);
CPPUNIT_TEST(testInput);
CPPUNIT_TEST(testColumnIterator);
+CPPUNIT_TEST(testTdf135249);
CPPUNIT_TEST(testDocStatistics);
CPPUNIT_TEST(testRowForHeight);
CPPUNIT_TEST(testDataEntries);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/docvw/OutlineContentVisibilityWin.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 9c894db4a32fd6f2c50202c7769fa86ba1bd5247 Author: Caolán McNamara AuthorDate: Fri Aug 7 09:48:29 2020 +0100 Commit: Caolán McNamara CommitDate: Fri Aug 7 21:03:43 2020 +0200 cid#1465676 silence Unchecked return value Change-Id: I61f9fda6e7a5200336adfccad1d531a38416679b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100296 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/sw/source/uibase/docvw/OutlineContentVisibilityWin.cxx b/sw/source/uibase/docvw/OutlineContentVisibilityWin.cxx index 44772f367813..a709e421435f 100644 --- a/sw/source/uibase/docvw/OutlineContentVisibilityWin.cxx +++ b/sw/source/uibase/docvw/OutlineContentVisibilityWin.cxx @@ -65,8 +65,8 @@ void SwOutlineContentVisibilityWin::Set() const SwTextNode* pTextNode = pTextFrame->GetTextNodeFirst(); SwWrtShell& rSh = GetEditWin()->GetView().GetWrtShell(); const SwOutlineNodes& rOutlineNodes = rSh.GetNodes().GetOutLineNds(); - rOutlineNodes.Seek_Entry(static_cast(const_cast(pTextNode)), - _nOutlinePos); + (void)rOutlineNodes.Seek_Entry(static_cast(const_cast(pTextNode)), + _nOutlinePos); assert(m_nOutlinePos != SwOutlineNodes::npos); // don't set if no content and no subs with content ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135542] New: Writer (L.O. 7.0) crashed after selecting tabbed user interface
https://bugs.documentfoundation.org/show_bug.cgi?id=135542 Bug ID: 135542 Summary: Writer (L.O. 7.0) crashed after selecting tabbed user interface Product: LibreOffice Version: 7.0.0.3 release Hardware: x86-64 (AMD64) OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: luca.sarde...@protonmail.com Description: I decided to try the tabbed user interface. I create a new text document, selected tabbed interface, LibreOffice crashed offering to recover "Untiled 1". L.O. kept crashing until I managed to quickly change back to the standard interface. Steps to Reproduce: 1. Create a new Writer document or open an existing Writer document 2. Select View > User Interface > Tabbed 3. Crash Actual Results: LibreOffice stopped reponding. Expected Results: Change to tabbed interface Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Tabbed inferface works with Calcs. Version: 7.0.0.3 Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e CPU threads: 4; OS: Mac OS X 10.15.6; UI render: default; VCL: osx Locale: it-IT (en_IT.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134377] Unoperating Help buttons in File/Open|Save|Save As|Save Remote libO dialogs
https://bugs.documentfoundation.org/show_bug.cgi?id=134377 --- Comment #6 from Olivier Hallot --- Agree to refactor the Open and Save Help pages. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134724] UI - Find in Calc fails when a formula refers to a cell in another sheet's pivot table
https://bugs.documentfoundation.org/show_bug.cgi?id=134724 --- Comment #1 from sora3...@gmail.com --- I do admit that this can be hard to track. I had a similar issue with a previous error involving sheets. As you said, it does work when tracking values, but sometimes it doesn't work either. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 135501] Change the default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=135501 --- Comment #46 from Telesto --- (In reply to Caolán McNamara from comment #37) > I'd hate to see a dialog presented to the user on first start to pick their > user-interface, that just seems horrible, like that terrible "pick your > default browser as a feeble workaround for an anti-competitive ruling" > windows has/had. You’ve a point here. It's bit nagging. And not to decisive either. If you follow the masses, maybe they tabbed one by default. It might be people are used to re-configuring as the tabbed interface is forced on them quite often anyhow (go with the flow) However their is still they issue of all the environments where LibreOffice is running. Will this be a change across the board? Or Windows/MacOS only? Splitting it up can be itself seen as indecisive. It also will cause multiple screenshots flying around with different default interfaces. > I think there are too many "user interface" options. Leaving aside the > experimental options, we have in the user interface menu in the muffin > section "tabbed, tabbed compact, groupedbar compact, "contextual single" and > I have no real feeling for what the difference is between them all. It feels > indecisive, as if it's uncertain which one is the right design. IMO, pick > one, drop the others and then its a clearer decision as what the option > between current and proposed ui would entail. I agree. And most users tend to stick with the default (I assume). It are all variants of the same thing, IMHO. From QA perspective I prefer not to many options; probably the same is valid for documentation for example a11 Ideally the alternatives should be delivered as extension. Or if not possible buried in the theming dialog or even Expert configuration. This would allow backward comp-ability and there would be a test if people are actually missing those (if there are complains about where did they.. interface go) (In reply to Maxim Monastirsky from comment #41) > What I really missing from this discussion are *facts*. A major change like > this shouldn't be done without a serious study. We should collect feedback > from users who really tried to use the other UI variants on a daily basis, > and take a decision based on that. So arguments like "ribbon is the default > on windows, therefore we should use it too" don't count. When we set > something as default, we should be confident that at least it will allow > users to get their job done. Such a study is time consuming and expensive. And results will be hard to asses. I assume Microsoft did spend some money on research on the acceptance of the ribbon or the start menu of "Windows 8'. They transition did have some bumps and there were some tweaks.. but the didn't go back to before. There are people who love the Ribbon others hate it. I assume the competitors did make the decision to use the ‘ribbon’ on purpose. All of them made the ‘Ribbon’ default, with an option of a toolbar. Not that follow the herd necessary is the wise thing to do. OTOH, they toolbar aren’t gone either. It’s a few clicks away. The existing user base you can reach (in theory). I still love some kind of info bar which makes users aware of poll using the same system as the automatic update check. So they can participate once in a while. [But that’s only a thought of mine]. However such poll only reaches the existing user base. Still not the potential user base. Maybe the potentials ignore LibreOffice because it lacks a ‘ribbon’ interface (or because the experience isn't the ‘same’ thing). I personally find the current ‘tabbed’ edition aesthetically not that nice to look. And it doesn’t get better with theme. They issues already known should be fix upfront. Instead of pushing something which isn’t finished. Especially something so noticeable :-). Not that ever will be finished, can still be tweaked, need feedback (users) for that. Maybe enable it by default in Master and until 7.1 RC1 and decide at RC2/3 what to do based feedback/comments etc. (In reply to V Stuart Foote from comment #44 But actually we can collect (Tender'd 2015) disabled by default: Tools -> Options -> General 'Collect usage data and send it to The Document Foundation'; and I'm not asking folks to turn it on. I'm not really against telemetry (as such) if it helps improve LibreOffice. However 1) Telemetry shouldn’t start registering without explicit consent. As separated question. Not checked by default etc or buried along with other questions 2) I want a full disclosure which kind of data is collected (openness) 3) I want to be able to see what’s will be send in advance (openness) 4) I want a to be informed every time telemetry data will be exchanged (control). Being aware it happens 5) I want to see some kind of statistics derived for that data (results). 6) Some idea how it is can be used to improve things. And actually being used. Else it’s pointless exercise -- You are receiving
[Libreoffice-bugs] [Bug 135501] Change the default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=135501 --- Comment #46 from Telesto --- (In reply to Caolán McNamara from comment #37) > I'd hate to see a dialog presented to the user on first start to pick their > user-interface, that just seems horrible, like that terrible "pick your > default browser as a feeble workaround for an anti-competitive ruling" > windows has/had. You’ve a point here. It's bit nagging. And not to decisive either. If you follow the masses, maybe they tabbed one by default. It might be people are used to re-configuring as the tabbed interface is forced on them quite often anyhow (go with the flow) However their is still they issue of all the environments where LibreOffice is running. Will this be a change across the board? Or Windows/MacOS only? Splitting it up can be itself seen as indecisive. It also will cause multiple screenshots flying around with different default interfaces. > I think there are too many "user interface" options. Leaving aside the > experimental options, we have in the user interface menu in the muffin > section "tabbed, tabbed compact, groupedbar compact, "contextual single" and > I have no real feeling for what the difference is between them all. It feels > indecisive, as if it's uncertain which one is the right design. IMO, pick > one, drop the others and then its a clearer decision as what the option > between current and proposed ui would entail. I agree. And most users tend to stick with the default (I assume). It are all variants of the same thing, IMHO. From QA perspective I prefer not to many options; probably the same is valid for documentation for example a11 Ideally the alternatives should be delivered as extension. Or if not possible buried in the theming dialog or even Expert configuration. This would allow backward comp-ability and there would be a test if people are actually missing those (if there are complains about where did they.. interface go) (In reply to Maxim Monastirsky from comment #41) > What I really missing from this discussion are *facts*. A major change like > this shouldn't be done without a serious study. We should collect feedback > from users who really tried to use the other UI variants on a daily basis, > and take a decision based on that. So arguments like "ribbon is the default > on windows, therefore we should use it too" don't count. When we set > something as default, we should be confident that at least it will allow > users to get their job done. Such a study is time consuming and expensive. And results will be hard to asses. I assume Microsoft did spend some money on research on the acceptance of the ribbon or the start menu of "Windows 8'. They transition did have some bumps and there were some tweaks.. but the didn't go back to before. There are people who love the Ribbon others hate it. I assume the competitors did make the decision to use the ‘ribbon’ on purpose. All of them made the ‘Ribbon’ default, with an option of a toolbar. Not that follow the herd necessary is the wise thing to do. OTOH, they toolbar aren’t gone either. It’s a few clicks away. The existing user base you can reach (in theory). I still love some kind of info bar which makes users aware of poll using the same system as the automatic update check. So they can participate once in a while. [But that’s only a thought of mine]. However such poll only reaches the existing user base. Still not the potential user base. Maybe the potentials ignore LibreOffice because it lacks a ‘ribbon’ interface (or because the experience isn't the ‘same’ thing). I personally find the current ‘tabbed’ edition aesthetically not that nice to look. And it doesn’t get better with theme. They issues already known should be fix upfront. Instead of pushing something which isn’t finished. Especially something so noticeable :-). Not that ever will be finished, can still be tweaked, need feedback (users) for that. Maybe enable it by default in Master and until 7.1 RC1 and decide at RC2/3 what to do based feedback/comments etc. (In reply to V Stuart Foote from comment #44 But actually we can collect (Tender'd 2015) disabled by default: Tools -> Options -> General 'Collect usage data and send it to The Document Foundation'; and I'm not asking folks to turn it on. I'm not really against telemetry (as such) if it helps improve LibreOffice. However 1) Telemetry shouldn’t start registering without explicit consent. As separated question. Not checked by default etc or buried along with other questions 2) I want a full disclosure which kind of data is collected (openness) 3) I want to be able to see what’s will be send in advance (openness) 4) I want a to be informed every time telemetry data will be exchanged (control). Being aware it happens 5) I want to see some kind of statistics derived for that data (results). 6) Some idea how it is can be used to improve things. And actually being used. Else it’s pointless exercise -- You are receiving
[Libreoffice-commits] core.git: dbaccess/source
dbaccess/source/ui/querydesign/ConnectionLine.cxx | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
New commits:
commit d7d09fd881ff56ea1a7b6863cafb298387f20f98
Author: Caolán McNamara
AuthorDate: Fri Aug 7 09:47:21 2020 +0100
Commit: Caolán McNamara
CommitDate: Fri Aug 7 20:46:12 2020 +0200
cid#1465673 Unchecked return value
Change-Id: I6213d9c0f0450b5e600553c18deb5fbef3a05230
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100295
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/dbaccess/source/ui/querydesign/ConnectionLine.cxx
b/dbaccess/source/ui/querydesign/ConnectionLine.cxx
index 791f89247a52..5411e22e9457 100644
--- a/dbaccess/source/ui/querydesign/ConnectionLine.cxx
+++ b/dbaccess/source/ui/querydesign/ConnectionLine.cxx
@@ -82,13 +82,20 @@ namespace
{
const OTableWindowListBox* pListBox = _pWin->GetListBox();
_rNewConPos.setY( _pWin->GetPosPixel().Y() );
+
+std::unique_ptr xEntry;
+const weld::TreeView& rTreeView = pListBox->get_widget();
+
if (_nEntry != -1)
{
_rNewConPos.AdjustY(pListBox->GetPosPixel().Y() );
-const weld::TreeView& rTreeView = pListBox->get_widget();
-std::unique_ptr xEntry = rTreeView.make_iterator();
-rTreeView.get_iter_first(*xEntry);
-rTreeView.iter_nth_sibling(*xEntry, _nEntry);
+xEntry = rTreeView.make_iterator();
+if (!rTreeView.get_iter_first(*xEntry) ||
!rTreeView.iter_nth_sibling(*xEntry, _nEntry))
+xEntry.reset();
+}
+
+if (xEntry)
+{
auto nEntryPos = rTreeView.get_row_area(*xEntry).Center().Y();
if( nEntryPos >= 0 )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svx/inc
svx/inc/numberingtype.hrc | 70 +++---
1 file changed, 35 insertions(+), 35 deletions(-)
New commits:
commit e5e66dcee74da4f8b91a29b21b744f7aed138f1c
Author: Caolán McNamara
AuthorDate: Fri Aug 7 12:45:05 2020 +0100
Commit: Caolán McNamara
CommitDate: Fri Aug 7 20:10:50 2020 +0200
move comment to the start so xgettext uses the right ones
Change-Id: I0601cbcdd9b4441dc937fadf7287d0133fe35a3a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100309
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/svx/inc/numberingtype.hrc b/svx/inc/numberingtype.hrc
index 37cdbbd3c0f6..7181aeb385e9 100644
--- a/svx/inc/numberingtype.hrc
+++ b/svx/inc/numberingtype.hrc
@@ -26,41 +26,41 @@
const std::pair RID_SVXSTRARY_NUMBERINGTYPE[] =
{
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "None") ,
5 /* SVX_NUM_NUMBER_NONE */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "Bullet") ,
6 /* SVX_NUM_CHAR_SPECIAL */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "Graphics") ,
8 /* SVX_NUM_BITMAP */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "Linked graphics") ,
136 /* SVX_NUM_BITMAP|0x80 */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "1, 2, 3, ...") ,
4 /* SVX_NUM_ARABIC */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "A, B, C, ...") ,
0 /* SVX_NUM_CHARS_UPPER_LETTER */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "a, b, c, ...") ,
1 /* SVX_NUM_CHARS_LOWER_LETTER */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "I, II, III, ...") ,
2 /* SVX_NUM_ROMAN_UPPER */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "i, ii, iii, ...") ,
3 /* SVX_NUM_ROMAN_LOWER */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "1st, 2nd, 3rd, ...") ,
60 /* TEXT_NUMBER */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "One, Two, Three, ...") ,
61 /* TEXT_CARDINAL*/ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "First, Second, Third, ...") ,
62 /* TEXT_ORDINAL */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "A, .., AA, .., AAA, ...") ,
9 /* SVX_NUM_CHARS_UPPER_LETTER_N */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "a, .., aa, .., aaa, ...") ,
10 /* SVX_NUM_CHARS_LOWER_LETTER_N */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "*, †, ‡, §, **, ††, ...") ,
63 /* SYMBOL_CHICAGO */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "Native Numbering") ,
12 /* NATIVE_NUMBERING */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "А, Б, .., Аа, Аб, ... (Bulgarian)")
, 38 /* CHARS_CYRILLIC_UPPER_LETTER_BG */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "а, б, .., аа, аб, ... (Bulgarian)")
, 39 /* CHARS_CYRILLIC_LOWER_LETTER_BG */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "А, Б, .., Аа, Бб, ... (Bulgarian)")
, 40 /* CHARS_CYRILLIC_UPPER_LETTER_N_BG */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "а, б, .., аа, бб, ... (Bulgarian)")
, 41 /* CHARS_CYRILLIC_LOWER_LETTER_N_BG */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "А, Б, .., Аа, Аб, ... (Russian)") ,
42 /* CHARS_CYRILLIC_UPPER_LETTER_RU */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "а, б, .., аа, аб, ... (Russian)") ,
43 /* CHARS_CYRILLIC_LOWER_LETTER_RU */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "А, Б, .., Аа, Бб, ... (Russian)") ,
44 /* CHARS_CYRILLIC_UPPER_LETTER_N_RU */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "а, б, .., аа, бб, ... (Russian)") ,
45 /* CHARS_CYRILLIC_LOWER_LETTER_N_RU */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "А, Б, .., Аа, Аб, ... (Serbian)") ,
48 /* CHARS_CYRILLIC_UPPER_LETTER_SR */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "а, б, .., аа, аб, ... (Serbian)") ,
49 /* CHARS_CYRILLIC_LOWER_LETTER_SR */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "А, Б, .., Аа, Бб, ... (Serbian)") ,
50 /* CHARS_CYRILLIC_UPPER_LETTER_N_SR */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "а, б, .., аа, бб, ... (Serbian)") ,
51 /* CHARS_CYRILLIC_LOWER_LETTER_N_SR */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "Α, Β, Γ, ... (Greek Upper Letter)"),
52 /* CHARS_GREEK_UPPER_LETTER */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "α, β, γ, ... (Greek Lower Letter)"),
53 /* CHARS_GREEK_LOWER_LETTER */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "א...י, יא...כ, ...") ,
56 /* NUMBER_HEBREW*/ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE", "א...ת, אא...תת, ...") ,
33 /* CHARS_HEBREW */ },
-{ NC_("RID_SVXSTRARY_NUMBERINGTYPE",
[Libreoffice-commits] core.git: sfx2/source svx/source
sfx2/source/inc/templdgi.hxx |1 -
svx/source/inc/fmexch.hxx|3 ---
2 files changed, 4 deletions(-)
New commits:
commit 583058cb5944e9e64552bb39b732ad19b33d0888
Author: Caolán McNamara
AuthorDate: Fri Aug 7 11:56:50 2020 +0100
Commit: Caolán McNamara
CommitDate: Fri Aug 7 20:10:32 2020 +0200
drop unneeded forward declares
Change-Id: I32c8f5fd73249bdd7a233801f6a23b280b8df50c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100305
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sfx2/source/inc/templdgi.hxx b/sfx2/source/inc/templdgi.hxx
index 57b95edf9191..03a499c1aca2 100644
--- a/sfx2/source/inc/templdgi.hxx
+++ b/sfx2/source/inc/templdgi.hxx
@@ -44,7 +44,6 @@ class SfxTemplateItem;
class SfxBindings;
class SfxStyleSheetBase;
class SfxStyleSheetBasePool;
-class SvTreeListBox ;
class StyleTreeListBox_Impl;
class SfxTemplateDialog_Impl;
class SfxCommonTemplateDialog_Impl;
diff --git a/svx/source/inc/fmexch.hxx b/svx/source/inc/fmexch.hxx
index 8eb65854e564..22066c5c887b 100644
--- a/svx/source/inc/fmexch.hxx
+++ b/svx/source/inc/fmexch.hxx
@@ -34,9 +34,6 @@
#include
#include
-class SvTreeListEntry;
-class SvTreeListBox;
-
namespace svxform
{
typedef ::std::set> ListBoxEntrySet;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: 2 commits - common/RenderTiles.hpp wsd/ClientSession.cpp wsd/DocumentBroker.cpp wsd/TileCache.cpp wsd/TileCache.hpp wsd/TileDesc.hpp
common/RenderTiles.hpp | 12 +-
wsd/ClientSession.cpp |5 +-
wsd/DocumentBroker.cpp | 16 +
wsd/TileCache.cpp | 85 +++--
wsd/TileCache.hpp | 13 +++
wsd/TileDesc.hpp |8
6 files changed, 82 insertions(+), 57 deletions(-)
New commits:
commit 4c6ba6d85096a223b5c6672ee2f4b51c12ca41c3
Author: Michael Meeks
AuthorDate: Fri Aug 7 18:37:53 2020 +0100
Commit: Michael Meeks
CommitDate: Fri Aug 7 20:01:40 2020 +0200
Notify WSD of tiles which we didn't need to render.
When we get a wid match, this helps WSD to cleanup its tile
subscriber list effectively.
Change-Id: I6517039fb3d8c9ad8f53aef549b8adbb79961ce1
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100348
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Michael Meeks
diff --git a/common/RenderTiles.hpp b/common/RenderTiles.hpp
index 011503f12..c5bc9d03e 100644
--- a/common/RenderTiles.hpp
+++ b/common/RenderTiles.hpp
@@ -638,6 +638,9 @@ namespace RenderTiles
// The tile content is identical to what the client already
has, so skip it
LOG_TRC("Match for tile #" << tileIndex << " at (" <<
positionX << ',' <<
positionY << ") oldhash==hash (" << hash << "),
wireId: " << wireId << " skipping");
+// Push a zero byte image to inform WSD we didn't need that.
+// This allows WSD side TileCache to free up waiting
subscribers.
+pushRendered(renderedTiles, tiles[tileIndex], wireId, 0);
tileIndex++;
continue;
}
@@ -701,13 +704,16 @@ namespace RenderTiles
tileIndex++;
}
+// empty ones come first
+size_t zeroCheckStart = renderedTiles.size();
+
pngPool.run();
-for (auto : renderedTiles)
+for (size_t i = zeroCheckStart; i < renderedTiles.size(); ++i)
{
-if (i.getImgSize() == 0)
+if (renderedTiles[i].getImgSize() == 0)
{
-LOG_ERR("Encoded 0-sized tile!");
+LOG_TRC("Encoded 0-sized tile in slot !" << i);
assert(!"0-sized tile enocded!");
}
}
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 5120bb099..a5e62fcc4 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -2034,7 +2034,7 @@ void DocumentBroker::handleTileCombinedResponse(const
std::vector& payload
try
{
const size_t length = payload.size();
-if (firstLine.size() < static_cast(length) - 1)
+if (firstLine.size() <= static_cast(length) -
1)
{
const TileCombined tileCombined = TileCombined::parse(firstLine);
const char* buffer = payload.data();
diff --git a/wsd/TileCache.cpp b/wsd/TileCache.cpp
index e1cdefe8d..982cd985b 100644
--- a/wsd/TileCache.cpp
+++ b/wsd/TileCache.cpp
@@ -175,19 +175,24 @@ void TileCache::saveTileAndNotify(const TileDesc& tile,
const char *data, const
{
assertCorrectThread();
-// Save to disk.
+if (size > 0)
+{
+// Save to in-memory cache.
-// Ignore if we can't save the tile, things will work anyway, but slower.
-// An error indication is supposed to be sent to all users in that case.
-saveDataToCache(tile, data, size);
-LOG_TRC("Saved cache tile: " << cacheFileName(tile) << " of size " << size
<< " bytes");
+// Ignore if we can't save the tile, things will work anyway, but
slower.
+// An error indication is supposed to be sent to all users in that
case.
+saveDataToCache(tile, data, size);
+LOG_TRC("Saved cache tile: " << cacheFileName(tile) << " of size " <<
size << " bytes");
+}
+else
+LOG_TRC("Zero sized cache tile: " << cacheFileName(tile));
// Notify subscribers, if any.
std::shared_ptr tileBeingRendered =
findTileBeingRendered(tile);
if (tileBeingRendered)
{
const size_t subscriberCount =
tileBeingRendered->getSubscribers().size();
-if (subscriberCount > 0)
+if (size > 0 && subscriberCount > 0)
{
std::string response = tile.serialize("tile:");
LOG_DBG("Sending tile message to " << subscriberCount << "
subscribers: " << response);
@@ -229,10 +234,9 @@ void TileCache::saveTileAndNotify(const TileDesc& tile,
const char *data, const
}
}
}
-else
-{
+else if (subscriberCount == 0)
LOG_DBG("No subscribers for: " << cacheFileName(tile));
-}
+// else zero sized
// Remove subscriptions.
if (tileBeingRendered->getVersion() <= tile.getVersion())
@@ -243,9 +247,7 @@ void TileCache::saveTileAndNotify(const TileDesc& tile,
const char *data, const
}
}
else
-{
[Libreoffice-bugs] [Bug 135541] New: Dates are entered inconsistently, switching between day and month.
https://bugs.documentfoundation.org/show_bug.cgi?id=135541 Bug ID: 135541 Summary: Dates are entered inconsistently, switching between day and month. Product: LibreOffice Version: 6.4.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jtee...@hotmail.com Description: In a cell with format code "[~buddhist]D MMM " or "DD/MM/" and "Thai" language, when a date is entered the first time (e.g. 3/6), the date 6 Mar 2020 is entered. Then if the same date is enter again (3/6) into the same cell, the date 3 Jun 2020 is entered. This is inconsistent and confusing. In former versions of Calc, when 3/6 is entered it's always 3 Jun of the current year. Steps to Reproduce: 1.Enter 3/6 into a cell with format code [~buddhist]D MMM 2.Enter 3/6 into the same cell again. 3. Actual Results: 1. 6 Mar is entered. (6 มี.ค. 2563 is shown) 2. 3 Jun is entered. (3 มิ.ย. 2563 is shown) Expected Results: 3 มิ.ย. 2563 Reproducible: Always User Profile Reset: No Additional Info: The software should accept dates according to the local format. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135540] New: TABLEIMPORT CALC: Format of the header of a table is copied while importing data to the content of all rows
https://bugs.documentfoundation.org/show_bug.cgi?id=135540 Bug ID: 135540 Summary: TABLEIMPORT CALC: Format of the header of a table is copied while importing data to the content of all rows Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rob...@familiegrosskopf.de Created attachment 164040 --> https://bugs.documentfoundation.org/attachment.cgi?id=164040=edit try to import the data of the table. Look for the format. Take the attached little *.ods example file. The header for the table is set to bold and underlined. Import the content to Base. Set in the import wizard "First row as fieldnames". Set ID to primary key. Finish. All the content of the table will be shown underlined and bold. 1. This is the wrong format for the content. It has been the format from the header. 2. No format will be saved in a database. So it will only irritate if there appears a format. People in the international users List had the header with black background and white font. The black background couldn't be set in the table - but all content had been white - and a white background. This bug appears in all here installed LO-versions, starting with LO 6.1 and ending with LO 7.0.0.3 under OpenSUSE 15.2 Linux. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132457] #DIV/0! error after undoing a deleting a row
https://bugs.documentfoundation.org/show_bug.cgi?id=132457 --- Comment #2 from b. --- hello @Telesto, would you mind trying 7.1 ? didn't have time for for in-depth testing, but at a first glance that ver. worked better ... and there was a autocalc problem with second from top shared formula cell being sensitive reg. autocalculate recently fixed ... reg. b. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 135501] Change the default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=135501 --- Comment #45 from andreas_k --- It was more a joke to offer two downloads but an discover LibreOffice hint for the different layout after the download page would be nice. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 135501] Change the default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=135501 --- Comment #45 from andreas_k --- It was more a joke to offer two downloads but an discover LibreOffice hint for the different layout after the download page would be nice. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135503] Vorschlag zur Änderung beim Steuerelement "Schaltfläche"
https://bugs.documentfoundation.org/show_bug.cgi?id=135503 rolf-brigitt...@t-online.de changed: What|Removed |Added CC||rolf-brigitt...@t-online.de --- Comment #2 from rolf-brigitt...@t-online.de --- Created attachment 164039 --> https://bugs.documentfoundation.org/attachment.cgi?id=164039=edit Kommunikation mit der Community Hallo guten tag! Ich habe mein Problem im März mit der Community geteilt, das Ergebnis habe ich dokumentiert, die Dokumentation habe ich her beigefügt. Sie enthält auch Screenshots. Ich hoffe, ich habe mein Anliegen verdeutlichen können. Mit freundlichen Grüßen Rolf Walter Pierstraße 4 67227 Frankenthal Tel. 06233/4803347 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135501] Change the default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=135501 --- Comment #44 from V Stuart Foote --- (In reply to andreas_k from comment #43) > Great Idea. As LibO has no telemetry data, let's release a LibreOffice > version with tabbed UI and see which one will be downloaded. ;-) But actually we can collect (Tender'd 2015) disabled by default: Tools -> Options -> General 'Collect usage data and send it to The Document Foundation'; and I'm not asking folks to turn it on. But that is a different issue. A split configuration release would be a logistical/infra nightmare. Just no... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 135501] Change the default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=135501 --- Comment #44 from V Stuart Foote --- (In reply to andreas_k from comment #43) > Great Idea. As LibO has no telemetry data, let's release a LibreOffice > version with tabbed UI and see which one will be downloaded. ;-) But actually we can collect (Tender'd 2015) disabled by default: Tools -> Options -> General 'Collect usage data and send it to The Document Foundation'; and I'm not asking folks to turn it on. But that is a different issue. A split configuration release would be a logistical/infra nightmare. Just no... -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: extensions/source
extensions/source/logging/csvformatter.cxx |8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
New commits:
commit f3da84db230a10551bbdbd6cdf5e4cf669e54e2a
Author: Stephan Bergmann
AuthorDate: Fri Aug 7 14:38:07 2020 +0200
Commit: Noel Grandin
CommitDate: Fri Aug 7 18:56:51 2020 +0200
Make use of std string_view
Change-Id: Ic4b330b7d046ba77e51d32d156501a18e3782985
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100313
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/extensions/source/logging/csvformatter.cxx
b/extensions/source/logging/csvformatter.cxx
index 866833c41fd5..9ab747ad504d 100644
--- a/extensions/source/logging/csvformatter.cxx
+++ b/extensions/source/logging/csvformatter.cxx
@@ -30,6 +30,7 @@
#include
#include
+#include
namespace logging
{
@@ -91,12 +92,7 @@ namespace
bool needsQuoting(const OUString& str)
{
-static const OUString quote_trigger_chars = "\",\n\r";
-sal_Int32 len = str.getLength();
-for(sal_Int32 i=0; ihttps://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: undeclared build-time dependency on libnumbertext 1.0.6
Hi, Rene Engelhard ezt írta (időpont: 2020. aug. 7., P, 18:35): > Hi, > > Am 07.08.20 um 18:29 schrieb Rene Engelhard: > > > > At least a quick look > > ( > https://packages.debian.org/search?searchon=contents=NotoSansOldHungarian-Regular.otf=exactfilename=unstable=any > ) > > suggests that this is not the case. > > Ah, nevermind, there's a .ttf: > > > https://packages.debian.org/search?suite=sid=any=filename=contents=OldHungarian Great! This font solves the UI issue, and it can be good also for text editing with some refinement (forbidding unnecessary automatic ligature replacements). Thanks, László > > > Regards, > > > Rene > > ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: undeclared build-time dependency on libnumbertext 1.0.6
Hi, Am 07.08.20 um 18:29 schrieb Rene Engelhard: > > At least a quick look > (https://packages.debian.org/search?searchon=contents=NotoSansOldHungarian-Regular.otf=exactfilename=unstable=any) > suggests that this is not the case. Ah, nevermind, there's a .ttf: https://packages.debian.org/search?suite=sid=any=filename=contents=OldHungarian Regards, Rene ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: undeclared build-time dependency on libnumbertext 1.0.6
Hi, A question related to this issue: I started to add Old Hungarian numbering to Writer > (https://gerrit.libreoffice.org/c/core/+/99950) and the UI will > contain Old Hungarian > numbers, see the attached screenshot, so I plan to update the > noto-fonts-20171024.tar.gz > tarball, adding also the fortunately small (45 kB) > NotoSansOldHungarian-Regular.otf to help to > fix the potential font issue [note: the screenshot contains another > problem: showing squares > at the place of 1-character non-Unicode BMP text spans]. > > There is a bug report for Linux Mint > (https://github.com/linuxmint/cinnamon/issues/9458), > also an older one for Debian > (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=908817). > I am going to file a bug for my LibreOffice patch related to the > numbering, maybe for > Noto font update in LibreOffice. Do you suggest something similar for > Debian (Ubuntu) etc., > or it is not necessary? > My LO packages do not include any fonts - except OpenSymbol of course. So anything which you might use here should use something also in proper noto packages. At least a quick look (https://packages.debian.org/search?searchon=contents=NotoSansOldHungarian-Regular.otf=exactfilename=unstable=any) suggests that this is not the case. Regards, Rene ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: oox/source sw/qa
oox/source/export/vmlexport.cxx| 41 +
sw/qa/extras/ooxmlexport/ooxmlexport15.cxx |4 ++
2 files changed, 44 insertions(+), 1 deletion(-)
New commits:
commit 8d83c29905ca6c4067ae0330d3544ddb983cafbc
Author: Michael Stahl
AuthorDate: Fri Aug 7 15:50:12 2020 +0200
Commit: Michael Stahl
CommitDate: Fri Aug 7 18:26:46 2020 +0200
oox: VML export: convert ESCHER_Prop_AnchorText to v-text-anchor
Change-Id: I903cac8d7b02138680613b5a1b6dab4b1c448158
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100333
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/oox/source/export/vmlexport.cxx b/oox/source/export/vmlexport.cxx
index bb5e2b8eee50..0a0a634708bf 100644
--- a/oox/source/export/vmlexport.cxx
+++ b/oox/source/export/vmlexport.cxx
@@ -430,6 +430,47 @@ void VMLExport::Commit( EscherPropertyContainer& rProps,
const tools::Rectangle&
bAlreadyWritten[ ESCHER_Prop_WrapText ] = true;
break;
+case ESCHER_Prop_AnchorText: // 135
+{
+char const* pValue(nullptr);
+switch (opt.nPropValue)
+{
+case ESCHER_AnchorTop:
+pValue = "top";
+break;
+case ESCHER_AnchorMiddle:
+pValue = "middle";
+break;
+case ESCHER_AnchorBottom:
+pValue = "bottom";
+break;
+case ESCHER_AnchorTopCentered:
+pValue = "top-center";
+break;
+case ESCHER_AnchorMiddleCentered:
+pValue = "middle-center";
+break;
+case ESCHER_AnchorBottomCentered:
+pValue = "bottom-center";
+break;
+case ESCHER_AnchorTopBaseline:
+pValue = "top-baseline";
+break;
+case ESCHER_AnchorBottomBaseline:
+pValue = "bottom-baseline";
+break;
+case ESCHER_AnchorTopCenteredBaseline:
+pValue = "top-center-baseline";
+break;
+case ESCHER_AnchorBottomCenteredBaseline:
+pValue = "bottom-center-baseline";
+break;
+}
+m_ShapeStyle.append(";v-text-anchor:");
+m_ShapeStyle.append(pValue);
+}
+break;
+
case ESCHER_Prop_txflTextFlow: // 136
{
// at least "bottom-to-top" only has an effect when it's
on the v:textbox element, not on v:shape
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport15.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport15.cxx
index 9643439d1f69..f8dc2b8e9fd8 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport15.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport15.cxx
@@ -281,7 +281,9 @@ DECLARE_OOXMLEXPORT_TEST(testAtPageShapeRelOrientation,
"rotated_shape.fodt")
assertXPath(pXmlDocument,
"/w:document/w:body/w:p/w:r/mc:AlternateContent[1]/mc:Fallback/w:pict/v:shape/v:textbox",
"style", "mso-layout-flow-alt:bottom-to-top");
// text wrap -> VML
assertXPath(pXmlDocument,
"/w:document/w:body/w:p/w:r/mc:AlternateContent[1]/mc:Fallback/w:pict/v:shape/w10:wrap",
"type", "none");
-
+// vertical alignment -> VML
+OUString const style = getXPath(pXmlDocument,
"/w:document/w:body/w:p/w:r/mc:AlternateContent[1]/mc:Fallback/w:pict/v:shape",
"style");
+CPPUNIT_ASSERT(style.indexOf("v-text-anchor:middle") != -1);
}
DECLARE_OOXMLEXPORT_TEST(testRelativeAnchorHeightFromBottomMarginHasFooter,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
