[Libreoffice-bugs] [Bug 135579] Deinstall of LO 7.0.0.3 on Win7Pro also deletes "VCRUNTIME140.dll"
https://bugs.documentfoundation.org/show_bug.cgi?id=135579 --- Comment #4 from Olaf Langmack --- (In reply to V Stuart Foote from comment #1) > I think there are RefCount controls that allow this if LibreOffice package > install was the source of the VC++ runtime. And that is it is correct MSI > behavior. A subsequent install of LibreOffice should install it again-if > needed. A reinstall of LO 6.4.5.2 (or 6.4.4) did not fix it in this case. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108561] Mail Merge Wizard stops at salutation screen
https://bugs.documentfoundation.org/show_bug.cgi?id=108561 --- Comment #9 from Conor --- This bug is still present in this version: Version: 5.3.3.2 (x64) Build ID: 3d9a8b4b4e538a85e0782bd6c2d430bafe583448 CPU Threads: 8; OS Version: Windows 6.19; UI Render: default; Layout Engine: new; Locale: en-AU (en_AU); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134591] UI Title of shapes in Gallery doesn't update automatically when changed
https://bugs.documentfoundation.org/show_bug.cgi?id=134591 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135171] FILESAVE DOCX: A DOCX exported from LibreOffice takes long long time to open
https://bugs.documentfoundation.org/show_bug.cgi?id=135171 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132901] Tools > Options > LibreOffice > Online update does not handle the situation of "online update" feature not being installed gracefully
https://bugs.documentfoundation.org/show_bug.cgi?id=132901 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: oox/source
oox/source/ppt/pptshape.cxx | 13 + 1 file changed, 13 insertions(+) New commits: commit 33696b2820ce3c8b21b753d2c2bf92345ecb9276 Author: Gülşah Köse AuthorDate: Sat Aug 8 00:34:37 2020 +0300 Commit: Gülşah Köse CommitDate: Mon Aug 10 06:18:49 2020 +0200 tdf#133015 Inherit numCol from placeholder. Change-Id: I402a40be7e8899ca017996f2bf77a2fb884b9462 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100372 Tested-by: Jenkins Reviewed-by: Gülşah Köse diff --git a/oox/source/ppt/pptshape.cxx b/oox/source/ppt/pptshape.cxx index 647435888fe3..d017b4348d93 100644 --- a/oox/source/ppt/pptshape.cxx +++ b/oox/source/ppt/pptshape.cxx @@ -229,6 +229,19 @@ void PPTShape::addShape( { if (TextBodyPtr pTextBody = getTextBody()) { +// If slide shape has not numCol but placeholder has we should inherit from placeholder. +if (pTextBody->getTextProperties().mnNumCol == 1 && +mnSubType && +getSubTypeIndex().has() && +rSlidePersist.getMasterPersist()) +{ +oox::drawingml::ShapePtr pPlaceholder = PPTShape::findPlaceholderByIndex( + getSubTypeIndex().get(), + rSlidePersist.getMasterPersist()->getShapes()->getChildren()); +if (pPlaceholder && pPlaceholder->getTableProperties()) +pTextBody->getTextProperties().mnNumCol = pPlaceholder->getTableProperties()->getTableGrid().size(); +} + sal_Int32 nNumCol = pTextBody->getTextProperties().mnNumCol; if (nNumCol > 1) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 134989] FILESAVE RTF: Unexpected insertion of a section
https://bugs.documentfoundation.org/show_bug.cgi?id=134989 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: oox/inc oox/source
oox/inc/drawingml/table/tableproperties.hxx|2 +- oox/source/drawingml/table/tableproperties.cxx |5 - oox/source/ppt/pptshape.cxx|2 +- 3 files changed, 6 insertions(+), 3 deletions(-) New commits: commit 7b64bd90637a6722438bf873b1ded74ab3424c46 Author: Gülşah Köse AuthorDate: Fri Aug 7 14:53:13 2020 +0300 Commit: Gülşah Köse CommitDate: Mon Aug 10 06:18:12 2020 +0200 tdf#133015 Do not import multicol table text on master. Change-Id: I0a1b1dc2f9b314858ed90347065407bcd1dbbb73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100311 Tested-by: Jenkins Reviewed-by: Gülşah Köse diff --git a/oox/inc/drawingml/table/tableproperties.hxx b/oox/inc/drawingml/table/tableproperties.hxx index dcdf41b17ed0..ec8b3c4c5b60 100644 --- a/oox/inc/drawingml/table/tableproperties.hxx +++ b/oox/inc/drawingml/table/tableproperties.hxx @@ -59,7 +59,7 @@ public: const ::oox::drawingml::TextListStylePtr& pMasterTextListStyle ); /// Distributes text body with multiple columns in table cells. -void pullFromTextBody(oox::drawingml::TextBodyPtr pTextBody, sal_Int32 nShapeWidth, bool bhasSameSubTypeIndex); +void pullFromTextBody(oox::drawingml::TextBodyPtr pTextBody, sal_Int32 nShapeWidth, bool bhasSameSubTypeIndex, bool bMaster); private: diff --git a/oox/source/drawingml/table/tableproperties.cxx b/oox/source/drawingml/table/tableproperties.cxx index 1ecea1363659..bf7d0dcfe7a2 100644 --- a/oox/source/drawingml/table/tableproperties.cxx +++ b/oox/source/drawingml/table/tableproperties.cxx @@ -207,7 +207,7 @@ void TableProperties::pushToPropSet(const ::oox::core::XmlFilterBase& rFilterBas xTableStyleToDelete.reset(); } -void TableProperties::pullFromTextBody(oox::drawingml::TextBodyPtr pTextBody, sal_Int32 nShapeWidth, bool bhasSameSubTypeIndex) +void TableProperties::pullFromTextBody(oox::drawingml::TextBodyPtr pTextBody, sal_Int32 nShapeWidth, bool bhasSameSubTypeIndex, bool bMaster) { // Create table grid and a single row. sal_Int32 nNumCol = pTextBody->getTextProperties().mnNumCol; @@ -245,6 +245,9 @@ void TableProperties::pullFromTextBody(oox::drawingml::TextBodyPtr pTextBody, sa // Copy properties provided by . pCellTextBody->getTextListStyle() = pTextBody->getTextListStyle(); +if (bMaster) +continue; + for (sal_Int32 nParaInCol = 0; nParaInCol < nParaPerCol; ++nParaInCol) { if (nPara < pTextBody->getParagraphs().size()) diff --git a/oox/source/ppt/pptshape.cxx b/oox/source/ppt/pptshape.cxx index d4d251d2ceb0..647435888fe3 100644 --- a/oox/source/ppt/pptshape.cxx +++ b/oox/source/ppt/pptshape.cxx @@ -236,7 +236,7 @@ void PPTShape::addShape( // represent that as a table. sServiceName = "com.sun.star.drawing.TableShape"; oox::drawingml::table::TablePropertiesPtr pTableProperties = getTableProperties(); -pTableProperties->pullFromTextBody(pTextBody, maSize.Width, bhasSameSubTypeIndex); +pTableProperties->pullFromTextBody(pTextBody, maSize.Width, bhasSameSubTypeIndex, meShapeLocation == Layout); setTextBody(nullptr); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135151] Special Paste RTF: Missing image/frames
https://bugs.documentfoundation.org/show_bug.cgi?id=135151 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135146] Image anchored to page prevents removal of empty pages in between
https://bugs.documentfoundation.org/show_bug.cgi?id=135146 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135155] FILESAVE DOCX: Image anchored to character not properly aligned
https://bugs.documentfoundation.org/show_bug.cgi?id=135155 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135141] FILEOPEN RTF: Table is split on file open. Proper layout after clicking somewhere
https://bugs.documentfoundation.org/show_bug.cgi?id=135141 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135158] FILESAVE DOC (97/2000/XP; fine with 95): Wrong position Image/image frame
https://bugs.documentfoundation.org/show_bug.cgi?id=135158 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135166] FILEOPEN RTF: A part is marked as deleted change and should be so
https://bugs.documentfoundation.org/show_bug.cgi?id=135166 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135138] Using CLI assemblies result in Invalid IL code in uno.util.Bootstrap:bootstrap
https://bugs.documentfoundation.org/show_bug.cgi?id=135138 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135165] FILEOPEN DOCX: A part of the hidden change appears on DOCX save
https://bugs.documentfoundation.org/show_bug.cgi?id=135165 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135168] Lots of empty pages added on paste since 6.5
https://bugs.documentfoundation.org/show_bug.cgi?id=135168 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135142] UNDO isn't removing styles inserted with RTF Special Paste
https://bugs.documentfoundation.org/show_bug.cgi?id=135142 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135156] Text splitting bit arbitrary for ODT/RTF/DOC fine for DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=135156 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135148] Delete index redo/index has an effect on the image position
https://bugs.documentfoundation.org/show_bug.cgi?id=135148 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135160] SPECIAL PASTE RTF: Image pasted without caption frame
https://bugs.documentfoundation.org/show_bug.cgi?id=135160 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129931] saving a large spreadsheet in xls file format
https://bugs.documentfoundation.org/show_bug.cgi?id=129931 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124631] OLE link doe not show preview
https://bugs.documentfoundation.org/show_bug.cgi?id=124631 --- Comment #18 from QA Administrators --- Dear Dave Nadler, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129931] saving a large spreadsheet in xls file format
https://bugs.documentfoundation.org/show_bug.cgi?id=129931 --- Comment #3 from QA Administrators --- Dear howardeaston999, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130562] Arrow moved automatically down after created
https://bugs.documentfoundation.org/show_bug.cgi?id=130562 --- Comment #2 from QA Administrators --- Dear Tobias, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135591] New: Aspect ratio disturbed while switching Slide > Format
https://bugs.documentfoundation.org/show_bug.cgi?id=135591 Bug ID: 135591 Summary: Aspect ratio disturbed while switching Slide > Format Product: LibreOffice Version: 6.4.5.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mohith.ma...@skanray.com Description: Images added to the presentation (vectors or rasters) do not maintain aspect ratio even when set in 'Position and Size > Keep ratio'. This happens to both master pages and normal view. This becomes a limitation when we make common templates of multiple formats. Steps to Reproduce: 1. Insert an SVG / PNG image in the slide master or in normal view. 2. Right click on the image and open 'Position and Size' dialog. 3. Check 'Keep ratio' option and hit OK. 4. Under Properties side bar, in Slide group, change the format (to any other) Actual Results: Images loose the original aspect ratio. Expected Results: Images should have maintained aspect ratio while maintaining the centre of the images on normalised coordinates. Reproducible: Always User Profile Reset: No Additional Info: Version: 6.4.5.2 Build ID: 1:6.4.5-0ubuntu0.18.04.1 CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3; Locale: en-GB (en_IN); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - desktop/qa
desktop/qa/desktop_lib/test_desktop_lib.cxx | 112 +--- 1 file changed, 86 insertions(+), 26 deletions(-) New commits: commit 347e0d5336ccd881356c89ecc5d8186dd9b773ad Author: Ashod Nakashian AuthorDate: Sun Aug 2 12:41:19 2020 -0400 Commit: Ashod Nakashian CommitDate: Mon Aug 10 04:50:20 2020 +0200 DesktopLOKTest: cleanup Refactor the handling of document loading and unloading and cleanup to allow more flexibility when loading multiple documents and for manual destruction. Also, correctly set the document type when loading, which was defaulted to TEXT even when loading spreadsheet and presentation documents. Minor misc cleanup such as dangling semicolons and unregistering the callback twice. Change-Id: Ia244aafd526d60f73c46e99fb8c7e63f63b0a8f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99974 Tested-by: Jenkins CollaboraOffice Reviewed-by: Ashod Nakashian diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx b/desktop/qa/desktop_lib/test_desktop_lib.cxx index 0123037ec75d..864041b71d49 100644 --- a/desktop/qa/desktop_lib/test_desktop_lib.cxx +++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx @@ -59,9 +59,34 @@ #include #include +#include + using namespace com::sun::star; using namespace desktop; +static LibreOfficeKitDocumentType getDocumentTypeFromName(const char* pName) +{ +CPPUNIT_ASSERT_MESSAGE("Document name must be valid.", pName != nullptr); + +const std::string name(pName); +CPPUNIT_ASSERT_MESSAGE("Document name must include extension.", name.size() > 4); + +const auto it = name.rfind('.'); +if (it != name.npos) +{ +const std::string ext = name.substr(it); + +if (ext == ".ods") +return LOK_DOCTYPE_SPREADSHEET; + +if (ext == ".odp") +return LOK_DOCTYPE_PRESENTATION; +} + +CPPUNIT_ASSERT_MESSAGE("Document name must include extension.", it != name.npos); +return LOK_DOCTYPE_TEXT; +} + class DesktopLOKTest : public UnoApiTest { class Resetter @@ -106,22 +131,39 @@ public: UnoApiTest::setUp(); mxDesktop.set(frame::Desktop::create(comphelper::getComponentContext(getMultiServiceFactory(; SfxApplication::GetOrCreate(); -}; +} virtual void tearDown() override { -if (m_pDocument) -m_pDocument->pClass->registerCallback(m_pDocument.get(), nullptr, nullptr); closeDoc(); UnoApiTest::tearDown(); comphelper::LibreOfficeKit::setActive(false); -}; +} + +std::pair, uno::Reference> +loadDocImpl(const char* pName, LibreOfficeKitDocumentType eType); + +std::pair, uno::Reference> +loadDocImpl(const char* pName) +{ +return loadDocImpl(pName, getDocumentTypeFromName(pName)); +} + +std::pair, uno::Reference> +loadDocUrlImpl(const OUString& rFileURL, LibreOfficeKitDocumentType eType); LibLODocument_Impl* loadDocUrl(const OUString& rFileURL, LibreOfficeKitDocumentType eType); -LibLODocument_Impl* loadDoc(const char* pName, LibreOfficeKitDocumentType eType = LOK_DOCTYPE_TEXT); -void closeDoc(); +LibLODocument_Impl* loadDoc(const char* pName, LibreOfficeKitDocumentType eType); +LibLODocument_Impl* loadDoc(const char* pName) +{ +return loadDoc(pName, getDocumentTypeFromName(pName)); +} + +void closeDoc(std::unique_ptr& loDocument, + uno::Reference& xComponent); +void closeDoc() { closeDoc(m_pDocument, mxComponent); } static void callback(int nType, const char* pPayload, void* pData); void callbackImpl(int nType, const char* pPayload); @@ -287,7 +329,8 @@ static Control* GetFocusControl(vcl::Window const * pParent) return nullptr; } -LibLODocument_Impl* DesktopLOKTest::loadDocUrl(const OUString& rFileURL, LibreOfficeKitDocumentType eType) +std::pair, uno::Reference> +DesktopLOKTest::loadDocUrlImpl(const OUString& rFileURL, LibreOfficeKitDocumentType eType) { OUString aService; switch (eType) @@ -305,28 +348,48 @@ LibLODocument_Impl* DesktopLOKTest::loadDocUrl(const OUString& rFileURL, LibreOf CPPUNIT_ASSERT(false); break; } -mxComponent = loadFromDesktop(rFileURL, aService); -if (!mxComponent.is()) -{ -CPPUNIT_ASSERT(false); -} -m_pDocument.reset(new LibLODocument_Impl(mxComponent)); -return m_pDocument.get(); + +uno::Reference xComponent = loadFromDesktop(rFileURL, aService); +CPPUNIT_ASSERT(xComponent.is()); + +std::unique_ptr pDocument(new LibLODocument_Impl(xComponent)); + +return std::make_pair(std::move(pDocument), xComponent); } -LibLODocument_Impl* DesktopLOKTest::loadDoc(const char* pName, LibreOfficeKitDocumentType eType) +std::pair, uno::Reference> +DesktopLOKTest::loadDocImpl(const char* pName, LibreOfficeKitDocumentType eType) { OUString aFileURL;
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sc/qa sd/qa sw/qa
sc/qa/unit/tiledrendering/tiledrendering.cxx |2 sd/qa/unit/tiledrendering/tiledrendering.cxx |2 sw/qa/extras/tiledrendering/tiledrendering.cxx | 69 - 3 files changed, 37 insertions(+), 36 deletions(-) New commits: commit afaed0b1141d67c36ff0714be5d7eb2825a79bdd Author: Ashod Nakashian AuthorDate: Sat Aug 1 16:09:00 2020 -0400 Commit: Ashod Nakashian CommitDate: Mon Aug 10 04:49:44 2020 +0200 lok: minor cleanup of ViewCallback in tiledrendering tests Change-Id: I39b964a7aa7d181083a153283f38c1a5bc64de58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99973 Tested-by: Jenkins CollaboraOffice Reviewed-by: Ashod Nakashian diff --git a/sc/qa/unit/tiledrendering/tiledrendering.cxx b/sc/qa/unit/tiledrendering/tiledrendering.cxx index 625f506bfe50..4962ebc5fb68 100644 --- a/sc/qa/unit/tiledrendering/tiledrendering.cxx +++ b/sc/qa/unit/tiledrendering/tiledrendering.cxx @@ -450,7 +450,7 @@ void ScTiledRenderingTest::testEmptyColumnSelection() } /// A view callback tracks callbacks invoked on one specific view. -class ViewCallback +class ViewCallback final { SfxViewShell* mpViewShell; int mnView; diff --git a/sd/qa/unit/tiledrendering/tiledrendering.cxx b/sd/qa/unit/tiledrendering/tiledrendering.cxx index a3dddaa78bb2..b6090961ebb7 100644 --- a/sd/qa/unit/tiledrendering/tiledrendering.cxx +++ b/sd/qa/unit/tiledrendering/tiledrendering.cxx @@ -838,7 +838,7 @@ void SdTiledRenderingTest::testResizeTableColumn() } /// A view callback tracks callbacks invoked on one specific view. -class ViewCallback +class ViewCallback final { SfxViewShell* mpViewShell; int mnView; diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx b/sw/qa/extras/tiledrendering/tiledrendering.cxx index 7cb4978be44c..4b4f00887a74 100644 --- a/sw/qa/extras/tiledrendering/tiledrendering.cxx +++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx @@ -752,7 +752,7 @@ void SwTiledRenderingTest::testPartHash() } /// A view callback tracks callbacks invoked on one specific view. -class ViewCallback +class ViewCallback final { SfxViewShell* mpViewShell; int mnView; @@ -780,7 +780,7 @@ public: /// Post-it / annotation payload. boost::property_tree::ptree m_aComment; -ViewCallback(SfxViewShell* pViewShell, std::function const & rBeforeInstallFunc = {}) +ViewCallback(SfxViewShell* pViewShell = nullptr, std::function const & rBeforeInstallFunc = {}) : m_bOwnCursorInvalidated(false), m_nOwnCursorInvalidatedBy(-1), m_bOwnCursorAtOrigin(false), @@ -798,7 +798,7 @@ public: if (rBeforeInstallFunc) rBeforeInstallFunc(*this); -mpViewShell = pViewShell; +mpViewShell = pViewShell ? pViewShell : SfxViewShell::Current(); mpViewShell->registerLibreOfficeKitViewCallback(::callback, this); mnView = SfxLokHelper::getView(); } @@ -966,10 +966,10 @@ void SwTiledRenderingTest::testMissingInvalidation() // Create two views. SwXTextDocument* pXTextDocument = createDoc("dummy.fodt"); -ViewCallback aView1(SfxViewShell::Current()); +ViewCallback aView1; int nView1 = SfxLokHelper::getView(); SfxLokHelper::createView(); -ViewCallback aView2(SfxViewShell::Current()); +ViewCallback aView2; int nView2 = SfxLokHelper::getView(); // First view: put the cursor into the first word. @@ -999,9 +999,10 @@ void SwTiledRenderingTest::testViewCursors() comphelper::LibreOfficeKit::setActive(); SwXTextDocument* pXTextDocument = createDoc("dummy.fodt"); -ViewCallback aView1(SfxViewShell::Current()); +ViewCallback aView1; SfxLokHelper::createView(); -ViewCallback aView2(SfxViewShell::Current()); +ViewCallback aView2; + CPPUNIT_ASSERT(aView1.m_bOwnCursorInvalidated); CPPUNIT_ASSERT(aView1.m_bViewCursorInvalidated); CPPUNIT_ASSERT(aView2.m_bOwnCursorInvalidated); @@ -1037,10 +1038,10 @@ void SwTiledRenderingTest::testShapeViewCursors() // Load a document and create a view, so we have 2 ones. SwXTextDocument* pXTextDocument = createDoc("shape.fodt"); -ViewCallback aView1(SfxViewShell::Current()); +ViewCallback aView1; SfxLokHelper::createView(); pXTextDocument->initializeForTiledRendering(uno::Sequence()); -ViewCallback aView2(SfxViewShell::Current()); +ViewCallback aView2; SwWrtShell* pWrtShell2 = pXTextDocument->GetDocShell()->GetWrtShell(); // Start shape text in the second view. @@ -1076,10 +1077,10 @@ void SwTiledRenderingTest::testViewCursorVisibility() // Load a document that has a shape and create two views. SwXTextDocument* pXTextDocument = createDoc("shape.fodt"); -ViewCallback aView1(SfxViewShell::Current()); +ViewCallback aView1; SfxLokHelper::createView(); pXTextDocument->initializeForTiledRendering(uno::Sequence()); -ViewCallback aView2(SfxViewShell::Current());
[Libreoffice-bugs] [Bug 135563] [Calc] Detailed Calculation Settings cannot be reset to default
https://bugs.documentfoundation.org/show_bug.cgi?id=135563 SteveDee changed: What|Removed |Added Ever confirmed|0 |1 CC||stevedee.atw...@gmail.com Status|UNCONFIRMED |NEW --- Comment #1 from SteveDee --- Thank you for reporting this bug. I can confirm that the bug is present in: Version: 6.4.5.2 (x64) Build ID: a726b36747cf2001e06b58ad5db1aa3a9a1872d6 CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: GL; VCL: win; Locale: en-AU (en_US); UI-Language: en-GB Calc: CL and is also present in: Version: 7.1.0.0.alpha0+ (x64) Build ID: CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: en-AU (en_US); UI: en-GB Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sfx2/source
sfx2/source/view/viewsh.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 02cde0be4fec9f4c77f535e5053888ef1e37fad6 Author: Ashod Nakashian AuthorDate: Sat Jul 25 16:51:47 2020 -0400 Commit: Ashod Nakashian CommitDate: Mon Aug 10 04:44:41 2020 +0200 sfx2: lok: more informative warning Include the LOK callback even type as readable name instead of its numeric ID. Change-Id: I7865ae24878124b850468bcaa630ca444f4b2a96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99971 Tested-by: Jenkins CollaboraOffice Reviewed-by: Ashod Nakashian diff --git a/sfx2/source/view/viewsh.cxx b/sfx2/source/view/viewsh.cxx index 978c1cca5d20..b9abc8833573 100644 --- a/sfx2/source/view/viewsh.cxx +++ b/sfx2/source/view/viewsh.cxx @@ -1496,7 +1496,7 @@ void SfxViewShell::libreOfficeKitViewCallback(int nType, const char* pPayload) c SAL_WARN( "sfx.view", "SfxViewShell::libreOfficeKitViewCallback no callback set! Dropped payload of type " -<< nType << ": [" << pPayload << ']'); +<< lokCallbackTypeToString(nType) << ": [" << pPayload << ']'); } void SfxViewShell::afterCallbackRegistered() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - desktop/source include/sfx2 sfx2/source sw/source
desktop/source/lib/init.cxx|4 +- include/sfx2/lokhelper.hxx | 17 +++--- sfx2/source/view/lokhelper.cxx | 69 - sw/source/core/crsr/crsrsh.cxx |2 - 4 files changed, 56 insertions(+), 36 deletions(-) New commits: commit b7b81c68dc406cfa16d959f22417a3c3ed7888d5 Author: Ashod Nakashian AuthorDate: Fri Jul 24 11:33:46 2020 -0400 Commit: Ashod Nakashian CommitDate: Mon Aug 10 04:45:07 2020 +0200 sfx2: lok: refactor notifications and const correctness This reduces the stringification and reuses the notificaiton helpers to reduce code duplication. Change-Id: Icf9f9c50f361a0ded741d39fed37cfcc8da1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99972 Tested-by: Jenkins CollaboraOffice Reviewed-by: Ashod Nakashian diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index 89269803af04..906d3c4c6baa 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -2169,7 +2169,7 @@ static LibreOfficeKitDocument* lo_documentLoadWithOptions(LibreOfficeKit* pThis, LibLibreOffice_Impl* pLib = static_cast(pThis); pLib->maLastExceptionMsg.clear(); -OUString aURL(getAbsoluteURL(pURL)); +const OUString aURL(getAbsoluteURL(pURL)); if (aURL.isEmpty()) { pLib->maLastExceptionMsg = "Filename to load was not provided."; @@ -2264,7 +2264,7 @@ static LibreOfficeKitDocument* lo_documentLoadWithOptions(LibreOfficeKit* pThis, LibLODocument_Impl* pDocument = new LibLODocument_Impl(xComponent, nDocumentIdCounter++); -// Do we know that after loading the document, its initial view is the "current" view? +// After loading the document, its initial view is the "current" view. SfxLokHelper::setDocumentIdOfView(pDocument->mnDocumentId); if (pLib->mpCallback) { diff --git a/include/sfx2/lokhelper.hxx b/include/sfx2/lokhelper.hxx index 57aee1bb3a5d..e3c75b4191c3 100644 --- a/include/sfx2/lokhelper.hxx +++ b/include/sfx2/lokhelper.hxx @@ -51,7 +51,7 @@ public: /// Set a view shell as current one. static void setView(int nId); /// Get the currently active view. -static int getView(SfxViewShell* pViewShell = nullptr); +static int getView(const SfxViewShell* pViewShell = nullptr); /// Get the number of views of the current object shell. static std::size_t getViewsCount(); /// Get viewIds of views of the current object shell. @@ -72,17 +72,24 @@ public: static LOKDeviceFormFactor getDeviceFormFactor(); /// Set the device form factor that should be used for a new view. static void setDeviceFormFactor(const OUString& rDeviceFormFactor); + /// Iterate over any view shell, except pThisViewShell, passing it to the f function. template static void forEachOtherView(ViewShellType* pThisViewShell, FunctionType f); + /// Invoke the LOK callback of all other views showing the same document as pThisView, with a payload of rKey-rPayload. -static void notifyOtherViews(SfxViewShell* pThisView, int nType, const OString& rKey, const OString& rPayload); +static void notifyOtherViews(const SfxViewShell* pThisView, int nType, const OString& rKey, + const OString& rPayload); /// Invoke the LOK callback of all views except pThisView, with a JSON payload created from the given property tree. -static void notifyOtherViews(SfxViewShell* pThisView, int nType, const boost::property_tree::ptree& rTree); +static void notifyOtherViews(const SfxViewShell* pThisView, int nType, + const boost::property_tree::ptree& rTree); /// Same as notifyOtherViews(), but works on a selected "other" view, not on all of them. -static void notifyOtherView(SfxViewShell* pThisView, SfxViewShell const* pOtherView, int nType, const OString& rKey, const OString& rPayload); +static void notifyOtherView(const SfxViewShell* pThisView, SfxViewShell const* pOtherView, +int nType, const OString& rKey, const OString& rPayload); /// Same as notifyOtherViews(), the property-tree version, but works on a selected "other" view, not on all of them. -static void notifyOtherView(SfxViewShell* pThisView, SfxViewShell const* pOtherView, int nType, const boost::property_tree::ptree& rTree); +static void notifyOtherView(const SfxViewShell* pThisView, SfxViewShell const* pOtherView, +int nType, const boost::property_tree::ptree& rTree); + /// Emits a LOK_CALLBACK_STATE_CHANGED static void sendUnoStatus(const SfxViewShell* pShell, const SfxPoolItem* pItem); /// Emits a LOK_CALLBACK_WINDOW diff --git a/sfx2/source/view/lokhelper.cxx b/sfx2/source/view/lokhelper.cxx index 03241d065a78..864523e50fd6 100644 --- a/sfx2/source/view/lokhelper.cxx +++ b/sfx2/source/view/lokhelper.cxx @@ -73,7 +73,7 @@
[Libreoffice-bugs] [Bug 135572] Margins in sidebar are confusing
https://bugs.documentfoundation.org/show_bug.cgi?id=135572 --- Comment #2 from Kiyotaka Nishibori --- This issue was reproduced also on following build: Version: 7.0.1.0.0+ Build ID: dc6093be8f016283880271bda72e8e0142b962a8 CPU threads: 8; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: ja-JP (ja_JP.UTF-8); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135585] Accessiblity To short announcements in options for auto correctionwhen working with screenreader
https://bugs.documentfoundation.org/show_bug.cgi?id=135585 V Stuart Foote changed: What|Removed |Added Keywords||accessibility CC||vstuart.fo...@utsa.edu Blocks||60251 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=60251 [Bug 60251] [META] ACCESSIBILITY: Tracking Windows OS accessibility and AT issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135586] Accessebility Quotes are not announced when working with screenreaders
https://bugs.documentfoundation.org/show_bug.cgi?id=135586 V Stuart Foote changed: What|Removed |Added Keywords||accessibility Blocks||60251 CC||vstuart.fo...@utsa.edu Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=60251 [Bug 60251] [META] ACCESSIBILITY: Tracking Windows OS accessibility and AT issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60251] [META] ACCESSIBILITY: Tracking Windows OS accessibility and AT issues
https://bugs.documentfoundation.org/show_bug.cgi?id=60251 V Stuart Foote changed: What|Removed |Added Depends on||135585 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135585 [Bug 135585] Accessiblity To short announcements in options for auto correctionwhen working with screenreader -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60251] [META] ACCESSIBILITY: Tracking Windows OS accessibility and AT issues
https://bugs.documentfoundation.org/show_bug.cgi?id=60251 V Stuart Foote changed: What|Removed |Added Depends on||135586 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135586 [Bug 135586] Accessebility Quotes are not announced when working with screenreaders -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135588] Accesebility text in Confirm dialog in Document restore is not announced when using screenreaders
https://bugs.documentfoundation.org/show_bug.cgi?id=135588 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Blocks||60251 Keywords||accessibility Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=60251 [Bug 60251] [META] ACCESSIBILITY: Tracking Windows OS accessibility and AT issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60251] [META] ACCESSIBILITY: Tracking Windows OS accessibility and AT issues
https://bugs.documentfoundation.org/show_bug.cgi?id=60251 V Stuart Foote changed: What|Removed |Added Depends on||135588 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135588 [Bug 135588] Accesebility text in Confirm dialog in Document restore is not announced when using screenreaders -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134591] UI Title of shapes in Gallery doesn't update automatically when changed
https://bugs.documentfoundation.org/show_bug.cgi?id=134591 SteveDee changed: What|Removed |Added CC||stevedee.atw...@gmail.com Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from SteveDee --- I can also confirm that the bug is present in: Version: 6.4.5.2 (x64) Build ID: a726b36747cf2001e06b58ad5db1aa3a9a1872d6 CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: GL; VCL: win; Locale: en-AU (en_US); UI-Language: en-GB Calc: CL I have checked also against the following build: Version: 7.1.0.0.alpha0+ (x64) Build ID: CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: en-AU (en_US); UI: en-GB Calc: CL In this build, even if you change from Detailed View to Icon View then back to Detailed View, the title does not change. However, if you go to another Theme and then back to the Theme just created, then it does change to the new title created. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135590] Create Envelope: differ some page format properties between sidebar and page style dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=135590 --- Comment #1 from sawakaze --- Created attachment 164081 --> https://bugs.documentfoundation.org/attachment.cgi?id=164081=edit ScreenCast -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135590] New: Create Envelope: differ some page format properties between sidebar and page style dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=135590 Bug ID: 135590 Summary: Create Envelope: differ some page format properties between sidebar and page style dialog Product: LibreOffice Version: 7.0.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: souichi...@gmail.com Description: after following step, create blank envelope. but i notice some page properties between sidebar and page style dialog detail is screen cast Steps to Reproduce: 1. open writer 2. Insert > Envelope... -> launch Envelope window 3. press Format tab 4. select Format to "C6 Envelope" 5. press New Document -> create new Envelope document 6. confirm page format on sidebar 7. open page style dialog by toggle button 8. confirm Page Format on Page tab Actual Results: differ between sidebar and Page style dialog [sidebar] Size : User width : 16.20cm height: 11.40cm orientation : Portrait [Page Style] Size : C6 Envelope width : 11.40cm height: 16.20cm orientation : Portrait Expected Results: As actual view. perhaps, I seem Size : C6 Envelope width : 16.20cm height: 11.40cm orientation : Landscape Reproducible: Always User Profile Reset: Yes Additional Info: I confirm Version: 7.1.0.0.alpha0+ Build ID: CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3 Locale: ja-JP (ja_JP.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-08-06_17:35:14 Calc: threaded I don't confirm other size. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 135501] Change the default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=135501 --- Comment #57 from Sascha Z --- (In reply to V Stuart Foote from comment #56) > Suffice to say that as demonstrated by this UX-advise BZ issue--user > expectations often may diverge from practical considerations of what is in > the best interest of LibreOffice as an ODF-centric cross-platform Office > program. No, I disagree for the fact that LibreOffice should always work in the best interest of its user expectations. Not vice versa! With only one difference in the amount of users. Meaning a single user might be wrong, a group of users might still be asking for changes disregarded by the majority, while the majority of users is the one and only angle to focus on. Only problem - we can't gather enough informations what the majority of users is using. Or would like to use if they know it does exists. So what do you suggest: a Tip of the day or a user choice during first start-up? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 135501] Change the default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=135501 --- Comment #57 from Sascha Z --- (In reply to V Stuart Foote from comment #56) > Suffice to say that as demonstrated by this UX-advise BZ issue--user > expectations often may diverge from practical considerations of what is in > the best interest of LibreOffice as an ODF-centric cross-platform Office > program. No, I disagree for the fact that LibreOffice should always work in the best interest of its user expectations. Not vice versa! With only one difference in the amount of users. Meaning a single user might be wrong, a group of users might still be asking for changes disregarded by the majority, while the majority of users is the one and only angle to focus on. Only problem - we can't gather enough informations what the majority of users is using. Or would like to use if they know it does exists. So what do you suggest: a Tip of the day or a user choice during first start-up? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'distro/collabora/co-4-2' - loleaflet/src
loleaflet/src/control/Control.StatusBar.js |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c41bb0f40c5b71eda323544f3d246b7053cdf07e Author: gokaysatir AuthorDate: Thu Jul 16 12:57:37 2020 +0300 Commit: Aron Budea CommitDate: Mon Aug 10 02:11:22 2020 +0200 loleaflet: Status bar quick views don't work. Change-Id: I68253955a97a79f7ccfecff9d3e26cb5e4a2032b Reviewed-on: https://gerrit.libreoffice.org/c/online/+/9 Tested-by: Jenkins Tested-by: Jenkins CollaboraOffice Reviewed-by: Henry Castro (cherry picked from commit bd28756cde488747bac8f2d1e08d100f974468e9) Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100355 Reviewed-by: Aron Budea diff --git a/loleaflet/src/control/Control.StatusBar.js b/loleaflet/src/control/Control.StatusBar.js index 59f567ad7..e9696243d 100644 --- a/loleaflet/src/control/Control.StatusBar.js +++ b/loleaflet/src/control/Control.StatusBar.js @@ -169,7 +169,7 @@ L.Control.StatusBar = L.Control.extend({ } }; this.map.sendUnoCommand('.uno:StatusBarFunc', command); - }); + }.bind(this)); } else if (id === 'userlist') { this.map.fire('openuserlist'); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 34058] Translation feature through external services
https://bugs.documentfoundation.org/show_bug.cgi?id=34058 --- Comment #15 from paulyste...@web.de --- extensions/tradutorlibretext do not go in LO 6.3 and 6.4 and 7.0 x64 on win 10-64 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 32228] Encoding problem when reading some XLS files produced by Microsoft Excel 2008 for Mac
https://bugs.documentfoundation.org/show_bug.cgi?id=32228 --- Comment #13 from paulyste...@web.de --- in 7.0.0.3 64bit in windows 10 x64 solved for me both files -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104878] Impress works very slow with large sized GIF
https://bugs.documentfoundation.org/show_bug.cgi?id=104878 --- Comment #54 from paulyste...@web.de --- Version: 7.0.0.3 (x64) windows10-64 looks ok in 7.0 , in 6.4 example was very frozen. a workaround for older versions is disabling run of animated pictures in options when performance is slow. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135501] Change the default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=135501 --- Comment #56 from V Stuart Foote --- (In reply to John Mills from comment #55) Well as most of those questions are obviously rhetorical--I won't bother. Suffice to say that as demonstrated by this UX-advise BZ issue--user expectations often may diverge from practical considerations of what is in the best interest of LibreOffice as an ODF-centric cross-platform Office program. Changing the default "standard" UI to the current MUFFIN NB implementation of a Tabbed UI would have little practical advantage (appearance or function), with potential for substantial regression in UX over our Toolbar/Menu/Dialog UI. Ill-advised on all counts... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 135501] Change the default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=135501 --- Comment #56 from V Stuart Foote --- (In reply to John Mills from comment #55) Well as most of those questions are obviously rhetorical--I won't bother. Suffice to say that as demonstrated by this UX-advise BZ issue--user expectations often may diverge from practical considerations of what is in the best interest of LibreOffice as an ODF-centric cross-platform Office program. Changing the default "standard" UI to the current MUFFIN NB implementation of a Tabbed UI would have little practical advantage (appearance or function), with potential for substantial regression in UX over our Toolbar/Menu/Dialog UI. Ill-advised on all counts... -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 132901] Tools > Options > LibreOffice > Online update does not handle the situation of "online update" feature not being installed gracefully
https://bugs.documentfoundation.org/show_bug.cgi?id=132901 baffclan changed: What|Removed |Added CC||news.distman@quantentunnel. ||de --- Comment #9 from baffclan --- *** Bug 135587 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135587] Crash when open Options > Online update
https://bugs.documentfoundation.org/show_bug.cgi?id=135587 baffclan changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from baffclan --- *** This bug has been marked as a duplicate of bug 132901 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131620] Unable to enter accented characters in Calc, Page properties, Header (Linux-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=131620 --- Comment #5 from Jorge Gustavo Rocha --- Still present in version 7.0.0.3. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135584] Crash - long document with tables
https://bugs.documentfoundation.org/show_bug.cgi?id=135584 Telesto changed: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #3 from Telesto --- @Xisco Private doc situation.. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: offapi/com slideshow/Library_slideshow.mk slideshow/source
offapi/com/sun/star/animations/AnimationNodeType.idl |3 slideshow/Library_slideshow.mk |1 slideshow/source/engine/animationfactory.cxx | 314 -- slideshow/source/engine/animationnodes/animationcolornode.cxx |6 slideshow/source/engine/animationnodes/animationnodefactory.cxx|6 slideshow/source/engine/animationnodes/animationpathmotionnode.cxx |3 slideshow/source/engine/animationnodes/animationphysicsnode.cxx| 48 + slideshow/source/engine/animationnodes/animationphysicsnode.hxx| 54 + slideshow/source/engine/animationnodes/animationsetnode.cxx|5 slideshow/source/engine/animationnodes/animationtransformnode.cxx |9 slideshow/source/engine/animationnodes/propertyanimationnode.cxx | 15 slideshow/source/engine/box2dtools.cxx | 66 +- slideshow/source/engine/slide/slideimpl.cxx|7 slideshow/source/engine/slideshowcontext.cxx |6 slideshow/source/engine/slideshowimpl.cxx |8 slideshow/source/engine/transitions/shapetransitionfactory.cxx |3 slideshow/source/inc/animationfactory.hxx | 16 slideshow/source/inc/box2dtools.hxx| 48 - slideshow/source/inc/slideshowcontext.hxx |7 19 files changed, 542 insertions(+), 83 deletions(-) New commits: commit 28022cee396715bc4b474ed1571074dc721bbe13 Author: Sarper Akdemir AuthorDate: Thu Jun 11 19:29:38 2020 +0300 Commit: Thorsten Behrens CommitDate: Sun Aug 9 23:44:00 2020 +0200 make physics based animation effects part of the animation engine Wiring up and creating required classes for physics based animation effects to be part of the animation engine. Creating a new animation node AnimationPhysicsNode for physics based animation effects and PhysicsAnimation class that inherits the NumberAnimation in the animation factory. Change-Id: I1f125df5324673e9937b8164c0fc267c9683afa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100151 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/offapi/com/sun/star/animations/AnimationNodeType.idl b/offapi/com/sun/star/animations/AnimationNodeType.idl index 31bed11ff728..d0cd6e268fd6 100644 --- a/offapi/com/sun/star/animations/AnimationNodeType.idl +++ b/offapi/com/sun/star/animations/AnimationNodeType.idl @@ -68,6 +68,9 @@ constants AnimationNodeType /** Defines a command effect. */ const short COMMAND = 11; +/** Defines a physics animation */ +const short ANIMATEPHYSICS = 12; + }; diff --git a/slideshow/Library_slideshow.mk b/slideshow/Library_slideshow.mk index 53324ea25dcc..3ff098c01639 100644 --- a/slideshow/Library_slideshow.mk +++ b/slideshow/Library_slideshow.mk @@ -75,6 +75,7 @@ $(eval $(call gb_Library_add_exception_objects,slideshow,\ slideshow/source/engine/animationnodes/animationnodefactory \ slideshow/source/engine/animationnodes/animationpathmotionnode \ slideshow/source/engine/animationnodes/animationsetnode \ +slideshow/source/engine/animationnodes/animationphysicsnode \ slideshow/source/engine/animationnodes/animationtransformnode \ slideshow/source/engine/animationnodes/animationtransitionfilternode \ slideshow/source/engine/animationnodes/basecontainernode \ diff --git a/slideshow/source/engine/animationfactory.cxx b/slideshow/source/engine/animationfactory.cxx index f81c37b77df3..bc1848f68435 100644 --- a/slideshow/source/engine/animationfactory.cxx +++ b/slideshow/source/engine/animationfactory.cxx @@ -35,6 +35,7 @@ #include #include +#include using namespace ::com::sun::star; @@ -203,7 +204,8 @@ namespace slideshow::internal sal_Int16nAdditive, const ShapeManagerSharedPtr& rShapeManager, const ::basegfx::B2DVector& rSlideSize, - int nFlags ) : + int nFlags, + const box2d::utils::Box2DWorldSharedPtr& pBox2DWorld ) : maPathPoly(), mpShape(), mpAttrLayer(), @@ -212,7 +214,8 @@ namespace slideshow::internal maShapeOrig(), mnFlags( nFlags ), mbAnimationStarted( false ), -mnAdditive( nAdditive ) +mnAdditive( nAdditive ), +mpBox2DWorld( pBox2DWorld ) { ENSURE_OR_THROW( rShapeManager, "PathAnimation::PathAnimation(): Invalid ShapeManager" ); @@ -283,6 +286,10 @@ namespace
[Libreoffice-bugs] [Bug 135583] FILEOPEN RTF: Image jumps out of table when pressing arrow up (no free movement)
https://bugs.documentfoundation.org/show_bug.cgi?id=135583 --- Comment #5 from Telesto --- This might partly caused by page wrap being converted to non (or imported as such). But even re-enabling page wrap makes the behaviour being off, IMHO -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - cui/uiconfig svx/source
cui/uiconfig/ui/borderareatransparencydialog.ui |1 + svx/source/dialog/hdft.cxx |5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) New commits: commit daad7e238bdcd39c332e255fc4feeb49afb26de9 Author: Caolán McNamara AuthorDate: Mon Mar 2 11:22:49 2020 + Commit: Aron Budea CommitDate: Sun Aug 9 23:40:38 2020 +0200 Resolves: tdf#131041 crash on async border dialog Change-Id: Ia9f5f02a0993c3b28ca5fecef3ce6333ba85806b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89823 Tested-by: Jenkins Reviewed-by: Caolán McNamara (cherry picked from commit fd55510992800d18d04f3c54bd2ad0e0eb62d9ab) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100411 Tested-by: Jenkins CollaboraOffice Reviewed-by: Aron Budea diff --git a/cui/uiconfig/ui/borderareatransparencydialog.ui b/cui/uiconfig/ui/borderareatransparencydialog.ui index 9e8ff3623d74..00957753639c 100644 --- a/cui/uiconfig/ui/borderareatransparencydialog.ui +++ b/cui/uiconfig/ui/borderareatransparencydialog.ui @@ -7,6 +7,7 @@ 6 Border / Background False +True dialog diff --git a/svx/source/dialog/hdft.cxx b/svx/source/dialog/hdft.cxx index b92dc46e8deb..82f815cf3625 100644 --- a/svx/source/dialog/hdft.cxx +++ b/svx/source/dialog/hdft.cxx @@ -619,12 +619,12 @@ IMPL_LINK_NOARG(SvxHFPage, BackgroundHdl, weld::Button&, void) SvxAbstractDialogFactory* pFact = SvxAbstractDialogFactory::Create(); -ScopedVclPtr pDlg(pFact->CreateSvxBorderBackgroundDlg( +VclPtr pDlg(pFact->CreateSvxBorderBackgroundDlg( GetFrameWeld(), *pBBSet, mbEnableDrawingLayerFillStyles)); -pDlg->StartExecuteAsync([&](sal_Int32 nResult) { +pDlg->StartExecuteAsync([pDlg, this](sal_Int32 nResult) { if (nResult == RET_OK && pDlg->GetOutputItemSet()) { SfxItemIter aIter(*pDlg->GetOutputItemSet()); @@ -676,6 +676,7 @@ IMPL_LINK_NOARG(SvxHFPage, BackgroundHdl, weld::Button&, void) } } } +pDlg->disposeOnce(); }); UpdateExample(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135566] Writer loses paragraph when editing RTL text with track, invisible changes
https://bugs.documentfoundation.org/show_bug.cgi?id=135566 --- Comment #4 from Eyal Rozenberg --- > Also, I believe the loss only happens when I make deletions or overwrites, > not additions. And it is certainly not consistent, i.e. most deletions and > overwrites do work. Maybe it's actually an "Undo" operation rather than a deletion. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135584] Crash - long document with tables
https://bugs.documentfoundation.org/show_bug.cgi?id=135584 --- Comment #2 from Marcin Segit --- Same behavior with Skia forced software rendering turned on. I didn't even have to click on anything as Writer crashed on itself after a minute or two. I also copied the content to a fresh document and saved it into odt, rtf and docx. Same thing, Writer crashes as with the original document with all three formats. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132901] Tools > Options > LibreOffice > Online update does not handle the situation of "online update" feature not being installed gracefully
https://bugs.documentfoundation.org/show_bug.cgi?id=132901 Mike Kaganski changed: What|Removed |Added CC||cl...@documentfoundation.or ||g --- Comment #8 from Mike Kaganski --- ... and building MSI for current master produces all three entries ... May cloph have any idea what is different in the generation of MSI package? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135514] identical formulae give different values
https://bugs.documentfoundation.org/show_bug.cgi?id=135514 --- Comment #3 from tor...@yahoo.com --- (In reply to m.a.riosv from comment #1) > Seems the file was saved in a inconsistent state. What is that? If LO saves in such a state, is this not a bug? > Doing a hard-recalc Menu/Data/Calculate/Recalculate hard, solves the issue. That's a work-around, it does not ‘solve the issue’—which result can be trusted and when is a result wrong? Actually, selecting B25 and hitting f9 recalculates —not ‘hard’. But why should I suspect this formula (or any other) needs recalculation? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104685] Item gets pasted on the next page (and out of border)
https://bugs.documentfoundation.org/show_bug.cgi?id=104685 Telesto changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104685] Item gets pasted on the next page (and out of border)
https://bugs.documentfoundation.org/show_bug.cgi?id=104685 Thomas Lendo changed: What|Removed |Added CC||thomas.le...@gmail.com --- Comment #6 from Thomas Lendo --- Repro with Version: 7.1.0.0.alpha0+ CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3 Locale: de-DE (de_DE.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-08-05_04:03:50 Calc: threaded But this is not a bug in my view because I see a page break in the (copied) table properties. Then this is a normal behavior. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135589] More or less text on a page depending on position of image moving up down on an nearly empty page
https://bugs.documentfoundation.org/show_bug.cgi?id=135589 Mike Kaganski changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED --- Comment #3 from Mike Kaganski --- The image moves not by the height of paragraphs. Thus the spacing between the previous paragraph and the image constantly changes; while the paragraph below starts right after the image. So the spacing between previous paragraph and the next one changes because of positioning of the image. No rounding problems here. Displaying formatting marks while moving the image might make this obvious. NOTABUG. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 135501] Change the default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=135501 --- Comment #55 from John Mills --- >The MUFFIN Notebook Bar framework is limited by the controls, attributes and >actions available implemented as UNO applets. >UNO controls can not be manipulated like Ribbon Class object and any >functional similarity is skin deep. They are not implemented as 'native' >Windows >(UWP/DWM)and so won't function like them--though naive users will >expect them to. Why expose the Windows users to that disappointment--and >cause a lot of grief to the project otherwise when those users say they >"expect" it. Hi Stuart, I'm not sure if you would have any knowledge on this but it is an interesting question to ponder. Do you know if WPS Office is directly programmable for UWP and DWM use on Windows? And does it also integrates well with other Windows controls? If it doesn't then does that hamper the use of the application by 'naive' Windows users who know no better? If it does use these interfaces then do the users of WPS office on MacOS have a poorer user experience than their Windows counterparts? Do the users on Linux also? Do they contact the publisher to report their poorer experience? Are they unable to accomplish their office tasks because of this? I can ask the same question for: SoftmakerOffice Polaris Office FreeOffice OnlyOffice (Desktop client) And a number of Chinese office suites I have forgotten the name of, I'm sure there are others also. Do users of Microsoft Office on Mac also have these issues because they lack of these essential functions? Do users of Microsoft Office 365 web client have this poor user experience are they frustrated and unable to accomplish their tasks? >Rather than wasting project resources on changing default and dealing with >long running support requests, IMHO much more appealing to fix other facets of >the GUI (e.g. Dark Mode support). >And then implement new useful document modes for the Libreoffice GUI handling >of ODF, e.g. Tabbed (bug 33173) or Multi-document (bug 37134) Does the possibility of switching to another user interface such as Tabbed preclude these improvements taking place? Can we only have one of the other? Is it not possible to use a dark mode with notebook bar interfaces? Does the architecture of the Notebook bar solutions preclude this? Maybe it's only a Linux thing but I'm sure that it is possibility to have a dark interface with LibreOffice under Ubuntu. If LibreOffice intended to include document tabs would it not be possible also in one of the notebook bar interfaces? This can only be accomplished in the current shipping interface? Kind regards -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 135501] Change the default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=135501 --- Comment #55 from John Mills --- >The MUFFIN Notebook Bar framework is limited by the controls, attributes and >actions available implemented as UNO applets. >UNO controls can not be manipulated like Ribbon Class object and any >functional similarity is skin deep. They are not implemented as 'native' >Windows >(UWP/DWM)and so won't function like them--though naive users will >expect them to. Why expose the Windows users to that disappointment--and >cause a lot of grief to the project otherwise when those users say they >"expect" it. Hi Stuart, I'm not sure if you would have any knowledge on this but it is an interesting question to ponder. Do you know if WPS Office is directly programmable for UWP and DWM use on Windows? And does it also integrates well with other Windows controls? If it doesn't then does that hamper the use of the application by 'naive' Windows users who know no better? If it does use these interfaces then do the users of WPS office on MacOS have a poorer user experience than their Windows counterparts? Do the users on Linux also? Do they contact the publisher to report their poorer experience? Are they unable to accomplish their office tasks because of this? I can ask the same question for: SoftmakerOffice Polaris Office FreeOffice OnlyOffice (Desktop client) And a number of Chinese office suites I have forgotten the name of, I'm sure there are others also. Do users of Microsoft Office on Mac also have these issues because they lack of these essential functions? Do users of Microsoft Office 365 web client have this poor user experience are they frustrated and unable to accomplish their tasks? >Rather than wasting project resources on changing default and dealing with >long running support requests, IMHO much more appealing to fix other facets of >the GUI (e.g. Dark Mode support). >And then implement new useful document modes for the Libreoffice GUI handling >of ODF, e.g. Tabbed (bug 33173) or Multi-document (bug 37134) Does the possibility of switching to another user interface such as Tabbed preclude these improvements taking place? Can we only have one of the other? Is it not possible to use a dark mode with notebook bar interfaces? Does the architecture of the Notebook bar solutions preclude this? Maybe it's only a Linux thing but I'm sure that it is possibility to have a dark interface with LibreOffice under Ubuntu. If LibreOffice intended to include document tabs would it not be possible also in one of the notebook bar interfaces? This can only be accomplished in the current shipping interface? Kind regards -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135514] identical formulae give different values
https://bugs.documentfoundation.org/show_bug.cgi?id=135514 tor...@yahoo.com changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #2 from tor...@yahoo.com --- Editing the formula B21 without changing it (eg, deleting ‘3’ and restoring it) forces the update of B25 to the correct value. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135580] Remove Euro Converter Wizard from Wizard menu
https://bugs.documentfoundation.org/show_bug.cgi?id=135580 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135589] More or less text on a page depending on position of image moving up down on an nearly empty page
https://bugs.documentfoundation.org/show_bug.cgi?id=135589 Telesto changed: What|Removed |Added CC||jl...@mail.com --- Comment #2 from Telesto --- @Justin Technically not you're type of cake, but you look at this from a different perspective.. I'm only curious what's happening here.. Are this VCL floating pointer error. Or some quirk with anchors. Or image not matching paragraph lines? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135589] New: More or less text on a page depending on position of image moving up down on an nearly empty page
https://bugs.documentfoundation.org/show_bug.cgi?id=135589 Bug ID: 135589 Summary: More or less text on a page depending on position of image moving up down on an nearly empty page Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: More or less text on a page depending on position of image moving up down on an nearly empty page Steps to Reproduce: 1. open the attached file 2. Make sure you can see the whole first page 3. Click the top/ first image on the page 4. Press arrow up until top of the page reached and back down.. notice everything wiggling and sometimes 2 sometimes 3 lines of text on the page Actual Results: 3 or 2 lines of text on a page depending on image position Expected Results: I assume this not being OK.. but who knows. Reproducible: Always User Profile Reset: No Additional Info: Found in 7.1 and in 3.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135589] More or less text on a page depending on position of image moving up down on an nearly empty page
https://bugs.documentfoundation.org/show_bug.cgi?id=135589 --- Comment #1 from Telesto --- Created attachment 164080 --> https://bugs.documentfoundation.org/attachment.cgi?id=164080=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135588] New: Accesebility text in Confirm dialog in Document restore is not announced when using screenreaders
https://bugs.documentfoundation.org/show_bug.cgi?id=135588 Bug ID: 135588 Summary: Accesebility text in Confirm dialog in Document restore is not announced when using screenreaders Product: LibreOffice Version: 6.4.5.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: k...@arcor.de Description: If you choose to dismiss restoring documents, the text within the Confirm dialog is not announced, only the buttons "Yes" or "No" are announced by the screenreader Steps to Reproduce: 1. Crash LibreOffice 2. restart LibreOffice 3. Dissmiss restoring Documents 4. The confirm dialog opens and all you can here from screenreader is "Yes" or "No". Actual Results: Only the buttons (Yes or No) are announced by screenreader. Expected Results: The question, which this dialog asks should be announced. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Working with screenreader NVDA 2020.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135566] Writer loses paragraph when editing RTL text with track, invisible changes
https://bugs.documentfoundation.org/show_bug.cgi?id=135566 --- Comment #3 from Eyal Rozenberg --- Seeing this now also with the LO 7 release version: Version: 7.0.0.3 Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e CPU threads: 4; OS: Linux 5.2; UI render: default; VCL: gtk3 Locale: he-IL (en_IL); UI: en-US -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135571] On screen page layout doesn't match save & reload screen layout (images & anchoring)
https://bugs.documentfoundation.org/show_bug.cgi?id=135571 Telesto changed: What|Removed |Added Version|7.1.0.0.alpha0+ Master |Inherited From OOo --- Comment #2 from Telesto --- Also in 3.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135584] Crash - long document with tables
https://bugs.documentfoundation.org/show_bug.cgi?id=135584 Telesto changed: What|Removed |Added CC||tele...@surfxs.nl --- Comment #1 from Telesto --- Launch LibreOffice -> Tools -> Options -> LibreOffice -> View -> Check Force software rendering They cause could be Skia Vulkan (the document itself could be the cause too, but we have to start somewhere) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134694] LibO changes the text on saving with potential data loss.
https://bugs.documentfoundation.org/show_bug.cgi?id=134694 --- Comment #7 from BogdanB --- After that tried to retest your bug, and if it yet reproductibile please comment hear. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134694] LibO changes the text on saving with potential data loss.
https://bugs.documentfoundation.org/show_bug.cgi?id=134694 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g --- Comment #6 from BogdanB --- Sergio, please go to Help - Restart in Safe Mode - Factory Reset -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/inspectorproperties.hrc|6 + sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx | 89 +++--- 2 files changed, 84 insertions(+), 11 deletions(-) New commits: commit 6ce2eddfdc35100b8079a4584dd3945e923d66a9 Author: Shivam Kumar Singh AuthorDate: Fri Aug 7 13:36:52 2020 +0530 Commit: Mike Kaganski CommitDate: Sun Aug 9 21:50:11 2020 +0200 tdf#135406 - Border properties not properly listed in the Styles Inspector Several Border properties are stored as STRUCT internally. Added support to show them in the Inspector. Change-Id: Ida1014691ab2245eea04487ce753c23bdf0bddb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100288 Reviewed-by: Mike Kaganski Tested-by: Jenkins diff --git a/sw/inc/inspectorproperties.hrc b/sw/inc/inspectorproperties.hrc index 7d9a272d1df2..f51521b30e9e 100644 --- a/sw/inc/inspectorproperties.hrc +++ b/sw/inc/inspectorproperties.hrc @@ -28,7 +28,13 @@ */ // Format names +#define RID_BORDER_COLOR NC_("RID_ATTRIBUTE_NAMES_MAP", "Color") #define RID_BORDER_DISTANCE NC_("RID_ATTRIBUTE_NAMES_MAP", "Border Distance") +#define RID_BORDER_INNER_LINE_WIDTH NC_("RID_ATTRIBUTE_NAMES_MAP", "Inner Line Width") +#define RID_BORDER_LINE_DISTANCE NC_("RID_ATTRIBUTE_NAMES_MAP", "Line Distance") +#define RID_BORDER_LINE_STYLE NC_("RID_ATTRIBUTE_NAMES_MAP", "Line Style") +#define RID_BORDER_LINE_WIDTH NC_("RID_ATTRIBUTE_NAMES_MAP", "Line Width") +#define RID_BORDER_OUTER_LINE_WIDTH NC_("RID_ATTRIBUTE_NAMES_MAP", "Outer Line Width") #define RID_BOTTOM_BORDER NC_("RID_ATTRIBUTE_NAMES_MAP", "Bottom Border") #define RID_BOTTOM_BORDER_DISTANCE NC_("RID_ATTRIBUTE_NAMES_MAP", "Bottom Border Distance") #define RID_BREAK_TYPE NC_("RID_ATTRIBUTE_NAMES_MAP", "Break Type") diff --git a/sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx b/sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx index f63fdc79b8bf..7c10f757edbc 100644 --- a/sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx +++ b/sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx @@ -30,6 +30,7 @@ #include #include #include +#include #include #include @@ -296,6 +297,12 @@ static OUString PropertyNametoRID(const OUString& rName) { "UnvisitedCharStyleName", RID_UNVISITED_CHAR_STYLE_NAME }, { "VisitedCharStyleName", RID_VISITED_CHAR_STYLE_NAME }, { "WritingMode", RID_WRITING_MODE }, +{ "BorderColor", RID_BORDER_COLOR }, +{ "BorderInnerLineWidth", RID_BORDER_INNER_LINE_WIDTH }, +{ "BorderLineDistance", RID_BORDER_LINE_DISTANCE }, +{ "BorderLineStyle", RID_BORDER_LINE_STYLE }, +{ "BorderLineWidth", RID_BORDER_LINE_WIDTH }, +{ "BorderOuterLineWidth", RID_BORDER_OUTER_LINE_WIDTH }, }; auto itr = aNameToRID.find(rName); @@ -304,6 +311,69 @@ static OUString PropertyNametoRID(const OUString& rName) return rName; } +static svx::sidebar::TreeNode SimplePropToTreeNode(const OUString& rName, const css::uno::Any& rVal) +{ +svx::sidebar::TreeNode aCurNode; +aCurNode.sNodeName = PropertyNametoRID(rName); +aCurNode.aValue = rVal; + +return aCurNode; +} + +static svx::sidebar::TreeNode BorderToTreeNode(const OUString& rName, const css::uno::Any& rVal) +{ +table::BorderLine2 aBorder; +rVal >>= aBorder; +svx::sidebar::TreeNode aChild; +svx::sidebar::TreeNode aCurNode; +aCurNode.sNodeName = PropertyNametoRID(rName); +aCurNode.NodeType = svx::sidebar::TreeNode::ComplexProperty; + +aCurNode.children.push_back(SimplePropToTreeNode("BorderColor", css::uno::Any(aBorder.Color))); +aCurNode.children.push_back( +SimplePropToTreeNode("BorderLineWidth", css::uno::Any(aBorder.LineWidth))); +aCurNode.children.push_back( +SimplePropToTreeNode("BorderLineStyle", css::uno::Any(aBorder.LineStyle))); +aCurNode.children.push_back( +SimplePropToTreeNode("BorderLineDistance", css::uno::Any(aBorder.LineDistance))); +aCurNode.children.push_back( +SimplePropToTreeNode("BorderInnerLineWidth", css::uno::Any(aBorder.InnerLineWidth))); +aCurNode.children.push_back( +SimplePropToTreeNode("BorderOuterLineWidth", css::uno::Any(aBorder.OuterLineWidth))); + +return aCurNode; +} + +static svx::sidebar::TreeNode +PropertyToTreeNode(const css::beans::Property& rProperty, + const uno::Reference& xPropertiesSet, const bool& rIsGrey) +{ +const OUString& rPropName = rProperty.Name; +svx::sidebar::TreeNode aCurNode; +const uno::Any aAny =
[Libreoffice-bugs] [Bug 135046] displaying a long menu overlaps the menu bar
https://bugs.documentfoundation.org/show_bug.cgi?id=135046 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g --- Comment #2 from BogdanB --- laurentio, please go to Help - Restart in Safe Mode - Factory Reseting We are waiting for some feedback from you -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134484] errors in printing documents
https://bugs.documentfoundation.org/show_bug.cgi?id=134484 --- Comment #3 from BogdanB --- Trafalgar, we need some feedback from you. It's your problem solved?... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134876] Create absolute range references when pointer-selecting cell ranges in Function Wizard
https://bugs.documentfoundation.org/show_bug.cgi?id=134876 Eike Rathke changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134876] Create absolute range references when pointer-selecting cell ranges in Function Wizard
https://bugs.documentfoundation.org/show_bug.cgi?id=134876 --- Comment #6 from Commit Notification --- Eike Rathke committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3b5fccb308b9554d024e1d576abbf3ebec26b7a5 Resolves: tdf#134876 Absolute range references when selecting in Wizard It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134876] Create absolute range references when pointer-selecting cell ranges in Function Wizard
https://bugs.documentfoundation.org/show_bug.cgi?id=134876 Commit Notification changed: What|Removed |Added Whiteboard||target:7.1.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/formdlg/formula.cxx | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) New commits: commit 3b5fccb308b9554d024e1d576abbf3ebec26b7a5 Author: Eike Rathke AuthorDate: Thu Aug 6 19:40:58 2020 +0200 Commit: Eike Rathke CommitDate: Sun Aug 9 21:46:00 2020 +0200 Resolves: tdf#134876 Absolute range references when selecting in Wizard Not doing the same for ScInputHandler::SetReference() now because selecting by keyboard is more likely to keep the existing behaviour and is easily edited to change. Change-Id: I368aa21c7f1099d175805493c92070da280cafa4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100267 Tested-by: Jenkins Reviewed-by: Eike Rathke diff --git a/sc/source/ui/formdlg/formula.cxx b/sc/source/ui/formdlg/formula.cxx index de2c41cfed0b..c21a8d859cbc 100644 --- a/sc/source/ui/formdlg/formula.cxx +++ b/sc/source/ui/formdlg/formula.cxx @@ -406,6 +406,16 @@ void ScFormulaDlg::SetReference( const ScRange& rRef, ScDocument& rRefDoc ) RefInputStart(GetActiveEdit()); } +// Pointer-selected => absolute range references for the non-single +// dimensions, so in the other dimension (if any) it's still +// copy-adjustable. +constexpr ScRefFlags eColFlags = ScRefFlags::COL_ABS | ScRefFlags::COL2_ABS; +constexpr ScRefFlags eRowFlags = ScRefFlags::ROW_ABS | ScRefFlags::ROW2_ABS; +ScRefFlags eRangeFlags = ScRefFlags::ZERO; +if (rRef.aStart.Col() != rRef.aEnd.Col()) +eRangeFlags |= eColFlags; +if (rRef.aStart.Row() != rRef.aEnd.Row()) +eRangeFlags |= eRowFlags; OUString aRefStr; bool bOtherDoc = ( != m_pDoc && rRefDoc.GetDocumentShell()->HasName()); if ( bOtherDoc ) @@ -414,8 +424,8 @@ void ScFormulaDlg::SetReference( const ScRange& rRef, ScDocument& rRefDoc ) OSL_ENSURE(rRef.aStart.Tab()==rRef.aEnd.Tab(), "nStartTab!=nEndTab"); -// Always 3D and absolute. -OUString aTmp( rRef.Format(rRefDoc, ScRefFlags::VALID | ScRefFlags::TAB_ABS_3D)); +// Sheet always 3D and absolute. +OUString aTmp( rRef.Format(rRefDoc, ScRefFlags::VALID | ScRefFlags::TAB_ABS_3D | eRangeFlags)); SfxObjectShell* pObjSh = rRefDoc.GetDocumentShell(); @@ -433,6 +443,16 @@ void ScFormulaDlg::SetReference( const ScRange& rRef, ScDocument& rRefDoc ) ScTokenArray aArray(); ScComplexRefData aRefData; aRefData.InitRangeRel(, rRef, m_CursorPos); +if ((eRangeFlags & eColFlags) == eColFlags) +{ +aRefData.Ref1.SetAbsCol( rRef.aStart.Col() ); +aRefData.Ref2.SetAbsCol( rRef.aEnd.Col() ); +} +if ((eRangeFlags & eRowFlags) == eRowFlags) +{ +aRefData.Ref1.SetAbsRow( rRef.aStart.Row() ); +aRefData.Ref2.SetAbsRow( rRef.aEnd.Row() ); +} bool bSingle = aRefData.Ref1 == aRefData.Ref2; if (m_CursorPos.Tab() != rRef.aStart.Tab()) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135548] EDITING: cosmetic glitch when edit a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=135548 --- Comment #1 from news.dist...@quantentunnel.de --- When select Tools -> Options -> LibreOffice -> View -> Check Force Skia Software rendering it looks good -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: dbaccess/inc dbaccess/source dbaccess/uiconfig dbaccess/UIConfig_dbaccess.mk solenv/sanitizers
dbaccess/UIConfig_dbaccess.mk|2 dbaccess/inc/pch/precompiled_dba.hxx |6 - dbaccess/inc/pch/precompiled_dbu.hxx |4 dbaccess/inc/strings.hrc |1 dbaccess/source/ui/app/AppDetailView.cxx | 156 --- dbaccess/source/ui/app/AppDetailView.hxx | 64 dbaccess/uiconfig/ui/creationlistbox.ui | 71 -- dbaccess/uiconfig/ui/taskwindow.ui | 147 + solenv/sanitizers/ui/dbaccess.suppr |1 9 files changed, 218 insertions(+), 234 deletions(-) New commits: commit 72aeda11bd1acbe5d9224eae0d22265630ebb0b8 Author: Caolán McNamara AuthorDate: Fri Aug 7 11:11:51 2020 +0100 Commit: Caolán McNamara CommitDate: Sun Aug 9 21:43:35 2020 +0200 weld OTasksWindow moving the InterimItemWindow one layer higher Change-Id: I500da55f4d4bf4dd31583c9c055564cf299a2166 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100304 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/dbaccess/UIConfig_dbaccess.mk b/dbaccess/UIConfig_dbaccess.mk index 2a0770c184c9..feaa35c10708 100644 --- a/dbaccess/UIConfig_dbaccess.mk +++ b/dbaccess/UIConfig_dbaccess.mk @@ -21,7 +21,6 @@ $(eval $(call gb_UIConfig_add_uifiles,dbaccess, \ dbaccess/uiconfig/ui/colwidthdialog \ dbaccess/uiconfig/ui/connectionpage \ dbaccess/uiconfig/ui/copytablepage \ -dbaccess/uiconfig/ui/creationlistbox \ dbaccess/uiconfig/ui/dbaseindexdialog \ dbaccess/uiconfig/ui/dbasepage \ dbaccess/uiconfig/ui/dbwizconnectionpage \ @@ -75,6 +74,7 @@ $(eval $(call gb_UIConfig_add_uifiles,dbaccess, \ dbaccess/uiconfig/ui/tablesfilterdialog \ dbaccess/uiconfig/ui/tablesfilterpage \ dbaccess/uiconfig/ui/tablesjoindialog \ +dbaccess/uiconfig/ui/taskwindow \ dbaccess/uiconfig/ui/textconnectionsettings \ dbaccess/uiconfig/ui/textpage \ dbaccess/uiconfig/ui/typeselectpage \ diff --git a/dbaccess/inc/pch/precompiled_dba.hxx b/dbaccess/inc/pch/precompiled_dba.hxx index d3d1a3fdc511..a09675bc8cdf 100644 --- a/dbaccess/inc/pch/precompiled_dba.hxx +++ b/dbaccess/inc/pch/precompiled_dba.hxx @@ -13,7 +13,7 @@ manual changes will be rewritten by the next run of update_pch.sh (which presumably also fixes all possible problems, so it's usually better to use it). - Generated on 2020-07-09 17:06:21 using: + Generated on 2020-08-07 11:34:54 using: ./bin/update_pch dbaccess dba --cutoff=6 --exclude:system --include:module --include:local If after updating build fails, use the following command to locate conflicting headers: @@ -68,14 +68,12 @@ #include #include #include -#include #include #include #include #include #include #include -#include #include #include #include @@ -182,7 +180,6 @@ #include #include #include -#include #include #include #include @@ -240,7 +237,6 @@ #include #include #include -#include #include #include #include diff --git a/dbaccess/inc/pch/precompiled_dbu.hxx b/dbaccess/inc/pch/precompiled_dbu.hxx index 7464063da918..41a2c2b08bcc 100644 --- a/dbaccess/inc/pch/precompiled_dbu.hxx +++ b/dbaccess/inc/pch/precompiled_dbu.hxx @@ -13,7 +13,7 @@ manual changes will be rewritten by the next run of update_pch.sh (which presumably also fixes all possible problems, so it's usually better to use it). - Generated on 2020-07-09 17:06:22 using: + Generated on 2020-08-07 11:35:01 using: ./bin/update_pch dbaccess dbu --cutoff=12 --exclude:system --exclude:module --exclude:local If after updating build fails, use the following command to locate conflicting headers: @@ -78,6 +78,7 @@ #include #include #include +#include #include #include #include @@ -202,6 +203,7 @@ #endif // PCH_LEVEL >= 3 #if PCH_LEVEL >= 4 #include +#include #include #include #include diff --git a/dbaccess/inc/strings.hrc b/dbaccess/inc/strings.hrc index 16b1ad7b3ab5..2ccc5a666717 100644 --- a/dbaccess/inc/strings.hrc +++ b/dbaccess/inc/strings.hrc @@ -180,7 +180,6 @@ #define RID_STR_VIEWS_HELP_TEXT_DESIGN NC_("RID_STR_VIEWS_HELP_TEXT_DESIGN", "Create a view by specifying the tables and field names you would like to have visible." ) #define STR_DATABASENC_("STR_DATABASE", "Database" ) #define STR_TASKS NC_("STR_TASKS", "Tasks" ) -#define STR_DESCRIPTION NC_("STR_DESCRIPTION", "Description" ) #define STR_PREVIEW NC_("STR_PREVIEW", "Preview" ) #define STR_QUERY_CLOSEDOCUMENTS NC_("STR_QUERY_CLOSEDOCUMENTS", "The connection type has been altered.\n" \ "For the changes to take effect, all forms, reports, queries and tables must be closed.\n\n" \ diff --git a/dbaccess/source/ui/app/AppDetailView.cxx
[Libreoffice-bugs] [Bug 135501] Change the default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=135501 --- Comment #54 from Telesto --- (In reply to V Stuart Foote from comment #53) > (In reply to Telesto from comment #52) > > > (In reply to V Stuart Foote from comment #6) > > > No this is pragmatic--the MUFFIN Tabbed NB only looks like the MS Ribbon > > > UI > > > it does not implement that API. > > > > I'm not all know in feature richness of the Ribbon interface. So what are > > you exactly pointing too? Live Preview? Or also other things? > > Have a look, the MS Ribbon Class [1] is fully implemented API for GUI > development in source (or for user scripted GUI customization). Every facet > of the MS Ribbon UI is directly programmable for UWP or DWM use, and then > integrates well with other MS Windows controls. If with they tabbed bar certain unrealistic expectations are raised automatically, it might be a problem. OTOH, if people dislike simply they the UI it would solve a problem. And this is delivered by the beloved competitors too (excluding MS Office). Do the competitors have real Ribbon, Or are those also superficial imitations (Didnt' check) And I really don't know what people look for.. a similar layout or similar functioning. There must be quite a group who doesn't use the 'advanced' programmable stuff. They only want something what they have seen before And there is quite some time spend on all those interfaces already :-). So my impression is that not so many resources are needed to finalize it; being a tabbed toolbar (not Ribbon). Without the intention of becoming a Ribbon in the short or mid term. I do know that some people are complaining about 'LibreOffice' looking like they '90's. And this might cause the impression of LibreOffice being dated. Not sure how large the whole group is assessing it this way. However there surely a need to prevent the wrong expectations arising (expectation management). This can partly be solved by some additional lines in the Release notes explaining... But sure, there are many sides to this. If opted for tabbed, it really should be over the full line.. So including Linux (on any environment). If Linux distro's want to tweak it, fine.. but the TDF release should be the same for all environments.. (Screenshot on the internet and documentation etc).. Pre-requisite are surely a11y support, nice aesthetics and proper documentation, IMHO. And it should be more or less bug free of course. Fortunately it's not up to me ;-). It's surely not simple yes/no answer. There a pro/cons. My wish list (or should I say reported bug list/regression list) is pretty long. I would love (some of) those being fixed.. Even before new features are added. Anyhow I see no objection for a (temporal) experiment on Master and/or Beta 1 and 2 and maybe one or 2 RC's. Simple to see what happens.. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 135501] Change the default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=135501 --- Comment #54 from Telesto --- (In reply to V Stuart Foote from comment #53) > (In reply to Telesto from comment #52) > > > (In reply to V Stuart Foote from comment #6) > > > No this is pragmatic--the MUFFIN Tabbed NB only looks like the MS Ribbon > > > UI > > > it does not implement that API. > > > > I'm not all know in feature richness of the Ribbon interface. So what are > > you exactly pointing too? Live Preview? Or also other things? > > Have a look, the MS Ribbon Class [1] is fully implemented API for GUI > development in source (or for user scripted GUI customization). Every facet > of the MS Ribbon UI is directly programmable for UWP or DWM use, and then > integrates well with other MS Windows controls. If with they tabbed bar certain unrealistic expectations are raised automatically, it might be a problem. OTOH, if people dislike simply they the UI it would solve a problem. And this is delivered by the beloved competitors too (excluding MS Office). Do the competitors have real Ribbon, Or are those also superficial imitations (Didnt' check) And I really don't know what people look for.. a similar layout or similar functioning. There must be quite a group who doesn't use the 'advanced' programmable stuff. They only want something what they have seen before And there is quite some time spend on all those interfaces already :-). So my impression is that not so many resources are needed to finalize it; being a tabbed toolbar (not Ribbon). Without the intention of becoming a Ribbon in the short or mid term. I do know that some people are complaining about 'LibreOffice' looking like they '90's. And this might cause the impression of LibreOffice being dated. Not sure how large the whole group is assessing it this way. However there surely a need to prevent the wrong expectations arising (expectation management). This can partly be solved by some additional lines in the Release notes explaining... But sure, there are many sides to this. If opted for tabbed, it really should be over the full line.. So including Linux (on any environment). If Linux distro's want to tweak it, fine.. but the TDF release should be the same for all environments.. (Screenshot on the internet and documentation etc).. Pre-requisite are surely a11y support, nice aesthetics and proper documentation, IMHO. And it should be more or less bug free of course. Fortunately it's not up to me ;-). It's surely not simple yes/no answer. There a pro/cons. My wish list (or should I say reported bug list/regression list) is pretty long. I would love (some of) those being fixed.. Even before new features are added. Anyhow I see no objection for a (temporal) experiment on Master and/or Beta 1 and 2 and maybe one or 2 RC's. Simple to see what happens.. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 135587] Crash when open Options > Online update
https://bugs.documentfoundation.org/show_bug.cgi?id=135587 --- Comment #1 from news.dist...@quantentunnel.de --- Created attachment 164079 --> https://bugs.documentfoundation.org/attachment.cgi?id=164079=edit Screnshot of the crash message -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135587] New: Crash when open Options > Online update
https://bugs.documentfoundation.org/show_bug.cgi?id=135587 Bug ID: 135587 Summary: Crash when open Options > Online update Product: LibreOffice Version: 7.0.0.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: news.dist...@quantentunnel.de Description: When I open the options and click on Libreoffice > "Online-Update" it crash. It doesn't matter which module (Calc, Writer, ...) is loaded. It happen also when no modul is loaded. Steps to Reproduce: 1. Start Libreoffice 2. open the Options 3. Click on LibreOffice > Online-Update Actual Results: The whole Libreoffice crash. Message: LibreOffice 7.0 - Fatal Error cannot find /org.openoffice.OfficeJobs/Jobs/UpdateCheck/Arguments Expected Results: Do not crash Reproducible: Always User Profile Reset: No Additional Info: Version: 7.0.0.3 (x64) Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e CPU-Threads: 4; BS: Windows 10.0 Build 18363; UI-Render: Skia/Vulkan; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135586] New: Accessebility Quotes are not announced when working with screenreaders
https://bugs.documentfoundation.org/show_bug.cgi?id=135586 Bug ID: 135586 Summary: Accessebility Quotes are not announced when working with screenreaders Product: LibreOffice Version: 6.4.5.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: k...@arcor.de Description: When working with screenreaders, quotes, no matters if in Charakters or in paragraphs are not annouced. Steps to Reproduce: 1.Open Writer 2. Create a quote, no matter character or paraph formated. 3.read the text with, for example, with Screenreader NVDA. Actual Results: When reading to text which contains a quote, no quote is announced. Expected Results: Announcment of the quote. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Detected with screenreader NVDA 2020.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135585] New: Accessiblity To short announcements in options for auto correctionwhen working with screenreader
https://bugs.documentfoundation.org/show_bug.cgi?id=135585 Bug ID: 135585 Summary: Accessiblity To short announcements in options for auto correctionwhen working with screenreader Product: LibreOffice Version: 6.4.5.2 release Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: k...@arcor.de Description: When opening the options for auto correctionthere is no announcements only "checkobox" is said by the screenreader Steps to Reproduce: 1.Open Writer 2.Move gto "Extrax", Auto Correction and select to "Auto Correct Options" 3. Actual Results: The screenreader says "Checkbox" and some other fields but no description. Expected Results: Announcement what the checkbox and the other fields do. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Using NVDA 2020.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135584] New: Crash - long document with tables
https://bugs.documentfoundation.org/show_bug.cgi?id=135584 Bug ID: 135584 Summary: Crash - long document with tables Product: LibreOffice Version: 7.0.0.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: s...@onet.pl Description: Writer crashes when I try to work with a long document - 218 pages of translation tables exported from TRADOS. Writer crashes upon clicking any of the menus, go to page on the bottom bar or randomly without any extensive menu interaction. It crashes regardless of hardware acceleration or Skia turned on, with the file in docx, rtf and odt formats. Steps to Reproduce: 1. Open document. 2. Click any options, usually it crashes after go to page selection. It should crash. Actual Results: Writer crashes. Sometimes recovery mode and crash report freeze as well. Expected Results: I can operate the menus and work on the document. Reproducible: Always User Profile Reset: No Additional Info: I'm not able to attach the file as it's a proprietary translation. I can. however, gather logs and other info - just let me know what needs to be done. Version: 7.0.0.3 (x64) Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e CPU threads: 16; OS: Windows 10.0 Build 19041; UI render: Skia/Vulkan; VCL: win Locale: pl-PL (pl_PL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135551] =min() wrong results and intelerance to text in fields
https://bugs.documentfoundation.org/show_bug.cgi?id=135551 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||108827 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108827 [Bug 108827] [META] Calc functions bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108827] [META] Calc functions bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108827 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||135551 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135551 [Bug 135551] =min() wrong results and intelerance to text in fields -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135551] =min() wrong results and intelerance to text in fields
https://bugs.documentfoundation.org/show_bug.cgi?id=135551 --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Created attachment 164078 --> https://bugs.documentfoundation.org/attachment.cgi?id=164078=edit File from description -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103152] [META] Writer image bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103152 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||135574 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135574 [Bug 135574] Image hidden after selecting image and pressing down arrow key twice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135574] Image hidden after selecting image and pressing down arrow key twice
https://bugs.documentfoundation.org/show_bug.cgi?id=135574 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||103152 Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Keywords||regression --- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> --- (In reply to Roman Kuznetsov from comment #3) > no problem in > > Version: 7.0.0.3 (x64) > Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e > Потоков ЦП: 4; ОС: Windows 6.1 Service Pack 1 Build 7601; Отрисовка ИП: > Skia/Vulkan; VCL: win > Locale: ru-RU (ru_RU); ИП: ru-RU > Calc: CL > > but when I press arrow up button, then the image moves down! but repro in Version: 7.1.0.0.alpha0+ (x64) Build ID: CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Vulkan; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL image moves up and became hidden, regression Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103152 [Bug 103152] [META] Writer image bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135501] Change the default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=135501 --- Comment #53 from V Stuart Foote --- (In reply to Telesto from comment #52) > (In reply to V Stuart Foote from comment #6) > > No this is pragmatic--the MUFFIN Tabbed NB only looks like the MS Ribbon UI > > it does not implement that API. > > I'm not all know in feature richness of the Ribbon interface. So what are > you exactly pointing too? Live Preview? Or also other things? Have a look, the MS Ribbon Class [1] is fully implemented API for GUI development in source (or for user scripted GUI customization). Every facet of the MS Ribbon UI is directly programmable for UWP or DWM use, and then integrates well with other MS Windows controls. The MUFFIN Notebook Bar framework is limited by the controls, attributes and actions available implemented as UNO applets. UNO controls can not be manipulated like Ribbon Class object and any functional similarity is skin deep. They are not implemented as 'native' Windows (UWP/DWM) and so won't function like them--though naive users will expect them to. Why expose the Windows users to that disappointment--and cause a lot of grief to the project otherwise when those users say they "expect" it. Rather than wasting project resources on changing default and dealing with long running support requests, IMHO much more appealing to fix other facets of the GUI (e.g. Dark Mode support). And then implement new useful document modes for the Libreoffice GUI handling of ODF, e.g. Tabbed (bug 33173) or Multi-document (bug 37134) =-ref-= [1] https://docs.microsoft.com/en-us/dotnet/api/system.windows.controls.ribbon.ribbon?view=netframework-4.8 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 135501] Change the default UI
https://bugs.documentfoundation.org/show_bug.cgi?id=135501 --- Comment #53 from V Stuart Foote --- (In reply to Telesto from comment #52) > (In reply to V Stuart Foote from comment #6) > > No this is pragmatic--the MUFFIN Tabbed NB only looks like the MS Ribbon UI > > it does not implement that API. > > I'm not all know in feature richness of the Ribbon interface. So what are > you exactly pointing too? Live Preview? Or also other things? Have a look, the MS Ribbon Class [1] is fully implemented API for GUI development in source (or for user scripted GUI customization). Every facet of the MS Ribbon UI is directly programmable for UWP or DWM use, and then integrates well with other MS Windows controls. The MUFFIN Notebook Bar framework is limited by the controls, attributes and actions available implemented as UNO applets. UNO controls can not be manipulated like Ribbon Class object and any functional similarity is skin deep. They are not implemented as 'native' Windows (UWP/DWM) and so won't function like them--though naive users will expect them to. Why expose the Windows users to that disappointment--and cause a lot of grief to the project otherwise when those users say they "expect" it. Rather than wasting project resources on changing default and dealing with long running support requests, IMHO much more appealing to fix other facets of the GUI (e.g. Dark Mode support). And then implement new useful document modes for the Libreoffice GUI handling of ODF, e.g. Tabbed (bug 33173) or Multi-document (bug 37134) =-ref-= [1] https://docs.microsoft.com/en-us/dotnet/api/system.windows.controls.ribbon.ribbon?view=netframework-4.8 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 135574] Image hidden after selecting image and pressing down arrow key twice
https://bugs.documentfoundation.org/show_bug.cgi?id=135574 --- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> --- no problem in Version: 7.0.0.3 (x64) Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e Потоков ЦП: 4; ОС: Windows 6.1 Service Pack 1 Build 7601; Отрисовка ИП: Skia/Vulkan; VCL: win Locale: ru-RU (ru_RU); ИП: ru-RU Calc: CL but when I press arrow up button, then the image moves down! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs