[Libreoffice-bugs] [Bug 135594] Unable to access a file in server throu macro
https://bugs.documentfoundation.org/show_bug.cgi?id=135594 --- Comment #2 from karadai...@hotmail.com --- After I reinstalled 6.4.5 everything was OK -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135594] Unable to access a file in server throu macro
https://bugs.documentfoundation.org/show_bug.cgi?id=135594 --- Comment #1 from karadai...@hotmail.com --- After I reinstalled 6.4.5 everything was OK -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135594] Unable to access a file in server throu macro
https://bugs.documentfoundation.org/show_bug.cgi?id=135594 karadai...@hotmail.com changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135503] Vorschlag zur Änderung beim Steuerelement "Schaltfläche"
https://bugs.documentfoundation.org/show_bug.cgi?id=135503 --- Comment #7 from rolf-brigitt...@t-online.de --- Nachdem ich tatsächlich die neueste Version LO 7.0.0.3 ausprobiert habe (es hat nicht funktioniert), habe ich wieder mein LO Vers. 6.1.5 installiert. Dann erhalte ich die genannte Fehlermeldung, LO läßt sich nicht mehr starten! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135503] Vorschlag zur Änderung beim Steuerelement "Schaltfläche"
https://bugs.documentfoundation.org/show_bug.cgi?id=135503 --- Comment #6 from rolf-brigitt...@t-online.de --- Created attachment 164179 --> https://bugs.documentfoundation.org/attachment.cgi?id=164179=edit Fehlermeldung Der Fehlerhinweis kommt beim Programmstart -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135155] FILESAVE DOCX: Image anchored to character not properly aligned
https://bugs.documentfoundation.org/show_bug.cgi?id=135155 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135166] FILEOPEN RTF: A part is marked as deleted change and should be so
https://bugs.documentfoundation.org/show_bug.cgi?id=135166 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135177] FILEOPEN DOCX: Small strip of text behind image (not in source ODT)
https://bugs.documentfoundation.org/show_bug.cgi?id=135177 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135151] Special Paste RTF: Missing image/frames
https://bugs.documentfoundation.org/show_bug.cgi?id=135151 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133649] paste special command when experimental very large spreadsheet option is active will crash
https://bugs.documentfoundation.org/show_bug.cgi?id=133649 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135114] crash when cursor moves off dialog box or collapsing dropdown strands cursor outside dialog box
https://bugs.documentfoundation.org/show_bug.cgi?id=135114 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135197] FILEOPEN DOCX: ODT opens in 2 seconds DOCX 30 seconds
https://bugs.documentfoundation.org/show_bug.cgi?id=135197 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133378] Crash if Print Preview is closed with User Interface “Groupedbar Compact”
https://bugs.documentfoundation.org/show_bug.cgi?id=133378 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135240] Undo restores hidden track changes information
https://bugs.documentfoundation.org/show_bug.cgi?id=135240 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135230] Save Document Dialog Doesn't Allow Keyboard Shortcut
https://bugs.documentfoundation.org/show_bug.cgi?id=135230 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135219] Image anchored as character vanishes from canvas
https://bugs.documentfoundation.org/show_bug.cgi?id=135219 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135205] Crash after deleting some info and undo
https://bugs.documentfoundation.org/show_bug.cgi?id=135205 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135243] Gallery items can be dropped outside they writer canvas (this was impossible with the old gallery items)
https://bugs.documentfoundation.org/show_bug.cgi?id=135243 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135229] Freeze/ hang when moving image in a certain path around
https://bugs.documentfoundation.org/show_bug.cgi?id=135229 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135238] Reject all removes image not included in track changes since 6.3
https://bugs.documentfoundation.org/show_bug.cgi?id=135238 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135206] Lots of layout movement deleting part of a text
https://bugs.documentfoundation.org/show_bug.cgi?id=135206 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135237] Image on wrong page after undo rejecting track changes
https://bugs.documentfoundation.org/show_bug.cgi?id=135237 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135220] Different number of pages/ layout after CTRL+X undo
https://bugs.documentfoundation.org/show_bug.cgi?id=135220 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135227] Empty image frame after moving an image
https://bugs.documentfoundation.org/show_bug.cgi?id=135227 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134415] Text boxes with border lines set or background set don't show up in the slide preview or presentation mode (until text is entered)
https://bugs.documentfoundation.org/show_bug.cgi?id=134415 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135643] In Calc I tried to search for text "simon" in a spreadsheet, using Ctrl-F, entered text, pressed Enter key, crash. EDITING
https://bugs.documentfoundation.org/show_bug.cgi?id=135643 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134415] Text boxes with border lines set or background set don't show up in the slide preview or presentation mode (until text is entered)
https://bugs.documentfoundation.org/show_bug.cgi?id=134415 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134202] Crash upon deleting a heading in a specific document
https://bugs.documentfoundation.org/show_bug.cgi?id=134202 --- Comment #11 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135163] Anchor to paragraph moves to different page
https://bugs.documentfoundation.org/show_bug.cgi?id=135163 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135177] FILEOPEN DOCX: Small strip of text behind image (not in source ODT)
https://bugs.documentfoundation.org/show_bug.cgi?id=135177 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135070] Crash clicking cover page while document is still loading
https://bugs.documentfoundation.org/show_bug.cgi?id=135070 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135643] In Calc I tried to search for text "simon" in a spreadsheet, using Ctrl-F, entered text, pressed Enter key, crash. EDITING
https://bugs.documentfoundation.org/show_bug.cgi?id=135643 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134202] Crash upon deleting a heading in a specific document
https://bugs.documentfoundation.org/show_bug.cgi?id=134202 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123798] libre office tells in a text box that there are some updates but there is nothing
https://bugs.documentfoundation.org/show_bug.cgi?id=123798 --- Comment #7 from QA Administrators --- Dear Pablo, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135177] FILEOPEN DOCX: Small strip of text behind image (not in source ODT)
https://bugs.documentfoundation.org/show_bug.cgi?id=135177 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: config_host.mk.in configure.ac external/libpng solenv/gbuild
config_host.mk.in |1 + configure.ac|1 + external/libpng/StaticLibrary_libpng.mk | 15 +++ solenv/gbuild/LinkTarget.mk |2 ++ solenv/gbuild/platform/android.mk |2 +- solenv/gbuild/platform/com_GCC_defs.mk |4 solenv/gbuild/platform/com_MSC_class.mk |2 +- solenv/gbuild/platform/iOS.mk |2 +- solenv/gbuild/platform/macosx.mk|2 +- solenv/gbuild/platform/solaris.mk |2 +- solenv/gbuild/platform/unxgcc.mk|4 ++-- 11 files changed, 26 insertions(+), 11 deletions(-) New commits: commit a42eefab8629c998ec0f1351075888b95b039ec1 Author: Stephan Bergmann AuthorDate: Tue Aug 11 20:26:56 2020 +0200 Commit: Stephan Bergmann CommitDate: Wed Aug 12 06:09:49 2020 +0200 Enable --enable-lto --enable-skia when building with GCC+Clang on Linux ...where all the Library_skia objects are built with Clang, so contain intermediate LLVM bytecode, but were then linked via GCC and ld or gold, which do not understand such object files and thus failed. So in gb_LinkTarget__command_dynamiclink use T_CC/T_CXX also for the linker command line. But then Clang would still be used for linking with the -fuse-ld=(ld or gold) $(USE_LD) suitable for GCC, and would still fail. So break T_USE_LD out of T_LDFLAGS and let gb_LinkTarget_use_clang override T_USE_LD with CLANG_USE_LD. At least for now, that CLANG_USE_LD (containing something like -fuse-ld=lld or -fuse-ld=lld --ld-path=... for the latter see d668c9a04d04d256fcbbd2165fe226f1db88256b "Adapt --enable-ld to Clang 12 trunk --ld-path") needs to manually be passed into autogen.sh, it is not computed in configure.ac. Then building Library_skia would still fail to link against StaticLibrary_libpng, as that only contains intermediate GCC object code, so make sure to build it with -ffat-lto-objects in this specific case. Change-Id: I0a104e53a8898cd9c2eb3b643e21954e853608cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100556 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/config_host.mk.in b/config_host.mk.in index 00288ccb6968..d62afe8e796f 100644 --- a/config_host.mk.in +++ b/config_host.mk.in @@ -76,6 +76,7 @@ export CLANG_CXXFLAGS_INTRINSICS_AVX=@CLANG_CXXFLAGS_INTRINSICS_AVX@ export CLANG_CXXFLAGS_INTRINSICS_AVX2=@CLANG_CXXFLAGS_INTRINSICS_AVX2@ export CLANG_CXXFLAGS_INTRINSICS_F16C=@CLANG_CXXFLAGS_INTRINSICS_F16C@ export CLANG_CXXFLAGS_INTRINSICS_FMA=@CLANG_CXXFLAGS_INTRINSICS_FMA@ +export CLANG_USE_LD=@CLANG_USE_LD@ export CLANGDIR=@CLANGDIR@ export CLANGLIBDIR=@CLANGLIBDIR@ export CLANGSYSINCLUDE=@CLANGSYSINCLUDE@ diff --git a/configure.ac b/configure.ac index dbf13a875ab8..71c395b792e7 100644 --- a/configure.ac +++ b/configure.ac @@ -11500,6 +11500,7 @@ AC_SUBST(CLANG_CXXFLAGS_INTRINSICS_AVX2) AC_SUBST(CLANG_CXXFLAGS_INTRINSICS_AVX512) AC_SUBST(CLANG_CXXFLAGS_INTRINSICS_F16C) AC_SUBST(CLANG_CXXFLAGS_INTRINSICS_FMA) +AC_SUBST(CLANG_USE_LD) SYSTEM_GPGMEPP= diff --git a/external/libpng/StaticLibrary_libpng.mk b/external/libpng/StaticLibrary_libpng.mk index 2d56a276f6a7..8abfdec063db 100644 --- a/external/libpng/StaticLibrary_libpng.mk +++ b/external/libpng/StaticLibrary_libpng.mk @@ -44,4 +44,19 @@ $(eval $(call gb_StaticLibrary_add_generated_cobjects,libpng,\ ) \ )) +# At least on Linux, with --enable-lto, when building both this external/libpng and external/skia, +# and building with GCC but building skia with Clang (which should be the sole combination that +# matches "CLANG_CC is non-empty"), build this as a fat archive (including both the intermediate GCC +# object code for LTO and machine object code). Besides targets like Library_vcl (which benefit +# from the intermediate GCC object code for LTO), also Library_skia (built with the Clang toolchain +# lld, which does not understand intermediate GCC object code) includes this, so would otherwise +# fail to link (but now does not benefit from LTO for this included StaticLibrary_libpng): +ifeq ($(OS)-$(ENABLE_LTO),LINUX-TRUE) +ifneq ($(filter SKIA,$(BUILD_TYPE)),) +ifneq ($(CLANG_CC),) +$(eval $(call gb_StaticLibrary_add_cflags,libpng,-ffat-lto-objects)) +endif +endif +endif + # vim: set noet sw=4 ts=4: diff --git a/solenv/gbuild/LinkTarget.mk b/solenv/gbuild/LinkTarget.mk index a18d0a67b1da..98c88a74616b 100644 --- a/solenv/gbuild/LinkTarget.mk +++ b/solenv/gbuild/LinkTarget.mk @@ -833,6 +833,7 @@ $(call gb_LinkTarget_get_target,$(1)) : COMPILER_TEST := $(call gb_LinkTarget_get_target,$(1)) : T_SYMBOLS := $(if $(call gb_LinkTarget__symbols_enabled,$(2)),$(true),$(false)) $(call gb_LinkTarget_get_target,$(1)) : T_CC := $(call gb_LinkTarget_get_target,$(1)) : T_CXX := +$(call gb_LinkTarget_get_target,$(1)) : T_USE_LD := $(USE_LD) ifeq
[Libreoffice-commits] core.git: cppuhelper/source
cppuhelper/source/typemanager.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 986bd8b93b35ad7f2760dfe0576860532daa0e42
Author: Stephan Bergmann
AuthorDate: Tue Aug 11 20:22:31 2020 +0200
Commit: Stephan Bergmann
CommitDate: Wed Aug 12 06:08:48 2020 +0200
-Werror,-Wuninitialized (apparently new in Clang 12 trunk)
> cppuhelper/source/typemanager.cxx:1571:47: error: field 'entity_' is
uninitialized when used here [-Werror,-Wuninitialized]
> ServiceBasedSingletonDescription_Base(entity_->isPublished()),
> ^
The code was like that ever since it was introduced in
fa559f1c416884015d1d83d0a7ac8803e745d9df "WIP: Experimental new binary
type.rdb
format". Odd that that never caused an issue, but the code appears to at
least
never be executed during `make check`.
Change-Id: I19fe78162c7c4a9211c380648595df9aa54bf4d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100554
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/cppuhelper/source/typemanager.cxx
b/cppuhelper/source/typemanager.cxx
index c03780b1e932..8949ea4c9547 100644
--- a/cppuhelper/source/typemanager.cxx
+++ b/cppuhelper/source/typemanager.cxx
@@ -1568,7 +1568,7 @@ public:
rtl::Reference< cppuhelper::TypeManager > const & manager,
OUString const & name,
rtl::Reference< unoidl::ServiceBasedSingletonEntity > const & entity):
-ServiceBasedSingletonDescription_Base(entity_->isPublished()),
+ServiceBasedSingletonDescription_Base(entity->isPublished()),
manager_(manager), name_(name), entity_(entity)
{ assert(manager.is()); assert(entity.is()); }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 134922] when I insert a calc graph it freezes
https://bugs.documentfoundation.org/show_bug.cgi?id=134922 SteveDee changed: What|Removed |Added Ever confirmed|0 |1 CC||stevedee.atw...@gmail.com Status|UNCONFIRMED |NEW --- Comment #5 from SteveDee --- I can confirm that this bug is present in the following builds: Version: 6.4.5.2 (x64) Build ID: a726b36747cf2001e06b58ad5db1aa3a9a1872d6 CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: GL; VCL: win; Locale: en-AU (en_US); UI-Language: en-GB Calc: CL and Version: 7.1.0.0.alpha0+ (x64) Build ID: CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: en-AU (en_US); UI: en-GB Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135652] New: open jenkinks dashboard
https://bugs.documentfoundation.org/show_bug.cgi?id=135652 Bug ID: 135652 Summary: open jenkinks dashboard Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cyberz...@gmail.com hello team, i have found open jenkinks of libreoffice. url: ci.libreoffice.org anyone can see project and nodes related information . anyone can update and delete information please check this issue as soon as possible -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135643] In Calc I tried to search for text "simon" in a spreadsheet, using Ctrl-F, entered text, pressed Enter key, crash. EDITING
https://bugs.documentfoundation.org/show_bug.cgi?id=135643 --- Comment #2 from mrdave...@gmail.com --- I replied to an email about this bug report, which asked me to try something. Nowhere in the email did it say not to reply. Rejection email said, "Recipient address rejected: You replied to a Bugzilla notification email. However email replies are not added to bug reports." No where did Julian's email say to reply in the Bug Reporting system, or how to do that, or how I should respond. So I'm adding my email below, and hope my frustrations can find their way to someone who can change things: Hello Julian, thank you for the very quick response. I didn't expect to hear anything at all! I installed 6.4.5.2 and that appears to have fixed the issue I had this morning. When I first saw the crashes, my first question was if a new version of LibreOffice was available. So I went to Help, Check for new version, and got the message that 6.3.6 is up to date. My mistake, I thought that meant no new version is available, so I didn't look for one. I guess it means, there is no new version of the version I already have, so it's fairly useless and misleading in my opinion. Also, when the program asked me to submit a bug report, why didn't it take me to the page your link leads to, "First steps to take before submitting a bug report"? I would have seen right away that a newer version existed. Altogether I spent about 10 hours trying to write the bug report, figure out what Open GL is running, if any (still don't know that one), checked my LO User Profile (worked the same in LO Safe Mode), searching the internet for posts about similar issues, explored .ods file components after unzipping them, checking other spreadsheet files, and trying to repair my file by copying sheet contents to new tabs and manually fixing hundreds of links (Search & Replace had the same issue as Search). I think your bug was related to sheets with formulas linking to other sheets within the same file. A file saved last June had the same problem, so that told me it was a software issue -- I _know_ I've done searches since then. I later realized I installed 6.3.6 only a few days ago, maybe a week, so that version introduced the bug into my workflow. So while I'm happy the problem is resolved, and happy for your support, I'm not happy that most of my wasted time could have been avoided if the "Check for new version" worked like it does in most (all?) other programs, and if your bug report process at least offered an obvious link to "First steps to take". So I hope you can get word to the right development people. My experience today will discourage me from recommending LO to others, and I came very close to deleting the program from my PC. A help process should consider that users don't know everything developers know. Even the bug report option to pick what kind of system I have... There's no option I can find relating to a 64 bit x86 system (NOT the same as IA64, I did some research on that also). So I picked "Other" even though I have what is probably the most common PC system type out there. "All" didn't seem appropriate. I don't know how you use this information but your most common case can't be identified and that simple menu cost me about 15 minutes. "See log" in Calc's About box was also quite unhelpful, it looked like a log of old unrelated issues, not a log of what happened on my PC. If it's some sort of change log, say so in the About box. From an end-user perspective, LibreOffice and its support websites are very difficult to figure out. I still don't understand why Cutting/Pasting a group of cells in Calc has different results than dragging the cells to a new destination. Things change by themselves over time, like formulas containing named references -- another name gets substituted in formulas I didn't change. Basics just don't seem to work consistently. For some context: I've been using computers since 1975, developed many applications and automations in MS Office/VBA and ran the IT group at a GE facility. The IT groups in two other companies I worked for told me I know more about IT than they did, and I was called in to help them several times, even though my background is Industrial Engineering. So I wish you the best of luck and again, thank you for your help. I've been too lazy to switch products but today made me realize I've been letting hope get in the way of reality for LibreOffice. On Tue, Aug 11, 2020 at 3:57 PM wrote: Julien Nabet changed bug 135643 What Removed Added Ever confirmed 1 Status UNCONFIRMED NEEDINFO CC serval2...@yahoo.fr Comment # 1 on bug 135643 from Julien Nabet Could you give a try with 6.4.5 + tryhttps://wiki.documentfoundation.org/QA/FirstSteps ? You are receiving this mail because: You reported the bug. -- mrdave...@gmail.com (primary) mrdave...@yahoo.com (if other address not working) -- You are receiving this mail because: You are the assignee for
[Libreoffice-bugs] [Bug 134607] LO7RC1 - LANGPACK macOS - many versions fail to recognize LibreOffice7 installation as valid on Catalina
https://bugs.documentfoundation.org/show_bug.cgi?id=134607 --- Comment #43 from Kamei --- Sorry. The escape character for line 69 is missing. line 69 set found_ooos_all to (do shell script "mdfind \"kMDItemContentType == 'com.apple.application-bundle' && kMDItemDisplayName == 'LibreOffice'\"") to set found_ooos_all to (do shell script "mdfind \"kMDItemContentType == 'com.apple.application-bundle' && kMDItemDisplayName == 'LibreOffice.app'\"") Line number 129 is as shown in the earlier post. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134607] LO7RC1 - LANGPACK macOS - many versions fail to recognize LibreOffice7 installation as valid on Catalina
https://bugs.documentfoundation.org/show_bug.cgi?id=134607 --- Comment #42 from Kamei --- I could install JA lang pack. I change the line 69 of 'LibreOffice Language Pack.app/Contents/osx_install.applescript' set found_ooos_all to (do shell script "mdfind "kMDItemContentType == 'com.apple.application-bundle' && kMDItemDisplayName == 'LibreOffice'"") to set found_ooos_all to (do shell script "mdfind "kMDItemContentType == 'com.apple.application-bundle' && kMDItemDisplayName == 'LibreOffice.app'"") And change the line 129 do shell script "mdls --raw --name kMDItemDisplayName --name kMDItemVersion " & quoted form of (choice as string) & " | xargs -0 | fgrep 'LibreOffice 7.0'" to do shell script "mdls --raw --name kMDItemDisplayName --name kMDItemVersion " & quoted form of (choice as string) & " | xargs -0 | fgrep 'LibreOffice.app 7.0'" Then, Run the Script. environment: Version: 7.0.0.3 Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e CPU threads: 16; OS:Mac OS X 10.15.6; UI render: GL; VCL: osx Locale: ja-JP (ja_JP.UTF-8); UI: ja-JP Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134910] LO 7.0 Release Candidate always crashes at startup
https://bugs.documentfoundation.org/show_bug.cgi?id=134910 Rafael Lima changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #6 from Rafael Lima --- (In reply to Xisco Faulí from comment #5) > Hi Rafael, > you should test with a daily build in order to check whether this issue is a > duplicate of bug 135495, which I believe so I've just done that. I downloaded the following build: master~2020-08-09_14.07.53_LibreOfficeDev_7.1.0.0.alpha0_Linux_x86-64_deb.tar.gz I started all LO applications and experienced no crashes this time. I also switched to the tabbed interface and no problems occurred. I guess this issue may have been solved for LO 7.1. More information about the build I tested: Version: 7.1.0.0.alpha0+ Build ID: CPU threads: 16; OS: Linux 5.6; UI render: default; VCL: gtk3 Locale: pt-BR (pt_BR.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-08-09_14:07:53 Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135651] New: Cmd+left/right arrow does the wrong thing in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=135651 Bug ID: 135651 Summary: Cmd+left/right arrow does the wrong thing in Calc Product: LibreOffice Version: 6.4.5.2 release Hardware: All OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: n...@linna.com Description: When editing text in cells of a spreadsheet, Command+left/right arrow does not move the insertion point to the begginning/end of a line, as it should, but does the same thing as Option+left/right arrow, moving the insertion point past a word. Steps to Reproduce: 1. Enter at least two words into a cell. 2. Press Command + left/right arrow. Actual Results: Observe that the insrtion point moves only by one word, rather than to the beginning or end of the line. Expected Results: The insertion point should move to the beginning or end of the line. Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: SpreadsheetDocument [Information guessed from browser] OS: Mac OS X (All) OS is 64bit: no -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135650] New: Can't set default font/char size in draw, can do it in writer
https://bugs.documentfoundation.org/show_bug.cgi?id=135650 Bug ID: 135650 Summary: Can't set default font/char size in draw, can do it in writer Product: LibreOffice Version: 6.0.7.3 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lachenma...@mchsi.com Description: Writer lets me set the default font name and default font size by merely un-selecting everything, going to the standard toolbar, pulling down the font name or font size icon menus. It will then use that font and font size for text I type in until I change it. This behavior is exactly what I want to do in Draw with Text Boxes. If it isn't a bug, I would sure like to request that Draw work like Writer. Steps to Reproduce: 1.Unselect all drawing objects. 2.Change font name/size. 3.Create Text Box and type into it. Actual Results: Font name and size go back to the original name/size before you changed it and text in text box is original name/size. Also, the font name/size switches back to what you set in step 2 above. Expected Results: Font name/size in Text Box would be the name/size I just selected in Step 2 above. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 6.0.7.3 Build ID: 1:6.0.7-0ubuntu0.18.04.10 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); Calc: group Output from checking for OpenGL glxinfo | grep OpenGL vendor string: Intel Open Source Technology Center OpenGL renderer string: Mesa DRI Intel(R) HD Graphics 620 (KBL GT2) OpenGL core profile version string: 4.6 (Core Profile) Mesa 20.0.8 OpenGL core profile shading language version string: 4.60 OpenGL core profile context flags: (none) OpenGL core profile profile mask: core profile OpenGL core profile extensions: OpenGL version string: 3.0 Mesa 20.0.8 OpenGL shading language version string: 1.30 OpenGL context flags: (none) OpenGL extensions: OpenGL ES profile version string: OpenGL ES 3.2 Mesa 20.0.8 OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20 OpenGL ES profile extensions: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - svx/source
svx/source/sidebar/area/AreaPropertyPanelBase.cxx |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
New commits:
commit 93aed840d996af6a7189bd6d5a3c40ca8e9b5205
Author: gokaysatir
AuthorDate: Sat Aug 8 16:27:48 2020 +0300
Commit: Aron Budea
CommitDate: Wed Aug 12 01:38:25 2020 +0200
core: Hide shape area bitmap import button.
Change-Id: I6f6987ea82c102fc5ac44a1c48a234c9f43484e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100391
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Jan Holesovsky
(cherry picked from commit 4a31a63c5e4d4dac01426581c39bc1ef9278f6cb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100367
diff --git a/svx/source/sidebar/area/AreaPropertyPanelBase.cxx
b/svx/source/sidebar/area/AreaPropertyPanelBase.cxx
index e22455ee2c5e..0e911e47b1e9 100644
--- a/svx/source/sidebar/area/AreaPropertyPanelBase.cxx
+++ b/svx/source/sidebar/area/AreaPropertyPanelBase.cxx
@@ -37,6 +37,7 @@
#include
#include
#include
+#include
using namespace css;
using namespace css::uno;
@@ -377,7 +378,8 @@ IMPL_LINK_NOARG(AreaPropertyPanelBase, SelectFillTypeHdl,
ListBox&, void)
GraphicObject aBitmap;
if(nPos == static_cast< sal_Int32 >(BITMAP))
{
-mpBmpImport->Show();
+if (!comphelper::LibreOfficeKit::isActive())
+mpBmpImport->Show();
const SvxBitmapListItem* pItem = pSh->GetItem(SID_BITMAP_LIST);
if(pItem)
{
@@ -1219,7 +1221,8 @@ void AreaPropertyPanelBase::Update()
{
if(pSh && pSh->GetItem(SID_BITMAP_LIST) && eXFS == BITMAP)
{
-mpBmpImport->Show();
+if (!comphelper::LibreOfficeKit::isActive())
+mpBmpImport->Show();
mpLbFillType->SelectEntryPos(sal_uInt32(BITMAP));
mpLbFillAttr->Fill(pSh->GetItem(SID_BITMAP_LIST)->GetBitmapList());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135633] Image border not being copied with the inserted image when it is pasted outside Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=135633 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #1 from Regina Henschel --- The reason is, that "borders" of an image do not exist in Calc, Draw or Impress. The border in Writer does not really belong to the image. If you rotate the image a little bit, then you will see, that the borders remain upright. It would be necessary to convert the "border" to a "line" (technically a "stroke"). The question is whether LibreOffice should do this automatically or on request. And what should happen with the "border" of a rotated image. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101313] Copy-paste a Table With Merged Cells: Loss of formatting (Cells Placed in Wrong Position)
https://bugs.documentfoundation.org/show_bug.cgi?id=101313 stragu changed: What|Removed |Added CC||stephane.guil...@member.fsf ||.org --- Comment #9 from stragu --- reproducible in: Version: 7.0.0.3 Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135168] Lots of empty pages added on paste since 6.5
https://bugs.documentfoundation.org/show_bug.cgi?id=135168 --- Comment #7 from Xisco Faulí --- (In reply to Telesto from comment #4) > Created attachment 164176 [details] > Example file > > Trimmed down little bit more 23 pages Much appreciated. Thanks a lot! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135114] crash when cursor moves off dialog box or collapsing dropdown strands cursor outside dialog box
https://bugs.documentfoundation.org/show_bug.cgi?id=135114 Xisco Faulí changed: What|Removed |Added Resolution|FIXED |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134910] LO 7.0 Release Candidate always crashes at startup
https://bugs.documentfoundation.org/show_bug.cgi?id=134910 Xisco Faulí changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #5 from Xisco Faulí --- Hi Rafael, you should test with a daily build in order to check whether this issue is a duplicate of bug 135495, which I believe so -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74577] Pasting a HTML table into Libreoffice Calc can jumble the table up.
https://bugs.documentfoundation.org/show_bug.cgi?id=74577 stragu changed: What|Removed |Added CC||stephane.guil...@member.fsf ||.org --- Comment #31 from stragu --- Same problem in the final release of 7.0.0: Version: 7.0.0.3 Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded I discovered this when trying to copy and paste a table from Jamovi into Calc. But following the steps in comment 30 is a great way to test. Note that the table looks good in Writer! One partial workaround is to paste first in Writer, and then copy and paste again into Calc. It is only partial because there is another issue (bug 101313) with copying and pasting merged cells between Writer and Calc, so some manual work is still needed (but it is less effort than the issue described here). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135649] Undo takes action on another shape
https://bugs.documentfoundation.org/show_bug.cgi?id=135649 --- Comment #2 from mustafa --- https://www.youtube.com/watch?v=rzLZafneJII https://www.youtube.com/watch?v=HKlw81Tqyc0=youtu.be -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135649] Undo takes action on another shape
https://bugs.documentfoundation.org/show_bug.cgi?id=135649 --- Comment #1 from mustafa --- https://www.youtube.com/watch?v=rzLZafneJII -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135649] New: Undo takes action on another shape
https://bugs.documentfoundation.org/show_bug.cgi?id=135649 Bug ID: 135649 Summary: Undo takes action on another shape Product: LibreOffice Version: 7.0.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bkel...@gmail.com Description: Undo takes action on another shape Actual Results: Undo takes action on another shape Expected Results: error Reproducible: Always User Profile Reset: No Additional Info: Undo takes action on another shape -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135647] Defect help
https://bugs.documentfoundation.org/show_bug.cgi?id=135647 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92960] Calc doesn't merge cells correctly when pasting merged content from HTML
https://bugs.documentfoundation.org/show_bug.cgi?id=92960 stragu changed: What|Removed |Added CC||stephane.guil...@member.fsf ||.org See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=74 ||577 --- Comment #21 from stragu --- Reproducible in LO 7.0.0 as per comment 12. Version: 7.0.0.3 Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74577] Pasting a HTML table into Libreoffice Calc can jumble the table up.
https://bugs.documentfoundation.org/show_bug.cgi?id=74577 stragu changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||960 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'distro/collabora/co-4-2' - loleaflet/js
loleaflet/js/w2ui-1.5.rc1.js |1 +
1 file changed, 1 insertion(+)
New commits:
commit 16c743d61044224aa521e1428beda2703030
Author: gokaysatir
AuthorDate: Sat Jul 11 14:35:26 2020 +0300
Commit: Aron Budea
CommitDate: Tue Aug 11 22:59:40 2020 +0200
loleaflet: Hide w2ui tooltips on mobile.
Change-Id: Iaf57e6f53fbc363e22ac1c11de0eb657d492edd3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98558
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Henry Castro
(cherry picked from commit 9aae80518d23dab3dbd8fdc9369b61d70798ea67)
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100364
Reviewed-by: Aron Budea
diff --git a/loleaflet/js/w2ui-1.5.rc1.js b/loleaflet/js/w2ui-1.5.rc1.js
index 533941987..4ff42eed2 100644
--- a/loleaflet/js/w2ui-1.5.rc1.js
+++ b/loleaflet/js/w2ui-1.5.rc1.js
@@ -6266,6 +6266,7 @@ w2utils.event = {
},
tooltipShow: function (id, event, forceRefresh) {
+if (window.mode.isMobile()) { return; }
if (window.ThisIsTheiOSApp) return;
if (this.tooltip == null) return;
var $el = $(this.box).find('#tb_'+ this.name + '_item_'+
w2utils.escapeId(id));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/co-4-2' - loleaflet/src
loleaflet/src/layer/tile/TileLayer.js |1 +
1 file changed, 1 insertion(+)
New commits:
commit 53ef2d33d00b51d44ab3370771ec8f23c69d760e
Author: gokaysatir
AuthorDate: Fri Jul 10 23:36:10 2020 +0300
Commit: Aron Budea
CommitDate: Tue Aug 11 22:58:44 2020 +0200
loleaflet: Remove carret marker when text selected.
Change-Id: Ifc055f852857188e4d35b9db1db62638ad5a27a5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98546
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Michael Meeks
Reviewed-by: Henry Castro
(cherry picked from commit e5dfd6a2f27450007f11ff017d919ab69422c665)
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100363
Reviewed-by: Aron Budea
diff --git a/loleaflet/src/layer/tile/TileLayer.js
b/loleaflet/src/layer/tile/TileLayer.js
index 0e1845706..726a5a5b2 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -1668,6 +1668,7 @@ L.TileLayer = L.GridLayer.extend({
weight: 2,
opacity: 0.25});
this._selections.addLayer(selection);
+
this._map.removeLayer(this._map._textInput._cursorHandler); // User selected a
text, we remove the carret marker.
if (this._selectionContentRequest) {
clearTimeout(this._selectionContentRequest);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135647] Defect help
https://bugs.documentfoundation.org/show_bug.cgi?id=135647 --- Comment #1 from Leif Johansen --- Problem solved - I have for first time install a new version in Linux (7) the hard way ( many times in Windows) and I forgot the general danish language packes. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135648] New: "Tab" buttons in the Style editor window move
https://bugs.documentfoundation.org/show_bug.cgi?id=135648 Bug ID: 135648 Summary: "Tab" buttons in the Style editor window move Product: LibreOffice Version: 6.4.5.2 release Hardware: All OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: n...@linna.com Description: I clicked a "tab" button in the Style editor window and the two rows of tabs swapped places. UI elements should not move out from under the pointer! This is presumably a problem anywhere there are multiple rows of "tab" buttons. Steps to Reproduce: 1. Open the Style editor window. 2. Click a "tab" button in the top row. Actual Results: The two rows of "tab" buttons swap places, meaning the button I clicked is no longer under the pointer, and all the other buttons are no longer where I thought they were. Expected Results: UI elements should not move around as the user is interacting with them. This is not a video game. Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: TextDocument [Information guessed from browser] OS: Mac OS X (All) OS is 64bit: no -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135647] New: Defect help
https://bugs.documentfoundation.org/show_bug.cgi?id=135647 Bug ID: 135647 Summary: Defect help Product: LibreOffice Version: 7.0.0.3 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Linguistic Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: l...@dagnyleif-johansen.dk CC: so...@libreoffice.org Description: I can not install the danish helppack to LibreOffice 7. When I try to install the deb I get the answer from my Linux Mint terminal: leif@leif-Latitude-E7240:~/Dokumenter/DEBS$ sudo dpkg -i *.deb [sudo] adgangskode for leif: (Læser database ... 369095 filer og kataloger installeret i øjeblikket.) Gør klar til at udpakke libobasis7.0-da-help_7.0.0.3-3_amd64.deb ... Udpakker libobasis7.0-da-help (7.0.0.3-3) over (7.0.0.3-3) ... dpkg: afhængighedsproblemer forhindrer konfiguration af libobasis7.0-da-help: libobasis7.0-da-help afhænger af libobasis7.0-da (>= 7.0.0.3); men: Pakken 'libobasis7.0-da' er ikke installeret. libobasis7.0-da-help afhænger af libobasis7.0-da (<= 7.0.0.3-3); men: Pakken 'libobasis7.0-da' er ikke installeret. dpkg: fejl under behandling af pakken libobasis7.0-da-help (--install): afhængighedsproblemer - efterlader den ukonfigureret Der opstod fejl under behandlingen: libobasis7.0-da-help Greetings Leif Steps to Reproduce: 1.Follow the copy from the terminal the debpack is in Dokument/DEBS. I am standing in this map. 2.sudo dpkg -i *.deb 3. Actual Results: No installation Expected Results: The change to danish Reproducible: Always User Profile Reset: No Additional Info: gerrit.libreoffice.org / core / 8061b3e9204bef6b321a21033174034a5e2ea88e the rest can not be copied -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135462] LibreOffice 7.0.0.3 does not recognise JRE installation location at startup other than those in /Library/Java/JavaVirtualMachines/
https://bugs.documentfoundation.org/show_bug.cgi?id=135462 --- Comment #16 from Marc Grober --- Re title of bug... I think it clear that LO7 identifies the existence of all jdks installed ata Library Javaa/JavaVirtualMachines... However, it appears to be either unable to use them, or is throwing inaccurate error messages, as it indicates that the installed JDKs are "defective". -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135646] New: The Window menu has no Minimize command
https://bugs.documentfoundation.org/show_bug.cgi?id=135646 Bug ID: 135646 Summary: The Window menu has no Minimize command Product: LibreOffice Version: 6.4.5.2 release Hardware: All OS: Mac OS X (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: n...@linna.com Description: The Window menu has no Minimize command. Steps to Reproduce: 1. Click on the Window menu. Actual Results: Observe that there is no Minimize command. Expected Results: There should be a Minimize command in the Window menu. Particularly since the key equivalent Command+M does work to minimize the frontmost window. Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: TextDocument [Information guessed from browser] OS: Mac OS X (All) OS is 64bit: no -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135462] LibreOffice 7.0.0.3 does not recognise JRE installation location at startup other than those in /Library/Java/JavaVirtualMachines/
https://bugs.documentfoundation.org/show_bug.cgi?id=135462 --- Comment #15 from Marc Grober --- Re zotero discussion, please see: https://forums.zotero.org/discussion/84538/zotero-plugin-fails-with-libreoffice-7-0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135442] LO crashes when About Libreoffice is clicked
https://bugs.documentfoundation.org/show_bug.cgi?id=135442 Commit Notification changed: What|Removed |Added Whiteboard||target:7.1.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/uiconfig sd/uiconfig svx/uiconfig vcl/uiconfig
cui/uiconfig/ui/aboutdialog.ui |2 +- cui/uiconfig/ui/additionsdialog.ui |2 +- cui/uiconfig/ui/additionsfragment.ui |2 +- sd/uiconfig/simpress/ui/clientboxfragment.ui |2 +- svx/uiconfig/ui/accessibilitycheckdialog.ui |2 +- svx/uiconfig/ui/accessibilitycheckentry.ui |2 +- vcl/uiconfig/ui/wizard.ui|2 +- 7 files changed, 7 insertions(+), 7 deletions(-) New commits: commit e603bbceed095b1e94756c1e7dc0078f657cf864 Author: Caolán McNamara AuthorDate: Tue Aug 11 15:29:38 2020 +0100 Commit: Caolán McNamara CommitDate: Tue Aug 11 22:31:11 2020 +0200 tdf#135442 min supported version of gtk3 is 3.18 not 3.20 Change-Id: Iaa2eefbe08fad3a7dd6eff98bf5fb513053a263d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100532 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/cui/uiconfig/ui/aboutdialog.ui b/cui/uiconfig/ui/aboutdialog.ui index d0c2f57f0378..f44ef92913c1 100644 --- a/cui/uiconfig/ui/aboutdialog.ui +++ b/cui/uiconfig/ui/aboutdialog.ui @@ -1,7 +1,7 @@ - + True False diff --git a/cui/uiconfig/ui/additionsdialog.ui b/cui/uiconfig/ui/additionsdialog.ui index cf606dec438f..523bcc276ede 100644 --- a/cui/uiconfig/ui/additionsdialog.ui +++ b/cui/uiconfig/ui/additionsdialog.ui @@ -1,7 +1,7 @@ - + 400 500 diff --git a/cui/uiconfig/ui/additionsfragment.ui b/cui/uiconfig/ui/additionsfragment.ui index 9b475e2fada4..2b4c23dff55b 100644 --- a/cui/uiconfig/ui/additionsfragment.ui +++ b/cui/uiconfig/ui/additionsfragment.ui @@ -1,7 +1,7 @@ - + True False diff --git a/sd/uiconfig/simpress/ui/clientboxfragment.ui b/sd/uiconfig/simpress/ui/clientboxfragment.ui index cb2dcfd413f6..9c800383a048 100644 --- a/sd/uiconfig/simpress/ui/clientboxfragment.ui +++ b/sd/uiconfig/simpress/ui/clientboxfragment.ui @@ -1,7 +1,7 @@ - + True False diff --git a/svx/uiconfig/ui/accessibilitycheckdialog.ui b/svx/uiconfig/ui/accessibilitycheckdialog.ui index 891a4b9ed24e..4acb6162aeba 100644 --- a/svx/uiconfig/ui/accessibilitycheckdialog.ui +++ b/svx/uiconfig/ui/accessibilitycheckdialog.ui @@ -1,7 +1,7 @@ - + 640 480 diff --git a/svx/uiconfig/ui/accessibilitycheckentry.ui b/svx/uiconfig/ui/accessibilitycheckentry.ui index 308cd8a08f7e..6ad955592fc8 100644 --- a/svx/uiconfig/ui/accessibilitycheckentry.ui +++ b/svx/uiconfig/ui/accessibilitycheckentry.ui @@ -1,7 +1,7 @@ - + True False diff --git a/vcl/uiconfig/ui/wizard.ui b/vcl/uiconfig/ui/wizard.ui index e1f68da9e66a..76f92607f1ce 100644 --- a/vcl/uiconfig/ui/wizard.ui +++ b/vcl/uiconfig/ui/wizard.ui @@ -1,7 +1,7 @@ - + True 6 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135442] LO crashes when About Libreoffice is clicked
https://bugs.documentfoundation.org/show_bug.cgi?id=135442 --- Comment #7 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e603bbceed095b1e94756c1e7dc0078f657cf864 tdf#135442 min supported version of gtk3 is 3.18 not 3.20 It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtk3gtkinst.cxx | 35 +--
1 file changed, 29 insertions(+), 6 deletions(-)
New commits:
commit 68ada413fd37163221dc14a6921ab041e5abbeaa
Author: Caolán McNamara
AuthorDate: Tue Aug 11 15:12:59 2020 +0100
Commit: Caolán McNamara
CommitDate: Tue Aug 11 22:30:19 2020 +0200
unset CustomCellRenderer instances in dtor
Change-Id: I60a5f91df65d1d511ba863ba9a0286c1483314d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100508
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 8f227854d966..5b7ee9c17fb3 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -5330,6 +5330,7 @@ GType crippled_viewport_get_type()
#define CUSTOM_TYPE_CELL_RENDERER_SURFACE
(custom_cell_renderer_surface_get_type())
#define CUSTOM_CELL_RENDERER_SURFACE(obj)
(G_TYPE_CHECK_INSTANCE_CAST((obj), CUSTOM_TYPE_CELL_RENDERER_SURFACE,
CustomCellRendererSurface))
+#define CUSTOM_IS_CELL_RENDERER_SURFACE(obj)
(G_TYPE_CHECK_INSTANCE_TYPE ((obj), CUSTOM_TYPE_CELL_RENDERER_SURFACE))
namespace {
@@ -11706,11 +11707,26 @@ public:
g_signal_handler_disconnect(m_pTreeView, m_nRowActivatedSignalId);
g_signal_handler_disconnect(gtk_tree_view_get_selection(m_pTreeView),
m_nChangedSignalId);
+GValue value = G_VALUE_INIT;
+g_value_init(, G_TYPE_POINTER);
+g_value_set_pointer(, static_cast(nullptr));
+
for (GList* pEntry = g_list_last(m_pColumns); pEntry; pEntry =
g_list_previous(pEntry))
{
GtkTreeViewColumn* pColumn = GTK_TREE_VIEW_COLUMN(pEntry->data);
g_signal_handler_disconnect(pColumn, m_aColumnSignalIds.back());
m_aColumnSignalIds.pop_back();
+
+// unset "instance" to avoid dangling "instance" points in any
CustomCellRenderers
+GList *pRenderers =
gtk_cell_layout_get_cells(GTK_CELL_LAYOUT(pColumn));
+for (GList* pRenderer = g_list_first(pRenderers); pRenderer;
pRenderer = g_list_next(pRenderer))
+{
+GtkCellRenderer* pCellRenderer =
GTK_CELL_RENDERER(pRenderer->data);
+if (!CUSTOM_IS_CELL_RENDERER_SURFACE(pCellRenderer))
+continue;
+g_object_set_property(G_OBJECT(pCellRenderer), "instance",
);
+}
+g_list_free(pRenderers);
}
g_list_free(m_pColumns);
}
@@ -14931,13 +14947,16 @@ bool
custom_cell_renderer_surface_get_preferred_size(GtkCellRenderer *cell,
GtkInstanceWidget* pWidget =
static_cast(g_value_get_pointer());
-ensure_device(cellsurface, pWidget);
-
Size aSize;
-if (GtkInstanceTreeView* pTreeView =
dynamic_cast(pWidget))
-aSize = pTreeView->call_signal_custom_get_size(*cellsurface->device,
sId);
-else if (GtkInstanceComboBox* pComboBox =
dynamic_cast(pWidget))
-aSize = pComboBox->call_signal_custom_get_size(*cellsurface->device);
+
+if (pWidget)
+{
+ensure_device(cellsurface, pWidget);
+if (GtkInstanceTreeView* pTreeView =
dynamic_cast(pWidget))
+aSize =
pTreeView->call_signal_custom_get_size(*cellsurface->device, sId);
+else if (GtkInstanceComboBox* pComboBox =
dynamic_cast(pWidget))
+aSize =
pComboBox->call_signal_custom_get_size(*cellsurface->device);
+}
if (orientation == GTK_ORIENTATION_HORIZONTAL)
{
@@ -14980,6 +14999,10 @@ void
custom_cell_renderer_surface_render(GtkCellRenderer* cell,
CustomCellRendererSurface *cellsurface =
CUSTOM_CELL_RENDERER_SURFACE(cell);
GtkInstanceWidget* pWidget =
static_cast(g_value_get_pointer());
+
+if (!pWidget)
+return;
+
ensure_device(cellsurface, pWidget);
Size aSize(cell_area->width, cell_area->height);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135462] LibreOffice 7.0.0.3 does not recognise JRE installation location at startup other than those in /Library/Java/JavaVirtualMachines/
https://bugs.documentfoundation.org/show_bug.cgi?id=135462 --- Comment #14 from Marc Grober --- Sorry w...@rsb.at, I did a search and this bug did not pop, so I added the bug at 135644. I have my Java installed in the "proper" location, Alex. (Library/Java/JavaVirtualMachines) Naming convention with Oracle Java is jdk-14.0.2.jdk What is the name format for you 12.x installation? This installation (6.x) also worked with all previous Oracle upgrades (from 8.x) which, since Oracle has nothing posted about any susbtantive changes in 14, and 14 works with 6.x, suggests that this is a 7.x problem? I presently have installed Oracle 14, 14.0.1, and 14.0.2 (not OpenJava...) I did a refresh install of 7.0.0 and updated from 14.0.1 to 14.0.2 and nothing helped (including rebooting several times, rofl). As noted in the bug I filed, I have a concurrent LO6.x running with 14.0.1 without any problem Re Zotero, Adam Stillman at zotero believes that since zotero requires working java, that the zotero issue (unable to install connector) is a result of LO not identifying a working java. When LO 7 opens after Two identical error messages, I can check the java menu and ALL java extensions are in fact properly listed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/nisz/libreoffice-6-4' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6da05dd959ce54b5920af326263fa3f47b3ba897 Author: Gabor Kelemen AuthorDate: Tue Aug 11 22:09:38 2020 +0200 Commit: Gabor Kelemen CommitDate: Tue Aug 11 22:16:32 2020 +0200 Weekly version bump: N5 Change-Id: I08ac654db6b18ddb49c3cc320198a69a75788f33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100566 Tested-by: Gabor Kelemen Reviewed-by: Gabor Kelemen diff --git a/configure.ac b/configure.ac index 5f86863d841e..75ebe989f41f 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([LibreOffice],[6.4.4.2-N4],[],[],[http://documentfoundation.org/]) +AC_INIT([LibreOffice],[6.4.4.2-N5],[],[],[http://documentfoundation.org/]) dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just fine if it is installed dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails hard ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/co-4-2' - loleaflet/src
loleaflet/src/control/Control.PartsPreview.js |1 -
1 file changed, 1 deletion(-)
New commits:
commit 0c7e678cbe07e866a764de2b65a246e1aac83eb1
Author: Henry Castro
AuthorDate: Tue Aug 11 15:47:36 2020 -0400
Commit: Henry Castro
CommitDate: Tue Aug 11 22:16:44 2020 +0200
Revert "Keep slide sorter in line on mobile devices"
This is no longer need it because the orientation is manual
changed, adding or removing class styles and the patches
below were added to adapt the new changes
This reverts commit 69c21d5bb4d084cb8abc38b4176c8b40f12c8490.
Change-Id: I70aee6b569f78795487cbff736130e0e74165432
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100564
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Henry Castro
diff --git a/loleaflet/src/control/Control.PartsPreview.js
b/loleaflet/src/control/Control.PartsPreview.js
index da01e151d..7d4648f7d 100644
--- a/loleaflet/src/control/Control.PartsPreview.js
+++ b/loleaflet/src/control/Control.PartsPreview.js
@@ -111,7 +111,6 @@ L.Control.PartsPreview = L.Control.extend({
}, this);
this._scrollContainer =
$(this._partsPreviewCont).find('.mCSB_container').get(0);
- $(this._scrollContainer).css('display',
'inline-table');
// Add a special frame just as a drop-site for
reordering.
var frameClass = 'preview-frame ' +
this.options.frameClass;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 90286] New OpenDocument Text from desktop (Windows Explorer) defaults to language other than system language
https://bugs.documentfoundation.org/show_bug.cgi?id=90286 --- Comment #12 from n...@arcor.de --- I would like to point out that this bug is of some importance, as this is just the way the "normal" user will create documents. And he for sure won't search for workarounds, bug reports etc. But will every single time change the language manually. So, please, have a look at that. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105146] Different lines of bulleted text animation are getting the same animation title in the deck
https://bugs.documentfoundation.org/show_bug.cgi?id=105146 Thomas Lendo changed: What|Removed |Added Resolution|--- |WORKSFORME CC||thomas.le...@gmail.com Status|NEW |RESOLVED --- Comment #5 from Thomas Lendo --- Can't reproduce with Version: 7.1.0.0.alpha0+ CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3 Locale: de-DE (de_DE.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-08-05_04:03:50 Calc: threaded Closing as Worksforme. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135643] In Calc I tried to search for text "simon" in a spreadsheet, using Ctrl-F, entered text, pressed Enter key, crash. EDITING
https://bugs.documentfoundation.org/show_bug.cgi?id=135643 Julien Nabet changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||serval2...@yahoo.fr --- Comment #1 from Julien Nabet --- Could you give a try with 6.4.5 + try https://wiki.documentfoundation.org/QA/FirstSteps ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/inc sc/source
sc/inc/global.hxx |2 +-
sc/source/core/data/global.cxx | 12 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
New commits:
commit e8d1824146027c708c6dd53cc8341c2677813cde
Author: Noel Grandin
AuthorDate: Tue Aug 11 17:02:48 2020 +0200
Commit: Noel Grandin
CommitDate: Tue Aug 11 21:54:56 2020 +0200
use unique_ptr for CalendarWrapper in ScGlobal
Change-Id: Id1a00798f9780006de28d3370e5bad1235fa2466
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100537
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sc/inc/global.hxx b/sc/inc/global.hxx
index de0b3311c4fc..6d13efab4523 100644
--- a/sc/inc/global.hxx
+++ b/sc/inc/global.hxx
@@ -522,7 +522,7 @@ class ScGlobal
static SvNumberFormatter* pEnglishFormatter; // for UNO / XML
export
static css::uno::Reference< css::i18n::XOrdinalSuffix> xOrdinalSuffix;
-static CalendarWrapper* pCalendar;
+static std::unique_ptr xCalendar;
static std::atomic pCaseCollator;
static std::atomic pCollator;
static std::atomic<::utl::TransliterationWrapper*> pTransliteration;
diff --git a/sc/source/core/data/global.cxx b/sc/source/core/data/global.cxx
index 538702c87097..8b149300bbe3 100644
--- a/sc/source/core/data/global.cxx
+++ b/sc/source/core/data/global.cxx
@@ -80,7 +80,7 @@ ScUserList* ScGlobal::pUserList = nullptr;
LanguageTypeScGlobal::eLnge = LANGUAGE_SYSTEM;
std::atomic ScGlobal::pLocale(nullptr);
std::unique_ptr ScGlobal::xSysLocale;
-CalendarWrapper* ScGlobal::pCalendar = nullptr;
+std::unique_ptr ScGlobal::xCalendar;
std::atomic ScGlobal::pCollator(nullptr);
std::atomic ScGlobal::pCaseCollator(nullptr);
std::atomic<::utl::TransliterationWrapper*>
ScGlobal::pTransliteration(nullptr);
@@ -548,7 +548,7 @@ void ScGlobal::Clear()
delete pTransliteration.load(); pTransliteration = nullptr;
delete pCaseCollator.load(); pCaseCollator = nullptr;
delete pCollator.load(); pCollator = nullptr;
-DELETEZ(pCalendar);
+xCalendar.reset();
xSysLocale.reset();
delete pLocale.load(); pLocale = nullptr;
@@ -1025,12 +1025,12 @@ const CharClass* ScGlobal::getCharClassPtr()
CalendarWrapper* ScGlobal::GetCalendar()
{
assert(!bThreadedGroupCalcInProgress);
-if ( !pCalendar )
+if ( !xCalendar )
{
-pCalendar = new CalendarWrapper(
::comphelper::getProcessComponentContext() );
-pCalendar->loadDefaultCalendar( *GetLocale() );
+xCalendar.reset( new CalendarWrapper(
::comphelper::getProcessComponentContext() ) );
+xCalendar->loadDefaultCalendar( *GetLocale() );
}
-return pCalendar;
+return xCalendar.get();
}
CollatorWrapper*ScGlobal::GetCollator()
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135462] LibreOffice 7.0.0.3 does not recognise JRE installation location at startup other than those in /Library/Java/JavaVirtualMachines/
https://bugs.documentfoundation.org/show_bug.cgi?id=135462 Julien Nabet changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||5644 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135644] LO & identifies Java 14.x as defective on MacOS Catalina
https://bugs.documentfoundation.org/show_bug.cgi?id=135644 Julien Nabet changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||5462 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135462] LibreOffice 7.0.0.3 does not recognise JRE installation location at startup other than those in /Library/Java/JavaVirtualMachines/
https://bugs.documentfoundation.org/show_bug.cgi?id=135462 Julien Nabet changed: What|Removed |Added CC||sberg...@redhat.com --- Comment #13 from Julien Nabet --- Stephan: thought you might be interested in this one since it concerns Java. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/inc sc/source
sc/inc/interpretercontext.hxx | 12 ++--
sc/source/core/data/documen2.cxx | 12 ++--
sc/source/core/tool/interpretercontext.cxx | 17 +++--
3 files changed, 19 insertions(+), 22 deletions(-)
New commits:
commit 4cb85b20ae5a8ddda46b74382d60ec89b1b41320
Author: Noel Grandin
AuthorDate: Tue Aug 11 16:17:50 2020 +0200
Commit: Noel Grandin
CommitDate: Tue Aug 11 21:54:08 2020 +0200
use unique_ptr for ScLookupCacheMap
Change-Id: Ib09a5331dfd57a99852555348c46730368d8d61d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100531
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sc/inc/interpretercontext.hxx b/sc/inc/interpretercontext.hxx
index 7eb1f1415642..2e0ff91632d6 100644
--- a/sc/inc/interpretercontext.hxx
+++ b/sc/inc/interpretercontext.hxx
@@ -57,21 +57,13 @@ struct ScInterpreterContext
size_t mnTokenCachePos;
std::vector maTokens;
std::vector maDelayedSetNumberFormat;
-ScLookupCacheMap* mScLookupCache; // cache for lookups like VLOOKUP and
MATCH
+std::unique_ptr mxScLookupCache; // cache for lookups
like VLOOKUP and MATCH
// Allocation cache for "aConditions" array in
ScInterpreter::IterateParameterIfs()
// This is populated/used only when formula-group threading is enabled.
std::vector maConditions;
ScInterpreter* pInterpreter;
-ScInterpreterContext(const ScDocument& rDoc, SvNumberFormatter* pFormatter)
-: mpDoc()
-, mnTokenCachePos(0)
-, maTokens(TOKEN_CACHE_SIZE, nullptr)
-, mScLookupCache(nullptr)
-, pInterpreter(nullptr)
-, mpFormatter(pFormatter)
-{
-}
+ScInterpreterContext(const ScDocument& rDoc, SvNumberFormatter*
pFormatter);
ScInterpreterContext() = delete;
diff --git a/sc/source/core/data/documen2.cxx b/sc/source/core/data/documen2.cxx
index e4413853aa71..9d8ed27a82ce 100644
--- a/sc/source/core/data/documen2.cxx
+++ b/sc/source/core/data/documen2.cxx
@@ -1151,14 +1151,14 @@ void
ScDocument::DisposeFieldEditEngine(std::unique_ptr& rpEd
ScLookupCache & ScDocument::GetLookupCache( const ScRange & rRange,
ScInterpreterContext* pContext )
{
ScLookupCache* pCache = nullptr;
-ScLookupCacheMap*& rpCacheMap = pContext->mScLookupCache;
-if (!rpCacheMap)
-rpCacheMap = new ScLookupCacheMap;
+if (!pContext->mxScLookupCache)
+pContext->mxScLookupCache.reset(new ScLookupCacheMap);
+ScLookupCacheMap* pCacheMap = pContext->mxScLookupCache.get();
// insert with temporary value to avoid doing two lookups
-auto [findIt, bInserted] = rpCacheMap->aCacheMap.emplace(rRange, nullptr);
+auto [findIt, bInserted] = pCacheMap->aCacheMap.emplace(rRange, nullptr);
if (bInserted)
{
-findIt->second = std::make_unique(this, rRange,
*rpCacheMap);
+findIt->second = std::make_unique(this, rRange,
*pCacheMap);
pCache = findIt->second.get();
// The StartListeningArea() call is not thread-safe, as all threads
// would access the same SvtBroadcaster.
@@ -1193,7 +1193,7 @@ void ScDocument::RemoveLookupCache( ScLookupCache &
rCache )
void ScDocument::ClearLookupCaches()
{
assert(!IsThreadedGroupCalcInProgress());
-DELETEZ(GetNonThreadedContext().mScLookupCache);
+GetNonThreadedContext().mxScLookupCache.reset();
// Clear lookup cache in all interpreter-contexts in the
(threaded/non-threaded) pools.
ScInterpreterContextPool::ClearLookupCaches();
}
diff --git a/sc/source/core/tool/interpretercontext.cxx
b/sc/source/core/tool/interpretercontext.cxx
index 77d2feadce6a..ce02ea28d52c 100644
--- a/sc/source/core/tool/interpretercontext.cxx
+++ b/sc/source/core/tool/interpretercontext.cxx
@@ -28,10 +28,19 @@
ScInterpreterContextPool
ScInterpreterContextPool::aThreadedInterpreterPool(true);
ScInterpreterContextPool
ScInterpreterContextPool::aNonThreadedInterpreterPool(false);
+ScInterpreterContext::ScInterpreterContext(const ScDocument& rDoc,
SvNumberFormatter* pFormatter)
+: mpDoc()
+, mnTokenCachePos(0)
+, maTokens(TOKEN_CACHE_SIZE, nullptr)
+, pInterpreter(nullptr)
+, mpFormatter(pFormatter)
+{
+}
+
ScInterpreterContext::~ScInterpreterContext()
{
ResetTokens();
-delete mScLookupCache;
+mxScLookupCache.reset();
}
void ScInterpreterContext::ResetTokens()
@@ -63,11 +72,7 @@ void ScInterpreterContext::Cleanup()
ResetTokens();
}
-void ScInterpreterContext::ClearLookupCache()
-{
-delete mScLookupCache;
-mScLookupCache = nullptr;
-}
+void ScInterpreterContext::ClearLookupCache() { mxScLookupCache.reset(); }
SvNumFormatType ScInterpreterContext::GetNumberFormatType(sal_uInt32 nFIndex)
const
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/nisz/libreoffice-6-4' - sw/qa writerfilter/source
sw/qa/extras/layout/data/tdf134685.docx |binary
sw/qa/extras/layout/layout.cxx | 10 ++
writerfilter/source/dmapper/TableData.hxx|9 +++--
writerfilter/source/dmapper/TableManager.cxx |7 ---
writerfilter/source/dmapper/TableManager.hxx |2 +-
5 files changed, 22 insertions(+), 6 deletions(-)
New commits:
commit 08796e1dfc34c8c17970bf3d7b360f57ce582f06
Author: László Németh
AuthorDate: Fri Jul 17 14:39:45 2020 +0200
Commit: Gabor Kelemen
CommitDate: Tue Aug 11 21:49:59 2020 +0200
tdf#134685 DOCX table import: fix gridBefore + cell width
Improve workaround to handle nested tables started at cell
start in a row with gridBefore. Omitted gridBefore cells
from commit 5483d4e10aad27889b961b9cb94d7ba6c86aed0b
(tdf#134606 DOCX table import: fix gridBefore + nesting)
resulted less cells in the row than defined by the grid,
and the different code path could lead to narrow cell width
with partially invisible nested table. Fix this by adding
gridBefore cell count to the cell span in the first cell.
Regression from commit 70274f86cdc1c023ffdd0130c262c1479262d76b
(tdf#116194 DOCX import: fix missing tables with w:gridBefore)
Conflicts:
sw/qa/extras/layout/layout.cxx
writerfilter/source/dmapper/TableManager.hxx
(cherry-picked from commit abea0d6647c7f1f7e76c73c26cb80e6a67dc5111)
Change-Id: If332305d54ff2b34b258270a607fb31ff7380149
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98973
Tested-by: Jenkins
Reviewed-by: László Németh
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100476
Tested-by: Gabor Kelemen
Reviewed-by: Gabor Kelemen
diff --git a/sw/qa/extras/layout/data/tdf134685.docx
b/sw/qa/extras/layout/data/tdf134685.docx
new file mode 100644
index ..86b59fa982f3
Binary files /dev/null and b/sw/qa/extras/layout/data/tdf134685.docx differ
diff --git a/sw/qa/extras/layout/layout.cxx b/sw/qa/extras/layout/layout.cxx
index f109a809355e..67ad3cb16343 100644
--- a/sw/qa/extras/layout/layout.cxx
+++ b/sw/qa/extras/layout/layout.cxx
@@ -2941,6 +2941,16 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testTdf127606)
assertXPath(pXmlDoc, "/root/page/body/tab/row/cell/txt[3]/Special",
"nHeight", "260");
}
+CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testTdf134685)
+{
+createDoc("tdf134685.docx");
+xmlDocPtr pXmlDoc = parseLayoutDump();
+sal_Int32 nWidth
+= getXPath(pXmlDoc, "/root/page/body/tab/row[6]/cell[1]/infos/bounds",
"width").toInt32();
+// This was 2223: the content was only partially visible according to the
lost cell width
+CPPUNIT_ASSERT_GREATER(static_cast(14000), nWidth);
+}
+
CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testTdf109077)
{
createDoc("tdf109077.docx");
diff --git a/writerfilter/source/dmapper/TableData.hxx
b/writerfilter/source/dmapper/TableData.hxx
index 14fedc66fba8..1632696bceb6 100644
--- a/writerfilter/source/dmapper/TableData.hxx
+++ b/writerfilter/source/dmapper/TableData.hxx
@@ -249,10 +249,15 @@ public:
nRet.push_back(aCell->getGridSpan());
return nRet;
}
-void setCurrentGridSpan(sal_uInt32 nSpan)
+void setCurrentGridSpan(sal_uInt32 nSpan, bool bFirstCell = false)
{
if ( mCells.size() )
-mCells.back()->setGridSpan(nSpan);
+{
+if ( bFirstCell )
+mCells.front()->setGridSpan(nSpan);
+else
+mCells.back()->setGridSpan(nSpan);
+}
}
};
diff --git a/writerfilter/source/dmapper/TableManager.cxx
b/writerfilter/source/dmapper/TableManager.cxx
index 596d036a506a..678092a15280 100644
--- a/writerfilter/source/dmapper/TableManager.cxx
+++ b/writerfilter/source/dmapper/TableManager.cxx
@@ -64,9 +64,9 @@ std::vector TableManager::getCurrentGridSpans()
return mTableDataStack.top()->getCurrentRow()->getGridSpans();
}
-void TableManager::setCurrentGridSpan(sal_uInt32 nGridSpan)
+void TableManager::setCurrentGridSpan(sal_uInt32 nGridSpan, bool bFirstCell)
{
-mTableDataStack.top()->getCurrentRow()->setCurrentGridSpan(nGridSpan);
+mTableDataStack.top()->getCurrentRow()->setCurrentGridSpan(nGridSpan,
bFirstCell);
}
void TableManager::endOfRowAction() {}
@@ -456,6 +456,8 @@ void TableManager::endRow()
{
// don't add gridBefore cells in not valid TextRange
setCurrentGridBefore(0);
+setCurrentGridSpan(getCurrentGridSpans().front() + nGridBefore,
+ /*bFirstCell=*/true);
}
}
}
@@ -518,7 +520,6 @@ TableManager::TableManager()
TableManager::~TableManager() = default;
}
-
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/dmapper/TableManager.hxx
b/writerfilter/source/dmapper/TableManager.hxx
index efac7afdbd7c..f06f06b0cd72 100644
---
[Libreoffice-commits] online.git: Branch 'distro/collabora/co-4-2' - loleaflet/css loleaflet/src
loleaflet/css/device-mobile.css |6 +++---
loleaflet/src/control/Control.PartsPreview.js | 15 ++-
2 files changed, 13 insertions(+), 8 deletions(-)
New commits:
commit e6b3149825e19b69e8381651b0e3dbddc371a703
Author: Henry Castro
AuthorDate: Thu Jun 11 09:35:25 2020 -0400
Commit: Henry Castro
CommitDate: Tue Aug 11 21:46:27 2020 +0200
android: fix thumbnails images when portrait orientation is set
Change-Id: I70aee6b569f78795487cbff736130e0e7413e852
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/96123
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Henry Castro
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100553
diff --git a/loleaflet/css/device-mobile.css b/loleaflet/css/device-mobile.css
index ca7007b6a..0343a3a94 100644
--- a/loleaflet/css/device-mobile.css
+++ b/loleaflet/css/device-mobile.css
@@ -584,14 +584,14 @@ td[id^=tb_spreadsheet-toolbar_item]:focus
table.w2ui-button div.w2ui-icon, td[id
/* Related to slidesorter */
/* Show slidesorter beyond 768px only */
#presentation-controls-wrapper {
- top: initial;
+ top: 41px;
left: initial;
bottom: 33px;
max-width: initial;
}
#presentation-controls-wrapper.readonly {
- top: initial;
+ top: 41px;
bottom: 0px;
}
@@ -691,7 +691,6 @@ td[id^=tb_spreadsheet-toolbar_item]:focus table.w2ui-button
div.w2ui-icon, td[id
.preview-img-portrait {
min-width: 37px;
max-width: 60px;
- max-height: 45px;
margin: 0px;
}
@@ -721,6 +720,7 @@ td[id^=tb_spreadsheet-toolbar_item]:focus table.w2ui-button
div.w2ui-icon, td[id
}
#document-container.landscape.parts-preview-document {
+ top: 41px;
left: 66px !important;
bottom: 33px;
}
diff --git a/loleaflet/src/control/Control.PartsPreview.js
b/loleaflet/src/control/Control.PartsPreview.js
index 6143ee28b..da01e151d 100644
--- a/loleaflet/src/control/Control.PartsPreview.js
+++ b/loleaflet/src/control/Control.PartsPreview.js
@@ -12,8 +12,8 @@ L.Control.PartsPreview = L.Control.extend({
frameClass: '',
axis: '',
allowOrientation: true,
- maxWidth: (window.mode.isMobile() || window.mode.isTablet()) ?
60 : 180,
- maxHeight: (window.mode.isMobile() || window.mode.isTablet()) ?
60 : 180
+ maxWidth: !window.mode.isDesktop() ? 60 : 180,
+ maxHeight: !window.mode.isDesktop() ? 60 : 180
},
partsFocused: false,
@@ -120,7 +120,7 @@ L.Control.PartsPreview = L.Control.extend({
frame.setAttribute('draggable', false);
frame.setAttribute('id', 'first-drop-site');
- if (!window.mode.isMobile()) {
+ if (window.mode.isDesktop()) {
L.DomUtil.setStyle(frame, 'height',
'20px');
L.DomUtil.setStyle(frame, 'margin',
'0em');
}
@@ -206,7 +206,7 @@ L.Control.PartsPreview = L.Control.extend({
img.hash = hashCode;
img.src = L.Icon.Default.imagePath + '/preview_placeholder.png';
img.fetched = false;
- if (window.mode.isMobile() || window.mode.isTablet()) {
+ if (!window.mode.isDesktop()) {
(new Hammer(img, {recognizers: [[Hammer.Press]]}))
.on('press', function (e) {
if (this._map.isPermissionEdit()) {
@@ -302,7 +302,7 @@ L.Control.PartsPreview = L.Control.extend({
var previewImgMinWidth =
Math.round(parseFloat(L.DomUtil.getStyle(img, 'min-width')));
var imgHeight = imgSize.height;
var imgWidth = imgSize.width;
- if (imgSize.width < previewImgMinWidth)
+ if (imgSize.width < previewImgMinWidth &&
window.mode.isDesktop())
imgHeight = Math.round(imgHeight *
previewImgMinWidth / imgSize.width);
var previewFrameBB =
img.parentElement.getBoundingClientRect();
if (this._direction === 'x') {
@@ -315,6 +315,11 @@ L.Control.PartsPreview = L.Control.extend({
this._previewFrameHeight = imgHeight + 2 *
previewImgBorder;
}
}
+
+ if (!window.mode.isDesktop() && imgSize) {
+ L.DomUtil.setStyle(img, 'width', imgSize.width + 'px');
+ L.DomUtil.setStyle(img, 'height', imgSize.height +
'px');
+ }
},
_setPart: function (e) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
[Libreoffice-commits] online.git: Branch 'distro/collabora/co-4-2' - loleaflet/src
loleaflet/src/control/Control.PartsPreview.js | 20
loleaflet/src/layer/tile/ImpressTileLayer.js | 10 --
2 files changed, 24 insertions(+), 6 deletions(-)
New commits:
commit 1b7d5cf92779aa3506c5ac2e9f8526de682dbab7
Author: Henry Castro
AuthorDate: Fri Jul 3 16:10:18 2020 -0400
Commit: Henry Castro
CommitDate: Tue Aug 11 21:46:10 2020 +0200
loleaflet: fix the orientation only on main custom scroll
Since we are manually changing the CSS class names when
orientation changes, this is only valid for main custom scrollbar
because the mobile wizard scrollbar is always in portrait mode.
Change-Id: I0b9e7156dac0e33a6e793c7f6caae2021068f252
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97900
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Henry Castro
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100552
diff --git a/loleaflet/src/control/Control.PartsPreview.js
b/loleaflet/src/control/Control.PartsPreview.js
index e6006a8f3..6143ee28b 100644
--- a/loleaflet/src/control/Control.PartsPreview.js
+++ b/loleaflet/src/control/Control.PartsPreview.js
@@ -8,6 +8,10 @@ L.Control.PartsPreview = L.Control.extend({
options: {
fetchThumbnail: true,
autoUpdate: true,
+ imageClass: '',
+ frameClass: '',
+ axis: '',
+ allowOrientation: true,
maxWidth: (window.mode.isMobile() || window.mode.isTablet()) ?
60 : 180,
maxHeight: (window.mode.isMobile() || window.mode.isTablet()) ?
60 : 180
},
@@ -31,7 +35,9 @@ L.Control.PartsPreview = L.Control.extend({
onAdd: function (map) {
this._previewInitialized = false;
this._previewTiles = [];
- this._direction = window.mode.isMobile() &&
L.DomUtil.isPortrait() ? 'x' : 'y';
+ this._direction = this.options.allowOrientation ?
+ (!window.mode.isDesktop() && L.DomUtil.isPortrait() ?
'x' : 'y') :
+ this.options.axis;
this._scrollY = 0;
map.on('updateparts', this._updateDisabled, this);
@@ -108,7 +114,8 @@ L.Control.PartsPreview = L.Control.extend({
$(this._scrollContainer).css('display',
'inline-table');
// Add a special frame just as a drop-site for
reordering.
- var frame = L.DomUtil.create('div',
'preview-frame', this._scrollContainer);
+ var frameClass = 'preview-frame ' +
this.options.frameClass;
+ var frame = L.DomUtil.create('div', frameClass,
this._scrollContainer);
this._addDnDHandlers(frame);
frame.setAttribute('draggable', false);
frame.setAttribute('id', 'first-drop-site');
@@ -142,6 +149,10 @@ L.Control.PartsPreview = L.Control.extend({
}
}
+ if (!this.options.allowOrientation) {
+ return;
+ }
+
// update portrait / landscape
var removePreviewImg = 'preview-img-portrait';
var addPreviewImg = 'preview-img-landscape';
@@ -185,11 +196,12 @@ L.Control.PartsPreview = L.Control.extend({
},
_createPreview: function (i, hashCode, bottomBound) {
- var frame = L.DomUtil.create('div', 'preview-frame',
this._scrollContainer);
+ var frameClass = 'preview-frame ' + this.options.frameClass;
+ var frame = L.DomUtil.create('div', frameClass,
this._scrollContainer);
this._addDnDHandlers(frame);
L.DomUtil.create('span', 'preview-helper', frame);
- var imgClassName = 'preview-img';
+ var imgClassName = 'preview-img ' + this.options.imageClass;
var img = L.DomUtil.create('img', imgClassName, frame);
img.hash = hashCode;
img.src = L.Icon.Default.imagePath + '/preview_placeholder.png';
diff --git a/loleaflet/src/layer/tile/ImpressTileLayer.js
b/loleaflet/src/layer/tile/ImpressTileLayer.js
index dc7573d28..b4e77f167 100644
--- a/loleaflet/src/layer/tile/ImpressTileLayer.js
+++ b/loleaflet/src/layer/tile/ImpressTileLayer.js
@@ -59,7 +59,13 @@ L.ImpressTileLayer = L.TileLayer.extend({
var container = L.DomUtil.createWithId('div',
'mobile-wizard-header', mobileWizard);
var preview = L.DomUtil.createWithId('div',
'mobile-slide-sorter', container);
L.DomUtil.toBack(container);
- map.addControl(L.control.partsPreview(container,
preview, {fetchThumbnail: false}));
+
[Libreoffice-commits] online.git: Branch 'distro/collabora/co-4-2' - loleaflet/src
loleaflet/src/control/Control.PartsPreview.js |9 ++---
loleaflet/src/control/Parts.js|7 +--
2 files changed, 11 insertions(+), 5 deletions(-)
New commits:
commit b47e5a670270fcf72dbec330099c20c17fbcd807
Author: Henry Castro
AuthorDate: Fri Jul 3 15:59:32 2020 -0400
Commit: Henry Castro
CommitDate: Tue Aug 11 21:45:45 2020 +0200
loleaflet: fix the bounding rectangle when not visible
The preview thumbnail in mobile wizard are not visible yet,
so assume the map container rectangle bounds to properly
calculate the aspect ratio of the image
Change-Id: Iacc387b92e326965c86fb60d1acfde5b49365ad3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97899
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Henry Castro
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100551
diff --git a/loleaflet/src/control/Control.PartsPreview.js
b/loleaflet/src/control/Control.PartsPreview.js
index 3468d8e2e..e6006a8f3 100644
--- a/loleaflet/src/control/Control.PartsPreview.js
+++ b/loleaflet/src/control/Control.PartsPreview.js
@@ -232,6 +232,11 @@ L.Control.PartsPreview = L.Control.extend({
var previewContBB =
this._partsPreviewCont.getBoundingClientRect();
var bottomBound;
+ // is not visible yet, assume map bounds
+ if (previewContBB.right === 0 && previewContBB.bottom === 0) {
+ previewContBB =
this._map._container.getBoundingClientRect();
+ }
+
if (this._direction === 'x') {
this._previewContTop = previewContBB.left;
bottomBound = previewContBB.right + previewContBB.width
/ 2;
@@ -270,9 +275,7 @@ L.Control.PartsPreview = L.Control.extend({
var imgSize;
if (i === 0 || (previewFrameTop >= topBound && previewFrameTop
<= bottomBound)
|| (previewFrameBottom >= topBound &&
previewFrameBottom <= bottomBound)) {
- imgSize = this.options.fetchThumbnail ?
- this._map.getPreview(i, i,
this.options.maxWidth, this.options.maxHeight, {autoUpdate:
this.options.autoUpdate}) :
- { width: this.options.maxWidth, height:
this.options.maxHeight };
+ imgSize = this._map.getPreview(i, i,
this.options.maxWidth, this.options.maxHeight, {autoUpdate:
this.options.autoUpdate, fetchThumbnail: this.options.fetchThumbnail});
img.fetched = true;
if (this._direction === 'x') {
diff --git a/loleaflet/src/control/Parts.js b/loleaflet/src/control/Parts.js
index 18ba9084d..d112557f7 100644
--- a/loleaflet/src/control/Parts.js
+++ b/loleaflet/src/control/Parts.js
@@ -103,6 +103,7 @@ L.Map.include({
}
var autoUpdate = options ? !!options.autoUpdate : false;
var forAllClients = options ? !!options.broadcast : false;
+ var fetchThumbnail = options && options.fetchThumbnail ?
options.fetchThumbnail : true;
this._docPreviews[id] = {id: id, index: index, maxWidth:
maxWidth, maxHeight: maxHeight, autoUpdate: autoUpdate, invalid: false};
var docLayer = this._docLayer;
@@ -131,7 +132,8 @@ L.Map.include({
dpiscale = 2; // some may be hidpi, and it is fine to
send the hi-dpi slide preview to non-hpi clients
}
- this._socket.sendMessage('tile ' +
+ if (fetchThumbnail) {
+ this._socket.sendMessage('tile ' +
'nviewid=0' + ' ' +
'part=' + part + ' ' +
'width=' + maxWidth *
dpiscale + ' ' +
@@ -141,7 +143,8 @@ L.Map.include({
'tilewidth=' +
tileWidth + ' ' +
'tileheight=' +
tileHeight + ' ' +
'id=' + id + ' ' +
- 'broadcast=' +
(forAllClients ? 'yes' : 'no'));
+'broadcast=' + (forAllClients
? 'yes' : 'no'));
+ }
return {width: maxWidth, height: maxHeight};
},
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/co-4-2' - loleaflet/src
loleaflet/src/control/Control.PartsPreview.js | 13 +++
loleaflet/src/layer/tile/ImpressTileLayer.js | 30 --
loleaflet/src/map/Map.js |6 -
3 files changed, 9 insertions(+), 40 deletions(-)
New commits:
commit 2ca01188531d6ff499c5c1c19157903287a06317
Author: Henry Castro
AuthorDate: Fri Jul 3 15:42:09 2020 -0400
Commit: Henry Castro
CommitDate: Tue Aug 11 21:45:23 2020 +0200
loleaflet: re-creates the scrollbar when orientation changes
We are manually changing the orientation CSS class name for
preview thumbnails, so it requires to destroy and create again
the custom scroll with the new axis to show a vertical or
horizontal scroll bar
Change-Id: Ib341025da66db05f6feddbbb32a286da107cd8df
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97898
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Henry Castro
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100550
diff --git a/loleaflet/src/control/Control.PartsPreview.js
b/loleaflet/src/control/Control.PartsPreview.js
index 934b4b179..3468d8e2e 100644
--- a/loleaflet/src/control/Control.PartsPreview.js
+++ b/loleaflet/src/control/Control.PartsPreview.js
@@ -42,11 +42,8 @@ L.Control.PartsPreview = L.Control.extend({
map.on('docsize', this._updateAllPreview, this);
},
- createScrollbar: function (axis) {
+ createScrollbar: function () {
var control = this;
- if (axis) {
- this._direction = axis;
- }
$(this._partsPreviewCont).mCustomScrollbar({
axis: this._direction,
@@ -165,6 +162,14 @@ L.Control.PartsPreview = L.Control.extend({
var previewFrame =
$(this._partsPreviewCont).find('.preview-frame');
previewFrame.removeClass(removePreviewFrame);
previewFrame.addClass(addPreviewFrame);
+
+ // re-create scrollbar with new direction
+ var direction = this._direction;
+ this._direction = !window.mode.isDesktop() &&
L.DomUtil.isPortrait() ? 'x' : 'y';
+ if (direction !== this._direction) {
+
$(this._partsPreviewCont).mCustomScrollbar('destroy');
+ this.createScrollbar();
+ }
}
},
diff --git a/loleaflet/src/layer/tile/ImpressTileLayer.js
b/loleaflet/src/layer/tile/ImpressTileLayer.js
index cc02e444d..dc7573d28 100644
--- a/loleaflet/src/layer/tile/ImpressTileLayer.js
+++ b/loleaflet/src/layer/tile/ImpressTileLayer.js
@@ -48,7 +48,6 @@ L.ImpressTileLayer = L.TileLayer.extend({
map.on('AnnotationSave', this.onAnnotationSave, this);
map.on('AnnotationScrollUp', this.onAnnotationScrollUp, this);
map.on('AnnotationScrollDown', this.onAnnotationScrollDown,
this);
- map.on('orientationchange', this.onOrientationChange, this);
map.on('resize', this.onResize, this);
map.uiManager.initializeSpecializedUI('presentation');
@@ -255,35 +254,6 @@ L.ImpressTileLayer = L.TileLayer.extend({
}
},
- onOrientationChange: function () {
- var container = L.DomUtil.get('presentation-controls-wrapper');
- var preview = L.DomUtil.get('slide-sorter');
-
- if (!container || !preview) {
- return;
- }
-
- // Android change the orientation if the keyboard is visible
- if (L.Browser.android) {
- if (window.innerHeight < 2 * screen.height / 3) {
-
L.DomUtil.addClass(this._map.options.documentContainer, 'keyboard');
- $(preview).hide();
- } else {
-
L.DomUtil.removeClass(this._map.options.documentContainer, 'keyboard');
- $(preview).show();
- }
- }
-
- if (L.DomUtil.isPortrait() && $(preview).data('mCS').opt.axis
!== 'x') {
- $(preview).mCustomScrollbar('destroy');
- this._preview.createScrollbar('x');
- } else if (L.DomUtil.isLandscape() &&
$(preview).data('mCS').opt.axis !== 'y') {
- $(preview).mCustomScrollbar('destroy');
- this._preview.createScrollbar('y');
- }
-
- },
-
onUpdatePermission: function (e) {
if (window.mode.isMobile()) {
if (e.perm === 'edit') {
diff --git a/loleaflet/src/map/Map.js b/loleaflet/src/map/Map.js
index 5fdc1520d..37e703de9 100644
--- a/loleaflet/src/map/Map.js
+++ b/loleaflet/src/map/Map.js
[Libreoffice-commits] online.git: Branch 'distro/collabora/co-4-2' - loleaflet/src
loleaflet/src/control/Control.PartsPreview.js | 38 +++---
1 file changed, 17 insertions(+), 21 deletions(-)
New commits:
commit 7bf6c0604376bb0f1a33fdcc81e67ccf9b84c6f6
Author: Henry Castro
AuthorDate: Thu Jul 2 15:13:12 2020 -0400
Commit: Henry Castro
CommitDate: Tue Aug 11 21:45:04 2020 +0200
loleafet: simplify to compute the bottom bound of the preview thumbnails
Change-Id: I5ee8c5b4182b2752821fcd3bba022bc4b3db42d1
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97778
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Henry Castro
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100549
diff --git a/loleaflet/src/control/Control.PartsPreview.js
b/loleaflet/src/control/Control.PartsPreview.js
index 84b8a1579..934b4b179 100644
--- a/loleaflet/src/control/Control.PartsPreview.js
+++ b/loleaflet/src/control/Control.PartsPreview.js
@@ -86,18 +86,9 @@ L.Control.PartsPreview = L.Control.extend({
$('.scroll-container').mCustomScrollbar('update');
}, this), 500);
}
- var previewContBB =
this._partsPreviewCont.getBoundingClientRect();
- var bottomBound;
this.createScrollbar();
-
- if (this._direction === 'x') {
- this._previewContTop =
previewContBB.left;
- bottomBound = previewContBB.right +
previewContBB.width / 2;
- } else {
- this._previewContTop =
previewContBB.top;
- bottomBound = previewContBB.bottom +
previewContBB.height / 2;
- }
+ var bottomBound = this._getBottomBound();
this._map.on('click', function() {
this.partsFocused = false;
@@ -182,17 +173,7 @@ L.Control.PartsPreview = L.Control.extend({
return;
}
- var previewContBB =
this._partsPreviewCont.getBoundingClientRect();
- var bottomBound;
-
- if (this._direction === 'x') {
- this._previewContTop = previewContBB.left;
- bottomBound = previewContBB.right + previewContBB.width
/ 2;
- } else {
- this._previewContTop = previewContBB.top;
- bottomBound = previewContBB.bottom +
previewContBB.height / 2;
- }
-
+ var bottomBound = this._getBottomBound();
for (var prev = 0; prev < this._previewTiles.length; prev++) {
this._layoutPreview(prev, this._previewTiles[prev],
bottomBound);
}
@@ -242,6 +223,21 @@ L.Control.PartsPreview = L.Control.extend({
return img;
},
+ _getBottomBound: function () {
+ var previewContBB =
this._partsPreviewCont.getBoundingClientRect();
+ var bottomBound;
+
+ if (this._direction === 'x') {
+ this._previewContTop = previewContBB.left;
+ bottomBound = previewContBB.right + previewContBB.width
/ 2;
+ } else {
+ this._previewContTop = previewContBB.top;
+ bottomBound = previewContBB.bottom +
previewContBB.height / 2;
+ }
+
+ return bottomBound;
+ },
+
_layoutPreview: function (i, img, bottomBound) {
var topBound = this._previewContTop;
var previewFrameTop = 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/co-4-2' - loleaflet/src
loleaflet/src/control/Control.PartsPreview.js | 32 +++---
1 file changed, 29 insertions(+), 3 deletions(-)
New commits:
commit dcbea7d8ede6bed202fb48ce4a449dc6ef9209fc
Author: Henry Castro
AuthorDate: Thu Jul 2 10:59:56 2020 -0400
Commit: Henry Castro
CommitDate: Tue Aug 11 21:44:42 2020 +0200
loleaflet: update preview images when the doc size changes
The unit test checks the aspect ratio of the preview thumbnails,
this happens when the document size changes (i.e changing paper format)
Change-Id: I0267e797327b73d714947258e004fe64cce9d1dd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97775
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Henry Castro
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100548
diff --git a/loleaflet/src/control/Control.PartsPreview.js
b/loleaflet/src/control/Control.PartsPreview.js
index f7f11e348..84b8a1579 100644
--- a/loleaflet/src/control/Control.PartsPreview.js
+++ b/loleaflet/src/control/Control.PartsPreview.js
@@ -39,6 +39,7 @@ L.Control.PartsPreview = L.Control.extend({
map.on('tilepreview', this._updatePreview, this);
map.on('insertpage', this._insertPreview, this);
map.on('deletepage', this._deletePreview, this);
+ map.on('docsize', this._updateAllPreview, this);
},
createScrollbar: function (axis) {
@@ -176,6 +177,27 @@ L.Control.PartsPreview = L.Control.extend({
}
},
+ _updateAllPreview: function () {
+ if (this._previewTiles.length === 0) {
+ return;
+ }
+
+ var previewContBB =
this._partsPreviewCont.getBoundingClientRect();
+ var bottomBound;
+
+ if (this._direction === 'x') {
+ this._previewContTop = previewContBB.left;
+ bottomBound = previewContBB.right + previewContBB.width
/ 2;
+ } else {
+ this._previewContTop = previewContBB.top;
+ bottomBound = previewContBB.bottom +
previewContBB.height / 2;
+ }
+
+ for (var prev = 0; prev < this._previewTiles.length; prev++) {
+ this._layoutPreview(prev, this._previewTiles[prev],
bottomBound);
+ }
+ },
+
_createPreview: function (i, hashCode, bottomBound) {
var frame = L.DomUtil.create('div', 'preview-frame',
this._scrollContainer);
this._addDnDHandlers(frame);
@@ -215,6 +237,12 @@ L.Control.PartsPreview = L.Control.extend({
}
}, this);
+ this._layoutPreview(i, img, bottomBound);
+
+ return img;
+ },
+
+ _layoutPreview: function (i, img, bottomBound) {
var topBound = this._previewContTop;
var previewFrameTop = 0;
var previewFrameBottom = 0;
@@ -260,7 +288,7 @@ L.Control.PartsPreview = L.Control.extend({
var imgWidth = imgSize.width;
if (imgSize.width < previewImgMinWidth)
imgHeight = Math.round(imgHeight *
previewImgMinWidth / imgSize.width);
- var previewFrameBB = frame.getBoundingClientRect();
+ var previewFrameBB =
img.parentElement.getBoundingClientRect();
if (this._direction === 'x') {
this._previewFrameMargin = previewFrameBB.left
- this._previewContTop;
this._previewImgHeight = imgWidth;
@@ -271,8 +299,6 @@ L.Control.PartsPreview = L.Control.extend({
this._previewFrameHeight = imgHeight + 2 *
previewImgBorder;
}
}
-
- return img;
},
_setPart: function (e) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135645] LO corrupts bitmaps and crashes in X11 with 16 bit color (TrueColor)
https://bugs.documentfoundation.org/show_bug.cgi?id=135645 --- Comment #1 from crx...@hotmail.com --- Created attachment 164178 --> https://bugs.documentfoundation.org/attachment.cgi?id=164178=edit Corruption of UI bitmaps in 16 bit color -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: basctl/source
basctl/source/basicide/baside2b.cxx | 63 ++--
1 file changed, 33 insertions(+), 30 deletions(-)
New commits:
commit b71815a8d49f95657ce8253434187827e63a5ade
Author: Mike Kaganski
AuthorDate: Tue Aug 11 18:11:10 2020 +0300
Commit: Mike Kaganski
CommitDate: Tue Aug 11 21:37:04 2020 +0200
tdf#135639: check the return value of GetDim32
... to avoid crash accessing non-existing element of pChildItem->vIndices
Change-Id: I248a9301abd69883f940051d9d9671298dcc8453
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100540
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/basctl/source/basicide/baside2b.cxx
b/basctl/source/basicide/baside2b.cxx
index e13656ee73a7..7771b8acff3e 100644
--- a/basctl/source/basicide/baside2b.cxx
+++ b/basctl/source/basicide/baside2b.cxx
@@ -2128,43 +2128,46 @@ IMPL_LINK(WatchWindow, RequestingChildrenHdl, const
weld::TreeIter&, rParent, bo
int nParentLevel = bArrayIsRootArray ? pItem->nDimLevel : 0;
int nThisLevel = nParentLevel + 1;
sal_Int32 nMin, nMax;
-pArray->GetDim32( nThisLevel, nMin, nMax );
-for( sal_Int32 i = nMin ; i <= nMax ; i++ )
+if (pArray->GetDim32(nThisLevel, nMin, nMax))
{
-WatchItem* pChildItem = new WatchItem(pItem->maName);
+for (sal_Int32 i = nMin; i <= nMax; i++)
+{
+WatchItem* pChildItem = new WatchItem(pItem->maName);
-// Copy data and create name
+// Copy data and create name
-OUStringBuffer aIndexStr = "(";
-pChildItem->mpArrayParentItem = pItem;
-pChildItem->nDimLevel = nThisLevel;
-pChildItem->nDimCount = pItem->nDimCount;
-pChildItem->vIndices.resize(pChildItem->nDimCount);
-sal_Int32 j;
-for( j = 0 ; j < nParentLevel ; j++ )
-{
-sal_Int32 n = pChildItem->vIndices[j] = pItem->vIndices[j];
-aIndexStr.append(OUString::number( n )).append(",");
-}
-pChildItem->vIndices[nParentLevel] = i;
-aIndexStr.append(OUString::number( i )).append(")");
+OUStringBuffer aIndexStr = "(";
+pChildItem->mpArrayParentItem = pItem;
+pChildItem->nDimLevel = nThisLevel;
+pChildItem->nDimCount = pItem->nDimCount;
+pChildItem->vIndices.resize(pChildItem->nDimCount);
+sal_Int32 j;
+for (j = 0; j < nParentLevel; j++)
+{
+sal_Int32 n = pChildItem->vIndices[j] = pItem->vIndices[j];
+aIndexStr.append(OUString::number(n)).append(",");
+}
+pChildItem->vIndices[nParentLevel] = i;
+aIndexStr.append(OUString::number(i)).append(")");
-OUString aDisplayName;
-WatchItem* pArrayRootItem = pChildItem->GetRootItem();
-if( pArrayRootItem && pArrayRootItem->mpArrayParentItem )
-aDisplayName = pItem->maDisplayName;
-else
-aDisplayName = pItem->maName;
-aDisplayName += aIndexStr;
-pChildItem->maDisplayName = aDisplayName;
+OUString aDisplayName;
+WatchItem* pArrayRootItem = pChildItem->GetRootItem();
+if (pArrayRootItem && pArrayRootItem->mpArrayParentItem)
+aDisplayName = pItem->maDisplayName;
+else
+aDisplayName = pItem->maName;
+aDisplayName += aIndexStr;
+pChildItem->maDisplayName = aDisplayName;
-OUString
sId(OUString::number(reinterpret_cast(pChildItem)));
+OUString
sId(OUString::number(reinterpret_cast(pChildItem)));
-m_xTreeListBox->insert(, -1, , , nullptr,
nullptr, false, xRet.get());
-m_xTreeListBox->set_text(*xRet, "", 1);
-m_xTreeListBox->set_text(*xRet, "", 2);
+m_xTreeListBox->insert(, -1, , ,
nullptr, nullptr, false,
+ xRet.get());
+m_xTreeListBox->set_text(*xRet, "", 1);
+m_xTreeListBox->set_text(*xRet, "", 2);
-nElementCount++;
+nElementCount++;
+}
}
if (nElementCount > 0 && !m_nUpdateWatchesId)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135645] New: LO corrupts bitmaps and crashes in X11 with 16 bit color (TrueColor)
https://bugs.documentfoundation.org/show_bug.cgi?id=135645 Bug ID: 135645 Summary: LO corrupts bitmaps and crashes in X11 with 16 bit color (TrueColor) Product: LibreOffice Version: 6.4.0.1 rc Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: crx...@hotmail.com Description: Under Linux/X11 (tested in CentOS 8) when using a 16 bit color Xserver (also called TrueColor): All versions NEWER than 6.3.6(.2) show UI bitmap corruption and then will crash when any document creation operation is performed. This is a problem for my environment because we use lots of thin clients and 24 bit color creates 33% more network activity than 16 bit color. Have no problems with any other programs in 16 bit color (including latest Firefox and recent GIMP). Steps to Reproduce: Install LO version newer than 6.3, set display to 16 bit color, launch LO. Actual Results: bitmap corruption/crash Expected Results: no corruption/crashes Reproducible: Always User Profile Reset: Yes Additional Info: Can't paste help-> about. Any menu selections cause LO to crash. Crash report uploaded crashreport.libreoffice.org/stats/crash_details/88876691-8c91-4d6a-a34f-27e12da2cf5a -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/dmapper/PropertyMap.cxx |4
1 file changed, 4 insertions(+)
New commits:
commit 98665425ebb5cdeeda341336871ca4da7f4842b7
Author: Justin Luth
AuthorDate: Tue Aug 11 09:14:39 2020 +0300
Commit: Justin Luth
CommitDate: Tue Aug 11 21:31:47 2020 +0200
related tdf#135343 writerfilter: document broken nextColumn
Fortunately, it is rather hard in Word to insert a nextColumn
section-break, so this situation is rarely seen,
and bug 135343's fix made it even more irrelevant.
The fix includes unit tests demonstrating this problem.
The column break should be inserted around m_xStartingRange,
but the section should start from pPrevSection->m_xStartingRange
and be extended include this section. But I have no idea
how to do that.
At least documenting that something is completely broken
should be very useful for anyone drawn to this code.
Change-Id: I878f99601bb2181500d215a0440a34a62f3840f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100461
Tested-by: Justin Luth
Reviewed-by: Justin Luth
diff --git a/writerfilter/source/dmapper/PropertyMap.cxx
b/writerfilter/source/dmapper/PropertyMap.cxx
index 6b5af2fd9404..578738175238 100644
--- a/writerfilter/source/dmapper/PropertyMap.cxx
+++ b/writerfilter/source/dmapper/PropertyMap.cxx
@@ -1536,6 +1536,10 @@ void SectionPropertyMap::CloseSectionGroup(
DomainMapper_Impl& rDM_Impl )
try
{
InheritOrFinalizePageStyles( rDM_Impl );
+/*TODO tdf#135343: Just inserting a column break sounds like the
right idea, but the implementation is wrong.
+ * Somehow, the previous column section needs to be extended to
cover this new text.
+ * Currently, it is completely broken, producing a no-column
section that starts on a new page.
+ */
uno::Reference< beans::XPropertySet > xRangeProperties;
if ( m_xStartingRange.is() )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135114] crash when cursor moves off dialog box or collapsing dropdown strands cursor outside dialog box
https://bugs.documentfoundation.org/show_bug.cgi?id=135114 b...@shaw.ca changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED --- Comment #2 from b...@shaw.ca --- Resolved: bug not present in version 7.0.0. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135601] Table in Impress doesn't grow when adding text
https://bugs.documentfoundation.org/show_bug.cgi?id=135601 Telesto changed: What|Removed |Added Version|5.4.0.3 release |5.2.0.4 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135635] Bulleted list enabled out of nowhere (not explicitly enabled) and not enabled in older versions
https://bugs.documentfoundation.org/show_bug.cgi?id=135635 Telesto changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #1 from Telesto --- *** This bug has been marked as a duplicate of bug 130788 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135635] Bulleted list enabled out of nowhere (not explicitly enabled) and not enabled in older versions
https://bugs.documentfoundation.org/show_bug.cgi?id=135635 Telesto changed: What|Removed |Added Keywords|bibisectRequest, regression | --- Comment #2 from Telesto --- Bibisected to the same commit -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130788] Adding a New Column to a Table in Libreoffice Impress Formats the Column with Bulletted Text
https://bugs.documentfoundation.org/show_bug.cgi?id=130788 Telesto changed: What|Removed |Added CC||tele...@surfxs.nl --- Comment #7 from Telesto --- *** Bug 135635 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79538] Calc: Images move when printing or exporting to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=79538 lamb...@gmail.com changed: What|Removed |Added Version|4.2.4.2 release |6.4.4.2 release --- Comment #22 from lamb...@gmail.com --- Comment 21: confirmed on windows 10 x64, calc 6.4.4.2 (x64), but also previous versions had same issue. 45 pages calc document with images every 10-20 rows. once exported to pdf images are shifted of several rows, or even on on different page. It doesn't matter if images are anchored to page/call or if position is "protected". Print preview is ok Print to PDF using Microsoft PDF printer or PDF Xchange printer give good result if images are anchored to page and position is protected. source file is 13MB, but I'm willing to sent to anyone interested in look into it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135638] Accessibility of PDF export: some images are not flagged by Figure tag while exporting docx into pdf
https://bugs.documentfoundation.org/show_bug.cgi?id=135638 --- Comment #4 from V Stuart Foote --- Sorry, support for PDF/UA *is* available for testing in the 7.0.0 release--but must be enabled as an experimental feature from the Tools -> Options -> Advanced dialog and LO restarted. It is not available for the 6.3 or 6.4 releases. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135168] Lots of empty pages added on paste since 6.5
https://bugs.documentfoundation.org/show_bug.cgi?id=135168 Telesto changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
