[Libreoffice-bugs] [Bug 131228] Tip of the day cannot be switched off
https://bugs.documentfoundation.org/show_bug.cgi?id=131228 Anke Lange changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125257] [META] Tip of the day
https://bugs.documentfoundation.org/show_bug.cgi?id=125257 Bug 125257 depends on bug 131228, which changed state. Bug 131228 Summary: Tip of the day cannot be switched off https://bugs.documentfoundation.org/show_bug.cgi?id=131228 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136465] Cell contains incorrect value from formula
https://bugs.documentfoundation.org/show_bug.cgi?id=136465 --- Comment #20 from Mike Kaganski --- But your scenario had saved the file with autocalculation disabled. That is a setting saved per-file; so how did you activated it for the file? The description didn't tell that. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136465] Cell contains incorrect value from formula
https://bugs.documentfoundation.org/show_bug.cgi?id=136465 --- Comment #19 from Mike Kaganski --- (In reply to BogdanB from comment #18) I'd say it is unexpected, and a bug. Can't test at the moment; please file a separate bug report, and add Eike to it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135992] All LO applications stops accepting keyboard input while copy-n-pasting/changing worksheet name
https://bugs.documentfoundation.org/show_bug.cgi?id=135992 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135366] implementation errors for border of data labels in charts
https://bugs.documentfoundation.org/show_bug.cgi?id=135366 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment|target:7.1.0 |target:7.1.0| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136023] Navigator sidebar icons didn't respect property icon size
https://bugs.documentfoundation.org/show_bug.cgi?id=136023 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136020] Crash when try to move data label in a chart with arrow key
https://bugs.documentfoundation.org/show_bug.cgi?id=136020 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136014] Right side of comments were cropped during printing into PDF with comments at margins
https://bugs.documentfoundation.org/show_bug.cgi?id=136014 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136021] UI: Interactive Frame has no border line settings in the sidebar (nor position and size)
https://bugs.documentfoundation.org/show_bug.cgi?id=136021 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135513] Libreoffice 7 is not updating linked files. DDE appears to be inoperable
https://bugs.documentfoundation.org/show_bug.cgi?id=135513 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136017] Image frame background set to white explicitly (instead of non) on DOC export
https://bugs.documentfoundation.org/show_bug.cgi?id=136017 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136018] The image in a image frame disappearing while moving the frame around with arrow keys
https://bugs.documentfoundation.org/show_bug.cgi?id=136018 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 136021] UI: Interactive Frame has no border line settings in the sidebar (nor position and size)
https://bugs.documentfoundation.org/show_bug.cgi?id=136021 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 136011] Number in multi-line chart categories are not exported if chart is copied from Calc to Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=136011 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136029] Formating issue in menu
https://bugs.documentfoundation.org/show_bug.cgi?id=136029 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136006] Shapes in LO Calc do not get hidden from print preview UI when hidden from printing
https://bugs.documentfoundation.org/show_bug.cgi?id=136006 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136008] Menu Items DO NOT show label
https://bugs.documentfoundation.org/show_bug.cgi?id=136008 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130492] Latest LO version (6.4) still crashes when special character button is used!
https://bugs.documentfoundation.org/show_bug.cgi?id=130492 --- Comment #5 from QA Administrators --- Dear arjanl, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135998] Double clicking on a docx that has spaces in the path or file name generates an error but won't open
https://bugs.documentfoundation.org/show_bug.cgi?id=135998 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131228] Tip of the day cannot be switched off
https://bugs.documentfoundation.org/show_bug.cgi?id=131228 --- Comment #4 from QA Administrators --- Dear Anke Lange, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131142] request for a more intuitive behavior when search in document has zero results ("search key not found") -- and at displaying matches
https://bugs.documentfoundation.org/show_bug.cgi?id=131142 --- Comment #2 from QA Administrators --- Dear peter josvai, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 131142] request for a more intuitive behavior when search in document has zero results ("search key not found") -- and at displaying matches
https://bugs.documentfoundation.org/show_bug.cgi?id=131142 --- Comment #2 from QA Administrators --- Dear peter josvai, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 112216] UI: First press of Backspace or Delete cannot delete characters in distance of shadow for shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=112216 --- Comment #3 from QA Administrators --- Dear Kotaro Osada, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135996] LO 7 is not registering itself as for docx
https://bugs.documentfoundation.org/show_bug.cgi?id=135996 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130492] Latest LO version (6.4) still crashes when special character button is used!
https://bugs.documentfoundation.org/show_bug.cgi?id=130492 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136485] Screen become not responsive but excepting chrs
https://bugs.documentfoundation.org/show_bug.cgi?id=136485 Tim Myers changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136485] Screen become not responsive but excepting chrs
https://bugs.documentfoundation.org/show_bug.cgi?id=136485 --- Comment #3 from Tim Myers --- thank you that looks like it worked - four tries including one over an hour and no problem -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127592] [META] LibreOffice Basic incl."Option Compatible" modules
https://bugs.documentfoundation.org/show_bug.cgi?id=127592 Bug 127592 depends on bug 136467, which changed state. Bug 136467 Summary: Regression on Basic Iif() function https://bugs.documentfoundation.org/show_bug.cgi?id=136467 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136467] Regression on Basic Iif() function
https://bugs.documentfoundation.org/show_bug.cgi?id=136467 Aron Budea changed: What|Removed |Added Status|NEW |RESOLVED Keywords|bibisectRequest, regression |bibisected, bisected Resolution|--- |NOTABUG CC||ba...@caesar.elte.hu --- Comment #7 from Aron Budea --- (In reply to Alain Romedenne from comment #0) > Description: > Iif(condition, expression1, expression2) evaluates BOTH expressions before > execution. Exceptions can be raised unconditionnally. I don't think this is a regression. In fact, I don't think it's a bug, I haven't found a reference to StarBasic, but VBA has the same function: https://docs.microsoft.com/en-us/office/vba/language/reference/user-interface-help/iif-function This states: "IIf always evaluates both truepart and falsepart, even though it returns only one of them. Because of this, you should watch for undesirable side effects. For example, if evaluating falsepart results in a division by zero error, an error occurs even if expr is True." Further note on the change that happened in 6.3: > e.g. > Sub _inverse_ > Print Iif(x=0,0,1/x) > End Sub If you do it like this, there's been a division by zero in older versions as well: x=0 Print Iif(x=0,0,1/x) The difference in the evaluation of the original sample came with the following commit: https://cgit.freedesktop.org/libreoffice/core/commit/?id=15c39bb2e75df40c30bcbf789d815376dd2e31ce author Eike Rathke 2019-05-02 20:54:16 +0200 committer Eike Rathke 2019-05-02 22:35:35 +0200 Resolves: tdf#124605 ditch "if operand 1 is Empty, result is operand 2" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134314] Auto Complete does weird stuff when comes to Umlauts in German Version 6.4.4.2
https://bugs.documentfoundation.org/show_bug.cgi?id=134314 --- Comment #4 from c.voel...@gmx.net --- Oops -sent inadvertently- I continue where I left. The collected words list contains only three of four sample words, but these words in several forms obviously generated automatically, such as ermächtige, ermächtigen and ermächtigt, but also forms that dont make sense as Beschäftig without any useful ending. The word Beschlußfassung did not get saved in the list. I kept the new document open and typed the same words again. Typing "erm" gives me the chance to accept "ermächtigt" and the word gets inserted including the Umlaut if I do. If I go on typing the Umlaut as a fourth letter myself "ermä", ignoring the suggestion, I get it replaced immediately with "ermchtigte" without Umlaut and without a chance to reject the suggestion. With Gründungsjahr it is different as I dont get a suggestion when typing only two letters "Gr", but as soon as I type "Grü", it get immediate replacement with "Grndungsjahr", loosing my "ü" and without a chance to reject the replacement. Beschäftigte same situation described for ermächtigen. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134314] Auto Complete does weird stuff when comes to Umlauts in German Version 6.4.4.2
https://bugs.documentfoundation.org/show_bug.cgi?id=134314 --- Comment #3 from c.voel...@gmx.net --- Now it gets really weird. My (not neccessarily complete) Update history is as follows. I am updating about every two month. I had installed 6.4.0 in February 6.4.3 in April 6.4.4 in June 7.0.0 since August As such I used 6.4.3 for two month and I did not notice the behaviour. I dont type much (I actually do, but mostly Emails, not formatted documents), but I should have noticed within this timeframe, so it feels save to say, that the issue started in 6.4.4. I just checked and found my word list to be empty. I dont know why. The option "clear word list when closing a document" was not checked, so there should have been at least some words, unless they did not get cleaned out during major Update from 6.x to 7.x. I opened a new text document and entered the words mentioned in the first report, among them Gründungsjahr, ermächtigen, Beschlußfassung and Beschäftigte. The collected words list now contains Gründungsjahr, ermächtigen and Beschäftigte in several forms such as -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108770] [META] DOCX (OOXML) bullet and numbering list-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108770 Aron Budea changed: What|Removed |Added Depends on||136194 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=136194 [Bug 136194] FILEOPEN Chapter numbering in a DOTX import is wrong in version 7.0, was OK in 6.4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136194] FILEOPEN Chapter numbering in a DOTX import is wrong in version 7.0, was OK in 6.4
https://bugs.documentfoundation.org/show_bug.cgi?id=136194 Aron Budea changed: What|Removed |Added Summary|Chapter numbering in a DOTX |FILEOPEN Chapter numbering |import is wrong in version |in a DOTX import is wrong |7.0, was OK in 6.4 |in version 7.0, was OK in ||6.4 Blocks||108770 Keywords|bibisectRequest |bibisected, bisected CC||ba...@caesar.elte.hu, ||libreoff...@nisz.hu, ||nem...@numbertext.org --- Comment #9 from Aron Budea --- (In reply to Mike Kaganski from comment #7) > I suspect a rebression from a fix to tdf#76817. Good guess, it is a regression from that, bibisected to the following commit using repo bibisect-linux-64-7.1. Adding CC: to László Németh. https://cgit.freedesktop.org/libreoffice/core/commit/?id=2128d59ab91da853652305390d56b3287bcb67b1 author László Németh2020-06-12 11:11:16 +0200 committer László Németh2020-06-12 17:42:00 +0200 tdf#76817: DOCX import: fix chapter numbering Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108770 [Bug 108770] [META] DOCX (OOXML) bullet and numbering list-related issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132688] Display of diacritics added to existing files is broken in lines with punctuation or footnotes/endnotes
https://bugs.documentfoundation.org/show_bug.cgi?id=132688 --- Comment #19 from Yotam Benshalom --- The issue is fixed in the latest build :-) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136503] Write crash when saves a file
https://bugs.documentfoundation.org/show_bug.cgi?id=136503 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #2 from BogdanB --- Please try 7.0.1. It was relased some days ago. And waiting for your results. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136504] New: EDITING: Backspace does not move the cursor to the left of a character recorded as deleted by "track changes"
https://bugs.documentfoundation.org/show_bug.cgi?id=136504 Bug ID: 136504 Summary: EDITING: Backspace does not move the cursor to the left of a character recorded as deleted by "track changes" Product: LibreOffice Version: 7.0.0.3 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: vdt.du...@gmail.com Description: When "track changes" is activated and visible, it is not possible to move the cursor to the left of a deleted character, i.e. the strike-through ones, by pressing backspace. This results, for example, in the impossibility to delete more than one character at a time when track changes are recorded and visible. Steps to Reproduce: 1. Activate track changes recording (edit > track changes > Record) and make the changes visible (edit > track changes > show) 2. Try to delete some text by pressing backspace 3. Or set your cursor to the right of character recorded as deleted, i.e. marked as stroked-through Actual Results: cursor does not move to the left of the deleted character, making it impossible to delete more than one character at a time or navigate trough text marked as deleted using the backspace key Expected Results: cursor should have shifted to the left Reproducible: Always User Profile Reset: No Additional Info: Tested on Debian Buster and Manjaro (both using KDE desktop) Writer 6.4.4.2 is working as expected delete key is working as expected even in Writer 7.0.0.3 (i.e. cursor moves to the right of previously deleted character) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136485] Screen become not responsive but excepting chrs
https://bugs.documentfoundation.org/show_bug.cgi?id=136485 --- Comment #2 from Telesto --- Tools -> Options -> View -> Check Force Skia Software Rendering (if unchecked). Press OK & Restart -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: hwpfilter/source
hwpfilter/source/formula.cxx |6 +--
hwpfilter/source/hwplib.h | 13 ++
hwpfilter/source/hwpreader.cxx | 82 -
3 files changed, 57 insertions(+), 44 deletions(-)
New commits:
commit 4f76b5e6fdd41d7d7a5302b4e9ea991236c9fdce
Author: Stephan Bergmann
AuthorDate: Sat Sep 5 21:41:36 2020 +0200
Commit: Stephan Bergmann
CommitDate: Sat Sep 5 23:23:06 2020 +0200
Improve hchar_string to OUString conversion
...assuming the way of constructing an OUString from just a
hchar_string::c_str
pointer, ignoring hchar_string::length, was not chosen deliberately to cut
off
the input string at a potential embedded NUL.
(This change is a prerequisite for making the OUString ctor taking a raw
pointer
explicit.)
Change-Id: I172a5627354c3da7105e50763edcb31cd89633e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102089
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/hwpfilter/source/formula.cxx b/hwpfilter/source/formula.cxx
index 119bd7642355..a5ba8a040854 100644
--- a/hwpfilter/source/formula.cxx
+++ b/hwpfilter/source/formula.cxx
@@ -217,7 +217,7 @@ void Formula::makeIdentifier(Node *res)
indo;
#else
rstartEl("math:mi", mxList.get());
- runistr(reinterpret_cast(getMathMLEntity(tmp->value).c_str()));
+ runistr(fromHcharStringToOUString(getMathMLEntity(tmp->value)));
rendEl("math:mi");
#endif
break;
@@ -239,7 +239,7 @@ void Formula::makeIdentifier(Node *res)
inds; fprintf(stderr,"%s\n",tmp->value); indo;
#else
rstartEl("math:mo", mxList.get());
- runistr(reinterpret_cast(getMathMLEntity(tmp->value).c_str()));
+ runistr(fromHcharStringToOUString(getMathMLEntity(tmp->value)));
rendEl("math:mo");
#endif
break;
@@ -400,7 +400,7 @@ void Formula::makeDecoration(Node *res)
indo;
#else
rstartEl("math:mo", mxList.get());
- runistr(reinterpret_cast(getMathMLEntity(tmp->value).c_str()));
+ runistr(fromHcharStringToOUString(getMathMLEntity(tmp->value)));
rendEl("math:mo");
#endif
diff --git a/hwpfilter/source/hwplib.h b/hwpfilter/source/hwplib.h
index 39d2f1b171f3..ec438d36134e 100644
--- a/hwpfilter/source/hwplib.h
+++ b/hwpfilter/source/hwplib.h
@@ -21,8 +21,14 @@
#define INCLUDED_HWPFILTER_SOURCE_HWPLIB_H
#include "precompile.h"
+#include
+#include
#include
+#include
+#include
+#include
+
/* hwp96부터 hunit가 4byte가 되었다. */
/**
* size of hunit is 4 since hwp96 version
@@ -37,6 +43,13 @@ typedef unsigned intuint;
typedef ::std::basic_string hchar_string;
+inline OUString fromHcharStringToOUString(hchar_string const & s) {
+if (s.length() >
o3tl::make_unsigned(std::numeric_limits::max())) {
+throw std::bad_alloc();
+}
+return {reinterpret_cast(s.c_str()),
sal_Int32(s.length())};
+}
+
/**
* @short Point
*/
diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index dfd7c5b95571..9a785645a5a3 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -265,21 +265,21 @@ void HwpReader::makeMeta()
if (hwpinfo.summary.title[0])
{
rstartEl("dc:title", mxList.get());
-rchars(reinterpret_cast(hconv(hwpinfo.summary.title)));
+rchars(fromHcharStringToOUString(hstr2ucsstr(hwpinfo.summary.title)));
rendEl("dc:title");
}
if (hwpinfo.summary.subject[0])
{
rstartEl("dc:subject", mxList.get());
-rchars(reinterpret_cast(hconv(hwpinfo.summary.subject)));
+
rchars(fromHcharStringToOUString(hstr2ucsstr(hwpinfo.summary.subject)));
rendEl("dc:subject");
}
if (hwpinfo.summary.author[0])
{
rstartEl("meta:initial-creator", mxList.get());
-rchars(reinterpret_cast(hconv(hwpinfo.summary.author)));
+rchars(fromHcharStringToOUString(hstr2ucsstr(hwpinfo.summary.author)));
rendEl("meta:initial-creator");
}
@@ -353,31 +353,31 @@ void HwpReader::makeMeta()
if (hwpinfo.summary.keyword[0][0])
{
rstartEl("meta:keyword", mxList.get());
-rchars(reinterpret_cast(hconv(hwpinfo.summary.keyword[0])));
+
rchars(fromHcharStringToOUString(hstr2ucsstr(hwpinfo.summary.keyword[0])));
rendEl("meta:keyword");
}
if (hwpinfo.summary.keyword[1][0])
{
rstartEl("meta:keyword", mxList.get());
-rchars(reinterpret_cast(hconv(hwpinfo.summary.keyword[1])));
+
rchars(fromHcharStringToOUString(hstr2ucsstr(hwpinfo.summary.keyword[1])));
rendEl("meta:keyword");
}
if (hwpinfo.summary.etc[0][0])
{
rstartEl("meta:keyword", mxList.get());
-rchars(reinterpret_cast(hconv(hwpinfo.summary.etc[0])));
+
[Libreoffice-commits] core.git: vcl/skia
vcl/skia/salbmp.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4c7b53f5af5d20be4e342cd7343db76567a98401 Author: Andrea Gelmini AuthorDate: Sat Sep 5 18:13:35 2020 +0200 Commit: Julien Nabet CommitDate: Sat Sep 5 23:14:18 2020 +0200 Fix typo Change-Id: Ia11acec42981e8c0015c972a8d5e72b918a292aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102077 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/vcl/skia/salbmp.cxx b/vcl/skia/salbmp.cxx index af9596a3ace7..ec91417cdf1b 100644 --- a/vcl/skia/salbmp.cxx +++ b/vcl/skia/salbmp.cxx @@ -779,7 +779,7 @@ bool SkiaSalBitmap::IsFullyOpaqueAsAlpha() const return false; // don't bother figuring it out from the pixels // If the erase color is set so that this bitmap used as alpha would // mean a fully opaque alpha mask (= noop), we can skip using it. -// Note that for alpha bitmaps we use the VCL "trasparency" convention, +// Note that for alpha bitmaps we use the VCL "transparency" convention, // i.e. alpha 0 is opaque. return SkColorGetA(fromEraseColorToAlphaImageColor(mEraseColor)) == 0; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: filter/source
filter/source/msfilter/eschesdo.hxx |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
New commits:
commit 138f02ac273d8a7217c51c800f18836041229b99
Author: Stephan Bergmann
AuthorDate: Sat Sep 5 21:38:37 2020 +0200
Commit: Stephan Bergmann
CommitDate: Sat Sep 5 22:57:12 2020 +0200
Drop unused ImplEESdrObject::ImplGetInt32PropertyValue overload
(This change is a prerequisite for making the OUString ctor taking a raw
pointer
explicit.)
Change-Id: I7a61a709c3a4950d067ed600a7c0441afe51043f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102088
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/filter/source/msfilter/eschesdo.hxx
b/filter/source/msfilter/eschesdo.hxx
index 3461a253c2f8..fc1522c79dca 100644
--- a/filter/source/msfilter/eschesdo.hxx
+++ b/filter/source/msfilter/eschesdo.hxx
@@ -53,10 +53,8 @@ public:
bool ImplGetPropertyValue( const OUString& rString );
-sal_Int32 ImplGetInt32PropertyValue( const sal_Unicode* pStr )
-{ return ImplGetPropertyValue( pStr ) ? *o3tl::doAccess(mAny) :
0; }
sal_Int32 ImplGetInt32PropertyValue( const OUString& rStr )
-{ return ImplGetInt32PropertyValue(rStr.getStr()); }
+{ return ImplGetPropertyValue( rStr ) ? *o3tl::doAccess(mAny) :
0; }
const css::uno::Reference< css::drawing::XShape >&GetShapeRef() const
{ return mXShape; }
const css::uno::Any& GetUsrAny() const { return mAny; }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: unotools/source
unotools/source/misc/fontdefs.cxx | 470 ++
1 file changed, 228 insertions(+), 242 deletions(-)
New commits:
commit 085e8ebd769b430fbd7ac0614f292697d4b36103
Author: Stephan Bergmann
AuthorDate: Sat Sep 5 21:22:21 2020 +0200
Commit: Stephan Bergmann
CommitDate: Sat Sep 5 22:52:01 2020 +0200
Simplify creation of the FontNameDictionary
Some of the key sal_Unicode arrays contained embedded NUL characters, for
which
everything after the first NUL was ignored. But from the corresponding
comment,
it looks like those sal_Unicode arrays were presumably meant to contain
multiple
keys that should all map to the same "English name," which I have added now.
(The original history of this source file beyond
942dbe34b9a1400c926a81f88e849d248b58ed55 "#i103496#: move some
fontsubstitution
stuff from vcl to unotools to get xmloff vcl free" appears to be lost,
unfortunately. Another comment had already wondered why keys were
terminated by
double NULs, where the second NUL maybe was originally meant to terminate
that
sequence of individual keys all stored in a single sal_Unicode array.)
There was also another
// TODO: check if all dictionary entries are already normalized?
in the construction of the FontNameDictionary aDictionary, of which I'm not
sure
what it should mean exactly, and whether I should have left it in.
(This change is a prerequisite for making the OUString ctor taking a raw
pointer
explicit.)
Change-Id: I168778307a67c6b72bf483dc34bfd45f8a48a143
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102086
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/unotools/source/misc/fontdefs.cxx
b/unotools/source/misc/fontdefs.cxx
index 6b8804d9e8c8..9effac2e839a 100644
--- a/unotools/source/misc/fontdefs.cxx
+++ b/unotools/source/misc/fontdefs.cxx
@@ -22,56 +22,49 @@
#include
#include
-namespace {
-
-struct ImplLocalizedFontName
-{
-const char* mpEnglishName;
-const sal_Unicode* mpLocalizedNames;
-};
-
-}
-
-// TODO: where did the 0,0 delimiters come from? A single 0 should suffice...
-sal_Unicode const aBatang[] = { 0xBC14, 0xD0D5, 0, 0 };
-sal_Unicode const aBatangChe[] = { 0xBC14, 0xD0D5, 0xCCB4, 0, 0 };
-sal_Unicode const aGungsuh[] = { 0xAD81, 0xC11C, 0, 0 };
-sal_Unicode const aGungsuhChe[] = { 0xAD81, 0xC11C, 0xCCB4, 0, 0 };
-sal_Unicode const aGulim[] = { 0xAD74, 0xB9BC, 0, 0 };
-sal_Unicode const aGulimChe[] = { 0xAD74, 0xB9BC, 0xCCB4, 0, 0 };
-sal_Unicode const aDotum[] = { 0xB3CB, 0xC6C0, 0, 0 };
-sal_Unicode const aDotumChe[] = { 0xB3CB, 0xC6C0, 0xCCB4, 0, 0 };
-sal_Unicode const aSimSun[] = { 0x5B8B, 0x4F53, 0, 0 };
-sal_Unicode const aNSimSun[] = { 0x65B0, 0x5B8B, 0x4F53, 0, 0 };
-sal_Unicode const aSimHei[] = { 0x9ED1, 0x4F53, 0, 0 };
-sal_Unicode const aSimKai[] = { 0x6977, 0x4F53, 0, 0 };
-sal_Unicode const azycjkSun[] = { 0x4E2D, 0x6613, 0x5B8B, 0x4F53, 0, 0 };
-sal_Unicode const azycjkHei[] = { 0x4E2D, 0x6613, 0x9ED1, 0x4F53, 0, 0 };
-sal_Unicode const azycjkKai[] = { 0x4E2D, 0x6613, 0x6977, 0x4F53, 0, 0 };
-sal_Unicode const aFZHei[] = { 0x65B9, 0x6B63, 0x9ED1, 0x4F53, 0, 0 };
-sal_Unicode const aFZKai[] = { 0x65B9, 0x6B63, 0x6977, 0x4F53, 0, 0 };
-sal_Unicode const aFZSongYI[] = { 0x65B9, 0x6B63, 0x5B8B, 0x4E00, 0, 0 };
-sal_Unicode const aFZShuSong[] = { 0x65B9, 0x6B63, 0x4E66, 0x5B8B, 0, 0 };
-sal_Unicode const aFZFangSong[] = { 0x65B9, 0x6B63, 0x4EFF, 0x5B8B, 0, 0 };
+sal_Unicode const aBatang[] = { 0xBC14, 0xD0D5, 0 };
+sal_Unicode const aBatangChe[] = { 0xBC14, 0xD0D5, 0xCCB4, 0 };
+sal_Unicode const aGungsuh[] = { 0xAD81, 0xC11C, 0 };
+sal_Unicode const aGungsuhChe[] = { 0xAD81, 0xC11C, 0xCCB4, 0 };
+sal_Unicode const aGulim[] = { 0xAD74, 0xB9BC, 0 };
+sal_Unicode const aGulimChe[] = { 0xAD74, 0xB9BC, 0xCCB4, 0 };
+sal_Unicode const aDotum[] = { 0xB3CB, 0xC6C0, 0 };
+sal_Unicode const aDotumChe[] = { 0xB3CB, 0xC6C0, 0xCCB4, 0 };
+sal_Unicode const aSimSun[] = { 0x5B8B, 0x4F53, 0 };
+sal_Unicode const aNSimSun[] = { 0x65B0, 0x5B8B, 0x4F53, 0 };
+sal_Unicode const aSimHei[] = { 0x9ED1, 0x4F53, 0 };
+sal_Unicode const aSimKai[] = { 0x6977, 0x4F53, 0 };
+sal_Unicode const azycjkSun[] = { 0x4E2D, 0x6613, 0x5B8B, 0x4F53, 0 };
+sal_Unicode const azycjkHei[] = { 0x4E2D, 0x6613, 0x9ED1, 0x4F53, 0 };
+sal_Unicode const azycjkKai[] = { 0x4E2D, 0x6613, 0x6977, 0x4F53, 0 };
+sal_Unicode const aFZHei[] = { 0x65B9, 0x6B63, 0x9ED1, 0x4F53, 0 };
+sal_Unicode const aFZKai[] = { 0x65B9, 0x6B63, 0x6977, 0x4F53, 0 };
+sal_Unicode const aFZSongYI[] = { 0x65B9, 0x6B63, 0x5B8B, 0x4E00, 0 };
+sal_Unicode const aFZShuSong[] = { 0x65B9, 0x6B63, 0x4E66, 0x5B8B, 0 };
+sal_Unicode const aFZFangSong[] = { 0x65B9, 0x6B63, 0x4EFF, 0x5B8B, 0 };
// Attention: this fonts includes the wrong encoding vector - so we double the
names with correct and wrong encoding
// First one is the GB-Encoding (we think the correct
[Libreoffice-bugs] [Bug 136503] Write crash when saves a file
https://bugs.documentfoundation.org/show_bug.cgi?id=136503 --- Comment #1 from Angel --- Write crash if you try to save it as DOC or DOCX, but works well if you save ir as ODT -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136503] Write crash when saves a file
https://bugs.documentfoundation.org/show_bug.cgi?id=136503 Angel changed: What|Removed |Added Version|7.1.0.0.alpha0+ Master |7.0.0.1 rc OS|All |Windows (All) CC||ang...@rumbosur.com.ar Hardware|All |x86-64 (AMD64) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136503] New: Write crash when saves a file
https://bugs.documentfoundation.org/show_bug.cgi?id=136503 Bug ID: 136503 Summary: Write crash when saves a file Product: LibreOffice Version: 7.1.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ang...@rumbosur.com.ar Created attachment 165187 --> https://bugs.documentfoundation.org/attachment.cgi?id=165187=edit Example file When save a file Write crash Simply open the attached file and try to save it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: filter/source
filter/source/t602/t602filter.cxx | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
New commits:
commit 0f323c534fdfe511deb5a4d2ed15bc789475d904
Author: Stephan Bergmann
AuthorDate: Sat Sep 5 21:36:00 2020 +0200
Commit: Stephan Bergmann
CommitDate: Sat Sep 5 22:40:33 2020 +0200
Simplify construction of a single-character OUString
(This change is a prerequisite for making the OUString ctor taking a raw
pointer
explicit.)
Change-Id: Ifc7450591c723223e8c696110866e8ee5e2900e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102087
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/filter/source/t602/t602filter.cxx
b/filter/source/t602/t602filter.cxx
index 19500d6093a5..13a1841f7f7e 100644
--- a/filter/source/t602/t602filter.cxx
+++ b/filter/source/t602/t602filter.cxx
@@ -472,9 +472,7 @@ void T602ImportFilter::Reset602()
void T602ImportFilter::inschrdef(unsigned char ch)
{
-static sal_Unicode xch[2];
-
-xch[1] = 0;
+sal_Unicode xch;
if(ch > 127) {
@@ -486,15 +484,15 @@ void T602ImportFilter::inschrdef(unsigned char ch)
}
if(ini.ruscode)
-xch[0] = (rus2UNC[(ch-128)*2] << 8) + rus2UNC[(ch-128)*2+1];
+xch = (rus2UNC[(ch-128)*2] << 8) + rus2UNC[(ch-128)*2+1];
else
-xch[0] = (lat2UNC[(ch-128)*2] << 8) + lat2UNC[(ch-128)*2+1];
+xch = (lat2UNC[(ch-128)*2] << 8) + lat2UNC[(ch-128)*2+1];
} else
-xch[0] = ch;
+xch = ch;
pst.waspar = false;
if (mxHandler.is())
-mxHandler->characters(xch);
+mxHandler->characters(OUString(xch));
}
void T602ImportFilter::wrtfnt()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: i18npool/source
i18npool/source/textconversion/textconversion_zh.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit d211909bb95f99b5adc6d49f60610f4d0676afbd
Author: Stephan Bergmann
AuthorDate: Sat Sep 5 18:33:27 2020 +0200
Commit: Stephan Bergmann
CommitDate: Sat Sep 5 22:28:21 2020 +0200
Simplify comparison between OUString and raw pointer
...avoiding the construction of an intermediary temporary OUString,
assuming the
given `word` will never contain embedded NUL characters.
(This change is a prerequisite for making the OUString ctor taking a raw
pointer
explicit.)
Change-Id: I3b500557abb3554e9dfda63ef30b22c6c06c99c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102084
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/i18npool/source/textconversion/textconversion_zh.cxx
b/i18npool/source/textconversion/textconversion_zh.cxx
index d45baa553e53..23689c0b568e 100644
--- a/i18npool/source/textconversion/textconversion_zh.cxx
+++ b/i18npool/source/textconversion/textconversion_zh.cxx
@@ -218,7 +218,8 @@ TextConversion_zh::getWordConversion(const OUString& aText,
sal_Int32 nStartPos,
while (bottom <= top && !found) {
current = (top + bottom) / 2;
-const sal_Int32 result = word.compareTo(wordData +
entry[current]);
+const sal_Int32 result = rtl_ustr_compare(
+word.getStr(), wordData + entry[current]);
if (result < 0)
top = current - 1;
else if (result > 0)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 116491] Identify commands of experimental features in the customization dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=116491 --- Comment #5 from Muhammet Kara --- (In reply to Heiko Tietze from comment #3) > I get Emoji also with Tools > Options > Advanced > Experimental off and can > assign it to the toolbar, for instance, but of course it's not shown then. > Thing is that I have no clue in the UI what command is experimental. I'd > still prefer gray font color like for disabled controls (ideally taking the > RGB value from system settings). That listbox unfortunately doesn't seem to support such a way of identification. Since we now always have the description field filled, maybe we can add something like this at the top of the description field? [EXPERIMENTAL] -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136465] Cell contains incorrect value from formula
https://bugs.documentfoundation.org/show_bug.cgi?id=136465 --- Comment #18 from BogdanB --- I played with this now. I made this test: - I created a file with 1, 4 and the sum of the 2 numbers. Autocalculate is NOT checked. Change the 4 to 6. The sum is wrong. Save the file and close. - First scenario: Recalculate still NOT checked. Open the file from above. THe sum is wrong. - Second scenario: Recalculate activated. Open the file from above. The sum is wrong. Select the sum. F9 - the sum is correct. Change the number: the sum is wrong. My conclusion: if a formula is created when Autocalculate is NOT checked, this formula will never became autocalculate, even IF autocalculate is activated. It is interesting to know what properties this formula or cell have, because I consider NOT to be ok, to have Autocalculate checked and not to have the real autocalculate for some cells activated. So, if there is a properties, this should change depending of the Autocalculate. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136498] In PDF options "%PRODUCTNAME" is displayed in tooltip
https://bugs.documentfoundation.org/show_bug.cgi?id=136498 --- Comment #2 from Julien Nabet --- @devs: shouldn't all %PRODUCTNAME placeholders be taken into account by ./sysui/desktop/share/brand.pl ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136502] app freezes
https://bugs.documentfoundation.org/show_bug.cgi?id=136502 Julien Nabet changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||serval2...@yahoo.fr --- Comment #1 from Julien Nabet --- Could you give a try to last stable LO version 6.4.6 + try https://wiki.documentfoundation.org/QA/FirstSteps if necessary? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: shell/source
shell/source/backends/kf5be/kf5access.cxx | 23 ---
1 file changed, 16 insertions(+), 7 deletions(-)
New commits:
commit 1bc728580364c626aa04df624e2afac8fa92890e
Author: Stephan Bergmann
AuthorDate: Sat Sep 5 18:29:59 2020 +0200
Commit: Stephan Bergmann
CommitDate: Sat Sep 5 21:19:56 2020 +0200
Improve QString to OUString conversion
...assuming the way of constructing an OUString from just a QString::utf16
pointer, ignoring QString::size, was not chosen deliberately to cut of the
input
string at a potential embedded NUL.
(This change is a prerequisite for making the OUString ctor taking a raw
pointer
explicit.)
Change-Id: I3fb3026065f0247c19f0497d28adf422106bd9c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102083
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/shell/source/backends/kf5be/kf5access.cxx
b/shell/source/backends/kf5be/kf5access.cxx
index d983b6d308ca..27d047d640d1 100644
--- a/shell/source/backends/kf5be/kf5access.cxx
+++ b/shell/source/backends/kf5be/kf5access.cxx
@@ -45,6 +45,15 @@ namespace
namespace uno = css::uno;
}
+namespace
+{
+OUString fromQStringToOUString(QString const& s)
+{
+// Conversion from QString size()'s int to OUString's sal_Int32 should be
non-narrowing:
+return { reinterpret_cast(s.utf16()), s.size() };
+}
+}
+
css::beans::Optional getValue(OUString const& id)
{
if (id == "ExternalMailer")
@@ -58,7 +67,7 @@ css::beans::Optional getValue(OUString const&
id)
aClientProgram = QStringLiteral("kmail");
else
aClientProgram = aClientProgram.section(QLatin1Char(' '), 0, 0);
-sClientProgram = reinterpret_cast(aClientProgram.utf16());
+sClientProgram = fromQStringToOUString(aClientProgram);
return css::beans::Optional(true,
uno::makeAny(sClientProgram));
}
else if (id == "SourceViewFontHeight")
@@ -71,7 +80,7 @@ css::beans::Optional getValue(OUString const&
id)
{
const QFont aFixedFont =
QFontDatabase::systemFont(QFontDatabase::FixedFont);
const QString aFontName = aFixedFont.family();
-const OUString sFontName = reinterpret_cast(aFontName.utf16());
+const OUString sFontName = fromQStringToOUString(aFontName);
return css::beans::Optional(true,
uno::makeAny(sFontName));
}
else if (id == "EnableATToolSupport")
@@ -90,7 +99,7 @@ css::beans::Optional getValue(OUString const&
id)
OUString sDocumentsURL;
if (aDocumentsDir.endsWith(QLatin1Char('/')))
aDocumentsDir.truncate(aDocumentsDir.length() - 1);
-sDocumentsDir = reinterpret_cast(aDocumentsDir.utf16());
+sDocumentsDir = fromQStringToOUString(aDocumentsDir);
osl_getFileURLFromSystemPath(sDocumentsDir.pData,
);
return css::beans::Optional(true,
uno::makeAny(sDocumentsURL));
}
@@ -117,7 +126,7 @@ css::beans::Optional getValue(OUString
const& id)
if (!aFTPProxy.isEmpty())
{
QUrl aProxy(aFTPProxy);
-OUString sProxy = reinterpret_cast(aProxy.host().utf16());
+OUString sProxy = fromQStringToOUString(aProxy.host());
return css::beans::Optional(true,
uno::makeAny(sProxy));
}
}
@@ -171,7 +180,7 @@ css::beans::Optional getValue(OUString
const& id)
if (!aHTTPProxy.isEmpty())
{
QUrl aProxy(aHTTPProxy);
-OUString sProxy = reinterpret_cast(aProxy.host().utf16());
+OUString sProxy = fromQStringToOUString(aProxy.host());
return css::beans::Optional(true,
uno::makeAny(sProxy));
}
}
@@ -225,7 +234,7 @@ css::beans::Optional getValue(OUString
const& id)
if (!aHTTPSProxy.isEmpty())
{
QUrl aProxy(aHTTPSProxy);
-OUString sProxy = reinterpret_cast(aProxy.host().utf16());
+OUString sProxy = fromQStringToOUString(aProxy.host());
return css::beans::Optional(true,
uno::makeAny(sProxy));
}
}
@@ -275,7 +284,7 @@ css::beans::Optional getValue(OUString
const& id)
OUString sNoProxyFor;
aNoProxyFor = aNoProxyFor.replace(QLatin1Char(','),
QLatin1Char(';'));
-sNoProxyFor = reinterpret_cast(aNoProxyFor.utf16());
+sNoProxyFor = fromQStringToOUString(aNoProxyFor);
return css::beans::Optional(true,
uno::makeAny(sNoProxyFor));
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 136405] Merging Cells Removes Formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=136405 BogdanB changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #7 from BogdanB --- Hi, Ray, have you watch all 3 videos? (one in comment 1, one in comment 2 and one in comment 3). If you can NOt see the video right click and download them, and watch with your mediaplayer. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 136490] UI: No visual difference between page break indictor with page style set & page break without page style set
https://bugs.documentfoundation.org/show_bug.cgi?id=136490 --- Comment #6 from Telesto --- (In reply to V Stuart Foote from comment #5) > Umm, isn't this exactly the function of the Navigator -> Styles -> Page > Styles tab? It gives direct visual indicator of which page style has been > applied to the page holding current edit cursor focus. Maybe I should give few examples 1. Page 2 = Landscape; Based on? Paragraph Style -> Text Flow -> ?; Nope. Next Page on previous page 2. Page 3 = Default style. Based on? Nope. Next Page on previous page? Nope Paragraph Style -> Text Flow -> Yes 3. Page 4 = Default style. Based on? Paragraph Style -> Text Flow -> No. Next Page 4. Page 5 = Not default page style; looks like it. How to detect. Click in the document Status bar or sidebar.. However, page style isn't noticeable while simply scrolling; or should I say no indication.. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 136490] UI: No visual difference between page break indictor with page style set & page break without page style set
https://bugs.documentfoundation.org/show_bug.cgi?id=136490 --- Comment #6 from Telesto --- (In reply to V Stuart Foote from comment #5) > Umm, isn't this exactly the function of the Navigator -> Styles -> Page > Styles tab? It gives direct visual indicator of which page style has been > applied to the page holding current edit cursor focus. Maybe I should give few examples 1. Page 2 = Landscape; Based on? Paragraph Style -> Text Flow -> ?; Nope. Next Page on previous page 2. Page 3 = Default style. Based on? Nope. Next Page on previous page? Nope Paragraph Style -> Text Flow -> Yes 3. Page 4 = Default style. Based on? Paragraph Style -> Text Flow -> No. Next Page 4. Page 5 = Not default page style; looks like it. How to detect. Click in the document Status bar or sidebar.. However, page style isn't noticeable while simply scrolling; or should I say no indication.. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136502] New: app freezes
https://bugs.documentfoundation.org/show_bug.cgi?id=136502 Bug ID: 136502 Summary: app freezes Product: LibreOffice Version: 6.1.6.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: harvwe...@gmail.com Description: When I click on any OPEN FILE and select a file, the file displays but is frozen. When that happens, no changes to the file (edits, deletions) are possible, and I can't even logoff the app. I have to re-start my PC and tell it to complete the file update, before the file is unfrozen. Steps to Reproduce: 1.click on Libreoffice6.3 icon on desktop. 2.go to OPEN FILE 3.select a file and try to make a change-- freezes about 50% of the time. Actual Results: freezes about 50% of tries. Expected Results: re-started my computer. says LibreOffice preventing re-start. option to re-start anyway. after re-start, asks if I want to update Libreoffice. I say yes, does update and file is unfrozen. Reproducible: Sometimes User Profile Reset: Yes Additional Info: opened without a file freeze. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136501] Selection frame doesn't not around image when slightly moving left (anchor to character)
https://bugs.documentfoundation.org/show_bug.cgi?id=136501 Telesto changed: What|Removed |Added Keywords|bibisectRequest, regression | Version|7.1.0.0.alpha0+ Master |Inherited From OOo --- Comment #4 from Telesto --- Also in 6.0 and in 4.4.7.2 and in Versie: 4.1.0.4 Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28 and in LibreOffice 3.5.7.2 Build ID: 3215f89-f603614-ab984f2-7348103-1225a5b and in LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136490] UI: No visual difference between page break indictor with page style set & page break without page style set
https://bugs.documentfoundation.org/show_bug.cgi?id=136490 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #5 from V Stuart Foote --- Umm, isn't this exactly the function of the Navigator -> Styles -> Page Styles tab? It gives direct visual indicator of which page style has been applied to the page holding current edit cursor focus. Paragraphs, and therefore pages with no page style assigned, take the 'default page style' as defined in template, or as the style is modified with direct formatting. And, assigning a page break but making no page style selection will follow the page style 'Next style' value--which for standard template 'Default paragraph' is 'Default page style' . Rather IMHO => NAB and WF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 136490] UI: No visual difference between page break indictor with page style set & page break without page style set
https://bugs.documentfoundation.org/show_bug.cgi?id=136490 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #5 from V Stuart Foote --- Umm, isn't this exactly the function of the Navigator -> Styles -> Page Styles tab? It gives direct visual indicator of which page style has been applied to the page holding current edit cursor focus. Paragraphs, and therefore pages with no page style assigned, take the 'default page style' as defined in template, or as the style is modified with direct formatting. And, assigning a page break but making no page style selection will follow the page style 'Next style' value--which for standard template 'Default paragraph' is 'Default page style' . Rather IMHO => NAB and WF -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 136501] Selection frame doesn't not around image when slightly moving left (anchor to character)
https://bugs.documentfoundation.org/show_bug.cgi?id=136501 Telesto changed: What|Removed |Added Keywords||bibisectRequest, regression --- Comment #3 from Telesto --- Not in Version: 6.0.6.0.0+ Build ID: c30963b8b4bbbe42a24b97aafa161eff9d7ccdd4 CPU threads: 4; OS: Windows 6.3; UI render: default; Locale: nl-NL (nl_NL); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136501] Selection frame doesn't not around image when slightly moving left (anchor to character)
https://bugs.documentfoundation.org/show_bug.cgi?id=136501 --- Comment #2 from Telesto --- Created attachment 165186 --> https://bugs.documentfoundation.org/attachment.cgi?id=165186=edit Screencast -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136501] New: Selection frame doesn't not around image when slightly moving left (anchor to character)
https://bugs.documentfoundation.org/show_bug.cgi?id=136501 Bug ID: 136501 Summary: Selection frame doesn't not around image when slightly moving left (anchor to character) Product: LibreOffice Version: 7.1.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Selection frame doesn't not around image when slightly moving left (anchor to character) Steps to Reproduce: 1. open the attached file 2. Go to page 2 3. Select the image with the mouse & hold left mouse button & move slightly left Actual Results: Frame of page Expected Results: Release an image moves to the second page Reproducible: Always User Profile Reset: No Additional Info: Version: 7.1.0.0.alpha0+ (x64) Build ID: e8b8e7be0b2ad693224cd94062a55610eb69df7e CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136501] Selection frame doesn't not around image when slightly moving left (anchor to character)
https://bugs.documentfoundation.org/show_bug.cgi?id=136501 --- Comment #1 from Telesto --- Created attachment 165185 --> https://bugs.documentfoundation.org/attachment.cgi?id=165185=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: solenv/gbuild
solenv/gbuild/platform/macosx.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c6104462fbe11ae053155b5f6c2ec52d31f0481c Author: Noel Grandin AuthorDate: Sat Sep 5 18:24:24 2020 +0200 Commit: Noel Grandin CommitDate: Sat Sep 5 20:45:38 2020 +0200 fix macOS malloc debugging which was introduced with insufficient testing in commit 302d85a931586313e04f82d206970dbc3bce9a47 add macOS malloc debugging env vars And this fix also avoids the potential problem of turning on malloc debugging for lldb itself. Change-Id: I0d65cefbd3ce8aea7223c6f0a3470b7ecbc8da89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102082 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/solenv/gbuild/platform/macosx.mk b/solenv/gbuild/platform/macosx.mk index 431f8e4b45fc..101251952e4b 100644 --- a/solenv/gbuild/platform/macosx.mk +++ b/solenv/gbuild/platform/macosx.mk @@ -261,7 +261,7 @@ gb_CppunitTest_CPPTESTPRECOMMAND := \ $(call gb_Helper_extend_ld_path,$(gb_Library_DLLDIR):$(WORKDIR)/UnpackedTarball/cppunit/src/cppunit/.libs) gb_CppunitTest_get_filename = libtest_$(1).dylib gb_CppunitTest_get_ilibfilename = $(gb_CppunitTest_get_filename) -gb_CppunitTest_malloc_check := MallocScribble=1 MallocPreScribble=1 +gb_CppunitTest_malloc_check := -o "env MallocScribble=1" -o "env MallocPreScribble=1" define gb_CppunitTest_CppunitTest_platform $(call gb_LinkTarget_get_target,$(2)) : RPATH := ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 136479] Regression started in 7.0.1 - In Toolbar Background color, Font color & Border color shows blank (should show default color or last used color)
https://bugs.documentfoundation.org/show_bug.cgi?id=136479 Telesto changed: What|Removed |Added CC||tele...@surfxs.nl --- Comment #6 from Telesto --- There was a bug their.. But solved. I assumed it landed in 7.0.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 136500] UI: Disable they Page Rotation setting for landscape page style
https://bugs.documentfoundation.org/show_bug.cgi?id=136500 Telesto changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 136500] New: UI: Disable they Page Rotation setting for landscape page style
https://bugs.documentfoundation.org/show_bug.cgi?id=136500 Bug ID: 136500 Summary: UI: Disable they Page Rotation setting for landscape page style Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: UI: Disable they Page Rotation setting for landscape page style Steps to Reproduce: 1. Open Writer -> Sidebar -> Styles -> Page Styles -> Right Click Landscape Modify 2. Page tab Actual Results: It's possible to change the rotation of the landscape page style. This would result in a page style not matching it's name Expected Results: If it's not to hard, simply disabling that setting (simply as precaution) Reproducible: Always User Profile Reset: No Additional Info: Version: 7.1.0.0.alpha0+ (x64) Build ID: e8b8e7be0b2ad693224cd94062a55610eb69df7e CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136500] UI: Disable they Page Rotation setting for landscape page style
https://bugs.documentfoundation.org/show_bug.cgi?id=136500 Telesto changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135800] Explain changing page style in Help
https://bugs.documentfoundation.org/show_bug.cgi?id=135800 Telesto changed: What|Removed |Added CC||jl...@mail.com --- Comment #8 from Telesto --- @Justin Sorry, for distributing those page style issues around.. always taking another route.. Comment 7 shows a number of issues. Comment 0 and answer in comment 3 The issue, you start to combine different approaches. And you even need to. And different context makes it really hard to follow. See also Bug 136348 comment 3. And also bug 136490. It doesn't make it (always) any easier that pages styles are attached to paragraph's (or me not being used to that) This is (partly) solved by the blue page break bar. Except Page 1 has none. So you need Paragraph dialog/ Text flow tab (and you still need to know). Or you use Status bar page style/ or Sidebar -> Styles -> Page Style. You can't use Insert -> More breaks -> Manual break. You could use Format -> Page Style -> Page orientation -> But that's changing the orientation for the default page (so what you actually want) If add new page with CTRL+ENTER, and want change the rotation, you can't use Sidebar -> Styles -> Page Style nor Status bar page style; this will convert also the first page. You now need to use Insert -> More breaks -> Manual break for inserting the page break or Format -> Paragraph -> Text Flow. Or access the paragraph style from the blue header bar Alternatively you can go the first page/ Format -> Page -> Style and set next style. But that's of course not what you supposed to do (if I understand it correctly) You can't see if a page break 'contains' an explicit page style setting (could be the same as the previous page) or non. Which isn't helping either. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 135800] Explain changing page style in Help
https://bugs.documentfoundation.org/show_bug.cgi?id=135800 Telesto changed: What|Removed |Added CC||jl...@mail.com --- Comment #8 from Telesto --- @Justin Sorry, for distributing those page style issues around.. always taking another route.. Comment 7 shows a number of issues. Comment 0 and answer in comment 3 The issue, you start to combine different approaches. And you even need to. And different context makes it really hard to follow. See also Bug 136348 comment 3. And also bug 136490. It doesn't make it (always) any easier that pages styles are attached to paragraph's (or me not being used to that) This is (partly) solved by the blue page break bar. Except Page 1 has none. So you need Paragraph dialog/ Text flow tab (and you still need to know). Or you use Status bar page style/ or Sidebar -> Styles -> Page Style. You can't use Insert -> More breaks -> Manual break. You could use Format -> Page Style -> Page orientation -> But that's changing the orientation for the default page (so what you actually want) If add new page with CTRL+ENTER, and want change the rotation, you can't use Sidebar -> Styles -> Page Style nor Status bar page style; this will convert also the first page. You now need to use Insert -> More breaks -> Manual break for inserting the page break or Format -> Paragraph -> Text Flow. Or access the paragraph style from the blue header bar Alternatively you can go the first page/ Format -> Page -> Style and set next style. But that's of course not what you supposed to do (if I understand it correctly) You can't see if a page break 'contains' an explicit page style setting (could be the same as the previous page) or non. Which isn't helping either. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: registry/source
registry/source/regimpl.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit aa357e56e8b6185e66ce763ca48fff61fe718bd7 Author: Stephan Bergmann AuthorDate: Sat Sep 5 18:25:07 2020 +0200 Commit: Stephan Bergmann CommitDate: Sat Sep 5 20:21:00 2020 +0200 Improve some OUString to OString conversions ...dropping an intermediary OUString temporary (assuming that way of constructing an OUString temporary from a pointer was not chosen deliberately to cut of the string at a potential embedded NUL). (This change is a prerequisite for making the OUString ctor taking a raw pointer explicit.) Change-Id: I752a0e63b86cb5e3d1a97ede1d855b9602a353c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102081 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/registry/source/regimpl.cxx b/registry/source/regimpl.cxx index f0c8162434d4..60d90faa9c6c 100644 --- a/registry/source/regimpl.cxx +++ b/registry/source/regimpl.cxx @@ -1383,7 +1383,7 @@ RegError ORegistry::dumpValue(const OUString& sPath, const OUString& sName, sal_ std::unique_ptr value(new sal_Unicode[size]); readString(aBuffer.data(), value.get(), size); -OString uStr = OUStringToOString(value.get(), RTL_TEXTENCODING_UTF8); +OString uStr(value.get(), rtl_ustr_getLength(value.get()), RTL_TEXTENCODING_UTF8); fprintf(stdout, "L\"%s\"\n", uStr.getStr()); } break; @@ -1498,7 +1498,7 @@ RegError ORegistry::dumpValue(const OUString& sPath, const OUString& sName, sal_ if (offset > 8) fprintf(stdout, "%s ", indent); -uStr = OUStringToOString(pValue, RTL_TEXTENCODING_UTF8); +uStr = OString(pValue, rtl_ustr_getLength(pValue), RTL_TEXTENCODING_UTF8); fprintf( stdout, "%lu = L\"%s\"\n", sal::static_int_cast< unsigned long >(i), ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: dbaccess/source
dbaccess/source/ui/dlg/tablespage.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 125b3ab3478b615a2391bdbd208c0e3efca1a5d6
Author: Stephan Bergmann
AuthorDate: Sat Sep 5 18:19:30 2020 +0200
Commit: Stephan Bergmann
CommitDate: Sat Sep 5 20:20:38 2020 +0200
Drop some seemingly redundant OUString(OUString::getStr()) construction
...assuming it was not chosen deliberately to cut of the input string at a
potential embedded NUL (or for whatever other arcane reason).
(This change is a prerequisite for making the OUString ctor taking a raw
pointer
explicit.)
Change-Id: I74411e590cedc4394a240435a837a406dc18cfb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102079
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/dbaccess/source/ui/dlg/tablespage.cxx
b/dbaccess/source/ui/dlg/tablespage.cxx
index 36d9fb8cbce2..180d84eacdd4 100644
--- a/dbaccess/source/ui/dlg/tablespage.cxx
+++ b/dbaccess/source/ui/dlg/tablespage.cxx
@@ -105,7 +105,7 @@ namespace dbaui
for (const OUString& rIncludeTable : _rTables)
{
if (xMeta.is())
-qualifiedNameComponents(xMeta, rIncludeTable.getStr(),
sCatalog, sSchema, sName,::dbtools::EComposeRule::InDataManipulation);
+qualifiedNameComponents(xMeta, rIncludeTable, sCatalog,
sSchema, sName,::dbtools::EComposeRule::InDataManipulation);
else
sName = rIncludeTable;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: registry/source
registry/source/regimpl.cxx |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
New commits:
commit 573f472c6d282c69d16d4ed985c7433c75876745
Author: Stephan Bergmann
AuthorDate: Sat Sep 5 18:23:31 2020 +0200
Commit: Stephan Bergmann
CommitDate: Sat Sep 5 20:20:13 2020 +0200
Make printString take any std::u16string_view argument
(This change is a prerequisite for making the OUString ctor taking a raw
pointer
explicit.)
Change-Id: I201c87e47ae83b7c3df39e5abb420d6a80b1d3e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102080
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/registry/source/regimpl.cxx b/registry/source/regimpl.cxx
index 583cddd295d1..f0c8162434d4 100644
--- a/registry/source/regimpl.cxx
+++ b/registry/source/regimpl.cxx
@@ -20,8 +20,10 @@
#include "regimpl.hxx"
+#include
#include
#include
+#include
#include
#include
#include
@@ -52,9 +54,9 @@ using namespace store;
namespace {
-void printString(OUString const & s) {
+void printString(std::u16string_view s) {
printf("\"");
-for (sal_Int32 i = 0; i < s.getLength(); ++i) {
+for (std::size_t i = 0; i < s.size(); ++i) {
sal_Unicode c = s[i];
if (c == '"' || c == '\\') {
printf("\\%c", static_cast< char >(c));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 136498] In PDF options "%PRODUCTNAME" is displayed in tooltip
https://bugs.documentfoundation.org/show_bug.cgi?id=136498 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I could reproduce this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/drivers/firebird/DatabaseMetaData.cxx |8 connectivity/source/drivers/mysqlc/mysqlc_databasemetadata.cxx |4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) New commits: commit 1daeea3a48fe08979139648289e188bb9fc211b3 Author: Stephan Bergmann AuthorDate: Sat Sep 5 18:15:24 2020 +0200 Commit: Stephan Bergmann CommitDate: Sat Sep 5 19:54:29 2020 +0200 Drop some seemingly redundant OUString(OUString::getStr()) constructions ...assuming they were not chosen deliberately to cut of the input string at a potential embedded NUL (or for whatever other arcane reason). (This change is a prerequisite for making the OUString ctor taking a raw pointer explicit.) Change-Id: I0f029ac8c7851e3722ec2e9e2e003c22d3453e6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102078 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/connectivity/source/drivers/firebird/DatabaseMetaData.cxx b/connectivity/source/drivers/firebird/DatabaseMetaData.cxx index 62a22454fc60..16ecb9e1a520 100644 --- a/connectivity/source/drivers/firebird/DatabaseMetaData.cxx +++ b/connectivity/source/drivers/firebird/DatabaseMetaData.cxx @@ -1075,7 +1075,7 @@ uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getColumnPrivileges( OUString query = queryBuf.makeStringAndClear(); -uno::Reference< XResultSet > rs = statement->executeQuery(query.getStr()); +uno::Reference< XResultSet > rs = statement->executeQuery(query); uno::Reference< XRow > xRow( rs, UNO_QUERY_THROW ); ODatabaseMetaDataResultSet::ORows aResults; @@ -1164,7 +1164,7 @@ uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getColumns( OUString query = queryBuf.makeStringAndClear(); uno::Reference< XStatement > statement = m_pConnection->createStatement(); -uno::Reference< XResultSet > rs = statement->executeQuery(query.getStr()); +uno::Reference< XResultSet > rs = statement->executeQuery(query); uno::Reference< XRow > xRow( rs, UNO_QUERY_THROW ); ODatabaseMetaDataResultSet::ORows aResults; @@ -1366,7 +1366,7 @@ uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getTables( OUString query = queryBuf.makeStringAndClear(); -uno::Reference< XResultSet > rs = statement->executeQuery(query.getStr()); +uno::Reference< XResultSet > rs = statement->executeQuery(query); uno::Reference< XRow > xRow( rs, UNO_QUERY_THROW ); ODatabaseMetaDataResultSet::ORows aResults; @@ -1749,7 +1749,7 @@ uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getTablePrivileges( OUString query = queryBuf.makeStringAndClear(); -uno::Reference< XResultSet > rs = statement->executeQuery(query.getStr()); +uno::Reference< XResultSet > rs = statement->executeQuery(query); uno::Reference< XRow > xRow( rs, UNO_QUERY_THROW ); ODatabaseMetaDataResultSet::ORows aResults; diff --git a/connectivity/source/drivers/mysqlc/mysqlc_databasemetadata.cxx b/connectivity/source/drivers/mysqlc/mysqlc_databasemetadata.cxx index a30e5d61808a..77e20700b135 100644 --- a/connectivity/source/drivers/mysqlc/mysqlc_databasemetadata.cxx +++ b/connectivity/source/drivers/mysqlc/mysqlc_databasemetadata.cxx @@ -747,7 +747,7 @@ Reference SAL_CALL ODatabaseMetaData::getColumns(const Any& /*catalo OUString query = queryBuf.makeStringAndClear(); Reference statement = m_rConnection.createStatement(); -Reference rs = statement->executeQuery(query.getStr()); +Reference rs = statement->executeQuery(query); Reference xRow(rs, UNO_QUERY_THROW); Reference xResultSet(getOwnConnection().getDriver().getFactory()->createInstance( @@ -946,7 +946,7 @@ Reference SAL_CALL ODatabaseMetaData::getImportedKeys(const Any& /*c std::vector> aRows; Reference statement = m_rConnection.createStatement(); -Reference rs = statement->executeQuery(query.getStr()); +Reference rs = statement->executeQuery(query); Reference xRow(rs, UNO_QUERY_THROW); while (rs->next()) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: registry/source
registry/source/keyimpl.cxx |4 ++--
registry/source/regimpl.cxx | 10 +-
2 files changed, 7 insertions(+), 7 deletions(-)
New commits:
commit 7fc98802ecd6d9e198ae37269f10522286db987e
Author: Stephan Bergmann
AuthorDate: Tue Sep 1 17:14:10 2020 +0200
Commit: Stephan Bergmann
CommitDate: Sat Sep 5 19:54:05 2020 +0200
Create OUString from storeFindData m_pszName and m_nLength
...assuming that (a) m_nLength does always reflect the actual m_pszName
length,
and (b) that way of constructing an OUString from a pointer was not chosen
deliberately to cut of the string at a potential embedded NUL.
(This change is a prerequisite for making the OUString ctor taking a raw
pointer
explicit.)
Change-Id: I75519825cd6b60a7c308a3697bfbfc40afb2d1c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102076
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/registry/source/keyimpl.cxx b/registry/source/keyimpl.cxx
index f3cb2d00b34e..e76512e9e19a 100644
--- a/registry/source/keyimpl.cxx
+++ b/registry/source/keyimpl.cxx
@@ -111,7 +111,7 @@ RegError ORegKey::openSubKeys(const OUString& keyName,
RegKeyHandle** phOpenSubK
{
if ( iter.m_nAttrib & STORE_ATTRIB_ISDIR )
{
-OUString const sSubKeyName = iter.m_pszName;
+OUString const sSubKeyName(iter.m_pszName, iter.m_nLength);
ORegKey* pOpenSubKey = nullptr;
_ret = pKey->openKey(sSubKeyName,
reinterpret_cast());
@@ -175,7 +175,7 @@ RegError ORegKey::getKeyNames(const OUString& keyName,
{
if ( iter.m_nAttrib & STORE_ATTRIB_ISDIR)
{
-OUString const sSubKeyName = iter.m_pszName;
+OUString const sSubKeyName(iter.m_pszName, iter.m_nLength);
OUString sFullKeyName(pKey->getName());
if (sFullKeyName.getLength() > 1)
diff --git a/registry/source/regimpl.cxx b/registry/source/regimpl.cxx
index 000d82fdd927..583cddd295d1 100644
--- a/registry/source/regimpl.cxx
+++ b/registry/source/regimpl.cxx
@@ -820,7 +820,7 @@ RegError ORegistry::deleteSubkeysAndValues(ORegKey* pKey)
while (_err == store_E_None)
{
-OUString const keyName = iter.m_pszName;
+OUString const keyName(iter.m_pszName, iter.m_nLength);
if (iter.m_nAttrib & STORE_ATTRIB_ISDIR)
{
@@ -867,7 +867,7 @@ RegError ORegistry::loadKey(RegKeyHandle hKey, const
OUString& regFileName,
while (_err == store_E_None)
{
-OUString const keyName = iter.m_pszName;
+OUString const keyName(iter.m_pszName, iter.m_nLength);
if (iter.m_nAttrib & STORE_ATTRIB_ISDIR)
{
@@ -1221,7 +1221,7 @@ RegError ORegistry::loadAndSaveKeys(ORegKey* pTargetKey,
while (_err == store_E_None)
{
-OUString const sName = iter.m_pszName;
+OUString const sName(iter.m_pszName, iter.m_nLength);
if (iter.m_nAttrib & STORE_ATTRIB_ISDIR)
{
@@ -1266,7 +1266,7 @@ RegError ORegistry::dumpRegistry(RegKeyHandle hKey) const
while (_err == store_E_None)
{
-sName = iter.m_pszName;
+sName = OUString(iter.m_pszName, iter.m_nLength);
if (iter.m_nAttrib & STORE_ATTRIB_ISDIR)
{
@@ -1552,7 +1552,7 @@ RegError ORegistry::dumpKey(const OUString& sPath, const
OUString& sName, sal_In
while (_err == store_E_None)
{
-sSubName = iter.m_pszName;
+sSubName = OUString(iter.m_pszName, iter.m_nLength);
if (iter.m_nAttrib & STORE_ATTRIB_ISDIR)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Build error
I resolved it. It was some config issue.. On Fri, 4 Sep, 2020, 10:49 PM anshu khare, wrote: > Hi, > > Recently my college tests have been going on. So I couldn't work much on > the development. > > I had some issues with the build recently. So I removed libo-core and got > it installed again. > If I run > > cd /cygdrive/c/build > instdir/program/soffice.bin > > from cygwin shell, LibreOfficeDev opens up without any issues. > > But when I open LibreOffice.sln from C:/ Build in Visual Studio and build > it's solution, it gives the following error : > > > Error MSB3073 The command "chcp 65001 >NUL && C:/cygwin64/bin/dash.exe -c > "PATH=\"/bin:$PATH\";BUILDDIR=\"C:/build\" C:/cygwin64/opt/lo/bin/make -rsC > C:/sources/libo-core/sal Library_sal"" exited with code 2. > Error on line 46 of Microsoft.MakeFile.Targets in project Library sal > > This error is not only for library sal, but it is also for all the > libraries. > I guess that the solution is being built for the previous faulty build. > How should I build solution for the new build? > > Or is there some other configuration problem? > > > Regards, > Anshu > ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sd/source
sd/source/ui/view/drviews1.cxx |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit bb0c7d1615ba56966cddf1ef6caa25c08f1bd852
Author: Pranam Lashkari
AuthorDate: Wed Aug 26 22:50:56 2020 +0530
Commit: Pranam Lashkari
CommitDate: Sat Sep 5 19:01:20 2020 +0200
LOK: allow slide switching in mobile even if it is same slide
problem:
In the mobile view taping on the selected slide preview would open the
wizard
but when some object is selected on the slide
wizard would open for that object
this patch helps us to set the Page as selection and as result
mobile wizard opens for the slide even when some object on slide is selected
Change-Id: I99cbece8b18ec8766956157c0231e5a0f600d993
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101869
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari
diff --git a/sd/source/ui/view/drviews1.cxx b/sd/source/ui/view/drviews1.cxx
index ab2339220574..70c9ba3a2090 100644
--- a/sd/source/ui/view/drviews1.cxx
+++ b/sd/source/ui/view/drviews1.cxx
@@ -30,6 +30,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -913,7 +914,8 @@ bool DrawViewShell::SwitchPage(sal_uInt16 nSelectedPage)
SdPage* pCurrentPage = pPV ?
dynamic_cast(pPV->GetPage()) : nullptr;
if (pCurrentPage
&& pNewPage == pCurrentPage
-&&
maTabControl->GetPageText(maTabControl->GetPageId(nSelectedPage)) ==
pNewPage->GetName())
+&&
maTabControl->GetPageText(maTabControl->GetPageId(nSelectedPage)) ==
pNewPage->GetName()
+&& SfxLokHelper::getDeviceFormFactor() !=
LOKDeviceFormFactor::MOBILE)
{
// this slide is already visible
return true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 104448] [META] DOCX SAXParseException
https://bugs.documentfoundation.org/show_bug.cgi?id=104448 Bug 104448 depends on bug 136441, which changed state. Bug 136441 Summary: FILESAVE: Saxparse error on file open (word/footnotes.xml line 2) after save to DOCX & file reload https://bugs.documentfoundation.org/show_bug.cgi?id=136441 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136490] UI: No visual difference between page break indictor with page style set & page break without page style set
https://bugs.documentfoundation.org/show_bug.cgi?id=136490 Buovjaga changed: What|Removed |Added CC|ilmari.lauhakangas@libreoff | |ice.org | --- Comment #4 from Buovjaga --- (In reply to Telesto from comment #3) > @Buovjaga > Spam hijacking.. Is there way to mark the user as spammer? BTW, has the UX > mailing list a spam filter? It is possible to ban users and I did it for this spammer already -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92183] LOCALHELP: write help pages for document EVENTS (to bind to macros)
https://bugs.documentfoundation.org/show_bug.cgi?id=92183 --- Comment #8 from Alain Romedenne --- Comment on attachment 165184 --> https://bugs.documentfoundation.org/attachment.cgi?id=165184 A macro-enabled document to help establish - doc event - timelines or sequence diagrams requires libO 6.1 due to IiF() regression on recenter versions -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 136490] UI: No visual difference between page break indictor with page style set & page break without page style set
https://bugs.documentfoundation.org/show_bug.cgi?id=136490 Buovjaga changed: What|Removed |Added CC|ilmari.lauhakangas@libreoff | |ice.org | --- Comment #4 from Buovjaga --- (In reply to Telesto from comment #3) > @Buovjaga > Spam hijacking.. Is there way to mark the user as spammer? BTW, has the UX > mailing list a spam filter? It is possible to ban users and I did it for this spammer already -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 92183] LOCALHELP: write help pages for document EVENTS (to bind to macros)
https://bugs.documentfoundation.org/show_bug.cgi?id=92183 --- Comment #7 from Alain Romedenne --- Created attachment 165184 --> https://bugs.documentfoundation.org/attachment.cgi?id=165184=edit A macro-enabled document to help establish - doc event - timelines or sequence diagrams Happy Python ! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130823] LibreOffice CALC TBILLYIELD function returns incorrect interest rate (Too low).
https://bugs.documentfoundation.org/show_bug.cgi?id=130823 himajin100...@gmail.com changed: What|Removed |Added CC||er...@redhat.com --- Comment #9 from himajin100...@gmail.com --- https://opengrok.libreoffice.org/xref/core/scaddins/source/analysis/financial.cxx?r=3bf3face#381 (100 / 99.8775 - 99.8775 / 99.8775) * 360 / x = 0.014718 => x = (100 / 99.8775 - 99.8775 / 99.8775) * 360 / 0.014718 = 30 https://support.microsoft.com/en-us/office/tbillyield-function-6d381232-f4b0-4cd5-8e97-45b9c03468ba?ui=en-us=en-us=us (100-99.8775)/99.8775 * 360 / ( DATE(2020,3,24) - DATE(2020,2,25)) = 0.0157693174138322 February has only 28 or 29 days I'm not familiar with finance, and I don't know which result is expected. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 136490] UI: No visual difference between page break indictor with page style set & page break without page style set
https://bugs.documentfoundation.org/show_bug.cgi?id=136490 Telesto changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #3 from Telesto --- @Buovjaga Spam hijacking.. Is there way to mark the user as spammer? BTW, has the UX mailing list a spam filter? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 136490] UI: No visual difference between page break indictor with page style set & page break without page style set
https://bugs.documentfoundation.org/show_bug.cgi?id=136490 Telesto changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #3 from Telesto --- @Buovjaga Spam hijacking.. Is there way to mark the user as spammer? BTW, has the UX mailing list a spam filter? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: chart2/qa xmloff/source
chart2/qa/extras/chart2geometry.cxx | 100 +-
chart2/qa/extras/data/ods/tdf135366_data_label_series.ods |binary
chart2/qa/extras/data/odt/tdf135366_data_label_point.odt |binary
xmloff/source/chart/SchXMLPlotAreaContext.cxx | 62 +++
xmloff/source/chart/SchXMLPlotAreaContext.hxx | 16
xmloff/source/chart/SchXMLSeries2Context.cxx | 231 ++
xmloff/source/chart/SchXMLSeries2Context.hxx |3
xmloff/source/chart/transporttypes.hxx| 18 +
8 files changed, 350 insertions(+), 80 deletions(-)
New commits:
commit 87d1ebeb11a00301745ee3c3c03fffb7033ab59d
Author: Regina Henschel
AuthorDate: Sat Aug 22 23:03:02 2020 +0200
Commit: Regina Henschel
CommitDate: Sat Sep 5 17:49:15 2020 +0200
tdf#135366 ODF import of line and fill of data labels
LibreOffice has line and fill properties of data labels in a chart in
properties of kind "LabelBorderWidth" or "LabelFillColor" at a data
point or, as defaults for the points, at a series.
But ODF has such information in a element, which is
refered by a element. That one can be child of a
and child of a element.
Microsoft Office correctly uses the element and its
style for the line and fill properties of data labels. Up to now LO
cannot import such information and does not write the ODF elements.
Instead LibreOffice reads and writes attributes in 'loext' namespace.
Using the "LabelFoo" properties was implemented by Kohei Yoshida,
July 2014. Although there is no published service, these properties
can be used in macros. Because they are now available since six
years, the decision was to keep this internal model and convert on
import and export.
This patch implements the import of the ODF fill and line properties
from the element and converts them to the internal
used properties.
LibreOffice has currently only implemented a few of the possible line
and fill properties. When more are implemented, their
pairs need to be added to the array aApiToLabelFooPairs, further
adaptions are not needed.
The contains in addition the absolute position of
a data label. LibreOffice has internally only a position offset
relative to the regular position of the label. The conversion of the
position is not included in the patch.
Change-Id: I5fd868945585971dac3dd945804a4a2951b8c12d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101194
Tested-by: Jenkins
Reviewed-by: Regina Henschel
diff --git a/chart2/qa/extras/chart2geometry.cxx
b/chart2/qa/extras/chart2geometry.cxx
index 091dafe67265..b3f537c372e0 100644
--- a/chart2/qa/extras/chart2geometry.cxx
+++ b/chart2/qa/extras/chart2geometry.cxx
@@ -11,10 +11,14 @@
#include
+#include
+#include
#include
+#include
+#include
+#include
#include
#include
-#include
#include
@@ -46,6 +50,8 @@ public:
void testTdf128345ChartWall_CS_TG_import();
void testTdf128345Legend_CS_TG_axial_export();
void testTdf128345Legend_CS_TG_axial_import();
+void testTdf135366LabelOnSeries();
+void testTdf135366LabelOnPoint();
CPPUNIT_TEST_SUITE(Chart2GeometryTest);
CPPUNIT_TEST(testTdf135184RoundLineCap);
@@ -58,6 +64,8 @@ public:
CPPUNIT_TEST(testTdf128345ChartWall_CS_TG_import);
CPPUNIT_TEST(testTdf128345Legend_CS_TG_axial_export);
CPPUNIT_TEST(testTdf128345Legend_CS_TG_axial_import);
+CPPUNIT_TEST(testTdf135366LabelOnSeries);
+CPPUNIT_TEST(testTdf135366LabelOnPoint);
CPPUNIT_TEST_SUITE_END();
@@ -71,12 +79,12 @@ protected:
xmlDocUniquePtr parseExport(const OUString& rDir, const OUString&
rFilterFormat);
};
-// This is copied from Chart2ExportTest. It allows to access the chart form a
MS Office document
+namespace
+{
+// This is copied from Chart2ExportTest. It allows to access the chart from a
MS Office document
// without knowing whether the file is a chart1.xml or chart2.xml... As of
August 2020, Calc
// and Impress use a static variable for the number and therefore the number
depends on whether
// there had already been savings before.
-namespace
-{
struct CheckForChartName
{
private:
@@ -410,6 +418,90 @@ void
Chart2GeometryTest::testTdf128345Legend_CS_TG_axial_import()
assertXPath(pXmlDoc2, sStart + " and @draw:end='100%']");
}
+void Chart2GeometryTest::testTdf135366LabelOnSeries()
+{
+// Error was, that the fill and line properties of a
were not
+// imported at all. Here they should be at the series.
+load("/chart2/qa/extras/data/ods/", "tdf135366_data_label_series.ods");
+uno::Reference xChartDoc = getChartDocFromSheet(0,
mxComponent);
+CPPUNIT_ASSERT(xChartDoc.is());
+Reference xDataSeries =
getDataSeriesFromDoc(xChartDoc, 0);
+CPPUNIT_ASSERT(xDataSeries.is());
+Reference xPropSet(xDataSeries, UNO_QUERY_THROW);
+
[Libreoffice-bugs] [Bug 135366] implementation errors for border of data labels in charts
https://bugs.documentfoundation.org/show_bug.cgi?id=135366 Commit Notification changed: What|Removed |Added Whiteboard| QA:needsComment| QA:needsComment ||target:7.1.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135366] implementation errors for border of data labels in charts
https://bugs.documentfoundation.org/show_bug.cgi?id=135366 --- Comment #5 from Commit Notification --- Regina Henschel committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/87d1ebeb11a00301745ee3c3c03fffb7033ab59d tdf#135366 ODF import of line and fill of data labels It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92183] LOCALHELP: write help pages for document EVENTS (to bind to macros)
https://bugs.documentfoundation.org/show_bug.cgi?id=92183 --- Comment #6 from Alain Romedenne --- Created attachment 165183 --> https://bugs.documentfoundation.org/attachment.cgi?id=165183=edit embryo of events timeline event description is WiP -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92183] LOCALHELP: write help pages for document EVENTS (to bind to macros)
https://bugs.documentfoundation.org/show_bug.cgi?id=92183 Alain Romedenne changed: What|Removed |Added CC||alain.romedenne@libreoffice ||.org --- Comment #5 from Alain Romedenne --- I've managed to match event names with Tools-Customize-Events dialog Refer to https://wiki.documentfoundation.org/User:LibreOfficiant/Events#Events for description and source code references -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130823] LibreOffice CALC TBILLYIELD function returns incorrect interest rate (Too low).
https://bugs.documentfoundation.org/show_bug.cgi?id=130823 --- Comment #8 from edwa...@vivaldi.net --- Dear Sirs, I have provided ALL info necessary to reproduce this bug in the original submission. The function TBILLYIELD functions return incorrect interest rate. Using the following inputs: TBILLYIELD(Settlement; Maturity; Price) (02/25/20, 03/24/20, 99.8775) returns .014718 SHOULD RETURN .01577 as verified with MS EXCEL COMPARE THE RESULT OF CALC TBILLYIELD WITH THE MICROSOFT OFFICE EXCEL VERSION! SEE COMMENT BELOW THE RESULT .014718 IS INCORRECT! This should be a simple fix! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/wrtww8.cxx | 32 ++--
sw/source/filter/ww8/ww8par.cxx |4 ++--
sw/source/filter/ww8/ww8struc.hxx | 14 --
3 files changed, 16 insertions(+), 34 deletions(-)
New commits:
commit 23cf849bd699427889a99301d50ad52edec9d06d
Author: Stephan Bergmann
AuthorDate: Sat Sep 5 14:54:15 2020 +0200
Commit: Stephan Bergmann
CommitDate: Sat Sep 5 17:12:44 2020 +0200
Turn JapanNotBegin/EndLevel1 into constexpr string literals
...in preparation of further OUString improvements
Change-Id: I8e1aca3b91d2843e84755691f5f5461866c1e4e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102075
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/sw/source/filter/ww8/wrtww8.cxx b/sw/source/filter/ww8/wrtww8.cxx
index a0df3f50e248..85b87aa0cfab 100644
--- a/sw/source/filter/ww8/wrtww8.cxx
+++ b/sw/source/filter/ww8/wrtww8.cxx
@@ -550,34 +550,6 @@ static void WriteDop( WW8Export& rWrt )
rDop.Write( *rWrt.pTableStrm, *rWrt.pFib );
}
-const sal_Unicode *WW8DopTypography::GetJapanNotBeginLevel1()
-{
-static const sal_Unicode aJapanNotBeginLevel1[nMaxFollowing] =
-//Japanese Level 1
-{
-0x0021, 0x0025, 0x0029, 0x002c, 0x002e, 0x003a, 0x003b, 0x003f,
-0x005d, 0x007d, 0x00a2, 0x00b0, 0x2019, 0x201d, 0x2030, 0x2032,
-0x2033, 0x2103, 0x3001, 0x3002, 0x3005, 0x3009, 0x300b, 0x300d,
-0x300f, 0x3011, 0x3015, 0x309b, 0x309c, 0x309d, 0x309e, 0x30fb,
-0x30fd, 0x30fe, 0xff01, 0xff05, 0xff09, 0xff0c, 0xff0e, 0xff1a,
-0xff1b, 0xff1f, 0xff3d, 0xff5d, 0xff61, 0xff63, 0xff64, 0xff65,
-0xff9e, 0xff9f, 0xffe0
-};
-return [0];
-}
-
-const sal_Unicode *WW8DopTypography::GetJapanNotEndLevel1()
-{
-static const sal_Unicode aJapanNotEndLevel1[nMaxLeading] =
-//Japanese Level 1
-{
-0x0024, 0x0028, 0x005b, 0x005c, 0x007b, 0x00a3, 0x00a5, 0x2018,
-0x201c, 0x3008, 0x300a, 0x300c, 0x300e, 0x3010, 0x3014, 0xff04,
-0xff08, 0xff3b, 0xff5b, 0xff62, 0xffe1, 0xffe5
-};
-return [0];
-}
-
static int lcl_CmpBeginEndChars( const OUString& rSWStr,
const sal_Unicode* pMSStr, int nMSStrByteLen )
{
@@ -717,14 +689,14 @@ void WW8Export::ExportDopTypography(WW8DopTypography
)
!lcl_CmpBeginEndChars
(
pForbidden->endLine,
-WW8DopTypography::GetJapanNotEndLevel1(),
+WW8DopTypography::JapanNotEndLevel1,
WW8DopTypography::nMaxLeading *
sizeof(sal_Unicode)
)
&&
!lcl_CmpBeginEndChars
(
pForbidden->beginLine,
-WW8DopTypography::GetJapanNotBeginLevel1(),
+WW8DopTypography::JapanNotBeginLevel1,
WW8DopTypography::nMaxFollowing *
sizeof(sal_Unicode)
)
)
diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx
index c77b0eef7b13..457f0410ce95 100644
--- a/sw/source/filter/ww8/ww8par.cxx
+++ b/sw/source/filter/ww8/ww8par.cxx
@@ -1993,8 +1993,8 @@ void SwWW8ImplReader::ImportDopTypography(const
WW8DopTypography )
*/
if (!rTypo.m_reserved2)
{
-i18n::ForbiddenCharacters
aForbidden(WW8DopTypography::GetJapanNotBeginLevel1(),
-WW8DopTypography::GetJapanNotEndLevel1());
+i18n::ForbiddenCharacters
aForbidden(WW8DopTypography::JapanNotBeginLevel1,
+WW8DopTypography::JapanNotEndLevel1);
m_rDoc.getIDocumentSettingAccess().setForbiddenCharacters(LANGUAGE_JAPANESE,aForbidden);
}
diff --git a/sw/source/filter/ww8/ww8struc.hxx
b/sw/source/filter/ww8/ww8struc.hxx
index 8b040fc83693..f272437da648 100644
--- a/sw/source/filter/ww8/ww8struc.hxx
+++ b/sw/source/filter/ww8/ww8struc.hxx
@@ -394,8 +394,18 @@ public:
//full document, might not matter all that much though ?
enum RuleLengths {nMaxFollowing = 101, nMaxLeading = 51};
-static const sal_Unicode * GetJapanNotBeginLevel1();
-static const sal_Unicode * GetJapanNotEndLevel1();
+static constexpr sal_Unicode JapanNotBeginLevel1[]
+= u"\u0021\u0025\u0029\u002c\u002e\u003a\u003b\u003f"
+ "\u005d\u007d\u00a2\u00b0\u2019\u201d\u2030\u2032"
+ "\u2033\u2103\u3001\u3002\u3005\u3009\u300b\u300d"
+ "\u300f\u3011\u3015\u309b\u309c\u309d\u309e\u30fb"
+ "\u30fd\u30fe\uff01\uff05\uff09\uff0c\uff0e\uff1a"
+ "\uff1b\uff1f\uff3d\uff5d\uff61\uff63\uff64\uff65"
+ "\uff9e\uff9f\uffe0";
+static constexpr sal_Unicode JapanNotEndLevel1[]
+= u"\u0024\u0028\u005b\u005c\u007b\u00a3\u00a5\u2018"
+
[Libreoffice-bugs] [Bug 136499] New: The startup of LibreOffice causes different connections to my Google Drive
https://bugs.documentfoundation.org/show_bug.cgi?id=136499 Bug ID: 136499 Summary: The startup of LibreOffice causes different connections to my Google Drive Product: LibreOffice Version: 7.0.0.3 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jj.wolth...@upcmail.nl Description: If I start LibreOffice it cause 4 times a Google Drive connection on my Desktop Steps to Reproduce: 1.Start LibreOffice 2.My Linux Mint 20 produce 4 times a connection to my Google Drive during startup of LibreOffice 3. Actual Results: Nothing Expected Results: Do not open connections to my Google Drive account Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: nl Module: StartModule [Information guessed from browser] OS: Linux (All) OS is 64bit: yes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134288] FILEOPEN PPTX: text box renders vertically instead of horizontally
https://bugs.documentfoundation.org/show_bug.cgi?id=134288 Gerald Pfeifer changed: What|Removed |Added CC||noelgran...@gmail.com --- Comment #7 from Gerald Pfeifer --- (In reply to Xisco Faulí from comment #6) > Current behaviour is reproducible since > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=d0119ff7f2c68aa05286bd303128f3a69c6bbd6a. > Before that, nothing was displayed on the slide Noel, that is a contribution of yours, that improved the situation already by showing the text (when it wasn't shown before). Maybe this one is interesting? "Just" the orientation is off now for this zero size textbox... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136498] New: In PDF options "%PRODUCTNAME" is displayed in tooltip
https://bugs.documentfoundation.org/show_bug.cgi?id=136498 Bug ID: 136498 Summary: In PDF options "%PRODUCTNAME" is displayed in tooltip Product: LibreOffice Version: 6.4.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: trivial Priority: medium Component: Printing and PDF export Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: officialm...@gmail.com Created attachment 165182 --> https://bugs.documentfoundation.org/attachment.cgi?id=165182=edit "%PRODUCTNAME" in a tootip in LibreOffice v6.4.5.2 Prompted by the according - https://wiki.documentfoundation.org/Faq/Writer/PDF_Hybrid - startup tip, in File → Export As → Export as PDF → General → Hybrid PDF, the tooltip to "Hybrid PDF (embed ODF file)" reads "Creates a PDF that is easily editable in %PRODUCTNAME" This is the only instance as far as I found. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/ooxmlexport/data/tdf136441_commentInFootnote.odt |binary
sw/qa/extras/ooxmlexport/ooxmlexport15.cxx|6 ++
sw/source/filter/ww8/wrtw8nds.cxx |4 +++-
3 files changed, 9 insertions(+), 1 deletion(-)
New commits:
commit 870bb98b3a1159e31895524ef54457db37d1b9af
Author: Justin Luth
AuthorDate: Sat Sep 5 13:38:04 2020 +0300
Commit: Justin Luth
CommitDate: Sat Sep 5 16:39:48 2020 +0200
tdf#136441 ms export: don't export comments in footnotes
Microsoft UI does not allow comments in footnotes,
or in headers/footers, or endnotes,
so just throw them away for all MS formats.
This avoids the biggest problem,
which was an error in LO reading the DOCX.
Prior to this bug fix, the status was:
DOCX:
Word 2016 opens it ok, but no comment in footnote.
Word 2003 hangs.
LO loads but has a SAX error the user must ignore,
and no comment seen in the footnote anyway.
DOC:
Word 2016 opens, but misses the main body text,
and of course no comment in footnote.
Word 2003 opens, sees the main body text just fine,
and no comment in footnote.
LO loads, but no comment seen in footnote anyway.
RTF:
Word 2016/2003 open, and no comment in footnote.
LO loads, but no comment seen in footnote anyway.
If the SAX error problem could be fixed, then perhaps
it would be worth allowing LO to export comments
to DOCX for its own benefit. In that case, allow
case SwFieldIds::Postit:
PostitField( pField );
This patch does not fix the problem where the body
text is missing in Word 2016 in DOC format.
Change-Id: I0b7389616a2207d41ae525dbc0b2eea536364d90
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102074
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/sw/qa/extras/ooxmlexport/data/tdf136441_commentInFootnote.odt
b/sw/qa/extras/ooxmlexport/data/tdf136441_commentInFootnote.odt
new file mode 100644
index ..61c9632b3972
Binary files /dev/null and
b/sw/qa/extras/ooxmlexport/data/tdf136441_commentInFootnote.odt differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport15.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport15.cxx
index 8d6e8228f8ba..4e39a5af0297 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport15.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport15.cxx
@@ -478,6 +478,12 @@ DECLARE_OOXMLEXPORT_TEST(testTdf135329_lostImage,
"tdf135329_lostImage.odt")
uno::Reference xImageProps(getShape(2),
uno::UNO_QUERY_THROW);
}
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf136441_commentInFootnote,
"tdf136441_commentInFootnote.odt")
+{
+// failed to load without error if footnote contained a comment.
+// (MS Word's UI doesn't allow adding comments to a footnote.)
+}
+
DECLARE_OOXMLEXPORT_TEST(testTdf134063, "tdf134063.docx")
{
CPPUNIT_ASSERT_EQUAL(2, getPages());
diff --git a/sw/source/filter/ww8/wrtw8nds.cxx
b/sw/source/filter/ww8/wrtw8nds.cxx
index a1f8965b686e..11f8b88059c5 100644
--- a/sw/source/filter/ww8/wrtw8nds.cxx
+++ b/sw/source/filter/ww8/wrtw8nds.cxx
@@ -2374,7 +2374,9 @@ void MSWordExportBase::OutputTextNode( SwTextNode& rNode )
// Append bookmarks in this range after flys, exclusive of final
// position of this range
AppendBookmarks( rNode, nCurrentPos, nNextAttr - nCurrentPos );
-AppendAnnotationMarks(aAttrIter, nCurrentPos, nNextAttr -
nCurrentPos);
+//Sadly only possible for word in main document text
+if ( m_nTextTyp == TXT_MAINTEXT )
+AppendAnnotationMarks(aAttrIter, nCurrentPos, nNextAttr -
nCurrentPos);
// At the moment smarttags are only written for paragraphs, at the
// beginning of the paragraph.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 136497] When entering "Name Box" via keyboard shortcut, existing text is not selected anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=136497 yallabala...@gmail.com changed: What|Removed |Added Summary|When entering "Name Box" vi |When entering "Name Box" |keyboard shortcut, existing |via keyboard shortcut, |text is not selected|existing text is not |anymore |selected anymore -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136497] New: When entering "Name Box" vi keyboard shortcut, existing text is not selected anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=136497
Bug ID: 136497
Summary: When entering "Name Box" vi keyboard shortcut,
existing text is not selected anymore
Product: LibreOffice
Version: 7.0.0.3 release
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: Calc
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: yallabala...@gmail.com
Description:
This bug is new in version 7; version 6.x worked correctly.
When clicking the Name Box with the mouse, all existing text is selected.
However, when navigating via keyboard (e.g. Ctrl+shift+F5, or Ctrl+Shift+T),
the existing text is not pre-selected.
Why this is a bug:
1. it worked differently in previous versions.
2. it's not consistent with mouse click
3. it disrupts and counterproductive: There's never a need to editing an
existing name; using this box only makes sense when entering a new name, or
navigating to a new range address.
Steps to Reproduce:
from a calc worksheet, press Ctrl+Shift+F5 or Ctrl+Shift+T
p.s.
If there's no assigned keyboard shortcut, then assign a key-combo with: "All
Commasnds > Sheet Area Input Field" (it's an inconsistent name for "name box",
there's an open bug for this, too)
Actual Results:
text is not selected.
cursor goes to the first position of the text.
Expected Results:
range name text is selected ("highlighted"), same as with clicking the mouse on
the Name Box.
Reproducible: Always
User Profile Reset: Yes
Additional Info:
Version: 7.0.0.3
Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: kf5
Locale: en-US (en_IL); UI: en-US
Calc: threaded
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136482] new LO document is write-protected
https://bugs.documentfoundation.org/show_bug.cgi?id=136482 --- Comment #5 from milly texas --- Everything that irritates us about others can lead us to an understanding of ourselves. Carl Jung Any fool can criticize, condemn, and complain but it takes character and self control to be understanding and forgiving. Dale Carnegie Never do today what you can put off till tomorrow. Delay may give clearer light as to what is best to be done. Aaron Burr All truths are easy to understand once they are discovered; the point is to discover them. Galileo Galilei You don't need strength to let go of something. What you really need is understanding. Guy Finley Everyone hears only what he understands. Johann Wolfgang von Goethe To understand the heart and mind of a person, look not at what he has already achieved, but at what he aspires to. Kahlil Gibran Nothing in life is to be feared. It is only to be understood. Marie Curie Don't believe what your eyes are telling you. All they show is limitation. Look with your understanding, find out what you already know, and you'll see the way to fly. https://quotesjin.com/ You do not understand even life. How can you understand death? Confucius Furious activity is no substitute for understanding. H.H Williams If we are to live together in peace, we must come to know each other better. Lyndon Johnson A matter that becomes clear ceases to concern us. Friedrich Nietzsche The reality of the other person is not in what he reveals to you, but in what he cannot reveal to you. Therefore, if you would understand him, listen not to what he says but rather what he does not say. Kahlil Gibran -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
