[Libreoffice-bugs] [Bug 136637] Firebird: Entering the sql command will cause Libreoffice to hang

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136637

--- Comment #5 from s...@imail.ru ---
Please note that my LO fell exactly with the CHARACTER SET option.
Is firebird still relevant? I see that when creating a new database, Firebird
is missing from the selection list. This is if advanced mode is not enabled. in
6.3, it was in normal mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117643] Word search does not work in LibreOffice Writer if search term contains an apostrophe

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117643

--- Comment #9 from JustinJacob  ---
You have shared the details of a commonly seen problem. But most of the people
don't know this. https://mycbdfaq.com  But through this post, everyone will
understand that a word search does not work in LibreOffice Writer if the search
term contains an apostrophe.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

About removing long time deprecated types from public API

[julien2412]

Hello,

I submitted https://gerrit.libreoffice.org/c/core/+/102436 "Remove unused
and deprecated sal_sChar" because it's not used in LO and has been
deprecated since 2013, see:
author  Stephan Bergmann   2013-11-27 12:50:35 +0100
committer   Stephan Bergmann   2013-11-27 12:52:32 
+0100
commit  d8565bd266939b4ae4231f5b2c7d6260bee404e9 (patch)
treec4dc8575d838bf7f588ebb5102acc62cf7651336
parent  b5fced896632a3c07586702b461545667b33966e (diff)
Mark sal_Char, sal_sChar, sal_uChar as deprecated
...there never was a good reason to have SAL abstractions for the C/C++ char
types anyway.

So almost 7 years these types have been deprecated. Must we wait for more
years to remove them or may we go ahead?
If not what's the use of deprecation except incitating people to use C/C++
char types (at least for people who monitor deprecation warnings)?

Of course, to remove these types won't fix any bug or optimize anything but
the goal is just some decruftify/cleaning.

Julien



--
Sent from: 
http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 45705] New UNO commands for "Zoom in" and "Zoom out" of document canvas, to support keyboard zoom (comment 21)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45705

Buovjaga  changed:

   What|Removed |Added

 CC||t...@funk.co.nz

--- Comment #33 from Buovjaga  ---
*** Bug 136669 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136669] Zoom In/Zoom Out keyboard shortcuts (a dupe I know, but wanted to share my extended writeup)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136669

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE
 CC||ilmari.lauhakangas@libreoff
   ||ice.org

--- Comment #3 from Buovjaga  ---


*** This bug has been marked as a duplicate of bug 45705 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/oox oox/source sw/qa sw/source

[Attila Bakos (via logerrit)]

 include/oox/export/vmlexport.hxx |1 
 oox/source/export/vmlexport.cxx  |   78 +++
 sw/qa/extras/ooxmlexport/data/tdf135667.odt  |binary
 sw/qa/extras/ooxmlexport/ooxmlexport15.cxx   |   17 +
 sw/source/filter/ww8/docxattributeoutput.cxx |  291 ---
 sw/source/filter/ww8/docxattributeoutput.hxx |4 
 6 files changed, 288 insertions(+), 103 deletions(-)

New commits:
commit 65bc6e12ef8a681ec4597635d0b3d86e9ac355d3
Author: Attila Bakos 
AuthorDate: Fri Sep 4 11:48:16 2020 +0200
Commit: László Németh 
CommitDate: Fri Sep 11 17:27:24 2020 +0200

tdf#135667 DOCX export: fix border line of OLE objects

which wasn't exported.

Note: the enlarged monolithic export function was
split in the following new functions:

- WriteOLEShape() exports the replacement shape of
the OLE object.

- GetOLEStyle() returns the string value of the
style attribute.

- ExportOLESurround() handles the surround settings.

Also add GetVMLShapeTypeDefinition() to reuse picture
frame VML formula string used by VMLExport.

Co-authored-by: Arató Dániel (NISZ)

Change-Id: I29800a50c60a824a14849ac286a18e5e2f97c689
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102034
Tested-by: László Németh 
Reviewed-by: László Németh 

diff --git a/include/oox/export/vmlexport.hxx b/include/oox/export/vmlexport.hxx
index 06dbbc57a21c..94aeb8601f1a 100644
--- a/include/oox/export/vmlexport.hxx
+++ b/include/oox/export/vmlexport.hxx
@@ -145,6 +145,7 @@ public:
 voidSetHashMarkForType(bool bUseHashMarkForType) { 
m_bUseHashMarkForType = bUseHashMarkForType; }
 voidOverrideShapeIDGen(bool bOverrideShapeIdGeneration,
 const OString& sShapeIDPrefix = OString());
+static OString GetVMLShapeTypeDefinition(const OString& sShapeID, const 
bool bIsPictureFrame);
 
 protected:
 /// Add an attribute to the generated  element.
diff --git a/oox/source/export/vmlexport.cxx b/oox/source/export/vmlexport.cxx
index 0a0a634708bf..dea03c552cee 100644
--- a/oox/source/export/vmlexport.cxx
+++ b/oox/source/export/vmlexport.cxx
@@ -1219,6 +1219,46 @@ sal_uInt32 VMLExport::GenerateShapeId()
 return m_nShapeIDCounter++;
 }
 
+OString VMLExport::GetVMLShapeTypeDefinition( const OString& sShapeID, const 
bool bIsPictureFrame )
+{
+OString sShapeType;
+if ( !bIsPictureFrame )
+// We don't have a shape definition for host control in 
presetShapeDefinitions.xml
+// So use a definition copied from DOCX file created with MSO
+sShapeType = "\n"
+"\n"
+"\n"
+"\n"
+"";
+else
+// We don't have a shape definition for picture frame in 
presetShapeDefinitions.xml
+// So use a definition copied from DOCX file created with MSO
+sShapeType = "\n"
+"\n"
+"\n"
+"\n"
+"\n"
+"\n"
+"\n"
+"\n"
+"\n"
+"\n"
+"\n"
+"\n"
+"\n"
+"\n"
+"\n"
+"\n"
+"\n"
+"\n"
+"";
+return sShapeType;
+}
+
 sal_Int32 VMLExport::StartShape()
 {
 if ( m_nShapeType == ESCHER_ShpInst_Nil )
@@ -1237,56 +1277,22 @@ sal_Int32 VMLExport::StartShape()
 case ESCHER_ShpInst_Line:   nShapeElement = XML_line;  
break;
 case ESCHER_ShpInst_HostControl:
 {
-// We don't have a shape definition for host control in 
presetShapeDefinitions.xml
-// So use a definition copied from DOCX file created with MSO
 bReferToShapeType = true;
 nShapeElement = XML_shape;
 if ( !m_aShapeTypeWritten[ m_nShapeType ] )
 {
-OString sShapeType =
-"\n"
-"\n"
-"\n"
-"\n"
-"";
-m_pSerializer->write(sShapeType);
+
m_pSerializer->write(GetVMLShapeTypeDefinition(OString::number(m_nShapeType), 
false));
 m_aShapeTypeWritten[ m_nShapeType ] = true;
 }
 break;
 }
 case ESCHER_ShpInst_PictureFrame:
 {
-// We don't have a shape definition for picture frame in 
presetShapeDefinitions.xml
-// So use a definition copied from DOCX file created with MSO
 bReferToShapeType = true;
 nShapeElement = XML_shape;
 if ( !m_aShapeTypeWritten[ 

[Libreoffice-bugs] [Bug 136670] New: EDITING: removing rows/columns via keyboard ctrl + minus works only once

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136670

Bug ID: 136670
   Summary: EDITING: removing rows/columns via keyboard ctrl +
minus works only once
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: oliver.brinz...@gmx.de

The second time the "cells removal" dialog is displayed, cause the row/column
selection has gone. This is different from inserting rows/colums via ctrl+plus.
Btw: It works with Excel.

steps to reproduce
- open new spreadsheet
- select a row, e.g. 5
- press ctrl + minus to delete row 5
- press ctrl + minus to delete next row - dialog is displayed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86899] [META] Requests for the addition of UNO commands

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86899

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||45705


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=45705
[Bug 45705] New UNO commands for "Zoom in" and "Zoom out" of document canvas,
to support keyboard zoom  (comment 21)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45705] New UNO commands for "Zoom in" and "Zoom out" of document canvas, to support keyboard zoom (comment 21)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45705

V Stuart Foote  changed:

   What|Removed |Added

Summary|Cant assign shortcuts to|New UNO commands for "Zoom
   |"Zoom in" and "Zoom out"|in" and "Zoom out" of
   |commands|document canvas, to support
   ||keyboard zoom  (comment 21)
 Blocks||86899


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=86899
[Bug 86899] [META] Requests for the addition of UNO commands
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45705] Cant assign shortcuts to "Zoom in" and "Zoom out" commands

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45705

V Stuart Foote  changed:

   What|Removed |Added

 CC||ber...@codewiz.org

--- Comment #32 from V Stuart Foote  ---
*** Bug 122414 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122414] Standard keybindings to increase/decrease zoom level

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122414

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #2 from V Stuart Foote  ---
bug 82679 was wrong BZ issue to dupe, adjusting

*** This bug has been marked as a duplicate of bug 45705 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136669] Zoom In/Zoom Out keyboard shortcuts (a dupe I know, but wanted to share my extended writeup)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136669

Tom Atkinson  changed:

   What|Removed |Added

URL||https://tomachi.co/review-l
   ||ibre-office-zoom-in-out-bug
   ||/

--- Comment #2 from Tom Atkinson  ---
Sorry to be a troll, but I reckon this one is a major bug. Especially
considering the new user experience in Calc (see screenshot).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: About removing long time deprecated types from public API

[Stephan Bergmann]

On 11/09/2020 17:03, julien2412 wrote:

Does it sound ok for you or do you want I merge/split some of the commits?


sounds ok at least to me

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 136669] Zoom In/Zoom Out keyboard shortcuts (a dupe I know, but wanted to share my extended writeup)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136669

Tom Atkinson  changed:

   What|Removed |Added

 CC||t...@funk.co.nz

--- Comment #1 from Tom Atkinson  ---
Created attachment 165395
  --> https://bugs.documentfoundation.org/attachment.cgi?id=165395=edit
this shows the worst case scenario damage that can happen from this bug. UNDO
obviously fixes this mind.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136669] New: Zoom In/Zoom Out keyboard shortcuts (a dupe I know, but wanted to share my extended writeup)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136669

Bug ID: 136669
   Summary: Zoom In/Zoom Out keyboard shortcuts (a dupe I know,
but wanted to share my extended writeup)
   Product: LibreOffice
   Version: 6.3.6.2 release
  Hardware: All
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: graphics stack
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: t...@funk.co.nz

Description:
DUPE is located at: https://bugs.documentfoundation.org/show_bug.cgi?id=45705 

Thanks for making such a fantastic product by the way.

I've written a really extended version of this report at
https://tomachi.co/review-libre-office-zoom-in-out-bug/ and to save you the
drama of reading it all in here I will just post the very short, action
summary, and steps to reproduce. Checkout the blog though for the epic study of
this 8 yerar old bug!

Steps to reproduce
On macOS 10.14.6 I'm running LibreOffice version 6.3.6.2 last modified 23rd
April 2020. This open bug appears first in 2012 and is still open.

open either Writer, Spreadsheet etc but not Draw
try to Zoom In/Zoom Out without touching your mouse. Only Draw works, but it
uses the wrong native macOS combo.
Jarring First Time User Experience

if i can only submit one image with this bud report this is it

Someone new to Libre Office Spreadsheet program would find it pretty
in-your-face jarring to get this result, as I just did:

[screenshot] shows a Zoomed up capture of Spreadsheets. cells 2, 3, and 4 have
been blown away when I try all the usual suspects:

[command][=], [command][=],[control][=], [control][=]  one of the combos I
mashed it actually causes the "Insert Cells" modal dialog to appear. Luckily I
am big and tough and don't mind reading the manual, but in this instance I
realised it was going to be more complex. I figured if I wait a few years.
well it's 8 years later and I'm still waiting.  Hence this extreme review / bug
report.

Hands Free Zoom
I wish to be be able to literally turf my mouse into the next room, and still
be able to zoom in / zoom out the display using only keyboard shortcuts. This
likely affects macOS version as last time I checked Control-+ was working fine
to zoom in on my Linuxbox. The terms "zoom in" and "zoom out" do appear in the
app at various places, and it is these two actions that I would like keyboard
shortcuts for.

Relabel (or delete) Zoom In -->  Print Preview Zoom In
Relabel (or delete) Zoom Out  --> Print Preview Zoom Out
Introduce new Zoom In / Zoom Out action feature
Create macOS friendly keyboard shortcuts showing in view menu of Command+/-
Default to 'Show Shortcuts in Menus' set in Preferences... View
...
extended report at report at
https://tomachi.co/review-libre-office-zoom-in-out-bug/


Steps to Reproduce:
1. Open any app, Writer, Calc especially, Draw
2. Through your mouse away
3. Try to zoom in / zoom out. See? not so easy.

Actual Results:
This can cause a fairly damaging over-write to cells in Calc. See the
screenshot. 

Expected Results:
Display is zoomed-in or zoomed out.


Reproducible: Always


User Profile Reset: No



Additional Info:
Please see my extended write up and the original bug from 2012 below:
https://tomachi.co/review-libre-office-zoom-in-out-bug/
https://bugs.documentfoundation.org/show_bug.cgi?id=45705

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136657] FILEOPEN DOCX: Text frames not rendered correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136657

Henrik  changed:

   What|Removed |Added

Summary|FILEOPEN DOCX: Graphics not |FILEOPEN DOCX: Text frames
   |rendered correctly  |not rendered correctly

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136657] FILEOPEN DOCX: Graphics not rendered correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136657

Henrik  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #5 from Henrik  ---
Thanks for taking a look at it, Aron!
You're completely right. They are not graphics but text frames with text in
them.
I did indeed not have the Bookman Old Style font installed when I submitted the
report, but having installed the font and tried again the problem persists. 

I've therefore changed the title of the bug.

The problem is that the text frames are not correctly rendered.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136668] Fileopen generated DOCX: Blank page between regular pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136668

Timur  changed:

   What|Removed |Added

Summary|Fileopen DOCX: Blank page   |Fileopen generated DOCX:
   |between regular pages   |Blank page between regular
   ||pages

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136668] Fileopen DOCX: Blank page between regular pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136668

--- Comment #2 from Timur  ---
Created attachment 165394
  --> https://bugs.documentfoundation.org/attachment.cgi?id=165394=edit
Document compared

Repro LO 7.1+. It was worse in OO.
This is older compatibility DOCX, but similar problem if resaved in MSO. 
This is a bug, but needs to be checked if a duplicate of some other report.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136668] Fileopen DOCX: Blank page between regular pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136668

Timur  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
Summary|Blank page between regular  |Fileopen DOCX: Blank page
   |pages   |between regular pages
   Keywords||filter:docx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107733] [META] Hyperlink bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107733
Bug 107733 depends on bug 78509, which changed state.

Bug 78509 Summary: FILEOPEN: MSO ODT - Hyperlink character style incorrectly 
loaded into one style when actually using another
https://bugs.documentfoundation.org/show_bug.cgi?id=78509

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94587] [META] ODF features missing or incorrectly imported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94587
Bug 94587 depends on bug 78509, which changed state.

Bug 78509 Summary: FILEOPEN: MSO ODT - Hyperlink character style incorrectly 
loaded into one style when actually using another
https://bugs.documentfoundation.org/show_bug.cgi?id=78509

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108014] [META] Writer character style bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108014
Bug 108014 depends on bug 78509, which changed state.

Bug 78509 Summary: FILEOPEN: MSO ODT - Hyperlink character style incorrectly 
loaded into one style when actually using another
https://bugs.documentfoundation.org/show_bug.cgi?id=78509

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78509] FILEOPEN: MSO ODT - Hyperlink character style incorrectly loaded into one style when actually using another

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78509

Regina Henschel  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #12 from Regina Henschel  ---
Works for me in Version: 7.0.0.2 (x64)
Build ID: c01aa64b6c3d89ebe5fe69c28c7adb24eb85249c
CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL

The hyperlinks texts have T205 and T207 as automatic styles, which have
"DefaultParagraphFont" as parent custom style. And that style is shown in the
Stylist.
The links are rendered in #FF, so there in neither a problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45705] Cant assign shortcuts to "Zoom in" and "Zoom out" commands

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45705

--- Comment #31 from Tom Atkinson  ---
@Mike I agree, in fact I have written up an extended article / review that
focuses *purely* on the Zoom In / Zoom Out bug, and even has a screenshot of a
real bad outcome: a bunch of cells overwritten, and the "Insert Cells" dialog
appearing surprisingly.

Please see:
https://tomachi.co/review-libre-office-zoom-in-out-bug/

I breifly thought it was getting addrsesed also, because I was poking about
this bug report a lot while writing this blog. Fingers crossed yours and now my
comment this one will be the stimulation required. I'm going to also post a
fresh new bug (I know theres lot of dupes already but heck, I already wrote it
up in the post above so it's no biggy. If I had a faster more powerful computer
I'd look into setting up my build env for some potentially contributions open
source stylee. But for now I prey to the gods of open-source!

PS perhaps a 'bug bounty' on stack exchange should be considered? to raise
funds for the friendly programmer or team that finally fixes this one?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: About removing long time deprecated types from public API

[Stephan Bergmann]

On 11/09/2020 13:42, julien2412 wrote:

I submitted https://gerrit.libreoffice.org/c/core/+/102436 "Remove unused
and deprecated sal_sChar" because it's not used in LO and has been
deprecated since 2013, see:
author  Stephan Bergmann 2013-11-27 12:50:35 +0100
committer   Stephan Bergmann 2013-11-27 12:52:32 
+0100
commit  d8565bd266939b4ae4231f5b2c7d6260bee404e9 (patch)
treec4dc8575d838bf7f588ebb5102acc62cf7651336
parent  b5fced896632a3c07586702b461545667b33966e (diff)
Mark sal_Char, sal_sChar, sal_uChar as deprecated
...there never was a good reason to have SAL abstractions for the C/C++ char
types anyway.

So almost 7 years these types have been deprecated. Must we wait for more
years to remove them or may we go ahead?
If not what's the use of deprecation except incitating people to use C/C++
char types (at least for people who monitor deprecation warnings)?

Of course, to remove these types won't fix any bug or optimize anything but
the goal is just some decruftify/cleaning.


So if you see a benefit in doing this particular change:  I'd say, mark 
the change as "[API CHANGE]" in the commit message, get it in, and 
document the backwards incompatible change at 
.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 135565] Fonts preview and libreoffice cover illegible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135565

--- Comment #9 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4fa53470339d8813cc40e32d2ac60483a10cf2df

tdf#135565 prepare font preview virtual device

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135565] Fonts preview and libreoffice cover illegible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135565

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/inc

[Caolán McNamara (via logerrit)]

 vcl/inc/salvtables.hxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 4fa53470339d8813cc40e32d2ac60483a10cf2df
Author: Caolán McNamara 
AuthorDate: Thu Sep 10 21:13:42 2020 +0200
Commit: Caolán McNamara 
CommitDate: Fri Sep 11 15:56:42 2020 +0200

tdf#135565 prepare font preview virtual device

make SalInstanceComboBox::create_render_virtual_device do more
setup to have an appropiate default background.

Change-Id: I43aeb6ffe85d21f11f3ebb1f981c0db67247e5db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102403
Reviewed-by: Jan-Marek Glogowski 
Tested-by: Jenkins

diff --git a/vcl/inc/salvtables.hxx b/vcl/inc/salvtables.hxx
index ac856598768e..0bac5447b608 100644
--- a/vcl/inc/salvtables.hxx
+++ b/vcl/inc/salvtables.hxx
@@ -829,7 +829,9 @@ public:
 
 VclPtr create_render_virtual_device() const override
 {
-return VclPtr::Create();
+auto xRet = VclPtr::Create();
+
xRet->SetBackground(Application::GetSettings().GetStyleSettings().GetFieldColor());
+return xRet;
 }
 
 virtual void set_item_menu(const OString& rIdent, weld::Menu* pMenu) 
override
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 133630] CRASH: Chart: Changing properties in different objects

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=133630

--- Comment #18 from Michael Meeks  ---
Patch looks plausible. I would SAL_WARN with a sensible domain if the object
type is wrong.

Otherwise the 'return 'looks fine when it's not an axis. I would avoid the
redundant extra braces - that module has a consistent
no-extra-brace-for-one-line statements style.

Lets get it in =) thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: oox/source sw/qa

[Regényi Balázs (via logerrit)]

 oox/source/export/drawingml.cxx  |   19 ++-
 sw/qa/extras/ooxmlexport/data/tdf77236_MissingSolidFill.docx |binary
 sw/qa/extras/ooxmlexport/ooxmlexport10.cxx   |9 +
 sw/qa/extras/ooxmlexport/ooxmlexport6.cxx|2 -
 4 files changed, 21 insertions(+), 9 deletions(-)

New commits:
commit 83c30743eaf44d8eded4a73e3ac2585b5bdbaffc
Author: Regényi Balázs 
AuthorDate: Mon Sep 7 19:54:19 2020 +0200
Commit: László Németh 
CommitDate: Fri Sep 11 15:36:15 2020 +0200

tdf#77236 DOCX shape export: fix missing solidFill

(resulting for example, invisible shapes).

Co-authored-by: Szabolcs Tóth

Change-Id: I328514022f4a594c374d5a97db39d1cf3a954e02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102195
Tested-by: László Németh 
Reviewed-by: László Németh 

diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index 06bbfea85d61..605e85ffa087 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -926,14 +926,17 @@ void DrawingML::WriteOutline( const 
Reference& rXPropSet, Referenc
 // the line had a scheme color and the user didn't change it
 WriteSolidFill( sColorFillScheme, aTransformations );
 }
-else if( aStyleProperties.hasElements() )
-{
-if( nColor != nStyleColor )
-// the line style defines some color but it wasn't being used
-WriteSolidFill( nColor );
-// in case the shape used the style color and the user didn't 
change it,
-// we must not write a  tag.
-}
+// tdf#77236: I do not understand why this condition is required.
+// The original docx document of bug tdf#77236 includes the native 
colors in both places,
+// so, I think, we can export this color too (not only schema ones).
+//else if( aStyleProperties.hasElements() )
+//{
+//if( nColor != nStyleColor )
+//// the line style defines some color but it wasn't being used
+//WriteSolidFill( nColor );
+//// in case the shape used the style color and the user didn't 
change it,
+//// we must not write a  tag.
+//}
 else
 {
 WriteSolidFill( nColor, nColorAlpha );
diff --git a/sw/qa/extras/ooxmlexport/data/tdf77236_MissingSolidFill.docx 
b/sw/qa/extras/ooxmlexport/data/tdf77236_MissingSolidFill.docx
new file mode 100644
index ..2bb2c097838d
Binary files /dev/null and 
b/sw/qa/extras/ooxmlexport/data/tdf77236_MissingSolidFill.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx
index da998b01bb5f..4f77681d2eaf 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx
@@ -1338,6 +1338,15 @@ DECLARE_OOXMLEXPORT_TEST( testTdf107359, 
"tdf107359-char-pitch.docx" )
 CPPUNIT_ASSERT_EQUAL( sal_Int32(convertTwipToMm100(24 * 20)), nBaseWidth );
 }
 
+DECLARE_OOXMLEXPORT_TEST(testTdf77236_MissingSolidFill, 
"tdf77236_MissingSolidFill.docx")
+{
+// tdf#77236: solidFill of VML shape was not exported if the colors of 
line and style were the same
+xmlDocUniquePtr pXmlDoc = parseExport("word/document.xml");
+if (!pXmlDoc)
+return;
+assertXPath(pXmlDoc, 
"//mc:Choice/w:drawing/wp:inline/a:graphic/a:graphicData/wps:wsp/wps:spPr/a:ln/a:solidFill",
 1);
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
index d1091c949bb6..eafdf88ea788 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
@@ -783,7 +783,7 @@ 
DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testShapeThemePreservation, "shape-theme-pre
 0);
 assertXPath(pXmlDocument,
 
"/w:document/w:body/w:p[1]/w:r/mc:AlternateContent/mc:Choice/w:drawing/wp:anchor/a:graphic/a:graphicData/wps:wsp/wps:spPr/a:ln/a:solidFill",
-0);
+1);
 
 // check direct theme assignments have been preserved
 assertXPath(pXmlDocument,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Bringing line and fill style of data labels to ODF

[Regina Henschel]

Hi NISZ LibreOffice Team, hi all,

I have started to bring the line and fill properties of data labels to 
ODF. Currently they are implemented in loext-Attributes in the styles of 
 and . But ODF needs  
elements and have them as ordinary line and fill attribute in the data 
label styles.


My current state of work is in 
https://gerrit.libreoffice.org/c/core/+/102381.


Because you are heavily working on chart import/export, it might be 
useful, if you have a look, whether what I plan to do is in conflict 
with that, what you plan to do.


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 123973] Master objects in a LO Draw document export with TIFF but not PNG or GIF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123973

--- Comment #8 from mwtjunkm...@gmail.com ---
Still an issue in:

Version: 7.1.0.0.alpha0+ (x64)
Build ID: ed4f610f4a3de12016f8308a17b6ad4f86e9d67a
CPU threads: 8; OS: Windows 10.0 Build 20211; UI render: default; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

And if all objects are only on the master, nowhere else, not only will PNG not
export them, but you get a "filter not found" message as if you're exporting
nothing (I can log that separately).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/source

[Caolán McNamara (via logerrit)]

 vcl/source/treelist/treelistbox.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 099bd18dea7efadbe25a8519d98d24cb69c35b95
Author: Caolán McNamara 
AuthorDate: Fri Sep 11 12:19:18 2020 +0100
Commit: Caolán McNamara 
CommitDate: Fri Sep 11 15:19:56 2020 +0200

drop misleading GetWindowTextColor use

We use a font from StyleSettings::GetFieldFont(),
but use a font color from StyleSettings::GetWindowTextColor()
and then immediately afterwards use
SetTextColor(StyleSettings::GetFieldTextColor());

Change-Id: I60f653947242a4e2d5fe48bd1d0df7a3ab693685
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102461
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/treelist/treelistbox.cxx 
b/vcl/source/treelist/treelistbox.cxx
index b59a4b0a9131..7ee2a50b33a7 100644
--- a/vcl/source/treelist/treelistbox.cxx
+++ b/vcl/source/treelist/treelistbox.cxx
@@ -3390,7 +3390,6 @@ void SvTreeListBox::InitSettings()
 {
 const StyleSettings& rStyleSettings = GetSettings().GetStyleSettings();
 vcl::Font aFont = rStyleSettings.GetFieldFont();
-aFont.SetColor(rStyleSettings.GetWindowTextColor());
 SetPointFont(*this, aFont);
 AdjustEntryHeightAndRecalc();
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/svtools svtools/source

[Caolán McNamara (via logerrit)]

 include/svtools/ctrlbox.hxx|6 ++--
 svtools/source/control/ctrlbox.cxx |   51 ++---
 2 files changed, 40 insertions(+), 17 deletions(-)

New commits:
commit 6a12fa6a77e407bf2d1e8be47f915ade8e1eab28
Author: Caolán McNamara 
AuthorDate: Fri Sep 11 11:53:12 2020 +0100
Commit: Caolán McNamara 
CommitDate: Fri Sep 11 15:19:32 2020 +0200

invalidate prerendered fontname cache on style change

Change-Id: Ie2111f23dc3346b914442090e3d9257c5659fafc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102459
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/include/svtools/ctrlbox.hxx b/include/svtools/ctrlbox.hxx
index 7411976b1642..817e276665d4 100644
--- a/include/svtools/ctrlbox.hxx
+++ b/include/svtools/ctrlbox.hxx
@@ -30,10 +30,11 @@
 
 namespace weld { class CustomWeld; }
 
-class VirtualDevice;
 class BitmapEx;
 class BorderWidthImpl;
 class FontList;
+class VclSimpleEvent;
+class VirtualDevice;
 
 /** Utility class storing the border line width, style and colors. The widths
 are defined in Twips.
@@ -339,7 +340,8 @@ private:
 SVT_DLLPRIVATE void ImplDestroyFontList();
 
 DECL_LINK(CustomRenderHdl, weld::ComboBox::render_args, void);
-DECL_STATIC_LINK(FontNameBox, CustomGetSizeHdl, OutputDevice&, Size);
+DECL_LINK(CustomGetSizeHdl, OutputDevice&, Size);
+DECL_LINK(SettingsChangedHdl, VclSimpleEvent&, void);
 DECL_LINK(UpdateHdl, Timer*, void);
 
 voidLoadMRUEntries( const OUString& aFontMRUEntriesFile );
diff --git a/svtools/source/control/ctrlbox.cxx 
b/svtools/source/control/ctrlbox.cxx
index 8287418a4fe4..3c553f531556 100644
--- a/svtools/source/control/ctrlbox.cxx
+++ b/svtools/source/control/ctrlbox.cxx
@@ -336,6 +336,35 @@ static size_t gPreviewsPerDevice;
 static std::vector> gFontPreviewVirDevs;
 static std::vector gRenderedFontNames;
 
+namespace
+{
+void calcCustomItemSize(weld::ComboBox& rComboBox)
+{
+gUserItemSz = Size(rComboBox.get_approximate_digit_width() * 52, 
rComboBox.get_text_height());
+gUserItemSz.setHeight(gUserItemSz.Height() * 16);
+gUserItemSz.setHeight(gUserItemSz.Height() / 10);
+
+size_t nMaxDeviceHeight = SAL_MAX_INT16 / 2; // see limitXCreatePixmap
+gPreviewsPerDevice = nMaxDeviceHeight / gUserItemSz.Height();
+}
+}
+
+IMPL_LINK(FontNameBox, SettingsChangedHdl, VclSimpleEvent&, rEvent, void)
+{
+if (rEvent.GetId() != VclEventId::ApplicationDataChanged)
+return;
+
+DataChangedEvent* pData = 
static_cast(static_cast(rEvent).GetData());
+if (pData->GetType() == DataChangedEventType::SETTINGS)
+{
+gFontPreviewVirDevs.clear();
+gRenderedFontNames.clear();
+calcCustomItemSize(*m_xComboBox);
+if (mbWYSIWYG)
+maUpdateIdle.Start();
+}
+}
+
 FontNameBox::FontNameBox(std::unique_ptr p)
 : m_xComboBox(std::move(p))
 , mnPreviewProgress(0)
@@ -347,10 +376,14 @@ FontNameBox::FontNameBox(std::unique_ptr 
p)
 
 maUpdateIdle.SetPriority(TaskPriority::LOWEST);
 maUpdateIdle.SetInvokeHandler(LINK(this, FontNameBox, UpdateHdl));
+
+Application::AddEventListener(LINK(this, FontNameBox, SettingsChangedHdl));
 }
 
 FontNameBox::~FontNameBox()
 {
+Application::RemoveEventListener(LINK(this, FontNameBox, 
SettingsChangedHdl));
+
 if (mpFontList)
 {
 SaveMRUEntries (maFontMRUEntriesFile);
@@ -473,21 +506,9 @@ void FontNameBox::EnableWYSIWYG(bool bEnable)
 return;
 mbWYSIWYG = bEnable;
 
-static bool bGlobalsInited;
-if (mbWYSIWYG && !bGlobalsInited)
-{
-gUserItemSz = Size(m_xComboBox->get_approximate_digit_width() * 52, 
m_xComboBox->get_text_height());
-gUserItemSz.setHeight(gUserItemSz.Height() * 16);
-gUserItemSz.setHeight(gUserItemSz.Height() / 10);
-
-size_t nMaxDeviceHeight = SAL_MAX_INT16 / 2; // see limitXCreatePixmap
-gPreviewsPerDevice = nMaxDeviceHeight / gUserItemSz.Height();
-
-bGlobalsInited = true;
-}
-
 if (mbWYSIWYG)
 {
+calcCustomItemSize(*m_xComboBox);
 m_xComboBox->connect_custom_get_size(LINK(this, FontNameBox, 
CustomGetSizeHdl));
 m_xComboBox->connect_custom_render(LINK(this, FontNameBox, 
CustomRenderHdl));
 }
@@ -499,9 +520,9 @@ void FontNameBox::EnableWYSIWYG(bool bEnable)
 m_xComboBox->set_custom_renderer(mbWYSIWYG);
 }
 
-IMPL_STATIC_LINK_NOARG(FontNameBox, CustomGetSizeHdl, OutputDevice&, Size)
+IMPL_LINK_NOARG(FontNameBox, CustomGetSizeHdl, OutputDevice&, Size)
 {
-return gUserItemSz;
+return mbWYSIWYG ? gUserItemSz : Size();
 }
 
 namespace
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 134375] Position and size property box in LO should show 0.00 when abutting a document's edge not be blank

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=134375

--- Comment #7 from mwtjunkm...@gmail.com ---
Created attachment 165393
  --> https://bugs.documentfoundation.org/attachment.cgi?id=165393=edit
sidebar properties

Showing blank sidebar properties.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 134375] Position and size property box in LO should show 0.00 when abutting a document's edge not be blank

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=134375

mwtjunkm...@gmail.com changed:

   What|Removed |Added

 Resolution|WORKSFORME  |---
 Status|RESOLVED|NEW

--- Comment #6 from mwtjunkm...@gmail.com ---
WHUPS spoke too soon.  I had failed to move the object on the draw slide that I
was testing to 0,0.  Objects at 0,0, even with the new properties box on the
sidebar, are still blank when selected.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 134375] Position and size property box in LO should show 0.00 when abutting a document's edge not be blank

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=134375

mwtjunkm...@gmail.com changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #5 from mwtjunkm...@gmail.com ---
The position & size properties box on the sidebar looks to have been reworked.
I don't see blank values now in the fields.

Works for me in:

Version: 7.1.0.0.alpha0+ (x64)
Build ID: ed4f610f4a3de12016f8308a17b6ad4f86e9d67a
CPU threads: 8; OS: Windows 10.0 Build 20211; UI render: default; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: ESC meeting minutes: 2020-09-10

[Jan-Marek Glogowski]

Am 10.09.20 um 16:55 schrieb Miklos Vajna:
> * Merging features/windows-cross-build (Jan-Marek)
>   + see 
> https://lists.freedesktop.org/archives/libreoffice/2020-September/085869.html
>   + flagging: this is to be merged (Thorsten)
> + seeing no objections so far

Sorry that I missed the call. What should I make of this?

I "just" rebased the branch, fixed the missing LibreOfficeWin32.conf
Christian found and re-triggered
https://gerrit.libreoffice.org/c/core/+/99717 - still green.

>From all I know, I can also push the whole patch set to Gerrit. The
patches should compile individually.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 136158] Dev Alpha 7.1: PNG export in LO Draw of a picture results in a blank image the size of the picture

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136158

mwtjunkm...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #13 from mwtjunkm...@gmail.com ---
There remain other problems with the PNG output, but at least I'm getting a
picture now in:

Version: 7.1.0.0.alpha0+ (x64)
Build ID: ed4f610f4a3de12016f8308a17b6ad4f86e9d67a
CPU threads: 8; OS: Windows 10.0 Build 20211; UI render: default; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

Both SKIA and hardware rendering.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136668] Blank page between regular pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136668

--- Comment #1 from Zamerov Aleksandr  ---
Created attachment 165392
  --> https://bugs.documentfoundation.org/attachment.cgi?id=165392=edit
Repro document

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136668] New: Blank page between regular pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136668

Bug ID: 136668
   Summary: Blank page between regular pages
   Product: LibreOffice
   Version: 6.4.5.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: zamerov...@directum.ru

Description:
Document generated with FastReport2020.

In word and onlyoffice all fine, in LibreOffice6.45 and 7 versions get blank
page

Steps to Reproduce:
Just open attachment

Actual Results:
2 page is blank. Actual info showed on 1 and 3 page.

Expected Results:
Only 1,3 pages showed, without blank page.


Reproducible: Always


User Profile Reset: No



Additional Info:
Maybe FastReport generate page break incorrect.
If anyone can say, how to do it correct - help me pls :)

Версия: 6.4.5.2 (x86)
ID сборки: a726b36747cf2001e06b58ad5db1aa3a9a1872d6
Потоков ЦП: 4; ОС: Windows 10.0 Build 14393; Отрисовка ИП: по умолчанию; VCL:
win; 
Локаль: ru-RU (ru_RU); Язык интерфейса: ru-RU
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135910] Transparent objects either possess outlines when none are defined or are completely opaque, depending on export PNG options

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135910

--- Comment #17 from mwtjunkm...@gmail.com ---
Still happening in 

Version: 7.1.0.0.alpha0+ (x64)
Build ID: ed4f610f4a3de12016f8308a17b6ad4f86e9d67a
CPU threads: 8; OS: Windows 10.0 Build 20211; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/xmloff xmloff/source

[Noel Grandin (via logerrit)]

 include/xmloff/txtimp.hxx  |1 -
 xmloff/source/core/xmltkmap.cxx|   12 +---
 xmloff/source/text/XMLTextFrameContext.cxx |6 +-
 xmloff/source/text/txtimp.cxx  |1 -
 4 files changed, 10 insertions(+), 10 deletions(-)

New commits:
commit e628b94ccf062c2f3161acef11012ae2f5fbc5a3
Author: Noel Grandin 
AuthorDate: Thu Sep 10 10:36:59 2020 +0200
Commit: Noel Grandin 
CommitDate: Fri Sep 11 14:35:23 2020 +0200

remove duplicate XML_TOK_TEXT_FRAME_FILTER_NAME

which has been there ever since
commit fd069bee7e57ad529c3c0974559fd2d84ec3151a
Date:   Mon Sep 18 16:07:07 2000 +
initial import

And add assert to prevent more duplicates

Change-Id: I371a117896c1ab36fabf69da41229a7bcf5459d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102366
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/xmloff/txtimp.hxx b/include/xmloff/txtimp.hxx
index 0eb09e6f580c..f2585b4259eb 100644
--- a/include/xmloff/txtimp.hxx
+++ b/include/xmloff/txtimp.hxx
@@ -291,7 +291,6 @@ enum XMLTextFrameAttrTokens
 XML_TOK_TEXT_FRAME_REL_HEIGHT,
 XML_TOK_TEXT_FRAME_NEXT_CHAIN_NAME,
 XML_TOK_TEXT_FRAME_HREF,
-XML_TOK_TEXT_FRAME_FILTER_NAME,
 XML_TOK_TEXT_FRAME_Z_INDEX,
 XML_TOK_TEXT_FRAME_TRANSFORM,
 XML_TOK_TEXT_FRAME_CLASS_ID,
diff --git a/xmloff/source/core/xmltkmap.cxx b/xmloff/source/core/xmltkmap.cxx
index d89eb9621638..bf61a37488f4 100644
--- a/xmloff/source/core/xmltkmap.cxx
+++ b/xmloff/source/core/xmltkmap.cxx
@@ -52,10 +52,16 @@ public:
 
 void SvXMLTokenMap_Impl::insert( const SvXMLTokenMapEntry& rEntry )
 {
-m_aPrefixAndNameToTokenMap.insert( std::make_pair( std::make_pair( 
rEntry.nPrefixKey,
-   GetXMLToken( rEntry.eLocalName ) ), 
rEntry.nToken ) );
+bool inserted = m_aPrefixAndNameToTokenMap.insert( std::make_pair( 
std::make_pair( rEntry.nPrefixKey,
+   GetXMLToken( rEntry.eLocalName ) ), 
rEntry.nToken ) ).second;
+assert(inserted && "duplicate token");
+(void)inserted;
 if( rEntry.nFastToken )
-m_aFastTokenToTokenMap.insert( std::make_pair( rEntry.nFastToken, 
rEntry.nToken ) );
+{
+bool inserted2 = m_aFastTokenToTokenMap.insert( std::make_pair( 
rEntry.nFastToken, rEntry.nToken ) ).second;
+assert(inserted2 && "duplicate token");
+(void)inserted2;
+}
 }
 
 sal_uInt16 SvXMLTokenMap_Impl::get( sal_uInt16 nKeyPrefix, const OUString& 
rLName ) const
diff --git a/xmloff/source/text/XMLTextFrameContext.cxx 
b/xmloff/source/text/XMLTextFrameContext.cxx
index 58988bae259c..7ab210dbd938 100644
--- a/xmloff/source/text/XMLTextFrameContext.cxx
+++ b/xmloff/source/text/XMLTextFrameContext.cxx
@@ -355,7 +355,6 @@ class XMLTextFrameContext_Impl : public SvXMLImportContext
 OUString sStyleName;
 OUString sNextName;
 OUString sHRef;
-OUString sFilterName;
 OUString sCode;
 OUString sMimeType;
 OUString sFrameName;
@@ -689,7 +688,7 @@ void XMLTextFrameContext_Impl::Create()
 xPropSet->setPropertyValue("Graphic", Any(xGraphic));
 
 // filter name
-xPropSet->setPropertyValue( "GraphicFilter", Any(sFilterName) );
+xPropSet->setPropertyValue( "GraphicFilter", Any(OUString()) );
 
 // rotation
 xPropSet->setPropertyValue( "GraphicRotation", Any(nRotation) );
@@ -1015,9 +1014,6 @@ XMLTextFrameContext_Impl::XMLTextFrameContext_Impl(
 case XML_TOK_TEXT_FRAME_HREF:
 sHRef = rValue;
 break;
-case XML_TOK_TEXT_FRAME_FILTER_NAME:
-sFilterName = rValue;
-break;
 case XML_TOK_TEXT_FRAME_TRANSFORM:
 {
 // RotateFlyFrameFix: im/export full 'draw:transform' using 
existing tooling
diff --git a/xmloff/source/text/txtimp.cxx b/xmloff/source/text/txtimp.cxx
index 73e6b61d853d..75e73c899171 100644
--- a/xmloff/source/text/txtimp.cxx
+++ b/xmloff/source/text/txtimp.cxx
@@ -372,7 +372,6 @@ const SvXMLTokenMapEntry aTextFrameAttrTokenMap[] =
 { XML_NAMESPACE_STYLE, XML_REL_HEIGHT, XML_TOK_TEXT_FRAME_REL_HEIGHT },
 { XML_NAMESPACE_DRAW, XML_CHAIN_NEXT_NAME, 
XML_TOK_TEXT_FRAME_NEXT_CHAIN_NAME },
 { XML_NAMESPACE_XLINK, XML_HREF, XML_TOK_TEXT_FRAME_HREF },
-{ XML_NAMESPACE_DRAW, XML_NAME, XML_TOK_TEXT_FRAME_FILTER_NAME },
 { XML_NAMESPACE_DRAW, XML_ZINDEX, XML_TOK_TEXT_FRAME_Z_INDEX },
 { XML_NAMESPACE_DRAW, XML_TRANSFORM, XML_TOK_TEXT_FRAME_TRANSFORM },
 { XML_NAMESPACE_DRAW, XML_CLASS_ID, XML_TOK_TEXT_FRAME_CLASS_ID },
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 136654] Next Style does not get triggered if there is Text after the cursor.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136654

--- Comment #5 from Clarc  ---
(In reply to BogdanB from comment #4)
> Ok. I confirm this behaviour, but I don't consider this to be a bug.
> Imagine that you will need the Heading 1 to be 2 rows and you press enter to
> finish the first line earlier, so you have a H1 on 2 rows. In this case is
> usefull.
That is one way to get two lines of Heading, yes. But consider this:
Your H1 Style is set to add a Page Break after the H1. Now you perform the
steps-to-reproduce.
What happens? You actually don't get a 2-line-heading but instead get two
headings. There will also be a problem if you set your headings to get them
numbered. Then, you would get something like this:

1 THIS IS MY

2 HEADING

Normal text. Normal text. Normal text. Normal text.


The proper way to get a two-line-Heading is to
(1. Just wait until your H1 is long enough to become a two-liner by itself)
2. Use SHIFT + ENTER two insert a manual page break.



And since this...
> 1. Open a new LO document
> 2. Press CTRL + 1 to get a H1
> 3. Write a few nonsense letters.
> 4. Press enter
> 5. The following text is a Text Body. (as it should be.) Write a few
>nonsense letters.
> 6. Place your cursor at the beginning of your Text-Body-Text.
> 7. Click DELETE/BACKSPACE to move your Text-Body-Text up and make it become
>a H1 Text
> 8. Click ENTER. Now you have two H1s, even though H1 is set to use Text
>Body as it's Next Style.
...is not the intended way of creating two-lined-headings, leaving this bug in
LO actually just takes away one very handy functionality: the ability to use
the Next-Style-option in those scenarios.


Do my thoughts on this make sense?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - include/vcl vcl/source

[Caolán McNamara (via logerrit)]

 include/vcl/treelist.hxx  |1 
 vcl/source/app/salvtables.cxx |   54 --
 2 files changed, 48 insertions(+), 7 deletions(-)

New commits:
commit b19e522654562b8f01d0b3af4078c43ce46834e4
Author: Caolán McNamara 
AuthorDate: Thu Sep 10 09:33:39 2020 +0100
Commit: Xisco Fauli 
CommitDate: Fri Sep 11 14:21:16 2020 +0200

tdf#131581 inhibit updates during all_foreach

Change-Id: I8494b4c9175e427bfb89696d49c2da7607af37ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102380
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/include/vcl/treelist.hxx b/include/vcl/treelist.hxx
index 85aba58f8818..46d3374d8caf 100644
--- a/include/vcl/treelist.hxx
+++ b/include/vcl/treelist.hxx
@@ -132,6 +132,7 @@ public:
 );
 
 voidEnableInvalidate( bool bEnable );
+boolIsEnableInvalidate() const { return 
mbEnableInvalidate; }
 
 // Notify all Listeners
 voidInvalidateEntry( SvTreeListEntry* );
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index ccfe3ac7d542..dbdff77e891f 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -3182,6 +3182,37 @@ class SalInstanceTreeView;
 
 static SalInstanceTreeView* g_DragSource;
 
+namespace
+{
+class UpdateGuard
+{
+private:
+SvTabListBox& m_rTreeView;
+bool m_bOrigUpdate;
+bool m_bOrigEnableInvalidate;
+
+public:
+UpdateGuard(SvTabListBox& rTreeView)
+: m_rTreeView(rTreeView)
+, m_bOrigUpdate(m_rTreeView.IsUpdateMode())
+, 
m_bOrigEnableInvalidate(m_rTreeView.GetModel()->IsEnableInvalidate())
+{
+if (m_bOrigUpdate)
+m_rTreeView.SetUpdateMode(false);
+if (m_bOrigEnableInvalidate)
+m_rTreeView.GetModel()->EnableInvalidate(false);
+}
+
+~UpdateGuard()
+{
+if (m_bOrigUpdate)
+m_rTreeView.SetUpdateMode(true);
+if (m_bOrigEnableInvalidate)
+m_rTreeView.GetModel()->EnableInvalidate(true);
+}
+};
+}
+
 class SalInstanceTreeView : public SalInstanceContainer, public virtual 
weld::TreeView
 {
 private:
@@ -3251,6 +3282,13 @@ private:
 pEntry->AddItem(std::move(xCell));
 }
 
+void InvalidateModelEntry(SvTreeListEntry* pEntry)
+{
+if (!m_xTreeView->GetModel()->IsEnableInvalidate())
+return;
+m_xTreeView->ModelHasEntryInvalidated(pEntry);
+}
+
 public:
 SalInstanceTreeView(SvTabListBox* pTreeView, SalInstanceBuilder* pBuilder, 
bool bTakeOwnership)
 : SalInstanceContainer(pTreeView, pBuilder, bTakeOwnership)
@@ -3714,7 +3752,7 @@ public:
 assert(dynamic_cast());
 static_cast(rItem).SetText(rText);
 }
-m_xTreeView->ModelHasEntryInvalidated(pEntry);
+InvalidateModelEntry(pEntry);
 }
 
 virtual void set_text(int pos, const OUString& rText, int col) override
@@ -3738,7 +3776,7 @@ public:
 if (rItem.GetType() == SvLBoxItemType::String)
 {
 rItem.Enable(bSensitive);
-m_xTreeView->ModelHasEntryInvalidated(pEntry);
+InvalidateModelEntry(pEntry);
 break;
 }
 }
@@ -3751,7 +3789,7 @@ public:
 SvLBoxItem& rItem = pEntry->GetItem(col);
 rItem.Enable(bSensitive);
 
-m_xTreeView->ModelHasEntryInvalidated(pEntry);
+InvalidateModelEntry(pEntry);
 }
 
 using SalInstanceWidget::set_sensitive;
@@ -3833,7 +3871,7 @@ public:
 break;
 }
 
-m_xTreeView->ModelHasEntryInvalidated(pEntry);
+InvalidateModelEntry(pEntry);
 }
 
 virtual void set_toggle(int pos, TriState eState, int col) override
@@ -3864,7 +3902,7 @@ public:
 assert(dynamic_cast());
 static_cast(rItem).Emphasize(bOn);
 
-m_xTreeView->ModelHasEntryInvalidated(pEntry);
+InvalidateModelEntry(pEntry);
 }
 
 virtual void set_text_emphasis(const weld::TreeIter& rIter, bool bOn, int 
col) override
@@ -3900,7 +3938,7 @@ public:
 assert(dynamic_cast());
 static_cast(rItem).Align(fAlign);
 
-m_xTreeView->ModelHasEntryInvalidated(pEntry);
+InvalidateModelEntry(pEntry);
 }
 
 virtual void set_text_align(const weld::TreeIter& rIter, double fAlign, 
int col) override
@@ -3962,7 +4000,7 @@ public:
 }
 
 m_xTreeView->SetEntryHeight(pEntry);
-m_xTreeView->ModelHasEntryInvalidated(pEntry);
+InvalidateModelEntry(pEntry);
 }
 
 virtual void set_image(int pos, const OUString& rImage, int col) override
@@ -4303,6 +4341,8 @@ public:
 
 virtual void all_foreach(const std::function& func) 
override
 {
+UpdateGuard aGuard(*m_xTreeView);
+
 

[Libreoffice-bugs] [Bug 136165] Transparent background when exporting a page with image to PNG

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136165

--- Comment #1 from mwtjunkm...@gmail.com ---
I agree, it is confusing. You have a (visually) white background whether the
page background is transparent or white. Many programs like Paint.net, Krita,
and others use a checkered white-and-gray pattern to represent transparency.

It is ABSOLUTELY desirable to have an exported image from Draw to have a
transparent background if the background is set to None.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 136165] Transparent background when exporting a page with image to PNG

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136165

--- Comment #1 from mwtjunkm...@gmail.com ---
I agree, it is confusing. You have a (visually) white background whether the
page background is transparent or white. Many programs like Paint.net, Krita,
and others use a checkered white-and-gray pattern to represent transparency.

It is ABSOLUTELY desirable to have an exported image from Draw to have a
transparent background if the background is set to None.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - desktop/source editeng/source sd/qa

[Marco Cecchetti (via logerrit)]

 desktop/source/lib/init.cxx   |2 
 editeng/source/editeng/impedit.cxx|  279 --
 editeng/source/editeng/impedit.hxx|2 
 editeng/source/editeng/impedit3.cxx   |5 
 sd/qa/unit/tiledrendering/LOKitSearchTest.cxx |4 
 5 files changed, 144 insertions(+), 148 deletions(-)

New commits:
commit dbca79d09acf5439e59c693db941b1d6e73c94c9
Author: Marco Cecchetti 
AuthorDate: Wed Aug 26 09:06:59 2020 +0200
Commit: Andras Timar 
CommitDate: Fri Sep 11 14:09:59 2020 +0200

Online: selection highlight in Calc should follow font size changes.

When user changes font size of selected text, markers and highlight 
rectangle should be updated.
impedit3.cxx: Line had no effect, removed.
Lokitsearchtest.cxx: Test had bug.
Other changes: LOKit code is separated. Now callback_text_selection is 
fired when font size is changed (Calc). On Writer it already behaves that way.

Change-Id: I9b7e3224ad162bfb7d8f0853b6cb17b4feafa0cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101193
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Marco Cecchetti 
Reviewed-by: Andras Timar 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102458
Tested-by: Andras Timar 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index d0982e0bdcf1..c5f19c23eb93 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -1393,6 +1393,8 @@ void CallbackFlushHandler::queue(const int type, const 
char* data)
 type != LOK_CALLBACK_CURSOR_VISIBLE &&
 type != LOK_CALLBACK_VIEW_CURSOR_VISIBLE &&
 type != LOK_CALLBACK_TEXT_SELECTION &&
+type != LOK_CALLBACK_TEXT_SELECTION_START &&
+type != LOK_CALLBACK_TEXT_SELECTION_END &&
 type != LOK_CALLBACK_REFERENCE_MARKS)
 {
 SAL_INFO("lok", "Skipping while painting [" << type << "]: [" << 
payload << "].");
diff --git a/editeng/source/editeng/impedit.cxx 
b/editeng/source/editeng/impedit.cxx
index b67a847c615d..58ba2ce6d43d 100644
--- a/editeng/source/editeng/impedit.cxx
+++ b/editeng/source/editeng/impedit.cxx
@@ -198,6 +198,124 @@ void ImpEditView::SelectionChanged()
 }
 }
 
+// This function is also called when a text's font || size is changed. Because 
its highlight rectangle must be updated.
+void ImpEditView::lokSelectionCallback(std::unique_ptr 
, bool bStartHandleVisible, bool bEndHandleVisible) {
+VclPtr pParent = pOutWin->GetParentWithLOKNotifier();
+vcl::Region pRegion = vcl::Region( *pPolyPoly );
+
+if (pParent && pParent->GetLOKWindowId() != 0)
+{
+const long nX = pOutWin->GetOutOffXPixel() - 
pParent->GetOutOffXPixel();
+const long nY = pOutWin->GetOutOffYPixel() - 
pParent->GetOutOffYPixel();
+
+std::vector aRectangles;
+pRegion.GetRegionRectangles(aRectangles);
+
+std::vector v;
+for (tools::Rectangle & rRectangle : aRectangles)
+{
+rRectangle = pOutWin->LogicToPixel(rRectangle);
+rRectangle.Move(nX, nY);
+v.emplace_back(rRectangle.toString().getStr());
+}
+OString sRectangle = comphelper::string::join("; ", v);
+
+const vcl::ILibreOfficeKitNotifier* pNotifier = 
pParent->GetLOKNotifier();
+const OUString rAction("text_selection");
+std::vector aItems;
+aItems.emplace_back("rectangles", sRectangle);
+aItems.emplace_back("startHandleVisible", 
OString::boolean(bStartHandleVisible));
+aItems.emplace_back("endHandleVisible", 
OString::boolean(bEndHandleVisible));
+pNotifier->notifyWindow(pParent->GetLOKWindowId(), rAction, aItems);
+}
+else
+{
+pOutWin->Push(PushFlags::MAPMODE);
+if (pOutWin->GetMapMode().GetMapUnit() == MapUnit::MapTwip)
+{
+// Find the parent that is not right
+// on top of us to use its offset.
+vcl::Window* parent = pOutWin->GetParent();
+while (parent &&
+parent->GetOutOffXPixel() == pOutWin->GetOutOffXPixel() &&
+parent->GetOutOffYPixel() == pOutWin->GetOutOffYPixel())
+{
+parent = parent->GetParent();
+}
+
+if (parent)
+{
+lcl_translateTwips(*parent, *pOutWin);
+}
+}
+
+bool bMm100ToTwip = (pOutWin->GetMapMode().GetMapUnit() == 
MapUnit::Map100thMM);
+
+Point aOrigin;
+if (pOutWin->GetMapMode().GetMapUnit() == MapUnit::MapTwip)
+// Writer comments: they use editeng, but are separate widgets.
+aOrigin = pOutWin->GetMapMode().GetOrigin();
+
+OString sRectangle;
+
+std::vector aRectangles;
+pRegion.GetRegionRectangles(aRectangles);
+
+if (!aRectangles.empty())
+{
+if (pOutWin->IsChart())
+{
+ 

[Libreoffice-commits] core.git: vcl/source

[Stephan Bergmann (via logerrit)]

 vcl/source/window/abstdlg.cxx |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit dd6f59a52a564f470070063719d1e9ff2e814261
Author: Stephan Bergmann 
AuthorDate: Fri Sep 11 12:30:13 2020 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Sep 11 14:09:12 2020 +0200

Do not even unload cui library during exit

 "Turn OUStringLiteral into 
a
consteval'ed, static-refcound rtl_uString" kept crashing in 
UITest_sw_options:
VclAbstractDialogFactory::Create loaded the cui library, then some code 
created
OUString instances pointing at the

> const OUStringLiteral VIEWOPT_DATANAME = u"page data";

(cui/source/options/treeopt.cxx) in the cui library's rodata section, and at
least one of those OUString instances ended up in the data structures
owned by the static configmgr::Components singleton
(configmgr/source/components.cxx).  Now the UITest_sw_options test code in
sw/qa/uitest/options/tdf78133.py makes some modifications that apparently 
cause
SvtLinguConfig (unotools/source/config/lingucfg.cxx) to be used but, for
whatever reason (i.e., whether or not that is another bug that would benefit
from chasing it down), not get cleaned up properly, so that during 
termination,

> 
warn:unotools.config:799178:799178:unotools/source/config/configmgr.cxx:140: 
ConfigManager not empty

gets emitted, and that SvtLinguConfig apparently holds on to configmgr data 
so
that the configmgr::Components singleton data structures are not fully 
cleaned
up prior to exit.

So when the exit handlers run, they happened to be run in such an order that
first this static aDialogLibrary was destroyed, causing the cui library 
(and its
rodata segment) to be unloaded, and only then the static 
configmgr::Components
singleton was destroyed.  The latter tried to remove all its 
not-yet-cleaned-up
(see above) data structures, which still referenced an OUString instance
containing a---meanwhile dangling---pointer to VIEWOPT_DATANAME, causing a
crash.

So instead of a static Module, use Module::release, as is already used in 
other
places loading libraries.

Change-Id: Ibc16d26f6125d20317a641b95ef71b4b406f0999
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102456
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/vcl/source/window/abstdlg.cxx b/vcl/source/window/abstdlg.cxx
index b774b0206f3e..7a75e8c439fb 100644
--- a/vcl/source/window/abstdlg.cxx
+++ b/vcl/source/window/abstdlg.cxx
@@ -33,12 +33,14 @@ VclAbstractDialogFactory* VclAbstractDialogFactory::Create()
 {
 static auto fp = []() -> FuncPtrCreateDialogFactory {
 #ifndef DISABLE_DYNLOADING
-static ::osl::Module aDialogLibrary;
+::osl::Module aDialogLibrary;
 if (aDialogLibrary.loadRelative(, CUI_DLL_NAME,
 SAL_LOADMODULE_GLOBAL | 
SAL_LOADMODULE_LAZY))
 {
-return reinterpret_cast(
+auto const p = reinterpret_cast(
 aDialogLibrary.getFunctionSymbol( "CreateDialogFactory" ) );
+aDialogLibrary.release();
+return p;
 }
 return nullptr;
 #else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

[Caolán McNamara (via logerrit)]

 vcl/source/app/vclevent.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a419780b39b1dc875db4ed4a45f6b338524e7c82
Author: Caolán McNamara 
AuthorDate: Fri Sep 11 11:36:40 2020 +0100
Commit: Caolán McNamara 
CommitDate: Fri Sep 11 14:04:00 2020 +0200

application level settings-changed event callbacks not triggering

this was originally...

ImplDelData aDel( pWinEvent->GetWindow() );
while ( aIter != aEnd && !aDel.IsDead() )

before

commit 1db7af8bc9febdf72138fac533ec81d6983da729
Date:   Tue Jan 26 22:10:52 2016 +0530

tdf#96888 - Kill internal vcl dog-tags ...

back then if GetWindow was null ImplDelData.IsDead() was
always false

Change-Id: I1e75c27635532afa08ed43bf92bda35b34ae6320
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102455
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/app/vclevent.cxx b/vcl/source/app/vclevent.cxx
index 94cf37c638d3..1895051ce633 100644
--- a/vcl/source/app/vclevent.cxx
+++ b/vcl/source/app/vclevent.cxx
@@ -35,7 +35,7 @@ void VclEventListeners::Call( VclSimpleEvent& rEvent ) const
 if (VclWindowEvent* pWindowEvent = dynamic_cast())
 {
 VclPtr xWin(pWindowEvent->GetWindow());
-while ( aIter != aEnd && xWin && ! xWin->IsDisposed() )
+while ( aIter != aEnd && (!xWin || !xWin->IsDisposed()) )
 {
 Link  = *aIter;
 // check this hasn't been removed in some re-enterancy scenario 
fdo#47368
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 136457] Sidebar does not appear in Impress on iOS (regression)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136457

--- Comment #10 from Tor Lillqvist  ---
Yep, that indeed is a reliable way to reproduce, so far. Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117134] FILEOPEN Adjacent tables in DOCX mostly overlap

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117134

NISZ LibreOffice Team  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=76
   ||022

--- Comment #15 from NISZ LibreOffice Team  ---
I guess we can consider this one fixed per comment #12 ?

There are similar problems still (bug #76022 and bug #115625 is for shape +
table ), but those are tracked as separate.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76022] DOC/DOCX import: textframe layout is wrong (also wrong in old versions of MSO, but "correct" in MSO2013)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=76022

NISZ LibreOffice Team  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||7134

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'distro/collabora/co-4-2' - loleaflet/src

[Pedro Pinto Silva (via logerrit)]

 loleaflet/src/control/Control.JSDialogBuilder.js |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit a201d0f5903032d02b5a3bfc034b278643307688
Author: Pedro Pinto Silva 
AuthorDate: Fri Sep 11 11:07:28 2020 +0200
Commit: Andras Timar 
CommitDate: Fri Sep 11 13:46:14 2020 +0200

Mobile: set icon for watermark transparency spinfield

Reuse lc_settransparency icon used on objects instead of duplicating file

Change-Id: Iec2393aa43edcf5907f3ae401811414cdb4682f3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102421
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 

diff --git a/loleaflet/src/control/Control.JSDialogBuilder.js 
b/loleaflet/src/control/Control.JSDialogBuilder.js
index 1422a71b6..87fe1060d 100644
--- a/loleaflet/src/control/Control.JSDialogBuilder.js
+++ b/loleaflet/src/control/Control.JSDialogBuilder.js
@@ -46,6 +46,8 @@ L.Control.JSDialogBuilder = L.Control.extend({
builder._fixedtextControl(parentContainer, 
fixedTextData, builder);
}
 
+   console.debug('baseSpinField: ' + data.id);
+
var div = L.DomUtil.create('div', 'spinfieldcontainer', 
parentContainer);
div.id = data.id;
controls['container'] = div;
@@ -53,7 +55,7 @@ L.Control.JSDialogBuilder = L.Control.extend({
var commandName = data.id ? 
data.id.substring('.uno:'.length) : data.id;
if (commandName && commandName.length && 
L.LOUtil.existsIconForCommand(commandName, builder.map.getDocType())) {
var image = L.DomUtil.create('img', 
'spinfieldimage', div);
-   var icon = builder._createIconURL(data.id);
+   var icon = (data.id === 'Transparency') ? 
builder._createIconURL('settransparency') : builder._createIconURL(data.id);
image.src = icon;
icon.alt = '';
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 117134] FILEOPEN Adjacent tables in DOCX mostly overlap

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117134

--- Comment #14 from NISZ LibreOffice Team  ---
Created attachment 165391
  --> https://bugs.documentfoundation.org/attachment.cgi?id=165391=edit
Frame+table in Word and LO 7.0

Example file from comment #7 now looks good in 7.0 since:

https://git.libreoffice.org/core/+/358f654af36fa12102685237f6eadebae4610fb5

author
Tibor Nagy  Wed May 20 13:31:51 2020 +0200 
committer
László Németh  Mon May 25 10:12:44 2020 +0200 

tdf#107119 DOCX import: fix parallel text wrap around frames

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136654] Next Style does not get triggered if there is Text after the cursor.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136654

BogdanB  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Keywords||needsUXEval

--- Comment #4 from BogdanB  ---
Ok. I confirm this behaviour, but I don't consider this to be a bug.
Imagine that you will need the Heading 1 to be 2 rows and you press enter to
finish the first line earlier, so you have a H1 on 2 rows. In this case is
usefull.

Also, in the case you described, you can select the second row and specify the
style you want to be.

Version: 7.0.1.2
Build ID: 7cbcfc562f6eb6708b5ff7d7397325de9e764452
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (ro_RO.UTF-8); UI: en-US
Calc: threaded

BEHAVIOUR CONFIRMED, but NOT consider as a bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121513] FILESAVE DOCX TextBox in Shape is modified after export

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121513

NISZ LibreOffice Team  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=80
   ||526

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80526] FILEOPEN: DOCX frame not being stretched to accomodate text in it

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80526

NISZ LibreOffice Team  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||1513

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 133343] Saving performance for a large complex drawing slow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=133343

--- Comment #7 from Noel Grandin  ---
We spend about 50% of the save time traversing every single property of every
single object in the diagram calculating something called AutoStyles.

Unfortunately, I do not see any relatively simple way to improve this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136651] LO installed from .deb file should tell user if there is a new version available.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136651

--- Comment #6 from BogdanB  ---
Created attachment 165390
  --> https://bugs.documentfoundation.org/attachment.cgi?id=165390=edit
see this image

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136651] LO installed from .deb file should tell user if there is a new version available.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136651

--- Comment #5 from BogdanB  ---
Between Advanced and OpenCL, there should be that option.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136651] LO installed from .deb file should tell user if there is a new version available.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136651

--- Comment #4 from BogdanB  ---
Yes, maybe.
I have .deb version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76324] CALC becomes very slow with 5000+ comments ( see comment 85 )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=76324

--- Comment #98 from b.  ---
i think i have isolated and visualized one of the 'most evil' aspects / effects
of this bug in: 

https://bugs.documentfoundation.org/show_bug.cgi?id=125619#c23

may be it's worth to have a look there ...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136667] Crash when opening file with change tracked floating table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136667

László Németh  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |nem...@numbertext.org
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125619] 'performance problem with plenty comments' still in 6.3 alpha1, *only after save of file/autosave*

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125619

--- Comment #23 from b.  ---
Created attachment 165389
  --> https://bugs.documentfoundation.org/attachment.cgi?id=165389=edit
evil effect of (auto)save

for those who do not believe in the 'bad influence' of autosave here is a
visualization:  

i used the sheet / macro from the above comment to create 150.000 cells with
comments (A2: 15 - A3: 1 - start macro), and observed the resource usage and
commented attached screenshot: 

1. - close calc (7.1.0.0.a0+), 
2. - open calc (7.1.0.0.a0+), 
3. - open the sheet with the macro, 
4. - start generation of the cells, 
5. - slow progress in the production, 
6. - start of autosave (after 9 minutes), 
7. - inadvertent opening of calc 7.0 parallel, 
8. - calc 7.0 closed, 7.1 continues to run, 
9. - memory full, 
10. - finished and display of the result, 

the used memory will be released only after closing calc, i.e. until then the
computer works with 'memory full', 

that certainly does not! help the system to work smooth and performant, 

(same happens if the cell creation is finished before autosave) 

the effect of many comments is already unhealthy, 

autosave - or any other save - in addition is catastrophic ... :-(

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: comphelper/source

[Noel Grandin (via logerrit)]

 comphelper/source/misc/anycompare.cxx |   64 +++---
 1 file changed, 60 insertions(+), 4 deletions(-)

New commits:
commit 3b918495513d8e43063a45ac500962703e08f94e
Author: Noel Grandin 
AuthorDate: Thu Sep 10 17:08:15 2020 +0200
Commit: Noel Grandin 
CommitDate: Fri Sep 11 13:09:26 2020 +0200

small optimisation

avoid allocating predicate on heap, which is expensive when walking over
large numbers of styles nodes

Change-Id: Ida4369b77fb74f3af1258a97b0b99e3a78413833
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102437
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/comphelper/source/misc/anycompare.cxx 
b/comphelper/source/misc/anycompare.cxx
index bb77544c957e..72156024ccd0 100644
--- a/comphelper/source/misc/anycompare.cxx
+++ b/comphelper/source/misc/anycompare.cxx
@@ -235,10 +235,66 @@ namespace comphelper
 auto rhsTypeClass = rhs.getValueType().getTypeClass();
 if (lhsTypeClass != rhsTypeClass)
 return lhsTypeClass < rhsTypeClass;
-std::unique_ptr< IKeyPredicateLess > pred = getStandardLessPredicate( 
lhs.getValueType(), Reference< XCollator >() );
-if (!pred) // type==VOID
-return false;
-return pred->isLess(lhs, rhs);
+
+switch ( lhsTypeClass )
+{
+case TypeClass_CHAR:
+return ScalarPredicateLess< sal_Unicode >().isLess(lhs, rhs);
+case TypeClass_BOOLEAN:
+return ScalarPredicateLess< bool >().isLess(lhs, rhs);
+break;
+case TypeClass_BYTE:
+return ScalarPredicateLess< sal_Int8 >().isLess(lhs, rhs);
+break;
+case TypeClass_SHORT:
+return ScalarPredicateLess< sal_Int16 >().isLess(lhs, rhs);
+break;
+case TypeClass_UNSIGNED_SHORT:
+return ScalarPredicateLess< sal_uInt16 >().isLess(lhs, rhs);
+break;
+case TypeClass_LONG:
+return ScalarPredicateLess< sal_Int32 >().isLess(lhs, rhs);
+break;
+case TypeClass_UNSIGNED_LONG:
+return ScalarPredicateLess< sal_uInt32 >().isLess(lhs, rhs);
+break;
+case TypeClass_HYPER:
+return ScalarPredicateLess< sal_Int64 >().isLess(lhs, rhs);
+break;
+case TypeClass_UNSIGNED_HYPER:
+return ScalarPredicateLess< sal_uInt64 >().isLess(lhs, rhs);
+break;
+case TypeClass_FLOAT:
+return ScalarPredicateLess< float >().isLess(lhs, rhs);
+break;
+case TypeClass_DOUBLE:
+return ScalarPredicateLess< double >().isLess(lhs, rhs);
+break;
+case TypeClass_STRING:
+return StringPredicateLess().isLess(lhs, rhs);
+break;
+case TypeClass_TYPE:
+return TypePredicateLess().isLess(lhs, rhs);
+break;
+case TypeClass_ENUM:
+return EnumPredicateLess( lhs.getValueType() ).isLess(lhs, rhs);
+break;
+case TypeClass_INTERFACE:
+return InterfacePredicateLess().isLess(lhs, rhs);
+break;
+case TypeClass_STRUCT:
+if ( lhs.getValueType().equals( ::cppu::UnoType< Date >::get() ) )
+return DatePredicateLess().isLess(lhs, rhs);
+else if ( lhs.getValueType().equals( ::cppu::UnoType< Time 
>::get() ) )
+return TimePredicateLess().isLess(lhs, rhs);
+else if ( lhs.getValueType().equals( ::cppu::UnoType< DateTime 
>::get() ) )
+return DateTimePredicateLess().isLess(lhs, rhs);
+break;
+default: ;
+}
+
+// type==VOID
+return false;
 }
 
 } // namespace comphelper
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 136667] Crash when opening file with change tracked floating table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136667

--- Comment #2 from Julien Nabet  ---
Extra gdb info:
(gdb) frame 5
#5  0x7fffd86115c3 in
writerfilter::dmapper::SectionPropertyMap::CloseSectionGroup (this=0x6650480,
rDM_Impl=...) at writerfilter/source/dmapper/PropertyMap.cxx:1413
1413
xCellProperties->getPropertyValue("CellName") >>= sCellName;
(gdb) p xCellProperties
$1 = empty uno::Reference
(gdb) p aValue
$2 = uno::Any(void)
(gdb) p rKey
$3 = "Cell"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136667] Crash when opening file with change tracked floating table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136667

Julien Nabet  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Keywords||haveBacktrace
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136667] Crash when opening file with change tracked floating table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136667

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #1 from Julien Nabet  ---
Created attachment 165388
  --> https://bugs.documentfoundation.org/attachment.cgi?id=165388=edit
bt with debug symbols + some console logs

On pc Debian x86-64 with master sources updated today, I could reproduce this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136667] Crash when opening file with change tracked floating table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136667

NISZ LibreOffice Team  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||2269

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136667] New: Crash when opening file with change tracked floating table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136667

Bug ID: 136667
   Summary: Crash when opening file with change tracked floating
table
   Product: LibreOffice
   Version: 7.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: regression
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: libreoff...@nisz.hu
CC: nem...@numbertext.org

Opening attachment #159750 from bug #132269 started to crash.

Steps to reproduce:
1. Open attachment #159750 

Actual results:
Crash.

Expected results:
File opens.

LibreOffice details:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: ed4f610f4a3de12016f8308a17b6ad4f86e9d67a
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL
(todays nightly)

But not yet in:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 4c20bb789c7536f63a6844a4cb4489a18cee53c7
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL
10 days old from bibisect-7.1

Likely a side effect of
https://cgit.freedesktop.org/libreoffice/core/commit/?id=288db6eb47fbbd2b3ca34ffea0686d8ed8ed9be9

tdf#132271 DOCX: import change tracking in floating tables

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/CppunitTest_sw_core_layout.mk

[Stephan Bergmann (via logerrit)]

 sw/CppunitTest_sw_core_layout.mk |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 1c271e9fdcea1832378995c9c43619290060f378
Author: Stephan Bergmann 
AuthorDate: Fri Sep 11 11:44:25 2020 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Sep 11 12:49:51 2020 +0200

Missing test dependencies

From-scratch `make CppunitTest_sw_core_layout` had failed for me on Linux 
with

> warn:vcl.builder:1528301:1528301:vcl/source/window/builder.cxx:467: 
DBG_UNHANDLED_EXCEPTION in VclBuilder
> when: Unable to read .ui file exception: 
com.sun.star.container.NoSuchElementException message: 
file:///.../instdir/share/config/soffice.cfg/svt/ui/editcontrol.ui 
xmlreader/source/xmlreader.cxx:66

and

> warn:vcl.builder:1529052:1529052:vcl/source/window/builder.cxx:467: 
DBG_UNHANDLED_EXCEPTION in VclBuilder
> when: Unable to read .ui file exception: 
com.sun.star.container.NoSuchElementException message: 
file:///.../instdir/share/config/soffice.cfg/svx/ui/sidebarstylespanel.ui 
xmlreader/source/xmlreader.cxx:66

Change-Id: I021cf45a61a894a88aee64110a9b9ea8f7a20888
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102452
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sw/CppunitTest_sw_core_layout.mk b/sw/CppunitTest_sw_core_layout.mk
index b875fd851053..06f35d4bdc04 100644
--- a/sw/CppunitTest_sw_core_layout.mk
+++ b/sw/CppunitTest_sw_core_layout.mk
@@ -66,6 +66,8 @@ $(eval $(call 
gb_CppunitTest_use_configuration,sw_core_layout))
 
 $(eval $(call gb_CppunitTest_use_uiconfigs,sw_core_layout, \
 modules/swriter \
+svt \
+svx \
 ))
 
 $(eval $(call gb_CppunitTest_use_more_fonts,sw_core_layout))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 136606] XHTML export drops text after 'as character' anchored element (e.g. image, math formula)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136606

Michael Stahl (CIB)  changed:

   What|Removed |Added

 CC||michael.st...@cib.de,
   ||svante.schub...@gmail.com
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #1 from Michael Stahl (CIB)  ---
probably need to cherry-pick XSLT fixes from:

https://github.com/oasis-tcs/odf-tc/pull/29

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127628] Aligning shape with text box causes separation of text box from shape

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127628

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from NISZ LibreOffice Team  ---
(In reply to Cor Nouws from comment #2)
> similar or related to bug 124430

Same problem indeed.

*** This bug has been marked as a duplicate of bug 124430 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118002] Crash in: ntdll.dll saving POTX file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=118002

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sd/source

[Caolán McNamara (via logerrit)]

 sd/source/filter/eppt/eppt.cxx  |2 ++
 sd/source/filter/eppt/pptx-epptbase.cxx |6 ++
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit b7756fdde63b1eef85ef13772fc3578e345d34dc
Author: Caolán McNamara 
AuthorDate: Fri Sep 11 10:04:45 2020 +0100
Commit: Caolán McNamara 
CommitDate: Fri Sep 11 12:38:54 2020 +0200

crashtesting: failed on export of tdf118002-1.potx to pptx

because the bg isn't set a master isn't exported, so
the endelement XML_sldMasterIdLst isn't exported and
the document is broken

so don't exit early if the propertyset isn't found and always call
ImplWriteSlideMaster

Modify the ppt variant PPTWriter::ImplWriteSlideMaster to do nothing on an
empty propertyset allowing PowerPointExport:ImplWriteSlideMaster to
output its XML_sldMasterIdLst on the last master

Change-Id: I512ee10b3b3c80b6566827d708b737c6c502c3b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102451
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sd/source/filter/eppt/eppt.cxx b/sd/source/filter/eppt/eppt.cxx
index 26f0dae9f234..5c1f9da7d7af 100644
--- a/sd/source/filter/eppt/eppt.cxx
+++ b/sd/source/filter/eppt/eppt.cxx
@@ -361,6 +361,8 @@ void PPTWriter::ImplWriteSlide( sal_uInt32 nPageNum, 
sal_uInt32 nMasterNum, sal_
 
 void PPTWriter::ImplWriteSlideMaster( sal_uInt32 nPageNum, Reference< 
XPropertySet > const & aXBackgroundPropSet )
 {
+if (!aXBackgroundPropSet)
+return;
 mpPptEscherEx->PtReplaceOrInsert( EPP_Persist_MainMaster | nPageNum, 
mpStrm->Tell() );
 mpPptEscherEx->OpenContainer( EPP_MainMaster );
 mpPptEscherEx->AddAtom( 24, EPP_SlideAtom, 2 );
diff --git a/sd/source/filter/eppt/pptx-epptbase.cxx 
b/sd/source/filter/eppt/pptx-epptbase.cxx
index 0f9975e7ce67..38015a654e09 100644
--- a/sd/source/filter/eppt/pptx-epptbase.cxx
+++ b/sd/source/filter/eppt/pptx-epptbase.cxx
@@ -388,11 +388,9 @@ bool PPTWriterBase::CreateSlideMaster( sal_uInt32 nPageNum 
)
 return false;
 SetCurrentStyleSheet( nPageNum );
 
-if ( !ImplGetPropertyValue( mXPagePropSet, "Background" ) )
// load background shape
-return false;
 css::uno::Reference< css::beans::XPropertySet > aXBackgroundPropSet;
-if ( !( mAny >>= aXBackgroundPropSet ) )
-return false;
+if (ImplGetPropertyValue(mXPagePropSet, "Background"))// 
load background shape
+mAny >>= aXBackgroundPropSet;
 
 ImplWriteSlideMaster( nPageNum, aXBackgroundPropSet );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 118002] Crash in: ntdll.dll saving POTX file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=118002

--- Comment #13 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b7756fdde63b1eef85ef13772fc3578e345d34dc

crashtesting: failed on export of tdf118002-1.potx to pptx

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/src

[Pedro Pinto Silva (via logerrit)]

 loleaflet/src/control/Control.JSDialogBuilder.js |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit adf8961cd376f5d5cf7424d0c89752a9663d6a42
Author: Pedro Pinto Silva 
AuthorDate: Fri Sep 11 11:07:28 2020 +0200
Commit: Pedro Silva 
CommitDate: Fri Sep 11 12:38:27 2020 +0200

Mobile: set icon for watermark transparency spinfield

Reuse lc_settransparency icon used on objects instead of duplicating file

Change-Id: Iec2393aa43edcf5907f3ae401811414cdb4682f3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102450
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Pedro Silva 

diff --git a/loleaflet/src/control/Control.JSDialogBuilder.js 
b/loleaflet/src/control/Control.JSDialogBuilder.js
index 044d852e5..8be8a1603 100644
--- a/loleaflet/src/control/Control.JSDialogBuilder.js
+++ b/loleaflet/src/control/Control.JSDialogBuilder.js
@@ -46,6 +46,8 @@ L.Control.JSDialogBuilder = L.Control.extend({
builder._fixedtextControl(parentContainer, 
fixedTextData, builder);
}
 
+   console.debug('baseSpinField: ' + data.id);
+
var div = L.DomUtil.create('div', 'spinfieldcontainer', 
parentContainer);
div.id = data.id;
controls['container'] = div;
@@ -53,7 +55,7 @@ L.Control.JSDialogBuilder = L.Control.extend({
var commandName = data.id ? 
data.id.substring('.uno:'.length) : data.id;
if (commandName && commandName.length && 
L.LOUtil.existsIconForCommand(commandName, builder.map.getDocType())) {
var image = L.DomUtil.create('img', 
'spinfieldimage', div);
-   var icon = builder._createIconURL(data.id);
+   var icon = (data.id === 'Transparency') ? 
builder._createIconURL('settransparency') : builder._createIconURL(data.id);
image.src = icon;
icon.alt = '';
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Tibor Nagy (via logerrit)]

 sw/source/core/layout/anchoreddrawobject.cxx |   12 +---
 1 file changed, 9 insertions(+), 3 deletions(-)

New commits:
commit f10ec80efd4d3437dae40748189e2ca942dc5754
Author: Tibor Nagy 
AuthorDate: Fri Sep 11 10:57:44 2020 +0200
Commit: Mike Kaganski 
CommitDate: Fri Sep 11 12:32:36 2020 +0200

Clean-up of commit I29af97001954ad353a386164b68cd22f6230e3e5

Change-Id: I1963a5d899da2d122e60c4d87ca32aba4fb1f32a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102449
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sw/source/core/layout/anchoreddrawobject.cxx 
b/sw/source/core/layout/anchoreddrawobject.cxx
index 0d7a8658b46e..81f5e6aa495b 100644
--- a/sw/source/core/layout/anchoreddrawobject.cxx
+++ b/sw/source/core/layout/anchoreddrawobject.cxx
@@ -682,9 +682,15 @@ SwRect SwAnchoredDrawObject::GetObjBoundRect() const
 nTargetWidth = nWidth * (*GetDrawObj( )->GetRelativeWidth());
 }
 
-auto pObjCustomShape = dynamic_cast(GetDrawObj());
-long nTargetHeight = aCurrObjRect.GetHeight( );
-if ( GetDrawObj( )->GetRelativeHeight( ) && (!pObjCustomShape || 
!pObjCustomShape->IsAutoGrowHeight()) )
+bool bCheck = GetDrawObj()->GetRelativeHeight();
+if (bCheck)
+{
+auto pObjCustomShape = dynamic_cast(GetDrawObj());
+bCheck = !pObjCustomShape || !pObjCustomShape->IsAutoGrowHeight();
+}
+
+long nTargetHeight = aCurrObjRect.GetHeight();
+if (bCheck)
 {
 long nHeight = 0;
 if (GetDrawObj()->GetRelativeHeightRelation() == 
text::RelOrientation::FRAME)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 136651] LO installed from .deb file should tell user if there is a new version available.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136651

--- Comment #3 from prabesh...@gmail.com  ---
(In reply to prabesh...@gmail.com from comment #2)
> Currently I have

LibreOffice 7.0.1.2 installed from Snap repo. 
I went to LO Writer > Tools > Options > Libre Office and I see a lot of
sub-options like:

User Data
General
View
Print
Paths
Fonts
Security
Personalization
Application Colors
Accessibility
Advanced
OpenCL

Where exactly can I see the option which says "Check for updates
automatically"? Do I have to install the LO.deb package in order to see that
option?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136651] LO installed from .deb file should tell user if there is a new version available.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136651

prabesh...@gmail.com  changed:

   What|Removed |Added

Version|7.0.0.3 release |7.0.1.2 release

--- Comment #2 from prabesh...@gmail.com  ---
Currently I have

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136663] Strange gap occurring between Korean characters and Numerals / Latin characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136663

--- Comment #4 from Geon Park  ---
I don't think there will be any Korean users who wants this feature anyway.
Maybe another option would be to exclude Korean characters from the set of
"Asian" characters to apply this feature on?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136663] Strange gap occurring between Korean characters and Numerals / Latin characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136663

--- Comment #3 from Geon Park  ---
I confirmed that works. Then, is it possible to disable this feature when the
text language is set to Korean? This feature is very annoying to Korean users,
and it is very hard to find the option to disable it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 59309] One cell containing text in a string of addends causes calc to return #VALUE!.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=59309

b.  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|INVALID |---

--- Comment #5 from b.  ---
did i miss re-opening? or did someone re-close?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122829] FILESAVE DOCX Images load as cropped when there are many large ones with captions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122829

NISZ LibreOffice Team  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||579

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96579] [WRITER] Figure caption badly converted in Word format because image anchoring and wrapping is changed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96579

NISZ LibreOffice Team  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||2829

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121831] Low raster quality when saving SVG as PNG to DOC(X)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121831

NISZ LibreOffice Team  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=51
   ||510

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51510] FILESAVE: Exporting documents with embedded SVG to doc or docx converts the image to low-resolution pixel graphics

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=51510

NISZ LibreOffice Team  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||1831

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104431] FILEOPEN DOCX Image in header positioned incorrectly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104431

NISZ LibreOffice Team  changed:

   What|Removed |Added

  Component|filters and storage |Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136613] FILEOPEN: Images have incorrect position

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136613

Attila Bakos (NISZ)  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |bakos.attilakar...@nisz.hu
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136588] FILEOPEN: DOCX: incorrect line break

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136588

Attila Bakos (NISZ)  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |bakos.attilakar...@nisz.hu
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135324] FILESAVE DOCX: Image and figure caption overlap

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135324

Attila Bakos (NISZ)  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |bakos.attilakar...@nisz.hu
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131540] FILESAVE DOCX OLE object anchored to page moves on saving

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131540

Attila Bakos (NISZ)  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |bakos.attilakar...@nisz.hu
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Caolán McNamara (via logerrit)]

 sw/source/filter/ww8/ww8par.cxx  |4 ++--
 sw/source/filter/ww8/ww8par2.cxx |6 +++---
 sw/source/filter/ww8/ww8par6.cxx |4 ++--
 sw/source/filter/ww8/ww8scan.cxx |   34 +-
 sw/source/filter/ww8/ww8scan.hxx |8 
 5 files changed, 28 insertions(+), 28 deletions(-)

New commits:
commit bcf1917a0934417226d2357b514df398129a7fab
Author: Caolán McNamara 
AuthorDate: Thu Sep 10 20:44:21 2020 +0100
Commit: Caolán McNamara 
CommitDate: Fri Sep 11 11:10:14 2020 +0200

ofz#25553 Infinite loop

Change-Id: Ie0ecacb69b1e99ca52abd9038baa176be8383661
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102404
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx
index ba974091c481..31e26eb7e0a7 100644
--- a/sw/source/filter/ww8/ww8par.cxx
+++ b/sw/source/filter/ww8/ww8par.cxx
@@ -6574,13 +6574,13 @@ bool SwMSDffManager::GetOLEStorageName(sal_uInt32 
nOLEId, OUString& rStorageName
 
 if (aDesc.nSprmsLen && aDesc.pMemPos) // Attributes present
 {
-long nLen = aDesc.nSprmsLen;
+auto nLen = aDesc.nSprmsLen;
 const sal_uInt8* pSprm = aDesc.pMemPos;
 
 while (nLen >= 2 && !nPictureId)
 {
 sal_uInt16 nId = aSprmParser.GetSprmId(pSprm);
-sal_uInt16 nSL = aSprmParser.GetSprmSize(nId, 
pSprm, nLen);
+sal_Int32 nSL = aSprmParser.GetSprmSize(nId, 
pSprm, nLen);
 
 if( nLen < nSL )
 break; // Not enough Bytes left
diff --git a/sw/source/filter/ww8/ww8par2.cxx b/sw/source/filter/ww8/ww8par2.cxx
index 6f8f7a49fc8c..292de278ff14 100644
--- a/sw/source/filter/ww8/ww8par2.cxx
+++ b/sw/source/filter/ww8/ww8par2.cxx
@@ -1842,9 +1842,9 @@ WW8TabDesc::WW8TabDesc(SwWW8ImplReader* pIoClass, WW8_CP 
nStartCp) :
 while (aSprmIter.GetSprms() && nullptr != (pParams = 
aSprmIter.GetCurrentParams()))
 {
 sal_uInt16 nId = aSprmIter.GetCurrentId();
-sal_uInt16 nFixedLen = aSprmParser.DistanceToData(nId);
-sal_uInt16 nL = aSprmParser.GetSprmSize(nId, 
aSprmIter.GetSprms(), aSprmIter.GetRemLen());
-sal_uInt16 nLen = nL - nFixedLen;
+sal_Int32 nFixedLen = aSprmParser.DistanceToData(nId);
+sal_Int32 nL = aSprmParser.GetSprmSize(nId, 
aSprmIter.GetSprms(), aSprmIter.GetRemLen());
+sal_Int32 nLen = nL - nFixedLen;
 wwTableSprm eSprm = GetTableSprm(nId, 
m_pIo->GetFib().GetFIBVersion());
 switch (eSprm)
 {
diff --git a/sw/source/filter/ww8/ww8par6.cxx b/sw/source/filter/ww8/ww8par6.cxx
index b546cb0ac79c..8d7edf6ac1c8 100644
--- a/sw/source/filter/ww8/ww8par6.cxx
+++ b/sw/source/filter/ww8/ww8par6.cxx
@@ -6103,8 +6103,8 @@ short SwWW8ImplReader::ImportSprm(const sal_uInt8* pPos, 
sal_Int32 nMemLen, sal_
 
 const SprmReadInfo& rSprm = GetSprmReadInfo(nId);
 
-sal_uInt16 nFixedLen = m_xSprmParser->DistanceToData(nId);
-sal_uInt16 nL = m_xSprmParser->GetSprmSize(nId, pPos, nMemLen);
+sal_Int32 nFixedLen = m_xSprmParser->DistanceToData(nId);
+sal_Int32 nL = m_xSprmParser->GetSprmSize(nId, pPos, nMemLen);
 
 if (rSprm.pReadFnc)
 (this->*rSprm.pReadFnc)(nId, pPos + nFixedLen, nL - nFixedLen);
diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index 3efefc1067e5..dfa8fe9d4a5e 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -928,8 +928,8 @@ SprmResult WW8SprmIter::FindSprm(sal_uInt16 nId, bool 
bFindFirst, const sal_uInt
 {
 if (GetCurrentId() == nId)
 {
-sal_uInt16 nFixedLen =  mrSprmParser.DistanceToData(nId);
-sal_uInt16 nL = mrSprmParser.GetSprmSize(nId, GetSprms(), 
GetRemLen());
+sal_Int32 nFixedLen =  mrSprmParser.DistanceToData(nId);
+sal_Int32 nL = mrSprmParser.GetSprmSize(nId, GetSprms(), 
GetRemLen());
 SprmResult aSprmResult(GetCurrentParams(), nL - nFixedLen);
 // typically pNextByteMatch is nullptr and we just return the 
first match
 // very occasionally we want one with a specific following byte
@@ -2981,8 +2981,8 @@ void WW8PLCFx_Fc_FKP::WW8Fkp::HasSprm(sal_uInt16 nId,
 {
 if (aIter.GetCurrentId() == nId)
 {
-sal_uInt16 nFixedLen = maSprmParser.DistanceToData(nId);
-sal_uInt16 nL = maSprmParser.GetSprmSize(nId, aIter.GetSprms(), 
aIter.GetRemLen());
+sal_Int32 nFixedLen = maSprmParser.DistanceToData(nId);
+sal_Int32 nL = maSprmParser.GetSprmSize(nId, aIter.GetSprms(), 
aIter.GetRemLen());
 

[Libreoffice-bugs] [Bug 136645] FILEOPEN: ODT: Incorrect section size

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136645

Xisco Faulí  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #6 from Xisco Faulí  ---
Verified in

Version: 7.1.0.0.alpha0+
Build ID: 3a22f5a589e822e7ca8bbb00e38a3aff93ed7ba5
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Noel, thanks for fixing this issue!!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136666] New: Line numbering: setting for "include header/footer" is not saved with document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=13

Bug ID: 13
   Summary: Line numbering: setting for "include header/footer" is
not saved with document
   Product: LibreOffice
   Version: 7.0.1.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: birnb...@posteo.de

Description:
In a document with activated line numbering, the setting for outputting line
numbers in the header or footer does not get saved with the document. In a
freshly opened document it is always active. 

Turning it off, saving, closing and re-opening the document has the option
turned on again. 



Steps to Reproduce:
1. create document with several lines 
2. create header/footer sections as desired
3. turn on line numbering, deactivating "include header/footer"
   I typically activate options "restart on every page" and 
   "include empty lines". 
   Numbering is numerical and every 5th line is numbered.
4. save and close document
5. re-open document

Actual Results:
1. Option "include header/footer" is set to active
2. A line number "5" is shown in the footer section. 
   This is also true for an empty footer


Expected Results:
1. Option "include header/footer" is set to inactive
2. No line numbers in footer



Reproducible: Always


User Profile Reset: Yes



Additional Info:
This bug was observed in version 6.4.6 and before. 
It seemed to not occur in 7.0 but reappeared in 7.0.1.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135487] UI: Color stripe for font color or highlight color is missing (skia)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135487

Ming Hua  changed:

   What|Removed |Added

 CC||ri...@rivalcomp.hu

--- Comment #6 from Ming Hua  ---
*** Bug 136664 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136664] Font color and background color toolbar buttons don't show the actual color settings

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136664

Ming Hua  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||ming.v@qq.com
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from Ming Hua  ---
Thanks for reporting.  This issue has been reported as bug 135487 and fixed for
the upcoming 7.0.2 release, so I'm marking this as a DUPLICATE.

Meanwhile, if you want to workaround this problem in 7.0.1, you can try
disabling Skia in Tool > Options > LibreOffice > View.

*** This bug has been marked as a duplicate of bug 135487 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136151] LO Does denies me as an administrator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136151

alainfrench...@gmail.com  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from alainfrench...@gmail.com  ---
[SOLVED]
After I have done a lot of research on this problem, it appears that it was my
AVAST anti ransom app that was causing problem, not being compatible with OOo &
LOo programs.

It did not even sorted it out when I authorized OOo & LOo apps in Avast.
I had to remove all documents & photos (IE all files) from their check.
This is very strange and I believe that other users could be fooled into that.
It si also very strange that OOo & LOo are subject to be blocked as an app by
Avast and surely somebody from the development should look into that ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs