date:20201004

[Libreoffice-bugs] [Bug 137256] New: Software not working

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137256

Bug ID: 137256
   Summary: Software not working
   Product: LibreOffice
   Version: 3.3.0 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android Editor
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: prakashd1...@outlook.com

Description:
 Crash if I open the Print dialog and click the 'Options' tab 

Actual Results:
hdgc

Expected Results:
jdvkdjv


Reproducible: Always


User Profile Reset: No



Additional Info:
sdfklbj

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: configure.ac

2020-10-04 Thread Tor Lillqvist (via logerrit)

 configure.ac |   26 ++
 1 file changed, 18 insertions(+), 8 deletions(-)

New commits:
commit e55f3e286283bc0570a6c4f396df952a812ceaef
Author: Tor Lillqvist 
AuthorDate: Sun Oct 4 22:30:46 2020 +0300
Commit: Tor Lillqvist 
CommitDate: Mon Oct 5 07:31:49 2020 +0200

Small cleanup of shell functions

Use "local" for local variables. Document the (global) variables used
to return values.

Change-Id: Iadb567af9e19a627da616f05a5dc650af1c070de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103926
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 

diff --git a/configure.ac b/configure.ac
index 7993b60cdab1..255410b50063 100644
--- a/configure.ac
+++ b/configure.ac
@@ -43,6 +43,8 @@ LO_PATH= # used by path_munge to construct a PATH variable
 
 FilterLibs()
 {
+# Return value: $filteredlibs
+
 filteredlibs=
 for f in $1; do
 case "$f" in
@@ -132,7 +134,11 @@ AbsolutePath()
 # There appears to be no simple and portable method to get an absolute and
 # canonical path, so we try creating the directory if does not exist and
 # utilizing the shell and pwd.
-rel="$1"
+
+# Args: $1: A possibly relative pathname
+# Return value: $absolute_path
+
+local rel="$1"
 absolute_path=""
 test ! -e "$rel" && mkdir -p "$rel"
 if test -d "$rel" ; then
@@ -344,11 +350,11 @@ fi
 
 win_short_path_for_make()
 {
-local_short_path="$1"
+local short_path="$1"
 if test "$GNUMAKE_WIN_NATIVE" = "TRUE" ; then
-cygpath -sm "$local_short_path"
+cygpath -sm "$short_path"
 else
-cygpath -u "$(cygpath -d "$local_short_path")"
+cygpath -u "$(cygpath -d "$short_path")"
 fi
 }
 
@@ -2579,6 +2585,7 @@ dnl 
===
 
 pathmunge ()
 {
+local new_path
 if test -n "$1"; then
 if test "$build_os" = "cygwin"; then
 if test "$GNUMAKE_WIN_NATIVE" = "TRUE" ; then
@@ -2596,7 +2603,6 @@ pathmunge ()
 else
 add_lopath_before "$new_path"
 fi
-unset new_path
 fi
 }
 
@@ -5893,8 +5899,6 @@ find_al()
 return
 fi
 done
-
-
 }
 
 find_dotnetsdk46()
@@ -5976,8 +5980,12 @@ find_winsdk()
 
 find_msms()
 {
+# Return value: $msmdir
+
 AC_MSG_CHECKING([for MSVC merge modules directory])
-my_msm_files=Microsoft_VC${VCVER}_CRT_x86.msm
+local my_msm_files=Microsoft_VC${VCVER}_CRT_x86.msm
+local my_msm_dir
+
 case "$VCVER" in
 160)
 my_msm_files="Microsoft_VC141_CRT_x86.msm Microsoft_VC142_CRT_x86.msm 
${my_msm_files}"
@@ -6048,6 +6056,8 @@ find_msms()
 
 find_msvc_x64_dlls()
 {
+# Return value: $msvcdllpath, $msvcdlls
+
 AC_MSG_CHECKING([for MSVC x64 DLL path])
 msvcdllpath="$VC_PRODUCT_DIR/redist/x64/Microsoft.VC${VCVER}.CRT"
 case "$VCVER" in
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 123079] Libreoffice leave tmp files in with new version

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=123079

--- Comment #6 from Gaurav Arora  ---
I tried change proposed in comment 4 of `if (eStage == SECOND_INIT)` by Mike by
compiling libreoffice locally with lloconv.

But it doesn't solves the issue. It still leaves the temporary file behind. 



Another thing, we noticed while working on this was temporary files is left
behind only during pre-initialisation. When the same instance of LibreOfficeKit
libreoffice is reutilized, it doesn't leave temporary folder for each processed
file. Just a single temporary folder is created and not cleaned up.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135230] Save Document Dialog Doesn't Allow Keyboard Shortcut

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=135230

Buovjaga  changed:

   What|Removed |Added

 Ever confirmed|1   |0
   Keywords|bibisectRequest, regression |
 Status|NEW |UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83734] EDITING: Cropped image gets distorted when Compress Graphic is used

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=83734

dainius.mazu...@gmail.com changed:

   What|Removed |Added

Version|4.1.6.2 release |7.0.1.2 release

--- Comment #29 from dainius.mazu...@gmail.com ---
The same occurring in v7.0.1.2 (2020-10-05), Win 10 x64. Kind of important bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137255] Crash: when press Design button on sidebar , after writer document was imported from Calc. (experimental feature)

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137255

--- Comment #1 from sawakaze  ---
Created attachment 166075
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166075=edit
ScreenCast

if my description is uncleared on report, please see screencast.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137255] New: Crash: when press Design button on sidebar , after writer document was imported from Calc. (experimental feature)

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137255

Bug ID: 137255
   Summary: Crash: when press Design button on sidebar , after
writer document was imported from Calc. (experimental
feature)
   Product: LibreOffice
   Version: 7.0.1.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: souichi...@gmail.com

Description:
On experimental feature is "Enable", after following steps, application
crashed.

if my description is uncleared, please see screencast.

Steps to Reproduce:
1. Enable experimental feature to ON (Tools > Options > Advanced > Optional
Features)
--> restart libreoffice.

2.open Calc
3.Insert > Object > OLE Object
--> Popup Insert OLE Object Window

4. Select Create new and Libreoffice Text 
5. Press OK
--> Insert writer document.
6. Double click inserted object
--> Change writer UI
7. press Design button on sidebar

Actual Results:
after step7, application crash
not open Design property widget

Note: after press "Manege change" button on sidebar, I confirmed application
crash, too.  

Expected Results:
not crash
open property


Reproducible: Always


User Profile Reset: Yes



Additional Info:
I confirm this version

Version: 7.0.2.1
Build ID: ede20268f3f8777cdf69e0281835d320c41213fc
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (C); UI: en-US
Calc: threaded

OS Ubuntu Mate 20.04

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Nikhil Varghese's license statement

2020-10-04 Thread Nikhil varghese

All of my past and future contributions to LibreOffice may be licensed
under the MPLv2/LGPLv3+ dual license.

-- 
Nikhil Varghese
   Github 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 136893] Basic-IDE - [File][Save] vs [File][Export Basic] - some characters replaced by ? [Export Basic]

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=136893

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130282] Calc Chart is not showing correct - Regression in 6.4

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130282

--- Comment #7 from QA Administrators  ---
Dear mail,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131187] Insert -> Object -> QR Code missing on installation, no access to QR Code generator

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131187

--- Comment #6 from QA Administrators  ---
Dear päde,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129572] Issues with OLE Embedding of Excel Workbooks

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=129572

--- Comment #4 from QA Administrators  ---
Dear Paul Connacher,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131806] Add type of paper in page style (for autoselect tray by printer)

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131806

--- Comment #2 from QA Administrators  ---
Dear Sergey S. Betke,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131187] Insert -> Object -> QR Code missing on installation, no access to QR Code generator

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131187

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90134] EDITING: Undo after dragging (cut and paste) selection from document to comment does not remove pasted text from comment

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=90134

--- Comment #7 from QA Administrators  ---
Dear Gordo,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131962] Software closed if I want to insert cover

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131962

--- Comment #2 from QA Administrators  ---
Dear Jean-Claude BARRÉ,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131777] Document is corrupted when saved with password

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131777

--- Comment #3 from QA Administrators  ---
Dear jeanlucwatter,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137254] New: Unable to save previously password protected calc file as new file and without password

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137254

Bug ID: 137254
   Summary: Unable to save previously password protected calc file
as new file and without password
   Product: LibreOffice
   Version: 7.0.0.3 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tony.y...@aol.com

Description:
Checked on Fedora 32 after unpuck rpm package LibreOffice ver. 7.0.0.3 also
checked on distro Q4OS using appimage with same version 7.0.0.3.
I have couple calc files which i saved with password. After reopening them with
correct password and trying to "save as" them with new name / or re-save with
same name but without password it doesn't work as it should, as when trying to
open newly created file or re-saved one it ask for password again. I checked
old libre office ver. 6.4 and i see that check box option "Save with password"
already selected when i am trying to re-save file without password and just
need to unselect it (on ver.7.0.0.3 all checkboxes unchecked all the time i
choose "Save as"). Files i was working with were saved in XLSX format

Steps to Reproduce:
1.Create new Calc file and save it with password as XLSX file. Close file.
2.Re-open that file and using "Save as" save as new file without selecting
"Save with password. 
3.Try to open newly saved file.

Actual Results:
On opening it will ask again for password

Expected Results:
Should not ask for password


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137253] New: Once a sound file is used in a slide show it won't work in another slide show.

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137253

Bug ID: 137253
   Summary: Once a sound file is used in a slide show it won't
work in another slide show.
   Product: LibreOffice
   Version: 6.3.4.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tenpen...@yahoo.com

Description:
I need to be able to use the same audio file name in every weekly slide show. 
At present I have to rename it and I'm running out of names.  My Church uses a
song called Doxolgy.wav every week but it won't play once it has been used. 
Therefore I am forced to rename every time.  Is there a way to reuse or delete
previously used names.  

Steps to Reproduce:
1.create slides 
2.add an outside  music file to transitions
3.Display slides.
4 Create another slide show
5 add an the music file from step 2 above
6 Display slides

Actual Results:
The second time through the slides the music will not play even if the file is
present in the folder in which the slide show is contained

Expected Results:
One would expect that once a music file is used or added to the list it should
play when added to another slide show.  


Reproducible: Always


User Profile Reset: No



Additional Info:
I have upgraded from version 4 up and the problem has been there for a long
time.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137252] Libre Office Base can't open mdb 2000 and mdb 2002/2003 files

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137252

--- Comment #2 from heine.ferre...@gmail.com ---
Created attachment 166074
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166074=edit
Access 2000 mdb

Sample Access 2000 mdb with data.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137252] Libre Office Base can't open mdb 2000 and mdb 2002/2003 files

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137252

--- Comment #1 from heine.ferre...@gmail.com ---
Created attachment 166073
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166073=edit
Access 2002/2003 mdb

Sample Access 2002/2003 test database.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137252] New: Libre Office Base can't open mdb 2000 and mdb 2002/2003 files

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137252

Bug ID: 137252
   Summary: Libre Office Base can't open mdb 2000 and mdb
2002/2003 files
   Product: LibreOffice
   Version: 7.0.1.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: heine.ferre...@gmail.com

Description:
Access ACCDB files saved as MDB files won't open in Libre Office Base.

Steps to Reproduce:
Take an Access 365 database and save it as an Access 2002/2003 mdb database or
an Access 2000 mdb database. Take the new mdb databases and try to open them in
Libre Office base using the "Access" driver. It crashes when you click on
finish. The original Access 365 accdb database does open with the Access 2007
driver. The mdb database contains only one table with 3 records. There is one
autoinc field as the first field and the second field is a text field. For
simplicity sake I just captured 3 peoples names into the 3 records with the
text field.

Actual Results:
Libre Office Base crashes when you click on finish.

Expected Results:
Libre Office Base is suppose to open the database and display it.


Reproducible: Always


User Profile Reset: No



Additional Info:
Latest version of office 365. Latest version of windows 10 64 bit prof. Latest
Libre Office for windows. I am attaching the mdb 2002/2003 file and the mdb
2000 file.
Both won't open. They open perfectly in Access 365. I also tried other tools.
Both files open perfectly in MDB Viewer Plus and DBeaver. MDB Viewer is a
freeware tool and DBeaver is an open source tool. DBeaver does however prompt
you to install the access drivers and it only opens the files once the drivers
are installed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137246] Calc Data Validity. Error Message UI Error

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137246

mrei  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
Version|6.4.6.2 release |6.3.6.2 release

--- Comment #2 from mrei  ---
Reproducible on 6.3.6 High Sierra

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137251] New: Crash in: dbaccess::ODatabaseDocument::storeToRecoveryFile

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137251

Bug ID: 137251
   Summary: Crash in:
dbaccess::ODatabaseDocument::storeToRecoveryFile
   Product: LibreOffice
   Version: 7.0.1.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ro...@rogerdcook.com

Created attachment 166072
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166072=edit
Spreadsheet I was editing when the crash occurred.

This bug was filed from the crash reporting server and is
br-f3b0867b-c27c-4197-90ab-a66bfb535f8d.
=

I was editing both a Firebird DB and an XLS (not XLSX) spreadsheet. I noticed
that the CPU usage was high on one of the base threads, so I clicked the X in
the upper right to close it. It asked to save. I confirmed, and then it
crashed. I can attach the XLS file I was using.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137235] Find and replace does not work on arabic style numbers 1, 2, 3

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137235

--- Comment #3 from Dave  ---
I imported the txt file into an empty LO file. LO of course immediately changed
it to an odt file. That is OK. But I have very little ability to change things,
I really want to change the numbers to bold with a parenthesis and bring far
left. Maybe it the previous formatting? You guys know more about this and what
the LO can do. Please email if you need more info.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137235] Find and replace does not work on arabic style numbers 1, 2, 3

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137235

Dave  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2020-10-04 Thread Bjoern Michaelsen (via logerrit)

 sw/source/core/crsr/bookmrk.cxx |7 ---
 sw/source/core/inc/bookmrk.hxx  |2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)

New commits:
commit 10f32207a3eb6295dcea4f1d2cdf30bc4c4098e9
Author: Bjoern Michaelsen 
AuthorDate: Sun Sep 20 12:04:37 2020 +0200
Commit: Bjoern Michaelsen 
CommitDate: Mon Oct 5 00:38:06 2020 +0200

MarkBase: Replace Modify with SwClientNotify

Change-Id: I15661c979c25d3d9fd47d9885183b972f0ae88ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103067
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen 

diff --git a/sw/source/core/crsr/bookmrk.cxx b/sw/source/core/crsr/bookmrk.cxx
index c918ec28917e..fd339f583ee1 100644
--- a/sw/source/core/crsr/bookmrk.cxx
+++ b/sw/source/core/crsr/bookmrk.cxx
@@ -340,10 +340,11 @@ namespace sw::mark
 }
 }
 
-void MarkBase::Modify( const SfxPoolItem *pOld, const SfxPoolItem *pNew )
+void MarkBase::SwClientNotify(const SwModify&, const SfxHint& rHint)
 {
-NotifyClients(pOld, pNew);
-if (pOld && (RES_REMOVE_UNO_OBJECT == pOld->Which()))
+CallSwClientNotify(rHint);
+auto pLegacy = dynamic_cast();
+if(pLegacy && RES_REMOVE_UNO_OBJECT == pLegacy->GetWhich())
 {   // invalidate cached uno object
 SetXBookmark(uno::Reference(nullptr));
 }
diff --git a/sw/source/core/inc/bookmrk.hxx b/sw/source/core/inc/bookmrk.hxx
index c9dce3e0a328..766791f772e1 100644
--- a/sw/source/core/inc/bookmrk.hxx
+++ b/sw/source/core/inc/bookmrk.hxx
@@ -105,7 +105,7 @@ namespace sw::mark {
 
 protected:
 // SwClient
-virtual void Modify( const SfxPoolItem* pOld, const SfxPoolItem 
*pNew ) override;
+virtual void SwClientNotify(const SwModify&, const SfxHint&) 
override;
 
 MarkBase(const SwPaM& rPaM, const OUString& rName);
 std::unique_ptr m_pPos1;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103182

Terrence Enger  changed:

   What|Removed |Added

 Depends on||137250


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=137250
[Bug 137250] with gtk3, keyboard ineffective in Format > Page > Page > Paper
Format
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137235] Find and replace does not work on arabic style numbers 1, 2, 3

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137235

--- Comment #2 from Dave  ---
Created attachment 166071
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166071=edit
This is what I am working with. See the verse numbers? Very inconsistant. Also
the space between each verse needs to go. This is what I started with :
https://ccel.org/ccel/b/bible/c1/cache/c1.txt

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137250] with gtk3, keyboard ineffective in Format > Page > Page > Paper Format

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137250

Terrence Enger  changed:

   What|Removed |Added

 Blocks||103182


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103182
[Bug 103182] [META] GTK3-specific bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86174] logic error with mod() and int() function

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=86174

b.  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|NOTABUG |---
 Ever confirmed|0   |1

--- Comment #4 from b.  ---
besides ... 50299 is! resolved / fixed ...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137250] New: with gtk3, keyboard ineffective in Format > Page > Page > Paper Format

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137250

Bug ID: 137250
   Summary: with gtk3, keyboard ineffective in Format > Page >
Page > Paper Format
   Product: LibreOffice
   Version: 7.1.0.0.alpha0+ Master
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lo_b...@iseries-guru.com

STR
---

( 1) Start Calc with SAL_USE_VCLPLUGIN=gtk3

( 2) Take menu options Format > Page.  Program presents dialog "Page
 Style: Default Page"

( 3) Click tab Page.  Program shows "Paper Format": Format = A4,
 Width = 21.00 cm, Height = 29.70 cm.

( 4) Type "+F".  Program outlines the form type control showing A4.

( 5) Type "L".  The form type control shows Letter, but still
 Width = 21.00 and Height = 29.70 cm.

( 6) Click button .  Program returns focus to Calc window; the
 document-modified flag in status bar is set (amber down-arrow).

( 7) Take menu options Format > Page.  Program presents dialog "Page
 Style: Default Page", tab Page.

 Expected :  "Paper Format" > Format = Letter

 Observed :  "Paper Format" > Format = A4

For comparison, continuing on in the tab Page, this works:

( 8) In the paper format control, click on the down arrow to expand
 the list of paper formats.

( 9) Click form type Letter.  Program shows: Format = Letter,
 Width = 21.59 cm, Height = 27.94 cm.

(10) Click button .  Program returns focus to Calc window.

(11) Take menu options Format > Page.  Program presents dialog "Page
 Style: Default Page", tab Page with "Paper Format" >
 Format = Letter.

The behaviour in Writer is similar.  However, with
SAL_USE_VCLPLUGIN=gen, I do not see this problem in either
application.


I see this is on a local build of commit f266feae (2020-10-03), built
and running on debian-buster with a new user profile, configured:

--with-vendor=Terrence Enger
--with-jdk-home=/usr/lib/jvm/default-java
--enable-split-debug
--enable-gdb-index
--enable-ld=gold
--enable-option-checking=fatal
#--enable-dbgutil
--enable-debug
--without-system-postgresql
--without-myspell-dicts
--with-extra-buildid
--without-doxygen
--with-external-tar=/home/terry/lo_hacking/git/src
--without-package-format

I cannot make the problem happen with the latest version in
bibisect-linux-64-7.1.  I do not know what the difference is.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86174] logic error with mod() and int() function

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=86174

b.  changed:

   What|Removed |Added

 CC||newbie...@gmx.de

--- Comment #3 from b.  ---
Created attachment 166070
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166070=edit
sample_that_correct_math_is_possible_in_calc

@m.a.riosv: 

disagree ... see attached sheet, 

hardware limitation? no, weak, but doesn't forbid meaningful calculations, 

kohei: 

'So it's a hardware problem.' - the software is responsible for what it does
with the hardware, 

'Anything we try to do at software level would be hacky and prone to other,
more serious errors,' - anything? really anything??? who gives up can no longer
win,  

'including significant performance impact.' - si, but hardware and performance
improve steadily, this statement is 8 years old, thus outdated by a performance
factor of 16, 

'IMO we should leave this alone.' - imho not, users won't let us alone with
their correct questions about incorrect results, 

math is an exact science - tries to be - we should try to keep up ... 

this bug is! a bug as the result is mathematically incorrect, and it is! a bug
as better results are possible, see attachement,

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137151] The break to paragraph (being a line) or linked to paragraph content

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137151

Telesto  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu

--- Comment #9 from Telesto  ---
@Aron
Would like to now your (UX) opinion this.. As this touches the same area as bug
120469 (the index 0) topic in some way. Except it's a 'feature' here (if you
ask me) and copy/paste (or cut/paste) is broken.. Heiko has an different
opinion.. Or we are speaking a different language and we simply don't
understand each other and we are in need of translator.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 137151] The break to paragraph (being a line) or linked to paragraph content

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137151

Telesto  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu

--- Comment #9 from Telesto  ---
@Aron
Would like to now your (UX) opinion this.. As this touches the same area as bug
120469 (the index 0) topic in some way. Except it's a 'feature' here (if you
ask me) and copy/paste (or cut/paste) is broken.. Heiko has an different
opinion.. Or we are speaking a different language and we simply don't
understand each other and we are in need of translator.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 137151] The break to paragraph (being a line) or linked to paragraph content

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137151

--- Comment #8 from Telesto  ---
Bug 120469 comment 1 explains the cause of difference between 'enter' and copy
(Mike Kaganski) 

Well - technically you are not moving the paragraph, but split the existing
one, creating *a new following paragraph* with the contents from previous...
thus it's strictly speaking correct that all paragraph anchors continue to
point to the paragraph object that has lost its content, but not its
identity...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 137151] The break to paragraph (being a line) or linked to paragraph content

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137151

--- Comment #8 from Telesto  ---
Bug 120469 comment 1 explains the cause of difference between 'enter' and copy
(Mike Kaganski) 

Well - technically you are not moving the paragraph, but split the existing
one, creating *a new following paragraph* with the contents from previous...
thus it's strictly speaking correct that all paragraph anchors continue to
point to the paragraph object that has lost its content, but not its
identity...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 137249] New: Dashes not replaced by autocorrect

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137249

Bug ID: 137249
   Summary: Dashes not replaced by autocorrect
   Product: LibreOffice
   Version: 6.4.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Dashes not replaced by autocorrect

Steps to Reproduce:
1. Open Writer
2. Hold 
3. Press Enter

Actual Results:
Dashes still present

Expected Results:
Dashes replaced by line


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 7f16cabf00daa30e9284d2fb2494bd341352c25e
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: threaded

and with
Version: 7.0.0.0.beta1+ (x64)
Build ID: 2891e91a513520d68ea2b8c59c14335861a15253
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

also with
6.4 -> but odd, based on bug 137245

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67026] [LOCALHELP] Limitations in Calc precision need to be documented

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=67026

--- Comment #18 from b.  ---

@Andrew: 

'if cell A1 is loaded with a number with limited decimals (say 15,02) and cell
B1 has a value of 10,02 I should expect to always get A1+B1=25.04 and not
25.039. My main beef is that both numbers are inputed and not
calculated (so I KNOW they have ONLY two decimal places) and thus output should
be ALWAYS on two decimal places.'

for theese values it works in recent LO versions, but there are some numbers
which produce irritating results, 

i had the same idea and tried if it is possible to implement 'smart rounding'
... it is ... it is slow, as done with the tools available to me (user macros),
but ... it works, 

perhaps you'd like to test, and perhaps sometimes somebody will implement
something similar or better in code, 

it doesn't help for very precise numbers with lots of digits, but i'd bet that
about 70 percent of numerical data hold and calculated in spreadsheets are
financial data with 2 or max three decimals, 

and that more than 95 percent of the complaints about wrong calculations in
spreadsheets result from users who didn't expect wx,yz99~ values for their
money, 

you find a version of my tests in
http://bugs.documentfoundation.org/attachment.cgi?id=165435, or in
http://bugs.documentfoundation.org/attachment.cgi?id=165424, 'SUM_S' doe's a
calculation and smart rounding of two numbers ... 

@Robin: 

which are your 'different results'? couldn't find any in the sample with LO
6.1.6.3 or 7.1.0.0.a0+, or do you mean I10 and J10? they have different display
format, 14 and 16 decimal digits, that's not an issue of calculation but of
user formatting ... 

doesn't say that there are no errors respectively very questionable decisions
how which numbers are processed and displayed (int 16 digits, floats 15, crazy
as producing crazy number sequences), just this sample is OT ... or did i miss
something? 

'Raises an interesting question of how it occurred.' - spreadsheets calculate
with binary 'float' numbers while humans are used to decimals, for many decimal
numbers there is no exact correspondence in the binary system, especially not
with a limited number of bits, so the calculation is done with the closest
value that can be constructed in IEEE 754 float numbers, and also the result is
not! the - often rounded - number that is displayed on the screen, but a binary
value with which calc continues to calculate in the background, thus errors can
add up, 

mostly save: multiplication and division, critical: adding numbers with
different magnitude and subtracting numbers with small difference compared to
their value, special: special functions like like modulus or angle functions
...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137143] Offer a Windows on ARM64 installer

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137143

--- Comment #4 from Jan-Marek Glogowski  ---
So I've updated the Windows build instructions in the wiki for ARM64. I don't
have a fresh install, but my setup just has two entries with ARM64 in the
installed components list:

* MSVC v142 - VS 2019 C++ ARM64 build tools (v14.2x)
* C++ ATL for v142 build tools (ARM64)

The LibreOfficeWinArm64.conf is the same then the LibreOfficeWin64.conf, except
for the architecture.

I tried to build with the new ".NET 5" SDK, which has a native Arm64 build, but
it's very different from the previous ".NET Framework 4.x". Currently I think
it might be the best to offer the clr interface and climaker, based on the x86
version of .NET 4.x. See https://github.com/dotnet/runtime/issues/36699 for
more infos regarding Arm64 .NET.

Current state is at: https://gerrit.libreoffice.org/c/core/+/103933

Nevertheless the config without cli support builds here, like described in the
Windows build instructions in the Wiki. Use LibreOfficeWinArm64.conf and
--with-jdk-home=, and you get a working instdir and
untested MSIs.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: configure.ac

2020-10-04 Thread Jan-Marek Glogowski (via logerrit)

 configure.ac |   25 +
 1 file changed, 17 insertions(+), 8 deletions(-)

New commits:
commit 856ce2a5b64a6f7a1ea3a6ab0ee2bb5932743566
Author: Jan-Marek Glogowski 
AuthorDate: Fri Oct 2 14:56:54 2020 +0200
Commit: Jan-Marek Glogowski 
CommitDate: Sun Oct 4 22:18:54 2020 +0200

Don't forward JDK home option to the cross-build

The configure flags on the command line always specify the host
config, so it doesn't make any sense to forward this setting in
case of a cross build. You can add a --with-jdk-home=... to the
--with-build-platform-configure-options flags, if the build
config finds the wrong build JDK. Also add this info to the
--with-jdk-home help.

For convenience (and because I don't want to adapt tinderboxes
again), this forwards the host JDK to the build for Android. And
explicitly disables Java for iOS build tools, as it used to be.

The whole --with-java handling should probably be removed in
favour of the --with-jdk-home. Do we have a real use case, where
we just need the Java interpreter but not the JDK (ok - the
document validators come to mind, but then you could also just
simply provide a JDK...)?

Change-Id: I328a15c090001bb025f4ba66d13b0cd020991fa9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103878
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/configure.ac b/configure.ac
index 700ca2908b2c..7993b60cdab1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2120,7 +2120,9 @@ AC_ARG_WITH(jdk-home,
 AS_HELP_STRING([--with-jdk-home=],
 [If you have installed JDK 9 or later on your system please supply the
  path here. Note that this is not the location of the java command but 
the
- location of the entire distribution.]),
+ location of the entire distribution. In case of cross-compiling, this
+ is the JDK of the host os. Use --with-build-platform-configure-options
+ to point to a different build platform JDK.]),
 ,)
 
 AC_ARG_WITH(help,
@@ -4967,24 +4969,31 @@ if test "$cross_compiling" = "yes"; then
 fi
 test -n "$PKG_CONFIG_FOR_BUILD" && export 
PKG_CONFIG="$PKG_CONFIG_FOR_BUILD"
 cd CONF-FOR-BUILD
+
 sub_conf_opts=""
 test -n "$enable_ccache" && sub_conf_opts="$sub_conf_opts 
--enable-ccache=$enable_ccache"
 test -n "$with_ant_home" && sub_conf_opts="$sub_conf_opts 
--with-ant-home=$with_ant_home"
 test "$with_junit" = "no" && sub_conf_opts="$sub_conf_opts --without-junit"
 if test -n "$ENABLE_JAVA"; then
-if test "$_os" != "iOS" -a "$_os" != "Android"; then
-if ! echo "$with_build_platform_configure_options" | grep -q -- 
'--with-jdk-home='; then
-AC_MSG_ERROR([Missing build JDK (see 
--with-build-platform-configure-options, --with-jdk-home and use 'cygpath -ms' 
on Windows)!])
-fi
-else
+case "$_os" in
+iOS) sub_conf_opts="$sub_conf_opts --without-java" ;; # force it off, 
like it used to be
+Android)
+# Hack for Android - the build doesn't need a host JDK, so just 
forward to build for convenience
 test -n "$with_jdk_home" && sub_conf_opts="$sub_conf_opts 
--with-jdk-home=$with_jdk_home"
-fi
+;;
+*)
+if test -z "$with_jdk_home"; then
+AC_MSG_ERROR([Missing host JDK! This can't be detected for the 
build OS, so you have to specify it with --with-jdk-home.])
+fi
+;;
+esac
 else
 sub_conf_opts="$sub_conf_opts --without-java"
 fi
 test -n "$TARFILE_LOCATION" && sub_conf_opts="$sub_conf_opts 
--with-external-tar=$TARFILE_LOCATION"
 test "$with_system_icu_for_build" = "yes" -o "$with_system_icu_for_build" 
= "force" && sub_conf_opts="$sub_conf_opts --with-system-icu"
 sub_conf_opts="$sub_conf_opts $with_build_platform_configure_options"
+
 # Don't bother having configure look for stuff not needed for the build 
platform anyway
 ./configure \
 --build="$build_alias" \
@@ -7863,11 +7872,11 @@ if test "$ENABLE_JAVA" != "" -a "$cross_compiling" != 
"yes"; then
 JAVA_CLASSPATH_NOT_SET=TRUE
 fi
 
-AC_MSG_RESULT([found (JDK $_jdk)])
 JAVA_HOME=`echo $JAVAINTERPRETER | $SED -n "s,//*bin//*java,,p"`
 if test "$_os" = "WINNT"; then
 JAVA_HOME=`echo $JAVA_HOME | $SED "s,\.[[eE]][[xX]][[eE]]$,,"`
 fi
+AC_MSG_RESULT([found $JAVA_HOME (JDK $_jdk)])
 
 # set to limit VM usage for JunitTests
 JAVAIFLAGS=-Xmx64M
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Fwd: A "normal" client interface.

2020-10-04 Thread Jan-Marek Glogowski

Am 04.10.20 um 20:51 schrieb Stef Bon:
>> I guess the hard part of this is that nextcloud and others don't
>> actually have access to the document, just tiles of it, i.e. bitmaps.
> 
> I know that. Thats the way to access a document while keeping it on
> the server: only a tile
> or a window.

You're misunderstanding the concept of "tile" in this context. Here a
tile is a part of an image, which displays parts of the LO online UI and
the the document. Just open the web-dev tools of your preferred browser
and you can see the document part of the "website" is split into a bunch
of squares in the browser: the tiles.

So yes, LO runs as a server and instead of rendering output to some
graphics hardware, it renders output to images / tiles. Very simplified,
your input (mouse, keyboard) is send to the LO server by the browser and
then LO sends new images to the browser with the changes. It's a bit
like a glorious, interactive HTML image map on steroids.

JMG

P.S. AFAIK some parts of the UI is JavaScript and additional images and
really runs in the browser, but not the document.
P.P.S FWIW: LO also runs as a "server" when you start it on your
machine: https://en.wikipedia.org/wiki/Universal_Network_Objects
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: ucb/Library_srtrs1.mk ucb/Library_ucphier1.mk ucb/Library_ucptdoc1.mk ucb/source xmloff/source

2020-10-04 Thread Mike Kaganski (via logerrit)

 ucb/Library_srtrs1.mk  |1 
 ucb/Library_ucphier1.mk|1 
 ucb/Library_ucptdoc1.mk|1 
 ucb/source/core/ucbstore.cxx   |4 -
 ucb/source/sorter/sortresult.cxx   |8 +--
 ucb/source/ucp/file/bc.cxx |8 +--
 ucb/source/ucp/hierarchy/hierarchydata.cxx |   46 -
 ucb/source/ucp/tdoc/tdoc_content.cxx   |   62 ++---
 ucb/source/ucp/tdoc/tdoc_docmgr.cxx|8 +--
 ucb/source/ucp/tdoc/tdoc_provider.cxx  |   40 +-
 ucb/source/ucp/tdoc/tdoc_stgelems.cxx  |8 +--
 xmloff/source/draw/animimp.cxx |3 -
 12 files changed, 93 insertions(+), 97 deletions(-)

New commits:
commit 83e445cd2d6b59845a330e990aa56c027f8fa85e
Author: Mike Kaganski 
AuthorDate: Sun Oct 4 22:03:46 2020 +0300
Commit: Mike Kaganski 
CommitDate: Sun Oct 4 22:12:16 2020 +0200

use more TOOLS_WARN_EXCEPTION

Change-Id: I269f88d82680f6a969a8bf582f0ae00cc7636509
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103925
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/ucb/Library_srtrs1.mk b/ucb/Library_srtrs1.mk
index 6ceffd3cc685..c04647907bf0 100644
--- a/ucb/Library_srtrs1.mk
+++ b/ucb/Library_srtrs1.mk
@@ -21,6 +21,7 @@ $(eval $(call gb_Library_use_libraries,srtrs1,\
cppu \
cppuhelper \
sal \
+   tl \
ucbhelper \
 ))
 
diff --git a/ucb/Library_ucphier1.mk b/ucb/Library_ucphier1.mk
index 27406f7a9b3c..3a0a0fa32e99 100644
--- a/ucb/Library_ucphier1.mk
+++ b/ucb/Library_ucphier1.mk
@@ -22,6 +22,7 @@ $(eval $(call gb_Library_use_libraries,ucphier1,\
cppuhelper \
sal \
salhelper \
+   tl \
ucbhelper \
 ))
 
diff --git a/ucb/Library_ucptdoc1.mk b/ucb/Library_ucptdoc1.mk
index 5dc25f3d0229..b04e43beabac 100644
--- a/ucb/Library_ucptdoc1.mk
+++ b/ucb/Library_ucptdoc1.mk
@@ -20,6 +20,7 @@ $(eval $(call gb_Library_use_libraries,ucptdoc1,\
cppuhelper \
sal \
salhelper \
+   tl \
ucbhelper \
 ))
 
diff --git a/ucb/source/core/ucbstore.cxx b/ucb/source/core/ucbstore.cxx
index 1ee882ff18d4..7db0b7925e02 100644
--- a/ucb/source/core/ucbstore.cxx
+++ b/ucb/source/core/ucbstore.cxx
@@ -27,7 +27,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -958,7 +958,7 @@ Reference< XInterface > 
PropertySetRegistry::getRootConfigReadAccess()
 {
 // createInstance, createInstanceWithArguments
 
-OSL_FAIL( "PropertySetRegistry::getRootConfigReadAccess - caught 
Exception!" );
+TOOLS_WARN_EXCEPTION("ucb", "");
 return Reference< XInterface >();
 }
 
diff --git a/ucb/source/sorter/sortresult.cxx b/ucb/source/sorter/sortresult.cxx
index 4c7814164457..bbf471a8b317 100644
--- a/ucb/source/sorter/sortresult.cxx
+++ b/ucb/source/sorter/sortresult.cxx
@@ -29,7 +29,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 
 using namespace com::sun::star::beans;
@@ -1284,7 +1284,7 @@ void SortedResultSet::Initialize(
 }
 catch (const SQLException&)
 {
-OSL_FAIL( "SortedResultSet::Initialize() : Got unexpected 
SQLException" );
+TOOLS_WARN_EXCEPTION("ucb", "");
 }
 
 // when we have fetched all the elements, we can create the
@@ -1632,7 +1632,7 @@ void SortedResultSet::ResortModified( EventList* pList )
 }
 catch (const SQLException&)
 {
-OSL_FAIL( "SortedResultSet::ResortModified() : Got unexpected 
SQLException" );
+TOOLS_WARN_EXCEPTION("ucb", "");
 }
 
 m_ModList.clear();
@@ -1665,7 +1665,7 @@ void SortedResultSet::ResortNew( EventList* pList )
 }
 catch (const SQLException&)
 {
-OSL_FAIL( "SortedResultSet::ResortNew() : Got unexpected SQLException" 
);
+TOOLS_WARN_EXCEPTION("ucb", "");
 }
 }
 
diff --git a/ucb/source/ucp/file/bc.cxx b/ucb/source/ucp/file/bc.cxx
index ef34e6a8150f..4d0a7b26fc3e 100644
--- a/ucb/source/ucp/file/bc.cxx
+++ b/ucb/source/ucp/file/bc.cxx
@@ -20,7 +20,7 @@
 #include 
 #include 
 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -419,7 +419,7 @@ BaseContent::getContentType()
 }
 catch (const sdbc::SQLException&)
 {
-OSL_FAIL( "BaseContent::getContentType - Caught SQLException!" 
);
+TOOLS_WARN_EXCEPTION("ucb.ucp.file", "");
 }
 }
 }
@@ -532,7 +532,7 @@ BaseContent::createNewContent( const ContentInfo& Info )
 }
 catch (const sdbc::SQLException&)
 {
-OSL_FAIL( "BaseContent::createNewContent - Caught SQLException!" );
+TOOLS_WARN_EXCEPTION("ucb.ucp.file", "");
 return Reference< XContent >();
 }
 
@@ -1031,7 +1031,7 @@ void BaseContent::insert( sal_Int32 nMyCommandIdentifier,
 }
 catch (const sdbc::SQLException&)
 {
-OSL_FAIL(

[Libreoffice-bugs] [Bug 76047] FILESAVE: Links to external data not preserved for XLSX

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=76047

--- Comment #45 from egc  ---
(In reply to Julien Nabet from comment #44)

> The pb here is you expect the same support for LO which is released freely
> by TDF than you'd expect from Microsoft for MsOffice which you must pay for.

I was talking about other open source bug tracking systems, not Microsoft or
so, i don't even know those bug tracking systems. But it's ok ...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: filter/source include/sal

2020-10-04 Thread Mike Kaganski (via logerrit)

 filter/source/msfilter/msoleexp.cxx  |5 ++-
 filter/source/xmlfilterdetect/filterdetect.cxx   |4 +--
 filter/source/xsltdialog/typedetectionexport.cxx |8 +++---
 filter/source/xsltdialog/typedetectionimport.cxx |4 +--
 filter/source/xsltdialog/xmlfilterjar.cxx|9 +++---
 filter/source/xsltdialog/xmlfiltersettingsdialog.cxx |   25 +--
 filter/source/xsltdialog/xmlfiltertabdialog.cxx  |5 ++-
 filter/source/xsltdialog/xmlfiltertestdialog.cxx |   15 ++-
 include/sal/log-areas.dox|1 
 9 files changed, 41 insertions(+), 35 deletions(-)

New commits:
commit 6923b1d527fa86fac8439b881d4ad468b765e915
Author: Mike Kaganski 
AuthorDate: Sun Oct 4 09:37:15 2020 +0300
Commit: Mike Kaganski 
CommitDate: Sun Oct 4 21:27:07 2020 +0200

use more TOOLS_WARN_EXCEPTION

Change-Id: Iff30468e59a0bc782958dd41bcea726a4c869698
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103909
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/filter/source/msfilter/msoleexp.cxx 
b/filter/source/msfilter/msoleexp.cxx
index a6e31ad8fb91..da109342b6c9 100644
--- a/filter/source/msfilter/msoleexp.cxx
+++ b/filter/source/msfilter/msoleexp.cxx
@@ -30,12 +30,12 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -250,7 +250,8 @@ void SvxMSExportOLEObjects::ExportOLEObject( 
svt::EmbeddedObjectRef const & rObj
 }
 catch( const uno::Exception& )
 {
-OSL_FAIL( "Unexpected exception while getting visual 
area size!" );
+TOOLS_WARN_EXCEPTION(
+"filter.ms", "Unexpected exception while getting 
visual area size!");
 aSize.Width = 5000;
 aSize.Height = 5000;
 }
diff --git a/filter/source/xmlfilterdetect/filterdetect.cxx 
b/filter/source/xmlfilterdetect/filterdetect.cxx
index b588fbc62a80..fd179a0e7898 100644
--- a/filter/source/xmlfilterdetect/filterdetect.cxx
+++ b/filter/source/xmlfilterdetect/filterdetect.cxx
@@ -18,12 +18,12 @@
  */
 
 #include "filterdetect.hxx"
-#include 
 #include 
 #include 
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -197,7 +197,7 @@ OUString SAL_CALL FilterDetect::detect( css::uno::Sequence< 
css::beans::Property
 }
 catch (const Exception &)
 {
-OSL_FAIL( "An Exception occurred while opening File stream" );
+TOOLS_WARN_EXCEPTION("filter.xmlfd", "An Exception occurred while 
opening File stream");
 }
 
 if (!sTypeName.isEmpty())
diff --git a/filter/source/xsltdialog/typedetectionexport.cxx 
b/filter/source/xsltdialog/typedetectionexport.cxx
index 692f1347230e..68ed95a065e5 100644
--- a/filter/source/xsltdialog/typedetectionexport.cxx
+++ b/filter/source/xsltdialog/typedetectionexport.cxx
@@ -22,7 +22,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 
 #include "typedetectionexport.hxx"
 #include "xmlfiltercommon.hxx"
@@ -197,7 +197,7 @@ void TypeDetectionExporter::doExport( const Reference< 
XOutputStream >& xOS,  co
 }
 catch( const Exception& )
 {
-OSL_FAIL( "TypeDetectionExporter::doExport exception caught!" );
+TOOLS_WARN_EXCEPTION("filter.xslt", "");
 }
 }
 
@@ -227,7 +227,7 @@ void TypeDetectionExporter::addProperty( const Reference< 
XWriter >& xHandler, c
 }
 catch( const Exception& )
 {
-OSL_FAIL( "TypeDetectionExporter::addProperty exception caught!" );
+TOOLS_WARN_EXCEPTION("filter.xslt", "");
 }
 }
 
@@ -258,7 +258,7 @@ void TypeDetectionExporter::addLocaleProperty( const 
Reference< XWriter >& xHand
 }
 catch( const Exception& )
 {
-OSL_FAIL( "TypeDetectionExporter::addLocaleProperty exception caught!" 
);
+TOOLS_WARN_EXCEPTION("filter.xslt", "");
 }
 }
 
diff --git a/filter/source/xsltdialog/typedetectionimport.cxx 
b/filter/source/xsltdialog/typedetectionimport.cxx
index 76dfeb54d250..4d785ec152a7 100644
--- a/filter/source/xsltdialog/typedetectionimport.cxx
+++ b/filter/source/xsltdialog/typedetectionimport.cxx
@@ -20,7 +20,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 
 #include "typedetectionimport.hxx"
 #include "xmlfiltercommon.hxx"
@@ -62,7 +62,7 @@ void TypeDetectionImporter::doImport( const Reference< 
XComponentContext >& rxCo
 }
 catch( const Exception& /* e */ )
 {
-OSL_FAIL( "TypeDetectionImporter::doImport exception caught!" );
+TOOLS_WARN_EXCEPTION("filter.xslt", "");
 }
 }
 
diff --git a/filter/source/xsltdialog/xmlfilterjar.cxx 
b/filter/source/xsltdialog/xmlfilterjar.cxx
index 4bf9f156c535..3ddaed0df05c 100644
--- a/filter/source/xsltdialog/xmlfilterjar.cxx
+++ b/filter/source/xsltdialog/xmlfilterjar.cxx
@@

[Libreoffice-bugs] [Bug 89069] FILESAVE: HTML output removes bold/italic from open-quote characters

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=89069

--- Comment #11 from Rev. Bob  ---
Bug still exists in LibreOffice Portable 7.0.1.2 under Windows 10 (32-bit).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: autogen.sh

2020-10-04 Thread Tor Lillqvist (via logerrit)

 autogen.sh |   12 
 1 file changed, 12 insertions(+)

New commits:
commit d1b399b687193951978500056ce461a921575d3e
Author: Tor Lillqvist 
AuthorDate: Sun Oct 4 19:07:41 2020 +0300
Commit: Tor Lillqvist 
CommitDate: Sun Oct 4 21:16:22 2020 +0200

Step towards building for Windows on WSL: ProgramFiles(x86) handling

autogen.sh is a Perl script. When running Perl on WSL, weirdly named
environment variables like the "ProgramFiles(x86)" one don't seem to
get imported to a shell child process of the Perl process. So export
it as PROGRAMFILESX86 instead. configure.ac will look for that on WSL.
(Changes to configure.ac will be coming in small careful steps.)

Change-Id: I572c3b1e2f2fab3629d1856d33fcf0dda51217d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103921
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 

diff --git a/autogen.sh b/autogen.sh
index 49835ff27e25..beda712747ce 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -296,6 +296,18 @@ if (defined $ENV{NOCONFIGURE}) {
 push @args, "--enable-option-checking=$option_checking";
 
 print "Running ./configure with '" . join (" ", @args), "'\n";
+
+# When running a shell script from Perl on WSL, weirdly named
+# environment variables like the "ProgramFiles(x86)" one don't get
+# imported by the shell. So export it as PROGRAMFILESX86 instead.
+if (`wslsys 2>/dev/null` ne "") {
+if (!$ENV{"ProgramFiles(x86)"}) {
+print STDERR "To build on WSL, you need to set the WSLENV 
environment variable in the Control Panel to 'ProgramFiles(x86)'\n";
+exit (1);
+}
+$ENV{"PROGRAMFILESX86"} = $ENV{"ProgramFiles(x86)"};
+}
+
 system ("./configure", @args) && die "Error running configure";
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: configure.ac

2020-10-04 Thread Jan-Marek Glogowski (via logerrit)

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b36df65bb2393f8f46eea68c861d7570e7a772a1
Author: Jan-Marek Glogowski 
AuthorDate: Sun Oct 4 20:08:57 2020 +0200
Commit: Jan-Marek Glogowski 
CommitDate: Sun Oct 4 21:11:03 2020 +0200

skia: don't fail Windows Arm64 build without clang

Since commit 77ba9a095b0b3f429e006571e16f8320ba0bb61e we build
Windows Arm64 with Skia, but since there is no clang compiler for
Arm64 in VS2019, we use the normal MSVC one. So don't even try
to detect it currently.

Change-Id: I1e82a1a92bce3b8f52fe24e3095ab6e70a7a1256
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103924
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/configure.ac b/configure.ac
index a781b4ecd222..700ca2908b2c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -11480,7 +11480,7 @@ CLANG_CXXFLAGS_INTRINSICS_AVX512=
 CLANG_CXXFLAGS_INTRINSICS_F16C=
 CLANG_CXXFLAGS_INTRINSICS_FMA=
 
-if test "$ENABLE_SKIA" = TRUE -a "$COM_IS_CLANG" != TRUE; then
+if test "$ENABLE_SKIA" = TRUE -a "$COM_IS_CLANG" != TRUE -a ! \( "$_os" = 
"WINNT" -a "$CPUNAME" = "ARM64" \); then
 if test -n "$CLANG_CC" -a -n "$CLANG_CXX"; then
 AC_MSG_CHECKING([for Clang])
 AC_MSG_RESULT([$CLANG_CC / $CLANG_CXX])
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 137247] Unable to detach embedded font from base form when editing one

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137247

Julien Nabet  changed:

   What|Removed |Added

Summary|Unable to detach embedded   |Unable to detach embedded
   |font from base form when|font from base form when
   |edditing one|editing one

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Fwd: A "normal" client interface.

2020-10-04 Thread Stef Bon

-- Forwarded message -
Van: Stef Bon 
Date: vr 2 okt. 2020 om 19:51
Subject: Re: A "normal" client interface.
To: Miklos Vajna 

Hi,
Op vr 2 okt. 2020 om 09:26 schreef Miklos Vajna :
>
> Hi Stef,
>
>
> I guess the hard part of this is that nextcloud and others don't
> actually have access to the document, just tiles of it, i.e. bitmaps.

I know that. Thats the way to access a document while keeping it on
the server: only a tile
or a window.

And is it possible to explain why these (nextcloud ea) only get bitmaps.
That's not something like a text, which you can edit and send back.
Are you sure bitmaps are used.
For example how can you change the font in a bitmap. It's a image
format, not a text format.

> This architecture has benefits like "your documents never leave the
> server" and also that there are ~no edit conflicts, but has costs like
> very hard integration with an existing running server.

Yes that a document stays on the server is great. No edit conflicts
are there only
when the server supports "locking" of a part/tile/window of the document.
(like: others can view your tile at most, but cannot edit, and two
tiles of different users can not overlap)

Huh? I do not understand what you say. What existing running server.
You mean libreoffice, but then running as server?

Stef
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 135370] LO does not refresh screen with Skia/Vulkan and nVidia cards

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=135370

--- Comment #28 from mv...@gmx.net ---
For some reason blacklisting doesn't work for me with os="windows". I am
running Windows 10. If I modify skia_blacklist_vulkan.xml to 



then Vulkan is disabled.

By the way, a note regarding the bug itself. 
I noticed if I do a 'minimize all' by clicking the small area at the right end
of the Windows 10 taskbar and then restore the Libreoffice window, then the
document window does not freeze, no matter how many times I try. 
If I minimize the Libreoffice window by clicking the "_" on the window itself
and then restore it, it freezes at the first try.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/inc sw/source

2020-10-04 Thread Caolán McNamara (via logerrit)

 sw/inc/editsh.hxx   |2 +-
 sw/inc/numrule.hxx  |2 +-
 sw/inc/unostyle.hxx |2 +-
 sw/source/core/doc/number.cxx   |   12 ++--
 sw/source/core/edit/edglss.cxx  |   24 +++-
 sw/source/core/frmedt/fecopy.cxx|2 +-
 sw/source/core/sw3io/swacorr.cxx|2 +-
 sw/source/core/unocore/unostyle.cxx |   24 
 8 files changed, 34 insertions(+), 36 deletions(-)

New commits:
commit ffbc494b2a139eabf062432f5b4fed3a4ce46382
Author: Caolán McNamara 
AuthorDate: Sun Oct 4 17:31:47 2020 +0100
Commit: Caolán McNamara 
CommitDate: Sun Oct 4 20:42:50 2020 +0200

SwXAutoStylesEnumerator always dereferences its SwDoc* arg

ditto:
SwNumFormat::UpdateNumNodes
SwEditShell::CopySelToDoc

Change-Id: I5f18b04e420facb703fcace20c645281d409cea6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103923
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/inc/editsh.hxx b/sw/inc/editsh.hxx
index 66226bc40d5a..b5d0068bd86a 100644
--- a/sw/inc/editsh.hxx
+++ b/sw/inc/editsh.hxx
@@ -200,7 +200,7 @@ public:
If table is copied into table, move all cursors away from it.
Copy and Paste must be in FEShell because of FlyFrames!
Copy all selections to the document. */
-bool CopySelToDoc( SwDoc* pInsDoc );
+bool CopySelToDoc( SwDoc& rInsDoc );
 
 void SplitNode( bool bAutoFormat = false, bool bCheckTableStart = true );
 bool AppendTextNode();
diff --git a/sw/inc/numrule.hxx b/sw/inc/numrule.hxx
index 4da44bbd8ced..84f2bfba5426 100644
--- a/sw/inc/numrule.hxx
+++ b/sw/inc/numrule.hxx
@@ -52,7 +52,7 @@ class SW_DLLPUBLIC SwNumFormat final : public 
SvxNumberFormat, public SwClient
 std::unique_ptr m_pVertOrient;
 //For i120928,record the cp info of graphic within bullet
 sal_Unicode m_cGrfBulletCP;
-SAL_DLLPRIVATE void UpdateNumNodes( SwDoc* pDoc );
+SAL_DLLPRIVATE void UpdateNumNodes(SwDoc& rDoc);
 
 using SvxNumberFormat::operator ==;
 using SvxNumberFormat::operator !=;
diff --git a/sw/inc/unostyle.hxx b/sw/inc/unostyle.hxx
index 2b29d2aa6729..0b40d1e73249 100644
--- a/sw/inc/unostyle.hxx
+++ b/sw/inc/unostyle.hxx
@@ -158,7 +158,7 @@ class SwXAutoStylesEnumerator final : public 
cppu::WeakImplHelper< css::containe
 {
 std::unique_ptr m_pImpl;
 public:
-SwXAutoStylesEnumerator( SwDoc* pDoc, IStyleAccess::SwAutoStyleFamily eFam 
);
+SwXAutoStylesEnumerator( SwDoc& rDoc, IStyleAccess::SwAutoStyleFamily eFam 
);
 virtual ~SwXAutoStylesEnumerator() override;
 
 //XEnumeration
diff --git a/sw/source/core/doc/number.cxx b/sw/source/core/doc/number.cxx
index 4de390353fdf..5430df621177 100644
--- a/sw/source/core/doc/number.cxx
+++ b/sw/source/core/doc/number.cxx
@@ -293,7 +293,7 @@ void SwNumFormat::Modify( const SfxPoolItem* pOld, const 
SfxPoolItem* pNew )
 }
 
 if( pFormat && !pFormat->GetDoc()->IsInDtor() )
-UpdateNumNodes( const_cast(pFormat->GetDoc()) );
+UpdateNumNodes( *const_cast(pFormat->GetDoc()) );
 else
 CheckRegistration( pOld );
 }
@@ -314,13 +314,13 @@ voidSwNumFormat::SetGraphicBrush( const SvxBrushItem* 
pBrushItem, const Size
 SvxNumberFormat::SetGraphicBrush( pBrushItem, pSize, pOrient);
 }
 
-void SwNumFormat::UpdateNumNodes( SwDoc* pDoc )
+void SwNumFormat::UpdateNumNodes( SwDoc& rDoc )
 {
-bool bDocIsModified = pDoc->getIDocumentState().IsModified();
+bool bDocIsModified = rDoc.getIDocumentState().IsModified();
 bool bFnd = false;
-for( SwNumRuleTable::size_type n = pDoc->GetNumRuleTable().size(); !bFnd 
&& n; )
+for( SwNumRuleTable::size_type n = rDoc.GetNumRuleTable().size(); !bFnd && 
n; )
 {
-const SwNumRule* pRule = pDoc->GetNumRuleTable()[ --n ];
+const SwNumRule* pRule = rDoc.GetNumRuleTable()[ --n ];
 for( sal_uInt8 i = 0; i < MAXLEVEL; ++i )
 if( pRule->GetNumFormat( i ) == this )
 {
@@ -336,7 +336,7 @@ void SwNumFormat::UpdateNumNodes( SwDoc* pDoc )
 }
 
 if( bFnd && !bDocIsModified )
-pDoc->getIDocumentState().ResetModified();
+rDoc.getIDocumentState().ResetModified();
 }
 
 const SwFormatVertOrient*  SwNumFormat::GetGraphicOrientation() const
diff --git a/sw/source/core/edit/edglss.cxx b/sw/source/core/edit/edglss.cxx
index 9ae88459452e..ce1aaecad7a4 100644
--- a/sw/source/core/edit/edglss.cxx
+++ b/sw/source/core/edit/edglss.cxx
@@ -64,7 +64,7 @@ sal_uInt16 SwEditShell::MakeGlossary( SwTextBlocks& rBlks, 
const OUString& rName
 if( rBlks.BeginPutDoc( rShortName, rName ) )
 {
 rBlks.GetDoc()->getIDocumentRedlineAccess().SetRedlineFlags_intern( 
RedlineFlags::DeleteRedlines );
-CopySelToDoc( pGDoc );
+CopySelToDoc(*pGDoc);
 rBlks.GetDoc()->getIDocumentRedlineAccess().SetRedlineFlags_intern( 
RedlineFlags::NONE );
 return rBlks.PutDoc();
 }
@@ -151,11

[Libreoffice-commits] core.git: sw/inc sw/source

2020-10-04 Thread Caolán McNamara (via logerrit)

 sw/inc/numrule.hxx  |2 
 sw/source/core/doc/DocumentContentOperationsManager.cxx |2 
 sw/source/core/doc/docfmt.cxx   |2 
 sw/source/core/doc/number.cxx   |6 -
 sw/source/core/doc/swserv.cxx   |   12 +--
 sw/source/core/inc/mvsave.hxx   |4 -
 sw/source/filter/ascii/parasc.cxx   |   52 
 sw/source/filter/ww8/docxattributeoutput.cxx|2 
 sw/source/filter/ww8/docxtablestyleexport.cxx   |   14 ++--
 sw/source/filter/ww8/docxtablestyleexport.hxx   |2 
 10 files changed, 49 insertions(+), 49 deletions(-)

New commits:
commit 6539ff3f4123a961a949c8d6a5fae8880c3d7081
Author: Caolán McNamara 
AuthorDate: Sun Oct 4 17:18:02 2020 +0100
Commit: Caolán McNamara 
CommitDate: Sun Oct 4 20:42:37 2020 +0200

DocxTableStyleExport never passed a null SwDoc*

ditto:
SwASCIIParser ctor
SwNumRule::CopyNumRule
SwDataChanged ctor

Change-Id: I0f731ef2856eb70bd5fff5372ee7bc769e1f8bd3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103922
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/inc/numrule.hxx b/sw/inc/numrule.hxx
index ae6405424518..4da44bbd8ced 100644
--- a/sw/inc/numrule.hxx
+++ b/sw/inc/numrule.hxx
@@ -214,7 +214,7 @@ public:
 /** A kind of copy-constructor to make sure the num formats are
attached to the correctCharFormats of a document!!
(Copies the NumFormats and returns itself). */
-SwNumRule& CopyNumRule( SwDoc*, const SwNumRule& );
+SwNumRule& CopyNumRule( SwDoc&, const SwNumRule& );
 
 /** Tests whether the CharFormats are from the given doc
and copies them if appropriate. */
diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx 
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index cf697077133f..fe748212d497 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -3120,7 +3120,7 @@ bool DocumentContentOperationsManager::SplitNode( const 
SwPosition , bool b
 {
 // BUG 26675: Send DataChanged before deleting, so that we notice 
which objects are in scope.
 //After that they can be before/after the position.
-SwDataChanged aTmp( _rDoc, rPos );
+SwDataChanged aTmp( m_rDoc, rPos );
 }
 
 SwUndoSplitNode* pUndo = nullptr;
diff --git a/sw/source/core/doc/docfmt.cxx b/sw/source/core/doc/docfmt.cxx
index dbafd42f1856..008f0beea2b2 100644
--- a/sw/source/core/doc/docfmt.cxx
+++ b/sw/source/core/doc/docfmt.cxx
@@ -1581,7 +1581,7 @@ void SwDoc::ReplaceStyles( const SwDoc& rSource, bool 
bIncludePageStyles )
 const SwNumRule& rR = *rArr[ n ];
 SwNumRule* pNew = FindNumRulePtr( rR.GetName());
 if( pNew )
-pNew->CopyNumRule( this, rR );
+pNew->CopyNumRule(*this, rR);
 else
 {
 if( !rR.IsAutoRule() )
diff --git a/sw/source/core/doc/number.cxx b/sw/source/core/doc/number.cxx
index a75c2478320d..4de390353fdf 100644
--- a/sw/source/core/doc/number.cxx
+++ b/sw/source/core/doc/number.cxx
@@ -853,17 +853,17 @@ OUString SwNumRule::MakeParagraphStyleListString() const
 A kind of copy constructor, so that the num formats are attached to the
 right CharFormats of a Document.
 Copies the NumFormats and returns itself. */
-SwNumRule& SwNumRule::CopyNumRule( SwDoc* pDoc, const SwNumRule& rNumRule )
+SwNumRule& SwNumRule::CopyNumRule( SwDoc& rDoc, const SwNumRule& rNumRule )
 {
 for( sal_uInt16 n = 0; n < MAXLEVEL; ++n )
 {
 Set( n, rNumRule.maFormats[ n ].get() );
 if( maFormats[ n ] && maFormats[ n ]->GetCharFormat() &&
-!pDoc->GetCharFormats()->IsAlive(maFormats[n]->GetCharFormat()))
+!rDoc.GetCharFormats()->IsAlive(maFormats[n]->GetCharFormat()))
 {
 // If we copy across different Documents, then copy the
 // corresponding CharFormat into the new Document.
-maFormats[n]->SetCharFormat( pDoc->CopyCharFormat( *maFormats[n]->
+maFormats[n]->SetCharFormat( rDoc.CopyCharFormat( *maFormats[n]->
 GetCharFormat() ) );
 }
 }
diff --git a/sw/source/core/doc/swserv.cxx b/sw/source/core/doc/swserv.cxx
index 100e8b6a3f2c..cc2d3fe5dbf5 100644
--- a/sw/source/core/doc/swserv.cxx
+++ b/sw/source/core/doc/swserv.cxx
@@ -275,13 +275,13 @@ void SwServerObject::SetDdeBookmark( ::sw::mark::IMark& 
rBookmark)
 }
 
 SwDataChanged::SwDataChanged( const SwPaM& rPam )
-: m_pPam(  ), m_pPos( nullptr ), m_pDoc( () )
+: m_pPam(  ), m_pPos( nullptr ), m_rDoc( rPam.GetDoc() )
 {
 m_nContent = rPam.GetPoint()->nContent.GetIndex();
 }
 
-SwDataChanged::SwDataChanged( SwDoc* pDc, const SwPosition&

[Libreoffice-bugs] [Bug 137248] Calc - AutoCalculate malfunction, always F9 (ReCalculate) necessary

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137248

--- Comment #2 from Viktor  ---
Created attachment 166069
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166069=edit
Screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137248] Calc - AutoCalculate malfunction, always F9 (ReCalculate) necessary

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137248

--- Comment #1 from Viktor  ---
Created attachment 166068
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166068=edit
Demo File from Screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137248] New: Calc - AutoCalculate malfunction, always F9 (ReCalculate) necessary

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137248

Bug ID: 137248
   Summary: Calc - AutoCalculate malfunction, always F9
(ReCalculate) necessary
   Product: LibreOffice
   Version: 7.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: so...@web.de

Description:
Problem: Since 7.0.2.x Calc has a problem with the automatic ReCalculation if
contents/values are changed.
Is there a new setting somewhere that can cause this?

In the settings I have already deactivated the automatic recalculation and
reactivated it again incl. restarting LO or the PC. 


See also ASK Libre Post:
https://ask.libreoffice.org/de/question/269302/calc-automatische-berechnung-geht-nicht-mehr/




Actual Results:
critical, because not automatically recalculated

Expected Results:
as in previous version, that all formulas (with activated function) are also
reliably recalculated.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Version: 7.0.2.2 (x64) Build ID: 8349ace3c3162073abd90d81fd06dcfb6b36b994 CPU
threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL

also

Version: 7.1.0.0.alpha0+ (x64)
Build ID: f266feaebea39668392e3a3830e20e4670344658
CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85493] VIEWING: In diagrams, tooltips shown over curve points show information about the wrong point when "Range for Name" cell values are not sorted in ascending order

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=85493

--- Comment #16 from Olivier DESCOUT  ---
I can still reproduce this with LibreOffice 7.0.

Please find below detailed LO version information:

Version: 7.0.1.2 (x64)
Build ID: 7cbcfc562f6eb6708b5ff7d7397325de9e764452
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Vulkan; VCL: win
Locale: fr-FR (fr_FR); Langue IHM : fr-FR
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137229] Tools -> Options -> Online Update -> Crash immediately (libc-2.31.so)

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137229

--- Comment #1 from Uwe Auer  ---
Could not reproduce using

Version: 7.0.1.2, Build ID: 7cbcfc562f6eb6708b5ff7d7397325de9e764452
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: kf5, Locale: de-DE
(de_DE.UTF-8); UI: en-US, Calc: threaded

on Fedora 32, Linux 5.8.10-200.fc32.x86_64 #1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76047] FILESAVE: Links to external data not preserved for XLSX

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=76047

--- Comment #44 from Julien Nabet  ---
(In reply to egc from comment #43)
> (In reply to Julien Nabet from comment #42)
> 
> Yeah right, learning C++ in one or more hours ... for someone who has no
> idea about programming languages ...
I supposed so. Still, you considered the bug is fixable in 15 min with no
programming knowledge or LO code source knowledge... Hope you don't speak the
same way with mechanics, plumber, etc. when you got car or house problems :-)

> 
> Anyway, i realise that i'm in the wrong place here. i always thought a
> bugtracking system (as far as i know them) is a place where normal users can
> find and report bugs to the developers so they fix them (of course, if
> someone of the users is also able to contribute for the fix they can do that
> too, but that's not the case with me)
> but that doesn't seem to be so here.
Take a look here https://cgit.freedesktop.org/libreoffice/core/log/ and you'll
see that most commits which include "tdf#" is a fix (some may be just related
like automatic test to avoid some regression on this part).
So yes the bugtracking system works well for quite some bugs.

> Here i only get advices to fix it myself or to let it fix by the company or
> to get a software developer and fix it ... or to change to another office
> suite ... Great!
In this case yes, nothing wrong here. 
The pb here is you expect the same support for LO which is released freely by
TDF than you'd expect from Microsoft for MsOffice which you must pay for.

> 
> Sorry for wasting your time. Have a good one!
No pb here to discuss here. Have a good day too!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76047] FILESAVE: Links to external data not preserved for XLSX

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=76047

--- Comment #43 from egc  ---
(In reply to Julien Nabet from comment #42)

Yeah right, learning C++ in one or more hours ... for someone who has no idea
about programming languages ...

Anyway, i realise that i'm in the wrong place here. i always thought a
bugtracking system (as far as i know them) is a place where normal users can
find and report bugs to the developers so they fix them (of course, if someone
of the users is also able to contribute for the fix they can do that too, but
that's not the case with me), but that doesn't seem to be so here. Here i only
get advices to fix it myself or to let it fix by the company or to get a
software developer and fix it ... or to change to another office suite ...
Great!

Sorry for wasting your time. Have a good one!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137246] Calc Data Validity. Error Message UI Error

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137246

G  changed:

   What|Removed |Added

 CC||guillermo_...@hotmail.com

--- Comment #1 from G  ---
Created attachment 166066
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166066=edit
Calc Data Validity UI Error

Not a mayor UI Error

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137247] New: Unable to detach embedded font from base form when edditing one

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137247

Bug ID: 137247
   Summary: Unable to detach embedded font from base form when
edditing one
   Product: LibreOffice
   Version: 6.3.5.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philnsi...@hotmail.com

Hi,

I wanted to have the same Look and feel within my base form in windows, mac and
linux as I use the form in all platforms.

I ticked the "Embed font in document" in the properties dialog of base forms.

My base file size was less than 1 Mo and it is now 37 Mo ! What's more, it is
now very slow when saving the file.

I tried different strategies to detach the fonts this :

1. I unticked to detach the fonts but it doesn't work.

2. I unzipped the base file, deleted the embedded fonts and zipped the file
back to ods but then the file is corrupted.

3. I made a copy of the file. And deleted all the forms in the original file.
Then the file size is back to normal (600 Ko). Then I added back the forms one
by one, saving the base file each time. So I identified the form which is 37
Mo. Then I made a copy of a normal form I had, renamed it to the name of the
BigSizeForm, edited it, deleting every control inside, and copied the controls
from the BigSizeForm in the base file copy. I have everything back to normal :
the base file size is 700 Ko and it saves superfastly. So problem solved.

Other than my third step, I don't see a safe way to detach those fonts. There
should at least a warning that you cannot undo it! And it would be better if it
was possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137181] Basic macro: CRASH when running a macro in Impress

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137181

--- Comment #4 from Julien Nabet  ---
I gave a try but the macro stops on line 29 with popup:
"Basic runtime error.
Sub-procedure or function procedure not defined".
(I don't have Rotation function)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137246] New: Calc Data Validity. Error Message UI Error

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137246

Bug ID: 137246
   Summary: Calc Data Validity. Error Message UI Error
   Product: LibreOffice
   Version: 6.4.6.2 release
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: guillermo_...@hotmail.com

Description:
Error Message UI Error.


Steps to Reproduce:
1. On a Column add two values on two rows. Example: CellB1=1.1 & CellB2=1.2
2. On CellA1 create a "Data Validity", with a "Cell range" with Source = B1:B2
3. On CellA1 write "1." (number "1" and a Dot ".") and the hit Option+Down (On
Mac, normally, it will display the list, can't remember how to do it on
Windows) to pick an option. 
4. It will Display the Error Message with the message "Invalid value." and
"OK". But at the same time you have the option to pick the correct option, if
you do, it won't display it on the CellA1, but when you do hit "OK" on the
Error Message it will display the option that you picked.
It is Just an UI error, but an Error is an Error, and it can lead to something
else.

Actual Results:
It work as Almost it should.

Expected Results:
It should not display the Error Message


Reproducible: Always


User Profile Reset: No



Additional Info:
MacBook Pro (Retina, 13-inch, Late 2013)
MacOS Catalina: 10.15.7 (19H2)

LibreOffice
Version: 6.4.6.2
Build ID: 0ce51a4fd21bff07a5c061082cc82c5ed232f115
CPU threads: 4; OS: Mac OS X 10.15.7; UI render: GL; VCL: osx; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80177] PIVOTTABLE: Date format PostgreSQL

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=80177

--- Comment #22 from Julien Nabet  ---
(In reply to philnsicab from comment #21)
> Here on windows 7, libreOffice Version : 6.3.5.2 (x64).
> ...
When retesting, it's more relevant to test with not an EOL version. I mean last
stable one is 6.4.6 and brand new one is 7.0.1. (Don't misunderstand me, I
don't pretend it's already fixed in these last versions, I haven't given a try)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137244] Slowness in changing paragraph properties in Libre Office 7.0.0.3 - found due to the "Template Changer" precisely "template-changer-1.2.7c.oxt" extension

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137244

Clark Freeman  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
Summary|Slowness in changing|Slowness in changing
   |paragraph properties in |paragraph properties in
   |Libre Office 7.0.0.3 -  |Libre Office 7.0.0.3 -
   |found due to the "Template  |found due to the "Template
   |Changer" extension  |Changer" precisely
   ||"template-changer-1.2.7c.ox
   ||t" extension

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 133771] When saving an encrypted document, unchecking 'Save with password' has no effect, encryption is kept

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=133771

--- Comment #21 from Uwe Auer  ---
*** Bug 137237 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137237] FILESAVING WITHOUT PASSWORD

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137237

Uwe Auer  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Uwe Auer  ---


*** This bug has been marked as a duplicate of bug 133771 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137245] New: Image disappears after inserting a horizontal line

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137245

Bug ID: 137245
   Summary: Image disappears after inserting a horizontal line
   Product: LibreOffice
   Version: 6.4.6.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bezv...@gmail.com

Description:
When creating a horizontal line after an image insertion, the line is created
in the paragraph preceding the image, but the image itself is lost.

Steps to Reproduce:
1. In a new document, enter some text
2. Insert an image (Insert -> Image)
3. Write a few dashes and hit Enter
4. The horizontal line is created in the paragraph preceding the image, but the
image itself is lost

Actual Results:
The horizontal line is created in the paragraph preceding the image, but the
image itself is lost.

Expected Results:
Keep the image.


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Version: 6.4.6.2
Build ID: 1:6.4.6-0ubuntu0.20.04.1
CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: gtk3; 
Locale: cs-CZ (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113458] [META] Packaging/installation/removal bugs and enhancements

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113458
Bug 113458 depends on bug 71538, which changed state.

Bug 71538 Summary: Other: make openldap an optional module
https://bugs.documentfoundation.org/show_bug.cgi?id=71538

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71538] Other: make openldap an optional module

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=71538

cj.wijtm...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: oox/source

2020-10-04 Thread Caolán McNamara (via logerrit)

 oox/source/crypto/AgileEngine.cxx |   15 ++-
 1 file changed, 10 insertions(+), 5 deletions(-)

New commits:
commit e11cdf021a1ee7ff95733699e75c35af72c54c69
Author: Caolán McNamara 
AuthorDate: Sun Oct 4 15:00:20 2020 +0100
Commit: Caolán McNamara 
CommitDate: Sun Oct 4 18:02:11 2020 +0200

ofz#26128 check at start instead of end if encryptedHashValue is too small

Change-Id: I10774802c96f6f0912a4ee3bf9a6a2a9482b7c94
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103918
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/oox/source/crypto/AgileEngine.cxx 
b/oox/source/crypto/AgileEngine.cxx
index ad01e31def83..179317510880 100644
--- a/oox/source/crypto/AgileEngine.cxx
+++ b/oox/source/crypto/AgileEngine.cxx
@@ -318,7 +318,13 @@ bool generateBytes(std::vector & rBytes, 
sal_Int32 nSize)
 
 bool AgileEngine::decryptAndCheckVerifierHash(OUString const & rPassword)
 {
-std::vector hashFinal(mInfo.hashSize, 0);
+std::vector& encryptedHashValue = 
mInfo.encryptedVerifierHashValue;
+size_t encryptedHashValueSize = encryptedHashValue.size();
+size_t nHashValueSize = mInfo.hashSize;
+if (nHashValueSize > encryptedHashValueSize)
+return false;
+
+std::vector hashFinal(nHashValueSize, 0);
 calculateHashFinal(rPassword, hashFinal);
 
 std::vector& encryptedHashInput = 
mInfo.encryptedVerifierHashInput;
@@ -327,14 +333,13 @@ bool AgileEngine::decryptAndCheckVerifierHash(OUString 
const & rPassword)
 std::vector hashInput(nSaltSize, 0);
 calculateBlock(constBlock1, hashFinal, encryptedHashInput, hashInput);
 
-std::vector& encryptedHashValue = 
mInfo.encryptedVerifierHashValue;
-std::vector hashValue(encryptedHashValue.size(), 0);
+std::vector hashValue(encryptedHashValueSize, 0);
 calculateBlock(constBlock2, hashFinal, encryptedHashValue, hashValue);
 
-std::vector hash(mInfo.hashSize, 0);
+std::vector hash(nHashValueSize, 0);
 hashCalc(hash, hashInput, mInfo.hashAlgorithm);
 
-return (hash.size() <= hashValue.size() && std::equal(hash.begin(), 
hash.end(), hashValue.begin()));
+return std::equal(hash.begin(), hash.end(), hashValue.begin());
 }
 
 void AgileEngine::decryptEncryptionKey(OUString const & rPassword)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

2020-10-04 Thread Caolán McNamara (via logerrit)

 sw/source/filter/ww8/writerhelper.hxx |2 +
 sw/source/filter/ww8/ww8atr.cxx   |   39 --
 2 files changed, 21 insertions(+), 20 deletions(-)

New commits:
commit 9f81fc25e528406f12cbfa6d56a27b69f9957edd
Author: Caolán McNamara 
AuthorDate: Sun Oct 4 14:16:53 2020 +0100
Commit: Caolán McNamara 
CommitDate: Sun Oct 4 18:01:53 2020 +0200

combine these identical blocks together into a function

Change-Id: I783c7f649d0624de9fb46c2b8379fc47ec311f63
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103917
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/filter/ww8/writerhelper.hxx 
b/sw/source/filter/ww8/writerhelper.hxx
index f9d186ec58df..9ad16d0c2f14 100644
--- a/sw/source/filter/ww8/writerhelper.hxx
+++ b/sw/source/filter/ww8/writerhelper.hxx
@@ -650,6 +650,8 @@ namespace sw
 */
 explicit SetLayer(const SwDoc );
 };
+
+const SwCharFormat* GetSwCharFormat(const SwFormatINetFormat& rINet, 
SwDoc& rDoc);
 }
 
 namespace hack
diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
index 7d2a1c0432d3..d6b0fabe8701 100644
--- a/sw/source/filter/ww8/ww8atr.cxx
+++ b/sw/source/filter/ww8/ww8atr.cxx
@@ -226,22 +226,10 @@ void MSWordExportBase::ExportPoolItemsToCHP( 
ww8::PoolItems , sal_uInt16
  if (pINetItem)
  {
  const SwFormatINetFormat& rINet = static_cast(*pINetItem);
-
- if ( rINet.GetValue().isEmpty() )
+ const SwCharFormat* pINetFormat = GetSwCharFormat(rINet, 
m_rDoc);
+ if (!pINetFormat)
  continue;
 
- const sal_uInt16 nId = rINet.GetINetFormatId();
- const OUString& rStr = rINet.GetINetFormat();
-
- if (rStr.isEmpty())
- {
- OSL_ENSURE( false, 
"MSWordExportBase::ExportPoolItemsToCHP(..) - missing unvisited character 
format at hyperlink attribute" );
- }
-
- const SwCharFormat* pINetFormat = IsPoolUserFormat( nId )
-? m_rDoc.FindCharFormatByName( rStr )
-: 
m_rDoc.getIDocumentStylePoolAccess().GetCharFormatFromPool( nId );
-
  const SwCharFormat* pFormat = static_cast(*pItem).GetCharFormat();
  ww8::PoolItems aCharItems, aINetItems;
  GetPoolItems(pFormat->GetAttrSet(), aCharItems, false);
@@ -1604,10 +1592,12 @@ void WW8AttributeOutput::CharBackground( const 
SvxBrushItem& rBrush )
 m_rWW8Export.InsUInt16( 0x);
 }
 
-void WW8AttributeOutput::TextINetFormat( const SwFormatINetFormat& rINet )
+namespace sw { namespace util {
+
+const SwCharFormat* GetSwCharFormat(const SwFormatINetFormat& rINet, SwDoc& 
rDoc)
 {
-if ( rINet.GetValue().isEmpty() )
-return;
+if (rINet.GetValue().isEmpty())
+return nullptr;
 
 const sal_uInt16 nId = rINet.GetINetFormatId();
 const OUString& rStr = rINet.GetINetFormat();
@@ -1616,9 +1606,18 @@ void WW8AttributeOutput::TextINetFormat( const 
SwFormatINetFormat& rINet )
 OSL_ENSURE( false, "WW8AttributeOutput::TextINetFormat(..) - missing 
unvisited character format at hyperlink attribute" );
 }
 
-const SwCharFormat* pFormat = IsPoolUserFormat( nId )
-? m_rWW8Export.m_rDoc.FindCharFormatByName( rStr )
-: 
m_rWW8Export.m_rDoc.getIDocumentStylePoolAccess().GetCharFormatFromPool( nId );
+return IsPoolUserFormat( nId )
+   ? rDoc.FindCharFormatByName( rStr )
+   : rDoc.getIDocumentStylePoolAccess().GetCharFormatFromPool( nId 
);
+}
+
+} }
+
+void WW8AttributeOutput::TextINetFormat( const SwFormatINetFormat& rINet )
+{
+const SwCharFormat* pFormat = GetSwCharFormat(rINet, m_rWW8Export.m_rDoc);
+if (!pFormat)
+return;
 
 m_rWW8Export.InsUInt16( NS_sprm::CIstd::val );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 137244] New: Slowness in changing paragraph properties in Libre Office 7.0.0.3 - found due to the "Template Changer" extension

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137244

Bug ID: 137244
   Summary: Slowness in changing paragraph properties in Libre
Office 7.0.0.3 - found due to the "Template Changer"
extension
   Product: LibreOffice
   Version: 7.0.0.3 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: zillabu...@gmail.com

Description:
Changing paragraph properties in Libre Office Writer Version: 7.0.0.3 (x64) is
very sluggish. If changing the properties of a number of selected paragraphs at
the same time it even goes non responding a number of times before settling
down, taking a long long time to execute.


Steps to Reproduce:
1.Select a few paragraphs with different settings
2.Bring up the paragraph properties dialog
3.Simply change the indents and observe the slowness of execution or going "not
responding" a number of times. Even clicking into an option window to type
something in it is taking forever (it seems).

Actual Results:
The properties get changed but after minutes of repetitions of "non response"
periods.

Expected Results:
That the properties can be changed in the dialog box within a second or two as
in the previous versions.


Reproducible: Always


User Profile Reset: No



Additional Info:
I restarted LibreOffice in safe mode and the bug was not there. I then checked
which extension was creating the difficulty and I found out that it was the
"Template Changer". Unfortunately I cannot tell you which exact version I had
loaded as I removed it now (disabling it did not work and  was just hanging
up).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2020-10-04 Thread Nikhil (via logerrit)

 sw/source/core/text/atrhndl.hxx |7 ++-
 sw/source/core/text/guess.hxx   |7 +++
 2 files changed, 5 insertions(+), 9 deletions(-)

New commits:
commit 1b6dead4dc7d11fd3d2e1b88da941857cb1be046
Author: Nikhil 
AuthorDate: Sun Oct 4 14:43:23 2020 +0530
Commit: Ilmari Lauhakangas 
CommitDate: Sun Oct 4 17:51:45 2020 +0200

tdf#124176 Use #pragma once in text

Change-Id: I4fd4fb8d232a2b250f1da3b9414d80a284367ec8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103919
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas 

diff --git a/sw/source/core/text/atrhndl.hxx b/sw/source/core/text/atrhndl.hxx
index e391b0825886..1033242492c3 100644
--- a/sw/source/core/text/atrhndl.hxx
+++ b/sw/source/core/text/atrhndl.hxx
@@ -17,9 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_SW_SOURCE_CORE_TEXT_ATRHNDL_HXX
-#define INCLUDED_SW_SOURCE_CORE_TEXT_ATRHNDL_HXX
-
+#pragma once
 #define NUM_ATTRIBUTE_STACKS 44
 
 #include 
@@ -116,6 +114,5 @@ inline const SwFont* SwAttrHandler::GetFont() const
 return m_pFnt.get();
 };
 
-#endif
 
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
\ No newline at end of file
diff --git a/sw/source/core/text/guess.hxx b/sw/source/core/text/guess.hxx
index 5ff7e7474e78..0d9fbb8d2d1c 100644
--- a/sw/source/core/text/guess.hxx
+++ b/sw/source/core/text/guess.hxx
@@ -16,8 +16,8 @@
  *   except in compliance with the License. You may obtain a copy of
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
-#ifndef INCLUDED_SW_SOURCE_CORE_TEXT_GUESS_HXX
-#define INCLUDED_SW_SOURCE_CORE_TEXT_GUESS_HXX
+
+#pragma once
 #include 
 
 #include "porrst.hxx"
@@ -59,6 +59,5 @@ public:
 { return xHyphWord; }
 };
 
-#endif
 
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
\ No newline at end of file
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=124176

--- Comment #127 from Commit Notification 
 ---
Nikhil committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1b6dead4dc7d11fd3d2e1b88da941857cb1be046

tdf#124176 Use #pragma once in text

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80177] PIVOTTABLE: Date format PostgreSQL

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=80177

--- Comment #21 from philnsi...@hotmail.com ---
Here on windows 7, libreOffice Version : 6.3.5.2 (x64).

The bug is still present :

I have a pivot table in calc based on a request and data from an HSQLBD file.
Dates are correctly formatted in my database. I can format them to appear
correctly in the database but as soon as I refresh they appear as numbers
again.

Because of this format bug, the pivot table is unusable. I hope this gets
solved one day...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71538] Other: make openldap an optional module

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=71538

--- Comment #8 from ^m'e  ---
Is this still valid? My latest Gentoo build (`libreoffice-6.4.6.2`) has indeed
no LDAP built in any more ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137241] Unable to backspace over some text (track changes)

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137241

Telesto  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76047] FILESAVE: Links to external data not preserved for XLSX

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=76047

--- Comment #42 from Julien Nabet  ---
(In reply to egc from comment #41)
> (In reply to Julien Nabet from comment #40)
> 
> As i already wrote, an other office package (MS) is already in use by some
> people in the company and at home, so the company for sure is not willing to
> pay for bug fixes in LO.
I had missed this part so no need to stick on LO indeed except if you're a big
supporter of OpenSource.

> I was hoping i could keep both office packages, but with such blocking bugs
> like this one, and for so long time, my arguments for keeping LO in the
> company are go to 0.
The goal of a company is to make money so no surprise here.

> 
> As i said i'm not a software developer so i can not really tell, but i could
> imagine, that this bug is not such a big deal to be fixed by one of the
> programmers of LO. LO just duplicates the external links, so someone would
> just need to have a look at it why this happens, fix that, and that's it. I
> guess it could be done in 15 minutes for someone who knows the code.
So you're not a software dev but "you could imagine it's not a big deal".
What about taking some hours to learn some C++ (after all there are Youtube
videos to learn C++ in 1 or some hours) then give it a try, here's a link to
start with:
https://wiki.documentfoundation.org/Development/GetInvolved
To install needed software and build the code hours, let's suppose some 3/4
hours.
I'm pretty sure that just with a good will, you may submit a fix on gerrit in
some days.
There are also some people of your IT who may contribute. If they already know
how to program (and perhaps how to program in C++) perhaps they may submit a
bugfix in just 2 days?

> 
> But i don't see any will of the LO developers to fix this bug ... People
> continue reporting the same thing since 6 years and nobody in LO seems to
> find it worth to deal with it. This is not just a minor bug, it is a deal
> breaker for a mixed environment with two office packages and more operating
> systems in use.
> That's why i don't understand why none of the programmers is trying to fix
> this bug. I repeat: It is a deal breaker. Not just a little formatting (or
> whatever) bug. 
Consider this:
- take a look at the number of bugs declared in Bugzilla
- there are only about a dozen of expert devs which regularly contribute and in
those, there are some who are quite driven by the company they belong (I mean
they fix the bugs their company indicate wrt what clients paid)
=> it may give you some hints.

>
> So you're right, at the end it will be time consuming for me to convert all
> the calc sheets to Excel and make them work there. This way my effort goes
> actually into MS Office instead of LO ... which is absurd in my eyes ...
It's just your/company choice to not pay LO because they wrongly consider since
it's freely downloadable, you shouldn't pay to fix the bugs.
So stop telling it's just devs fault and see there's also you/your company
fault not willing to contribute in a way (money or programming).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137241] Unable to backspace over some text (track changes)

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137241

Telesto  changed:

   What|Removed |Added

 OS|Linux (All) |All
Summary|Unable to backspace over|Unable to backspace over
   |some text   |some text (track changes)
 CC||tele...@surfxs.nl
   Keywords||bibisectRequest, regression

--- Comment #1 from Telesto  ---
Deleting something pretty hard; repro
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 7f16cabf00daa30e9284d2fb2494bd341352c25e
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

everything still ok in
Version: 6.2.0.0.alpha0+
Build ID: 9d754a59154c40235c240bb0e7f47a2006fa85bd
CPU threads: 4; OS: Windows 6.3; UI render: default; 
Locale: nl-NL (nl_NL); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 134092] Scrolling down freezes Libreoffice caused by image anchored to character depending on zoomfactor

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=134092

Telesto  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #5 from Telesto  ---
(In reply to Dieter from comment #4)
> There are two (more or less identical) images in the document. 

Yes

> You don't differ in your description. 

Relevance? Not sure where you're going here.. It's about 'freezing'
caused/triggered by images.. (probably interacting with each other)

> And how does scrolling depend on zoom factor(see bug summary)?

Scrolling doesn't depend on zoom factor; the freezing does.. On certain
zoomfactors you won't encounter the issue (maybe again different between
versions of LibO)

If you scroll down the whole document hangs.. sometimes you get lucky (and
there is some feedback.. other cases it hangs permanently.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137228] The data could not be loaded completely because the maximum number of columns per sheet was exceeded.

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137228

--- Comment #1 from Uwe Auer  ---
This doesn't seem to be a bug but the limitation to 1024 columns in LibreOffice
while XLSX allows 16384 columns.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137243] New: "Header" for "endnote" style not saved !

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137243

Bug ID: 137243
   Summary: "Header" for "endnote" style not saved !
   Product: LibreOffice
   Version: 7.0.1.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: yousifjka...@yahoo.com

Description:
As the title saying. 
When I tried to add "Header" for the "endnote" page, the changed not saved &
header disappeared after colsing then re-opened the document !

Actual Results:
Should be saved.

Expected Results:
Not saved, & disappear after closing then re-open the document.


Reproducible: Always


User Profile Reset: No



Additional Info:
I'm using flatpak from FlatHub on my Fedora 32 X64 bit Cinnamon edition.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137242] New: "-1" parameter Offset value for footer !

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137242

Bug ID: 137242
   Summary: "-1" parameter Offset value for footer !
   Product: LibreOffice
   Version: 7.0.1.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: yousifjka...@yahoo.com

Description:
I have docx. file composed from 16 pages, a theses. The 1st page is a cover
(title & my name). I like to add page number as footer. I like to start the
count from 2nd page to be numbered as "1" (I mean that I like to leave the
cover not numbered).

Steps to Reproduce:
1. go to inferior sector of page
2. click "add footer"
3. select "format footer" & uncheck "same content on 1st page" then save.
4. select "Insert Page Number", then set Offset at "-1", then add it.
5. save docx. & exit
6. re-open the document.

Actual Results:
when add "Insert Page Number" after set "Offset" to "-1", the numbers started
from 2nd page (leave 1st page "cover") without number & started the number from
2nd page counting it as 1, then to other pages as 3, 4, 5,  as I like very
okay.
But after save changed & closing the docx. file then re-open it the Offset
value revert to default "0" & numbering of page, though started from 2nd page,
but not started by number 1 ! It started from number 2 !

Expected Results:
The numbering of page should remain start from 2nd page as 1, then for next
pages as 2, 3, 4, 5, ..


Reproducible: Always


User Profile Reset: No



Additional Info:
I'm using flatpak package from FlatHub on my Fedora Linux 32 X64 bit Cinnamon
edition.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137181] Basic macro: CRASH when running a macro in Impress

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137181

--- Comment #3 from Frederic Parrenin 
 ---
Created attachment 166065
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166065=edit
.odp file to reproduce the problem

Sorry, my mistake. Here it is.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137231] Calc crashes when going back from cell XFD1 to cell A1048576

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137231

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> ---
It was fixed for master.

*** This bug has been marked as a duplicate of bug 133033 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 133033] CRASH: With Ctrl+Down or Ctrl+A when 'Enable very large spreadsheets' is active

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=133033

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||lino.fiori...@gmail.com

--- Comment #21 from Roman Kuznetsov <79045_79...@mail.ru> ---
*** Bug 137231 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137241] New: Unable to backspace over some text

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137241

Bug ID: 137241
   Summary: Unable to backspace over some text
   Product: LibreOffice
   Version: 6.4.4.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: luke.kend...@gmail.com

Created attachment 166064
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166064=edit
Very short sample document

While editing a document, with record and show changes enabled, I found after
backspacing to delete a period left behind after copying some text elsewhere,
that I could not backspace over it to the characters to its left. It was as if
the deleted period formed a barrier.
I also found that although "Undo delete "."" appeared in the text to the right
of the "Edit: Undo" menu, choosing to Undo had no effect, and that undo item
stayed unchanged.

I have provided a vastly cut down document that for me shows the problem.

Steps to reproduce:

1. Position the cursor immediately to the right of the 2nd period after
"valuable"
2. Attempt to backspace to travel left over the already deleted text and then
to delete characters further to the left
3. The cursor will not move, characters can not be deleted by backspacing.
4. Note the Edit menu item for Undo says Undo: Delete "."
5. Attempt to undo that deletion: nothing happens.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76047] FILESAVE: Links to external data not preserved for XLSX

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=76047

--- Comment #41 from egc  ---
(In reply to Julien Nabet from comment #40)

As i already wrote, an other office package (MS) is already in use by some
people in the company and at home, so the company for sure is not willing to
pay for bug fixes in LO. 
I was hoping i could keep both office packages, but with such blocking bugs
like this one, and for so long time, my arguments for keeping LO in the company
are go to 0.

As i said i'm not a software developer so i can not really tell, but i could
imagine, that this bug is not such a big deal to be fixed by one of the
programmers of LO. LO just duplicates the external links, so someone would just
need to have a look at it why this happens, fix that, and that's it. I guess it
could be done in 15 minutes for someone who knows the code.

But i don't see any will of the LO developers to fix this bug ... People
continue reporting the same thing since 6 years and nobody in LO seems to find
it worth to deal with it. This is not just a minor bug, it is a deal breaker
for a mixed environment with two office packages and more operating systems in
use.
That's why i don't understand why none of the programmers is trying to fix this
bug. I repeat: It is a deal breaker. Not just a little formatting (or whatever)
bug. 

So you're right, at the end it will be time consuming for me to convert all the
calc sheets to Excel and make them work there. This way my effort goes actually
into MS Office instead of LO ... which is absurd in my eyes ...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: extensions/source extensions/test

2020-10-04 Thread Mike Kaganski (via logerrit)

 extensions/source/abpilot/admininvokationimpl.cxx   |5 +++--
 extensions/source/abpilot/datasourcehandling.cxx|   17 +++--
 extensions/source/abpilot/fieldmappingimpl.cxx  |8 +---
 extensions/source/bibliography/datman.cxx   |6 +++---
 extensions/source/bibliography/framectr.cxx |   11 +++
 extensions/source/dbpilots/controlwizard.cxx|5 +++--
 extensions/source/dbpilots/groupboxwiz.cxx  |5 +++--
 extensions/source/dbpilots/optiongrouplayouter.cxx  |5 +++--
 extensions/source/propctrlr/cellbindinghandler.cxx  |4 +++-
 extensions/source/propctrlr/formlinkdialog.cxx  |3 ++-
 extensions/source/propctrlr/handlerhelper.cxx   |6 --
 extensions/source/propctrlr/propcontroller.cxx  |6 +++---
 extensions/source/propctrlr/xsdvalidationhelper.cxx |3 ++-
 extensions/test/ole/cpnt/cpnt.cxx   |4 ++--
 14 files changed, 54 insertions(+), 34 deletions(-)

New commits:
commit ee7fa0bd67d1c5a6b2f48eff98f96f73302c1d92
Author: Mike Kaganski 
AuthorDate: Sun Oct 4 10:12:22 2020 +0300
Commit: Mike Kaganski 
CommitDate: Sun Oct 4 15:31:16 2020 +0200

use more TOOLS_WARN_EXCEPTION

Change-Id: I7ddc1539cbd020b4b65740e213a0a993672516b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103910
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/extensions/source/abpilot/admininvokationimpl.cxx 
b/extensions/source/abpilot/admininvokationimpl.cxx
index a151647a1f9e..947f3886232b 100644
--- a/extensions/source/abpilot/admininvokationimpl.cxx
+++ b/extensions/source/abpilot/admininvokationimpl.cxx
@@ -18,6 +18,7 @@
  */
 
 #include "admininvokationimpl.hxx"
+#include 
 #include 
 #include 
 #include 
@@ -27,7 +28,6 @@
 #include 
 #include 
 #include 
-#include 
 
 namespace abp
 {
@@ -103,7 +103,8 @@ namespace abp
 }
 catch(const Exception&)
 {
-OSL_FAIL("OAdminDialogInvokation::invokeAdministration: caught an 
exception while executing the dialog!");
+TOOLS_WARN_EXCEPTION("extensions.abpilot",
+ "caught an exception while executing the 
dialog!");
 }
 return false;
 }
diff --git a/extensions/source/abpilot/datasourcehandling.cxx 
b/extensions/source/abpilot/datasourcehandling.cxx
index 1d7da2e1719b..aa8bba0b33fd 100644
--- a/extensions/source/abpilot/datasourcehandling.cxx
+++ b/extensions/source/abpilot/datasourcehandling.cxx
@@ -153,7 +153,8 @@ namespace abp
 }
 catch(const Exception&)
 {
-OSL_FAIL( "lcl_implCreateAndSetURL: caught an exception while 
creating the data source!" );
+TOOLS_WARN_EXCEPTION("extensions.abpilot",
+ "caught an exception while creating the data 
source!");
 }
 
 return aReturn;
@@ -387,7 +388,8 @@ namespace abp
 }
 catch(const Exception&)
 {
-OSL_FAIL( "ODataSource::registerDataSource: caught an exception 
while creating the data source!" );
+TOOLS_WARN_EXCEPTION("extensions.abpilot",
+ "caught an exception while creating the data 
source!");
 }
 }
 
@@ -404,7 +406,8 @@ namespace abp
 }
 catch(const Exception&)
 {
-OSL_FAIL( "ODataSource::registerDataSource: caught an exception 
while creating the data source!" );
+TOOLS_WARN_EXCEPTION("extensions.abpilot",
+ "caught an exception while creating the data 
source!");
 }
 }
 
@@ -436,7 +439,8 @@ namespace abp
 }
 catch(const Exception&)
 {
-OSL_FAIL( "ODataSource::remove: caught an exception while creating 
the data source!" );
+TOOLS_WARN_EXCEPTION("extensions.abpilot",
+ "caught an exception while creating the data 
source!");
 }
 }
 
@@ -551,7 +555,7 @@ namespace abp
 catch( const SQLException& e ) { aError <<= e; }
 catch( const Exception& )
 {
-OSL_FAIL( "ODataSource::connect: caught a generic exception!" );
+TOOLS_WARN_EXCEPTION("extensions.abpilot", "");
 }
 
 
@@ -580,7 +584,8 @@ namespace abp
 }
 catch( const Exception& )
 {
-OSL_FAIL( "ODataSource::connect: caught an exception while 
trying to display the error!" );
+TOOLS_WARN_EXCEPTION("extensions.abpilot",
+ "caught an exception while trying to 
display the error!");
 }
 }
 
diff --git a/extensions/source/abpilot/fieldmappingimpl.cxx 
b/extensions/source/abpilot/fieldmappingimpl.cxx
index df003f36d07f..7a72f8475c4b 100644
--- a/extensions/source/abpilot/fieldmappingimpl.cxx
+++ b/extensions/source/abpilot/fieldmappingimpl.cxx
@@ -24,6 +24,7 @@
 #include 
 #include

[Libreoffice-commits] core.git: solenv/wsl

2020-10-04 Thread Tor Lillqvist (via logerrit)

 solenv/wsl/wsl-lo-helper.cpp |  107 ---
 1 file changed, 90 insertions(+), 17 deletions(-)

New commits:
commit 0781f89597a5c30f9ad3345e0421a9ec4a32c147
Author: Tor Lillqvist 
AuthorDate: Sun Oct 4 15:31:21 2020 +0300
Commit: Tor Lillqvist 
CommitDate: Sun Oct 4 15:24:33 2020 +0200

Add usage message and reading of the Registry

Change-Id: Iddebcaaaeee234321a71569e80f939e8c324513d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103914
Tested-by: Tor Lillqvist 
Reviewed-by: Tor Lillqvist 

diff --git a/solenv/wsl/wsl-lo-helper.cpp b/solenv/wsl/wsl-lo-helper.cpp
index 9fe780dc12f6..0b641ceb04bd 100644
--- a/solenv/wsl/wsl-lo-helper.cpp
+++ b/solenv/wsl/wsl-lo-helper.cpp
@@ -12,9 +12,7 @@
  *
  * It is a Win32 program, not a Linux (WSL) one.
  *
- * So far just one function: Convert a full Windows pathname to 8.3 format (if 
present). WSL does
- * not seem to have that functionality built-in, and doing it through some 
invocations of cmd.exe or
- * a .bat file from WSL seems very complex.
+ * Compile as: cl -MD wsl-lo-helper.cpp advapi32.lib
  */
 
 #include 
@@ -22,12 +20,32 @@
 
 #include 
 
+static void print_result(const wchar_t* argv0, const wchar_t* result)
+{
+char output[1000];
+if (WideCharToMultiByte(CP_UTF8, WC_ERR_INVALID_CHARS, result, -1, output, 
sizeof(output), NULL,
+NULL)
+== 0)
+{
+fprintf(stderr, "%S --8.3: Could not convert result to UTF-8.\n", 
argv0);
+exit(1);
+}
+
+// Intentionally output no newline at end
+printf("%s", output);
+fflush(stdout);
+}
+
 int wmain(int argc, wchar_t** argv)
 {
 if (argc <= 1)
 {
-fprintf(stderr, "%S: Arguments expected\n", argv[0]);
-return 1;
+fprintf(stderr, "%S: Usage:\n", argv[0]);
+fprintf(stderr, "%S --8.3 \n", argv[0]);
+fprintf(stderr, "Print the 8.3 form of a Windows pathnam. Fail it 
not present.\n");
+fprintf(stderr, "%S --read-registry [32|64] \n", argv[0]);
+fprintf(stderr, "Read a string value from HKLM in the Registry and 
print it.\n");
+exit(1);
 }
 
 if (wcscmp(argv[1], L"--8.3") == 0)
@@ -35,7 +53,7 @@ int wmain(int argc, wchar_t** argv)
 if (argc != 3)
 {
 fprintf(stderr, "%S --8.3: One pathname argument expected\n", 
argv[0]);
-return 1;
+exit(1);
 }
 
 // The argument should be a pathname in Windows format. The
@@ -45,22 +63,77 @@ int wmain(int argc, wchar_t** argv)
 wchar_t woutput[1000];
 if (GetShortPathNameW(argv[2], woutput, sizeof(woutput) / 
sizeof(woutput[0])) == 0)
 {
-fprintf(stderr, "%S --8.3: Could not get short pathname\n", 
argv[0]);
-return 1;
+fprintf(stderr, "%S --8.3: Could not get short pathname.\n", 
argv[0]);
+exit(1);
+}
+
+print_result(argv[0], woutput);
+}
+else if (wcscmp(argv[1], L"--read-registry") == 0)
+{
+if (argc != 4)
+{
+fprintf(stderr, "%S --read-registry: Bitness and path arguments 
expected.\n", argv[0]);
+exit(1);
 }
 
-char output[1000];
-if (WideCharToMultiByte(CP_UTF8, WC_ERR_INVALID_CHARS, woutput, -1, 
output, sizeof(output),
-NULL, NULL)
-== 0)
+REGSAM sam;
+if (wcscmp(argv[2], L"32") == 0)
+sam = KEY_WOW64_32KEY;
+else if (wcscmp(argv[2], L"64") == 0)
+sam = KEY_WOW64_64KEY;
+else
 {
-fprintf(stderr, "%S --8.3: Could not convert result to UTF-8\n", 
argv[0]);
-return 1;
+fprintf(stderr, "%S --read-registry: Use 32 or 64.\n", argv[0]);
+exit(1);
 }
 
-// Intentionally output no newline at end
-printf("%s", output);
-fflush(stdout);
+wchar_t* path = wcsdup(argv[3]);
+
+for (wchar_t* p = path; *p != L'\0'; p++)
+if (*p == '/')
+*p = '\\';
+
+DWORD type;
+wchar_t result[1000];
+DWORD count = sizeof(result);
+
+wchar_t* last_backslash = wcsrchr(path, L'\\');
+if (last_backslash == NULL)
+{
+fprintf(stderr, "%S: Invalid path to value in the Registry.\n", 
argv[0]);
+exit(1);
+}
+
+*last_backslash = L'\0';
+wchar_t* value = last_backslash + 1;
+
+HKEY key;
+if (RegOpenKeyExW(HKEY_LOCAL_MACHINE, path, 0, KEY_QUERY_VALUE | sam, 
)
+!= ERROR_SUCCESS)
+{
+fprintf(stderr, "%S: Opening key %S in %S-bit Registry failed.\n", 
argv[0], path,
+argv[2]);
+exit(1);
+}
+
+if (RegQueryValueExW(key, value, NULL, , (LPBYTE)result, ) 
!= ERROR_SUCCESS)
+{
+fprintf(stderr, "%S: Reading value %S\\%S from %S-bit

[Libreoffice-commits] core.git: distro-configs/LibreOfficeWinArm64.conf

2020-10-04 Thread Jan-Marek Glogowski (via logerrit)

 distro-configs/LibreOfficeWinArm64.conf |   13 +
 1 file changed, 13 insertions(+)

New commits:
commit ce7c77250a310caf4706a39618d9fb52dd06e0af
Author: Jan-Marek Glogowski 
AuthorDate: Sat Jul 18 04:01:32 2020 +0200
Commit: Caolán McNamara 
CommitDate: Sun Oct 4 15:18:21 2020 +0200

Add a LibreOfficeWinArm64.conf

This is just tested with a cross-build including Java:

--with-distro-config=LibreOfficeWinArm64 \
--with-build-platform-configure-options="\
--with-jdk-home=C:/PROGRA~1/Java/JDK-14~1.1" \
--with-jdk-home=/cygdrive/c/lode/jdk-16-ea+25-windows-aarch64

Change-Id: I762049d34e6a00fec0960395f94d6537047f6061
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103643
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/distro-configs/LibreOfficeWinArm64.conf 
b/distro-configs/LibreOfficeWinArm64.conf
new file mode 100644
index ..6aface896786
--- /dev/null
+++ b/distro-configs/LibreOfficeWinArm64.conf
@@ -0,0 +1,13 @@
+--host=aarch64-pc-cygwin
+--without-junit
+--without-helppack-integration
+--enable-extension-integration
+--enable-scripting-beanshell
+--enable-scripting-javascript
+--enable-ext-wiki-publisher
+--enable-ext-nlpsolver
+--enable-online-update
+--with-help=html
+--with-myspell-dicts
+--with-package-format=msi
+--enable-mergelibs
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - cui/source

2020-10-04 Thread Eike Rathke (via logerrit)

 cui/source/inc/numfmt.hxx  |5 +++--
 cui/source/tabpages/numfmt.cxx |   35 +++
 2 files changed, 34 insertions(+), 6 deletions(-)

New commits:
commit 893bdbe8ff9fcf96ca212f72d080bad141a5d99e
Author: Eike Rathke 
AuthorDate: Sun Oct 4 00:57:08 2020 +0200
Commit: Caolán McNamara 
CommitDate: Sun Oct 4 15:17:30 2020 +0200

Fix format comment handling in number format dialog

Clicking any format in the Format list could had applied the
default 'User-defined' comment to that format. Also an edited
comment for an already existing format when clicking on another
format applied the new comment to that other format. Sometimes
'User-defined' was displayed instead of a real comment.

Change-Id: I452d41f2860affed2475737e3bc925db687d96c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103907
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit cf40efa7518fb78c6ec12a6fa2c0fef284fa2a87)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103801
Reviewed-by: Caolán McNamara 

diff --git a/cui/source/inc/numfmt.hxx b/cui/source/inc/numfmt.hxx
index 54796c63b736..1be328d9414e 100644
--- a/cui/source/inc/numfmt.hxx
+++ b/cui/source/inc/numfmt.hxx
@@ -77,12 +77,13 @@ public:
 private:
 std::unique_ptrpNumItem;
 std::unique_ptr pNumFmtShell;
-sal_uLong   nInitFormat;
+sal_uLong   nInitFormat;
+short   m_nLbFormatSelPosEdComment;
 
 boolbNumItemFlag; ///< for handling with DocShell
 boolbOneAreaFlag;
 boolbLegacyAutomaticCurrency;
-short   nFixedCategory;
+short   nFixedCategory;
 
 OUString sAutomaticLangEntry;
 OUString sAutomaticCurrencyEntry;
diff --git a/cui/source/tabpages/numfmt.cxx b/cui/source/tabpages/numfmt.cxx
index 4297cd52241e..5e3e4252a05b 100644
--- a/cui/source/tabpages/numfmt.cxx
+++ b/cui/source/tabpages/numfmt.cxx
@@ -195,6 +195,7 @@ 
SvxNumberFormatTabPage::SvxNumberFormatTabPage(weld::Container* pPage, weld::Dia
 const SfxItemSet& rCoreAttrs)
 : SfxTabPage(pPage, pController, "cui/ui/numberingformatpage.ui", 
"NumberingFormatPage", )
 , nInitFormat(ULONG_MAX)
+, m_nLbFormatSelPosEdComment(SELPOS_NONE)
 , bLegacyAutomaticCurrency(false)
 , sAutomaticLangEntry(CuiResId(RID_SVXSTR_AUTO_ENTRY))
 , m_xFtCategory(m_xBuilder->weld_label("categoryft"))
@@ -1166,6 +1167,18 @@ IMPL_LINK(SvxNumberFormatTabPage, 
SelFormatListBoxHdl_Impl, weld::ComboBox&, rLb
 
 void SvxNumberFormatTabPage::SelFormatHdl_Impl(weld::Widget* pLb)
 {
+if (m_nLbFormatSelPosEdComment != SELPOS_NONE)
+{
+// Click handler is called before focus change handler, so finish
+// comment editing of previous format, otherwise a new format will have
+// the old comment displayed after LostFocusHdl_Impl() is called
+// later. Also, clicking into another category invalidates the format
+// list and SvxNumberFormatShell::SetComment4Entry() could either
+// access a wrong format from aCurEntryList[nEntry] or crash there if
+// the new vector has less elements.
+LostFocusHdl_Impl(*pLb);
+}
+
 if (pLb == m_xCbSourceFormat.get())
 {
 EnableBySourceFormat_Impl();// enable/disable everything else
@@ -1424,6 +1437,10 @@ bool SvxNumberFormatTabPage::Click_Impl(weld::Button& 
rIB)
 {
 if (!m_xEdComment->get_visible())
 {
+if (!m_xIbAdd->get_sensitive())
+// Editing for existing format.
+m_nLbFormatSelPosEdComment = m_xLbFormat->get_selected_index();
+
 m_xEdComment->set_text(m_xFtComment->get_label());
 m_xEdComment->show();
 m_xFtComment->hide();
@@ -1432,6 +1449,7 @@ bool SvxNumberFormatTabPage::Click_Impl(weld::Button& rIB)
 else
 {
 m_xEdFormat->grab_focus();
+m_xFtComment->set_label( m_xEdComment->get_text());
 m_xEdComment->hide();
 m_xFtComment->show();
 }
@@ -1600,13 +1618,22 @@ IMPL_LINK_NOARG(SvxNumberFormatTabPage, 
LostFocusHdl_Impl, weld::Widget&, void)
 {
 if (!pNumFmtShell)
 return;
-m_xFtComment->set_label(m_xEdComment->get_text());
+
+const bool bAddSensitive = m_xIbAdd->get_sensitive();
+if (bAddSensitive || m_nLbFormatSelPosEdComment != SELPOS_NONE)
+// Comment editing was possible.
+m_xFtComment->set_label(m_xEdComment->get_text());
+
 m_xEdComment->hide();
 m_xFtComment->show();
-if(!m_xIbAdd->get_sensitive())
+if (m_nLbFormatSelPosEdComment != SELPOS_NONE)
+{
+// Save edited comment of existing format.
+pNumFmtShell->SetComment4Entry( m_nLbFormatSelPosEdComment, 
m_xEdComment->get_text());
+m_nLbFormatSelPosEdComment = SELPOS_NONE;
+}
+if (!bAddSensitive)
 {
-

[Libreoffice-bugs] [Bug 76047] FILESAVE: Links to external data not preserved for XLSX

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=76047

--- Comment #40 from Julien Nabet  ---
(In reply to egc from comment #39)
> 
> 
> Glad you're having fun ... As i'm not a programmer my only choice is it now
> to convert all the calc documents to the other office package already in use
> in the company.
Please read what several people indicated, you can:
- wait
- fix it yourself
OR
- pay someone to do it.

For the rest, you can't convince your company to stick on LO just because you
like it. You/your company must consider ads/cons.
ads:
- it's free
- you can fix the bugs or pay someone to fix the bugs since it's open source
- multi envs (but I suppose most companies don't care since they use Windows
and when they use Linux, it's rather for servers where Office suites are not so
used, except for batch treatments for some cases)
- some relevant features for you/your company may be present in LO exclusively

cons:
- less mature than other Office suites (like Ms) (at least from my opinion)
- more difficult to have support
- depending what module you use, you may undergo lots of bugs (eg: use of
Firebird in Base is a real pb for the moment)
- some relevant features for you/your company may be lacking in LO

So if you and your company:
- don't want/can't pay for bug fixes
- can't fix bug yourselves
- can't wait anymore (I agree 6 years is too long)
=> you should consider migrating.
Now, I suppose you and your company already know that migrating has also a
cost:
- license (except if you choose a free Office suite)/support
- time consuming for IT people who'll do the migration and have to deal with
potential incompatibilities
- user training (even if the interfaces are quite similar, there are always
differences)

So perhaps it may be relevant to compare cost migration and cost to pay someone
to fix this bug and other bugs which are blocking for you.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2020-10-04 Thread Xisco Fauli (via logerrit)

 sw/source/filter/ww8/ww8atr.cxx |   20 ++--
 1 file changed, 18 insertions(+), 2 deletions(-)

New commits:
commit adab4dcb1ea11246f29f43edb2f3c0c588014b2b
Author: Xisco Fauli 
AuthorDate: Fri Oct 2 15:27:46 2020 +0200
Commit: Caolán McNamara 
CommitDate: Sun Oct 4 15:10:05 2020 +0200

related: tdf#127579: make use of FindCharFormatByName more robust

the same way it's done in WW8AttributeOutput::TextINetFormat

This might fix crashes like

https://crashreport.libreoffice.org/stats/crash_details/3538a470-23d7-4e37-9504-fe6e81da301b
unfortunatelly, I have no steps to reproduce it at the moment

Change-Id: I509ee439643dfbaf6f08477142bbbd171e13eed8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103859
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
index 1f2c6f99364c..7d2a1c0432d3 100644
--- a/sw/source/filter/ww8/ww8atr.cxx
+++ b/sw/source/filter/ww8/ww8atr.cxx
@@ -222,11 +222,27 @@ void MSWordExportBase::ExportPoolItemsToCHP( 
ww8::PoolItems , sal_uInt16
  if (nWhich == RES_TXTATR_CHARFMT)
  {
  const SfxPoolItem* pINetItem = SearchPoolItems(rItems, 
RES_TXTATR_INETFMT);
+
  if (pINetItem)
  {
+ const SwFormatINetFormat& rINet = static_cast(*pINetItem);
+
+ if ( rINet.GetValue().isEmpty() )
+ continue;
+
+ const sal_uInt16 nId = rINet.GetINetFormatId();
+ const OUString& rStr = rINet.GetINetFormat();
+
+ if (rStr.isEmpty())
+ {
+ OSL_ENSURE( false, 
"MSWordExportBase::ExportPoolItemsToCHP(..) - missing unvisited character 
format at hyperlink attribute" );
+ }
+
+ const SwCharFormat* pINetFormat = IsPoolUserFormat( nId )
+? m_rDoc.FindCharFormatByName( rStr )
+: 
m_rDoc.getIDocumentStylePoolAccess().GetCharFormatFromPool( nId );
+
  const SwCharFormat* pFormat = static_cast(*pItem).GetCharFormat();
- const SwCharFormat* pINetFormat = 
m_rDoc.FindCharFormatByName(
- static_cast(*pINetItem).GetINetFormat());
  ww8::PoolItems aCharItems, aINetItems;
  GetPoolItems(pFormat->GetAttrSet(), aCharItems, false);
  GetPoolItems(pINetFormat->GetAttrSet(), aINetItems, 
false);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sd/inc sd/source

2020-10-04 Thread Tomaž Vajngerl (via logerrit)

 sd/inc/Annotation.hxx |   75 +-
 sd/source/core/annotations/Annotation.cxx |   74 -
 2 files changed, 76 insertions(+), 73 deletions(-)

New commits:
commit 73576d93ebec33a97d8a13bfd8d1f374438b414b
Author: Tomaž Vajngerl 
AuthorDate: Sat Oct 3 13:25:20 2020 +0200
Commit: Caolán McNamara 
CommitDate: Sun Oct 4 15:06:58 2020 +0200

sd: move Annotation to the header file

Change-Id: Ibae50a235dcc80af94be37fce2b35c69586ca111
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103893
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sd/inc/Annotation.hxx b/sd/inc/Annotation.hxx
index cd3c011fe8a5..24eb09989aca 100644
--- a/sd/inc/Annotation.hxx
+++ b/sd/inc/Annotation.hxx
@@ -23,7 +23,15 @@
 #include 
 #include 
 
-class SdPage;
+#include 
+#include 
+#include 
+#include 
+
+#include "drawdoc.hxx"
+#include "sdpage.hxx"
+#include "textapi.hxx"
+
 class SdrUndoAction;
 
 namespace com::sun::star::office {
@@ -53,6 +61,71 @@ void LOKCommentNotify(CommentNotificationType nType, const 
SfxViewShell* pViewSh
 
 void LOKCommentNotifyAll(CommentNotificationType nType,
 css::uno::Reference const & rxAnnotation);
+
+class Annotation : private ::cppu::BaseMutex,
+   public 
::cppu::WeakComponentImplHelper,
+   public ::cppu::PropertySetMixin
+{
+public:
+explicit Annotation( const 
css::uno::Reference& context, SdPage* pPage );
+Annotation(const Annotation&) = delete;
+Annotation& operator=(const Annotation&) = delete;
+
+static sal_uInt32 m_nLastId;
+
+SdPage* GetPage() const { return mpPage; }
+SdrModel* GetModel() { return (mpPage != nullptr) ? 
>getSdrModelFromSdrPage() : nullptr; }
+sal_uInt32 GetId() const { return m_nId; }
+
+// XInterface:
+virtual css::uno::Any SAL_CALL queryInterface(css::uno::Type const & type) 
override;
+virtual void SAL_CALL acquire() throw () override { 
::cppu::WeakComponentImplHelper::acquire(); }
+virtual void SAL_CALL release() throw () override { 
::cppu::WeakComponentImplHelper::release(); }
+
+// css::beans::XPropertySet:
+virtual css::uno::Reference SAL_CALL 
getPropertySetInfo() override;
+virtual void SAL_CALL setPropertyValue(const OUString & aPropertyName, 
const css::uno::Any & aValue) override;
+virtual css::uno::Any SAL_CALL getPropertyValue(const OUString & 
PropertyName) override;
+virtual void SAL_CALL addPropertyChangeListener(const OUString & 
aPropertyName, const css::uno::Reference & 
xListener) override;
+virtual void SAL_CALL removePropertyChangeListener(const OUString & 
aPropertyName, const css::uno::Reference & 
aListener) override;
+virtual void SAL_CALL addVetoableChangeListener(const OUString & 
PropertyName, const css::uno::Reference & 
aListener) override;
+virtual void SAL_CALL removeVetoableChangeListener(const OUString & 
PropertyName, const css::uno::Reference & 
aListener) override;
+
+// css::office::XAnnotation:
+virtual css::uno::Any SAL_CALL getAnchor() override;
+virtual css::geometry::RealPoint2D SAL_CALL getPosition() override;
+virtual void SAL_CALL setPosition(const css::geometry::RealPoint2D & 
the_value) override;
+virtual css::geometry::RealSize2D SAL_CALL getSize() override;
+virtual void SAL_CALL setSize(const css::geometry::RealSize2D& _size) 
override;
+virtual OUString SAL_CALL getAuthor() override;
+virtual void SAL_CALL setAuthor(const OUString & the_value) override;
+virtual OUString SAL_CALL getInitials() override;
+virtual void SAL_CALL setInitials(const OUString & the_value) override;
+virtual css::util::DateTime SAL_CALL getDateTime() override;
+virtual void SAL_CALL setDateTime(const css::util::DateTime & the_value) 
override;
+virtual css::uno::Reference SAL_CALL getTextRange() 
override;
+
+void createChangeUndo();
+
+private:
+// destructor is private and will be called indirectly by the release call 
   virtual ~Annotation() {}
+
+// override WeakComponentImplHelperBase::disposing()
+// This function is called upon disposing the component,
+// if your component needs special work when it becomes
+// disposed, do it here.
+virtual void SAL_CALL disposing() override;
+
+sal_uInt32 m_nId;
+SdPage* mpPage;
+css::geometry::RealPoint2D m_Position;
+css::geometry::RealSize2D m_Size;
+OUString m_Author;
+OUString m_Initials;
+css::util::DateTime m_DateTime;
+rtl::Reference m_TextRange;
+};
+
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sd/source/core/annotations/Annotation.cxx 
b/sd/source/core/annotations/Annotation.cxx
index 6a22623c1da5..d1562581c7bd 100644
--- a/sd/source/core/annotations/Annotation.cxx
+++ b/sd/source/core/annotations/Annotation.cxx
@@ -19,16 +19,14 @@
 
 #include 
 
+#include 
+
 #include 
 
-#include 
 #include 
 
 #include 
 #include

[Libreoffice-bugs] [Bug 126830] Icons not showing in menus

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=126830

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.4.0 target:6.3.1   |target:6.4.0 target:6.3.1
   |target:7.1.0 target:7.0.3   |target:7.1.0 target:7.0.3
   ||target:6.4.8

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126830] Icons not showing in menus

2020-10-04 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=126830

--- Comment #10 from Commit Notification 
 ---
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/fa85f4c9dfdef681dbbcb56845b0c19c6ef1ff52

Restore the fix for tdf#126830

It will be available in 6.4.8.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - vcl/unx

2020-10-04 Thread Maxim Monastirsky (via logerrit)

 vcl/unx/gtk3/gtk3gtksalmenu.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit fa85f4c9dfdef681dbbcb56845b0c19c6ef1ff52
Author: Maxim Monastirsky 
AuthorDate: Wed Sep 30 09:29:48 2020 +0300
Commit: Caolán McNamara 
CommitDate: Sun Oct 4 15:04:36 2020 +0200

Restore the fix for tdf#126830

It was lost with 1ae450504cf57457f9702684b1517fda1dd3c481
("drop gtk2 support"), which was based on an older revision
of gtksalmenu.cxx.

In the meantime, the UI for settings icons on was hidden
(see tdf#123265), but this can't be an excuse for carrying
the broken code. The setting is also still available as an
expert config.

Change-Id: Iffc6342bb312230646399f2f85ef0211315f6c8a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103660
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 
(cherry picked from commit 800baa9c60d8fb7b4ed8cf8ae0ba7b6b68c69c9c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103663
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtk3gtksalmenu.cxx b/vcl/unx/gtk3/gtk3gtksalmenu.cxx
index db0480e3040e..bc60db2be80f 100644
--- a/vcl/unx/gtk3/gtk3gtksalmenu.cxx
+++ b/vcl/unx/gtk3/gtk3gtksalmenu.cxx
@@ -1032,7 +1032,7 @@ namespace
 void GtkSalMenu::NativeSetItemIcon( unsigned nSection, unsigned nItemPos, 
const Image& rImage )
 {
 #if GLIB_CHECK_VERSION(2,38,0)
-if (!!rImage && mbHasNullItemIcon)
+if (!rImage && mbHasNullItemIcon)
 return;
 
 SolarMutexGuard aGuard;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

1 2 >

1 - 100 of 169 matches

Mail list logo