date:20201101

[Libreoffice-bugs] [Bug 137559] UI: page scroll bar not functioning properly (dragging not responding; not properly positioned when scrolling) (painting issue; Skia)

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137559

Telesto  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129960] Print range for sheet 13 or higher not saved to ODS format, if linked data is used

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=129960

--- Comment #5 from Tomasz  ---
Hi Guys,

I confirm that I can't reproduce the issue with 7.0.2.2 on Windows!
So the problem is gone for me but was it fixed ? :)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137922] Extensions button in Template choose does not show anything

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137922

--- Comment #1 from Heiko Tietze  ---
The dialog shows up for me but remains empty.

Console show the following after some certification info:
Signature Algorithm: sha256WithRSAEncryption
...
ssl: Match common name 'yusufketen.com' against 'yusufketen.com'
Identity match for 'yusufketen.com': good
SSL certificate checks failed: Server certificate verification failed: issuer
is not trusted
Request ends, status 0 class 0xx, error line:
Server certificate verification failed: issuer is not trusted
Running destroy hooks.
Request ends.
warn:ucb.ucp.webdav:26878:26951:ucb/source/ucp/webdav-neon/NeonSession.cxx:1839:
Neon returned NE_ERROR, http response status code was: 0 'Server certificate
verification failed: issuer is not trusted'
sess: Destroying session.
warn:cui.dialogs:26878:26950:cui/source/dialogs/AdditionsDialog.cxx:95: Reading
 failed with 0x20d(Error Area:Io
Class:General Code:13)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137907] Wrong orientation of CJK Black Lenticular Brackets in vertical layout (AR PL UKai TW)

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137907

--- Comment #2 from Volga  ---
Created attachment 166915
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166915=edit
My screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: compilerplugins/clang dbaccess/source editeng/source include/xmloff linguistic/source reportdesign/source sc/source starmath/source svx/source sw/source xmloff/inc xmlo

2020-11-01 Thread Noel (via logerrit)

 compilerplugins/clang/test/xmlimport.cxx |  155 -
 compilerplugins/clang/xmlimport.cxx  |  289 ++
 dbaccess/source/filter/xml/xmlColumn.hxx |2 
 dbaccess/source/filter/xml/xmlComponent.hxx  |2 
 dbaccess/source/filter/xml/xmlConnectionData.hxx |2 
 dbaccess/source/filter/xml/xmlConnectionResource.hxx |2 
 dbaccess/source/filter/xml/xmlDataSource.hxx |2 
 dbaccess/source/filter/xml/xmlDataSourceInfo.hxx |2 
 dbaccess/source/filter/xml/xmlDataSourceSetting.hxx  |3 
 dbaccess/source/filter/xml/xmlDataSourceSettings.hxx |2 
 dbaccess/source/filter/xml/xmlDatabase.hxx   |2 
 dbaccess/source/filter/xml/xmlDatabaseDescription.hxx|2 
 dbaccess/source/filter/xml/xmlDocuments.hxx  |2 
 dbaccess/source/filter/xml/xmlFileBasedDatabase.hxx  |2 
 dbaccess/source/filter/xml/xmlHierarchyCollection.hxx|2 
 dbaccess/source/filter/xml/xmlLogin.hxx  |2 
 dbaccess/source/filter/xml/xmlQuery.hxx  |2 
 dbaccess/source/filter/xml/xmlServerDatabase.hxx |2 
 dbaccess/source/filter/xml/xmlStyleImport.cxx|3 
 dbaccess/source/filter/xml/xmlTable.hxx  |2 
 dbaccess/source/filter/xml/xmlTableFilterList.hxx|3 
 dbaccess/source/filter/xml/xmlTableFilterPattern.hxx |2 
 dbaccess/source/filter/xml/xmlfilter.cxx |   13 
 editeng/source/misc/SvXMLAutoCorrectImport.hxx   |8 
 editeng/source/xml/xmltxtimp.cxx |2 
 include/xmloff/DocumentSettingsContext.hxx   |3 
 include/xmloff/XMLBase64ImportContext.hxx|6 
 include/xmloff/XMLCharContext.hxx|7 
 include/xmloff/XMLEventsImportContext.hxx|   10 
 include/xmloff/XMLTextMasterPageContext.hxx  |3 
 include/xmloff/xmlimp.hxx|   11 
 include/xmloff/xmlmetai.hxx  |4 
 include/xmloff/xmlprcon.hxx  |3 
 include/xmloff/xmlscripti.hxx|3 
 include/xmloff/xmlstyle.hxx  |3 
 linguistic/source/convdicxml.cxx |   10 
 reportdesign/source/filter/xml/xmlCell.hxx   |2 
 reportdesign/source/filter/xml/xmlColumn.cxx |4 
 reportdesign/source/filter/xml/xmlColumn.hxx |4 
 reportdesign/source/filter/xml/xmlComponent.hxx  |2 
 reportdesign/source/filter/xml/xmlCondPrtExpr.hxx|3 
 reportdesign/source/filter/xml/xmlControlProperty.hxx|4 
 reportdesign/source/filter/xml/xmlFormatCondition.hxx|3 
 reportdesign/source/filter/xml/xmlFunction.hxx   |3 
 reportdesign/source/filter/xml/xmlGroup.hxx  |3 
 reportdesign/source/filter/xml/xmlMasterFields.hxx   |3 
 reportdesign/source/filter/xml/xmlReport.hxx |2 
 reportdesign/source/filter/xml/xmlReportElement.hxx  |3 
 reportdesign/source/filter/xml/xmlReportElementBase.hxx  |3 
 reportdesign/source/filter/xml/xmlSection.hxx|3 
 reportdesign/source/filter/xml/xmlStyleImport.cxx|3 
 reportdesign/source/filter/xml/xmlTable.hxx  |2 
 reportdesign/source/filter/xml/xmlfilter.cxx |9 
 reportdesign/source/filter/xml/xmlfilter.hxx |3 
 sc/source/filter/xml/XMLTableHeaderFooterContext.hxx |5 
 sc/source/filter/xml/XMLTableSourceContext.cxx   |6 
 sc/source/filter/xml/XMLTableSourceContext.hxx   |3 
 sc/source/filter/xml/celltextparacontext.cxx |6 
 sc/source/filter/xml/celltextparacontext.hxx |2 
 sc/source/filter/xml/importcontext.cxx   |   18 
 sc/source/filter/xml/importcontext.hxx   |   11 
 sc/source/filter/xml/xmlcoli.cxx |6 
 sc/source/filter/xml/xmlcoli.hxx |3 
 sc/source/filter/xml/xmlconti.cxx|5 
 sc/source/filter/xml/xmlconti.hxx|2 
 sc/source/filter/xml/xmlimprt.cxx|   43 -
 sc/source/filter/xml/xmlstyli.cxx|6 
 sc/source/filter/xml/xmltabi.cxx |6 
 sc/source/filter/xml/xmltabi.hxx |3 
 starmath/source/mathmlimport.cxx |   41 -
 svx/source/xml/xmlxtimp.cxx  |3

[Libreoffice-bugs] [Bug 113499] [META] AutoFill bugs and enhancements

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113499
Bug 113499 depends on bug 137621, which changed state.

Bug 137621 Summary: EDITING Autofill of merged cells with Boolean content 
incorrect, series detection does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=137621

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113499] [META] AutoFill bugs and enhancements

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113499
Bug 113499 depends on bug 137625, which changed state.

Bug 137625 Summary: EDITING Autofill of merged cells with user list content 
incorrect, series detection does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=137625

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137916] Report wizard doesn't open correctly

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137916

--- Comment #5 from Julien Nabet  ---
Thank you Robert for the confirmation.

I created a brand odb file with LO Debian package 7.0.2.2 with a simple table
and a basic report.
Then I tried to open and edit with LO master sources, I got error message:
"unsatisfied query of interface of type
com.sun.star.xml.sax.XDocumentHandler!/home/julien/lo/libreoffice/include/com/sun/star/uno/Reference.hxx:79

on console, I noticed these:
warn:legacy.osl:3995:3995:dbaccess/source/core/dataaccess/ModelImpl.cxx:773:
ODatabaseModelImpl::getOrCreateRootStorage: no source to create the storage
from!
warn:legacy.osl:3995:3995:dbaccess/source/core/dataaccess/ModelImpl.cxx:773:
ODatabaseModelImpl::getOrCreateRootStorage: no source to create the storage
from!
warn:legacy.osl:3995:3995:dbaccess/source/core/dataaccess/ModelImpl.cxx:773:
ODatabaseModelImpl::getOrCreateRootStorage: no source to create the storage
from!
warn:dbaccess:3995:3995:dbaccess/source/filter/xml/xmlComponent.cxx:69: unknown
attribute http://www.w3.org/1999/xlink xlink:type=simple
warn:svl.items:3995:3995:svl/source/items/itempool.cxx:396: old secondary pool:
EditEngineItemPool of pool: XOutdevItemPool must be empty.
warn:legacy.osl:3995:3995:dbaccess/source/ui/dlg/sqlmessage.cxx:226:
lcl_buildExceptionChain: useless exception: no state, no error code, no
message!
warn:svl.items:3995:3995:svl/source/items/itempool.cxx:396: old secondary pool:
EditEngineItemPool of pool: XOutdevItemPool must be empty.
warn:legacy.osl:3995:3995:dbaccess/source/ui/dlg/sqlmessage.cxx:226:
lcl_buildExceptionChain: useless exception: no state, no error code, no
message!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87057] comment box text should have style options

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=87057

Dieter  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/source include/svtools sfx2/source svtools/source

2020-11-01 Thread Noel Grandin (via logerrit)

 cui/source/options/optjava.cxx|   11 +--
 include/svtools/miscopt.hxx   |3 ---
 sfx2/source/view/viewfrm.cxx  |5 +++--
 svtools/source/config/miscopt.cxx |   36 ++--
 4 files changed, 10 insertions(+), 45 deletions(-)

New commits:
commit 0f3a8a972421aa440f4276b92463a481e5cd4267
Author: Noel Grandin 
AuthorDate: Sat Oct 31 19:49:13 2020 +0200
Commit: Noel Grandin 
CommitDate: Mon Nov 2 07:25:54 2020 +0100

use officecfg or MacroRecorderMode

Change-Id: I2a8d4f401ddfd4368a7b50b4c3c8a72724f9afa3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105154
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/cui/source/options/optjava.cxx b/cui/source/options/optjava.cxx
index 3072fb71b757..ed695295b583 100644
--- a/cui/source/options/optjava.cxx
+++ b/cui/source/options/optjava.cxx
@@ -32,7 +32,6 @@
 
 #include 
 #include 
-#include 
 
 #include 
 #include 
@@ -482,8 +481,10 @@ bool SvxJavaOptionsPage::FillItemSet( SfxItemSet* 
/*rCoreSet*/ )
 
 if ( m_xMacroCB->get_state_changed_from_saved() )
 {
-SvtMiscOptions aMiscOpt;
-aMiscOpt.SetMacroRecorderMode(m_xMacroCB->get_active());
+std::shared_ptr< comphelper::ConfigurationChanges > xChanges(
+comphelper::ConfigurationChanges::create());
+officecfg::Office::Common::Misc::MacroRecorderMode::set( 
m_xMacroCB->get_active(), xChanges );
+xChanges->commit();
 bModified = true;
 }
 
@@ -561,8 +562,6 @@ void SvxJavaOptionsPage::Reset( const SfxItemSet* /*rSet*/ )
 ClearJavaInfo();
 m_xJavaList->clear();
 
-SvtMiscOptions aMiscOpt;
-
 #if HAVE_FEATURE_JAVA
 bool bEnabled = false;
 javaFrameworkError eErr = jfw_getEnabled(  );
@@ -586,7 +585,7 @@ void SvxJavaOptionsPage::Reset( const SfxItemSet* /*rSet*/ )
 
 m_xExperimentalCB->set_active( 
officecfg::Office::Common::Misc::ExperimentalMode::get() );
 m_xExperimentalCB->save_state();
-m_xMacroCB->set_active(aMiscOpt.IsMacroRecorderMode());
+m_xMacroCB->set_active( 
officecfg::Office::Common::Misc::MacroRecorderMode::get() );
 m_xMacroCB->save_state();
 
 m_aResetIdle.Start();
diff --git a/include/svtools/miscopt.hxx b/include/svtools/miscopt.hxx
index f2902de1a4a3..a295aca97c0f 100644
--- a/include/svtools/miscopt.hxx
+++ b/include/svtools/miscopt.hxx
@@ -73,9 +73,6 @@ class SVT_DLLPUBLIC SvtMiscOptions final : public 
utl::detail::Options
 sal_Int16   GetToolboxStyle() const;
 voidSetToolboxStyle( sal_Int16 nStyle );
 
-voidSetMacroRecorderMode( bool bSet );
-boolIsMacroRecorderMode() const;
-
 private:
 
 
/*-
diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx
index 76b8db3754b5..3076c58ea033 100644
--- a/sfx2/source/view/viewfrm.cxx
+++ b/sfx2/source/view/viewfrm.cxx
@@ -3006,7 +3006,8 @@ void SfxViewFrame::MiscState_Impl(SfxItemSet )
 SvtMiscOptions aMiscOptions;
 const OUString& 
sName{GetObjectShell()->GetFactory().GetFactoryName()};
 bool bMacrosDisabled = 
officecfg::Office::Common::Security::Scripting::DisableMacrosExecution::get();
-if (bMacrosDisabled || !aMiscOptions.IsMacroRecorderMode() 
||
+if (bMacrosDisabled ||
+ 
!officecfg::Office::Common::Misc::MacroRecorderMode::get() ||
  ( sName!="swriter" && sName!="scalc" ) )
 {
 rSet.DisableItem( nWhich );
@@ -3031,7 +3032,7 @@ void SfxViewFrame::MiscState_Impl(SfxItemSet )
 {
 SvtMiscOptions aMiscOptions;
 const OUString& 
sName{GetObjectShell()->GetFactory().GetFactoryName()};
-if ( !aMiscOptions.IsMacroRecorderMode() ||
+if ( 
!officecfg::Office::Common::Misc::MacroRecorderMode::get() ||
  ( sName!="swriter" && sName!="scalc" ) )
 {
 rSet.DisableItem( nWhich );
diff --git a/svtools/source/config/miscopt.cxx 
b/svtools/source/config/miscopt.cxx
index 3390cba46229..09cbfb832dcd 100644
--- a/svtools/source/config/miscopt.cxx
+++ b/svtools/source/config/miscopt.cxx
@@ -52,12 +52,10 @@ using namespace ::com::sun::star;
 #define PROPERTYHANDLE_SYMBOLSTYLE  2
 #define PROPERTYNAME_DISABLEUICUSTOMIZATION "DisableUICustomization"
 #define PROPERTYHANDLE_DISABLEUICUSTOMIZATION   3
-#define PROPERTYNAME_MACRORECORDERMODE   "MacroRecorderMode"
-#define PROPERTYHANDLE_MACRORECORDERMODE4
 #define PROPERTYNAME_SIDEBARICONSIZE"SidebarIconSize"
-#define PROPERTYHANDLE_SIDEBARICONSIZE  5
+#define PROPERTYHANDLE_SIDEBARICONSIZE  4
 #define PROPERTYNAME_NOTEBOOKBARICONSIZE

[Libreoffice-bugs] [Bug 87057] comment box text should have style options

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=87057

--- Comment #14 from wantfall  ---
Nice to see this post here and thanks for sharing this to us. The
feed.kroger.com is an online official web portal started by the Kroger. On the
feed.kroger.com portal, the employees use an Enterprise kroger eschedule
https://krogerfeedback.ninja/eschedule/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137924] New: [KF5] UI not scaled correctly on HIDPI Wayland/KDE screens

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137924

Bug ID: 137924
   Summary: [KF5] UI not scaled correctly on HIDPI Wayland/KDE
screens
   Product: LibreOffice
   Version: 7.0.2.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: da...@ingeniumdigital.com

Description:
When running any LibreOffice application under a KDE Wayland session
(specifically, the "Plasma (Full Wayland)" session under OpenSUSE Tumbleweed),
on a HiDPI display, the UI elements (buttons, etc) are not scaled, appearing
tiny.

The layout of most windows (dialog boxes, etc), including the main windows of
the various applications (Writer, Impress, etc) only use the top-left quarter
of the window (when 2× scaling is enabled for the display in KDE), though
resizeable windows will usually correctly use the whole window area if it's
resized. Note that the mouse cursor still interacts correctly with these
controls, so it seems to be a layout problem rather than a rendering problem.

Note that the menu bar is scaled correctly — presumably it's handled
differently.

The "gtk3" VCL plugin seems to work fine. This issue seems to have only
appeared when Bug 127687 was fixed (beforehand, everything was blurry and
pixelated: I think KWin was scaling the window). I haven't actually tried to
bisect, though, so take that with a grain of salt.

Steps to Reproduce:
Start any LibreOffice application under a KDE Wayland session, (with
QT_QPA_PLATFORM=wayland and SAL_USE_VCLPLUGIN=kf5, both of which should be
defaults).

Actual Results:
The controls in windows are tiny, and may be squeezed into the top-left-hand
corner of the window.

See screenshots:
https://davidgow.net/stuff/lowriter-recovery-hidpi-scale.png
https://davidgow.net/stuff/lowriter-totd-hidpi-scale.png
https://davidgow.net/stuff/lowriter-mainwin-hidpi-scale.png


Expected Results:
The controls in the UI are twice the width and twice the height.

Basically, it should look like this, but not blurry (this is running under
XWayland, where a lower-resolution display is reported to the application, and
the window manager scales the input/output):
https://davidgow.net/stuff/lowriter-mainwin-x11-scale.png


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
This seems to have been happening since LibreOffice 7.0.

I've tried it with and without a new UserProfile and OpenGL enabled/disabled.
The system in question is running OpenSUSE Tumbleweed (a rolling-release
distro), with an Intel Integrated Graphics chipset. (This is a Dell XPS 13 9360
laptop.)

The output of "$ env | grep QT" is below, but changing these (except
QT_QPA_PLATFORM) doesn't fix the issue:
QT_QPA_PLATFORM=wayland
PLASMA_USE_QT_SCALING=1
QT_WAYLAND_FORCE_DPI=96
QT_IM_MODULE=fcitx
QT_AUTO_SCREEN_SCALE_FACTOR=0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137718] Crash when exporting/registering odt file in html format when html file already exist

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137718

mrei  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #1 from mrei  ---
Working for me. I am exporting in html format, no problem. When I am rewriting
over the same file no speed issue, no crash.

Version: 7.1.0.0.alpha1
Build ID: 987671387712c4f9061d6216ff2f001a7bb9e57b
CPU threads: 4; OS: Mac OS X 10.13.6; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132580] Italics button just not work in docx files (in odt it works fine) after save and reopen the file the italics formatting is gone.

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=132580

--- Comment #6 from QA Administrators  ---
Dear dinospao132,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137916] Report wizard doesn't open correctly

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137916

QA Administrators  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132601] A shape can be anchored in header and dragged into to the text. Making it impossible to delete

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=132601

--- Comment #2 from QA Administrators  ---
Dear Telesto,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137577] UI: resolve ambiguity for 'named ranges' with identical name and different scope

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137577

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137574] The image selection frame lagging behind when moving they image with arrow keys

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137574

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137580] Closing Impress presentation relatively slow (8 seconds; expected 2)

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137580

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137578] Entering chart data labels on a Pie Chart distorts the Pie Chart display

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137578

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132475] Dynamic fields revert to static text in LibreOffice Writer documents saved in .docx format.

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=132475

--- Comment #6 from QA Administrators  ---
Dear Paul Villani,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113561] In LO CALC it is not possible to integrate the SOLVER into a macro by recording a macro

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113561

--- Comment #3 from QA Administrators  ---
Dear Justin Gray,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132184] Data source combobox has bad height

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=132184

--- Comment #3 from QA Administrators  ---
Dear guser,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #34 from Justin L  ---
The last instance I found was calc comments. They were working until 6.2 as
mentioned in comment 0, when again they stopped deleting the composing chars.
I tried to fix this one myself, but couldn't even find the window/control that
handled the comment...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137838] Hyperlink to shape apparently not working

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137838

Jim Raykowski  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |rayk...@gmail.com
   |desktop.org |

--- Comment #4 from Jim Raykowski  ---
Included with this enhancement patch are fixes to focus lost bugs after
hyperlink or Navigator content navigation from frame type content to non-frame
type content.

https://gerrit.libreoffice.org/c/core/+/105164

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137918] Characters overlap feature

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137918

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #1 from Regina Henschel  ---
For regular text you can use characters from the "Combining Diacritical Marks"
and "Combining Diacritical Symbols" subsets. You should also have a look at
other special characters. 
For math formulas you find some predefined combinations in the category
"Attributes".

We have already character spacing with negative values, but it is restricted to
-2pt. The ability to use e.g. -14pt is already tracked in bug 107405.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136244] Zoom in/out on a document with picture slow with Raster & GDI (fine with Vulkan)

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=136244

--- Comment #11 from Frank Ch. Eigler  ---
(In reply to Commit Notification from comment #7)
> Luboš Luňák committed a patch related to this issue.
> It has been pushed to "master":
> 
> https://git.libreoffice.org/core/commit/
> a8a7df6de6b48a03589ac9b66b490875eab19b75
> 
> increase Skia image cache size to 64MiB (tdf#136244)

Can we get this number made available to users to modify, or decided as a
function of available RAM on the machine?  Previous versions of libreoffice had
an image cache size option.  64MB appears too small to handle multiple 4Kx4K
raster images pasted onto pages without huge slowdowns.  This is a regression
over libreoffice 6.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: svx/uiconfig

2020-11-01 Thread andreas kainz (via logerrit)

 svx/uiconfig/ui/sidebararea.ui |   12 +++-
 1 file changed, 7 insertions(+), 5 deletions(-)

New commits:
commit ccad985c5163224d669e9f0fa70fdff070fc58ca
Author: andreas kainz 
AuthorDate: Sun Nov 1 23:50:31 2020 +0100
Commit: Andreas Kainz 
CommitDate: Mon Nov 2 00:57:57 2020 +0100

Sidebar Area alignment update

Change-Id: Ie8155e73adc2c52e8f3ec3455a5cdb4ed596c352
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105160
Tested-by: Jenkins
Reviewed-by: Andreas Kainz 

diff --git a/svx/uiconfig/ui/sidebararea.ui b/svx/uiconfig/ui/sidebararea.ui
index 95311615234a..a14641887cdb 100644
--- a/svx/uiconfig/ui/sidebararea.ui
+++ b/svx/uiconfig/ui/sidebararea.ui
@@ -1,5 +1,5 @@
 
-
+
 
   
   
@@ -121,12 +121,13 @@
   
 True
 False
+center
+vertical
 
   
 True
 False
 Select the gradient 
style.
-True
 
   Linear
   Axial
@@ -152,7 +153,6 @@
 _Import
 True
 True
-True
 True
   
   
@@ -171,6 +171,7 @@
   
 True
 False
+center
 True
 
   
@@ -234,9 +235,9 @@
 True
 False
 Fill gradient from.
-0
 center
 True
+0
 True
 
 
@@ -259,6 +260,7 @@
   
 True
 Select the gradient 
angle.
+center
 adjustment2
 
   
@@ -277,8 +279,8 @@
 True
 False
 Fill gradient to.
-0
 center
+0
 True
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 137923] New: "Clone Formatting" disabled on some elements which can take cloned formats

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137923

Bug ID: 137923
   Summary: "Clone Formatting" disabled on some elements which can
take cloned formats
   Product: LibreOffice
   Version: 7.0.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyal...@technion.ac.il

I've recent used Clone Formatting on some arrow objects in a presentation of
mine. I've noticed that when selecting some (individual) arrows - the Clone
Formatting button is disabled. This, despite the fact that these arrows are
quite formattable, and I am able to apply "Clone Formatting" to them from other
arrows.

I think the arrows for which this happens are the "fancy" ones, i.e. having two
right-turns, or a curved path, rather than going straight between the
endpoints.

Version: 7.0.2.2
Build ID: 8349ace3c3162073abd90d81fd06dcfb6b36b994
CPU threads: 4; OS: Linux 5.2; UI render: default; VCL: gtk3
Locale: he-IL (en_IL); UI: en-US

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137908] Exceptions for auto correct disappear lost after restart

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137908

Telesto  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137908] Exceptions for auto correct disappear lost after restart

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137908

Telesto  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
Summary|Fehler in der Autokorrektur |Exceptions for auto correct
   ||disappear lost after
   ||restart
   Priority|medium  |high

--- Comment #1 from Telesto  ---
STR
1. Open Writer
2. Tools - Auto correction -> Auto correct options -> Exceptions entry
3. Add some entry
4. Press OK
5. Close LibreOffice
6. Launch LibreOffice again
7. Tools - Auto correction -> Auto correct options -> Exceptions entry being
empty

It's even empty from launch on.. which not the case in LibreOffice 6.4


Repro with
Version: 7.1.0.0.alpha1+ (x64)
Build ID: ec1f4d3253963ac16d638734ac70dde033e82154
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

not with
Version: 6.4.0.0.beta1+ (x64)
Build ID: 20be5cd0bdc57d812bf34a2debfe48caa51de881
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: GL; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137922] New: Extensions button in Template choose does not show anything

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137922

Bug ID: 137922
   Summary: Extensions button in Template choose does not show
anything
   Product: LibreOffice
   Version: 7.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: riz_17_...@yahoo.co.id

Created attachment 166914
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166914=edit
Extension button in Template Chooser

Step to reproduce
1. Click File > New > Templates. A template dialog chooser will apears
2. Click on Extensions button in the bottom left

This button does not show anything. It should open Additions dialog with
Templates as the content category.

Version: 7.1.0.0.alpha1+
Build ID: 5d51b8f5ac0a82c458f792c11985407a5eeb6fd5
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: kf5
Locale: id-ID (id_ID.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2020-10-29_05:12:40
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137902] ENHANCEMENT: integration of the office with the Git.

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137902

Telesto  changed:

   What|Removed |Added

  Component|Base|LibreOffice
   Keywords||needsUXEval
Summary|Suggestion for improvement  |ENHANCEMENT: integration of
   ||the office with the Git.
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 137902] ENHANCEMENT: integration of the office with the Git.

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137902

Telesto  changed:

   What|Removed |Added

  Component|Base|LibreOffice
   Keywords||needsUXEval
Summary|Suggestion for improvement  |ENHANCEMENT: integration of
   ||the office with the Git.
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: i18npool/source

2020-11-01 Thread Rene Engelhard (via logerrit)

 i18npool/source/calendar/calendar_gregorian.cxx |9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

New commits:
commit 9cdcc20dee02a13e065b6117ff0d574e567c6112
Author: Rene Engelhard 
AuthorDate: Sun Nov 1 18:30:49 2020 +0100
Commit: Eike Rathke 
CommitDate: Sun Nov 1 23:39:37 2020 +0100

fix build with ICU 68

use standard true.


/home/rene/LibreOffice/git/master/i18npool/source/calendar/calendar_gregorian.cxx:
 In member function 'virtual void 
i18npool::Calendar_gregorian::setLocalDateTime(double)':

/home/rene/LibreOffice/git/master/i18npool/source/calendar/calendar_gregorian.cxx:363:40:
 error: 'TRUE' was not declared in this scope
  363 | body->getTimeZone().getOffset( fR, TRUE, nZoneOffset, 
nDSTOffset, status );
  |^~~~

/usr/include/unicode/umachine.h says:

@deprecated ICU 68 Use standard "true" instead.

Change-Id: I45d2b0afa6a9043767af5c2cf41ba24377f2cdc4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105151
Tested-by: René Engelhard 
Reviewed-by: Eike Rathke 

diff --git a/i18npool/source/calendar/calendar_gregorian.cxx 
b/i18npool/source/calendar/calendar_gregorian.cxx
index 69fb08797ab3..f05fc96009ca 100644
--- a/i18npool/source/calendar/calendar_gregorian.cxx
+++ b/i18npool/source/calendar/calendar_gregorian.cxx
@@ -360,7 +360,14 @@ Calendar_gregorian::setLocalDateTime( double fTimeInDays )
 "Calendar_gregorian::setLocalDateTime: " << std::fixed << fM << " 
rounded to " << fR);
 int32_t nZoneOffset, nDSTOffset;
 UErrorCode status = U_ZERO_ERROR;
-body->getTimeZone().getOffset( fR, TRUE, nZoneOffset, nDSTOffset, status );
+body->getTimeZone().getOffset( fR,
+#if U_ICU_VERSION_MAJOR_NUM >= 68
+true,
+#else
+TRUE,
+#endif
+nZoneOffset, nDSTOffset, status );
+
 if ( !U_SUCCESS(status) ) throw ERROR;
 status = U_ZERO_ERROR;
 body->setTime( fR - (nZoneOffset + nDSTOffset), status );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 113933] Incorrect font rendering with Impress

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113933

--- Comment #5 from Apoplectic  ---
Thanks to the creator for writing the post, it was quite necessary for me and
liked it. I wrote a note on the https://essaysservicesreviews.com/ about this.
I will be happy if you read it and accept it. Thank you for your concern.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137921] New: Spell checker does not seem to work

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137921

Bug ID: 137921
   Summary: Spell checker does not seem to work
   Product: LibreOffice
   Version: 7.0.3.1 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: haylwo...@gmail.com

Description:
I wrote a document in Write and Spell check did not find any miss spelled words
in the document either as I typed or manually checked for poor spelling. I did
catch miss-spelled word by checking some words manually using an online
dictionary but Write did not find any miss-spellings.



Steps to Reproduce:
1.Write a document and miss spell words and check
2.
3.

Actual Results:
spell check will not hightlight the miss spelled word

Expected Results:
nothing


Reproducible: Always


User Profile Reset: No



Additional Info:
highlighted the miss spelled word and suggest correct spellings or correct
word.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg

2020-11-01 Thread Rizal Muttaqin (via logerrit)

 icon-themes/colibre/cmd/32/downsearch.png|binary
 icon-themes/colibre/cmd/32/firstrecord.png   |binary
 icon-themes/colibre/cmd/32/lastrecord.png|binary
 icon-themes/colibre/cmd/32/mailmergeexcludeentry.png |binary
 icon-themes/colibre/cmd/32/mailmergewizard.png   |binary
 icon-themes/colibre/cmd/32/movepagefirst.png |binary
 icon-themes/colibre/cmd/32/movepagelast.png  |binary
 icon-themes/colibre/cmd/32/nextrecord.png|binary
 icon-themes/colibre/cmd/32/prevrecord.png|binary
 icon-themes/colibre/cmd/32/upsearch.png  |binary
 icon-themes/colibre/cmd/lc_downsearch.png|binary
 icon-themes/colibre/cmd/lc_firstrecord.png   |binary
 icon-themes/colibre/cmd/lc_lastrecord.png|binary
 icon-themes/colibre/cmd/lc_mailmergeexcludeentry.png |binary
 icon-themes/colibre/cmd/lc_mailmergewizard.png   |binary
 icon-themes/colibre/cmd/lc_movepagefirst.png |binary
 icon-themes/colibre/cmd/lc_movepagelast.png  |binary
 icon-themes/colibre/cmd/lc_nextrecord.png|binary
 icon-themes/colibre/cmd/lc_prevrecord.png|binary
 icon-themes/colibre/cmd/lc_upsearch.png  |binary
 icon-themes/colibre/cmd/sc_downsearch.png|binary
 icon-themes/colibre/cmd/sc_firstrecord.png   |binary
 icon-themes/colibre/cmd/sc_lastrecord.png|binary
 icon-themes/colibre/cmd/sc_mailmergeexcludeentry.png |binary
 icon-themes/colibre/cmd/sc_mailmergewizard.png   |binary
 icon-themes/colibre/cmd/sc_movepagefirst.png |binary
 icon-themes/colibre/cmd/sc_movepagelast.png  |binary
 icon-themes/colibre/cmd/sc_nextrecord.png|binary
 icon-themes/colibre/cmd/sc_prevrecord.png|binary
 icon-themes/colibre/cmd/sc_upsearch.png  |binary
 icon-themes/colibre/links.txt|4 
 icon-themes/colibre/res/helpimg/info.png |binary
 icon-themes/colibre/svx/res/galdefl.png  |binary
 icon-themes/colibre/svx/res/galdefs.png  |binary
 icon-themes/colibre/svx/res/galnorl.png  |binary
 icon-themes/colibre/svx/res/galnors.png  |binary
 icon-themes/colibre/svx/res/galrdol.png  |binary
 icon-themes/colibre/svx/res/galrdos.png  |binary
 icon-themes/colibre/sw/res/sc20171.png   |binary
 icon-themes/colibre/sw/res/sc20172.png   |binary
 icon-themes/colibre/sw/res/sc20173.png   |binary
 icon-themes/colibre/sw/res/sc20174.png   |binary
 icon-themes/colibre/vcl/res/infobox.png  |binary
 icon-themes/colibre_svg/cmd/32/downsearch.svg|2 +-
 icon-themes/colibre_svg/cmd/32/firstrecord.svg   |2 +-
 icon-themes/colibre_svg/cmd/32/lastrecord.svg|2 +-
 icon-themes/colibre_svg/cmd/32/mailmergeexcludeentry.svg |2 +-
 icon-themes/colibre_svg/cmd/32/mailmergewizard.svg   |2 +-
 icon-themes/colibre_svg/cmd/32/movepagefirst.svg |2 +-
 icon-themes/colibre_svg/cmd/32/movepagelast.svg  |2 +-
 icon-themes/colibre_svg/cmd/32/nextrecord.svg|2 +-
 icon-themes/colibre_svg/cmd/32/prevrecord.svg|2 +-
 icon-themes/colibre_svg/cmd/32/upsearch.svg  |2 +-
 icon-themes/colibre_svg/cmd/lc_downsearch.svg|2 +-
 icon-themes/colibre_svg/cmd/lc_firstrecord.svg   |2 +-
 icon-themes/colibre_svg/cmd/lc_lastrecord.svg|2 +-
 icon-themes/colibre_svg/cmd/lc_mailmergeexcludeentry.svg |2 +-
 icon-themes/colibre_svg/cmd/lc_mailmergewizard.svg   |2 +-
 icon-themes/colibre_svg/cmd/lc_movepagefirst.svg |2 +-
 icon-themes/colibre_svg/cmd/lc_movepagelast.svg  |2 +-
 icon-themes/colibre_svg/cmd/lc_nextrecord.svg|2 +-
 icon-themes/colibre_svg/cmd/lc_prevrecord.svg|2 +-
 icon-themes/colibre_svg/cmd/lc_upsearch.svg  |2 +-
 icon-themes/colibre_svg/cmd/sc_downsearch.svg|2 +-
 icon-themes/colibre_svg/cmd/sc_firstrecord.svg   |2 +-
 icon-themes/colibre_svg/cmd/sc_lastrecord.svg|2 +-
 icon-themes/colibre_svg/cmd/sc_mailmergeexcludeentry.svg |2 +-
 icon-themes/colibre_svg/cmd/sc_mailmergewizard.svg   |3 ++-
 icon-themes/colibre_svg/cmd/sc_movepagefirst.svg |2 +-
 icon-themes/colibre_svg/cmd/sc_movepagelast.svg  |2 +-
 icon-themes/colibre_svg/cmd/sc_nextrecord.svg|2 +-
 icon-themes/colibre_svg/cmd/sc_prevrecord.svg|2 +-
 icon-themes/colibre_svg/cmd/sc_upsearch.svg  |2 +-
 icon-themes/colibre_svg/res/helpimg/info.svg |2 +-
 icon-themes/colibre_svg/svx/res/galdefl.svg

[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg

2020-11-01 Thread Rizal Muttaqin (via logerrit)

 dev/null  |binary
 icon-themes/colibre/cmd/32/changepicture.png  |binary
 icon-themes/colibre/cmd/32/color.png  |binary
 icon-themes/colibre/cmd/32/compressgraphic.png|binary
 icon-themes/colibre/cmd/32/crop.png   |binary
 icon-themes/colibre/cmd/32/gallery.png|binary
 icon-themes/colibre/cmd/32/graphicdialog.png  |binary
 icon-themes/colibre/cmd/32/graphicfiltersepia.png |binary
 icon-themes/colibre/cmd/32/imagebutton.png|binary
 icon-themes/colibre/cmd/32/imagecontrol.png   |binary
 icon-themes/colibre/cmd/32/imagemapdialog.png |binary
 icon-themes/colibre/cmd/32/insertgraphic.png  |binary
 icon-themes/colibre/cmd/lc_changepicture.png  |binary
 icon-themes/colibre/cmd/lc_compressgraphic.png|binary
 icon-themes/colibre/cmd/lc_crop.png   |binary
 icon-themes/colibre/cmd/lc_gallery.png|binary
 icon-themes/colibre/cmd/lc_graphicdialog.png  |binary
 icon-themes/colibre/cmd/lc_graphicfiltersepia.png |binary
 icon-themes/colibre/cmd/lc_imagebutton.png|binary
 icon-themes/colibre/cmd/lc_imagecontrol.png   |binary
 icon-themes/colibre/cmd/lc_imagemapdialog.png |binary
 icon-themes/colibre/cmd/lc_insertgraphic.png  |binary
 icon-themes/colibre/cmd/sc_changepicture.png  |binary
 icon-themes/colibre/cmd/sc_compressgraphic.png|binary
 icon-themes/colibre/cmd/sc_gallery.png|binary
 icon-themes/colibre/cmd/sc_graphicdialog.png  |binary
 icon-themes/colibre/cmd/sc_graphicfiltersepia.png |binary
 icon-themes/colibre/cmd/sc_imagebutton.png|binary
 icon-themes/colibre/cmd/sc_imagecontrol.png   |binary
 icon-themes/colibre/cmd/sc_imagemapdialog.png |binary
 icon-themes/colibre/cmd/sc_insertgraphic.png  |binary
 icon-themes/colibre/links.txt |6 
+++---
 icon-themes/colibre/res/grafikde.png  |binary
 icon-themes/colibre/res/grafikei.png  |binary
 icon-themes/colibre/sd/res/image.png  |binary
 icon-themes/colibre/sd/res/placeholder_image_large.png|binary
 icon-themes/colibre/sd/res/placeholder_image_large_hover.png  |binary
 icon-themes/colibre/sd/res/placeholder_image_small.png|binary
 icon-themes/colibre/sd/res/placeholder_image_small_hover.png  |binary
 icon-themes/colibre/svx/res/symphony/ColorModeNormal_16x16.png|binary
 icon-themes/colibre/svx/res/symphony/ColorModeWaterMark_16x16.png |binary
 icon-themes/colibre/svx/res/symphony/Highlight.png|binary
 icon-themes/colibre/svx/res/symphony/Line_color.png   |binary
 icon-themes/colibre_svg/cmd/32/changepicture.svg  |2 +-
 icon-themes/colibre_svg/cmd/32/color.svg  |2 +-
 icon-themes/colibre_svg/cmd/32/compressgraphic.svg|2 +-
 icon-themes/colibre_svg/cmd/32/crop.svg   |2 +-
 icon-themes/colibre_svg/cmd/32/es/underline.svg   |1 -
 icon-themes/colibre_svg/cmd/32/es/underlinedouble.svg |1 -
 icon-themes/colibre_svg/cmd/32/firstpage.svg  |1 -
 icon-themes/colibre_svg/cmd/32/gallery.svg|2 +-
 icon-themes/colibre_svg/cmd/32/graphicdialog.svg  |2 +-
 icon-themes/colibre_svg/cmd/32/graphicfiltersepia.svg |2 +-
 icon-themes/colibre_svg/cmd/32/imagebutton.svg|2 +-
 icon-themes/colibre_svg/cmd/32/imagecontrol.svg   |2 +-
 icon-themes/colibre_svg/cmd/32/imagemapdialog.svg |2 +-
 icon-themes/colibre_svg/cmd/32/insertgraphic.svg  |2 +-
 icon-themes/colibre_svg/cmd/lc_changepicture.svg  |2 +-
 icon-themes/colibre_svg/cmd/lc_compressgraphic.svg|2 +-
 icon-themes/colibre_svg/cmd/lc_crop.svg   |2 +-
 icon-themes/colibre_svg/cmd/lc_firstpage.svg  |1 -
 icon-themes/colibre_svg/cmd/lc_gallery.svg|2 +-
 icon-themes/colibre_svg/cmd/lc_graphicdialog.svg

[Libreoffice-bugs] [Bug 137920] New: Writer hung on Mac when inserting image larger than page

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137920

Bug ID: 137920
   Summary: Writer hung on Mac when inserting image larger than
page
   Product: LibreOffice
   Version: 7.0.2.2 release
  Hardware: All
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rich...@filmlight.ltd.uk

Description:
Seen on 7.0.2.2 on Mac when inserting a cover image on the first page. If the
image was larger than the page less margins, I got the Spinning Beachball of
Death. Setting the page borders to zero stopped this happening. Inserting the
image then warned that the image was larger than the printable area, which is
OK.

I made a 20.5x29cm image in Gimp. A4 is 21x29.7cm.



Steps to Reproduce:
1. Make A4 document with 2cm margins. 
2. Make 20.5cm x 29cm image 
3. Insert image


Actual Results:
Writer hung and needed Force Quit. Repeated quite a few times. Fixed by
changing page margins. I could then stretch the image to the actual page
boundaries.

Expected Results:
Insert image somehow. Not to hang.



Reproducible: Always


User Profile Reset: No



Additional Info:
Warn, with option to crop the page to the page limits or abort.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2020-11-01 Thread Bjoern Michaelsen (via logerrit)

 sw/source/core/docnode/node.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit fccbd1211ca5c620482591e7916f0f262d9f86bc
Author: Bjoern Michaelsen 
AuthorDate: Sun Nov 1 13:32:03 2020 +0100
Commit: Bjoern Michaelsen 
CommitDate: Sun Nov 1 21:34:07 2020 +0100

move UpdateAttr sanity check to DBG_UTIL

Change-Id: I9a6fd1ef8ea704a0ea3f8182d06cbbe938fd1937
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105137
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen 

diff --git a/sw/source/core/docnode/node.cxx b/sw/source/core/docnode/node.cxx
index abfc0d13e827..c13ffe5620ed 100644
--- a/sw/source/core/docnode/node.cxx
+++ b/sw/source/core/docnode/node.cxx
@@ -69,7 +69,9 @@
 #include 
 #include 
 #include 
+#ifdef DBG_UTIL
 #include 
+#endif
 
 using namespace ::com::sun::star::i18n;
 
@@ -1169,11 +1171,13 @@ void SwContentNode::SwClientNotify( const SwModify&, 
const SfxHint& rHint)
 // This makes the crude "WhichId" type divert from the true 
type, which is bad.
 // Thus we are asserting here, but falling back to an proper
 // hint instead. so that we at least will not spread such 
poison further.
+#ifdef DBG_UTIL
 if(pLegacyHint->m_pNew != pLegacyHint->m_pOld)
 {
 auto pBT = sal::backtrace_get(20);
 SAL_WARN("sw.core", "UpdateAttr not matching! " << 
sal::backtrace_to_string(pBT.get()));
 }
+#endif
 assert(pLegacyHint->m_pNew == pLegacyHint->m_pOld);
 assert(dynamic_cast(pLegacyHint->m_pNew));
 const SwUpdateAttr aFallbackHint(0,0,0);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 137916] Report wizard doesn't open correctly

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137916

Robert Großkopf  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #4 from Robert Großkopf  ---
Could confirm wizard for report builder in Base wouldn't open in LO 7.1.0.0
alpha1+ on OpenSUSE 15.1 64bit rpm Linux. 

But there is a difference between the normal design of a report. When trying to
start with the wizard there will be content in the page header of the report:
Title:
Author: (with my name ...)
Date:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/svtools sc/source sd/source svtools/source svx/source sw/source

2020-11-01 Thread Noel Grandin (via logerrit)

 include/svtools/miscopt.hxx   |4 --
 sc/source/ui/drawfunc/fuins1.cxx  |4 +-
 sd/source/ui/func/fuinsert.cxx|4 +-
 svtools/source/config/miscopt.cxx |   63 ++
 svx/source/dialog/linkwarn.cxx|   18 ++
 sw/source/uibase/uiview/view2.cxx |4 +-
 6 files changed, 21 insertions(+), 76 deletions(-)

New commits:
commit d3a9db6310204247a3bd8f23a984c5a04afbeef1
Author: Noel Grandin 
AuthorDate: Sat Oct 31 18:55:36 2020 +0200
Commit: Noel Grandin 
CommitDate: Sun Nov 1 21:05:00 2020 +0100

use officecfg for ShowLinkWarningDialog

Change-Id: I92a42eb2ff48bff4e635f1a37a25c8ecb9ac1347
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105153
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/svtools/miscopt.hxx b/include/svtools/miscopt.hxx
index 90e3702a2838..f2902de1a4a3 100644
--- a/include/svtools/miscopt.hxx
+++ b/include/svtools/miscopt.hxx
@@ -73,10 +73,6 @@ class SVT_DLLPUBLIC SvtMiscOptions final : public 
utl::detail::Options
 sal_Int16   GetToolboxStyle() const;
 voidSetToolboxStyle( sal_Int16 nStyle );
 
-boolShowLinkWarningDialog() const;
-voidSetShowLinkWarningDialog( bool bSet );
-boolIsShowLinkWarningDialogReadOnly() const;
-
 voidSetMacroRecorderMode( bool bSet );
 boolIsMacroRecorderMode() const;
 
diff --git a/sc/source/ui/drawfunc/fuins1.cxx b/sc/source/ui/drawfunc/fuins1.cxx
index 4187300e3428..d5a28f8a29ad 100644
--- a/sc/source/ui/drawfunc/fuins1.cxx
+++ b/sc/source/ui/drawfunc/fuins1.cxx
@@ -19,6 +19,7 @@
 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -30,7 +31,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -325,7 +325,7 @@ FuInsertGraphic::FuInsertGraphic( ScTabViewShell&   rViewSh,
 bool bAsLink = aDlg.IsAsLink();
 
 // really store as link only?
-if( bAsLink && SvtMiscOptions().ShowLinkWarningDialog() )
+if( bAsLink && 
officecfg::Office::Common::Misc::ShowLinkWarningDialog::get() )
 {
 SvxLinkWarningDialog aWarnDlg(pWin ? pWin->GetFrameWeld() 
: nullptr, aFileName);
 if (aWarnDlg.run() != RET_OK)
diff --git a/sd/source/ui/func/fuinsert.cxx b/sd/source/ui/func/fuinsert.cxx
index ce0d45082b3f..cc93f6f38c37 100644
--- a/sd/source/ui/func/fuinsert.cxx
+++ b/sd/source/ui/func/fuinsert.cxx
@@ -22,6 +22,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -37,7 +38,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -177,7 +177,7 @@ void FuInsertGraphic::DoExecute( SfxRequest& rReq )
 if(pGrafObj && bAsLink )
 {
 // really store as link only?
-if( SvtMiscOptions().ShowLinkWarningDialog() )
+if( 
officecfg::Office::Common::Misc::ShowLinkWarningDialog::get() )
 {
 SvxLinkWarningDialog aWarnDlg(mpWindow->GetFrameWeld(), 
aFileName);
 if (aWarnDlg.run() != RET_OK)
diff --git a/svtools/source/config/miscopt.cxx 
b/svtools/source/config/miscopt.cxx
index fe216fe263e0..3390cba46229 100644
--- a/svtools/source/config/miscopt.cxx
+++ b/svtools/source/config/miscopt.cxx
@@ -50,16 +50,14 @@ using namespace ::com::sun::star;
 #define PROPERTYHANDLE_TOOLBOXSTYLE 1
 #define PROPERTYNAME_ICONTHEME  "SymbolStyle"
 #define PROPERTYHANDLE_SYMBOLSTYLE  2
-#define PROPERTYNAME_SHOWLINKWARNINGDIALOG  "ShowLinkWarningDialog"
-#define PROPERTYHANDLE_SHOWLINKWARNINGDIALOG3
 #define PROPERTYNAME_DISABLEUICUSTOMIZATION "DisableUICustomization"
-#define PROPERTYHANDLE_DISABLEUICUSTOMIZATION   4
+#define PROPERTYHANDLE_DISABLEUICUSTOMIZATION   3
 #define PROPERTYNAME_MACRORECORDERMODE   "MacroRecorderMode"
-#define PROPERTYHANDLE_MACRORECORDERMODE5
+#define PROPERTYHANDLE_MACRORECORDERMODE4
 #define PROPERTYNAME_SIDEBARICONSIZE"SidebarIconSize"
-#define PROPERTYHANDLE_SIDEBARICONSIZE  6
+#define PROPERTYHANDLE_SIDEBARICONSIZE  5
 #define PROPERTYNAME_NOTEBOOKBARICONSIZE"NotebookbarIconSize"
-#define PROPERTYHANDLE_NOTEBOOKBARICONSIZE  7
+#define PROPERTYHANDLE_NOTEBOOKBARICONSIZE  6
 
 class SvtMiscOptions_Impl : public ConfigItem
 {
@@ -74,8 +72,6 @@ private:
 boolm_bIsSymbolsStyleRO;
 sal_Int16   m_nToolboxStyle;
 boolm_bIsToolboxStyleRO;
-boolm_bShowLinkWarningDialog;
-boolm_bIsShowLinkWarningDialogRO;
 boolm_bDisableUICustomization;
 boolm_bMacroRecorderMode;
 boolm_bIconThemeWasSetAutomatically;
@@ -161,15 +157,6 @@ public:
 // translate from VCL settings
 void SetToolboxStyle( sal_Int16 nStyle );
 
-bool ShowLinkWarningDialog()

[Libreoffice-commits] core.git: sw/inc sw/source

2020-11-01 Thread Bjoern Michaelsen (via logerrit)

 sw/inc/calbck.hxx   |8 
 sw/inc/node.hxx |4 
 sw/source/core/attr/calbck.cxx  |7 +++
 sw/source/core/docnode/swbaslnk.cxx |8 
 4 files changed, 15 insertions(+), 12 deletions(-)

New commits:
commit 63076928d41d95d6c0bc86580ba8a5a985b1f415
Author: Bjoern Michaelsen 
AuthorDate: Sun Nov 1 17:39:30 2020 +0100
Commit: Bjoern Michaelsen 
CommitDate: Sun Nov 1 20:56:54 2020 +0100

Make SwClient::ModifyNotification non-virtual

Change-Id: Ic34b0b7a3ad906da5f25103f32a28e2a3efd82fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105150
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen 

diff --git a/sw/inc/calbck.hxx b/sw/inc/calbck.hxx
index 020697b285b8..19c7c0b1125a 100644
--- a/sw/inc/calbck.hxx
+++ b/sw/inc/calbck.hxx
@@ -144,7 +144,10 @@ public:
 // should be called only from SwModify the client is registered in
 // mba: IMHO this method should be pure virtual
 // DO NOT USE IN NEW CODE! use SwClientNotify instead.
-virtual void Modify(const SfxPoolItem* pOldValue, const SfxPoolItem* 
pNewValue);
+virtual void Modify(const SfxPoolItem*, const SfxPoolItem*);
+// controlled access to Modify method
+// mba: this is still considered a hack and it should be fixed; the name 
makes grep-ing easier
+void ModifyNotification(const SfxPoolItem*, const SfxPoolItem*);
 // when overriding this, you MUST call SwClient::SwClientModify() in the 
override!
 virtual void SwClientNotify(const SwModify&, const SfxHint& rHint) 
override;
 
@@ -152,9 +155,6 @@ public:
 // its SwClient objects can decide to get registered to the latter instead 
by calling this method
 std::unique_ptr CheckRegistration( const 
SfxPoolItem* pOldValue );
 
-// controlled access to Modify method
-// mba: this is still considered a hack and it should be fixed; the name 
makes grep-ing easier
-virtual void ModifyNotification( const SfxPoolItem *pOldValue, const 
SfxPoolItem *pNewValue ) { Modify ( pOldValue, pNewValue ); }
 void SwClientNotifyCall( const SwModify& rModify, const SfxHint& rHint ) { 
SwClientNotify( rModify, rHint ); }
 
 const SwModify* GetRegisteredIn() const { return m_pRegisteredIn; }
diff --git a/sw/inc/node.hxx b/sw/inc/node.hxx
index 3708e82f1c5c..7aa3fe8525bb 100644
--- a/sw/inc/node.hxx
+++ b/sw/inc/node.hxx
@@ -480,10 +480,6 @@ public:
 // Access to DrawingLayer FillAttributes in a preprocessed form for 
primitive usage
 virtual drawinglayer::attribute::SdrAllFillAttributesHelperPtr 
getSdrAllFillAttributesHelper() const;
 
-virtual void ModifyNotification(const SfxPoolItem* pOld, const 
SfxPoolItem* pNew) override
-{
-SwClientNotify(*this, sw::LegacyModifyHint(pOld, pNew));
-}
 void UpdateAttr(const SwUpdateAttr&);
 
 private:
diff --git a/sw/source/core/attr/calbck.cxx b/sw/source/core/attr/calbck.cxx
index c3eda1a29e64..917efa340bbd 100644
--- a/sw/source/core/attr/calbck.cxx
+++ b/sw/source/core/attr/calbck.cxx
@@ -113,6 +113,13 @@ void SwClient::SwClientNotify(const SwModify&, const 
SfxHint& rHint)
 }
 };
 
+void SwClient::ModifyNotification(const SfxPoolItem* pOldValue, const 
SfxPoolItem* pNewValue)
+{
+SwModify aFallbackMod;
+auto pMod = dynamic_cast(this);
+SwClientNotify(pMod ? *pMod : aFallbackMod, 
sw::LegacyModifyHint(pOldValue, pNewValue));
+}
+
 void SwClient::StartListeningToSameModifyAs(const SwClient& other)
 {
 if(other.m_pRegisteredIn)
diff --git a/sw/source/core/docnode/swbaslnk.cxx 
b/sw/source/core/docnode/swbaslnk.cxx
index 2d297445bd41..3ab59b95932c 100644
--- a/sw/source/core/docnode/swbaslnk.cxx
+++ b/sw/source/core/docnode/swbaslnk.cxx
@@ -61,14 +61,14 @@ static void lcl_CallModify( SwGrfNode& rGrfNd, SfxPoolItem& 
rItem )
 //  them haven't a loaded Graphic.
 rGrfNd.LockModify();
 {
-SwIterator aIter(rGrfNd);
-for(SwClient* pLast = aIter.First(); pLast; pLast = aIter.Next())
-if(dynamic_cast( pLast) ==  nullptr)
+SwIterator aIter(rGrfNd);
+for(SwModify* pLast = aIter.First(); pLast; pLast = aIter.Next())
+if(dynamic_cast(pLast) ==  nullptr)
 pLast->ModifyNotification(, );
 }
 {
 SwIterator aIter(rGrfNd);
-for(SwClient* pLast = aIter.First(); pLast; pLast = aIter.Next())
+for(SwContentFrame* pLast = aIter.First(); pLast; pLast = aIter.Next())
 pLast->ModifyNotification(, );
 }
 rGrfNd.UnlockModify();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 133355] Optimise memory use for large animated gifs

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=133355

Telesto  changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #12 from Telesto  ---
@Caolán
Armin has introduced a more intelligent handling of animated GIFs. They same
trick needs to be implemented for presentation mode; it has exactly the same
flaw.

I should ask Armin technically, but he is probably not available  

A warning in advance: the fix is not totally unproblematic; bug 104878. However
they current implementation will crash x32 builds and make system going out of
mem pretty fast (if enough gifs are used).

But feel free to ignore of course :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112491] SDBC-mismatch on alter field-properties in embedded Firebird database when editing primary key

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112491

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||7527

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117527] Firebird: EDIT: Table wizard does not set field properties "AutoValue" to "Yes" for user selected primary key field.

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=117527

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||2491

--- Comment #8 from Julien Nabet  ---
It seems that, like tdf#112491, the pb is it's not possible to enable Autovalue
once the table has been created, so shouldn't it be a dup of tdf#112491?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 133355] Optimise memory use for large animated gifs

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=133355

Telesto  changed:

   What|Removed |Added

Version|6.1.0.3 release |5.2.0.4 release
   Keywords||perf

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121731] [META] Page border bugs and enhancements

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121731
Bug 121731 depends on bug 136814, which changed state.

Bug 136814 Summary: Border padding of 0,10 cm becomes 0,07 cm on doc/x export
https://bugs.documentfoundation.org/show_bug.cgi?id=136814

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137903] Fonts- Special characters with high numbers not found

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137903

--- Comment #6 from Mike Sapsard  ---
Thanks for putting me right. I can reproduce everything as you say under Format
| Character| Features.

It is not a bug. However, I could not make the suggestions about entering PUA
style using U+FFF7 or U+FFFD respectively and using alt-x work. 

Previously I have always found what I needed under Insert | Special Character,
and I was unaware that such characters could be found like this.

If there were a way of enhancing Insert | Special Character it would be great,
because I suspect many users have not yet found Format | Character| Features.
Also a single place to go to might be a usability improvement.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104878] Impress works very slow with large sized GIF

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104878

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=99
   ||519

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2020-11-01 Thread Eike Rathke (via logerrit)

 sc/source/ui/docshell/docsh4.cxx |7 ++-
 sc/source/ui/inc/docsh.hxx   |1 +
 sc/source/ui/view/tabvwsh4.cxx   |9 +
 3 files changed, 16 insertions(+), 1 deletion(-)

New commits:
commit 14f9dac4fbaeb0e13ad4875f77960c4019d8f229
Author: Eike Rathke 
AuthorDate: Sun Nov 1 18:09:45 2020 +0100
Commit: Eike Rathke 
CommitDate: Sun Nov 1 20:39:28 2020 +0100

Resolves: tdf#135108 Allow link updates if loaded document so far had none

It is the current user who'll add external references, not the
creator of the loaded document.

Change-Id: I59a6d0b8600a9b299aa54a1efeedfccc16ad69d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105152
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/sc/source/ui/docshell/docsh4.cxx b/sc/source/ui/docshell/docsh4.cxx
index c2d1c5047794..737268f9b8e7 100644
--- a/sc/source/ui/docshell/docsh4.cxx
+++ b/sc/source/ui/docshell/docsh4.cxx
@@ -111,10 +111,15 @@ using namespace ::com::sun::star;
 
 #include 
 
-void ScDocShell::ReloadAllLinks()
+void ScDocShell::AllowLinkUpdate()
 {
 m_aDocument.SetLinkFormulaNeedingCheck(false);
 getEmbeddedObjectContainer().setUserAllowsLinkUpdate(true);
+}
+
+void ScDocShell::ReloadAllLinks()
+{
+AllowLinkUpdate();
 
 ReloadTabLinks();
 weld::Window *pDialogParent = GetActiveDialogParent();
diff --git a/sc/source/ui/inc/docsh.hxx b/sc/source/ui/inc/docsh.hxx
index 706d47cc6996..bfdaf85af4b3 100644
--- a/sc/source/ui/inc/docsh.hxx
+++ b/sc/source/ui/inc/docsh.hxx
@@ -294,6 +294,7 @@ public:
 
 virtual voidReconnectDdeLink(SfxObjectShell& rServer) override;
 voidUpdateLinks() override;
+voidAllowLinkUpdate();
 voidReloadAllLinks();
 voidReloadTabLinks();
 ScLkUpdMode GetLinkUpdateModeState() const;
diff --git a/sc/source/ui/view/tabvwsh4.cxx b/sc/source/ui/view/tabvwsh4.cxx
index c173ca5e69bf..68a76c329007 100644
--- a/sc/source/ui/view/tabvwsh4.cxx
+++ b/sc/source/ui/view/tabvwsh4.cxx
@@ -1583,6 +1583,15 @@ void ScTabViewShell::Construct( TriState 
nForceDesignMode )
 SfxCallMode::ASYNCHRON | 
SfxCallMode::RECORD );
 }
 }
+else
+{
+// No links yet, but loading an existing document may have
+// disabled link update but there's no "Allow updating" infobar
+// that could enable it again. So in order to enable the user
+// to add formulas with external references allow link updates
+// again.
+pDocSh->AllowLinkUpdate();
+}
 
 bool bReImport = false; // update 
imported data
 ScDBCollection* pDBColl = rDoc.GetDBCollection();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 133355] Optimise memory use for large animated gifs

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=133355

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=99
   ||519

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 133355] Optimise memory use for large animated gifs

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=133355

--- Comment #11 from Telesto  ---
Created attachment 166913
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166913=edit
Bibisect log

This got solved in non-presentation mode with

author  Armin Le Grand   2016-06-03 13:58:40 +0200
committer   Caolán McNamara 2016-06-10 14:42:57
+0100
commit  702b58945b51e738cdcc3d383ca38881f9f1338d (patch)
tree9c1958b8c44ee5bbc7803765e498d2208b906556
parent  b523e20a8fb8c9c26e7ffdc1b3f5fd06c440985c (diff)
tdf#99519 Added more intelligent handling of animated GIFs
Isolated to a single Primitive2D class based on the AnimatedSwitch-
Primitive2D which does the specializing in one place. Buffers small
GIFs completely, handles 1st frame always buffered, huge GIFs get
animated by just playing he next frame.
To reach more with the current approach we would have to re-implement
AnimatedGIF import, replay it internally on a sys-specific Surface
and blit the current content (with alpha) to our display

https://cgit.freedesktop.org/libreoffice/core/commit/?id=702b58945b51e738cdcc3d383ca38881f9f1338d

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137354] LibreOffice logo distorted on About Page

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137354

mwtjunkm...@gmail.com changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|REOPENED|RESOLVED

--- Comment #19 from mwtjunkm...@gmail.com ---
And someone must have noticed.

Works now with

Version: 7.1.0.0.alpha1+ (x64)
Build ID: a689cf1672e89cb78fbcfa14c505850927e71f58
CPU threads: 8; OS: Windows 10.0 Build 20246; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

and I see that the little tag line underneath the logo has been removed, which
is probably a good thing, considering how small the text was.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103202] [META] About dialog bugs and enhancements

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103202
Bug 103202 depends on bug 137354, which changed state.

Bug 137354 Summary: LibreOffice logo distorted on About Page
https://bugs.documentfoundation.org/show_bug.cgi?id=137354

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137620] kmfl keyboard entry jumps around to other textboxes or beginning of line in editeng

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137620

--- Comment #33 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c99e66cb5c75efb933694bfbb8edd7117c3d655f

tdf#137620 support surrounding text for impress outline view

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sd/source

2020-11-01 Thread Caolán McNamara (via logerrit)

 sd/source/ui/view/drtxtob.cxx  |   14 --
 sd/source/ui/view/drtxtob1.cxx |6 ++
 2 files changed, 6 insertions(+), 14 deletions(-)

New commits:
commit c26ef8b1f06906fb1acd3999b36f546bf2722461
Author: Caolán McNamara 
AuthorDate: Sun Nov 1 15:40:50 2020 +
Commit: Caolán McNamara 
CommitDate: Sun Nov 1 20:35:27 2020 +0100

dynamic_cast followed by static_cast

Change-Id: I29daabb250d72403ccf751aeeb5fd2fa755e895c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105145
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/sd/source/ui/view/drtxtob.cxx b/sd/source/ui/view/drtxtob.cxx
index 02344e1c4564..1464a5d06c30 100644
--- a/sd/source/ui/view/drtxtob.cxx
+++ b/sd/source/ui/view/drtxtob.cxx
@@ -180,11 +180,8 @@ void TextObjectBar::GetAttrState( SfxItemSet& rSet )
 
 assert(mpViewShell);
 
-if( dynamic_cast< const OutlineView *>( mpView ) !=  
nullptr)
-{
-pOLV = 
static_cast(mpView)->GetViewByWindow(
-mpViewShell->GetActiveWindow());
-}
+if (OutlineView* pOView = 
dynamic_cast(mpView))
+pOLV = 
pOView->GetViewByWindow(mpViewShell->GetActiveWindow());
 
 sal_uInt16 stretchY = 100;
 if( pOutliner )
@@ -254,11 +251,8 @@ void TextObjectBar::GetAttrState( SfxItemSet& rSet )
 {
 OutlinerView* pOLV = mpView->GetTextEditOutlinerView();
 
-if( dynamic_cast< const OutlineView *>( mpView ) !=  
nullptr)
-{
-pOLV = 
static_cast(mpView)->GetViewByWindow(
-mpViewShell->GetActiveWindow());
-}
+if (OutlineView* pOView = 
dynamic_cast(mpView))
+pOLV = 
pOView->GetViewByWindow(mpViewShell->GetActiveWindow());
 
 bool bOutlineViewSh = dynamic_cast< const OutlineViewShell 
*>( mpViewShell ) !=  nullptr;
 
diff --git a/sd/source/ui/view/drtxtob1.cxx b/sd/source/ui/view/drtxtob1.cxx
index 996265c3c9ea..69e83e18f2db 100644
--- a/sd/source/ui/view/drtxtob1.cxx
+++ b/sd/source/ui/view/drtxtob1.cxx
@@ -121,11 +121,9 @@ void TextObjectBar::Execute( SfxRequest  )
 
 assert(mpViewShell);
 
-if( dynamic_cast< const OutlineView *>( mpView ) !=  nullptr)
+if (OutlineView* pOView = dynamic_cast(mpView))
 {
-pOLV = static_cast(mpView)
-->GetViewByWindow(mpViewShell->GetActiveWindow());
-
+pOLV = pOView->GetViewByWindow(mpViewShell->GetActiveWindow());
 aGuard.reset( new OutlineViewModelChangeGuard( 
static_cast(*mpView) ) );
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sd/source

2020-11-01 Thread Caolán McNamara (via logerrit)

 sd/source/ui/inc/Window.hxx|4 +++
 sd/source/ui/view/sdwindow.cxx |   49 -
 2 files changed, 29 insertions(+), 24 deletions(-)

New commits:
commit c99e66cb5c75efb933694bfbb8edd7117c3d655f
Author: Caolán McNamara 
AuthorDate: Sun Nov 1 15:51:22 2020 +
Commit: Caolán McNamara 
CommitDate: Sun Nov 1 20:35:47 2020 +0100

tdf#137620 support surrounding text for impress outline view

Change-Id: I7136ec4237fe41bd7e795594d66413fc7d8c311c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105146
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sd/source/ui/inc/Window.hxx b/sd/source/ui/inc/Window.hxx
index cbbe7311c086..979983e492ff 100644
--- a/sd/source/ui/inc/Window.hxx
+++ b/sd/source/ui/inc/Window.hxx
@@ -25,6 +25,8 @@
 #include 
 #include 
 
+class OutlinerView;
+
 namespace sd {
 
 class ViewShell;
@@ -151,6 +153,8 @@ public:
 void SetUseDropScroll (bool bUseDropScroll);
 void DropScroll (const Point& rMousePos);
 virtual void KeyInput(const KeyEvent& rKEvt) override;
+private:
+OutlinerView* GetOutlinerView() const;
 protected:
 Point maWinPos;
 Point maViewOrigin;
diff --git a/sd/source/ui/view/sdwindow.cxx b/sd/source/ui/view/sdwindow.cxx
index eb1d17fca32a..7ab817969516 100644
--- a/sd/source/ui/view/sdwindow.cxx
+++ b/sd/source/ui/view/sdwindow.cxx
@@ -36,6 +36,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -973,43 +974,43 @@ css::uno::Reference
 }
 }
 
-OUString Window::GetSurroundingText() const
+OutlinerView* Window::GetOutlinerView() const
 {
-if ( mpViewShell->GetShellType() == ViewShell::ST_OUTLINE )
-return OUString();
-else if ( mpViewShell->GetView()->IsTextEdit() )
+OutlinerView *pOLV = nullptr;
+sd::View* pView = mpViewShell->GetView();
+if (mpViewShell->GetShellType() == ViewShell::ST_OUTLINE)
 {
-if (OutlinerView *pOLV = 
mpViewShell->GetView()->GetTextEditOutlinerView())
-return pOLV->GetEditView().GetSurroundingText();
+if (OutlineView* pOView = dynamic_cast(pView))
+pOLV = pOView->GetViewByWindow(this);
 }
+else if (pView->IsTextEdit())
+{
+pOLV = pView->GetTextEditOutlinerView();
+}
+return pOLV;
+}
+
+OUString Window::GetSurroundingText() const
+{
+OutlinerView *pOLV = GetOutlinerView();
+if (pOLV)
+return pOLV->GetEditView().GetSurroundingText();
 return OUString();
 }
 
 Selection Window::GetSurroundingTextSelection() const
 {
-if ( mpViewShell->GetShellType() == ViewShell::ST_OUTLINE )
-{
-return Selection( 0, 0 );
-}
-else if ( mpViewShell->GetView()->IsTextEdit() )
-{
-if (OutlinerView *pOLV = 
mpViewShell->GetView()->GetTextEditOutlinerView())
-return pOLV->GetEditView().GetSurroundingTextSelection();
-}
+OutlinerView *pOLV = GetOutlinerView();
+if (pOLV)
+return pOLV->GetEditView().GetSurroundingTextSelection();
 return Selection( 0, 0 );
 }
 
 bool Window::DeleteSurroundingText(const Selection& rSelection)
 {
-if ( mpViewShell->GetShellType() == ViewShell::ST_OUTLINE )
-{
-return false;
-}
-else if ( mpViewShell->GetView()->IsTextEdit() )
-{
-if (OutlinerView *pOLV = 
mpViewShell->GetView()->GetTextEditOutlinerView())
-return pOLV->GetEditView().DeleteSurroundingText(rSelection);
-}
+OutlinerView *pOLV = GetOutlinerView();
+if (pOLV)
+return pOLV->GetEditView().DeleteSurroundingText(rSelection);
 return false;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/vcl

2020-11-01 Thread Caolán McNamara (via logerrit)

 include/vcl/embeddedfontshelper.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0b8526460dc6196408a97a0f081f1146abe89799
Author: Caolán McNamara 
AuthorDate: Sun Nov 1 15:18:30 2020 +
Commit: Caolán McNamara 
CommitDate: Sun Nov 1 20:34:22 2020 +0100

cid#1468697 Uncaught exception

Change-Id: Ibc589c87356781b143088d4231a8c0a2a2671961
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105143
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/include/vcl/embeddedfontshelper.hxx 
b/include/vcl/embeddedfontshelper.hxx
index c1c98eaf0694..7f8c1f3094cf 100644
--- a/include/vcl/embeddedfontshelper.hxx
+++ b/include/vcl/embeddedfontshelper.hxx
@@ -96,7 +96,7 @@ public:
 */
 static void clearTemporaryFontFiles();
 
-~EmbeddedFontsHelper()
+~EmbeddedFontsHelper() COVERITY_NOEXCEPT_FALSE
 {
 activateFonts();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 137919] New: Button in a formulaire

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137919

Bug ID: 137919
   Summary: Button in a formulaire
   Product: LibreOffice
   Version: 7.0.3.1 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jlb...@gmx.fr

It is impossible to enter an URL when I tray to create an button (letters go
from right to left)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38093] Add an Outline View layout and editing mode to Writer

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=38093

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=54
   ||772

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 54772] Writer needs intrinsic collapsing outliner

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=54772

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=38
   ||093

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112491] SDBC-mismatch on alter field-properties in embedded Firebird database when editing primary key

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112491

--- Comment #18 from Julien Nabet  ---
(In reply to Julien Nabet from comment #17)
> ...
> Dmitry Yemanov added a comment - 17/Nov/15 10:52 AM
> "... Adding NOT NULL columns over a populated table is not allowed anymore,
> because such operations violate the NOT NULL constraint..."
> ...
Just realized that in our case, the table is empty, so bug of Firebird or do we
use a too old version (3.0.0)?
Could someone give a try on Firebird directly?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/svtools sfx2/source svtools/source

2020-11-01 Thread Noel Grandin (via logerrit)

 include/svtools/miscopt.hxx   |2 -
 sfx2/source/doc/iframe.cxx|4 +-
 svtools/source/config/miscopt.cxx |   54 +-
 3 files changed, 10 insertions(+), 50 deletions(-)

New commits:
commit f70f3a46b8de6397bbcc09e8b9c8be9451919ae1
Author: Noel Grandin 
AuthorDate: Sat Oct 31 18:04:35 2020 +0200
Commit: Noel Grandin 
CommitDate: Sun Nov 1 19:34:04 2020 +0100

use officecfg for IsPluginsEnabled

Change-Id: Id80ba8a87af7f87b8232949b70804b1a021b23d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105147
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/svtools/miscopt.hxx b/include/svtools/miscopt.hxx
index cbaf146f607e..90e3702a2838 100644
--- a/include/svtools/miscopt.hxx
+++ b/include/svtools/miscopt.hxx
@@ -57,8 +57,6 @@ class SVT_DLLPUBLIC SvtMiscOptions final : public 
utl::detail::Options
 
 boolDisableUICustomization() const;
 
-boolIsPluginsEnabled() const;
-
 sal_Int16   GetSymbolsSize() const;
 voidSetSymbolsSize( sal_Int16 eSet );
 ToolBoxButtonSize   GetSidebarIconSize() const;
diff --git a/sfx2/source/doc/iframe.cxx b/sfx2/source/doc/iframe.cxx
index e74ccc353b63..e37607c91a46 100644
--- a/sfx2/source/doc/iframe.cxx
+++ b/sfx2/source/doc/iframe.cxx
@@ -35,7 +35,7 @@
 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -155,7 +155,7 @@ sal_Bool SAL_CALL IFrameObject::load(
 const uno::Sequence < css::beans::PropertyValue >& /*lDescriptor*/,
 const uno::Reference < frame::XFrame >& xFrame )
 {
-if ( SvtMiscOptions().IsPluginsEnabled() )
+if ( officecfg::Office::Common::Misc::PluginsEnabled::get() )
 {
 DBG_ASSERT( !mxFrame.is(), "Frame already existing!" );
 VclPtr pParent = VCLUnoHelper::GetWindow( 
xFrame->getContainerWindow() );
diff --git a/svtools/source/config/miscopt.cxx 
b/svtools/source/config/miscopt.cxx
index 592f05b5c4eb..fe216fe263e0 100644
--- a/svtools/source/config/miscopt.cxx
+++ b/svtools/source/config/miscopt.cxx
@@ -44,31 +44,27 @@ using namespace ::com::sun::star;
 #define ROOTNODE_MISC   "Office.Common/Misc"
 
 // PROPERTYHANDLE defines must be sequential from zero for Commit/Load
-#define PROPERTYNAME_PLUGINSENABLED "PluginsEnabled"
-#define PROPERTYHANDLE_PLUGINSENABLED   0
 #define PROPERTYNAME_SYMBOLSET  "SymbolSet"
-#define PROPERTYHANDLE_SYMBOLSET1
+#define PROPERTYHANDLE_SYMBOLSET0
 #define PROPERTYNAME_TOOLBOXSTYLE   "ToolboxStyle"
-#define PROPERTYHANDLE_TOOLBOXSTYLE 2
+#define PROPERTYHANDLE_TOOLBOXSTYLE 1
 #define PROPERTYNAME_ICONTHEME  "SymbolStyle"
-#define PROPERTYHANDLE_SYMBOLSTYLE  3
+#define PROPERTYHANDLE_SYMBOLSTYLE  2
 #define PROPERTYNAME_SHOWLINKWARNINGDIALOG  "ShowLinkWarningDialog"
-#define PROPERTYHANDLE_SHOWLINKWARNINGDIALOG4
+#define PROPERTYHANDLE_SHOWLINKWARNINGDIALOG3
 #define PROPERTYNAME_DISABLEUICUSTOMIZATION "DisableUICustomization"
-#define PROPERTYHANDLE_DISABLEUICUSTOMIZATION   5
+#define PROPERTYHANDLE_DISABLEUICUSTOMIZATION   4
 #define PROPERTYNAME_MACRORECORDERMODE   "MacroRecorderMode"
-#define PROPERTYHANDLE_MACRORECORDERMODE6
+#define PROPERTYHANDLE_MACRORECORDERMODE5
 #define PROPERTYNAME_SIDEBARICONSIZE"SidebarIconSize"
-#define PROPERTYHANDLE_SIDEBARICONSIZE  7
+#define PROPERTYHANDLE_SIDEBARICONSIZE  6
 #define PROPERTYNAME_NOTEBOOKBARICONSIZE"NotebookbarIconSize"
-#define PROPERTYHANDLE_NOTEBOOKBARICONSIZE  8
+#define PROPERTYHANDLE_NOTEBOOKBARICONSIZE  7
 
 class SvtMiscOptions_Impl : public ConfigItem
 {
 private:
 ::std::vector> aList;
-boolm_bPluginsEnabled;
-boolm_bIsPluginsEnabledRO;
 sal_Int16   m_nSymbolsSize;
 boolm_bIsSymbolsSizeRO;
 ToolBoxButtonSize m_nSidebarIconSize;
@@ -121,9 +117,6 @@ public:
 bool IsMacroRecorderMode() const
 { return m_bMacroRecorderMode; }
 
-bool IsPluginsEnabled() const
-{ return m_bPluginsEnabled; }
-
 sal_Int16 GetSymbolsSize() const
 { return m_nSymbolsSize; }
 
@@ -204,8 +197,6 @@ SvtMiscOptions_Impl::SvtMiscOptions_Impl()
 // Init baseclasses first
 : ConfigItem( ROOTNODE_MISC )
 
-, m_bPluginsEnabled( false )
-, m_bIsPluginsEnabledRO( false )
 , m_nSymbolsSize( 0 )
 , m_bIsSymbolsSizeRO( false )
 , m_nSidebarIconSize( ToolBoxButtonSize::DontCare )
@@ -239,16 +230,6 @@ SvtMiscOptions_Impl::SvtMiscOptions_Impl()
 continue;
 switch( nProperty )
 {
-case PROPERTYHANDLE_PLUGINSENABLED :
-{
-if( !(seqValues[nProperty] >>= m_bPluginsEnabled) )
-{
-OSL_FAIL("Wrong type of \"Misc\\PluginsEnabled\"!" );
-}
-

[Libreoffice-bugs] [Bug 112491] SDBC-mismatch on alter field-properties in embedded Firebird database when editing primary key

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112491

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #17 from Julien Nabet  ---
I think it's not LO related but more Firebird related.

After having removed "ID" column + refresh tables, I tried these on SQL:
ALTER TABLE "EmployeesTasks" ADD "ID" INTEGER NOT NULL
or
ALTER TABLE "EmployeesTasks" ADD "ID" INTEGER GENERATED BY DEFAULT AS IDENTITY
both indicated on console:
warn:connectivity.firebird:63575:63575:connectivity/source/drivers/firebird/Util.cxx:57:
firebird_sdbc error:
*unsuccessful metadata update
*Cannot make field ID of table EmployeesTasks NOT NULL because there are NULLs
present


https://firebirdsql.org/file/documentation/release_notes/html/en/3_0/rnfb30-ddl-enhance.html
indicates:
"Identity columns are implicitly NOT NULL (non-nullable)."


http://tracker.firebirdsql.org/browse/CORE-5019 indicates

Dmitry Yemanov added a comment - 17/Nov/15 10:52 AM
"... Adding NOT NULL columns over a populated table is not allowed anymore,
because such operations violate the NOT NULL constraint..."

Dmitry Yemanov is one of the author of Firebird (see
https://firebirdsql.org/en/news/interview-with-dmitry-yemanov-firebird-core-developer/)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137918] New: Characters overlap feature

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137918

Bug ID: 137918
   Summary: Characters overlap feature
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: silvio.ge...@sinte.net

It could be a very useful feature to have the possibility to overlap (a least)
two (or more) character.

What I mean is to have the possibility to write a O overlapped with a ·, or a
character ovelapped with / to say contrary.

It could be useful in many occasion, in particular in math text.

another example comes from the need to have the "hat" character in Statistics.
There is not a overline with "hat" like "^".
If it would be possible to make characters ovelap ones could write β and than ^
overlapping.

I hope it is clear. It is something that in Latex is present and very used.

Let me know if you need more explanation on what I mean.

thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135514] calc: formula: 'label' references not properly adapted when moving cells | was: identical formulae give different values

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=135514

--- Comment #8 from tor...@yahoo.com ---
Suggested fix:
0: link to its label a cell referred to in another cell by its label;
1: prevent any attempt to move a linked cell alone, with a pop-up: ‘This cell
is linked to its label, must be moved with it.’ The user could select the cell
and its label, and move the pair or (why not?) a group of such pairs.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 134653] Undo produces different number of pages (large view/ lots of image anchored + footnotes) (steps in comment 4)

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=134653

Telesto  changed:

   What|Removed |Added

 CC||michael.st...@cib.de
Version|4.0.0.3 release |6.4.0.3 release

--- Comment #7 from Telesto  ---
Adding Michael Stahl
> So I confirm the behaviour, but I'm not sure, if this is a sufficient bug
> report. What causes the different number of pages?I don't have the tme for
> further investigations.
> 
> So I change status to NEW, but perhaps we can get a third opinion.

I'm betting on attempt to layout footnotes + timing factor at undo (or they
layout cache)
Anyhow the exact steps can't be used in older versions (as undo is blocked for
update index).

It's already broken 
Version: 6.4.0.0.beta1+ (x64)
Build ID: 20be5cd0bdc57d812bf34a2debfe48caa51de881
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: GL; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL

can't be reproduced with 6.3 and older because lacking undo steps
Version: 6.3.0.0.alpha0+
Build ID: da881f38c088c439f034e3404ca53e67389f
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137917] New: FILESAVE XLSX wrong export of Major and Minor interval of date axis

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137917

Bug ID: 137917
   Summary: FILESAVE XLSX wrong export of Major and Minor interval
of date axis
   Product: LibreOffice
   Version: 7.1.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Chart
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Created attachment 166912
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166912=edit
Chart with non automatic date axis

Open attached document and verify these settings for the x-axis in the chart:
Type Date
Resolution Days
Major interval 1 Month
Minor interval 7 Days

Save the file to xlsx format.

Reopen. The settings are now
Type Date
Resolution Automatic
Major interval Automatic
Minor interval Automatic

"Automatic" does not resolve to the original settings.

Excel is able to use the manual settings and a chart with such manual settings
made in Excel opens correctly in LibreOffice. Thus I think, it is an export
error.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Try to upgrade to Firebird 3.0.7

2020-11-01 Thread julien2412

Jan-Marek Glogowski wrote
> Am 01.11.20 um 14:29 schrieb julien2412:
>> ...
> Done. Uploaded Firebird-3.0.7.33374-0.tar.bz2 and removed the other 
> versions.

Thank you for the very fast feedback! :-)


Jan-Marek Glogowski wrote
>> Remark: last time, the biggest pb was to make it build on every envs (so
>> deal with env specific patches).
> 
> I was looking into building 3.0.7 when trying to build Firebird for 
> Windows Arm64. I'm really wondering, why we build Firebird on Windows 
> with a heavily patched configure, which doesn't support cross building 
> at all. Any reason not to use VS / msbuild solutions? Has anyone tried
> that?
> 
> We use msbuild for quite a few external dependencies, like Python.

I got no idea but perhaps git history may give some hints.

Julien



--
Sent from: 
http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 137905] Copying and pasting text from Word into Libreoffice pastes an image

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137905

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||108843, 102593
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #3 from V Stuart Foote  ---
For OP, could you find some Clipboard viewer to get a look at what the macOS
flavor of Word is placing on the system "Clipboard" pasteboard, it might help
to spot an issue. 

=-ref-=
something like this:

https://langui.net/clipboard-viewer/


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102593
[Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108843
[Bug 108843] [META] Clipboard bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102593

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||137905


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=137905
[Bug 137905] Copying and pasting text from Word into Libreoffice pastes an
image
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108843] [META] Clipboard bugs and enhancements

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108843

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||137905


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=137905
[Bug 137905] Copying and pasting text from Word into Libreoffice pastes an
image
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/inc sw/source

2020-11-01 Thread Bjoern Michaelsen (via logerrit)

 sw/inc/fchrfmt.hxx |2 +-
 sw/inc/txtatr.hxx  |3 +--
 sw/source/core/txtnode/fmtatr2.cxx |7 ---
 sw/source/core/txtnode/ndtxt.cxx   |   19 ---
 sw/source/core/txtnode/txtatr2.cxx |   17 +
 5 files changed, 23 insertions(+), 25 deletions(-)

New commits:
commit 38a71843fab65fed60d799bc7572608608bb70e8
Author: Bjoern Michaelsen 
AuthorDate: Sun Nov 1 13:33:58 2020 +0100
Commit: Bjoern Michaelsen 
CommitDate: Sun Nov 1 18:56:13 2020 +0100

sw/source/core/txtnode: ModifyNotification no more ...

Change-Id: I380b6c173d35865188c6d65f356a6e5d1165bd1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105138
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen 

diff --git a/sw/inc/fchrfmt.hxx b/sw/inc/fchrfmt.hxx
index acca285590ea..ef8719103f7c 100644
--- a/sw/inc/fchrfmt.hxx
+++ b/sw/inc/fchrfmt.hxx
@@ -41,7 +41,7 @@ public:
 SwFormatCharFormat( const SwFormatCharFormat& rAttr );
 
 private:
-virtual void Modify( const SfxPoolItem*, const SfxPoolItem* ) override;
+virtual void SwClientNotify(const SwModify&, const SfxHint&) override;
 
 /// @@@ public copy ctor, but no copy assignment?
 SwFormatCharFormat & operator= (const SwFormatCharFormat &) = delete;
diff --git a/sw/inc/txtatr.hxx b/sw/inc/txtatr.hxx
index fcc25811d63d..0cbd82fb826e 100644
--- a/sw/inc/txtatr.hxx
+++ b/sw/inc/txtatr.hxx
@@ -39,8 +39,7 @@ public:
 SwTextCharFormat( SwFormatCharFormat& rAttr, sal_Int32 nStart, sal_Int32 
nEnd );
 virtual ~SwTextCharFormat( ) override;
 
-// Passed from SwFormatCharFormat (no derivation from SwClient!).
-void ModifyNotification( const SfxPoolItem*, const SfxPoolItem* );
+void TriggerNodeUpdate(const sw::LegacyModifyHint&);
 bool GetInfo( SfxPoolItem const & rInfo ) const;
 
 // get and set TextNode pointer
diff --git a/sw/source/core/txtnode/fmtatr2.cxx 
b/sw/source/core/txtnode/fmtatr2.cxx
index 3a3694f3cd84..cf9d57dd79a9 100644
--- a/sw/source/core/txtnode/fmtatr2.cxx
+++ b/sw/source/core/txtnode/fmtatr2.cxx
@@ -84,10 +84,11 @@ SwFormatCharFormat* SwFormatCharFormat::Clone( SfxItemPool* 
) const
 }
 
 // forward to the TextAttribute
-void SwFormatCharFormat::Modify( const SfxPoolItem* pOld, const SfxPoolItem* 
pNew )
+void SwFormatCharFormat::SwClientNotify(const SwModify&, const SfxHint& rHint)
 {
-if( m_pTextAttribute )
-m_pTextAttribute->ModifyNotification( pOld, pNew );
+auto pLegacy = dynamic_cast();
+if(m_pTextAttribute && pLegacy)
+m_pTextAttribute->TriggerNodeUpdate(*pLegacy);
 }
 
 // forward to the TextAttribute
diff --git a/sw/source/core/txtnode/ndtxt.cxx b/sw/source/core/txtnode/ndtxt.cxx
index 951fc6d63012..62cf217563a1 100644
--- a/sw/source/core/txtnode/ndtxt.cxx
+++ b/sw/source/core/txtnode/ndtxt.cxx
@@ -759,11 +759,8 @@ SwTextNode *SwTextNode::SplitContentNode(const SwPosition 
& rPos,
 // pasting the frames, but that causes other problems that look
 // expensive to solve.
 const SfxPoolItem *pItem;
-if( HasWriterListeners() && SfxItemState::SET == pNode->GetSwAttrSet().
-GetItemState( RES_PAGEDESC, true,  ) )
-{
-pNode->ModifyNotification( pItem, pItem );
-}
+if(HasWriterListeners() && SfxItemState::SET == 
pNode->GetSwAttrSet().GetItemState(RES_PAGEDESC, true, ))
+pNode->TriggerNodeUpdate(sw::LegacyModifyHint(pItem, pItem));
 }
 return pNode;
 }
@@ -2484,12 +2481,12 @@ void SwTextNode::CutImpl( SwTextNode * const pDest, 
const SwIndex & rDestStart,
 
 // notify frames - before moving hints, because footnotes
 // want to find their anchor text frame in the follow chain
-SwInsText aInsHint( nDestStart, nLen );
-pDest->ModifyNotification( nullptr,  );
-sw::MoveText const moveHint(pDest, nDestStart, nTextStartIdx, nLen);
-CallSwClientNotify(moveHint);
-SwDelText aDelHint( nTextStartIdx, nLen );
-ModifyNotification( nullptr,  );
+SwInsText aInsHint(nDestStart, nLen);
+pDest->TriggerNodeUpdate(sw::LegacyModifyHint(nullptr, ));
+const sw::MoveText aMoveHint(pDest, nDestStart, nTextStartIdx, nLen);
+CallSwClientNotify(aMoveHint);
+const SwDelText aDelHint(nTextStartIdx, nLen);
+TriggerNodeUpdate(sw::LegacyModifyHint(nullptr, ));
 
 // 2. move attributes
 // Iterate over attribute array until the start of the attribute
diff --git a/sw/source/core/txtnode/txtatr2.cxx 
b/sw/source/core/txtnode/txtatr2.cxx
index fff614058984..5c5875610431 100644
--- a/sw/source/core/txtnode/txtatr2.cxx
+++ b/sw/source/core/txtnode/txtatr2.cxx
@@ -49,20 +49,21 @@ SwTextCharFormat::~SwTextCharFormat( )
 {
 }
 
-void SwTextCharFormat::ModifyNotification( const SfxPoolItem* pOld, const 
SfxPoolItem* pNew )
+void SwTextCharFormat::TriggerNodeUpdate(const sw::LegacyModifyHint& rHint)
 {
-const sal_uInt16 nWhich = pOld ? pOld->Which() : pNew ? pNew->Which() : 0;
-

[Libreoffice-bugs] [Bug 134653] Undo produces different number of pages (large view/ lots of image anchored + footnotes) (steps in comment 4)

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=134653

--- Comment #6 from Telesto  ---
I would go for randomly splitting footnotes, pushing images around
(anchoring).. 
Somehow the result is different depending on they way things are done

And there is they lovely timing aspect.. so depends on how fast everything
being processed and such.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2020-11-01 Thread Bjoern Michaelsen (via logerrit)

 sw/source/core/crsr/callnk.cxx |3 ++-
 sw/source/core/crsr/pam.cxx|   19 +--
 2 files changed, 11 insertions(+), 11 deletions(-)

New commits:
commit b24d809e0d89380850a0081c56353410d8616f9f
Author: Bjoern Michaelsen 
AuthorDate: Sat Oct 31 16:18:35 2020 +0100
Commit: Bjoern Michaelsen 
CommitDate: Sun Nov 1 18:53:26 2020 +0100

sw/source/core/crsr: Stop abusing observer pattern for code obfuscation.

Change-Id: I2423b70b2d6a9e90388bb7c83d886181cb268c0f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105136
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen 

diff --git a/sw/source/core/crsr/callnk.cxx b/sw/source/core/crsr/callnk.cxx
index 8c585524470e..d793a906815b 100644
--- a/sw/source/core/crsr/callnk.cxx
+++ b/sw/source/core/crsr/callnk.cxx
@@ -86,7 +86,8 @@ static void lcl_notifyRow(const SwContentNode* pNode, 
SwCursorShell & rShell)
 }
 
 SwFormatFrameSize aSize = pLine->GetFrameFormat()->GetFrameSize();
-pRow->ModifyNotification(nullptr, );
+SwModify aMod;
+pRow->SwClientNotify(aMod, sw::LegacyModifyHint(nullptr, ));
 }
 
 SwCallLink::~SwCallLink() COVERITY_NOEXCEPT_FALSE
diff --git a/sw/source/core/crsr/pam.cxx b/sw/source/core/crsr/pam.cxx
index 3d759416a387..5f9e3877f1e6 100644
--- a/sw/source/core/crsr/pam.cxx
+++ b/sw/source/core/crsr/pam.cxx
@@ -1121,16 +1121,15 @@ OUString SwPaM::GetText() const
 
 void SwPaM::InvalidatePaM()
 {
-const SwNode &_pNd = GetNode();
-const SwTextNode *_pTextNd = _pNd.GetTextNode();
-if (_pTextNd != nullptr)
-{
-// pretend that the PaM marks inserted text to recalc the portion...
-SwInsText aHint( Start()->nContent.GetIndex(),
-End()->nContent.GetIndex() - 
Start()->nContent.GetIndex() + 1 );
-SwModify *_pModify=const_cast(static_cast(_pTextNd));
-_pModify->ModifyNotification( nullptr, );
-}
+const SwNode& pNd = GetNode();
+SwTextNode* pTextNd = const_cast(pNd.GetTextNode());
+if(!pTextNd)
+return;
+// pretend that the PaM marks inserted text to recalc the portion...
+SwInsText aHint(
+Start()->nContent.GetIndex(),
+End()->nContent.GetIndex() - Start()->nContent.GetIndex() + 1);
+pTextNd->TriggerNodeUpdate(sw::LegacyModifyHint(nullptr, ));
 }
 
 void SwPaM::dumpAsXml(xmlTextWriterPtr pWriter) const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 137916] Report wizard doesn't open correctly

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137916

Julien Nabet  changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #3 from Julien Nabet  ---
Caolán: thought you might have some thoughts here about the crash or about the
fact the report wizard doesn't open.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137916] Report wizard doesn't open correctly

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137916

--- Comment #2 from Julien Nabet  ---
Created attachment 166911
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166911=edit
bt with debug symbols

The crash happens only with gen rendering + closing main window of report
without closing the subwindow with fields.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137905] Copying and pasting text from Word into Libreoffice pastes an image

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137905

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #2 from V Stuart Foote  ---
Created attachment 166910
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166910=edit
Paste special clipboard content from Word 365/2019 on Windows os

Can not confirm on Windows builds recent master/7.1.0

Default paste is expected text string, Calibri of Word 365/2019 is received as
unformatted text.

Attached shows the Special Paste dialog for when I select the text in Word 365,
the content of the system clipboard shows the formats Word 365 prvides.

macOS flavor of MS Word should provide similar, with similar priorities.

Need to see the clipboard content for macOS instance of MS Word, otherwise this
is really NOT A BUG as OP reports the Unformatted Text is available as a Paste
format.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137916] Report wizard doesn't open correctly

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137916

Julien Nabet  changed:

   What|Removed |Added

   Keywords||regression
 CC||rob...@familiegrosskopf.de

--- Comment #1 from Julien Nabet  ---
I don't reproduce this with LO Debian package 7.0.2.2.

Using gen rendering doesn't change anything except a crash when closing the
report window.

Robert: would you have some time to try to reproduce this? (it happens only on
7.1/master branch)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137916] New: Report wizard doesn't open correctly

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137916

Bug ID: 137916
   Summary: Report wizard doesn't open correctly
   Product: LibreOffice
   Version: 7.1.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: serval2...@yahoo.fr

Description:
On pc Debian x86-64 with master sources updated today, report wizard doesn't
open correctly, it open the same way as design report.

I noticed this on console:
java.lang.NullPointerException
at
com.sun.star.wizards.reportbuilder.layout.ReportBuilderLayouter.getTypeFromFieldName(ReportBuilderLayouter.java:491)
at
com.sun.star.wizards.reportbuilder.layout.ReportBuilderLayouter.insertFormattedField(ReportBuilderLayouter.java:735)
at
com.sun.star.wizards.reportbuilder.layout.ReportBuilderLayouter.insertFormattedField(ReportBuilderLayouter.java:723)
at
com.sun.star.wizards.reportbuilder.layout.ReportBuilderLayouter.insertPageHeader(ReportBuilderLayouter.java:1282)
at
com.sun.star.wizards.reportbuilder.layout.ReportBuilderLayouter.layout(ReportBuilderLayouter.java:137)
at
com.sun.star.wizards.reportbuilder.ReportBuilderImplementation.setPageOrientation(ReportBuilderImplementation.java:282)
at
com.sun.star.wizards.reportbuilder.ReportBuilderImplementation.getFrame(ReportBuilderImplementation.java:219)
at
com.sun.star.wizards.reportbuilder.ReportBuilderImplementation.getWizardParent(ReportBuilderImplementation.java:96)
at
com.sun.star.wizards.report.ReportWizard.startReportWizard(ReportWizard.java:458)
at
com.sun.star.wizards.report.CallReportWizard$ReportWizardImplementation.trigger(CallReportWizard.java:90)


Steps to Reproduce:
1. Launch Base
2. Create a brand new file HSQLDB embedded
3. Create a simple table
4. Click Report wizard

Actual Results:
No wizard

Expected Results:
Wizard should display


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 7.1.0.0.alpha1+
Build ID: 6e81dad4c2b23017cb0c996a4ab9a81e24fab16f
CPU threads: 12; OS: Linux 5.9; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137915] New: Hyperlinks to a local document fail in exported PDFs

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137915

Bug ID: 137915
   Summary: Hyperlinks to a local document fail in exported PDFs
   Product: LibreOffice
   Version: 7.0.3.1 release
  Hardware: All
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: wolfgang.schu...@gmail.com

Description:
Hyperlinks to local documents (i.e. PDFs) in cells of Calc (Libreoffice 7.0.3,
macosx) function very well direct from the .ods document. But open that links
in an exported PDF document is not possible. 

Steps to Reproduce:
1.Insert Hyperlink in a cell
2.Choose Document and select a Path to the document to link
3.Choose a name for the link
4. OK
5. Try the link in the .ods document (should be ok)
6. Export the .ods document to a PDF
7. Try the link in the PDF document (should fail, because the reported bug)

Actual Results:
If you try to open the link in the pdf on macos Catalina 10.15.7 the following
message appears: 
Das kann nicht Programm geoffnet werden.
-50

Expected Results:
should open the link correctly


Reproducible: Always


User Profile Reset: No



Additional Info:
no

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128264] [EDITING][FILESAVE]Formulas are shuffled maybe after saving the writer document

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128264

Dieter  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #10 from Dieter  ---
(In reply to Reinhard from comment #9)
> I remember I did the following:
> I copied a formula, edited the copy and saved the file. 
> After saving the file the copied formula was the same as the original again.
> 
> Changing the formula for a second time and saving again then worked like
> expected  - nothing changed for a second time.

I've tried to reproduce it (with the first formula of attachment from comment
1), but failed. 
So please try to reproduce it with the steps you've mentioned. Perhaps more
detailed informations are needed: a specific formula, an information how to
change it, ...

Sorry, but again NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Try to upgrade to Firebird 3.0.7

2020-11-01 Thread julien2412

Hello,

Would it be possible to make available Firebird 3.0.7 on
https://dev-www.libreoffice.org/src?

BTW, since we're only on Firebird-3.0.0.32483-0.tar.bz2, would it be
possible to remove from dev server:
- Firebird-3.0.4.33054-0.tar.bz2
- Firebird-3.0.2.32703-0.tar.bz2
- Firebird-3.0.1.32609-0.tar.bz2
since they've never been used.

I'm not sure to make it so if someone wants to work on it, don't hesitate.
Anyway, it'll be more relevant to work on 3.0.7 than on 3.0.4

Remark: about the alternative to use 4.0 Beta, it's a beta, there are more
work to do since it's a bigger change and we must deal with descendant
compatibility. Now, in the same way, if someone wants to give a try, don't
hesitate too!

Remark: last time, the biggest pb was to make it build on every envs (so
deal with env specific patches).

Julien



--
Sent from: 
http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105948

Dieter  changed:

   What|Removed |Added

 Depends on||134653


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=134653
[Bug 134653] Undo produces different number of pages (large view/ lots of image
anchored + footnotes) (steps in comment 4)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 134653] Undo produces different number of pages (large view/ lots of image anchored + footnotes) (steps in comment 4)

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=134653

Dieter  changed:

   What|Removed |Added

Summary|Undo produces different |Undo produces different
   |number of pages (large  |number of pages (large
   |view/ lots of image |view/ lots of image
   |anchored + footnotes)   |anchored + footnotes)
   ||(steps in comment 4)
 Blocks||105948
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 Whiteboard| QA:needsComment|

--- Comment #5 from Dieter  ---
(In reply to Telesto from comment #4)
> 1. Retry (as I notice it again)
> 2. Open the attached file
> 3. Update index -> 74 pages will be 71 (looks OK)
75 pags will be 71
> 4. CTRL+Z -> result 80 pages
result 79 pages
> 5. Update Index 74 pages
71 pages

So I confirm the behaviour, but I'm not sure, if this is a sufficient bug
report. What causes the different number of pages?I don't have the tme for
further investigations.

So I change status to NEW, but perhaps we can get a third opinion.

Version: 7.0.3.1 (x64)
Build ID: d7547858d014d4cf69878db179d326fc3483e082
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105948
[Bug 105948] [META] Undo/Redo bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Try to upgrade to Firebird 3.0.7

2020-11-01 Thread Terrence Enger

On Sun, 2020-11-01 at 06:29 -0700, julien2412 wrote:
> 
> Remark: last time, the biggest pb was to
make it build on every envs (so
> deal with env specific patches).

Funny thing: just on Friday, I was thinking about incorporting a newer
Firebird, and I looked at some of the work to upgrade to 3.0.0.  I
decided that, without access to multiple development systems, I had no
chance of doing anything useful.

Terry.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: canvas/source vcl/unx

2020-11-01 Thread Stephan Bergmann (via logerrit)

 canvas/source/cairo/cairo_canvasbitmap.hxx |2 +-
 canvas/source/vcl/canvasbitmap.hxx |2 +-
 vcl/unx/generic/gdi/salbmp.cxx |2 +-
 vcl/unx/generic/gdi/salgdi.cxx |2 +-
 vcl/unx/generic/window/salobj.cxx  |4 ++--
 5 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 3c77541ec0ba2c9f209c67da272f57093092ebdb
Author: Stephan Bergmann 
AuthorDate: Sun Nov 1 16:27:17 2020 +0100
Commit: Stephan Bergmann 
CommitDate: Sun Nov 1 18:07:47 2020 +0100

Transport Pixmap from GetNativeSurfaceHandle via css::uno::Any as sal_Int64

The values returned from GetNativeSurfaceHandle are only used in
cairocanvas::CanvasBitmap::getFastPropertyValue
(canvas/source/cairo/cairo_canvasbitmap.cxx), whose consumers in turn are 
(at
least the ones I could identify):

* OGLTransitionerImpl::setSlides
  (slideshow/source/engine/opengl/TransitionerImpl.cxx), passing the
  values on to X11SalObject::SetLeaveEnterBackgrounds, which extracts the
  Pixmap value to pass it on to XSetWindowBackgroundPixmap.

* X11SalBitmap::Create (vcl/unx/generic/gdi/salbmp.cxx), which extracts the
  Pixmap value to pass it on to X11SalBitmap::ImplCreateFromDrawable (as a
  Drawable) and to XFreePixmap.

While Pixmap XIDs are apparently 32-bit in the X11 protocol, see e.g.
, Xlib and 
the
underlying /usr/include/X11/Xdefs.h appear to be somewhat confused whether 
the
typedef for XID should be unsigned long (presumably stemming from times when
long was universally 32-bit) or CARD32, see e.g. 
.  So conservatively
stick to a 64-bit type here, even if it should only ever contain 32-bit 
values.

Change-Id: I26c3a2ff74cef092042a6e3648cd9a6f4a9e3aac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105144
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/canvas/source/cairo/cairo_canvasbitmap.hxx 
b/canvas/source/cairo/cairo_canvasbitmap.hxx
index 72a22ca0cfe3..a4e55f7b642a 100644
--- a/canvas/source/cairo/cairo_canvasbitmap.hxx
+++ b/canvas/source/cairo/cairo_canvasbitmap.hxx
@@ -108,7 +108,7 @@ namespace cairocanvas
 // 2 ... FIXME: leftover? ever called with this? always returns 
nothing (empty Any)
 // returned any contains either BitmapEx pointer or array of three Any 
value
 // 1st a bool value: true - free the pixmap after used by 
XFreePixmap, false do nothing, the pixmap is used internally in the canvas
-// 2nd the pixmap handle
+// 2nd the pixmap handle (sal_Int64)
 // 3rd the pixmap depth
 virtual css::uno::Any SAL_CALL getFastPropertyValue(sal_Int32 nHandle) 
override;
 virtual void SAL_CALL setFastPropertyValue(sal_Int32, const 
css::uno::Any&) override {}
diff --git a/canvas/source/vcl/canvasbitmap.hxx 
b/canvas/source/vcl/canvasbitmap.hxx
index 7eea1ac31383..1a95ce8c632c 100644
--- a/canvas/source/vcl/canvasbitmap.hxx
+++ b/canvas/source/vcl/canvasbitmap.hxx
@@ -101,7 +101,7 @@ namespace vclcanvas
 // 2 ... get X pixmap handle to alpha mask
 // returned any contains either BitmapEx pointer or array of three Any 
value
 // 1st a bool value: true - free the pixmap after used by 
XFreePixmap, false do nothing, the pixmap is used internally in the canvas
-// 2nd the pixmap handle
+// 2nd the pixmap handle (sal_Int64)
 // 3rd the pixmap depth
 virtual css::uno::Any SAL_CALL getFastPropertyValue(sal_Int32 nHandle) 
override;
 virtual void SAL_CALL setFastPropertyValue(sal_Int32, const 
css::uno::Any&) override {}
diff --git a/vcl/unx/generic/gdi/salbmp.cxx b/vcl/unx/generic/gdi/salbmp.cxx
index ac3b704f870b..aa3cd0ac034d 100644
--- a/vcl/unx/generic/gdi/salbmp.cxx
+++ b/vcl/unx/generic/gdi/salbmp.cxx
@@ -707,7 +707,7 @@ bool X11SalBitmap::Create(
 css::uno::Sequence< css::uno::Any > args;
 
 if( xFastPropertySet->getFastPropertyValue(bMask ? 2 : 1) >>= args ) {
-tools::Long pixmapHandle = {}; // spurious 
-Werror=maybe-uninitialized
+sal_Int64 pixmapHandle = {}; // spurious 
-Werror=maybe-uninitialized
 sal_Int32 depth;
 if( ( args[1] >>= pixmapHandle ) && ( args[2] >>= depth ) ) {
 
diff --git a/vcl/unx/generic/gdi/salgdi.cxx b/vcl/unx/generic/gdi/salgdi.cxx
index 06400197d490..35b9fe7fd2f8 100644
--- a/vcl/unx/generic/gdi/salgdi.cxx
+++ b/vcl/unx/generic/gdi/salgdi.cxx
@@ -573,7 +573,7 @@ css::uno::Any 
X11SalGraphics::GetNativeSurfaceHandle(cairo::SurfaceSharedPtr& rS
 cairo::X11Surface& 
rXlibSurface=dynamic_cast(*rSurface);
 css::uno::Sequence< css::uno::Any > args( 3 );
 args[0] <<= false;  // do not call XFreePixmap on it
-args[1] <<=

[Libreoffice-bugs] [Bug 137914] New: UI, mouse, cannot move cell content, only copy

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137914

Bug ID: 137914
   Summary: UI, mouse, cannot move cell content, only copy
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: stayb...@gmail.com

When mouse hovers over lower right corner of a cell a plus sign appears when no
keys pressed. Pressing any modifier keys has no effect. Can only copy contents
not move them. Tried with two different computers, mice. This happens in both
LibreOffice and OpenOffice.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137913] Clicking apply or apply to all should close they Select Your preferred user interface

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137913

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #2 from Regina Henschel  ---
It is good, that it stays open, so that you can try it out for your current
window. The illustration in the dialog might be to small for some users.

Unusual is the fact, that the bottom area does not follow the Help, OK, Cancel
pattern.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 137913] Clicking apply or apply to all should close they Select Your preferred user interface

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137913

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #2 from Regina Henschel  ---
It is good, that it stays open, so that you can try it out for your current
window. The illustration in the dialog might be to small for some users.

Unusual is the fact, that the bottom area does not follow the Help, OK, Cancel
pattern.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 137913] Clicking apply or apply to all should close they Select Your preferred user interface

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137913

Telesto  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

--- Comment #1 from Telesto  ---
As this topic which can be debated about.. I prefer closing the dialog

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 137913] Clicking apply or apply to all should close they Select Your preferred user interface

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137913

Telesto  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

--- Comment #1 from Telesto  ---
As this topic which can be debated about.. I prefer closing the dialog

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137913] New: Clicking apply or apply to all should close they Select Your preferred user interface

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137913

Bug ID: 137913
   Summary: Clicking apply or apply to all should close they
Select Your preferred user interface
   Product: LibreOffice
   Version: 7.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Clicking apply or apply to all should close they Select Your preferred user
interface 

Steps to Reproduce:
1. Open Writer 
2. View -> Select Your preferred user interface 

Actual Results:
Pressing Apply doesn't close the dialog

Expected Results:
I think it should close. If apply is they problem.. because it doesn't close
normally, please pick a different name


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha1+ (x86)
Build ID: eb55d1a29a1ffb9e5c8c3f2bcfd97bf3d3ca49f9
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135108] Err:540 is unjustified and persistent

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=135108

Eike Rathke  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |er...@redhat.com
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137912] Select Your preferred user interface uses screenshot of non-default icon set (breeze). Expected Collibere

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137912

--- Comment #1 from Telesto  ---
And next.. Toolbars are not unlocked by default (so no dotted bar at the left)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137912] New: Select Your preferred user interface uses screenshot of non-default icon set (breeze). Expected Collibere

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137912

Bug ID: 137912
   Summary: Select Your preferred user interface uses screenshot
of non-default icon set (breeze). Expected Collibere
   Product: LibreOffice
   Version: 7.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Select Your preferred user interface uses screenshot of non-default icon set

Steps to Reproduce:
1. Open Writer
2. View -> user Interface

Actual Results:
Grayish look (Breeze)

Expected Results:
Collibere


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha1+ (x86)
Build ID: eb55d1a29a1ffb9e5c8c3f2bcfd97bf3d3ca49f9
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137911] Select preferred interface has an odd screenshot for sidebar mode

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137911

--- Comment #1 from Telesto  ---
Created attachment 166909
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166909=edit
Screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137911] New: Select preferred interface has an odd screenshot for sidebar mode

2020-11-01 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137911

Bug ID: 137911
   Summary: Select preferred interface has an odd screenshot for
sidebar mode
   Product: LibreOffice
   Version: 7.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Select preferred interface has an odd screenshot for sidebar mode

Steps to Reproduce:
1. Open Writer
2. With the first tooltip -> click dialog settings
3. Click sidebar

Actual Results:
See screenshot

Expected Results:
Not a squeezed screenshot


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha1+ (x86)
Build ID: eb55d1a29a1ffb9e5c8c3f2bcfd97bf3d3ca49f9
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

1 2 >

1 - 100 of 188 matches

Mail list logo