[Libreoffice-commits] core.git: xmloff/source
xmloff/source/chart/SchXMLLegendContext.cxx | 91 ++--
xmloff/source/chart/SchXMLLegendContext.hxx |3
2 files changed, 24 insertions(+), 70 deletions(-)
New commits:
commit bcfd9f8f166aec58ee92642e8e70dc5a94a3119f
Author: Noel Grandin
AuthorDate: Wed Nov 18 19:21:37 2020 +0200
Commit: Noel Grandin
CommitDate: Thu Nov 19 08:59:11 2020 +0100
fastparser in SchXMLLegendContext
Change-Id: I9fe41436f4a5dd15867e172d4a43775ca49d29df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106070
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/xmloff/source/chart/SchXMLLegendContext.cxx
b/xmloff/source/chart/SchXMLLegendContext.cxx
index e043edb1f65f..758863a688c6 100644
--- a/xmloff/source/chart/SchXMLLegendContext.cxx
+++ b/xmloff/source/chart/SchXMLLegendContext.cxx
@@ -34,59 +34,14 @@
using namespace ::xmloff::token;
using namespace com::sun::star;
-namespace
-{
-
-enum LegendAttributeTokens
-{
-XML_TOK_LEGEND_POSITION,
-XML_TOK_LEGEND_OVERLAY,
-XML_TOK_LEGEND_X,
-XML_TOK_LEGEND_Y,
-XML_TOK_LEGEND_STYLE_NAME,
-XML_TOK_LEGEND_EXPANSION,
-XML_TOK_LEGEND_EXPANSION_ASPECT_RATIO,
-XML_TOK_LEGEND_WIDTH,
-XML_TOK_LEGEND_WIDTH_EXT,
-XML_TOK_LEGEND_HEIGHT,
-XML_TOK_LEGEND_HEIGHT_EXT
-};
-
-const SvXMLTokenMapEntry aLegendAttributeTokenMap[] =
-{
-{ XML_NAMESPACE_CHART, XML_LEGEND_POSITION,
XML_TOK_LEGEND_POSITION },
-{ XML_NAMESPACE_LO_EXT, XML_OVERLAY,XML_TOK_LEGEND_OVERLAY
},
-{ XML_NAMESPACE_SVG,XML_X, XML_TOK_LEGEND_X
},
-{ XML_NAMESPACE_SVG,XML_Y, XML_TOK_LEGEND_Y
},
-{ XML_NAMESPACE_CHART, XML_STYLE_NAME,
XML_TOK_LEGEND_STYLE_NAME },
-{ XML_NAMESPACE_STYLE, XML_LEGEND_EXPANSION,
XML_TOK_LEGEND_EXPANSION},
-{ XML_NAMESPACE_STYLE, XML_LEGEND_EXPANSION_ASPECT_RATIO,
XML_TOK_LEGEND_EXPANSION_ASPECT_RATIO},
-{ XML_NAMESPACE_SVG,XML_WIDTH, XML_TOK_LEGEND_WIDTH
},
-{ XML_NAMESPACE_CHART_EXT, XML_WIDTH,
XML_TOK_LEGEND_WIDTH_EXT},
-{ XML_NAMESPACE_SVG,XML_HEIGHT, XML_TOK_LEGEND_HEIGHT
},
-{ XML_NAMESPACE_CHART_EXT, XML_HEIGHT,
XML_TOK_LEGEND_HEIGHT_EXT },
-XML_TOKEN_MAP_END
-};
-
-class LegendAttributeTokenMap : public SvXMLTokenMap
-{
-public:
-LegendAttributeTokenMap(): SvXMLTokenMap( aLegendAttributeTokenMap ) {}
-virtual ~LegendAttributeTokenMap() {}
-};
-
-//a LegendAttributeTokenMap Singleton
-struct theLegendAttributeTokenMap : public rtl::Static<
LegendAttributeTokenMap, theLegendAttributeTokenMap > {};
-
-}//end anonymous namespace
-
SchXMLLegendContext::SchXMLLegendContext( SchXMLImportHelper& rImpHelper,
SvXMLImport& rImport ) :
SvXMLImportContext( rImport ),
mrImportHelper( rImpHelper )
{
}
-void SchXMLLegendContext::StartElement( const uno::Reference<
xml::sax::XAttributeList >& xAttrList )
+void SchXMLLegendContext::startFastElement( sal_Int32 /*nElement*/,
+const css::uno::Reference< css::xml::sax::XFastAttributeList >& xAttrList )
{
uno::Reference< chart::XChartDocument > xDoc =
mrImportHelper.GetChartDocument();
if( !xDoc.is() )
@@ -115,9 +70,6 @@ void SchXMLLegendContext::StartElement( const
uno::Reference< xml::sax::XAttribu
}
// parse attributes
-sal_Int16 nAttrCount = xAttrList.is()? xAttrList->getLength(): 0;
-const SvXMLTokenMap& rAttrTokenMap = theLegendAttributeTokenMap::get();
-
awt::Point aLegendPos;
bool bOverlay = false;
bool bHasXPosition=false;
@@ -131,16 +83,12 @@ void SchXMLLegendContext::StartElement( const
uno::Reference< xml::sax::XAttribu
OUString sAutoStyleName;
uno::Any aAny;
-for( sal_Int16 i = 0; i < nAttrCount; i++ )
+for( auto& aIter : sax_fastparser::castToFastAttributeList(xAttrList) )
{
-OUString sAttrName = xAttrList->getNameByIndex( i );
-OUString aLocalName;
-OUString aValue = xAttrList->getValueByIndex( i );
-sal_uInt16 nPrefix = GetImport().GetNamespaceMap().GetKeyByAttrName(
sAttrName, );
-
-switch( rAttrTokenMap.Get( nPrefix, aLocalName ))
+OUString aValue = aIter.toString();
+switch(aIter.getToken())
{
-case XML_TOK_LEGEND_POSITION:
+case XML_ELEMENT(CHART, XML_LEGEND_POSITION):
try
{
if(
SchXMLEnumConverter::getLegendPositionConverter().importXML( aValue, aAny,
GetImport().GetMM100UnitConverter() ) )
@@ -151,10 +99,10 @@ void SchXMLLegendContext::StartElement( const
uno::Reference< xml::sax::XAttribu
SAL_INFO("xmloff.chart", "Property Alignment (legend) not
found" );
}
break;
-case XML_TOK_LEGEND_OVERLAY:
+case XML_ELEMENT(LO_EXT,
[Libreoffice-bugs] [Bug 129386] Box with slide transitions can't be scrolled in the sidebar in iOS (app version 4.2)
https://bugs.documentfoundation.org/show_bug.cgi?id=129386 --- Comment #8 from Nicolas Christener --- Technically this issue has been fixed in 6.4.0 (16) - the box is big enough to fit the whole content; there's no need to scroll it. But there are other boxes that are not scrollable - even ones that can have infinite entries. I suggest we close this issue. In parallel I'll add a new issue on GH to have an up to date description. Thanks a lot to the Collabora team for taking care of this! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116211] LO Send by email fails in Writer / Calc / Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=116211 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||8316 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138316] sending email through Mailspring (Linux) provides input/output error
https://bugs.documentfoundation.org/show_bug.cgi?id=138316 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||6211 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129512] Copy & paste across iOS documents
https://bugs.documentfoundation.org/show_bug.cgi?id=129512 --- Comment #3 from Nicolas Christener --- Hi Tor This issue is fixed in 6.4.0 (16). It works for both cases: using the app in a multitasking fashion (two documents open in parallel) as well as working with two different documents sequentially. This issue can be closed now. Thanks a lot to the Collabora team and especially Tor for taking care of this! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86725] Comments disappearing
https://bugs.documentfoundation.org/show_bug.cgi?id=86725 --- Comment #23 from avisek kumar --- Saritha Splendor are the best residential place to stay in Bangalore as it offers ease of commute to major locales of Bangalore, and its superior class construction is one of the eye-openers! https://www.homes247.in/property/bangalore/kogilu-cross/adarsh-greens-626 https://www.homes247.in/property/bangalore/itpl-main-road/saritha-splendor-679 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90563] LibreOffice Calc crashes when attempting to format page
https://bugs.documentfoundation.org/show_bug.cgi?id=90563 --- Comment #14 from Guadalupe Thompson --- The LibreOffice requires lighter specs than the MS Office. The major thing is that the product is free of cost on https://www.resumehelpservices.com/dragonresume-com-review/ and I think this should be highlighted for this generosity of the company. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137989] Bullet Journal style Bullets
https://bugs.documentfoundation.org/show_bug.cgi?id=137989 alias...@tutanota.com changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86725] Comments disappearing
https://bugs.documentfoundation.org/show_bug.cgi?id=86725 --- Comment #22 from avisek kumar --- If you are looking for the best ready to move flats in Bangalore. then visit : https://www.homes247.in/property/bangalore/electronic-city-phase-1/mjr-clique-hercules-670 https://www.homes247.in/property/bangalore/sarjapur-road/mana-capitol-607 https://www.homes247.in/property/bangalore/whitefield/sobha-windsor-778 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86725] Comments disappearing
https://bugs.documentfoundation.org/show_bug.cgi?id=86725 --- Comment #21 from avisek kumar --- Adarsh Greens near Kogilu Cross is another cluster of apartments that is slowly rising in the active region of North Bangalore. https://www.homes247.in/property/bangalore/kogilu-cross/adarsh-greens-626 https://www.homes247.in/property/bangalore/itpl-main-road/saritha-splendor-679 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86725] Comments disappearing
https://bugs.documentfoundation.org/show_bug.cgi?id=86725 --- Comment #20 from avisek kumar --- If you are looking for the best ready to move flats in Bangalore. then visit : https://www.homes247.in/property/bangalore/electronic-city-phase-1/mjr-clique-hercules-670 https://www.homes247.in/property/bangalore/sarjapur-road/mana-capitol-607 https://www.homes247.in/property/bangalore/whitefield/sobha-windsor-778 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137989] Bullet Journal style Bullets
https://bugs.documentfoundation.org/show_bug.cgi?id=137989 --- Comment #2 from alias...@tutanota.com --- I am referring to different bullets for list level. Give a quick search for "bullet journals" and you'll see exactly what I'm referring to. In a bullet journal the bullets change in a task list on different factors such as completed, high priority, etc. It is a very popular way to journal and usually done in a paper notebook. Unlike a task application a bullet journal is a more detailed way of organizing thoughts, priorities, and anything you want. LibreOffice would be a great application to do it digitally if it had the option to have bullets that could be tweaked. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125328] Printing - file is very large using Microsoft Print to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=125328 --- Comment #18 from Timur --- I can't test now, but PPTX is LO created, which may be important. Needs to be tested from MSO and also resaved there as PPTX and tested in LO. Also can be seen via unzip which exactly image makes the problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86725] Comments disappearing
https://bugs.documentfoundation.org/show_bug.cgi?id=86725 --- Comment #19 from avisek kumar --- properties for sale in Bangalore- https://www.homes247.in/property/bangalore/electronic-city-phase-2/shriram-liberty-square-509 https://www.homes247.in/property/bangalore/budigere-cross/shriram-yuva-808 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86725] Comments disappearing
https://bugs.documentfoundation.org/show_bug.cgi?id=86725 --- Comment #18 from avisek kumar --- Buy luxury properties in Bangalore at top locations from Homes247.in https://www.homes247.in/property/bangalore/sarjapur-road/shriram-chirping-woods-80 https://www.homes247.in/property/bangalore/whitefield/vaswani-menlo-park-255 https://www.homes247.in/property/bangalore/electronic-city-phase-1/psr-krish-kamal-739 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice font blurry on MacBook Pro's Internal HiDPI Retina Display running macOS Big Sur 11.0.1
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #47 from lupu...@web.de --- I'm sorry for drifting away a little bit with my comments about dark mode and so on. Thats just because I am new to the code base and I'm trying to understand, how the things work, so that I maybe can find a solution for this issue (this has the first priority). As far as I understand it right now, LO is drawing everything in a NSView, it doesn't uses the native widgets of Cocoa (what would explain, that it's not that performant as a native application). But it still uses drawing methods from the Carbon framework? If so, I don't think, that Skia will help here in any way, because using the native drawing code of Apple will be necessary either way for drawing the components. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86725] Comments disappearing
https://bugs.documentfoundation.org/show_bug.cgi?id=86725 --- Comment #17 from avisek kumar --- Buy luxury properties in Bangalore at top locations from Homes247.in https://www.homes247.in/property/bangalore/sarjapur-road/shriram-chirping-woods-80 https://www.homes247.in/property/bangalore/whitefield/vaswani-menlo-park-255 https://www.homes247.in/property/bangalore/electronic-city-phase-1/psr-krish-kamal-739 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86725] Comments disappearing
https://bugs.documentfoundation.org/show_bug.cgi?id=86725 --- Comment #16 from avisek kumar --- properties for sale in Bangalore- https://www.homes247.in/property/bangalore/electronic-city-phase-2/shriram-liberty-square-509 https://www.homes247.in/property/bangalore/budigere-cross/shriram-yuva-808 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86725] Comments disappearing
https://bugs.documentfoundation.org/show_bug.cgi?id=86725 avisek kumar changed: What|Removed |Added URL|https://www.homes247.in/fla |https://www.homes247.in/ |ts-in-bangalore | --- Comment #15 from avisek kumar --- Flats ,Homes and Houses for sale in Bangalore - https://www.homes247.in/flats-in-bangalore https://www.homes247.in/house-for-sale-in-bangalore https://www.homes247.in/home-for-sale-in-bangalore -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138318] Text boxes moved and cannot be resized or moved back to their original places
https://bugs.documentfoundation.org/show_bug.cgi?id=138318 Timur changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Timur --- Wrong but report. You need to search for the issue in existing bugs and, if not found, to submit clear Reproducible steps, avoiding personal talk. https://wiki.documentfoundation.org/QA/BugReport -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122710] PRINT DIALOG: For "Pages to print" field interpret space as separator for a list of distinct pages to print
https://bugs.documentfoundation.org/show_bug.cgi?id=122710 --- Comment #15 from Michael Weghorn --- (In reply to sdc.blanco from comment #14) > Created attachment 167384 [details] > current draft of proposed help page on print selections > > My query (comment 2) that brought this bug report to life was motivated the > intention to make a help page about printing selections (see bug 73398 and > bug 107192). Thanks to Michael Weghorn's testing, partial ranges are now > added to the planned patch. I have attached a screenshot of the "current > draft" for the page. Comments, suggestions, criticisms are welcome. Thanks, looks good to me. (Just an "s" is missing in "for a list of page**s**" in section "Printing a range of pages", step 3, third bullet point). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128502] Not possible to use the multitasking feature of iOS 13.x
https://bugs.documentfoundation.org/show_bug.cgi?id=128502 --- Comment #36 from Nicolas Christener --- I just tested this with 6.4.0 (16) and it's working quite well now. Cool! @Tor: there are some things I encountered (mainly not rendered tiles in one document) - I'll add a new issue for this. So the question is: do you have any plans regarding this feature (aka: are you still working on it?) or shall we close this one for now? Anyway: thanks a lot to the Collabora team and especiall Tor for taking care of this! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138303] Is it reasonable to send money from Paypal to Cash App?
https://bugs.documentfoundation.org/show_bug.cgi?id=138303 Timur changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138303] Is it reasonable to send money from Paypal to Cash App?
https://bugs.documentfoundation.org/show_bug.cgi?id=138303 Timur changed: What|Removed |Added Resolution|--- |INVALID Component|BASIC |deletionRequest Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86725] Comments disappearing
https://bugs.documentfoundation.org/show_bug.cgi?id=86725 avisek kumar changed: What|Removed |Added URL||https://www.homes247.in/fla ||ts-in-bangalore --- Comment #14 from avisek kumar --- Buy villas and plots in Bangalore - https://www.homes247.in/villas-in-bangalore https://www.homes247.in/plots-in-bangalore -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137983] Bug: footnote reference
https://bugs.documentfoundation.org/show_bug.cgi?id=137983 Dieter changed: What|Removed |Added Whiteboard| QA:needsComment| CC||dgp-m...@gmx.de Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Dieter --- I can't confirm with Version: 7.0.3.1 (x64) Build ID: d7547858d014d4cf69878db179d326fc3483e082 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: threaded Not sure, which version do you use. If it is not the actual version, please update. If you already use LO 7.0.3.1 please restart in SafeMode (Help => Restart in SafeMode) and retest. If the bug doesn't occur, you should reset your user profile Does this solve your problem? => NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137989] Bullet Journal style Bullets
https://bugs.documentfoundation.org/show_bug.cgi?id=137989 Dieter changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||dgp-m...@gmx.de --- Comment #1 from Dieter --- You can choose a bullet for every level of the bullet list. Just choose the customise tab in the bullets and numbering diaog. Does this solve your problem? => NEEDINFO I assume, yo don't talk about different bullets for the same list level, because I've never seen that. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68810] VIEWING: WMF image is black / dark in Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=68810 Aron Budea changed: What|Removed |Added Component|Writer |graphics stack Keywords||bibisectRequest --- Comment #23 from Aron Budea --- (In reply to Aron Budea from comment #21) > On Linux, it still doesn't look correct in the latest master bibisect repo > build, it changed from pitch black to visible, but dark in the center > between 6.4 and 7.0 (see screenshot). The change occurred in two steps, first the rectangle turned white with the following commit: https://cgit.freedesktop.org/libreoffice/core/commit/?id=828504974d70111e4a35b31d579cf42fe660a660 author Armin Le Grand (Collabora) 2020-02-21 16:58:17 +0100 committer Armin Le Grand 2020-02-21 20:16:59 +0100 "tdf#130768 speedup huge pixel graphics Cairo" Probably the above commit made the actual change, but there was a bug in it, which was fixed in the following commit, resulting in the look in attachment 167381. https://cgit.freedesktop.org/libreoffice/core/commit/?id=5f58ffce789c15e3849bceb9fe4844d838e9c40e author Armin Le Grand 2020-02-27 17:21:16 +0100 committer Armin Le Grand 2020-02-27 19:24:46 +0100 "tdf#130951 Use the correct OutputDevice" Based on the commits, and the experience in Windows it seems more of an issue related to graphics stack rather than the handling of the file format. Re-adding bibisectRequest for a reverse bibisect in Windows in 6.0, default rendering to see what fixed the issue there. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138322] [writer] wrong button given on tip of the day 153/222
https://bugs.documentfoundation.org/show_bug.cgi?id=138322 --- Comment #2 from Daniel Frost --- Created attachment 167393 --> https://bugs.documentfoundation.org/attachment.cgi?id=167393=edit Screenshot of English version -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138235] Database creation from Calc spreadsheet not happening
https://bugs.documentfoundation.org/show_bug.cgi?id=138235 Robert Großkopf changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED --- Comment #3 from Robert Großkopf --- (In reply to Linde Merrick from comment #2) > > Thank you for this Robert. Now managed to get the database and print off my > labels. So I have set this bug to RESOLVED and NOTABUG. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138322] [writer] wrong button given on tip of the day 153/222
https://bugs.documentfoundation.org/show_bug.cgi?id=138322 --- Comment #1 from Daniel Frost --- Created attachment 167392 --> https://bugs.documentfoundation.org/attachment.cgi?id=167392=edit Screenshot of German version -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138322] New: [writer] wrong button given on tip of the day 153/222
https://bugs.documentfoundation.org/show_bug.cgi?id=138322 Bug ID: 138322 Summary: [writer] wrong button given on tip of the day 153/222 Product: LibreOffice Version: 7.0.1.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: o...@frostinfo.de Description: The tip of the day 153/222 describes how to apply headline formats by key combinations. For level one STRG + 1 is given (fine). But level two specifies as different combination: GERMAN: ALT + 2. ENGLISH UK: %MOD11 + 2 See screenshots. Note: I am not sure if this Steps to Reproduce: 1. Read tip of the day no. 153/222 Actual Results: A wrong key combination is given for the second level. Expected Results: The correct combination with STRG is shown. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.0.1.2 (x86) Build ID: 7cbcfc562f6eb6708b5ff7d7397325de9e764452 CPU threads: 6; OS: Windows 10.0 Build 17763; UI render: default; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL Using LO portable. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards
https://bugs.documentfoundation.org/show_bug.cgi?id=124176 --- Comment #141 from Commit Notification --- Roman Kuznetsov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6d74413e5d2b03d84a2f8f748827234b2c22d62c tdf#124176 use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/svtools
include/svtools/DocumentToGraphicRenderer.hxx |5 + include/svtools/HtmlWriter.hxx |5 + include/svtools/PlaceEditDialog.hxx|4 +--- include/svtools/acceleratorexecute.hxx |5 + include/svtools/accessibilityoptions.hxx |5 + include/svtools/addresstemplate.hxx|5 + include/svtools/apearcfg.hxx |5 + include/svtools/asynclink.hxx |5 + include/svtools/bindablecontrolhelper.hxx |6 +- include/svtools/borderhelper.hxx |5 + include/svtools/borderline.hxx |5 + include/svtools/brwbox.hxx |6 +- include/svtools/brwhead.hxx|5 + include/svtools/cliplistener.hxx |5 + include/svtools/collatorres.hxx|5 + include/svtools/colorcfg.hxx |4 +--- include/svtools/colrdlg.hxx|5 + include/svtools/ctrlbox.hxx|6 +- include/svtools/ctrltool.hxx |5 + include/svtools/dialogclosedlistener.hxx |6 +- include/svtools/editbrowsebox.hxx |6 +- include/svtools/ehdl.hxx |5 + include/svtools/embedhlp.hxx |5 + include/svtools/embedtransfer.hxx |5 + include/svtools/extcolorcfg.hxx|4 +--- include/svtools/filechangedchecker.hxx |5 + include/svtools/fontsubstconfig.hxx|6 +- include/svtools/framestatuslistener.hxx|5 + include/svtools/genericunodialog.hxx |6 +- include/svtools/helpids.h |5 + include/svtools/helpopt.hxx|5 + include/svtools/htmlcfg.hxx|6 +- include/svtools/htmlkywd.hxx |5 + include/svtools/htmlout.hxx|5 + include/svtools/htmltokn.h |5 + include/svtools/imagemgr.hxx |5 + include/svtools/imageresourceaccess.hxx|5 + include/svtools/imgdef.hxx |5 + include/svtools/indexentryres.hxx |6 +- include/svtools/inettbc.hxx|5 + include/svtools/insdlg.hxx |5 + include/svtools/javacontext.hxx|5 + include/svtools/javainteractionhandler.hxx |5 + include/svtools/langhelp.hxx |5 + include/svtools/langtab.hxx|5 + include/svtools/menuoptions.hxx|5 + include/svtools/miscopt.hxx|5 + include/svtools/openfiledroptargetlistener.hxx |5 + include/svtools/optionsdrawinglayer.hxx|5 + include/svtools/parhtml.hxx|5 + include/svtools/parrtf.hxx |5 + include/svtools/place.hxx |5 + include/svtools/popupmenucontrollerbase.hxx|5 + include/svtools/popupwindowcontroller.hxx |5 + include/svtools/printoptions.hxx |5 + include/svtools/prnsetup.hxx |5 + include/svtools/querydelete.hxx|5 + include/svtools/restartdialog.hxx |5 + include/svtools/rtfkeywd.hxx |5 + include/svtools/rtfout.hxx |6 +- include/svtools/rtftoken.h |5 + include/svtools/ruler.hxx |5 + include/svtools/sampletext.hxx |5 + include/svtools/scriptedtext.hxx |6 +- include/svtools/sfxecode.hxx |6 +- include/svtools/slidesorterbaropt.hxx |5 + include/svtools/soerr.hxx |5 + include/svtools/statusbarcontroller.hxx|5 + include/svtools/strings.hrc|4 +--- include/svtools/stringtransfer.hxx |5 + include/svtools/svparser.hxx |5 + include/svtools/svtdllapi.h|5 + include/svtools/svtresid.hxx |5 + include/svtools/tabbar.hxx |5 + include/svtools/templatefoldercache.hxx|6 +- include/svtools/toolbarmenu.hxx|5 + include/svtools/toolboxcontroller.hxx |5 + include/svtools/unitconv.hxx |5 + include/svtools/unoevent.hxx |5 + include/svtools/unoimap.hxx|5 + include/svtools/urlfilter.hxx |5 + include/svtools/valueset.hxx
[Libreoffice-commits] core.git: compilerplugins/clang connectivity/source dbaccess/source forms/source reportdesign/source sc/source sw/source vbahelper/source
compilerplugins/clang/stringview.cxx | 34
compilerplugins/clang/test/stringview.cxx |8 ++
connectivity/source/commontools/dbtools2.cxx |2
dbaccess/source/core/dataaccess/databasedocument.cxx |2
forms/source/xforms/resourcehelper.cxx|6 +-
reportdesign/source/ui/inspection/GeometryHandler.cxx |2
sc/source/ui/vba/vbaapplication.cxx |4 -
sc/source/ui/vba/vbaaxis.cxx | 50 +-
sc/source/ui/vba/vbaformat.cxx| 50 +-
sc/source/ui/vba/vbaformatcondition.cxx |8 +-
sc/source/ui/vba/vbaformatconditions.cxx | 16 ++---
sc/source/ui/vba/vbapagebreaks.cxx|2
sc/source/ui/vba/vbarange.cxx | 24
sc/source/ui/vba/vbastyle.cxx | 14 ++---
sc/source/ui/vba/vbastyles.cxx|8 +-
sw/source/filter/html/swhtml.cxx |8 +-
sw/source/ui/vba/vbadocument.cxx |2
sw/source/ui/vba/vbafield.cxx |2
sw/source/ui/vba/vbaoptions.cxx |2
sw/source/ui/vba/vbaparagraphformat.cxx |2
sw/source/ui/vba/vbarange.cxx |4 -
sw/source/ui/vba/vbaselection.cxx |8 +-
sw/source/ui/vba/vbastyles.cxx|2
sw/source/ui/vba/vbatabstops.cxx |2
sw/source/ui/vba/vbaview.cxx |6 +-
vbahelper/source/vbahelper/vbahelper.cxx |2
26 files changed, 156 insertions(+), 114 deletions(-)
New commits:
commit 19926ed35ebb623fc896942b1f232b83edf1fc1e
Author: Stephan Bergmann
AuthorDate: Wed Nov 18 23:30:24 2020 +0100
Commit: Stephan Bergmann
CommitDate: Thu Nov 19 07:09:58 2020 +0100
loplugin:stringview: Flag empty string converted to string view
Change-Id: Idf412dc5f235230512160cb4fb7e1a00baa1cfa7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106085
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/compilerplugins/clang/stringview.cxx
b/compilerplugins/clang/stringview.cxx
index 530cf43d95a0..5a70d01de841 100644
--- a/compilerplugins/clang/stringview.cxx
+++ b/compilerplugins/clang/stringview.cxx
@@ -52,6 +52,7 @@ public:
bool VisitCXXConstructExpr(CXXConstructExpr const*);
bool VisitFunctionDecl(FunctionDecl const*);
bool VisitCXXOperatorCallExpr(CXXOperatorCallExpr const*);
+bool VisitImplicitCastExpr(ImplicitCastExpr const*);
};
bool StringView::VisitCallExpr(CallExpr const* callExpr)
@@ -180,6 +181,39 @@ bool StringView::VisitCXXConstructExpr(CXXConstructExpr
const* constructExpr)
return true;
}
+bool StringView::VisitImplicitCastExpr(ImplicitCastExpr const* expr)
+{
+if (ignoreLocation(expr))
+{
+return true;
+}
+if
(!loplugin::TypeCheck(expr->getType()).ClassOrStruct("basic_string_view").StdNamespace())
+{
+return true;
+}
+auto const e =
dyn_cast(expr->getSubExprAsWritten()->IgnoreParens());
+if (e == nullptr)
+{
+return true;
+}
+if (e->getNumArgs() != 0)
+{
+return true;
+}
+auto const tc = loplugin::TypeCheck(e->getType());
+if (!(tc.Class("OString").Namespace("rtl").GlobalNamespace()
+ || tc.Class("OUString").Namespace("rtl").GlobalNamespace()))
+{
+return true;
+}
+report(DiagnosticsEngine::Warning,
+ "instead of an empty %0, pass an empty
'%select{std::string_view|std::u16string_view}1'",
+ e->getLocation())
+<< e->getType() <<
(tc.Class("OString").Namespace("rtl").GlobalNamespace() ? 0 : 1)
+<< e->getSourceRange();
+return true;
+}
+
loplugin::Plugin::Registration stringview("stringview");
}
diff --git a/compilerplugins/clang/test/stringview.cxx
b/compilerplugins/clang/test/stringview.cxx
index 96d4927e533a..3c15d9cc4437 100644
--- a/compilerplugins/clang/test/stringview.cxx
+++ b/compilerplugins/clang/test/stringview.cxx
@@ -93,4 +93,12 @@ void f4(OUString s1, OUString s2)
}
}
+void f5()
+{
+// expected-error@+1 {{instead of an empty 'rtl::OString', pass an empty
'std::string_view' [loplugin:stringview]}}
+call_view(OString());
+// expected-error@+1 {{instead of an empty 'rtl::OUString', pass an empty
'std::u16string_view' [loplugin:stringview]}}
+call_view(OUString());
+}
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s
cinkeys+=0=break: */
diff --git a/connectivity/source/commontools/dbtools2.cxx
b/connectivity/source/commontools/dbtools2.cxx
index b2626dd6fbe6..59f7dd50136e 100644
--- a/connectivity/source/commontools/dbtools2.cxx
+++ b/connectivity/source/commontools/dbtools2.cxx
@@ -380,7 +380,7 @@ OUString
[Libreoffice-bugs] [Bug 138028] Error 1335. libreoffice1.cab in the LibreOffice_7.0.3_Win_x64 pack is corrupt
https://bugs.documentfoundation.org/show_bug.cgi?id=138028 --- Comment #5 from Mike Kaganski --- (In reply to Blesson Thomas from comment #4) > So does it mean that both these browsers are unable to download the x64 file > correctly from the server? Have you tried all the steps in the FAQ mentioned in comment 2? It included advice to try different mirrors (in case when a mirror contains a broken binary, and it happens to be picked reliably by GeoIP - if it happens to be that, then please report the exact broken mirror address here); and disabling antivirus (because it's known that sometimes it interferes with installation). Of course, disabling AV is the least advisable during the download, because it has a risk, but if your problem is caused by that... maybe it's better to get the installer on a different system with a different antivirus, check the checksum, and bring home on a flash drive. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138321] New: Comments disappear after saving document.
https://bugs.documentfoundation.org/show_bug.cgi?id=138321 Bug ID: 138321 Summary: Comments disappear after saving document. Product: LibreOffice Version: 7.0.2.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: larrywbrad...@gmail.com Description: Need to try to recreate exactly what happened, but wanted to capture this before I forget and move on to other matters. Basically, created a comment, did some other editing and formatting, saved the document, then re-opened it and the comment was no longer in the document. Apologize, but cannot try to recreate it until possibly another day or so. This is not the first time this has happened. Actual Results: Comment disappears upon saving and re-opening, but not always. Expected Results: Expect comment to save and "stay saved." Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: TextDocument [Information guessed from browser] OS: Linux (All) OS is 64bit: yes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138117] Custom toolbar icons rendered small even on option Large and not at all on option Small
https://bugs.documentfoundation.org/show_bug.cgi?id=138117 Buovjaga changed: What|Removed |Added Version|6.4.6.2 release |6.1.0.3 release --- Comment #5 from Buovjaga --- Ok, so let's call 6.1 the first bad release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124573] Printer extremely slow for each page with anything but normal print setting
https://bugs.documentfoundation.org/show_bug.cgi?id=124573 --- Comment #14 from Buovjaga --- (In reply to 76kenreed from comment #13) > So, we don't seem to have made any improvement, at least not in v. > 6.4.7.2. I'm concerned that this newer version is not even printing as well > as the previous version. I'm not sure I want to try the beta 7.1 version, > since things seem to be going backward for me. Recommendations? At least a 7.1 daily build will not replace your stable build, but install alongside it: https://dev-builds.libreoffice.org/daily/master/current.html -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/comphelper
include/comphelper/lok.hxx | 10 --
1 file changed, 10 deletions(-)
New commits:
commit 8f79f590662145b054661846e018a4fc1837db8a
Author: Ashod Nakashian
AuthorDate: Fri Sep 18 17:11:09 2020 -0400
Commit: Ashod Nakashian
CommitDate: Thu Nov 19 05:55:00 2020 +0100
lok: remove unused API
Change-Id: Ibf3039f0f5d8b580e8d93c77d7adb9c4b90ba67a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105365
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian
diff --git a/include/comphelper/lok.hxx b/include/comphelper/lok.hxx
index b8276ea49fc6..2391ceab3661 100644
--- a/include/comphelper/lok.hxx
+++ b/include/comphelper/lok.hxx
@@ -26,16 +26,6 @@ namespace comphelper::LibreOfficeKit
COMPHELPER_DLLPUBLIC void setActive(bool bActive = true);
-// Call either setMobilePhone() or setTablet() for a view, and at most once.
(If neither is called,
-// the view is assumed to be on a desktop browser.) In the future, this will
possibly be changed
-// into using an enum for the kind of the view, that can be DESKTOP,
MOBILEPHONE, or TABLET.
-
-// Tell that LOK view is on a mobile phone (regardless what its pixel
resolution is, whether its form factor is "phablet" or not)
-COMPHELPER_DLLPUBLIC void setMobilePhone(int nViewId);
-
-// Tell that LOK view is on a tablet
-COMPHELPER_DLLPUBLIC void setTablet(int nViewId);
-
enum class statusIndicatorCallbackType { Start, SetValue, Finish };
COMPHELPER_DLLPUBLIC void setStatusIndicatorCallback(void (*callback)(void
*data, statusIndicatorCallbackType type, int percent), void *data);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 138117] Custom toolbar icons rendered small even on option Large and not at all on option Small
https://bugs.documentfoundation.org/show_bug.cgi?id=138117 --- Comment #4 from david mccracken --- On further investigation I see that all versions of LO in Windows after 6.0.7.3 screw up user-defined toolbar icons in one way or another by producing bad toolbar image files. I haven't tested any newer releases in Linux. Replacing these with ones produced by version 6.0.7.3 or hand-crafted (I use Gimp) fixes the problem. See https://ask.libreoffice.org/en/question/195561/toolbar-custom-icon-problem/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136938] HYPERLINK function cannot concatenate URL's strings
https://bugs.documentfoundation.org/show_bug.cgi?id=136938 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137739] A ODS document does not print correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=137739 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128196] filenames containing '#' get truncated when saving to GVFS smb:// paths (Samba share), effectively causing silent data loss
https://bugs.documentfoundation.org/show_bug.cgi?id=128196 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137989] Bullet Journal style Bullets
https://bugs.documentfoundation.org/show_bug.cgi?id=137989 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137990] FILESAVE. Writer. Save As. Automatic file name extension. File corrupt and could not be repaired.
https://bugs.documentfoundation.org/show_bug.cgi?id=137990 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137983] Bug: footnote reference
https://bugs.documentfoundation.org/show_bug.cgi?id=137983 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127724] Multiple instances of LibreOffice from separate machines (shared homedir) not working
https://bugs.documentfoundation.org/show_bug.cgi?id=127724 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137987] Incorrect formula display
https://bugs.documentfoundation.org/show_bug.cgi?id=137987 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137984] The files in the last used documents list show up with wrong drive character in the file path
https://bugs.documentfoundation.org/show_bug.cgi?id=137984 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138310] Crash in: mergedlo.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=138310 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137978] Calc header/footer editing dialog after choose preset will not show same on the screen
https://bugs.documentfoundation.org/show_bug.cgi?id=137978 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137945] every times the after file save and reopen content validation help message spaces incremented to a very large number
https://bugs.documentfoundation.org/show_bug.cgi?id=137945 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137841] Sluggishness with 7.0 in "web view" mode when a large picture in the document is visible
https://bugs.documentfoundation.org/show_bug.cgi?id=137841 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138310] Crash in: mergedlo.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=138310 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136119] Spreadsheets shoud not have "infinite" numbers of cells.
https://bugs.documentfoundation.org/show_bug.cgi?id=136119 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136119] Spreadsheets shoud not have "infinite" numbers of cells.
https://bugs.documentfoundation.org/show_bug.cgi?id=136119 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127724] Multiple instances of LibreOffice from separate machines (shared homedir) not working
https://bugs.documentfoundation.org/show_bug.cgi?id=127724 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127724] Multiple instances of LibreOffice from separate machines (shared homedir) not working
https://bugs.documentfoundation.org/show_bug.cgi?id=127724 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125721] (LibreOffice-Flatpak) Opening the Options window takes a long time
https://bugs.documentfoundation.org/show_bug.cgi?id=125721 --- Comment #14 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125721] (LibreOffice-Flatpak) Opening the Options window takes a long time
https://bugs.documentfoundation.org/show_bug.cgi?id=125721 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132304] LibreOffice Calc, EDIT, Cells linked to an external file don't automatically update when both files are open.
https://bugs.documentfoundation.org/show_bug.cgi?id=132304 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132304] LibreOffice Calc, EDIT, Cells linked to an external file don't automatically update when both files are open.
https://bugs.documentfoundation.org/show_bug.cgi?id=132304 --- Comment #3 from QA Administrators --- Dear Paul O, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132283] Unable to make changes on any saved documents
https://bugs.documentfoundation.org/show_bug.cgi?id=132283 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132283] Unable to make changes on any saved documents
https://bugs.documentfoundation.org/show_bug.cgi?id=132283 --- Comment #3 from QA Administrators --- Dear Ashley, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133230] starting up .odt in standard toolbar. crash with note on com.surrey.simpletextrecognize.
https://bugs.documentfoundation.org/show_bug.cgi?id=133230 --- Comment #2 from QA Administrators --- Dear Rory Griffin, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133185] faltan opciones
https://bugs.documentfoundation.org/show_bug.cgi?id=133185 --- Comment #2 from QA Administrators --- Dear maicol figueroa, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113912] UI Leaving dialog open prevents docking sidebar in another window
https://bugs.documentfoundation.org/show_bug.cgi?id=113912 --- Comment #5 from QA Administrators --- Dear Emil Tanev, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138028] Error 1335. libreoffice1.cab in the LibreOffice_7.0.3_Win_x64 pack is corrupt
https://bugs.documentfoundation.org/show_bug.cgi?id=138028 --- Comment #4 from Blesson Thomas --- Initially I had downloaded the file using Mozilla Firefox and now I tried Opera browser, but in both cases the checksum is not correct and I get the error. So does it mean that both these browsers are unable to download the x64 file correctly from the server? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136938] HYPERLINK function cannot concatenate URL's strings
https://bugs.documentfoundation.org/show_bug.cgi?id=136938
--- Comment #1 from Rangga ---
Hi,
I also found a very similar issue:
- Put =HYPERLINK(CONCATENATE("https://test.com/",A2)) as cell value
- the pop up link will show http://concatenate(https//test.com/
If I use right click on the cell it is still redirect to the correct url, so
probably the bug only on pop up link
Thanks,
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: getting started with libreoffice online
I found this link: https://documentation.libreoffice.org/en/english-documentation/ This is version 6.3. We are working on updating to 7.0, but this may take some time. Dan On 11/18/20 17:28, Marc Roos wrote: Dan, can you help with this? -Original Message- To: libreoffice Subject: RE: getting started with libreoffice online Can anyone point me to a manual where I can just run the libreoffice online and edit some files on a tablet for instance? Are these strange questions wanting to know what the rest api documentation is? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - extensions/source
extensions/source/propctrlr/usercontrol.hxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit acddc14fef3f3d34c9f2218545364ff37815b507
Author: Caolán McNamara
AuthorDate: Wed Nov 18 10:48:24 2020 +
Commit: Adolfo Jayme Barrientos
CommitDate: Thu Nov 19 02:21:01 2020 +0100
Resolves: tdf#138271 flag formatted spinbuttons as modified on any entry
change
formattedspinbuttons should send value-changed on losing focus, but this
is sufficient for this use case and safe to backport
Change-Id: Ie0cf5ab22152d95169dc5579423a4173be678a33
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105999
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/extensions/source/propctrlr/usercontrol.hxx
b/extensions/source/propctrlr/usercontrol.hxx
index 93969d2afb21..b72fcbd8048d 100644
--- a/extensions/source/propctrlr/usercontrol.hxx
+++ b/extensions/source/propctrlr/usercontrol.hxx
@@ -58,6 +58,7 @@ namespace pcr
m_xEntry->connect_focus_in( LINK( this,
CommonBehaviourControlHelper, GetFocusHdl ) );
m_xEntry->connect_focus_out( LINK( this,
CommonBehaviourControlHelper, LoseFocusHdl ) );
m_xSpinButton->connect_value_changed(LINK(this,
CommonBehaviourControlHelper, FormattedModifiedHdl));
+m_xSpinButton->connect_changed(LINK(this,
CommonBehaviourControlHelper, EditModifiedHdl));
}
void SetFormatSupplier(const SvNumberFormatsSupplierObj* pSupplier);
@@ -105,6 +106,7 @@ namespace pcr
{
OFormattedNumericControl_Base::SetModifyHandler();
getTypedControlWindow()->connect_value_changed(LINK(this,
CommonBehaviourControlHelper, FormattedModifiedHdl));
+getTypedControlWindow()->connect_changed(LINK(this,
CommonBehaviourControlHelper, EditModifiedHdl));
}
virtual weld::Widget* getWidget() override { return
getTypedControlWindow(); }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - svx/source
svx/source/sidebar/possize/PosSizePropertyPanel.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 2b433a52c164558b85ec85b6b8ccf6b11776695c Author: Caolán McNamara AuthorDate: Wed Nov 18 11:22:42 2020 + Commit: Adolfo Jayme Barrientos CommitDate: Thu Nov 19 02:18:28 2020 +0100 tdf#137397 Faulty Height value in Position and Size content panel Change-Id: Ie7439371cb2d216ca1d95f21db44d203cccd9ea8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106001 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/svx/source/sidebar/possize/PosSizePropertyPanel.cxx b/svx/source/sidebar/possize/PosSizePropertyPanel.cxx index 248675f7ee1f..f6f6b242e884 100644 --- a/svx/source/sidebar/possize/PosSizePropertyPanel.cxx +++ b/svx/source/sidebar/possize/PosSizePropertyPanel.cxx @@ -1057,9 +1057,9 @@ void PosSizePropertyPanel::SetPosSizeMinMax() double fMaxWidth = maWorkArea.getWidth() - (maRect.getWidth() - fLeft); double fMaxHeight = maWorkArea.getHeight() - (maRect.getHeight() - fTop); -mxMtrWidth->set_max(basegfx::fround64(fMaxWidth*100), FieldUnit::NONE); +mxMtrWidth->set_max(std::min(INT_MAX, basegfx::fround64(fMaxWidth*100)), FieldUnit::NONE); limitWidth(*mxMtrWidth); -mxMtrHeight->set_max(basegfx::fround64(fMaxHeight*100), FieldUnit::NONE); +mxMtrHeight->set_max(std::min(INT_MAX, basegfx::fround64(fMaxHeight*100)), FieldUnit::NONE); limitWidth(*mxMtrHeight); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - sc/source svx/source
sc/source/core/data/postit.cxx |3 +++
svx/source/svdraw/svdotxat.cxx |3 ++-
2 files changed, 5 insertions(+), 1 deletion(-)
New commits:
commit 0d36233d4555b5f160a407328661825eb9305c98
Author: Caolán McNamara
AuthorDate: Wed Nov 18 17:09:52 2020 +
Commit: Adolfo Jayme Barrientos
CommitDate: Thu Nov 19 02:17:40 2020 +0100
Resolves: tdf#114956 skip broadcast optimization for ScPostIts
so we can resize the ScPostIt as was the case before
commit f06b48a5dddab20fd1bbf9b5f3e8543593f5e590
Date: Fri Aug 4 18:56:43 2017 +0200
editviewoverlay: Allow EditView to run in Overlay
Change-Id: Idd92716a9b38058f6f275769d4f2523eddac500c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106005
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/sc/source/core/data/postit.cxx b/sc/source/core/data/postit.cxx
index d0ac658f3e35..9ccb6c31a8f5 100644
--- a/sc/source/core/data/postit.cxx
+++ b/sc/source/core/data/postit.cxx
@@ -382,6 +382,9 @@ void ScCaptionCreator::CreateCaption( bool bShown, bool
bTailFront )
*mrDoc.GetDrawLayer(), // should ret a ref?
aTextRect,
aTailPos));
+// tdf#114956 a way to recognize that this SdrCaption is for a ScPostit in
+// SdrTextObj::AdjustTextFrameWidthAndHeight
+mxCaption->SetName("ScPostIt");
// basic caption settings
ScCaptionUtil::SetBasicCaptionSettings( *mxCaption, bShown );
}
diff --git a/svx/source/svdraw/svdotxat.cxx b/svx/source/svdraw/svdotxat.cxx
index 6f4559fd33ca..6f97960b5377 100644
--- a/svx/source/svdraw/svdotxat.cxx
+++ b/svx/source/svdraw/svdotxat.cxx
@@ -278,7 +278,8 @@ bool SdrTextObj::AdjustTextFrameWidthAndHeight()
GetTextEditOutliner() &&
GetTextEditOutliner()->hasEditViewCallbacks());
-if (!bSuppressChangeWhenEditOnOverlay)
+// tdf#114956 always broadcast change for ScPostIts
+if (!bSuppressChangeWhenEditOnOverlay || GetName() == "ScPostIt")
{
SetChanged();
BroadcastObjectChange();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - sw/source
sw/source/core/crsr/pam.cxx | 24
1 file changed, 16 insertions(+), 8 deletions(-)
New commits:
commit cb9ec4a95b0f2ac3db6cb51678bd55f73c44c874
Author: Michael Stahl
AuthorDate: Tue Nov 17 17:58:33 2020 +0100
Commit: Adolfo Jayme Barrientos
CommitDate: Thu Nov 19 02:17:04 2020 +0100
sw_redlinehide: replace bogus implementation of SwPaM::InvalidatePaM()
Sending SwInsText will mess up merged paragraphs. Instead, send
SwUpdateAttr with which-id 0, which results in InvalidateRange_() being
called with at least 1 character.
This appears to be called only by fieldmark UI, and now asserts in
UITest_writer_tests5
DateFormFieldPropertiesDialog.dateFormFieldDialog.test_date_field_with_custom_format
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106022
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 93b1adf7442839dcfbf16660b1fbe1139f14a4d0)
sw_redlinehide: use correct node in SwPaM::InvalidatePaM()
(oopsie from 93b1adf7442839dcfbf16660b1fbe1139f14a4d0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106046
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 53c69d392b1e55267a44994a889688cc80fbbd98)
Change-Id: I948ddefa3acece8809e4bf3d2beee6cec3ed56f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106065
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/sw/source/core/crsr/pam.cxx b/sw/source/core/crsr/pam.cxx
index 0473d8bacfd1..d1fccd357f5e 100644
--- a/sw/source/core/crsr/pam.cxx
+++ b/sw/source/core/crsr/pam.cxx
@@ -1121,15 +1121,23 @@ OUString SwPaM::GetText() const
void SwPaM::InvalidatePaM()
{
-const SwNode &_pNd = GetNode();
-const SwTextNode *_pTextNd = _pNd.GetTextNode();
-if (_pTextNd != nullptr)
+for (SwNodeIndex index = Start()->nNode; index <= End()->nNode; ++index)
{
-// pretend that the PaM marks inserted text to recalc the portion...
-SwInsText aHint( Start()->nContent.GetIndex(),
-End()->nContent.GetIndex() -
Start()->nContent.GetIndex() + 1 );
-SwModify *_pModify=const_cast(static_cast(_pTextNd));
-_pModify->ModifyNotification( nullptr, );
+if (SwTextNode *const pTextNode = index.GetNode().GetTextNode())
+{
+// pretend that the PaM marks changed formatting to reformat...
+sal_Int32 const nStart(
+index == Start()->nNode ? Start()->nContent.GetIndex() : 0);
+// this should work even for length of 0
+SwUpdateAttr const aHint(
+nStart,
+index == End()->nNode
+? End()->nContent.GetIndex() - nStart
+: pTextNode->Len() - nStart,
+0);
+pTextNode->CallSwClientNotify(sw::LegacyModifyHint(,
));
+}
+// other node types not invalidated
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 138320] New: search-string menu should open with the LAST search, not the first menu item
https://bugs.documentfoundation.org/show_bug.cgi?id=138320 Bug ID: 138320 Summary: search-string menu should open with the LAST search, not the first menu item Product: LibreOffice Version: 7.1.0.0.alpha1+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tor...@yahoo.com Description: When beginning a search (^f)search-string menu opens at the first item, eg, ‘aa’ if user searched successively for ‘aa’, ‘bb’ and ‘cc’. The menu should open instead with the LAST search, eg, ‘bb’ (which may not be the last menu item), because: * it's more likely for the user to repeat the last search rather than the first one done in the work session; (If he|she does want the first menu item, he|she can select it, and it becomes the last-used item!) * if the search is automatic, eg, via a AutoHotKey script, the user does not have a chance to reject the first menu item if it's not wanted. Steps to Reproduce: 1.Do 2 (or more) different searches begin another search (^f) 3. Actual Results: Menu opens at the first item. Expected Results: Menu should open at last search Reproducible: Always User Profile Reset: No Additional Info: none -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/source sw/qa sw/source
sfx2/source/view/sfxbasecontroller.cxx| 12 +-
sw/qa/uibase/uiview/data/update-replacement-nosetting.odt |binary
sw/qa/uibase/uiview/uiview.cxx| 25 ++
sw/source/uibase/uiview/view.cxx |2 -
4 files changed, 34 insertions(+), 5 deletions(-)
New commits:
commit 693f12ad57912c2356a197d9a794e6108ce79ef2
Author: Miklos Vajna
AuthorDate: Wed Nov 18 17:55:13 2020 +0100
Commit: Miklos Vajna
CommitDate: Thu Nov 19 01:37:50 2020 +0100
sw replacement image creation: fix this when an ODT's settings.xml is
invalid
This builds on top of commit c123bfff501229f398a1b679fc7434b82d53685c
(Bin overly eager early return that stops replacement image creation,
2020-08-20), and handles a similar case, when
SwView::ReadUserDataSequence() is not called at all.
The result is the same: no shell is selected on the command dispatcher
stack, so .uno:UpdateAll is ignored and the replacement images are not
created.
Change-Id: If8b74424b0ad88e63129fd8f7efd09f85e300895
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106068
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sfx2/source/view/sfxbasecontroller.cxx
b/sfx2/source/view/sfxbasecontroller.cxx
index cecf046bfbe9..23b1aad5c3d0 100644
--- a/sfx2/source/view/sfxbasecontroller.cxx
+++ b/sfx2/source/view/sfxbasecontroller.cxx
@@ -1334,12 +1334,18 @@ void SfxBaseController::ConnectSfxFrame_Impl( const
ConnectSfxFrame i_eConnect )
break;
}
}
-if ( nViewDataIndex < nCount )
+if (nViewDataIndex < nCount || !xViewData.is())
{
Sequence< PropertyValue > aViewData;
-OSL_VERIFY( xViewData->getByIndex( nViewDataIndex )
>>= aViewData );
-if ( aViewData.hasElements() )
+if (xViewData.is())
+{
+OSL_VERIFY(xViewData->getByIndex(nViewDataIndex)
>>= aViewData);
+}
+if (aViewData.hasElements() || !xViewData.is())
+{
+// Tolerate empty xViewData,
ReadUserDataSequence() has side effects.
m_pData->m_pViewShell->ReadUserDataSequence(
aViewData );
+}
}
}
catch (const Exception&)
diff --git a/sw/qa/uibase/uiview/data/update-replacement-nosetting.odt
b/sw/qa/uibase/uiview/data/update-replacement-nosetting.odt
new file mode 100644
index ..055c3d1a2c2a
Binary files /dev/null and
b/sw/qa/uibase/uiview/data/update-replacement-nosetting.odt differ
diff --git a/sw/qa/uibase/uiview/uiview.cxx b/sw/qa/uibase/uiview/uiview.cxx
index 8827cea10752..4d622aafaa5f 100644
--- a/sw/qa/uibase/uiview/uiview.cxx
+++ b/sw/qa/uibase/uiview/uiview.cxx
@@ -12,6 +12,7 @@
#include
#include
#include
+#include
#include
#include
@@ -87,6 +88,30 @@ CPPUNIT_TEST_FIXTURE(SwUibaseUiviewTest,
testUpdateAllObjectReplacements)
CPPUNIT_ASSERT(xNameAccess->hasByName("ObjectReplacements/Components_1"));
}
+CPPUNIT_TEST_FIXTURE(SwUibaseUiviewTest, testUpdateReplacementNosetting)
+{
+// Load a copy of the document in hidden mode.
+OUString aSourceURL
+= m_directories.getURLFromSrc(DATA_DIRECTORY) +
"update-replacement-nosetting.odt";
+CPPUNIT_ASSERT_EQUAL(osl::FileBase::E_None, osl::File::copy(aSourceURL,
maTempFile.GetURL()));
+mxComponent = loadFromDesktop(maTempFile.GetURL(),
"com.sun.star.text.TextDocument",
+ { comphelper::makePropertyValue("Hidden",
true) });
+
+// Update "everything" (including object replacements) and save it.
+dispatchCommand(mxComponent, ".uno:UpdateAll", {});
+uno::Reference xStorable(mxComponent, uno::UNO_QUERY);
+xStorable->storeSelf({});
+
+// Check the contents of the updated copy.
+uno::Reference xContext =
comphelper::getProcessComponentContext();
+uno::Reference xNameAccess
+= packages::zip::ZipFileAccess::createWithURL(xContext,
maTempFile.GetURL());
+
+// Without the accompanying fix in place, this test would have failed,
because the embedded
+// object replacement image was not generated.
+CPPUNIT_ASSERT(xNameAccess->hasByName("ObjectReplacements/Components"));
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/uibase/uiview/view.cxx b/sw/source/uibase/uiview/view.cxx
index 2b5670cffc11..0e12a868f88d 100644
--- a/sw/source/uibase/uiview/view.cxx
+++ b/sw/source/uibase/uiview/view.cxx
@@ -1283,8 +1283,6 @@ void SwView::ReadUserDataSequence ( const uno::Sequence <
beans::PropertyValue >
[Libreoffice-commits] core.git: lotuswordpro/inc lotuswordpro/source solenv/clang-format
lotuswordpro/inc/localtime.hxx | 20 lotuswordpro/inc/lwpatomholder.hxx | 18 lotuswordpro/inc/lwpbasetype.hxx | 15 lotuswordpro/inc/lwpfilehdr.hxx| 14 lotuswordpro/inc/lwpfrib.hxx | 37 - lotuswordpro/inc/lwpglobalmgr.hxx | 16 lotuswordpro/inc/lwpobj.hxx| 15 lotuswordpro/inc/lwpobjstrm.hxx| 30 - lotuswordpro/inc/lwpsvstream.hxx | 20 lotuswordpro/inc/xfilter/ixfstream.hxx | 14 lotuswordpro/inc/xfilter/ixfstyle.hxx | 22 lotuswordpro/inc/xfilter/xfannotation.hxx | 32 - lotuswordpro/inc/xfilter/xfarrowstyle.hxx | 52 - lotuswordpro/inc/xfilter/xfbgimage.hxx | 32 - lotuswordpro/inc/xfilter/xfcellstyle.hxx | 33 - lotuswordpro/inc/xfilter/xfchange.hxx | 35 - lotuswordpro/inc/xfilter/xfcolstyle.hxx| 20 lotuswordpro/inc/xfilter/xfconfigmanager.hxx | 12 lotuswordpro/inc/xfilter/xfcontentcontainer.hxx| 20 lotuswordpro/inc/xfilter/xfcrossref.hxx| 18 lotuswordpro/inc/xfilter/xfdatestyle.hxx | 52 - lotuswordpro/inc/xfilter/xfdrawgroup.hxx | 21 lotuswordpro/inc/xfilter/xfdrawpath.hxx| 27 lotuswordpro/inc/xfilter/xfdrawpolyline.hxx| 10 lotuswordpro/inc/xfilter/xfdrawrect.hxx| 14 lotuswordpro/inc/xfilter/xfdrawstyle.hxx | 31 - lotuswordpro/inc/xfilter/xfentry.hxx | 37 - lotuswordpro/inc/xfilter/xffloatframe.hxx |9 lotuswordpro/inc/xfilter/xffontdecl.hxx| 10 lotuswordpro/inc/xfilter/xffooter.hxx | 12 lotuswordpro/inc/xfilter/xffooterstyle.hxx | 11 lotuswordpro/inc/xfilter/xffootnote.hxx| 36 - lotuswordpro/inc/xfilter/xfglobal.hxx | 40 - lotuswordpro/inc/xfilter/xfheader.hxx | 13 lotuswordpro/inc/xfilter/xfheaderstyle.hxx | 36 - lotuswordpro/inc/xfilter/xfhyperlink.hxx | 59 -- lotuswordpro/inc/xfilter/xfimagestyle.hxx | 30 - lotuswordpro/inc/xfilter/xflinebreak.hxx | 10 lotuswordpro/inc/xfilter/xflist.hxx| 22 lotuswordpro/inc/xfilter/xflistitem.hxx| 36 - lotuswordpro/inc/xfilter/xfmasterpage.hxx | 10 lotuswordpro/inc/xfilter/xfofficemeta.hxx | 22 lotuswordpro/inc/xfilter/xfpagecount.hxx | 10 lotuswordpro/inc/xfilter/xfpagenumber.hxx | 21 lotuswordpro/inc/xfilter/xfplaceholder.hxx | 53 - lotuswordpro/inc/xfilter/xfrowstyle.hxx| 22 lotuswordpro/inc/xfilter/xfruby.hxx| 40 - lotuswordpro/inc/xfilter/xfrubystyle.hxx | 31 - lotuswordpro/inc/xfilter/xfsectionstyle.hxx| 16 lotuswordpro/inc/xfilter/xfstyle.hxx | 24 lotuswordpro/inc/xfilter/xfstylecont.hxx | 27 lotuswordpro/inc/xfilter/xftablestyle.hxx | 32 - lotuswordpro/inc/xfilter/xftabstop.hxx | 10 lotuswordpro/inc/xfilter/xftextspan.hxx| 15 lotuswordpro/inc/xfilter/xftextstyle.hxx | 18 lotuswordpro/inc/xfilter/xfutil.hxx| 26 lotuswordpro/source/filter/benlist.cxx | 23 lotuswordpro/source/filter/benobj.cxx | 15 lotuswordpro/source/filter/explode.hxx | 37 - lotuswordpro/source/filter/first.hxx |6 lotuswordpro/source/filter/localtime.cxx | 32 - lotuswordpro/source/filter/lwp9reader.cxx | 58 +- lotuswordpro/source/filter/lwp9reader.hxx |8 lotuswordpro/source/filter/lwpatomholder.cxx | 18 lotuswordpro/source/filter/lwpbackgroundstuff.cxx | 28 - lotuswordpro/source/filter/lwpbackgroundstuff.hxx | 12 lotuswordpro/source/filter/lwpbasetype.cxx | 14 lotuswordpro/source/filter/lwpbreaksoverride.cxx | 29 - lotuswordpro/source/filter/lwpbreaksoverride.hxx | 41 - lotuswordpro/source/filter/lwpcharacterstyle.cxx | 28 - lotuswordpro/source/filter/lwpcharborderoverride.hxx | 14 lotuswordpro/source/filter/lwpcharsetmgr.cxx | 53 - lotuswordpro/source/filter/lwpcontent.cxx | 15 lotuswordpro/source/filter/lwpdivinfo.cxx | 20 lotuswordpro/source/filter/lwpdivinfo.hxx | 21 lotuswordpro/source/filter/lwpdivopts.hxx | 10 lotuswordpro/source/filter/lwpdlvlist.cxx | 51 -
[Libreoffice-commits] core.git: scaddins/source sc/inc sc/qa sc/source solenv/clang-format
sc/inc/bulkdatahint.hxx| 13 sc/inc/calcconfig.hxx | 24 - sc/inc/celltextattr.hxx|7 sc/inc/cellvalues.hxx | 53 +-- sc/inc/chartarr.hxx| 20 - sc/inc/clipoptions.hxx |5 sc/inc/columniterator.hxx | 10 sc/inc/columnset.hxx |7 sc/inc/datamapper.hxx | 10 sc/inc/datastreamgettime.hxx |8 sc/inc/documentstreamaccess.hxx| 15 sc/inc/dpfilteredcache.hxx | 35 +- sc/inc/dpresfilter.hxx | 24 - sc/inc/edittextiterator.hxx|7 sc/inc/formulaiter.hxx |5 sc/inc/generalfunction.hxx | 14 sc/inc/listenercontext.hxx | 27 - sc/inc/listenerquery.hxx | 21 - sc/inc/macromgr.hxx|8 sc/inc/mid.h |8 sc/inc/numformat.hxx |9 sc/inc/pageuno.hxx |6 sc/inc/reffind.hxx |8 sc/inc/refreshtimerprotector.hxx |4 sc/inc/scdllapi.h |4 sc/inc/scopetools.hxx | 25 - sc/inc/segmenttree.hxx | 49 +- sc/inc/stylehelper.hxx |4 sc/inc/tokenstringcontext.hxx | 21 - sc/inc/unitconv.hxx| 17 - sc/inc/userlist.hxx| 20 - sc/inc/zforauto.hxx| 12 sc/qa/extras/check_data_pilot_field.cxx| 61 +-- sc/qa/extras/recordchanges-test.cxx| 27 - sc/qa/extras/sccellrangesobj.cxx | 39 +- sc/qa/extras/scmodelobj.cxx| 25 - sc/qa/extras/scoutlineobj.cxx | 17 - sc/qa/extras/scsubtotalfieldobj.cxx| 29 - sc/qa/unit/dataproviders_test.cxx | 45 +- sc/qa/unit/test_ScChartListenerCollection.cxx | 38 +- sc/source/core/data/table5.cxx | 279 - sc/source/core/inc/arraysumfunctor.hxx | 13 sc/source/core/inc/cellkeytranslator.hxx | 12 sc/source/core/inc/doubleref.hxx | 19 - sc/source/core/inc/scrdata.hxx |7 sc/source/core/tool/addincfg.cxx | 19 - sc/source/core/tool/math.cxx | 27 - sc/source/core/tool/subtotal.cxx | 52 +-- sc/source/filter/excel/xltracer.cxx| 66 +--- sc/source/filter/inc/optab.h | 10 sc/source/filter/inc/qpro.hxx | 10 sc/source/filter/inc/qproform.hxx | 19 - sc/source/filter/inc/sharedformulagroups.hxx | 13 sc/source/filter/inc/xepivotxml.hxx| 25 - sc/source/filter/lotus/memory.cxx | 14 sc/source/filter/xml/XMLChangeTrackingExportHelper.hxx | 10 sc/source/filter/xml/XMLEmptyContext.hxx |9 sc/source/filter/xml/XMLExportDatabaseRanges.hxx |7 sc/source/filter/xml/XMLTrackedChangesContext.hxx | 18 - sc/source/filter/xml/importcontext.hxx |5 sc/source/filter/xml/pivotsource.hxx | 29 - sc/source/filter/xml/xmlcvali.hxx |8 sc/source/ui/Accessibility/AccessibleDocumentBase.cxx |9 sc/source/ui/attrdlg/scuiexp.cxx | 19 - sc/source/ui/cctrl/cbnumberformat.cxx | 11 sc/source/ui/dataprovider/htmldataprovider.hxx |7 sc/source/ui/dbgui/PivotLayoutTreeList.cxx | 18 - sc/source/ui/formdlg/formdata.cxx |9 sc/source/ui/inc/AccessibleDocumentBase.hxx|7 sc/source/ui/inc/IAnyRefDialog.hxx | 12 sc/source/ui/inc/PivotLayoutTreeListBase.hxx |7 sc/source/ui/inc/PivotLayoutTreeListLabel.hxx |3 sc/source/ui/inc/attrdlg.hxx |6 sc/source/ui/inc/chartsh.hxx |5 sc/source/ui/inc/condformatdlgitem.hxx | 18 - sc/source/ui/inc/dapitype.hxx | 10 sc/source/ui/inc/dataproviderdlg.hxx | 11
[Libreoffice-commits] core.git: solenv/clang-format sw/inc sw/qa sw/source
solenv/clang-format/excludelist| 202 -- sw/inc/HandleAnchorNodeChg.hxx | 10 sw/inc/IDocumentChartDataProviderAccess.hxx|9 sw/inc/IDocumentDeviceAccess.hxx | 21 - sw/inc/IDocumentDrawModelAccess.hxx| 10 sw/inc/IDocumentSettingAccess.hxx | 42 +- sw/inc/IDocumentState.hxx |4 sw/inc/IDocumentStatistics.hxx |7 sw/inc/IDocumentStylePoolAccess.hxx| 21 - sw/inc/IDocumentTimerAccess.hxx|2 sw/inc/IGrammarContact.hxx | 11 sw/inc/IShellCursorSupplier.hxx| 10 sw/inc/PageColumnPopup.hxx |5 sw/inc/PageMarginPopup.hxx |4 sw/inc/PageOrientationPopup.hxx|4 sw/inc/PageSizePopup.hxx |5 sw/inc/SidebarWindowsTypes.hxx | 10 sw/inc/SwCapObjType.hxx|5 sw/inc/SwDocIdle.hxx | 11 sw/inc/SwGetPoolIdFromName.hxx | 13 sw/inc/SwNodeNum.hxx | 30 - sw/inc/SwNumberTree.hxx| 85 +--- sw/inc/SwNumberTreeTypes.hxx |4 sw/inc/SwRewriter.hxx |4 sw/inc/SwSmartTagMgr.hxx |6 sw/inc/ToxWhitespaceStripper.hxx | 12 sw/inc/UndoParagraphSignature.hxx | 13 sw/inc/checkit.hxx |7 sw/inc/colwd.hxx |4 sw/inc/dbgoutsw.hxx| 58 +- sw/inc/dobjfac.hxx |2 sw/inc/docfac.hxx |4 sw/inc/docfunc.hxx | 50 +- sw/inc/drawdoc.hxx |4 sw/inc/flddropdown.hxx | 34 - sw/inc/hintids.hxx | 422 ++--- sw/inc/pausethreadstarting.hxx | 12 sw/inc/prtopt.hxx |6 sw/inc/sw_primitivetypes2d.hxx |8 sw/inc/swcli.hxx |6 sw/inc/swcommands.h|3 sw/inc/swddetbl.hxx| 12 sw/inc/swdll.hxx |9 sw/inc/swdllapi.h |4 sw/inc/toxe.hxx|2 sw/inc/unoprnms.hxx|3 sw/qa/core/test_ToxMiscTest.cxx|7 sw/qa/core/test_ToxWhitespaceStripper.cxx | 28 - sw/qa/extras/htmlexport/htmlexport.cxx | 113 +++-- sw/qa/extras/ooxmlexport/ooxmlencryption.cxx |5 sw/qa/extras/ooxmlexport/ooxmllinks.cxx| 11 sw/source/core/access/accheaderfooter.hxx | 22 - sw/source/core/attr/fmtfollowtextflow.cxx |2 sw/source/core/bastyp/SwSmartTagMgr.cxx| 24 - sw/source/core/bastyp/checkit.cxx |2 sw/source/core/bastyp/proofreadingiterator.cxx | 21 - sw/source/core/bastyp/swtypes.cxx | 14 sw/source/core/crsr/BlockCursor.cxx|9 sw/source/core/doc/swstylemanager.hxx |2 sw/source/core/docnode/cancellablejob.hxx |8 sw/source/core/docnode/ndsect.hxx |3 sw/source/core/docnode/pausethreadstarting.cxx |8 sw/source/core/docnode/swthreadjoiner.cxx | 17 sw/source/core/edit/edfldexp.cxx | 15 sw/source/core/inc/DocumentDeviceManager.hxx | 29 - sw/source/core/inc/DocumentDrawModelManager.hxx| 12 sw/source/core/inc/DocumentExternalDataManager.hxx | 10 sw/source/core/inc/DocumentStatisticsManager.hxx | 22 - sw/source/core/inc/DocumentTimerManager.hxx|8 sw/source/core/inc/SwGrammarMarkUp.hxx | 23 - sw/source/core/inc/SwUndoTOXChange.hxx |8 sw/source/core/inc/UndoBookmark.hxx| 49 +- sw/source/core/inc/UndoDraw.hxx| 43 +- sw/source/core/inc/colfrm.hxx |6 sw/source/core/inc/docedt.hxx |4 sw/source/core/inc/docredln.hxx|2 sw/source/core/inc/environmentofanchoredobject.hxx | 132 +++--- sw/source/core/inc/fefly.hxx |3 sw/source/core/inc/fieldhint.hxx |6 sw/source/core/inc/node2lay.hxx| 12 sw/source/core/inc/noteurl.hxx |2 sw/source/core/inc/paintfrm.hxx|7
[Libreoffice-bugs] [Bug 138314] Blank tab names in dialog frames
https://bugs.documentfoundation.org/show_bug.cgi?id=138314 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO OS|All |Mac OS X (All) --- Comment #1 from V Stuart Foote --- All on macOS. Please post details from Help -> About LibreOffice And your macOS about this Apple details (need os build, screen resolution, and graphics GPU). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Bug 102495 depends on bug 132639, which changed state. Bug 132639 Summary: Tooltips randomly pop-up when LibreOffice is in second plane / minimized [kf5 VCL only] https://bugs.documentfoundation.org/show_bug.cgi?id=132639 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132639] Tooltips randomly pop-up when LibreOffice is in second plane / minimized [kf5 VCL only]
https://bugs.documentfoundation.org/show_bug.cgi?id=132639 RGB changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO|RESOLVED --- Comment #9 from RGB --- It seems the bug is gone in Version 7.0.3.1. I kept it open for a couple of hours now and did not see the problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice font blurry on MacBook Pro's Internal HiDPI Retina Display running macOS Big Sur 11.0.1
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #46 from Thorsten Wagner --- I will take a look at the code during the next few days to isolate some code pointers... BTW: Please let us discuss only the issue related technical details here. As LO has a good visual appearance on macOS and becomes significantly worse on Big Sur, this issue has do be fixed independent of long term considerations. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Trouble with SdrMeasureObj (dimension line)
Hi all, I have wondered why a SdrMeasureObj, which is anchored "to cell (resize with cell), does not work in Calc (e.g. tdf#137576). Problems detected so far: (A) TRGetBaseGeometry does not include a rotation angle. So a chain of TRGetBaseGeometry followed by TRSetBaseGeometry does not work. I'm going to change ScXMLExport::WriteShapes so that is does not use matrices. I think, a fix for TR*BaseGeometry is a larger effort. (B) Neither "drag create", nor ctor, nor "create default" set maRect. Because SdrMeasureObj has no own NbcGetLogicRect it uses the inherited one from SdrTextObj, which simple results maRect. Thus Calc uses in some cases an empty rectangle, when it calculates NonRotatedAnchor. The latter is used when saving the document. (C) Setting start or end point does not update maRect. The method includes SetRectsDirty(). A call to GetSnapRect() will then trigger RecalSnapRect(), but that does not affect maRect. (D) Both NbcSetLogicRect and NbcSetSnapRect use the inherited one from SdrTextObj and therefor do not set start and end point. Fixing that looks like a larger effort to me too. TakeUnrotatedSnapRect can calculate a logic rectangle of the current state of a SdrMeasureObj. I can add this to FuConstRectangle::CreateDefaultObject, which is responsible for a default SdrMeasureObj (used for accessibility), and to SdrMeasureObj::EndCreate. That will work for creating measure lines in the UI of Calc. Implementing a SdrMeasureObj::GetLogicRect(), which recalculates maRect, is not possible because of const-ness. Questions: Should I add TakeUnrotatedSnapRect to other places too? Candidates are ctor SdrMeasureObj::SdrMeasureObj(SdrModel& rSdrModel, const Point& rPt1, const Point& rPt2) SdrMeasureObj::RecalcSnapRect() SdrMeasureObj::NbcSetPoint(const Point& rPnt, sal_uInt32 i) Do you know other places which need to be changed, or which are sensible and need testing? Do you have better ideas? Do you have a suggestion for the order, things to do? Do you know examples for unit tests with "drag create" and for unit tests with "create default objects"? Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 138319] The whole sidebar is repainted on file reload (it's or painting more or slower; but obviously flashes)
https://bugs.documentfoundation.org/show_bug.cgi?id=138319 --- Comment #1 from Telesto --- Created attachment 167391 --> https://bugs.documentfoundation.org/attachment.cgi?id=167391=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138319] New: The whole sidebar is repainted on file reload (it's or painting more or slower; but obviously flashes)
https://bugs.documentfoundation.org/show_bug.cgi?id=138319 Bug ID: 138319 Summary: The whole sidebar is repainted on file reload (it's or painting more or slower; but obviously flashes) Product: LibreOffice Version: 7.1.0.0.alpha1+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: The whole sidebar is repainted on file reload (it's or painting more or slower; but obviously flashes) Steps to Reproduce: 1. Open the attached file 2. Expand sidebar at navigator 3. File reload Actual Results: The whole sidebar flashes Expected Results: Small content flash within they navigator content frame Reproducible: Always User Profile Reset: No Additional Info: Found in Version: 7.1.0.0.alpha1+ (x64) Build ID: 312a33b7636334f6ce3b6d1702bc5d3e45215601 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL still ok for me in Version: 7.1.0.0.alpha0+ (x64) Build ID: 6274fbe13c8fa556916b5aed695c6921ef6ff84f CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: nl-NL Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138302] Restart of numbering is not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=138302 Telesto changed: What|Removed |Added CC||tele...@surfxs.nl --- Comment #1 from Telesto --- Is it possible to add a sample file where this is happening.. If I understand it correctly, you enable start new numbering.. and after file reload it's numbered contentiously I don't reproduce that -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice font blurry on MacBook Pro's Internal HiDPI Retina Display running macOS Big Sur 11.0.1
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #45 from Alexander Barris --- So what areas/files need to be changed/fixed in order to tackle this bug? I don't know ANY Objective-C so unfortunately I won't be much help with the code, but can help build and test when changes are made to the source. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127423] Font feature dialog: handle OTF features that are enabled by default (liga, calt, kern)
https://bugs.documentfoundation.org/show_bug.cgi?id=127423 LibreTraining changed: What|Removed |Added CC||libretraining.tutorials@gma ||il.com --- Comment #13 from LibreTraining --- Certain OpenType features are On by default. This is apart of the OpenType specifications not a font setting or a prorgamming choice in the text shaping engine. For example OpenType Standard Ligatures (liga) are On by default. So having a checkbox which adds ":liga" the font name makes no sense. If Standard Ligatures exist, users only option is to disable them. The interface should show that Standard ligatures are On by default. And have a toggle to turn them Off. That toggle to Off should add "-liga" to the font name. Same with OpenType Kerning (kern) - it is On by default. The interface should show that Kerning is On by default. And have a toggle to turn it Off. That toggle to Off should add "-kern" to the font name. Contextual Alternates is On by default. A checkbox to add ":calt" to the font name makes no sense. Being able to turn-off calt makes sense ":-calt" I use that all the time to show the before text for OpenType features. The interface should show that Contextual Alternates is On by default. The same for all other OpenType features which are On by default. Many OpenType features are mutually exclusive. Having multiple check boxes which enables selecting multiple mutually exclusive OpenType features at the same time makes no sense. That is confusing to users. Those mutually exclusive settings should be grouped together and have buttons for each, but only allow selecting one of the group. For example these are mutually exclusive: - Denominators (dnom) - Numerators (numr) - Subscript (subs) - Superscript (sups) - Scientific Inferiors (sinf) Being able to check all these at once makes no sense. Also mutually exclusive: - Tabular Figures (tnum) vs. Proportional Figures (pnum) - Lining Figures (lnum) vs. Oldstyle Figures - Small Capitals (smcp) vs. Petite Capitals (pcap) - etc. etc. ... there are many more Being able to check all these at once makes no sense. Similar settings should be grouped together. Numbers settings, case settings, ligatures (liga, dlig, hlig, rlig, etc.). Access All Alternates (aalt) enabled as a checkbox makes no sense. No user checking that box is going to have any idea of what is happening. The OpenType spec recommends a select list as the interface - which most apps do as it is the only one that makes sense. It is possible to use something like ":aalt=5" but the average user has no idea of what the options are for each character. Unless you look at the actual OpenType code inside the font you have no idea what is possible for that particular font. Not something the average user is going to do. That is confusing to users. The best option is to simply remove it. A very knowledgeable user is going to add it manually anyway. The Fractions style selector does not make sense. Nut fractions do not exist in most fonts and this allows selecting it anyway. That is confusing to users. I don't know if this is some holdover from the Graphite stuff or what. In OpenType ... - Fractions (frac) is for diagonal fractions - Alternative Fractions (afrc) is for stacked or nut fractions The AutoCorrect rules for the legacy Unicode ligatures and fractions can create some confusing interactions with the OpenType ligatures and fractions. Probably good to have a warning somewhere to prevent user confusion. Some fonts have simply removed them to prevent confusion. But many of the fonts included with LO still have the issues. And there are a few other AutoCorrect rules which affect OpenType features. The OpenType specs recommend that certain features not be exposed to users. Users really do not need to see stuff like MarkPositioning (which is hidden). But some features may be useful to turn-off - such as calt. Some of those features may be appropriate to put in a More or Advanced reveal which simplifies the interface to include only the features normally used. Most users should never touch calt so why put it in their face? And on and on and on ... OpenType is complex and this interface could be improved greatly to add some clarity. I offered to help create a better OpenType interface over two years ago. And was met with ignorance combined with arrogance and condescension. So I dropped it. I know a lot about OpenType features and could help improve this LO feature. If a developer would like to work together on this I would be happy to help. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
RE: getting started with libreoffice online
Dan, can you help with this? -Original Message- To: libreoffice Subject: RE: getting started with libreoffice online Can anyone point me to a manual where I can just run the libreoffice online and edit some files on a tablet for instance? Are these strange questions wanting to know what the rest api documentation is? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 117643] Word search does not work in LibreOffice Writer if search term contains an apostrophe
https://bugs.documentfoundation.org/show_bug.cgi?id=117643 --- Comment #22 from mwtjunkm...@gmail.com --- Not working in Version: 7.1.0.0.alpha1+ (x64) Build ID: ccd0e5f445d4a7d0e7aca6c23c02c61bf14510b2 CPU threads: 8; OS: Windows 10.0 Build 20257; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded Will wait for another daily build. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138258] Not all apostrophe marks work in search
https://bugs.documentfoundation.org/show_bug.cgi?id=138258 --- Comment #2 from mwtjunkm...@gmail.com --- Not working in Version: 7.1.0.0.alpha1+ (x64) Build ID: ccd0e5f445d4a7d0e7aca6c23c02c61bf14510b2 CPU threads: 8; OS: Windows 10.0 Build 20257; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded Will wait for another daily build. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112491] SDBC-mismatch on alter field-properties in embedded Firebird database when editing primary key
https://bugs.documentfoundation.org/show_bug.cgi?id=112491 --- Comment #19 from Luigui9393 --- (In reply to QA Administrators from comment #6) > Estimado remitente de errores: > > Lea este mensaje en su totalidad antes de continuar. > > Su informe de error se cierra como INSUFFICIENTDATA debido a inactividad y > una falta de información que se necesita para poder precisar > reproducir y confirmar el problema. Le recomendamos que vuelva a realizar la > prueba > su error contra la última versión. Si el problema persiste > presente en la última versión estable, necesitamos lo siguiente > información (ignore la que ya haya proporcionado): > > a) Proporcione detalles de su sistema, incluido su >sistema y la última versión de LibreOffice que tenga >confirmó que el error está presente > > b) Proporcione pasos fáciles de reproducir: cuanto más simples, mejor > > c) Proporcione cualquier caso de prueba que nos ayude a confirmar el > problema. > > d) Proporcione capturas de pantalla del problema si cree que podría ayudar > > e) Leer todos los comentarios y proporcionar la información solicitada > > Una vez hecho todo esto, vuelva a configurar el error en NO CONFIRMADO > e intentaremos reproducir el problema. Por favor no: > > a) responder por correo electrónico > > b) actualice el campo de versión en el error o cualquiera de los otros > detalles >en la sección superior de nuestro rastreador de errores > > Un cordial saludo, > Equipo de control de calidad > > MassPing-NeedInfo-20180502 Hola encuentro un error muy recurrente en el programa "isc_dsql_prepare", para la función de incrementos de variable automático en columnas como id-automático, e probado de 2 formas el incremento y en ninguna de los dos me permite ponerlo en modo automático: a) por medio de la creación manual de nuevas tablas, me manda el error (-104, IM001, 751,-607, 1, 68, ). b) por medio de el asistente automático de tablas, una vez que se le asigna automático a la columna de id, ocurre el mismo problema error (-104, IM001, 751,-607, 1, 68, ) el problema parece venir de la función /build/libreoffice/parts/libreoffice/build/connectivity/source/drivers/firebird/Util.cxx:68 creo suponer que los "PERMISOS" no dejan que la función realice su trabajo, pero este error se viene presentando desde libreoffice 3 hasta el mas actual que tengo probando en mi maquina LibreOffice 7.0.2.2, puede ser que se pierda el control del incrementó o que por alguna razón la función pierda los permisos Saludos -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125721] (LibreOffice-Flatpak) Opening the Options window takes a long time
https://bugs.documentfoundation.org/show_bug.cgi?id=125721 --- Comment #13 from antistress --- (In reply to Xisco Faulí from comment #12) > Hello antistress, > Could you please try to reproduce it with the latest version of LibreOffice > from https://www.libreoffice.org/download/libreoffice-fresh/ ? > I have set the bug's status to 'NEEDINFO'. Please change it back to > 'UNCONFIRMED' if the bug is still present in the latest version. Hi, I'm not sure ton understand : this bug is about the flatpak version of LibO..? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138195] UI: Rename image/chart has no separate undo step (working correctly for textbox)
https://bugs.documentfoundation.org/show_bug.cgi?id=138195 neuf...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Severity|normal |minor Ever confirmed|0 |1 --- Comment #2 from neuf...@gmail.com --- Could get bug to reproduce in: Version: 7.0.3.1 (x64) Build ID: d7547858d014d4cf69878db179d326fc3483e082 CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL Also in: Version: 7.1.0.0.alpha1+ (x64) Build ID: 631974dd958fe4ca1d1f2164266e1e2c81b325ce CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL It seems the rename step isn't tracked in changes at all. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138173] Find and Replace dialog default should other options be closed
https://bugs.documentfoundation.org/show_bug.cgi?id=138173 Thomas Lendo changed: What|Removed |Added CC||thomas.le...@gmail.com --- Comment #7 from Thomas Lendo --- This is a difficile issue. In 2017, Bug 111846 was implemented to have a positive wording in all settings and to have no checked option in the default F dialog. Then in 2018 with Bug 98544 it was implemented that the F dialog should remember the 'other options' state. If something is checked then the dialog should stay open. Also in 2018 the diacritic setting was changed so that it's checked by default. This reversed parts of the initial idea of Bug 111846. I think Bug 98544 must be re-implemented in a smarter way. The F dialog should be collapsed at it's first opening. After that the user's choice and/or the checkboxes' status should be considered to decide if it's collapsed or not. If a user or a program function changes a checkbox status then the dialog should open in it's full extent. With this no one will oversee a setting. Overseen settings hidden in the collapsed dialog could harm the search function in a user's point of view. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 138173] Find and Replace dialog default should other options be closed
https://bugs.documentfoundation.org/show_bug.cgi?id=138173 Thomas Lendo changed: What|Removed |Added CC||thomas.le...@gmail.com --- Comment #7 from Thomas Lendo --- This is a difficile issue. In 2017, Bug 111846 was implemented to have a positive wording in all settings and to have no checked option in the default F dialog. Then in 2018 with Bug 98544 it was implemented that the F dialog should remember the 'other options' state. If something is checked then the dialog should stay open. Also in 2018 the diacritic setting was changed so that it's checked by default. This reversed parts of the initial idea of Bug 111846. I think Bug 98544 must be re-implemented in a smarter way. The F dialog should be collapsed at it's first opening. After that the user's choice and/or the checkboxes' status should be considered to decide if it's collapsed or not. If a user or a program function changes a checkbox status then the dialog should open in it's full extent. With this no one will oversee a setting. Overseen settings hidden in the collapsed dialog could harm the search function in a user's point of view. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 120976] WRITE local IT guide different from the menu
https://bugs.documentfoundation.org/show_bug.cgi?id=120976 --- Comment #16 from gmarco --- (In reply to Xisco Faulí from comment #14) > Hello gmarco, > Could you please try to reproduce it with the latest version of LibreOffice > from https://www.libreoffice.org/download/libreoffice-fresh/ ? > I have set the bug's status to 'NEEDINFO'. Please change it back to > 'UNCONFIRMED' if the bug is still present in the latest version. Hi Xisco, I think Valter has already answered correctly. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138129] Add color picker to starmath
https://bugs.documentfoundation.org/show_bug.cgi?id=138129 --- Comment #6 from V Stuart Foote --- (In reply to V Stuart Foote from comment #5) > > - Add support for #RGB colors. > > These of course are still RGB colors, but they are a short hand representing > a double Hex value 0-F. That is, #123 would be shorthand for #112233, or > #0F0 would be #00FF00, etc. > And, seems the current 7.0 "rgb" implementation is not the doubled HEX, but is instead the decimal representation of the Hex value 0-255--I was wondering about that. Seems more useful than the doubled shorthand of the MathML standard. For "rgb" is color rgb 255 0 0 Green is color rgb 0 255 0 Blue is color 0 0 255 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
