[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards
https://bugs.documentfoundation.org/show_bug.cgi?id=124176 --- Comment #153 from Commit Notification --- Gökhan Özeloğlu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/61f2209ac2e744b42da929e79ed9380269a95dd6 tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/access/acctable.hxx |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) New commits: commit 61f2209ac2e744b42da929e79ed9380269a95dd6 Author: Gökhan Özeloğlu AuthorDate: Sun Nov 22 06:57:14 2020 + Commit: Julien Nabet CommitDate: Sun Nov 22 08:52:21 2020 +0100 tdf#124176: Use pragma once instead of include guards Change-Id: Idb778188a0a2f0c26e007dc919adbffe3af6e435 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106331 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/sw/source/core/access/acctable.hxx b/sw/source/core/access/acctable.hxx index 4da4944ba2c2..eea56e379015 100644 --- a/sw/source/core/access/acctable.hxx +++ b/sw/source/core/access/acctable.hxx @@ -17,8 +17,7 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#ifndef INCLUDED_SW_SOURCE_CORE_ACCESS_ACCTABLE_HXX -#define INCLUDED_SW_SOURCE_CORE_ACCESS_ACCTABLE_HXX +#pragma once #include #include @@ -275,6 +274,5 @@ public: getImplementationName() override; }; -#endif /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards
https://bugs.documentfoundation.org/show_bug.cgi?id=124176 --- Comment #152 from Commit Notification --- Bartu Bayazıt committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c3c9c0505509d69501ed835e97418b82e64bdfab tdf#124176: Use pragma once, instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/inc/wlistsh.hxx |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) New commits: commit c3c9c0505509d69501ed835e97418b82e64bdfab Author: Bartu Bayazıt AuthorDate: Sat Nov 21 12:22:42 2020 + Commit: Julien Nabet CommitDate: Sun Nov 22 08:51:05 2020 +0100 tdf#124176: Use pragma once, instead of include guards Change-Id: Ie955db5e8410ee4c7cfdb6bfb75b5a3aaa61784f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106311 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/sw/source/uibase/inc/wlistsh.hxx b/sw/source/uibase/inc/wlistsh.hxx index be6ca6310996..de6e8d5c28a3 100644 --- a/sw/source/uibase/inc/wlistsh.hxx +++ b/sw/source/uibase/inc/wlistsh.hxx @@ -16,8 +16,8 @@ * except in compliance with the License. You may obtain a copy of * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#ifndef INCLUDED_SW_SOURCE_UIBASE_INC_WLISTSH_HXX -#define INCLUDED_SW_SOURCE_UIBASE_INC_WLISTSH_HXX + +#pragma once #include "listsh.hxx" @@ -35,6 +35,4 @@ public: virtual ~SwWebListShell() override; }; -#endif - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 82698] FILESAVE: RTF List numbers are the wrong size
https://bugs.documentfoundation.org/show_bug.cgi?id=82698 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=78 ||492 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78492] FILESAVE: RTF - Bullet character not saved with correct font
https://bugs.documentfoundation.org/show_bug.cgi?id=78492 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=82 ||698 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138150] Filesave Docx: sub bullets not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=138150 Timur changed: What|Removed |Added Summary|sub bullets not saved |Filesave Docx: sub bullets ||not saved --- Comment #3 from Timur --- Reporter, please attach ODT. Best to add screenshot inside with correct sub bullets, before save aa DOCX. Please search if already reported, like in bug 134619. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138403] New: foreign numerals formatting not permanent
https://bugs.documentfoundation.org/show_bug.cgi?id=138403 Bug ID: 138403 Summary: foreign numerals formatting not permanent Product: LibreOffice Version: 6.2.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: itt...@yandex.com Description: When setting the numerals formatting in any numbers field like list numbering, page numbering ... the language set gets back systematically to a same foreign language. For example, if the language is sanskrit (० १ २ ३ ४ ५ ६ ७ ८ ९), libreoffice changes it into farsi when reopening the document. In my installation farsi or persian has never been set anywhere manually as a default language neither it has been used ever. English is set as the default language for western script and Hindi for complex characters. Steps to Reproduce: 1.make a numbered list of items 2.in the "customize" pane of numbering settings, select "१, २, ३, ..." in the list for the field "Number" and click "OK" 3.save and close the document and reopen it. Actual Results: numbers are set to farsi which is the field above "१, २, ३, ...". Farsi is the persian language, its numbers are like this "۱ ۲ ۳". Expected Results: language settings should not be automatically reset. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: nothing -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138357] convert problem opening xlsx file in Calc with calender
https://bugs.documentfoundation.org/show_bug.cgi?id=138357 Timur changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136121] Digits (1234 etc.) not rendered when font set as Noto Kufi Arabic - English characters rendered using fallback font, but digits are not (Regression from 6.0.7, example
https://bugs.documentfoundation.org/show_bug.cgi?id=136121 Timur changed: What|Removed |Added Resolution|WONTFIX |NOTOURBUG --- Comment #17 from Timur --- Won't Fix is for confirmed issue, here is not, so I close as NOB. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131455] Right arrow causes a large unexpected column jump. ( steps in comment 4 )
https://bugs.documentfoundation.org/show_bug.cgi?id=131455 --- Comment #14 from Daniel Baran --- Further testing on a second machine seems to validate the fix in 6.4.7 (Windows) I will continue testing on other machines and report back. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72792] Inserted music in any Start mode no playback sound from PPT
https://bugs.documentfoundation.org/show_bug.cgi?id=72792 --- Comment #9 from alinado --- Select the songs at Dzwonki mp3 to join and the videos for you are being shared for free you know? https://dzwoneknatelefon.com/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 137174] HTML conversion: fields always shaded
https://bugs.documentfoundation.org/show_bug.cgi?id=137174 Dieter changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval --- Comment #5 from Dieter --- (In reply to ajlittoz from comment #3) > (In reply to Dieter from comment #2) > > Could you please try to reproduce it with the latest version of LibreOffice > > from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set > > the bug's status to 'NEEDINFO'. > > I checked with my installed 7.0.3.1. > > Compared to previous 6.4.6.2, View>Field Shadings determines if generated > HTML will have a background for fields. > > I am not sure this is intended behaviour because fields are routinely used > to insert "dynamic" content in continuity with text. Nothing should distract > reader's attention. Let's as design-team, if this is intended behaviour or not cc: Design-Team -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 137174] HTML conversion: fields always shaded
https://bugs.documentfoundation.org/show_bug.cgi?id=137174 Dieter changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval --- Comment #5 from Dieter --- (In reply to ajlittoz from comment #3) > (In reply to Dieter from comment #2) > > Could you please try to reproduce it with the latest version of LibreOffice > > from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set > > the bug's status to 'NEEDINFO'. > > I checked with my installed 7.0.3.1. > > Compared to previous 6.4.6.2, View>Field Shadings determines if generated > HTML will have a background for fields. > > I am not sure this is intended behaviour because fields are routinely used > to insert "dynamic" content in continuity with text. Nothing should distract > reader's attention. Let's as design-team, if this is intended behaviour or not cc: Design-Team -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137783] EDITING: FORMATTING: excess character font code added when editing inside a paragraph.
https://bugs.documentfoundation.org/show_bug.cgi?id=137783 --- Comment #10 from Dieter --- Thank you for the files, but I still try to find out what the problem is. So you are talking about html-code itself? Because I can't see any problems if I compare html documents and odt documents. Since I only have a very basic knowledge about html-code I can't help. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138150] sub bullets not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=138150 --- Comment #2 from guy1...@gmail.com --- I just re checked When I write in Hebrew the fonts are not saved either , while using DOCX When I save as WORD97 something.doc it is saved OK HTH -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132900] Delay when opening Customize dialog the first time (Windows-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=132900 --- Comment #21 from Dieter --- I also in safe mode with the following result: 5 seconds when opening for the first time in SafeMode; 2,5 seconds when I tried again. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138223] FILEOPEN PPTX: text shown black on black (instead of black on white)
https://bugs.documentfoundation.org/show_bug.cgi?id=138223 Aron Budea changed: What|Removed |Added OS|Linux (All) |All CC||ba...@caesar.elte.hu Version|7.0.0.3 release |6.4.0.3 release Keywords||filter:pptx Blocks||107899 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107899 [Bug 107899] [META] PPTX paragraph-related issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107899] [META] PPTX paragraph-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107899 Aron Budea changed: What|Removed |Added Depends on||138223 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=138223 [Bug 138223] FILEOPEN PPTX: text shown black on black (instead of black on white) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137990] FILESAVE. Writer. Save As. Automatic file name extension. File corrupt and could not be repaired.
https://bugs.documentfoundation.org/show_bug.cgi?id=137990 Dieter changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||dgp-m...@gmx.de --- Comment #1 from Dieter --- First of all: "Welcome to LibreOffice!" I hope you like it! And thank you for your help to improve LO! I've tried to reproduce the bug, you describe. What I can see is: 1.Create new .odt file (just right click on desktop New->OpenDocument) and type something. 2.File->Save As 3.AFNE uncheck(off) 4.Save Result: Document is only saved with a file nam extension (like .odt or .docx), if you add it manually. If you don't do this, document is saved without an extension and can't be opened. But for me this is the expected behaviour. So I don't think, that this is a bug. Perhaps it is a lack of information about the AFNE-option, because LO Help doesn't say anything about that option (see: https://help.libreoffice.org/7.0/en-GB/text/shared/01/0107.html?=WRITER=WIN) So perhaps an information should be added there? Andrea, wah do you think => NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138009] Cross-Reference in Header: If the value somewhere on the page changes, the header remains unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=138009 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Severity|enhancement |normal Whiteboard| QA:needsComment| Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Dieter --- Thank you for reporting the bug. Please attach a sample document, as this makes it easier for us to verify the bug. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided. (Please note that the attachment will be public, remove any sensitive information before attaching it) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138033] No way to create a new macro module
https://bugs.documentfoundation.org/show_bug.cgi?id=138033 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138057] can't dissynchronize cell borders
https://bugs.documentfoundation.org/show_bug.cgi?id=138057 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138055] Problem printing #10 Envelope wit HP OfficeJet 4650
https://bugs.documentfoundation.org/show_bug.cgi?id=138055 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138357] convert problem opening xlsx file in Calc with calender
https://bugs.documentfoundation.org/show_bug.cgi?id=138357 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138357] convert problem opening xlsx file in Calc with calender
https://bugs.documentfoundation.org/show_bug.cgi?id=138357 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132365] Hyperlinks in text words are removed after spelling check
https://bugs.documentfoundation.org/show_bug.cgi?id=132365 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132365] Hyperlinks in text words are removed after spelling check
https://bugs.documentfoundation.org/show_bug.cgi?id=132365 --- Comment #5 from QA Administrators --- Dear utilsites, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132362] libreoffice calc lose data and excel 2016 loses data too
https://bugs.documentfoundation.org/show_bug.cgi?id=132362 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132362] libreoffice calc lose data and excel 2016 loses data too
https://bugs.documentfoundation.org/show_bug.cgi?id=132362 --- Comment #3 from QA Administrators --- Dear jykaboxjive, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132330] Global hyphenation won't turn off
https://bugs.documentfoundation.org/show_bug.cgi?id=132330 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132330] Global hyphenation won't turn off
https://bugs.documentfoundation.org/show_bug.cgi?id=132330 --- Comment #3 from QA Administrators --- Dear 80905, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133303] Spreadsheet export as PDF produces zero margin document
https://bugs.documentfoundation.org/show_bug.cgi?id=133303 --- Comment #6 from QA Administrators --- Dear PK Seet, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133263] resizing RTL table column width hides text / displaces text beyond cell boundaries
https://bugs.documentfoundation.org/show_bug.cgi?id=133263 --- Comment #3 from QA Administrators --- Dear yallabalagan, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99477] EDITING: "View> Freeze Cells> Freeze First..." does not work if the sheet is already frozen
https://bugs.documentfoundation.org/show_bug.cgi?id=99477 --- Comment #30 from shubhamswaraj20...@gmail.com --- Thanks for sharing the information regarding https://www.lyricsauto.com;>it -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138402] EDITING: Embedded chart in PPT is black after returning from OLE editor
https://bugs.documentfoundation.org/show_bug.cgi?id=138402 Aron Budea changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138402] EDITING: Embedded chart in PPT is black after returning from OLE editor
https://bugs.documentfoundation.org/show_bug.cgi?id=138402 --- Comment #2 from Aron Budea --- Created attachment 167469 --> https://bugs.documentfoundation.org/attachment.cgi?id=167469=edit Chart (after getting back from MS Graph, 7.0, better) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138402] EDITING: Embedded chart in PPT is black after returning from OLE editor
https://bugs.documentfoundation.org/show_bug.cgi?id=138402 --- Comment #1 from Aron Budea --- Created attachment 167468 --> https://bugs.documentfoundation.org/attachment.cgi?id=167468=edit Chart (after getting back from MS Graph, 7.1, bad) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138402] New: EDITING: Embedded chart in PPT is black after returning from OLE editor
https://bugs.documentfoundation.org/show_bug.cgi?id=138402 Bug ID: 138402 Summary: EDITING: Embedded chart in PPT is black after returning from OLE editor Product: LibreOffice Version: 7.1.0.0.alpha1+ Hardware: All OS: Windows (All) Status: UNCONFIRMED Keywords: bibisectRequest, regression Severity: minor Priority: low Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@caesar.elte.hu Blocks: 58323 Created attachment 167467 --> https://bugs.documentfoundation.org/attachment.cgi?id=167467=edit Chart (after opening, for reference) This bug requires the MS Graph chart editor to be installed alongside LO, and to be installed when the OLE chart in the sample is activated. MS Office installations should have it. - Disable Skia under Tools -> Options; LibreOffice -> View; 'Use Skia for all rendering' (with Skia there's also a different bug), - Open attachment 44651 (bug 35498), - Double-click on the chart, this is where MS Graph opens, - Close MS Graph, without changing anything. -> Chart is black instead of the original colors. It looked slightly bad in 7.0 as well, but in 7.1 it's completely black, so something got worse. Buggy in LO 7.1.0.0.alpha1+ (312a33b7636334f6ce3b6d1702bc5d3e45215601) / Windows. Less buggy in 7.0.0.3. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=58323 [Bug 58323] [META] OLE objects interoperability issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58323] [META] OLE objects interoperability issues
https://bugs.documentfoundation.org/show_bug.cgi?id=58323 Aron Budea changed: What|Removed |Added Depends on||138402 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=138402 [Bug 138402] EDITING: Embedded chart in PPT is black after returning from OLE editor -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131455] Right arrow causes a large unexpected column jump. ( steps in comment 4 )
https://bugs.documentfoundation.org/show_bug.cgi?id=131455 --- Comment #13 from Daniel Baran --- When I test on Linux, the problem remains there also. (steps in comment 4) Version: 6.4.7.2 Build ID: 639b8ac485750d5696d7590a72ef1b496725cfb5 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138401] Strange colours in patches on libreoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=138401 --- Comment #1 from Richard --- Created attachment 167466 --> https://bugs.documentfoundation.org/attachment.cgi?id=167466=edit Show colour patterns appearing when i select cells -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138401] New: Strange colours in patches on libreoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=138401 Bug ID: 138401 Summary: Strange colours in patches on libreoffice Product: LibreOffice Version: 7.0.1.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: davisconsult...@gmail.com Description: Colour areas develop a cross-hatch pattern in my RTX 2080 windows 10 1920x. Should stay a pure colour. Gets a bit distracting Steps to Reproduce: 1.eg selecting a region of cells in a spreadsheet, the coloured headings of columns get cross-hatch pattern of light aqua and dark blue rather than staying dark blue, with some overlaid effects 2. 3. Actual Results: the coloured headings of columns get cross-hatch pattern of light aqua and dark blue rather than staying dark blue, with some overlaid effects 2. Expected Results: Colours should be constant Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-GB Module: SpreadsheetDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: no -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: i18npool/inc i18npool/source solenv/clang-format
i18npool/inc/servicename.hxx|3
i18npool/source/transliteration/hiraganaToKatakana.cxx | 11
i18npool/source/transliteration/ignoreKashida_CTL.cxx | 10
i18npool/source/transliteration/ignoreMiddleDot_ja_JP.cxx | 15
i18npool/source/transliteration/ignoreMinusSign_ja_JP.cxx | 13
i18npool/source/transliteration/ignoreSeZe_ja_JP.cxx|5
i18npool/source/transliteration/ignoreSeparator_ja_JP.cxx | 151
--
i18npool/source/transliteration/ignoreTiJi_ja_JP.cxx|5
i18npool/source/transliteration/ignoreTraditionalKana_ja_JP.cxx | 20 -
i18npool/source/transliteration/ignoreZiZu_ja_JP.cxx| 20 -
i18npool/source/transliteration/katakanaToHiragana.cxx | 10
i18npool/source/transliteration/largeToSmall_ja_JP.cxx | 67 ++--
i18npool/source/transliteration/smallToLarge_ja_JP.cxx | 67 ++--
solenv/clang-format/excludelist | 13
14 files changed, 192 insertions(+), 218 deletions(-)
New commits:
commit 10b23330a9655658e6d7ef1d008a3302a15e9629
Author: Philipp Hofer
AuthorDate: Thu Nov 12 13:00:14 2020 +0100
Commit: Christian Lohmaier
CommitDate: Sun Nov 22 01:58:10 2020 +0100
tdf#123936 Formatting files in module i18npool with clang-format
Change-Id: I95fe065f4dcbe9d7bab105944ba4f835e80718ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105678
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier
diff --git a/i18npool/inc/servicename.hxx b/i18npool/inc/servicename.hxx
index cbe187729078..a988d31d031d 100644
--- a/i18npool/inc/servicename.hxx
+++ b/i18npool/inc/servicename.hxx
@@ -53,12 +53,11 @@ Implementation Name
*/
-
#ifndef INCLUDED_I18NPOOL_INC_SERVICENAME_HXX
#define INCLUDED_I18NPOOL_INC_SERVICENAME_HXX
#define TRLT_SERVICELNAME "com.sun.star.i18n.Transliteration"
-#define TRLT_SERVICELNAME_L10N TRLT_SERVICELNAME ".l10n"
+#define TRLT_SERVICELNAME_L10N TRLT_SERVICELNAME ".l10n"
#define TRLT_IMPLNAME_PREFIX "com.sun.star.i18n.Transliteration."
//1...5...901...5...901...5...901..4 --> 34
diff --git a/i18npool/source/transliteration/hiraganaToKatakana.cxx
b/i18npool/source/transliteration/hiraganaToKatakana.cxx
index 439ec58365e2..80b6f14d82f8 100644
--- a/i18npool/source/transliteration/hiraganaToKatakana.cxx
+++ b/i18npool/source/transliteration/hiraganaToKatakana.cxx
@@ -22,12 +22,14 @@
using namespace com::sun::star::uno;
using namespace com::sun::star::lang;
-namespace i18npool {
-
+namespace i18npool
+{
// see http://charts.unicode.org/Web/U3040.html Hiragana (U+3040..U+309F)
// see http://charts.unicode.org/Web/U30A0.html Katakana (U+30A0..U+30FF)
-static sal_Unicode toKatakana (const sal_Unicode c) {
-if ( (0x3041 <= c && c <= 0x3096) || (0x309d <= c && c <= 0x309f) ) { //
3040 - 309F HIRAGANA LETTER
+static sal_Unicode toKatakana(const sal_Unicode c)
+{
+if ((0x3041 <= c && c <= 0x3096) || (0x309d <= c && c <= 0x309f))
+{ // 3040 - 309F HIRAGANA LETTER
// shift code point by 0x0060
return c + (0x30a0 - 0x3040);
}
@@ -41,7 +43,6 @@ hiraganaToKatakana::hiraganaToKatakana()
transliterationName = "hiraganaToKatakana";
implementationName = "com.sun.star.i18n.Transliteration.HIRAGANA_KATAKANA";
}
-
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/i18npool/source/transliteration/ignoreKashida_CTL.cxx
b/i18npool/source/transliteration/ignoreKashida_CTL.cxx
index 4dfb54da2e7d..e93ffd849481 100644
--- a/i18npool/source/transliteration/ignoreKashida_CTL.cxx
+++ b/i18npool/source/transliteration/ignoreKashida_CTL.cxx
@@ -9,12 +9,11 @@
#include
-namespace i18npool {
-
-static sal_Unicode
-ignoreKashida_CTL_translator (const sal_Unicode c)
+namespace i18npool
+{
+static sal_Unicode ignoreKashida_CTL_translator(const sal_Unicode c)
{
-if( c == 0x0640 ) // Check if it's Kashida
+if (c == 0x0640) // Check if it's Kashida
return 0x; // Then skip this character
return c;
@@ -28,7 +27,6 @@ ignoreKashida_CTL::ignoreKashida_CTL()
transliterationName = "ignoreKashida_CTL";
implementationName = "com.sun.star.i18n.Transliteration.ignoreKashida_CTL";
}
-
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/i18npool/source/transliteration/ignoreMiddleDot_ja_JP.cxx
b/i18npool/source/transliteration/ignoreMiddleDot_ja_JP.cxx
index b95a46910ae2..8b03275695bf 100644
--- a/i18npool/source/transliteration/ignoreMiddleDot_ja_JP.cxx
+++ b/i18npool/source/transliteration/ignoreMiddleDot_ja_JP.cxx
@@ -19,16 +19,16 @@
#include
-namespace i18npool {
-
-static sal_Unicode
-ignoreMiddleDot_ja_JP_translator (const sal_Unicode c)
+namespace i18npool
+{
+static sal_Unicode ignoreMiddleDot_ja_JP_translator(const sal_Unicode c)
{
-switch (c) {
+switch (c)
+{
case 0x30FB: // KATAKANA MIDDLE DOT
[Libreoffice-commits] core.git: chart2/inc chart2/qa chart2/source solenv/clang-format
chart2/inc/SpecialCharacters.hxx |3 chart2/qa/extras/xshape/chart2xshape.cxx | 39 ++--- chart2/source/controller/accessibility/AccessibleViewForwarder.hxx | 18 +- chart2/source/controller/accessibility/ChartElementFactory.cxx | 13 - chart2/source/controller/accessibility/ChartElementFactory.hxx |5 chart2/source/controller/chartapiwrapper/WrappedAutomaticPositionProperties.hxx | 15 +- chart2/source/controller/chartapiwrapper/WrappedTextRotationProperty.hxx | 10 - chart2/source/controller/dialogs/ChangingResource.cxx | 13 - chart2/source/controller/dialogs/TimerTriggeredControllerLock.cxx | 19 +- chart2/source/controller/dialogs/dlg_ChartType.cxx | 13 - chart2/source/controller/dialogs/dlg_InsertLegend.cxx | 11 - chart2/source/controller/dialogs/dlg_InsertTitle.cxx |7 chart2/source/controller/dialogs/dlg_NumberFormat.hxx |8 - chart2/source/controller/dialogs/res_BarGeometry.cxx | 15 -- chart2/source/controller/dialogs/res_Titles.cxx | 74 -- chart2/source/controller/dialogs/tp_3D_SceneIllumination.hxx | 30 ++-- chart2/source/controller/dialogs/tp_AxisPositions.hxx | 33 ++-- chart2/source/controller/dialogs/tp_DataLabel.hxx | 11 - chart2/source/controller/dialogs/tp_PointGeometry.hxx |7 chart2/source/controller/inc/ConfigurationAccess.hxx |4 chart2/source/controller/inc/ItemPropertyMap.hxx |8 - chart2/source/controller/inc/RangeSelectionListener.hxx | 25 +-- chart2/source/controller/inc/TabPageNotifiable.hxx |5 chart2/source/controller/inc/TextDirectionListBox.hxx |2 chart2/source/controller/inc/TimerTriggeredControllerLock.hxx | 21 +- chart2/source/controller/inc/dlg_ChartType.hxx |8 - chart2/source/controller/inc/dlg_CreationWizard.hxx | 21 +- chart2/source/controller/inc/dlg_InsertAxis_Grid.hxx | 10 - chart2/source/controller/inc/dlg_InsertErrorBars.hxx | 20 +- chart2/source/controller/inc/dlg_View3D.hxx |9 - chart2/source/controller/inc/res_Titles.hxx | 22 ++ chart2/source/controller/sidebar/ChartSidebarModifyListener.cxx | 15 -- chart2/source/controller/sidebar/ChartSidebarModifyListener.hxx |6 chart2/source/controller/sidebar/ChartSidebarSelectionListener.hxx |9 - chart2/source/inc/ChartViewHelper.hxx | 13 + chart2/source/inc/ControllerLockGuard.hxx | 26 ++- chart2/source/inc/DisposeHelper.hxx | 12 - chart2/source/inc/FastPropertyIdRanges.hxx | 17 +- chart2/source/inc/ModifyListenerCallBack.hxx | 14 + chart2/source/inc/PopupRequest.hxx | 10 - chart2/source/inc/ResId.hxx |3 chart2/source/inc/WrappedDirectStateProperty.hxx |9 - chart2/source/inc/chartview/ExplicitScaleValues.hxx | 30 ++-- chart2/source/inc/servicenames_charttypes.hxx |4 chart2/source/model/inc/CartesianCoordinateSystem.hxx | 21 +- chart2/source/model/inc/PolarCoordinateSystem.hxx | 21 +- chart2/source/model/template/ColumnLineDataInterpreter.hxx | 11 - chart2/source/model/template/FilledNetChartType.hxx | 14 - chart2/source/tools/ChartViewHelper.cxx | 18 +- chart2/source/tools/PopupRequest.cxx |8 - chart2/source/tools/TrueGuard.cxx | 10 - chart2/source/view/axes/TickmarkProperties.hxx |6 chart2/source/view/charttypes/BarPositionHelper.hxx |9 - chart2/source/view/charttypes/CategoryPositionHelper.hxx | 22 +- chart2/source/view/inc/LabelAlignment.hxx
[Libreoffice-commits] core.git: sdext/source solenv/clang-format
sdext/source/minimizer/pppoptimizer.cxx|9 -
sdext/source/minimizer/pppoptimizer.hxx|3 +--
sdext/source/minimizer/pppoptimizertoken.hxx |4 ++--
sdext/source/presenter/PresenterHelper.hxx | 22 +++---
sdext/source/presenter/PresenterPane.hxx | 24 +++-
sdext/source/presenter/PresenterSprite.hxx | 12 +---
sdext/source/presenter/PresenterSpritePane.hxx | 21 ++---
sdext/source/presenter/PresenterUIPainter.hxx | 15 ++-
solenv/clang-format/excludelist|8
9 files changed, 50 insertions(+), 68 deletions(-)
New commits:
commit a9bce41c64bda648be2609a0dc4aea728fa8ec77
Author: Philipp Hofer
AuthorDate: Thu Nov 12 13:14:32 2020 +0100
Commit: Christian Lohmaier
CommitDate: Sun Nov 22 01:56:27 2020 +0100
tdf#123936 Formatting files in module sdext with clang-format
Change-Id: Ibfed67a0f772ea0c02bf0e7267e9ed46517e2018
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105704
Reviewed-by: Christian Lohmaier
Tested-by: Jenkins
diff --git a/sdext/source/minimizer/pppoptimizer.cxx
b/sdext/source/minimizer/pppoptimizer.cxx
index 4d21ca3aabc9..c869f72187f6 100644
--- a/sdext/source/minimizer/pppoptimizer.cxx
+++ b/sdext/source/minimizer/pppoptimizer.cxx
@@ -17,19 +17,18 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
-
#include "pppoptimizer.hxx"
#include
// returning filesize, on error zero is returned
-sal_Int64 PPPOptimizer::GetFileSize( const OUString& rURL )
+sal_Int64 PPPOptimizer::GetFileSize(const OUString& rURL)
{
sal_Int64 nFileSize = 0;
osl::DirectoryItem aItem;
-if ( osl::DirectoryItem::get( rURL, aItem ) == osl::FileBase::E_None )
+if (osl::DirectoryItem::get(rURL, aItem) == osl::FileBase::E_None)
{
-osl::FileStatus aStatus( osl_FileStatus_Mask_FileSize );
-if ( aItem.getFileStatus( aStatus ) == osl::FileBase::E_None )
+osl::FileStatus aStatus(osl_FileStatus_Mask_FileSize);
+if (aItem.getFileStatus(aStatus) == osl::FileBase::E_None)
{
nFileSize = aStatus.getFileSize();
}
diff --git a/sdext/source/minimizer/pppoptimizer.hxx
b/sdext/source/minimizer/pppoptimizer.hxx
index cf1e5e0f244b..60b191a7bd07 100644
--- a/sdext/source/minimizer/pppoptimizer.hxx
+++ b/sdext/source/minimizer/pppoptimizer.hxx
@@ -22,10 +22,9 @@
#include
-
struct PPPOptimizer
{
-static sal_Int64 GetFileSize( const OUString& rURL );
+static sal_Int64 GetFileSize(const OUString& rURL);
};
#endif // INCLUDED_SDEXT_SOURCE_MINIMIZER_PPPOPTIMIZER_HXX
diff --git a/sdext/source/minimizer/pppoptimizertoken.hxx
b/sdext/source/minimizer/pppoptimizertoken.hxx
index 8f83e8dd8f8e..d0ae65ed74ab 100644
--- a/sdext/source/minimizer/pppoptimizertoken.hxx
+++ b/sdext/source/minimizer/pppoptimizertoken.hxx
@@ -140,8 +140,8 @@ enum PPPOptimizerTokenEnum
TK_NotFound
};
-PPPOptimizerTokenEnum TKGet( const OUString& );
-OUString TKGet( const PPPOptimizerTokenEnum );
+PPPOptimizerTokenEnum TKGet(const OUString&);
+OUString TKGet(const PPPOptimizerTokenEnum);
#endif
diff --git a/sdext/source/presenter/PresenterHelper.hxx
b/sdext/source/presenter/PresenterHelper.hxx
index 6704844d730c..7f4387c163bd 100644
--- a/sdext/source/presenter/PresenterHelper.hxx
+++ b/sdext/source/presenter/PresenterHelper.hxx
@@ -23,23 +23,23 @@
#include
#include
-namespace sdext::presenter {
-
+namespace sdext::presenter
+{
/** Collection of helper functions that do not fit in anywhere else.
Provide access to frequently used strings of the drawing framework.
*/
namespace PresenterHelper
{
-extern const OUString msCenterPaneURL;
-extern const OUString msFullScreenPaneURL;
+extern const OUString msCenterPaneURL;
+extern const OUString msFullScreenPaneURL;
-/** Return the slide show controller of a running presentation that has
-the same document as the given framework controller.
-@return
-When no presentation is running this method returns an empty
reference.
-*/
-css::uno::Reference
GetSlideShowController (
-const css::uno::Reference& rxController);
+/** Return the slide show controller of a running presentation that has
+the same document as the given framework controller.
+@return
+When no presentation is running this method returns an empty reference.
+*/
+css::uno::Reference
+GetSlideShowController(const css::uno::Reference&
rxController);
}
} // end of namespace presenter
diff --git a/sdext/source/presenter/PresenterPane.hxx
b/sdext/source/presenter/PresenterPane.hxx
index 62b1941695d6..2a057229f802 100644
--- a/sdext/source/presenter/PresenterPane.hxx
+++ b/sdext/source/presenter/PresenterPane.hxx
@@ -25,8 +25,8 @@
#include
#include
-namespace sdext::presenter {
-
+namespace sdext::presenter
+{
/** Pane used by the presenter
[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format
compilerplugins/clang/expressionalwayszero.cxx | 54 +++-
compilerplugins/clang/store/cascadingcondop.cxx | 25 +--
compilerplugins/clang/store/test/deadclass.cxx |3 -
compilerplugins/clang/test/datamembershadow.cxx |6 +-
compilerplugins/clang/test/external.hxx |5 --
compilerplugins/clang/test/oslendian-1.cxx | 12 ++---
compilerplugins/clang/test/redundantcast.hxx| 11 ++--
compilerplugins/clang/test/stringconcatauto.cxx | 34 ++-
solenv/clang-format/excludelist |8 ---
9 files changed, 72 insertions(+), 86 deletions(-)
New commits:
commit c096ab87c8a11e8d75dc689ea7024288419cfd22
Author: Philipp Hofer
AuthorDate: Thu Nov 12 12:51:50 2020 +0100
Commit: Christian Lohmaier
CommitDate: Sun Nov 22 01:56:05 2020 +0100
tdf#123936 Formatting files in module compilerplugins with clang-format
Change-Id: Ie6e23d3d2a20849e47d048b439d72fd7376c53db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105654
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier
diff --git a/compilerplugins/clang/expressionalwayszero.cxx
b/compilerplugins/clang/expressionalwayszero.cxx
index 067aa9cc6dbd..24e7287615ba 100644
--- a/compilerplugins/clang/expressionalwayszero.cxx
+++ b/compilerplugins/clang/expressionalwayszero.cxx
@@ -21,13 +21,15 @@
Generally a mistake when people meant to use | or operator|
*/
-namespace {
-
-class ExpressionAlwaysZero:
-public loplugin::FilteringPlugin
+namespace
+{
+class ExpressionAlwaysZero : public
loplugin::FilteringPlugin
{
public:
-explicit ExpressionAlwaysZero(loplugin::InstantiationData const & data):
FilteringPlugin(data) {}
+explicit ExpressionAlwaysZero(loplugin::InstantiationData const& data)
+: FilteringPlugin(data)
+{
+}
virtual void run() override
{
@@ -57,15 +59,16 @@ public:
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
}
-bool VisitBinaryOperator(BinaryOperator const *);
-bool VisitCXXOperatorCallExpr(CXXOperatorCallExpr const *);
-bool TraverseStaticAssertDecl(StaticAssertDecl *);
+bool VisitBinaryOperator(BinaryOperator const*);
+bool VisitCXXOperatorCallExpr(CXXOperatorCallExpr const*);
+bool TraverseStaticAssertDecl(StaticAssertDecl*);
+
private:
// note, abusing std::unique_ptr as a std::optional lookalike
std::unique_ptr getExprValue(const Expr* arg);
};
-bool ExpressionAlwaysZero::VisitBinaryOperator( BinaryOperator const *
binaryOperator )
+bool ExpressionAlwaysZero::VisitBinaryOperator(BinaryOperator const*
binaryOperator)
{
if (ignoreLocation(binaryOperator))
return true;
@@ -86,16 +89,14 @@ bool ExpressionAlwaysZero::VisitBinaryOperator(
BinaryOperator const * binaryOpe
; // ok
else
return true;
-report(
-DiagnosticsEngine::Warning, "expression always evaluates to zero,
lhs=%0 rhs=%1",
-compat::getBeginLoc(binaryOperator))
+report(DiagnosticsEngine::Warning, "expression always evaluates to zero,
lhs=%0 rhs=%1",
+ compat::getBeginLoc(binaryOperator))
<< (lhsValue ? lhsValue->toString(10) : "unknown")
-<< (rhsValue ? rhsValue->toString(10) : "unknown")
-<< binaryOperator->getSourceRange();
+<< (rhsValue ? rhsValue->toString(10) : "unknown") <<
binaryOperator->getSourceRange();
return true;
}
-bool ExpressionAlwaysZero::VisitCXXOperatorCallExpr( CXXOperatorCallExpr const
* cxxOperatorCallExpr )
+bool ExpressionAlwaysZero::VisitCXXOperatorCallExpr(CXXOperatorCallExpr const*
cxxOperatorCallExpr)
{
if (ignoreLocation(cxxOperatorCallExpr))
return true;
@@ -103,7 +104,7 @@ bool ExpressionAlwaysZero::VisitCXXOperatorCallExpr(
CXXOperatorCallExpr const *
return true;
auto op = cxxOperatorCallExpr->getOperator();
-if ( !(op == OO_Amp || op == OO_AmpEqual || op == OO_AmpAmp))
+if (!(op == OO_Amp || op == OO_AmpEqual || op == OO_AmpAmp))
return true;
if (cxxOperatorCallExpr->getNumArgs() != 2)
@@ -118,20 +119,19 @@ bool ExpressionAlwaysZero::VisitCXXOperatorCallExpr(
CXXOperatorCallExpr const *
; // ok
else
return true;
-report(
-DiagnosticsEngine::Warning, "expression always evaluates to zero,
lhs=%0 rhs=%1",
-compat::getBeginLoc(cxxOperatorCallExpr))
+report(DiagnosticsEngine::Warning, "expression always evaluates to zero,
lhs=%0 rhs=%1",
+ compat::getBeginLoc(cxxOperatorCallExpr))
<< (lhsValue ? lhsValue->toString(10) : "unknown")
-<< (rhsValue ? rhsValue->toString(10) : "unknown")
-<< cxxOperatorCallExpr->getSourceRange();
+<< (rhsValue ? rhsValue->toString(10) : "unknown") <<
cxxOperatorCallExpr->getSourceRange();
return true;
}
-std::unique_ptr ExpressionAlwaysZero::getExprValue(Expr const * expr)
+std::unique_ptr
[Libreoffice-commits] core.git: sfx2/inc sfx2/qa sfx2/source solenv/clang-format
sfx2/inc/emojicontrol.hxx |5 +-
sfx2/inc/emojiview.hxx| 20 -
sfx2/inc/fwkhelper.hxx|4 -
sfx2/inc/sidebar/DeckDescriptor.hxx |6 +-
sfx2/inc/sidebar/DeckTitleBar.hxx |9 +---
sfx2/inc/strings.hxx | 28 ++---
sfx2/inc/templatecontaineritem.hxx|4 -
sfx2/inc/templatedefaultview.hxx |6 +-
sfx2/qa/unit/sfx2-dialogs-test.cxx|9
sfx2/source/appl/appquit.cxx | 17 +++-
sfx2/source/bastyp/sfxresid.cxx |5 --
sfx2/source/control/charwin.cxx | 55 +++---
sfx2/source/control/emojipopup.cxx| 16 +++
sfx2/source/control/itemdel.cxx | 20 +++--
sfx2/source/control/templatecontaineritem.cxx |8 ---
sfx2/source/dialog/alienwarn.cxx | 15 +++
sfx2/source/dialog/backingwindow.hxx | 11 ++---
sfx2/source/dialog/charmappopup.cxx | 18 +++-
sfx2/source/dialog/dialoghelper.cxx |9 +---
sfx2/source/dialog/inputdlg.cxx | 14 +-
sfx2/source/dialog/securitypage.hxx |9 ++--
sfx2/source/dialog/sfxdlg.cxx |7 ---
sfx2/source/dialog/styfitem.cxx |7 ++-
sfx2/source/doc/QuerySaveDocument.cxx |3 -
sfx2/source/doc/syspath.cxx |4 -
sfx2/source/inc/appopen.hxx |5 --
sfx2/source/inc/childwinimpl.hxx | 19
sfx2/source/inc/ctrlfactoryimpl.hxx | 12 ++---
sfx2/source/inc/documentfontsdialog.hxx | 14 --
sfx2/source/inc/helper.hxx| 11 ++---
sfx2/source/inc/nochaos.hxx |4 -
sfx2/source/inc/openflag.hxx |7 +--
sfx2/source/inc/openurlhint.hxx |4 -
sfx2/source/inc/sfxtypes.hxx |6 --
sfx2/source/inc/shellimpl.hxx | 26 +---
sfx2/source/inc/templatesearchviewitem.hxx|7 +--
sfx2/source/inc/versdlg.hxx | 10 ++--
sfx2/source/notebookbar/DropdownBox.cxx | 17 ++--
sfx2/source/notebookbar/PriorityHBox.cxx | 20 -
sfx2/source/notify/hintpost.cxx | 17 +++-
sfx2/source/safemode/safemode.cxx | 13 ++
sfx2/source/sidebar/SidebarModelUpdate.cxx|7 ---
sfx2/source/sidebar/UnoSidebar.cxx| 26
sfx2/source/view/viewimp.hxx |8 +--
solenv/clang-format/excludelist | 44
45 files changed, 238 insertions(+), 348 deletions(-)
New commits:
commit b35232bdf56fbda34476cf537d53bbea31235a95
Author: Philipp Hofer
AuthorDate: Thu Nov 12 13:15:32 2020 +0100
Commit: Christian Lohmaier
CommitDate: Sun Nov 22 01:55:36 2020 +0100
tdf#123936 Formatting files in module sfx2 with clang-format
Change-Id: I0ddd7b531cbf9aed6a3834e3cd15c7fe3644736e
(cherry picked from commit 92daf140419e4539f6843e30428e786c3e655dcc)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105706
Reviewed-by: Christian Lohmaier
Tested-by: Jenkins
diff --git a/sfx2/inc/emojicontrol.hxx b/sfx2/inc/emojicontrol.hxx
index eee551600da4..2e2ab150762f 100644
--- a/sfx2/inc/emojicontrol.hxx
+++ b/sfx2/inc/emojicontrol.hxx
@@ -14,7 +14,10 @@
#include
#include
-namespace com::sun::star::frame { class XFrame; }
+namespace com::sun::star::frame
+{
+class XFrame;
+}
class EmojiPopup;
class EmojiView;
diff --git a/sfx2/inc/emojiview.hxx b/sfx2/inc/emojiview.hxx
index 223d3872..52bb47bf0bc0 100644
--- a/sfx2/inc/emojiview.hxx
+++ b/sfx2/inc/emojiview.hxx
@@ -34,21 +34,19 @@ enum class FILTER_CATEGORY
class ViewFilter_Category final
{
public:
-
-ViewFilter_Category (FILTER_CATEGORY rCategory)
+ViewFilter_Category(FILTER_CATEGORY rCategory)
: mCategory(rCategory)
-{}
+{
+}
-bool operator () (const ThumbnailViewItem *pItem);
+bool operator()(const ThumbnailViewItem* pItem);
-static bool isFilteredCategory(FILTER_CATEGORY filter, const OUString
);
+static bool isFilteredCategory(FILTER_CATEGORY filter, const OUString&
rCategory);
private:
-
FILTER_CATEGORY mCategory;
};
-
class EmojiView final : public ThumbnailView
{
public:
@@ -59,16 +57,16 @@ public:
// Fill view with emojis
void Populate();
-void setInsertEmojiHdl (const Link );
+void setInsertEmojiHdl(const Link& rLink);
-void AppendItem(const OUString , const OUString , const
OUString );
+void AppendItem(const OUString& rTitle, const OUString& rCategory, const
OUString& rName);
private:
-virtual bool MouseButtonDown( const MouseEvent& rMEvt ) override;
+virtual bool MouseButtonDown(const MouseEvent& rMEvt) override;
virtual
[Libreoffice-commits] core.git: solenv/clang-format vcl/backendtest vcl/headless vcl/inc vcl/opengl vcl/osx vcl/qa vcl/source vcl/unx vcl/win vcl/workben
solenv/clang-format/excludelist| 118 --- vcl/backendtest/outputdevice/gradient.cxx | 36 - vcl/backendtest/outputdevice/pixel.cxx |7 vcl/backendtest/outputdevice/polypolygon.cxx | 16 vcl/backendtest/outputdevice/rectangle.cxx | 30 vcl/headless/svpcairotextrender.cxx| 10 vcl/inc/BitmapScaleConvolutionFilter.hxx |6 vcl/inc/BitmapScaleSuperFilter.hxx |1 vcl/inc/BitmapSymmetryCheck.hxx|2 vcl/inc/ControlCacheKey.hxx| 13 vcl/inc/IconThemeScanner.hxx | 26 vcl/inc/android/androidinst.hxx| 14 vcl/inc/headless/svpprn.hxx|4 vcl/inc/iconview.hxx |5 vcl/inc/ios/iosinst.hxx| 13 vcl/inc/langboost.hxx |2 vcl/inc/opengl/BufferObject.hxx|8 vcl/inc/opengl/TextureState.hxx|7 vcl/inc/opengl/x11/gdiimpl.hxx |6 vcl/inc/opengl/zone.hxx| 12 vcl/inc/osx/a11ylistener.hxx | 11 vcl/inc/osx/keyboardfocuslistener.hxx |5 vcl/inc/osx/salnsmenu.h| 20 vcl/inc/osx/salnstimer.h |2 vcl/inc/quartz/ctfonts.hxx |2 vcl/inc/regionband.hxx | 11 vcl/inc/salsys.hxx | 10 vcl/inc/scanlinewriter.hxx | 15 vcl/inc/scrptrun.h | 47 - vcl/inc/unx/desktops.hxx |3 vcl/inc/unx/i18n_keysym.hxx|2 vcl/inc/unx/salunx.h |6 vcl/inc/unx/screensaverinhibitor.hxx | 18 vcl/inc/unx/x11/x11gdiimpl.h |4 vcl/inc/unx/x11_cursors/wshide_curs.h |6 vcl/inc/unx/x11_cursors/wshide_mask.h |6 vcl/inc/unx/x11_cursors/wsshow_curs.h |6 vcl/inc/unx/x11_cursors/wsshow_mask.h |6 vcl/inc/vcleventlisteners.hxx |9 vcl/opengl/DeviceInfo.cxx |4 vcl/osx/DragActionConversion.cxx | 40 - vcl/osx/PictToBmpFlt.hxx |9 vcl/osx/a11yactionwrapper.h|4 vcl/osx/a11ycomponentwrapper.h | 12 vcl/osx/a11yfocuslistener.hxx | 11 vcl/osx/a11yselectionwrapper.h |8 vcl/osx/a11ytablewrapper.h |8 vcl/osx/a11ytextwrapper.h | 50 - vcl/osx/a11yutil.h |7 vcl/osx/a11yvaluewrapper.h | 12 vcl/osx/a11ywrapperbutton.h|6 vcl/osx/a11ywrappercheckbox.h |6 vcl/osx/a11ywrappercombobox.h | 21 vcl/osx/a11ywrappergroup.h |4 vcl/osx/a11ywrapperlist.h |2 vcl/osx/a11ywrapperradiobutton.h |6 vcl/osx/a11ywrapperradiogroup.h|2 vcl/osx/a11ywrapperrow.h |4 vcl/osx/a11ywrapperscrollarea.h|6 vcl/osx/a11ywrapperscrollbar.h |2 vcl/osx/a11ywrappersplitter.h |2 vcl/osx/a11ywrapperstatictext.h|4 vcl/osx/a11ywrappertabgroup.h |2 vcl/osx/a11ywrappertextarea.h |2 vcl/osx/a11ywrappertoolbar.h |2 vcl/qa/cppunit/BitmapProcessorTest.cxx |1 vcl/qa/cppunit/fontcharmap.cxx | 11 vcl/qa/cppunit/jpeg/JpegReaderTest.cxx | 16 vcl/qa/cppunit/mnemonic.cxx|6 vcl/qa/cppunit/outdev.cxx | 33 - vcl/qa/cppunit/pdfexport/pdfexport.cxx | 385 +++ vcl/qa/unit/vcl-dialogs-test.cxx |9 vcl/source/app/ITiledRenderable.cxx| 30 vcl/source/app/salvtables.cxx | 675 + vcl/source/app/sound.cxx |2 vcl/source/bitmap/bitmapfilter.cxx |4 vcl/source/control/thumbpos.hxx|5 vcl/source/filter/graphicfilter_internal.hxx |2 vcl/source/filter/igif/gifread.hxx |2 vcl/source/filter/ixbm/xbmread.hxx |2 vcl/source/filter/ixpm/xpmread.hxx |2 vcl/source/filter/jpeg/JpegTransform.hxx |7 vcl/source/filter/jpeg/jinclude.h
[Libreoffice-bugs] [Bug 124007] Doesn't set up focus into text field in Autofilter window
https://bugs.documentfoundation.org/show_bug.cgi?id=124007 Kevin Suo changed: What|Removed |Added Status|RESOLVED|VERIFIED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138400] UI Calc Wrong icons showing for format as general and format as currency
https://bugs.documentfoundation.org/show_bug.cgi?id=138400 --- Comment #3 from Jay --- Created attachment 167465 --> https://bugs.documentfoundation.org/attachment.cgi?id=167465=edit Format as Currency -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138400] UI Calc Wrong icons showing for format as general and format as currency
https://bugs.documentfoundation.org/show_bug.cgi?id=138400 --- Comment #2 from Jay --- Created attachment 167464 --> https://bugs.documentfoundation.org/attachment.cgi?id=167464=edit Format as General -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138400] UI Calc Wrong icons showing for format as general and format as currency
https://bugs.documentfoundation.org/show_bug.cgi?id=138400 --- Comment #1 from Jay --- Created attachment 167463 --> https://bugs.documentfoundation.org/attachment.cgi?id=167463=edit Picture of toolbar segment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138400] New: UI Calc Wrong icons showing for format as general and format as currency
https://bugs.documentfoundation.org/show_bug.cgi?id=138400 Bug ID: 138400 Summary: UI Calc Wrong icons showing for format as general and format as currency Product: LibreOffice Version: 6.4.7.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: b...@outlook.com Description: The icon on the Formatting toolbar for the Format as General function shows $0, while the icon for Format as Currency function shows a rectangle containing shapes. Steps to Reproduce: 1. Look at the Formatting toolbar 2. 3. Actual Results: The icon on the Formatting toolbar for the Format as General function shows $0, while the icon for Format as Currency function shows a rectangle containing shapes. Expected Results: The icon on the Formatting toolbar for the Format as General function would be a number (like 123 or 999 or something similar) and the icon for Format as Currency function would be $0 Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: SpreadsheetDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: no Version: 6.4.7.2 (x64) Build ID: 639b8ac485750d5696d7590a72ef1b496725cfb5 CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: default; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138395] Separator/Divider lines in menus should have an optional text label (see included mockup image)
https://bugs.documentfoundation.org/show_bug.cgi?id=138395 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #6 from V Stuart Foote --- I think Mike's point was that there is no way to do this consistently cross platform without imposing a lot of native code overhead if even possible. My take is that it is not justified as existing separators would not be improved by addition of labeling. IMHO -1, and a clear WF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124007] Doesn't set up focus into text field in Autofilter window
https://bugs.documentfoundation.org/show_bug.cgi?id=124007 --- Comment #6 from Roman Kuznetsov <79045_79...@mail.ru> --- (In reply to Kevin Suo from comment #5) > Mark as WORKSFORME since it works in recent version (libreoffice 7.0). Feel > free to set back to NEW if you don't agree. Confirm WFM status in 7.1 version on Windows, so nice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138399] New: Calc missing the ability to use a formula to specify a data range for a chart
https://bugs.documentfoundation.org/show_bug.cgi?id=138399 Bug ID: 138399 Summary: Calc missing the ability to use a formula to specify a data range for a chart Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Chart Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: b...@outlook.com Description: Excel allows a formula to be used in the specification of a range in a chart. I would like to suggest that this capability be added to Calc. For example a formula such as IF(ISLEAPYEAR(),C4:C32,C4:C31) in the range specification of a chart would be very useful for creating a chart that would work for both leap years and standard years by showing only the appropriate number of days in a chart of data for each day of the month of February. The version that I am currently running is Version: 6.4.7.2 (x64), but I first noticed the lack of this capability in version 6.2.8.2 however I am certain that it is a condition inherited from OOo. Steps to Reproduce: This is an enhancement request, there are no steps to reproduce it. Actual Results: This is an enhancement request, there are no actual results. Expected Results: This is an enhancement request, there are no expected results. Reproducible: Always User Profile Reset: No Additional Info: Version: 6.4.7.2 (x64) Build ID: 639b8ac485750d5696d7590a72ef1b496725cfb5 CPU threads: 4; OS: Windows 10.0 Build 19041.630; UI render: default; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138398] MAILMERGE: nothing append when sending range emails (no problem with mailing all or printing)
https://bugs.documentfoundation.org/show_bug.cgi?id=138398 Thierry Munoz changed: What|Removed |Added Summary|MAILMERGE: nothing append |MAILMERGE: nothing append |when sending emails (no |when sending range emails |problem with printing) |(no problem with mailing ||all or printing) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138398] MAILMERGE: nothing append when sending emails (no problem with printing)
https://bugs.documentfoundation.org/show_bug.cgi?id=138398 --- Comment #5 from Thierry Munoz --- This problem occurs only when you select a range of email. If we send all the documents by email, there's no problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138395] Separator/Divider lines in menus should have an optional text label (see included mockup image)
https://bugs.documentfoundation.org/show_bug.cgi?id=138395 --- Comment #5 from Riban --- Cool, thanks! Good to hear there's hope. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: desktop/source
desktop/source/lib/init.cxx |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit a65141b2b46ad8150bafca4629b0ef924978a201 Author: Tor Lillqvist AuthorDate: Thu Sep 3 22:28:29 2020 +0300 Commit: Tor Lillqvist CommitDate: Sat Nov 21 23:21:57 2020 +0100 Must now call the lovely SfxViewShell::SetCurrentDocId() Fixes fallout from 4fd2679a7a2b0494da84f344ab97b835edf73377. Otherwise the SfxViewShell doesn't know the id of its document, and counting the number of views of a document in SfxLokHelper::getViewsCount() fails. Change-Id: I16ba209463281aae4ab9fdfd4ee1cd6b98205774 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102025 Tested-by: Jenkins CollaboraOffice Reviewed-by: Tor Lillqvist Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106254 Tested-by: Jenkins diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index 9bcfff524bbf..cf8503bf136d 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -2278,6 +2278,8 @@ static LibreOfficeKitDocument* lo_documentLoadWithOptions(LibreOfficeKit* pThis, aFilterOptions[3].Value <<= nUpdateDoc; */ +const int nThisDocumentId = nDocumentIdCounter++; +SfxViewShell::SetCurrentDocId(ViewShellDocId(nThisDocumentId)); uno::Reference xComponent = xComponentLoader->loadComponentFromURL( aURL, "_blank", 0, aFilterOptions); @@ -2291,7 +2293,7 @@ static LibreOfficeKitDocument* lo_documentLoadWithOptions(LibreOfficeKit* pThis, return nullptr; } -LibLODocument_Impl* pDocument = new LibLODocument_Impl(xComponent, nDocumentIdCounter++); +LibLODocument_Impl* pDocument = new LibLODocument_Impl(xComponent, nThisDocumentId); // After loading the document, its initial view is the "current" view. if (pLib->mpCallback) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: desktop/qa
desktop/qa/desktop_lib/test_desktop_lib.cxx | 181 ++--
1 file changed, 92 insertions(+), 89 deletions(-)
New commits:
commit cf09258fc3287b6299d07799dce22d9b9fd1ebb7
Author: Tor Lillqvist
AuthorDate: Thu Sep 3 21:51:16 2020 +0300
Commit: Tor Lillqvist
CommitDate: Sat Nov 21 23:20:23 2020 +0100
Test also that loading more documents after closing all open ones works
Just run the code in DesktopLOKTest::testMultiDocuments() in a short
loop.
Sadly this did not find the actual problem that is present in the
code, though. (A follow-up commit will fix that problem, and then I
might also change this unit test so that it would have found that
problem.)
Change-Id: Ie847d04e77ea3d712820413fa0f00521207eb7de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102018
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Tor Lillqvist
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106253
Tested-by: Jenkins
diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index 0a19d5582e80..701f624038c5 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -2940,95 +2940,98 @@ void DesktopLOKTest::testSpellcheckerMultiView()
void DesktopLOKTest::testMultiDocuments()
{
-// Load a document.
-uno::Reference xComponent1;
-std::unique_ptr document1;
-std::tie(document1, xComponent1) = loadDocImpl("blank_text.odt");
-LibLODocument_Impl* pDocument1 = document1.get();
-CPPUNIT_ASSERT_EQUAL(1,
pDocument1->m_pDocumentClass->getViewsCount(pDocument1));
-const int nDocId1 = pDocument1->mnDocumentId;
-
-const int nDoc1View0 = pDocument1->m_pDocumentClass->getView(pDocument1);
-CPPUNIT_ASSERT_EQUAL(nDocId1,
SfxLokHelper::getDocumentIdOfView(nDoc1View0));
-const int nDoc1View1 =
pDocument1->m_pDocumentClass->createView(pDocument1);
-CPPUNIT_ASSERT_EQUAL(nDoc1View1,
pDocument1->m_pDocumentClass->getView(pDocument1));
-CPPUNIT_ASSERT_EQUAL(nDocId1,
SfxLokHelper::getDocumentIdOfView(nDoc1View1));
-CPPUNIT_ASSERT_EQUAL(2,
pDocument1->m_pDocumentClass->getViewsCount(pDocument1));
-
-// Validate the views of document 1.
-std::vector aViewIdsDoc1(2);
-CPPUNIT_ASSERT(pDocument1->m_pDocumentClass->getViewIds(pDocument1,
aViewIdsDoc1.data(), aViewIdsDoc1.size()));
-CPPUNIT_ASSERT_EQUAL(nDoc1View0, aViewIdsDoc1[0]);
-CPPUNIT_ASSERT_EQUAL(nDoc1View1, aViewIdsDoc1[1]);
-
-CPPUNIT_ASSERT_EQUAL(nDoc1View1,
pDocument1->m_pDocumentClass->getView(pDocument1));
-CPPUNIT_ASSERT_EQUAL(nDocId1,
SfxLokHelper::getDocumentIdOfView(nDoc1View1));
-pDocument1->m_pDocumentClass->setView(pDocument1, nDoc1View0);
-CPPUNIT_ASSERT_EQUAL(nDoc1View0,
pDocument1->m_pDocumentClass->getView(pDocument1));
-CPPUNIT_ASSERT_EQUAL(nDocId1,
SfxLokHelper::getDocumentIdOfView(nDoc1View0));
-pDocument1->m_pDocumentClass->setView(pDocument1, nDoc1View1);
-CPPUNIT_ASSERT_EQUAL(nDoc1View1,
pDocument1->m_pDocumentClass->getView(pDocument1));
-CPPUNIT_ASSERT_EQUAL(nDocId1,
SfxLokHelper::getDocumentIdOfView(nDoc1View1));
-CPPUNIT_ASSERT_EQUAL(2,
pDocument1->m_pDocumentClass->getViewsCount(pDocument1));
-
-// Load another document.
-uno::Reference xComponent2;
-std::unique_ptr document2;
-std::tie(document2, xComponent2) = loadDocImpl("blank_presentation.odp");
-LibLODocument_Impl* pDocument2 = document2.get();
-CPPUNIT_ASSERT_EQUAL(1,
pDocument2->m_pDocumentClass->getViewsCount(pDocument2));
-const int nDocId2 = pDocument2->mnDocumentId;
-
-const int nDoc2View0 = pDocument2->m_pDocumentClass->getView(pDocument2);
-CPPUNIT_ASSERT_EQUAL(nDocId2,
SfxLokHelper::getDocumentIdOfView(nDoc2View0));
-const int nDoc2View1 =
pDocument2->m_pDocumentClass->createView(pDocument2);
-CPPUNIT_ASSERT_EQUAL(nDoc2View1,
pDocument2->m_pDocumentClass->getView(pDocument2));
-CPPUNIT_ASSERT_EQUAL(nDocId2,
SfxLokHelper::getDocumentIdOfView(nDoc2View1));
-CPPUNIT_ASSERT_EQUAL(2,
pDocument2->m_pDocumentClass->getViewsCount(pDocument2));
-
-// Validate the views of document 2.
-std::vector aViewIdsDoc2(2);
-CPPUNIT_ASSERT(pDocument2->m_pDocumentClass->getViewIds(pDocument2,
aViewIdsDoc2.data(), aViewIdsDoc2.size()));
-CPPUNIT_ASSERT_EQUAL(nDoc2View0, aViewIdsDoc2[0]);
-CPPUNIT_ASSERT_EQUAL(nDoc2View1, aViewIdsDoc2[1]);
-
-CPPUNIT_ASSERT_EQUAL(nDoc2View1,
pDocument2->m_pDocumentClass->getView(pDocument2));
-CPPUNIT_ASSERT_EQUAL(nDocId2,
SfxLokHelper::getDocumentIdOfView(nDoc2View1));
-pDocument2->m_pDocumentClass->setView(pDocument2, nDoc2View0);
-CPPUNIT_ASSERT_EQUAL(nDoc2View0,
pDocument2->m_pDocumentClass->getView(pDocument2));
-CPPUNIT_ASSERT_EQUAL(nDocId2,
SfxLokHelper::getDocumentIdOfView(nDoc2View0));
-pDocument2->m_pDocumentClass->setView(pDocument2, nDoc2View1);
-
[Libreoffice-bugs] [Bug 68810] VIEWING: WMF image is black / dark in Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=68810 Aron Budea changed: What|Removed |Added Keywords|bibisectRequest | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138398] MAILMERGE: nothing append when sending emails (no problem with printing)
https://bugs.documentfoundation.org/show_bug.cgi?id=138398 --- Comment #4 from Thierry Munoz --- Created attachment 167462 --> https://bugs.documentfoundation.org/attachment.cgi?id=167462=edit Connection test OK with smtp account Connection test is OK with the smtp account in the Internet options. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138398] MAILMERGE: nothing append when sending emails (no problem with printing)
https://bugs.documentfoundation.org/show_bug.cgi?id=138398 --- Comment #3 from Thierry Munoz --- Created attachment 167461 --> https://bugs.documentfoundation.org/attachment.cgi?id=167461=edit The email application in LibreOffice Writer e-mailing option The path to Thunderbird, working in command line. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138395] Separator/Divider lines in menus should have an optional text label (see included mockup image)
https://bugs.documentfoundation.org/show_bug.cgi?id=138395 --- Comment #4 from Mike Kaganski --- (In reply to Riban from comment #3) > Correct me if I am wrong, but the Windows version of LO has some features > that other platform don't have, right? For example Jump List support for the > Windows Task Bar. LibreOffice does not use Jump List feature of Windows (unfortunately). Windows uses whatever it does by default. However, I didn't close it right away, and added the needsUXEval keyword, so that the team could evaluate it. My comment was just a personal thought. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138395] Separator/Divider lines in menus should have an optional text label (see included mockup image)
https://bugs.documentfoundation.org/show_bug.cgi?id=138395 --- Comment #3 from Riban --- What I have in mind is an additional entry in the customization options for the menus: something like "Labelled Separator" in addition to the now existing normal "Separator" line. At least in supported operating systems. Correct me if I am wrong, but the Windows version of LO has some features that other platform don't have, right? For example Jump List support for the Windows Task Bar. So maybe this labelled separator could become such a feature, too, where supported by the platform and missing where it is not supported. On a more general note (not only regarding LO): It's kind of a pity to see that sometimes features/enhancements aren't developed because of the so-called "lowest common denominator" between different/multiple/all platforms. Maybe this feature idea could be evaluated how possible it's implementation would be and where? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Tolunay Dündar license statement
All of my past & future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license.___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=71732 Bug 71732 depends on bug 136121, which changed state. Bug 136121 Summary: Digits (1234 etc.) not rendered when font set as Noto Kufi Arabic - English characters rendered using fallback font, but digits are not (Regression from 6.0.7, example file in comment 10) https://bugs.documentfoundation.org/show_bug.cgi?id=136121 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136121] Digits (1234 etc.) not rendered when font set as Noto Kufi Arabic - English characters rendered using fallback font, but digits are not (Regression from 6.0.7, example
https://bugs.documentfoundation.org/show_bug.cgi?id=136121 Taher Alkhateeb changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEEDINFO|RESOLVED --- Comment #16 from Taher Alkhateeb --- Hello, Thank you for all the support you guys. I'm resolving this ticket as I have moved away from Linux Mint. I had this problem in two different computers and so I thought this might be a problem generally with Linux Mint, but since then I'm on Arch and everything seems to be working fine. If I face this problem in the future I might re-open a ticket to identify a recurring problem, but I think by now this problem might not be worth all the effort. Thank you all again Cheers, Taher Alkhateeb -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards
https://bugs.documentfoundation.org/show_bug.cgi?id=124176 --- Comment #151 from Commit Notification --- Umut Emre Bayramoglu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ddc9c95745183e2e6d7791bcd3248db976c89f4e tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/inc/wrap.hxx |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
New commits:
commit ddc9c95745183e2e6d7791bcd3248db976c89f4e
Author: Umut Emre Bayramoglu
AuthorDate: Sat Nov 21 15:54:18 2020 +
Commit: Julien Nabet
CommitDate: Sat Nov 21 22:38:54 2020 +0100
tdf#124176: Use pragma once instead of include guards
Change-Id: I92c70f2f540c9179c36acfdf9484da2600bed38c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106321
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/sw/source/uibase/inc/wrap.hxx b/sw/source/uibase/inc/wrap.hxx
index 60313ffd4da6..3a69e43ff210 100644
--- a/sw/source/uibase/inc/wrap.hxx
+++ b/sw/source/uibase/inc/wrap.hxx
@@ -16,8 +16,8 @@
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
-#ifndef INCLUDED_SW_SOURCE_UIBASE_INC_WRAP_HXX
-#define INCLUDED_SW_SOURCE_UIBASE_INC_WRAP_HXX
+
+#pragma once
#include
#include
@@ -92,6 +92,4 @@ public:
void SetShell(SwWrtShell* pSh) { m_pWrtSh = pSh; }
};
-#endif
-
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 138398] MAILMERGE: nothing append when sending emails (no problem with printing)
https://bugs.documentfoundation.org/show_bug.cgi?id=138398 --- Comment #2 from Thierry Munoz --- Created attachment 167460 --> https://bugs.documentfoundation.org/attachment.cgi?id=167460=edit Box hanging with details -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: desktop/inc desktop/qa desktop/source include/editeng include/sfx2 sc/source sd/qa sd/source sfx2/source sw/qa
desktop/inc/lib/init.hxx |3
desktop/qa/desktop_lib/test_desktop_lib.cxx| 100
desktop/source/lib/init.cxx| 36 ---
include/editeng/outliner.hxx |1
include/sfx2/lokhelper.hxx | 17 ++-
include/sfx2/viewsh.hxx| 15 ++-
sc/source/ui/view/tabvwshc.cxx |3
sd/qa/unit/tiledrendering/LOKitSearchTest.cxx |1
sd/source/ui/unoidl/unomodel.cxx |3
sfx2/source/view/lokhelper.cxx | 120 +
sfx2/source/view/viewimp.hxx |4
sfx2/source/view/viewsh.cxx| 13 +-
sw/qa/extras/tiledrendering/tiledrendering.cxx |2
13 files changed, 249 insertions(+), 69 deletions(-)
New commits:
commit e82335afd6e3e9a75275865661cf14a0a2959603
Author: Ashod Nakashian
AuthorDate: Sun Aug 2 14:52:02 2020 -0400
Commit: Tor Lillqvist
CommitDate: Sat Nov 21 22:26:19 2020 +0100
sfx2: lok: reliably support multi-documents
Instead of using the current view to set
the DocId, we instead make sure that the ShellView
object has the DocId set at construction time.
This turned out to be necessary in at least one
case (which has a unit-test that failed), which
is when events fired during the creation of a
new view. The cursor position is notified
before we have a chance to set the DocId and
because of that we miss the notifications (or
worse, we end up sending them to all other
documents' views in an effort to fix this bug).
This approach is clean and always guarantees that
all views have the correct DocId set as soon as
possible and that all notifications are sent
as expected.
A unit-test is added to exercise mult-document
usage, which exposed a number of bugs and issues
that have been addressed in this patch.
Change-Id: Icf5145fb1dabd0d029368310c2b9bf73ae927ccc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99975
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Michael Meeks
Reviewed-by: Ashod Nakashian
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106252
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist
diff --git a/desktop/inc/lib/init.hxx b/desktop/inc/lib/init.hxx
index a71ecae79f83..84d9d5299fd4 100644
--- a/desktop/inc/lib/init.hxx
+++ b/desktop/inc/lib/init.hxx
@@ -150,7 +150,8 @@ namespace desktop {
std::map>
mpCallbackFlushHandlers;
const int mnDocumentId;
-explicit LibLODocument_Impl(const css::uno::Reference
, int nDocumentId = -1);
+explicit LibLODocument_Impl(const
css::uno::Reference& xComponent,
+int nDocumentId);
~LibLODocument_Impl();
};
diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index a02347450a38..0a19d5582e80 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -195,6 +195,7 @@ public:
void testCalcSaveAs();
void testControlState();
void testMetricField();
+void testMultiDocuments();
void testABI();
CPPUNIT_TEST_SUITE(DesktopLOKTest);
@@ -257,6 +258,7 @@ public:
CPPUNIT_TEST(testCalcSaveAs);
CPPUNIT_TEST(testControlState);
CPPUNIT_TEST(testMetricField);
+CPPUNIT_TEST(testMultiDocuments);
CPPUNIT_TEST(testABI);
CPPUNIT_TEST_SUITE_END();
@@ -322,10 +324,13 @@ DesktopLOKTest::loadDocUrlImpl(const OUString& rFileURL,
LibreOfficeKitDocumentT
break;
}
+static int nDocumentIdCounter = 0;
+SfxViewShell::SetCurrentDocId(ViewShellDocId(nDocumentIdCounter));
uno::Reference xComponent = loadFromDesktop(rFileURL,
aService);
CPPUNIT_ASSERT(xComponent.is());
-std::unique_ptr pDocument(new
LibLODocument_Impl(xComponent));
+std::unique_ptr pDocument(new
LibLODocument_Impl(xComponent, nDocumentIdCounter));
+++nDocumentIdCounter;
return std::make_pair(std::move(pDocument), xComponent);
}
@@ -2933,6 +2938,99 @@ void DesktopLOKTest::testSpellcheckerMultiView()
CPPUNIT_ASSERT_EQUAL(1,
pDocument->m_pDocumentClass->getViewsCount(pDocument));
}
+void DesktopLOKTest::testMultiDocuments()
+{
+// Load a document.
+uno::Reference xComponent1;
+std::unique_ptr document1;
+std::tie(document1, xComponent1) = loadDocImpl("blank_text.odt");
+LibLODocument_Impl* pDocument1 = document1.get();
+CPPUNIT_ASSERT_EQUAL(1,
pDocument1->m_pDocumentClass->getViewsCount(pDocument1));
+const int nDocId1 = pDocument1->mnDocumentId;
+
+const int nDoc1View0 = pDocument1->m_pDocumentClass->getView(pDocument1);
+CPPUNIT_ASSERT_EQUAL(nDocId1,
SfxLokHelper::getDocumentIdOfView(nDoc1View0));
+const int nDoc1View1 =
pDocument1->m_pDocumentClass->createView(pDocument1);
+
[Libreoffice-bugs] [Bug 138398] MAILMERGE: nothing append when sending emails (no problem with printing)
https://bugs.documentfoundation.org/show_bug.cgi?id=138398 Thierry Munoz changed: What|Removed |Added CC||thierry.mu...@free.fr --- Comment #1 from Thierry Munoz --- Created attachment 167459 --> https://bugs.documentfoundation.org/attachment.cgi?id=167459=edit The box hanging -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: desktop/qa
desktop/qa/desktop_lib/test_desktop_lib.cxx | 117 +---
1 file changed, 91 insertions(+), 26 deletions(-)
New commits:
commit 23951bdc3836b252aab0e7628d8839e89b5a9f6d
Author: Ashod Nakashian
AuthorDate: Sun Aug 2 12:41:19 2020 -0400
Commit: Tor Lillqvist
CommitDate: Sat Nov 21 22:25:05 2020 +0100
DesktopLOKTest: cleanup
Refactor the handling of document loading
and unloading and cleanup to allow more flexibility
when loading multiple documents and for manual
destruction.
Also, correctly set the document type when loading,
which was defaulted to TEXT even when loading
spreadsheet and presentation documents.
Minor misc cleanup such as dangling semicolons and
unregistering the callback twice.
Change-Id: Ia244aafd526d60f73c46e99fb8c7e63f63b0a8f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99974
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Ashod Nakashian
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106225
Tested-by: Tor Lillqvist
Reviewed-by: Tor Lillqvist
diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index 74d9bcede0cf..a02347450a38 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -55,9 +55,34 @@
#include
#include
+#include
+
using namespace com::sun::star;
using namespace desktop;
+static LibreOfficeKitDocumentType getDocumentTypeFromName(const char* pName)
+{
+CPPUNIT_ASSERT_MESSAGE("Document name must be valid.", pName != nullptr);
+
+const std::string name(pName);
+CPPUNIT_ASSERT_MESSAGE("Document name must include extension.",
name.size() > 4);
+
+const auto it = name.rfind('.');
+if (it != std::string::npos)
+{
+const std::string ext = name.substr(it);
+
+if (ext == ".ods")
+return LOK_DOCTYPE_SPREADSHEET;
+
+if (ext == ".odp")
+return LOK_DOCTYPE_PRESENTATION;
+}
+
+CPPUNIT_ASSERT_MESSAGE("Document name must include extension.", it !=
std::string::npos);
+return LOK_DOCTYPE_TEXT;
+}
+
class DesktopLOKTest : public UnoApiTest
{
public:
@@ -78,22 +103,38 @@ public:
UnoApiTest::setUp();
mxDesktop.set(frame::Desktop::create(comphelper::getComponentContext(getMultiServiceFactory(;
SfxApplication::GetOrCreate();
-};
+}
virtual void tearDown() override
{
-if (m_pDocument)
-m_pDocument->pClass->registerCallback(m_pDocument.get(), nullptr,
nullptr);
closeDoc();
UnoApiTest::tearDown();
comphelper::LibreOfficeKit::setActive(false);
-};
+}
+
+std::pair,
uno::Reference>
+loadDocImpl(const char* pName, LibreOfficeKitDocumentType eType);
+
+private:
+std::pair,
uno::Reference>
+loadDocImpl(const char* pName);
+
+public:
+std::pair,
uno::Reference>
+loadDocUrlImpl(const OUString& rFileURL, LibreOfficeKitDocumentType eType);
LibLODocument_Impl* loadDocUrl(const OUString& rFileURL,
LibreOfficeKitDocumentType eType);
-LibLODocument_Impl* loadDoc(const char* pName, LibreOfficeKitDocumentType
eType = LOK_DOCTYPE_TEXT);
-void closeDoc();
+LibLODocument_Impl* loadDoc(const char* pName, LibreOfficeKitDocumentType
eType);
+LibLODocument_Impl* loadDoc(const char* pName)
+{
+return loadDoc(pName, getDocumentTypeFromName(pName));
+}
+
+void closeDoc(std::unique_ptr& loDocument,
+ uno::Reference& xComponent);
+void closeDoc() { closeDoc(m_pDocument, mxComponent); }
static void callback(int nType, const char* pPayload, void* pData);
void callbackImpl(int nType, const char* pPayload);
@@ -261,7 +302,8 @@ static Control* GetFocusControl(vcl::Window const * pParent)
return nullptr;
}
-LibLODocument_Impl* DesktopLOKTest::loadDocUrl(const OUString& rFileURL,
LibreOfficeKitDocumentType eType)
+std::pair,
uno::Reference>
+DesktopLOKTest::loadDocUrlImpl(const OUString& rFileURL,
LibreOfficeKitDocumentType eType)
{
OUString aService;
switch (eType)
@@ -279,28 +321,54 @@ LibLODocument_Impl* DesktopLOKTest::loadDocUrl(const
OUString& rFileURL, LibreOf
CPPUNIT_ASSERT(false);
break;
}
-mxComponent = loadFromDesktop(rFileURL, aService);
-if (!mxComponent.is())
-{
-CPPUNIT_ASSERT(false);
-}
-m_pDocument.reset(new LibLODocument_Impl(mxComponent));
-return m_pDocument.get();
+
+uno::Reference xComponent = loadFromDesktop(rFileURL,
aService);
+CPPUNIT_ASSERT(xComponent.is());
+
+std::unique_ptr pDocument(new
LibLODocument_Impl(xComponent));
+
+return std::make_pair(std::move(pDocument), xComponent);
}
-LibLODocument_Impl* DesktopLOKTest::loadDoc(const char* pName,
LibreOfficeKitDocumentType eType)
+std::pair,
uno::Reference>
+DesktopLOKTest::loadDocImpl(const char* pName,
[Libreoffice-bugs] [Bug 138398] New: MAILMERGE: nothing append when sending emails (no problem with printing)
https://bugs.documentfoundation.org/show_bug.cgi?id=138398 Bug ID: 138398 Summary: MAILMERGE: nothing append when sending emails (no problem with printing) Product: LibreOffice Version: 6.4.6.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: thierry.mu...@free.fr Description: I use an odt file and a database based on calc for mailing on Ubuntu 18.04. No problem for printing the results but when I want send the emails nothing append. The sending hangs. I've verified the Internet Options and all seems good. I can send the .odt by email so this configuration is OK. Same problem under 6.4.2 rc2, 6.4.7 and 7.0.3.1. Steps to Reproduce: 1. Prepare an .odt document with fields coming from a calc file. I use conditionnal fields. 2. Clic on the icon for mailmerge 3. I select one recording in order to test. 4. Writer generates all the records but it's not necessary. 5. An info box appears to show the evolution of the sending but nothing append, no details, the bar progress stays at the beginning. Actual Results: Nothing appends. No sending with the info box always displayed and doesn't changing, it's hanging. Expected Results: The emails should be sent. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Version: 7.0.3.1 Build ID: 00(Build:1) CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR Ubuntu package version: 1:7.0.3-0ubuntu0.18.04.1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/frmfmt.hxx|2 +
sw/source/core/layout/atrfrm.cxx | 13 +++
sw/source/core/undo/untbl.cxx| 71 ++-
3 files changed, 48 insertions(+), 38 deletions(-)
New commits:
commit cfc04e5fc3ab6c5ee98af04805f3840ba3f3fa67
Author: Bjoern Michaelsen
AuthorDate: Sat Nov 21 15:48:41 2020 +0100
Commit: Bjoern Michaelsen
CommitDate: Sat Nov 21 21:50:01 2020 +0100
SaveTable: Replace SwClientNotifyCall
Change-Id: I0e961844836d60e96bcda178612fc0372a55cef1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106319
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen
diff --git a/sw/inc/frmfmt.hxx b/sw/inc/frmfmt.hxx
index d739925f81f4..0fb32c34d190 100644
--- a/sw/inc/frmfmt.hxx
+++ b/sw/inc/frmfmt.hxx
@@ -37,6 +37,7 @@ class IMapObject;
class SwRect;
class SdrObject;
class SwRootFrame;
+class SwTableBox;
namespace sw
{
@@ -178,6 +179,7 @@ public:
void dumpAsXml(xmlTextWriterPtr pWriter) const;
virtual void SetName( const OUString& rNewName, bool bBroadcast=false )
override;
+void MoveTableBox(SwTableBox& rTableBox, const SwFrameFormat* pOldFormat);
};
// The FlyFrame-Format
diff --git a/sw/source/core/layout/atrfrm.cxx b/sw/source/core/layout/atrfrm.cxx
index e3ee7fa334b8..84076a24ced6 100644
--- a/sw/source/core/layout/atrfrm.cxx
+++ b/sw/source/core/layout/atrfrm.cxx
@@ -92,6 +92,7 @@
#include
#include
#include
+#include
using namespace ::com::sun::star;
@@ -3560,6 +3561,18 @@ drawinglayer::attribute::SdrAllFillAttributesHelperPtr
SwFrameFormat::getSdrAllF
return maFillAttributes;
}
+void SwFrameFormat::MoveTableBox(SwTableBox& rTableBox, const SwFrameFormat*
pOldFormat)
+{
+Add();
+if(!pOldFormat)
+return;
+const auto& rOld = pOldFormat->GetFormatAttr(RES_BOXATR_FORMAT);
+const auto& rNew = GetFormatAttr(RES_BOXATR_FORMAT);
+if(rOld != rNew)
+SwClientNotify(*this, sw::LegacyModifyHint(, ));
+}
+
+
namespace sw {
bool IsFlyFrameFormatInHeader(const SwFrameFormat& rFormat)
diff --git a/sw/source/core/undo/untbl.cxx b/sw/source/core/undo/untbl.cxx
index f46961cfedca..a07d8cb7df69 100644
--- a/sw/source/core/undo/untbl.cxx
+++ b/sw/source/core/undo/untbl.cxx
@@ -95,6 +95,12 @@ namespace {
class SaveBox;
class SaveLine;
+void KillEmptyFrameFormat(SwFrameFormat& rFormat)
+{
+if(!rFormat.HasWriterListeners())
+delete
+};
+
}
class SaveTable
@@ -113,14 +119,15 @@ class SaveTable
SaveTable(const SaveTable&) = delete;
SaveTable& operator=(const SaveTable&) = delete;
+SwFrameFormat& CreateNewFormat(SwFrameFormat& rFormat, sal_uInt16
nFormatPos);
public:
SaveTable( const SwTable& rTable, sal_uInt16 nLnCnt = USHRT_MAX,
bool bSaveFormula = true );
sal_uInt16 AddFormat( SwFrameFormat* pFormat, bool bIsLine );
-void NewFrameFormat( const SwTableLine* , const SwTableBox*, sal_uInt16
nFormatPos,
-SwFrameFormat* pOldFormat );
+void NewFrameFormatForLine(const SwTableLine&, sal_uInt16 nFormatPos,
SwFrameFormat* pOldFormat);
+void NewFrameFormatForBox(const SwTableBox&, sal_uInt16 nFormatPos,
SwFrameFormat* pOldFormat);
void RestoreAttr( SwTable& rTable, bool bModifyBox = false );
void SaveContentAttrs( SwDoc* pDoc );
@@ -1072,43 +1079,31 @@ void SaveTable::CreateNew( SwTable& rTable, bool
bCreateFrames,
}
}
-void SaveTable::NewFrameFormat( const SwTableLine* pTableLn, const SwTableBox*
pTableBx,
-sal_uInt16 nFormatPos, SwFrameFormat* pOldFormat )
+SwFrameFormat& SaveTable::CreateNewFormat(SwFrameFormat& rFormat, sal_uInt16
nFormatPos)
{
-SwDoc* pDoc = pOldFormat->GetDoc();
-
-SwFrameFormat* pFormat = m_aFrameFormats[ nFormatPos ];
-if( !pFormat )
-{
-if( pTableLn )
-pFormat = pDoc->MakeTableLineFormat();
-else
-pFormat = pDoc->MakeTableBoxFormat();
-pFormat->SetFormatAttr(*m_aSets[nFormatPos]);
-m_aFrameFormats[nFormatPos] = pFormat;
-}
-
-// first re-assign Frames
-if(pTableLn)
-pOldFormat->CallSwClientNotify(sw::MoveTableLineHint(*pFormat,
*pTableLn));
-else
-pOldFormat->CallSwClientNotify(sw::MoveTableBoxHint(*pFormat,
*pTableBx));
-// than re-assign myself
-if ( pTableLn )
-const_cast(pTableLn)->RegisterToFormat( *pFormat );
-else if ( pTableBx )
-const_cast(pTableBx)->RegisterToFormat( *pFormat );
+rFormat.SetFormatAttr(*m_aSets[nFormatPos]);
+m_aFrameFormats[nFormatPos] =
+return rFormat;
+}
-if (m_bModifyBox && !pTableLn)
-{
-const SfxPoolItem& rOld = pOldFormat->GetFormatAttr( RES_BOXATR_FORMAT
),
- & rNew = pFormat->GetFormatAttr( RES_BOXATR_FORMAT );
-if( rOld != rNew )
-pFormat->SwClientNotifyCall(*pFormat, sw::LegacyModifyHint(,
));
-}
+void
[Libreoffice-commits] core.git: Branch 'feature/cib_contract891' - l10ntools/source sal/osl shell/source
l10ntools/source/uimerge.cxx |7 +++
sal/osl/w32/process.cxx |4 +++-
shell/source/win32/SysShExec.cxx | 23 +--
3 files changed, 23 insertions(+), 11 deletions(-)
New commits:
commit 6a25955d5d4b963463e10485e039fb4d466da12b
Author: Thorsten Behrens
AuthorDate: Sat Nov 21 21:04:41 2020 +0100
Commit: Thorsten Behrens
CommitDate: Sat Nov 21 21:43:21 2020 +0100
Fix Windows build
Change-Id: Iddc6a40743fde3142c121b2b2dfafb3f12753977
diff --git a/l10ntools/source/uimerge.cxx b/l10ntools/source/uimerge.cxx
index 91a0283f0b4e..3e93a8ca32ae 100644
--- a/l10ntools/source/uimerge.cxx
+++ b/l10ntools/source/uimerge.cxx
@@ -7,6 +7,13 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
+#ifdef _WIN32
+#if !defined WIN32_LEAN_AND_MEAN
+# define WIN32_LEAN_AND_MEAN
+#endif
+#include
+#endif
+
#include
#include
diff --git a/sal/osl/w32/process.cxx b/sal/osl/w32/process.cxx
index 44b66a89b846..5f053ec5d319 100644
--- a/sal/osl/w32/process.cxx
+++ b/sal/osl/w32/process.cxx
@@ -283,7 +283,9 @@ static rtl_uString ** osl_createCommandArgs_Impl (int &
argc, char **)
/* Ensure absolute path */
::osl::LongPathBuffer< sal_Unicode > aBuffer( MAX_LONG_PATH );
DWORD dwResult
-= GetModuleFileNameW(nullptr, o3tl::toW(aBuffer),
aBuffer.getBufSizeInSymbols());
+= GetModuleFileNameW(nullptr,
+ reinterpret_cast(static_cast(aBuffer)),
+ aBuffer.getBufSizeInSymbols());
if ((0 < dwResult) && (dwResult < aBuffer.getBufSizeInSymbols()))
{
/* Replace argv[0] with it's absolute path */
diff --git a/shell/source/win32/SysShExec.cxx b/shell/source/win32/SysShExec.cxx
index 6f3b0d578323..e265788d0d52 100644
--- a/shell/source/win32/SysShExec.cxx
+++ b/shell/source/win32/SysShExec.cxx
@@ -321,7 +321,7 @@ void SAL_CALL CSysShExec::execute( const OUString&
aCommand, const OUString& aPa
throw css::lang::IllegalArgumentException(
("XSystemShellExecute.execute, getSystemPathFromFileURL <"
+ aCommand
+ "> failed with " + OUString::number(e1)),
-{}, 0);
+static_cast< XSystemShellExecute* >( this ), 0);
}
for (int i = 0;; ++i) {
SHFILEINFOW info;
@@ -330,14 +330,16 @@ void SAL_CALL CSysShExec::execute( const OUString&
aCommand, const OUString& aPa
!= 0)
{
throw css::lang::IllegalArgumentException(
-"XSystemShellExecute.execute, cannot process <" +
aCommand + ">", {}, 0);
+"XSystemShellExecute.execute, cannot process <" +
aCommand + ">",
+static_cast< XSystemShellExecute* >( this ), 0);
}
if (SHGetFileInfoW(
pathname.getStr(), 0, , sizeof info,
SHGFI_ATTRIBUTES)
== 0)
{
throw css::lang::IllegalArgumentException(
-"XSystemShellExecute.execute, SHGetFileInfoW(" +
pathname + ") failed", {},
+"XSystemShellExecute.execute, SHGetFileInfoW(" +
pathname + ") failed",
+static_cast< XSystemShellExecute* >( this ),
0);
}
if ((info.dwAttributes & SFGAO_LINK) == 0) {
@@ -351,7 +353,7 @@ void SAL_CALL CSysShExec::execute( const OUString&
aCommand, const OUString& aPa
throw css::lang::IllegalArgumentException(
("XSystemShellExecute.execute, CoCreateInstance failed
with "
+ OUString::number(e2)),
-{}, 0);
+static_cast< XSystemShellExecute* >( this ), 0);
}
sal::systools::COMReference file;
try {
@@ -360,21 +362,21 @@ void SAL_CALL CSysShExec::execute( const OUString&
aCommand, const OUString& aPa
throw css::lang::IllegalArgumentException(
("XSystemShellExecute.execute, QueryInterface failed
with: "
+ o3tl::runtimeToOUString(e3.what())),
-{}, 0);
+static_cast< XSystemShellExecute* >( this ), 0);
}
e2 = file->Load(pathname.getStr(), STGM_READ);
if (FAILED(e2)) {
throw css::lang::IllegalArgumentException(
("XSystemShellExecute.execute, IPersistFile.Load
failed with "
+ OUString::number(e2)),
-{}, 0);
+static_cast< XSystemShellExecute* >( this ), 0);
}
e2 = link->Resolve(nullptr,
[Libreoffice-bugs] [Bug 117212] MAILMERGE: Save/Print Merged Documents command processes every record even when it is unnecessary
https://bugs.documentfoundation.org/show_bug.cgi?id=117212 Thierry Munoz changed: What|Removed |Added CC||thierry.mu...@free.fr --- Comment #5 from Thierry Munoz --- I confirm this behavior on my system : Version: 7.0.3.1 Build ID: 00(Build:1) CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR Ubuntu package version: 1:7.0.3-0ubuntu0.18.04.1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138395] Separator/Divider lines in menus should have an optional text label (see included mockup image)
https://bugs.documentfoundation.org/show_bug.cgi?id=138395 Mike Kaganski changed: What|Removed |Added Keywords||needsUXEval --- Comment #2 from Mike Kaganski --- I really doubt that we can do that in a uniform manner across all platforms, with all their widget specifics and HIGs... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138382] with gtk3 table design window sometimes ignores some accelerator keys
https://bugs.documentfoundation.org/show_bug.cgi?id=138382 --- Comment #2 from Terrence Enger --- (In reply to Caolán McNamara from comment #1) > This is set as blocking GTK3 but comment #1 mentions SAL_USE_VCLPLUGIN=gen, > should comment #1 actually be SAL_USE_VCLPLUGIN=gtk3 ? Yes, I meant gtk3. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138396] Overlapping conditional formats offered by option but not implemented
https://bugs.documentfoundation.org/show_bug.cgi?id=138396 --- Comment #2 from Jim Avera --- Hrm... actually, if you answer "Yes" to the question "Do you want to edit the existing conditional format?" then you can not edit the existing format; it appears to be asking for a new format. So it looks like the question is asking the opposite of what it means -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138397] New: FILEOPEN VIEWING can't open file saved in outline view
https://bugs.documentfoundation.org/show_bug.cgi?id=138397 Bug ID: 138397 Summary: FILEOPEN VIEWING can't open file saved in outline view Product: LibreOffice Online Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: matthiasstec...@gmx.de Created attachment 167458 --> https://bugs.documentfoundation.org/attachment.cgi?id=167458=edit Screenshots An ODP created by the LO Impress program saved in outline view can't be opened in LOOL. You just see the UI, but not the presentation. As LOOL is not capable of display the outline view, you don't see anything and can't escape from it except you open the ODP with the program and save it in the normal view. Steps to reproduce: 1. Create an ODP presentation with LO Impress 2. Change into the outline view 3. Do some changes so you can save in that view 4. View this file via LOOL Correct me if this bug should rather be filed to https://github.com/CollaboraOnline/online Attachments: 1. saved document in LO Impress 2. opend document in LOOL Versions: LO Impress: Version: 7.0.3.1 Build ID: 00(Build:1) CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3 Locale: de-DE (de_DE.UTF-8); UI: en-US Debian package version: 1:7.0.3-4 Calc: threaded LOOL: Collabora Online Development Edition LOOLWSD: 6.4.1 (git hash: 81f1aab) provided by 210df5d9 LOKit: Collabora Office 6.4-14 (git hash: 0165bd4) used via Nextcloud App Collabora Online (richdocuments) version 3.7.9 on Debian GNU/Linux bullseye/sid -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/doc/objserv.cxx |1 - sfx2/source/sidebar/FocusManager.cxx |2 -- sfx2/source/view/viewfrm.cxx |1 - 3 files changed, 4 deletions(-) New commits: commit 3828a5b35f9ac4006461fa46cbe30e4dde01d01f Author: Caolán McNamara AuthorDate: Fri Nov 20 16:48:05 2020 + Commit: Caolán McNamara CommitDate: Sat Nov 21 21:20:52 2020 +0100 these don't need to include vcl/button.hxx anymore Change-Id: I6af85519b1fd55c1b4192cbdc9661b053b302f51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106287 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/sfx2/source/doc/objserv.cxx b/sfx2/source/doc/objserv.cxx index 3930e451c916..5a4354b92717 100644 --- a/sfx2/source/doc/objserv.cxx +++ b/sfx2/source/doc/objserv.cxx @@ -58,7 +58,6 @@ #include #include #include -#include #include #include #include diff --git a/sfx2/source/sidebar/FocusManager.cxx b/sfx2/source/sidebar/FocusManager.cxx index 484aeef503cc..967256a46875 100644 --- a/sfx2/source/sidebar/FocusManager.cxx +++ b/sfx2/source/sidebar/FocusManager.cxx @@ -22,9 +22,7 @@ #include #include #include -#include #include -#include #include #include diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx index d525fa400859..46a7c4d9dc42 100644 --- a/sfx2/source/view/viewfrm.cxx +++ b/sfx2/source/view/viewfrm.cxx @@ -36,7 +36,6 @@ #include #include #include -#include #include #include #include ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: basctl/source
basctl/source/basicide/bastypes.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 78091a860ade61addab12ae5e541fa01707bfb59
Author: Caolán McNamara
AuthorDate: Fri Nov 20 14:39:29 2020 +
Commit: Caolán McNamara
CommitDate: Sat Nov 21 21:20:32 2020 +0100
remove non-functional resize grip at right of basic ide tabbar
left behind after
commit 867af25bd8d36c7e5ef6f16c2876ac82e63648cc
Date: Fri Jan 22 12:04:05 2016 +0100
tdf#96683 Move tabs in Basic IDE to an own row
before that it could be used to assign sizes to the tabbar vs
scrollbar when they were on the same line. Now that they are on
different lines it shouldn't be there.
See tdf#87684 for the similar calc case where
Office::Calc::Layout::Other::TabbarInlineWithScrollbar exists to
re-enable this feature for calc.
Change-Id: I6430e13ab79f4c424ae35f7b8e3ad7bd47ec201b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106275
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/basctl/source/basicide/bastypes.cxx
b/basctl/source/basicide/bastypes.cxx
index 5a4012b6cebb..eabb6ea12f69 100644
--- a/basctl/source/basicide/bastypes.cxx
+++ b/basctl/source/basicide/bastypes.cxx
@@ -422,7 +422,7 @@ void DockingWindow::DockThis ()
}
TabBar::TabBar( vcl::Window* pParent ) :
-::TabBar( pParent, WinBits( WB_3DLOOK | WB_SCROLL | WB_BORDER |
WB_SIZEABLE | WB_DRAG ) )
+::TabBar( pParent, WinBits( WB_3DLOOK | WB_SCROLL | WB_BORDER | WB_DRAG ) )
{
EnableEditMode();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 138396] Overlapping conditional formats offered by option but not implemented
https://bugs.documentfoundation.org/show_bug.cgi?id=138396 --- Comment #1 from Jim Avera --- Created attachment 167457 --> https://bugs.documentfoundation.org/attachment.cgi?id=167457=edit test.ods (see steps to reproduce) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138382] with gtk3 table design window sometimes ignores some accelerator keys
https://bugs.documentfoundation.org/show_bug.cgi?id=138382 --- Comment #1 from Caolán McNamara --- This is set as blocking GTK3 but comment #1 mentions SAL_USE_VCLPLUGIN=gen, should comment #1 actually be SAL_USE_VCLPLUGIN=gtk3 ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138396] New: Overlapping conditional formats offered by option but not implemented
https://bugs.documentfoundation.org/show_bug.cgi?id=138396 Bug ID: 138396 Summary: Overlapping conditional formats offered by option but not implemented Product: LibreOffice Version: 7.1.0.0.alpha1+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jim.av...@gmail.com Description: In Calc, if you try to apply a Conditional Format to a cell which is alredy covered by an existing Conditional Format, a dialog pops up telling you that you can either edit the existing cond. format or create an overlapping one, and then asks "Do you want to edit the existing conditional format?" with No and Yes buttons. However clicking "No" (implying that the user want to create an overlapping condition) just exits without allowing a new conditional format to be created. If the intent is to not allow overlapping conditional formats, then the dialog should be changed to say that (currently it says you have a choice). If overlapping conditions *are* supposed to be allowed, then if the user clicks the button corresponding to that choice (i.e. "No" to "Do you want to edit..."), then a conditional-format-creation dialog should appear. Steps to Reproduce: 1. Loat attached "test.ods" spreadsheet 2. On sheet "Sheet2", select cell B1, then do Format->Conditional->Condition (dialog appears asking "Do you want to edit the existing cond. format?") 3. Click No Actual Results: The dialog closes and nothing else happens. Expected Results: Expected that a new overlapping conditional format could be created, as implied by the question in the dialog box Reproducible: Always User Profile Reset: No Additional Info: . -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138395] Separator/Divider lines in menus should have an optional text label (see included mockup image)
https://bugs.documentfoundation.org/show_bug.cgi?id=138395 --- Comment #1 from Riban --- Created attachment 167456 --> https://bugs.documentfoundation.org/attachment.cgi?id=167456=edit Separator labels -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138395] Separator/Divider lines in menus should have an optional text label (see included mockup image)
https://bugs.documentfoundation.org/show_bug.cgi?id=138395 Riban changed: What|Removed |Added Summary|Separator/Divider lines |Separator/Divider lines in |should have an optional |menus should have an |text label (see included|optional text label (see |mockup image) |included mockup image) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138395] Separator/Divider lines should have an optional text label (see included mockup image)
https://bugs.documentfoundation.org/show_bug.cgi?id=138395 Riban changed: What|Removed |Added Summary|Separator/Divider lines |Separator/Divider lines |should have an optional |should have an optional |text header (see included |text label (see included |mockup image) |mockup image) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards
https://bugs.documentfoundation.org/show_bug.cgi?id=124176 --- Comment #150 from Commit Notification --- Umut Emre Bayramoglu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bac71fd104a19e481ed688fba0b0f427e855ce91 tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/docvw/SidebarScrollBar.hxx |5 + 1 file changed, 1 insertion(+), 4 deletions(-) New commits: commit bac71fd104a19e481ed688fba0b0f427e855ce91 Author: Umut Emre Bayramoglu AuthorDate: Sat Nov 21 15:43:02 2020 + Commit: Julien Nabet CommitDate: Sat Nov 21 21:03:22 2020 +0100 tdf#124176: Use pragma once instead of include guards Change-Id: I5f4f6ccdc8ce2ccfeb5046b7d477c29849696e39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106320 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/sw/source/uibase/docvw/SidebarScrollBar.hxx b/sw/source/uibase/docvw/SidebarScrollBar.hxx index 8a2834cdb797..8d7ddd6c8486 100644 --- a/sw/source/uibase/docvw/SidebarScrollBar.hxx +++ b/sw/source/uibase/docvw/SidebarScrollBar.hxx @@ -7,8 +7,7 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -#ifndef INCLUDED_SW_SOURCE_UIBASE_DOCVW_SIDEBARSCROLLBAR_HXX -#define INCLUDED_SW_SOURCE_UIBASE_DOCVW_SIDEBARSCROLLBAR_HXX +#pragma once #include @@ -38,6 +37,4 @@ public: }; } -#endif - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 138386] LO Writer does not display .emf files properly
https://bugs.documentfoundation.org/show_bug.cgi?id=138386 --- Comment #7 from Ming Hua --- Created attachment 167455 --> https://bugs.documentfoundation.org/attachment.cgi?id=167455=edit Screenshot with 7.0.2 on Windows 10 First sample file looks different but still less than ideal for me with 7.0.2 on Windows 10. Screenshot attached. Not sure if this counts as reproduced or not... Version: 7.0.2.2 (x64) Build ID: 8349ace3c3162073abd90d81fd06dcfb6b36b994 CPU threads: 2; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: zh-CN (zh_CN); 界面: zh-CN Calc: threaded When opened with 7.1.0 alpha1+ there are other problems. Will investigate further. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138395] New: Separator/Divider lines should have an optional text header (see included mockup image)
https://bugs.documentfoundation.org/show_bug.cgi?id=138395 Bug ID: 138395 Summary: Separator/Divider lines should have an optional text header (see included mockup image) Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ri...@gmx.net Description: LibreOffice menus (as well as other parts of the interface) are highly customizable. They can be customized to include as many or as few items as the user wishes. Separators help to structure customized menus, but they are just lines. It would be great if those separator lines could be customized to have a text heading/header. Screenshot with mockup: https://imgur.com/a/jsuyq9K In the attached screenshot in the upper part of the menu I have made a up a mockup scenario for illustration purposes; the lower part shows the current situation. I think custom naming of separators would help a lot in making the menu more structured. Steps to Reproduce: see description Actual Results: see description Expected Results: see description Reproducible: Always User Profile Reset: No Additional Info: see description -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103859 Ming Hua changed: What|Removed |Added Depends on||138386 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=138386 [Bug 138386] LO Writer does not display .emf files properly -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138386] LO Writer does not display .emf files properly
https://bugs.documentfoundation.org/show_bug.cgi?id=138386 Ming Hua changed: What|Removed |Added CC||ming.v@qq.com Blocks||103859 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103859 [Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: icon-themes/colibre_svg
icon-themes/colibre_svg/cmd/lc_alignbottom.svg |2 icon-themes/colibre_svg/cmd/lc_aligntop.svg |2 icon-themes/colibre_svg/cmd/lc_bulletsandnumberingdialog.svg | 51 ++ icon-themes/colibre_svg/cmd/lc_cone.svg | 26 + icon-themes/colibre_svg/cmd/lc_convertinto3dlathe.svg| 34 ++- icon-themes/colibre_svg/cmd/lc_cube.svg | 42 icon-themes/colibre_svg/cmd/lc_cylinder.svg | 34 ++- icon-themes/colibre_svg/cmd/lc_cyramid.svg | 34 ++- icon-themes/colibre_svg/cmd/lc_halfsphere.svg| 42 icon-themes/colibre_svg/cmd/lc_hfixedline.svg| 12 ++ icon-themes/colibre_svg/cmd/lc_insertneutralparagraph.svg| 40 icon-themes/colibre_svg/cmd/lc_line.svg | 12 ++ icon-themes/colibre_svg/cmd/lc_line_diagonal.svg | 20 icon-themes/colibre_svg/cmd/lc_linearrowcircle.svg | 28 + icon-themes/colibre_svg/cmd/lc_linearrowend.svg | 20 icon-themes/colibre_svg/cmd/lc_linearrows.svg| 28 + icon-themes/colibre_svg/cmd/lc_linearrowsquare.svg | 28 + icon-themes/colibre_svg/cmd/lc_linearrowstart.svg| 20 icon-themes/colibre_svg/cmd/lc_linecirclearrow.svg | 28 + icon-themes/colibre_svg/cmd/lc_lineendstyle.svg | 52 ++- icon-themes/colibre_svg/cmd/lc_linesquarearrow.svg | 28 + icon-themes/colibre_svg/cmd/lc_measureline.svg | 36 +++ icon-themes/colibre_svg/cmd/lc_outlinecollapse.svg | 35 +++ icon-themes/colibre_svg/cmd/lc_outlinecollapseall.svg| 35 +++ icon-themes/colibre_svg/cmd/lc_outlineexpand.svg | 35 +++ icon-themes/colibre_svg/cmd/lc_outlineexpandall.svg | 35 +++ icon-themes/colibre_svg/cmd/lc_paraspacedecrease.svg |6 - icon-themes/colibre_svg/cmd/lc_paraspaceincrease.svg |4 icon-themes/colibre_svg/cmd/lc_pie.svg | 12 ++ icon-themes/colibre_svg/cmd/lc_pie_unfilled.svg | 20 icon-themes/colibre_svg/cmd/lc_polygon.svg | 12 ++ icon-themes/colibre_svg/cmd/lc_polygon_diagonal.svg | 12 ++ icon-themes/colibre_svg/cmd/lc_polygon_diagonal_unfilled.svg | 20 icon-themes/colibre_svg/cmd/lc_polygon_unfilled.svg | 20 icon-themes/colibre_svg/cmd/lc_rect_rounded_unfilled.svg | 20 icon-themes/colibre_svg/cmd/lc_rect_unfilled.svg |4 icon-themes/colibre_svg/cmd/lc_shell3d.svg | 38 +++- icon-themes/colibre_svg/cmd/lc_spacepara1.svg|4 icon-themes/colibre_svg/cmd/lc_spacepara15.svg |4 icon-themes/colibre_svg/cmd/lc_spacepara2.svg|4 icon-themes/colibre_svg/cmd/lc_square_rounded.svg| 12 ++ icon-themes/colibre_svg/cmd/lc_square_rounded_unfilled.svg |4 icon-themes/colibre_svg/cmd/lc_square_unfilled.svg |4 icon-themes/colibre_svg/cmd/lc_torus.svg | 31 ++ icon-themes/colibre_svg/cmd/lc_vfixedline.svg| 12 ++ 45 files changed, 948 insertions(+), 54 deletions(-) New commits: commit e449edb409e47390fef78bdf9fc23156da737dcc Author: andreas kainz AuthorDate: Sat Nov 21 08:36:52 2020 +0100 Commit: Andreas Kainz CommitDate: Sat Nov 21 20:37:58 2020 +0100 Colibre icon theme css support Change-Id: I03f38ea988993c077d02a09c9b7f78024542e87e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106299 Tested-by: Jenkins Reviewed-by: Andreas Kainz diff --git a/icon-themes/colibre_svg/cmd/lc_alignbottom.svg b/icon-themes/colibre_svg/cmd/lc_alignbottom.svg index 78445751c375..ce1cacf0a870 100644 --- a/icon-themes/colibre_svg/cmd/lc_alignbottom.svg +++ b/icon-themes/colibre_svg/cmd/lc_alignbottom.svg @@ -9,7 +9,7 @@ /> http://www.w3.org/2000/svg;> \ No newline at end of file + +http://www.w3.org/2000/svg;> + + + + + + + diff --git a/icon-themes/colibre_svg/cmd/lc_cone.svg b/icon-themes/colibre_svg/cmd/lc_cone.svg index 27fb9a2cfb64..baee4ca4c6d9 100644 --- a/icon-themes/colibre_svg/cmd/lc_cone.svg +++ b/icon-themes/colibre_svg/cmd/lc_cone.svg @@ -1 +1,25 @@ -http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file + +http://www.w3.org/2000/svg;> + + + + + + + diff --git a/icon-themes/colibre_svg/cmd/lc_convertinto3dlathe.svg b/icon-themes/colibre_svg/cmd/lc_convertinto3dlathe.svg index 608f6f656f26..b90e47a93e89 100644 --- a/icon-themes/colibre_svg/cmd/lc_convertinto3dlathe.svg +++ b/icon-themes/colibre_svg/cmd/lc_convertinto3dlathe.svg @@ -1 +1,33 @@ -http://www.w3.org/2000/svg;
[Libreoffice-bugs] [Bug 137662] When combo box (and List box) from Base is located in a data sheet, it ha to be clicked twice in order to be able to enter text
https://bugs.documentfoundation.org/show_bug.cgi?id=137662 Julien Nabet changed: What|Removed |Added CC||caol...@redhat.com, ||serval2...@yahoo.fr --- Comment #4 from Julien Nabet --- (In reply to Robert Großkopf from comment #1) > Could confirm the buggy behavior, also for VCL: kf5 on OpenSUSE 15.1 64bit > rpm Linux. Works in LO 6.4.6.2, fails in LO 7.0.2.2, so a regression > > Note: You can't get out of the listbox or combobox by tabulator if you > activated it by mouse, if you are using VCL: gtk3 inside a tablecontrol with > LO 7.0.2.2 Another bug? On pc Debian x86-64 with master sources updated today + gtk3, after having select listbox with mouse, I can use tabulator to go to the next field. If I click on the arrow, I must first type Escape key to show only the selected entry. However, I can select a value in listbox manually once in it with a tabulator, I would have expected top/bottom arrows to select an entry of the listbox. Also I noticed that, only after having expanded a listbox, this log appears each time I use tabulator: ** (soffice:908352): WARNING **: 20:12:49.048: Focused object has invalid index in parent BTW, no better with gen rendering except that top/bottom arrows in list box just move the cursor at previous/next row, so again impossible to select another entry of the listbox without mouse (or missed it). Caolán: not specific gtk3, but thought you might be interested in this one since it may be related to vcl/welding process? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
