[Libreoffice-commits] core.git: xmloff/source
xmloff/source/text/XMLIndexTOCStylesContext.cxx | 23 ---
xmloff/source/text/XMLIndexTOCStylesContext.hxx |7 +++
2 files changed, 11 insertions(+), 19 deletions(-)
New commits:
commit dba2a0435fb8aa1c5a312261fc10959e824230c6
Author: Noel Grandin
AuthorDate: Tue Nov 24 20:27:03 2020 +0200
Commit: Noel Grandin
CommitDate: Wed Nov 25 08:56:57 2020 +0100
fastparser in XMLIndexTOCStylesContext
Change-Id: I59f6a044da134fe1ce6ffe415df518dce9272b53
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106549
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/xmloff/source/text/XMLIndexTOCStylesContext.cxx
b/xmloff/source/text/XMLIndexTOCStylesContext.cxx
index 36621df0770e..d761027b57af 100644
--- a/xmloff/source/text/XMLIndexTOCStylesContext.cxx
+++ b/xmloff/source/text/XMLIndexTOCStylesContext.cxx
@@ -106,27 +106,20 @@ void XMLIndexTOCStylesContext::endFastElement(sal_Int32 )
xIndexReplace->replaceByIndex(nOutlineLevel, Any(aStyleNamesSequence));
}
-SvXMLImportContextRef XMLIndexTOCStylesContext::CreateChildContext(
-sal_uInt16 p_nPrefix,
-const OUString& rLocalName,
-const Reference & xAttrList )
+css::uno::Reference< css::xml::sax::XFastContextHandler >
XMLIndexTOCStylesContext::createFastChildContext(
+sal_Int32 nElement,
+const css::uno::Reference< css::xml::sax::XFastAttributeList >& xAttrList )
{
// check for index-source-style
-if ( (XML_NAMESPACE_TEXT == p_nPrefix) &&
- IsXMLToken( rLocalName, XML_INDEX_SOURCE_STYLE ) )
+if ( nElement == XML_ELEMENT(TEXT, XML_INDEX_SOURCE_STYLE) )
{
// find text:style-name attribute and record in aStyleNames
-sal_Int16 nCount = xAttrList->getLength();
-for(sal_Int16 nAttr = 0; nAttr < nCount; nAttr++)
+for( auto& aIter : sax_fastparser::castToFastAttributeList(xAttrList) )
{
-OUString sLocalName;
-sal_uInt16 nPrefix = GetImport().GetNamespaceMap().
-GetKeyByAttrName( xAttrList->getNameByIndex(nAttr),
- );
-if ( (XML_NAMESPACE_TEXT == nPrefix) &&
- IsXMLToken( sLocalName, XML_STYLE_NAME ) )
+if ( aIter.getToken() == XML_ELEMENT(TEXT, XML_STYLE_NAME) )
{
-aStyleNames.push_back(xAttrList->getValueByIndex(nAttr));
+aStyleNames.push_back(aIter.toString());
+break;
}
}
}
diff --git a/xmloff/source/text/XMLIndexTOCStylesContext.hxx
b/xmloff/source/text/XMLIndexTOCStylesContext.hxx
index 6714c828709c..bf18d7e64d71 100644
--- a/xmloff/source/text/XMLIndexTOCStylesContext.hxx
+++ b/xmloff/source/text/XMLIndexTOCStylesContext.hxx
@@ -65,10 +65,9 @@ protected:
virtual void SAL_CALL endFastElement(sal_Int32 nElement) override;
-virtual SvXMLImportContextRef CreateChildContext(
-sal_uInt16 nPrefix,
-const OUString& rLocalName,
-const css::uno::Reference & xAttrList )
override;
+virtual css::uno::Reference< css::xml::sax::XFastContextHandler > SAL_CALL
createFastChildContext(
+sal_Int32 nElement,
+const css::uno::Reference< css::xml::sax::XFastAttributeList >&
xAttrList ) override;
};
#endif
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 138349] Editing : Issue when replacing an image by another
https://bugs.documentfoundation.org/show_bug.cgi?id=138349 --- Comment #3 from Andrew Watson --- Created attachment 167551 --> https://bugs.documentfoundation.org/attachment.cgi?id=167551=edit Small PNG file which provokes bug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138349] Editing : Issue when replacing an image by another
https://bugs.documentfoundation.org/show_bug.cgi?id=138349 Andrew Watson changed: What|Removed |Added CC||notinterest...@gmx.com --- Comment #2 from Andrew Watson --- Created attachment 167550 --> https://bugs.documentfoundation.org/attachment.cgi?id=167550=edit Small JPG file which provokes bug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: xmloff/source
xmloff/source/text/XMLIndexAlphabeticalSourceContext.cxx |4
xmloff/source/text/XMLIndexAlphabeticalSourceContext.hxx |2
xmloff/source/text/XMLIndexBibliographySourceContext.cxx |4
xmloff/source/text/XMLIndexBibliographySourceContext.hxx |3
xmloff/source/text/XMLIndexBodyContext.cxx |9 -
xmloff/source/text/XMLIndexBodyContext.hxx |5
xmloff/source/text/XMLIndexIllustrationSourceContext.cxx |4
xmloff/source/text/XMLIndexIllustrationSourceContext.hxx |3
xmloff/source/text/XMLIndexObjectSourceContext.cxx |4
xmloff/source/text/XMLIndexObjectSourceContext.hxx |2
xmloff/source/text/XMLIndexSourceBaseContext.cxx |4
xmloff/source/text/XMLIndexSourceBaseContext.hxx |2
xmloff/source/text/XMLIndexTOCContext.cxx| 124 +++
xmloff/source/text/XMLIndexTOCContext.hxx| 12 -
xmloff/source/text/XMLIndexTOCSourceContext.cxx |4
xmloff/source/text/XMLIndexTOCSourceContext.hxx |2
xmloff/source/text/XMLIndexTableSourceContext.cxx|5
xmloff/source/text/XMLIndexTableSourceContext.hxx|3
xmloff/source/text/XMLIndexUserSourceContext.cxx |4
xmloff/source/text/XMLIndexUserSourceContext.hxx |3
20 files changed, 76 insertions(+), 127 deletions(-)
New commits:
commit b563b61af9a8d9917845f52d2058b7d18ec6cdce
Author: Noel Grandin
AuthorDate: Tue Nov 24 20:23:19 2020 +0200
Commit: Noel Grandin
CommitDate: Wed Nov 25 08:42:54 2020 +0100
fastparser in text index
Change-Id: Ia1811b6e913aabcb9f1fb138ab440f5cee8a9d74
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106548
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/xmloff/source/text/XMLIndexAlphabeticalSourceContext.cxx
b/xmloff/source/text/XMLIndexAlphabeticalSourceContext.cxx
index c5ad3ffe1c3a..b6ed744129c8 100644
--- a/xmloff/source/text/XMLIndexAlphabeticalSourceContext.cxx
+++ b/xmloff/source/text/XMLIndexAlphabeticalSourceContext.cxx
@@ -45,10 +45,8 @@ using ::xmloff::token::XML_OUTLINE_LEVEL;
XMLIndexAlphabeticalSourceContext::XMLIndexAlphabeticalSourceContext(
SvXMLImport& rImport,
-sal_uInt16 nPrfx,
-const OUString& rLocalName,
Reference & rPropSet)
-: XMLIndexSourceBaseContext(rImport, nPrfx, rLocalName, rPropSet, false)
+: XMLIndexSourceBaseContext(rImport, rPropSet, false)
, bMainEntryStyleNameOK(false)
, bSeparators(false)
, bCombineEntries(true)
diff --git a/xmloff/source/text/XMLIndexAlphabeticalSourceContext.hxx
b/xmloff/source/text/XMLIndexAlphabeticalSourceContext.hxx
index 8f39f4c7788a..ef4938b5be69 100644
--- a/xmloff/source/text/XMLIndexAlphabeticalSourceContext.hxx
+++ b/xmloff/source/text/XMLIndexAlphabeticalSourceContext.hxx
@@ -56,8 +56,6 @@ public:
XMLIndexAlphabeticalSourceContext(
SvXMLImport& rImport,
-sal_uInt16 nPrfx,
-const OUString& rLocalName,
css::uno::Reference & rPropSet);
virtual ~XMLIndexAlphabeticalSourceContext() override;
diff --git a/xmloff/source/text/XMLIndexBibliographySourceContext.cxx
b/xmloff/source/text/XMLIndexBibliographySourceContext.cxx
index 3b3cab16ded2..6ac60aece7ba 100644
--- a/xmloff/source/text/XMLIndexBibliographySourceContext.cxx
+++ b/xmloff/source/text/XMLIndexBibliographySourceContext.cxx
@@ -37,10 +37,8 @@ using ::com::sun::star::xml::sax::XAttributeList;
XMLIndexBibliographySourceContext::XMLIndexBibliographySourceContext(
SvXMLImport& rImport,
-sal_uInt16 nPrfx,
-const OUString& rLocalName,
Reference & rPropSet) :
-XMLIndexSourceBaseContext(rImport, nPrfx, rLocalName,
+XMLIndexSourceBaseContext(rImport,
rPropSet, false)
{
}
diff --git a/xmloff/source/text/XMLIndexBibliographySourceContext.hxx
b/xmloff/source/text/XMLIndexBibliographySourceContext.hxx
index c6684c24e150..bc02d9568b54 100644
--- a/xmloff/source/text/XMLIndexBibliographySourceContext.hxx
+++ b/xmloff/source/text/XMLIndexBibliographySourceContext.hxx
@@ -38,11 +38,8 @@ class XMLIndexBibliographySourceContext : public
XMLIndexSourceBaseContext
public:
-
XMLIndexBibliographySourceContext(
SvXMLImport& rImport,
-sal_uInt16 nPrfx,
-const OUString& rLocalName,
css::uno::Reference & rPropSet);
virtual ~XMLIndexBibliographySourceContext() override;
diff --git a/xmloff/source/text/XMLIndexBodyContext.cxx
b/xmloff/source/text/XMLIndexBodyContext.cxx
index 25c01a7db135..b83e7fd36531 100644
--- a/xmloff/source/text/XMLIndexBodyContext.cxx
+++ b/xmloff/source/text/XMLIndexBodyContext.cxx
@@ -27,12 +27,9 @@ using ::com::sun::star::uno::Reference;
using ::com::sun::star::xml::sax::XAttributeList;
-XMLIndexBodyContext::XMLIndexBodyContext(
-SvXMLImport& rImport,
-sal_uInt16 nPrfx,
-const OUString& rLocalName ) :
-
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx |2 +-
connectivity/source/drivers/evoab2/NDatabaseMetaData.hxx |6 +-
2 files changed, 6 insertions(+), 2 deletions(-)
New commits:
commit 60d0cf170b637c01f76e354e8bf5a40cade11b69
Author: Stephan Bergmann
AuthorDate: Tue Nov 24 15:34:44 2020 +0100
Commit: Stephan Bergmann
CommitDate: Wed Nov 25 08:19:16 2020 +0100
loplugin:stringviewparam
Change-Id: Ieddc3cc1913e57f51d270cead97b1eadaa81fc6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106507
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx
b/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx
index 97cdd9775c7f..fc6a12a5979b 100644
--- a/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx
+++ b/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx
@@ -169,7 +169,7 @@ namespace connectivity::evoab
return nType == G_TYPE_STRING ? DataType::VARCHAR : DataType::BIT;
}
-guint findEvoabField(const OUString& aColName)
+guint findEvoabField(std::u16string_view aColName)
{
guint nRet = guint(-1);
bool bFound = false;
diff --git a/connectivity/source/drivers/evoab2/NDatabaseMetaData.hxx
b/connectivity/source/drivers/evoab2/NDatabaseMetaData.hxx
index 11270aca5259..cbfed176fabc 100644
--- a/connectivity/source/drivers/evoab2/NDatabaseMetaData.hxx
+++ b/connectivity/source/drivers/evoab2/NDatabaseMetaData.hxx
@@ -20,6 +20,10 @@
#ifndef INCLUDED_CONNECTIVITY_SOURCE_DRIVERS_EVOAB2_NDATABASEMETADATA_HXX
#define INCLUDED_CONNECTIVITY_SOURCE_DRIVERS_EVOAB2_NDATABASEMETADATA_HXX
+#include
+
+#include
+
#include "NConnection.hxx"
#include
#include
@@ -54,7 +58,7 @@ namespace connectivity::evoab
sal_Int32 getFieldType(guint nCol) ;
OUString getFieldTypeName(guint nCol) ;
OUString getFieldName(guint nCol) ;
-guint findEvoabField(const OUString& aColName);
+guint findEvoabField(std::u16string_view aColName);
void free_column_resources();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 138447] A right aligned Text Box in Microsoft Word is shifted to left in Libre Office Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=138447 Timur changed: What|Removed |Added Keywords||filter:docx --- Comment #2 from Timur --- Please search in existing bugs and see if duplicate of Bug 100920. Looks similar enough and if that one is ever fixed, duplicates should be tested. Also, good approach is comparison screenshot with DOCX in MSO and in LO. Once fileopen is hopefully fixed, also of resave and reopen in LO and MSO. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47055] EDITING: Cannot comment on block of text
https://bugs.documentfoundation.org/show_bug.cgi?id=47055 --- Comment #5 from Gregyrd --- Cannot comment on a block of text, Don't know the reason but as I know these pages, I understand through this https://askpetersen.com/ site, Where such text is really matters for those who are leaving comments and this really matters to take these pages. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136801] BASIC: CInt("+2") returns 0
https://bugs.documentfoundation.org/show_bug.cgi?id=136801 --- Comment #5 from Mike Kaganski --- (In reply to An-Kh from comment #4) Hi! FTR: it's https://gerrit.libreoffice.org/c/core/+/106556 Of course, you are welcome to cover IsNumeric here. However, the task is not to apply separate workarounds to each specific higher-level functions one by one. The task is to find the common (set of) lower-level number parsing functions used by those higher-level functions, and implement a common fix on that lower level. Thank you for your work! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138326] impress template thumbnails are blurred
https://bugs.documentfoundation.org/show_bug.cgi?id=138326 Noel Grandin changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: xmloff/source
xmloff/source/text/XMLIndexAlphabeticalSourceContext.cxx | 14 ++
xmloff/source/text/XMLIndexAlphabeticalSourceContext.hxx |7 +--
xmloff/source/text/XMLIndexBibliographySourceContext.cxx | 14 ++
xmloff/source/text/XMLIndexBibliographySourceContext.hxx |7 +--
xmloff/source/text/XMLIndexIllustrationSourceContext.cxx | 14 ++
xmloff/source/text/XMLIndexIllustrationSourceContext.hxx |7 +--
xmloff/source/text/XMLIndexObjectSourceContext.cxx | 14 ++
xmloff/source/text/XMLIndexObjectSourceContext.hxx |7 +--
xmloff/source/text/XMLIndexSourceBaseContext.cxx | 33 +--
xmloff/source/text/XMLIndexSourceBaseContext.hxx |7 +--
xmloff/source/text/XMLIndexTOCSourceContext.cxx | 14 ++
xmloff/source/text/XMLIndexTOCSourceContext.hxx |7 +--
xmloff/source/text/XMLIndexTOCStylesContext.cxx |5 --
xmloff/source/text/XMLIndexTOCStylesContext.hxx |6 --
xmloff/source/text/XMLIndexTableSourceContext.cxx| 14 ++
xmloff/source/text/XMLIndexTableSourceContext.hxx|7 +--
xmloff/source/text/XMLIndexTemplateContext.cxx |4 -
xmloff/source/text/XMLIndexTemplateContext.hxx |6 --
xmloff/source/text/XMLIndexTitleTemplateContext.cxx |6 --
xmloff/source/text/XMLIndexTitleTemplateContext.hxx |5 --
xmloff/source/text/XMLIndexUserSourceContext.cxx | 14 ++
xmloff/source/text/XMLIndexUserSourceContext.hxx |7 +--
22 files changed, 80 insertions(+), 139 deletions(-)
New commits:
commit 7ac81c6a1dc0ccd6ab62793f4787002da73b4d5b
Author: Noel Grandin
AuthorDate: Tue Nov 24 20:13:47 2020 +0200
Commit: Noel Grandin
CommitDate: Wed Nov 25 07:14:34 2020 +0100
fastparser in TOC
Change-Id: Ia46d61e202292c957299e77e133c7f7a9f6eb0ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106547
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/xmloff/source/text/XMLIndexAlphabeticalSourceContext.cxx
b/xmloff/source/text/XMLIndexAlphabeticalSourceContext.cxx
index 3c1725887fce..c5ad3ffe1c3a 100644
--- a/xmloff/source/text/XMLIndexAlphabeticalSourceContext.cxx
+++ b/xmloff/source/text/XMLIndexAlphabeticalSourceContext.cxx
@@ -197,16 +197,13 @@ void
XMLIndexAlphabeticalSourceContext::endFastElement(sal_Int32 nElement)
XMLIndexSourceBaseContext::endFastElement(nElement);
}
-SvXMLImportContextRef XMLIndexAlphabeticalSourceContext::CreateChildContext(
-sal_uInt16 nPrefix,
-const OUString& rLocalName,
-const Reference & xAttrList )
+css::uno::Reference< css::xml::sax::XFastContextHandler >
XMLIndexAlphabeticalSourceContext::createFastChildContext(
+sal_Int32 nElement,
+const css::uno::Reference< css::xml::sax::XFastAttributeList >& xAttrList )
{
-if ( (XML_NAMESPACE_TEXT == nPrefix) &&
- IsXMLToken( rLocalName, XML_ALPHABETICAL_INDEX_ENTRY_TEMPLATE ) )
+if ( nElement == XML_ELEMENT(TEXT, XML_ALPHABETICAL_INDEX_ENTRY_TEMPLATE) )
{
return new XMLIndexTemplateContext(GetImport(), rIndexPropertySet,
- nPrefix, rLocalName,
aLevelNameAlphaMap,
XML_OUTLINE_LEVEL,
aLevelStylePropNameAlphaMap,
@@ -214,8 +211,7 @@ SvXMLImportContextRef
XMLIndexAlphabeticalSourceContext::CreateChildContext(
}
else
{
-return XMLIndexSourceBaseContext::CreateChildContext(nPrefix,
- rLocalName,
+return XMLIndexSourceBaseContext::createFastChildContext(nElement,
xAttrList);
}
}
diff --git a/xmloff/source/text/XMLIndexAlphabeticalSourceContext.hxx
b/xmloff/source/text/XMLIndexAlphabeticalSourceContext.hxx
index bf903ab091c4..8f39f4c7788a 100644
--- a/xmloff/source/text/XMLIndexAlphabeticalSourceContext.hxx
+++ b/xmloff/source/text/XMLIndexAlphabeticalSourceContext.hxx
@@ -70,10 +70,9 @@ protected:
virtual void SAL_CALL endFastElement(sal_Int32 nElement) override;
-virtual SvXMLImportContextRef CreateChildContext(
-sal_uInt16 nPrefix,
-const OUString& rLocalName,
-const css::uno::Reference & xAttrList )
override;
+virtual css::uno::Reference< css::xml::sax::XFastContextHandler > SAL_CALL
createFastChildContext(
+sal_Int32 nElement,
+const css::uno::Reference< css::xml::sax::XFastAttributeList >&
xAttrList ) override;
};
#endif
diff --git a/xmloff/source/text/XMLIndexBibliographySourceContext.cxx
b/xmloff/source/text/XMLIndexBibliographySourceContext.cxx
index 8434c6adccfa..3b3cab16ded2 100644
--- a/xmloff/source/text/XMLIndexBibliographySourceContext.cxx
+++ b/xmloff/source/text/XMLIndexBibliographySourceContext.cxx
@@ -61,16 +61,13 @@ void
[Libreoffice-bugs] [Bug 138326] impress template thumbnails are blurred
https://bugs.documentfoundation.org/show_bug.cgi?id=138326 --- Comment #2 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/caf72d1f20547a94e29c0943eb94fa52aec430a4 tdf#138326 impress template thumbnails are blurred It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138326] impress template thumbnails are blurred
https://bugs.documentfoundation.org/show_bug.cgi?id=138326 Commit Notification changed: What|Removed |Added Whiteboard||target:7.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/inc
vcl/inc/bitmap/impoctree.hxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit caf72d1f20547a94e29c0943eb94fa52aec430a4
Author: Noel Grandin
AuthorDate: Tue Nov 24 19:13:28 2020 +0200
Commit: Noel Grandin
CommitDate: Wed Nov 25 07:13:38 2020 +0100
tdf#138326 impress template thumbnails are blurred
regression from
commit 548d77d0c06f7088dd3eb408797aa1fc1d7eb277
Author: Noel
Date: Fri Nov 13 10:23:36 2020 +0200
tools::Long->sal_uInt16 in ImpErrorQuad
Change-Id: I29403afcb7d88dee27f1565793ffbd7ad4c53a17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106545
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/vcl/inc/bitmap/impoctree.hxx b/vcl/inc/bitmap/impoctree.hxx
index 50083e38d6a0..7c464dbb9758 100644
--- a/vcl/inc/bitmap/impoctree.hxx
+++ b/vcl/inc/bitmap/impoctree.hxx
@@ -24,9 +24,9 @@
class ImpErrorQuad
{
-sal_uInt16 nRed;
-sal_uInt16 nGreen;
-sal_uInt16 nBlue;
+sal_uInt32 nRed;
+sal_uInt32 nGreen;
+sal_uInt32 nBlue;
public:
ImpErrorQuad()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/sax include/xmloff sax/source xmloff/source
include/sax/tools/converter.hxx | 32 ++---
include/xmloff/xmluconv.hxx |8 -
sax/source/tools/converter.cxx | 112 ++-
xmloff/source/chart/SchXMLPlotAreaContext.cxx|2
xmloff/source/chart/SchXMLPlotAreaContext.hxx|2
xmloff/source/core/xmluconv.cxx |8 -
xmloff/source/draw/ximpcustomshape.cxx |4
xmloff/source/text/XMLChangedRegionImportContext.cxx |2
xmloff/source/text/XMLChangedRegionImportContext.hxx |2
xmloff/source/xforms/XFormsSubmissionContext.cxx |2
10 files changed, 94 insertions(+), 80 deletions(-)
New commits:
commit c8a2550b6a014c05cd4d0ad6a72122f79ce301af
Author: Noel
AuthorDate: Tue Nov 24 14:33:13 2020 +0200
Commit: Noel Grandin
CommitDate: Wed Nov 25 07:13:26 2020 +0100
use string_view for the parsing in sax utils
Change-Id: Ifd7430501318684fc90dd36c1ca965373947
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106499
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/sax/tools/converter.hxx b/include/sax/tools/converter.hxx
index e5e6d5764d0f..6d2347ef289d 100644
--- a/include/sax/tools/converter.hxx
+++ b/include/sax/tools/converter.hxx
@@ -59,7 +59,7 @@ class SAX_DLLPUBLIC Converter
public:
/** convert string to measure using optional min and max values*/
static bool convertMeasure( sal_Int32& rValue,
-const OUString& rString,
+std::u16string_view rString,
sal_Int16 nTargetUnit =
css::util::MeasureUnit::MM_100TH,
sal_Int32 nMin = SAL_MIN_INT32,
sal_Int32 nMax = SAL_MAX_INT32 );
@@ -72,7 +72,7 @@ public:
/** convert string to boolean */
static bool convertBool( bool& rBool,
- const OUString& rString );
+ std::u16string_view rString );
/** convert boolean to string */
static void convertBool( OUStringBuffer& rBuffer,
@@ -80,7 +80,7 @@ public:
/** convert string to percent */
static bool convertPercent( sal_Int32& rValue,
-const OUString& rString );
+std::u16string_view rString );
/** convert percent to string */
static void convertPercent( OUStringBuffer& rBuffer,
@@ -88,7 +88,7 @@ public:
/** convert string to pixel measure unite */
static bool convertMeasurePx( sal_Int32& rValue,
- const OUString& rString );
+ std::u16string_view rString );
/** convert pixel measure unit to string */
static void convertMeasurePx( OUStringBuffer& rBuffer,
@@ -96,9 +96,9 @@ public:
/** convert string to rgb color */
static bool convertColor( sal_Int32& rColor,
- const OUString );
+ std::u16string_view rValue );
static bool convertColor( ::Color& rColor,
- const OUString )
+ std::u16string_view rValue )
{
sal_Int32 n(rColor);
bool b = convertColor( n, rValue );
@@ -139,19 +139,19 @@ public:
/** convert string to double number (using ::rtl::math) and DO convert from
source unit to target unit. */
static bool convertDouble( double& rValue,
-const OUString& rString,
+std::u16string_view rString,
sal_Int16 nSourceUnit,
sal_Int16 nTargetUnit );
/** convert string to double number (using ::rtl::math) without unit
conversion */
-static bool convertDouble(double& rValue, const OUString& rString);
+static bool convertDouble(double& rValue, std::u16string_view rString);
/** convert number, 10th of degrees with range [0..3600] to SVG angle */
static void convertAngle(OUStringBuffer& rBuffer, sal_Int16 nAngle,
SvtSaveOptions::ODFSaneDefaultVersion nVersion);
/** convert SVG angle to number, 10th of degrees with range [0..3600] */
-static bool convertAngle(sal_Int16& rAngle, OUString const& rString,
+static bool convertAngle(sal_Int16& rAngle, std::u16string_view rString,
bool isWrongOOo10thDegAngle);
/** convert double to XMLSchema-2 "duration" string; negative durations
allowed */
@@ -164,11 +164,11 @@ public:
/** convert XMLSchema-2 "duration" string to double; negative durations
allowed */
static bool convertDuration(double & rfTime,
-const OUString& rString);
+std::u16string_view rString);
/** convert XMLSchema-2 "duration" string to util::Duration */
static bool
[Libreoffice-bugs] [Bug 135202] LO 6.4.6.1 and 7.0.1 fail with error 1045 when accessing MySQL database using native connector
https://bugs.documentfoundation.org/show_bug.cgi?id=135202 Julien Nabet changed: What|Removed |Added Whiteboard|target:7.1.0 target:7.0.4 | CC|serval2...@yahoo.fr | --- Comment #63 from Julien Nabet --- Thank you for your last feedback. Since we can't have more details, I don't know how we can guess the missing pluging. I give up=>uncc myself -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138446] Inline objects still disapearing from screen in some positions
https://bugs.documentfoundation.org/show_bug.cgi?id=138446 --- Comment #4 from Sergey --- This error is more complex than I thought: - bug is not reproduce if no graphic line in bottom colontitle - bug is not reproduce if graphic line text flowing setted to "on background" I still can't reproduce it starting from clear document. Only this document with graphic line exists https://bugs.documentfoundation.org/attachment.cgi?id=167531 But now we know how to get around it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137480] Severe screen flickering and misplaced cursor visual while editing with dual window on dual screen
https://bugs.documentfoundation.org/show_bug.cgi?id=137480 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138058] Crashed when I try to create a Table with the Wizard or when I click on the 'Queries' tab of a new HSQLDB file
https://bugs.documentfoundation.org/show_bug.cgi?id=138058 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138118] When you put a picture in the background it was helpful to be able to turn it around if it is upside-down. FORMATTING
https://bugs.documentfoundation.org/show_bug.cgi?id=138118 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138119] to keep the aspect ratio of a background-picture just like with "normal" pictures and graphics FORMATTING
https://bugs.documentfoundation.org/show_bug.cgi?id=138119 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132316] Autocomplete function is activated too early.
https://bugs.documentfoundation.org/show_bug.cgi?id=132316 --- Comment #3 from QA Administrators --- Dear saulpaur, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132316] Autocomplete function is activated too early.
https://bugs.documentfoundation.org/show_bug.cgi?id=132316 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127812] Cannot open a digitally signed hybrid odf in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=127812 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138112] After inserting SVM picture incorrect fallback picture is generated.
https://bugs.documentfoundation.org/show_bug.cgi?id=138112 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105605 Bug 105605 depends on bug 127812, which changed state. Bug 127812 Summary: Cannot open a digitally signed hybrid odf in Writer https://bugs.documentfoundation.org/show_bug.cgi?id=127812 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127812] Cannot open a digitally signed hybrid odf in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=127812 --- Comment #8 from QA Administrators --- Dear Hayder Al-Hakeem, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126162] Can't set jdk downloaded with sdkman
https://bugs.documentfoundation.org/show_bug.cgi?id=126162 --- Comment #6 from QA Administrators --- Dear Marco Sulla, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133481] LibreOffice opens a odt file when a spreadsheet is selected
https://bugs.documentfoundation.org/show_bug.cgi?id=133481 --- Comment #2 from QA Administrators --- Dear Luis, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126162] Can't set jdk downloaded with sdkman
https://bugs.documentfoundation.org/show_bug.cgi?id=126162 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/doc/docfld.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit aac9c35c7405859a38f634ee95b8aba5f62db84d Author: Mike Kaganski AuthorDate: Tue Nov 24 22:57:02 2020 +0300 Commit: Mike Kaganski CommitDate: Wed Nov 25 05:21:22 2020 +0100 Fix --disable-pch build on Windows Restore inclusion of , added in 63f7efe613f4f7436eddd90933c1916d2e689648 to fix exactly the same problem that reappeared now after removing it in commit fe88ffb661053f8fff9bd77affdf4de820c43ca8. This partially reverts fe88ffb661053f8fff9bd77affdf4de820c43ca8, making the inclusion conditional. Change-Id: Iab6893549377e1b8f2f96150b09b7294c9476fa2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106555 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/sw/source/core/doc/docfld.cxx b/sw/source/core/doc/docfld.cxx index ad21d076a3ac..68b6df983e4a 100644 --- a/sw/source/core/doc/docfld.cxx +++ b/sw/source/core/doc/docfld.cxx @@ -24,6 +24,9 @@ #include #include #include +#ifndef UNX +#include +#endif #include #include #include ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 90796] [META] HiDPI / Retina bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=90796 Alexander Barris changed: What|Removed |Added Depends on||138122 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=138122 [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 Alexander Barris changed: What|Removed |Added Blocks||90796 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=90796 [Bug 90796] [META] HiDPI / Retina bugs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138476] LibreOffice Calc file loading time, saving time and response time. FILEOPEN, FILESAVE
https://bugs.documentfoundation.org/show_bug.cgi?id=138476 --- Comment #1 from Rubel --- Created attachment 167549 --> https://bugs.documentfoundation.org/attachment.cgi?id=167549=edit It's my file that i use full day and facing problem to open, save, edit it I am making bug report base on attached spreadsheet. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138475] Default Asian font-size in Calc Heading styles are not the same as Western fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=138475 --- Comment #2 from Kevin Suo --- Created attachment 167548 --> https://bugs.documentfoundation.org/attachment.cgi?id=167548=edit pdf file showing the issue -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138476] New: LibreOffice Calc file loading time, saving time and response time. FILEOPEN, FILESAVE
https://bugs.documentfoundation.org/show_bug.cgi?id=138476 Bug ID: 138476 Summary: LibreOffice Calc file loading time, saving time and response time. FILEOPEN, FILESAVE Product: LibreOffice Version: 7.0.3.1 release Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: an.is...@gmail.com Description: Hi I need to use excel file for my office work. I use the file with 57 worksheet in single file. I use to work on microsoft office but i was useing pirated MS office so sometime it makes problem. So i decided to move to LibreOffice as it's free and quite popular. The problem i am facing is, 1. It takes long time to load the file compare with MS Excel 2. During file saving time also take long time, and it become not responding. I become stuck for few moment 3. During switch cell, column, row or worksheet it response very slow compare with MS Excel. Steps to Reproduce: 1.Open one spreadsheet file that contains 57 worksheet 2.Jump between cell, column, row, worksheet 3.Save the file Actual Results: It takes too much time to complete job compared with MS Excel. Expected Results: It should response quicker. Reproducible: Always User Profile Reset: No Additional Info: First i keep file format in .xlx so i thought problem happening due to not native file format of LibreOffice. Then i save the file in .ods format but it's performing same slow. I want to share my file to you so you can find out the specific problem. Let me know how i can share my file. Version: 7.0.3.1 (x64) Build ID: d7547858d014d4cf69878db179d326fc3483e082 CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138475] Default Asian font-size in Calc Heading styles are not the same as Western fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=138475 --- Comment #1 from Kevin Suo --- I will try to change this, but could someone give me some code pointer where the default Calc template is located? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138475] New: Default Asian font-size in Calc Heading styles are not the same as Western fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=138475 Bug ID: 138475 Summary: Default Asian font-size in Calc Heading styles are not the same as Western fonts Product: LibreOffice Version: 7.1.0.0.alpha1+ Hardware: All OS: All Status: UNCONFIRMED Severity: trivial Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: suokunl...@126.com Steps to Reproduce: 1. Copy paste "This is 汉字" in Calc. 2. Apply Heading, Heading 1 or Heading 2 style. Current Result: Heading: 24pt for Western fonts but 10pt for Asian. Heading 1: 18pt for Western, still 10pt for Asian. Heading 2: 12pt for Western, still 10pt for Asian. Expected: Asian font size should be the same as Western, otherwise the texts shown in the cells will look ugly. Version 7.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136801] BASIC: CInt("+2") returns 0
https://bugs.documentfoundation.org/show_bug.cgi?id=136801
--- Comment #4 from An-Kh ---
Hi
IsNumeric("+2")
gives false.
I have only worked on the IsNumeric part.
Should I open a new bug for it and report my patch there or should I report it
here?
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 Aron Budea changed: What|Removed |Added Priority|medium |highest Severity|normal |critical --- Comment #65 from Aron Budea --- I'm assuming the same severity/priority as bug 122218 is warranted here. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106040] [META] Help bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106040 Bug 106040 depends on bug 138458, which changed state. Bug 138458 Summary: Help section does not contain info about the "Save preview image" checkbox in "File > Properties" dialog, "General" tab https://bugs.documentfoundation.org/show_bug.cgi?id=138458 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138458] Help section does not contain info about the "Save preview image" checkbox in "File > Properties" dialog, "General" tab
https://bugs.documentfoundation.org/show_bug.cgi?id=138458 sdc.bla...@youmail.dk changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |sdc.bla...@youmail.dk |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit cb084f475db33a2cfc62bc9c8de37b8c3c87b3c7 Author: Seth Chaiklin AuthorDate: Wed Nov 25 02:10:00 2020 +0100 Commit: Gerrit Code Review CommitDate: Wed Nov 25 02:10:00 2020 +0100 Update git submodules * Update helpcontent2 from branch 'master' to bb3b17ed7577aca011955a97e40edfd795e70cd3 - tdf#138458 add explanation of "Save Preview Image..." in File > Properties-General Change-Id: I08f7d94c61262d51f3deb128becb4544a4fa7064 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106518 Tested-by: Jenkins Reviewed-by: Seth Chaiklin diff --git a/helpcontent2 b/helpcontent2 index 4ce5903f1a64..bb3b17ed7577 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 4ce5903f1a64531b32402523c0d33050b42bba7a +Subproject commit bb3b17ed7577aca011955a97e40edfd795e70cd3 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 138458] Help section does not contain info about the "Save preview image" checkbox in "File > Properties" dialog, "General" tab
https://bugs.documentfoundation.org/show_bug.cgi?id=138458 --- Comment #5 from Commit Notification --- Seth Chaiklin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/bb3b17ed7577aca011955a97e40edfd795e70cd3 tdf#138458 add explanation of "Save Preview Image..." in File > Properties-General -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138458] Help section does not contain info about the "Save preview image" checkbox in "File > Properties" dialog, "General" tab
https://bugs.documentfoundation.org/show_bug.cgi?id=138458 Commit Notification changed: What|Removed |Added Whiteboard||target:7.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] help.git: source/text
source/text/shared/01/01100200.xhp |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit bb3b17ed7577aca011955a97e40edfd795e70cd3 Author: Seth Chaiklin AuthorDate: Wed Nov 25 01:59:43 2020 +0100 Commit: Seth Chaiklin CommitDate: Wed Nov 25 02:10:00 2020 +0100 tdf#138458 add explanation of "Save Preview Image..." in File > Properties-General Change-Id: I08f7d94c61262d51f3deb128becb4544a4fa7064 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106518 Tested-by: Jenkins Reviewed-by: Seth Chaiklin diff --git a/source/text/shared/01/01100200.xhp b/source/text/shared/01/01100200.xhp index 001816e0c..15aa5f325 100644 --- a/source/text/shared/01/01100200.xhp +++ b/source/text/shared/01/01100200.xhp @@ -76,6 +76,8 @@ Reset Properties Resets the editing time to zero, the creation date to the current date and time, and the version number to 1. The modification and printing dates are also deleted. Save preview image with this document - + Saves a thumbnail preview .png inside the document. This image may be used by a file manager under certain conditions. + If you want to disable generating thumbnails in general, then choose +Tools > Options > LibreOffice > Advanced. Click the Open Expert Configuration button, and search for GenerateThumbnail. If this property has the value true, then double-click on it to set its value to false. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 138091] Base Index Design not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=138091 --- Comment #3 from Fred --- (In reply to Robert Großkopf from comment #1) Robert, I restarted Base in "Safe Mode" and this worked as expected. I created and tested my "index1". "John Q Public" could not be entered twice in the table, so it now has "John Q Public" and "John Q1 Public". I closed Base and restarted normally. Now it works, and I was able to create another index as a test. The only extensions are those bundled with LibreOffice: English dictionaries for OpenOffice/LibreOffice 4.0+ Solver for Nonlinear Programing 0.9 Spanish Ortografia 2.5 Wiki Publisher 1.2.0 I don't know what to say as if did work just now as expected. -- Fred -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138474] New: When image is anchored to page in Writer, cannot interact with anchor.
https://bugs.documentfoundation.org/show_bug.cgi?id=138474 Bug ID: 138474 Summary: When image is anchored to page in Writer, cannot interact with anchor. Product: LibreOffice Version: 7.0.0.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: stefan.m.te...@gmail.com Description: When an image on a page is set to anchor to page, trying to interact with the anchor to change the page it is anchored to instead opens the header/footer, making it impossible to change the page these images are anchored to effectively. When switching to another anchor method, it is unpredictable where the image will end up, and has on multiple occasions become hidden and unable to be interacted with entirely. Steps to Reproduce: 1.place one or more images on a page 2.set anchor to page 3.try to move the anchor Actual Results: the image lost focus, and the header gained focus. Expected Results: allowed movement of the anchor to another page. Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: TextDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: no -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137879] LO should know not to try and recover temporary files
https://bugs.documentfoundation.org/show_bug.cgi?id=137879 Eyal Rozenberg changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #2 from Eyal Rozenberg --- (In reply to pavlog from comment #1) > Please provide a clearer set of step-by-step instructions on how to > reproduce the problem. I guess I wasn't explicit enough. 1. Ensure LibreOffice is closed 2. Open LibreOffice; ensure no recovery dialog comes up (otherwise handle recovery and return to step 1) 3. Close LibreOffice 4. Open a mail client (say, Thunderbird). 5. View a message with an attachment document you can open with LibreOffice Writer (if you don't have one - send yourself one). 6. Open the file (e.g. by double-clicking it - but this depends on your OS and desktop environment of course); this should launch LO writer with the document 7. Determine where the temporary file LO has opened is located (on Linux and with Thunderbird this might be under /tmp/mozilla_yourname0/the_file ) 8. kill the LO process - aggressively (e.g. with kill -9 if you're on Linux/BSD/Mac; I'm not sure End Process on Windows is enough) 9. Remove the copy of the file from wherever it is located 10. Launch LO. Expected results: No recovery dialog is opened, or a dialog is opened indicating already the special case of a temporary file which is no longer present. Actual Results: A recovery dialog is opened, like for any other document; and the attempted recovery reports a failure. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138473] New: Typing slows down if there's at least 2 images on the document
https://bugs.documentfoundation.org/show_bug.cgi?id=138473 Bug ID: 138473 Summary: Typing slows down if there's at least 2 images on the document Product: LibreOffice Version: 7.0.3.1 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: virtuald...@gmail.com Description: I'm using LibreOffice for photography assignments that involve placing photos in a document and giving a description and the settings of the photo. That combines photos and words. With only 2 photos in the document (with more to come), there's a lag between my physical keystrokes and the letters showing up on the document and I have to wait for it catch up. There's even a lag on scrolling up or down. Steps to Reproduce: 1. Add at least 2 photos to a document 2. Try to type and watch the letters show up 3. Try scrolling up and down the page Actual Results: The letters showing up on screen lag behind my keystrokes Expected Results: The letters showing up match up perfectly with my keystrokes Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: TextDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: no -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138472] Calc enhancement: ignore rows when importing CVS
https://bugs.documentfoundation.org/show_bug.cgi?id=138472 j22...@gmail.com changed: What|Removed |Added Severity|normal |enhancement --- Comment #1 from j22...@gmail.com --- Changed to "enhancement" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138472] New: Calc enhancement: ignore rows when importing CVS
https://bugs.documentfoundation.org/show_bug.cgi?id=138472
Bug ID: 138472
Summary: Calc enhancement: ignore rows when importing CVS
Product: LibreOffice
Version: 3.3.0 release
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: Calc
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: j22...@gmail.com
Description:
Many times we get data files as CVS from 3rd parties. These files often have
comments and explanations which are not relevant to eg making plots.
It would be great to have an option in the CVS import dialog where the user can
ignore some rows. I am aware that you can "ignore" the first x rows, however if
you want to automate this task you would need to know X for each and all files
to be imported.
As comments rows start with different character in different uses or data
sources, it would be convenient to be able to chose that character.
So I propose to include an option in this dialog which let the user
"ignore rows starting with [] character" where [] is a text box.
Steps to Reproduce:
Open CSV in Calc.
Lets imagine the file has a number of rows (which you do not know in advance)
that are comments and you don't need them to work with Calc. Each line of the
comments starts with "#"
Actual Results:
You get a dialog where several options are presented, eg the character which
separates the values (eg"," ";"etc).
But you can not discard the comments rows. So you have to load the whole file,
then manually delete the rows.
Expected Results:
It would be great if there was the option in the import dialog, something like
a click box to activate the option "Ignore the rows starting with []" where []
is a text box where the user would place the "comment character" ("#" in this
case)
Reproducible: Always
User Profile Reset: No
Additional Info:
Additionally, this could be useful to ignore empty lines, for example writing
"" (empty string) into the "ignore box".
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138456] Add an APPLY button to "Number Format" dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=138456 --- Comment #1 from Uwe Auer --- The result/preview of the selected format code is already in the preview in the middle of the right side of the dialog. What is the additional benefit of an Apply button? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138295] Calc shows "loading file" each time I select a column
https://bugs.documentfoundation.org/show_bug.cgi?id=138295 j22...@gmail.com changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|UNCONFIRMED |RESOLVED --- Comment #2 from j22...@gmail.com --- It works fine now. Apparently something changed in my GNU/Linux (presumably an update, since I apply updates as soon as they're available). So now it works perfectly fine even with thousands of rows. Calling LO from terminal using SAL_USE_VCLPLUGIN=gen also works fine as expected. Since LO has not changed as far as I know, I assume the problem was in my OS. Just in case: Version: 7.0.3.1 Build ID: 00(Build:1) CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Ubuntu package version: 1:7.0.3-0ubuntu0.20.04.1 Calc: threaded I see that VCL is "gtk3" now instead of "x11". Not sure what they mean and if that could hint to some of the troubles. Anyway, it is seems to be fixed now. Thanks everyone for this wonderful FOSS!! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138091] Base Index Design not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=138091 --- Comment #2 from Fred --- (In reply to Robert Großkopf from comment #1) Thank you. Please refer to BH40-BaseHandbook, page 41. A test table (People) would have Person_ID (primary key, autovalue), FirstName, Initial, LastName (all Text [VARCHAR]). It is possible that there are several "John Q Public". Each would have his own Primary Key (PK). I want to create an Index of the (3) name fields. Edit the Table, and see several ~SYS_IDX_##~ Click the leftmost icon (New Index) and see ~index1~ Select each of the name fields, then click "Close" Verify that Unique is checked. See the "Do you want to save the changes made to the current index?" Click "Yes" Read "Index not found: index1 in statement [DROP INDEX "index1" ON "People"] Note: the names shown for the indexes are not constant. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/source sw/qa sw/source
sfx2/source/view/viewsh.cxx | 14 -
sw/qa/extras/tiledrendering/data/table-paint-invalidate.odt |binary
sw/qa/extras/tiledrendering/tiledrendering.cxx | 33
sw/source/uibase/docvw/edtwin2.cxx | 11
4 files changed, 56 insertions(+), 2 deletions(-)
New commits:
commit 0f65b4b6f33891a724bee5356aa5549c76fa0ce3
Author: Miklos Vajna
AuthorDate: Tue Nov 24 17:26:32 2020 +0100
Commit: Miklos Vajna
CommitDate: Tue Nov 24 23:05:13 2020 +0100
sw tiled rendering: fix paint->invalidation loop when paint is started by
vcl
SwViewShell::PaintTile() already calls
comphelper::LibreOfficeKit::setTiledPainting(), so by the time it would
rearch SwViewShell::Paint(), callbacks (e.g. invalidations) are ignored
during paint.
Do the same for SwEditWin::Paint(), where we processed invalidations
during paint, potentially leading to paint->invalidation loops.
Change-Id: I8280f5c2571beeae6c0f2986d275dde3c2d33161
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106542
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sfx2/source/view/viewsh.cxx b/sfx2/source/view/viewsh.cxx
index d35253d1342a..2da4bc1e81bd 100644
--- a/sfx2/source/view/viewsh.cxx
+++ b/sfx2/source/view/viewsh.cxx
@@ -1463,8 +1463,18 @@ void SfxViewShell::libreOfficeKitViewCallback(int nType,
const char* pPayload) c
if (!comphelper::LibreOfficeKit::isActive())
return;
-if (comphelper::LibreOfficeKit::isTiledPainting() && nType !=
LOK_CALLBACK_FORM_FIELD_BUTTON)
-return;
+if (comphelper::LibreOfficeKit::isTiledPainting())
+{
+switch (nType)
+{
+case LOK_CALLBACK_FORM_FIELD_BUTTON:
+case LOK_CALLBACK_TEXT_SELECTION:
+break;
+default:
+// Reject e.g. invalidate during paint.
+return;
+}
+}
if (pImpl->m_bTiledSearching)
{
diff --git a/sw/qa/extras/tiledrendering/data/table-paint-invalidate.odt
b/sw/qa/extras/tiledrendering/data/table-paint-invalidate.odt
new file mode 100644
index ..b42c5cc51588
Binary files /dev/null and
b/sw/qa/extras/tiledrendering/data/table-paint-invalidate.odt differ
diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index dc57ef1e451a..afb261b4d4bc 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -144,6 +144,7 @@ public:
void testDropDownFormFieldButtonEditing();
void testDropDownFormFieldButtonNoSelection();
void testDropDownFormFieldButtonNoItem();
+void testTablePaintInvalidate();
CPPUNIT_TEST_SUITE(SwTiledRenderingTest);
CPPUNIT_TEST(testRegisterCallback);
@@ -215,6 +216,7 @@ public:
CPPUNIT_TEST(testDropDownFormFieldButtonEditing);
CPPUNIT_TEST(testDropDownFormFieldButtonNoSelection);
CPPUNIT_TEST(testDropDownFormFieldButtonNoItem);
+CPPUNIT_TEST(testTablePaintInvalidate);
CPPUNIT_TEST_SUITE_END();
private:
@@ -2836,6 +2838,37 @@ void
SwTiledRenderingTest::testDropDownFormFieldButtonNoItem()
}
}
+void SwTiledRenderingTest::testTablePaintInvalidate()
+{
+// Load a document with a table in it.
+SwXTextDocument* pXTextDocument = createDoc("table-paint-invalidate.odt");
+SwWrtShell* pWrtShell = pXTextDocument->GetDocShell()->GetWrtShell();
+
pWrtShell->GetSfxViewShell()->registerLibreOfficeKitViewCallback(::callback,
this);
+// Enter the table.
+pWrtShell->Down(/*bSelect=*/false);
+Scheduler::ProcessEventsToIdle();
+m_nInvalidations = 0;
+
+// Paint a tile.
+size_t nCanvasWidth = 256;
+size_t nCanvasHeight = 256;
+std::vector aPixmap(nCanvasWidth * nCanvasHeight * 4, 0);
+ScopedVclPtrInstance pDevice(DeviceFormat::DEFAULT);
+pDevice->SetBackground(Wallpaper(COL_TRANSPARENT));
+pDevice->SetOutputSizePixelScaleOffsetAndBuffer(Size(nCanvasWidth,
nCanvasHeight),
+Fraction(1.0), Point(),
aPixmap.data());
+pXTextDocument->paintTile(*pDevice, nCanvasWidth, nCanvasHeight,
m_aInvalidation.getX(),
+ m_aInvalidation.getY(), /*nTileWidth=*/1000,
+ /*nTileHeight=*/1000);
+Scheduler::ProcessEventsToIdle();
+
+// Without the accompanying fix in place, this test would have failed with
+// - Expected: 0
+// - Actual : 5
+// i.e. paint generated an invalidation, which caused a loop.
+CPPUNIT_ASSERT_EQUAL(0, m_nInvalidations);
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(SwTiledRenderingTest);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/source/uibase/docvw/edtwin2.cxx
b/sw/source/uibase/docvw/edtwin2.cxx
index fb7f965838e2..ae168908de6f 100644
--- a/sw/source/uibase/docvw/edtwin2.cxx
+++ b/sw/source/uibase/docvw/edtwin2.cxx
@@ -51,6 +51,7 @@
[Libreoffice-bugs] [Bug 137748] [UI] not working in Statistics tab [Writer] [Calc]
https://bugs.documentfoundation.org/show_bug.cgi?id=137748 neuf...@gmail.com changed: What|Removed |Added Whiteboard| QA:needsComment| Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from neuf...@gmail.com --- Could reproduce in: Version: 7.0.3.1 (x64) Build ID: d7547858d014d4cf69878db179d326fc3483e082 CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL Also in: Version: 7.2.0.0.alpha0+ (x64) Build ID: f313e27fb7f2d42247407e26e16f264e30f87ca5 CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134802] [ENHANCEMENT] Proposal of a new "Paste Special" dialog box
https://bugs.documentfoundation.org/show_bug.cgi?id=134802 --- Comment #11 from Roman Kuznetsov <79045_79...@mail.ru> --- (In reply to Heiko Tietze from comment #10) > Created attachment 167541 [details] > Example for solutions > > From left to right: Current situation, Proposal with 3 columns, Proposal > with 4 columns, and Presets (see comment 7) (the buttons should show > Image+Text but don't out of the box; "Run Immediately" off means the button > applies settings only) I like a last right variant with Presets in first column, but I dislike icons on buttons in that case. I would prefer buttons with labels there And I would change "Selection" label to "Paste" and item label "Paste all" to simple "All" like: Paste: All Numbers Text Date etc. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 134802] [ENHANCEMENT] Proposal of a new "Paste Special" dialog box
https://bugs.documentfoundation.org/show_bug.cgi?id=134802 --- Comment #11 from Roman Kuznetsov <79045_79...@mail.ru> --- (In reply to Heiko Tietze from comment #10) > Created attachment 167541 [details] > Example for solutions > > From left to right: Current situation, Proposal with 3 columns, Proposal > with 4 columns, and Presets (see comment 7) (the buttons should show > Image+Text but don't out of the box; "Run Immediately" off means the button > applies settings only) I like a last right variant with Presets in first column, but I dislike icons on buttons in that case. I would prefer buttons with labels there And I would change "Selection" label to "Paste" and item label "Paste all" to simple "All" like: Paste: All Numbers Text Date etc. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 135202] LO 6.4.6.1 and 7.0.1 fail with error 1045 when accessing MySQL database using native connector
https://bugs.documentfoundation.org/show_bug.cgi?id=135202 --- Comment #62 from Dan Lewis --- (In reply to Dan Lewis from comment #61) > Created attachment 167547 [details] > native password not working daily build 11/23/2020 This is the error for this daily build: SQL Status: 28000 Error code: 1045 Plugin mysql_native_password could not be loaded: /tinderbox/buildslave/source/libo-70/connectivity/source/drivers/mysqlc/mysqlc_general.cxx:119 I will download the daily build for 7.0.4.0+ tomorrow. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138471] New: Clicking "Page Margins" button sets left and right margins to 0
https://bugs.documentfoundation.org/show_bug.cgi?id=138471 Bug ID: 138471 Summary: Clicking "Page Margins" button sets left and right margins to 0 Product: LibreOffice Version: 7.0.2.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: carlsone...@protonmail.com Description: When in the Tabbed user interface, clicking the "Page Margins" button under the Layout tab immediately sets the left and right margins to 0. Steps to Reproduce: 1. Enable Tabbed user interface 2. Click on the Layout tab 3. Click on Page Margins Actual Results: Left and right margins are changed to 0. Expected Results: All margins should retain their current values until the user overwrites them. Reproducible: Always User Profile Reset: Yes Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: TextDocument [Information guessed from browser] OS: Linux (All) OS is 64bit: yes Ubuntu package version: 1:7.0.2-ubuntu1 UI Render: default; VCL: gtk3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135202] LO 6.4.6.1 and 7.0.1 fail with error 1045 when accessing MySQL database using native connector
https://bugs.documentfoundation.org/show_bug.cgi?id=135202 --- Comment #61 from Dan Lewis --- Created attachment 167547 --> https://bugs.documentfoundation.org/attachment.cgi?id=167547=edit native password not working daily build 11/23/2020 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138470] Crash when joining 2 paragraphs, one with bullet
https://bugs.documentfoundation.org/show_bug.cgi?id=138470 --- Comment #1 from Olivier Hallot --- Created attachment 167546 --> https://bugs.documentfoundation.org/attachment.cgi?id=167546=edit Document that causes crash -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138470] New: Crash when joining 2 paragraphs, one with bullet
https://bugs.documentfoundation.org/show_bug.cgi?id=138470 Bug ID: 138470 Summary: Crash when joining 2 paragraphs, one with bullet Product: LibreOffice Version: 7.0.3.1 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: olivier.hal...@libreoffice.org Created attachment 167545 --> https://bugs.documentfoundation.org/attachment.cgi?id=167545=edit traceback under kubuntu 20.04 Step to reproduce 1) open odt file attached 2) Join the bullet paragraph on page 7 of the document with the upper paragraph -> crash. (...) Barra de Menus Abaixo da barra de título está a barra de menus. Quando se escolhe um dos menus, uma lista de opções é exibida. Também pode-se modificar a barra de menus, conforme explicado no Capítulo 14, Configuração e personalização. • Arquivo – contém comandos que se aplicam a todo o documento, como Abrir, Salvar, Assistentes, Exportar como PDF, Imprimir, Assinaturas digitais, Modelos. (...) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137887] wrong help page linked to Help button in Position and Size dialog for Textbox and Shape
https://bugs.documentfoundation.org/show_bug.cgi?id=137887 pavlog changed: What|Removed |Added CC||pavlograd...@gmail.com Whiteboard| QA:needsComment| Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from pavlog --- Thank you for reporting the bug. I can confirm that the bug is present in Version: 7.1.0.0.alpha1+ (x64) Build ID: 91c5642bf0ee48ff91181d779c3a84c768f340df CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137879] LO should know not to try and recover temporary files
https://bugs.documentfoundation.org/show_bug.cgi?id=137879 pavlog changed: What|Removed |Added Ever confirmed|0 |1 CC||pavlograd...@gmail.com Whiteboard| QA:needsComment| Status|UNCONFIRMED |NEEDINFO --- Comment #1 from pavlog --- Hello Eyal, Thank you for reporting the bug. Unfortunately without clear steps to reproduce it, we cannot track down the origin of the problem. Please provide a clearer set of step-by-step instructions on how to reproduce the problem. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the steps are provided -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137877] Changing some line feature of a group object including lines where another feature is different across them, causes this second feature to change
https://bugs.documentfoundation.org/show_bug.cgi?id=137877 pavlog changed: What|Removed |Added Ever confirmed|0 |1 Whiteboard| QA:needsComment| Status|UNCONFIRMED |NEEDINFO CC||pavlograd...@gmail.com --- Comment #2 from pavlog --- Hello Sergio, Thank you for reporting the bug. Unfortunately without clear steps to reproduce it, we cannot track down the origin of the problem. Please provide a clearer set of step-by-step instructions on how to reproduce the problem. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the steps are provided -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sfx2/uiconfig
sfx2/uiconfig/ui/tabbarcontents.ui |1 + 1 file changed, 1 insertion(+) New commits: commit c3b94e1d3f12f9f8a58c3f33bdb18d3a0990ea79 Author: Caolán McNamara AuthorDate: Tue Nov 24 15:46:49 2020 + Commit: Caolán McNamara CommitDate: Tue Nov 24 21:30:01 2020 +0100 center the button for narrower Colibre theme icon Change-Id: I7feb62abf4e4f4b635c0e3096ff67f698d8de6b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106514 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/sfx2/uiconfig/ui/tabbarcontents.ui b/sfx2/uiconfig/ui/tabbarcontents.ui index d3945c8eec0b..b898359194e3 100644 --- a/sfx2/uiconfig/ui/tabbarcontents.ui +++ b/sfx2/uiconfig/ui/tabbarcontents.ui @@ -92,6 +92,7 @@ True Sidebar Settings center +center 3 image6 none ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - filter/source
filter/source/pdf/pdfdecomposer.cxx |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
New commits:
commit 5f159d4f8524cd466e124ca8366d71566cb883c4
Author: Noel Grandin
AuthorDate: Thu Aug 20 21:54:25 2020 +0200
Commit: Caolán McNamara
CommitDate: Tue Nov 24 21:29:01 2020 +0100
fix unit-test with non-pdfium build
otherwise testSwappingPageNumber will crash accessing out of
bounds element in vector.
Change-Id: I07499e79d523931e1f3cc02a5150f033e1ea9578
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101094
Tested-by: Jenkins
Reviewed-by: Noel Grandin
(cherry picked from commit 17798a503bc67f2a38f4b558e37447d1ea8f4623)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106511
Reviewed-by: Caolán McNamara
diff --git a/filter/source/pdf/pdfdecomposer.cxx
b/filter/source/pdf/pdfdecomposer.cxx
index e053fd215369..e54206e4c175 100644
--- a/filter/source/pdf/pdfdecomposer.cxx
+++ b/filter/source/pdf/pdfdecomposer.cxx
@@ -70,7 +70,10 @@ uno::Sequence>
SAL_CALL XPdfDecomposer::ge
nPageIndex = 0;
std::vector aBitmaps;
-vcl::RenderPDFBitmaps(xPdfData.getConstArray(), xPdfData.getLength(),
aBitmaps, nPageIndex, 1);
+int rv = vcl::RenderPDFBitmaps(xPdfData.getConstArray(),
xPdfData.getLength(), aBitmaps,
+ nPageIndex, 1);
+if (rv == 0)
+return {}; // happens if we do not have PDFium
BitmapEx aReplacement(aBitmaps[0]);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - cui/source svx/source
cui/source/tabpages/numpages.cxx |6 +++---
svx/source/tbxctrls/bulletsnumbering.cxx |2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
New commits:
commit d8c5bd180ede0103bd3f0c6caec05757920fc27d
Author: Caolán McNamara
AuthorDate: Tue Nov 24 10:02:34 2020 +
Commit: Caolán McNamara
CommitDate: Tue Nov 24 21:28:33 2020 +0100
tdf#138430 scrolled windows need to have auto scrolling disabled
Change-Id: I8a622f00238d3d20d21d2439d6fc4fb13358f0c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106444
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/cui/source/tabpages/numpages.cxx b/cui/source/tabpages/numpages.cxx
index f158be94773e..dd699b85428d 100644
--- a/cui/source/tabpages/numpages.cxx
+++ b/cui/source/tabpages/numpages.cxx
@@ -163,7 +163,7 @@
SvxSingleNumPickTabPage::SvxSingleNumPickTabPage(weld::Container* pPage, weld::D
, bModified(false)
, bPreset(false)
, nNumItemId(SID_ATTR_NUMBERING_RULE)
-, m_xExamplesVS(new
SvxNumValueSet(m_xBuilder->weld_scrolled_window("valuesetwin")))
+, m_xExamplesVS(new
SvxNumValueSet(m_xBuilder->weld_scrolled_window("valuesetwin", true)))
, m_xExamplesVSWin(new weld::CustomWeld(*m_xBuilder, "valueset",
*m_xExamplesVS))
{
SetExchangeSupport();
@@ -342,7 +342,7 @@ SvxBulletPickTabPage::SvxBulletPickTabPage(weld::Container*
pPage, weld::DialogC
, bModified(false)
, bPreset(false)
, nNumItemId(SID_ATTR_NUMBERING_RULE)
-, m_xExamplesVS(new
SvxNumValueSet(m_xBuilder->weld_scrolled_window("valuesetwin")))
+, m_xExamplesVS(new
SvxNumValueSet(m_xBuilder->weld_scrolled_window("valuesetwin", true)))
, m_xExamplesVSWin(new weld::CustomWeld(*m_xBuilder, "valueset",
*m_xExamplesVS))
{
SetExchangeSupport();
@@ -491,7 +491,7 @@ SvxNumPickTabPage::SvxNumPickTabPage(weld::Container*
pPage, weld::DialogControl
, nNumItemId(SID_ATTR_NUMBERING_RULE)
, bModified(false)
, bPreset(false)
-, m_xExamplesVS(new
SvxNumValueSet(m_xBuilder->weld_scrolled_window("valuesetwin")))
+, m_xExamplesVS(new
SvxNumValueSet(m_xBuilder->weld_scrolled_window("valuesetwin", true)))
, m_xExamplesVSWin(new weld::CustomWeld(*m_xBuilder, "valueset",
*m_xExamplesVS))
{
SetExchangeSupport();
diff --git a/svx/source/tbxctrls/bulletsnumbering.cxx
b/svx/source/tbxctrls/bulletsnumbering.cxx
index d30a6aabcfd0..7eeac2bd7202 100644
--- a/svx/source/tbxctrls/bulletsnumbering.cxx
+++ b/svx/source/tbxctrls/bulletsnumbering.cxx
@@ -68,7 +68,7 @@ NumberingPopup::NumberingPopup(NumberingToolBoxControl&
rController,
: WeldToolbarPopup(rController.getFrameInterface(), pParent,
"svx/ui/numberingwindow.ui", "NumberingWindow")
, mePageType(ePageType)
, mrController(rController)
-, mxValueSet(new
SvxNumValueSet(m_xBuilder->weld_scrolled_window("valuesetwin")))
+, mxValueSet(new
SvxNumValueSet(m_xBuilder->weld_scrolled_window("valuesetwin", true)))
, mxValueSetWin(new weld::CustomWeld(*m_xBuilder, "valueset", *mxValueSet))
, mxMoreButton(m_xBuilder->weld_button("more"))
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sfx2/uiconfig
sfx2/uiconfig/ui/tabbarcontents.ui |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 84368443fe44d4c8eaba88c9dd45d20974142ce2 Author: Caolán McNamara AuthorDate: Tue Nov 24 15:23:03 2020 + Commit: Caolán McNamara CommitDate: Tue Nov 24 21:27:32 2020 +0100 open_more.png is narrower than other icons in Colibre theme so use a different one to measure desired width of tabbar Change-Id: Iace4b46d77d5cb52b2faaf6bb035be50fd556d12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106512 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/sfx2/uiconfig/ui/tabbarcontents.ui b/sfx2/uiconfig/ui/tabbarcontents.ui index 34aa02d360df..d3945c8eec0b 100644 --- a/sfx2/uiconfig/ui/tabbarcontents.ui +++ b/sfx2/uiconfig/ui/tabbarcontents.ui @@ -118,7 +118,7 @@ True False True -sfx2/res/symphony/open_more.png +sfx2/res/symphony/sidebar-property-large.png False ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - external/redland
external/redland/UnpackedTarball_raptor.mk
|2
external/redland/raptor/0001-CVE-2020-25713-raptor2-malformed-input-file-can-lead.patch.1
| 33 ++
external/redland/raptor/raptor-fix-oob.patch.1
| 14
3 files changed, 34 insertions(+), 15 deletions(-)
New commits:
commit e56013edb547155e2cb21bb8471edf15c45e2633
Author: Caolán McNamara
AuthorDate: Tue Nov 24 10:32:30 2020 +
Commit: Caolán McNamara
CommitDate: Tue Nov 24 21:25:07 2020 +0100
CVE-2020-25713 raptor2: malformed input file can lead to a segfault
due to an out of bounds array access in
raptor_xml_writer_start_element_common
use a better fix than the initial suggestion
See:
https: //bugs.mageia.org/show_bug.cgi?id=27605
https: //www.openwall.com/lists/oss-security/2020/11/13/1
Change-Id: I9203904755b0e4ac98ae1e39942fd6f616c1efff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106448
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/external/redland/UnpackedTarball_raptor.mk
b/external/redland/UnpackedTarball_raptor.mk
index 3a4d7f17a471..c5ff226168d8 100644
--- a/external/redland/UnpackedTarball_raptor.mk
+++ b/external/redland/UnpackedTarball_raptor.mk
@@ -28,7 +28,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,raptor,\
$(if $(SYSTEM_LIBXML),,external/redland/raptor/rpath.patch) \
external/redland/raptor/xml2-config.patch \
external/redland/raptor/0001-Calcualte-max-nspace-declarations-correctly-for-XML-.patch.1
\
- external/redland/raptor/raptor-fix-oob.patch.1\
+
external/redland/raptor/0001-CVE-2020-25713-raptor2-malformed-input-file-can-lead.patch.1
\
external/redland/raptor/libtool.patch \
external/redland/raptor/libxml-override.patch \
))
diff --git
a/external/redland/raptor/0001-CVE-2020-25713-raptor2-malformed-input-file-can-lead.patch.1
b/external/redland/raptor/0001-CVE-2020-25713-raptor2-malformed-input-file-can-lead.patch.1
new file mode 100644
index ..1fb279df3e4d
--- /dev/null
+++
b/external/redland/raptor/0001-CVE-2020-25713-raptor2-malformed-input-file-can-lead.patch.1
@@ -0,0 +1,33 @@
+From a549457461874157c8c8e8e8a6e0eec06da4fbd0 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Caol=C3=A1n=20McNamara?=
+Date: Tue, 24 Nov 2020 10:30:20 +
+Subject: [PATCH] CVE-2020-25713 raptor2: malformed input file can lead to a
+ segfault
+
+due to an out of bounds array access in
+raptor_xml_writer_start_element_common
+
+See:
+https://bugs.mageia.org/show_bug.cgi?id=27605
+https://www.openwall.com/lists/oss-security/2020/11/13/1
+https://gerrit.libreoffice.org/c/core/+/106249
+---
+ src/raptor_xml_writer.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/raptor_xml_writer.c b/src/raptor_xml_writer.c
+index 56993dc3..4426d38c 100644
+--- a/src/raptor_xml_writer.c
b/src/raptor_xml_writer.c
+@@ -227,7 +227,7 @@ raptor_xml_writer_start_element_common(raptor_xml_writer*
xml_writer,
+
+ /* check it wasn't an earlier declaration too */
+ for(j = 0; j < nspace_declarations_count; j++)
+-if(nspace_declarations[j].nspace ==
element->attributes[j]->nspace) {
++if(nspace_declarations[j].nspace ==
element->attributes[i]->nspace) {
+ declare_me = 0;
+ break;
+ }
+--
+2.28.0
+
diff --git a/external/redland/raptor/raptor-fix-oob.patch.1
b/external/redland/raptor/raptor-fix-oob.patch.1
deleted file mode 100644
index 04106dc9a70e..
--- a/external/redland/raptor/raptor-fix-oob.patch.1
+++ /dev/null
@@ -1,14 +0,0 @@
-diff --git a/src/raptor_xml_writer.c b/src/raptor_xml_writer.c
-index 56993dc3..163f34d5 100644
a/src/raptor_xml_writer.c
-+++ b/src/raptor_xml_writer.c
-@@ -216,6 +216,9 @@ raptor_xml_writer_start_element_common(raptor_xml_writer*
xml_writer,
-
- if(nstack && element->attributes) {
- for(i = 0; i < element->attribute_count; i++) {
-+ if (nspace_declarations_count > element->attribute_count)
-+goto error;
-+
- /* qname */
- if(element->attributes[i]->nspace) {
- /* Check if we need a namespace declaration attribute */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/filter/basflt/fltshell.cxx |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
New commits:
commit 48d052a9f1bdbd34e1819b45ab83f51b84911702
Author: Caolán McNamara
AuthorDate: Tue Nov 24 13:06:13 2020 +
Commit: Caolán McNamara
CommitDate: Tue Nov 24 21:24:41 2020 +0100
ofz#27817 null deref
Change-Id: I16da6f6f78dfd0a4bc17017275a6644d6e4340c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106533
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/filter/basflt/fltshell.cxx
b/sw/source/filter/basflt/fltshell.cxx
index 5a6aefa85191..153ccf42a37b 100644
--- a/sw/source/filter/basflt/fltshell.cxx
+++ b/sw/source/filter/basflt/fltshell.cxx
@@ -631,9 +631,8 @@ void SwFltControlStack::SetAttrInDoc(const SwPosition&
rTmpPos,
{
SwTextNode const*const pTextNode(
aRegion.End()->nNode.GetNode().GetTextNode());
-assert(pTextNode);
-SwTextField const*const pField(pTextNode->GetFieldTextAttrAt(
-aRegion.End()->nContent.GetIndex() - 1, true));
+SwTextField const*const pField = pTextNode ?
pTextNode->GetFieldTextAttrAt(
+aRegion.End()->nContent.GetIndex() - 1, true) :
nullptr;
if (pField)
{
SwPostItField const*const pPostIt(
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sfx2/uiconfig
sfx2/uiconfig/ui/tabbarcontents.ui |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 906b99c21b668b44b1e47909268961023b0bdae8 Author: Caolán McNamara AuthorDate: Tue Nov 24 15:23:03 2020 + Commit: Caolán McNamara CommitDate: Tue Nov 24 21:22:14 2020 +0100 open_more.png is narrower than other icons in Colibre theme so use a different one to measure desired width of tabbar Change-Id: Iace4b46d77d5cb52b2faaf6bb035be50fd556d12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106534 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/sfx2/uiconfig/ui/tabbarcontents.ui b/sfx2/uiconfig/ui/tabbarcontents.ui index 1125db911a77..080ee8b83e53 100644 --- a/sfx2/uiconfig/ui/tabbarcontents.ui +++ b/sfx2/uiconfig/ui/tabbarcontents.ui @@ -118,7 +118,7 @@ True False True -sfx2/res/symphony/open_more.png +sfx2/res/symphony/sidebar-property-large.png False ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 138469] Background patterns and gradients for Calc cells
https://bugs.documentfoundation.org/show_bug.cgi?id=138469 --- Comment #2 from Ming Hua --- (In reply to Ming Hua from comment #1) > You can add the request for patterns as cell background there. Alas, no need. I see now the request for patterns is tracked separately as bug 31205. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - include/vcl vcl/source
include/vcl/tabpage.hxx |2 --
vcl/source/window/tabpage.cxx |5 -
2 files changed, 7 deletions(-)
New commits:
commit bc5b764c7c77e992d4d3df045c008f8cabc6a237
Author: Samuel Mehrbrodt
AuthorDate: Tue Nov 24 08:59:11 2020 +0100
Commit: Thorsten Behrens
CommitDate: Tue Nov 24 21:17:48 2020 +0100
Remove unused ScrollBarBox from tabpage
This displays an empty rectangle at the upper left of the tabpage.
Change-Id: I8424a3f8ec4896814b135aa2c86012f0b33ee1be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106480
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
(cherry picked from commit 6df0e538ff05b98e1123c5ad1d77f554007bff12)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106440
Reviewed-by: Thorsten Behrens
diff --git a/include/vcl/tabpage.hxx b/include/vcl/tabpage.hxx
index 1a66bab9eabd..45d1c1220d60 100644
--- a/include/vcl/tabpage.hxx
+++ b/include/vcl/tabpage.hxx
@@ -25,7 +25,6 @@
#include
class ScrollBar;
-class ScrollBarBox;
class VCL_DLLPUBLIC TabPage
: public vcl::Window
@@ -40,7 +39,6 @@ private:
VclPtrm_pVScroll;
VclPtrm_pHScroll;
-VclPtr m_aScrollBarBox;
Size maScrollArea;
bool mbHasHoriBar;
bool mbHasVertBar;
diff --git a/vcl/source/window/tabpage.cxx b/vcl/source/window/tabpage.cxx
index 0ee256425709..f3acc5998ec3 100644
--- a/vcl/source/window/tabpage.cxx
+++ b/vcl/source/window/tabpage.cxx
@@ -57,10 +57,6 @@ void TabPage::ImplInit( vcl::Window* pParent, WinBits nStyle
)
if ( mbHasHoriBar || mbHasVertBar )
{
-m_aScrollBarBox.set(
-VclPtr::Create(this,
- ((nStyle & (WB_VSCROLL|WB_HSCROLL)) ?
WB_HIDE : 0)));
-m_aScrollBarBox->Show();
SetStyle( GetStyle() | WB_CLIPCHILDREN );
}
@@ -113,7 +109,6 @@ void TabPage::dispose()
{
m_pVScroll.disposeAndClear();
m_pHScroll.disposeAndClear();
-m_aScrollBarBox.disposeAndClear();
vcl::Window::dispose();
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 49177] Add color gradient for FORMATTING cell background
https://bugs.documentfoundation.org/show_bug.cgi?id=49177 Ming Hua changed: What|Removed |Added CC||decepticce...@gmail.com --- Comment #8 from Ming Hua --- *** Bug 138469 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138469] Background patterns and gradients for Calc cells
https://bugs.documentfoundation.org/show_bug.cgi?id=138469 Ming Hua changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||ming.v@qq.com --- Comment #1 from Ming Hua --- While bug 49177 only mentions gradient, I'm still marking this as a DUPLICATE. You can add the request for patterns as cell background there. *** This bug has been marked as a duplicate of bug 49177 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sw/source
sw/source/uibase/shells/drwbassh.cxx |7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
New commits:
commit 7c21121f7caa8667d86fc1946ef2a337c5b15da9
Author: Attila Bakos (NISZ)
AuthorDate: Tue Nov 3 15:05:00 2020 +0100
Commit: Xisco Fauli
CommitDate: Tue Nov 24 21:10:03 2020 +0100
tdf#137546 sw: fix text position at textbox alignment
Follow-up of commit 06fd06597796d9e92117602245f3968c93707708
(tdf#124430 Writer Editing: Fix textbox aligning).
Testing:
1. Insert a shape. Choose menu item "Add Text Box" of
its local menu, and write a short text in it.
2. Choose menu item "Align->Right" of the local menu of
the shape. The textbox is aligned to the right margin
and before the fix, text position had changed slightly
within the shape. (Only moving the textbox fixed it.)
Change-Id: I758e0f65c8b51e09ac15a96e19819cb3ad3beacb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105253
Tested-by: László Németh
Reviewed-by: László Németh
(cherry picked from commit 3347d71b23595919e167bd49932675e77cbbdbbb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106449
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sw/source/uibase/shells/drwbassh.cxx
b/sw/source/uibase/shells/drwbassh.cxx
index 65f95858a480..f901f32cc15d 100644
--- a/sw/source/uibase/shells/drwbassh.cxx
+++ b/sw/source/uibase/shells/drwbassh.cxx
@@ -443,7 +443,8 @@ void SwDrawBaseShell::Execute(SfxRequest const )
if ( bAlignPossible )
{
const SdrMarkList& rMarkList = pSdrView->GetMarkedObjectList();
-if ( rMarkList.GetMarkCount() == 1 )
+if (rMarkList.GetMarkCount() == 1
+&&
!SwTextBoxHelper::hasTextFrame(rMarkList.GetMark(0)->GetMarkedSdrObj()))
{
sal_Int16 nHorizOrient = -1, nVertOrient = -1;
@@ -479,8 +480,6 @@ void SwDrawBaseShell::Execute(SfxRequest const )
SwFormatHoriOrient
aHOrient(pFrameFormat->GetFormatAttr(RES_HORI_ORIENT));
aHOrient.SetHoriOrient( nHorizOrient );
pFrameFormat->SetFormatAttr(aHOrient);
-if (auto pTxFrm =
SwTextBoxHelper::getOtherTextBoxFormat(pFrameFormat, RES_DRAWFRMFMT))
-pTxFrm->SetFormatAttr(aHOrient);
pSh->EndAction();
}
@@ -492,8 +491,6 @@ void SwDrawBaseShell::Execute(SfxRequest const )
SwFormatVertOrient
aVOrient(pFrameFormat->GetFormatAttr(RES_VERT_ORIENT));
aVOrient.SetVertOrient( nVertOrient );
pFrameFormat->SetFormatAttr(aVOrient);
-if (auto pTxFrm =
SwTextBoxHelper::getOtherTextBoxFormat(pFrameFormat, RES_DRAWFRMFMT))
-pTxFrm->SetFormatAttr(aVOrient);
pSh->EndAction();
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 138458] Help section does not contain info about the "Save preview image" checkbox in "File > Properties" dialog, "General" tab
https://bugs.documentfoundation.org/show_bug.cgi?id=138458 --- Comment #4 from Tommer tchernov --- Thank you , let me know what are the results -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106040] [META] Help bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106040 Ming Hua changed: What|Removed |Added Depends on||138458 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=138458 [Bug 138458] Help section does not contain info about the "Save preview image" checkbox in "File > Properties" dialog, "General" tab -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138458] Help section does not contain info about the "Save preview image" checkbox in "File > Properties" dialog, "General" tab
https://bugs.documentfoundation.org/show_bug.cgi?id=138458 Ming Hua changed: What|Removed |Added Summary|The help section does not |Help section does not |contain info about the |contain info about the |"Save preview image"|"Save preview image" |checkbox in the "General" |checkbox in "File > |tab.|Properties" dialog, ||"General" tab Status|NEEDINFO|NEW Blocks||106040 --- Comment #3 from Ming Hua --- (In reply to Tommer tchernov from comment #2) > My apologies for the troubles > , its in the "Properties" menu on the left side, thanks for your help Thanks for the quick reply. Now I'm able to find the help page you are referring to, and can confirm this bug still exists for 7.1 (a new heading was added, but still no explanation): https://help.libreoffice.org/7.1/en-US/text/shared/01/01100200.html Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106040 [Bug 106040] [META] Help bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138458] The help section does not contain info about the "Save preview image" checkbox in the "General" tab.
https://bugs.documentfoundation.org/show_bug.cgi?id=138458 --- Comment #2 from Tommer tchernov --- My apologies for the troubles , its in the "Properties" menu on the left side, thanks for your help -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138465] FILEOPEN DOCX Formula appears squashed until touched
https://bugs.documentfoundation.org/show_bug.cgi?id=138465 Timur changed: What|Removed |Added Summary|FILEOPEN DOCX Formula |FILEOPEN DOCX Formula |appears squashed|appears squashed until ||touched Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138458] The help section does not contain info about the "Save preview image" checkbox in the "General" tab.
https://bugs.documentfoundation.org/show_bug.cgi?id=138458 Timur changed: What|Removed |Added Component|LibreOffice |Documentation CC||olivier.hallot@libreoffice. ||org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138469] New: Background patterns and gradients for Calc cells
https://bugs.documentfoundation.org/show_bug.cgi?id=138469 Bug ID: 138469 Summary: Background patterns and gradients for Calc cells Product: LibreOffice Version: 6.4.6.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: decepticce...@gmail.com Description: Unlike LibreOffice Calc, Microsoft Office Excel gives you the ability to apply patterns and gradients in the "Format Cells" dialogue box right before the "Cell Protection" page Steps to Reproduce: Right click on any document cell and select "Format Cells" Actual Results: The second last tab "Background" only allows for the customization of cell colors Expected Results: The second last tab "Background" would have customization options for patterns and gradients on Excel Reproducible: Always User Profile Reset: No Additional Info: Version: 6.4.6.2 Build ID: 1:6.4.6-0ubuntu0.20.04.1 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33041] Allow page background to cover the whole page, not only within page borders/margins (workaround in comment 33)
https://bugs.documentfoundation.org/show_bug.cgi?id=33041 Mike Kaganski changed: What|Removed |Added CC||nem...@numbertext.org --- Comment #55 from Mike Kaganski --- (In reply to Timur from comment #54) László Németh had implemented the change for tdf#112195 - https://git.libreoffice.org/core/+/f006b6339e20af6a3fbd60d97d21590d4ebf5021 - and then it was reported in release notes for this bug: https://wiki.documentfoundation.org/ReleaseNotes/6.3#Writer. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134133] Go back in presenting mode leads to dropped animation steps
https://bugs.documentfoundation.org/show_bug.cgi?id=134133 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=77 ||275 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77275] SLIDESHOW: Cannot go to previous page with left arrow or PageUp
https://bugs.documentfoundation.org/show_bug.cgi?id=77275 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||4133 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138058] Crashed when I try to create a Table with the Wizard or when I click on the 'Queries' tab of a new HSQLDB file
https://bugs.documentfoundation.org/show_bug.cgi?id=138058 --- Comment #2 from Tom Tiger --- Same with me, Libre Office 7 chrashes whenever it has to use java. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103304] [META] Page style dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103304 Bug 103304 depends on bug 33041, which changed state. Bug 33041 Summary: Allow page background to cover the whole page, not only within page borders/margins (workaround in comment 33) https://bugs.documentfoundation.org/show_bug.cgi?id=33041 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94722] [META] Object fill bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=94722 Bug 94722 depends on bug 33041, which changed state. Bug 33041 Summary: Allow page background to cover the whole page, not only within page borders/margins (workaround in comment 33) https://bugs.documentfoundation.org/show_bug.cgi?id=33041 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33041] Allow page background to cover the whole page, not only within page borders/margins (workaround in comment 33)
https://bugs.documentfoundation.org/show_bug.cgi?id=33041 Timur changed: What|Removed |Added Resolution|FIXED |--- Summary|Allow page background to|Allow page background to |cover the whole page, not |cover the whole page, not |only within page|only within page |borders/margins |borders/margins (workaround ||in comment 33) Status|RESOLVED|REOPENED --- Comment #54 from Timur --- Sorry, but I open again. Surely this is not status Fixed, because Fixed means specific commit,so it was more appropriate for WFM. But from comments it more looks like there is a workaround and not real solution. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/cib_contract3753' - 4 commits - external/liblangtag offapi/com offapi/UnoApi_offapi.mk sw/inc sw/qa sw/source
external/liblangtag/UnpackedTarball_liblangtag.mk |3 external/liblangtag/Wformat-overflow.patch | 17 offapi/UnoApi_offapi.mk|1 offapi/com/sun/star/datatransfer/XTransferableTextSupplier.idl | 44 + sw/inc/unoparagraph.hxx|6 sw/inc/unotextrange.hxx| 16 sw/qa/extras/unowriter/data/bookmarkintable.fodt | 82 +++ sw/qa/extras/unowriter/data/tdf134250.fodt | 86 +++ sw/qa/extras/unowriter/data/tdf134252.fodt | 95 sw/qa/extras/unowriter/unowriter.cxx | 149 ++ sw/source/core/unocore/unoobj.cxx |7 sw/source/core/unocore/unoobj2.cxx | 225 -- sw/source/core/unocore/unosect.cxx | 25 + sw/source/core/unocore/unotbl.cxx |6 sw/source/uibase/dochdl/swdtflvr.cxx | 91 +++- sw/source/uibase/inc/swdtflvr.hxx |2 sw/source/uibase/inc/unotxvw.hxx |5 sw/source/uibase/uno/unotxvw.cxx | 29 + 18 files changed, 820 insertions(+), 69 deletions(-) New commits: commit 592367ac711d9bf9fbd2ba4ecc41cb49da7a44ec Author: Michael Stahl AuthorDate: Tue Nov 24 15:33:44 2020 +0100 Commit: Michael Stahl CommitDate: Tue Nov 24 20:12:29 2020 +0100 sw: fix SwXTextRange::createEnumeration() inside table cell This would set CursorType::SelectionInTable but leave m_pOwnTable and m_pOwnStartNode uninitialised, causing sw/source/core/unocore/unoobj2.cxx:399: SwXParagraphEnumeration: table type but no start node or table and then the enumeration would return the table it's in as the first element, which is quite annoying. Refactor the creation of SwXParagraphEnumeration to prevent this. Change-Id: I4e9e3456bdf66b9822d19ad985a20b094e6bbba4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106532 Tested-by: Jenkins Reviewed-by: Michael Stahl (cherry picked from commit ecc3c621fe5a7e962f0e40cb3709ad5772a5d744) diff --git a/sw/inc/unoparagraph.hxx b/sw/inc/unoparagraph.hxx index 64a8defd83fc..eb89ce47249e 100644 --- a/sw/inc/unoparagraph.hxx +++ b/sw/inc/unoparagraph.hxx @@ -43,7 +43,7 @@ class SwPaM; class SwUnoCursor; class SwStartNode; class SwTextNode; -class SwTable; +class SwTableBox; class SwXText; typedef ::cppu::ImplInheritanceHelper @@ -216,8 +216,8 @@ struct SwXParagraphEnumeration css::uno::Reference< css::text::XText > const & xParent, const std::shared_ptr& pCursor, const CursorType eType, -SwStartNode const*const pStartNode = nullptr, -SwTable const*const pTable = nullptr); +/// only for CursorType::TableText +SwTableBox const*const pTableBox = nullptr); }; #endif // INCLUDED_SW_INC_UNOPARAGRAPH_HXX diff --git a/sw/qa/extras/unowriter/data/bookmarkintable.fodt b/sw/qa/extras/unowriter/data/bookmarkintable.fodt new file mode 100644 index ..641200fef93e --- /dev/null +++ b/sw/qa/extras/unowriter/data/bookmarkintable.fodt @@ -0,0 +1,82 @@ + +http://openoffice.org/2009/office; xmlns:css3t="http://www.w3.org/TR/css3-text/; xmlns:grddl="http://www.w3.org/2003/g/data-view#; xmlns:xhtml="http://www.w3.org/1999/xhtml; xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xmlns:xsd="http://www.w3.org/2001/XMLSchema; xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0" xmlns:oooc="http://openoffice.org/2004/calc; xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0" xmlns:ooow="http://openoffice.org/2004/writer; xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:rpt="http://openoffice.org/2005/report; xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0" xmlns:config="urn:oasis:names:tc:opendocument:xmlns :config:1.0" xmlns:xlink="http://www.w3.org/1999/xlink; xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" xmlns:ooo="http://openoffice.org/2004/office; xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0" xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0" xmlns:tableooo="http://openoffice.org/2009/table;
[Libreoffice-bugs] [Bug 138462] Adding bullet/footnote/endnote/page number in Bengali language
https://bugs.documentfoundation.org/show_bug.cgi?id=138462 Ming Hua changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||4622 CC||ming.v@qq.com --- Comment #2 from Ming Hua --- If the Bengali numbers are already supported as an LO NatNumX series for the corresponding locale (I didn't check and don't even know exactly how to check), the code change needed for this seems minimal, see bug 114622 for a similar effort. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138446] Inline objects still disapearing from screen in some positions
https://bugs.documentfoundation.org/show_bug.cgi?id=138446 Timur changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #3 from Timur --- Main requirement of bug report is to have reproducible steps. Please try to find them or this cannot be confirmed. Since this bug is marked Writer, I guess you use anchor as character for inlime images. Could be that your problem is already reported, even if not with objects, you may search to find. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138446] Inline objects still disapearing from screen in some positions
https://bugs.documentfoundation.org/show_bug.cgi?id=138446 --- Comment #2 from Timur --- Writing again from report: Description: This bug exists as long as I know LibreOffice - 2 year at least File that reproduce bug attached in "Other information" Steps to Reproduce: 1.Write inline equation 2.Try to write some before it to move it to page end until it disapear - difficult to reproduce, may be need some paragraph style change Actual Results: Inline equation disapearing from page and shows again when it position chainges relating to page buy text editing Expected Results: Equation (and inline pictures) must not disapear Reproducible: Sometimes User Profile Reset: No OpenGL enabled: Yes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/qa sw/source
sw/inc/unoparagraph.hxx |6 - sw/qa/extras/unowriter/data/bookmarkintable.fodt | 82 +++ sw/qa/extras/unowriter/unowriter.cxx | 27 +++ sw/source/core/unocore/unoobj.cxx|7 - sw/source/core/unocore/unoobj2.cxx | 32 +++- sw/source/core/unocore/unotbl.cxx|3 6 files changed, 140 insertions(+), 17 deletions(-) New commits: commit ecc3c621fe5a7e962f0e40cb3709ad5772a5d744 Author: Michael Stahl AuthorDate: Tue Nov 24 15:33:44 2020 +0100 Commit: Michael Stahl CommitDate: Tue Nov 24 19:54:36 2020 +0100 sw: fix SwXTextRange::createEnumeration() inside table cell This would set CursorType::SelectionInTable but leave m_pOwnTable and m_pOwnStartNode uninitialised, causing sw/source/core/unocore/unoobj2.cxx:399: SwXParagraphEnumeration: table type but no start node or table and then the enumeration would return the table it's in as the first element, which is quite annoying. Refactor the creation of SwXParagraphEnumeration to prevent this. Change-Id: I4e9e3456bdf66b9822d19ad985a20b094e6bbba4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106532 Tested-by: Jenkins Reviewed-by: Michael Stahl diff --git a/sw/inc/unoparagraph.hxx b/sw/inc/unoparagraph.hxx index 64a8defd83fc..eb89ce47249e 100644 --- a/sw/inc/unoparagraph.hxx +++ b/sw/inc/unoparagraph.hxx @@ -43,7 +43,7 @@ class SwPaM; class SwUnoCursor; class SwStartNode; class SwTextNode; -class SwTable; +class SwTableBox; class SwXText; typedef ::cppu::ImplInheritanceHelper @@ -216,8 +216,8 @@ struct SwXParagraphEnumeration css::uno::Reference< css::text::XText > const & xParent, const std::shared_ptr& pCursor, const CursorType eType, -SwStartNode const*const pStartNode = nullptr, -SwTable const*const pTable = nullptr); +/// only for CursorType::TableText +SwTableBox const*const pTableBox = nullptr); }; #endif // INCLUDED_SW_INC_UNOPARAGRAPH_HXX diff --git a/sw/qa/extras/unowriter/data/bookmarkintable.fodt b/sw/qa/extras/unowriter/data/bookmarkintable.fodt new file mode 100644 index ..641200fef93e --- /dev/null +++ b/sw/qa/extras/unowriter/data/bookmarkintable.fodt @@ -0,0 +1,82 @@ + +http://openoffice.org/2009/office; xmlns:css3t="http://www.w3.org/TR/css3-text/; xmlns:grddl="http://www.w3.org/2003/g/data-view#; xmlns:xhtml="http://www.w3.org/1999/xhtml; xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xmlns:xsd="http://www.w3.org/2001/XMLSchema; xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0" xmlns:oooc="http://openoffice.org/2004/calc; xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0" xmlns:ooow="http://openoffice.org/2004/writer; xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:rpt="http://openoffice.org/2005/report; xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0" xmlns:config="urn:oasis:names:tc:opendocument:xmlns :config:1.0" xmlns:xlink="http://www.w3.org/1999/xlink; xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" xmlns:ooo="http://openoffice.org/2004/office; xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0" xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0" xmlns:tableooo="http://openoffice.org/2009/table; xmlns:drawooo="http://openoffice.org/2010/draw; xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0" xmlns:dom="http://www.w3.org/2001/xml-events; xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" xmlns:math="http://www.w3.org/1998/Math/MathML; xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:script="ur n:oasis:names:tc:opendocument:xmlns:script:1.0" xmlns:xforms="http://www.w3.org/2002/xforms; office:version="1.3" office:mimetype="application/vnd.oasis.opendocument.text"> + 2020-11-24T13:16:34.2483766402020-11-24T14:47:04.359492742PT2M22S2LibreOfficeDev/7.1.0.0.alpha1$Linux_X86_64 LibreOffice_project/a871df849fad8f923db945cf0606f30603380ef7 + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
[Libreoffice-bugs] [Bug 138458] The help section does not contain info about the "Save preview image" checkbox in the "General" tab.
https://bugs.documentfoundation.org/show_bug.cgi?id=138458 Ming Hua changed: What|Removed |Added CC||ming.v@qq.com Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Ming Hua --- (In reply to Tommer tchernov from comment #0) > Steps to Reproduce: > 1.Open the "General" tab ow writter. When Writer is opened with the default user interface, there is no "General" tab. There are many dialogs that can be invoked from Writer, many of which have a "General" tab. I can't easily guess which one you are referring to. > 2.Press the "Help" button > 3.Look in the help section in the online page that opens up. Would you please be more specific about your steps? Which menu items or toolbar buttons did you click? Or which keyboard shortcut did you press? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137480] Severe screen flickering and misplaced cursor visual while editing with dual window on dual screen
https://bugs.documentfoundation.org/show_bug.cgi?id=137480 srd...@email.cz changed: What|Removed |Added CC||srd...@email.cz Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Severity|normal |minor --- Comment #2 from srd...@email.cz --- Hello Dominique, Thank you for reporting the bug. I can confirm that the bug is present in master. Version: 7.1.0.0.alpha1+ (x64) Build ID: 418c63dff5db2005bbc4dbfc92b56778f89cea8b CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: cs-CZ (cs_CZ); UI: en-GB Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137925] UI: Preferred user interface: the arrangement of options
https://bugs.documentfoundation.org/show_bug.cgi?id=137925 Rizal Muttaqin changed: What|Removed |Added CC||riz...@libreoffice.org --- Comment #6 from Rizal Muttaqin --- +1 for this request There's chance people are not having familiarity with "Tabbed" naming and with this arrangement more developers hopefully come to enhance this still "second class citizen" user interface. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
