[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/uiwriter/uiwriter2.cxx | 33 +++
sw/source/core/undo/unredln.cxx | 50
2 files changed, 67 insertions(+), 16 deletions(-)
New commits:
commit 586bd08fa2655ad90ef4777626ad8f17d6a2c4ce
Author: László Németh
AuthorDate: Wed Nov 25 18:06:54 2020 +0100
Commit: László Németh
CommitDate: Thu Nov 26 08:54:50 2020 +0100
tdf#137503 sw ChangesInMargin: fix Undo/Redo of deleted paragraph
Tracked deletion of paragraph(s) consists of several hidden
redlines in "Show changes in margin" mode. Fix Undo by setting
them all visible with recovering the original deletion range.
Follow-up of commit 469f472fb31c4ef1a57f8ec54ba750c1332feec2
(tdf#138479 tdf#137769 sw ChangesInMargin: fix Undo in paragraphs).
Change-Id: Ib92aa5055eaf3e0754a154a2c78172378f6e6f6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106608
Tested-by: László Németh
Reviewed-by: László Németh
diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index 28019c51df0b..4bbaeee20341 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -1924,6 +1924,39 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf137684)
CPPUNIT_ASSERT(!pWrtShell->GetViewOptions()->IsShowChangesInMargin());
}
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf137503)
+{
+load(DATA_DIRECTORY, "tdf132160.odt");
+
+SwXTextDocument* pTextDoc =
dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+
+// switch on "Show changes in margin" mode
+dispatchCommand(mxComponent, ".uno:ShowChangesInMargin", {});
+
+SwWrtShell* const pWrtShell = pTextDoc->GetDocShell()->GetWrtShell();
+CPPUNIT_ASSERT(pWrtShell->GetViewOptions()->IsShowChangesInMargin());
+
+// select and delete the first two paragraphs
+pWrtShell->EndPara(/*bSelect=*/true);
+pWrtShell->EndPara(/*bSelect=*/true);
+pWrtShell->Right(CRSR_SKIP_CHARS, /*bSelect=*/true, 1,
/*bBasicCall=*/false);
+dispatchCommand(mxComponent, ".uno:Delete", {});
+CPPUNIT_ASSERT(getParagraph(1)->getString().startsWith("The"));
+
+// this would crash due to bad redline range
+dispatchCommand(mxComponent, ".uno:Undo", {});
+CPPUNIT_ASSERT(getParagraph(1)->getString().startsWith("Encryption "));
+
+// this would crash due to bad redline range
+dispatchCommand(mxComponent, ".uno:Redo", {});
+CPPUNIT_ASSERT(getParagraph(1)->getString().startsWith("The"));
+
+// switch off "Show changes in margin" mode
+dispatchCommand(mxComponent, ".uno:ShowChangesInMargin", {});
+CPPUNIT_ASSERT(!pWrtShell->GetViewOptions()->IsShowChangesInMargin());
+}
+
CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf138135)
{
load(DATA_DIRECTORY, "tdf132160.odt");
diff --git a/sw/source/core/undo/unredln.cxx b/sw/source/core/undo/unredln.cxx
index d870935c6613..6865beba6cd6 100644
--- a/sw/source/core/undo/unredln.cxx
+++ b/sw/source/core/undo/unredln.cxx
@@ -93,28 +93,46 @@ void SwUndoRedline::UndoImpl(::sw::UndoRedoContext &
rContext)
// fix PaM for deletions shown in margin
bool bIsDeletion = dynamic_cast(this);
+sal_uInt32 nMaxId = SAL_MAX_UINT32;
if ( bIsDeletion )
{
-SwRedlineTable::size_type nCurRedlinePos = 0;
-const SwRedlineTable& rTable =
rDoc.getIDocumentRedlineAccess().GetRedlineTable();
-SwRangeRedline * pRedline(rTable[nCurRedlinePos]);
-// search last redline by its biggest id
-// TODO handle multiple nodes
-for( SwRedlineTable::size_type n = 1; n < rTable.size(); ++n )
+// Nodes of the deletion range are in the newest invisible redlines.
+// Set all redlines visible and recover the original deletion range.
+for (sal_uInt32 nNodes = 0; nNodes < m_nEndNode - m_nSttNode + 1; ++
nNodes)
{
-SwRangeRedline *pRed(rTable[n]);
-if ( pRedline->GetId() < pRed->GetId() )
+SwRedlineTable::size_type nCurRedlinePos = 0;
+const SwRedlineTable& rTable =
rDoc.getIDocumentRedlineAccess().GetRedlineTable();
+SwRangeRedline * pRedline(rTable[nCurRedlinePos]);
+
+// search last but nNodes redline by its nth biggest id
+for( SwRedlineTable::size_type n = 1; n < rTable.size(); ++n )
{
-nCurRedlinePos = n;
-pRedline = pRed;
+SwRangeRedline *pRed(rTable[n]);
+if ( pRedline->GetId() < pRed->GetId() && pRed->GetId() <
nMaxId )
+{
+nCurRedlinePos = n;
+pRedline = pRed;
+}
}
-}
-if ( !pRedline->IsVisible() )
-{
-pRedline->Show(0, rTable.GetPos(pRedline), /*bForced=*/true);
-pRedline->Show(1, rTable.GetPos(pRedline), /*bForced=*/true);
-rPam = *pRedline;
+nMaxId =
[Libreoffice-bugs] [Bug 137503] fix Undo/Redo of deletions of paragraphs in ShowChangesInMargin mode
https://bugs.documentfoundation.org/show_bug.cgi?id=137503 --- Comment #2 from Commit Notification --- László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/586bd08fa2655ad90ef4777626ad8f17d6a2c4ce tdf#137503 sw ChangesInMargin: fix Undo/Redo of deleted paragraph It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137503] fix Undo/Redo of deletions of paragraphs in ShowChangesInMargin mode
https://bugs.documentfoundation.org/show_bug.cgi?id=137503 Commit Notification changed: What|Removed |Added Whiteboard||target:7.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137770] [META] Tracked changes in margin
https://bugs.documentfoundation.org/show_bug.cgi?id=137770 Bug 137770 depends on bug 137503, which changed state. Bug 137503 Summary: fix Undo/Redo of deletions of paragraphs in ShowChangesInMargin mode https://bugs.documentfoundation.org/show_bug.cgi?id=137503 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137503] fix Undo/Redo of deletions of paragraphs in ShowChangesInMargin mode
https://bugs.documentfoundation.org/show_bug.cgi?id=137503 László Németh changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Assignee|nem...@numbertext.org |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl offapi/com sfx2/source vcl/osx vcl/source vcl/unx
include/vcl/print.hxx |3 +++
offapi/com/sun/star/view/PrintOptions.idl |4
sfx2/source/doc/printhelper.cxx |9 +
vcl/osx/salprn.cxx|7 +--
vcl/source/gdi/print3.cxx | 16
vcl/unx/generic/print/genprnpsp.cxx |8 +---
6 files changed, 26 insertions(+), 21 deletions(-)
New commits:
commit 2e2c162b7a816d990415fca434e6d3d5600b2858
Author: Samuel Mehrbrodt
AuthorDate: Wed Nov 25 16:22:11 2020 +0100
Commit: Samuel Mehrbrodt
CommitDate: Thu Nov 26 08:51:57 2020 +0100
Add 'SinglePrintJobs' to PrintOptions
So that this option can be set via UNO API
Change-Id: I0b69162661a4327d59aaed82d5eff98cb50d852c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106593
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
diff --git a/include/vcl/print.hxx b/include/vcl/print.hxx
index 6d3adf0e00d7..631b2f5b83fe 100644
--- a/include/vcl/print.hxx
+++ b/include/vcl/print.hxx
@@ -168,6 +168,7 @@ private:
boolmbPrintFile;
boolmbInPrintPage;
boolmbNewJobSetup;
+boolmbSinglePrintJobs;
VCL_DLLPRIVATE void ImplInitData();
VCL_DLLPRIVATE void ImplInit( SalPrinterQueueInfo* pInfo );
@@ -316,6 +317,8 @@ public:
voidSetCopyCount( sal_uInt16 nCopy, bool bCollate
);
sal_uInt16 GetCopyCount() const { return mnCopyCount; }
boolIsCollateCopy() const { return mbCollateCopy; }
+voidSetSinglePrintJobs(bool bSinglePrintJobs) {
mbSinglePrintJobs = bSinglePrintJobs; }
+boolIsSinglePrintJobs() const { return
mbSinglePrintJobs; }
boolIsPrinting() const { return mbPrinting; }
diff --git a/offapi/com/sun/star/view/PrintOptions.idl
b/offapi/com/sun/star/view/PrintOptions.idl
index eea96f98937e..4ed8b23baaf0 100644
--- a/offapi/com/sun/star/view/PrintOptions.idl
+++ b/offapi/com/sun/star/view/PrintOptions.idl
@@ -76,6 +76,10 @@ published service PrintOptions
/** if set, specifies name of the printer to use.
*/
[optional, property] string PrinterName;
+
+/** advises the printer to create a single print job for each copy.
+ */
+[optional, property] boolean SinglePrintJobs;
};
diff --git a/sfx2/source/doc/printhelper.cxx b/sfx2/source/doc/printhelper.cxx
index e0c2cc75ad77..e2ce74172288 100644
--- a/sfx2/source/doc/printhelper.cxx
+++ b/sfx2/source/doc/printhelper.cxx
@@ -696,6 +696,15 @@ void SAL_CALL SfxPrintHelper::print(const uno::Sequence<
beans::PropertyValue >&
aCheckedArgs[nProps++].Value <<= bTemp;
}
+else if ( rProp.Name == "SinglePrintJobs" )
+{
+bool bTemp;
+if ( !(rProp.Value >>= bTemp) )
+throw css::lang::IllegalArgumentException();
+aCheckedArgs[nProps].Name = "SinglePrintJobs";
+aCheckedArgs[nProps++].Value <<= bTemp;
+}
+
// Pages-Property
else if ( rProp.Name == "Pages" )
{
diff --git a/vcl/osx/salprn.cxx b/vcl/osx/salprn.cxx
index 6fd92fd4c5d6..bec30a35b562 100644
--- a/vcl/osx/salprn.cxx
+++ b/vcl/osx/salprn.cxx
@@ -380,12 +380,7 @@ bool AquaSalInfoPrinter::StartJob( const OUString*
i_pFileName,
bShowProgressPanel = false;
// possibly create one job for collated output
-bool bSinglePrintJobs = false;
-beans::PropertyValue* pSingleValue = i_rController.getValue( OUString(
"PrintCollateAsSingleJobs" ) );
-if( pSingleValue )
-{
-pSingleValue->Value >>= bSinglePrintJobs;
-}
+bool bSinglePrintJobs = i_rController.getPrinter()->IsSinglePrintJobs();
// FIXME: jobStarted() should be done after the print dialog has ended (if
there is one)
// how do I know when that might be ?
diff --git a/vcl/source/gdi/print3.cxx b/vcl/source/gdi/print3.cxx
index 04ac1f5a92e6..1cc0ce8c1c93 100644
--- a/vcl/source/gdi/print3.cxx
+++ b/vcl/source/gdi/print3.cxx
@@ -509,8 +509,7 @@ bool
Printer::PreparePrintJob(std::shared_ptr xController,
}
else if (aDlg.isSingleJobs())
{
-xController->setValue( "PrintCollateAsSingleJobs",
-css::uno::makeAny( true ) );
+xController->getPrinter()->SetSinglePrintJobs(true);
}
}
catch (const std::bad_alloc&)
@@ -585,12 +584,7 @@ bool Printer::StartJob( const OUString& i_rJobName,
std::shared_ptrgetValue("PrintCollateAsSingleJobs");
-if( pSingleValue )
-{
-pSingleValue->Value >>= bSinglePrintJobs;
-}
+bool bSinglePrintJobs = i_xController->getPrinter()->IsSinglePrintJobs();
css::beans::PropertyValue* pFileValue =
[Libreoffice-bugs] [Bug 137770] [META] Tracked changes in margin
https://bugs.documentfoundation.org/show_bug.cgi?id=137770 Bug 137770 depends on bug 138479, which changed state. Bug 138479 Summary: ChangesInMargin: fix Undo of embedded deletions (in paragraph level) https://bugs.documentfoundation.org/show_bug.cgi?id=138479 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138479] ChangesInMargin: fix Undo of embedded deletions (in paragraph level)
https://bugs.documentfoundation.org/show_bug.cgi?id=138479 László Németh changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Assignee|nem...@numbertext.org |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/qa sw/source
sw/inc/docary.hxx |5 -
sw/qa/extras/uiwriter/uiwriter2.cxx | 67 ++--
sw/source/core/doc/DocumentContentOperationsManager.cxx | 21 -
sw/source/core/doc/docredln.cxx | 10 --
sw/source/core/undo/unredln.cxx | 48 +--
5 files changed, 85 insertions(+), 66 deletions(-)
New commits:
commit 469f472fb31c4ef1a57f8ec54ba750c1332feec2
Author: László Németh
AuthorDate: Wed Nov 25 10:55:13 2020 +0100
Commit: László Németh
CommitDate: Thu Nov 26 08:32:30 2020 +0100
tdf#138479 tdf#137769 sw ChangesInMargin: fix Undo in paragraphs
Fix Undo of embedded tracked deletions in paragraphs, for example
Undo of deletions Lorem->Loem->Lm resulted only Loem, moreover
a crash in the case of typing (not tracked) text before the
tracked deletions.
Now the last tracked deletion is chosen by the biggest
SwRangeRedline ID during Undo instead of the lost/modified
redline range in case of hidden redlines of the ChangesInMargin
mode.
Note: revert commit 4ad0459494303745b377c848c681a747f294fc64
(tdf#138135: sw ChangesInMargin: join characters at backspac) to
avoid crash on extra Undo (tdf#137769). Showing deleted
character sequence in margin needs grouping of hidden redlines,
as for managing tracked changes.
Change-Id: Ia9dab5cbbc08f39e05ff8e499efff37bc825c624
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106582
Tested-by: László Németh
Reviewed-by: László Németh
diff --git a/sw/inc/docary.hxx b/sw/inc/docary.hxx
index 4a3e2031420e..9b4a6e80ea26 100644
--- a/sw/inc/docary.hxx
+++ b/sw/inc/docary.hxx
@@ -259,11 +259,8 @@ public:
@param tableIndex position in SwRedlineTable to start searching at, will
be updated with the index of the returned
redline (or the next redline after the given position
if not found)
@param next true: redline starts at position and ends after, false:
redline starts before position and ends at or after
- @param visibletrue: redline must be visible false: redline must be
not visible
*/
-const SwRangeRedline* FindAtPosition( const SwPosition& startPosition,
- size_type& tableIndex,
- bool next = true, bool visible =
true ) const;
+const SwRangeRedline* FindAtPosition( const SwPosition& startPosition,
size_type& tableIndex, bool next = true ) const;
boolempty() const { return maVector.empty(); }
size_type size() const { return maVector.size(); }
diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index 48a6aa3fdc99..28019c51df0b 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -1946,11 +1946,9 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf138135)
}
CPPUNIT_ASSERT(getParagraph(1)->getString().startsWith("support"));
-// single Undo undoes the deletion of the whole word
-//
-// This was only a 1-character Undo because of missing
-// joining of the deleted characters
-dispatchCommand(mxComponent, ".uno:Undo", {});
+// TODO group redlines for managing tracked changes/showing in margin
+for (int i = 0; i <= 10; ++i)
+dispatchCommand(mxComponent, ".uno:Undo", {});
CPPUNIT_ASSERT(getParagraph(1)->getString().startsWith("Encryption"));
@@ -2008,10 +2006,13 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf137771)
assertXPath(pXmlDoc, "/metafile/push/push/push/line", 13);
// This was the content of the next (missing deletion on margin)
-assertXPathContent(pXmlDoc, "/metafile/push/push/push/textarray[16]/text",
" saved.");
+assertXPathContent(pXmlDoc, "/metafile/push/push/push/textarray[16]/text",
" s");
// this would crash due to bad redline range
-dispatchCommand(mxComponent, ".uno:Undo", {});
+for (int i = 0; i < 6; ++i)
+{
+dispatchCommand(mxComponent, ".uno:Undo", {});
+}
CPPUNIT_ASSERT(getParagraph(1)->getString().endsWith("to be saved."));
// switch off "Show changes in margin" mode
@@ -2019,6 +2020,58 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf137771)
CPPUNIT_ASSERT(!pWrtShell->GetViewOptions()->IsShowChangesInMargin());
}
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf138479)
+{
+SwDoc* const pDoc = createDoc();
+
+SwXTextDocument* pTextDoc =
dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+
+SwWrtShell* const pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+
+pWrtShell->Insert("Lorem");
+CPPUNIT_ASSERT_EQUAL(OUString("Lorem"), getParagraph(1)->getString());
+
+//turn on red-lining and show changes
+pDoc->getIDocumentRedlineAccess().SetRedlineFlags(RedlineFlags::On |
RedlineFlags::ShowDelete
+
[Libreoffice-bugs] [Bug 137770] [META] Tracked changes in margin
https://bugs.documentfoundation.org/show_bug.cgi?id=137770 Bug 137770 depends on bug 137769, which changed state. Bug 137769 Summary: ChangesInMargin: Crash on Undo of characters deleted by pressing Delete ( part 2 ) https://bugs.documentfoundation.org/show_bug.cgi?id=137769 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137769] ChangesInMargin: Crash on Undo of characters deleted by pressing Delete ( part 2 )
https://bugs.documentfoundation.org/show_bug.cgi?id=137769 --- Comment #3 from Commit Notification --- László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/469f472fb31c4ef1a57f8ec54ba750c1332feec2 tdf#138479 tdf#137769 sw ChangesInMargin: fix Undo in paragraphs It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137769] ChangesInMargin: Crash on Undo of characters deleted by pressing Delete ( part 2 )
https://bugs.documentfoundation.org/show_bug.cgi?id=137769 Commit Notification changed: What|Removed |Added Whiteboard||target:7.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137769] ChangesInMargin: Crash on Undo of characters deleted by pressing Delete ( part 2 )
https://bugs.documentfoundation.org/show_bug.cgi?id=137769 László Németh changed: What|Removed |Added Resolution|--- |FIXED Assignee|nem...@numbertext.org |libreoffice-b...@lists.free ||desktop.org Status|ASSIGNED|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134628] Rename "Ignore system input language" in language options
https://bugs.documentfoundation.org/show_bug.cgi?id=134628 --- Comment #11 from Mike Kaganski --- For the context (this partially repeats some bits from attachment 162773, and also adds some missing parts). The option to *take the system input language into account* had been introduced in 2001 in https://bz.apache.org/ooo/show_bug.cgi?id=1035. It had received requests then to make it optional, e.g. its comm. 6, and in https://bz.apache.org/ooo/show_bug.cgi?id=100762. Our bug 36324 had introduced the UI option to disable the feature, but not the discussed functionality. The option had been implemented initially for Writer, and for Windows (OOo bug had even a comment telling "on Unix I see no chance"). However, lately Jan-Marek had committed https://git.libreoffice.org/core/+/9d96088c2832b681ae079b29cbc977231674ad52, with support for Qt5 (so it is expected that v.7.2 will *partially* support it on Linux). The "See Also" bug tdf#108151 covers the missing OS support bits, and bugs tdf#34142 and tdf#127898 - the missing component support bits. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138276] Cannot open report for printing - missing JVM error message
https://bugs.documentfoundation.org/show_bug.cgi?id=138276 Alex Thurgood changed: What|Removed |Added Summary|Cannot open report for |Cannot open report for |printing|printing - missing JVM ||error message -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138276] Cannot open report for printing
https://bugs.documentfoundation.org/show_bug.cgi?id=138276 --- Comment #3 from Alex Thurgood --- @LFBailey : Opening and editing reports in LO on Mac requires the presence of a Java virtual machine environment. Usually, this means that you have to install a JDK. Without a JDK, any Base functionality requiring a JVM won't work. This includes, inter alia : - the default embedded hsqldb database engine ; - any JDBC driver access to other database engines ; - the report writer generator (which is written in Java, with a C++ interface from within LO to create a corresponding XML definition) ; - any LO extensions, such as some typographical and grammar correctors, that require Java, in order to either be installed, or even function. Apple macOS doesn't provide a JVM by default, so it is up to the user to install one. If you have installed a JDK/JVM, please specify which one. If you are using LO Vanilla by Collabora, instead of LO distributed through TDF from the LO website, then you are out of luck, as LO Vanilla deliberately does not include any access to JDK/JVM functionality. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134133] Go back in presenting mode leads to dropped animation steps
https://bugs.documentfoundation.org/show_bug.cgi?id=134133 --- Comment #9 from Pierre C --- 6.4.4.1 is the first buggy version of 6.4 branch So It works with LO 6.4.3.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/fmtcol.hxx| 15 ++-
sw/inc/ndtxt.hxx | 12
sw/inc/paratr.hxx| 25 +++--
sw/source/core/attr/swatrset.cxx | 15 ---
sw/source/core/para/paratr.cxx | 17 -
sw/source/core/undo/rolbck.cxx |4 ++--
6 files changed, 47 insertions(+), 41 deletions(-)
New commits:
commit 089bb2f3bd2b5fc8118caaa6b7c6b82dd36a094e
Author: Bjoern Michaelsen
AuthorDate: Sun Nov 22 21:15:13 2020 +0100
Commit: Bjoern Michaelsen
CommitDate: Thu Nov 26 08:25:14 2020 +0100
Refactor SwFormatDrop
... and get rid of the SwClientNotifyCall.
Change-Id: I2118290944c21e9773c359109e60e7778459a41f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106365
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen
diff --git a/sw/inc/fmtcol.hxx b/sw/inc/fmtcol.hxx
index 20b5409f21e0..07f157f13bf2 100644
--- a/sw/inc/fmtcol.hxx
+++ b/sw/inc/fmtcol.hxx
@@ -22,6 +22,7 @@
#include "swdllapi.h"
#include "format.hxx"
#include "hintids.hxx"
+#include "paratr.hxx"
#include
#include
@@ -31,7 +32,7 @@
class SwAttrPool;
namespace sw{ class DocumentStylePoolManager; }
-class SAL_DLLPUBLIC_RTTI SwFormatColl : public SwFormat
+class SAL_DLLPUBLIC_RTTI SwFormatColl: public SwFormat
{
protected:
SwFormatColl( SwAttrPool& rPool, const char* pFormatName,
@@ -52,7 +53,9 @@ private:
};
/// Represents the style of a paragraph.
-class SW_DLLPUBLIC SwTextFormatColl: public SwFormatColl
+class SW_DLLPUBLIC SwTextFormatColl
+: public SwFormatColl
+, public sw::FormatDropDefiner
{
friend class SwDoc;
friend class ::sw::DocumentStylePoolManager;
@@ -66,7 +69,6 @@ class SW_DLLPUBLIC SwTextFormatColl: public SwFormatColl
SwTextFormatColl *mpNextTextFormatColl;
protected:
-
SwTextFormatColl( SwAttrPool& rPool, const char* pFormatCollName,
SwTextFormatColl* pDerFrom = nullptr,
sal_uInt16 nFormatWh = RES_TXTFMTCOLL )
@@ -91,8 +93,6 @@ protected:
virtual void SwClientNotify(const SwModify&, const SfxHint&) override;
public:
-
-
inline void SetNextTextFormatColl(SwTextFormatColl& rNext);
SwTextFormatColl& GetNextTextFormatColl() const { return
*mpNextTextFormatColl; }
@@ -133,6 +133,11 @@ public:
bool AreListLevelIndentsApplicable() const;
void dumpAsXml(xmlTextWriterPtr pWriter) const;
+virtual void FormatDropNotify(const SwFormatDrop& rDrop) override
+{
+if(HasWriterListeners() && !IsModifyLocked())
+CallSwClientNotify(sw::LegacyModifyHint(, ));
+};
};
class SwGrfFormatColl final : public SwFormatColl
diff --git a/sw/inc/ndtxt.hxx b/sw/inc/ndtxt.hxx
index 190649642ffb..5733a5f2c3d6 100644
--- a/sw/inc/ndtxt.hxx
+++ b/sw/inc/ndtxt.hxx
@@ -22,12 +22,13 @@
#include
#include "swdllapi.h"
-#include "node.hxx"
-#include "hintids.hxx"
-#include "ndhints.hxx"
-#include "SwNumberTreeTypes.hxx"
#include "IDocumentContentOperations.hxx"
+#include "SwNumberTreeTypes.hxx"
+#include "hintids.hxx"
#include "modeltoviewhelper.hxx"
+#include "ndhints.hxx"
+#include "node.hxx"
+#include "paratr.hxx"
#include
#include
@@ -79,6 +80,7 @@ typedef o3tl::sorted_vector< sal_Int32 > SwSoftPageBreakList;
class SW_DLLPUBLIC SwTextNode
: public SwContentNode
, public ::sfx2::Metadatable
+, public sw::FormatDropDefiner
{
friend class SwContentNode;
/// For creating the first TextNode.
@@ -805,6 +807,8 @@ public:
/// In MS Word, the font underline setting of the paragraph end position
won't affect the formatting of numbering, so we ignore it
static bool IsIgnoredCharFormatForNumbering(const sal_uInt16 nWhich);
+void FormatDropNotify(const SwFormatDrop& rDrop) override
+{ TriggerNodeUpdate(sw::LegacyModifyHint(, )); };
};
inline SwpHints & SwTextNode::GetSwpHints()
diff --git a/sw/inc/paratr.hxx b/sw/inc/paratr.hxx
index 1c6bcf4de0fc..d9712028198c 100644
--- a/sw/inc/paratr.hxx
+++ b/sw/inc/paratr.hxx
@@ -39,18 +39,29 @@
#include
#include
+class SwTextNode;
class IntlWrapper;
#define DROP_WHOLEWORD ((sal_uInt16)0x0001)
+class SwFormatDrop;
+
+namespace sw {
+class SW_DLLPUBLIC FormatDropDefiner {
+protected:
+virtual ~FormatDropDefiner() {};
+public:
+virtual void FormatDropNotify(const SwFormatDrop&) =0;
+};
+}
+
/** If SwFormatDrop is a Client, it is the CharFormat that describes the font
for the
DropCaps. If it is not a Client, formatting uses the CharFormat of the
paragraph.
If the CharFormat is modified, this change is propagated to the paragraphs
via the Modify of SwFormatDrop. */
class SW_DLLPUBLIC SwFormatDrop: public SfxPoolItem, public SwClient
{
-sw::BroadcastingModify* m_pDefinedIn; /**< Modify-Object, that
contains DropCaps.
- Can only be
[Libreoffice-ux-advise] [Bug 138502] Spellchecker problems with multiple languages and custom languages
https://bugs.documentfoundation.org/show_bug.cgi?id=138502 Telesto changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||tele...@surfxs.nl -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 104640] Images with caption will disappearing ('white box') when changing anchor
https://bugs.documentfoundation.org/show_bug.cgi?id=104640 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||8492 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108469] 'As Character' image disappears after another image is inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=108469 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||8492 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112929] EDITING: 'As Character' image disappears after deleting a previous paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=112929 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||8492 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138492] [Docx] Missing Picture on second page
https://bugs.documentfoundation.org/show_bug.cgi?id=138492 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||2929, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||8469, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||4640 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136230] SPECIAL CHARACTER DIALOG: Search functionality is too bad
https://bugs.documentfoundation.org/show_bug.cgi?id=136230 Dieter changed: What|Removed |Added Summary|search functionality for|SPECIAL CHARACTER DIALOG: |special characters is too |Search functionality is too |bad |bad -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138193] SPECIAL CHARACTER DIALOG: Help for search field is missing
https://bugs.documentfoundation.org/show_bug.cgi?id=138193 Dieter changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||6230 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136230] search functionality for special characters is too bad
https://bugs.documentfoundation.org/show_bug.cgi?id=136230 Dieter changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||8193 Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO Whiteboard| QA:needsComment | CC||dgp-m...@gmx.de --- Comment #2 from Dieter --- PLease have a look at the bug I've reported (bug 138193). Will a better documentation solve your problem? => NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112139] [META] Options dialog's Language settings bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112139 Dieter changed: What|Removed |Added Depends on||136769 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=136769 [Bug 136769] when right-click creating a new writer file, default language is ignored -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119352] [META] Language issues
https://bugs.documentfoundation.org/show_bug.cgi?id=119352 Dieter changed: What|Removed |Added Depends on||136769 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=136769 [Bug 136769] when right-click creating a new writer file, default language is ignored -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136769] when right-click creating a new writer file, default language is ignored
https://bugs.documentfoundation.org/show_bug.cgi?id=136769 Dieter changed: What|Removed |Added Whiteboard| QA:needsComment| Blocks||119352, 112139 Ever confirmed|0 |1 CC||dgp-m...@gmx.de Status|UNCONFIRMED |NEW --- Comment #6 from Dieter --- I confirm it with Version: 7.0.3.1 (x64) Build ID: d7547858d014d4cf69878db179d326fc3483e082 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL See Tools => Options => Language settings => Languages: Default language for documents changes from German (in my case) to English (USA). Thisonly happens if I create a new document from desktop or explorer. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112139 [Bug 112139] [META] Options dialog's Language settings bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=119352 [Bug 119352] [META] Language issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138092] We need a "Protect Comments" feature under Tools -> Protect Document as well, to prevent unknown deletion of comments.
https://bugs.documentfoundation.org/show_bug.cgi?id=138092 Dieter changed: What|Removed |Added Status|NEW |UNCONFIRMED Ever confirmed|1 |0 --- Comment #3 from Dieter --- (In reply to TH from comment #2) > You need to be using a current version of LibreOffice Writer If you are > using a current version, then you WILL see two options under Tools ==> > Protect Document, and neither of those has to do with comments. We need an > option to also protect comments Sorry, but I don't have an "Protect Document" entry in Version: 7.0.3.1 (x64) Build ID: d7547858d014d4cf69878db179d326fc3483e082 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL ans even if I try to customise the menu, I can't find that option. Perhaps anybody else can help. (BTW: You can't confirm your own bugs => UNCONFIRMED) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138498] Word 2007-365 documents have wrong image positioning
https://bugs.documentfoundation.org/show_bug.cgi?id=138498 Timur changed: What|Removed |Added Keywords||filter:docx -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138498] Word 2007-365 documents have wrong image positioning
https://bugs.documentfoundation.org/show_bug.cgi?id=138498 Timur changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Timur --- Please: 1.attach sample ODT which is per this report wrongly saved to DOCX 2.if you can ,add comparison screenshot of ODT in LO, DOCX in LO and DOCX in MSO 3.just to have complete info , try also with saving to DOC and reopening in LO and MSO 4.see via search of already reported, if this is a delicate of older bug 5. to confirm the bug, it needs to be tested with daily master from https://dev-builds.libreoffice.org/daily/master/current.html When you attach ODT set Unconfirmed. Other steps are optional but useful. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138503] Wrong formatting of non-Latin Unicode text.
https://bugs.documentfoundation.org/show_bug.cgi?id=138503 --- Comment #1 from Johannes Wülk --- Created attachment 167582 --> https://bugs.documentfoundation.org/attachment.cgi?id=167582=edit Sample text, first two lines should show in bold. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126712] FILEOPEN DOC: Anchor to character for image in header is located off page
https://bugs.documentfoundation.org/show_bug.cgi?id=126712 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=38 ||575 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 38575] 2-page DOC or DOCX with image anchored to header yields page counting and block Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=38575 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||6712 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138503] New: Wrong formatting of non-Latin Unicode text.
https://bugs.documentfoundation.org/show_bug.cgi?id=138503 Bug ID: 138503 Summary: Wrong formatting of non-Latin Unicode text. Product: LibreOffice Version: 7.0.3.1 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: johnwu...@yahoo.de Description: LibreOffice Writer shows wrong formatting of non-latin Unicode characters (Unicode Range: 1200–137F used for languages like Tigrinya or Amharic). For example bold text is shown as regular/non-bold text. This problem doesn't seem to depend on a specific file type, as I tested it on doc, docx and odt files. Other Office Suites like Google Docs, MSO or Free Office show the formatting correctly. As I like to use Libre Office as my main and only Office suite, I hope this problem can be easily fixed. Thank you in advance. Actual Results: Bold text is shown regular/non-bold. Expected Results: Correct Formatting overall. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.0.3.1 Build ID: 00(Build:1) CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3 Locale: de-DE (de_DE.UTF-8); UI: en-US 7.0.3-2 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80392] Endless page counting on opening or editing a particular DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=80392 Timur changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=38 | |575 | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118535] FILESAVE DOCX Writer saves images anchored to header/footer multiple times
https://bugs.documentfoundation.org/show_bug.cgi?id=118535 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=38 ||575 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 38575] 2-page DOC or DOCX with image anchored to header yields page counting and block Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=38575 Timur changed: What|Removed |Added CC||gti...@gmail.com See Also|https://bugs.documentfounda |https://bugs.documentfounda |tion.org/show_bug.cgi?id=80 |tion.org/show_bug.cgi?id=11 |392 |8535 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/qa
vcl/qa/cppunit/GraphicTest.cxx| 30 ++
vcl/qa/cppunit/data/roundtrip.wmf |binary
2 files changed, 30 insertions(+)
New commits:
commit 6bb0e09e2423ae00e06e6b7ae2c5a0af6ca100a1
Author: Miklos Vajna
AuthorDate: Wed Nov 25 18:01:08 2020 +0100
Commit: Miklos Vajna
CommitDate: Thu Nov 26 07:37:29 2020 +0100
WMF export: just write the source data as is for from-WMF graphics
This was already working on master since commit
5868745db74ae930edb0058490076d82aaeafbe9 (emfplus: make VectorFormats
Emf/Wmf/Svg work, 2017-06-12), but a matching testcase was missing.
Change-Id: I7661cd5e66d13b1750f16c0c423c4b69420577a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106607
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/vcl/qa/cppunit/GraphicTest.cxx b/vcl/qa/cppunit/GraphicTest.cxx
index 50ff4a133f86..df9711b54a35 100644
--- a/vcl/qa/cppunit/GraphicTest.cxx
+++ b/vcl/qa/cppunit/GraphicTest.cxx
@@ -24,6 +24,7 @@
#include
#include
#include
+#include
#include
@@ -49,6 +50,7 @@ private:
void testSwapping();
void testSwappingVectorGraphic();
void testSwappingPageNumber();
+void testWMFRoundtrip();
CPPUNIT_TEST_SUITE(GraphicTest);
CPPUNIT_TEST(testUnloadedGraphic);
@@ -59,6 +61,7 @@ private:
CPPUNIT_TEST(testSwapping);
CPPUNIT_TEST(testSwappingVectorGraphic);
CPPUNIT_TEST(testSwappingPageNumber);
+CPPUNIT_TEST(testWMFRoundtrip);
CPPUNIT_TEST_SUITE_END();
};
@@ -468,6 +471,33 @@ void GraphicTest::testSwappingPageNumber()
CPPUNIT_ASSERT_EQUAL(sal_Int32(1),
aGraphic.getVectorGraphicData()->getPageIndex());
}
+void GraphicTest::testWMFRoundtrip()
+{
+// Load a WMF file.
+test::Directories aDirectories;
+OUString aURL =
aDirectories.getURLFromSrc("vcl/qa/cppunit/data/roundtrip.wmf");
+SvFileStream aStream(aURL, StreamMode::READ);
+sal_uInt64 nExpectedSize = aStream.TellEnd();
+GraphicFilter& rGraphicFilter = GraphicFilter::GetGraphicFilter();
+Graphic aGraphic = rGraphicFilter.ImportUnloadedGraphic(aStream);
+
+// Save as WMF.
+utl::TempFile aTempFile;
+aTempFile.EnableKillingFile();
+sal_uInt16 nFormat =
rGraphicFilter.GetExportFormatNumberForShortName(u"WMF");
+SvStream& rOutStream = *aTempFile.GetStream(StreamMode::READWRITE);
+rGraphicFilter.ExportGraphic(aGraphic, OUString(), rOutStream, nFormat);
+
+// Check if we preserved the WMF data perfectly.
+sal_uInt64 nActualSize = rOutStream.TellEnd();
+
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: 6475
+// - Actual : 2826
+// i.e. we lost some of the WMF data on roundtrip.
+CPPUNIT_ASSERT_EQUAL(nExpectedSize, nActualSize);
+}
+
} // namespace
CPPUNIT_TEST_SUITE_REGISTRATION(GraphicTest);
diff --git a/vcl/qa/cppunit/data/roundtrip.wmf
b/vcl/qa/cppunit/data/roundtrip.wmf
new file mode 100644
index ..83210546c373
Binary files /dev/null and b/vcl/qa/cppunit/data/roundtrip.wmf differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 138302] Restart of numbering is not saved when saving to DOC
https://bugs.documentfoundation.org/show_bug.cgi?id=138302 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||8496 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34959] Export/convert presentation to video
https://bugs.documentfoundation.org/show_bug.cgi?id=34959 Timur changed: What|Removed |Added CC||mgrosh...@mail.ru --- Comment #25 from Timur --- *** Bug 134856 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134856] Export as video
https://bugs.documentfoundation.org/show_bug.cgi?id=134856 --- Comment #5 from Timur --- *** This bug has been marked as a duplicate of bug 34959 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128395] Font change to Liberation Mono on some part of my text when I reboot
https://bugs.documentfoundation.org/show_bug.cgi?id=128395 Timur changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138502] Spellchecker problems with multiple languages and custom languages
https://bugs.documentfoundation.org/show_bug.cgi?id=138502 Mike Kaganski changed: What|Removed |Added Keywords||needsUXEval --- Comment #1 from Mike Kaganski --- In LibreOffice, there are two ways this is expected to work: 1. Use of styles. This method implies that you create styles (character and/or maybe paragraph) which have required languages defined explicitly. The styles may be assigned custom keyboard shortcuts for ease of use. This method works in any environment. However, until there's no UI for nesting character styles (tdf#115311), it will not be useful, since there's no way to make a text range have "language" character style *and* some other character style (say, strong emphasis). 2. Taking system input language into account. This method uses the input language as reported by OS/environment, and applies respective direct formatting to entered text automatically at each key press. This feature depends on "Ignore system input language" setting in Options->Language Settings->Languages (when the setting is unchecked, the feature is active); it is active by default. This requires that user *changes* system input language correctly, though. In locales where it's normal to switch keyboard layouts when switching languages (e.g., when one uses a Cyrillic script and a Latin script: say, Russian + English, which have different keyboard layouts, with no Latin characters on Russian layout and vice versa), one *always* presses e.g. Shift+Alt when switching the keyboard layout, and that additionally switches the input language. That is in muscle memory of those users, and does not impose problems. However, for users who write in two languages both using Latin script, this is an unknown/unusual workflow; these users don't think about switching something when start writing in a different language; they usually don't know that they are able to have several system input modes (e.g., English input language using en-US intl keyboard layout, and German language also using en-US intl keyboard layout), which would enable them to facilitate that system feature. This feature also depends on OS/environment support for this feature in LO. It has always been supported on Windows. Until recently, it was not supported on Linux (tdf#108151); it was implemented for Qt5 by Jan-Marek, which will be in LO 7.2 (summer 2021). It is not (yet?) available for GTK and other backends. I disagree that we should allow marking text as multi-language. Instead, we should fix the existing problems in the use of the two methods described above, and create an extensive help how to use them properly. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131920] Full text highlight + shading support
https://bugs.documentfoundation.org/show_bug.cgi?id=131920 --- Comment #12 from Justin L --- LibreOffice is able to recognize and clear highlighting in character properties, but it is missing that ability in paragraph-style's highlighting tab. Proposed fix at https://gerrit.libreoffice.org/c/core/+/106323. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131920] Full text highlight + shading support
https://bugs.documentfoundation.org/show_bug.cgi?id=131920 Justin L changed: What|Removed |Added Severity|normal |enhancement --- Comment #11 from Justin L --- (In reply to Heiko Tietze from comment #6) > (In reply to Bart from comment #2) who was suggesting the compatibility > palette be "encouraged" for character highlighting, and selective export of > highlight-compatible colours as highlight, and the rest as shading. > > Your proposal looks like a tremendous amount of work to fix Microsoft's > issues. > Do you think it's needed given that MSO's Theme Shading is not hard to find? I had initially come to the same conclusion as Bart. However, as Heiko notes, that will be a tremendous amount of work since the current PaletteManager has no capabilities for "special use cases". The most recent palette used is saved in user settings and used for EVERY use case. Also, Heiko is right about modern MS Word's shading tool being easy to find. At first I compared shading to a permanent marker used on a whiteboard - really hard to remove. But today, a better analogy is the difference between a pencil/eraser and a pen/white-out. Our current support for import/export of highlight works for the practical cases, but isn't complete enough to handle the theoretical documentation. I mean, MS Word doesn't allow the user to add highlighting to paragraph styles, so the fact that we don't import or export "none" highlighting doesn't really matter. But it DOES matter if we start exporting colours as highlight in styles. So Bart's idea of exporting the 15 colours as highlight is simple enough on the surface, but it leads to a lot of other development work to support styles properly. (It would be easy enough to do if it only applied to direct formatting.) See bug 137683 and bug 138345. So my conclusion after working on various parts of this for a week is that it is not beneficial to export the 15 colours as highlight with the rest as shading - just export them all as shading. Otherwise LibreOffice edits become inconsistent to remove in MS Word. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73035] Other: Invalid countif result on Named range
https://bugs.documentfoundation.org/show_bug.cgi?id=73035 --- Comment #3 from pourvan --- LiteBlue.usps.gov online portal site is specially designed for liteblue usps gov worker. Liteblue is the official portal for United Stated Postal Service employees. Use liteblue.usps.gov to log in to your Liteblue to man age work. https://liteblue.fun -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138502] New: Spellchecker problems with multiple languages and custom languages
https://bugs.documentfoundation.org/show_bug.cgi?id=138502 Bug ID: 138502 Summary: Spellchecker problems with multiple languages and custom languages Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Linguistic Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: arie...@trashmail.com CC: so...@libreoffice.org Description: Suppose I am writing an English text containing many German words, or a German text containing many English ones. There is no obvious way to use a spellchecker without manually labeling each language switch. Suppose I write my own .aff file for a language. It seems I can set a user-defined dictionary, but I cannot find any way to set a user-defined .aff file. This makes it difficult to develop and test new dictionaries in LibreOffice. Steps to Reproduce: 1. Write a document containing words in two or more languages (where one language may or may not be supported) 2. Try to use spellcheck Actual Results: I may want the spellchecker to accept any words in the de_DE.dic files, inflected according to the de_DE.aff file, AND any words in the en_GB.dic file, inflected according to the en_GB.aff file. However, currently, I cannot, unless I explicitly tell the document which bits are in which language (Tools>Language>For selection), which is more tedious than manual spellchecking in each of the two language modes. I realize that using multiple languages would increase my false-negative rate, since misspellings that happened to be words in the other language would not be picked up. That's acceptable; it'd be much better than the huge false-positive rate you get when spellchecking German as English or vice-versa. To avoid this error-rate issue, I could add the minor-language words to a user-defined dictionary; this often works well. However, in user-defined dictionaries, I can only give inflection rules by analogy to existing words *in the default document language*. Many words in German inflect in ways that English words do not, and vice-versa. I therefore have to add every possible inflection of each second-language word as a separate user-defined dictionary entry, or the spellchecker won't work. This is very tedious. Expected Results: Potential solutions: Potential solution 1: I could manually amalgamate the de_DE and en_GB files, but that would be tedious (inflection categories have what are essentially one-capital-letter variable names!). Also, while there's a system for adding user-defined dictionaries, there is no way I can see to add a user-defined .aff file. So it seems I'd have to pretend my hybrid file was an existing language! And I get the error-rate issue. This solution seems poor. Potential solution 2: Since many extensions supply new dictionary+aff-file pairs, an extension/function allowing the user to add custom pairs seems like it should be possible, but I don't think it exists. https://wiki.documentfoundation.org/Development/Dictionaries has no instructions, beyond asking the developers. Potential solution 2.5: An option to do a semi-automated merge of existing dictionary+aff pairs to create a custom merged dic+aff pair for use as in PS2 above (while leaving the original languages intact). The error-rate issue occurs, unless I pare down the auto-generated file. Potential solution 3: User-defined dictionaries currently only allow users to define inflections by analogy to words in ONE dictionary+aff pair: "inflect this word like the word 'troggle' in the .dic file". There is no way to say "inflect the word "triggle" like the word 'troggle' in (xy_XY.dic and xy_XY.aff), and inflect the word "boing" like the word 'sproing' in (wz_WZ.dic and wz_WZ.aff)". 3a. I'd like to have the option to define inflections with variable names (like in the non-user-defined dictionaries, e.g.: "Adam/SM", where "S" and "M" are classes of inflections "Adam" takes, namely "Adams" and "Adam's"). 3b. I'd also like to use variable names that refer to a specific .aff file. Example: if the word is "widget", defining inflections with "widget/$en_GB_X" instead of "widget/X". It should also be possible to say "widget/$en_GB_X+$de_DE_Y" or "widget/$en_GB_X$de_DE_X". But maybe multiletter names would run into format-definition problems. This solution would greatly reduce the error-rate issue, especially combined with PS2. It would save manually copying inflections into a PS2 custom .aff file. Potential solution 4: Add a Libreoffice setting to tell the spellchecker to use multiple pairs of words+inflections, and only flag words not found in any selected language. For correct-spelling-guessing algorithms, I'd be happy to set a preference for the rules in one specified .aff file over another, or set an order of priorities.
[Libreoffice-bugs] [Bug 138501] Distance-Based Dash Patterns Drawn Incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=138501 --- Comment #4 from Alfred Hellstern --- I work for Microsoft and we are going to implement ODF 1.3. This was found during investigation of 1.3 changes. Per Regina Henschel (like Regina, I'm a member of the OpenDocument technical committee) this appears to be the ssame error as with hatch distance: https://bugs.documentfoundation.org/show_bug.cgi?id=100972 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138147] Shapes/Annotations on DOCX files drawn with Microsoft Surface Pen are invisible when opening with Libre
https://bugs.documentfoundation.org/show_bug.cgi?id=138147 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138121] Impress going unresponsive while handling gifs in the presentation.
https://bugs.documentfoundation.org/show_bug.cgi?id=138121 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132462] Crash in: RtlpLowFragHeapAllocFromContext
https://bugs.documentfoundation.org/show_bug.cgi?id=132462 --- Comment #3 from QA Administrators --- Dear Elieu, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132462] Crash in: RtlpLowFragHeapAllocFromContext
https://bugs.documentfoundation.org/show_bug.cgi?id=132462 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131348] CRASH: Mailmerge with ODBC Connection to sqlite3 when sending mailmerge as email with personalized greeting
https://bugs.documentfoundation.org/show_bug.cgi?id=131348 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131348] CRASH: Mailmerge with ODBC Connection to sqlite3 when sending mailmerge as email with personalized greeting
https://bugs.documentfoundation.org/show_bug.cgi?id=131348 --- Comment #10 from QA Administrators --- Dear Tomi, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128694] Add a slider to the tranparency property in LibreOffice Draw for stroke properties
https://bugs.documentfoundation.org/show_bug.cgi?id=128694 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128694] Add a slider to the tranparency property in LibreOffice Draw for stroke properties
https://bugs.documentfoundation.org/show_bug.cgi?id=128694 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 128694] Add a slider to the tranparency property in LibreOffice Draw for stroke properties
https://bugs.documentfoundation.org/show_bug.cgi?id=128694 --- Comment #3 from QA Administrators --- Dear Arian, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128694] Add a slider to the tranparency property in LibreOffice Draw for stroke properties
https://bugs.documentfoundation.org/show_bug.cgi?id=128694 --- Comment #3 from QA Administrators --- Dear Arian, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 133488] The latest update 6.3.6.2 has completely ruined my spreadsheets
https://bugs.documentfoundation.org/show_bug.cgi?id=133488 --- Comment #2 from QA Administrators --- Dear boblampard, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47256] MAILMERGE: Field "Statistics - Pages" becomes static number in resulting merged document
https://bugs.documentfoundation.org/show_bug.cgi?id=47256 --- Comment #12 from QA Administrators --- Dear FDF, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128391] Mouse pointer changed ...
https://bugs.documentfoundation.org/show_bug.cgi?id=128391 --- Comment #4 from QA Administrators --- Dear Kai Zimmermann, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138501] Distance-Based Dash Patterns Drawn Incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=138501 --- Comment #3 from Alfred Hellstern --- Created attachment 167581 --> https://bugs.documentfoundation.org/attachment.cgi?id=167581=edit styles.xml relevant for this bug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138501] Distance-Based Dash Patterns Drawn Incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=138501 --- Comment #2 from Alfred Hellstern --- Created attachment 167580 --> https://bugs.documentfoundation.org/attachment.cgi?id=167580=edit Sample file created in LibreOffice This is the sample to reproduce the Line with dots distance bug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138501] Distance-Based Dash Patterns Drawn Incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=138501 --- Comment #1 from Alfred Hellstern --- Created attachment 167579 --> https://bugs.documentfoundation.org/attachment.cgi?id=167579=edit Bug report with illustrations contains the illustrations referenced in the bug report opened using the Bugzilla template -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138490] documentation of "whole sheet export" PDF export option is not useful
https://bugs.documentfoundation.org/show_bug.cgi?id=138490 Ming Hua changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Ming Hua --- *** This bug has been marked as a duplicate of bug 132720 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132720] Help files do not yet describe new option on Calc's PDF Options dialog - "Whole Sheet Export"
https://bugs.documentfoundation.org/show_bug.cgi?id=132720 Ming Hua changed: What|Removed |Added CC||lio...@mamane.lu --- Comment #3 from Ming Hua --- *** Bug 138490 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132720] Help files do not yet describe new option on Calc's PDF Options dialog - "Whole Sheet Export"
https://bugs.documentfoundation.org/show_bug.cgi?id=132720 --- Comment #2 from Ming Hua --- More information about this feature can be found at: https://wiki.documentfoundation.org/ReleaseNotes/6.4#Whole_sheet_export -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138490] documentation of "whole sheet export" PDF export option is not useful
https://bugs.documentfoundation.org/show_bug.cgi?id=138490 Ming Hua changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Ming Hua --- I don't think this option puts all sheets onto one print page. More information about this feature can be found at: https://wiki.documentfoundation.org/ReleaseNotes/6.4#Whole_sheet_export It's also a good idea to check the lastet version (7.1 right now) of online help when reporting bugs againt it. In this case 7.1 version [1] still lacks information for this, so not a big deal. 1. https://help.libreoffice.org/7.1/en-US/text/shared/01/ref_pdf_export_general.html -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138501] New: Distance-Based Dash Patterns Drawn Incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=138501 Bug ID: 138501 Summary: Distance-Based Dash Patterns Drawn Incorrectly Product: LibreOffice Version: 7.0.0.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: alfr...@microsoft.com Description: We noticed a discrepancy between how LibreOffice saves and displays the same information. Background: A stroke pattern is defined with these parameters: • primary dash length (percentage or distance) • primary dash count • secondary dash length (percentage or distance) • secondary dash count • distance between all dashes So for example, the following dash pattern: one long dash, two short dashes, repeating is defined by: • primary dash length = 1100% of width • primary dash count = 1 • secondary dash length = 100% of width • secondary dash count = 2 • distance between all dashes = 500% of width Most dash patterns are defined as percentages, and so the dashes change lengths proportionally as the width changes, but some use absolute distance values. These, specifically, appear to have an issue. Steps to Reproduce: • Open LibreOffice Writer and create a vertical line with width 6pt and dash pattern "Line with Fine Dots". • Save and close the document. Change the file extension to .zip, extract all the contents, and open styles.xml. Actual Results: •Observe that the dash pattern is defined with this XML line: •The primary dash, then, should be .79 inches long, but if you draw a square next to the primary dash, you can see that it's actually drawn 1.39 inches long. [See Fig. 1 at bottom.] •If you open the ODT in Office Word and perform the same comparison, you can see that Word actually does draw the primary dash .79 inches long. [See Fig. 2 at bottom.] Expected Results: It seems that Office Word honors the measurements given, but LibreOffice renders them at about double the given distance. I believe this is a LibreOffice bug. Reproducible: Always User Profile Reset: No Additional Info: see attached files -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128395] Font change to Liberation Mono on some part of my text when I reboot
https://bugs.documentfoundation.org/show_bug.cgi?id=128395 --- Comment #5 from Thavaided --- I did search for Libre Office menu to star the application, but I not fount at all https://geometrydash-free.com/ What I have to do, for successful installation of Libre Office. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96678] Add Hotkeys to Each Font Effect Option
https://bugs.documentfoundation.org/show_bug.cgi?id=96678 Ming Hua changed: What|Removed |Added CC||ming.v@qq.com --- Comment #2 from Ming Hua --- For quite some time (at least since 6.2 series), LibreOffice has been generating hotkeys for UI items automatically, so all the options on this tab have hotkeys now. This is at least the default behavior on Windows, not sure about other platforms, but should be configurable. Joel, would you please check with a new version of LO (6.4 and 7.0 are the currently supported "Still" and "Fresh" series), and see if this bug is solved for you? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127611] Writer: ~h does not toggle Hidden effect
https://bugs.documentfoundation.org/show_bug.cgi?id=127611 Ming Hua changed: What|Removed |Added CC||ming.v@qq.com --- Comment #2 from Ming Hua --- (In reply to V Stuart Foote from comment #1) > Suspect the ~h accelerator of the hidden character attribute is conflicting > with the ~h of the help action I agree the problem is that ~h is assigned as mnemonic for both "Hidden" and "Help". However the problem can't be easily fixed with a string change, because here ~h is automatically assigned to "Hidden". I submitted a patch https://gerrit.libreoffice.org/c/core/+/106670 to address the symptom of the problem without fixing the underlying flaw of the mnemonic auto-generation mechanism. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131414] video insertion in slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=131414 --- Comment #18 from loin --- También tengo algunos problemas en la mozzilla de mi sitio de https://convertidor.live/ Eso aún no se ha resuelto. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - sw/qa
sw/qa/extras/uiwriter/data3/tdf138130.docx |binary
sw/qa/extras/uiwriter/uiwriter3.cxx| 30 +
2 files changed, 30 insertions(+)
New commits:
commit 7893e24c82c97de9c066f6e09df0ac107a6d97dd
Author: Xisco Fauli
AuthorDate: Wed Nov 25 17:04:16 2020 +0100
Commit: Xisco Fauli
CommitDate: Thu Nov 26 00:26:23 2020 +0100
tdf#138130: sw_uiwriter: Add unittest
Change-Id: If7eca097e83003d657cc39ae617eaccabcf62a5a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106610
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
Signed-off-by: Xisco Fauli
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106633
diff --git a/sw/qa/extras/uiwriter/data3/tdf138130.docx
b/sw/qa/extras/uiwriter/data3/tdf138130.docx
new file mode 100644
index ..a570dec4b08a
Binary files /dev/null and b/sw/qa/extras/uiwriter/data3/tdf138130.docx differ
diff --git a/sw/qa/extras/uiwriter/uiwriter3.cxx
b/sw/qa/extras/uiwriter/uiwriter3.cxx
index da425a13e071..36b971e6a5ec 100644
--- a/sw/qa/extras/uiwriter/uiwriter3.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter3.cxx
@@ -868,6 +868,36 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf117601)
CPPUNIT_ASSERT(xCellB1->getString().endsWith("test1"));
}
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf138130)
+{
+load(DATA_DIRECTORY, "tdf138130.docx");
+SwXTextDocument* pTextDoc =
dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+
+CPPUNIT_ASSERT_EQUAL(1, getShapes());
+uno::Reference xShape = getShape(1);
+
+awt::Point aPos = xShape->getPosition();
+
+//select shape and change the anchor
+dispatchCommand(mxComponent, ".uno:JumpToNextFrame", {});
+Scheduler::ProcessEventsToIdle();
+
+// Without the fix in place, this test would have crashed here
+dispatchCommand(mxComponent, ".uno:SetAnchorToPage", {});
+Scheduler::ProcessEventsToIdle();
+
+//position has changed
+CPPUNIT_ASSERT(aPos.X < xShape->getPosition().X);
+CPPUNIT_ASSERT(aPos.Y < xShape->getPosition().Y);
+
+dispatchCommand(mxComponent, ".uno:Undo", {});
+Scheduler::ProcessEventsToIdle();
+
+CPPUNIT_ASSERT_EQUAL(aPos.X, xShape->getPosition().X);
+CPPUNIT_ASSERT_EQUAL(aPos.Y, xShape->getPosition().Y);
+}
+
CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf128782)
{
load(DATA_DIRECTORY, "tdf128782.odt");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 138130] Crash in: swlo.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=138130 --- Comment #8 from Commit Notification --- Xisco Fauli committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/7893e24c82c97de9c066f6e09df0ac107a6d97dd tdf#138130: sw_uiwriter: Add unittest It will be available in 7.0.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134369] Enable word-wrap by default for shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=134369 Rafael Lima changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |rafael.palma.l...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99646] Make default type of anchoring optional
https://bugs.documentfoundation.org/show_bug.cgi?id=99646 Gabriele Ponzo changed: What|Removed |Added CC||gpo...@gmail.com --- Comment #11 from Gabriele Ponzo --- (In reply to Heiko Tietze from comment #7) > We discussed this topic in the design meeting. While we intentionally > decided to change the default to "To Character" there might be also > scenarios where other anchors make sense. The idea discussed in bug 87720 to > just remember the last used option is not ideal since, for example, user > want to change anchoring for just one image but have to reset the default > next time. So we decided to introduce radio buttons under Tools > Options > > Writer > Formatting Aid that allow to change the default from _To Character_ > to any other option. In which version of LO is it planned to find this "Formatting Aid" branch in Writer's options section? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99646] Make default type of anchoring optional
https://bugs.documentfoundation.org/show_bug.cgi?id=99646 --- Comment #10 from Andrea Piovesana --- idem for me I would also like this. I normally anchor images as character, so it's a real hassle having to change the anchor every time I paste something into my document. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134369] Enable word-wrap by default for shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=134369 --- Comment #10 from Rafael Lima --- > Not sure if all this helps ;-) It helped me start from a different angle, then after a some time I managed to find where it is. Thanks! Actually the code that creates the default template is hard-coded in the method SdDrawDocument::CreateLayoutTemplates() inside the file: /core/sd/source/core/drawdoc4.cxx I changed the default template and tested if it breaks compatibility with files created with the current build. Fortunately the styles are saved inside the .odp file and compatibility is not broken. I'll submit the patch to Gerrit for review. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138496] JRE and JDK not found 7.1.0.0 beta1
https://bugs.documentfoundation.org/show_bug.cgi?id=138496 --- Comment #4 from ThP --- Version: 7.1.0.0.beta1 (x64) Build ID: 828a45a14a0b954e0e539f5a9a10ca31c81d8f53 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138500] The Title Slug graphic on the Help -> About dialog has lost its quality
https://bugs.documentfoundation.org/show_bug.cgi?id=138500 --- Comment #2 from V Stuart Foote --- No difference Skia Vulkan or raster only rendering. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138500] The Title Slug graphic on the Help -> About dialog has lost its quality
https://bugs.documentfoundation.org/show_bug.cgi?id=138500 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #1 from V Stuart Foote --- Created attachment 167578 --> https://bugs.documentfoundation.org/attachment.cgi?id=167578=edit Help -> About dialog 7.1.0beta1 -- on Windows build -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138500] New: The Title Slug graphic on the Help -> About dialog has lost its quality
https://bugs.documentfoundation.org/show_bug.cgi?id=138500 Bug ID: 138500 Summary: The Title Slug graphic on the Help -> About dialog has lost its quality Product: LibreOffice Version: 7.1.0.0.beta1+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: vstuart.fo...@utsa.edu -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134962] FILESAVE: DOC: Saving ODT with lots of formulas to doc slow
https://bugs.documentfoundation.org/show_bug.cgi?id=134962 --- Comment #7 from Telesto --- Version is set to 3.5.7.2. No clue if i tested back then... anyhow repro with Versie: 4.4.7.2 Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600 Locale: nl_NL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136695] Footer text in impress is wrapped inside words and does not respect alignment directives
https://bugs.documentfoundation.org/show_bug.cgi?id=136695 Henrique SantAnna changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||hsantanna+libreoffice@gmail ||.com Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138424] calc: calculation: rounding of results: bad influence of unspecific rounding if terms in different dyadic ranges
https://bugs.documentfoundation.org/show_bug.cgi?id=138424 Eike Rathke changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138496] JRE and JDK not found 7.1.0.0 beta1
https://bugs.documentfoundation.org/show_bug.cgi?id=138496 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #3 from V Stuart Foote --- Can not confirm. On Windows 10 64-bit (1909) with the 64-bit 15.0.1-hotspot AdoptOpenJDK Version: 7.1.0.0.beta1 (x64) Build ID: 828a45a14a0b954e0e539f5a9a10ca31c81d8f53 CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL Tools -> Options -> Advanced panel, the JDK shows in the Java Options -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138360] calculation: basic math fail, !calc rounding wrong! dividing by inverse sometimes different from multiply, 7E10/1E-5 wrong,
https://bugs.documentfoundation.org/show_bug.cgi?id=138360 Eike Rathke changed: What|Removed |Added Keywords||bibisectRequest Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Eike Rathke --- (In reply to b. from comment #0) > '=7000*0,1/0,1' fails (6999~), while > '=7000/10*10' holds, > > acc. school math the results should be equal, 'weitz' tells me 700 / > 0,1 = 6,~, You can't apply school math on IEEE-754 binary floating-point values over all ranges. Period. 0.1 has no exact binary representation, hence 700 / 0.1 => 6999 > question 1: weitz and calc may share some basic problem - buggy library, > wrong compiler options or similar, They share IEEE-754 binary floating-point. > question 2: if the error is 'unavoidable' would it be a good idea to use the > better of both formulas in calc? i 'assume' calcs rounding routine uses the > 'wrong' of both formulas and thus fails sometimes ... There's no extra rounding involved in multiplication and division. Also, the formula expression is calculated as entered from left to right, there's no "use the better". > question 3: may it be possible that this or similar errors, which can be > easily circumvented in the same or a similar way, are the cause of many > other 'inaccuracies' in calc? There's no Calc error in this case. And this case of inaccuracy can't be circumvented unless the final value is rounded but to what criteria? > earlier versions of calc were 'better', so i think that 'better' is > possible, Which version yielded the result 7000 for this very example? I tried 5.3.7 and it delivers the same 6999 result. Also doing that math in a raw C++ compiled program yields 6999. Also Gnumeric agrees. > didn't do extensive testing, but on a first glance even ex$el looks better, Maybe they apply some magic. Ask them to reveal their tricks. > and i think it is important, such elementary errors affect many other > calculations ... Yes, IEEE-754 binary floating-point is not perfect. Get over it. > Steps to Reproduce: > 1. key '=ROUND(5e15+1;9)' in a cell, > 2. hit enter, > 3. observe result 5002, I'll keep this bug for the rounding thing, we maybe could do better to not round integer values beyond the decimal. Apart from that Gnumeric also delivers the same 5002 result. > 8. try the same steps in calc ver. 4.1.6.2, it is not! unavoidable, Oh, that version does it different? Maybe it did other things wrong. It delivered better results for both 5002 6999 ? > 9. call it a regression, If so, maybe a bibisect could shed some light. Requesting. But it could also be that compilers' IEEE-754 handling or libraries changed somewhat. And that even both on Windows and Linux. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138499] Impress Animation panel's animation list is not properly displaying on a high-DPI system.
https://bugs.documentfoundation.org/show_bug.cgi?id=138499 --- Comment #1 from typing...@gmail.com --- Created attachment 167577 --> https://bugs.documentfoundation.org/attachment.cgi?id=167577=edit Screenshot. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138130] Crash in: swlo.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=138130 --- Comment #7 from Commit Notification --- Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a45ea4f7939e7ca2e5c071ad209c957702b527e6 tdf#138130: sw_uiwriter: Add unittest It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138130] Crash in: swlo.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=138130 Commit Notification changed: What|Removed |Added Whiteboard|target:7.0.5|target:7.0.5 target:7.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/uiwriter/data3/tdf138130.docx |binary
sw/qa/extras/uiwriter/uiwriter3.cxx| 30 +
2 files changed, 30 insertions(+)
New commits:
commit a45ea4f7939e7ca2e5c071ad209c957702b527e6
Author: Xisco Fauli
AuthorDate: Wed Nov 25 17:04:16 2020 +0100
Commit: Xisco Fauli
CommitDate: Wed Nov 25 23:08:13 2020 +0100
tdf#138130: sw_uiwriter: Add unittest
Change-Id: If7eca097e83003d657cc39ae617eaccabcf62a5a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106598
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/extras/uiwriter/data3/tdf138130.docx
b/sw/qa/extras/uiwriter/data3/tdf138130.docx
new file mode 100644
index ..a570dec4b08a
Binary files /dev/null and b/sw/qa/extras/uiwriter/data3/tdf138130.docx differ
diff --git a/sw/qa/extras/uiwriter/uiwriter3.cxx
b/sw/qa/extras/uiwriter/uiwriter3.cxx
index 38b9e6e7115a..4f8c046356f8 100644
--- a/sw/qa/extras/uiwriter/uiwriter3.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter3.cxx
@@ -1598,6 +1598,36 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf117601)
CPPUNIT_ASSERT(xCellB1->getString().endsWith("test1"));
}
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf138130)
+{
+load(DATA_DIRECTORY, "tdf138130.docx");
+SwXTextDocument* pTextDoc =
dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+
+CPPUNIT_ASSERT_EQUAL(1, getShapes());
+uno::Reference xShape = getShape(1);
+
+awt::Point aPos = xShape->getPosition();
+
+//select shape and change the anchor
+dispatchCommand(mxComponent, ".uno:JumpToNextFrame", {});
+Scheduler::ProcessEventsToIdle();
+
+// Without the fix in place, this test would have crashed here
+dispatchCommand(mxComponent, ".uno:SetAnchorToPage", {});
+Scheduler::ProcessEventsToIdle();
+
+//position has changed
+CPPUNIT_ASSERT(aPos.X < xShape->getPosition().X);
+CPPUNIT_ASSERT(aPos.Y < xShape->getPosition().Y);
+
+dispatchCommand(mxComponent, ".uno:Undo", {});
+Scheduler::ProcessEventsToIdle();
+
+CPPUNIT_ASSERT_EQUAL(aPos.X, xShape->getPosition().X);
+CPPUNIT_ASSERT_EQUAL(aPos.Y, xShape->getPosition().Y);
+}
+
CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf136385)
{
load(DATA_DIRECTORY, "tdf136385.odt");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 138499] New: Impress Animation panel's animation list is not properly displaying on a high-DPI system.
https://bugs.documentfoundation.org/show_bug.cgi?id=138499 Bug ID: 138499 Summary: Impress Animation panel's animation list is not properly displaying on a high-DPI system. Product: LibreOffice Version: 7.0.3.1 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: typing...@gmail.com Description: List item's height is not correct and the text lines look overlapped on a 200% DPI monitor. Steps to Reproduce: 1.Create a new Impress document 2.Open the Animation panel on the right. 3.Add a new animation by clicking the [+] button. Actual Results: Two lies of text overlap, and the font is very small, making it almost impossible to read. Expected Results: The text should be properly displayed. Reproducible: Always User Profile Reset: Yes Additional Info: Checked: Skia. Unchecked: Software rendering. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138496] JRE and JDK not found 7.1.0.0 beta1
https://bugs.documentfoundation.org/show_bug.cgi?id=138496 --- Comment #2 from ThP --- It's all 64 bit. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138092] We need a "Protect Comments" feature under Tools -> Protect Document as well, to prevent unknown deletion of comments.
https://bugs.documentfoundation.org/show_bug.cgi?id=138092 TH changed: What|Removed |Added Status|NEEDINFO|NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138092] We need a "Protect Comments" feature under Tools -> Protect Document as well, to prevent unknown deletion of comments.
https://bugs.documentfoundation.org/show_bug.cgi?id=138092 --- Comment #2 from TH --- (In reply to Dieter from comment #1) > I can't see the option Tools => Protect document > > LO help > https://help.libreoffice.org/7.0/en-GB/text/swriter/guide/protection. > html?=WRITER=WIN gives also no information. Could you please > explain where I can find that option? > > => NEDINFO You need to be using a current version of LibreOffice Writer If you are using a current version, then you WILL see two options under Tools ==> Protect Document, and neither of those has to do with comments. We need an option to also protect comments -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: avmedia/source
avmedia/source/win/player.cxx |4 +---
avmedia/source/win/player.hxx |2 +-
2 files changed, 2 insertions(+), 4 deletions(-)
New commits:
commit 8f4d36009d789f645ab700bfcd20f8e268ce8cee
Author: Stephan Bergmann
AuthorDate: Wed Nov 25 17:45:08 2020 +0100
Commit: Stephan Bergmann
CommitDate: Wed Nov 25 22:58:16 2020 +0100
Player::processEvent return value is unused
Change-Id: Ia3f35f761cdfbfe6a57fce6bc632969759367c56
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106603
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/avmedia/source/win/player.cxx b/avmedia/source/win/player.cxx
index b3e621cbc56d..7990e7aecdfe 100644
--- a/avmedia/source/win/player.cxx
+++ b/avmedia/source/win/player.cxx
@@ -191,7 +191,7 @@ void Player::setNotifyWnd( HWND nNotifyWnd )
}
-long Player::processEvent()
+void Player::processEvent()
{
long nCode;
LONG_PTR nParam1, nParam2;
@@ -214,8 +214,6 @@ long Player::processEvent()
mpME->FreeEventParams( nCode, nParam1, nParam2 );
}
-
-return 0;
}
diff --git a/avmedia/source/win/player.hxx b/avmedia/source/win/player.hxx
index ed34981e96ae..84e2689c0397 100644
--- a/avmedia/source/win/player.hxx
+++ b/avmedia/source/win/player.hxx
@@ -60,7 +60,7 @@ public:
boolcreate( const OUString& rURL );
voidsetNotifyWnd( HWND nNotifyWnd );
-longprocessEvent();
+voidprocessEvent();
const IVideoWindow* getVideoWindow() const;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128329] WORK: 'incomplete autocalculations' - cooperation of autocalculate and shared formulas / formulae still broken in LO calc ver. 6.2.7.1 with *threaded* calculation on
https://bugs.documentfoundation.org/show_bug.cgi?id=128329 --- Comment #13 from b. --- got one catched, in ver. 6.1.6.3 'unparallelized', (i reported the bug as 'threaded' problem as i exprienced plenty fails in that mode, work without threading or openCL since then, and now spotted that typical bug without parallelizing) have the file open and can rollback - rollforward with ctrl-z, ctrl-y and see the error evolving, will try to keep that file open and answer questions you have, can't provide it for privacy reasons, and it's useless as the fail isn't reproducible in copies, failing region: in col AF about 300 formulas totaling from their respective row, e.g. in AF70: '=SUM(D70:AD70)' - that's the affected cell -, theese formulas are grouped in blocks, sometimes single, most 2 to 30 identic, one big block over 100, the blocks are separated by empty cells, in two positions are additional formulas which total from a part of the column below it, e.g. in AF62: '=SUM(AF64:AF282)' - which includes AF70, the block where AF70 is in is old-24, new-25 'shared formulas', all other formulas are 'inside' their respective row, no cross row calculations, steps the error evolved: - inserted one row at row 69 with 'alt-s r a', 'insert row above', making the former row 69 to now row 70, - copied 'now row 70' to row 69 with ctrl-c - ctrl-v to get the needed formulas, - cell AF70 with the formula above is totaling '1' from cell M70 and '1' from cell U70 to '2', - pasting a '1' in cell I70 failed to update AF70, still '2', expected '3', as far as i understand: a group of 24 shared formulas was split between position 1 and 2, formula from position 3 (former 2) is copied to position 2, position 3 lost it's 'autocalc capability' (the property listening to updates of referenced cells), doe's that help to catch the bug? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
