[Libreoffice-commits] core.git: icon-themes/elementary icon-themes/elementary_svg
icon-themes/elementary/cmd/32/animationeffects.png |binary icon-themes/elementary/cmd/32/animationmode.png|binary icon-themes/elementary/cmd/32/cone.png |binary icon-themes/elementary/cmd/32/convertinto3d.png|binary icon-themes/elementary/cmd/32/cube.png |binary icon-themes/elementary/cmd/32/cylinder.png |binary icon-themes/elementary/cmd/32/cyramid.png |binary icon-themes/elementary/cmd/32/datadatapilotrun.png |binary icon-themes/elementary/cmd/32/deletepivottable.png |binary icon-themes/elementary/cmd/32/diaeffect.png|binary icon-themes/elementary/cmd/32/extrusiontiltdown.png|binary icon-themes/elementary/cmd/32/extrusiontiltleft.png|binary icon-themes/elementary/cmd/32/extrusiontiltright.png |binary icon-themes/elementary/cmd/32/extrusiontiltup.png |binary icon-themes/elementary/cmd/32/fliphorizontal.png |binary icon-themes/elementary/cmd/32/flipvertical.png |binary icon-themes/elementary/cmd/32/halfsphere.png |binary icon-themes/elementary/cmd/32/insertobject.png |binary icon-themes/elementary/cmd/32/insertobjectdialog.png |binary icon-themes/elementary/cmd/32/mirror.png |binary icon-themes/elementary/cmd/32/mirrorvert.png |binary icon-themes/elementary/cmd/32/objectmenu.png |binary icon-themes/elementary/cmd/32/recalcpivottable.png |binary icon-themes/elementary/cmd/32/renameobject.png |binary icon-themes/elementary/cmd/32/setobjecttobackground.png|binary icon-themes/elementary/cmd/32/setobjecttoforeground.png|binary icon-themes/elementary/cmd/32/shell3d.png |binary icon-themes/elementary/cmd/32/sphere.png |binary icon-themes/elementary/cmd/32/torus.png|binary icon-themes/elementary/cmd/lc_animationeffects.png |binary icon-themes/elementary/cmd/lc_animationmode.png|binary icon-themes/elementary/cmd/lc_cone.png |binary icon-themes/elementary/cmd/lc_convertinto3d.png|binary icon-themes/elementary/cmd/lc_crookrotate.png |binary icon-themes/elementary/cmd/lc_crookslant.png |binary icon-themes/elementary/cmd/lc_cylinder.png |binary icon-themes/elementary/cmd/lc_datadatapilotrun.png |binary icon-themes/elementary/cmd/lc_deletepivottable.png |binary icon-themes/elementary/cmd/lc_diaeffect.png|binary icon-themes/elementary/cmd/lc_extrusiontiltdown.png|binary icon-themes/elementary/cmd/lc_extrusiontiltleft.png|binary icon-themes/elementary/cmd/lc_extrusiontiltright.png |binary icon-themes/elementary/cmd/lc_extrusiontiltup.png |binary icon-themes/elementary/cmd/lc_fliphorizontal.png |binary icon-themes/elementary/cmd/lc_flipvertical.png |binary icon-themes/elementary/cmd/lc_halfsphere.png |binary icon-themes/elementary/cmd/lc_mirror.png |binary icon-themes/elementary/cmd/lc_mirrorvert.png |binary icon-themes/elementary/cmd/lc_objectmenu.png |binary icon-themes/elementary/cmd/lc_recalcpivottable.png |binary icon-themes/elementary/cmd/lc_renameobject.png |binary icon-themes/elementary/cmd/lc_shell3d.png |binary icon-themes/elementary/cmd/lc_sphere.png |binary icon-themes/elementary/cmd/lc_torus.png|binary icon-themes/elementary/cmd/sc_animationeffects.png |binary icon-themes/elementary/cmd/sc_animationmode.png|binary icon-themes/elementary/cmd/sc_crookrotate.png |binary icon-themes/elementary/cmd/sc_crookslant.png |binary icon-themes/elementary/cmd/sc_diaeffect.png|binary icon-themes/elementary/cmd/sc_mirror.png |binary icon-themes/elementary/cmd/sc_mirrorvert.png |binary icon-themes/elementary/cmd/sc_objectmenu.png |binary icon-themes/elementary/cmd/sc_setobjecttobackground.png|binary icon-themes/elementary/cmd/sc_setobjecttoforeground.png|binary icon-themes/elementary/cmd/sc_shell3d.png |binary icon-themes/elementary/cmd/sc_sphere.png |binary icon-themes/elementary/res/base128.png |binary icon-themes/elementary/res/lx03245.png |binary icon-themes/elementary/res/odb_16_8.png|binary
[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - oox/source sd/qa
oox/source/drawingml/diagram/diagramlayoutatoms.cxx |5 -
sd/qa/unit/data/pptx/smartart-pyramid-1child.pptx |binary
sd/qa/unit/import-tests-smartart.cxx| 15 +++
3 files changed, 19 insertions(+), 1 deletion(-)
New commits:
commit 21755f2ab58cc053f9555c3d77241689c225d233
Author: Miklos Vajna
AuthorDate: Tue Jan 12 10:13:14 2021 +0100
Commit: Xisco Fauli
CommitDate: Wed Jan 13 08:53:38 2021 +0100
oox smartart: fix crash in pyra algorithm with a single child shape
Regression from commit 14a56533ff2c9c859d22cd3039ada75b99e94bc0
(SmartArt Pyramid: Now lays out shapes, 2018-07-10), the added pyramid
algorithm by first centering the topmost children, then decrementing the
horizontal postion of each additional shape, with the end goal of having
0 horizontal position of the last children.
This means that simply avoiding the division in the 1-child case leads
to correct results, because in this case the only child is also the last
child at the sane time.
(cherry picked from commit f2e04fe98e313cffa3f98d55eae641415142a431)
Change-Id: Ifd0027e9616b0909dbfde43e1555427b50de4dad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109120
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
b/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
index 7f926cc9a5e8..24acaf176491 100644
--- a/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
+++ b/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
@@ -1286,7 +1286,10 @@ void AlgAtom::layoutShape(const ShapePtr& rShape, const
std::vector&
for (auto & aCurrShape : rShape->getChildren())
{
aCurrShape->setPosition(aCurrPos);
-aCurrPos.X -= aChildSize.Height/(nCount-1);
+if (nCount > 1)
+{
+aCurrPos.X -= aChildSize.Height / (nCount - 1);
+}
aChildSize.Width += aChildSize.Height;
aCurrShape->setSize(aChildSize);
aCurrShape->setChildSize(aChildSize);
diff --git a/sd/qa/unit/data/pptx/smartart-pyramid-1child.pptx
b/sd/qa/unit/data/pptx/smartart-pyramid-1child.pptx
new file mode 100644
index ..42e43c54bbc4
Binary files /dev/null and b/sd/qa/unit/data/pptx/smartart-pyramid-1child.pptx
differ
diff --git a/sd/qa/unit/import-tests-smartart.cxx
b/sd/qa/unit/import-tests-smartart.cxx
index 4fe544a86000..b243a2bc395f 100644
--- a/sd/qa/unit/import-tests-smartart.cxx
+++ b/sd/qa/unit/import-tests-smartart.cxx
@@ -75,6 +75,7 @@ public:
void testRotation();
void testTextAutoRotation();
void testPyramid();
+void testPyramidOneChild();
void testChevron();
void testCycle();
void testvenndiagram();
@@ -125,6 +126,7 @@ public:
CPPUNIT_TEST(testRotation);
CPPUNIT_TEST(testTextAutoRotation);
CPPUNIT_TEST(testPyramid);
+CPPUNIT_TEST(testPyramidOneChild);
CPPUNIT_TEST(testChevron);
CPPUNIT_TEST(testCycle);
CPPUNIT_TEST(testHierarchy);
@@ -429,6 +431,19 @@ void SdImportTestSmartArt::testPyramid()
//FIXME : so far this only introduce the test document, but the actual
importer was not fixed yet.
}
+void SdImportTestSmartArt::testPyramidOneChild()
+{
+// Load a document with a pyra algorithm in it.
+// Without the accompanying fix in place, this test would have crashed.
+sd::DrawDocShellRef xDocShRef = loadURL(
+
m_directories.getURLFromSrc(u"sd/qa/unit/data/pptx/smartart-pyramid-1child.pptx"),
PPTX);
+uno::Reference xGroup(getShapeFromPage(0, 0, xDocShRef),
uno::UNO_QUERY);
+uno::Reference xText(getChildShape(getChildShape(xGroup,
1), 1),
+ uno::UNO_QUERY);
+// Verify that the text of the only child is imported correctly.
+CPPUNIT_ASSERT_EQUAL(OUString("A"), xText->getString());
+}
+
void SdImportTestSmartArt::testChevron()
{
sd::DrawDocShellRef xDocShRef =
loadURL(m_directories.getURLFromSrc("sd/qa/unit/data/pptx/smartart-chevron.pptx"),
PPTX);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/jsdialog vcl/source
include/vcl/window.hxx |3 --
vcl/inc/jsdialog/jsdialogbuilder.hxx | 11 ---
vcl/inc/window.h |2 -
vcl/jsdialog/jsdialogbuilder.cxx | 52 +++
vcl/source/window/window.cxx | 14 -
5 files changed, 6 insertions(+), 76 deletions(-)
New commits:
commit 8cbf3938ee3951ef53842bb5664bea6b57828111
Author: Szymon Kłos
AuthorDate: Wed Dec 30 10:05:26 2020 +0100
Commit: Szymon Kłos
CommitDate: Wed Jan 13 08:47:15 2021 +0100
Revert "jsdialog: disable idle notify"
This reverts commit 71ec214d7583f637fefcb5eca13c637cc6b38029.
and partially 54b5e6b4e083ce7a71e16ef622753898f38dc8ab
freeze/thaw functionality was added so no longer needed.
Change-Id: Iee29fa79bcebfd409fd3cea4f11cb1d48053daa6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108509
Tested-by: Jenkins
Reviewed-by: Szymon Kłos
diff --git a/include/vcl/window.hxx b/include/vcl/window.hxx
index bf4a8790ae25..1a164c0654ed 100644
--- a/include/vcl/window.hxx
+++ b/include/vcl/window.hxx
@@ -1178,9 +1178,6 @@ public:
/// Find an existing Window based on the LOKWindowId.
static VclPtr FindLOKWindow(vcl::LOKWindowId
nWindowId);
-boolIsDisableIdleNotify();
-voidSetDisableIdleNotify(bool bValue);
-
/// check if LOK Window container is empty
static bool IsLOKWindowsEmpty();
diff --git a/vcl/inc/jsdialog/jsdialogbuilder.hxx
b/vcl/inc/jsdialog/jsdialogbuilder.hxx
index c31c3e5fa560..2df2aaeb3ad1 100644
--- a/vcl/inc/jsdialog/jsdialogbuilder.hxx
+++ b/vcl/inc/jsdialog/jsdialogbuilder.hxx
@@ -73,7 +73,6 @@ public:
virtual void notifyDialogState(bool bForce = false);
void sendClose();
-void dumpStatus();
virtual void sendUpdate(VclPtr pWindow);
};
@@ -250,11 +249,6 @@ public:
class JSDialog : public JSWidget
{
-DECL_LINK(on_dump_status, void*, void);
-DECL_LINK(on_window_event, VclWindowEvent&, void);
-
-bool m_bNotifyCreated;
-
public:
JSDialog(VclPtr aNotifierWindow, VclPtr
aContentWindow,
::Dialog* pDialog, SalInstanceBuilder* pBuilder, bool
bTakeOwnership,
@@ -343,11 +337,6 @@ public:
class JSMessageDialog : public SalInstanceMessageDialog, public JSDialogSender
{
-DECL_LINK(on_dump_status, void*, void);
-DECL_LINK(on_window_event, VclWindowEvent&, void);
-
-bool m_bNotifyCreated;
-
public:
JSMessageDialog(::MessageDialog* pDialog, VclPtr
aContentWindow,
SalInstanceBuilder* pBuilder, bool bTakeOwnership);
diff --git a/vcl/inc/window.h b/vcl/inc/window.h
index a6d46c41eeda..a14852ca02c0 100644
--- a/vcl/inc/window.h
+++ b/vcl/inc/window.h
@@ -117,8 +117,6 @@ struct ImplWinData
sal_uInt16 mnIsTopWindow;
boolmbMouseOver;//< tracks mouse over for
native widget paint effect
boolmbEnableNativeWidget; //< toggle native widget
rendering
-boolmbDisableIdleNotify;
-
::std::list< VclPtr >
maTopWindowChildren;
diff --git a/vcl/jsdialog/jsdialogbuilder.cxx b/vcl/jsdialog/jsdialogbuilder.cxx
index f33d0be85fd5..df2d68e71c16 100644
--- a/vcl/jsdialog/jsdialogbuilder.cxx
+++ b/vcl/jsdialog/jsdialogbuilder.cxx
@@ -159,8 +159,7 @@ void JSDialogNotifyIdle::sendClose() {
send(*generateCloseMessage()); }
void JSDialogSender::notifyDialogState(bool bForce)
{
-auto aNotifierWnd = mpIdleNotify->getNotifierWindow();
-if (aNotifierWnd && aNotifierWnd->IsDisableIdleNotify())
+if (!mpIdleNotify->getNotifierWindow())
return;
if (bForce)
@@ -170,8 +169,6 @@ void JSDialogSender::notifyDialogState(bool bForce)
void JSDialogSender::sendClose() { mpIdleNotify->sendClose(); }
-void JSDialogSender::dumpStatus() { mpIdleNotify->Invoke(); }
-
void JSDialogSender::sendUpdate(VclPtr pWindow)
{
mpIdleNotify->updateStatus(pWindow);
@@ -461,16 +458,13 @@ std::unique_ptr
JSInstanceBuilder::weld_dialog(const OString& id)
m_xBuilder->drop_ownership(pDialog);
m_bHasTopLevelDialog = true;
-if (id == "MacroSelectorDialog")
-pDialog->SetDisableIdleNotify(true);
-
pRet.reset(
new JSDialog(m_aOwnedToplevel, m_aOwnedToplevel, pDialog, this,
false, m_sTypeOfJSON));
RememberWidget("__DIALOG__", pRet.get());
const vcl::ILibreOfficeKitNotifier* pNotifier =
pDialog->GetLOKNotifier();
-if (pNotifier && id != "MacroSelectorDialog")
+if (pNotifier)
{
tools::JsonWriter aJsonWriter;
m_aOwnedToplevel->DumpAsPropertyTree(aJsonWriter);
@@ -497,14 +491,14 @@ std::unique_ptr
JSInstanceBuilder::weld_message_dialog(cons
assert(!m_aOwnedToplevel && "only one toplevel per .ui allowed");
[Libreoffice-bugs] [Bug 135310] [META] Writer outline view bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=135310 Bug 135310 depends on bug 138136, which changed state. Bug 138136 Summary: EDITING Collapsing first of two consecutive headings does nothing https://bugs.documentfoundation.org/show_bug.cgi?id=138136 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138136] EDITING Collapsing first of two consecutive headings does nothing
https://bugs.documentfoundation.org/show_bug.cgi?id=138136 Jim Raykowski changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126084] DOCX/OOXML support of SVG images via Office Drawing extension and fallback (published schema)
https://bugs.documentfoundation.org/show_bug.cgi?id=126084 NISZ LibreOffice Team changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=82 ||267 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82267] Add warning that inserting an .svg file will get converted to bitmap when converting to OOXML formatted .pptx
https://bugs.documentfoundation.org/show_bug.cgi?id=82267 NISZ LibreOffice Team changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||6084 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: download.lst external/pdfium
download.lst |
4
external/pdfium/AnnotationBorderProperties.patch.1 |
89 --
external/pdfium/AnnotationInkAndVertices.patch.1 |
260 ---
external/pdfium/AnnotationLineStartAndEnd.patch.1|
103 --
external/pdfium/FPDF_GetTrailerEnds-make-this-not-depend-on-whitespa.patch.1 |
55 -
external/pdfium/SignatureGetDocMDPPermission.patch.1 |
345 --
external/pdfium/UnpackedTarball_pdfium.mk|
11
7 files changed, 2 insertions(+), 865 deletions(-)
New commits:
commit 229ee7c0ff5a69f09d6ac87dd585a11a8aacdcab
Author: Miklos Vajna
AuthorDate: Tue Jan 12 21:07:24 2021 +0100
Commit: Miklos Vajna
CommitDate: Wed Jan 13 08:33:14 2021 +0100
external: update pdfium to 4380
Allows dropping 5 upstreamed patches.
Change-Id: I5f77502c5a2d11288b060956e69fd7767f52ab97
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109195
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/download.lst b/download.lst
index 693608947f18..f4a442525c03 100644
--- a/download.lst
+++ b/download.lst
@@ -212,8 +212,8 @@ export OWNCLOUD_ANDROID_LIB_SHA256SUM :=
b18b3e3ef7fae6a79b62f2bb43cc47a5346b633
export OWNCLOUD_ANDROID_LIB_TARBALL :=
owncloud-android-library-0.9.4-no-binary-deps.tar.gz
export PAGEMAKER_SHA256SUM :=
66adacd705a7d19895e08eac46d1e851332adf2e736c566bef1164e7a442519d
export PAGEMAKER_TARBALL := libpagemaker-0.0.4.tar.xz
-export PDFIUM_SHA256SUM :=
eca406d47ac7e2a84dcc86f93c08f96e591d409589e881477fa75e488e4851d8
-export PDFIUM_TARBALL := pdfium-4306.tar.bz2
+export PDFIUM_SHA256SUM :=
7676aba84cb064e5e6f3a5173284087372761d1f704b0626570fce0445de520e
+export PDFIUM_TARBALL := pdfium-4380.tar.bz2
export PIXMAN_SHA256SUM :=
21b6b249b51c6800dc9553b65106e1e37d0e25df942c90531d4c3997aa20a88e
export PIXMAN_TARBALL := e80ebae4da01e77f68744319f01d52a3-pixman-0.34.0.tar.gz
export LIBPNG_SHA256SUM :=
505e70834d35383537b6491e7ae8641f1a4bed1876dbfe361201fc80868d88ca
diff --git a/external/pdfium/AnnotationBorderProperties.patch.1
b/external/pdfium/AnnotationBorderProperties.patch.1
deleted file mode 100644
index 0dc42e1f95f5..
--- a/external/pdfium/AnnotationBorderProperties.patch.1
+++ /dev/null
@@ -1,89 +0,0 @@
-From 305d2ed186c9e1e7c3d0f914235e926e27b35a9f Mon Sep 17 00:00:00 2001
-From: Miklos Vajna
-Date: Tue, 15 Dec 2020 17:28:49 +
-Subject: [PATCH] Add FPDFAnnot_GetBorder() API
-
-This is similar to FPDFAnnot_GetLine(), but a /Border key is valid for
-all annotation types.
-
-The array can have an optional 4th element, but that itself doesn't have
-a fixed size, so it's not exposed by this API -- could be done by a
-separate function.
-
-Change-Id: I796c2ea17be1f039a6c6129dbde0b0a22276e19a
-Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/77010
-Commit-Queue: Tom Sepez
-Reviewed-by: Tom Sepez
- fpdfsdk/fpdf_annot.cpp | 23 +
- fpdfsdk/fpdf_annot_embeddertest.cpp | 40 +
- fpdfsdk/fpdf_view_c_api_test.c | 1 +
- public/fpdf_annot.h | 16
- testing/resources/line_annot.in | 2 ++
- testing/resources/line_annot.pdf| 6 +++--
- 6 files changed, 86 insertions(+), 2 deletions(-)
-
-diff --git a/fpdfsdk/fpdf_annot.cpp b/fpdfsdk/fpdf_annot.cpp
-index 85f86e547..eee3567d4 100644
a/fpdfsdk/fpdf_annot.cpp
-+++ b/fpdfsdk/fpdf_annot.cpp
-@@ -913,6 +913,29 @@ FPDF_EXPORT FPDF_BOOL FPDF_CALLCONV
FPDFAnnot_GetLine(FPDF_ANNOTATION annot,
- return true;
- }
-
-+FPDF_EXPORT FPDF_BOOL FPDF_CALLCONV
-+FPDFAnnot_GetBorder(FPDF_ANNOTATION annot,
-+float* horizontal_radius,
-+float* vertical_radius,
-+float* border_width) {
-+ if (!horizontal_radius || !vertical_radius || !border_width)
-+return false;
-+
-+ CPDF_Dictionary* annot_dict = GetAnnotDictFromFPDFAnnotation(annot);
-+ if (!annot_dict)
-+return false;
-+
-+ CPDF_Array* border = annot_dict->GetArrayFor(pdfium::annotation::kBorder);
-+ if (!border || border->size() < 3)
-+return false;
-+
-+ *horizontal_radius = border->GetNumberAt(0);
-+ *vertical_radius = border->GetNumberAt(1);
-+ *border_width = border->GetNumberAt(2);
-+
-+ return true;
-+}
-+
- FPDF_EXPORT FPDF_BOOL FPDF_CALLCONV FPDFAnnot_HasKey(FPDF_ANNOTATION annot,
- FPDF_BYTESTRING key) {
- CPDF_Dictionary* pAnnotDict = GetAnnotDictFromFPDFAnnotation(annot);
-diff --git a/public/fpdf_annot.h b/public/fpdf_annot.h
-index 6c8a237e7..2b708af13 100644
a/public/fpdf_annot.h
-+++ b/public/fpdf_annot.h
-@@ -452,6 +452,22 @@ FPDF_EXPORT FPDF_BOOL FPDF_CALLCONV
FPDFAnnot_GetLine(FPDF_ANNOTATION annot,
- FS_POINTF* start,
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/tiledrendering/tiledrendering.cxx | 43 +
sw/source/uibase/docvw/edtwin.cxx | 10 +
2 files changed, 52 insertions(+), 1 deletion(-)
New commits:
commit 0c03a97fb8844ad0de1abea79b5265617a509460
Author: Miklos Vajna
AuthorDate: Tue Jan 12 17:10:49 2021 +0100
Commit: Miklos Vajna
CommitDate: Wed Jan 13 08:32:51 2021 +0100
sw edit win: fix read-only selections while handling ExtTextInput
When typing into a protected section (or other read-only area), the code
goes through SwEditWin::KeyInput(), which checks for HasReadonlySel(),
and calls into sw::DocumentContentOperationsManager::InsertString() in
the read-write case.
When typing via ExtTextInput (e.g. Online), then SwEditWin::Command()
called into sw::DocumentContentOperationsManager::InsertString() without
such a check.
The convention is to do a read-only check in the first Writer function
called by vcl, so handle this in SwEditWin::Command(), to have exactly 1
read-only popup on typing a character.
Change-Id: I7d002e7d76bffeb6f16750de735c5bbf13a7bba9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109186
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index 936066755825..10d54fc91e2e 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -17,6 +17,7 @@
#include
#include
#include
+#include
#include
#include
@@ -146,6 +147,7 @@ public:
void testDropDownFormFieldButtonNoItem();
void testTablePaintInvalidate();
void testSpellOnlineRenderParameter();
+void testExtTextInputReadOnly();
CPPUNIT_TEST_SUITE(SwTiledRenderingTest);
CPPUNIT_TEST(testRegisterCallback);
@@ -219,6 +221,7 @@ public:
CPPUNIT_TEST(testDropDownFormFieldButtonNoItem);
CPPUNIT_TEST(testTablePaintInvalidate);
CPPUNIT_TEST(testSpellOnlineRenderParameter);
+CPPUNIT_TEST(testExtTextInputReadOnly);
CPPUNIT_TEST_SUITE_END();
private:
@@ -2886,6 +2889,46 @@ void
SwTiledRenderingTest::testSpellOnlineRenderParameter()
CPPUNIT_ASSERT_EQUAL(!bSet, pOpt->IsOnlineSpell());
}
+void SwTiledRenderingTest::testExtTextInputReadOnly()
+{
+// Create a document with a protected section + a normal paragraph after
it.
+SwXTextDocument* pXTextDocument = createDoc();
+uno::Reference xController(
+pXTextDocument->getCurrentController(), uno::UNO_QUERY);
+uno::Reference xCursor =
xController->getViewCursor();
+uno::Reference xText = xCursor->getText();
+uno::Reference xSection(
+pXTextDocument->createInstance("com.sun.star.text.TextSection"),
uno::UNO_QUERY);
+uno::Reference xSectionProps(xSection,
uno::UNO_QUERY);
+xSectionProps->setPropertyValue("IsProtected", uno::Any(true));
+xText->insertTextContent(xCursor, xSection, /*bAbsorb=*/true);
+
+// First paragraph is the protected section, is it empty?
+VclPtr pEditWin = pXTextDocument->getDocWindow();
+CPPUNIT_ASSERT(pEditWin);
+CPPUNIT_ASSERT(getParagraph(1)->getString().isEmpty());
+
+// Try to type into the protected section, is it still empty?
+SwWrtShell* pWrtShell = pXTextDocument->GetDocShell()->GetWrtShell();
+pWrtShell->SttEndDoc(/*bStt=*/true);
+SfxLokHelper::postExtTextEventAsync(pEditWin, LOK_EXT_TEXTINPUT, "x");
+SfxLokHelper::postExtTextEventAsync(pEditWin, LOK_EXT_TEXTINPUT_END, "x");
+Scheduler::ProcessEventsToIdle();
+// Without the accompanying fix in place, this test would have failed, as
it was possible to
+// type into the protected section.
+CPPUNIT_ASSERT(getParagraph(1)->getString().isEmpty());
+
+// Second paragraph is a normal paragraph, is it empty?
+pWrtShell->Down(/*bSelect=*/false);
+CPPUNIT_ASSERT(getParagraph(2)->getString().isEmpty());
+
+// Try to type into the protected section, does it have the typed content?
+SfxLokHelper::postExtTextEventAsync(pEditWin, LOK_EXT_TEXTINPUT, "x");
+SfxLokHelper::postExtTextEventAsync(pEditWin, LOK_EXT_TEXTINPUT_END, "x");
+Scheduler::ProcessEventsToIdle();
+CPPUNIT_ASSERT_EQUAL(OUString("x"), getParagraph(2)->getString());
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(SwTiledRenderingTest);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/source/uibase/docvw/edtwin.cxx
b/sw/source/uibase/docvw/edtwin.cxx
index 7edaa5eea53a..2bb328138d6e 100644
--- a/sw/source/uibase/docvw/edtwin.cxx
+++ b/sw/source/uibase/docvw/edtwin.cxx
@@ -5556,7 +5556,7 @@ void SwEditWin::Command( const CommandEvent& rCEvt )
{
bool bIsDocReadOnly = m_rView.GetDocShell()->IsReadOnly() &&
rSh.IsCursorReadonly();
-if(!bIsDocReadOnly)
+if (!bIsDocReadOnly && !rSh.HasReadonlySel())
{
if( m_pQuickHlpData->m_bIsDisplayed )
[Libreoffice-bugs] [Bug 107642] [META] Paragraph dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107642 Dieter changed: What|Removed |Added Depends on|122145 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122145 [Bug 122145] PARAGRAPH BORDERS: Border styles "Thin Thick" are misaligned in the corners -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122145] PARAGRAPH BORDERS: Border styles "Thin Thick" are misaligned in the corners
https://bugs.documentfoundation.org/show_bug.cgi?id=122145 Dieter changed: What|Removed |Added Blocks|107642 | Summary|PARAGRAPH DIALOG: Border|PARAGRAPH BORDERS: Border |styles "Thin Thick" are |styles "Thin Thick" are |misaligned in the corners |misaligned in the corners Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107642 [Bug 107642] [META] Paragraph dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122145] PARAGRAPH DIALOG: Border styles "Thin Thick" are misaligned in the corners
https://bugs.documentfoundation.org/show_bug.cgi?id=122145 Dieter changed: What|Removed |Added Summary|PARAGRAPH DIALOG: Border|PARAGRAPH DIALOG: Border |styles and tooltips don't |styles "Thin Thick" are |match (see comment 3) |misaligned in the corners --- Comment #12 from Dieter --- Tested again with Version: 7.0.4.2 (x64) Build ID: dcf040e67528d9187c66b2379df5ea4407429775 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Results: Double => O.K. Double thin => O.K. Thin Thick Small => Not O.K. Thin Thick Medium => Not O.K. Thin Thick Large => Better, but not perfect Thick Thin Small => O.K. Thick Thin Medium => O.K. Thick Thin Large => O.K. So it's the same result that is described in commen 9: Problem is only with Thin Thick Borders => I changed bug summary -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139538] Cannot load HsqlDB other than 1.8.0
https://bugs.documentfoundation.org/show_bug.cgi?id=139538 prrv...@gmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||5618 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125618] JavaDriverClassPath doesn't modify JVM ClassPath
https://bugs.documentfoundation.org/show_bug.cgi?id=125618 prrv...@gmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||9538 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136916] Underline menu lines not visible in dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=136916 Dieter changed: What|Removed |Added Summary|Underline menu lines not|Underline menu lines not |visible |visible in dark mode -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130913] FIRST PAGE HEADER cannot be edited independently on Endnotes pages, and end-of-document Footnotes pages
https://bugs.documentfoundation.org/show_bug.cgi?id=130913 --- Comment #7 from Justin L --- It looks to me like these two bugs are duplicates. The same thing said in bug 131132 comment 2 is true here - if you switch to web view, and then back again, the first page header of the endnotes is empty, and left and right have different contents. (Of course, the contents are messed up, but I assume that is caused by confusion over what the program was displaying earlier.) So - it doesn't seem as if there is anything limiting these two styles to not use a different first (or left/right) header/footer, but the layout is not cooperating. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129434] [META] Writer (EDITING) Suggested bug fixes, enhancements and features for authors.
https://bugs.documentfoundation.org/show_bug.cgi?id=129434 Dieter changed: What|Removed |Added Depends on||137160 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=137160 [Bug 137160] ALPHABETICAL INDEX: need to add thin space between page reference and f./ff. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89606] [META] Table of Contents and Indexes bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=89606 Dieter changed: What|Removed |Added Depends on||137160 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=137160 [Bug 137160] ALPHABETICAL INDEX: need to add thin space between page reference and f./ff. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137160] ALPHABETICAL INDEX: need to add thin space between page reference and f./ff.
https://bugs.documentfoundation.org/show_bug.cgi?id=137160 Dieter changed: What|Removed |Added Keywords||needsUXEval Blocks||129434, 89606 Whiteboard| QA:needsComment| CC||dgp-m...@gmx.de, ||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #1 from Dieter --- Thia is the question, if LO follows a certain style (could also be CMOS and some others). Unfortunately there is no internal guideline for that. I still think, at least Design-Team needs an internal consensus about it. cc: Design-Team for further input and decision Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=89606 [Bug 89606] [META] Table of Contents and Indexes bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=129434 [Bug 129434] [META] Writer (EDITING) Suggested bug fixes, enhancements and features for authors. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 137160] ALPHABETICAL INDEX: need to add thin space between page reference and f./ff.
https://bugs.documentfoundation.org/show_bug.cgi?id=137160 Dieter changed: What|Removed |Added Keywords||needsUXEval Blocks||129434, 89606 Whiteboard| QA:needsComment| CC||dgp-m...@gmx.de, ||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #1 from Dieter --- Thia is the question, if LO follows a certain style (could also be CMOS and some others). Unfortunately there is no internal guideline for that. I still think, at least Design-Team needs an internal consensus about it. cc: Design-Team for further input and decision Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=89606 [Bug 89606] [META] Table of Contents and Indexes bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=129434 [Bug 129434] [META] Writer (EDITING) Suggested bug fixes, enhancements and features for authors. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: include/svx svx/source
include/svx/devtools/DevelopmentToolDockingWindow.hxx |5 -
svx/source/devtools/DevelopmentToolDockingWindow.cxx | 89 +-
2 files changed, 91 insertions(+), 3 deletions(-)
New commits:
commit 6d0ae96a158d8c883cf7cbbf300a92ca80c73284
Author: Tomaž Vajngerl
AuthorDate: Thu Dec 24 17:12:48 2020 +0900
Commit: Tomaž Vajngerl
CommitDate: Wed Jan 13 08:00:39 2021 +0100
devtools: Add selection change listener to DevTools
Selection listener is needed so it is possible to react when the
selection changes in the document.
Change-Id: I94e9da06b3ceedbad13dd203f690037f3eafdb13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108259
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/svx/devtools/DevelopmentToolDockingWindow.hxx
b/include/svx/devtools/DevelopmentToolDockingWindow.hxx
index 89030c0652e1..30499379f32e 100644
--- a/include/svx/devtools/DevelopmentToolDockingWindow.hxx
+++ b/include/svx/devtools/DevelopmentToolDockingWindow.hxx
@@ -15,13 +15,15 @@
#include
#include
+#include
+#include
+
class SAL_WARN_UNUSED SVX_DLLPUBLIC DevelopmentToolChildWindow final : public
SfxChildWindow
{
SFX_DECL_CHILDWINDOW_WITHID(DevelopmentToolChildWindow);
DevelopmentToolChildWindow(vcl::Window* pParentWindow, sal_uInt16 nId,
SfxBindings* pBindings,
SfxChildWinInfo* pInfo);
-virtual ~DevelopmentToolChildWindow() override;
};
class SAL_WARN_UNUSED SVX_DLLPUBLIC DevelopmentToolDockingWindow final :
public SfxDockingWindow
@@ -29,6 +31,7 @@ class SAL_WARN_UNUSED SVX_DLLPUBLIC
DevelopmentToolDockingWindow final : public
public:
DevelopmentToolDockingWindow(SfxBindings* pBindings, SfxChildWindow*
pChildWindow,
vcl::Window* pParent);
+
virtual ~DevelopmentToolDockingWindow() override;
virtual void ToggleFloatingMode() override;
diff --git a/svx/source/devtools/DevelopmentToolDockingWindow.cxx
b/svx/source/devtools/DevelopmentToolDockingWindow.cxx
index a435cd9b9c04..7d2626ae7978 100644
--- a/svx/source/devtools/DevelopmentToolDockingWindow.cxx
+++ b/svx/source/devtools/DevelopmentToolDockingWindow.cxx
@@ -12,10 +12,85 @@
#include
+#include
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include
+
#include
#include
#include
+#include
+
+#include
+
+#include
+#include
+
+#include
+#include
+
+#include
+
+using namespace css;
+
+namespace
+{
+void introspect(uno::Reference const& xInterface)
+{
+if (!xInterface.is())
+return;
+
+uno::Reference xContext =
comphelper::getProcessComponentContext();
+if (!xContext.is())
+return;
+}
+
+typedef cppu::WeakComponentImplHelper
+SelectionChangeHandlerInterfaceBase;
+
+class SelectionChangeHandler final : private ::cppu::BaseMutex,
+ public SelectionChangeHandlerInterfaceBase
+{
+private:
+css::uno::Reference mxController;
+
+public:
+SelectionChangeHandler(const css::uno::Reference&
rxController)
+: SelectionChangeHandlerInterfaceBase(m_aMutex)
+, mxController(rxController)
+{
+}
+
+virtual void SAL_CALL selectionChanged(const css::lang::EventObject&
/*rEvent*/) override
+{
+uno::Reference xSupplier(mxController,
uno::UNO_QUERY);
+if (xSupplier.is())
+{
+uno::Any aAny = xSupplier->getSelection();
+auto aRef = aAny.get>();
+introspect(aRef);
+}
+}
+virtual void SAL_CALL disposing(const css::lang::EventObject& /*rEvent*/)
override {}
+virtual void SAL_CALL disposing() override {}
+
+private:
+SelectionChangeHandler(const SelectionChangeHandler&) = delete;
+SelectionChangeHandler& operator=(const SelectionChangeHandler&) = delete;
+};
+
+} // end anonymous namespace
+
SFX_IMPL_DOCKINGWINDOW_WITHID(DevelopmentToolChildWindow,
SID_DEVELOPMENT_TOOLS_DOCKING_WINDOW);
DevelopmentToolChildWindow::DevelopmentToolChildWindow(vcl::Window*
pParentWindow, sal_uInt16 nId,
@@ -30,14 +105,24 @@
DevelopmentToolChildWindow::DevelopmentToolChildWindow(vcl::Window* pParentWindo
pWin->Initialize(pInfo);
}
-DevelopmentToolChildWindow::~DevelopmentToolChildWindow() {}
-
DevelopmentToolDockingWindow::DevelopmentToolDockingWindow(SfxBindings*
pInputBindings,
SfxChildWindow*
pChildWindow,
vcl::Window*
pParent)
: SfxDockingWindow(pInputBindings, pChildWindow, pParent,
"DevelopmentTool",
"svx/ui/developmenttool.ui")
{
+auto* pViewFrame = pInputBindings->GetDispatcher()->GetFrame();
+
+uno::Reference xCtrl =
pViewFrame->GetFrame().GetController();
+
+uno::Reference xSupplier(xCtrl, uno::UNO_QUERY);
+if (xSupplier.is())
+{
+uno::Reference
[Libreoffice-bugs] [Bug 139302] [UI] Demote Chapter in navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=139302 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de, ||libreoffice-ux-advise@lists ||.freedesktop.org, ||rayk...@gmail.com --- Comment #3 from Dieter --- cc: Design-Team cc: Jim Raykowski -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 139302] [UI] Demote Chapter in navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=139302 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de, ||libreoffice-ux-advise@lists ||.freedesktop.org, ||rayk...@gmail.com --- Comment #3 from Dieter --- cc: Design-Team cc: Jim Raykowski -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 139338] The distinction paragraph <-> Character direct formatting in style inspector seems a kind of pointless
https://bugs.documentfoundation.org/show_bug.cgi?id=139338 --- Comment #13 from Mike Kaganski --- (In reply to V Stuart Foote from comment #12) > Ouch, that was a little too harsh Mike Indeed. If only Telesto could accept that when they do not understand an answer, that means a need to learn something, not keep insisting on own PoV along with stating own right to keep ignorant. It's OK when casual user gets confused with how to use bug tracker, and also how to interact when the problem is discussed; but when a #1 bug filer keeps showing the same inappropriate attitude, it's ... inappropriate. (In reply to Telesto from comment #10) > 16.30.2 appears to > be about 'Paragraph Styles (styles!). And text style referencing to > "character style" (I guess) > > I'm talking about the relevance of "Paragraph *Direct Formatting*" next to > "Character *Direct Formatting* ". I'm not talking about "paragraph styles". See 3.15.3 : http://docs.oasis-open.org/office/OpenDocument/v1.3/OpenDocument-v1.3-part3-schema.html#element-office_automatic-styles for another technical description why description of styles is relevant to DF. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 139338] The distinction paragraph <-> Character direct formatting in style inspector seems a kind of pointless
https://bugs.documentfoundation.org/show_bug.cgi?id=139338 --- Comment #13 from Mike Kaganski --- (In reply to V Stuart Foote from comment #12) > Ouch, that was a little too harsh Mike Indeed. If only Telesto could accept that when they do not understand an answer, that means a need to learn something, not keep insisting on own PoV along with stating own right to keep ignorant. It's OK when casual user gets confused with how to use bug tracker, and also how to interact when the problem is discussed; but when a #1 bug filer keeps showing the same inappropriate attitude, it's ... inappropriate. (In reply to Telesto from comment #10) > 16.30.2 appears to > be about 'Paragraph Styles (styles!). And text style referencing to > "character style" (I guess) > > I'm talking about the relevance of "Paragraph *Direct Formatting*" next to > "Character *Direct Formatting* ". I'm not talking about "paragraph styles". See 3.15.3 : http://docs.oasis-open.org/office/OpenDocument/v1.3/OpenDocument-v1.3-part3-schema.html#element-office_automatic-styles for another technical description why description of styles is relevant to DF. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: include/o3tl
include/o3tl/lru_map.hxx |1 + 1 file changed, 1 insertion(+) New commits: commit e24cc814b5b6e50967116cb3908e4bf56b7aee4b Author: Stephan Bergmann AuthorDate: Tue Jan 12 15:50:10 2021 +0100 Commit: Stephan Bergmann CommitDate: Wed Jan 13 07:37:30 2021 +0100 Missing include (for std::min) Change-Id: I44eebee0149d7e890aeff715dd7ae0005c45378d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109179 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/include/o3tl/lru_map.hxx b/include/o3tl/lru_map.hxx index 96fb3161782d..ce5a078bc352 100644 --- a/include/o3tl/lru_map.hxx +++ b/include/o3tl/lru_map.hxx @@ -11,6 +11,7 @@ #ifndef INCLUDED_O3TL_LRU_MAP_HXX #define INCLUDED_O3TL_LRU_MAP_HXX +#include #include #include #include ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: connectivity/source sfx2/source vcl/source vcl/win
connectivity/source/drivers/ado/ADatabaseMetaDataImpl.cxx |2
connectivity/source/drivers/ado/AKeys.cxx |2
connectivity/source/drivers/ado/AStatement.cxx|2
connectivity/source/drivers/ado/Awrapado.cxx | 52 +++---
connectivity/source/inc/ado/AStatement.hxx|3
connectivity/source/inc/ado/Awrapado.hxx | 38 +-
connectivity/source/inc/ado/Awrapadox.hxx | 10 +-
connectivity/source/inc/ado/WrapCatalog.hxx |6 +
connectivity/source/inc/ado/WrapColumn.hxx|8 +-
connectivity/source/inc/ado/WrapIndex.hxx |6 +
connectivity/source/inc/ado/WrapKey.hxx |8 +-
connectivity/source/inc/ado/WrapTable.hxx |6 +
sfx2/source/appl/appdde.cxx | 12 ++-
vcl/source/opengl/win/WinDeviceInfo.cxx |3
vcl/source/opengl/win/context.cxx |5 -
vcl/win/dtrans/ImplHelper.cxx |4 -
vcl/win/dtrans/ImplHelper.hxx |8 +-
17 files changed, 107 insertions(+), 68 deletions(-)
New commits:
commit 363a3be9bb17bd85fd52c1f22abdf649e7cd0d0b
Author: Stephan Bergmann
AuthorDate: Tue Jan 12 15:45:50 2021 +0100
Commit: Stephan Bergmann
CommitDate: Wed Jan 13 07:36:57 2021 +0100
loplugin:stringviewparam (clang-cl)
Change-Id: Ie66996f905fcb68ee413171c8727cb42dcb28dbc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109178
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/connectivity/source/drivers/ado/ADatabaseMetaDataImpl.cxx
b/connectivity/source/drivers/ado/ADatabaseMetaDataImpl.cxx
index 3b39585c6f00..8972a4f2dee1 100644
--- a/connectivity/source/drivers/ado/ADatabaseMetaDataImpl.cxx
+++ b/connectivity/source/drivers/ado/ADatabaseMetaDataImpl.cxx
@@ -539,7 +539,7 @@ void WpADOTable::Create()
}
}
-OUString WpADOCatalog::GetObjectOwner(const OUString& _rName, ObjectTypeEnum
_eNum)
+OUString WpADOCatalog::GetObjectOwner(std::u16string_view _rName,
ObjectTypeEnum _eNum)
{
OLEVariant _rVar;
_rVar.setNoArg();
diff --git a/connectivity/source/drivers/ado/AKeys.cxx
b/connectivity/source/drivers/ado/AKeys.cxx
index 19027e79ffb6..0d921c39842b 100644
--- a/connectivity/source/drivers/ado/AKeys.cxx
+++ b/connectivity/source/drivers/ado/AKeys.cxx
@@ -71,7 +71,7 @@ sdbcx::ObjectType OKeys::appendObject( const OUString&, const
Reference< XProper
WpADOKey aKey = pKey->getImpl();
OUString sName = aKey.get_Name();
if(!sName.getLength())
-aKey.put_Name("PrimaryKey");
+aKey.put_Name(u"PrimaryKey");
ADOKeys* pKeys = m_aCollection;
if ( FAILED(pKeys->Append(OLEVariant(static_cast(aKey)),
diff --git a/connectivity/source/drivers/ado/AStatement.cxx
b/connectivity/source/drivers/ado/AStatement.cxx
index 6f2c14617e0e..599df13aba36 100644
--- a/connectivity/source/drivers/ado/AStatement.cxx
+++ b/connectivity/source/drivers/ado/AStatement.cxx
@@ -634,7 +634,7 @@ void OStatement_Base::setMaxFieldSize(sal_Int32 /*_par0*/)
::dbtools::throwFeatureNotImplementedSQLException(
"Statement::MaxFieldSize", *this );
}
-void OStatement_Base::setCursorName(const OUString &_par0)
+void OStatement_Base::setCursorName(std::u16string_view _par0)
{
::osl::MutexGuard aGuard( m_aMutex );
checkDisposed(OStatement_BASE::rBHelper.bDisposed);
diff --git a/connectivity/source/drivers/ado/Awrapado.cxx
b/connectivity/source/drivers/ado/Awrapado.cxx
index 0393dc35c9a2..6f4dd5ce1c20 100644
--- a/connectivity/source/drivers/ado/Awrapado.cxx
+++ b/connectivity/source/drivers/ado/Awrapado.cxx
@@ -58,7 +58,7 @@ OUString WpADOConnection::GetConnectionString() const
return aBSTR.asOUString();
}
-bool WpADOConnection::PutConnectionString(const OUString ) const
+bool WpADOConnection::PutConnectionString(std::u16string_view aCon) const
{
assert(pInterface);
OLEString bstr(aCon);
@@ -101,7 +101,7 @@ bool WpADOConnection::Close()
return (SUCCEEDED(pInterface->Close()));
}
-bool WpADOConnection::Execute(const OUString& CommandText,OLEVariant&
RecordsAffected,long Options, WpADORecordset** ppiRset)
+bool WpADOConnection::Execute(std::u16string_view CommandText,OLEVariant&
RecordsAffected,long Options, WpADORecordset** ppiRset)
{
assert(pInterface);
OLEString sStr1(CommandText);
@@ -128,7 +128,7 @@ bool WpADOConnection::RollbackTrans( )
return SUCCEEDED(pInterface->RollbackTrans());
}
-bool WpADOConnection::Open(const OUString& ConnectionString, const OUString&
UserID,const OUString& Password,long Options)
+bool WpADOConnection::Open(std::u16string_view ConnectionString,
std::u16string_view UserID,std::u16string_view Password,long Options)
{
assert(pInterface);
OLEString sStr1(ConnectionString);
@@ -151,7 +151,7 @@ OUString
[Libreoffice-commits] core.git: basctl/source extensions/source fpicker/source vcl/win
basctl/source/basicide/baside3.cxx |2 -
extensions/source/config/WinUserInfo/WinUserInfoBe.cxx | 28 -
fpicker/source/win32/VistaFilePickerEventHandler.cxx |4 +-
vcl/win/dtrans/ftransl.cxx |2 -
4 files changed, 18 insertions(+), 18 deletions(-)
New commits:
commit 3fff050a343e7fb45c3c562772b22fb5e824352f
Author: Stephan Bergmann
AuthorDate: Tue Jan 12 15:25:26 2021 +0100
Commit: Stephan Bergmann
CommitDate: Wed Jan 13 07:36:36 2021 +0100
loplugin:stringliteralvar (clang-cl)
Change-Id: I79949789634242eb95cc722bab83e0348775f274
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109174
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/basctl/source/basicide/baside3.cxx
b/basctl/source/basicide/baside3.cxx
index 30d158aeb51b..69fc19b74329 100644
--- a/basctl/source/basicide/baside3.cxx
+++ b/basctl/source/basicide/baside3.cxx
@@ -69,7 +69,7 @@ using namespace ::com::sun::star::resource;
using namespace ::com::sun::star::ui::dialogs;
#ifdef _WIN32
-char const FilterMask_All[] = "*.*";
+OUStringLiteral const FilterMask_All = u"*.*";
#else
constexpr OUStringLiteral FilterMask_All = u"*";
#endif
diff --git a/extensions/source/config/WinUserInfo/WinUserInfoBe.cxx
b/extensions/source/config/WinUserInfo/WinUserInfoBe.cxx
index 7dd5c5463e46..f9f5f9545439 100644
--- a/extensions/source/config/WinUserInfo/WinUserInfoBe.cxx
+++ b/extensions/source/config/WinUserInfo/WinUserInfoBe.cxx
@@ -60,23 +60,23 @@ public:
namespace
{
-constexpr char givenname[]("givenname");
-constexpr char sn[]("sn");
+constexpr OUStringLiteral givenname(u"givenname");
+constexpr OUStringLiteral sn(u"sn");
constexpr char fathersname[]("fathersname");
-constexpr char initials[]("initials");
-constexpr char street[]("street");
-constexpr char l[]("l");
-constexpr char st[]("st");
+constexpr OUStringLiteral initials(u"initials");
+constexpr OUStringLiteral street(u"street");
+constexpr OUStringLiteral l(u"l");
+constexpr OUStringLiteral st(u"st");
constexpr char apartment[]("apartment");
-constexpr char postalcode[]("postalcode");
-constexpr char c[]("c");
-constexpr char o[]("o");
+constexpr OUStringLiteral postalcode(u"postalcode");
+constexpr OUStringLiteral c(u"c");
+constexpr OUStringLiteral o(u"o");
constexpr char position[]("position");
-constexpr char title[]("title");
-constexpr char homephone[]("homephone");
-constexpr char telephonenumber[]("telephonenumber");
-constexpr char facsimiletelephonenumber[]("facsimiletelephonenumber");
-constexpr char mail[]("mail");
+constexpr OUStringLiteral title(u"title");
+constexpr OUStringLiteral homephone(u"homephone");
+constexpr OUStringLiteral telephonenumber(u"telephonenumber");
+constexpr OUStringLiteral
facsimiletelephonenumber(u"facsimiletelephonenumber");
+constexpr OUStringLiteral mail(u"mail");
// Backend class implementing access to Active Directory user data. It caches
its encoded data
// in a configuration entry, to allow reusing it when user later doesn't have
access to AD DC
diff --git a/fpicker/source/win32/VistaFilePickerEventHandler.cxx
b/fpicker/source/win32/VistaFilePickerEventHandler.cxx
index 4275adf3b749..1e148bb3e1db 100644
--- a/fpicker/source/win32/VistaFilePickerEventHandler.cxx
+++ b/fpicker/source/win32/VistaFilePickerEventHandler.cxx
@@ -233,8 +233,8 @@ void VistaFilePickerEventHandler::stopListening()
}
}
-const char PROP_CONTROL_ID[] = "control_id";
-const char PROP_PICKER_LISTENER[] = "picker_listener";
+const OUStringLiteral PROP_CONTROL_ID = u"control_id";
+const OUStringLiteral PROP_PICKER_LISTENER = u"picker_listener";
namespace {
diff --git a/vcl/win/dtrans/ftransl.cxx b/vcl/win/dtrans/ftransl.cxx
index f7eb3e2086ed..6bcf59066b81 100644
--- a/vcl/win/dtrans/ftransl.cxx
+++ b/vcl/win/dtrans/ftransl.cxx
@@ -34,7 +34,7 @@
#define CPPUTYPE_SEQSALINT8 cppu::UnoType>::get()
#define CPPUTYPE_DEFAULT CPPUTYPE_SEQSALINT8
-const char Windows_FormatName[] = "windows_formatname";
+const OUStringLiteral Windows_FormatName = u"windows_formatname";
const css::uno::Type CppuType_ByteSequence =
cppu::UnoType>::get();
const css::uno::Type CppuType_String = ::cppu::UnoType::get();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 139577] Korean/hangul input has issues for Libreoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=139577 --- Comment #2 from potassi...@protonmail.com --- The video shows korean input demonstration. The actual issue demonstration starts at 20 (seconds) in the video, please carefully observe this, because I don't think I did a good job explaining this with text. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl sd/qa svx/source vcl/inc vcl/qa vcl/source
include/vcl/vectorgraphicdata.hxx | 19 +-
sd/qa/unit/SdrPdfImportTest.cxx| 11 ++-
sd/qa/unit/import-tests.cxx|4 -
svx/source/svdraw/svdpdf.cxx |4 -
svx/source/xoutdev/_xoutbmp.cxx|3 -
vcl/inc/pdf/ExternalPDFStreams.hxx |7 +-
vcl/qa/cppunit/PDFiumLibraryTest.cxx | 30 --
vcl/source/filter/graphicfilter.cxx|9 ++-
vcl/source/filter/ipdf/pdfread.cxx | 21 +++
vcl/source/gdi/TypeSerializer.cxx |6 +-
vcl/source/gdi/impgraph.cxx|4 -
vcl/source/gdi/pdfwriter_impl.cxx | 13 +---
vcl/source/gdi/pdfwriter_impl.hxx |3 -
vcl/source/gdi/vectorgraphicdata.cxx | 81 ++---
vcl/source/graphic/GraphicID.cxx |5 -
vcl/source/graphic/VectorGraphicSearch.cxx |4 -
vcl/source/pdf/ExternalPDFStreams.cxx |9 +--
17 files changed, 132 insertions(+), 101 deletions(-)
New commits:
commit dcfac443c608aec2ce4e5fa30a3dd021b5a8bfd3
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 28 10:03:18 2020 +0900
Commit: Tomaž Vajngerl
CommitDate: Wed Jan 13 07:22:31 2021 +0100
vcl: use BinaryDataContianer in VectorGraphicData
This change is needed so we can use the same data in GfxLink and
in VectorGraphicData. Currently the data needed to be duplicated,
which is less than ideal.
Change-Id: I79419921d09681fa8f0b1ac4bf8ea84199d4aae6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108440
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/vcl/vectorgraphicdata.hxx
b/include/vcl/vectorgraphicdata.hxx
index f18def5b7316..21d86fa12b3d 100644
--- a/include/vcl/vectorgraphicdata.hxx
+++ b/include/vcl/vectorgraphicdata.hxx
@@ -23,6 +23,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -55,7 +56,7 @@ class VCL_DLLPUBLIC VectorGraphicData
{
private:
// the file and length
-VectorGraphicDataArray maVectorGraphicDataArray;
+BinaryDataContainer maDataContainer;
// on demand created content
boolmbSequenceCreated;
@@ -90,6 +91,10 @@ public:
VectorGraphicDataType eVectorDataType,
sal_Int32 nPageIndex = -1);
VectorGraphicData(const OUString& rPath, VectorGraphicDataType
eVectorDataType);
+VectorGraphicData(
+const BinaryDataContainer& rDataContainer,
+VectorGraphicDataType eVectorDataType,
+sal_Int32 nPageIndex = -1);
~VectorGraphicData();
/// compare op
@@ -99,8 +104,16 @@ public:
void setWmfExternalHeader(const WmfExternal& aExtHeader);
/// data read
-const VectorGraphicDataArray& getVectorGraphicDataArray() const { return
maVectorGraphicDataArray; }
-sal_uInt32 getVectorGraphicDataArrayLength() const { return
maVectorGraphicDataArray.getLength(); }
+const BinaryDataContainer& getBinaryDataContainer() const
+{
+return maDataContainer;
+}
+
+sal_uInt32 getVectorGraphicDataArrayLength() const
+{
+return maDataContainer.getSize();
+}
+
enum class State { UNPARSED, PARSED };
std::pair getSizeBytes() const;
diff --git a/sd/qa/unit/SdrPdfImportTest.cxx b/sd/qa/unit/SdrPdfImportTest.cxx
index afbb02594e21..ea5f2aee477f 100644
--- a/sd/qa/unit/SdrPdfImportTest.cxx
+++ b/sd/qa/unit/SdrPdfImportTest.cxx
@@ -175,8 +175,7 @@ CPPUNIT_TEST_FIXTURE(SdrPdfImportTest,
testAnnotationsImportExport)
sd::ViewShell* pViewShell =
pImpressDocument->GetDocShell()->GetViewShell();
CPPUNIT_ASSERT(pViewShell);
-const void* pData = nullptr;
-int nLength = 0;
+BinaryDataContainer aContainer;
{
// Get the first page - there should be only one.
@@ -202,13 +201,15 @@ CPPUNIT_TEST_FIXTURE(SdrPdfImportTest,
testAnnotationsImportExport)
pVectorGraphicData->getVectorGraphicDataType());
// Write the PDF
-pData =
pVectorGraphicData->getVectorGraphicDataArray().getConstArray();
-nLength = pVectorGraphicData->getVectorGraphicDataArrayLength();
+aContainer = pVectorGraphicData->getBinaryDataContainer();
}
{ // check graphic PDF has annotations
-auto pPDFDocument = pPdfiumLibrary->openDocument(pData, nLength);
+CPPUNIT_ASSERT_EQUAL(false, aContainer.isEmpty());
+
+auto pPDFDocument
+= pPdfiumLibrary->openDocument(aContainer.getData(),
aContainer.getSize());
auto pPDFPage = pPDFDocument->openPage(0);
CPPUNIT_ASSERT_EQUAL(2, pPDFPage->getAnnotationCount());
diff --git a/sd/qa/unit/import-tests.cxx b/sd/qa/unit/import-tests.cxx
index eefda64a9cd9..b5c1c5ca03c3 100644
--- a/sd/qa/unit/import-tests.cxx
+++ b/sd/qa/unit/import-tests.cxx
@@ -1380,8 +1380,8 @@ void SdImportTest::testPDFImportShared()
{
Graphic const & rGraphic = aGraphics[i];
[Libreoffice-bugs] [Bug 139577] Korean/hangul input has issues for Libreoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=139577 --- Comment #1 from potassi...@protonmail.com --- Created attachment 168844 --> https://bugs.documentfoundation.org/attachment.cgi?id=168844=edit This a video using fcitx and LibreOfice to demenstrate the issue -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138942] In the Navigator, show separate nodes for Headings and Outline levels
https://bugs.documentfoundation.org/show_bug.cgi?id=138942 --- Comment #4 from Jim Raykowski --- Sorry, I'm not quite following. An example document with a list of what is to be included in the "Outline" and "Headings" nodes may help. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 138942] In the Navigator, show separate nodes for Headings and Outline levels
https://bugs.documentfoundation.org/show_bug.cgi?id=138942 --- Comment #4 from Jim Raykowski --- Sorry, I'm not quite following. An example document with a list of what is to be included in the "Outline" and "Headings" nodes may help. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 139577] New: Korean/hangul input has issues for Libreoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=139577 Bug ID: 139577 Summary: Korean/hangul input has issues for Libreoffice Product: LibreOffice Version: 7.0.3.1 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: potassi...@protonmail.com Description: I love GNU/open source products, and LibreOffice is one of my favorite examples to present the beauty of these projects. However, a serious bug in LibreOffice is making life difficult of me to present LibreOffice to my friends, since they use Korean. The translations are O.K, however when using Korean while writing a document, the highlighted Korean input cursor fails to input when the user selects a different word leaving the current cursor. I believe the person who is kindly reading this bug report may not be familiar with How Korean input works... So, for some basic knowledge to understand this bug, I will explain how Korean input works. I use Fcitx for Korean input, but other input frame work such as i-bus will do the same thing. For example, in English, we just type and the characters will just show up on the screen. but in Korean, these 'characters' need to be combined to make sense. 한 this is a example of a 'combined' readable Korean word ㅎㅏㄴ this a the same characters but not combined, notice the 'ㅏ'goes next to 'ㅎ' and 'ㄴ' goes under the 'ㅎ' + 'ㅏ' The input framework creates a highlighted cursor (I'm not sure if they call this a cursor) and within the cursor, the Korean characters get combined and when the user presses enter or continues to type, the character that is combined (like the example above, '한')appears. The main bug is when the user moves the cursor to a different location via mouse click, the highlighted text, that contains the last Korean characters the user was inputing is not left behind, but disappears, and sometimes reappears when in the new cursor location, forcing the user to delete the unwanted text. To be honest, this is not a bug only happening in LibreOffice programs almost every program in GNU/Linux (besides Firefox) has this Korean input issue, but this issue usually gets ignored, because the developers usually think the existence of a "easy" workaround to fix the issue makes the bug unnecessary to fix. I understand their conclusion, since they have major bugs(crashes, cannot install etc) to work on, and since Korean is not the language they use they feel less importance to fix the issue. However, I beg you to take this seriously, if this issue continues to live along, normal Korean Document editing maybe possible, but re-writing a Korean Documents is a pain for every character I input since I need to press -> arrow button to make sure the highlighted text gets properly located. Steps to Reproduce: 1.Get Korean input framework such as Fcitx, or i-bus 2.start typing in Korean(In LibreOffice or others, like Impress presentation) 3.using your mouse cursor, move your cursor location, and say hello to the frustrating disappearing text. Actual Results: The highlighted Korean text disappears from the last location where the cursor was, and sometimes reappears to the next location where you just moved your cursor to. Expected Results: the highlighted Korean characters should stay where they are when the user changes the cursor's location using the mouse. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.0.3.1 Build ID: d7547858d014d4cf69878db179d326fc3483e082 CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sc/source
sc/source/ui/app/inputhdl.cxx | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
New commits:
commit 6554d69871b0798ae38e5a406aefb5dd90f19ff0
Author: Tamás Zolnai
AuthorDate: Wed Jan 13 05:30:53 2021 +0100
Commit: Tamás Zolnai
CommitDate: Wed Jan 13 06:37:20 2021 +0100
lok: don't turn off online spelling by view change.
Since we don't exit editing for LOK inside this NotifyChange()
method, we should keep also spelling functionality alive. See
also the comment we have here: "As long as the content is not
edited, turn off online spelling." So it seems a good idea
to make this spelling modification dependent of bStopEditing flag.
This causes issues, during view switches.
Change-Id: Ic684073d129c1cac4b6f4d11f34cd64cb5db3295
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109206
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Tamás Zolnai
diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx
index e240f3e57cc0..97b54526f20c 100644
--- a/sc/source/ui/app/inputhdl.cxx
+++ b/sc/source/ui/app/inputhdl.cxx
@@ -4063,16 +4063,17 @@ void ScInputHandler::NotifyChange( const
ScInputHdlState* pState,
pActiveViewSh->libreOfficeKitViewCallback(LOK_CALLBACK_CELL_ADDRESS,
aPosStr.toUtf8().getStr());
}
-if (bStopEditing)
+if (bStopEditing) {
SfxGetpApp()->Broadcast( SfxHint(
SfxHintId::ScKillEditView ) );
-// As long as the content is not edited, turn off online
spelling.
-// Online spelling is turned back on in StartTable, after
setting
-// the right language from cell attributes.
+// As long as the content is not edited, turn off online
spelling.
+// Online spelling is turned back on in StartTable, after
setting
+// the right language from cell attributes.
-EEControlBits nCntrl = mpEditEngine->GetControlWord();
-if ( nCntrl & EEControlBits::ONLINESPELLING )
-mpEditEngine->SetControlWord( nCntrl &
~EEControlBits::ONLINESPELLING );
+EEControlBits nCntrl = mpEditEngine->GetControlWord();
+if ( nCntrl & EEControlBits::ONLINESPELLING )
+mpEditEngine->SetControlWord( nCntrl &
~EEControlBits::ONLINESPELLING );
+}
bModified = false;
bSelIsRef = false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/crsr/crsrsh.cxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit 68b1ae7b493eea4d77f36a0c8566ca0224f04798
Author: Tamás Zolnai
AuthorDate: Tue Jan 12 16:00:46 2021 +0100
Commit: Tamás Zolnai
CommitDate: Wed Jan 13 06:11:40 2021 +0100
tdf#139566: Fix select all (table + text) when document window looses focus.
Without setting mbSelectAll properly the selection cursor
is converted to a SwShellTableCursor, which can't handle
if a selection is extended outside of the table.
Change-Id: Ibd43097ac782b9fc02ff818d3911ebcd20efbd21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109185
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Tamás Zolnai
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109205
Tested-by: Jenkins
diff --git a/sw/source/core/crsr/crsrsh.cxx b/sw/source/core/crsr/crsrsh.cxx
index 2b36d8c8c3c9..88513297d535 100644
--- a/sw/source/core/crsr/crsrsh.cxx
+++ b/sw/source/core/crsr/crsrsh.cxx
@@ -2430,6 +2430,8 @@ void SwCursorShell::ShellLoseFocus()
void SwCursorShell::ShellGetFocus()
{
+comphelper::FlagRestorationGuard g(mbSelectAll, StartsWithTable() &&
ExtendedSelectedAll());
+
m_bHasFocus = true;
if( !m_bBasicHideCursor && VisArea().Width() )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120715] Cursor doesn't move forward on typing space at the end of .docx file when text is centered
https://bugs.documentfoundation.org/show_bug.cgi?id=120715 --- Comment #15 from stragu --- Reproduced with example document in: Version: 7.0.4.2 Build ID: 00(Build:2) CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Ubuntu package version: 1:7.0.4_rc2-0ubuntu0.18.04.2 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39667] Enable accessible/tagged PDF export options by default
https://bugs.documentfoundation.org/show_bug.cgi?id=39667 RISHAV changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |eladutt...@gmail.com |desktop.org | Status|NEW |ASSIGNED --- Comment #17 from RISHAV --- Hi, I am working on this. Can you please point me where should I look for the code related to this issue? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139576] New: Libre Office Calc freezes during routing cell copy/paste/save apparently only when browser Firefox is also open
https://bugs.documentfoundation.org/show_bug.cgi?id=139576
Bug ID: 139576
Summary: Libre Office Calc freezes during routing cell
copy/paste/save apparently only when browser Firefox
is also open
Product: LibreOffice
Version: 6.4.7.2 release
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: Calc
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: 2...@earthlink.net
Description:
Calc freezes within 3-4 minutes of routine use such as copy/paste of cells,
saving the file. This apparently only happens when browser Firefox is also
open. Firefox had an update several days ago (~1/8/21), and Libre Office's Calc
now quickly freezes with typical use. Once Calc freezes, I am not able to close
it with Task Manager nor with with command line commands; I must re-boot to
close Calc, losing some work. This has now occurred ~10 times. I have isolated
the occurrence to only happen when Firefox 84.0.2 is open.
My Operating System: Windows 8.1
Libre Office versions which freeze(tested on): 7.03, 7.04, 6.47.
Actual Results:
Open Firefox 84.0.2 on a a Windows 8.1 PC, then open Calc, do some routine
copy/pastes of cells, rows, then Save the file -repeat the actions 7-10 times.
Expected Results:
Calc freezes ("Not Responding"), with application display greyed-out, and no
longer responds. Calc will not respond to forced closure when using Task
Manager, nor from Microsoft Windows "End Process" dialogue box, which will
appear when repeatedly trying to "X" out of Calc.
Reproducible: Always
User Profile Reset: No
Additional Info:
Calc should operate without freezing. (Sometimes Calc takes 10-20 seconds to
save.)
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 139037] UI: collapsed pre-formatted text in style inspector keeps expanding after each cursor position change
https://bugs.documentfoundation.org/show_bug.cgi?id=139037 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 139037] UI: collapsed pre-formatted text in style inspector keeps expanding after each cursor position change
https://bugs.documentfoundation.org/show_bug.cgi?id=139037 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138215] LibreOffice struggles with dark themes.
https://bugs.documentfoundation.org/show_bug.cgi?id=138215 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139306] UI: numerical string in formula bar (input line) and cell editing truncated (to 20 digits)
https://bugs.documentfoundation.org/show_bug.cgi?id=139306 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139302] [UI] Demote Chapter in navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=139302 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139300] FILEOPEN CALC
https://bugs.documentfoundation.org/show_bug.cgi?id=139300 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139293] Function-focused way to add keyboard shortcuts
https://bugs.documentfoundation.org/show_bug.cgi?id=139293 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139143] EDITING 3D column/bar chart with multilevel X axis label does not have separator lines
https://bugs.documentfoundation.org/show_bug.cgi?id=139143 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138981] Slow save because high res clipboard pasted image (jpg) gets converted to PNG (because it pastes as unknown format)
https://bugs.documentfoundation.org/show_bug.cgi?id=138981 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139550] Version: 6.3.4.2 does not display lower case "x, y, & z" from New York font
https://bugs.documentfoundation.org/show_bug.cgi?id=139550 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131855] Printing Select Brochure - Cannot unselect brochure, cannot cancel brochure, brochure is still set after restart (Solus)
https://bugs.documentfoundation.org/show_bug.cgi?id=131855 --- Comment #5 from QA Administrators --- Dear David Lynn Skinner, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139550] Version: 6.3.4.2 does not display lower case "x, y, & z" from New York font
https://bugs.documentfoundation.org/show_bug.cgi?id=139550 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139521] Changing the default anchor to paragraph doesn't work (still to character)
https://bugs.documentfoundation.org/show_bug.cgi?id=139521 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131855] Printing Select Brochure - Cannot unselect brochure, cannot cancel brochure, brochure is still set after restart (Solus)
https://bugs.documentfoundation.org/show_bug.cgi?id=131855 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139521] Changing the default anchor to paragraph doesn't work (still to character)
https://bugs.documentfoundation.org/show_bug.cgi?id=139521 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134871] Writer Document extremely slow to open document
https://bugs.documentfoundation.org/show_bug.cgi?id=134871 --- Comment #2 from QA Administrators --- Dear b.benoit, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134838] User-defined variables pasted from earlier version of LibreOffice are "locked"/non-functional
https://bugs.documentfoundation.org/show_bug.cgi?id=134838 --- Comment #2 from QA Administrators --- Dear Steven Shelton, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134788] Inserting a table with 4000-6000 takes a long time to process since 5.1
https://bugs.documentfoundation.org/show_bug.cgi?id=134788 --- Comment #2 from QA Administrators --- Dear Telesto, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130021] "File-Edit-View-Insert etc" toolbar crash
https://bugs.documentfoundation.org/show_bug.cgi?id=130021 --- Comment #7 from QA Administrators --- Dear otsiakal, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120230] Palette of colors on tool bar 'Color Bar' cannot be set directly; palette chosen elsewhere is used only after restart
https://bugs.documentfoundation.org/show_bug.cgi?id=120230 --- Comment #5 from QA Administrators --- Dear Cor Nouws, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139575] MSO Group Shape with SmartArt is not support
https://bugs.documentfoundation.org/show_bug.cgi?id=139575 --- Comment #1 from nd101 --- Created attachment 168843 --> https://bugs.documentfoundation.org/attachment.cgi?id=168843=edit pptx file test case -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139575] New: MSO Group Shape with SmartArt is not support
https://bugs.documentfoundation.org/show_bug.cgi?id=139575 Bug ID: 139575 Summary: MSO Group Shape with SmartArt is not support Product: LibreOffice Version: 7.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: f...@nd.com.cn Description: In MSPowerPoint 2016，Group Shape with SmartArt. Open the document in LibreOffice to see the problem. Steps to Reproduce: 1.pptx file with Group Shape open the document in LibreOffice 2.SmartArt in Group Shape is disappeared Actual Results: SmartArt in Group Shape is disappeared Expected Results: SmartArt in Group Shape is visiable Reproducible: Always User Profile Reset: No Additional Info: pptx file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139574] MSO Text blipfill is not support
https://bugs.documentfoundation.org/show_bug.cgi?id=139574 --- Comment #1 from nd101 --- Created attachment 168842 --> https://bugs.documentfoundation.org/attachment.cgi?id=168842=edit pptx file test case -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139574] New: MSO Text blipfill is not support
https://bugs.documentfoundation.org/show_bug.cgi?id=139574 Bug ID: 139574 Summary: MSO Text blipfill is not support Product: LibreOffice Version: 7.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: f...@nd.com.cn Description: In MSPowerPoint 2016，text with blipfill. Open the document in LibreOffice to see the problem. Steps to Reproduce: 1.pptx file with text blipfill open the document in LibreOffice 2.in LibreOffice the text blipfill is not support 3. Actual Results: text blipfill is not support in Impress Expected Results: text blipfill is support Reproducible: Always User Profile Reset: No Additional Info: none -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139573] New: MSO Text blipfill is not support
https://bugs.documentfoundation.org/show_bug.cgi?id=139573 Bug ID: 139573 Summary: MSO Text blipfill is not support Product: LibreOffice Version: 7.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: f...@nd.com.cn Description: In MSPowerPoint 2016，text with blipfill. Open the document in LibreOffice to see the problem. Steps to Reproduce: 1.pptx file with text blipfill open the document in LibreOffice 2.in LibreOffice the text blipfill is not support 3. Actual Results: text blipfill is not support in Impress Expected Results: text blipfill is support Reproducible: Always User Profile Reset: No Additional Info: none -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sw/source
sw/source/core/crsr/crsrsh.cxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit 7f150d63253e171e87c09225291c4e059aaf2476
Author: Tamás Zolnai
AuthorDate: Tue Jan 12 16:00:46 2021 +0100
Commit: Tamás Zolnai
CommitDate: Wed Jan 13 03:02:39 2021 +0100
tdf#139566: Fix select all (table + text) when document window looses focus.
Without setting mbSelectAll properly the selection cursor
is converted to a SwShellTableCursor, which can't handle
if a selection is extended outside of the table.
Change-Id: Ibd43097ac782b9fc02ff818d3911ebcd20efbd21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109185
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Tamás Zolnai
diff --git a/sw/source/core/crsr/crsrsh.cxx b/sw/source/core/crsr/crsrsh.cxx
index 9df9af2501e4..7d3b70dbf363 100644
--- a/sw/source/core/crsr/crsrsh.cxx
+++ b/sw/source/core/crsr/crsrsh.cxx
@@ -2415,6 +2415,8 @@ void SwCursorShell::ShellLoseFocus()
void SwCursorShell::ShellGetFocus()
{
+comphelper::FlagRestorationGuard g(mbSelectAll, StartsWithTable() &&
ExtendedSelectedAll());
+
m_bHasFocus = true;
if( !m_bBasicHideCursor && VisArea().Width() )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - vcl/ios
vcl/ios/DataFlavorMapping.cxx |8
vcl/ios/DataFlavorMapping.hxx |2 +-
vcl/ios/clipboard.cxx |7 ++-
vcl/ios/clipboard.hxx |1 -
vcl/ios/iOSTransferable.cxx | 14 +-
vcl/ios/iOSTransferable.hxx |3 +--
6 files changed, 13 insertions(+), 22 deletions(-)
New commits:
commit b02be1d4aae9176c7cff1f37c91406cbebd092eb
Author: Tor Lillqvist
AuthorDate: Wed Jan 13 00:31:43 2021 +0200
Commit: Tor Lillqvist
CommitDate: Wed Jan 13 02:16:27 2021 +0100
We only use the systemwide general pasteboard
Simplify code to explicitly use it then instead of using variables.
Change-Id: I915a44cf7275fbf2140671a2edf1da29f1bf4e40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109202
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Tor Lillqvist
diff --git a/vcl/ios/DataFlavorMapping.cxx b/vcl/ios/DataFlavorMapping.cxx
index eff8abd4323c..8a6167881d09 100644
--- a/vcl/ios/DataFlavorMapping.cxx
+++ b/vcl/ios/DataFlavorMapping.cxx
@@ -429,13 +429,13 @@ NSString*
DataFlavorMapper::openOfficeToSystemFlavor(const DataFlavor& oOOFlavor
return sysFlavor;
}
-NSString* DataFlavorMapper::openOfficeImageToSystemFlavor(UIPasteboard*
pPasteboard)
+NSString* DataFlavorMapper::openOfficeImageToSystemFlavor()
{
-if ([pPasteboard containsPasteboardTypes:@[ PBTYPE_PNG ]])
+if ([[UIPasteboard generalPasteboard] containsPasteboardTypes:@[
PBTYPE_PNG ]])
return PBTYPE_PNG;
-else if ([pPasteboard containsPasteboardTypes:@[ PBTYPE_JPEG ]])
+else if ([[UIPasteboard generalPasteboard] containsPasteboardTypes:@[
PBTYPE_JPEG ]])
return PBTYPE_JPEG;
-else if ([pPasteboard containsPasteboardTypes:@[ PBTYPE_PDF ]])
+else if ([[UIPasteboard generalPasteboard] containsPasteboardTypes:@[
PBTYPE_PDF ]])
return PBTYPE_PDF;
return @"";
}
diff --git a/vcl/ios/DataFlavorMapping.hxx b/vcl/ios/DataFlavorMapping.hxx
index 7e527dc09c34..fa45be243e9e 100644
--- a/vcl/ios/DataFlavorMapping.hxx
+++ b/vcl/ios/DataFlavorMapping.hxx
@@ -80,7 +80,7 @@ public:
If there is no suitable mapping available NULL will
be returned.
*/
-static NSString* openOfficeImageToSystemFlavor(UIPasteboard* pPasteboard);
+static NSString* openOfficeImageToSystemFlavor();
/* Get a data provider which is able to provide the data 'rTransferable'
offers in a format that can
be put on to the system clipboard.
diff --git a/vcl/ios/clipboard.cxx b/vcl/ios/clipboard.cxx
index ad0af57e3995..46dfa92bfcd7 100644
--- a/vcl/ios/clipboard.cxx
+++ b/vcl/ios/clipboard.cxx
@@ -36,9 +36,6 @@ iOSClipboard::iOSClipboard()
mrXMimeCntFactory =
css::datatransfer::MimeContentTypeFactory::create(xContext);
mpDataFlavorMapper.reset(new DataFlavorMapper());
-
-mPasteboard = [UIPasteboard generalPasteboard];
-assert(mPasteboard != nil);
}
iOSClipboard::~iOSClipboard() {}
@@ -48,7 +45,7 @@ css::uno::Reference
SAL_CALL iOSClipboard::get
osl::MutexGuard aGuard(m_aMutex);
return css::uno::Reference(
-new iOSTransferable(mrXMimeCntFactory, mpDataFlavorMapper,
mPasteboard));
+new iOSTransferable(mrXMimeCntFactory, mpDataFlavorMapper));
}
void SAL_CALL iOSClipboard::setContents(
@@ -75,7 +72,7 @@ void SAL_CALL iOSClipboard::setContents(
}
}
SAL_INFO("vcl.ios.clipboard", "Setting pasteboard items: " <<
NSDictionaryKeysToOUString(dict));
-[mPasteboard setItems:array options:@{}];
+[[UIPasteboard generalPasteboard] setItems:array options:@{}];
// We don't keep a copy of the clipboard contents around in-process, so
fire the lost clipboard
// ownership event right away.
diff --git a/vcl/ios/clipboard.hxx b/vcl/ios/clipboard.hxx
index 144e9c3acdee..66a4dd1b5591 100644
--- a/vcl/ios/clipboard.hxx
+++ b/vcl/ios/clipboard.hxx
@@ -103,7 +103,6 @@ private:
mClipboardListeners;
css::uno::Reference
mXClipboardOwner;
std::shared_ptr mpDataFlavorMapper;
-UIPasteboard* mPasteboard;
};
#endif // INCLUDED_VCL_IOS_CLIPBOARD_HXX
diff --git a/vcl/ios/iOSTransferable.cxx b/vcl/ios/iOSTransferable.cxx
index 1ae2277014b6..6e1bd00b3a97 100644
--- a/vcl/ios/iOSTransferable.cxx
+++ b/vcl/ios/iOSTransferable.cxx
@@ -86,18 +86,14 @@ bool cmpAllContentTypeParameter(const
Reference& xLhs,
} // unnamed namespace
iOSTransferable::iOSTransferable(const Reference&
rXMimeCntFactory,
- std::shared_ptr
pDataFlavorMapper,
- UIPasteboard* pasteboard)
+ std::shared_ptr
pDataFlavorMapper)
: mrXMimeCntFactory(rXMimeCntFactory)
, mDataFlavorMapper(pDataFlavorMapper)
-, mPasteboard(pasteboard)
{
-[mPasteboard retain];
-
initClipboardItemList();
}
-iOSTransferable::~iOSTransferable() { [mPasteboard release]; }
+iOSTransferable::~iOSTransferable() {}
Any SAL_CALL
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - vcl/ios
vcl/ios/DataFlavorMapping.cxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit ea0add3540d6ffefd6077e80526fa5625342e32b
Author: Tor Lillqvist
AuthorDate: Tue Jan 12 22:48:34 2021 +0200
Commit: Tor Lillqvist
CommitDate: Wed Jan 13 02:16:07 2021 +0100
Log successful mapping from system pasteboard format to internal MIME type
Change-Id: I98bedc8fc07a56fbbf3e175277cc9846da46a8c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109201
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Tor Lillqvist
diff --git a/vcl/ios/DataFlavorMapping.cxx b/vcl/ios/DataFlavorMapping.cxx
index e24e3d2a9707..eff8abd4323c 100644
--- a/vcl/ios/DataFlavorMapping.cxx
+++ b/vcl/ios/DataFlavorMapping.cxx
@@ -560,6 +560,8 @@ DataFlavorMapper::typesArrayToFlavorSequence(NSArray*
types) const
{
flavors.realloc(flavors.getLength() + 1);
flavors[flavors.getLength() - 1] = oOOFlavor;
+SAL_INFO("vcl.ios.clipboard",
+ "Mapped " << [sysFormat UTF8String] << " to " <<
oOOFlavor.MimeType);
}
else
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 139572] status bar disappears
https://bugs.documentfoundation.org/show_bug.cgi?id=139572 --- Comment #1 from Nick Levinson --- See also: For Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1686364 For gedit: https://gitlab.gnome.org/GNOME/gedit/-/issues/399 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139572] New: status bar disappears
https://bugs.documentfoundation.org/show_bug.cgi?id=139572 Bug ID: 139572 Summary: status bar disappears Product: LibreOffice Version: 7.0.4.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nick_levin...@yahoo.com Description: The status bar disappears at unpredictable times. Steps to Reproduce: Unknown. Inception of problem not noticed. When using a document, problem sometimes discovered. Actual Results: The window is maximized, which is how I like to work. I have a document open. The status bar displays. Eventually, sometimes, I realize the status bar has disappeared. I don't know exactly when it disappeared. Editing still works but I can't see what the status bar says. I do not remember the predicate, what I did that may have caused the problem. For a solution, a kludgy one is to click the maximize/restore top-right button twice. Clicking only once makes no apparent difference, because the window still looks maximized, although it probably isn't. The second click is necessary. I have not tested a double-click vs. two single clicks. The effect of clicking twice seems to be of popping out from behind Gnome's desktop environment's bottom panel. When, on one occasion, I couldn't see the status bar, I clicked the maximize/restore button twice, and that exposed the scroll bar. Expected Results: The status bar should remain visible all the time. Reproducible: Sometimes User Profile Reset: No Additional Info: This is almost certainly an upstream problem, but I don't know where to go upstream. I suspect the problem is from either the status bar or the maximize/restore functionality. If the status bar is at fault, the bar may be auto-disappearing despite having been preferred by the user (View menu > Status Bar). If the maximize/restore functionality is at fault, it may be executing a demaximization that retains full window width and similar window height so that the demaximization is not obvious to the user. This is with LibreOffice Writer on Fedora 33 Linux, kept evergreen. >From About LibreOffice: Version: 7.0.4.2 Build ID: 00(Build:2) CPU threads: 2; OS: Linux 5.9; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded I recently checked for a corrupt UserProfile and there isn't one. I don't think I have an OpenGL setting. Possibly of interest: Bug 91323; bug 93799; bug 68801. I have virtually the same problem with the gedit statusbar and the Firefox Find bar (via ctrl-f). The problem began only recently on all three apps, but I don't remember exactly when. The three apps likely have the same code from somewhere upstream. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139325] LO writer hangs/crashes--can't access my large ODT data file
https://bugs.documentfoundation.org/show_bug.cgi?id=139325 --- Comment #22 from Hal --- FYI (not FRY) :) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139325] LO writer hangs/crashes--can't access my large ODT data file
https://bugs.documentfoundation.org/show_bug.cgi?id=139325 --- Comment #21 from Hal --- (In reply to Hal from comment #18) > More data/info: Attempting to Insert a small jpg image (64KB) causes > LibreOffice to crash. > > Any help by the 'pros' on the horizon? > > Until the LO bug is fixed I'm unable to proceed with my large-scale Writer > project containing lots of formatted text, tables, images, captions, & > indices. FRY - NEW INFO: Dragging a small jpg image into my very large .ODT file seems to work whereas trying to Insert it crashes LibreOffice. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139325] LO writer hangs/crashes--can't access my large ODT data file
https://bugs.documentfoundation.org/show_bug.cgi?id=139325 --- Comment #20 from Hal --- Thank you V Stuart Foote. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139325] LO writer hangs/crashes--can't access my large ODT data file
https://bugs.documentfoundation.org/show_bug.cgi?id=139325 --- Comment #19 from V Stuart Foote --- (In reply to Hal from comment #17) > Installed 7-zip. Was able to retrieve images, but can't seem to display the > more important lost text (supposedly converted to XML format) using > LibreOffice. Text will be in the ODF zip archive in the file "content.xml"; it is sequentially built so newest text will be toward the bottom. The text "runs" will be mixed together with formatting & style notations and URI for the images, but with some judicious find and replace should get you back the text. If you need a good text editor to do this I'd suggest the notepad++ project [1], or alternatively the gvim project [2]. But vim syntax, while powerful for search and replacement, is a little daunting. If you don't want to invest the time, the GUI based notepad++ editor should work well. Good luck with recovery. =-ref-= [1] https://notepad-plus-plus.org/ [2] https://www.vim.org/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139550] Version: 6.3.4.2 does not display lower case "x, y, & z" from New York font
https://bugs.documentfoundation.org/show_bug.cgi?id=139550 --- Comment #2 from Joseph Massucco --- I’m on Mac OS X 10.15.7 (19H15). Right now, I can’t remember if it was downloaded or from a cd. I’ll try downloading the later version to see if the problem persists. This is the only real problem I’ve had with Libre since I started using it (more than I can say for Micosoft’s %$#%^& product). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139325] LO writer hangs/crashes--can't access my large ODT data file
https://bugs.documentfoundation.org/show_bug.cgi?id=139325 --- Comment #18 from Hal --- More data/info: Attempting to Insert a small jpg image (64KB) causes LibreOffice to crash. Any help by the 'pros' on the horizon? Until the LO bug is fixed I'm unable to proceed with my large-scale Writer project containing lots of formatted text, tables, images, captions, & indices. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139338] The distinction paragraph <-> Character direct formatting in style inspector seems a kind of pointless
https://bugs.documentfoundation.org/show_bug.cgi?id=139338 --- Comment #12 from V Stuart Foote --- (In reply to Mike Kaganski from comment #11) Ouch, that was a little too harsh Mike, but yes I would agree that some of Telesto's musings are not as well structured or researched as they should be. But he really does poke at some of the frayed edges of the UI--we have a spot for him here if he could perhaps edit his submissions. Stuart -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 139338] The distinction paragraph <-> Character direct formatting in style inspector seems a kind of pointless
https://bugs.documentfoundation.org/show_bug.cgi?id=139338 --- Comment #12 from V Stuart Foote --- (In reply to Mike Kaganski from comment #11) Ouch, that was a little too harsh Mike, but yes I would agree that some of Telesto's musings are not as well structured or researched as they should be. But he really does poke at some of the frayed edges of the UI--we have a spot for him here if he could perhaps edit his submissions. Stuart -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 122001] Delete key is not transparently assigned to shortcut
https://bugs.documentfoundation.org/show_bug.cgi?id=122001 Gabor Kelemen changed: What|Removed |Added CC||kelem...@ubuntu.com --- Comment #4 from Gabor Kelemen --- Created attachment 168841 --> https://bugs.documentfoundation.org/attachment.cgi?id=168841=edit Delete Contents command in the Customize dialog in current master This command exists, and it is assigned the Delete key on the generic application level since forever (okay, only checked LO 6.0.7 right now): officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu: officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu- officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu- Delete C~ontents... officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu- It's just not very easy to find it, like finding any other command in our jungle of commands. I think this is basically NAB. Maybe a bit more documentation could be useful on the top right radio buttons in this dialog. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139569] PDF password input fields don't accept german umlauts, password confirmation fields do
https://bugs.documentfoundation.org/show_bug.cgi?id=139569 Uwe Auer changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Uwe Auer --- Repro in Version: 7.0.4.2, Build ID: dcf040e67528d9187c66b2379df5ea4407429775 CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: kf5 Locale: de-DE (de_DE.UTF-8); UI: de-DE, Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139338] The distinction paragraph <-> Character direct formatting in style inspector seems a kind of pointless
https://bugs.documentfoundation.org/show_bug.cgi?id=139338 --- Comment #11 from Mike Kaganski --- (In reply to Telesto from comment #10) > Ask LibreOffice is about user questions.. This ends up in the area of > technical questions. At ask people assume things to be this way. Or ask what > the practical issue is Or give quick fixes (workarounds). > > So it's misplaced at ask (if you ask me). No I do not ask you. Ask is for user questions; and this is a user question. Especially since it focuses on "usefulness", which is a topic exactly fit for Ask. And no, this is not technical question, since strictly correct and technical answer about *why* is it so is not good for you. > FWIW: Enhancement request are no bugs either, if we want be nitpicking. So > don't belong here. Would belong to UX enhancement request tracker or > whatever. Yet another unsolicited off-topic from you. Bugzilla is for what TDF intends it, not for what you imagine it is for. It is *the* place for enhancements. Period. > I'm surely not good at reading technical documentation. You surely are not. What you're good at is wasting everyone's time. > 16.30.2 appears to > be about 'Paragraph Styles (styles!). And text style referencing to > "character style" (I guess) Yes. Styles, as defined by ODF, and in ODF, *every* bit of formatting is implemented using styles, DF being defined also by special kind of styles - automatic styles. So everything described in 16.30.2 applies to DF. > The advantage of the (presence of) Paragraph Direct Formatting next to > Character Direct Formatting being unclear to me. This is definitely off-topic here. As said, "what is it useful for" is for Ask, whatever you might think. > > Direct Formatting should not be be distributed around easily. It should be > reduced to a minimum (without breaking user experience using DF) to make > working with style a success, IMHO. > And distinctions between Paragraph Direct Formatting/ Character Direct > Formatting kind of subtle (without being visible; making managing even > harder. You easy distributing DF all over the document without knowing. > Ruining the user experience of using (paragraph) styles. You need to > manually scrub all DF. Polluting the XML files with unnecessary (additional) > DF junk. More unrelated stuff. Not surprising. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 139338] The distinction paragraph <-> Character direct formatting in style inspector seems a kind of pointless
https://bugs.documentfoundation.org/show_bug.cgi?id=139338 --- Comment #11 from Mike Kaganski --- (In reply to Telesto from comment #10) > Ask LibreOffice is about user questions.. This ends up in the area of > technical questions. At ask people assume things to be this way. Or ask what > the practical issue is Or give quick fixes (workarounds). > > So it's misplaced at ask (if you ask me). No I do not ask you. Ask is for user questions; and this is a user question. Especially since it focuses on "usefulness", which is a topic exactly fit for Ask. And no, this is not technical question, since strictly correct and technical answer about *why* is it so is not good for you. > FWIW: Enhancement request are no bugs either, if we want be nitpicking. So > don't belong here. Would belong to UX enhancement request tracker or > whatever. Yet another unsolicited off-topic from you. Bugzilla is for what TDF intends it, not for what you imagine it is for. It is *the* place for enhancements. Period. > I'm surely not good at reading technical documentation. You surely are not. What you're good at is wasting everyone's time. > 16.30.2 appears to > be about 'Paragraph Styles (styles!). And text style referencing to > "character style" (I guess) Yes. Styles, as defined by ODF, and in ODF, *every* bit of formatting is implemented using styles, DF being defined also by special kind of styles - automatic styles. So everything described in 16.30.2 applies to DF. > The advantage of the (presence of) Paragraph Direct Formatting next to > Character Direct Formatting being unclear to me. This is definitely off-topic here. As said, "what is it useful for" is for Ask, whatever you might think. > > Direct Formatting should not be be distributed around easily. It should be > reduced to a minimum (without breaking user experience using DF) to make > working with style a success, IMHO. > And distinctions between Paragraph Direct Formatting/ Character Direct > Formatting kind of subtle (without being visible; making managing even > harder. You easy distributing DF all over the document without knowing. > Ruining the user experience of using (paragraph) styles. You need to > manually scrub all DF. Polluting the XML files with unnecessary (additional) > DF junk. More unrelated stuff. Not surprising. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 139537] Image drops out of frame when moving image & caption frame to certain spot
https://bugs.documentfoundation.org/show_bug.cgi?id=139537 Telesto changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected Version|4.4.7.2 release |4.4.0.3 release --- Comment #7 from Telesto --- Detaching started with bibisect-44max$ git bisect good 61a02ce9cb6491b832cffd74c65196133ec769aa is the first bad commit commit 61a02ce9cb6491b832cffd74c65196133ec769aa Author: Matthew Francis Date: Sat Mar 14 22:08:24 2015 +0800 source-hash-7596e26fd259ce5445212949403e7cd32303b2bd commit 7596e26fd259ce5445212949403e7cd32303b2bd Author: Miklos Vajna AuthorDate: Tue Jun 24 17:11:25 2014 +0200 Commit: Miklos Vajna CommitDate: Tue Jun 24 17:47:40 2014 +0200 Add SwTextBoxHelper::findShapes It builds a textbox -> shape map, so methods interested to pick the shape instead of a shape's textbox can call it and act accordingly if their textbox is in the map. Change-Id: I0f30d64a284eb461f462ed6c0a36c88271153f04 :04 04 66d15d46ba19a20eb3b99bed74f33b492299f211 972e5f90a36adfcb690c2a6bfdfe55158f8afa46 M opt -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139537] Image drops out of frame when moving image & caption frame to certain spot
https://bugs.documentfoundation.org/show_bug.cgi?id=139537 --- Comment #6 from Telesto --- Wrap dysfunction (which later got fixed again, but maybe related 64c8b13f248fe7ea3808c7f8e62d0d656f170378 is the first bad commit commit 64c8b13f248fe7ea3808c7f8e62d0d656f170378 Author: Matthew Francis Date: Sat Mar 14 21:42:08 2015 +0800 source-hash-d379d18666aa42031359ca8eb34b0021960347ae commit d379d18666aa42031359ca8eb34b0021960347ae Author: Miklos Vajna AuthorDate: Wed Jun 18 11:57:31 2014 +0200 Commit: Miklos Vajna CommitDate: Wed Jun 18 12:09:15 2014 +0200 oox: import WPS shape with text as shape with textbox This allows having real shapes (like having rounded corners) and complex content (like containing a table) at the same time. WPS shapes are wrappers around drawingML markup in DOCX files, so this only affects the DOCX import. Change-Id: Iad1c1c61233be1c17efa1821e680927aa9587215 :04 04 529a5c3ebc7c866c86be0c93a0b6a58ee22501a1 14e07ed25ffce284ed57439d86f382777554d6ee M opt -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132532] FILEOPEN: DOCX: Smartart: Flowchart shows empty boxes
https://bugs.documentfoundation.org/show_bug.cgi?id=132532 --- Comment #13 from jake.weilham...@blackboard.com --- Hello, Is there any updates on the priority or status of this ticket? Was just wondering if there was any timeframe that I could expect for a bugfix related to these cases. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139571] Frame an content mismatch. Image goes to top page 1. Frame to page 2 (DOCX)
https://bugs.documentfoundation.org/show_bug.cgi?id=139571 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||5153 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139571] Frame an content mismatch. Image goes to top page 1. Frame to page 2 (DOCX)
https://bugs.documentfoundation.org/show_bug.cgi?id=139571 Telesto changed: What|Removed |Added Keywords||bibisected, bisected, ||regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139571] Frame an content mismatch. Image goes to top page 1. Frame to page 2 (DOCX)
https://bugs.documentfoundation.org/show_bug.cgi?id=139571 --- Comment #2 from Telesto --- 61a02ce9cb6491b832cffd74c65196133ec769aa is the first bad commit commit 61a02ce9cb6491b832cffd74c65196133ec769aa Author: Matthew Francis Date: Sat Mar 14 22:08:24 2015 +0800 source-hash-7596e26fd259ce5445212949403e7cd32303b2bd commit 7596e26fd259ce5445212949403e7cd32303b2bd Author: Miklos Vajna AuthorDate: Tue Jun 24 17:11:25 2014 +0200 Commit: Miklos Vajna CommitDate: Tue Jun 24 17:47:40 2014 +0200 Add SwTextBoxHelper::findShapes It builds a textbox -> shape map, so methods interested to pick the shape instead of a shape's textbox can call it and act accordingly if their textbox is in the map. Change-Id: I0f30d64a284eb461f462ed6c0a36c88271153f04 :04 04 66d15d46ba19a20eb3b99bed74f33b492299f211 972e5f90a36adfcb690c2a6bfdfe55158f8afa46 M opt -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139571] Frame an content mismatch. Image goes to top page 1. Frame to page 2 (DOCX)
https://bugs.documentfoundation.org/show_bug.cgi?id=139571 Telesto changed: What|Removed |Added Version|7.2.0.0.alpha0+ Master |4.4.7.2 release --- Comment #1 from Telesto --- Also found in 4.4.7.2 not in 4.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139571] New: Frame an content mismatch. Image goes to top page 1. Frame to page 2 (DOCX)
https://bugs.documentfoundation.org/show_bug.cgi?id=139571 Bug ID: 139571 Summary: Frame an content mismatch. Image goes to top page 1. Frame to page 2 (DOCX) Product: LibreOffice Version: 7.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Frame an content mismatch. Image goes to top page 1. Frame to page 2 Steps to Reproduce: 1. Open attachment 163564 2. Save as DOCX 3. File reload 4. Drag figure 3 down to the next page Actual Results: Image frame on second page 2.. image shows at top of page 1 Expected Results: So be aligned Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.0.0.alpha0+ (x64) Build ID: f2171af6ce3516598d9f8bac8294025a21a5b1a2 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/stringviewparam.cxx | 55 +
compilerplugins/clang/test/stringviewparam.cxx | 12 +
2 files changed, 67 insertions(+)
New commits:
commit 94f6765d6ecc3145fa2d266231124003cf953118
Author: Stephan Bergmann
AuthorDate: Tue Jan 12 15:53:36 2021 +0100
Commit: Stephan Bergmann
CommitDate: Tue Jan 12 22:28:18 2021 +0100
Avoid loplugin:stringviewparam when there already is a string_view overload
This avoids clang-cl
> In file included from
core/connectivity/source/drivers/ado/Aolevariant.cxx:20:
> connectivity/source/inc\ado/Aolevariant.hxx(72,40): error: replace
function parameter of type 'const rtl::OUString &' with 'std::u16string_view'
[loplugin:stringviewparam]
> OLEVariant(const OUString& us)
>^~
which would make that OLEVariant ctor overload redundant with the existing
OLEVariant(std::u16string_view us);
overload, but with the OUString overload gone, implicit conversions from
OUString to OLEVariant would no longer work, e.g.,
> connectivity/source/drivers/ado/AColumn.cxx(184,76): error: no viable
conversion from 'rtl::OUString' to 'const connectivity::ado::OLEVariant'
> OTools::putValue(m_aColumn.get_Properties(),
sAdoPropertyName, getString(rValue));
>
^
Change-Id: I92a5cc29d9fd2a5ff1a951f79df64879d0f71743
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109180
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/compilerplugins/clang/stringviewparam.cxx
b/compilerplugins/clang/stringviewparam.cxx
index a96d8cad4929..86ee7c21b393 100644
--- a/compilerplugins/clang/stringviewparam.cxx
+++ b/compilerplugins/clang/stringviewparam.cxx
@@ -206,6 +206,57 @@ SmallVector
relevantCXXOperatorCallExpr(CXXOperatorCallEx
return {};
}
+//TODO: current implementation is not at all general, just tests what we
encounter in practice:
+bool hasStringViewOverload(ParmVarDecl const* decl)
+{
+auto const d1 = cast(decl->getDeclContext());
+auto const ctx = d1->getDeclContext();
+if (!ctx->isLookupContext())
+{
+return false;
+}
+auto const res = ctx->lookup(d1->getDeclName());
+auto const idx = decl->getFunctionScopeIndex();
+auto const n = d1->getNumParams();
+assert(n > idx);
+for (auto i = res.begin(); i != res.end(); ++i)
+{
+auto const d2 = dyn_cast(*i);
+if (d2 == nullptr)
+{
+continue;
+}
+if (d2->getNumParams() != n)
+{
+continue;
+}
+auto match = true;
+for (unsigned j = 0; j != n; ++j)
+{
+if (j == idx)
+{
+//TODO: check for exactly std::string_view or
std::u16string_view:
+if (!isStringView(d2->getParamDecl(j)->getType()))
+{
+match = false;
+break;
+}
+}
+else if (d1->getParamDecl(j)->getType().getCanonicalType()
+ != d2->getParamDecl(j)->getType().getCanonicalType())
+{
+match = false;
+break;
+}
+}
+if (match)
+{
+return true;
+}
+}
+return false;
+}
+
class StringViewParam final
: public
loplugin::FunctionAddress>
{
@@ -439,6 +490,10 @@ private:
{
continue;
}
+if (hasStringViewOverload(i))
+{
+continue;
+}
auto const t =
relevantStringType(i->getType().getNonReferenceType());
assert(t != StringType::None);
report(DiagnosticsEngine::Warning,
diff --git a/compilerplugins/clang/test/stringviewparam.cxx
b/compilerplugins/clang/test/stringviewparam.cxx
index 56fadbea71cf..24dab18e0f9c 100644
--- a/compilerplugins/clang/test/stringviewparam.cxx
+++ b/compilerplugins/clang/test/stringviewparam.cxx
@@ -71,4 +71,16 @@ struct Converter
}
};
+void f9(std::u16string_view);
+void f9(OUString const& s) { return f9(std::u16string_view(s)); }
+
+struct S10
+{
+S10(std::u16string_view);
+S10(OUString const& s)
+: S10(std::u16string_view(s))
+{
+}
+};
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s
cinkeys+=0=break: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 139520] LO base (HSQLDB & FIREBIRD): crashes frequently during creation and editing a report design
https://bugs.documentfoundation.org/show_bug.cgi?id=139520 --- Comment #2 from Richard Demattio --- The bugs "Bug 138108" and "Bug 137016" are coming into my mind. -> exiting the report design without saving the whole database makes the crash happen more often than saving all before exiting --> selecting both Label field and value field and moving them makes the crash happen more often too --> but nevertheless: the crashes are coming accitdntally too -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139520] LO base (HSQLDB & FIREBIRD): crashes frequently during creation and editing a report design
https://bugs.documentfoundation.org/show_bug.cgi?id=139520 Richard Demattio changed: What|Removed |Added Summary|LO base (HSQLDB): crashes |LO base (HSQLDB & |frequently during creation |FIREBIRD): crashes |and editing a report design |frequently during creation ||and editing a report design -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139564] Loading Styles From Another File Does Not Import Custom Page Styles
https://bugs.documentfoundation.org/show_bug.cgi?id=139564 sdc.bla...@youmail.dk changed: What|Removed |Added CC||sdc.bla...@youmail.dk --- Comment #2 from sdc.bla...@youmail.dk --- (In reply to larrybradley from comment #0) > Steps to Reproduce: > 1.Create new page styles in a document (Doc 1). Save and close. Did you "apply" the new page style in Doc 1? When I do that -- in LO 7.2.0.0.alpha0+ -- then the custom Page Style from Doc 1 is imported from Doc 2. See tip at bottom of: https://help.libreoffice.org/7.2/en-US/text/swriter/01/0517.html -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139570] EDITING: PPTX: text box renders vertically instead of horizontally
https://bugs.documentfoundation.org/show_bug.cgi?id=139570 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org Blocks||108226 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108226 [Bug 108226] [META] PPTX (OOXML) bug tracker -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=108226 Xisco Faulí changed: What|Removed |Added Depends on||139570 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=139570 [Bug 139570] EDITING: PPTX: text box renders vertically instead of horizontally -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139500] Crash mergedlo!EditUndo::GetComment+54 press undo inside table in impress
https://bugs.documentfoundation.org/show_bug.cgi?id=139500 pavlog changed: What|Removed |Added CC||pavlograd...@gmail.com --- Comment #4 from pavlog --- I can't reproduce in Version: 7.2.0.0.alpha0+ (x64) Build ID: ecb916667b633f8647790e040226b093760e6cfe CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139570] EDITING: PPTX: text box renders vertically instead of horizontally
https://bugs.documentfoundation.org/show_bug.cgi?id=139570 Xisco Faulí changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||4288 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139570] New: EDITING: PPTX: text box renders vertically instead of horizontally
https://bugs.documentfoundation.org/show_bug.cgi?id=139570 Bug ID: 139570 Summary: EDITING: PPTX: text box renders vertically instead of horizontally Product: LibreOffice Version: 7.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: xiscofa...@libreoffice.org This is a follow-up of bug 134288 Steps to reproduce: 1. Open attachment 162385 from bug 134288 2. Click on the textbox to edit it -> text box renders vertically instead of horizontally Reproduced in Version: 7.2.0.0.alpha0+ Build ID: 5adc93a9a9426ef79054751be2904896f787a8a2 CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa uitest/uitest
sc/qa/uitest/autofilter/autofilter.py |7 +-- sc/qa/uitest/autofilter/autofilterBugs.py |8 +--- sc/qa/uitest/autofilter/tdf101165.py |6 +- sc/qa/uitest/autofilter/tdf117276.py |6 +- sc/qa/uitest/autofilter/tdf117276_autofilter_reset.py |6 +- sc/qa/uitest/autofilter/tdf122260.py |6 +- sc/qa/uitest/autofilter/tdf130070.py |6 +- sc/qa/uitest/autofilter/tdf97340.py |7 +-- sc/qa/uitest/calc_tests/autofill.py |8 +--- sc/qa/uitest/calc_tests/autosum.py|8 ++-- sc/qa/uitest/calc_tests/mergedRowsColumns.py |9 + sc/qa/uitest/calc_tests/tdf120161.py |8 +--- sc/qa/uitest/calc_tests/tdf133855.py |6 +- sc/qa/uitest/calc_tests2/consolidate.py |8 +--- sc/qa/uitest/calc_tests2/stableSorting.py |8 ++-- sc/qa/uitest/calc_tests2/standardFilter.py|7 ++- sc/qa/uitest/calc_tests2/subtotals.py |9 + sc/qa/uitest/calc_tests2/tdf114992.py |6 ++ sc/qa/uitest/calc_tests2/tdf118189.py |8 +--- sc/qa/uitest/calc_tests2/tdf120174.py |6 +- sc/qa/uitest/calc_tests2/tdf37623.py |7 +-- sc/qa/uitest/calc_tests2/tdf53482.py |8 ++-- sc/qa/uitest/calc_tests3/tdf77509.py |9 + sc/qa/uitest/calc_tests3/tdf81351.py |7 +-- sc/qa/uitest/calc_tests4/tdf131170.py |7 +-- sc/qa/uitest/calc_tests4/tdf95192.py |7 +-- sc/qa/uitest/calc_tests4/tdf99386.py |9 + sc/qa/uitest/calc_tests4/textToColumns.py | 10 ++ sc/qa/uitest/calc_tests4/trackedChanges.py|7 +-- sc/qa/uitest/calc_tests6/tdf107869.py |8 +--- sc/qa/uitest/calc_tests6/tdf108654.py |7 +-- sc/qa/uitest/calc_tests6/tdf118638.py |9 + sc/qa/uitest/calc_tests7/tdf120660.py |8 +--- sc/qa/uitest/calc_tests7/tdf122509.py |8 +--- sc/qa/uitest/calc_tests7/tdf124818.py |8 +--- sc/qa/uitest/calc_tests7/tdf137397.py |7 +-- sc/qa/uitest/calc_tests7/tdf31805.py |6 +- sc/qa/uitest/calc_tests8/navigator.py |7 +-- sc/qa/uitest/calc_tests8/tdf119343.py |7 +-- sc/qa/uitest/calc_tests8/tdf124829.py |8 +--- sc/qa/uitest/calc_tests9/tdf126673.py |6 +- sc/qa/uitest/calc_tests9/tdf130371.py |7 +-- sc/qa/uitest/calc_tests9/tdf137446.py |7 +-- sc/qa/uitest/calc_tests9/tdf91217.py |7 +-- sc/qa/uitest/chart/chartArea.py |8 +--- sc/qa/uitest/chart/chartAxes.py |9 + sc/qa/uitest/chart/formatDataSeries.py|9 + sc/qa/uitest/chart/tdf122398.py |9 + uitest/uitest/uihelper/common.py |5 + 49 files changed, 59 insertions(+), 305 deletions(-) New commits: commit 82cb5a3bb27bb70c97b3d04b9de97a3ff67231c5 Author: Xisco Fauli AuthorDate: Tue Jan 12 12:29:07 2021 +0100 Commit: Xisco Fauli CommitDate: Tue Jan 12 21:24:20 2021 +0100 uitest: sc: factor out common code ( part 1 ) Change-Id: Ib0b84349c138d361001af4547d91a81d8b5d8e63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109166 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/sc/qa/uitest/autofilter/autofilter.py b/sc/qa/uitest/autofilter/autofilter.py index 78a5887a6c4c..bef8d43c6ef6 100644 --- a/sc/qa/uitest/autofilter/autofilter.py +++ b/sc/qa/uitest/autofilter/autofilter.py @@ -6,15 +6,10 @@ # from uitest.framework import UITestCase -from uitest.uihelper.common import get_state_as_dict +from uitest.uihelper.common import get_state_as_dict, get_url_for_data_file from libreoffice.uno.propertyvalue import mkPropertyValues from libreoffice.calc.document import get_row from uitest.uihelper.calc import enter_text_to_cell -import org.libreoffice.unotest -import pathlib - -def get_url_for_data_file(file_name): -return pathlib.Path(org.libreoffice.unotest.makeCopyFromTDOC(file_name)).as_uri() def is_row_hidden(doc, index): row = get_row(doc, index) diff --git a/sc/qa/uitest/autofilter/autofilterBugs.py b/sc/qa/uitest/autofilter/autofilterBugs.py index e1d0cd19d524..9eb45d83a3a0 100644 --- a/sc/qa/uitest/autofilter/autofilterBugs.py +++ b/sc/qa/uitest/autofilter/autofilterBugs.py @@ -6,15
[Libreoffice-bugs] [Bug 137783] FORMATTING: HTML-EXPORT: Excess character font code added when editing inside a paragraph - appears to be individual character attribute settings being added
https://bugs.documentfoundation.org/show_bug.cgi?id=137783 Ernest Bywater changed: What|Removed |Added Summary|HTML-EXPORT: FORMATTING:|FORMATTING: HTML-EXPORT: |Excess character font code |Excess character font code |added when editing inside a |added when editing inside a |paragraph - appears to be |paragraph - appears to be |character attribute |individual character |settings being added|attribute settings being ||added -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
