[Libreoffice-bugs] [Bug 103427] [META] Styles and Formatting sidebar deck and floating window
https://bugs.documentfoundation.org/show_bug.cgi?id=103427 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||139824 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=139824 [Bug 139824] Allow multiselecting for styles in Sidebar -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139824] Allow multiselecting for styles in Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=139824 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Blocks||103427 Keywords||needsUXEval Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103427 [Bug 103427] [META] Styles and Formatting sidebar deck and floating window -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 139824] Allow multiselecting for styles in Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=139824 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Blocks||103427 Keywords||needsUXEval Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103427 [Bug 103427] [META] Styles and Formatting sidebar deck and floating window -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: vcl/jsdialog
vcl/jsdialog/jsdialogbuilder.cxx | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
New commits:
commit 12a78b0c6c3db1df823d90e0359d84a549f2e894
Author: Szymon Kłos
AuthorDate: Tue Jan 19 14:08:35 2021 +0100
Commit: Szymon Kłos
CommitDate: Fri Jan 22 08:50:58 2021 +0100
jsdialog: enqueue update on dialog weld
Change-Id: I01f14cdf0aa3ea16cd311aed9abe14423e2ec846
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109727
Tested-by: Jenkins
Reviewed-by: Szymon Kłos
diff --git a/vcl/jsdialog/jsdialogbuilder.cxx b/vcl/jsdialog/jsdialogbuilder.cxx
index 836c73f3edea..658ee5ae18d6 100644
--- a/vcl/jsdialog/jsdialogbuilder.cxx
+++ b/vcl/jsdialog/jsdialogbuilder.cxx
@@ -484,16 +484,8 @@ std::unique_ptr
JSInstanceBuilder::weld_dialog(const OString& id)
RememberWidget("__DIALOG__", pRet.get());
-const vcl::ILibreOfficeKitNotifier* pNotifier =
pDialog->GetLOKNotifier();
-if (pNotifier)
-{
-tools::JsonWriter aJsonWriter;
-m_aOwnedToplevel->DumpAsPropertyTree(aJsonWriter);
-aJsonWriter.put("id", m_aOwnedToplevel->GetLOKWindowId());
-pNotifier->libreOfficeKitViewCallback(LOK_CALLBACK_JSDIALOG,
aJsonWriter.extractData());
-}
-
initializeSender(GetNotifierWindow(), GetContentWindow(),
GetTypeOfJSON());
+sendFullUpdate();
}
return pRet;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 55457] Highlight button sticks
https://bugs.documentfoundation.org/show_bug.cgi?id=55457 Heiko Tietze changed: What|Removed |Added Component|Writer |Documentation CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org, ||olivier.hallot@libreoffice. ||org Keywords|needsUXEval | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 55457] Highlight button sticks
https://bugs.documentfoundation.org/show_bug.cgi?id=55457 Heiko Tietze changed: What|Removed |Added Component|Writer |Documentation CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org, ||olivier.hallot@libreoffice. ||org Keywords|needsUXEval | -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 129061] FILEOPEN PPTX: equation not displayed because Impress doesn't support inline formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=129061 --- Comment #26 from NISZ LibreOffice Team --- *** Bug 133239 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133239] PPTX: missing special character in pdf
https://bugs.documentfoundation.org/show_bug.cgi?id=133239 NISZ LibreOffice Team changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #8 from NISZ LibreOffice Team --- Those characters are actually equations inserted into a shape. *** This bug has been marked as a duplicate of bug 129061 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139811] Sidebar Draw Properties deck -> Page -> Background 'Gradient' control needs additional height, the Insert Image dialog button is being clipped
https://bugs.documentfoundation.org/show_bug.cgi?id=139811 --- Comment #5 from Heiko Tietze --- Code pointer is sd/uiconfig/simpress/ui/sidebarslidebackground.ui -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 139811] Sidebar Draw Properties deck -> Page -> Background 'Gradient' control needs additional height, the Insert Image dialog button is being clipped
https://bugs.documentfoundation.org/show_bug.cgi?id=139811 --- Comment #5 from Heiko Tietze --- Code pointer is sd/uiconfig/simpress/ui/sidebarslidebackground.ui -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 139811] Sidebar Draw Properties deck -> Page -> Background 'Gradient' control needs additional height, the Insert Image dialog button is being clipped
https://bugs.documentfoundation.org/show_bug.cgi?id=139811 Heiko Tietze changed: What|Removed |Added CC||kain...@gmail.com --- Comment #4 from Heiko Tietze --- Can't find an issue with the design but some more spacing would be nice anyway. Meaning everything is now in one grid with 3pt spacing but could separated before Insert Image getting also more spacing. What do you think, Andreas? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 139811] Sidebar Draw Properties deck -> Page -> Background 'Gradient' control needs additional height, the Insert Image dialog button is being clipped
https://bugs.documentfoundation.org/show_bug.cgi?id=139811 Heiko Tietze changed: What|Removed |Added CC||kain...@gmail.com --- Comment #4 from Heiko Tietze --- Can't find an issue with the design but some more spacing would be nice anyway. Meaning everything is now in one grid with 3pt spacing but could separated before Insert Image getting also more spacing. What do you think, Andreas? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 105395] Footer Altered for some pptx after opening in Impress: Master Object is displayed and it should not
https://bugs.documentfoundation.org/show_bug.cgi?id=105395 NISZ LibreOffice Team changed: What|Removed |Added CC||mic...@lebihan.pl --- Comment #6 from NISZ LibreOffice Team --- *** Bug 133154 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133154] FILEOPEN: PPTX: hidden background graphics displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=133154 NISZ LibreOffice Team changed: What|Removed |Added CC||libreoff...@nisz.hu Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #8 from NISZ LibreOffice Team --- *** This bug has been marked as a duplicate of bug 105395 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139818] REQUEST :: Need for BETTERING - Handling of graphics / photographs / objects AND THEIR ANCHORS
https://bugs.documentfoundation.org/show_bug.cgi?id=139818 Telesto changed: What|Removed |Added CC||tele...@surfxs.nl --- Comment #2 from Telesto --- Thanks for the report. Not totally following. The default anchoring is "to character" Is it possible to try to explain it again? If English being problematic, maybe in German. " There could be A SPECIAL ROUTINE, that could be automatcally invoked, to reorganise. PAGE ANCHORED Graphics to the "new (because inserted) numbers." -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139824] New: Allow multiselecting for styles in Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=139824 Bug ID: 139824 Summary: Allow multiselecting for styles in Sidebar Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: 79045_79...@mail.ru Description: Allow multiselecting for styles in Sidebar Steps to Reproduce: 1. Open Styles on Sidebar 2. Try select more than one style using any method => You can't Usecase -> I have a spreadsheet file with over 1000 wrong custom styles and I wanted delete it for one time, but I could delete it only one by one Actual Results: User can't select more than one style in Sidebar Expected Results: User can select more than one style in Sidebar Reproducible: Always User Profile Reset: No Additional Info: - -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/vectorgraphicdata.cxx | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
New commits:
commit ea3514e72961a6ee8b86413dbdbb69c61b368079
Author: Tomaž Vajngerl
AuthorDate: Sat Jan 2 00:18:25 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Jan 22 08:22:50 2021 +0100
vcl: rename ambiguious aSequence variable to aPropertySequence
There is maSequence already, which is totally different to this
variable, so rename it to aPropertySequence, which should hint
at what it is actually used for.
Change-Id: Ia202c5bd69ed17ebe80ffb522538e03de2a83f3c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109601
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/vectorgraphicdata.cxx
b/vcl/source/gdi/vectorgraphicdata.cxx
index 5a977191fef4..608251dc62c9 100644
--- a/vcl/source/gdi/vectorgraphicdata.cxx
+++ b/vcl/source/gdi/vectorgraphicdata.cxx
@@ -218,11 +218,11 @@ void VectorGraphicData::ensureSequenceAndRange()
std::copy(maDataContainer.cbegin(), maDataContainer.cend(),
aDataSequence.begin());
const uno::Reference xInputStream(new
comphelper::SequenceInputStream(aDataSequence));
-uno::Sequence< ::beans::PropertyValue > aSequence;
+uno::Sequence< ::beans::PropertyValue > aPropertySequence;
if (mpExternalHeader)
{
-aSequence = mpExternalHeader->getSequence();
+aPropertySequence = mpExternalHeader->getSequence();
}
if (xInputStream.is())
@@ -235,12 +235,12 @@ void VectorGraphicData::ensureSequenceAndRange()
if (!mbEnableEMFPlus)
{
-auto aVector =
comphelper::sequenceToContainer>(aSequence);
+auto aVector =
comphelper::sequenceToContainer>(aPropertySequence);
aVector.push_back(comphelper::makePropertyValue("EMFPlusEnable",
uno::makeAny(false)));
-aSequence = comphelper::containerToSequence(aVector);
+aPropertySequence =
comphelper::containerToSequence(aVector);
}
-maSequence =
comphelper::sequenceToContainer>>(xEmfParser->getDecomposition(xInputStream,
OUString(), aSequence));
+maSequence =
comphelper::sequenceToContainer>>(xEmfParser->getDecomposition(xInputStream,
OUString(), aPropertySequence));
}
break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 116228] UI glitches directly after changing „Tools/Options.../View/Notebookbar icon size:“ (needs redraw)
https://bugs.documentfoundation.org/show_bug.cgi?id=116228 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> --- No repro in (after click OK button in Options dialog) Version: 7.2.0.0.alpha0+ (x64) Build ID: 94f6765d6ecc3145fa2d266231124003cf953118 CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: threaded But it needs retesting on Linux Xisco? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/core/data/dociter.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit fc3b904b671a71266db2e8b30cbeeef4f7981753 Author: Michael Weghorn AuthorDate: Wed Jan 20 12:41:47 2021 +0100 Commit: Noel Grandin CommitDate: Fri Jan 22 08:03:59 2021 +0100 Related tdf#139782 sc: Make sure column exists before accessing it While the first fix (Change-Id I12a780bf52024cef31188651813d3a93cc2b5ddd, "tdf#139782 sc: Don't try to access unallocated column") makes opening the simplified bugdoc I had attached to tdf#139782 work, the original document I was given (which I can't share as is, but from which the simplified bugdoc was created) had more formulas and managed to hit another similar issue related to the fact that columns are now dynamically allocated, and crashed trying to access one that wasn't yet allocated. Fix this place as well by making sure the column exists. Backtrace: "#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50\n" "#1 0x77aa7537 in __GI_abort () at abort.c:79\n" "#2 0x7794beb1 in std::__throw_bad_exception() () at /lib/x86_64-linux-gnu/libstdc++.so.6\n" "#3 0x7fffa0b161dc in std::__debug::vector >, std::allocator > > >::operator[](unsigned long) (this=0x58827250, __n=84) at /usr/include/c++/10/debug/vector:427\n" "#4 0x7fffa0c23935 in ScColContainer::operator[](unsigned long) (this=0x58827250, nIndex=84) at .../libreoffice/sc/inc/colcontainer.hxx:44\n" "#5 0x7fffa0c76275 in ScQueryCellIterator::InitPos() (this=0x7fff8040) at .../libreoffice/sc/source/core/data/dociter.cxx:1082\n" "#6 0x7fffa0c76c28 in ScQueryCellIterator::GetFirst() (this=0x7fff8040) at .../libreoffice/sc/source/core/data/dociter.cxx:1233\n" "#7 0x7fffa0c76fb6 in ScQueryCellIterator::FindEqualOrSortedLastInRange(short&, int&) (this=0x7fff8040, nFoundCol=@0x7fff7f58: 1024, nFoundRow=@0x7fff7fb0: 1048576) at .../libreoffice/sc/source/core/data/dociter.cxx:1304\n" "#8 0x7fffa11b1529 in ScInterpreter::ScMatch() (this=0x619f7fd0) at .../libreoffice/sc/source/core/tool/interpr1.cxx:5050\n" "#9 0x7fffa121f653 in ScInterpreter::Interpret() (this=0x619f7fd0) at .../libreoffice/sc/source/core/tool/interpr4.cxx:4247\n" "#10 0x7fffa0f03bf5 in ScFormulaCell::InterpretTail(ScInterpreterContext&, ScFormulaCell::ScInterpretTailParameter) (this=0x5e793030, rContext=..., eTailParam=ScFormulaCell::SCITP_NORMAL) at .../libreoffice/sc/source/core/data/formulacell.cxx:1952\n" "#11 0x7fffa0f028b2 in ScFormulaCell::Interpret(int, int) (this=0x5e793030, nStartOffset=-1, nEndOffset=-1) at .../libreoffice/sc/source/core/data/formulacell.cxx:1644\n" "#12 0x7fffa0be0274 in ScFormulaCell::MaybeInterpret() (this=0x5e793030) at .../libreoffice/sc/inc/formulacell.hxx:445\n" "#13 0x7fffa0f07b34 in ScFormulaCell::GetErrCode() (this=0x5e793030) at .../libreoffice/sc/source/core/data/formulacell.cxx:2974\n" "#14 0x7fffa10bac28 in ScCellFormat::GetString(ScRefCellValue const&, unsigned int, rtl::OUString&, Color const**, SvNumberFormatter&, ScDocument const&, bool, bool, bool) (rCell=..., nFormat=0, rString=\"\", ppColor=0x7fff87e8, rFormatter=..., rDoc=..., bNullVals=true, bFormula=false, bUseStarFormat=false) at .../libreoffice/sc/source/core/tool/cellform.cxx:77\n" "#15 0x7fffa0bcb8f8 in ScColumn::UpdateScriptType(sc::CellTextAttr&, int, mdds::detail::mtv::iterator_base, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>::iterator_trait, mdds::detail::mtv::private_data_forward_update > >&) (this=0x5e793330, rAttr=..., nRow=1, itr=...) at .../libreoffice/sc/source/core/data/column3.cxx:794\n" "#16 0x7fffa0b9e315 in ScColumn::GetRangeScriptType(mdds::detail::mtv::iterator_base >, mdds::detail::mtv::event_func>::iterator_trait, mdds::detail::mtv::private_data_forward_update > >&, int, int, mdds::detail::mtv::iterator_base, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>::iterator_trait, mdds::detail::mtv::private_data_forward_update > > const&) (this=0x5e793330, itPos=..., nRow1=1, nRow2=1, itrCells_=...) at .../libreoffice/sc/source/core/data/column2.cxx:2089\n" "#17 0x7fffa0b27563 in (anonymous namespace)::FindEditCellsHandler::operator()(size_t, ScFormulaCell const*) (this=0x7fff9180, nRow=1, p=0x5e793030) at .../libreoffice/sc/source/core/data/column.cxx:3091\n" "#18 0x7fffa0b31267 in sc::CheckElem, mdds::multi_type_vector,
[Libreoffice-commits] core.git: sc/source
sc/source/core/data/dociter.cxx |4 1 file changed, 4 insertions(+) New commits: commit 3032cf9df042f50511a15c6a627c50f708a34238 Author: Michael Weghorn AuthorDate: Wed Jan 20 12:21:43 2021 +0100 Commit: Noel Grandin CommitDate: Fri Jan 22 08:03:16 2021 +0100 tdf#139782 sc: Don't try to access unallocated column This fixes a regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. Change-Id: I12a780bf52024cef31188651813d3a93cc2b5ddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109704 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/sc/source/core/data/dociter.cxx b/sc/source/core/data/dociter.cxx index d4e565edf80e..686e426c8d52 100644 --- a/sc/source/core/data/dociter.cxx +++ b/sc/source/core/data/dociter.cxx @@ -1798,6 +1798,10 @@ bool ScQueryCellIterator::BinarySearch() assert(nTab < rDoc.GetTableCount() && "index out of bounds, FIX IT"); nCol = maParam.nCol1; + +if (nCol >= rDoc.maTabs[nTab]->GetAllocatedColumnsCount()) +return false; + ScColumn* pCol = &(rDoc.maTabs[nTab])->aCol[nCol]; if (pCol->IsEmptyData()) return false; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sc/inc sc/sdi sc/source
sc/inc/sc.hrc |2 +-
sc/sdi/cellsh.sdi |1 +
sc/sdi/scalc.sdi | 17 +
sc/source/ui/view/cellsh1.cxx | 34 ++
4 files changed, 53 insertions(+), 1 deletion(-)
New commits:
commit 820984cdd2bc8f1bd8675606ec92eb42e01fff75
Author: Pranam Lashkari
AuthorDate: Tue Jan 5 20:43:57 2021 +0530
Commit: Pranam Lashkari
CommitDate: Fri Jan 22 07:51:53 2021 +0100
Added uno command for formula range selection
Change-Id: I01cd06ed51197ffe21102fb1fd0fcdce88ab333b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108810
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Szymon Kłos
(cherry picked from commit e8a9157878f156e599e66349d7fb60ca39e62514)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109746
Reviewed-by: Pranam Lashkari
diff --git a/sc/inc/sc.hrc b/sc/inc/sc.hrc
index 52b945ea9441..9ada93af7dfa 100644
--- a/sc/inc/sc.hrc
+++ b/sc/inc/sc.hrc
@@ -614,7 +614,7 @@
#define FID_DELETE_ALL_NOTES(SID_NEW_SLOTS+104)
#define SID_SCATTR_CELLPROTECTION(SID_NEW_SLOTS+105)
#define SID_SELECT_UNPROTECTED_CELLS (SID_NEW_SLOTS+106)
-
+#define SID_CURRENT_FORMULA_RANGE (SID_NEW_SLOTS+107)
// idl parameter
#define SID_SORT_BYROW (SC_PARAM_START)
diff --git a/sc/sdi/cellsh.sdi b/sc/sdi/cellsh.sdi
index e58ef8de34a8..5a257fe690ac 100644
--- a/sc/sdi/cellsh.sdi
+++ b/sc/sdi/cellsh.sdi
@@ -228,6 +228,7 @@ interface CellSelection
SID_DEC_INDENT [ ExecMethod = ExecuteEdit;
StateMethod = GetState; ]
SID_INC_INDENT [ ExecMethod = ExecuteEdit;
StateMethod = GetState; ]
SID_SELECT_UNPROTECTED_CELLS[ ExecMethod = ExecuteEdit;]
+SID_CURRENT_FORMULA_RANGE [ ExecMethod = ExecuteEdit;]
SID_THESAURUS [ ExecMethod = ExecuteEdit; StateMethod = GetCellState; ]
SID_SPELL_DIALOG [ ExecMethod = ExecuteEdit; StateMethod = GetState; ]
diff --git a/sc/sdi/scalc.sdi b/sc/sdi/scalc.sdi
index 23b9c72fbe0f..3f14637f3d4b 100644
--- a/sc/sdi/scalc.sdi
+++ b/sc/sdi/scalc.sdi
@@ -4436,6 +4436,23 @@ SfxVoidItem SelectUnprotectedCells
SID_SELECT_UNPROTECTED_CELLS
GroupId = SfxGroupId::Edit;
]
+SfxVoidItem CurrentFormulaRange SID_CURRENT_FORMULA_RANGE
+(SfxInt32Item StartCol FN_PARAM_1,SfxInt32Item StartRow
FN_PARAM_2,SfxInt32Item EndCol FN_PARAM_3,SfxInt32Item EndRow FN_PARAM_4,
SfxInt32Item Table FN_PARAM_5)
+[
+AutoUpdate = FALSE,
+FastCall = FALSE,
+ReadOnlyDoc = TRUE,
+Toggle = FALSE,
+Container = FALSE,
+RecordAbsolute = FALSE,
+RecordPerSet;
+
+AccelConfig = FALSE,
+MenuConfig = FALSE,
+ToolBoxConfig = FALSE,
+GroupId = SfxGroupId::Edit;
+]
+
SfxVoidItem SelectOLE SID_OLE_SELECT
()
[
diff --git a/sc/source/ui/view/cellsh1.cxx b/sc/source/ui/view/cellsh1.cxx
index 07e6ad15a44e..ccd17f217fa1 100644
--- a/sc/source/ui/view/cellsh1.cxx
+++ b/sc/source/ui/view/cellsh1.cxx
@@ -2704,6 +2704,40 @@ void ScCellShell::ExecuteEdit( SfxRequest& rReq )
}
break;
+case SID_CURRENT_FORMULA_RANGE:
+{
+const SfxInt32Item* param1 =
rReq.GetArg(FN_PARAM_1);
+SCCOL colStart = param1 ? param1->GetValue() : 0;
+
+const SfxInt32Item* param2 =
rReq.GetArg(FN_PARAM_2);
+SCROW rowStart = param2 ? param2->GetValue() : 0;
+
+const SfxInt32Item* param3 =
rReq.GetArg(FN_PARAM_3);
+SCCOL colEnd = param3 ? param3->GetValue() : 0;
+
+const SfxInt32Item* param4 =
rReq.GetArg(FN_PARAM_4);
+SCROW rowEnd = param4 ? param4->GetValue() : 0;
+
+const SfxInt32Item* param5 =
rReq.GetArg(FN_PARAM_5);
+SCROW table = param5 ? param5->GetValue() : 0;
+
+ScInputHandler* pInputHdl = SC_MOD()->GetInputHdl();
+
+if(param3 && param4 && pInputHdl && pTabViewShell)
+{
+ScViewData& rViewData = pTabViewShell->GetViewData();
+ScTabView* pTabView = dynamic_cast< ScTabView* >(
rViewData.GetView() );
+
+if (param1 && param2)
+rViewData.SetRefStart(colStart, rowStart, table);
+
+pTabView->UpdateRef( colEnd, rowEnd, table ); // setup the
end & refresh formula
+
+pInputHdl->UpdateLokReferenceMarks();
+}
+}
+break;
+
default:
OSL_FAIL("incorrect slot in ExecuteEdit");
break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120574] TXT file encoding is lost when saving
https://bugs.documentfoundation.org/show_bug.cgi?id=120574 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=38 ||902 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 38902] UTF-8 contents should be detected and this codepage should be suggested for FILESAVE as ".txt coded"
https://bugs.documentfoundation.org/show_bug.cgi?id=38902 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||0574 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/source
include/vcl/graph.hxx |1 +
vcl/inc/graphic/Manager.hxx|3 +++
vcl/inc/impgraph.hxx |1 +
vcl/source/filter/ipdf/pdfread.cxx |6 +-
vcl/source/gdi/graph.cxx |5 +
vcl/source/gdi/impgraph.cxx| 17 +
vcl/source/graphic/Manager.cxx |8
7 files changed, 36 insertions(+), 5 deletions(-)
New commits:
commit 3adff41ab14ab27ca07cffef0f38471ac5321ee2
Author: Tomaž Vajngerl
AuthorDate: Sat Jan 2 00:12:25 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Jan 22 07:49:17 2021 +0100
vcl: support creating a Graphic with only GfxLink as swapped-out
This adds support to create a Graphic with only a GfxLink and the
Graphic is in a swapped-out state. This is similar to the prepared
state, but the prepared state is a special state of the Graphic.
In the future, all loading will probably be done in this way and
prepared state will go away, but for now this is only supported
for PDF and is used in PDFium import only.
The main reason is to avoid that a multi-page PDF is immediately
swapped out after loading, which just does unneeded work and
freezes the application for a while.
Change-Id: I409741d27a4ad309264cdf27b2ba03f2cf37ead9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109600
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/vcl/graph.hxx b/include/vcl/graph.hxx
index 86d885a326ac..79083bb5a224 100644
--- a/include/vcl/graph.hxx
+++ b/include/vcl/graph.hxx
@@ -89,6 +89,7 @@ public:
SAL_DLLPRIVATE ImpGraphic* ImplGetImpGraphic() const { return
mxImpGraphic.get(); }
Graphic();
+Graphic(std::shared_ptr const & rGfxLink,
sal_Int32 nPageIndex = 0);
Graphic( const GraphicExternalLink& rGraphicLink );
Graphic( const Graphic& rGraphic );
Graphic( Graphic&& rGraphic ) noexcept;
diff --git a/vcl/inc/graphic/Manager.hxx b/vcl/inc/graphic/Manager.hxx
index 098c8644ac61..4319620e21c4 100644
--- a/vcl/inc/graphic/Manager.hxx
+++ b/vcl/inc/graphic/Manager.hxx
@@ -17,6 +17,7 @@
#include
#include
#include
+#include
#include
#include
@@ -60,6 +61,8 @@ public:
std::shared_ptr copy(std::shared_ptr const&
pImpGraphic);
std::shared_ptr newInstance();
std::shared_ptr newInstance(const BitmapEx& rBitmapEx);
+std::shared_ptr newInstance(std::shared_ptr const&
rLink,
+sal_Int32 nPageIndex = 0);
std::shared_ptr
newInstance(const std::shared_ptr&
rVectorGraphicDataPtr);
std::shared_ptr newInstance(const Animation& rAnimation);
diff --git a/vcl/inc/impgraph.hxx b/vcl/inc/impgraph.hxx
index 2ee0e9ef61ec..6287be0df1b1 100644
--- a/vcl/inc/impgraph.hxx
+++ b/vcl/inc/impgraph.hxx
@@ -90,6 +90,7 @@ public:
ImpGraphic( const ImpGraphic& rImpGraphic );
ImpGraphic( ImpGraphic&& rImpGraphic ) noexcept;
ImpGraphic( const GraphicExternalLink& rExternalLink);
+ImpGraphic(std::shared_ptr const& rGfxLink, sal_Int32 nPageIndex
= 0);
ImpGraphic( const BitmapEx& rBmpEx );
ImpGraphic(const std::shared_ptr&
rVectorGraphicDataPtr);
ImpGraphic( const Animation& rAnimation );
diff --git a/vcl/source/filter/ipdf/pdfread.cxx
b/vcl/source/filter/ipdf/pdfread.cxx
index 7a7d1c75aa38..f2730dbfe811 100644
--- a/vcl/source/filter/ipdf/pdfread.cxx
+++ b/vcl/source/filter/ipdf/pdfread.cxx
@@ -474,14 +474,10 @@ size_t ImportPDFUnloaded(const OUString& rURL,
std::vector& rG
tools::Long nPageWidth = convertTwipToMm100(aPageSize.getX() *
pointToTwipconversionRatio);
tools::Long nPageHeight = convertTwipToMm100(aPageSize.getY() *
pointToTwipconversionRatio);
-auto aVectorGraphicDataPtr = std::make_shared(
-aDataContainer, VectorGraphicDataType::Pdf, nPageIndex);
-
// Create the Graphic with the VectorGraphicDataPtr and link the
original PDF stream.
// We swap out this Graphic as soon as possible, and a later swap in
// actually renders the correct Bitmap on demand.
-Graphic aGraphic(aVectorGraphicDataPtr);
-aGraphic.SetGfxLink(pGfxLink);
+Graphic aGraphic(pGfxLink, nPageIndex);
auto pPage = pPdfDocument->openPage(nPageIndex);
diff --git a/vcl/source/gdi/graph.cxx b/vcl/source/gdi/graph.cxx
index 033e5576ce20..74a61e871e78 100644
--- a/vcl/source/gdi/graph.cxx
+++ b/vcl/source/gdi/graph.cxx
@@ -177,6 +177,11 @@ Graphic::Graphic(Graphic&& rGraphic) noexcept
{
}
+Graphic::Graphic(std::shared_ptr const & rGfxLink, sal_Int32
nPageIndex)
+: mxImpGraphic(vcl::graphic::Manager::get().newInstance(rGfxLink,
nPageIndex))
+{
+}
+
Graphic::Graphic(GraphicExternalLink const & rGraphicExternalLink)
:
mxImpGraphic(vcl::graphic::Manager::get().newInstance(rGraphicExternalLink))
{
diff --git
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/impgraph.cxx |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) New commits: commit 4cde10d255ce9741ca8ea115078b104dc4d67057 Author: Tomaž Vajngerl AuthorDate: Sat Jan 2 00:03:33 2021 +0900 Commit: Tomaž Vajngerl CommitDate: Fri Jan 22 07:48:53 2021 +0100 vcl: optimize copying size in px to ImpSwapInfo when swapping out Calling getSizePixel can force to create a bitmap for vector graphic, only for the purpuse to get the size of the graphic in pixels. We use this when swapping out, which is not ideal as we would force create a replacement bitmap just before we would get rid of it. This optimization will just copy the size in pixels to the ImpSwapInfo structure if a bitmap exists and otherwise leave it empty. Change-Id: I9ccb1af4ddc63e77e2a6ca536cb4f762d0b5f182 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109599 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/vcl/source/gdi/impgraph.cxx b/vcl/source/gdi/impgraph.cxx index 6fe065896d3f..5e53a900a60f 100644 --- a/vcl/source/gdi/impgraph.cxx +++ b/vcl/source/gdi/impgraph.cxx @@ -334,7 +334,11 @@ void ImpGraphic::createSwapInfo() if (isSwappedOut()) return; -maSwapInfo.maSizePixel = getSizePixel(); +if (!maBitmapEx.IsEmpty()) +maSwapInfo.maSizePixel = maBitmapEx.GetSizePixel(); +else +maSwapInfo.maSizePixel = Size(); + maSwapInfo.maPrefMapMode = getPrefMapMode(); maSwapInfo.maPrefSize = getPrefSize(); maSwapInfo.mbIsAnimated = isAnimated(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/inc vcl/Library_vcl.mk vcl/source
vcl/Library_vcl.mk |1 +
vcl/inc/graphic/VectorGraphicLoader.hxx| 24
vcl/source/gdi/impgraph.cxx| 29 ++---
vcl/source/graphic/VectorGraphicLoader.cxx | 26 ++
4 files changed, 73 insertions(+), 7 deletions(-)
New commits:
commit 9ae99dd8bcb682ca86e51ea89744f3a1c1de1d03
Author: Tomaž Vajngerl
AuthorDate: Fri Jan 1 23:44:57 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Jan 22 07:48:28 2021 +0100
vcl: create PDF from DataContainer, use that when swapping in
VectorGraphicLoader is a set of functions that "load" a vector
graphic (starting with PDF) from a BinaryDataContainer. Usually
this only needs to create VectorGraphicData and set the correct
type, as loading will be done on-demand.
Use the VectorGraphicLoader function when swapping-in so this is
an alternative to calling LoadNative on GfxLink, which loads
into a new Graphic via. GraphicFilter, which is something we
really want to avoid.
Change-Id: If529c8ddca2b31660da4ea28d8e75bb20bf3c778
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109598
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index e58e6b8b3d17..a27af8f6d031 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -337,6 +337,7 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
vcl/source/graphic/UnoGraphicProvider \
vcl/source/graphic/UnoGraphicTransformer \
vcl/source/graphic/VectorGraphicSearch \
+vcl/source/graphic/VectorGraphicLoader \
vcl/source/bitmap/impvect \
vcl/source/bitmap/bitmap \
vcl/source/bitmap/BitmapEx \
diff --git a/vcl/inc/graphic/VectorGraphicLoader.hxx
b/vcl/inc/graphic/VectorGraphicLoader.hxx
new file mode 100644
index ..b6f38120885c
--- /dev/null
+++ b/vcl/inc/graphic/VectorGraphicLoader.hxx
@@ -0,0 +1,24 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#pragma once
+
+#include
+#include
+#include
+#include
+
+namespace vcl
+{
+std::shared_ptr
+loadPdfFromDataContainer(BinaryDataContainer const& rDataContainer);
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/gdi/impgraph.cxx b/vcl/source/gdi/impgraph.cxx
index 794d5ca68a22..6fe065896d3f 100644
--- a/vcl/source/gdi/impgraph.cxx
+++ b/vcl/source/gdi/impgraph.cxx
@@ -46,6 +46,7 @@
#include
#include
#include
+#include
#define GRAPHIC_MTFTOBMP_MAXEXT 2048
#define GRAPHIC_STREAMBUFSIZE 8192UL
@@ -1422,16 +1423,30 @@ bool ImpGraphic::swapIn()
}
else if (mpGfxLink && mpGfxLink->IsNative())
{
-Graphic aGraphic;
-if (!mpGfxLink->LoadNative(aGraphic))
-return false;
+if (mpGfxLink->GetType() == GfxLinkType::NativePdf)
+{
+maVectorGraphicData =
vcl::loadPdfFromDataContainer(mpGfxLink->getDataContainer());
-ImpGraphic* pImpGraphic = aGraphic.ImplGetImpGraphic();
+// Set to 0, to force recalculation
+mnSizeBytes = 0;
+mnChecksum = 0;
-if (meType != pImpGraphic->meType)
-return false;
+restoreFromSwapInfo();
-updateFromLoadedGraphic(pImpGraphic);
+mbSwapOut = false;
+}
+else
+{
+Graphic aGraphic;
+if (!mpGfxLink->LoadNative(aGraphic))
+return false;
+
+ImpGraphic* pImpGraphic = aGraphic.ImplGetImpGraphic();
+if (meType != pImpGraphic->meType)
+return false;
+
+updateFromLoadedGraphic(pImpGraphic);
+}
maLastUsed = std::chrono::high_resolution_clock::now();
bReturn = true;
diff --git a/vcl/source/graphic/VectorGraphicLoader.cxx
b/vcl/source/graphic/VectorGraphicLoader.cxx
new file mode 100644
index ..988c3db803be
--- /dev/null
+++ b/vcl/source/graphic/VectorGraphicLoader.cxx
@@ -0,0 +1,26 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#include
+#include
+
+namespace vcl
+{
+std::shared_ptr
+loadPdfFromDataContainer(BinaryDataContainer const& rDataContainer)
+{
+if (rDataContainer.isEmpty())
+return std::shared_ptr();
+
+return std::make_shared(rDataContainer,
VectorGraphicDataType::Pdf);
+}
+}
+
+/*
[Libreoffice-commits] core.git: filter/source offapi/com vcl/source
filter/source/pdf/pdfdecomposer.cxx| 14 ++
offapi/com/sun/star/graphic/XPdfDecomposer.idl |7 ---
vcl/source/gdi/vectorgraphicdata.cxx | 11 +++
3 files changed, 21 insertions(+), 11 deletions(-)
New commits:
commit 2d0cefae7a899e5ed62730468f4fb0f25d6297e3
Author: Tomaž Vajngerl
AuthorDate: Thu Dec 31 21:10:27 2020 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Jan 22 07:48:09 2021 +0100
[API CHANGE] change XPdfDecomposer to use XBinaryDataContainer
Using BinaryDataContainer doesn't require to copy the data as it
is compatible with what is used in Graphic, VectorGraphicData and
GfxLink.
Change-Id: I01589158ae6bf6ac407bde60f07952e3968e3970
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109597
Tested-by: Tomaž Vajngerl
Reviewed-by: Tomaž Vajngerl
diff --git a/filter/source/pdf/pdfdecomposer.cxx
b/filter/source/pdf/pdfdecomposer.cxx
index ce1321a3ceb5..f4572f93742a 100644
--- a/filter/source/pdf/pdfdecomposer.cxx
+++ b/filter/source/pdf/pdfdecomposer.cxx
@@ -17,11 +17,14 @@
#include
#include
#include
+#include
+#include
#include
#include
#include
#include
+#include
using namespace css;
@@ -38,7 +41,7 @@ public:
// XPdfDecomposer
uno::Sequence> SAL_CALL
-getDecomposition(const uno::Sequence& xPdfData,
+getDecomposition(const uno::Reference&
xDataContainer,
const uno::Sequence&
xDecompositionParameters) override;
// XServiceInfo
@@ -49,8 +52,9 @@ public:
XPdfDecomposer::XPdfDecomposer(uno::Reference const&)
{}
-uno::Sequence> SAL_CALL
XPdfDecomposer::getDecomposition(
-const uno::Sequence& xPdfData, const
uno::Sequence& xParameters)
+uno::Sequence> SAL_CALL
+XPdfDecomposer::getDecomposition(const
uno::Reference& xDataContainer,
+ const uno::Sequence&
xParameters)
{
sal_Int32 nPageIndex = -1;
@@ -66,8 +70,10 @@ uno::Sequence>
SAL_CALL XPdfDecomposer::ge
if (nPageIndex < 0)
nPageIndex = 0;
+BinaryDataContainer aDataContainer =
vcl::convertUnoBinaryDataContainer(xDataContainer);
+
std::vector aBitmaps;
-int rv = vcl::RenderPDFBitmaps(xPdfData.getConstArray(),
xPdfData.getLength(), aBitmaps,
+int rv = vcl::RenderPDFBitmaps(aDataContainer.getData(),
aDataContainer.getSize(), aBitmaps,
nPageIndex, 1);
if (rv == 0)
return {}; // happens if we do not have PDFium
diff --git a/offapi/com/sun/star/graphic/XPdfDecomposer.idl
b/offapi/com/sun/star/graphic/XPdfDecomposer.idl
index 25bf8870c1ee..9976475d74cd 100644
--- a/offapi/com/sun/star/graphic/XPdfDecomposer.idl
+++ b/offapi/com/sun/star/graphic/XPdfDecomposer.idl
@@ -11,6 +11,7 @@
#define __com_sun_star_graphic_XPdfDecomposer_idl__
#include
+#include
module com { module sun { module star { module graphic {
@@ -26,15 +27,15 @@ interface XPdfDecomposer : ::com::sun::star::uno::XInterface
{
/** Retrieve decomposed list - in this case a bitmap with the rendered PDF.
-@param xPdfData
-The PDF data.
+@param xDataContainer
+The PDF data in a data container
@param xDecompositionParameters
Parameters for decomposition. Parameters include:
sal_Int32 PageIndex - which page to use
*/
-sequence getDecomposition([in] sequence xPdfData,
+sequence getDecomposition([in]
com::sun::star::util::XBinaryDataContainer xDataContainer,
[in]
sequence xDecompositionParameters);
};
diff --git a/vcl/source/gdi/vectorgraphicdata.cxx
b/vcl/source/gdi/vectorgraphicdata.cxx
index 2afe12e97fbd..5a977191fef4 100644
--- a/vcl/source/gdi/vectorgraphicdata.cxx
+++ b/vcl/source/gdi/vectorgraphicdata.cxx
@@ -29,6 +29,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -40,6 +41,7 @@
#include
#include
#include
+#include
using namespace ::com::sun::star;
@@ -249,10 +251,11 @@ void VectorGraphicData::ensureSequenceAndRange()
uno::Sequence aDecompositionParameters =
comphelper::InitPropertySequence({
{"PageIndex", uno::makeAny(mnPageIndex)},
});
-// TODO: change xPdfDecomposer to use BinaryDataContainer directly
-css::uno::Sequence
aDataSequence(maDataContainer.getSize());
-std::copy(maDataContainer.cbegin(), maDataContainer.cend(),
aDataSequence.begin());
-auto xPrimitive2D =
xPdfDecomposer->getDecomposition(aDataSequence, aDecompositionParameters);
+
+auto* pUnoBinaryDataContainer = new
UnoBinaryDataContainer(getBinaryDataContainer());
+uno::Reference xDataContainer =
pUnoBinaryDataContainer;
+
+auto xPrimitive2D =
xPdfDecomposer->getDecomposition(xDataContainer, aDecompositionParameters);
maSequence =
[Libreoffice-commits] core.git: external/libcdr external/libqxp
external/libcdr/UnpackedTarball_libcdr.mk |1 +
external/libcdr/ax_gcc_func_attribute.m4.patch | 11 +++
external/libqxp/UnpackedTarball_libqxp.mk |3 +++
external/libqxp/ax_gcc_func_attribute.m4.patch | 11 +++
4 files changed, 26 insertions(+)
New commits:
commit 05aedcba6672979d317b540bbfa74f5c9b409402
Author: Stephan Bergmann
AuthorDate: Thu Jan 21 23:19:20 2021 +0100
Commit: Stephan Bergmann
CommitDate: Fri Jan 22 07:31:49 2021 +0100
Fix use of -fvisibility=hidden with Clang in external/libcdr,
external/libqxp
At least on macOS x86-64 you get a warning
> [build LNK] Library/libwpftdrawlo.dylib
> ld: warning: direct access in function
'std::__1::__shared_ptr_pointer::__shared_ptr_default_delete, std::__1::allocator
>::__get_deleter(std::type_info const&) const' from file
'workdir/UnpackedTarball/libzmf/src/lib/.libs/libzmf-0.0.a(ZMFDocument.o)' to
global weak symbol 'typeinfo for
std::__1::shared_ptr::__shared_ptr_default_delete' from file
'workdir/UnpackedTarball/libcdr/src/lib/.libs/libcdr-0.1.a(CDRDocument.o)'
means the weak symbol cannot be overridden at runtime. This was likely caused
by different translation units being compiled with different visibility
settings.
The reason is that libzmf uses -fvisibility=hidden and generates
> $ nm -m workdir/UnpackedTarball/libzmf/src/lib/.libs/libzmf-0.0.a | grep
__ZTINSt3__110shared_ptrIN10librevenge15RVNGInputStreamEE27__shared_ptr_default_deleteIS2_S2_EE
> 6dd8 (__DATA,__const) weak private external
__ZTINSt3__110shared_ptrIN10librevenge15RVNGInputStreamEE27__shared_ptr_default_deleteIS2_S2_EE
while libcdr erroneously does not use -fvisibility=hidden and generates
> $ nm -m workdir/UnpackedTarball/libcdr/src/lib/.libs/libcdr-0.1.a | grep
__ZTINSt3__110shared_ptrIN10librevenge15RVNGInputStreamEE27__shared_ptr_default_deleteIS2_S2_EE
> 72b8 (__DATA,__const) weak external
__ZTINSt3__110shared_ptrIN10librevenge15RVNGInputStreamEE27__shared_ptr_default_deleteIS2_S2_EE
The reason for that error is as follows:
workdir/UnpackedTarball/libcdr/configure.ac uses, among other things, the
result
of
AX_GCC_FUNC_ATTRIBUTE([visibility])
when deciding whether to use -fvisibility=hidden. And the old ("serial 5")
workdir/UnpackedTarball/libcdr/m4/ax_gcc_func_attribute.m4 decides "no" if
its
test compilation generates any warning output. But Clang on macOS generates
> conftest.cpp:34:56: warning: target does not support 'protected'
visibility; using 'default' [-Wunsupported-visibility]
> int foo_pro( void )
__attribute__((visibility("protected")));
>^
and lots of
> conftest.cpp:2:9: warning: macro is not used [-Wunused-macros]
> #define PACKAGE_NAME "libcdr"
> ^
(because of -Wunused-macros set for Clang in
solenv/gbuild/platform/com_GCC_defs.mk).
Same issue with external/libqxp, which would cause
> [LNK] Library/libwpftdrawlo.dylib
> ld: warning: direct access in function
'std::__1::__shared_ptr_pointer::__shared_ptr_default_delete, std::__1::allocator
>::__get_deleter(std::type_info const&) const' from file
'workdir/UnpackedTarball/libcdr/src/lib/.libs/libcdr-0.1.a(CDRDocument.o)' to
global weak symbol 'typeinfo for
std::__1::shared_ptr::__shared_ptr_default_delete' from file
'workdir/UnpackedTarball/libqxp/src/lib/.libs/libqxp-0.0.a(QXPMacFileParser.o)'
means the weak symbol cannot be overridden at runtime. This was likely caused
by different translation units being compiled with different visibility
settings.
"ax_gcc_func_attribute: Revise
the
detection of unknown attributes", even though it was apparently meant to fix
something different, nicely fixes this Clang issue, making
AX_GCC_FUNC_ATTRIBUTE
correctly detect support for visibility now.
When building with Clang on Linux, there is no -Wunsupported-visibility
about
__attribute__((visibility("protected"))), but all the -Wunused-macros are
present as well, which caused all the AX_GCC_FUNC_ATTRIBUTE checks to be
mis-
detected as "no" there, too.
There are more uses of AX_GCC_FUNC_ATTRIBUTE in
workdir/UnpackedTarball/libcdr/configure.ac and
workdir/UnpackedTarball/libqxp/configure.ac, and there are many more
workdir/UnpackedTarball/*/m4/ax_gcc_func_attribute.m4 in other external
projects,
all of which may cause similar AX_GCC_FUNC_ATTRIBUTE mis-detections.
However,
they do not cause any noticeable traces like the "direct access" ld warning
here,
so I left those alone for now. (Ultimately, all the upstream external
projects
should probably
[Libreoffice-bugs] [Bug 139267] FORMS: Databases lost contact to Writer-form
https://bugs.documentfoundation.org/show_bug.cgi?id=139267 Justin L changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Justin L --- This seems to have been fixed in 7.1 by author Michael Stahl on 2021-01-11 10:29:48 with commit db283d2e3f5cd8be412c5204f358cd06af761b13 xmloff: "form:datasource" vs. "db:data-source" Recently xmloff started to use XML_DATASOURCE for "form:datasource" but it actually means "data-source". Add XML_DATA_SOURCE and use it for "db:data-source". (regression from 3de38e95561ab7ca114d9f3307702ba89c4e3e9a) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/uitest/data/tdf138546.odt |binary
sw/qa/uitest/writer_tests4/tdf138546.py | 46
sw/source/ui/frmdlg/column.cxx | 16 +--
sw/source/uibase/inc/column.hxx |2 -
4 files changed, 55 insertions(+), 9 deletions(-)
New commits:
commit b84bcb4fd70ae920ac2f54f70919b773fa9b2e78
Author: Justin Luth
AuthorDate: Tue Dec 22 17:36:54 2020 +0300
Commit: Mike Kaganski
CommitDate: Fri Jan 22 05:25:52 2021 +0100
tdf#138546 sw PageDialog: fix bad reset of colwidth
The presence of border padding was causing the algorithm
to reset the overall width, which in page style triggered
an even redistribution of the columns. That should only
happen when the number of columns changes, or else one of
the 5 predefined column choices is selected.
My first python unit test is included.
make UITest_writer_tests4 \
UITEST_TEST_NAME=tdf138546.tdf138546.test_tdf138546
Change-Id: I650e429568f2ab794649cc557998a809479b6e82
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108210
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sw/qa/uitest/data/tdf138546.odt b/sw/qa/uitest/data/tdf138546.odt
new file mode 100644
index ..8bfa9f6e5a2d
Binary files /dev/null and b/sw/qa/uitest/data/tdf138546.odt differ
diff --git a/sw/qa/uitest/writer_tests4/tdf138546.py
b/sw/qa/uitest/writer_tests4/tdf138546.py
new file mode 100644
index ..c94f7eed3d48
--- /dev/null
+++ b/sw/qa/uitest/writer_tests4/tdf138546.py
@@ -0,0 +1,46 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+from uitest.framework import UITestCase
+from uitest.uihelper.common import change_measurement_unit
+from uitest.uihelper.common import get_state_as_dict, type_text
+from uitest.uihelper.common import select_pos
+import org.libreoffice.unotest
+import pathlib
+def get_url_for_data_file(file_name):
+return
pathlib.Path(org.libreoffice.unotest.makeCopyFromTDOC(file_name)).as_uri()
+class tdf138546(UITestCase):
+def test_tdf138546(self):
+self.ui_test.load_file(get_url_for_data_file("tdf138546.odt"))
+xWriterDoc = self.xUITest.getTopFocusWindow()
+
+change_measurement_unit(self, "Centimeter")
+
+#dialog Columns
+self.ui_test.execute_dialog_through_command(".uno:FormatColumns")
+xDialog = self.xUITest.getTopFocusWindow()
+
+colsnf = xDialog.getChild("colsnf")
+width1mf = xDialog.getChild("width1mf")
+self.assertEqual(get_state_as_dict(colsnf)["Text"], "2")
+self.assertEqual((get_state_as_dict(width1mf)["Text"])[0:3], "2.0")
#2.00 cm
+xOKBtn = xDialog.getChild("cancel")
+self.ui_test.close_dialog_through_button(xOKBtn)
+
+self.ui_test.execute_dialog_through_command(".uno:PageDialog")
+xDialog = self.xUITest.getTopFocusWindow()
+tabcontrol = xDialog.getChild("tabcontrol")
+select_pos(tabcontrol, "7") #Columns
+colsnf = xDialog.getChild("colsnf")
+width1mf = xDialog.getChild("width1mf")
+self.assertEqual(get_state_as_dict(colsnf)["Text"], "2")
+self.assertEqual((get_state_as_dict(width1mf)["Text"])[0:3], "2.0")
#2.00 cm
+xOKBtn = xDialog.getChild("cancel")
+self.ui_test.close_dialog_through_button(xOKBtn)
+
+self.ui_test.close_doc()
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/sw/source/ui/frmdlg/column.cxx b/sw/source/ui/frmdlg/column.cxx
index 4adf7cb34447..472ce06acb82 100644
--- a/sw/source/ui/frmdlg/column.cxx
+++ b/sw/source/ui/frmdlg/column.cxx
@@ -903,12 +903,12 @@ void SwColumnPage::SetLabels( sal_uInt16 nVis )
* the column number overwrites potential user's width settings; all columns
* are equally wide.
*/
-IMPL_LINK(SwColumnPage, ColModify, weld::SpinButton&, rEdit, void)
+IMPL_LINK_NOARG(SwColumnPage, ColModify, weld::SpinButton&, void)
{
-ColModify();
+ColModify(/*bForceColReset=*/false);
}
-void SwColumnPage::ColModify(const weld::SpinButton* pNF)
+void SwColumnPage::ColModify(bool bForceColReset)
{
m_nCols = static_cast(m_xCLNrEdt->get_value());
//#107890# the handler is also called from LoseFocus()
@@ -916,10 +916,10 @@ void SwColumnPage::ColModify(const weld::SpinButton* pNF)
// #i17816# changing the displayed types within the ValueSet
//from two columns to two columns with different settings doesn't
invalidate the
// example windows in ::ColModify()
-if (pNF && m_xColMgr->GetCount() == m_nCols)
+if (!bForceColReset && m_xColMgr->GetCount() == m_nCols)
return;
-if (pNF)
+if (!bForceColReset)
m_aDefaultVS.SetNoSelection();
tools::Long nDist = static_cast< tools::Long
[Libreoffice-commits] core.git: vcl/source
vcl/source/app/salvtables.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit f72c5680b0e10ad59e2abf0ebc1e71c94c41d173
Author: Mert Tumer
AuthorDate: Wed Dec 16 21:02:42 2020 +0300
Commit: Mert Tumer
CommitDate: Fri Jan 22 05:17:06 2021 +0100
Fix MouseClick shoud be MouseLeft for drawing area
Change-Id: I4dd0c6862c6473d3cbfcc4535c2d2ebe4a0a238a
Signed-off-by: Mert Tumer
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108683
Tested-by: Jenkins CollaboraOffice
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109215
Tested-by: Jenkins
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 6183b1a3ac24..fe93e637a823 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -5921,7 +5921,7 @@ OutputDevice& SalInstanceDrawingArea::get_ref_device() {
return *m_xDrawingArea;
void SalInstanceDrawingArea::click(const Point& rPos)
{
-MouseEvent aEvent(rPos);
+MouseEvent aEvent(rPos, 1, MouseEventModifiers::NONE, MOUSE_LEFT, 0);
m_xDrawingArea->MouseButtonDown(aEvent);
m_xDrawingArea->MouseButtonUp(aEvent);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 139781] Community/Enterprise flavor breaks the StartCenter
https://bugs.documentfoundation.org/show_bug.cgi?id=139781 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139486] FORMS: Height of fields couldn't be changed by key directly
https://bugs.documentfoundation.org/show_bug.cgi?id=139486 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139125] Need to set options "Mail Merge E-mail" twice
https://bugs.documentfoundation.org/show_bug.cgi?id=139125 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139479] Impossible to configure Update
https://bugs.documentfoundation.org/show_bug.cgi?id=139479 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139475] Shape 1 being selected at cut action, but Image205 selected after undo
https://bugs.documentfoundation.org/show_bug.cgi?id=139475 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139467] Calc: Data->Refresh Range fails if query (Base) has been inserted with user interface language set to German
https://bugs.documentfoundation.org/show_bug.cgi?id=139467 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139474] Style inspector not showing Direct Formatting in Comment box
https://bugs.documentfoundation.org/show_bug.cgi?id=139474 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137864] Master slides formatting for outline text format not saved (and rendered)
https://bugs.documentfoundation.org/show_bug.cgi?id=137864 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139481] Ctrl-Click hyperlink sends wrong link. it sends the old pre edited link
https://bugs.documentfoundation.org/show_bug.cgi?id=139481 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139469] [LOCALHELP] fontwork help page needs review
https://bugs.documentfoundation.org/show_bug.cgi?id=139469 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134273] Calc and Writer freeze.
https://bugs.documentfoundation.org/show_bug.cgi?id=134273 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139463] Imported SVG background not rendered correctly in master slides
https://bugs.documentfoundation.org/show_bug.cgi?id=139463 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139472] [EDITING] Internal document Hyperlink get broken when changing UI language
https://bugs.documentfoundation.org/show_bug.cgi?id=139472 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134273] Calc and Writer freeze.
https://bugs.documentfoundation.org/show_bug.cgi?id=134273 --- Comment #4 from QA Administrators --- Dear Felipe, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139459] "Close Preview" is always showing in the File Menu even though the preview is not being used
https://bugs.documentfoundation.org/show_bug.cgi?id=139459 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132994] Crash when I try to connect Writer with Calc in combining correspondence
https://bugs.documentfoundation.org/show_bug.cgi?id=132994 --- Comment #8 from QA Administrators --- Dear aneolf, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93668] [l10n, Russian] A few more statistical problems
https://bugs.documentfoundation.org/show_bug.cgi?id=93668 --- Comment #7 from QA Administrators --- Dear Mercury, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132994] Crash when I try to connect Writer with Calc in combining correspondence
https://bugs.documentfoundation.org/show_bug.cgi?id=132994 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68910] EDITING: Wrong pasting websites from WikiTravel
https://bugs.documentfoundation.org/show_bug.cgi?id=68910 --- Comment #6 from QA Administrators --- Dear Bartosz Skowron, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68364] Fields: Conditional text error
https://bugs.documentfoundation.org/show_bug.cgi?id=68364 --- Comment #10 from QA Administrators --- Dear Roberto Guimarães, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68801] Empty status bar appears after Ctrl+V if it was disabled beforehand
https://bugs.documentfoundation.org/show_bug.cgi?id=68801 --- Comment #8 from QA Administrators --- Dear Dario, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67259] PDF: Charts in Writer documents do not refresh to represent new data in generated PDF: Tilte and axis labels incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=67259 --- Comment #9 from QA Administrators --- Dear Brandon Tylke, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49246] FILEOPEN: particular .pptx with missing (2D) WordArt Text Effects (Glow)
https://bugs.documentfoundation.org/show_bug.cgi?id=49246 --- Comment #12 from QA Administrators --- Dear sasha.libreoffice, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104293] Image is dropping out of the table cell when its moved near to the cell border
https://bugs.documentfoundation.org/show_bug.cgi?id=104293 --- Comment #7 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 139811] Sidebar Draw Properties deck -> Page -> Background 'Gradient' control needs additional height, the Insert Image dialog button is being clipped
https://bugs.documentfoundation.org/show_bug.cgi?id=139811 --- Comment #3 from mwtjunkm...@gmail.com --- (In reply to V Stuart Foote from comment #2) > No, the intended function is to provide the image background preferentially. > > The 'Insert Picture...' dialog control is intentionally present with *each* > of the Background types--its button is clipped for the Gradient selection > only bcz the gradient has both a start and an end color pick. The gradient > mode needs a few more pixels. > > Otherwise, a simple viusal glitch that does not affect function in *any* > way. > > It may or may not show full button in macOS or one of the Linux backends. Selecting gradient also hides the margin and master page controls. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 139811] Sidebar Draw Properties deck -> Page -> Background 'Gradient' control needs additional height, the Insert Image dialog button is being clipped
https://bugs.documentfoundation.org/show_bug.cgi?id=139811 --- Comment #3 from mwtjunkm...@gmail.com --- (In reply to V Stuart Foote from comment #2) > No, the intended function is to provide the image background preferentially. > > The 'Insert Picture...' dialog control is intentionally present with *each* > of the Background types--its button is clipped for the Gradient selection > only bcz the gradient has both a start and an end color pick. The gradient > mode needs a few more pixels. > > Otherwise, a simple viusal glitch that does not affect function in *any* > way. > > It may or may not show full button in macOS or one of the Linux backends. Selecting gradient also hides the margin and master page controls. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa uitest/uitest
sc/qa/uitest/calc_tests8/tdf118308.py | 58 ++
uitest/uitest/test.py | 15 ++--
2 files changed, 69 insertions(+), 4 deletions(-)
New commits:
commit 86c8c775bbefe333d684e12c99855a3c1de68051
Author: Xisco Fauli
AuthorDate: Thu Jan 21 23:16:19 2021 +0100
Commit: Xisco Fauli
CommitDate: Fri Jan 22 00:41:28 2021 +0100
tdf#118308: sc: Add UItest
Change-Id: I4d23b4eda9abeb0c062259601ba9bfb2179d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109775
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/uitest/calc_tests8/tdf118308.py
b/sc/qa/uitest/calc_tests8/tdf118308.py
new file mode 100644
index ..313a2dc35ec8
--- /dev/null
+++ b/sc/qa/uitest/calc_tests8/tdf118308.py
@@ -0,0 +1,58 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+from uitest.framework import UITestCase
+from uitest.uihelper.common import get_state_as_dict
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.uihelper.calc import enter_text_to_cell
+from libreoffice.calc.document import get_cell_by_position
+
+class tdf118308(UITestCase):
+
+def test_tdf118308(self):
+calc_doc = self.ui_test.create_doc_in_start_center("calc")
+xCalcDoc = self.xUITest.getTopFocusWindow()
+gridwin = xCalcDoc.getChild("grid_window")
+document = self.ui_test.get_component()
+
+enter_text_to_cell(gridwin, "A1", "A")
+gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "A1"}))
+self.xUITest.executeCommand(".uno:Copy")
+
+self.ui_test.close_doc()
+
+calc_doc = self.ui_test.load_empty_file("calc")
+
+xCalcDoc = self.xUITest.getTopFocusWindow()
+gridwin = xCalcDoc.getChild("grid_window")
+document = self.ui_test.get_component()
+
+gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "A1"}))
+
+self.ui_test.execute_dialog_through_command(".uno:PasteSpecial")
+xDialog = self.xUITest.getTopFocusWindow()
+
+# Without the fix in place, this test would have failed here
+# since a different dialog would have been opened and the children
+# wouldn't have been found
+xText = xDialog.getChild("text")
+xNumbers = xDialog.getChild("numbers")
+xDatetime = xDialog.getChild("datetime")
+xFormats = xDialog.getChild("formats")
+
+self.assertEqual("true", get_state_as_dict(xText)["Selected"])
+self.assertEqual("true", get_state_as_dict(xNumbers)["Selected"])
+self.assertEqual("true", get_state_as_dict(xDatetime)["Selected"])
+self.assertEqual("false", get_state_as_dict(xFormats)["Selected"])
+
+xOkBtn = xDialog.getChild("ok")
+self.ui_test.close_dialog_through_button(xOkBtn)
+
+self.assertEqual("A", get_cell_by_position(document, 0, 0,
0).getString())
+self.ui_test.close_doc()
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
+
diff --git a/uitest/uitest/test.py b/uitest/uitest/test.py
index 556fb511cc97..a746643638bf 100644
--- a/uitest/uitest/test.py
+++ b/uitest/uitest/test.py
@@ -66,10 +66,14 @@ class UITest(object):
time_ += DEFAULT_SLEEP
time.sleep(DEFAULT_SLEEP)
-def load_file(self, url):
+def load_file(self, url, eventName="OnLoad"):
+target = "_default"
+if eventName == "OnNew":
+target = "_blank"
+
desktop = self.get_desktop()
-with EventListener(self._xContext, "OnLoad") as event:
-component = desktop.loadComponentFromURL(url, "_default", 0,
tuple())
+with EventListener(self._xContext, eventName) as event:
+component = desktop.loadComponentFromURL(url, target, 0, tuple())
time_ = 0
while time_ < MAX_WAIT:
if event.executed:
@@ -81,6 +85,10 @@ class UITest(object):
time_ += DEFAULT_SLEEP
time.sleep(DEFAULT_SLEEP)
+def load_empty_file(self, app):
+url = "private:factory/s" + app
+return self.load_file(url, "OnNew")
+
def execute_dialog_through_command(self, command, printNames=False):
with EventListener(self._xContext, "DialogExecute",
printNames=printNames) as event:
if not self._xUITest.executeDialog(command):
@@ -149,7 +157,6 @@ class UITest(object):
if event.executed:
frames = self.get_frames()
self.get_desktop().setActiveFrame(frames[0])
-print(len(frames))
return
time_ += DEFAULT_SLEEP
time.sleep(DEFAULT_SLEEP)
___
[Libreoffice-bugs] [Bug 139823] Writer: Extrange behaviour comprising frames and 3-column table
https://bugs.documentfoundation.org/show_bug.cgi?id=139823 drexlar changed: What|Removed |Added CC||ramiroar...@usa.com --- Comment #1 from drexlar --- Created attachment 169083 --> https://bugs.documentfoundation.org/attachment.cgi?id=169083=edit Bug concerning frames and 3-column table -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139823] New: Writer: Extrange behaviour comprising frames and 3-column table
https://bugs.documentfoundation.org/show_bug.cgi?id=139823 Bug ID: 139823 Summary: Writer: Extrange behaviour comprising frames and 3-column table Product: LibreOffice Version: 6.4.6.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ramiroar...@usa.com Description: The problem cannot be described here. I made a Writer document of 8 pages describing the situation before the problem and after the problem. Steps to Reproduce: 1. Please read my document 2. I will enclose it 3. I think once this bug is submitted Actual Results: The matter of the fact is that the problem is not easily reproducible. That is why I made an 8 page document trying to meticulously describe the problem. Expected Results: It is described in my document Reproducible: Sometimes User Profile Reset: Yes OpenGL enabled: Yes Additional Info: It is obvious if you read my document -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139822] Wrong button type within Startcenter on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=139822 --- Comment #1 from Thorsten Wagner --- Created attachment 169082 --> https://bugs.documentfoundation.org/attachment.cgi?id=169082=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139822] New: Wrong button type within Startcenter on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=139822 Bug ID: 139822 Summary: Wrong button type within Startcenter on macOS Product: LibreOffice Version: 7.1.0.2 rc Hardware: All OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: thorsten.wagne...@gmail.com Description: When opening Startcenter button "Recent Documents" is selected first. A native button is displayed now. All other buttons are displayed as stock buttons with images on the left side (see screenshot attached). Steps to Reproduce: 1. Open LO Startcenter Actual Results: Button "Recent Documents" is displayed as native button. Expected Results: Button "Recent Documents" is display as stock button with image on the left side as alle other buttons. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.1.0.2.0+ / LibreOffice Community Build ID: 0565308bbb1d654dc129f200b08e475ae3a4f97a CPU threads: 12; OS: Mac OS X 10.14.6; UI render: GL; VCL: osx Locale: de-DE (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: canvas/source sd/qa
canvas/source/directx/dx_surfacebitmap.cxx |2 +-
sd/qa/unit/import-tests-smartart.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit b3d713e7be354712f8815c877eb3787ac38bdc11
Author: Andrea Gelmini
AuthorDate: Wed Jan 20 12:59:14 2021 +0100
Commit: Andrea Gelmini
CommitDate: Fri Jan 22 00:16:58 2021 +0100
Fix typos
Change-Id: Ie8d28702bbae6c76924745a5a773393f1b831012
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109706
Tested-by: Jenkins
Reviewed-by: Andrea Gelmini
diff --git a/canvas/source/directx/dx_surfacebitmap.cxx
b/canvas/source/directx/dx_surfacebitmap.cxx
index a118b31db2d8..e8eb44566c8f 100644
--- a/canvas/source/directx/dx_surfacebitmap.cxx
+++ b/canvas/source/directx/dx_surfacebitmap.cxx
@@ -540,7 +540,7 @@ namespace dxcanvas
// lock the directx surface to receive the pointer to the surface
memory.
D3DLOCKED_RECT aLockedRect;
if(FAILED(mpSurface->LockRect(,nullptr,D3DLOCK_NOSYSLOCK|D3DLOCK_READONLY)))
-throw uno::RuntimeException("failed to lock direcrx surface to
surface memory");
+throw uno::RuntimeException("failed to lock directx surface to
surface memory");
sal_uInt8 const *pSrc = reinterpret_cast(data.getConstArray());
sal_uInt8 *pDst = (static_cast(aLockedRect.pBits)+(rect.Y1*aLockedRect.Pitch))+rect.X1;
diff --git a/sd/qa/unit/import-tests-smartart.cxx
b/sd/qa/unit/import-tests-smartart.cxx
index ecd881330f63..e4bf1d4d2c63 100644
--- a/sd/qa/unit/import-tests-smartart.cxx
+++ b/sd/qa/unit/import-tests-smartart.cxx
@@ -1731,7 +1731,7 @@ void SdImportTestSmartArt::testSnakeRows()
void SdImportTestSmartArt::testCompositeInferRight()
{
// Load a smartart which contains a composite algorithm.
-// One contraint says that the left of the text should be the right of the
image.
+// One constraint says that the left of the text should be the right of
the image.
sd::DrawDocShellRef xDocShRef = loadURL(
m_directories.getURLFromSrc(u"/sd/qa/unit/data/pptx/smartart-composite-infer-right.pptx"),
PPTX);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/qa
sw/qa/uitest/writer_tests5/titlePageWizard.py |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 9b19c772b85e2b19dd6a1296767d99119d54002d
Author: Andrea Gelmini
AuthorDate: Thu Jan 21 13:34:02 2021 +0100
Commit: Andrea Gelmini
CommitDate: Fri Jan 22 00:16:14 2021 +0100
Fix typo
Change-Id: Id6594ea397f08e1b460d8ba94cb05e674dfa2ba0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109757
Tested-by: Jenkins
Reviewed-by: Andrea Gelmini
diff --git a/sw/qa/uitest/writer_tests5/titlePageWizard.py
b/sw/qa/uitest/writer_tests5/titlePageWizard.py
index 24d3ff4c53cb..a04ebaf61eff 100644
--- a/sw/qa/uitest/writer_tests5/titlePageWizard.py
+++ b/sw/qa/uitest/writer_tests5/titlePageWizard.py
@@ -81,7 +81,7 @@ class tdf138907(UITestCase):
self.ui_test.execute_dialog_through_command(".uno:TitlePageDialog")
xDialog = self.xUITest.getTopFocusWindow()
print(xDialog.getChildren())
-#Insert thre title/index pages at page two.
+#Insert the title/index pages at page two.
xPageCount = xDialog.getChild("NF_PAGE_COUNT")
for _ in range(0,2):
xPageCount.executeAction("UP", tuple())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92622] WRITER: context menu "Unstyle selected text" from list style to "no-list" style
https://bugs.documentfoundation.org/show_bug.cgi?id=92622 --- Comment #17 from S.Zosgornik --- I don't think "Clear Direct Formatting" should apply on list because they have there own styles -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139074] CRASH on Paste from clipboard into dialog or other floating window, paste to document canvas is fine; Windows only?
https://bugs.documentfoundation.org/show_bug.cgi?id=139074 Xisco Faulí changed: What|Removed |Added CC||kls...@web.de --- Comment #45 from Xisco Faulí --- *** Bug 139821 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139821] Libre Office 7.1.0.1 Writer Crash when pasting in the search box
https://bugs.documentfoundation.org/show_bug.cgi?id=139821 Xisco Faulí changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||xiscofa...@libreoffice.org --- Comment #1 from Xisco Faulí --- Thanks for reporting this issue. This is a duplicate of bug 139074 and it's fixed in LibreOffice 7.1.0.2 *** This bug has been marked as a duplicate of bug 139074 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137864] Master slides formatting for outline text format not saved (and rendered)
https://bugs.documentfoundation.org/show_bug.cgi?id=137864 Marina Latini (SUSE) changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||gulsah.k...@collabora.com, ||marina.latini@libreoffice.o ||rg Ever confirmed|0 |1 Keywords|bibisectRequest |bibisected --- Comment #1 from Marina Latini (SUSE) --- Repro with: Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: 4e1294b7d6f8de981147f15d4ca1b4e4853249eb CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: kf5 Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded ID="opensuse-tumbleweed" VERSION_ID="20210105" No repro with: Version: 6.0.6.0.0+ Build ID: c6c82096301180cfa7942dd9fb9d1cb66c7ecc04 CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3; Locale: en-GB (en_GB.UTF-8); Calc: group No repro with: Version: 6.3.0.0.alpha1+ Build ID: c98b1f1cd43b3e109bcaf6324ef2d1f449b34099 CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: kde5; Locale: en-GB (en_GB.UTF-8); UI-Language: en-US Calc: threaded 9ec89f14bbd717d3dbc1da107e34ff1b3ec9a4b0 is the first bad commit commit 9ec89f14bbd717d3dbc1da107e34ff1b3ec9a4b0 Author: Jenkins Build User Date: Tue Jul 16 08:49:15 2019 +0200 source sha:40bb9ac690d979ef544d5aa759bd734a176912a0 source sha:40bb9ac690d979ef544d5aa759bd734a176912a0 instdir/program/libsdlo.so | Bin 10058008 -> 10058008 bytes instdir/program/versionrc | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) https://git.libreoffice.org/core/+/40bb9ac690d979ef544d5aa759bd734a176912a0%5E%21 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139667] Should "Bullets and Numbering" in Writer become "Lists", with consistent use of "List Style" in Writer UI?
https://bugs.documentfoundation.org/show_bug.cgi?id=139667 --- Comment #5 from sdc.bla...@youmail.dk --- Created attachment 169081 --> https://bugs.documentfoundation.org/attachment.cgi?id=169081=edit proposed changes to Format and Styles menus (In reply to sdc.blanco from comment #2) > "Lists" seems better (but will require some evaluation of consequences in > Format menu) 1. Attached is proposal for Format menu "before" and "after". 2. Plus the "direct format lists" should be removed from Styles menu. (UI reason: clear, consistent separation of Styles and direct formatting) (UX reason: multiple comments in BZ about how users need to learn styles and the difference between direct formatted lists and styled lists - so -- UI should facilitate that ideal by not mixing these things up.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 139667] Should "Bullets and Numbering" in Writer become "Lists", with consistent use of "List Style" in Writer UI?
https://bugs.documentfoundation.org/show_bug.cgi?id=139667 --- Comment #5 from sdc.bla...@youmail.dk --- Created attachment 169081 --> https://bugs.documentfoundation.org/attachment.cgi?id=169081=edit proposed changes to Format and Styles menus (In reply to sdc.blanco from comment #2) > "Lists" seems better (but will require some evaluation of consequences in > Format menu) 1. Attached is proposal for Format menu "before" and "after". 2. Plus the "direct format lists" should be removed from Styles menu. (UI reason: clear, consistent separation of Styles and direct formatting) (UX reason: multiple comments in BZ about how users need to learn styles and the difference between direct formatted lists and styled lists - so -- UI should facilitate that ideal by not mixing these things up.) -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 123008] text in table wasn't aligned when opening a RTF file
https://bugs.documentfoundation.org/show_bug.cgi?id=123008 --- Comment #3 from Dieter --- Still present in Version: 7.0.4.2 (x64) Build ID: dcf040e67528d9187c66b2379df5ea4407429775 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/data/ods/tdf122643.ods |binary
sc/qa/unit/subsequent_filters-test.cxx | 14 ++
2 files changed, 14 insertions(+)
New commits:
commit 09192bc178f7f7b21ef63508f516f52790f3307d
Author: Xisco Fauli
AuthorDate: Thu Jan 21 21:30:44 2021 +0100
Commit: Xisco Fauli
CommitDate: Thu Jan 21 22:52:25 2021 +0100
tdf#122643: sc_subsequent_filters: Add unittest
Change-Id: I89aed7ffbe40ddda19baff569b08580f1e4f118d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109770
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/unit/data/ods/tdf122643.ods
b/sc/qa/unit/data/ods/tdf122643.ods
new file mode 100644
index ..7c1d5485531e
Binary files /dev/null and b/sc/qa/unit/data/ods/tdf122643.ods differ
diff --git a/sc/qa/unit/subsequent_filters-test.cxx
b/sc/qa/unit/subsequent_filters-test.cxx
index dea5fa845d80..6635feb5e10b 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -254,6 +254,7 @@ public:
void testTdf100709XLSX();
void testTdf97598XLSX();
void testTdf110440XLSX();
+void testTdf122643();
void testTdf132278();
void testTdf130959();
void testTdf129410();
@@ -438,6 +439,7 @@ public:
CPPUNIT_TEST(testTdf100709XLSX);
CPPUNIT_TEST(testTdf97598XLSX);
CPPUNIT_TEST(testTdf110440XLSX);
+CPPUNIT_TEST(testTdf122643);
CPPUNIT_TEST(testTdf132278);
CPPUNIT_TEST(testTdf130959);
CPPUNIT_TEST(testTdf129410);
@@ -3842,6 +3844,18 @@ void ScFiltersTest::testTdf110440XLSX()
xDocSh->DoClose();
}
+void ScFiltersTest::testTdf122643()
+{
+// Would crash without the fix on loading
+ScDocShellRef xDocSh = loadDoc(u"tdf122643.", FORMAT_ODS);
+CPPUNIT_ASSERT_MESSAGE("Failed to open doc", xDocSh.is());
+
+ScDocument& rDoc = xDocSh->GetDocument();
+rDoc.CalcAll(); // perform hard re-calculation.
+
+xDocSh->DoClose();
+}
+
void ScFiltersTest::testTdf132278()
{
// Would crash without the fix on loading
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 113998] Moving a bulleted list entry up/down also moves the subsequent text line
https://bugs.documentfoundation.org/show_bug.cgi?id=113998 Dieter changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #8 from Dieter --- WORKSFORME in Version: 7.0.4.2 (x64) Build ID: dcf040e67528d9187c66b2379df5ea4407429775 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103369 Bug 103369 depends on bug 113998, which changed state. Bug 113998 Summary: Moving a bulleted list entry up/down also moves the subsequent text line https://bugs.documentfoundation.org/show_bug.cgi?id=113998 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103239] [META] Toolbars bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103239 Bug 103239 depends on bug 112743, which changed state. Bug 112743 Summary: Undo toolbar button not active after modifying page style https://bugs.documentfoundation.org/show_bug.cgi?id=112743 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107936] [META] Page-level bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107936 Bug 107936 depends on bug 112743, which changed state. Bug 112743 Summary: Undo toolbar button not active after modifying page style https://bugs.documentfoundation.org/show_bug.cgi?id=112743 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105948 Bug 105948 depends on bug 112743, which changed state. Bug 112743 Summary: Undo toolbar button not active after modifying page style https://bugs.documentfoundation.org/show_bug.cgi?id=112743 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139811] Sidebar Draw Properties deck -> Page -> Background 'Gradient' control needs additional height, the Insert Image dialog button is being clipped
https://bugs.documentfoundation.org/show_bug.cgi?id=139811 V Stuart Foote changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||vstuart.fo...@utsa.edu Ever confirmed|0 |1 Summary|Windows 10 LO Draw sidebar |Sidebar Draw Properties |interface needs to be |deck -> Page -> Background |thoroughly revisited for|'Gradient' control needs |which controls appear when |additional height, the |and for what|Insert Image dialog button ||is being clipped --- Comment #2 from V Stuart Foote --- No, the intended function is to provide the image background preferentially. The 'Insert Picture...' dialog control is intentionally present with *each* of the Background types--its button is clipped for the Gradient selection only bcz the gradient has both a start and an end color pick. The gradient mode needs a few more pixels. Otherwise, a simple viusal glitch that does not affect function in *any* way. It may or may not show full button in macOS or one of the Linux backends. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112743] Undo toolbar button not active after modifying page style
https://bugs.documentfoundation.org/show_bug.cgi?id=112743 Dieter changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from Dieter --- WORKSFORME with Version: 7.0.4.2 (x64) Build ID: dcf040e67528d9187c66b2379df5ea4407429775 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 139811] Sidebar Draw Properties deck -> Page -> Background 'Gradient' control needs additional height, the Insert Image dialog button is being clipped
https://bugs.documentfoundation.org/show_bug.cgi?id=139811 V Stuart Foote changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||vstuart.fo...@utsa.edu Ever confirmed|0 |1 Summary|Windows 10 LO Draw sidebar |Sidebar Draw Properties |interface needs to be |deck -> Page -> Background |thoroughly revisited for|'Gradient' control needs |which controls appear when |additional height, the |and for what|Insert Image dialog button ||is being clipped --- Comment #2 from V Stuart Foote --- No, the intended function is to provide the image background preferentially. The 'Insert Picture...' dialog control is intentionally present with *each* of the Background types--its button is clipped for the Gradient selection only bcz the gradient has both a start and an end color pick. The gradient mode needs a few more pixels. Otherwise, a simple viusal glitch that does not affect function in *any* way. It may or may not show full button in macOS or one of the Linux backends. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 87321] FILEOPEN: high memory footprint opening a xls containg a big html table in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=87321 Gabriele changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #10 from Gabriele --- I'm the original submitter, 6 years later. Seems to be at least partially solved. RAM usage to open the file is down to 2.1GB which is still high but surely feasible nowadays Version: 7.0.3.1 Build ID: 00(Build:1) CPU threads: 6; OS: Linux 5.8; UI render: default; VCL: kf5 Locale: en-US (it_IT.UTF-8); Interfaccia utente: it-IT Ubuntu package version: 1:7.0.3-0ubuntu0.20.10.1 Calc: threaded I've also tested in version 6.4.6 in Windows and also in that version appears to use something more than 2GB of memory -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122652] [META] Memory problems in LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=122652 Bug 122652 depends on bug 87321, which changed state. Bug 87321 Summary: FILEOPEN: high memory footprint opening a xls containg a big html table in Calc https://bugs.documentfoundation.org/show_bug.cgi?id=87321 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109072] [META] XLS (binary) format bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=109072 Bug 109072 depends on bug 87321, which changed state. Bug 87321 Summary: FILEOPEN: high memory footprint opening a xls containg a big html table in Calc https://bugs.documentfoundation.org/show_bug.cgi?id=87321 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139803] highlight and font colours are always reset to defaults without asking!
https://bugs.documentfoundation.org/show_bug.cgi?id=139803 Telesto changed: What|Removed |Added CC||tele...@surfxs.nl Ever confirmed|0 |1 OS|Linux (All) |All Status|UNCONFIRMED |NEW --- Comment #1 from Telesto --- Confirm Version: 7.1.0.0.alpha1+ Build ID: c784b3da15102caf1022e83371863a86766e69cd CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139811] Windows 10 LO Draw sidebar interface needs to be thoroughly revisited for which controls appear when and for what
https://bugs.documentfoundation.org/show_bug.cgi?id=139811 Telesto changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||tele...@surfxs.nl Keywords||needsUXEval -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 139811] Windows 10 LO Draw sidebar interface needs to be thoroughly revisited for which controls appear when and for what
https://bugs.documentfoundation.org/show_bug.cgi?id=139811 Telesto changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||tele...@surfxs.nl Keywords||needsUXEval -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 139633] Direct editing of tree nodes in the Navigator to rename objects
https://bugs.documentfoundation.org/show_bug.cgi?id=139633 --- Comment #8 from Xisco Faulí --- (In reply to Jim Raykowski from comment #4) > Direct editing is the way renaming is done in the Form Navigator. Menu > > Form > Form Navigator... > > IMHO, it is a challenging hack for a beginning LO hacker. > > If anyone is interested in taking this on please let me know. I will provide > code pointers and review to make this work in the Writer Navigator content > tree. Hi Jim, Could you please provide the code pointers so we can turn this bug into an easyhack ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139821] New: Libre Office 7.1.0.1 Writer Crash when pasting in the search box
https://bugs.documentfoundation.org/show_bug.cgi?id=139821 Bug ID: 139821 Summary: Libre Office 7.1.0.1 Writer Crash when pasting in the search box Product: LibreOffice Version: 6.4.7.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kls...@web.de Description: When I search entries/text - with contr F and edit the texz; then it is ok to start search - but when i copy and insert the text into the search box; the writer and total L.O. will crash. Maybe is like this as well with "Calc" - I did not test. I guess, this crash is not just with LO 7.x - could persist since prior versions - I can not tell. Steps to Reproduce: 1. think, I gave enough input above 2. do copy and paste to the search box 3. Actual Results: LO will crash immediatly Expected Results: LO will do usual recovery Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: allow c into the search box -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139633] Direct editing of tree nodes in the Navigator to rename objects
https://bugs.documentfoundation.org/show_bug.cgi?id=139633 --- Comment #7 from Telesto --- (In reply to Xisco Faulí from comment #6) > (In reply to Telesto from comment #5) > > Adding easyHack & mentoring.. To be sure it's on a proper list. Where > > 'easyHack' must be read 'instrumentally'; not literally.. being a > > challenging hack > > Hi Telesto, > Please, do not add the keyword 'easyhack' unless you know the code involved > and the effort it would require to fix the issue. You also need to add code > pointers when you use the keyword 'easyhack' and they are missing in this > case. Deleting the keyword... comment 4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92622] WRITER: context menu "Unstyle selected text" from list style to "no-list" style
https://bugs.documentfoundation.org/show_bug.cgi?id=92622
--- Comment #16 from An-Kh ---
(In reply to Heiko Tietze from comment #13)
> Character Style has a Default option to un-set so we should add this to the
> list styles too. Could be labelled "No List" rather than "None".
>
> @An-Kh: You need to add a new list style, make it responsive so "No List" is
> highlighted unless something is set, respond to selection, etc. Sounds like
> an interesting difficulty. Please unassign if this is too challenging.
>
> Very basic code pointer: sfx2/source/dialog/templdlg.cxx (interaction with
> the UI) and check doc/SwStyleNameMapper.cxx and other for
> STR_POOLCHR_STANDARD ("Default CS").
Hi
If I understand correctly, two tasks need to be done in this patch..
1. In the Styles menu menubar, a "No List" option needs to be added, which is
by default selected unless some other type of list (e.g. Bulleted List) is
selected.
2."Clear direct formatting" should work for lists as well, i.e., if it is
pressed "No List" option should be selected by default..
Please correct me if I am wrong..
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138409] FIREBIRD: decimal fields in table are falsifying their default values
https://bugs.documentfoundation.org/show_bug.cgi?id=138409 --- Comment #19 from Caolán McNamara --- wip of https://gerrit.libreoffice.org/c/core/+/109772 along the lines of that theory. You have to change the defaults to new defaults via the UI for the change to take effect. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 139667] Should "Bullets and Numbering" in Writer become "Lists", with consistent use of "List Style" in Writer UI?
https://bugs.documentfoundation.org/show_bug.cgi?id=139667 sdc.bla...@youmail.dk changed: What|Removed |Added Summary|Should "Bullets and |Should "Bullets and |Numbering" in Writer become |Numbering" in Writer become |"Bullets and Lists", with |"Lists", with consistent |consistent use of "List |use of "List Style" in |Style" in Writer UI?|Writer UI? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 139667] Should "Bullets and Numbering" in Writer become "Lists", with consistent use of "List Style" in Writer UI?
https://bugs.documentfoundation.org/show_bug.cgi?id=139667 sdc.bla...@youmail.dk changed: What|Removed |Added Summary|Should "Bullets and |Should "Bullets and |Numbering" in Writer become |Numbering" in Writer become |"Bullets and Lists", with |"Lists", with consistent |consistent use of "List |use of "List Style" in |Style" in Writer UI?|Writer UI? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: avmedia/source include/avmedia sd/qa svx/source
avmedia/source/framework/mediaitem.cxx | 13 +
include/avmedia/mediaitem.hxx |8 ++--
sd/qa/unit/export-tests-ooxml1.cxx | 23 +++
svx/source/svdraw/svdomedia.cxx|5 +
svx/source/unodraw/unoprov.cxx |1 +
svx/source/unodraw/unoshap4.cxx| 31 +--
6 files changed, 77 insertions(+), 4 deletions(-)
New commits:
commit e2d46da076f43a7c0d56fc486b9f15339243f7c9
Author: Miklos Vajna
AuthorDate: Thu Jan 21 15:08:13 2021 +0100
Commit: Miklos Vajna
CommitDate: Thu Jan 21 21:40:20 2021 +0100
avmedia: add doc model for bitmap fill of slide narrations
This allows specifying a custom bitmap for a media shape. It's mostly
useful for audio-only streams where the additional bitmap may be e.g. a
speaker icon to indicate this a narration.
Change-Id: I21c1b492ac09b631cf6e3ec8120be8b82c01c26d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109763
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/avmedia/source/framework/mediaitem.cxx
b/avmedia/source/framework/mediaitem.cxx
index f42065e8e81e..54db2e3bc6bf 100644
--- a/avmedia/source/framework/mediaitem.cxx
+++ b/avmedia/source/framework/mediaitem.cxx
@@ -40,6 +40,7 @@
#include
#include
#include
+#include
using namespace ::com::sun::star;
@@ -62,6 +63,7 @@ struct MediaItem::Impl
boolm_bLoop;
boolm_bMute;
css::media::ZoomLevel m_eZoom;
+Graphic m_aGraphic;
explicit Impl(AVMediaSetMask nMaskSet)
: m_nMaskSet( nMaskSet )
@@ -104,6 +106,7 @@ bool MediaItem::operator==( const SfxPoolItem& rItem ) const
&& m_pImpl->m_URL == rOther.m_pImpl->m_URL
&& m_pImpl->m_Referer == rOther.m_pImpl->m_Referer
&& m_pImpl->m_sMimeType == rOther.m_pImpl->m_sMimeType
+&& m_pImpl->m_aGraphic == rOther.m_pImpl->m_aGraphic
&& m_pImpl->m_eState == rOther.m_pImpl->m_eState
&& m_pImpl->m_fDuration == rOther.m_pImpl->m_fDuration
&& m_pImpl->m_fTime == rOther.m_pImpl->m_fTime
@@ -188,6 +191,9 @@ void MediaItem::merge( const MediaItem& rMediaItem )
if( AVMediaSetMask::MIME_TYPE & nMaskSet )
setMimeType( rMediaItem.getMimeType() );
+if (nMaskSet & AVMediaSetMask::GRAPHIC)
+setGraphic(rMediaItem.getGraphic());
+
if( AVMediaSetMask::STATE & nMaskSet )
setState( rMediaItem.getState() );
@@ -256,6 +262,13 @@ OUString MediaItem::getMimeType() const
return !m_pImpl->m_sMimeType.isEmpty() ? m_pImpl->m_sMimeType :
AVMEDIA_MIMETYPE_COMMON;
}
+void MediaItem::setGraphic(const Graphic& rGraphic)
+{
+m_pImpl->m_nMaskSet |= AVMediaSetMask::GRAPHIC;
+m_pImpl->m_aGraphic = rGraphic;
+}
+
+Graphic MediaItem::getGraphic() const { return m_pImpl->m_aGraphic; }
void MediaItem::setState( MediaState eState )
{
diff --git a/include/avmedia/mediaitem.hxx b/include/avmedia/mediaitem.hxx
index 7246c9e7e2a1..9e3fb4cd4530 100644
--- a/include/avmedia/mediaitem.hxx
+++ b/include/avmedia/mediaitem.hxx
@@ -32,6 +32,7 @@ namespace com::sun::star::embed { class XStorage; }
namespace com::sun::star::frame { class XModel; }
namespace com::sun::star::io { class XInputStream; }
namespace com::sun::star::io { class XStream; }
+class Graphic;
enum class AVMediaSetMask
{
@@ -45,11 +46,12 @@ enum class AVMediaSetMask
ZOOM= 0x040,
URL = 0x080,
MIME_TYPE = 0x100,
-ALL = 0x1ff,
+GRAPHIC = 0x200,
+ALL = 0x3ff,
};
namespace o3tl
{
-template<> struct typed_flags :
is_typed_flags {};
+template<> struct typed_flags :
is_typed_flags {};
}
@@ -115,6 +117,8 @@ public:
voidsetMimeType( const OUString& rMimeType );
OUStringgetMimeType() const;
+void setGraphic(const Graphic& rGraphic);
+Graphic getGraphic() const;
const OUString& getTempURL() const;
const OUString& getReferer() const;
diff --git a/sd/qa/unit/export-tests-ooxml1.cxx
b/sd/qa/unit/export-tests-ooxml1.cxx
index 5784d00d112d..91ce68e20a50 100644
--- a/sd/qa/unit/export-tests-ooxml1.cxx
+++ b/sd/qa/unit/export-tests-ooxml1.cxx
@@ -53,6 +53,8 @@
#include
#include
+#include
+#include
using namespace css;
@@ -1313,6 +1315,27 @@ void SdOOXMLExportTest1::testNarrationMimeType()
assertXPath(pXmlDoc,
"/ContentType:Types/ContentType:Override[@PartName='/ppt/media/media1.m4a']",
"ContentType", "audio/mp4");
+
+// Check if the bitmap of the media shape is exported correctly.
+xmlDocUniquePtr pSlideDoc = parseExport(aTempFile,
"ppt/slides/slide1.xml");
+OUString aImageId = getXPath(pSlideDoc,
"/p:sld/p:cSld/p:spTree/p:pic/p:blipFill/a:blip", "embed");
+xmlDocUniquePtr pRelsDoc = parseExport(aTempFile,
"ppt/slides/_rels/slide1.xml.rels");
+OUString aImagePath =
[Libreoffice-bugs] [Bug 139633] Direct editing of tree nodes in the Navigator to rename objects
https://bugs.documentfoundation.org/show_bug.cgi?id=139633 Xisco Faulí changed: What|Removed |Added Keywords|difficultyInteresting, | |easyHack, skillCpp | --- Comment #6 from Xisco Faulí --- (In reply to Telesto from comment #5) > Adding easyHack & mentoring.. To be sure it's on a proper list. Where > 'easyHack' must be read 'instrumentally'; not literally.. being a > challenging hack Hi Telesto, Please, do not add the keyword 'easyhack' unless you know the code involved and the effort it would require to fix the issue. You also need to add code pointers when you use the keyword 'easyhack' and they are missing in this case. Deleting the keyword... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Calc memory consumption
On 20/01/2021 10:29, Daniel A. Rodriguez wrote: >>> Hi, exists some kind of formula to estimate how much RAM a spreadsheet >>> could use? For instance 468K rows and columns from A to AG. > > Well, trying to do something with such file using an i3 based PC with > 4Gb freezes the software completely. Both Tor and Noel are right; but I collect the 'shape' of pathological spreadsheets as a hobby =) Can you tell me: + what data-type is in each column + whether the column is sparse (ie, are there 'holes' in the data) + what formulae are used - and what their shape is ? + hopefully formulae are normally non-confidential + what file format you're using. But of course, this really doesn't belong on the dev list, but in a bug if you have one ? In case nothing jumps out of the above data, possibly running a sampling profiler under Linux like 'perf' might show what's being slow, though I imagine it sounds like a memory issue (perhaps even a transient memory use) problem. Thanks ! =) Michael. -- michael.me...@collabora.com <><, GM Collabora Productivity Hangout: mejme...@gmail.com, Skype: mmeeks (M) +44 7795 666 147 - timezone usually UK / Europe ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sfx2/source
sfx2/source/appl/appserv.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit bfe856e7cb191888b723e6bb115242dc6d73d334
Author: Andras Timar
AuthorDate: Thu Jan 21 21:27:38 2021 +0100
Commit: Andras Timar
CommitDate: Thu Jan 21 21:29:04 2021 +0100
Use the he...@collaboraoffice.com for user feedback
Change-Id: I8a779b98e60a9037188674a0ad6fd60aa8ea32ee
diff --git a/sfx2/source/appl/appserv.cxx b/sfx2/source/appl/appserv.cxx
index 07f56777b5af..47fb7a5f92c7 100644
--- a/sfx2/source/appl/appserv.cxx
+++ b/sfx2/source/appl/appserv.cxx
@@ -562,7 +562,7 @@ void SfxApplication::MiscExec_Impl( SfxRequest& rReq )
case SID_SEND_FEEDBACK:
{
OUString module = SfxHelp::GetCurrentModuleIdentifier();
-OUString
sURL("mailto:supp...@collaboraoffice.com?Subject=Version:%20; +
utl::ConfigManager::getAboutBoxProductVersion() +
+OUString
sURL("mailto:he...@collaboraoffice.com?Subject=Version:%20; +
utl::ConfigManager::getAboutBoxProductVersion() +
",%20Locale:%20" + utl::ConfigManager::getUILocale() +
",%20Module:%20" + module.copy(module.lastIndexOf('.') + 1 ) );
sfx2::openUriExternally(sURL, false);
break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 133214] UI: Icons of the tabbed toolbar aren't positioned properly on MacOS
https://bugs.documentfoundation.org/show_bug.cgi?id=133214 --- Comment #10 from Thorsten Wagner --- Created attachment 169080 --> https://bugs.documentfoundation.org/attachment.cgi?id=169080=edit Screenshot of GTK UI -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133214] UI: Icons of the tabbed toolbar aren't positioned properly on MacOS
https://bugs.documentfoundation.org/show_bug.cgi?id=133214 Thorsten Wagner changed: What|Removed |Added CC||thorsten.wagne...@gmail.com --- Comment #9 from Thorsten Wagner --- Sven, I suggest not to fix issue within macOS specific VCL code (vcl/osx and vcl/quartz) directories. Please find attached a screenshot from a GTK UI: (1) Different tabs are simple text labels similar to Windows UIs. (2) With current macOS implementation dialog tabs are used. These tabs are positioned centered on the top border of the window. I guess this causes area for icons above to be calculated too small. My proposal: (1) Identify code to be used to draw notebookbar outside macOS specific code and replace usage of native widgets (tab items in this case) by using stock widgets (independent from GTK, QT, Windows or macOS backends) - take care not to cause side effects to other backends. (2) Doublecheck whether toolbar is drawn similar to GTK. If the issue still exists thereafter, reasons of miscalculation have to be identified. In any case I suggest not to use HITheme tabs for notebookbar. BTW: Wrong text colors within tabs on macOS Big Sur have been fixed in the meantime. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139667] Should "Bullets and Numbering" in Writer become "Bullets and Lists", with consistent use of "List Style" in Writer UI?
https://bugs.documentfoundation.org/show_bug.cgi?id=139667 --- Comment #4 from sdc.bla...@youmail.dk --- (In reply to Dieter from comment #3) > We shouldn't use phrase "numbering style" (I agree). Good. > But since we have "Numbered Lists" and "Bulleted Lists" it is logic to me > that we also have "Numbered List Style" and "Bulleted List Style" > (at least in documentation). Please elaborate your logic. Meanwhile, some counter-arguments. 1. In relation to documentation: - cannot find any instances of "Numbered List Style" or "Bulleted List Style" in the current online help. - "numbered list styles" and "bulleted list styles" appear only one time each in Writers Guide 6.4 (i.e., not a big revision task) 2. In light of previous point: why introduce a new phrase that is likely to create unnecessary confusion with "style" and "list style" ? 3. (from point 5, comment 0): "Numbered List" and "Bulleted List" should remain unchanged. 4. (from point 4, comment 2): Refer to different "types" of "Bulleted list" or different "types" of "Numbered list". But "types" does not have to be a "technical word" (see next point). 5. (from point 3, comment 2): Use adjectives to refer to lists. For example, Roman Numbered List, alphabetic numbered List. In that case (in documentation), one could refer to different "kinds" of numbered list. In sum, the idea is: The UI, tooltips and documentation should only use the word "style" in relation to LO Styles (Paragraph, Character, List, etc.) Possibly this principle is a little artificial or stiff, but then there is no ambiguity about when/whether the UI/documentation is referring to Styles -- as opposed to direct formatting. -- and points 4 and 5 show that it is not so difficult -- in documentation -- to refer to different types or kinds of bulleted or numbered lists -- nor is it a handicap that one should not use styles in those situations. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
