Re: Starmath syntax hightlight

2021-01-29 Thread Heiko Tietze

Respective ticket is https://bugs.documentfoundation.org/show_bug.cgi?id=138129

On 29.01.21 12:46, Dante Doménech wrote:

The starmath syntax highlight first revision is now available here:
https://gerrit.libreoffice.org/c/core/+/109639/21 



I write asking for a deep review since it's a patch that may change the user 
experience.

I'd like the UX team to take a look and evaluate the code legibility.
Note that bright colors have been avoided.
Maybe some documentation should be added.
Get sure the preferences page keeps up to the accessibility and quality 
standards.
Can get a stability test with some twisted starmath code I haven't thought of.
I can't think of any automated test, but it may be possible.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice



--
Dr. Heiko Tietze, UX-Designer and UX-Mentor
Tel: +49 30 5557992-63 | Mail: heiko.tie...@documentfoundation.org
The Document Foundation, Kurfürstendamm 188, 10707 Berlin, DE
Gemeinnützige rechtsfähige Stiftung des bürgerlichen Rechts
Legal details: https://www.documentfoundation.org/imprint



OpenPGP_signature
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 115805] Choices in step increment for numeric steppers

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115805

stragu  changed:

   What|Removed |Added

Summary|Choices in valuable boxes   |Choices in step increment
   |"incrément" |for numeric steppers

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112790] [META] Toolbar context menu bugs and enhancements

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112790
Bug 112790 depends on bug 122714, which changed state.

Bug 122714 Summary: Re-expanding the titlebar menu of a floating toolbar needs 
a second click
https://bugs.documentfoundation.org/show_bug.cgi?id=122714

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122714] Re-expanding the titlebar menu of a floating toolbar needs a second click

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122714

Maxim Monastirsky  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |momonas...@gmail.com
   |desktop.org |
 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87740] [META] Anchor and text wrapping bugs and enhancements

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=87740
Bug 87740 depends on bug 139696, which changed state.

Bug 139696 Summary: UI: Anchor drop down button not working properly in Tabbed 
mode (click doesn't expand like toolbar)
https://bugs.documentfoundation.org/show_bug.cgi?id=139696

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 139696] UI: Anchor drop down button not working properly in Tabbed mode (click doesn't expand like toolbar)

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139696

Maxim Monastirsky  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |momonas...@gmail.com
   |desktop.org |
 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135890] Chart Properties Dialog broken on some workflows

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135890

--- Comment #8 from Rafael Lima  ---
Created attachment 169269
  --> https://bugs.documentfoundation.org/attachment.cgi?id=169269=edit
Calc Chart Test

This bug is still present in LO 7.2 alpha.

I carried out a few tests and I think it may be related to the context in which
the sidebar is opened. I prepared a file for testing (see the attached Calc
Chart Test). In these tests I am using the KF5 VCL.

SCENARIO 1
1) Open the file
2) Open the Properties sidebar
3) Double-click the chart
4) Everything is fine! You can use the sidebar for editing the chart.

SCENARIO 2
1) Open the file
2) Close the sidebar
3) Double-click the chart
4) Open the properties sidebar
5) On the KF5 backend the sidebar opens, but if I click anywhere in the
sidebar, it exits the chart editing mode, as though there were nothing in the
sidebar

I do not have a good knowledge of the underlying code base here. But I think it
has something to do with the context of the sidebar, because it doesn't seem to
capture mouse events in Scenario 2.

Hope this helps figure out how to fix this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: helpcontent2

2021-01-29 Thread Seth Chaiklin (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d9af8971cd2192ae53cab0b00d9b76feebf6524d
Author: Seth Chaiklin 
AuthorDate: Fri Jan 29 13:39:13 2021 +0100
Commit: Gerrit Code Review 
CommitDate: Fri Jan 29 13:39:13 2021 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to f05a74cdb79ebe1da4e58a1df147488d536c8d1e
  - Related to tdf#75923: update command "Add to AutoCorrect" in Spelling

  * tdf#75923 changed "Always Correct" control to "Add to AutoCorrect"
  updated this label change, and clarified the operation of
  the button
  + add "Check grammar" control, and adjust explanation
  + add "Ignore Rule" control and explanation.
(and no changes to "hidden" paragraph on Ignore Rule)
  * re-arrange presentation of controls to correspond to order
  of dialog box
  + add  about how to make New Dictionaries
 Thanks to Peter CM/MartinPC!
  + add links in Related topics to "AutoCorrect" and "Spelling Options"
  * update to ,

Change-Id: I352d36f09aa7858481da0cc035b84b99b7311622
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109810
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin 

diff --git a/helpcontent2 b/helpcontent2
index 3afce37d8a47..f05a74cdb79e 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 3afce37d8a47b2b95a8228492b223b462b5e6502
+Subproject commit f05a74cdb79ebe1da4e58a1df147488d536c8d1e
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] help.git: source/text

2021-01-29 Thread Seth Chaiklin (via logerrit)
 source/text/shared/01/0601.xhp |   67 +++--
 1 file changed, 35 insertions(+), 32 deletions(-)

New commits:
commit f05a74cdb79ebe1da4e58a1df147488d536c8d1e
Author: Seth Chaiklin 
AuthorDate: Mon Jan 25 09:58:43 2021 +0100
Commit: Seth Chaiklin 
CommitDate: Fri Jan 29 13:39:13 2021 +0100

Related to tdf#75923: update command "Add to AutoCorrect" in Spelling

  * tdf#75923 changed "Always Correct" control to "Add to AutoCorrect"
  updated this label change, and clarified the operation of
  the button
  + add "Check grammar" control, and adjust explanation
  + add "Ignore Rule" control and explanation.
(and no changes to "hidden" paragraph on Ignore Rule)
  * re-arrange presentation of controls to correspond to order
  of dialog box
  + add  about how to make New Dictionaries
 Thanks to Peter CM/MartinPC!
  + add links in Related topics to "AutoCorrect" and "Spelling Options"
  * update to ,

Change-Id: I352d36f09aa7858481da0cc035b84b99b7311622
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109810
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin 

diff --git a/source/text/shared/01/0601.xhp 
b/source/text/shared/01/0601.xhp
index 9f7c0c72e..b3656b618 100644
--- a/source/text/shared/01/0601.xhp
+++ b/source/text/shared/01/0601.xhp
@@ -1,6 +1,5 @@
 
 
-
 
 
-
 
   
  Spelling
@@ -46,53 +44,58 @@
   
  
   
-  
   The 
spellcheck starts at the current cursor position and advances to the end of the 
document or selection. You can then choose to continue the spellcheck from the 
beginning of the document.
   Spelling 
looks for misspelled words and gives you the option of adding an unknown word 
to a user dictionary. When the first misspelled word is found, the 
Spelling dialog opens.
-  Spelling errors are underlined in red, grammar errors in blue. 
First the dialog presents all spelling errors, then all grammar 
errors.
-
-Enable Check grammar to work first 
on all spelling errors, then on all grammar errors.
-
-Not in 
dictionary
-  Displays the sentence with the misspelled word highlighted. Edit the 
word or the sentence, or click one of the suggestions in the text box 
below.
-
-Suggestions
-  Lists suggested words to replace the 
misspelled word. Select the word that you want to use, and then click 
Correct or Correct All.
+  Spelling errors are underlined in red, grammar errors in blue. 

+
 
-Text 
Language
+Text Language
   Specifies the language to use to check 
the spelling.
   
-
-AutoCorrect
-
-  Adds the current combination of the 
incorrect word and the replacement word to the AutoCorrect replacements 
table.
-
-
-Options
-  Opens a dialog, where you can select the 
user-defined dictionaries, and set the rules for the 
spellchecking.
-
-Add to 
Dictionary
-  Adds the unknown word to a user-defined 
dictionary.
+
+Not in Dictionary
+  Displays the sentence with the misspelled word highlighted. Edit the 
word or the sentence, or click one of the suggestions in the text box 
below.
 
-Ignore 
Once
+Ignore Once
   Skips the unknown word and continues with 
the spellcheck.
-  This label of 
this button changes to Resume if you leave the Spelling dialog 
open when you return to your document. To continue the spellcheck from the 
current position of the cursor, click Resume.
-
-While performing a grammar 
check, click Ignore Rule to ignore the rule that is currently flagged as a 
grammar error.
+  This label of this button 
changes to Resume if you leave the Spelling dialog open when you 
return to your document. To continue the spellcheck from the current position 
of the cursor, click Resume.
 
-Ignore 
All
+Ignore All
   Skips all occurrences of the unknown word 
until the end of the current %PRODUCTNAME session and continues with the 
spellcheck.
+
+While performing a grammar 
check, click Ignore Rule to ignore the rule that is currently flagged as a 
grammar error.
+Ignore Rule
+  Appears when 
checking grammar. Click to ignore the suggested grammatical change.
+
+Add to Dictionary
+  Adds the unknown word to a user-defined 
dictionary.
+
+  To add a new dictionary, press 
Options, then press New. After %PRODUCTNAME is 
restarted, multiple user-defined dictionaries are shown when Add to 
Dictionary is pressed. Select which dictionary should receive the added 
word.
+Suggestions
+  Lists suggested words to replace the 
misspelled word. Select the word that you want to use, and then click 
Correct or Correct All.
 
-Correct
+Correct
   Replaces the unknown word with the current 
suggestion. If you changed more than just the misspelled word, the entire 
sentence is replaced.
 
-Correct 
All
+Correct All
   Replaces all occurrences of the unknown 
word with the current suggestion.
+
+Add to AutoCorrect
+  Adds the current 

[Libreoffice-bugs] [Bug 122715] FILEOPEN XLSB format is inconsistent with Excel with incorrect cell references and hiding

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122715

--- Comment #6 from Roman Kuznetsov <79045_79...@mail.ru> ---
still repro in

Version: 7.2.0.0.alpha0+ (x64)
Build ID: 94f6765d6ecc3145fa2d266231124003cf953118
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - filter/qa sfx2/source

2021-01-29 Thread Mike Kaganski (via logerrit)
 filter/qa/unit/textfilterdetect.cxx |   20 
 sfx2/source/doc/objstor.cxx |6 --
 2 files changed, 24 insertions(+), 2 deletions(-)

New commits:
commit e3307e5e76d5c35ee79b262d519c4a777acce536
Author: Mike Kaganski 
AuthorDate: Wed Jan 27 16:05:54 2021 +0100
Commit: Michael Stahl 
CommitDate: Fri Jan 29 13:28:51 2021 +0100

tdf#123476 filter: Also handle empty ODF

This builds on top of commit ada07f303e7cd1e39c73abe0741aefe7d9d73a57,
to allow 0-byte ODT, ODS etc.

Possible TODO would be somehow use default template for such empty files,
getting the template name using SfxObjectFactory::GetStandardTemplate.
That would enable using 0-byte ODF files as means to "create new document
at this location from default template" workflow.

Change-Id: I36e07b80f60c42aecdcc6a7357e5bdd18f62e4f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109989
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 
(cherry picked from commit 2854362f429e476d4a1ab4759c6a1f1c04150280)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110060
Reviewed-by: Michael Stahl 

diff --git a/filter/qa/unit/data/empty.odp b/filter/qa/unit/data/empty.odp
new file mode 100644
index ..e69de29bb2d1
diff --git a/filter/qa/unit/data/empty.odt b/filter/qa/unit/data/empty.odt
new file mode 100644
index ..e69de29bb2d1
diff --git a/filter/qa/unit/textfilterdetect.cxx 
b/filter/qa/unit/textfilterdetect.cxx
index fb1ff1d2ac7e..56dccf8914b9 100644
--- a/filter/qa/unit/textfilterdetect.cxx
+++ b/filter/qa/unit/textfilterdetect.cxx
@@ -91,6 +91,26 @@ CPPUNIT_TEST_FIXTURE(TextFilterDetectTest, testEmptyFile)
 // Without the accompanying fix in place, this test would have failed, as 
it was opened in
 // Writer instead.
 
CPPUNIT_ASSERT(xServiceInfo->supportsService("com.sun.star.presentation.PresentationDocument"));
+
+getComponent()->dispose();
+
+// Now also test ODT
+aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) + "empty.odt";
+getComponent() = loadFromDesktop(aURL);
+xServiceInfo.set(getComponent(), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xServiceInfo.is());
+// Make sure it opens in Writer.
+
CPPUNIT_ASSERT(xServiceInfo->supportsService("com.sun.star.text.TextDocument"));
+getComponent()->dispose();
+
+// ... and ODP
+aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) + "empty.odp";
+getComponent() = loadFromDesktop(aURL);
+xServiceInfo.set(getComponent(), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xServiceInfo.is());
+// Without the accompanying fix in place, this test would have failed, as 
it was opened in
+// Writer instead.
+
CPPUNIT_ASSERT(xServiceInfo->supportsService("com.sun.star.presentation.PresentationDocument"));
 }
 }
 
diff --git a/sfx2/source/doc/objstor.cxx b/sfx2/source/doc/objstor.cxx
index d5803e1b0029..4188ec2a7ef2 100644
--- a/sfx2/source/doc/objstor.cxx
+++ b/sfx2/source/doc/objstor.cxx
@@ -424,7 +424,7 @@ bool SfxObjectShell::InitNew( const uno::Reference< 
embed::XStorage >& xStorage
 
 bool SfxObjectShell::Load( SfxMedium& rMedium )
 {
-return GeneralInit_Impl( rMedium.GetStorage(), true );
+return GeneralInit_Impl(rMedium.GetStorage(), 
!tools::isEmptyFileUrl(rMedium.GetName()));
 }
 
 void SfxObjectShell::DoInitUnitTest()
@@ -660,7 +660,9 @@ bool SfxObjectShell::DoLoad( SfxMedium *pMed )
 bWarnMediaTypeFallback = false;
 }
 
-if ( bWarnMediaTypeFallback || 
!xStorage->getElementNames().hasElements() )
+if (bWarnMediaTypeFallback
+|| (!tools::isEmptyFileUrl(pMedium->GetName())
+&& !xStorage->getElementNames().hasElements()))
 SetError(ERRCODE_IO_BROKENPACKAGE);
 }
 catch( uno::Exception& )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: [libreoffice-documentation] Starmath syntax hightlight

2021-01-29 Thread Rafael Lima
Hi Dante!

Thank you for the initiative! Syntax highlighting is something I have
always wished to see in StarMath. I am myself a frequent user of StarMath,
so I can tell that this will be a great addition to the application.

The current Formula Editor does not provide a good experience, especially
when the formula gets very long. Also, it becomes hard to spot syntax
mistakes if there's no highlighting.

I'll pull and build your patch later today to see how it performs. Then
I'll try to provide some feedback from the user perspective. However, my
experience with the LibreOffice codebase is limited, so I can't help with
automated tests.

Regards,
Rafael Lima


On Fri, Jan 29, 2021 at 8:58 AM Dante Doménech 
wrote:

>  The starmath syntax highlight first revision is now available here:
> https://gerrit.libreoffice.org/c/core/+/109639/21
>
> I write asking for a deep review since it's a patch that may change the
> user experience.
> I'd like the UX team to take a look and evaluate the code legibility.
> Note that bright colors have been avoided.
> Maybe some documentation should be added.
> Get sure the preferences page keeps up to the accessibility and quality
> standards.
> Can get a stability test with some twisted starmath code I haven't thought
> of.
> I can't think of any automated test, but it may be possible.
>
> --
> To unsubscribe e-mail to: documentation+unsubscr...@global.libreoffice.org
> Problems?
> https://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
> Posting guidelines + more: https://wiki.documentfoundation.org/Netiquette
> List archive: https://listarchives.libreoffice.org/global/documentation/
> Privacy Policy: https://www.documentfoundation.org/privacy
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: helpcontent2

2021-01-29 Thread Rafael Lima (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 725af1985f8fd92c27d8ea224b171c12316bad22
Author: Rafael Lima 
AuthorDate: Fri Jan 29 13:02:23 2021 +0100
Commit: Gerrit Code Review 
CommitDate: Fri Jan 29 13:02:23 2021 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 3afce37d8a47b2b95a8228492b223b462b5e6502
  - Create SF_Calc help page (ScriptForge)

Also fixes localization issues in previously created pages 
adding/removing localize="false" tags.

Change-Id: I71c8dad854be5cacfd4c701850fe539630689d45
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109882
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 9104dcbfe3c4..3afce37d8a47 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 9104dcbfe3c4d7a845520ad62d34efa0d3356abe
+Subproject commit 3afce37d8a47b2b95a8228492b223b462b5e6502
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] help.git: AllLangHelp_sbasic.mk source/text

2021-01-29 Thread Rafael Lima (via logerrit)
 AllLangHelp_sbasic.mk|1 
 source/text/sbasic/shared/03/lib_ScriptForge.xhp |1 
 source/text/sbasic/shared/03/sf_calc.xhp | 1083 +++
 source/text/sbasic/shared/03/sf_document.xhp |   49 -
 source/text/sbasic/shared/03/sf_exception.xhp|   48 -
 source/text/sbasic/shared/03/sf_ui.xhp   |  128 +-
 6 files changed, 1197 insertions(+), 113 deletions(-)

New commits:
commit 3afce37d8a47b2b95a8228492b223b462b5e6502
Author: Rafael Lima 
AuthorDate: Tue Jan 26 00:59:42 2021 +0100
Commit: Olivier Hallot 
CommitDate: Fri Jan 29 13:02:23 2021 +0100

Create SF_Calc help page (ScriptForge)

Also fixes localization issues in previously created pages adding/removing 
localize="false" tags.

Change-Id: I71c8dad854be5cacfd4c701850fe539630689d45
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109882
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/AllLangHelp_sbasic.mk b/AllLangHelp_sbasic.mk
index 83ff3bad2..57cfed0d9 100644
--- a/AllLangHelp_sbasic.mk
+++ b/AllLangHelp_sbasic.mk
@@ -78,6 +78,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,sbasic,\
 helpcontent2/source/text/sbasic/shared/03/lib_script \
 helpcontent2/source/text/sbasic/shared/03/lib_ScriptForge \
 helpcontent2/source/text/sbasic/shared/03/sf_array \
+helpcontent2/source/text/sbasic/shared/03/sf_calc \
 helpcontent2/source/text/sbasic/shared/03/sf_dictionary \
 helpcontent2/source/text/sbasic/shared/03/sf_exception \
 helpcontent2/source/text/sbasic/shared/03/sf_ui \
diff --git a/source/text/sbasic/shared/03/lib_ScriptForge.xhp 
b/source/text/sbasic/shared/03/lib_ScriptForge.xhp
index 2185a1364..2813a026d 100644
--- a/source/text/sbasic/shared/03/lib_ScriptForge.xhp
+++ b/source/text/sbasic/shared/03/lib_ScriptForge.xhp
@@ -34,6 +34,7 @@
 ScriptForge Basic 
library is available from %PRODUCTNAME 7.1 onwards.
 
 
+
 
 
 
diff --git a/source/text/sbasic/shared/03/sf_calc.xhp 
b/source/text/sbasic/shared/03/sf_calc.xhp
new file mode 100644
index 0..f988184f8
--- /dev/null
+++ b/source/text/sbasic/shared/03/sf_calc.xhp
@@ -0,0 +1,1083 @@
+
+
+
+
+
+  
+SFDocuments.Calc service
+/text/sbasic/shared/03/sf_calc.xhp
+  
+
+
+
+
+
+  Calc service
+   
+
+
+
+SFDocuments.Calc 
service
+The SFDocuments library provides a number 
of methods and properties to facilitate the management and handling of 
LibreOffice Calc documents.
+Some methods are generic for all types of documents and are 
inherited from the SF_Document service, whereas other 
methods are specific for the SF_Calc module.
+The SF_Calc module is focused 
on:
+
+
+Handling sheets within a Calc document (copy, insert, move, 
etc)
+
+
+Exchanging data between Basic data structures and Calc 
ranges
+
+
+Copying and importing massive amounts of data
+
+
+
+
+  Service invocation
+  Before using the 
Calc service the ScriptForge library 
needs to be loaded using:
+  
+GlobalScope.BasicLibraries.LoadLibrary("ScriptForge")
+  
+  The 
Calc service is closely related to the UI 
service of the ScriptForge library. Below are a few examples 
of how the Calc service can be invoked.
+  
+'1) From the 
ScriptForge.UI service:
+Dim 
ui As Object, oDoc As Object
+Set 
ui = CreateScriptService("UI")
+Set 
oDoc = ui.CreateDocument("Calc")
+'Or: Set oDoc = 
ui.OpenDocument("C:\Me\MyFile.ods")
+  
+  
+'2) Directly if the 
document is already open
+Dim 
oDoc As Object
+Set 
oDoc = CreateScriptService("SFDocuments.Calc", "Untitled 1") 'Default = 
ActiveWindow
+  
+  It is 
recommended to free resources after use:
+  
+Set 
oDoc = oDoc.Dispose()
+  
+  However, if the 
document was closed using the CloseDocument method, it 
becomes unnecessary to free resources using the command described 
above.
+  The use of the prefix 
"SFDocuments." while calling the service is optional.
+
+  Definitions
+Many methods require a "Sheet" or a 
"Range" as argument. Single cells are considered a special case of 
a Range).
+Both may be expressed either as a string or as a reference (= 
object) depending on the situation:
+
+
+Within a specific Calc 
instance, sheets and ranges are given as strings such as "Sheet1" 
and "D2:F6".
+
+
+Additionally, the .Sheet and 
.Range properties return a reference that may be used as 
argument of a method called from another instance of the 
Calc service.
+
+
+  
+The example below copies data from document A (opened as 
read-only and hidden) to document B.
+
+Dim 
oDocA As Object, oDocB As Object
+Set 
oDocA = ui.OpenDocument("C:\FileA.ods", Hidden := True, ReadOnly := 
True)
+Set 
oDocB = ui.OpenDocument("C:\FileB.ods")
+

[Libreoffice-commits] core.git: include/unotools unotools/source

2021-01-29 Thread Mike Kaganski (via logerrit)
 include/unotools/moduleoptions.hxx   |3 ---
 unotools/source/config/moduleoptions.cxx |   23 ++-
 2 files changed, 6 insertions(+), 20 deletions(-)

New commits:
commit 497452595bccf939e1a7e6b54b964e34504e5075
Author: Mike Kaganski 
AuthorDate: Fri Jan 29 07:11:38 2021 +0100
Commit: Mike Kaganski 
CommitDate: Fri Jan 29 12:55:08 2021 +0100

Replace rtl::Static with function-local static here

Change-Id: Iaba5c16c9f80431a5a9c03b94087e3f0b14fd9d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110132
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/include/unotools/moduleoptions.hxx 
b/include/unotools/moduleoptions.hxx
index 3293560c3733..1324e4d06e18 100644
--- a/include/unotools/moduleoptions.hxx
+++ b/include/unotools/moduleoptions.hxx
@@ -27,7 +27,6 @@
 #include 
 #include 
 
-namespace osl { class Mutex; }
 namespace com::sun::star::frame { class XModel; }
 namespace com::sun::star::beans { struct PropertyValue; }
 
@@ -168,8 +167,6 @@ class SAL_WARN_UNUSED UNOTOOLS_DLLPUBLIC SvtModuleOptions 
final : public utl::de
 css::uno::Sequence < OUString > GetAllServiceNames();
 
 private:
-UNOTOOLS_DLLPRIVATE static ::osl::Mutex& impl_GetOwnStaticMutex();
-
 std::shared_ptr   m_pImpl;
 
 };  // class SvtModuleOptions
diff --git a/unotools/source/config/moduleoptions.cxx 
b/unotools/source/config/moduleoptions.cxx
index 1468501220ec..ea3db01585c2 100644
--- a/unotools/source/config/moduleoptions.cxx
+++ b/unotools/source/config/moduleoptions.cxx
@@ -761,6 +761,12 @@ void SvtModuleOptions_Impl::MakeReadonlyStatesAvailable()
 namespace {
 //global
 std::weak_ptr g_pModuleOptions;
+
+osl::Mutex& impl_GetOwnStaticMutex()
+{
+static osl::Mutex s_Mutex;
+return s_Mutex;
+}
 }
 
 
/*-
@@ -907,23 +913,6 @@ bool SvtModuleOptions::IsDataBase() const
 return m_pImpl->IsModuleInstalled( EModule::DATABASE );
 }
 
-namespace
-{
-class theModuleOptionsMutex : public rtl::Static {};
-}
-/*-
-@short  return a reference to a static mutex
-@descr  These class is threadsafe.
-We create a static mutex only for one time and use it to 
protect our refcount and container
-member!
-@return A reference to a static mutex member.
-@threadsafe yes
-*//*-*/
-::osl::Mutex& SvtModuleOptions::impl_GetOwnStaticMutex()
-{
-return theModuleOptionsMutex::get();
-}
-
 OUString SvtModuleOptions::GetModuleName( EModule eModule ) const
 {
 switch( eModule )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 139997] New: Video playback in Impress disappears with Skia

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139997

Bug ID: 139997
   Summary: Video playback in Impress disappears with Skia
   Product: LibreOffice
   Version: 7.1.0.2 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisectRequest, regression
  Severity: normal
  Priority: medium
 Component: graphics stack
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: libreoff...@nisz.hu
Blocks: 129062

Created attachment 169266
  --> https://bugs.documentfoundation.org/attachment.cgi?id=169266=edit
Screenshot of the problem in Impress

When playing a video in Impress, the playback goes back to the placeholder
image while sound is continuously played. 
This only happens with Skia backend, not with GDI.

Steps to reproduce:
1. Open attachment 169242 (it contains an mpg video in a pptx file, but
also happens if I convert this to odp)
2. Open the Properties sidebar, select the video on the slide
3. Start playing the video, then move the cursor above the slide and click
on it OR out of the Impress window.

Actual results:
The video being played is replaced with the placeholder image.
Sound is continous.

Expected results:
Video played back normally.

LibreOffice details:

Version: 7.1.0.2 (x64) / LibreOffice Community
Build ID: 53d68d29d90fd16448721a60aad68c28ff0809f5
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: CL

Version: 7.1.0.2 (x64) / LibreOffice Community
Build ID: 53d68d29d90fd16448721a60aad68c28ff0809f5
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: CL

But not yet with:
Version: 7.0.0.3 (x64)
Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e
CPU szálak: 4; OS: Windows 6.3 Build 9600; Felületmegjelenítés: Skia/Raster;
VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: CL

Additional Information: 
I can only reproduce this with SI-GUI release builds, but not in bibisect
repos.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129062
[Bug 129062] [META] Skia library bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 128821] FILEOPEN PPTX Animations defined on master slide are not imported

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128821

NISZ LibreOffice Team  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||9997

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129062] [META] Skia library bugs

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129062

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Depends on||139997


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=139997
[Bug 139997] Video playback in Impress disappears with Skia
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Starmath syntax hightlight

2021-01-29 Thread Dante Doménech
 The starmath syntax highlight first revision is now available here:
https://gerrit.libreoffice.org/c/core/+/109639/21

I write asking for a deep review since it's a patch that may change the
user experience.
I'd like the UX team to take a look and evaluate the code legibility.
Note that bright colors have been avoided.
Maybe some documentation should be added.
Get sure the preferences page keeps up to the accessibility and quality
standards.
Can get a stability test with some twisted starmath code I haven't thought
of.
I can't think of any automated test, but it may be possible.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re:

2021-01-29 Thread Dante Doménech
Awesome, thanks!

El vie, 29 ene 2021 a las 11:57, Caolán McNamara ()
escribió:

> On Fri, 2021-01-29 at 10:47 +0100, Dante Doménech wrote:
> > Got it, a lot of thanks! It was the last piece of the puzzle. Now I
> > get this:
> > Does 0 new warnings mean everything is OK?
>
> yeah, you should be good now
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 89841] [Calc] Autofilter - weak indication that autofilter was set

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89841

Tünde Tóth  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |tund...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 89841] [Calc] Autofilter - weak indication that autofilter was set

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89841

Tünde Tóth  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |tund...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 139996] CRASH: using CTRL + SHIFT + Up in the slidesorter when no slide is selected

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139996

Xisco Faulí  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||xiscofa...@libreoffice.org
 Status|UNCONFIRMED |ASSIGNED
   Assignee|libreoffice-b...@lists.free |xiscofa...@libreoffice.org
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 139996] New: CRASH: using CTRL + SHIFT + Up in the slidesorter when no slide is selected

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139996

Bug ID: 139996
   Summary: CRASH: using CTRL + SHIFT + Up in the slidesorter when
no slide is selected
   Product: LibreOffice
   Version: 7.2.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Steps to reproduce:
1. Open Impress
2. Click on the slidesorter
3. Use CTRL + SHIFT + UP

-> Crash

Reproduced in

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: f2389a70da606768a39ee599de6a5b24058734aa
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: zh-TW (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 139995] Conditional filters list is missing Cell value “is empty” and “is not empty” options

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139995

--- Comment #1 from NISZ LibreOffice Team  ---
Created attachment 169265
  --> https://bugs.documentfoundation.org/attachment.cgi?id=169265=edit
Screenshot of the original document side by side in Excel and Calc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 139995] New: Conditional filters list is missing Cell value “is empty” and “is not empty” options

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139995

Bug ID: 139995
   Summary: Conditional filters list is missing Cell value “is
empty” and “is not empty” options
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: libreoff...@nisz.hu
CC: nagy.tib...@nisz.hu, nem...@numbertext.org
Blocks: 87351

Created attachment 169264
  --> https://bugs.documentfoundation.org/attachment.cgi?id=169264=edit
Example file from Excel with conditions “empty” and “not empty”

In Excel it is possible to conditionally format cells that are empty or not
empty. Attached file demonstrates that.
Calc however does not offer this option on the Conditional Formatting dialog in
the “Cell value” condition list.
So this is a feature request to extend the list of supported conditions.

Steps to reproduce:
1. Open attached file in Calc
2. Go to Format – Conditional – Manage.

Actual results:
The list displays two “Formula is” type conditional formatting.

Expected results:
The conditions list should have “Cell value” entries of “is empty” and “is not
empty” so that these conditions in XLSX files can be mapped properly.
These may be useful on their own too :).
It might be necessary to extend ODF as well to accommodate for these.

LibreOffice details:
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 7eb289c49cc7245ef3001a39be0c15d06bbe875b
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=87351
[Bug 87351] [META] Conditional formatting bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87351] [META] Conditional formatting bugs and enhancements

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=87351

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Depends on||139995


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=139995
[Bug 139995] Conditional filters list is missing Cell value “is empty” and “is
not empty” options
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105605

steve  changed:

   What|Removed |Added

 Depends on||115538


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115538
[Bug 115538] GnuPG / OpenPGP keys not found on macOS unless from command line
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115538] GnuPG / OpenPGP keys not found on macOS unless from command line

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115538

steve  changed:

   What|Removed |Added

 Blocks||105605


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105605
[Bug 105605] [META] Digital signatures bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115538] GnuPG / OpenPGP keys not found on macOS unless from command line

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115538

steve  changed:

   What|Removed |Added

 Blocks||113278
   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=11 |
   |3278|


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113278
[Bug 113278] Digitally signing PDF files with OpenPGP ang GPG keys does not
work
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113278] Digitally signing PDF files with OpenPGP ang GPG keys does not work

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113278

steve  changed:

   What|Removed |Added

 Depends on||115538
   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=11 |
   |5538|


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115538
[Bug 115538] GnuPG / OpenPGP keys not found on macOS unless from command line
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115538] GnuPG / OpenPGP keys not found on macOS unless from command line

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115538

steve  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||3278

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113278] Digitally signing PDF files with OpenPGP ang GPG keys does not work

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113278

steve  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5538

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 139974] Data Corruption with more than 16368 characters

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139974

--- Comment #2 from rema...@gmx.de ---
This bug happens for me under Fedora 33.

As an example you can create following formula:

=1234567890+1234567890+1234567890+1234567890+ [...]

until you have more than 16368 characters.

You can create this inside a Calc-cell by copy pasting those numbers or outside
and then paste it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113278] Digitally signing PDF files with OpenPGP ang GPG keys does not work

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113278

--- Comment #11 from steve  ---
Created attachment 169263
  --> https://bugs.documentfoundation.org/attachment.cgi?id=169263=edit
2021-01-29 LO7.1.0.2 signing UI, but no OpenPGP keys shown

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113278] Digitally signing PDF files with OpenPGP ang GPG keys does not work

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113278

--- Comment #10 from steve  ---
What is the status here? There is a commit but as there are no clear steps to
reproduce not sure what to test.

Reproduce steps:

1. open LO writer
2. type "test" and export PDF via File > Export as > Export as PDF
3. open Digital Signatures tab

Currently
No keys shown despite having OpenPGP keys on my system.

Expected
Show secret keys to sign PDF about to be exported.

Probably what I am seeing is
https://bugs.documentfoundation.org/show_bug.cgi?id=115538 so someone else will
have to retest this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 139956] FORMATTING : Grid lines are not visible on a different background colour

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139956

--- Comment #8 from Steve  ---
Perfect!

Thank you very much

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 139956] FORMATTING : Grid lines are not visible on a different background colour

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139956

--- Comment #8 from Steve  ---
Perfect!

Thank you very much

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


Re:

2021-01-29 Thread Caolán McNamara
On Fri, 2021-01-29 at 10:47 +0100, Dante Doménech wrote:
> Got it, a lot of thanks! It was the last piece of the puzzle. Now I
> get this:
> Does 0 new warnings mean everything is OK?

yeah, you should be good now

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 139981] LO 7.1.1.0.0+ does not start (GTK3)

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139981

--- Comment #3 from Xisco Faulí  ---
Reverting in https://gerrit.libreoffice.org/c/core/+/110134

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 139981] LO 7.1.1.0.0+ does not start (GTK3)

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139981

Xisco Faulí  changed:

   What|Removed |Added

   Severity|major   |critical
   Priority|high|highest

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 139981] LO 7.1.1.0.0+ does not start (GTK3)

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139981

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected
 Ever confirmed|0   |1
Summary|LO 7.1.1.0.0+ does not  |LO 7.1.1.0.0+ does not
   |start   |start (GTK3)
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 139994] New: the mouse pointer makes blur the document

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139994

Bug ID: 139994
   Summary: the mouse pointer makes blur the document
   Product: LibreOffice
   Version: 7.1.0.2 rc
  Hardware: All
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sandro...@libero.it

Description:
When I try to work on the sheet, the mouse pointer creates a blur effect (seems
like a maximum zoom) that doesn't allow to modify the document.

Steps to Reproduce:
1.open LIbreoffive
2.open an odt file
3.when the mouse pointer moves, the document blurs

Actual Results:
Impossible to work on sheets

Expected Results:
work normally


Reproducible: Always


User Profile Reset: No



Additional Info:
Help - About LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 139956] FORMATTING : Grid lines are not visible on a different background colour

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139956

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED

--- Comment #7 from Heiko Tietze  ---
There is an options for everything ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 139956] FORMATTING : Grid lines are not visible on a different background colour

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139956

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED

--- Comment #7 from Heiko Tietze  ---
There is an options for everything ;-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 139956] FORMATTING : Grid lines are not visible on a different background colour

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139956

--- Comment #6 from Maxim Monastirsky  ---
There is a setting for it: Tools > Options... > LibreOffice Calc > View > Grid
Lines. This can be changed to "Show on colored cells".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 139956] FORMATTING : Grid lines are not visible on a different background colour

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139956

--- Comment #6 from Maxim Monastirsky  ---
There is a setting for it: Tools > Options... > LibreOffice Calc > View > Grid
Lines. This can be changed to "Show on colored cells".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sw/qa sw/source

2021-01-29 Thread Miklos Vajna (via logerrit)
 sw/qa/extras/tiledrendering/tiledrendering.cxx |   57 +
 sw/source/core/txtnode/ndtxt.cxx   |   50 +
 2 files changed, 98 insertions(+), 9 deletions(-)

New commits:
commit a01b54995d3d7c73ab28bdb412d4d5bcdf9c887f
Author: Miklos Vajna 
AuthorDate: Thu Jan 28 17:28:54 2021 +0100
Commit: Miklos Vajna 
CommitDate: Fri Jan 29 11:14:05 2021 +0100

sw: don't repaint all text frames on text node delete for bullet numberings

The intention of the InvalidateNumRule() call is probably to make sure
that generated number portions in e.g. Arabic numbering are up to date.
But this is not necessary for bullets and causes not needed
invalidations.

(cherry picked from commit 6de46444027d03b617d02b66434f626c5723501f)

Conflicts:
sw/qa/extras/tiledrendering/tiledrendering.cxx

Change-Id: Iad555727e5e2b069bbffae0e7650fb8c75a56770
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110124
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx 
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index d5d638e9b4ca..47c54f84e96d 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -50,6 +50,7 @@
 #include 
 #include 
 #include 
+#include 
 
 static char const DATA_DIRECTORY[] = "/sw/qa/extras/tiledrendering/data/";
 
@@ -134,6 +135,7 @@ public:
 void testSpellOnlineRenderParameter();
 void testTablePaintInvalidate();
 void testExtTextInputReadOnly();
+void testBulletDeleteInvalidation();
 
 CPPUNIT_TEST_SUITE(SwTiledRenderingTest);
 CPPUNIT_TEST(testRegisterCallback);
@@ -205,13 +207,17 @@ public:
 CPPUNIT_TEST(testSpellOnlineRenderParameter);
 CPPUNIT_TEST(testTablePaintInvalidate);
 CPPUNIT_TEST(testExtTextInputReadOnly);
+CPPUNIT_TEST(testBulletDeleteInvalidation);
 CPPUNIT_TEST_SUITE_END();
 
 private:
 SwXTextDocument* createDoc(const char* pName = nullptr);
 static void callback(int nType, const char* pPayload, void* pData);
 void callbackImpl(int nType, const char* pPayload);
+// First invalidation.
 tools::Rectangle m_aInvalidation;
+/// Union of all invalidations.
+tools::Rectangle m_aInvalidations;
 Size m_aDocumentSize;
 OString m_aTextSelection;
 bool m_bFound;
@@ -285,17 +291,20 @@ void SwTiledRenderingTest::callbackImpl(int nType, const 
char* pPayload)
 {
 case LOK_CALLBACK_INVALIDATE_TILES:
 {
+tools::Rectangle aInvalidation;
+uno::Sequence aSeq = 
comphelper::string::convertCommaSeparated(OUString::createFromAscii(pPayload));
+if (OString("EMPTY") == pPayload)
+return;
+CPPUNIT_ASSERT(aSeq.getLength() == 4 || aSeq.getLength() == 5);
+aInvalidation.setX(aSeq[0].toInt32());
+aInvalidation.setY(aSeq[1].toInt32());
+aInvalidation.setWidth(aSeq[2].toInt32());
+aInvalidation.setHeight(aSeq[3].toInt32());
 if (m_aInvalidation.IsEmpty())
 {
-uno::Sequence aSeq = 
comphelper::string::convertCommaSeparated(OUString::createFromAscii(pPayload));
-if (OString("EMPTY") == pPayload)
-return;
-CPPUNIT_ASSERT(aSeq.getLength() == 4 || aSeq.getLength() == 5);
-m_aInvalidation.setX(aSeq[0].toInt32());
-m_aInvalidation.setY(aSeq[1].toInt32());
-m_aInvalidation.setWidth(aSeq[2].toInt32());
-m_aInvalidation.setHeight(aSeq[3].toInt32());
+m_aInvalidation = aInvalidation;
 }
+m_aInvalidations.Union(aInvalidation);
 ++m_nInvalidations;
 }
 break;
@@ -2826,6 +2835,38 @@ void SwTiledRenderingTest::testExtTextInputReadOnly()
 CPPUNIT_ASSERT(getParagraph(1)->getString().isEmpty());
 }
 
+void SwTiledRenderingTest::testBulletDeleteInvalidation()
+{
+// Given a document with 3 paragraphs: first 2 is bulleted, the last is 
not.
+SwXTextDocument* pXTextDocument = createDoc();
+SwWrtShell* pWrtShell = pXTextDocument->GetDocShell()->GetWrtShell();
+pWrtShell->SplitNode();
+pWrtShell->Up(/*bSelect=*/false);
+pWrtShell->StartAllAction();
+pWrtShell->BulletOn();
+pWrtShell->EndAllAction();
+pWrtShell->Insert2("a");
+pWrtShell->SplitNode();
+pWrtShell->Insert2("b");
+pWrtShell->Down(/*bSelect=*/false);
+pWrtShell->GetLayout()->PaintSwFrame(*pWrtShell->GetOut(),
+ 
pWrtShell->GetLayout()->getFrameArea());
+Scheduler::ProcessEventsToIdle();
+
pWrtShell->GetSfxViewShell()->registerLibreOfficeKitViewCallback(::callback,
 this);
+m_aInvalidations = tools::Rectangle();
+
+// When pressing backspace in the last paragraph.
+pWrtShell->DelLeft();
+
+// Then the first paragraph should not be invalidated.
+SwRootFrame* pRoot = pWrtShell->GetLayout();

[Libreoffice-bugs] [Bug 139981] LO 7.1.1.0.0+ does not start

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139981

Heiko Tietze  changed:

   What|Removed |Added

   Priority|highest |high
   Severity|critical|major

--- Comment #2 from Heiko Tietze  ---
7.1.1 - it's not critical

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 139981] LO 7.1.1.0.0+ does not start

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139981

Heiko Tietze  changed:

   What|Removed |Added

   Priority|medium  |highest
 CC||caol...@redhat.com,
   ||cl...@documentfoundation.or
   ||g,
   ||xiscofa...@libreoffice.org
   Severity|normal  |critical

--- Comment #1 from Heiko Tietze  ---
Xisco, please have a look.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 139956] FORMATTING : Grid lines are not visible on a different background colour

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139956

Heiko Tietze  changed:

   What|Removed |Added

 CC||er...@redhat.com
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #5 from Heiko Tietze  ---
You may set-up a sheet to your liking (with border lines in a defined color),
save it as template, and make this the default in the template manager. If you
run Calc now it will always use this template.

Should we switch the appearance by default? Have to admit that these grid lines
are surprising- they not only disappear for cells with a background but are
also not shown on printouts/previews. Eike, what do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 139956] FORMATTING : Grid lines are not visible on a different background colour

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139956

Heiko Tietze  changed:

   What|Removed |Added

 CC||er...@redhat.com
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #5 from Heiko Tietze  ---
You may set-up a sheet to your liking (with border lines in a defined color),
save it as template, and make this the default in the template manager. If you
run Calc now it will always use this template.

Should we switch the appearance by default? Have to admit that these grid lines
are surprising- they not only disappear for cells with a background but are
also not shown on printouts/previews. Eike, what do you think?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 139993] New: Extreme lagging with SVG's containing gradients

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139993

Bug ID: 139993
   Summary: Extreme lagging with SVG's containing gradients
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gellert.gyu...@gmail.com

Created attachment 169262
  --> https://bugs.documentfoundation.org/attachment.cgi?id=169262=edit
Test files for lagging with SVG gradients

I experience lagging during typing text when there is an inserted SVG.

1) No problem with other formats: I tested EMF, EPS, JPG, PNG, WMF, ODG, not
event with PDF.

2) As I researched the cause of the bug I found that it occurs when there is
gradient in the SVG.

3) Affected versions:
- LibreOffice 6.4.7.2: There is no problem with real graphics, but with
prepared SVG I can cause the lagging.
- LibreOffice 7.0.3.1; 7.0.4.2, 7.1.0.2; 7.2.0.0α: All are affected with real
graphics and there is an extreme lagging with prepared SVGs.

Step to reproduce:
- Open a new document
- Insert > Insert image... chose one attached SVG file.
- Start typing some text after inserted image. The characters appear very
slowly with lagging and they usually appear at the same time with a small or
big delay depending on how many gradient there is in SVG.

Test files:
Real graphics:
- LibreOffice logo.svg: No noticeable lagging with 6.4, but the lagging is
experienced with 7.0+.
- Ghostscript_Tiger.svg: Same as above.
Prepared SVG's for testing this bug:
- svg_objects.svg (There is no gradient, only transparency): No problem.
- svg_many_objects.svg (Lot of object without gradients): No problem.
- svg_many_objects_with_gradient (Only a few gradients): Lagging in all
versions.
- svg_many_objects_with_gradient.svg (Lot of object with gradients): Extreme
lagging, especially in 7.0+


I tested on Linux (Ubuntu 20.10, XOrg).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 139781] Community/Enterprise flavor breaks the StartCenter

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139781

--- Comment #18 from Maxim Monastirsky  ---
*** Bug 139988 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 139988] Some icons are missing in template manager

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139988

Maxim Monastirsky  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #4 from Maxim Monastirsky  ---
(In reply to Rizal Muttaqin from comment #2)
> @Maxim, could this have something to do with Glade? Similar to what's happen
> with tdf#139781 (https://bugs.documentfoundation.org/show_bug.cgi?id=139781)?
Yes it is. Should be fixed with my commit, please try with a newer build. No
changes are required from your side.

*** This bug has been marked as a duplicate of bug 139781 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51330] FILEOPEN: Vertical Text in .pptx becomes horizontal when imported

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=51330

--- Comment #16 from NISZ LibreOffice Team  ---
Created attachment 169261
  --> https://bugs.documentfoundation.org/attachment.cgi?id=169261=edit
Screenshot of the original document side by side in PP and Impress

Still a problem in:

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 7eb289c49cc7245ef3001a39be0c15d06bbe875b
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 54052] Improvement - PDF export defaults in Options/General

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=54052

Heiko Tietze  changed:

   What|Removed |Added

 CC||samuel.mehrbrodt@allotropia
   ||.de, t...@libreoffice.org
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #7 from Heiko Tietze  ---
Having the PDF export options under tools > options makes sense if you set it
up for once and never again. It has the benefit of an easier workflow on export
but the drawback that these things are somewhat hidden. For sake of consistency
we would have to do the same for other export dialogs. The request is a WF if
we assume that PDF's are different and you have to save a PDF/A only once in a
while. IÄm a bit split here. Samuel, Thorsten: What's your take?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 54052] Improvement - PDF export defaults in Options/General

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=54052

Heiko Tietze  changed:

   What|Removed |Added

 CC||samuel.mehrbrodt@allotropia
   ||.de, t...@libreoffice.org
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #7 from Heiko Tietze  ---
Having the PDF export options under tools > options makes sense if you set it
up for once and never again. It has the benefit of an easier workflow on export
but the drawback that these things are somewhat hidden. For sake of consistency
we would have to do the same for other export dialogs. The request is a WF if
we assume that PDF's are different and you have to save a PDF/A only once in a
while. IÄm a bit split here. Samuel, Thorsten: What's your take?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


Re:

2021-01-29 Thread Dante Doménech
Got it, a lot of thanks! It was the last piece of the puzzle. Now I get
this:
Does *0 new warnings* mean everything is OK?

[PRL] CustomTarget/postprocess/images/commandimagelist.ilst
Suppression file:
/home/uv/Downloads/libreoffice/solenv/sanitizers/ui/modules/smath.suppr
False positive file:
/home/uv/Downloads/libreoffice/solenv/sanitizers/ui/modules/smath.false
*0 new warnings* (36 suppressed by
/home/uv/Downloads/libreoffice/solenv/sanitizers/ui/modules/smath.suppr,
please fix them)
Explanations are available on
https://wiki.documentfoundation.org/Development/Accessibility

El vie, 29 ene 2021 a las 10:27, Caolán McNamara ()
escribió:

> On Thu, 2021-01-28 at 22:25 +0100, Dante Doménech wrote:
> > starmath/uiconfig/smath/ui/smathsettings.ui:350 WARNING: 'GtkLabel'
> > 'label6' does not specify what it labels within 'GtkFrame'
> > 'contents1'
>
> label6 is "Scaling SmEditWindow:" and it is beside the smzoom
> SpinButton and is surely a label for the smzoom so smzoom should be set
> as the mnemonic target for label6.
>
> If using the glade editor, then click on label6, click on "general"
> tab, enable "Use underlne" which changes the selector widget beside it
> to sensitive, click its select area and from the resulting dialog pick
> "smzoom" as the target.
>
> If you wanted to do it manually the properties to add to label6 are
> True
> smzoom
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 54037] FILESAVE: Loss of internal hyperlinks in PPT/PPTX

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=54037

--- Comment #17 from NISZ LibreOffice Team  ---
Created attachment 169260
  --> https://bugs.documentfoundation.org/attachment.cgi?id=169260=edit
Interaction settings in the odp and pptx export

Interactions disappear from the shapes and the images too. PP seems to have a
similar feature on the Insert ribbon called Actions(?) so saving should be
possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re:

2021-01-29 Thread Caolán McNamara
On Thu, 2021-01-28 at 22:25 +0100, Dante Doménech wrote:
> starmath/uiconfig/smath/ui/smathsettings.ui:350 WARNING: 'GtkLabel'
> 'label6' does not specify what it labels within 'GtkFrame'
> 'contents1' 

label6 is "Scaling SmEditWindow:" and it is beside the smzoom
SpinButton and is surely a label for the smzoom so smzoom should be set
as the mnemonic target for label6.

If using the glade editor, then click on label6, click on "general"
tab, enable "Use underlne" which changes the selector widget beside it
to sensitive, click its select area and from the resulting dialog pick
"smzoom" as the target.

If you wanted to do it manually the properties to add to label6 are
True
smzoom 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 54037] FILESAVE: Loss of internal hyperlinks in PPT/PPTX

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=54037

--- Comment #16 from NISZ LibreOffice Team  ---
Created attachment 169259
  --> https://bugs.documentfoundation.org/attachment.cgi?id=169259=edit
Clicking on the hyperlink of the second slide in slide show view of Impress

Clicking the hyperlink opens the same file with a different program instead of
going to the first slide.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 54037] FILESAVE: Loss of internal hyperlinks in PPT/PPTX

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=54037

--- Comment #15 from NISZ LibreOffice Team  ---
Created attachment 169258
  --> https://bugs.documentfoundation.org/attachment.cgi?id=169258=edit
The hyperlink in the pptx file saved by Impress master

Still a problem in:

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 7eb289c49cc7245ef3001a39be0c15d06bbe875b
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL

The exported pptx contains the full file name reference in the Path field which
was empty in the original. This makes the file open in the system default pptx
viewer program.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113008] Signing+saving action should be more explicit and certificate is propagated to "Digital Signatures"

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113008

Srijita  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |msrijita...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/unx

2021-01-29 Thread Caolán McNamara (via logerrit)
 vcl/unx/gtk3/gtk3gtkframe.cxx  |5 +
 vcl/unx/gtk3/gtk3gtkinst.cxx   |   10 ++
 vcl/unx/gtk3/gtk3gtkobject.cxx |   30 +-
 3 files changed, 40 insertions(+), 5 deletions(-)

New commits:
commit 697399a78f17f5277d3e2962aa7b92e610619abe
Author: Caolán McNamara 
AuthorDate: Thu Jan 28 20:20:56 2021 +
Commit: Caolán McNamara 
CommitDate: Fri Jan 29 10:16:48 2021 +0100

keep focus in GtkSalObject child on gtk_widget_hide

gtk will take the focus out on hiding the GtkSalObject's child widget,
we want to keep it in. e.g. writer's comments in margin feature put
cursor in a sidebar comment and scroll the page so the comment is
invisible, we want the focus to stay in the invisible widget, so its
there when we scroll back or on a keypress the widget gets the keystroke
and scrolls back to make it visible again

Change-Id: If200779ef1b9cdfa9c4b027c27eca0afd5013ac5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110094
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtk3gtkframe.cxx b/vcl/unx/gtk3/gtk3gtkframe.cxx
index 4243763a3158..fb013d2a95ca 100644
--- a/vcl/unx/gtk3/gtk3gtkframe.cxx
+++ b/vcl/unx/gtk3/gtk3gtkframe.cxx
@@ -3188,6 +3188,11 @@ void GtkSalFrame::signalSetFocus(GtkWindow*, GtkWidget* 
pWidget, gpointer frame)
 else
 pGrabWidget = GTK_WIDGET(pThis->m_pFixedContainer);
 
+GtkWidget* pTopLevel = gtk_widget_get_toplevel(pGrabWidget);
+// see commentary in GtkSalObjectWidgetClip::Show
+if (pTopLevel && g_object_get_data(G_OBJECT(pTopLevel), 
"g-lo-BlockFocusChange"))
+return;
+
 // tdf#129634 interpret losing focus as focus passing explicitly to 
another widget
 bool bLoseFocus = pWidget && pWidget != pGrabWidget;
 
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index a42dbd5f4d8b..38708be5d273 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -1935,6 +1935,11 @@ protected:
 
 void launch_signal_focus_in()
 {
+GtkWidget* pTopLevel = gtk_widget_get_toplevel(m_pWidget);
+// see commentary in GtkSalObjectWidgetClip::Show
+if (pTopLevel && g_object_get_data(G_OBJECT(pTopLevel), 
"g-lo-BlockFocusChange"))
+return;
+
 // in e.g. function wizard RefEdits we want to select all when we get 
focus
 // but there are pending gtk handlers which change selection after our 
handler
 // post our focus in event to happen after those finish
@@ -1969,6 +1974,11 @@ protected:
 
 void launch_signal_focus_out()
 {
+GtkWidget* pTopLevel = gtk_widget_get_toplevel(m_pWidget);
+// see commentary in GtkSalObjectWidgetClip::Show
+if (pTopLevel && g_object_get_data(G_OBJECT(pTopLevel), 
"g-lo-BlockFocusChange"))
+return;
+
 // tdf#127262 because focus in is async, focus out must not appear out
 // of sequence to focus in
 if (m_pFocusOutEvent)
diff --git a/vcl/unx/gtk3/gtk3gtkobject.cxx b/vcl/unx/gtk3/gtk3gtkobject.cxx
index d9de95926611..5923088b79ee 100644
--- a/vcl/unx/gtk3/gtk3gtkobject.cxx
+++ b/vcl/unx/gtk3/gtk3gtkobject.cxx
@@ -415,12 +415,32 @@ void GtkSalObjectWidgetClip::Reparent(SalFrame* pFrame)
 
 void GtkSalObjectWidgetClip::Show( bool bVisible )
 {
-if( m_pSocket )
+if (!m_pSocket)
+return;
+bool bCurrentVis = gtk_widget_get_visible(m_pScrolledWindow);
+if (bVisible == bCurrentVis)
+return;
+if( bVisible )
+gtk_widget_show(m_pScrolledWindow);
+else
 {
-if( bVisible )
-gtk_widget_show(m_pScrolledWindow);
-else
-gtk_widget_hide(m_pScrolledWindow);
+// on hiding the widget, if a child has focus gtk will want to move 
the focus out of the widget
+// but we want to keep the focus where it is, e.g. writer's comments 
in margin feature put
+// cursor in a sidebar comment and scroll the page so the comment is 
invisible, we want the focus
+// to stay in the invisible widget, so its there when we scroll back 
or on a keypress the widget
+// gets the keystroke and scrolls back to make it visible again
+GtkWidget* pTopLevel = gtk_widget_get_toplevel(m_pScrolledWindow);
+GtkWidget* pOldFocus = GTK_IS_WINDOW(pTopLevel) ? 
gtk_window_get_focus(GTK_WINDOW(pTopLevel)) : nullptr;
+
+g_object_set_data(G_OBJECT(pTopLevel), "g-lo-BlockFocusChange", 
GINT_TO_POINTER(true) );
+
+gtk_widget_hide(m_pScrolledWindow);
+
+GtkWidget* pNewFocus = GTK_IS_WINDOW(pTopLevel) ? 
gtk_window_get_focus(GTK_WINDOW(pTopLevel)) : nullptr;
+if (pOldFocus && pOldFocus != pNewFocus)
+gtk_widget_grab_focus(pOldFocus);
+
+g_object_set_data(G_OBJECT(pTopLevel), "g-lo-BlockFocusChange", 
GINT_TO_POINTER(false) );
 }
 }
 
___
Libreoffice-commits 

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sd/source

2021-01-29 Thread Tamás Zolnai (via logerrit)
 sd/source/ui/sidebar/SlideBackground.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 873759184cc8728af0cdea4d8b689ef6da23375c
Author: Tamás Zolnai 
AuthorDate: Thu Jan 28 12:20:29 2021 +0100
Commit: Tamás Zolnai 
CommitDate: Fri Jan 29 10:15:49 2021 +0100

tdf#139965: Broken master slide list after switching mode.

Let's update the master slide combobox by context change.
populateMasterSlideDropdown() will fill the list when we
switch to normal view. The same method is called when the
sidebar created in normal view.
mpMasterSlide->Clear() will clean the list when we switch
to master view. The same happens, when the sidebar is created
in a master view context (the list is empty).

Change-Id: I322619e409a5352ddcd59a249dd0c874054c1e4c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110075
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tamás Zolnai 
(cherry picked from commit 2be52f741e283b5f172ae536f0e99ce0f38df9e1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110113

diff --git a/sd/source/ui/sidebar/SlideBackground.cxx 
b/sd/source/ui/sidebar/SlideBackground.cxx
index bf1914465bac..31b91379a86f 100644
--- a/sd/source/ui/sidebar/SlideBackground.cxx
+++ b/sd/source/ui/sidebar/SlideBackground.cxx
@@ -283,6 +283,7 @@ void SlideBackground::HandleContextChange(
 mpCloseMaster->Show();
 mpEditMaster->Hide();
 mpMasterSlide->Disable();
+mpMasterSlide->Clear();
 mpDspMasterBackground->Disable();
 mpDspMasterObjects->Disable();
 mpFillStyle->Hide();
@@ -299,6 +300,7 @@ void SlideBackground::HandleContextChange(
 mpCloseMaster->Hide();
 mpEditMaster->Hide();
 mpMasterSlide->Disable();
+mpMasterSlide->Clear();
 mpDspMasterBackground->Disable();
 mpDspMasterObjects->Disable();
 mpFillStyle->Hide();
@@ -310,6 +312,7 @@ void SlideBackground::HandleContextChange(
 mpCloseMaster->Hide();
 mpEditMaster->Show();
 mpMasterSlide->Enable();
+populateMasterSlideDropdown();
 mpDspMasterBackground->Enable();
 mpDspMasterObjects->Enable();
 mpFillStyle->Show();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sd/source

2021-01-29 Thread Tamás Zolnai (via logerrit)
 sd/source/ui/sidebar/SlideBackground.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 6c30a605b1d59d31b9a46b6d33ac56a46621dec4
Author: Tamás Zolnai 
AuthorDate: Thu Jan 28 12:20:29 2021 +0100
Commit: Tamás Zolnai 
CommitDate: Fri Jan 29 10:15:22 2021 +0100

tdf#139965: Broken master slide list after switching mode.

Let's update the master slide combobox by context change.
populateMasterSlideDropdown() will fill the list when we
switch to normal view. The same method is called when the
sidebar created in normal view.
mpMasterSlide->Clear() will clean the list when we switch
to master view. The same happens, when the sidebar is created
in a master view context (the list is empty).

Change-Id: I322619e409a5352ddcd59a249dd0c874054c1e4c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110075
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tamás Zolnai 
(cherry picked from commit 2be52f741e283b5f172ae536f0e99ce0f38df9e1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110114
Tested-by: Jenkins

diff --git a/sd/source/ui/sidebar/SlideBackground.cxx 
b/sd/source/ui/sidebar/SlideBackground.cxx
index e92c936c92a8..17c85e21540d 100644
--- a/sd/source/ui/sidebar/SlideBackground.cxx
+++ b/sd/source/ui/sidebar/SlideBackground.cxx
@@ -301,6 +301,7 @@ void SlideBackground::HandleContextChange(
 mxCloseMaster->show();
 mxEditMaster->hide();
 mxMasterSlide->set_sensitive(false);
+mxMasterSlide->clear();
 mxDspMasterBackground->set_sensitive(false);
 mxDspMasterObjects->set_sensitive(false);
 mxFillStyle->hide();
@@ -312,6 +313,7 @@ void SlideBackground::HandleContextChange(
 mxCloseMaster->hide();
 mxEditMaster->hide();
 mxMasterSlide->set_sensitive(false);
+mxMasterSlide->clear();
 mxDspMasterBackground->set_sensitive(false);
 mxDspMasterObjects->set_sensitive(false);
 mxFillStyle->hide();
@@ -323,6 +325,7 @@ void SlideBackground::HandleContextChange(
 mxCloseMaster->hide();
 mxEditMaster->show();
 mxMasterSlide->set_sensitive(true);
+populateMasterSlideDropdown();
 mxDspMasterBackground->set_sensitive(true);
 mxDspMasterObjects->set_sensitive(true);
 mxFillStyle->show();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: helpcontent2

2021-01-29 Thread Seth Chaiklin (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3c2d0a647c78bb876a75896293bce9494f40646e
Author: Seth Chaiklin 
AuthorDate: Fri Jan 29 10:02:58 2021 +0100
Commit: Gerrit Code Review 
CommitDate: Fri Jan 29 10:02:58 2021 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 9104dcbfe3c4d7a845520ad62d34efa0d3356abe
  - correction to option labels in AutoCorrect options

   * corrections to three option labels to align them with
 actual options in AutoCorrect dialog
   * removed mention of "digits" in  because the "digit"
 example was recently added to the "replace dashes" table.
   * updated to ,

Change-Id: I32a5c874487e4ccd9c65cca346323257bb27d12a
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110053
Reviewed-by: Seth Chaiklin 
Tested-by: Jenkins

diff --git a/helpcontent2 b/helpcontent2
index 586ced62fd1b..9104dcbfe3c4 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 586ced62fd1bea8a07e84fea7c3befc59c1249e1
+Subproject commit 9104dcbfe3c4d7a845520ad62d34efa0d3356abe
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] help.git: source/text

2021-01-29 Thread Seth Chaiklin (via logerrit)
 source/text/shared/01/06040100.xhp |   12 +---
 1 file changed, 5 insertions(+), 7 deletions(-)

New commits:
commit 9104dcbfe3c4d7a845520ad62d34efa0d3356abe
Author: Seth Chaiklin 
AuthorDate: Thu Jan 28 02:56:03 2021 +0100
Commit: Seth Chaiklin 
CommitDate: Fri Jan 29 10:02:58 2021 +0100

correction to option labels in AutoCorrect options

   * corrections to three option labels to align them with
 actual options in AutoCorrect dialog
   * removed mention of "digits" in  because the "digit"
 example was recently added to the "replace dashes" table.
   * updated to ,

Change-Id: I32a5c874487e4ccd9c65cca346323257bb27d12a
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110053
Reviewed-by: Seth Chaiklin 
Tested-by: Jenkins

diff --git a/source/text/shared/01/06040100.xhp 
b/source/text/shared/01/06040100.xhp
index a32c9f22b..75d30685d 100644
--- a/source/text/shared/01/06040100.xhp
+++ b/source/text/shared/01/06040100.xhp
@@ -67,7 +67,7 @@
   Correct TWo INitial CApitals
   If you 
type two uppercase letters at the beginning of a "WOrd", the second uppercase 
letter is automatically replaced with a lowercase letter.
   Capitalize first letter of every 
sentence.
-  Capitalizes the first letter of every sentence.
+  Capitalizes the first letter of every sentence
 
 
 The first letter in 
a Calc cell will never be capitalized automatically.see 
i78661
@@ -149,26 +149,24 @@
  
   
 
-  If the 
hyphens are there between digits or the text has the Hungarian or Finnish 
language attribute, then two hyphens in the sequence A--B are replaced by an 
en-dash instead of an em-dash.i71908
+  If the text has the Hungarian 
or Finnish language attribute, then two hyphens in the sequence A--B are 
replaced by an en-dash instead of an em-dash.i71908
   Delete spaces and tabs at beginning 
and end of paragraph
 
   Removes spaces and tabs at the beginning of a paragraph. To use 
this option, the Apply Styles option must also be selected.
 
-  Delete blanks and tabs at end and 
start of lines
-
+  Delete spaces and tabs at end and 
start of line
   Removes spaces and tabs at the beginning of each line. To use 
this option, the Apply Styles option must also be selected.
 
   Ignore double spaces
   Replaces 
two or more consecutive spaces with a single space.
-  Apply numbering - symbol
-
+  Bulleted and numbered lists. Bullet 
symbol:
   Automatically creates a numbered list when you press Enter at 
the end of a line that starts with a number followed by a period, a space, and 
text. If a line starts with a hyphen (-), a plus sign (+), or an asterisk (*), 
followed by a space, and text, a bulleted list is created when you press Enter.
 
   To 
cancel automatic numbering when you press Enter at the end of a line that 
starts with a numbering symbol, press Enter again.
 
 
 
-The automatic 
numbering option is only applied to paragraphs that are formatted with the 
"Default", "Text body", or "Text body indent" paragraph style.
+The automatic numbering option is 
only applied to paragraphs that are formatted with the "Default", "Text body", 
or "Text body indent" paragraph style.
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: cui/uiconfig sw/uiconfig

2021-01-29 Thread Seth Chaiklin (via logerrit)
 cui/uiconfig/ui/spellingdialog.ui   |   16 +++-
 sw/uiconfig/swriter/ui/spellmenu.ui |7 ---
 2 files changed, 15 insertions(+), 8 deletions(-)

New commits:
commit f51119a37864bca35737898a8cbba9345e09b124
Author: Seth Chaiklin 
AuthorDate: Mon Jan 25 09:18:29 2021 +0100
Commit: Heiko Tietze 
CommitDate: Fri Jan 29 09:51:46 2021 +0100

tdf#75923 "Always Correct" to "Add to AutoCorrect" in Spelling dialog

  * improve choices for accelerator keys
  + add tooltip for "Add to AutoCorrect"
  + add missing extended tip for "Add to Dictionary"

  * change "Always correct to" to "Always AutoCorrect to"
in Spelling context menu.
  + add tooltip for "Always AutoCorrect to"

Change-Id: I54428fcd03ed7205a503935c77a7e08f9682bb1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109809
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 

diff --git a/cui/uiconfig/ui/spellingdialog.ui 
b/cui/uiconfig/ui/spellingdialog.ui
index 368e9506efe5..81458c8ff92a 100644
--- a/cui/uiconfig/ui/spellingdialog.ui
+++ b/cui/uiconfig/ui/spellingdialog.ui
@@ -272,7 +272,7 @@
 True
 False
 True
-_Not in dictionary
+_Not in Dictionary
 True
 sentence
 0
@@ -482,16 +482,17 @@
 
 
   
-Alwa_ys Correct
+Add to _AutoCorrect
 True
 True
 True
+Add selected suggestion as replacement for 
incorrect word in AutoCorrect replacement table.
 center
 True
 True
 
   
-Adds the 
current combination of the incorrect word and the replacement word to the 
AutoCorrect replacements table.
+Adds the 
current combination of the incorrect word and the replacement word to the 
AutoCorrect replacement table.
   
 
   
@@ -575,13 +576,18 @@
 
 
   
-_Add to Dictionary
+Add to _Dictionary
 True
 True
 True
 center
 True
 True
+
+ 
+   Adds the unknown 
word to a user-defined dictionary.
+ 
+
   
   
 0
@@ -590,7 +596,7 @@
 
 
   
-_Add to Dictionary
+Add to _Dictionary
 True
 True
 True
diff --git a/sw/uiconfig/swriter/ui/spellmenu.ui 
b/sw/uiconfig/swriter/ui/spellmenu.ui
index 81383c2aebe7..749f0c25531e 100644
--- a/sw/uiconfig/swriter/ui/spellmenu.ui
+++ b/sw/uiconfig/swriter/ui/spellmenu.ui
@@ -17,7 +17,7 @@
   
 True
 False
-_Add to Dictionary
+Add to _Dictionary
 True
 
   
@@ -31,7 +31,7 @@
   
 True
 False
-_Add 
to Dictionary
+Add 
to _Dictionary
 True
   
 
@@ -52,7 +52,8 @@
   
 True
 False
-Always correct _to
+Always AutoCorrect _to
+Add selected correction as replacement for 
incorrect word in AutoCorrect replacement table.
 
   
 True
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 138706] [META] Regressions from "tdf106792 Get rid of SvxShapePolyPolygonBezier"

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138706

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Depends on||79920


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=79920
[Bug 79920] VIEWING: Diagram shapes not displayed correctly
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 79920] VIEWING: Diagram shapes not displayed correctly

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=79920

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Blocks||138706

--- Comment #16 from NISZ LibreOffice Team  ---
(In reply to NISZ LibreOffice Team from comment #15)
> Now we are back to the 
> "Before that the vertical lines became horizontal between 6.1 and 6.2."
> level.

This started with:

https://git.libreoffice.org/core/+/36bade04d3780bc54c51b46bb0b63e69789658a5

tdf106792 Get rid of SvxShapePolyPolygonBezier

Even without this there would be a lot to do about this document:

- the blue-red cell tables are floating tables, which may cause troubles. I'm
not sure yet if they actually do.
- Some vertical lines seem to be longer than in Word: at the first table below
customer_id and the one on the left of the document connecting the ORDER and
ORDER_STAFF tables
- The orange-green grouped shape in the header has a 95% relative width
relative to the page, that is not imported correctly and shrunk quite a bit.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=138706
[Bug 138706] [META] Regressions from "tdf106792 Get rid of
SvxShapePolyPolygonBezier"
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105605
Bug 105605 depends on bug 115884, which changed state.

Bug 115884 Summary: PDF signing should mention it only works with x509 
certificates
https://bugs.documentfoundation.org/show_bug.cgi?id=115884

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115884] PDF signing should mention it only works with x509 certificates

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115884

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org
 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #16 from Buovjaga  ---
(In reply to Marco A.G.Pinto from comment #15)
> (In reply to Timur from comment #13)
> > I don't understand Comment 12, it needs precision or this bug be closed. 
> > Because it's clear now with added X. 509, simple "select X.509 certificate".
> 
> Timur, if it now shows "select X.509 certificate" the bug can be closed.

No need to guess, just look at the commit
https://git.libreoffice.org/core/commit/a1146fd95022196636f8c41f7322a7257955cef4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115884] PDF signing should mention it only works with x509 certificates

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115884

--- Comment #15 from Marco A.G.Pinto  ---
(In reply to Timur from comment #13)
> I don't understand Comment 12, it needs precision or this bug be closed. 
> Because it's clear now with added X. 509, simple "select X.509 certificate".

Timur, if it now shows "select X.509 certificate" the bug can be closed.

:-)

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: basic/source chart2/source codemaker/source comphelper/source compilerplugins/clang configmgr/source connectivity/source cppu/source dbaccess/qa dbaccess/source desktop

2021-01-29 Thread Noel (via logerrit)
 basic/source/classes/sb.cxx|2 
 basic/source/classes/sbunoobj.cxx  |   10 +-
 chart2/source/controller/main/ChartController_Insert.cxx   |2 
 chart2/source/controller/main/ChartController_Properties.cxx   |   20 ++--
 chart2/source/controller/main/ObjectHierarchy.cxx  |   12 +-
 chart2/source/controller/main/SelectionHelper.cxx  |8 -
 chart2/source/controller/sidebar/ChartAreaPanel.cxx|2 
 chart2/source/inc/ObjectIdentifier.hxx |   24 ++---
 chart2/source/tools/ObjectIdentifier.cxx   |   40 
-
 chart2/source/view/charttypes/CandleStickChart.cxx |4 
 chart2/source/view/diagram/VDiagram.cxx|6 -
 chart2/source/view/main/ChartView.cxx  |2 
 chart2/source/view/main/VDataSeries.cxx|2 
 codemaker/source/commonjava/commonjava.cxx |2 
 codemaker/source/javamaker/javatype.cxx|4 
 comphelper/source/misc/string.cxx  |2 
 compilerplugins/clang/stringviewparam.cxx  |   34 
+++-
 compilerplugins/clang/test/stringviewparam.cxx |8 +
 configmgr/source/access.cxx|4 
 configmgr/source/data.cxx  |4 
 configmgr/source/data.hxx  |2 
 connectivity/source/commontools/dbtools.cxx|2 
 connectivity/source/commontools/filtermanager.cxx  |2 
 connectivity/source/drivers/firebird/Blob.cxx  |   10 +-
 connectivity/source/drivers/firebird/Connection.cxx|   18 ++--
 connectivity/source/drivers/firebird/PreparedStatement.cxx |   16 +--
 connectivity/source/drivers/firebird/ResultSet.cxx |2 
 connectivity/source/drivers/firebird/StatementCommonBase.cxx   |   14 +--
 connectivity/source/drivers/firebird/Util.cxx  |4 
 connectivity/source/drivers/firebird/Util.hxx  |4 
 connectivity/source/drivers/hsqldb/HTools.cxx  |8 -
 connectivity/source/inc/hsqldb/HTools.hxx  |4 
 cppu/source/uno/lbmap.cxx  |6 -
 dbaccess/qa/unit/embeddeddb_performancetest.cxx|   24 ++---
 dbaccess/source/core/api/OptimisticSet.cxx |2 
 dbaccess/source/core/api/SingleSelectQueryComposer.cxx |6 -
 dbaccess/source/core/recovery/settingsimport.cxx   |2 
 dbaccess/source/core/recovery/settingsimport.hxx   |2 
 dbaccess/source/filter/hsqldb/fbcreateparser.cxx   |   14 +--
 dbaccess/source/filter/hsqldb/hsqlimport.cxx   |5 -
 dbaccess/source/filter/hsqldb/hsqlimport.hxx   |2 
 desktop/source/app/dispatchwatcher.cxx |2 
 desktop/source/deployment/gui/dp_gui_updatedialog.cxx  |6 -
 extensions/source/propctrlr/formcomponenthandler.cxx   |4 
 extensions/source/propctrlr/formcomponenthandler.hxx   |2 
 framework/inc/recording/dispatchrecorder.hxx   |2 
 framework/source/accelerators/documentacceleratorconfiguration.cxx |4 
 framework/source/accelerators/presethandler.cxx|4 
 framework/source/inc/accelerators/presethandler.hxx|4 
 framework/source/recording/dispatchrecorder.cxx|2 
 include/basic/sbstar.hxx   |2 
 include/codemaker/commonjava.hxx   |2 
 include/comphelper/stl_types.hxx   |2 
 include/comphelper/string.hxx  |2 
 include/connectivity/dbtools.hxx   |2 
 include/connectivity/filtermanager.hxx |2 
 include/oox/core/contexthandler2.hxx   |2 
 include/oox/dump/dumperbase.hxx|2 
 include/oox/ole/vbamodule.hxx  |2 
 include/sfx2/DocumentMetadataAccess.hxx|2 
 include/sfx2/linkmgr.hxx   |2 
 include/sfx2/lokhelper.hxx |2 
 include/svl/zforlist.hxx   |4 
 include/svl/zformat.hxx|2 
 include/xmloff/xmlnumfe.hxx|2 

[Libreoffice-bugs] [Bug 115884] PDF signing should mention it only works with x509 certificates

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115884

Timur  changed:

   What|Removed |Added

 CC||sdc.bla...@youmail.dk

--- Comment #14 from Timur  ---
Help also needs to be improved, or can be done in this bug or another.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115884] PDF signing should mention it only works with x509 certificates

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115884

--- Comment #13 from Timur  ---
I don't understand Comment 12, it needs precision or this bug be closed. 
Because it's clear now with added X. 509, simple "select X.509 certificate".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 139591] Separation between start interactive frame not ok. I's hard to place cursor at the start of the paragraph with the mouse (depend on zoomlevel)

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139591

Dieter  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
 Whiteboard| QA:needsComment|
   Severity|normal  |trivial

--- Comment #4 from Dieter  ---
Tested with

Version: 7.2.0.0.alpha0+ (x64)
Build ID: 9f9798f07f0b56ae474f31ded671cc8da598d244
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded

If mouse position is displayed as arrow, you select frame (this is also at
beginning of H); if it changes to cursor-symbol cursor is placed left from H.

I won't consider this as a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: [Libreoffice-qa] ESC meeting agenda - Adding topic: Broken release process when fresh become still and when still become EOL'ed

2021-01-29 Thread Michael Weghorn



On 28/01/2021 22.03, Jan-Marek Glogowski wrote:

LO is regression plagued product.


Yup. But honestly with the available resources, I don't see this 
changing in any time-frame, I can imagine. One IMHO main problem is, 
that we mainly have regression unit tests. So every change is almost 
guaranteed to break stuff. At least for me it feels like this. 
Everything is a lot of guesswork for me, even in areas, where people 
claim I'm the actual expert.


[...]

You may ask: do we have unit tests at least for some of the essential 
low level stuff I touched? Barely any and nothing I would consider 
remotely sufficient.


[...] >
So I can very much relate to your impression. But unless you have some 
large new resources available for the project, we'll have to bear with it.


Sadly true.

I fully agree with Timur that our current release model (with fresh and 
still) mitigates the negative impacts, though, and currently don't see 
how that would reasonably work if we switch to a rolling release model 
without addressing the issues you outlined, or another way to 
effectively avoid more severe regressions landing in our rolling release 
version.


I'm not against a rolling release model in general, but would love to 
see such aspects addressed in a more detailed proposal.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice-qa] ESC meeting agenda - Adding topic: Broken release process when fresh become still and when still become EOL'ed

2021-01-29 Thread Michael Weghorn



On 28/01/2021 22.03, Jan-Marek Glogowski wrote:

LO is regression plagued product.


Yup. But honestly with the available resources, I don't see this 
changing in any time-frame, I can imagine. One IMHO main problem is, 
that we mainly have regression unit tests. So every change is almost 
guaranteed to break stuff. At least for me it feels like this. 
Everything is a lot of guesswork for me, even in areas, where people 
claim I'm the actual expert.


[...]

You may ask: do we have unit tests at least for some of the essential 
low level stuff I touched? Barely any and nothing I would consider 
remotely sufficient.


[...] >
So I can very much relate to your impression. But unless you have some 
large new resources available for the project, we'll have to bear with it.


Sadly true.

I fully agree with Timur that our current release model (with fresh and 
still) mitigates the negative impacts, though, and currently don't see 
how that would reasonably work if we switch to a rolling release model 
without addressing the issues you outlined, or another way to 
effectively avoid more severe regressions landing in our rolling release 
version.


I'm not against a rolling release model in general, but would love to 
see such aspects addressed in a more detailed proposal.

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/


[Libreoffice-bugs] [Bug 139594] Placing cursor inside Interactive frame at the beginning of paragraph by mouse is off at smaller zoom levels (clicking halfway first character) selecting the frame

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139594

Dieter  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Whiteboard| QA:needsComment|
 CC||dgp-m...@gmx.de
 Status|UNCONFIRMED |NEEDINFO
   Severity|normal  |trivial

--- Comment #2 from Dieter  ---
Attachment has a frame and a shape.

I confirm behaviour with the shape, but not with the frame. Telsto, please
specify your description
=> NEEDINFO

Version: 7.2.0.0.alpha0+ (x64)
Build ID: 9f9798f07f0b56ae474f31ded671cc8da598d244
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 59323] Impress conversion to PPTX doesn't save (header and footer) fields - with sample or steps in Comment 7

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=59323

--- Comment #14 from NISZ LibreOffice Team  ---
Created attachment 169257
  --> https://bugs.documentfoundation.org/attachment.cgi?id=169257=edit
Screenshot of the original document and its PPTX version in Impress

Still a problem in:

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 7eb289c49cc7245ef3001a39be0c15d06bbe875b
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL

However the PPTX version is opened without invalid contents warning in my PP
2013.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 41572] Please make it possible to add custom animations to master slides

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=41572

NISZ LibreOffice Team  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||8821

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 128821] FILEOPEN PPTX Animations defined on master slide are not imported

2021-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128821

NISZ LibreOffice Team  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=41
   ||572

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


<    1   2   3