[Libreoffice-bugs] [Bug 138465] FILEOPEN DOCX Formula appears squashed until touched
https://bugs.documentfoundation.org/show_bug.cgi?id=138465 Attila Bakos (NISZ) changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |bakos.attilakar...@nisz.hu |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138297] Outer frame and inner text frame mismatch after anchor change and broken even after undo (DOCX)
https://bugs.documentfoundation.org/show_bug.cgi?id=138297 Attila Bakos (NISZ) changed: What|Removed |Added Assignee|bakos.attilakar...@nisz.hu |libreoffice-b...@lists.free ||desktop.org Status|ASSIGNED|NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135010] Memory usage opening and scrolling a DOCX increased from 600 to 1250 MB; still 360 MB in use after close
https://bugs.documentfoundation.org/show_bug.cgi?id=135010 --- Comment #8 from Telesto --- (In reply to Buovjaga from comment #7) > I bibisected with linux-64-7.0. There were two bumps in memory use. I only > checked the last one and it is caused by > https://git.libreoffice.org/core/commit/ > 828504974d70111e4a35b31d579cf42fe660a660 > tdf#130768 speedup huge pixel graphics Cairo > > so I guess it is just the use of caching to speed things up. Cairo there > explains why I don't see the memory bump with Linux gen backend. > > Let's close as everything seems to be working according to plan. Caching and caching.. whole debate about that at bug 138068. Cairo one but apparently broken (or I read it that way). And Skia might do another round with an independent caching system. Another topic is. Is this related to DOCX filter or not [have to check, don't remember]. As the filter tends to convert stuff.. So there is plenty of room/ 'potential' to have unintended memory issue with images. That's the part worrying me. At obviously clear that even developers struggle; else the would have seen bug 138068 from miles away (there is patch in gerrit, no clue what that will do) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138141] FILEOPEN DOCX Textframes don’t inherit their shapes z-order
https://bugs.documentfoundation.org/show_bug.cgi?id=138141 Attila Bakos (NISZ) changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|bakos.attilakar...@nisz.hu |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135324] FILESAVE DOCX: Image and figure caption overlap
https://bugs.documentfoundation.org/show_bug.cgi?id=135324 Attila Bakos (NISZ) changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|bakos.attilakar...@nisz.hu |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138512] CRASH: Changing vertical alignment (GTK3)
https://bugs.documentfoundation.org/show_bug.cgi?id=138512 Attila Bakos (NISZ) changed: What|Removed |Added Assignee|bakos.attilakar...@nisz.hu |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sc/qa sc/source
sc/qa/unit/ucalc_sharedformula.cxx |2 +-
sc/source/ui/docshell/docfunc.cxx |4 ++--
sc/source/ui/inc/docfunc.hxx |2 +-
sc/source/ui/view/viewfunc.cxx | 10 +++---
4 files changed, 11 insertions(+), 7 deletions(-)
New commits:
commit d11933d905d1a610f4b4f0a97354b06cdbd6ee6d
Author: Tor Lillqvist
AuthorDate: Wed Feb 10 11:58:52 2021 +0200
Commit: Tor Lillqvist
CommitDate: Thu Feb 11 14:51:41 2021 +0100
Don't shrink row height when deleting cell contents interactively either
Follow-up to e763e13873adfe3c6abfa4c2dfd3ac3847e2d494. Such shrinking
of row height, typically by a few silly pixels, just causes
unnecessary invalidation thrash in a collaborative editing context.
Change-Id: I5651ce994ba4bf82c83d7d4ef1bb8ed5bab0a66d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110697
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Dennis Francis
Reviewed-by: Tor Lillqvist
diff --git a/sc/qa/unit/ucalc_sharedformula.cxx
b/sc/qa/unit/ucalc_sharedformula.cxx
index 7cb85e8c9bbf..3aeffd2f3fef 100644
--- a/sc/qa/unit/ucalc_sharedformula.cxx
+++ b/sc/qa/unit/ucalc_sharedformula.cxx
@@ -2406,7 +2406,7 @@ void Test::testSharedFormulaDeleteTopCell()
// Delete cell A1.
ScMarkData aMark(MAXROW, MAXCOL);
aMark.SelectOneTable(0);
-getDocShell().GetDocFunc().DeleteCell( ScAddress(0,0,0), aMark,
InsertDeleteFlags::CONTENTS, false);
+getDocShell().GetDocFunc().DeleteCell( ScAddress(0,0,0), aMark,
InsertDeleteFlags::CONTENTS, false, /*bApi=*/ true);
// Check it's gone.
CPPUNIT_ASSERT(!m_pDoc->GetFormulaCell( ScAddress(0,0,0)));
diff --git a/sc/source/ui/docshell/docfunc.cxx
b/sc/source/ui/docshell/docfunc.cxx
index c016d3083b63..3a135d9d0042 100644
--- a/sc/source/ui/docshell/docfunc.cxx
+++ b/sc/source/ui/docshell/docfunc.cxx
@@ -658,7 +658,7 @@ bool ScDocFunc::DeleteContents(
}
bool ScDocFunc::DeleteCell(
-const ScAddress& rPos, const ScMarkData& rMark, InsertDeleteFlags nFlags,
bool bRecord )
+const ScAddress& rPos, const ScMarkData& rMark, InsertDeleteFlags nFlags,
bool bRecord, bool bApi )
{
ScDocShellModificator aModificator(rDocShell);
@@ -714,7 +714,7 @@ bool ScDocFunc::DeleteCell(
nFlags, pDataSpans, false, bDrawUndo);
}
-if (!AdjustRowHeight(rPos, true, true))
+if (!AdjustRowHeight(rPos, true, bApi))
rDocShell.PostPaint(
rPos.Col(), rPos.Row(), rPos.Tab(), rPos.Col(), rPos.Row(),
rPos.Tab(),
PaintPartFlags::Grid, nExtFlags);
diff --git a/sc/source/ui/inc/docfunc.hxx b/sc/source/ui/inc/docfunc.hxx
index af8e23fc3124..8ca4c445cca7 100644
--- a/sc/source/ui/inc/docfunc.hxx
+++ b/sc/source/ui/inc/docfunc.hxx
@@ -91,7 +91,7 @@ public:
const ScMarkData& rMark, InsertDeleteFlags nFlags, bool bRecord, bool
bApi );
bool DeleteCell(
-const ScAddress& rPos, const ScMarkData& rMark, InsertDeleteFlags
nFlags, bool bRecord );
+const ScAddress& rPos, const ScMarkData& rMark, InsertDeleteFlags
nFlags, bool bRecord, bool bApi );
boolTransliterateText( const ScMarkData& rMark,
TransliterationFlags nType,
bool bApi );
diff --git a/sc/source/ui/view/viewfunc.cxx b/sc/source/ui/view/viewfunc.cxx
index 06241ecb4cf7..e5b1da40162c 100644
--- a/sc/source/ui/view/viewfunc.cxx
+++ b/sc/source/ui/view/viewfunc.cxx
@@ -1,4 +1,4 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4;
fill-column: 100 -*- */
/*
* This file is part of the LibreOffice project.
*
@@ -1987,10 +1987,14 @@ void ScViewFunc::DeleteContents( InsertDeleteFlags
nFlags )
HideAllCursors(); // for if summary is cancelled
ScDocFunc& rDocFunc = pDocSh->GetDocFunc();
+
+// Can we really be sure that we can pass the bApi parameter as false to
DeleteCell() and
+// DeleteContents() here? (Meaning that this is interactive use.) Is this
never invoked from
+// scripting and whatnot?
if (bSimple)
-rDocFunc.DeleteCell(aMarkRange.aStart, aFuncMark, nFlags, bRecord);
+rDocFunc.DeleteCell(aMarkRange.aStart, aFuncMark, nFlags, bRecord,
/*bApi=*/ false);
else
-rDocFunc.DeleteContents(aFuncMark, nFlags, bRecord, false);
+rDocFunc.DeleteContents(aFuncMark, nFlags, bRecord, /*bApi=*/ false);
pDocSh->UpdateOle(());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140337] In 7.1.0.3, the Basic macro of calc shows the error "CellAddress method is missing.
https://bugs.documentfoundation.org/show_bug.cgi?id=140337 --- Comment #1 from himajin100...@gmail.com --- at least not reproducible on Windows Version: 7.1.0.3 (x64) / LibreOffice Community Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: ja-JP (ja_JP); UI: ja-JP Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134821] Empty pages after pasting multiple times
https://bugs.documentfoundation.org/show_bug.cgi?id=134821 Buovjaga changed: What|Removed |Added Keywords|bibisectRequest |notBibisectable --- Comment #7 from Buovjaga --- The blanks do not appear reliably, so in its current form this is not bibisectable -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135010] Memory usage opening and scrolling a DOCX increased from 600 to 1250 MB; still 360 MB in use after close
https://bugs.documentfoundation.org/show_bug.cgi?id=135010 Buovjaga changed: What|Removed |Added Keywords|bibisectRequest, regression | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135010] Memory usage opening and scrolling a DOCX increased from 600 to 1250 MB; still 360 MB in use after close
https://bugs.documentfoundation.org/show_bug.cgi?id=135010 Buovjaga changed: What|Removed |Added Status|NEEDINFO|RESOLVED CC||ilmari.lauhakangas@libreoff ||ice.org Resolution|--- |NOTABUG --- Comment #7 from Buovjaga --- I bibisected with linux-64-7.0. There were two bumps in memory use. I only checked the last one and it is caused by https://git.libreoffice.org/core/commit/828504974d70111e4a35b31d579cf42fe660a660 tdf#130768 speedup huge pixel graphics Cairo so I guess it is just the use of caching to speed things up. Cairo there explains why I don't see the memory bump with Linux gen backend. Let's close as everything seems to be working according to plan. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140337] New: In 7.1.0.3, the Basic macro of calc shows the error "CellAddress method is missing.
https://bugs.documentfoundation.org/show_bug.cgi?id=140337 Bug ID: 140337 Summary: In 7.1.0.3, the Basic macro of calc shows the error "CellAddress method is missing. Product: LibreOffice Version: 7.1.0.3 release Hardware: x86 (IA32) OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cam...@mac.com Description: This is about a macro in Calc. I have a Calc Basic macro that I set up about three years ago, and it worked fine until 7.0.4. But in 7.1.0.3, it doesn't work anymore. The error dialog looks like this BASIC Runtime Error. The following property or method was not found: CellAddress. The macro, which is assigned to a button and deletes the row with the selected cell, looks like this Sub delete_Click() Dim oSheet As Object oSheet = ThisComponent.CurrentController.ActiveSheet dim oActiveCell As Object dim currRowNum As Long oActiveCell = ThisComponent.CurrentSelection currRowNum = oActiveCell.CellAddress.Row oSheet.Rows.removeByIndex(currRowNum, 1) End Sub Steps to Reproduce: 1. Create a Calc file 2. Put text in some cells 3. Set up a button and assign the macro above. 4. Select one of the cells and then press the button. Actual Results: error "CellAddress method is missing. Expected Results: The row with the selected cell will be deleted. Reproducible: Always User Profile Reset: No Additional Info: When I run it with 7.0.4 on the same machine, it works fine. Both 7.0.4 and 7.1.0.3 have been converted to Japanese by installing the Language pack. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 796ad7204414f587d472a8915f122fa58677711a Author: Seth Chaiklin AuthorDate: Thu Feb 11 14:03:30 2021 +0100 Commit: Gerrit Code Review CommitDate: Thu Feb 11 14:03:30 2021 +0100 Update git submodules * Update helpcontent2 from branch 'master' to b8b09233de0fddc9d89b7c2e84394a7767ee342d - tdf#139667 update help pages for List Style, Ordered and Unordered ( swriter/01/05130004.xhp ) "List Style" * modify description from 2004 about list styles ( shared/01/05040100.xhp ) "Organizer" + add that "Inherit From" cannot be used with list style and page style. ( shared/01/06050100.xhp ) "Bullets" * rename "Bullets" to "Unordered" * adjust to indicate Unordered list * replace "style" with "type" when referring to bullets * change "Options" to "Customize" in Related topics * update to ,, ( shared/01/06050200.xhp ) "Numbering Style" * rename "Numbering Style" to "Ordered" * small adjustment in description Change-Id: Iac5eab2de236c7457c7e849c0f6e475551fcea4d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110371 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index dc49a6fffb00..b8b09233de0f 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit dc49a6fffb002ab158b7052ab40048f0ddf7f54a +Subproject commit b8b09233de0fddc9d89b7c2e84394a7767ee342d ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/shared/01/05040100.xhp |3 +-- source/text/shared/01/06050100.xhp | 16 source/text/shared/01/06050200.xhp |6 +++--- source/text/swriter/01/05130004.xhp |2 +- 4 files changed, 13 insertions(+), 14 deletions(-) New commits: commit b8b09233de0fddc9d89b7c2e84394a7767ee342d Author: Seth Chaiklin AuthorDate: Fri Feb 5 02:58:59 2021 +0100 Commit: Olivier Hallot CommitDate: Thu Feb 11 14:03:30 2021 +0100 tdf#139667 update help pages for List Style, Ordered and Unordered ( swriter/01/05130004.xhp ) "List Style" * modify description from 2004 about list styles ( shared/01/05040100.xhp ) "Organizer" + add that "Inherit From" cannot be used with list style and page style. ( shared/01/06050100.xhp ) "Bullets" * rename "Bullets" to "Unordered" * adjust to indicate Unordered list * replace "style" with "type" when referring to bullets * change "Options" to "Customize" in Related topics * update to ,, ( shared/01/06050200.xhp ) "Numbering Style" * rename "Numbering Style" to "Ordered" * small adjustment in description Change-Id: Iac5eab2de236c7457c7e849c0f6e475551fcea4d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110371 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/shared/01/05040100.xhp b/source/text/shared/01/05040100.xhp index d74947fcc..9d6d75545 100644 --- a/source/text/shared/01/05040100.xhp +++ b/source/text/shared/01/05040100.xhp @@ -1,6 +1,5 @@ - - Organizer @@ -66,6 +64,7 @@ Inherit from Select an existing style (or - None -) to provide its definitions to the current style. Use the other tabs to modify the inherited style. + You cannot use this option with a page style or a list style. Edit Style Edit the properties of the parent style. diff --git a/source/text/shared/01/06050100.xhp b/source/text/shared/01/06050100.xhp index d75923434..d912826a4 100644 --- a/source/text/shared/01/06050100.xhp +++ b/source/text/shared/01/06050100.xhp @@ -1,6 +1,5 @@ -
[Libreoffice-commits] core.git: sw/source
sw/source/core/crsr/bookmrk.cxx | 12
sw/source/core/inc/bookmrk.hxx |2 --
sw/source/uibase/shells/textsh1.cxx |4
3 files changed, 18 deletions(-)
New commits:
commit 1e00ec5b5303bcf3eafd665106ba1e2c0ae8f791
Author: Tamás Zolnai
AuthorDate: Wed Feb 10 11:04:25 2021 +0100
Commit: Tamás Zolnai
CommitDate: Thu Feb 11 13:57:21 2021 +0100
Dropdown form field: don't increase code compexity for gen backend.
It's just an internal thing, we don't really need to
optimize the code for it. This HideButton() function is
not use anywhere else.
Change-Id: I2e5fff73f6d50a0dedbd8d5f7eea748d09de6330
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110709
Tested-by: Tamás Zolnai
Reviewed-by: Tamás Zolnai
(cherry picked from commit e8d1504ba7299d78dd825a512e8f04ef33900997)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110758
Tested-by: Jenkins
diff --git a/sw/source/core/crsr/bookmrk.cxx b/sw/source/core/crsr/bookmrk.cxx
index 167aaf37f625..5ea199607d5e 100644
--- a/sw/source/core/crsr/bookmrk.cxx
+++ b/sw/source/core/crsr/bookmrk.cxx
@@ -648,12 +648,6 @@ namespace sw::mark
m_pButton.disposeAndClear();
}
-void FieldmarkWithDropDownButton::HideButton()
-{
-if(m_pButton)
-m_pButton->Show(false);
-}
-
void FieldmarkWithDropDownButton::RemoveButton()
{
if(m_pButton)
@@ -682,12 +676,6 @@ namespace sw::mark
}
}
-void DropDownFieldmark::HideButton()
-{
-SendLOKMessage("hide");
-FieldmarkWithDropDownButton::HideButton();
-}
-
void DropDownFieldmark::RemoveButton()
{
SendLOKMessage("hide");
diff --git a/sw/source/core/inc/bookmrk.hxx b/sw/source/core/inc/bookmrk.hxx
index 63e05befe41b..272667432584 100644
--- a/sw/source/core/inc/bookmrk.hxx
+++ b/sw/source/core/inc/bookmrk.hxx
@@ -273,7 +273,6 @@ namespace sw::mark {
virtual ~FieldmarkWithDropDownButton() override;
virtual void ShowButton(SwEditWin* pEditWin) = 0;
-virtual void HideButton();
virtual void RemoveButton();
protected:
@@ -289,7 +288,6 @@ namespace sw::mark {
virtual ~DropDownFieldmark() override;
virtual void ShowButton(SwEditWin* pEditWin) override;
-virtual void HideButton() override;
virtual void RemoveButton() override;
// This method should be called only by the portion so we can now
the portion's painting area
diff --git a/sw/source/uibase/shells/textsh1.cxx
b/sw/source/uibase/shells/textsh1.cxx
index a65d7ccebf42..c191d4c90f86 100644
--- a/sw/source/uibase/shells/textsh1.cxx
+++ b/sw/source/uibase/shells/textsh1.cxx
@@ -1416,8 +1416,6 @@ void SwTextShell::Execute(SfxRequest )
pFieldBM->Invalidate();
rWrtSh.InvalidateWindows( rWrtSh.GetView().GetVisArea() );
rWrtSh.UpdateCursor(); // cursor position might be invalid
-// Hide the button here and make it visible later, to make
transparent background work with SAL_USE_VCLPLUGIN=gen
-
dynamic_cast<::sw::mark::DropDownFieldmark&>(*pFieldBM).HideButton();
}
}
else if ( pFieldBM && pFieldBM->GetFieldname() == ODF_FORMDATE )
@@ -1430,8 +1428,6 @@ void SwTextShell::Execute(SfxRequest )
rDateField.Invalidate();
rWrtSh.InvalidateWindows( rWrtSh.GetView().GetVisArea() );
rWrtSh.UpdateCursor(); // cursor position might be invalid
-// Hide the button here and make it visible later, to make
transparent background work with SAL_USE_VCLPLUGIN=gen
-rDateField.HideButton();
}
}
else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140262] Auto-hyphenation do not turns off
https://bugs.documentfoundation.org/show_bug.cgi?id=140262 --- Comment #1 from Noora --- I can not reproduce the bug in Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: e0843b1fe6e39d3e5f14c8f13476008f17c8ed2e CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_FI); UI: en-US However, in order to have all auto-hyphenation gone, the following steps need to be done: 1) Check auto-hyphenation off from "Styles-Edit style-Text Flow-Hyphenation-Automatically" AND 2) Check auto-hyphenation off from individual paragraphs through "Paragraph Style-Text Flow-Hyphenation-Automatically" "Tools-Options-Language settings-Writing Aids-Options-Hyphenate without incuiry" doesn't seem to influence the auto-hyphenation, only the selection in Styles-Edit style-Text flow and Paragrahp-Text flow seems to generate hyphenation in this context. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sc/source
sc/source/ui/inc/select.hxx |1 +
sc/source/ui/view/gridwin.cxx | 15 +++
sc/source/ui/view/select.cxx | 16 +---
3 files changed, 29 insertions(+), 3 deletions(-)
New commits:
commit 45fb849a44ca5be3f9dc1f9af5848279e02c77f5
Author: Pranam Lashkari
AuthorDate: Fri Jan 22 01:27:28 2021 +0530
Commit: Pranam Lashkari
CommitDate: Thu Feb 11 13:54:06 2021 +0100
prevent reference range resetting on panning in mobile
Change-Id: Ic6cabe1d4e5a1e7c4d42294550d654e38e27db22
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110461
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Pranam Lashkari
diff --git a/sc/source/ui/inc/select.hxx b/sc/source/ui/inc/select.hxx
index d3071f31e344..3e8be2ffa017 100644
--- a/sc/source/ui/inc/select.hxx
+++ b/sc/source/ui/inc/select.hxx
@@ -70,6 +70,7 @@ public:
virtual voidDeselectAll() override;
boolSetCursorAtCell( SCCOL nPosX, SCROW nPosY, bool bScroll );
+boolCheckRefBounds(SCCOL nPosX, SCROW nPosY);
};
class ScHeaderFunctionSet : public FunctionSet // Column / row headers
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 5a8bf3a1734f..c2a1a244f2e4 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -1418,6 +1418,21 @@ void ScGridWindow::LogicMouseMove(const MouseEvent&
rMouseEvent)
void ScGridWindow::MouseButtonDown( const MouseEvent& rMEvt )
{
+if (SfxLokHelper::getDeviceFormFactor() == LOKDeviceFormFactor::MOBILE)
+{
+ScViewFunc* pView = pViewData->GetView();
+ScTabViewShell* pViewShell = pViewData->GetViewShell();
+bool bRefMode = pViewShell && pViewShell->IsRefInputMode();
+
+Point aPos(rMEvt.GetPosPixel());
+SCCOL nPosX;
+SCROW nPosY;
+pViewData->GetPosFromPixel(aPos.X(), aPos.Y(), eWhich, nPosX, nPosY);
+
+if (bRefMode && pView->GetFunctionSet().CheckRefBounds(nPosX, nPosY))
+return;
+}
+
nNestedButtonState = ScNestedButtonState::Down;
MouseEventState aState;
diff --git a/sc/source/ui/view/select.cxx b/sc/source/ui/view/select.cxx
index b165234df5c2..99d8707bce75 100644
--- a/sc/source/ui/view/select.cxx
+++ b/sc/source/ui/view/select.cxx
@@ -417,6 +417,17 @@ void ScViewFunctionSet::SetCursorAtPoint( const Point&
rPointPixel, bool /* bDon
SetCursorAtCell( nPosX, nPosY, bScroll );
}
+bool ScViewFunctionSet::CheckRefBounds(SCCOL nPosX, SCROW nPosY)
+{
+SCCOL startX = pViewData->GetRefStartX();
+SCROW startY = pViewData->GetRefStartY();
+
+SCCOL endX = pViewData->GetRefEndX();
+SCROW endY = pViewData->GetRefEndY();
+
+return nPosX >= startX && nPosX <= endX && nPosY >= startY && nPosY <=
endY;
+}
+
bool ScViewFunctionSet::SetCursorAtCell( SCCOL nPosX, SCROW nPosY, bool
bScroll )
{
ScTabView* pView = pViewData->GetView();
@@ -468,7 +479,7 @@ bool ScViewFunctionSet::SetCursorAtCell( SCCOL nPosX, SCROW
nPosY, bool bScroll
if (bRefMode)
{
// if no input is possible from this doc, don't move the reference
cursor around
-if ( !pScMod->IsModalMode(pViewData->GetSfxDocShell()) )
+if ( !pScMod->IsModalMode(pViewData->GetSfxDocShell()) &&
(!CheckRefBounds(nPosX, nPosY) || SfxLokHelper::getDeviceFormFactor() !=
LOKDeviceFormFactor::MOBILE))
{
if (!bAnchor)
{
@@ -476,8 +487,7 @@ bool ScViewFunctionSet::SetCursorAtCell( SCCOL nPosX, SCROW
nPosY, bool bScroll
pView->InitRefMode( nPosX, nPosY, pViewData->GetTabNo(),
SC_REFTYPE_REF );
}
-if(SfxLokHelper::getDeviceFormFactor() !=
LOKDeviceFormFactor::MOBILE)
-pView->UpdateRef( nPosX, nPosY, pViewData->GetTabNo() );
+pView->UpdateRef( nPosX, nPosY, pViewData->GetTabNo() );
pView->SelectionChanged();
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sc/source
sc/source/ui/view/select.cxx |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit dbeab98b54b43756aefa06790e7ea890fa431c5a Author: Pranam Lashkari AuthorDate: Sat Jan 9 20:01:27 2021 +0530 Commit: Pranam Lashkari CommitDate: Thu Feb 11 13:53:31 2021 +0100 LOK: stop range selection with mouse/touch move in mobile Change-Id: I0a7b3a5fc89bcbced4acee18415308ed8aa57ba2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109035 Tested-by: Jenkins CollaboraOffice Reviewed-by: Szymon Kłos (cherry picked from commit 408e59359b5b67af119059a5d3f47bc807f81300) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109747 Reviewed-by: Pranam Lashkari diff --git a/sc/source/ui/view/select.cxx b/sc/source/ui/view/select.cxx index 0c4e171cd097..b165234df5c2 100644 --- a/sc/source/ui/view/select.cxx +++ b/sc/source/ui/view/select.cxx @@ -31,6 +31,7 @@ #include #include #include +#include #if defined(_WIN32) #define SC_SELENG_REFMODE_UPDATE_INTERVAL_MIN 65 @@ -475,7 +476,9 @@ bool ScViewFunctionSet::SetCursorAtCell( SCCOL nPosX, SCROW nPosY, bool bScroll pView->InitRefMode( nPosX, nPosY, pViewData->GetTabNo(), SC_REFTYPE_REF ); } -pView->UpdateRef( nPosX, nPosY, pViewData->GetTabNo() ); +if(SfxLokHelper::getDeviceFormFactor() != LOKDeviceFormFactor::MOBILE) +pView->UpdateRef( nPosX, nPosY, pViewData->GetTabNo() ); + pView->SelectionChanged(); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140335] pdf opened in Draw is messing with the text
https://bugs.documentfoundation.org/show_bug.cgi?id=140335 --- Comment #2 from notrealname --- Comment on attachment 169670 --> https://bugs.documentfoundation.org/attachment.cgi?id=169670 issue vs the pdf correct no pic -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140335] pdf opened in Draw is messing with the text
https://bugs.documentfoundation.org/show_bug.cgi?id=140335 --- Comment #1 from notrealname --- Created attachment 169670 --> https://bugs.documentfoundation.org/attachment.cgi?id=169670=edit issue vs the pdf correct -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134556] Show list style at the Styles Inspector
https://bugs.documentfoundation.org/show_bug.cgi?id=134556 sdc.bla...@youmail.dk changed: What|Removed |Added CC||sdc.bla...@youmail.dk --- Comment #1 from sdc.bla...@youmail.dk --- iiuc, list styles are shown presently in Paragraph DF section. Both predefined and custom list styles are shown. Is more needed? Two improvement suggestions though: 1. Show STR_POOLNUMRULE_BUL[1-5] names (same ones as in Sidebar) instead of "List 1", "List 2", etc. 2. Show a list item's "level" in SI ( - suspect it is missing at present because it is missing in general from paragraph dialog. - is visible in status bar ) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140336] Background color of frame off after export to DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=140336 Telesto changed: What|Removed |Added CC||libreoff...@nisz.hu Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140336] Background color of frame off after export to DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=140336 --- Comment #1 from Telesto --- Created attachment 169669 --> https://bugs.documentfoundation.org/attachment.cgi?id=169669=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140336] New: Background color of frame off after export to DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=140336 Bug ID: 140336 Summary: Background color of frame off after export to DOCX Product: LibreOffice Version: 4.4.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Background color of frame off after export Steps to Reproduce: 1. Open the attached file 2. Save as DOCX 3. File reload 4. Compare Actual Results: Text in dark red square Expected Results: Same as ODT Reproducible: Always User Profile Reset: No Additional Info: Found in Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 3ed9bba283a6a67864c0928186e277240be0d9ba CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL 4.4.7.2 white square in 4.3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140313] SELECTION: It's not visible, that a bullet at the beginning of the docment is selected
https://bugs.documentfoundation.org/show_bug.cgi?id=140313 Noora changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Noora --- I can confirm that the bug is present in Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: e0843b1fe6e39d3e5f14c8f13476008f17c8ed2e CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_FI); UI: en-US -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140335] New: pdf opened in Draw is messing with the text
https://bugs.documentfoundation.org/show_bug.cgi?id=140335 Bug ID: 140335 Summary: pdf opened in Draw is messing with the text Product: LibreOffice Version: unspecified Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: smurtaza...@outlook.com Description: When I open pdf it squeezes the text together Steps to Reproduce: 1. open a pdf in LibreOffice draw 2. the document would be malformed 3. e.g. the text would be squashed to gather Actual Results: The text was not in the correct place but on top of each other squished left to right. Expected Results: Text to open up normally in its positions not on top of each other. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: I have tested a copy of the file by changing its extension to odg from pdf, the text squishing and malformation remained the same. Then I changed the odg file to pdf and check it in multiple other pdf viewers and there was no error. so i have come the conclusion there is an issue with converting pdf to odg. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - vcl/source
vcl/source/window/seleng.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 7f832dbb5bc585acf5d1855cc5349599c077c7b5
Author: Caolán McNamara
AuthorDate: Tue Feb 9 16:50:22 2021 +
Commit: Pranam Lashkari
CommitDate: Thu Feb 11 13:21:18 2021 +0100
Revert "on SelMouseButtonDown check if window pointer is not null"
because there is no pWin for the cases where an EditEngine is
hosted in a native widget, e.g. comment in a sidebar in writer
or format header/footer in calc's format page, header/footer, edit...
and with change applied clicking doesn't move the cursor
This reverts commit 0a2fa32f8756b3c99975df6d98736a8e9abb625a.
Change-Id: Ie1da24d22b6d298f0c074f7bf187c5d891b78368
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110648
Reviewed-by: Pranam Lashkari
Tested-by: Jenkins
(cherry picked from commit 2d154d55db925dfa20358faa0302d4d942496aee)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110677
Tested-by: Jenkins CollaboraOffice
diff --git a/vcl/source/window/seleng.cxx b/vcl/source/window/seleng.cxx
index 85719192aedb..41d0d5f89ec9 100644
--- a/vcl/source/window/seleng.cxx
+++ b/vcl/source/window/seleng.cxx
@@ -115,7 +115,7 @@ void SelectionEngine::CursorPosChanging( bool bShift, bool
bMod1 )
bool SelectionEngine::SelMouseButtonDown( const MouseEvent& rMEvt )
{
nFlags &= ~SelectionEngineFlags::CMDEVT;
-if ( !pFunctionSet || rMEvt.GetClicks() > 1 || !pWin )
+if ( !pFunctionSet || rMEvt.GetClicks() > 1 )
return false;
sal_uInt16 nModifier = rMEvt.GetModifier() | nLockedMods;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 139863] Grantha consonants combining with Vedic svara markers are not displayed correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=139863 --- Comment #3 from Shriramana Sharma --- Just wanted to note that this bug persists in latest LibO 7.1.0.3, and that the relevant characters are present in the font files linked above. Elsewhere I have noted problems when glyphs for combining marks are *not* present in the same font, but this is happening despite the glyphs being present. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134339] Export to pdf creates big bloated file
https://bugs.documentfoundation.org/show_bug.cgi?id=134339 --- Comment #14 from Hugh Craddock --- (In reply to Alex Thurgood from comment #13) > (In reply to Alex Thurgood from comment #12) Hi Alex, yes there may be an overlap with bug 119634. I had a good look round before posting the original report, but this one escaped me. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101217] Setting the column width and height should not round the values causing compounding errors
https://bugs.documentfoundation.org/show_bug.cgi?id=101217 --- Comment #16 from Regina Henschel --- (In reply to Heiko Tietze from comment #15) > (In reply to Regina Henschel from comment #14) > > I agree, that the input fields in the column size dialog should have more > > decimal places, so that it is possible to enter n/8 values. > > Would another decimal point in the UI solve the Twips problem? Not the Twips problem, but the original reported problem. Especially in an environment with US measurement system, you need at least 4 decimals. I personally see no need to restrict the column width input field at all. Currently I workaround the problem in using Millimeter as unit. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 101217] Setting the column width and height should not round the values causing compounding errors
https://bugs.documentfoundation.org/show_bug.cgi?id=101217 --- Comment #16 from Regina Henschel --- (In reply to Heiko Tietze from comment #15) > (In reply to Regina Henschel from comment #14) > > I agree, that the input fields in the column size dialog should have more > > decimal places, so that it is possible to enter n/8 values. > > Would another decimal point in the UI solve the Twips problem? Not the Twips problem, but the original reported problem. Especially in an environment with US measurement system, you need at least 4 decimals. I personally see no need to restrict the column width input field at all. Currently I workaround the problem in using Millimeter as unit. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 135039] Freeze pasting with track changes enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=135039 Telesto changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #9 from Telesto --- Still present for me Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 3ed9bba283a6a67864c0928186e277240be0d9ba CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL Show changes ON at paste [did try without]. Paste goes, fine but slightly scroll up.. and ... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134656] Animating text box requires quite some CPU time on MacOS
https://bugs.documentfoundation.org/show_bug.cgi?id=134656 Telesto changed: What|Removed |Added Resolution|--- |WORKSFORME Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140334] Failing widow control in footnotes
https://bugs.documentfoundation.org/show_bug.cgi?id=140334 Telesto changed: What|Removed |Added CC||jl...@mail.com, ||libreoff...@nisz.hu --- Comment #4 from Telesto --- A poke for analysis.. if this 'by design' or some flaw. Touching probably something else, footnotes as such kind of 'error prone' area. So changes will introduce new bugs and/or unmask whole bunch of issues hidden somewhere, being my estimate. JMUX should have some practical experience in this corner of the code -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/sfx2 sfx2/Library_sfx.mk sfx2/source
include/sfx2/devtools/DevelopmentToolDockingWindow.hxx |6
include/sfx2/devtools/ObjectInspectorTreeHandler.hxx | 44 +
sfx2/Library_sfx.mk|1
sfx2/source/devtools/DevelopmentToolDockingWindow.cxx | 501
sfx2/source/devtools/ObjectInspectorTreeHandler.cxx| 503 +
5 files changed, 557 insertions(+), 498 deletions(-)
New commits:
commit e44639f50056b843913573b4635517019e00431c
Author: Tomaž Vajngerl
AuthorDate: Mon Feb 8 22:41:36 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Thu Feb 11 12:54:47 2021 +0100
devtools: move handling of object inspector tree to own class/files
To make handling of object inspector tree view easier, move the
functionality to its own class and file.
Change-Id: I47ae1bc06b582d0d146e7e97bc08a3b5f82ce794
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110734
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/sfx2/devtools/DevelopmentToolDockingWindow.hxx
b/include/sfx2/devtools/DevelopmentToolDockingWindow.hxx
index 1ed166239949..4721a424e66d 100644
--- a/include/sfx2/devtools/DevelopmentToolDockingWindow.hxx
+++ b/include/sfx2/devtools/DevelopmentToolDockingWindow.hxx
@@ -16,6 +16,7 @@
#include
#include
+#include
#include
#include
@@ -37,18 +38,15 @@ private:
css::uno::Reference
mxSelectionListener;
DocumentModelTreeHandler maDocumentModelTreeHandler;
+ObjectInspectorTreeHandler maObjectInspectorTreeHandler;
DECL_LINK(DocumentModelTreeViewSelectionHandler, weld::TreeView&, void);
DECL_LINK(SelectionToggled, weld::ToggleButton&, void);
-DECL_LINK(ObjectInspectorExpandingHandler, const weld::TreeIter&, bool);
-
void inspectDocument();
void updateSelection();
void inspectSelectionOrRoot(css::uno::Reference
const& xController);
-void clearObjectInspectorChildren(weld::TreeIter const& rParent);
-
public:
DevelopmentToolDockingWindow(SfxBindings* pBindings, SfxChildWindow*
pChildWindow,
vcl::Window* pParent);
diff --git a/include/sfx2/devtools/ObjectInspectorTreeHandler.hxx
b/include/sfx2/devtools/ObjectInspectorTreeHandler.hxx
new file mode 100644
index ..aa6e353e6549
--- /dev/null
+++ b/include/sfx2/devtools/ObjectInspectorTreeHandler.hxx
@@ -0,0 +1,44 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#pragma once
+
+#include
+#include
+
+#include
+#include
+
+class ObjectInspectorTreeHandler
+{
+private:
+std::unique_ptr& mpObjectInspectorTree;
+std::unique_ptr& mpClassNameLabel;
+
+void clearObjectInspectorChildren(weld::TreeIter const& rParent);
+
+public:
+ObjectInspectorTreeHandler(std::unique_ptr&
pObjectInspectorTree,
+ std::unique_ptr& pClassNameLabel)
+: mpObjectInspectorTree(pObjectInspectorTree)
+, mpClassNameLabel(pClassNameLabel)
+{
+mpObjectInspectorTree->connect_expanding(
+LINK(this, ObjectInspectorTreeHandler, ExpandingHandler));
+}
+
+DECL_LINK(ExpandingHandler, const weld::TreeIter&, bool);
+
+void introspect(css::uno::Reference const&
xInterface);
+
+void dispose();
+};
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sfx2/Library_sfx.mk b/sfx2/Library_sfx.mk
index 52ace3c503fe..b5126ca87893 100644
--- a/sfx2/Library_sfx.mk
+++ b/sfx2/Library_sfx.mk
@@ -165,6 +165,7 @@ $(eval $(call gb_Library_add_exception_objects,sfx,\
sfx2/source/devtools/DevelopmentToolChildWindow \
sfx2/source/devtools/DevelopmentToolDockingWindow \
sfx2/source/devtools/DocumentModelTreeHandler \
+sfx2/source/devtools/ObjectInspectorTreeHandler \
sfx2/source/dialog/alienwarn \
sfx2/source/dialog/backingcomp \
sfx2/source/dialog/backingwindow \
diff --git a/sfx2/source/devtools/DevelopmentToolDockingWindow.cxx
b/sfx2/source/devtools/DevelopmentToolDockingWindow.cxx
index 89f9e878d69b..0d335b5118cc 100644
--- a/sfx2/source/devtools/DevelopmentToolDockingWindow.cxx
+++ b/sfx2/source/devtools/DevelopmentToolDockingWindow.cxx
@@ -12,433 +12,16 @@
#include
-#include
-#include
-
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-
-#include
-#include
-#include
-
-#include
-#include
-
#include
-#include
-
#include
-#include
-
#include
-
#include
-#include
-#include
-
#include "SelectionChangeHandler.hxx"
using namespace css;
-namespace
-{
-uno::Reference
-TypeToIdlClass(const uno::Type& rType, const
uno::Reference& xContext)
-{
-auto xReflection = reflection::theCoreReflection::get(xContext);
[Libreoffice-bugs] [Bug 140334] Failing widow control in footnotes
https://bugs.documentfoundation.org/show_bug.cgi?id=140334 Telesto changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Version|unspecified |Inherited From OOo --- Comment #3 from Telesto --- Created attachment 169665 [details] Example file 1. Open the attached file 2. Go to footnote 2 3. Increase Widow Control .. Widow control Specifies the minimum number of lines in a paragraph in the first page after the break. Select this check box, and then enter a number in the Lines box. If the number of lines at the top of the page is less than the amount specified in the Lines box, the position of the break is adjusted. Except 'top of the page' in this case top of footnote; apparently never worked LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/sfx2 include/svx sc/source sd/inc sd/source sfx2/Library_sfx.mk sfx2/source sfx2/uiconfig sfx2/UIConfig_sfx.mk svx/Library_svx.mk svx/source svx/uiconfig svx/UI
include/sfx2/devtools/DevelopmentToolChildWindow.hxx|4 ++--
include/sfx2/devtools/DevelopmentToolDockingWindow.hxx |8
include/sfx2/devtools/DocumentModelTreeHandler.hxx |2 +-
sc/source/ui/app/scdll.cxx |2 +-
sc/source/ui/view/tabvwsh.cxx |2 +-
sd/inc/pch/precompiled_sd.hxx |5 +++--
sd/source/ui/app/sddll.cxx |2 +-
sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx |2 +-
sd/source/ui/view/drvwshrg.cxx |2 +-
sd/source/ui/view/outlnvsh.cxx |2 +-
sfx2/Library_sfx.mk |3 +++
sfx2/UIConfig_sfx.mk|1 +
sfx2/source/devtools/DevelopmentToolChildWindow.cxx |7 +++
sfx2/source/devtools/DevelopmentToolDockingWindow.cxx |5 ++---
sfx2/source/devtools/DocumentModelTreeHandler.cxx |2 +-
sfx2/source/devtools/SelectionChangeHandler.hxx |2 +-
svx/Library_svx.mk |3 ---
svx/UIConfig_svx.mk |1 -
sw/source/uibase/app/swmodule.cxx |2 +-
sw/source/uibase/shells/basesh.cxx |2 +-
20 files changed, 29 insertions(+), 30 deletions(-)
New commits:
commit a1ca311061b617b2e4731f6e4c8a5466e8a080f5
Author: Tomaž Vajngerl
AuthorDate: Mon Feb 8 17:11:17 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Thu Feb 11 12:54:10 2021 +0100
devtools: move devtools from svx to sfx2
It's a better suited location for devtools as we can access the
classes when we handle the .uno:DevelopmentToolsDockingWindow
event.
Change-Id: I753ca56808804c9cf6713920f92cd7d313f1f156
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110733
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/svx/devtools/DevelopmentToolChildWindow.hxx
b/include/sfx2/devtools/DevelopmentToolChildWindow.hxx
similarity index 84%
rename from include/svx/devtools/DevelopmentToolChildWindow.hxx
rename to include/sfx2/devtools/DevelopmentToolChildWindow.hxx
index 34849da762e0..adf5adf44980 100644
--- a/include/svx/devtools/DevelopmentToolChildWindow.hxx
+++ b/include/sfx2/devtools/DevelopmentToolChildWindow.hxx
@@ -10,10 +10,10 @@
#pragma once
-#include
+#include
#include
-class SAL_WARN_UNUSED SVX_DLLPUBLIC DevelopmentToolChildWindow final : public
SfxChildWindow
+class SAL_WARN_UNUSED SFX2_DLLPUBLIC DevelopmentToolChildWindow final : public
SfxChildWindow
{
SFX_DECL_CHILDWINDOW_WITHID(DevelopmentToolChildWindow);
diff --git a/include/svx/devtools/DevelopmentToolDockingWindow.hxx
b/include/sfx2/devtools/DevelopmentToolDockingWindow.hxx
similarity index 92%
rename from include/svx/devtools/DevelopmentToolDockingWindow.hxx
rename to include/sfx2/devtools/DevelopmentToolDockingWindow.hxx
index cdb20c081ba4..1ed166239949 100644
--- a/include/svx/devtools/DevelopmentToolDockingWindow.hxx
+++ b/include/sfx2/devtools/DevelopmentToolDockingWindow.hxx
@@ -10,21 +10,21 @@
#pragma once
-#include
+#include
#include
#include
#include
+#include
+
#include
#include
#include
#include
-#include
-
#include
-class SVX_DLLPUBLIC DevelopmentToolDockingWindow final : public
SfxDockingWindow
+class SFX2_DLLPUBLIC DevelopmentToolDockingWindow final : public
SfxDockingWindow
{
private:
std::unique_ptr mpClassNameLabel;
diff --git a/include/svx/devtools/DocumentModelTreeHandler.hxx
b/include/sfx2/devtools/DocumentModelTreeHandler.hxx
similarity index 98%
rename from include/svx/devtools/DocumentModelTreeHandler.hxx
rename to include/sfx2/devtools/DocumentModelTreeHandler.hxx
index fad725726cfb..5b752b172b4e 100644
--- a/include/svx/devtools/DocumentModelTreeHandler.hxx
+++ b/include/sfx2/devtools/DocumentModelTreeHandler.hxx
@@ -10,7 +10,7 @@
#pragma once
-#include
+#include
#include
#include
diff --git a/sc/source/ui/app/scdll.cxx b/sc/source/ui/app/scdll.cxx
index 2749a46d1af9..56d5e106e042 100644
--- a/sc/source/ui/app/scdll.cxx
+++ b/sc/source/ui/app/scdll.cxx
@@ -25,7 +25,7 @@
#include
#include
#include
-#include
+#include
#include
#include
diff --git a/sc/source/ui/view/tabvwsh.cxx b/sc/source/ui/view/tabvwsh.cxx
index e67c7e27b52a..fdad3b66af33 100644
--- a/sc/source/ui/view/tabvwsh.cxx
+++ b/sc/source/ui/view/tabvwsh.cxx
@@ -23,7 +23,7 @@
#include
#include
#include
-#include
+#include
#include
#include
diff --git a/sd/inc/pch/precompiled_sd.hxx b/sd/inc/pch/precompiled_sd.hxx
index a4257ad31a82..bd3957cf2ca7 100644
--- a/sd/inc/pch/precompiled_sd.hxx
+++ b/sd/inc/pch/precompiled_sd.hxx
@@ -13,7 +13,7 @@
manual changes will be rewritten by the next run of update_pch.sh (which
presumably
also fixes all possible problems, so it's usually better to use
[Libreoffice-commits] core.git: include/svx svx/source
include/svx/devtools/DevelopmentToolDockingWindow.hxx |2 +
svx/source/devtools/DevelopmentToolDockingWindow.cxx | 29 --
2 files changed, 28 insertions(+), 3 deletions(-)
New commits:
commit 9afdfc80a39f85b440bf753daa52832532ee1e8c
Author: Tomaž Vajngerl
AuthorDate: Mon Feb 8 11:49:03 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Thu Feb 11 12:53:48 2021 +0100
devtools: inspect selected object when DevTools are started
When DevTools window is started, we check if there is a selected
object and inspect that one automatically, else use the root
document object.
Change-Id: I1b8b5031c4ac67300bcc15d176b86bac0a4c5d4f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110732
Tested-by: Tomaž Vajngerl
Reviewed-by: Tomaž Vajngerl
diff --git a/include/svx/devtools/DevelopmentToolDockingWindow.hxx
b/include/svx/devtools/DevelopmentToolDockingWindow.hxx
index b6fe26e67ea4..cdb20c081ba4 100644
--- a/include/svx/devtools/DevelopmentToolDockingWindow.hxx
+++ b/include/svx/devtools/DevelopmentToolDockingWindow.hxx
@@ -18,6 +18,7 @@
#include
#include
#include
+#include
#include
@@ -44,6 +45,7 @@ private:
void inspectDocument();
void updateSelection();
+void inspectSelectionOrRoot(css::uno::Reference
const& xController);
void clearObjectInspectorChildren(weld::TreeIter const& rParent);
diff --git a/svx/source/devtools/DevelopmentToolDockingWindow.cxx
b/svx/source/devtools/DevelopmentToolDockingWindow.cxx
index 1ab3ab997808..bcb554a2668e 100644
--- a/svx/source/devtools/DevelopmentToolDockingWindow.cxx
+++ b/svx/source/devtools/DevelopmentToolDockingWindow.cxx
@@ -30,6 +30,8 @@
#include
#include
+#include
+
#include
#include
@@ -40,8 +42,6 @@
#include
-#include
-
#include
#include
@@ -465,9 +465,32 @@
DevelopmentToolDockingWindow::DevelopmentToolDockingWindow(SfxBindings* pInputBi
mxRoot =
pInputBindings->GetDispatcher()->GetFrame()->GetObjectShell()->GetBaseModel();
-introspect(mxRoot);
maDocumentModelTreeHandler.inspectDocument();
mxSelectionListener.set(new SelectionChangeHandler(xController, this));
+
+inspectSelectionOrRoot(xController);
+}
+
+void DevelopmentToolDockingWindow::inspectSelectionOrRoot(
+uno::Reference const& xController)
+{
+css::uno::Reference xSupplier(xController,
css::uno::UNO_QUERY);
+if (xSupplier.is())
+{
+css::uno::Any aAny = xSupplier->getSelection();
+if (aAny.hasValue())
+{
+auto xInterface =
aAny.get>();
+if (xInterface.is())
+{
+introspect(xInterface);
+mpSelectionToggle->set_state(TRISTATE_TRUE);
+return;
+}
+}
+}
+mpSelectionToggle->set_state(TRISTATE_FALSE);
+introspect(mxRoot);
}
IMPL_LINK(DevelopmentToolDockingWindow, DocumentModelTreeViewSelectionHandler,
weld::TreeView&,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140322] Calc subtotals: can't only show the last line (grand sum)
https://bugs.documentfoundation.org/show_bug.cgi?id=140322 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g --- Comment #1 from BogdanB --- Created attachment 169668 --> https://bugs.documentfoundation.org/attachment.cgi?id=169668=edit working I tested on Version: 7.1.0.3 (x64) / LibreOffice Community Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: ro-RO (ro_RO); UI: en-US Calc: threaded and this is how it looks. It's ok like that? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140334] Failing widow control in footnotes
https://bugs.documentfoundation.org/show_bug.cgi?id=140334 --- Comment #2 from BogdanB --- *** Bug 140320 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140320] Failing orphan control in footnotes
https://bugs.documentfoundation.org/show_bug.cgi?id=140320 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #4 from BogdanB --- *** This bug has been marked as a duplicate of bug 140334 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140334] Failing widow control in footnotes
https://bugs.documentfoundation.org/show_bug.cgi?id=140334 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g --- Comment #1 from BogdanB --- Confirm with Version: 7.1.0.3 (x64) / LibreOffice Community Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: ro-RO (ro_RO); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/control/tabctrl.cxx |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
New commits:
commit 6f7e48c00fc879158576c36c4bfcfdc0440f201d
Author: Caolán McNamara
AuthorDate: Thu Feb 11 10:19:01 2021 +
Commit: Caolán McNamara
CommitDate: Thu Feb 11 12:40:20 2021 +0100
Related: tdf#139667 allow TabControl tabs to always show tooltips
If one is set, then just show it. The removed restrictions seem to have
been added in...
commit 85702858a81c72b40f0e7e3ce05e677ffb996da9
Date: Tue Dec 16 16:42:03 2008 +
CWS-TOOLING: integrate CWS alf01
fix: #158798# show tooltip if only a image is shown
where #158798# is old private bugtracker
and referenced public #i95201# add: images for tab items
has no mention of the restrictions
Change-Id: Ia11952700fb212397bf0c0228666a1545817ce8d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110757
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/source/control/tabctrl.cxx b/vcl/source/control/tabctrl.cxx
index c4cb34ef5fae..571926faaca2 100644
--- a/vcl/source/control/tabctrl.cxx
+++ b/vcl/source/control/tabctrl.cxx
@@ -1415,8 +1415,7 @@ void TabControl::RequestHelp( const HelpEvent& rHEvt )
{
ImplTabItem* pItem = ImplGetItem( nItemId );
const OUString& rHelpText = pItem->maHelpText;
-// show tooltip if not text but image is set and helptext is
available
-if ( !rHelpText.isEmpty() && pItem->maText.isEmpty() &&
!!pItem->maTabImage )
+if (!rHelpText.isEmpty())
{
tools::Rectangle aItemRect = ImplGetTabRect( GetPagePos(
nItemId ) );
Point aPt = OutputToScreenPixel( aItemRect.TopLeft() );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/vcl
include/vcl/tabctrl.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 50568dab5baf0df31effbd39d73948b37fe64c1a Author: Caolán McNamara AuthorDate: Wed Feb 10 20:54:27 2021 + Commit: Caolán McNamara CommitDate: Thu Feb 11 12:39:44 2021 +0100 default args for ImplGetTabRect variant are a hazard as it won't do anything with those defaults Change-Id: I7b21bc09a28d40c4c643770872571f9caef4d615 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110729 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/include/vcl/tabctrl.hxx b/include/vcl/tabctrl.hxx index b113450fd90e..38a26e0680a4 100644 --- a/include/vcl/tabctrl.hxx +++ b/include/vcl/tabctrl.hxx @@ -69,7 +69,7 @@ protected: SAL_DLLPRIVATE ImplTabItem* ImplGetItem(const Point& rPt) const; SAL_DLLPRIVATE Size ImplGetItemSize( ImplTabItem* pItem, tools::Long nMaxWidth ); SAL_DLLPRIVATE tools::RectangleImplGetTabRect( sal_uInt16 nPos, tools::Long nWidth = -1, tools::Long nHeight = -1 ); -SAL_DLLPRIVATE tools::Rectangle ImplGetTabRect(const ImplTabItem*, tools::Long nWidth = -1, tools::Long nHeight = -1); +SAL_DLLPRIVATE tools::Rectangle ImplGetTabRect(const ImplTabItem*, tools::Long nWidth, tools::Long nHeight); SAL_DLLPRIVATE void ImplChangeTabPage( sal_uInt16 nId, sal_uInt16 nOldId ); SAL_DLLPRIVATE bool ImplPosCurTabPage(); virtual voidImplActivateTabPage( bool bNext ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/control/tabctrl.cxx |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
New commits:
commit bd5eedd14069fa859bad25d4e126c244074d5f94
Author: Caolán McNamara
AuthorDate: Wed Feb 10 20:37:41 2021 +
Commit: Caolán McNamara
CommitDate: Thu Feb 11 12:38:34 2021 +0100
ImplGetTabRect(ImplTabItem*) variant always returns 0 with default args
so TabControl::GetPageId(const Point& rPos) doesn't work
since...
commit 6540912ae1a570fd8c2318f77b757e07b87c0707
Date: Sun Jun 16 21:41:31 2019 +
VCL merge most of NotebookbarTabControlBase
Change-Id: Ia99911e753dbe2bb22dc892c6bddc0392fab97a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110728
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/source/control/tabctrl.cxx b/vcl/source/control/tabctrl.cxx
index 6579613dbd62..c4cb34ef5fae 100644
--- a/vcl/source/control/tabctrl.cxx
+++ b/vcl/source/control/tabctrl.cxx
@@ -1787,9 +1787,10 @@ sal_uInt16 TabControl::GetPagePos( sal_uInt16 nPageId )
const
sal_uInt16 TabControl::GetPageId( const Point& rPos ) const
{
+Size winSize = Control::GetOutputSizePixel();
const auto = mpTabCtrlData->maItemList;
-const auto it = std::find_if(rList.begin(), rList.end(), [,
this](const auto ) {
-return
const_cast(this)->ImplGetTabRect().IsInside(rPos); });
+const auto it = std::find_if(rList.begin(), rList.end(), [, ,
this](const auto ) {
+return const_cast(this)->ImplGetTabRect(,
winSize.Width(), winSize.Height()).IsInside(rPos); });
return (it != rList.end()) ? it->id() : 0;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 88803] Introduce Web View mode to make text reflow on zoom
https://bugs.documentfoundation.org/show_bug.cgi?id=88803 --- Comment #10 from Tomaz Vajngerl --- I have ages ago "proselytized" that the web view can be converted to a re-flow view in Writer (mostly when people wanted to throw all the web stuff out of LO), which has very useful for e-documents (e-books) where you can re-flow the text to adapt to the current viewing device. I think this would be great for mobile devices. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140308] Crash import old OpenOffice template (stw, stc, sti, std)
https://bugs.documentfoundation.org/show_bug.cgi?id=140308 Regina Henschel changed: What|Removed |Added Summary|Crash import old OpenOffice |Crash import old OpenOffice |template (std) |template (stw, stc, sti, ||std) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138482] CRASH: deleting content from document
https://bugs.documentfoundation.org/show_bug.cgi?id=138482 Buovjaga changed: What|Removed |Added Status|NEW |RESOLVED CC||ilmari.lauhakangas@libreoff ||ice.org Resolution|--- |DUPLICATE --- Comment #7 from Buovjaga --- I tested this and noticed the crash was gone. I bisected the fix with linux-64-7.2 to: https://git.libreoffice.org/core/commit/eef10be20a4c5108c68b19ccdda263c5ca852386 *** This bug has been marked as a duplicate of bug 135014 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105537] [META] Assertion failed crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=105537 Bug 105537 depends on bug 123134, which changed state. Bug 123134 Summary: Failed assert( xImpBmp && "Forbidden Access to empty bitmap!" ) in "3D Effects" dialog https://bugs.documentfoundation.org/show_bug.cgi?id=123134 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123134] Failed assert( xImpBmp && "Forbidden Access to empty bitmap!" ) in "3D Effects" dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=123134 Regina Henschel changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEEDINFO|RESOLVED --- Comment #4 from Regina Henschel --- It is OK now in Version: 7.1.0.3 (x64) / LibreOffice Community Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win Locale: de-DE (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101217] Setting the column width and height should not round the values causing compounding errors
https://bugs.documentfoundation.org/show_bug.cgi?id=101217 Heiko Tietze changed: What|Removed |Added Severity|minor |enhancement --- Comment #15 from Heiko Tietze --- (In reply to Regina Henschel from comment #14) > I agree, that the input fields in the column size dialog should have more > decimal places, so that it is possible to enter n/8 values. Would another decimal point in the UI solve the Twips problem? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 101217] Setting the column width and height should not round the values causing compounding errors
https://bugs.documentfoundation.org/show_bug.cgi?id=101217 Heiko Tietze changed: What|Removed |Added Severity|minor |enhancement --- Comment #15 from Heiko Tietze --- (In reply to Regina Henschel from comment #14) > I agree, that the input fields in the column size dialog should have more > decimal places, so that it is possible to enter n/8 values. Would another decimal point in the UI solve the Twips problem? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 140327] Please add an option for deletions to disappear in Track Changes mode rather than be replaced by a strikethrough
https://bugs.documentfoundation.org/show_bug.cgi?id=140327 Timur changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Timur --- You reported against previous LO, likely without previous search, which is also waste of time. You should test daily master, there were changes. Can this be a duplicate of Bug 34355 - Option to show track changes in margin? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125539] Text box to small within Impress' slide sorter toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=125539 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu --- Comment #6 from Aron Budea --- At least in Linux this has been fixed since 7.0, Thorsten, is it still a problem in Mac? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107334] [META] Chart wizard dialog issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107334 Bug 107334 depends on bug 42191, which changed state. Bug 42191 Summary: Add option to Chart wizard to treat cell content as text in column captions https://bugs.documentfoundation.org/show_bug.cgi?id=42191 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42191] Add option to Chart wizard to treat cell content as text in column captions
https://bugs.documentfoundation.org/show_bug.cgi?id=42191 Heiko Tietze changed: What|Removed |Added Status|NEW |RESOLVED Severity|enhancement |normal Resolution|--- |NOTABUG --- Comment #10 from Heiko Tietze --- Don't see any ambiguity here. If cells are text, the chart will use sequential numbers for the axis. Date is a representation of a number and large steps between produce gaps. => NAB -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 42191] Add option to Chart wizard to treat cell content as text in column captions
https://bugs.documentfoundation.org/show_bug.cgi?id=42191 Heiko Tietze changed: What|Removed |Added Status|NEW |RESOLVED Severity|enhancement |normal Resolution|--- |NOTABUG --- Comment #10 from Heiko Tietze --- Don't see any ambiguity here. If cells are text, the chart will use sequential numbers for the axis. Date is a representation of a number and large steps between produce gaps. => NAB -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 140320] Failing orphan control in footnotes
https://bugs.documentfoundation.org/show_bug.cgi?id=140320 --- Comment #3 from Butch --- SORRY FOR THE CONFUSION, the correct term is WIDOW, not orphan. @ Moderator: Could you please remove this report or move it to the new report Bug 140334 already created -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140334] New: Failing widow control in footnotes
https://bugs.documentfoundation.org/show_bug.cgi?id=140334 Bug ID: 140334 Summary: Failing widow control in footnotes Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lo...@skofic.eu Created attachment 169667 --> https://bugs.documentfoundation.org/attachment.cgi?id=169667=edit WidowControlFootnotes There is an old bug report marked RESOLVED, https://bugs.documentfoundation.org/show_bug.cgi?id=35285, but the discussioon there seems to be somehow intransparent, and I also can't find a solution there. So I'll try again, using a simple example file: The problem ist the failing widow control in footnotes: It often happens that only one line of the footnote is wrapped to the next page, although the widow setting (2 lines) is activated for the footnote and therefore two last lines should be wrapped. It should be the case that the problem basically only occurs with a footnote, inserted in the very last line. (Thanks to mikeleb, https://de.openoffice.info/viewtopic.php?f=1=75294, for the demo file.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: oox/source
oox/source/export/drawingml.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit aab2968434e4413565397692b74169a128117de8
Author: Andrea Gelmini
AuthorDate: Wed Feb 10 23:38:25 2021 +0100
Commit: Gülşah Köse
CommitDate: Thu Feb 11 12:07:11 2021 +0100
Fix typo
Change-Id: Ie307727fdbc5c748c2ef249f10012a7b81c6803b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110731
Tested-by: Jenkins
Reviewed-by: Gülşah Köse
diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index 7f7e6ec3525f..86c57f86acc1 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -1618,7 +1618,7 @@ void
DrawingML::WriteGraphicCropProperties(uno::Reference c
if(GetProperty(rXPropSet, "CustomShapeGeometry"))
{
// tdf#134210 GraphicCrop property is handled in import filter because of
LibreOffice has not core
-// feature. We croped the bitmap physically and MSO shouldn't crop bitmap
one more time. When we
+// feature. We cropped the bitmap physically and MSO shouldn't crop bitmap
one more time. When we
// have core feature for graphic cropping in custom shapes, we should
uncomment the code anymore.
mpFS->singleElementNS( XML_a, XML_srcRect);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140333] New: Automatic correction problem
https://bugs.documentfoundation.org/show_bug.cgi?id=140333 Bug ID: 140333 Summary: Automatic correction problem Product: LibreOffice Version: 5.4 all versions Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: reali...@gmail.com Description: Hello, I have a problem with the autocorrect feature of calc. How to reproduce the problem: - Open Calc in French language - If you write _2 in cell and press Enter, the 2 becomes very small (autocorrection, it's normal) - In Utils>Autocorrection you delete the entry _2:2 - Try again, it will continue to autocorrect although the entry is deleted This problem doesn't appear with version 4.2. Thanks, Steps to Reproduce: - Open Calc in French language - If you write _2 in cell and press Enter, the 2 becomes very small (autocorrection, it's normal) - In Utils>Autocorrection you delete the entry _2:2 - Try again, it will continue to autocorrect although the entry is deleted Actual Results: The 2 is autocorrected Expected Results: The 2 shouldn't be autocorrected Reproducible: Always User Profile Reset: No Additional Info: . -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa
sc/qa/uitest/conditional_format/tdf104026.py | 48 +++
sc/qa/uitest/data/tdf104026.ods |binary
2 files changed, 48 insertions(+)
New commits:
commit a7c41f93421ddb2b48e38960b669c4e4f5413efb
Author: Xisco Fauli
AuthorDate: Thu Feb 11 10:07:09 2021 +0100
Commit: Xisco Fauli
CommitDate: Thu Feb 11 12:03:58 2021 +0100
tdf#104026: sc: Add UItest
Change-Id: Id423fd75de75a70a7bd48e6104d870b63d2c744e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110753
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/uitest/conditional_format/tdf104026.py
b/sc/qa/uitest/conditional_format/tdf104026.py
new file mode 100644
index ..5aa6a1ff8b6f
--- /dev/null
+++ b/sc/qa/uitest/conditional_format/tdf104026.py
@@ -0,0 +1,48 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+from uitest.framework import UITestCase
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.uihelper.common import get_state_as_dict, get_url_for_data_file
+
+class Tdf104026(UITestCase):
+
+ def execute_conditional_format_manager_dialog(self, nCount):
+
+
self.ui_test.execute_dialog_through_command(".uno:ConditionalFormatManagerDialog")
+xCondFormatMgr = self.xUITest.getTopFocusWindow()
+
+aExpectedResults = ['A2\tCell value != $Sheet1.$B2', 'A3\tCell value !=
$Sheet1.$B3',
+'A4\tCell value != $Sheet1.$B4', 'A5\tCell value != $Sheet1.$B5',
+'A6\tCell value != $Sheet1.$B6', 'A7\tCell value != $Sheet1.$B7']
+
+xList = xCondFormatMgr.getChild("CONTAINER")
+self.assertEqual(nCount, len(xList.getChildren()))
+
+for i in range(nCount):
+self.assertEqual(aExpectedResults[i],
get_state_as_dict(xList.getChild(str(i)))['Text'])
+
+xOKBtn = xCondFormatMgr.getChild("ok")
+self.ui_test.close_dialog_through_button(xOKBtn)
+
+ def test_tdf104026(self):
+self.ui_test.load_file(get_url_for_data_file("tdf104026.ods"))
+
+self.execute_conditional_format_manager_dialog(6)
+
+xCalcDoc = self.xUITest.getTopFocusWindow()
+gridwin = xCalcDoc.getChild("grid_window")
+gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "A2"}))
+
+self.xUITest.executeCommand(".uno:DeleteRows")
+
+# Without the fix in place, this test would have failed with
+# AssertionError: 'A2\tCell value != $Sheet1.$B2' != 'A2\tCell value !=
$Sheet1.$B#REF!'
+self.execute_conditional_format_manager_dialog(5)
+
+self.ui_test.close_doc()
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/sc/qa/uitest/data/tdf104026.ods b/sc/qa/uitest/data/tdf104026.ods
new file mode 100644
index ..3d6611fb753c
Binary files /dev/null and b/sc/qa/uitest/data/tdf104026.ods differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sfx2/CppunitTest_sfx2_doc.mk sfx2/Module_sfx2.mk sfx2/qa sfx2/source
sfx2/CppunitTest_sfx2_doc.mk | 45 +++
sfx2/Module_sfx2.mk |1
sfx2/qa/cppunit/doc.cxx | 81 +++
sfx2/source/doc/objserv.cxx |5 ++
4 files changed, 132 insertions(+)
New commits:
commit 430ab72c2cf785cd99e3275d9b76349aa9d5352c
Author: Miklos Vajna
AuthorDate: Wed Feb 10 21:05:29 2021 +0100
Commit: Caolán McNamara
CommitDate: Thu Feb 11 12:02:29 2021 +0100
tdf#140280 sfx2: fix crash on double-clicking a no-sign shape in read-only
mode
Don't assume that all shapes provide an InteropGrabBag UNO property,
check for it.
(cherry picked from commit c76e6307b6cf33bda0cfa12647ed0342aecc1b29)
Change-Id: I6347c54b0631c37154424babbfbd52f802af57d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110751
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sfx2/CppunitTest_sfx2_doc.mk b/sfx2/CppunitTest_sfx2_doc.mk
new file mode 100644
index ..02b06dfd1b14
--- /dev/null
+++ b/sfx2/CppunitTest_sfx2_doc.mk
@@ -0,0 +1,45 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#*
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+#*
+
+$(eval $(call gb_CppunitTest_CppunitTest,sfx2_doc))
+
+$(eval $(call gb_CppunitTest_use_externals,sfx2_doc,\
+ boost_headers \
+))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,sfx2_doc, \
+sfx2/qa/cppunit/doc \
+))
+
+$(eval $(call gb_CppunitTest_use_libraries,sfx2_doc, \
+comphelper \
+cppu \
+sal \
+test \
+unotest \
+sfx \
+svl \
+))
+
+$(eval $(call gb_CppunitTest_use_sdk_api,sfx2_doc))
+
+$(eval $(call gb_CppunitTest_use_ure,sfx2_doc))
+$(eval $(call gb_CppunitTest_use_vcl,sfx2_doc))
+
+$(eval $(call gb_CppunitTest_use_rdb,sfx2_doc,services))
+
+$(eval $(call gb_CppunitTest_use_custom_headers,sfx2_doc,\
+ officecfg/registry \
+))
+
+$(eval $(call gb_CppunitTest_use_configuration,sfx2_doc))
+
+# vim: set noet sw=4 ts=4:
diff --git a/sfx2/Module_sfx2.mk b/sfx2/Module_sfx2.mk
index d64b871c2a7f..dbab052e1a0d 100644
--- a/sfx2/Module_sfx2.mk
+++ b/sfx2/Module_sfx2.mk
@@ -37,6 +37,7 @@ $(eval $(call gb_Module_add_check_targets,sfx2,\
CppunitTest_sfx2_controlleritem \
CppunitTest_sfx2_classification \
CppunitTest_sfx2_view \
+CppunitTest_sfx2_doc \
))
$(eval $(call gb_Module_add_subsequentcheck_targets,sfx2,\
diff --git a/sfx2/qa/cppunit/doc.cxx b/sfx2/qa/cppunit/doc.cxx
new file mode 100644
index ..01e8fd7f2000
--- /dev/null
+++ b/sfx2/qa/cppunit/doc.cxx
@@ -0,0 +1,81 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include
+#include
+
+#include
+#include
+#include
+
+#include
+#include
+#include
+
+using namespace com::sun::star;
+
+namespace
+{
+/// Covers sfx2/source/doc/ fixes.
+class Test : public test::BootstrapFixture, public unotest::MacrosTest
+{
+private:
+uno::Reference mxComponent;
+
+public:
+void setUp() override;
+void tearDown() override;
+uno::Reference& getComponent() { return mxComponent; }
+};
+
+void Test::setUp()
+{
+test::BootstrapFixture::setUp();
+
+mxDesktop.set(frame::Desktop::create(mxComponentContext));
+}
+
+void Test::tearDown()
+{
+if (mxComponent.is())
+mxComponent->dispose();
+
+test::BootstrapFixture::tearDown();
+}
+
+CPPUNIT_TEST_FIXTURE(Test, testNoGrabBagShape)
+{
+// Load a document and select the first shape.
+css::uno::Sequence aArgs{
comphelper::makePropertyValue("ReadOnly",
+
true) };
+getComponent() = loadFromDesktop("private:factory/simpress", "", aArgs);
+uno::Reference xModel(getComponent(), uno::UNO_QUERY);
+uno::Reference xDrawPagesSupplier(xModel,
uno::UNO_QUERY);
+uno::Reference xDrawPage(
+xDrawPagesSupplier->getDrawPages()->getByIndex(0), uno::UNO_QUERY);
+uno::Any aShape = xDrawPage->getByIndex(0);
+uno::Reference
xController(xModel->getCurrentController(),
+ uno::UNO_QUERY);
+xController->select(aShape);
+
+// See if it has a signing certificate associated.
+auto pBaseModel = dynamic_cast(xModel.get());
+CPPUNIT_ASSERT(pBaseModel);
+SfxObjectShell* pObjectShell =
[Libreoffice-commits] core.git: svx/source
svx/source/svdraw/svdoedge.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit f3f1140dc9d5766e589b328f86d0dd3804315cf4
Author: Caolán McNamara
AuthorDate: Thu Feb 11 09:27:27 2021 +
Commit: Caolán McNamara
CommitDate: Thu Feb 11 12:01:53 2021 +0100
ofz#30805 Null-dereference READ
presumably since...
commit 09cb778b6eb7d3a5b9029965a1320b49c90e7295
Date: Tue Feb 9 13:42:22 2021 +0200
clean up SdrObject cloning
Change-Id: I5e87c6ac7b786d691d625e16c31b8916e0b7da76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110754
Reviewed-by: Noel Grandin
Reviewed-by: Caolán McNamara
Tested-by: Jenkins
diff --git a/svx/source/svdraw/svdoedge.cxx b/svx/source/svdraw/svdoedge.cxx
index 5231d0649b3f..47c012c7c36e 100644
--- a/svx/source/svdraw/svdoedge.cxx
+++ b/svx/source/svdraw/svdoedge.cxx
@@ -179,7 +179,7 @@ SdrEdgeObj::SdrEdgeObj(SdrModel& rSdrModel, SdrEdgeObj
const & rSource)
{
bClosedObj = false;
bIsEdge = true;
-*pEdgeTrack=*rSource.pEdgeTrack;
+pEdgeTrack.reset(new XPolygon(*rSource.pEdgeTrack));
bEdgeTrackDirty=rSource.bEdgeTrackDirty;
aCon1 =rSource.aCon1;
aCon2 =rSource.aCon2;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/cib_contract57d' - 2 commits - desktop/source
desktop/source/pkgchk/unopkg/unopkg_app.cxx | 21 ++---
desktop/source/pkgchk/unopkg/unopkg_misc.cxx |7 +++
desktop/source/pkgchk/unopkg/unopkg_shared.h |2 +-
3 files changed, 22 insertions(+), 8 deletions(-)
New commits:
commit defbbe30f320922bda444e5a311df8e69f8716d5
Author: Samuel Mehrbrodt
AuthorDate: Mon Jan 20 11:12:12 2020 +0100
Commit: Samuel Mehrbrodt
CommitDate: Wed Feb 10 15:37:06 2021 +0100
tdf#129917 Use temp user profile when installing shared extensions
Change-Id: I62dd163758e6348a62fc8a0b25150a62f282de90
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86543
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
(cherry picked from commit c51a43bd70aa9fec0a051e51622a6a91f5aaa1a9)
diff --git a/desktop/source/pkgchk/unopkg/unopkg_app.cxx
b/desktop/source/pkgchk/unopkg/unopkg_app.cxx
index 35d2bee6f5c5..6064d1976aa1 100644
--- a/desktop/source/pkgchk/unopkg/unopkg_app.cxx
+++ b/desktop/source/pkgchk/unopkg/unopkg_app.cxx
@@ -31,6 +31,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -204,6 +205,7 @@ extern "C" int unopkg_main()
Reference xFileHandler;
Reference xConsoleHandler;
std::unique_ptr logger;
+std::unique_ptr pUserProfileTempDir;
OptionInfo const * info_shared = getOptionInfo(
s_option_infos, "shared" );
@@ -298,8 +300,16 @@ extern "C" int unopkg_main()
}
}
-xComponentContext = getUNO(
-option_verbose, option_shared, subcmd_gui, xLocalComponentContext );
+// tdf#129917 Use temp user profile when installing shared extensions
+if (option_shared)
+{
+pUserProfileTempDir.reset(new utl::TempFile(nullptr, true));
+pUserProfileTempDir->EnableKillingFile();
+}
+
+xComponentContext = getUNO(option_verbose, subcmd_gui,
+ pUserProfileTempDir ?
pUserProfileTempDir->GetURL() : "",
+ xLocalComponentContext);
// Initialize logging. This will log errors to the console and
// also to file if the --log-file parameter was provided.
@@ -359,7 +369,6 @@ extern "C" int unopkg_main()
APP_NAME, toString(info_shared),
toString(info_bundled));
return 1;
}
-
}
#endif
diff --git a/desktop/source/pkgchk/unopkg/unopkg_misc.cxx
b/desktop/source/pkgchk/unopkg/unopkg_misc.cxx
index 6a11fdeae059..dcf77eb71602 100644
--- a/desktop/source/pkgchk/unopkg/unopkg_misc.cxx
+++ b/desktop/source/pkgchk/unopkg/unopkg_misc.cxx
@@ -416,13 +416,12 @@ static OUString getLockFilePath()
}
Reference getUNO(
-bool verbose, bool shared, bool bGui,
+bool verbose, bool bGui, const OUString& sTempDir,
Reference & out_localContext)
{
// do not create any user data (for the root user) in --shared mode:
-if (shared) {
-rtl::Bootstrap::set("CFG_CacheUrl", OUString());
-}
+if (!sTempDir.isEmpty())
+rtl::Bootstrap::set("UserInstallation", sTempDir);
// hold lock during process runtime:
static ::desktop::Lockfile s_lockfile( false /* no IPC server */ );
diff --git a/desktop/source/pkgchk/unopkg/unopkg_shared.h
b/desktop/source/pkgchk/unopkg/unopkg_shared.h
index 6d23b4c8f39e..68a46227314e 100644
--- a/desktop/source/pkgchk/unopkg/unopkg_shared.h
+++ b/desktop/source/pkgchk/unopkg/unopkg_shared.h
@@ -109,7 +109,7 @@ void printf_packages(
css::uno::Reference getUNO(
-bool verbose, bool shared, bool bGui,
+bool verbose, bool bGui, const OUString& sTempDir,
css::uno::Reference &
out_LocalComponentContext);
}
commit 777551b86a560cd8e45877cbb16075a940314866
Author: Stephan Bergmann
AuthorDate: Tue Jan 28 10:39:16 2020 +0100
Commit: Samuel Mehrbrodt
CommitDate: Wed Feb 10 15:32:19 2021 +0100
Dispose configmgr at the end of unopkg
...so that the configmgr::Components::WriteThread
(configmgr/source/components.cxx) is joined well before exit. (This should
solve the issue discussed at
, "tdf#129917 Use temp user profile
when
installing shared extensions".)
Change-Id: I79004c2e7f839d80eda23eed2a1c5e8e660a58df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87592
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
(cherry picked from commit 9f277b2616512299ec20de0209c272527f26386b)
diff --git a/desktop/source/pkgchk/unopkg/unopkg_app.cxx
b/desktop/source/pkgchk/unopkg/unopkg_app.cxx
index f6e4d0c19b7c..35d2bee6f5c5 100644
--- a/desktop/source/pkgchk/unopkg/unopkg_app.cxx
+++ b/desktop/source/pkgchk/unopkg/unopkg_app.cxx
@@ -590,6 +590,8 @@ extern "C" int unopkg_main()
logger->log(LogLevel::INFO, "$1$ done.", APP_NAME);
//Force to release all bridges which connect us to the child processes
[Libreoffice-bugs] [Bug 128233] macOS: Can't save or open files using Finder dialog on Standard accounts on macOS 10.15 Catalina
https://bugs.documentfoundation.org/show_bug.cgi?id=128233 --- Comment #43 from Uwe Altmann --- Investigation further (Catalina 10.15.7): renaming user folder and doing clean install of LO 6.4.7, adding german langPack, not having Full Disk Access. Starting from console as user, Create New document is OK, save works OK Opening existing Document works, but throws five times „(pkix_CacheCert_Add: PKIX_PL_HashTable_Add for Certs skipped: entry existed“. Later doing the same these messages do not repeat. Save this changed Document works. Doing clean install of LO 7.0.4, not having Full Disk Access everything described above works OK Doing clean install of LO 7.1.0, not having Full Disk Access Starting from console as user, Create New document is OK, save throws 2021-02-11 09:41:31.302 soffice[92346:1589178] +[NSXPCSharedListener endpointForReply:withListenerName:]: an error occurred while attempting to obtain endpoint for listener 'com.apple.view-bridge': Connection interrupted 2021-02-11 09:41:41.401 soffice[92346:1589522] +[NSXPCSharedListener endpointForReply:withListenerName:]: an error occurred while attempting to obtain endpoint for listener 'com.apple.view-bridge': Connection interrupted 2021-02-11 09:41:51.538 soffice[92346:1589629] +[NSXPCSharedListener endpointForReply:withListenerName:]: an error occurred while attempting to obtain endpoint for listener 'com.apple.view-bridge': Connection interrupted Open and save of a recently opened document from StartCenter works. "File open" throws 2021-02-11 09:44:05.786 soffice[92346:1590496] +[NSXPCSharedListener endpointForReply:withListenerName:]: an error occurred while attempting to obtain endpoint for listener 'com.apple.view-bridge': Connection interrupted 2021-02-11 09:44:15.944 soffice[92346:1590488] +[NSXPCSharedListener endpointForReply:withListenerName:]: an error occurred while attempting to obtain endpoint for listener 'com.apple.view-bridge': Connection interrupted 2021-02-11 09:44:26.033 soffice[92346:1590674] +[NSXPCSharedListener endpointForReply:withListenerName:]: an error occurred while attempting to obtain endpoint for listener 'com.apple.view-bridge': Connection interrupted Starting from console as sudo, Create New document is OK, save is OK Open and save of a recently opened document from StartCenter works. "File open" Opening existing Document works, save this changed Document works also. Using LO 7.0.4 as user not having Full Disk Access After having installed "Language toll" Extension, opening a document still works but throws SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". SLF4J: Defaulting to no-operation (NOP) logger implementation SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129033] Navigator's vertical scroll-bar is no longer exhibited under a condition
https://bugs.documentfoundation.org/show_bug.cgi?id=129033 Xisco Faulí changed: What|Removed |Added Keywords|dataLoss| URL|https://www.theleathermaker | |s.com/8-ball-jacket/| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140274] Incorrect size of form navigator window
https://bugs.documentfoundation.org/show_bug.cgi?id=140274 Caolán McNamara changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140332] FIREBIRD - LibreOffice Vanilla fails to load tables or reports from an embedded Firebird ODB file
https://bugs.documentfoundation.org/show_bug.cgi?id=140332 Alex Thurgood changed: What|Removed |Added Version|7.1.0.1 rc |7.0.4.2 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129033] Navigator's vertical scroll-bar is no longer exhibited under a condition
https://bugs.documentfoundation.org/show_bug.cgi?id=129033 Anna Moore changed: What|Removed |Added Keywords||dataLoss URL||https://www.theleathermaker ||s.com/8-ball-jacket/ --- Comment #19 from Anna Moore --- We are the best American leather jackets manufacturer and supplier having a range from lightweight leather outfit to best quality. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140332] FIREBIRD - LibreOffice Vanilla fails to load tables or reports from an embedded Firebird ODB file
https://bugs.documentfoundation.org/show_bug.cgi?id=140332 Alex Thurgood changed: What|Removed |Added Priority|medium |highest Severity|normal |critical -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140332] New: FIREBIRD - LibreOffice Vanilla fails to load tables or reports from an embedded Firebird ODB file
https://bugs.documentfoundation.org/show_bug.cgi?id=140332 Bug ID: 140332 Summary: FIREBIRD - LibreOffice Vanilla fails to load tables or reports from an embedded Firebird ODB file Product: LibreOffice Version: 7.1.0.1 rc Hardware: ARM OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ipla...@tuta.io Description: 1) Attempting to reproduce bug 140285 2) Downloaded test ODB file provided by original reporter 3) Activated macros on loading ODB file 4) Noticed error message "Error #1 (An exception occurred : ) at line 1302 in OpenConnection" - clicked on OK to make error message go away 5) Tried to display a table, or load any report, generates an error message : firebird_sdbc error: *lock manager error *failed to create database /Users/alex/Library/Containers/com.collabora.libreoffice-free/Data/Library/Application Support/LibreOfficeVanilla/4/user/temp/lu17362qz8l.tmp/lu17362qz8u.tmp/firebird.fdb *Exiting before completion due to errors caused by 'isc_service_query' Steps to Reproduce: See above Actual Results: Data fails to load in any selected table, no reports can be run. Expected Results: Table data should be loaded and displayed. Reports should be loaded and displayed. Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.0.4.4 Build ID: 841d27ff4cd6850c43bdd7333f8373cae686520d CPU threads: 8; OS: Mac OS X 11.2; UI render: default; VCL: osx Locale: fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140285] Reportbuilder - impossible to edit report, causes Libreoffice to crash
https://bugs.documentfoundation.org/show_bug.cgi?id=140285 --- Comment #4 from Alex Thurgood --- Tested with: Version: 7.1.0.1 Build ID: b585d7d90ab863bf29b2d110c174c0c2a98f3ee4 CPU threads: 8; OS: Mac OS X 10.16; UI render: default; VCL: osx Locale: fr-FR (fr_FR.UTF-8); UI: en-US Calc: threaded 1) Open ODB file. 2) Open Report named R3xSALARIOSxIRPF 3) No crash. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137779] Add info about Jumbo sheets status into About dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=137779 Dipanshu Garg changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |dipan...@iitk.ac.in |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51138] Editing a FONTWORK is difficult
https://bugs.documentfoundation.org/show_bug.cgi?id=51138 Heiko Tietze changed: What|Removed |Added Priority|low |medium --- Comment #16 from Heiko Tietze --- The issue is that when editing fontwork it keeps the design in the background which is odd for the readability of text. What comes in mind is: a) hide the fontwork design b) grey-out/watermark the design c) temporarily revert stretching and rotation effects (similar to d) edit the content in a separate dialog -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 51138] Editing a FONTWORK is difficult
https://bugs.documentfoundation.org/show_bug.cgi?id=51138 Heiko Tietze changed: What|Removed |Added Priority|low |medium --- Comment #16 from Heiko Tietze --- The issue is that when editing fontwork it keeps the design in the background which is odd for the readability of text. What comes in mind is: a) hide the fontwork design b) grey-out/watermark the design c) temporarily revert stretching and rotation effects (similar to d) edit the content in a separate dialog -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 140285] Reportbuilder - impossible to edit report, causes Libreoffice to crash
https://bugs.documentfoundation.org/show_bug.cgi?id=140285 --- Comment #3 from Alex Thurgood --- Trying to test with LO Vanilla from Collabora as provided via the Apple AppStore leads to the following error message : firebird_sdbc error: *lock manager error *failed to create database /Users/alex/Library/Containers/com.collabora.libreoffice-free/Data/Library/Application Support/LibreOfficeVanilla/4/user/temp/lu17362qz8l.tmp/lu17362qz8u.tmp/firebird.fdb *Exiting before completion due to errors caused by 'isc_service_query' -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140285] Reportbuilder - impossible to edit report, causes Libreoffice to crash
https://bugs.documentfoundation.org/show_bug.cgi?id=140285 Alex Thurgood changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #2 from Alex Thurgood --- @jorojmaqui : I am testing on : Version: 7.0.4.4 Build ID: 841d27ff4cd6850c43bdd7333f8373cae686520d CPU threads: 8; OS: Mac OS X 11.2; UI render: default; VCL: osx Locale: fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR Calc: threaded I notice that the test file contains macros. If I activate the macros on loading the ODB, I get an error message : Error #1 (An exception occurred : ) at line 1302 in OpenConnection Is it possible to test the problem of editing a report without having activated the macro environment ? Please provide detailed steps for testing, for example, which report are we supposed to be opening / editing ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140293] first start under windows to startcenter fails
https://bugs.documentfoundation.org/show_bug.cgi?id=140293 Luboš Luňák changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140285] Reportbuilder - impossible to edit report, causes Libreoffice to crash
https://bugs.documentfoundation.org/show_bug.cgi?id=140285 Alex Thurgood changed: What|Removed |Added Summary|Reportbuilder impossible|Reportbuilder - impossible |edit, libreoffice closes |to edit report, causes |me |Libreoffice to crash -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139913] Calc selects multiple cells on click instead of just one
https://bugs.documentfoundation.org/show_bug.cgi?id=139913 Michael Weghorn changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #20 from Michael Weghorn --- Nice findings! Can you try whether it's still reproducible if you reduce the screen resolution for all 4 screen? (In reply to Michael Weghorn from comment #14) > (Side note: One idea to try to reproduce this without having the actual > hardware might be to try setting up a VM with corresponding virtual screens, > not sure whether that will work properly.) I just tried that and can set up multiple screens or can even set up a single virtual HiDPI screen using libvirt/virt-manager and spice-vdagent (but need to disable/remove kscreen which somehow gets in the way), but I'm unable to set up several virtual HiDPI screens at the same time. xrandr fails setting the corresponding resolution, might be memory-related or something different (and screen just turns black if I further increase memory for the virtual graphics card). I couldn't quickly reproduce the issue with 4 virtual screens with a 1024x768 resolution, but the approach might be worth trying again in case you say it even works with a minimum resolution of XxY on all 4 screens... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140293] first start under windows to startcenter fails
https://bugs.documentfoundation.org/show_bug.cgi?id=140293 Commit Notification changed: What|Removed |Added Whiteboard||target:7.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140331] Program in the use of the process is a crash
https://bugs.documentfoundation.org/show_bug.cgi?id=140331 Xisco Faulí changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org --- Comment #1 from Xisco Faulí --- Thank you for reporting the bug. Please attach a sample document, as this makes it easier for us to verify the bug. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided. (Please note that the attachment will be public, remove any sensitive information before attaching it. See https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F for help on how to do so.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 51138] Editing a FONTWORK is difficult
https://bugs.documentfoundation.org/show_bug.cgi?id=51138 Heiko Tietze changed: What|Removed |Added Attachment #63096|0 |1 is obsolete|| -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 51138] Editing a FONTWORK is difficult
https://bugs.documentfoundation.org/show_bug.cgi?id=51138 Heiko Tietze changed: What|Removed |Added Attachment #63096|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51138] Editing a FONTWORK is difficult
https://bugs.documentfoundation.org/show_bug.cgi?id=51138 Heiko Tietze changed: What|Removed |Added Attachment #68834|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140293] first start under windows to startcenter fails
https://bugs.documentfoundation.org/show_bug.cgi?id=140293 --- Comment #3 from Commit Notification --- Luboš Luňák committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/843af72bcc9047867588e29c8e10b84a5e58d70e make win32 variant AnyInput() not deliver events (tdf#140293) It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 51138] Editing a FONTWORK is difficult
https://bugs.documentfoundation.org/show_bug.cgi?id=51138 Heiko Tietze changed: What|Removed |Added Attachment #68834|0 |1 is obsolete|| -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: vcl/win
vcl/win/app/salinst.cxx | 185
1 file changed, 18 insertions(+), 167 deletions(-)
New commits:
commit 843af72bcc9047867588e29c8e10b84a5e58d70e
Author: Luboš Luňák
AuthorDate: Wed Feb 10 16:37:17 2021 +
Commit: Luboš Luňák
CommitDate: Thu Feb 11 11:07:11 2021 +0100
make win32 variant AnyInput() not deliver events (tdf#140293)
Win32 API PeekMessage() actually may deliver events, despite
what the name may suggest, even with PM_NOREMOVE argument.
That means this is problematic for use in AnyInput(), as that
function should just check the event queue but not do anything
with it. Using GetQueueStatus() should solve the problem.
See
https://lists.freedesktop.org/archives/libreoffice/2021-February/086788.html
for further details.
Change-Id: I10d3423f89f6f050534625110113dee60959f7a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110718
Reviewed-by: Jan-Marek Glogowski
Reviewed-by: Luboš Luňák
Tested-by: Jenkins
diff --git a/vcl/win/app/salinst.cxx b/vcl/win/app/salinst.cxx
index ea4c9420beb0..18605f2f17d4 100644
--- a/vcl/win/app/salinst.cxx
+++ b/vcl/win/app/salinst.cxx
@@ -665,116 +665,8 @@ LRESULT CALLBACK SalComWndProcW( HWND hWnd, UINT nMsg,
WPARAM wParam, LPARAM lPa
return nRet;
}
-namespace {
-
-struct MsgRange
-{
-UINT nStart;
-UINT nEnd;
-};
-
-}
-
-static std::vector GetOtherRanges( VclInputFlags nType )
-{
-assert( nType != VCL_INPUT_ANY );
-
-// this array must be kept sorted!
-const UINT nExcludeMsgIds[] =
-{
-0,
-
-WM_MOVE, // 3
-WM_SIZE, // 5
-WM_PAINT, // 15
-WM_KEYDOWN, // 256
-WM_TIMER, // 275
-
-WM_MOUSEFIRST, // 512
-513,
-514,
-515,
-516,
-517,
-518,
-519,
-520,
-WM_MOUSELAST, // 521
-
-SAL_MSG_POSTMOVE, // WM_USER+136
-SAL_MSG_POSTCALLSIZE, // WM_USER+137
-
-SAL_MSG_TIMER_CALLBACK, // WM_USER+162
-
-UINT_MAX
-};
-const unsigned MAX_EXCL = SAL_N_ELEMENTS( nExcludeMsgIds );
-
-bool aExcludeMsgList[ MAX_EXCL ] = { false, };
-std::vector aResult;
-
-// set the excluded values
-if ( !(nType & VclInputFlags::MOUSE) )
-{
-for ( unsigned i = 0; nExcludeMsgIds[ 6 + i ] <= WM_MOUSELAST; ++i )
-aExcludeMsgList[ 6 + i ] = true;
-}
-
-if ( !(nType & VclInputFlags::KEYBOARD) )
-aExcludeMsgList[ 4 ] = true;
-
-if ( !(nType & VclInputFlags::PAINT) )
-{
-aExcludeMsgList[ 1 ] = true;
-aExcludeMsgList[ 2 ] = true;
-aExcludeMsgList[ 3 ] = true;
-aExcludeMsgList[ 16 ] = true;
-aExcludeMsgList[ 17 ] = true;
-}
-
-if ( !(nType & VclInputFlags::TIMER) )
-{
-aExcludeMsgList[ 5 ] = true;
-aExcludeMsgList[ 18 ] = true;
-}
-
-// build the message ranges to check
-MsgRange aRange = { 0, 0 };
-bool doEnd = true;
-for ( unsigned i = 1; i < MAX_EXCL; ++i )
-{
-if ( aExcludeMsgList[ i ] )
-{
-if ( !doEnd )
-{
-if ( nExcludeMsgIds[ i ] == aRange.nStart )
-++aRange.nStart;
-else
-doEnd = true;
-}
-if ( doEnd )
-{
-aRange.nEnd = nExcludeMsgIds[ i ] - 1;
-aResult.push_back( aRange );
-doEnd = false;
-aRange.nStart = aRange.nEnd + 2;
-}
-}
-}
-
-if ( aRange.nStart != UINT_MAX )
-{
-aRange.nEnd = UINT_MAX;
-aResult.push_back( aRange );
-}
-
-return aResult;
-}
-
bool WinSalInstance::AnyInput( VclInputFlags nType )
{
-MSG aMsg;
-
if ( nType & VclInputFlags::TIMER )
{
const WinSalTimer* pTimer = static_cast(
ImplGetSVData()->maSchedCtx.mpSalTimer );
@@ -782,81 +674,40 @@ bool WinSalInstance::AnyInput( VclInputFlags nType )
return true;
}
+// Note: Do not use PeekMessage(), despite the name it may dispatch events,
+// even with PM_NOREMOVE specified, which may lead to unwanted recursion.
+
if ( (nType & VCL_INPUT_ANY) == VCL_INPUT_ANY )
{
// revert bugfix for #108919# which never reported timeouts when
called from the timer handler
// which made the application completely unresponsive during
background formatting
-if ( PeekMessageW( , nullptr, 0, 0, PM_NOREMOVE | PM_NOYIELD ) )
+if ( GetQueueStatus( QS_ALLEVENTS ))
return true;
}
else
{
-const bool bCheck_KEYBOARD (nType & VclInputFlags::KEYBOARD);
-const bool bCheck_OTHER(nType & VclInputFlags::OTHER);
-
-// If there is a modifier key event, it counts as OTHER
-// Previously we were simply ignoring these events...
-if ( bCheck_KEYBOARD || bCheck_OTHER )
-
[Libreoffice-bugs] [Bug 140331] New: Program in the use of the process is a crash
https://bugs.documentfoundation.org/show_bug.cgi?id=140331 Bug ID: 140331 Summary: Program in the use of the process is a crash Product: LibreOffice Version: 7.1.0.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cheng...@outlook.com Description: Program in the use of the process is a crash, open the DB file after the crash will continue to restart the program, can only be opened in safe mode by ending multiple libreoffice process, restore the most recent correct configuration use, in the process of use will still repeat the problem, the program still needs to be improved. Steps to Reproduce: 1.Enter the interface via the libreoffice 7.1 version and the clicker will exit 2.Enter the interface with the libreoffice 7.1 version, click on the database to import excel type files, double-click to open the file will appear from time to time crash 3.Rows cannot be inserted into the design format in the database form, or the export file cannot be in the normal excel format, resulting Chinese of the same class Actual Results: The program crashes, Chinese data is pasted into the excel table for garbled code Expected Results: The program crashes, Chinese data is pasted into the excel table for garbled code Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: No other information is automatically uploaded when the file report crashes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76264] FILESAVE option to append version incrementation to filename
https://bugs.documentfoundation.org/show_bug.cgi?id=76264 Heiko Tietze changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=88 ||994 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Keywords|needsUXEval | --- Comment #5 from Heiko Tietze --- I'm with Owen here. Such a feature would never be a viable replacement of CMS. We should rather improve the versioning option and introduce an option "Do not reset version" in the Save dialog. See also bug 88994. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88994] Auto enable versioning on new odf files
https://bugs.documentfoundation.org/show_bug.cgi?id=88994 Heiko Tietze changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=76 ||264 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 76264] FILESAVE option to append version incrementation to filename
https://bugs.documentfoundation.org/show_bug.cgi?id=76264 Heiko Tietze changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=88 ||994 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Keywords|needsUXEval | --- Comment #5 from Heiko Tietze --- I'm with Owen here. Such a feature would never be a viable replacement of CMS. We should rather improve the versioning option and introduce an option "Do not reset version" in the Save dialog. See also bug 88994. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 87338] RTL justification in cross-reference list window
https://bugs.documentfoundation.org/show_bug.cgi?id=87338 --- Comment #11 from Safeer Pasha --- still happens Version: 7.1.0.3 / LibreOffice Community Build ID: 10(Build:3) CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: kf5 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88803] Introduce Web View mode to make text reflow on zoom
https://bugs.documentfoundation.org/show_bug.cgi?id=88803 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org, ||ke...@collabora.com Summary|Document Text Doesn't |Introduce Web View mode to |Reflow on Zoom |make text reflow on zoom Priority|lowest |medium Keywords|needsUXEval | --- Comment #9 from Heiko Tietze --- (In reply to blendergeek from comment #7) > In LibreOffice Desktop there is something called "Web" view. It is intended > for documents that are actually websites. Could we adapt or simply use this > view to allow users to have something like this? Sounds like a good idea to me. @Kendy: Do you know who is working on Android? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 88803] Introduce Web View mode to make text reflow on zoom
https://bugs.documentfoundation.org/show_bug.cgi?id=88803 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org, ||ke...@collabora.com Summary|Document Text Doesn't |Introduce Web View mode to |Reflow on Zoom |make text reflow on zoom Priority|lowest |medium Keywords|needsUXEval | --- Comment #9 from Heiko Tietze --- (In reply to blendergeek from comment #7) > In LibreOffice Desktop there is something called "Web" view. It is intended > for documents that are actually websites. Could we adapt or simply use this > view to allow users to have something like this? Sounds like a good idea to me. @Kendy: Do you know who is working on Android? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 133112] Cell formatting (color) of some cells change after Undo (conditional formatting)
https://bugs.documentfoundation.org/show_bug.cgi?id=133112 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org Priority|medium |high --- Comment #5 from Xisco Faulí --- Still reproducible in Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: 066799b4a162aa0a4bc6aa28339f1f943a13971e CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140330] Conditional formatting breaks after redoing cell deletion
https://bugs.documentfoundation.org/show_bug.cgi?id=140330 Xisco Faulí changed: What|Removed |Added CC||er...@redhat.com --- Comment #2 from Xisco Faulí --- @Eike, I thought you might be interested in this issue -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87351] [META] Conditional formatting bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=87351 Xisco Faulí changed: What|Removed |Added Depends on||140330 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140330 [Bug 140330] Conditional formatting breaks after redoing cell deletion -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140330] Conditional formatting breaks after redoing cell deletion
https://bugs.documentfoundation.org/show_bug.cgi?id=140330 Xisco Faulí changed: What|Removed |Added Blocks||87351 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=87351 [Bug 87351] [META] Conditional formatting bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
